Revert "Make hit point counts reliable for architectures that stop before evaluation."This reverts commit 5778ada8e54edb2bc2869505b88a959d1915c02f.The watchpoint tests all stall on aarch64-ubuntu
Revert "Make hit point counts reliable for architectures that stop before evaluation."This reverts commit 5778ada8e54edb2bc2869505b88a959d1915c02f.The watchpoint tests all stall on aarch64-ubuntu bots. Reverting till I canget my hands on an system to test this out.
show more ...
Make hit point counts reliable for architectures that stop before evaluation.Since we want to present the "new & old" values for watchpoint hits, on architectures,including the ARM family, that st
Make hit point counts reliable for architectures that stop before evaluation.Since we want to present the "new & old" values for watchpoint hits, on architectures,including the ARM family, that stop before the triggering instruction is run, we needto single step over the instruction before stopping for realz. This was incorrectlydone directly in the StopInfoWatchpoint::ShouldStop. That causes problems if more thanone thread stops "for a reason" at the same time as the watchpoint, since the other actionsdidn't expect the process to make progress in this part of the execution control machinery.The correct way to do this is to schedule the step over using ThreadPlans, and then to restorethe stop info after that plan stops, so that the rest of the stop info actions can happen whenall the other threads have handled their immediate actions as well.Differential Revision: https://reviews.llvm.org/D129814
[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://r
[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://reviews.llvm.org/D128077
[lldb] Remove support for replaying the test suite from a reproducerThis patch removes the infrastructure to replay the test suite from areproducer, as well as the modifications made to the indivi
[lldb] Remove support for replaying the test suite from a reproducerThis patch removes the infrastructure to replay the test suite from areproducer, as well as the modifications made to the individual tests.
[lldb] [Process/FreeBSDRemote] Enable watchpoint supportReplace the inline x86 watchpoint handling code with the reusableNativeRegisterContextWatchpoint_x86. Implement watchpoint supportin Nativ
[lldb] [Process/FreeBSDRemote] Enable watchpoint supportReplace the inline x86 watchpoint handling code with the reusableNativeRegisterContextWatchpoint_x86. Implement watchpoint supportin NativeThreadFreeBSD and SIGTRAP handling for watchpoints.Un-skip all concurrent_events tests as they pass with the new plugin.Differential Revision: https://reviews.llvm.org/D90102
[lldb/Test] Modify more tests for API replaySkip tests or parts thereof that aren't expected to work when run from areproducer. Also improve the doc comments in configuration.py to preventmistake
[lldb/Test] Modify more tests for API replaySkip tests or parts thereof that aren't expected to work when run from areproducer. Also improve the doc comments in configuration.py to preventmistakes in the future.
[lldb] Remove license headers from all test source filesSummary:Around a third of our test sources have LLVM license headers. This patch removes those headers from all testsources and also fixes
[lldb] Remove license headers from all test source filesSummary:Around a third of our test sources have LLVM license headers. This patch removes those headers from all testsources and also fixes any tests that depended on the length of the license header.The reasons for this are:* A few tests verify line numbers and will start failing if the number of lines in the LLVM license header changes. Once I landed my patch for valid SourceLocations in debug info we will probably have even more tests that verify line numbers.* No other LLVM project is putting license headers in its test files to my knowledge.* They make the test sources much more verbose than they have to be. Several tests have longer license headers than the actual test source.For the record, the following tests had their line numbers changed to pass with the removal of the license header: lldb-api :: functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py lldb-shell :: Reproducer/TestGDBRemoteRepro.test lldb-shell :: Reproducer/TestMultipleTargets.test lldb-shell :: Reproducer/TestReuseDirectory.test lldb-shell :: ExecControl/StopHook/stop-hook-threads.test lldb-shell :: ExecControl/StopHook/stop-hook.test lldb-api :: lang/objc/exceptions/TestObjCExceptions.pyReviewers: #lldb, espindola, JDevlieghereReviewed By: #lldb, JDevlieghereSubscribers: emaste, aprantl, arphaman, JDevlieghere, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D74839
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdi
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdir -p lldb/test/API/{test_runner/test,tools/lldb-{server,vscode}}mv lldb/packages/Python/lldbsuite/test/test_runner/test lldb/test/API/test_runnerfor d in $(find lldb/packages/Python/lldbsuite/test/* -maxdepth 0 -type d | egrep -v "make|plugins|test_runner|tools"); do mv $d lldb/test/API; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-vscode -maxdepth 1 -mindepth 1 | grep -v ".py"); do mv $d lldb/test/API/tools/lldb-vscode; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-server -maxdepth 1 -mindepth 1 | egrep -v "gdbremote_testcase.py|lldbgdbserverutils.py|socket_packet_pump.py"); do mv $d lldb/test/API/tools/lldb-server; done```lldb/packages/Python/lldbsuite/__init__.py and lldb/test/API/lit.cfg.py were also updated with the new directory structure.Reviewers: labath, JDevlieghereTags: #lldbDifferential Revision: https://reviews.llvm.org/D71151