[libc++] Fix tests after aee49255074f
Recommit: Compress formatting of array type names (int [4] -> int[4])Based on post-commit review discussion on2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith.Other uses of forcing Ha
Recommit: Compress formatting of array type names (int [4] -> int[4])Based on post-commit review discussion on2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith.Other uses of forcing HasEmptyPlaceHolder to false seem OK to me -they're all around pointer/reference types where the pointer/referencetoken will appear at the rightmost side of the left side of the typename, so they make nested types (eg: the "int" in "int *") behave asthough there is a non-empty placeholder (because the "*" is essentiallythe placeholder as far as the "int" is concerned).This was originally committed in 277623f4d5a672d707390e2c3eaf30a9eb4b075cReverted in f9ad1d1c775a8e264bebc15d75e0c6e5c20eefc7 due to breakagesoutside of clang - lldb seems to have some strange/strong dependence on"char [N]" versus "char[N]" when printing strings (not due to that nameappearing in DWARF, but probably due to using clang to stringify typenames) that'll need to be addressed, plus a few other odds and ends inother subprojects (clang-tools-extra, compiler-rt, etc).
show more ...
Add include for 'test_macros.h' to all the tests that were missing them. Thanks to Zoe for the (big, but simple) patch. NFC intended.llvm-svn: 362252
Support tests in freestandingSummary:Freestanding is *weird*. The standard allows it to differ in a bunch of oddmanners from regular C++, and the committee would like to improve thatsituation. I
Support tests in freestandingSummary:Freestanding is *weird*. The standard allows it to differ in a bunch of oddmanners from regular C++, and the committee would like to improve thatsituation. I'd like to make libc++ behave better with what freestanding shouldbe, so that it can be a tool we use in improving the standard. To do that weneed to try stuff out, both with "freestanding the language mode" and"freestanding the library subset".Let's start with the super basic: run the libc++ tests in freestanding, usingclang as the compiler, and see what works. The easiest hack to do this:In utils/libcxx/test/config.py add: self.cxx.compile_flags += ['-ffreestanding']Run the tests and they all fail.Why? Because in freestanding `main` isn't special. This "not special" propertyhas two effects: main doesn't get mangled, and main isn't allowed to omit its`return` statement. The first means main gets mangled and the linker can'tcreate a valid executable for us to test. The second means we spew out warnings(ew) and the compiler doesn't insert the `return` we omitted, and main justfalls of the end and does whatever undefined behavior (if you're luck, ud2leading to non-zero return code).Let's start my work with the basics. This patch changes all libc++ tests todeclare `main` as `int main(int, char**` so it mangles consistently (enabling usto declare another `extern "C"` main for freestanding which calls the mangledone), and adds `return 0;` to all places where it was missing. This touches 6124files, and I apologize.The former was done with The Magic Of Sed.The later was done with a (not quite correct but decent) clang tool: https://gist.github.com/jfbastien/793819ff360baa845483dde81170feedThis works for most tests, though I did have to adjust a few places when e.g.the test runs with `-x c`, macros are used for main (such as for the filesystemtests), etc.Once this is in we can create a freestanding bot which will prevent furtherregressions. After that, we can start the real work of supporting C++freestanding fairly well in libc++.<rdar://problem/47754795>Reviewers: ldionne, mclow.lists, EricWFSubscribers: christof, jkorous, dexonsmith, arphaman, miyuki, libcxx-commitsDifferential Revision: https://reviews.llvm.org/D57624llvm-svn: 353086
Update more file headers across all of the LLVM projects in the monorepoto reflect the new license. These used slightly different spellings thatdefeated my regular expressions.We understand that
Update more file headers across all of the LLVM projects in the monorepoto reflect the new license. These used slightly different spellings thatdefeated my regular expressions.We understand that people may be surprised that we're moving the headerentirely to discuss the new license. We checked this carefully with theFoundation's lawyer and we believe this is the correct approach.Essentially, all code in the project is now made available by the LLVMproject under our new license, so you will see that the license headersinclude that license only. Some of our contributors have contributedcode under our old license, and accordingly, we have retained a copy ofour old license notice in the top-level files in each project andrepository.llvm-svn: 351648
Change (void) casts to TEST_IGNORE_NODISCARD, as requested by Eric. Reviewed as https://reviews.llvm.org/D40065llvm-svn: 318804
Rewrite and cleanup unique_ptr tests.This patch almost entirely rewrites the unique_ptr tests. There are a coupleof reasons for this:A) Most of the *.fail.cpp tests were either incorrect or coul
Rewrite and cleanup unique_ptr tests.This patch almost entirely rewrites the unique_ptr tests. There are a coupleof reasons for this:A) Most of the *.fail.cpp tests were either incorrect or could be better written as a *.pass.cpp test that uses <type_traits> to check if certain operations are valid (Ex. Using static_assert(!std::is_copy_constructible_v<T>) instead of writing a failure test).B) [unique.ptr.runtime] has very poor test coverage. Many of the constructors and assignment operators have to tests at all. The special members that have tests have very few test cases and are typically way out of date.C) The tests for [unique.ptr.single] and [unique.ptr.runtime] are largely duplicates of each other. This means common requirements have two different sets of tests in two different test files. This makes the tests harder to maintain than if there was a single copy.To address (A) this patch changes almost all of the *.fail.cpp tests into.pass.cpp tests using type traits; Allowing the *.fail.cpp tests to be removed.The address (B) and (C) the tests for [unique.ptr.single] and [unique.ptr.runtime]have been combined into a single directory, allowing both specializations to sharecommon tests. Tests specific to the single/runtime specializations are given thesuffix "*.single.pass.cpp" or "*.runtime.pass.cpp".Finally the unique.ptr test have been moved into the correct directory accordingto the standard. Specifically they have been removed from "utilities/memory" into"utilities/smartptr".PS. This patch also adds newly written tests for upcoming unique_ptr changes/fixes.However since these tests don't currently pass they are guarded by the macroTEST_WORKAROUND_UPCOMING_UNIQUE_PTR_CHANGES. This allows other STL's to validatethe tests before libc++ implements the changes. The relevant libc++ changes shouldland in the next week.llvm-svn: 300388