[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://r
[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://reviews.llvm.org/D128077
show more ...
[lldb] Skip a bunch of tests that shouldn't run remotelySkip a bunch of tests that don't really make sense to run remotely.
[lldb] Replace asserts on .Success() with assertSuccess()Replace forms of `assertTrue(err.Success())` with `assertSuccess(err)` (added in D82759).* `assertSuccess` prints out the error's message
[lldb] Replace asserts on .Success() with assertSuccess()Replace forms of `assertTrue(err.Success())` with `assertSuccess(err)` (added in D82759).* `assertSuccess` prints out the error's message* `assertSuccess` expresses explicit higher level semantics, both to the reader and for test failure output* `assertSuccess` seems not to be well known, using it where possible will help spread knowledge* `assertSuccess` statements are more succinctDifferential Revision: https://reviews.llvm.org/D119616
[lldb] Don't print "Command Options Usage:" for an alias with no options"shell" is an alias to "platform shell -h --". Previously you would get thishelp text:(lldb) help shellRun a shell comman
[lldb] Don't print "Command Options Usage:" for an alias with no options"shell" is an alias to "platform shell -h --". Previously you would get thishelp text:(lldb) help shellRun a shell command on the host. Expects 'raw' input (see 'help raw-input'.)Syntax: shell <shell-command>Command Options Usage:'shell' is an abbreviation for 'platform shell -h --'Since the code doesn't handle the base command having optionsbut the alias removing them. With these changes you get:(lldb) help shellRun a shell command on the host. Expects 'raw' input (see 'help raw-input'.)Syntax: shell <shell-command>'shell' is an abbreviation for 'platform shell -h --'Note that we already handle a non-alias command having no options,for example "quit":(lldb) help quitQuit the LLDB debugger.Syntax: quit [exit-code]Reviewed By: JDevlieghere, jinghamDifferential Revision: https://reviews.llvm.org/D117004
[lldb/test] Fix TestPlatform*.py Windows failures (NFC)This patch fixes the windows failures introduced by `addb514`:http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/18671/steps/tes
[lldb/test] Fix TestPlatform*.py Windows failures (NFC)This patch fixes the windows failures introduced by `addb514`:http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/18671/steps/test/logs/stdioThis macro, used in the test to check the platform, was missing a `_`,making the test behave like it was run from a UNIX platform.Signed-off-by: Med Ismail Bennani <[email protected]>
[lldb/Target] Add custom interpreter option to `platform shell`This patch adds the ability to use a custom interpreter with the`platform shell` command. If the user set the `-s|--shell` optionwit
[lldb/Target] Add custom interpreter option to `platform shell`This patch adds the ability to use a custom interpreter with the`platform shell` command. If the user set the `-s|--shell` optionwith the path to a binary, lldb passes it down to the platform's`RunShellProcess` method and set it as the shell to use in`ProcessLaunchInfo to run commands.Note that not all the Platforms support running shell commands withcustom interpreters (i.e. RemoteGDBServer is only expected to use thedefault shell).This patch also makes some refactoring and cleanups, like swappingCString for StringRef when possible and updating `SBPlatformShellCommand`with new methods and a new constructor.rdar://67759256Differential Revision: https://reviews.llvm.org/D86667Signed-off-by: Med Ismail Bennani <[email protected]>
[lldb/Commands] Add ability to run shell command on the host.This patch introduces the `(-h|--host)` option to the `platform shell`command. It allows the user to run shell commands from the host p
[lldb/Commands] Add ability to run shell command on the host.This patch introduces the `(-h|--host)` option to the `platform shell`command. It allows the user to run shell commands from the host platform(always available) without putting lldb in the background.Since the default behaviour of `platform shell` is to run the command ofthe selected platform, having such a choice can be quite handy whendebugging remote targets, for instances.This patch also introduces a `shell` alias, to improve the commanddiscoverability and make it more convenient to use for the user.rdar://62856024Differential Revision: https://reviews.llvm.org/D79659Signed-off-by: Med Ismail Bennani <[email protected]>
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdi
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdir -p lldb/test/API/{test_runner/test,tools/lldb-{server,vscode}}mv lldb/packages/Python/lldbsuite/test/test_runner/test lldb/test/API/test_runnerfor d in $(find lldb/packages/Python/lldbsuite/test/* -maxdepth 0 -type d | egrep -v "make|plugins|test_runner|tools"); do mv $d lldb/test/API; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-vscode -maxdepth 1 -mindepth 1 | grep -v ".py"); do mv $d lldb/test/API/tools/lldb-vscode; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-server -maxdepth 1 -mindepth 1 | egrep -v "gdbremote_testcase.py|lldbgdbserverutils.py|socket_packet_pump.py"); do mv $d lldb/test/API/tools/lldb-server; done```lldb/packages/Python/lldbsuite/__init__.py and lldb/test/API/lit.cfg.py were also updated with the new directory structure.Reviewers: labath, JDevlieghereTags: #lldbDifferential Revision: https://reviews.llvm.org/D71151