1 //===--- LeftRightQualifierAlignmentFixer.cpp -------------------*- C++--*-===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 /// 9 /// \file 10 /// This file implements LeftRightQualifierAlignmentFixer, a TokenAnalyzer that 11 /// enforces either left or right const depending on the style. 12 /// 13 //===----------------------------------------------------------------------===// 14 15 #include "QualifierAlignmentFixer.h" 16 #include "FormatToken.h" 17 #include "llvm/Support/Debug.h" 18 #include "llvm/Support/Regex.h" 19 20 #include <algorithm> 21 22 #define DEBUG_TYPE "format-qualifier-alignment-fixer" 23 24 namespace clang { 25 namespace format { 26 27 QualifierAlignmentFixer::QualifierAlignmentFixer( 28 const Environment &Env, const FormatStyle &Style, StringRef &Code, 29 ArrayRef<tooling::Range> Ranges, unsigned FirstStartColumn, 30 unsigned NextStartColumn, unsigned LastStartColumn, StringRef FileName) 31 : TokenAnalyzer(Env, Style), Code(Code), Ranges(Ranges), 32 FirstStartColumn(FirstStartColumn), NextStartColumn(NextStartColumn), 33 LastStartColumn(LastStartColumn), FileName(FileName) { 34 std::vector<std::string> LeftOrder; 35 std::vector<std::string> RightOrder; 36 std::vector<tok::TokenKind> ConfiguredQualifierTokens; 37 PrepareLeftRightOrdering(Style.QualifierOrder, LeftOrder, RightOrder, 38 ConfiguredQualifierTokens); 39 40 // Handle the left and right alignment separately. 41 for (const auto &Qualifier : LeftOrder) { 42 Passes.emplace_back( 43 [&, Qualifier, ConfiguredQualifierTokens](const Environment &Env) { 44 return LeftRightQualifierAlignmentFixer(Env, Style, Qualifier, 45 ConfiguredQualifierTokens, 46 /*RightAlign=*/false) 47 .process(); 48 }); 49 } 50 for (const auto &Qualifier : RightOrder) { 51 Passes.emplace_back( 52 [&, Qualifier, ConfiguredQualifierTokens](const Environment &Env) { 53 return LeftRightQualifierAlignmentFixer(Env, Style, Qualifier, 54 ConfiguredQualifierTokens, 55 /*RightAlign=*/true) 56 .process(); 57 }); 58 } 59 } 60 61 std::pair<tooling::Replacements, unsigned> QualifierAlignmentFixer::analyze( 62 TokenAnnotator & /*Annotator*/, 63 SmallVectorImpl<AnnotatedLine *> & /*AnnotatedLines*/, 64 FormatTokenLexer & /*Tokens*/) { 65 auto Env = Environment::make(Code, FileName, Ranges, FirstStartColumn, 66 NextStartColumn, LastStartColumn); 67 if (!Env) 68 return {}; 69 llvm::Optional<std::string> CurrentCode = None; 70 tooling::Replacements Fixes; 71 for (size_t I = 0, E = Passes.size(); I < E; ++I) { 72 std::pair<tooling::Replacements, unsigned> PassFixes = Passes[I](*Env); 73 auto NewCode = applyAllReplacements( 74 CurrentCode ? StringRef(*CurrentCode) : Code, PassFixes.first); 75 if (NewCode) { 76 Fixes = Fixes.merge(PassFixes.first); 77 if (I + 1 < E) { 78 CurrentCode = std::move(*NewCode); 79 Env = Environment::make( 80 *CurrentCode, FileName, 81 tooling::calculateRangesAfterReplacements(Fixes, Ranges), 82 FirstStartColumn, NextStartColumn, LastStartColumn); 83 if (!Env) 84 return {}; 85 } 86 } 87 } 88 89 // Don't make replacements that replace nothing. 90 tooling::Replacements NonNoOpFixes; 91 92 for (const tooling::Replacement &Fix : Fixes) { 93 StringRef OriginalCode = Code.substr(Fix.getOffset(), Fix.getLength()); 94 95 if (!OriginalCode.equals(Fix.getReplacementText())) { 96 auto Err = NonNoOpFixes.add(Fix); 97 if (Err) 98 llvm::errs() << "Error adding replacements : " 99 << llvm::toString(std::move(Err)) << "\n"; 100 } 101 } 102 return {NonNoOpFixes, 0}; 103 } 104 105 static void replaceToken(const SourceManager &SourceMgr, 106 tooling::Replacements &Fixes, 107 const CharSourceRange &Range, std::string NewText) { 108 auto Replacement = tooling::Replacement(SourceMgr, Range, NewText); 109 auto Err = Fixes.add(Replacement); 110 111 if (Err) 112 llvm::errs() << "Error while rearranging Qualifier : " 113 << llvm::toString(std::move(Err)) << "\n"; 114 } 115 116 static void removeToken(const SourceManager &SourceMgr, 117 tooling::Replacements &Fixes, 118 const FormatToken *First) { 119 auto Range = CharSourceRange::getCharRange(First->getStartOfNonWhitespace(), 120 First->Tok.getEndLoc()); 121 replaceToken(SourceMgr, Fixes, Range, ""); 122 } 123 124 static void insertQualifierAfter(const SourceManager &SourceMgr, 125 tooling::Replacements &Fixes, 126 const FormatToken *First, 127 const std::string &Qualifier) { 128 FormatToken *Next = First->Next; 129 if (!Next) 130 return; 131 auto Range = CharSourceRange::getCharRange(Next->getStartOfNonWhitespace(), 132 Next->Tok.getEndLoc()); 133 134 std::string NewText = " " + Qualifier + " "; 135 NewText += Next->TokenText; 136 replaceToken(SourceMgr, Fixes, Range, NewText); 137 } 138 139 static void insertQualifierBefore(const SourceManager &SourceMgr, 140 tooling::Replacements &Fixes, 141 const FormatToken *First, 142 const std::string &Qualifier) { 143 auto Range = CharSourceRange::getCharRange(First->getStartOfNonWhitespace(), 144 First->Tok.getEndLoc()); 145 146 std::string NewText = " " + Qualifier + " "; 147 NewText += First->TokenText; 148 149 replaceToken(SourceMgr, Fixes, Range, NewText); 150 } 151 152 static bool endsWithSpace(const std::string &s) { 153 if (s.empty()) 154 return false; 155 return isspace(s.back()); 156 } 157 158 static bool startsWithSpace(const std::string &s) { 159 if (s.empty()) 160 return false; 161 return isspace(s.front()); 162 } 163 164 static void rotateTokens(const SourceManager &SourceMgr, 165 tooling::Replacements &Fixes, const FormatToken *First, 166 const FormatToken *Last, bool Left) { 167 auto *End = Last; 168 auto *Begin = First; 169 if (!Left) { 170 End = Last->Next; 171 Begin = First->Next; 172 } 173 174 std::string NewText; 175 // If we are rotating to the left we move the Last token to the front. 176 if (Left) { 177 NewText += Last->TokenText; 178 NewText += " "; 179 } 180 181 // Then move through the other tokens. 182 auto *Tok = Begin; 183 while (Tok != End) { 184 if (!NewText.empty() && !endsWithSpace(NewText)) 185 NewText += " "; 186 187 NewText += Tok->TokenText; 188 Tok = Tok->Next; 189 } 190 191 // If we are rotating to the right we move the first token to the back. 192 if (!Left) { 193 if (!NewText.empty() && !startsWithSpace(NewText)) 194 NewText += " "; 195 NewText += First->TokenText; 196 } 197 198 auto Range = CharSourceRange::getCharRange(First->getStartOfNonWhitespace(), 199 Last->Tok.getEndLoc()); 200 201 replaceToken(SourceMgr, Fixes, Range, NewText); 202 } 203 204 const FormatToken *LeftRightQualifierAlignmentFixer::analyzeRight( 205 const SourceManager &SourceMgr, const AdditionalKeywords &Keywords, 206 tooling::Replacements &Fixes, const FormatToken *Tok, 207 const std::string &Qualifier, tok::TokenKind QualifierType) { 208 // We only need to think about streams that begin with a qualifier. 209 if (!Tok->is(QualifierType)) 210 return Tok; 211 // Don't concern yourself if nothing follows the qualifier. 212 if (!Tok->Next) 213 return Tok; 214 if (LeftRightQualifierAlignmentFixer::isPossibleMacro(Tok->Next)) 215 return Tok; 216 217 FormatToken *Qual = Tok->Next; 218 FormatToken *LastQual = Qual; 219 while (Qual && isQualifierOrType(Qual, ConfiguredQualifierTokens)) { 220 LastQual = Qual; 221 Qual = Qual->Next; 222 } 223 if (LastQual && Qual != LastQual) { 224 rotateTokens(SourceMgr, Fixes, Tok, LastQual, /*Left=*/false); 225 Tok = LastQual; 226 } else if (Tok->startsSequence(QualifierType, tok::identifier, 227 TT_TemplateOpener)) { 228 // Read from the TemplateOpener to 229 // TemplateCloser as in const ArrayRef<int> a; const ArrayRef<int> &a; 230 FormatToken *EndTemplate = Tok->Next->Next->MatchingParen; 231 if (EndTemplate) { 232 // Move to the end of any template class members e.g. 233 // `Foo<int>::iterator`. 234 if (EndTemplate->startsSequence(TT_TemplateCloser, tok::coloncolon, 235 tok::identifier)) 236 EndTemplate = EndTemplate->Next->Next; 237 } 238 if (EndTemplate && EndTemplate->Next && 239 !EndTemplate->Next->isOneOf(tok::equal, tok::l_paren)) { 240 insertQualifierAfter(SourceMgr, Fixes, EndTemplate, Qualifier); 241 // Remove the qualifier. 242 removeToken(SourceMgr, Fixes, Tok); 243 return Tok; 244 } 245 } else if (Tok->startsSequence(QualifierType, tok::identifier)) { 246 FormatToken *Next = Tok->Next; 247 // The case `const Foo` -> `Foo const` 248 // The case `const Foo *` -> `Foo const *` 249 // The case `const Foo &` -> `Foo const &` 250 // The case `const Foo &&` -> `Foo const &&` 251 // The case `const std::Foo &&` -> `std::Foo const &&` 252 // The case `const std::Foo<T> &&` -> `std::Foo<T> const &&` 253 while (Next && Next->isOneOf(tok::identifier, tok::coloncolon)) 254 Next = Next->Next; 255 if (Next && Next->is(TT_TemplateOpener)) { 256 Next = Next->MatchingParen; 257 // Move to the end of any template class members e.g. 258 // `Foo<int>::iterator`. 259 if (Next && Next->startsSequence(TT_TemplateCloser, tok::coloncolon, 260 tok::identifier)) 261 return Tok; 262 assert(Next && "Missing template opener"); 263 Next = Next->Next; 264 } 265 if (Next && Next->isOneOf(tok::star, tok::amp, tok::ampamp) && 266 !Tok->Next->isOneOf(Keywords.kw_override, Keywords.kw_final)) { 267 if (Next->Previous && !Next->Previous->is(QualifierType)) { 268 insertQualifierAfter(SourceMgr, Fixes, Next->Previous, Qualifier); 269 removeToken(SourceMgr, Fixes, Tok); 270 } 271 return Next; 272 } 273 } 274 275 return Tok; 276 } 277 278 const FormatToken *LeftRightQualifierAlignmentFixer::analyzeLeft( 279 const SourceManager &SourceMgr, const AdditionalKeywords &Keywords, 280 tooling::Replacements &Fixes, const FormatToken *Tok, 281 const std::string &Qualifier, tok::TokenKind QualifierType) { 282 // if Tok is an identifier and possibly a macro then don't convert. 283 if (LeftRightQualifierAlignmentFixer::isPossibleMacro(Tok)) 284 return Tok; 285 286 const FormatToken *Qual = Tok; 287 const FormatToken *LastQual = Qual; 288 while (Qual && isQualifierOrType(Qual, ConfiguredQualifierTokens)) { 289 LastQual = Qual; 290 Qual = Qual->Next; 291 if (Qual && Qual->is(QualifierType)) 292 break; 293 } 294 295 if (!Qual) 296 return Tok; 297 298 if (LastQual && Qual != LastQual && Qual->is(QualifierType)) { 299 rotateTokens(SourceMgr, Fixes, Tok, Qual, /*Left=*/true); 300 Tok = Qual->Next; 301 } else if (Tok->startsSequence(tok::identifier, QualifierType)) { 302 if (Tok->Next->Next && Tok->Next->Next->isOneOf(tok::identifier, tok::star, 303 tok::amp, tok::ampamp)) { 304 // Don't swap `::iterator const` to `::const iterator`. 305 if (!Tok->Previous || 306 (Tok->Previous && !Tok->Previous->is(tok::coloncolon))) { 307 rotateTokens(SourceMgr, Fixes, Tok, Tok->Next, /*Left=*/true); 308 Tok = Tok->Next; 309 } 310 } 311 } 312 if (Tok->is(TT_TemplateOpener) && Tok->Next && 313 (Tok->Next->is(tok::identifier) || Tok->Next->isSimpleTypeSpecifier()) && 314 Tok->Next->Next && Tok->Next->Next->is(QualifierType)) 315 rotateTokens(SourceMgr, Fixes, Tok->Next, Tok->Next->Next, /*Left=*/true); 316 if (Tok->startsSequence(tok::identifier) && Tok->Next) { 317 if (Tok->Previous && 318 Tok->Previous->isOneOf(tok::star, tok::ampamp, tok::amp)) 319 return Tok; 320 const FormatToken *Next = Tok->Next; 321 // The case `std::Foo<T> const` -> `const std::Foo<T> &&` 322 while (Next && Next->isOneOf(tok::identifier, tok::coloncolon)) 323 Next = Next->Next; 324 if (Next && Next->Previous && 325 Next->Previous->startsSequence(tok::identifier, TT_TemplateOpener)) { 326 // Read from to the end of the TemplateOpener to 327 // TemplateCloser const ArrayRef<int> a; const ArrayRef<int> &a; 328 if (Next->is(tok::comment) && Next->getNextNonComment()) 329 Next = Next->getNextNonComment(); 330 assert(Next->MatchingParen && "Missing template closer"); 331 Next = Next->MatchingParen->Next; 332 333 // Move to the end of any template class members e.g. 334 // `Foo<int>::iterator`. 335 if (Next && Next->startsSequence(tok::coloncolon, tok::identifier)) 336 Next = Next->Next->Next; 337 if (Next && Next->is(QualifierType)) { 338 // Remove the const. 339 insertQualifierBefore(SourceMgr, Fixes, Tok, Qualifier); 340 removeToken(SourceMgr, Fixes, Next); 341 return Next; 342 } 343 } 344 if (Next && Next->Next && 345 Next->Next->isOneOf(tok::amp, tok::ampamp, tok::star)) { 346 if (Next->is(QualifierType)) { 347 // Remove the qualifier. 348 insertQualifierBefore(SourceMgr, Fixes, Tok, Qualifier); 349 removeToken(SourceMgr, Fixes, Next); 350 return Next; 351 } 352 } 353 } 354 return Tok; 355 } 356 357 tok::TokenKind LeftRightQualifierAlignmentFixer::getTokenFromQualifier( 358 const std::string &Qualifier) { 359 // Don't let 'type' be an identifier, but steal typeof token. 360 return llvm::StringSwitch<tok::TokenKind>(Qualifier) 361 .Case("type", tok::kw_typeof) 362 .Case("const", tok::kw_const) 363 .Case("volatile", tok::kw_volatile) 364 .Case("static", tok::kw_static) 365 .Case("inline", tok::kw_inline) 366 .Case("constexpr", tok::kw_constexpr) 367 .Case("restrict", tok::kw_restrict) 368 .Default(tok::identifier); 369 } 370 371 LeftRightQualifierAlignmentFixer::LeftRightQualifierAlignmentFixer( 372 const Environment &Env, const FormatStyle &Style, 373 const std::string &Qualifier, 374 const std::vector<tok::TokenKind> &QualifierTokens, bool RightAlign) 375 : TokenAnalyzer(Env, Style), Qualifier(Qualifier), RightAlign(RightAlign), 376 ConfiguredQualifierTokens(QualifierTokens) {} 377 378 std::pair<tooling::Replacements, unsigned> 379 LeftRightQualifierAlignmentFixer::analyze( 380 TokenAnnotator & /*Annotator*/, 381 SmallVectorImpl<AnnotatedLine *> &AnnotatedLines, 382 FormatTokenLexer &Tokens) { 383 tooling::Replacements Fixes; 384 const AdditionalKeywords &Keywords = Tokens.getKeywords(); 385 const SourceManager &SourceMgr = Env.getSourceManager(); 386 AffectedRangeMgr.computeAffectedLines(AnnotatedLines); 387 388 tok::TokenKind QualifierToken = getTokenFromQualifier(Qualifier); 389 assert(QualifierToken != tok::identifier && "Unrecognised Qualifier"); 390 391 for (AnnotatedLine *Line : AnnotatedLines) { 392 FormatToken *First = Line->First; 393 assert(First); 394 if (First->Finalized) 395 continue; 396 397 const auto *Last = Line->Last; 398 399 for (const auto *Tok = First; Tok && Tok != Last && Tok->Next; 400 Tok = Tok->Next) { 401 if (Tok->is(tok::comment)) 402 continue; 403 if (RightAlign) 404 Tok = analyzeRight(SourceMgr, Keywords, Fixes, Tok, Qualifier, 405 QualifierToken); 406 else 407 Tok = analyzeLeft(SourceMgr, Keywords, Fixes, Tok, Qualifier, 408 QualifierToken); 409 } 410 } 411 return {Fixes, 0}; 412 } 413 414 void QualifierAlignmentFixer::PrepareLeftRightOrdering( 415 const std::vector<std::string> &Order, std::vector<std::string> &LeftOrder, 416 std::vector<std::string> &RightOrder, 417 std::vector<tok::TokenKind> &Qualifiers) { 418 419 // Depending on the position of type in the order you need 420 // To iterate forward or backward through the order list as qualifier 421 // can push through each other. 422 // The Order list must define the position of "type" to signify 423 assert(llvm::is_contained(Order, "type") && 424 "QualifierOrder must contain type"); 425 // Split the Order list by type and reverse the left side. 426 427 bool left = true; 428 for (const auto &s : Order) { 429 if (s == "type") { 430 left = false; 431 continue; 432 } 433 434 tok::TokenKind QualifierToken = 435 LeftRightQualifierAlignmentFixer::getTokenFromQualifier(s); 436 if (QualifierToken != tok::kw_typeof && QualifierToken != tok::identifier) 437 Qualifiers.push_back(QualifierToken); 438 439 if (left) 440 // Reverse the order for left aligned items. 441 LeftOrder.insert(LeftOrder.begin(), s); 442 else 443 RightOrder.push_back(s); 444 } 445 } 446 447 bool LeftRightQualifierAlignmentFixer::isQualifierOrType( 448 const FormatToken *Tok, const std::vector<tok::TokenKind> &specifiedTypes) { 449 return Tok && (Tok->isSimpleTypeSpecifier() || Tok->is(tok::kw_auto) || 450 llvm::is_contained(specifiedTypes, Tok->Tok.getKind())); 451 } 452 453 // If a token is an identifier and it's upper case, it could 454 // be a macro and hence we need to be able to ignore it. 455 bool LeftRightQualifierAlignmentFixer::isPossibleMacro(const FormatToken *Tok) { 456 if (!Tok) 457 return false; 458 if (!Tok->is(tok::identifier)) 459 return false; 460 if (Tok->TokenText.upper() == Tok->TokenText.str()) 461 return true; 462 return false; 463 } 464 465 } // namespace format 466 } // namespace clang 467