Revert "[lldb server] Tidy up LLDB server return codes and associated tests"This reverts commit e387c8c413e2127bc93950fb6d786290237b4a9f. TheTestErrorMessages.test is failing on the Linux bots.
[lldb server] Tidy up LLDB server return codes and associated testsThis diff modifies the LLDB server return codes to more accurately reflect usageerror paths. Specifically we always propagate the
[lldb server] Tidy up LLDB server return codes and associated testsThis diff modifies the LLDB server return codes to more accurately reflect usageerror paths. Specifically we always propagate the return codes from the mainentrypoints into GDB remote LLDB server, and platform LLDB server. This way, thetop-level caller of LLDB server will be able to correctly check whether theexecutable exited with or without an error.We additionally modify and extend the associated shell unit tests to expectnonzero return codes on error conditions.Test Plan:LLDB tests pass:```ninja check-lldb```Reviewed By: teemperorDifferential Revision: https://reviews.llvm.org/D108351
show more ...
[lldb] Reinstate TestGdbserverPort.testThis test was deleted by accident in the great lldb-mi removal:37fed664022e07c2293b674e9c9d2b50aac547ba
[lldb] Fix TestErrorMessages test on standalone builds by adding lldb-server substitutionIt seems that TestErrorMessages.test is failing on the standalone + Xcode buildsas lldb-server executable c
[lldb] Fix TestErrorMessages test on standalone builds by adding lldb-server substitutionIt seems that TestErrorMessages.test is failing on the standalone + Xcode buildsas lldb-server executable can't be found by lit's default PATH search. I assumeinvoking lldb-server via a lit substitution gets this working again aseverything else is working, so that's what this patch is doing.I had to add the lldb-server substitution as the test seems lldb-server specificand we don't want it to default to debugserver on Darwin.Using a substitution also seems in general like a good idea so that the commandslit is printing on failure are using the full path to lldb-server and can bere-run in a terminal.Reviewed By: labathDifferential Revision: https://reviews.llvm.org/D91155
[lldb] Port lldb gdb-server to libOptionThe existing help text was very terse and was missing several importantoptions. In the new version, I add a short description of each optionand a slightly
[lldb] Port lldb gdb-server to libOptionThe existing help text was very terse and was missing several importantoptions. In the new version, I add a short description of each optionand a slightly longer description of the tool as a whole.The new option list does not include undocumented no-op options:--debug and --verbose. It also does not include undocumented shortaliases for long options, with two exceptions: -h, because it'swell-known; and -S (--setsid), as it's used in one test. Using theseoptions will now produce an error. I believe that is acceptable as usersaren't generally invoking lldb-server directly, and the only way tolearn about the short aliases was by looking at the source.Differential Revision: https://reviews.llvm.org/D89477