[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://r
[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://reviews.llvm.org/D128077
show more ...
[lldb] Use assertIn/NotIn over assertTrue/False (NFC)For improved failure messages, use `assertIn` over `assertTrue`.Differential Revision: https://reviews.llvm.org/D96095
[Test] Simplify DWARF test cases. NFC.The Length, AbbrOffset and Values fields of the debug_info section areoptional. This patch helps remove them and simplify test cases.Reviewed By: MaskRayD
[Test] Simplify DWARF test cases. NFC.The Length, AbbrOffset and Values fields of the debug_info section areoptional. This patch helps remove them and simplify test cases.Reviewed By: MaskRayDifferential Revision: https://reviews.llvm.org/D86857
[DWARFYAML] Add support for emitting multiple abbrev tables.This patch adds support for emitting multiple abbrev tables. Currently,compilation units will always reference the first abbrev table.
[DWARFYAML] Add support for emitting multiple abbrev tables.This patch adds support for emitting multiple abbrev tables. Currently,compilation units will always reference the first abbrev table.Reviewed By: jhenderson, labathDifferential Revision: https://reviews.llvm.org/D86194
[DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.'InitialLength' is replaced with 'Format' (DWARF32 by default) and 'Length' in this patch.Besides, test cases for DWARFv4
[DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.'InitialLength' is replaced with 'Format' (DWARF32 by default) and 'Length' in this patch.Besides, test cases for DWARFv4 and DWARFv5, DWARF32 and DWARF64 isadded.Reviewed By: jhendersonDifferential Revision: https://reviews.llvm.org/D82622
[lldb][test] Trying to fix build bot after 0431e4bcb27bba30156ac49be4c09ac632c5a03a
[source maps] Fix remove, insert-after and replaceSummary:In this diff of mine D77186 I introduce a bug in the replace operation, where I was failing fast by mistake.Besides, a similar problem ex
[source maps] Fix remove, insert-after and replaceSummary:In this diff of mine D77186 I introduce a bug in the replace operation, where I was failing fast by mistake.Besides, a similar problem existed in the insert-after operation, where it was failing fast.Finally, the remove operation was wrong, as it was not using the indices provided by the users.I fixed those issues and added some tests account for cases with multiple elements in these requests.Reviewers: labath, clayborgReviewed By: labathSubscribers: mgrang, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D77324
[source maps] Ensure all valid source maps are added instead of failing with the first invalid oneSummary:Several lldb-vscode users have noticed that when a source map rule is invalid (because a f
[source maps] Ensure all valid source maps are added instead of failing with the first invalid oneSummary:Several lldb-vscode users have noticed that when a source map rule is invalid (because a folder doesn't exist anymore), the rest of the source maps from their configurations are not applied.This happens because lldb-vscode executes a single "settings set target.source-map" command with all the source maps and LLDB processes them one by one until one fails.Instead of doing this, we can process in LLDB all the source map rules and apply the valid ones instead of failing fast.Reviewers: clayborg, labath, kusmour, aadsmSubscribers: lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D77186
[lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suiteSummary:The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely usel
[lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suiteSummary:The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely useless for actually debugging the issue.This patch is just replacing this construct (and similar ones like `assertTrue(a != b, ...)` with the proper call to assertEqual or assertNotEquals.This patch was mostly written by a shell script with some manual verification afterwards:```lang=pythonimport sysdef sanitize_line(line): if line.strip().startswith("self.assertTrue(") and " == " in line: line = line.replace("self.assertTrue(", "self.assertEquals(") line = line.replace(" == ", ", ", 1) if line.strip().startswith("self.assertTrue(") and " != " in line: line = line.replace("self.assertTrue(", "self.assertNotEqual(") line = line.replace(" != ", ", ", 1) return linefor a in sys.argv[1:]: with open(a, "r") as f: lines = f.readlines() with open(a, "w") as f: for line in lines: f.write(sanitize_line(line))```Reviewers: labath, JDevlieghereReviewed By: labathSubscribers: abidh, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D74475
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdi
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdir -p lldb/test/API/{test_runner/test,tools/lldb-{server,vscode}}mv lldb/packages/Python/lldbsuite/test/test_runner/test lldb/test/API/test_runnerfor d in $(find lldb/packages/Python/lldbsuite/test/* -maxdepth 0 -type d | egrep -v "make|plugins|test_runner|tools"); do mv $d lldb/test/API; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-vscode -maxdepth 1 -mindepth 1 | grep -v ".py"); do mv $d lldb/test/API/tools/lldb-vscode; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-server -maxdepth 1 -mindepth 1 | egrep -v "gdbremote_testcase.py|lldbgdbserverutils.py|socket_packet_pump.py"); do mv $d lldb/test/API/tools/lldb-server; done```lldb/packages/Python/lldbsuite/__init__.py and lldb/test/API/lit.cfg.py were also updated with the new directory structure.Reviewers: labath, JDevlieghereTags: #lldbDifferential Revision: https://reviews.llvm.org/D71151