[lldb] Use assertState in even more tests (NFC)Followup to D127355 and D127378, converting more instances ofassertEqual to assertState.
[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://r
[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://reviews.llvm.org/D128077
show more ...
[lldb] Use assertIn/NotIn over assertTrue/False (NFC)For improved failure messages, use `assertIn` over `assertTrue`.Differential Revision: https://reviews.llvm.org/D96095
[lldb] Convert more assertTrue to assertEqual (NFC)Follow up to D95813, this converts multiline assertTrue to assertEqual.Differential Revision: https://reviews.llvm.org/D95899
[lldb] [test] Link FreeBSD test failures to bugsDifferential Revision: https://reviews.llvm.org/D92740
[lldb] Enable FreeBSDRemote plugin by default and update test statusThe new FreeBSDRemote plugin has reached feature parity on i386and amd64 targets. Use it by default on these architectures, whi
[lldb] Enable FreeBSDRemote plugin by default and update test statusThe new FreeBSDRemote plugin has reached feature parity on i386and amd64 targets. Use it by default on these architectures, whileallowing the use of the legacy plugin via FREEBSD_LEGACY_PLUGIN envvar.Revisit the method of switching plugins. Apparently, the return valueof PlatformFreeBSD::CanDebugProcess() is what really decides whetherthe legacy or the new plugin is used.Update the test status. Reenable the tests that were previouslydisabled on FreeBSD and do not cause hangs or are irrelevant to FreeBSD.Mark all tests that fail reliably as expectedFailure. For now, teststhat are flaky (i.e. produce unstable results) are left enabledand cause unpredictable test failures.Differential Revision: https://reviews.llvm.org/D90757
Harmonize Python shebangDifferential Revision: https://reviews.llvm.org/D83857
[lldb/Properties] Move OSPluginReportsAllThreads from Target to ProcessThis is what Jim wanted originally.rdar://problem/61236293Differential revision: https://reviews.llvm.org/D80159
[lldb] NFC: Fix trivial typo in comments, documents, and messagesDifferential Revision: https://reviews.llvm.org/D77460
Disable two new tests on Windows. They are failing but the logs are not helpful.Also turn on the command trace unconditionally for TestThreadPlanCommands.py as thetests for the Ubuntu bot don't s
Disable two new tests on Windows. They are failing but the logs are not helpful.Also turn on the command trace unconditionally for TestThreadPlanCommands.py as thetests for the Ubuntu bot don't seem to run with -t making it hard to see why this isfailing remotely.
Allow the ThreadPlanStackMap to hold the thread plans for threadsthat were not reported by the OS plugin. To facilitate this, moveadding/updating the ThreadPlans for a Thread to the ThreadPlanStac
Allow the ThreadPlanStackMap to hold the thread plans for threadsthat were not reported by the OS plugin. To facilitate this, moveadding/updating the ThreadPlans for a Thread to the ThreadPlanStackMap.Also move dumping thread plans there as well.Added some tests for "thread plan list" and "thread plan discard" sinceI didn't seem to have written any originally.Differential Revision: https://reviews.llvm.org/D76814
[lldb][testsuite] Create a SBDebugger instance for each testSome tests set settings and don't clean them up, this leads to side effects in other tests.The patch removes a global debugger instance
[lldb][testsuite] Create a SBDebugger instance for each testSome tests set settings and don't clean them up, this leads to side effects in other tests.The patch removes a global debugger instance with a per-test debugger to avoid such effects.From what I see, lldb.DBG was needed to determine the platform before a test is run,lldb.selected_platform is used for this purpose now. Though, this required adding a new functionto the SBPlatform interface.Differential Revision: https://reviews.llvm.org/D74903
[lldb] Remove license headers from all test source filesSummary:Around a third of our test sources have LLVM license headers. This patch removes those headers from all testsources and also fixes
[lldb] Remove license headers from all test source filesSummary:Around a third of our test sources have LLVM license headers. This patch removes those headers from all testsources and also fixes any tests that depended on the length of the license header.The reasons for this are:* A few tests verify line numbers and will start failing if the number of lines in the LLVM license header changes. Once I landed my patch for valid SourceLocations in debug info we will probably have even more tests that verify line numbers.* No other LLVM project is putting license headers in its test files to my knowledge.* They make the test sources much more verbose than they have to be. Several tests have longer license headers than the actual test source.For the record, the following tests had their line numbers changed to pass with the removal of the license header: lldb-api :: functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py lldb-shell :: Reproducer/TestGDBRemoteRepro.test lldb-shell :: Reproducer/TestMultipleTargets.test lldb-shell :: Reproducer/TestReuseDirectory.test lldb-shell :: ExecControl/StopHook/stop-hook-threads.test lldb-shell :: ExecControl/StopHook/stop-hook.test lldb-api :: lang/objc/exceptions/TestObjCExceptions.pyReviewers: #lldb, espindola, JDevlieghereReviewed By: #lldb, JDevlieghereSubscribers: emaste, aprantl, arphaman, JDevlieghere, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D74839
[lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suiteSummary:The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely usel
[lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suiteSummary:The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely useless for actually debugging the issue.This patch is just replacing this construct (and similar ones like `assertTrue(a != b, ...)` with the proper call to assertEqual or assertNotEquals.This patch was mostly written by a shell script with some manual verification afterwards:```lang=pythonimport sysdef sanitize_line(line): if line.strip().startswith("self.assertTrue(") and " == " in line: line = line.replace("self.assertTrue(", "self.assertEquals(") line = line.replace(" == ", ", ", 1) if line.strip().startswith("self.assertTrue(") and " != " in line: line = line.replace("self.assertTrue(", "self.assertNotEqual(") line = line.replace(" != ", ", ", 1) return linefor a in sys.argv[1:]: with open(a, "r") as f: lines = f.readlines() with open(a, "w") as f: for line in lines: f.write(sanitize_line(line))```Reviewers: labath, JDevlieghereReviewed By: labathSubscribers: abidh, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D74475
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdi
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdir -p lldb/test/API/{test_runner/test,tools/lldb-{server,vscode}}mv lldb/packages/Python/lldbsuite/test/test_runner/test lldb/test/API/test_runnerfor d in $(find lldb/packages/Python/lldbsuite/test/* -maxdepth 0 -type d | egrep -v "make|plugins|test_runner|tools"); do mv $d lldb/test/API; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-vscode -maxdepth 1 -mindepth 1 | grep -v ".py"); do mv $d lldb/test/API/tools/lldb-vscode; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-server -maxdepth 1 -mindepth 1 | egrep -v "gdbremote_testcase.py|lldbgdbserverutils.py|socket_packet_pump.py"); do mv $d lldb/test/API/tools/lldb-server; done```lldb/packages/Python/lldbsuite/__init__.py and lldb/test/API/lit.cfg.py were also updated with the new directory structure.Reviewers: labath, JDevlieghereTags: #lldbDifferential Revision: https://reviews.llvm.org/D71151