Recommit: Compress formatting of array type names (int [4] -> int[4])Based on post-commit review discussion on2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith.Other uses of forcing Ha
Recommit: Compress formatting of array type names (int [4] -> int[4])Based on post-commit review discussion on2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith.Other uses of forcing HasEmptyPlaceHolder to false seem OK to me -they're all around pointer/reference types where the pointer/referencetoken will appear at the rightmost side of the left side of the typename, so they make nested types (eg: the "int" in "int *") behave asthough there is a non-empty placeholder (because the "*" is essentiallythe placeholder as far as the "int" is concerned).This was originally committed in 277623f4d5a672d707390e2c3eaf30a9eb4b075cReverted in f9ad1d1c775a8e264bebc15d75e0c6e5c20eefc7 due to breakagesoutside of clang - lldb seems to have some strange/strong dependence on"char [N]" versus "char[N]" when printing strings (not due to that nameappearing in DWARF, but probably due to using clang to stringify typenames) that'll need to be addressed, plus a few other odds and ends inother subprojects (clang-tools-extra, compiler-rt, etc).
show more ...
Revert "Compress formatting of array type names (int [4] -> int[4])"Looks like lldb has some issues with this - somehow it causes lldb totreat a "char[N]" type as an array of chars (prints them ou
Revert "Compress formatting of array type names (int [4] -> int[4])"Looks like lldb has some issues with this - somehow it causes lldb totreat a "char[N]" type as an array of chars (prints them outindividually) but a "char [N]" is printed as a string. (even though theDWARF doesn't have this string in it - it's something to do with thestring lldb generates for itself using clang)This reverts commit 277623f4d5a672d707390e2c3eaf30a9eb4b075c.
Compress formatting of array type names (int [4] -> int[4])Based on post-commit review discussion on2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith.Other uses of forcing HasEmptyPlac
Compress formatting of array type names (int [4] -> int[4])Based on post-commit review discussion on2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith.Other uses of forcing HasEmptyPlaceHolder to false seem OK to me -they're all around pointer/reference types where the pointer/referencetoken will appear at the rightmost side of the left side of the typename, so they make nested types (eg: the "int" in "int *") behave asthough there is a non-empty placeholder (because the "*" is essentiallythe placeholder as far as the "int" is concerned).
[ASTImporter] Actually test ArrayInitLoopExpr in the array-init-loop-expr test.Summary:The `array-init-loop-expr` test is currently not testing the importing of ArrayInitLoopExprs.This is becaus
[ASTImporter] Actually test ArrayInitLoopExpr in the array-init-loop-expr test.Summary:The `array-init-loop-expr` test is currently not testing the importing of ArrayInitLoopExprs.This is because we import the `S` struct into the `test.cpp` contextand only do a copy-assignment in `test.cpp`, so the actual ArrayInitLoopExpr we wanted toimport is generated by clang directly in the target context. This means we actuallynever test the importing of ArrayInitLoopExpr with this test, which becomes obviouswhen looking at the missing test coverage for the respective VisitArrayInitLoopExpr method.This patch moves the copy-assignment of our struct to the `S.cpp` context, which meansthat `test.cpp` now actually has to import the ArrayInitLoopExpr.Reviewers: a.sidorin, a_sidorinReviewed By: a_sidorinSubscribers: a_sidorin, martong, cfe-commitsDifferential Revision: https://reviews.llvm.org/D51115llvm-svn: 340467
[ASTImporter] Add test for ArrayInitLoopExprReviewers: a.sidorin, a_sidorinReviewed By: a_sidorinSubscribers: martong, cfe-commitsDifferential Revision: https://reviews.llvm.org/D50733llvm-
[ASTImporter] Add test for ArrayInitLoopExprReviewers: a.sidorin, a_sidorinReviewed By: a_sidorinSubscribers: martong, cfe-commitsDifferential Revision: https://reviews.llvm.org/D50733llvm-svn: 339831