[lldb] Update TestBasicEntryValues.py for `image lookup` outputUpdate TestBasicEntryValues.py for 15983c28aa81 which changes the outputfor `image lookup -v`. This should fix the debian and macos b
[lldb] Update TestBasicEntryValues.py for `image lookup` outputUpdate TestBasicEntryValues.py for 15983c28aa81 which changes the outputfor `image lookup -v`. This should fix the debian and macos build bots.
show more ...
Rough guess at fixing lldb tests to handle Clang defaulting to DWARFv5
[lldb] Bumb Clang version requirement for TestBasicEntryValues.py to 11The test only passes with Clang>=11 so adjust the decorator.Failure output for Clang 10 is:--- FileCheck trace (code=1) --
[lldb] Bumb Clang version requirement for TestBasicEntryValues.py to 11The test only passes with Clang>=11 so adjust the decorator.Failure output for Clang 10 is:--- FileCheck trace (code=1) ---FileCheck main.cpp -check-prefix=FUNC1-GNUFileCheck input: Address: a.out[0x0000000000401127] (a.out.PT_LOAD[1]..text + 263) Summary: a.out`func1(int&) + 23 at main.cpp:25:1 Module: file = "functionalities/param_entry_vals/basic_entry_values/BasicEntryValues_GNU.test_dwo/a.out", arch = "x86_64" CompileUnit: id = {0x00000000}, file = "functionalities/param_entry_vals/basic_entry_values/main.cpp", language = "c++11" Function: id = {0x400000000000010a}, name = "func1(int&)", mangled = "_Z5func1Ri", range = [0x0000000000401110-0x0000000000401129) FuncType: id = {0x400000000000010a}, byte-size = 0, decl = main.cpp:13, compiler_type = "void (int &)" Blocks: id = {0x400000000000010a}, range = [0x00401110-0x00401129) LineEntry: [0x0000000000401127-0x0000000000401130): functionalities/param_entry_vals/basic_entry_values/main.cpp:25:1 Symbol: id = {0x0000002c}, range = [0x0000000000401110-0x0000000000401129), name="func1(int&)", mangled="_Z5func1Ri"FileCheck output:functionalities/param_entry_vals/basic_entry_values/main.cpp:23:16: error: FUNC1-GNU: expected string not found in input // FUNC1-GNU: name = "sink", type = "int &", location = DW_OP_GNU_entry_value
[lldb] Skip tests exercising DW_OP_GNU_entry_value with dsymutilIt seems that this opcode needs explicit support in dsymutil. Disablethese tests until that is implemented.
[lldb/DWARF] Add support for pre-standard GNU call site attributesSummary:The code changes are very straight-forward -- just handle both DW_AT_GNUand DW_AT_call versions of all tags and attribute
[lldb/DWARF] Add support for pre-standard GNU call site attributesSummary:The code changes are very straight-forward -- just handle both DW_AT_GNUand DW_AT_call versions of all tags and attributes. There is just onesmall gotcha: in the GNU version, DW_AT_low_pc was used both for the"return pc" and the "call pc" values, depending on whether the tag wasdescribing a tail call, while the official scheme uses differentattributes for the two things.Reviewers: vsk, dblaikieSubscribers: lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D80519
[lldb] Make "inline" tests more configurableSummary:This patch adds two new arguments to the MakeInlineTest function. Themain motivation is a follow-up patch I'm preparing, but they seemgenerall
[lldb] Make "inline" tests more configurableSummary:This patch adds two new arguments to the MakeInlineTest function. Themain motivation is a follow-up patch I'm preparing, but they seemgenerally useful.The first argument allows the user to specify the "build dictionary".With this argument one can avoid the need to provide a custom Makefileif all he needs is to override a couple of make variables. This hooks inneatly into the existing dictionary support for non-inline tests.The second argument specifies the name of the test. This could be usedto provide better names to the generated test classes, but it's mainlyuseful in conjuction with the first argument: now that we can specify acustom build dictionary, it may sometimes make sense to run the sametest twice with different build configurations. To achieve that, we needto give the two tests different names, and this argument achieves that.The usage of the arguments is demonstrated via TestBasicEntryValues.py.Reviewers: vsk, JDevlieghereSubscribers: lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D80518
[DwarfExpression] Support entry values for indirect parametersSummary:A struct argument can be passed-by-value to a callee via a pointer to atemporary stack copy. Add support for emitting an entr
[DwarfExpression] Support entry values for indirect parametersSummary:A struct argument can be passed-by-value to a callee via a pointer to atemporary stack copy. Add support for emitting an entry value DBG_VALUEwhen an indirect parameter DBG_VALUE becomes unavailable. This is doneby omitting DW_OP_stack_value from the entry value expression, to makethe expression describe the location of an object.rdar://63373691Reviewers: djtodoro, aprantl, dstenbSubscribers: hiraditya, lldb-commits, llvm-commitsTags: #lldb, #llvmDifferential Revision: https://reviews.llvm.org/D80345
[LLDB] Disable TestBasicEntryValues.py for armTestBasicEntryValues.py fails on arm 32 bit. Currently running on silent master here:http://lab.llvm.org:8014/builders/lldb-arm-ubuntu/
[lldb] Speculative fix for the entry values test on arm64The bot fails with a message which seems to indicate a problem in optionparsing. Avoid grouping the options to see if that helps.
[lldb] Revive TestBasicEntryValuesX86_64Summary:This function rewrites the test to be (hopefully) less susceptible tocodegen changes and re-enables it.The most interesting changes are:- use an
[lldb] Revive TestBasicEntryValuesX86_64Summary:This function rewrites the test to be (hopefully) less susceptible tocodegen changes and re-enables it.The most interesting changes are:- use an __attribute__((optnone)) function instead of a volatile asm to "use" a value. This isn't strictly necessary, but it makes the function simpler while achieving the same effect.- use a call to a function with the exact same signature instead of a volatile asm to "destroy" arguments. This makes the independent of the ABI, and (together with avoiding the usage of the arguments after the call) ensures that the compiler has no reason to move the argument from its initial register (previously we needed to guess where will the compiler store the arguments).Reviewers: vsk, djtodoro, dblaikieSubscribers: lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D79491
Reland D73534: [DebugInfo] Enable the debug entry values feature by defaultThe issue that was causing the build failures was fixed with the D76164.
Revert "Reland "[DebugInfo] Enable the debug entry values feature by default""This reverts commit 5aa5c943f7da155b95564058cd5d50a93eabfc89.Causes clang to assert, seehttps://bugs.chromium.org/p/c
Revert "Reland "[DebugInfo] Enable the debug entry values feature by default""This reverts commit 5aa5c943f7da155b95564058cd5d50a93eabfc89.Causes clang to assert, seehttps://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c4for a repro.
Reland "[DebugInfo] Enable the debug entry values feature by default"Differential Revision: https://reviews.llvm.org/D73534
Revert "Reland "[DebugInfo] Enable the debug entry values feature by default""This reverts commit rGfaff707db82d.A failure found on an ARM 2-stage buildbot.The investigation is needed.
Revert "Reland "[DebugInfo] Enable the debug entry values feature by default""This reverts commit rGa82d3e8a6e67.
Reland "[DebugInfo] Enable the debug entry values feature by default"This patch enables the debug entry values feature. - Remove the (CC1) experimental -femit-debug-entry-values option - Enabl
Reland "[DebugInfo] Enable the debug entry values feature by default"This patch enables the debug entry values feature. - Remove the (CC1) experimental -femit-debug-entry-values option - Enable it for x86, arm and aarch64 targets - Resolve the test failures - Leave the llc experimental option for targets that do not support the CallSiteInfo yetDifferential Revision: https://reviews.llvm.org/D73534
Revert "[DebugInfo] Enable the debug entry values feature by default"This reverts commit rG9f6ff07f8a39.Found a test failure on clang-with-thin-lto-ubuntu buildbot.
[DebugInfo] Enable the debug entry values feature by defaultThis patch enables the debug entry values feature. - Remove the (CC1) experimental -femit-debug-entry-values option - Enable it for
[DebugInfo] Enable the debug entry values feature by defaultThis patch enables the debug entry values feature. - Remove the (CC1) experimental -femit-debug-entry-values option - Enable it for x86, arm and aarch64 targets - Resolve the test failures - Leave the llc experimental option for targets that do not support the CallSiteInfo yetDifferential Revision: https://reviews.llvm.org/D73534
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdi
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdir -p lldb/test/API/{test_runner/test,tools/lldb-{server,vscode}}mv lldb/packages/Python/lldbsuite/test/test_runner/test lldb/test/API/test_runnerfor d in $(find lldb/packages/Python/lldbsuite/test/* -maxdepth 0 -type d | egrep -v "make|plugins|test_runner|tools"); do mv $d lldb/test/API; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-vscode -maxdepth 1 -mindepth 1 | grep -v ".py"); do mv $d lldb/test/API/tools/lldb-vscode; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-server -maxdepth 1 -mindepth 1 | egrep -v "gdbremote_testcase.py|lldbgdbserverutils.py|socket_packet_pump.py"); do mv $d lldb/test/API/tools/lldb-server; done```lldb/packages/Python/lldbsuite/__init__.py and lldb/test/API/lit.cfg.py were also updated with the new directory structure.Reviewers: labath, JDevlieghereTags: #lldbDifferential Revision: https://reviews.llvm.org/D71151