Don't depend on the "run" alias doing shell expanding.Instead dial it up explicitly.This test started failing recently and I'm not sure why. It alsodoesn't make sense to me the replacing "run" w
Don't depend on the "run" alias doing shell expanding.Instead dial it up explicitly.This test started failing recently and I'm not sure why. It alsodoesn't make sense to me the replacing "run" with "process launch -X 1 --"should make any difference - run is an alias for the latter. Butit does pass with the change, and unless we are testing for the exactrun alias, it's better to ask for what we want explicitly.
show more ...
[lldb] Fix 'r' and 'run' aliases on Apple SiliconThe 'r' and 'run' aliases were different based on the targetarchitecture. I suspect the intention was to disable shell expansion onembedded device
[lldb] Fix 'r' and 'run' aliases on Apple SiliconThe 'r' and 'run' aliases were different based on the targetarchitecture. I suspect the intention was to disable shell expansion onembedded devices. This fixes TestCustomShell.test on AS.
[lldb/Driver] Exit with a non-zero exit code in case of error in batch mode.We have the option to stop running commands in batch mode when an erroroccurs. When that happens we should exit the driv
[lldb/Driver] Exit with a non-zero exit code in case of error in batch mode.We have the option to stop running commands in batch mode when an erroroccurs. When that happens we should exit the driver with a non-zero exitcode.Differential revision: https://reviews.llvm.org/D78825
[lldb/lit] Introduce %clang_host substitutionsSummary:This patch addresses an ambiguity in how our existing tests invoke thecompiler. Roughly two thirds of our current "shell" tests invoke theco
[lldb/lit] Introduce %clang_host substitutionsSummary:This patch addresses an ambiguity in how our existing tests invoke thecompiler. Roughly two thirds of our current "shell" tests invoke thecompiler to build the executables for the host. However, there is alsoa significant number of tests which don't build a host binary (becausethey don't need to run it) and instead they hardcode a certain target.We also have code which adds a bunch of default arguments to the %clangsubstitutions. However, most of these arguments only really make sensefor the host compilation. So far, this has worked mostly ok, because thearguments we were adding were not conflicting with the target-hardcodingtests (though they did provoke an occasional "argument unused" warning).However, this started to break down when we wanted to usetarget-hardcoding clang-cl tests (D69031) because clang-cl has asubstantially different command line, and it was getting very confusedby some of the arguments we were adding on non-windows hosts.This patch avoid this problem by creating separate %clang(xx,_cl)_hostsubstutitions, which are specifically meant to be used for compilinghost binaries. All funny host-specific options are moved there. Toensure that the regular %clang substitutions are not used for compilinghost binaries (skipping the extra arguments) I employ a littlehac^H^H^Htrick -- I add an invalid --target argument to the %clangsubstitution, which means that one has to use an explicit --target inorder for the compilation to succeed.Reviewers: JDevlieghere, aprantl, mstorsjo, espindolaSubscribers: emaste, arichardson, MaskRay, jfb, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D69619
[lldb] [test] Mark TestCustomShell XFAIL on *bsd as wellAll *BSD targets do not implement ShellExpandArguments, so markthe test appropriately.
Re-land "[test] Split LLDB tests into API, Shell & Unit"The original patch got reverted because it broke `check-lldb` on a cleanbuild. This fixes that.llvm-svn: 374201
Revert [test] Split LLDB tests into API, Shell & Unitas it appears to have broken check-lldb.This reverts r374184 (git commit 22314179f0660c172514b397060fd8f34b586e82)llvm-svn: 374187
[test] Split LLDB tests into API, Shell & UnitLLDB has three major testing strategies: unit tests, tests that exercisethe SB API though dotest.py and what we currently call lit tests. Thelater is
[test] Split LLDB tests into API, Shell & UnitLLDB has three major testing strategies: unit tests, tests that exercisethe SB API though dotest.py and what we currently call lit tests. Thelater is rather confusing as we're now using lit as the driver for allthree types of tests. As most of this grew organically, the directorystructure in the LLDB repository doesn't really make this clear.The 'lit' tests are part of the root and among these tests there's aUnit and Suite folder for the unit and dotest-tests. This layout makesit impossible to run just the lit tests.This patch changes the directory layout to match the 3 testingstrategies, each with their own directory and their own configurationfile. This means there are now 3 directories under lit with 3corresponding targets: - API (check-lldb-api): Test exercising the SB API. - Shell (check-lldb-shell): Test exercising command line utilities. - Unit (check-lldb-unit): Unit tests.Finally, there's still the `check-lldb` target that runs all three testsuites.Finally, this also renames the lit folder to `test` to match the LLVMrepository layout.Differential revision: https://reviews.llvm.org/D68606llvm-svn: 374184