Have CommandObjectParsed check for "commands that take no arguments".This is currently being done in an ad hoc way, and so for somecommands it isn't being checked. We have the info to make this c
Have CommandObjectParsed check for "commands that take no arguments".This is currently being done in an ad hoc way, and so for somecommands it isn't being checked. We have the info to make this check,since commands are supposed to add their arguments to the m_argumentsfield of the CommandObject. This change uses that info to check whetherthe command received arguments in error.A handful of commands weren't defining their argument types, I also hadto fix them. And a bunch of commands were checking for arguments byhand, so I removed those checks in favor of the CommandObject one. Thatalso meant I had to change some tests that were checking for the ad hocerror outputs.Differential Revision: https://reviews.llvm.org/D128453
show more ...
[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://r
[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://reviews.llvm.org/D128077
[lldb] [test] Update baseline test status for FreeBSDFixes #19721Fixes #18440Partially fixes bug #47660Fixes #47761Fixes #47763Sponsored by: The FreeBSD Foundation
[lldb] Correctly display the number of types foundCorrectly display the number of types found for `target modules lookup--type` and add a test.Fixes #53219
[lldb] Skip tests for target var without a proc on both arm64 & arm64eLLDB needs to be taught about chained fixups.<rdar://problem/37773624>
[lldb] Skip target variable test on AS
[lldb] Remove support for replaying the test suite from a reproducerThis patch removes the infrastructure to replay the test suite from areproducer, as well as the modifications made to the indivi
[lldb] Remove support for replaying the test suite from a reproducerThis patch removes the infrastructure to replay the test suite from areproducer, as well as the modifications made to the individual tests.
[LLDB] On Windows, fix testsThis patch fixes a few issues seen when running `ninja check-lldb` in a Release build with VS2017:- Some binaries couldn't be found (such as lldb-vscode.exe), because
[LLDB] On Windows, fix testsThis patch fixes a few issues seen when running `ninja check-lldb` in a Release build with VS2017:- Some binaries couldn't be found (such as lldb-vscode.exe), because .exe wasn't appended to the file name.- Many tests used to fail since our installed locale is in French - the OS error messages are not emitted in English.- Our codepage being Windows-1252, python failed to decode some error messages with accentuations.Differential Revision: https://reviews.llvm.org/D88975
[lldb/Test] Add missing stdio.h includesFixes error: implicit declaration of function 'printf' is invalid in C99[-Werror,-Wimplicit-function-declaration]
[lldb] Improve platform handling in CreateTargetInternalCurrently, `target create` has no --platform option. However,TargetList::CreateTargetInternal which is called under the hood, willreturn an
[lldb] Improve platform handling in CreateTargetInternalCurrently, `target create` has no --platform option. However,TargetList::CreateTargetInternal which is called under the hood, willreturn an error when either no platform or multiple matching platformsare found, saying that a platform should be specified with --platform.This patch adds the platform option, but that doesn't solve either ofthese errors. - If more than one platform matches, specifying the platform isn't going to fix that. The current code will only look at the architecture instead. I've updated the error message to ask the user to specify an architecture. - If no architecture is found, specifying a new one via platform isn't going to change that either because we already try to find one that matches the given architecture.Differential revision: https://reviews.llvm.org/D84809
[lldb/Test] Add a trace method to replace print statements.Many tests use (commented out) print statement for debugging the testitself. This patch adds a new trace method to lldbtest to reuse the
[lldb/Test] Add a trace method to replace print statements.Many tests use (commented out) print statement for debugging the testitself. This patch adds a new trace method to lldbtest to reuse theexisting tracing infrastructure and replace these print statements.Differential revision: https://reviews.llvm.org/D80448
[lldb/Test] Skip more tests that are not expected to work with passive replayThis skips some tests that pass with active replay (which doesn't checkthe output) but fail with passive replay. Valid
[lldb/Test] Skip more tests that are not expected to work with passive replayThis skips some tests that pass with active replay (which doesn't checkthe output) but fail with passive replay. Valid reasons for thisinclude: - Checking the output of the process (which doesn't run during replay), - Checking files that cannot be captured in the VFS (non-existing or unreadable files or files that are removed during test),Unfortunately there's no good way to mark a test as supported for activereplay but unsupported for passive replay because the number and orderof API calls needs to be identical during capture and replay. I don'tthink this is a huge loss however.
[lldb/test] Fix wrong target command failure message on WindowsThis patch fixes the test failure happening on Windows introduced by`015117411e11458f9816ba4359246132164a4297`.Since the failure me
[lldb/test] Fix wrong target command failure message on WindowsThis patch fixes the test failure happening on Windows introduced by`015117411e11458f9816ba4359246132164a4297`.Since the failure message comes from the OS, the test needs to support bothUNIX and Windows messages.Signed-off-by: Med Ismail Bennani <[email protected]>
[lldb/Host] Improve error messages on unowned read filesWhen trying to read a core file that is not owned by the user running lldband that doesn't have read permission on the file, lldb shows a mi
[lldb/Host] Improve error messages on unowned read filesWhen trying to read a core file that is not owned by the user running lldband that doesn't have read permission on the file, lldb shows a misleadingerror message:```Unable to find process plug-in for core file```This is due to the fact that currently, lldb doesn't check the fileownership. And when trying to to open and read a core file, the syscallfails, which prevents a process to be created.Since lldb already have a portable `open` syscall interface, lets takeadvantage of that and delegate the error handling to the syscallitself. This way, no matter if the file exists or if the user has properownership, lldb will always try to open the file, and behave accordinglyto the error code returned.rdar://42630030https://reviews.llvm.org/D78712Signed-off-by: Med Ismail Bennani <[email protected]>
[lldb] Remove license headers from all test source filesSummary:Around a third of our test sources have LLVM license headers. This patch removes those headers from all testsources and also fixes
[lldb] Remove license headers from all test source filesSummary:Around a third of our test sources have LLVM license headers. This patch removes those headers from all testsources and also fixes any tests that depended on the length of the license header.The reasons for this are:* A few tests verify line numbers and will start failing if the number of lines in the LLVM license header changes. Once I landed my patch for valid SourceLocations in debug info we will probably have even more tests that verify line numbers.* No other LLVM project is putting license headers in its test files to my knowledge.* They make the test sources much more verbose than they have to be. Several tests have longer license headers than the actual test source.For the record, the following tests had their line numbers changed to pass with the removal of the license header: lldb-api :: functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py lldb-shell :: Reproducer/TestGDBRemoteRepro.test lldb-shell :: Reproducer/TestMultipleTargets.test lldb-shell :: Reproducer/TestReuseDirectory.test lldb-shell :: ExecControl/StopHook/stop-hook-threads.test lldb-shell :: ExecControl/StopHook/stop-hook.test lldb-api :: lang/objc/exceptions/TestObjCExceptions.pyReviewers: #lldb, espindola, JDevlieghereReviewed By: #lldb, JDevlieghereSubscribers: emaste, aprantl, arphaman, JDevlieghere, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D74839
[lldb] Remove some unnecessary includes from test sources
[TestTargetCommand] Remove another reference to a stale rdar.The test passes, and the rdar is closed.
[TestTargetCommand] `target var` without a process doesn't work on arm64e.lldb needs to know about chains of authenticated relocations.<rdar://problem/37773624>
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdi
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdir -p lldb/test/API/{test_runner/test,tools/lldb-{server,vscode}}mv lldb/packages/Python/lldbsuite/test/test_runner/test lldb/test/API/test_runnerfor d in $(find lldb/packages/Python/lldbsuite/test/* -maxdepth 0 -type d | egrep -v "make|plugins|test_runner|tools"); do mv $d lldb/test/API; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-vscode -maxdepth 1 -mindepth 1 | grep -v ".py"); do mv $d lldb/test/API/tools/lldb-vscode; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-server -maxdepth 1 -mindepth 1 | egrep -v "gdbremote_testcase.py|lldbgdbserverutils.py|socket_packet_pump.py"); do mv $d lldb/test/API/tools/lldb-server; done```lldb/packages/Python/lldbsuite/__init__.py and lldb/test/API/lit.cfg.py were also updated with the new directory structure.Reviewers: labath, JDevlieghereTags: #lldbDifferential Revision: https://reviews.llvm.org/D71151