Fix "settings set -g" so it works again.When we switched options over to use the Options.td file, a bug was introduced that caused the "-g" option for "settings set" to require a filename arguemnt.
Fix "settings set -g" so it works again.When we switched options over to use the Options.td file, a bug was introduced that caused the "-g" option for "settings set" to require a filename arguemnt. This patch fixes this issue and adds a test so this doesn't regress.Reviewed By: JDevlieghereDifferential Revision: https://reviews.llvm.org/D116012
show more ...
[lldb] Fix TestEchoCommands.test againIn 7f01f78593d6 [lldb] update TestEchoCommands -- I fixed this test,but not on windows, becuase I used some unix shell syntax thatdoesn't work with cmd.exe.
[lldb] Fix TestEchoCommands.test againIn 7f01f78593d6 [lldb] update TestEchoCommands -- I fixed this test,but not on windows, becuase I used some unix shell syntax thatdoesn't work with cmd.exe. Fixed it so it will work in both.Test logic is the same.This is a trivial fix, so bypassing review to get the build clean againASAP.
[lldb] update TestEchoCommandsFollowup to https://reviews.llvm.org/D112988Sorry, I broke this test. The test was verifying the bad behaviorof --source-quietly that the previous change fixed --
[lldb] update TestEchoCommandsFollowup to https://reviews.llvm.org/D112988Sorry, I broke this test. The test was verifying the bad behaviorof --source-quietly that the previous change fixed -- namely thatit still echos the initial list of startup commands whilesourcing them.Updated the test to verify that --source-quietly is quiet, rather thanloud.Reviewed By: JDevlieghereDifferential Revision: https://reviews.llvm.org/D113047
[lldb] Fix that symbols.clang-modules-cache-path is never initializedLLDB is supposed to ask the Clang Driver what the default module cache path isand then use that value as the default for the`s
[lldb] Fix that symbols.clang-modules-cache-path is never initializedLLDB is supposed to ask the Clang Driver what the default module cache path isand then use that value as the default for the`symbols.clang-modules-cache-path` setting. However, we use the property type`String` to change `symbols.clang-modules-cache-path` even though the type ofthat setting is `FileSpec`, so the setter will simply do nothing and return`false`. We also don't check the return value of the setter, so this whole codeends up not doing anything at all.This changes the setter to use the correct property type and adds an assert thatwe actually successfully set the default path. Also adds a test that checks thatthe default value for this setting is never unset/empty path as this wouldeffectively disable the import-std-module feature from working by default.Reviewed By: JDevlieghere, shafikDifferential Revision: https://reviews.llvm.org/D92772
[lldb/Driver] Exit with a non-zero exit code in case of error in batch mode.We have the option to stop running commands in batch mode when an erroroccurs. When that happens we should exit the driv
[lldb/Driver] Exit with a non-zero exit code in case of error in batch mode.We have the option to stop running commands in batch mode when an erroroccurs. When that happens we should exit the driver with a non-zero exitcode.Differential revision: https://reviews.llvm.org/D78825
[lldb] Color the line markerHighlight the color marker similar to what we do for the column marker.The default color matches the color of the current PC marker (->) in thedefault disassembly form
[lldb] Color the line markerHighlight the color marker similar to what we do for the column marker.The default color matches the color of the current PC marker (->) in thedefault disassembly format.Differential revision: https://reviews.llvm.org/D75070
[lldb/Test] Update TestDisassemblyFormat for new format
[FormatEntity] Add mangled function name supportSummary:Add `function.mangled-name` key for FormatEntity to show the mangledfunction names in backtraces.rdar://54088244Signed-off-by: Med Isma
[FormatEntity] Add mangled function name supportSummary:Add `function.mangled-name` key for FormatEntity to show the mangledfunction names in backtraces.rdar://54088244Signed-off-by: Med Ismail Bennani <[email protected]>Subscribers: lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D71237Signed-off-by: Med Ismail Bennani <[email protected]>
[lldb/lit] Introduce %clang_host substitutionsSummary:This patch addresses an ambiguity in how our existing tests invoke thecompiler. Roughly two thirds of our current "shell" tests invoke theco
[lldb/lit] Introduce %clang_host substitutionsSummary:This patch addresses an ambiguity in how our existing tests invoke thecompiler. Roughly two thirds of our current "shell" tests invoke thecompiler to build the executables for the host. However, there is alsoa significant number of tests which don't build a host binary (becausethey don't need to run it) and instead they hardcode a certain target.We also have code which adds a bunch of default arguments to the %clangsubstitutions. However, most of these arguments only really make sensefor the host compilation. So far, this has worked mostly ok, because thearguments we were adding were not conflicting with the target-hardcodingtests (though they did provoke an occasional "argument unused" warning).However, this started to break down when we wanted to usetarget-hardcoding clang-cl tests (D69031) because clang-cl has asubstantially different command line, and it was getting very confusedby some of the arguments we were adding on non-windows hosts.This patch avoid this problem by creating separate %clang(xx,_cl)_hostsubstutitions, which are specifically meant to be used for compilinghost binaries. All funny host-specific options are moved there. Toensure that the regular %clang substitutions are not used for compilinghost binaries (skipping the extra arguments) I employ a littlehac^H^H^Htrick -- I add an invalid --target argument to the %clangsubstitution, which means that one has to use an explicit --target inorder for the compilation to succeed.Reviewers: JDevlieghere, aprantl, mstorsjo, espindolaSubscribers: emaste, arichardson, MaskRay, jfb, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D69619
Re-land "[test] Split LLDB tests into API, Shell & Unit"The original patch got reverted because it broke `check-lldb` on a cleanbuild. This fixes that.llvm-svn: 374201
Revert [test] Split LLDB tests into API, Shell & Unitas it appears to have broken check-lldb.This reverts r374184 (git commit 22314179f0660c172514b397060fd8f34b586e82)llvm-svn: 374187
[test] Split LLDB tests into API, Shell & UnitLLDB has three major testing strategies: unit tests, tests that exercisethe SB API though dotest.py and what we currently call lit tests. Thelater is
[test] Split LLDB tests into API, Shell & UnitLLDB has three major testing strategies: unit tests, tests that exercisethe SB API though dotest.py and what we currently call lit tests. Thelater is rather confusing as we're now using lit as the driver for allthree types of tests. As most of this grew organically, the directorystructure in the LLDB repository doesn't really make this clear.The 'lit' tests are part of the root and among these tests there's aUnit and Suite folder for the unit and dotest-tests. This layout makesit impossible to run just the lit tests.This patch changes the directory layout to match the 3 testingstrategies, each with their own directory and their own configurationfile. This means there are now 3 directories under lit with 3corresponding targets: - API (check-lldb-api): Test exercising the SB API. - Shell (check-lldb-shell): Test exercising command line utilities. - Unit (check-lldb-unit): Unit tests.Finally, there's still the `check-lldb` target that runs all three testsuites.Finally, this also renames the lit folder to `test` to match the LLVMrepository layout.Differential revision: https://reviews.llvm.org/D68606llvm-svn: 374184