[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://r
[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://reviews.llvm.org/D128077
show more ...
[lldb] Remove support for replaying the test suite from a reproducerThis patch removes the infrastructure to replay the test suite from areproducer, as well as the modifications made to the indivi
[lldb] Remove support for replaying the test suite from a reproducerThis patch removes the infrastructure to replay the test suite from areproducer, as well as the modifications made to the individual tests.
[lldb] Use file to synchronize TestDeepBundle and TestBundleWithDotInFilenameCurrently these two tests use an arbitrary wait of 5 seconds for theinferior to finish setting up. When the test machin
[lldb] Use file to synchronize TestDeepBundle and TestBundleWithDotInFilenameCurrently these two tests use an arbitrary wait of 5 seconds for theinferior to finish setting up. When the test machine is under heavy loadthis sometimes is insufficient leading to spurious test failures. Thispatch adds synchronization trough a token on the file system. Inaddition to making the test more reliable it also makes it much fasterbecause we no longer have to wait the full 5 seconds if the setup wascompleted faster than that.Differential revision: https://reviews.llvm.org/D85915
[lldb/Test] Always set the cleanupSubprocesses tear down hookAlways clean up subprocesses on tear down instead of relying on thecaller to do so. This is not only less error prone but also means th
[lldb/Test] Always set the cleanupSubprocesses tear down hookAlways clean up subprocesses on tear down instead of relying on thecaller to do so. This is not only less error prone but also means thetests can be more concise.Differential revision: https://reviews.llvm.org/D83787
Repair support for launching ios/tv/watch simulator binaries through platformand delete a bunch (but not all) redundant code. If you compare the remaining implementations of Platform*Simulator.cpp,
Repair support for launching ios/tv/watch simulator binaries through platformand delete a bunch (but not all) redundant code. If you compare the remaining implementations of Platform*Simulator.cpp, there is still an obvious leftover cleanup task.Specifically, this patch- removes SDK initialization from dotest (there is equivalent but more complete code in Makefile.rules)- make Platform*Simulator inherit the generic implementation of PlatformAppleSimulator (more can be done here)- simplify the platform logic in Makefile.rules- replace the custom SDK finding logic in Platform*Simulator with XcodeSDK- adds a test for each supported simulatorDifferential Revision: https://reviews.llvm.org/D81980
[lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suiteSummary:The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely usel
[lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suiteSummary:The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely useless for actually debugging the issue.This patch is just replacing this construct (and similar ones like `assertTrue(a != b, ...)` with the proper call to assertEqual or assertNotEquals.This patch was mostly written by a shell script with some manual verification afterwards:```lang=pythonimport sysdef sanitize_line(line): if line.strip().startswith("self.assertTrue(") and " == " in line: line = line.replace("self.assertTrue(", "self.assertEquals(") line = line.replace(" == ", ", ", 1) if line.strip().startswith("self.assertTrue(") and " != " in line: line = line.replace("self.assertTrue(", "self.assertNotEqual(") line = line.replace(" != ", ", ", 1) return linefor a in sys.argv[1:]: with open(a, "r") as f: lines = f.readlines() with open(a, "w") as f: for line in lines: f.write(sanitize_line(line))```Reviewers: labath, JDevlieghereReviewed By: labathSubscribers: abidh, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D74475
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdi
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdir -p lldb/test/API/{test_runner/test,tools/lldb-{server,vscode}}mv lldb/packages/Python/lldbsuite/test/test_runner/test lldb/test/API/test_runnerfor d in $(find lldb/packages/Python/lldbsuite/test/* -maxdepth 0 -type d | egrep -v "make|plugins|test_runner|tools"); do mv $d lldb/test/API; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-vscode -maxdepth 1 -mindepth 1 | grep -v ".py"); do mv $d lldb/test/API/tools/lldb-vscode; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-server -maxdepth 1 -mindepth 1 | egrep -v "gdbremote_testcase.py|lldbgdbserverutils.py|socket_packet_pump.py"); do mv $d lldb/test/API/tools/lldb-server; done```lldb/packages/Python/lldbsuite/__init__.py and lldb/test/API/lit.cfg.py were also updated with the new directory structure.Reviewers: labath, JDevlieghereTags: #lldbDifferential Revision: https://reviews.llvm.org/D71151