[utils] Don't print username in arcanist clang format messageI didn't realise this message was also posted to the phabricator review.Just say "the user's local path". "local" is the important par
[utils] Don't print username in arcanist clang format messageI didn't realise this message was also posted to the phabricator review.Just say "the user's local path". "local" is the important part,the username is not important.
show more ...
[Utils] Use whoami to get username for arcanist warning message959eec1fddc83c90c208789f20cb6573b2a20642 changed the messageto show the local username with "$user" but this is not always set.Some
[Utils] Use whoami to get username for arcanist warning message959eec1fddc83c90c208789f20cb6573b2a20642 changed the messageto show the local username with "$user" but this is not always set.Some systems will have USER/USERNAME/LOGNAME, so just use "whoami"instead.
[NFC] Give better diagnose on clang-format not found errorContributors often confused by whether this is a server or local issue.
Fix arc lint's clang-format rule: only format the file we were asked to format.This avoids diffs being applied in the work tree to files that aresupposed to be excluded (clang tests), allows arc t
Fix arc lint's clang-format rule: only format the file we were asked to format.This avoids diffs being applied in the work tree to files that aresupposed to be excluded (clang tests), allows arc to properly provideinteractive feedback for the formatting fixes, and reduces the number offiles that we format, in a change affecting N files, from N^2 to N.
Use in-tree clang-format-diff.py as Arcanist linterSummary:The only guarantee there seems to be in the clang-format packaging isthat an executable called `clang-format` is in the PATH. Use thein
Use in-tree clang-format-diff.py as Arcanist linterSummary:The only guarantee there seems to be in the clang-format packaging isthat an executable called `clang-format` is in the PATH. Use thein-tree `clang-format-diff.py` to avoid assuming anything else.Also remove dead code for SVN repo and switch to `git diff-index` whichis the git plumbing equivalent of `git diff` in this case.Reviewers: starsid, mehdi_amini, vitalybuka, fhahn, kadircetSubscribers: llvm-commitsTags: #llvmDifferential Revision: https://reviews.llvm.org/D77428
Revert "Use git-clang-format as Arcanist linter"This reverts commit 31b6e182f2ce957c86b961e21b9eb82bbcea7c59.As it was breaking `arc diff` workflow for multiple people.
Use --style file instead of --style LLVMLLVM includes .clang-format files which must be respected.
Use git-clang-format as Arcanist linterD49116 was using clang-format-diff because at the time of its writing,it needed to handle the subversion repo as well.Differential Revision: https://review
Use git-clang-format as Arcanist linterD49116 was using clang-format-diff because at the time of its writing,it needed to handle the subversion repo as well.Differential Revision: https://reviews.llvm.org/D77363
Setup clang-format as an Arcanist linterSummary:This uses clang-format-diff as a linter for Arcanist.`arc lint` flow, also run as part of `arc diff` unless skipped with`--nolint`, will now run
Setup clang-format as an Arcanist linterSummary:This uses clang-format-diff as a linter for Arcanist.`arc lint` flow, also run as part of `arc diff` unless skipped with`--nolint`, will now run the linter shell script on the changed files,and prompt the user to accept the suggested changes.Message when clang-format-diff is not installed:{F6654094}Example of the noise during code review when clang-format-diff is not installed:https://reviews.llvm.org/differential/changeset/?ref=1115809Prompt when clang-format-diff is installed and suggests edits:{F6650223}Reviewers: probinson, scott.linderReviewed By: scott.linderSubscribers: scott.linder, MyDeveloperDay, JonasToth, danilaml, JDevlieghere, dberris, llvm-commitsTags: #llvmDifferential Revision: https://reviews.llvm.org/D49116