[mlir][spirv] Replace StructAttrs with AttrDefsDepends on D127370Reviewed By: antiagainstDifferential Revision: https://reviews.llvm.org/D127373
[mlir][spirv] Fix capability check for 64-bit element typesUsing 64-bit integer/float type in interface storage classes wouldrequire Int64/Float64 capability, per the Vulkan spec:```shaderInt64
[mlir][spirv] Fix capability check for 64-bit element typesUsing 64-bit integer/float type in interface storage classes wouldrequire Int64/Float64 capability, per the Vulkan spec:```shaderInt64 specifies whether 64-bit integers (signed and unsigned) aresupported in shader code. If this feature is not enabled, 64-bit integertypes must not be used in shader code. This also specifies whethershader modules can declare the Int64 capability. Declaring and using64-bit integers is enabled for all storage classes that SPIR-V allowswith the Int64 capability.```This is different from, say, 16-bit element types, where:```shaderInt16 specifies whether 16-bit integers (signed and unsigned) aresupported in shader code. If this feature is not enabled, 16-bit integertypes must not be used in shader code. This also specifies whethershader modules can declare the Int16 capability. However, this onlyenables a subset of the storage classes that SPIR-V allows for the Int16SPIR-V capability: Declaring and using 16-bit integers in the Private,Workgroup (for non-Block variables), and Function storage classes isenabled, while declaring them in the interface storage classes (e.g.,UniformConstant, Uniform, StorageBuffer, Input, Output, andPushConstant) is not enabled.```Reviewed By: hanchungDifferential Revision: https://reviews.llvm.org/D126256
show more ...
[mlir][spirv] Remove layout decoration on unneeded storage classesPer SPIR-V validation rules, explict layout decorations are onlyneeded for StorageBuffer, PhysicalStorageBuffer, Uniform, andPush
[mlir][spirv] Remove layout decoration on unneeded storage classesPer SPIR-V validation rules, explict layout decorations are onlyneeded for StorageBuffer, PhysicalStorageBuffer, Uniform, andPushConstant storage classes. (And even that is for Shadercapabilities). So we don't need such decorations on the rest.Reviewed By: hanchungDifferential Revision: https://reviews.llvm.org/D124543
[mlir][NFC] Update textual references of `func` to `func.func` in Conversion/ testsThe special case parsing of `func` operations is being removed.
[mlir][spirv] Convert func.call to spv.FunctionCallDifferential Revision: https://reviews.llvm.org/D122368
[mlir][SPIRV] Split up StandardToSPIRV now that the Standard dialect is goneStandardToSPIRV currently contains an assortment of patterns converting fromdifferent dialects to SPIRV. This commit spl
[mlir][SPIRV] Split up StandardToSPIRV now that the Standard dialect is goneStandardToSPIRV currently contains an assortment of patterns converting fromdifferent dialects to SPIRV. This commit splits up StandardToSPIRV into separateconversions for each of the dialects involved (some of which already exist).Differential Revision: https://reviews.llvm.org/D120767