[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://r
[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://reviews.llvm.org/D128077
show more ...
Fix runInTerminal failures on Windowsstella.stemenova mentioned in https://reviews.llvm.org/D93951 failures on Windows for this test.I'm fixing the macro definitions and disabling the tests for p
Fix runInTerminal failures on Windowsstella.stemenova mentioned in https://reviews.llvm.org/D93951 failures on Windows for this test.I'm fixing the macro definitions and disabling the tests for pythonversions lower than 3.7. I'll figure out that actual issue withpython3.6 after the buildbots are fine again.
Fix runInTerminal errors on ARMCaused by https://reviews.llvm.org/D93951This feature is not needed on ARM, so let's just disable the tests onARM.
Fix 0f0462cacf34aa88ae71a13c4199c1b1e70f3ee6This test fails on ARM, but this feature won't be used on ARM, so we candisable it for that architecture.
[vscode] Improve runInTerminal and support linuxDepends on D93874.runInTerminal was using --wait-for, but it was some problems because it uses process polling looking for a single instance of the
[vscode] Improve runInTerminal and support linuxDepends on D93874.runInTerminal was using --wait-for, but it was some problems because it uses process polling looking for a single instance of the debuggee:- it gets to know of the target late, which renders breakpoints in the main function almost impossible- polling might fail if there are already other processes with the same name- polling might also fail on some linux machine, as it's implemented with the ps command, and the ps command's args and output are not standard everywhereAs a better way to implement this so that it works well on Darwin and Linux, I'm using now the following process:- lldb-vscode notices the runInTerminal, so it spawns lldb-vscode with a special flag --launch-target <target>. This flags tells lldb-vscode to wait to be attached and then it execs the target program. I'm using lldb-vscode itself to do this, because it makes finding the launcher program easier. Also no CMAKE INSTALL scripts are needed.- Besides this, the debugger creates a temporary FIFO file where the launcher program will write its pid to. That way the debugger will be sure of which program to attach.- Once attach happend, the debugger creates a second temporary file to notify the launcher program that it has been attached, so that it can then exec. I'm using this instead of using a signal or a similar mechanism because I don't want the launcher program to wait indefinitely to be attached in case the debugger crashed. That would pollute the process list with a lot of hanging processes. Instead, I'm setting a 20 seconds timeout (that's an overkill) and the launcher program seeks in intervals the second tepmorary file.Some notes:- I preferred not to use sockets because it requires a lot of code and I only need a pid. It would also require a lot of code when windows support is implemented.- I didn't add Windows support, as I don't have a windows machine, but adding support for it should be easy, as the FIFO file can be implemented with a named pipe, which is standard on Windows and works pretty much the same way.The existing test which didn't pass on Linux, now passes.Differential Revision: https://reviews.llvm.org/D93951
Retry of D84974- Fix a small issue caused by a conflicting name (GetObject) on Windows. The fix was to rename the internal GetObject function to GetNextFunction.
Revert "Retry of D84974"This reverts commit 5b2b4f331d78f326e5e29166bec5ad92c864343d.This caused a link error inhttp://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/18794/steps/build/
Revert "Retry of D84974"This reverts commit 5b2b4f331d78f326e5e29166bec5ad92c864343d.This caused a link error inhttp://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/18794/steps/build/logs/stdio
Retry of D84974The test is being disabled on Linux, as lldb-vscode has a bug with--wait-for on LInux.I'm also fixing some compilation warnings.
Revert de6caf871be79dc7549aebe4e4fb57d52f6ed202 and 51128b670d4f757132e927c4f3dd78d257d37f70 (https://reviews.llvm.org/D84974)The tests seem to be timing out in all linux bots. Need further analysi
Revert de6caf871be79dc7549aebe4e4fb57d52f6ed202 and 51128b670d4f757132e927c4f3dd78d257d37f70 (https://reviews.llvm.org/D84974)The tests seem to be timing out in all linux bots. Need further analysis.Revert "run in terminal"This reverts commit de6caf871be79dc7549aebe4e4fb57d52f6ed202.
run in terminal