[lldb] Expand $ when using tcshUnlike for any of the other shells, we were escaping $ when using tcsh.There's nothing special about $ in tcsh and this prevents you fromexpanding shell variables,
[lldb] Expand $ when using tcshUnlike for any of the other shells, we were escaping $ when using tcsh.There's nothing special about $ in tcsh and this prevents you fromexpanding shell variables, one of the main reasons this functionalityexists in the first place.Differential revision: https://reviews.llvm.org/D123690
show more ...
[lldb] Replace TestAbortExitCode with a debugserver specific testWhen I added TestAbortExitCode I actually planned this to be a generic test for theexit code functionality on POSIX systems. Howeve
[lldb] Replace TestAbortExitCode with a debugserver specific testWhen I added TestAbortExitCode I actually planned this to be a generic test for theexit code functionality on POSIX systems. However due to all the different test setups wecan have I don't think this worked out. Right now the test had to be made so permissivethat it pretty much can't fail.Just to summarize, we would need to support the following situations:1. ToT debugserver (on macOS)2. lldb-server (on other platforms)3. Any old debugserver version when using the system debugserver (on macOS)This patch is removing TestAbortExitCode and adds a ToT debugserver specific testthat checks the patch that motivated the whole exit code testing. There is alreadyan exit-code test for lldb-server from what I can see and 3) is pretty much untestableas we don't know anything about the system debugserver.Reviewed By: kastiglioneDifferential Revision: https://reviews.llvm.org/D89305
[debugserver] Fix that debugserver's stop reply packets always return signal code 0If our process terminates due to an unhandled signal, we are supposed to get thesignal code via WTERMSIG. However
[debugserver] Fix that debugserver's stop reply packets always return signal code 0If our process terminates due to an unhandled signal, we are supposed to get thesignal code via WTERMSIG. However, we instead try to get the exit status viaWEXITSTATUS which just ends up always calculating signal code 0 (at least on themacOS implementation where it just shifts the signal code bits away and we'releft with only 0 bits).The exit status calculation on the LLDB side also seems a bit off as it claimsan exit status that is just the signal code (instead of for example 128 + signalcode), but that will be another patch.Reviewed By: jasonmolendaDifferential Revision: https://reviews.llvm.org/D86336
Print a warning when stopped in a frame LLDB has no plugin for.This patchs adds an optional warning that is printed when stopped at aframe that was compiled in a source language that LLDB has no p
Print a warning when stopped in a frame LLDB has no plugin for.This patchs adds an optional warning that is printed when stopped at aframe that was compiled in a source language that LLDB has no pluginfor.The motivational use-case is debugging Swift code on Linux. When theuser accidentally invokes the system LLDB that was built without theSwift plugin, it is very much non-obvious why debugging doesntwork. This warning makes it easy to figure out what went wrong.<rdar://problem/56986569>
Re-land "[test] Split LLDB tests into API, Shell & Unit"The original patch got reverted because it broke `check-lldb` on a cleanbuild. This fixes that.llvm-svn: 374201
Revert [test] Split LLDB tests into API, Shell & Unitas it appears to have broken check-lldb.This reverts r374184 (git commit 22314179f0660c172514b397060fd8f34b586e82)llvm-svn: 374187
[test] Split LLDB tests into API, Shell & UnitLLDB has three major testing strategies: unit tests, tests that exercisethe SB API though dotest.py and what we currently call lit tests. Thelater is
[test] Split LLDB tests into API, Shell & UnitLLDB has three major testing strategies: unit tests, tests that exercisethe SB API though dotest.py and what we currently call lit tests. Thelater is rather confusing as we're now using lit as the driver for allthree types of tests. As most of this grew organically, the directorystructure in the LLDB repository doesn't really make this clear.The 'lit' tests are part of the root and among these tests there's aUnit and Suite folder for the unit and dotest-tests. This layout makesit impossible to run just the lit tests.This patch changes the directory layout to match the 3 testingstrategies, each with their own directory and their own configurationfile. This means there are now 3 directories under lit with 3corresponding targets: - API (check-lldb-api): Test exercising the SB API. - Shell (check-lldb-shell): Test exercising command line utilities. - Unit (check-lldb-unit): Unit tests.Finally, there's still the `check-lldb` target that runs all three testsuites.Finally, this also renames the lit folder to `test` to match the LLVMrepository layout.Differential revision: https://reviews.llvm.org/D68606llvm-svn: 374184