[lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbersThe requirements for "thread until <line number>" are:a) If any code contributed by <line number> or the nearest sub
[lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbersThe requirements for "thread until <line number>" are:a) If any code contributed by <line number> or the nearest subsequent of <line number> is executed before leaving the function, stopb) If you end up leaving the function w/o triggering (a), then stopIn case of (a), since the <line number> may have multiple entries in the line table and the compiler might have scheduled/moved the relevant code across, and the lldb does not know the control flow, set breakpoints on all the line table entries of best match of <line number> i.e. exact or the nearest subsequent line.Along with the above, currently, CommandObjectThreadUntil is also setting the breakpoints on all the subsequent line numbers after the best match and this latter part is wrong.This issue is discussed at http://lists.llvm.org/pipermail/lldb-dev/2018-August/013979.html.In fact, currently `TestStepUntil.py` is not actually testing step until scenarios and `test_missing_one` test fails without this patch if tests are made to run. Fixed the test as well.Reviewed By: jinghamDifferential Revision: https://reviews.llvm.org/D50304
show more ...
Revert "[lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers"This reverts commit a57b62deef37c7f2ec31bca3bf9173a6206bfb9b.lldb-aarch64-ubuntu buildbot test fails since
Revert "[lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers"This reverts commit a57b62deef37c7f2ec31bca3bf9173a6206bfb9b.lldb-aarch64-ubuntu buildbot test fails since https://lab.llvm.org/buildbot/#/builders/96/builds/25128
[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://r
[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://reviews.llvm.org/D128077
[lldb] [test] Rename '.categories' to 'categories'Make category-specifying files visible. There is really no good reasonto keep them hidden, and having them visible increases the chancesthat som
[lldb] [test] Rename '.categories' to 'categories'Make category-specifying files visible. There is really no good reasonto keep them hidden, and having them visible increases the chancesthat someone will actually spot them.Differential Revision: https://reviews.llvm.org/D91065
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdi
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdir -p lldb/test/API/{test_runner/test,tools/lldb-{server,vscode}}mv lldb/packages/Python/lldbsuite/test/test_runner/test lldb/test/API/test_runnerfor d in $(find lldb/packages/Python/lldbsuite/test/* -maxdepth 0 -type d | egrep -v "make|plugins|test_runner|tools"); do mv $d lldb/test/API; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-vscode -maxdepth 1 -mindepth 1 | grep -v ".py"); do mv $d lldb/test/API/tools/lldb-vscode; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-server -maxdepth 1 -mindepth 1 | egrep -v "gdbremote_testcase.py|lldbgdbserverutils.py|socket_packet_pump.py"); do mv $d lldb/test/API/tools/lldb-server; done```lldb/packages/Python/lldbsuite/__init__.py and lldb/test/API/lit.cfg.py were also updated with the new directory structure.Reviewers: labath, JDevlieghereTags: #lldbDifferential Revision: https://reviews.llvm.org/D71151