[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://r
[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://reviews.llvm.org/D128077
show more ...
Fix buildbots after https://reviews.llvm.org/D120755.This improves this test a lot because before when using the "attachCommands" to run the following commands:(lldb) target create -d /path/to/a.
Fix buildbots after https://reviews.llvm.org/D120755.This improves this test a lot because before when using the "attachCommands" to run the following commands:(lldb) target create -d /path/to/a.out(lldb) process launchThis was racy as it wasn't stopping the program at the entry point, and the process might run to completion before we can even debug it. With the recent changes to the "attachCommands" we were waiting for the process to stop, but the process might be exited already, and that _should_ have caused the attach to fail since there was no process to attach to. By adding "--stop-at-entry" to the process launch, we ensure this should be less racy and give us a valid process to attach to.
[lldb-vscode] Add postRunCommandsThis diff ass postRunCommands, which are the counterpart of the preRunCommands. TThey will be executed right after the target is launched or attached correctly, whi
[lldb-vscode] Add postRunCommandsThis diff ass postRunCommands, which are the counterpart of the preRunCommands. TThey will be executed right after the target is launched or attached correctly, which means that the targets can assume that the target is running.Differential Revision: https://reviews.llvm.org/D100340
[lldb-vscode] Speculative fix for raciness in TestVSCode_attachThe test appears to expect the inferior to be stopped, but the custom"attach commands" leave it in a running state.It's unclear how
[lldb-vscode] Speculative fix for raciness in TestVSCode_attachThe test appears to expect the inferior to be stopped, but the custom"attach commands" leave it in a running state.It's unclear how this could have ever worked.
[lldb/Test] Always set the cleanupSubprocesses tear down hookAlways clean up subprocesses on tear down instead of relying on thecaller to do so. This is not only less error prone but also means th
[lldb/Test] Always set the cleanupSubprocesses tear down hookAlways clean up subprocesses on tear down instead of relying on thecaller to do so. This is not only less error prone but also means thetests can be more concise.Differential revision: https://reviews.llvm.org/D83787
[LLDB] Disable flaky lldb-vscode tests on armSummary:These two tests are flaky on lldb Arm buildbot as well. They are alreadybeing skipped for aarch64. I am going to mark them skipped for Arm.T
[LLDB] Disable flaky lldb-vscode tests on armSummary:These two tests are flaky on lldb Arm buildbot as well. They are alreadybeing skipped for aarch64. I am going to mark them skipped for Arm.Tags: #lldbDifferential Revision: https://reviews.llvm.org/D81978
Disable flaky lldb-vscode tests on aarch64Summary:These two tests are flaky only on this arch for some reason. They are testing important features and are not flaky on x86_64, so I'll investigate
Disable flaky lldb-vscode tests on aarch64Summary:These two tests are flaky only on this arch for some reason. They are testing important features and are not flaky on x86_64, so I'll investigate this arm issue separatedly.Some flaky runs:http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/5517/steps/test/logs/stdiohttp://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/5527/steps/test/logs/stdioDiff that created those tests:https://reviews.llvm.org/D81978
Redo of Add terminateCommands to lldb-vscode protocolSummary:This redoes https://reviews.llvm.org/D79726 and fixes two things.- The logic that determines whether to automatically disconnect durin
Redo of Add terminateCommands to lldb-vscode protocolSummary:This redoes https://reviews.llvm.org/D79726 and fixes two things.- The logic that determines whether to automatically disconnect during the tear down is not very dumb compared to the original implementation. Each test will determine whether to do that or not.- The terminate commands and terminate event were being sent after the disconnect response was sent to the IDE. That was not good, as VSCode stops the debug session as soon as it receives a disconnect response. Now, the terminate event and terminateEvents are being executed before the disconnect response is sent. This ensures that any connection between the IDE and lldb-vscode is alive while the terminate commands are executed. Besides, it also allows displaying the output of the terminate commands on the debug console, as it's still alive.Reviewers: clayborg, aadsm, kusmour, labathSubscribers: lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D81978
Revert "Add terminateCommands to lldb-vscode protocol"This reverts commit a3609b0ec68522cb417ffe36ce9eb2e25ca61578, because itmakes a number of lldb-vscode tests flaky.
Add terminateCommands to lldb-vscode protocolSummary: Adding this in line with "stopCommands" and "exitCommands" so that we can run commands at the end of the debugging session.Reviewers: claybor
Add terminateCommands to lldb-vscode protocolSummary: Adding this in line with "stopCommands" and "exitCommands" so that we can run commands at the end of the debugging session.Reviewers: clayborg, wallace, labathReviewed By: clayborg, labathSubscribers: lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D79726
[lldb] NFC: Fix trivial typo in comments, documents, and messagesDifferential Revision: https://reviews.llvm.org/D77460
[lldb/Test] s/skipIfDarwinEmbedded/skipIfRemote/ in VSCode tests.As pointed out on lldb-commits this skipIfRemote is the better fit forthe decorator.
[lldb/Test] Skip VSCode test on embedded DarwinThese tests are not configured to run on the device.
[lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suiteSummary:The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely usel
[lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suiteSummary:The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely useless for actually debugging the issue.This patch is just replacing this construct (and similar ones like `assertTrue(a != b, ...)` with the proper call to assertEqual or assertNotEquals.This patch was mostly written by a shell script with some manual verification afterwards:```lang=pythonimport sysdef sanitize_line(line): if line.strip().startswith("self.assertTrue(") and " == " in line: line = line.replace("self.assertTrue(", "self.assertEquals(") line = line.replace(" == ", ", ", 1) if line.strip().startswith("self.assertTrue(") and " != " in line: line = line.replace("self.assertTrue(", "self.assertNotEqual(") line = line.replace(" != ", ", ", 1) return linefor a in sys.argv[1:]: with open(a, "r") as f: lines = f.readlines() with open(a, "w") as f: for line in lines: f.write(sanitize_line(line))```Reviewers: labath, JDevlieghereReviewed By: labathSubscribers: abidh, lldb-commitsTags: #lldbDifferential Revision: https://reviews.llvm.org/D74475
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdi
[lldb][test] Remove symlink for API tests.Summary: Moves lldbsuite tests to lldb/test/API.This is a largely mechanical change, moved with the following steps:```rm lldb/test/API/testcasesmkdir -p lldb/test/API/{test_runner/test,tools/lldb-{server,vscode}}mv lldb/packages/Python/lldbsuite/test/test_runner/test lldb/test/API/test_runnerfor d in $(find lldb/packages/Python/lldbsuite/test/* -maxdepth 0 -type d | egrep -v "make|plugins|test_runner|tools"); do mv $d lldb/test/API; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-vscode -maxdepth 1 -mindepth 1 | grep -v ".py"); do mv $d lldb/test/API/tools/lldb-vscode; donefor d in $(find lldb/packages/Python/lldbsuite/test/tools/lldb-server -maxdepth 1 -mindepth 1 | egrep -v "gdbremote_testcase.py|lldbgdbserverutils.py|socket_packet_pump.py"); do mv $d lldb/test/API/tools/lldb-server; done```lldb/packages/Python/lldbsuite/__init__.py and lldb/test/API/lit.cfg.py were also updated with the new directory structure.Reviewers: labath, JDevlieghereTags: #lldbDifferential Revision: https://reviews.llvm.org/D71151