Reapply r336660: [Modules] Autoload subdirectory modulemaps with specific LangOptsSummary:Reproducer and errors:https://bugs.llvm.org/show_bug.cgi?id=37878lookupModule was falling back to loadS
Reapply r336660: [Modules] Autoload subdirectory modulemaps with specific LangOptsSummary:Reproducer and errors:https://bugs.llvm.org/show_bug.cgi?id=37878lookupModule was falling back to loadSubdirectoryModuleMaps when it couldn'tfind ModuleName in (proper) search paths. This was causing iteration over allfiles in the search path subdirectories for example "/usr/include/foobar" inbugzilla case.Users don't expect Clang to load modulemaps in subdirectories implicitly, andalso the disk access is not cheap.if (AllowExtraModuleMapSearch) true with ObjC with @import ModuleName.Reviewers: rsmith, aprantl, brunoSubscribers: cfe-commits, teemperor, v.g.vassilevDifferential Revision: https://reviews.llvm.org/D48367llvm-svn: 337430
show more ...
Revert "[modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts"This reverts commit f40124d4f05ecf4f880cf4e8f26922d861f705f3 / r336660.This change shouldn't be affecting `@im
Revert "[modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts"This reverts commit f40124d4f05ecf4f880cf4e8f26922d861f705f3 / r336660.This change shouldn't be affecting `@import` behavior, but turns out it is:https://ci.swift.org/view/swift-master-next/job/oss-swift-incremental-RA-osx-master-next/2800/consoleFull#-12570166563122a513-f36a-4c87-8ed7-cbc36a1ec144Working on a reduced testcase for this, reverting in the meantime.rdar://problem/42102222llvm-svn: 336920
[modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOptsSummary:Reproducer and errors:https://bugs.llvm.org/show_bug.cgi?id=37878lookupModule was falling back to loadSubdire
[modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOptsSummary:Reproducer and errors:https://bugs.llvm.org/show_bug.cgi?id=37878lookupModule was falling back to loadSubdirectoryModuleMaps when it couldn'tfind ModuleName in (proper) search paths. This was causing iteration over allfiles in the search path subdirectories for example "/usr/include/foobar" inbugzilla case.Users don't expect Clang to load modulemaps in subdirectories implicitly, andalso the disk access is not cheap.if (AllowExtraModuleMapSearch) true with ObjC with @import ModuleName.Reviewers: rsmith, aprantl, brunoSubscribers: cfe-commits, teemperor, v.g.vassilevDifferential Revision: https://reviews.llvm.org/D48367llvm-svn: 336660