drm/nouveau/mxm: switch to instanced constructorSigned-off-by: Ben Skeggs <[email protected]>Reviewed-by: Lyude Paul <[email protected]>
drm/nouveau: Use fallthrough pseudo-keywordReplace the existing /* fall through */ comments and its variants withthe new pseudo-keyword macro fallthrough[1]. Also, remove unnecessaryfall-through
drm/nouveau: Use fallthrough pseudo-keywordReplace the existing /* fall through */ comments and its variants withthe new pseudo-keyword macro fallthrough[1]. Also, remove unnecessaryfall-through markings when it is the case.[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-throughSigned-off-by: Gustavo A. R. Silva <[email protected]>Signed-off-by: Ben Skeggs <[email protected]>
show more ...
drm/nouveau: fix bogus GPL-2 license headerThe bulk SPDX addition made all these files into GPL-2.0 licensed files.However the remainder of the project is MIT-licensed, these fileswere simply mis
drm/nouveau: fix bogus GPL-2 license headerThe bulk SPDX addition made all these files into GPL-2.0 licensed files.However the remainder of the project is MIT-licensed, these fileswere simply missing the boiler plate and got caught up in the global update.Fixes: 96ac6d4351004 (treewide: Add SPDX license identifier - Kbuild)Signed-off-by: Ben Skeggs <[email protected]>
drm/nouveau: fix bogus GPL-2 license headerThe bulk SPDX addition made all these files into GPL-2.0 licensed files.However the remainder of the project is MIT-licensed, these files(primarily head
drm/nouveau: fix bogus GPL-2 license headerThe bulk SPDX addition made all these files into GPL-2.0 licensed files.However the remainder of the project is MIT-licensed, these files(primarily header files) were simply missing the boiler plate and gotcaught up in the global update.Fixes: b24413180f5 (License cleanup: add SPDX GPL-2.0 license identifier to files with no license)Signed-off-by: Ilia Mirkin <[email protected]>Acked-by: Emil Velikov <[email protected]>Acked-by: Karol Herbst <[email protected]>Signed-off-by: Ben Skeggs <[email protected]>
treewide: Add SPDX license identifier - KbuildAdd SPDX license identifiers to all Make/Kconfig files which: - Have no license information of any formThese files fall under the project license,
treewide: Add SPDX license identifier - KbuildAdd SPDX license identifiers to all Make/Kconfig files which: - Have no license information of any formThese files fall under the project license, GPL v2 only. The resulting SPDXlicense identifier is: GPL-2.0Reported-by: Masahiro Yamada <[email protected]>Signed-off-by: Greg Kroah-Hartman <[email protected]>Reviewed-by: Kate Stewart <[email protected]>Signed-off-by: Greg Kroah-Hartman <[email protected]>
drm/nouveau/nvkm: mark expected switch fall-throughsIn preparation to enabling -Wimplicit-fallthrough, mark switch caseswhere we are expecting to fall through.This patch aims to suppress 29 miss
drm/nouveau/nvkm: mark expected switch fall-throughsIn preparation to enabling -Wimplicit-fallthrough, mark switch caseswhere we are expecting to fall through.This patch aims to suppress 29 missing-break-in-switch false positives.Addresses-Coverity-ID: 1456891 ("Missing break in switch")Addresses-Coverity-ID: 1324063 ("Missing break in switch")Addresses-Coverity-ID: 1324063 ("Missing break in switch")Addresses-Coverity-ID: 141432 ("Missing break in switch")Addresses-Coverity-ID: 141433 ("Missing break in switch")Addresses-Coverity-ID: 141434 ("Missing break in switch")Addresses-Coverity-ID: 141435 ("Missing break in switch")Addresses-Coverity-ID: 141436 ("Missing break in switch")Reviewed-by: Kees Cook <[email protected]>Signed-off-by: Gustavo A. R. Silva <[email protected]>
License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine
License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart <[email protected]>Reviewed-by: Philippe Ombredanne <[email protected]>Reviewed-by: Thomas Gleixner <[email protected]>Signed-off-by: Greg Kroah-Hartman <[email protected]>
ACPI: Switch to use generic guid_t in acpi_evaluate_dsm()acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16bytes. Instead we convert them to use guid_t type. At the same time we
ACPI: Switch to use generic guid_t in acpi_evaluate_dsm()acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16bytes. Instead we convert them to use guid_t type. At the same time weconvert current users.acpi_str_to_uuid() becomes useless after the conversion and it's safe toget rid of it.Acked-by: Rafael J. Wysocki <[email protected]>Cc: Borislav Petkov <[email protected]>Acked-by: Dan Williams <[email protected]>Cc: Amir Goldstein <[email protected]>Reviewed-by: Jarkko Sakkinen <[email protected]>Reviewed-by: Jani Nikula <[email protected]>Acked-by: Jani Nikula <[email protected]>Cc: Ben Skeggs <[email protected]>Acked-by: Benjamin Tissoires <[email protected]>Acked-by: Joerg Roedel <[email protected]>Acked-by: Adrian Hunter <[email protected]>Cc: Yisen Zhuang <[email protected]>Acked-by: Bjorn Helgaas <[email protected]>Acked-by: Felipe Balbi <[email protected]>Acked-by: Mathias Nyman <[email protected]>Reviewed-by: Heikki Krogerus <[email protected]>Acked-by: Mark Brown <[email protected]>Signed-off-by: Andy Shevchenko <[email protected]>Signed-off-by: Christoph Hellwig <[email protected]>
drm/nouveau/mxm: warn more loudly on unsupported DCB versionSigned-off-by: Ben Skeggs <[email protected]>
drm/nouveau/mxm: handle DCB 4.1 modificationAllows MXM DCB modification to be handled on GM20x and newer boards.Signed-off-by: Ben Skeggs <[email protected]>
drm/nouveau/mxm: add some extra debug outputSigned-off-by: Ben Skeggs <[email protected]>
drm/nouveau/nouveau: bios pointers may be unaligned, use proper accessorsThis can show up on SPARC or other architectures that don't handleunaligned accesses. The kernel normally fixes these up, b
drm/nouveau/nouveau: bios pointers may be unaligned, use proper accessorsThis can show up on SPARC or other architectures that don't handleunaligned accesses. The kernel normally fixes these up, but it shouldn'thave to.Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96836Signed-off-by: Ilia Mirkin <[email protected]>Signed-off-by: Ben Skeggs <[email protected]>
drm/nouveau/core: remove pmc_enable argument from subdev ctorThese are now specified directly in the MC subdev.Signed-off-by: Ben Skeggs <[email protected]>
drm/nouveau/device: remove pci/platform_device from common structSigned-off-by: Ben Skeggs <[email protected]>
drm/nouveau/mxm: convert to new-style nvkm_subdevSigned-off-by: Ben Skeggs <[email protected]>
drm/nouveau/bios: convert to new-style nvkm_subdevSigned-off-by: Ben Skeggs <[email protected]>
drm/nouveau/i2c: transition pad/ports away from being based on nvkm_objectSigned-off-by: Ben Skeggs <[email protected]>
drm/nouveau/bios: remove object accessor functionsSigned-off-by: Ben Skeggs <[email protected]>
drm/nouveau/mxm: switch to subdev printk macrosSigned-off-by: Ben Skeggs <[email protected]>
drm/nouveau/mxm: cosmetic changesThis is purely preparation for upcoming commits, there should be nocode changes here.Signed-off-by: Ben Skeggs <[email protected]>
drm/nouveau/device: include core/device.h automatically for subdevs/enginesPretty much every subdev/engine is going to need access to nvkm_deviceshortly to touch registers and/or output messages.
drm/nouveau/device: include core/device.h automatically for subdevs/enginesPretty much every subdev/engine is going to need access to nvkm_deviceshortly to touch registers and/or output messages.The odd placement of the includes is necessary to work around someinter-dependencies that currently exist. This will be fixed later.Signed-off-by: Ben Skeggs <[email protected]>
drm/nouveau/mxm: indent an if statementThis if statement is correct but it wasn't indented, so it looked likesome code was missing.Signed-off-by: Dan Carpenter <[email protected]>Signed-
drm/nouveau/mxm: indent an if statementThis if statement is correct but it wasn't indented, so it looked likesome code was missing.Signed-off-by: Dan Carpenter <[email protected]>Signed-off-by: Ben Skeggs <[email protected]>
drm/nouveau: finalise nvkm namespace switch (no binary change)The namespace of NVKM is being changed to nvkm_ instead of nouveau_,which will be used for the DRM part of the driver. This is being
drm/nouveau: finalise nvkm namespace switch (no binary change)The namespace of NVKM is being changed to nvkm_ instead of nouveau_,which will be used for the DRM part of the driver. This is beingdone in order to make it very clear as to what part of the driver agiven symbol belongs to, and as a minor step towards splitting theDRM driver out to be able to stand on its own (for virt).Because there's already a large amount of churn here anyway, this isas good a time as any to also switch to NVIDIA's device and chipsetnaming to ease collaboration with them.A comparison of objdump disassemblies proves no code changes.Signed-off-by: Ben Skeggs <[email protected]>
drm/nouveau: remove symlinks, move core/ to nvkm/ (no code changes)The symlinks were annoying some people, and they're not used anywhereelse in the kernel tree. The include directory structure ha
drm/nouveau: remove symlinks, move core/ to nvkm/ (no code changes)The symlinks were annoying some people, and they're not used anywhereelse in the kernel tree. The include directory structure has beenchanged so that symlinks aren't needed anymore.NVKM has been moved from core/ to nvkm/ to make it more obvious as towhat the directory is for, and as some minor prep for when NVKM getssplit out into its own module (virt) at a later date.Signed-off-by: Ben Skeggs <[email protected]>