ifnet: Replace if_addr_lock rwlock with epoch + mutexRun on LLNW canaries and tested by pho@gallatin:Using a 14-core, 28-HTT single socket E5-2697 v3 with a 40GbE MLX5based ConnectX 4-LX NIC, I
ifnet: Replace if_addr_lock rwlock with epoch + mutexRun on LLNW canaries and tested by pho@gallatin:Using a 14-core, 28-HTT single socket E5-2697 v3 with a 40GbE MLX5based ConnectX 4-LX NIC, I see an almost 12% improvement in receivedpacket rate, and a larger improvement in bytes delivered all the wayto userspace.When the host receiving 64 streams of netperf -H $DUT -t UDP_STREAM -- -m 1,I see, using nstat -I mce0 1 before the patch:InMpps OMpps InGbs OGbs err TCP Est %CPU syscalls csw irq GBfree4.98 0.00 4.42 0.00 4235592 33 83.80 4720653 2149771 1235 247.324.73 0.00 4.20 0.00 4025260 33 82.99 4724900 2139833 1204 247.324.72 0.00 4.20 0.00 4035252 33 82.14 4719162 2132023 1264 247.324.71 0.00 4.21 0.00 4073206 33 83.68 4744973 2123317 1347 247.324.72 0.00 4.21 0.00 4061118 33 80.82 4713615 2188091 1490 247.324.72 0.00 4.21 0.00 4051675 33 85.29 4727399 2109011 1205 247.324.73 0.00 4.21 0.00 4039056 33 84.65 4724735 2102603 1053 247.32After the patchInMpps OMpps InGbs OGbs err TCP Est %CPU syscalls csw irq GBfree5.43 0.00 4.20 0.00 3313143 33 84.96 5434214 1900162 2656 245.515.43 0.00 4.20 0.00 3308527 33 85.24 5439695 1809382 2521 245.515.42 0.00 4.19 0.00 3316778 33 87.54 5416028 1805835 2256 245.515.42 0.00 4.19 0.00 3317673 33 90.44 5426044 1763056 2332 245.515.42 0.00 4.19 0.00 3314839 33 88.11 5435732 1792218 2499 245.525.44 0.00 4.19 0.00 3293228 33 91.84 5426301 1668597 2121 245.52Similarly, netperf reports 230Mb/s before the patch, and 270Mb/s after the patchReviewed by: gallatinSponsored by: Limelight NetworksDifferential Revision: https://reviews.freebsd.org/D15366
show more ...
sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - error
sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - errorprone - task.The Software Package Data Exchange (SPDX) group provides a specificationto make it easier for automated tools to detect and summarize well knownopensource licenses. We are gradually adopting the specification, notingthat the tags are considered only advisory and do not, in any way,superceed or replace the license texts.
ql*_def.h: fix QL_ALIGN parenthesizationQL_ALIGN is a set of copies of roundup2, but it was missing an outer setof parentheses, which began to matter with r324538. Now, fully copy theparenthesiza
ql*_def.h: fix QL_ALIGN parenthesizationQL_ALIGN is a set of copies of roundup2, but it was missing an outer setof parentheses, which began to matter with r324538. Now, fully copy theparenthesization of roundup2.Reviewed by: davidcsDifferential Revision: https://reviews.freebsd.org/D12673
Remove register keyword from sys/ and ANSIfy prototypesA long long time ago the register keyword told the compiler to storethe corresponding variable in a CPU register, but it is not relevantfor
Remove register keyword from sys/ and ANSIfy prototypesA long long time ago the register keyword told the compiler to storethe corresponding variable in a CPU register, but it is not relevantfor any compiler used in the FreeBSD world today.ANSIfy related prototypes while here.Reviewed by: cem, jhbSponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D10193
net: Use M_HASHTYPE_OPAQUE_HASH if the mbuf flowid has hash propertiesReviewed by: hps, erj, tuexenSponsored by: Microsoft OSTCDifferential Revision: https://reviews.freebsd.org/D6688
sys/dev: minor spelling fixes.Most affect comments, very few have user-visible effects.
tcp/lro: Use tcp_lro_flush_all in device drivers to avoid code duplicationAnd factor out tcp_lro_rx_done, which deduplicates the same logic withnetinet/tcp_lro.cReviewed by: gallatin (1st versio
tcp/lro: Use tcp_lro_flush_all in device drivers to avoid code duplicationAnd factor out tcp_lro_rx_done, which deduplicates the same logic withnetinet/tcp_lro.cReviewed by: gallatin (1st version), hps, zbb, np, Dexuan Cui <decui microsoft com>Sponsored by: Microsoft OSTCDifferential Revision: https://reviews.freebsd.org/D5725
CALLOUT_MPSAFE has lost its meaning since r141428, i.e., for more than tenyears for head. However, it is continuously misused as the mpsafe argumentfor callout_init(9). Deprecate the flag and cle
CALLOUT_MPSAFE has lost its meaning since r141428, i.e., for more than tenyears for head. However, it is continuously misused as the mpsafe argumentfor callout_init(9). Deprecate the flag and clean up callout_init() callsto make them more consistent.Differential Revision: https://reviews.freebsd.org/D2613Reviewed by: jhbMFC after: 2 weeks
Start process of removing the use of the deprecated "M_FLOWID" flagfrom the FreeBSD network code. The flag is still kept around in the"sys/mbuf.h" header file, but does no longer have any users. In
Start process of removing the use of the deprecated "M_FLOWID" flagfrom the FreeBSD network code. The flag is still kept around in the"sys/mbuf.h" header file, but does no longer have any users. Insteadthe "m_pkthdr.rsstype" field in the mbuf structure is now used todecide the meaning of the "m_pkthdr.flowid" field. To modify the"m_pkthdr.rsstype" field please use the existing "M_HASHTYPE_XXX"macros as defined in the "sys/mbuf.h" header file.This patch introduces new behaviour in the transmit direction.Previously network drivers checked if "M_FLOWID" was set in "m_flags"before using the "m_pkthdr.flowid" field. This check has now now beenreplaced by checking if "M_HASHTYPE_GET(m)" is different from"M_HASHTYPE_NONE". In the future more hashtypes will be added, forexample hashtypes for hardware dedicated flows."M_HASHTYPE_OPAQUE" indicates that the "m_pkthdr.flowid" value isvalid and has no particular type. This change removes the need for an"if" statement in TCP transmit code checking for the presence of avalid flowid value. The "if" statement mentioned above is now a directvariable assignment which is then later checked by the respectivenetwork drivers like before.Additional notes:- The SCTP code changes will be committed as a separate patch.- Removal of the "M_FLOWID" flag will also be done separately.- The FreeBSD version has been bumped.MFC after: 1 monthSponsored by: Mellanox Technologies
Mechanically convert to if_inc_counter().
Use define from if_var.h to access a field inside struct if_data,that resides in struct ifnet.Sponsored by: Nginx, Inc.
Unload maps for DMA buffers allocated via bus_dmamem_alloc() beforefreeing the buffers.Reviewed by: davidcs
Since 32-bit if_baudrate isn't enough to describe a baud rate of a 10 Gbitinterface, in the r241616 a crutch was provided. It didn't work well, andfinally we decided that it is time to break ABI an
Since 32-bit if_baudrate isn't enough to describe a baud rate of a 10 Gbitinterface, in the r241616 a crutch was provided. It didn't work well, andfinally we decided that it is time to break ABI and simply make if_baudratea 64-bit value. Meanwhile, the entire struct if_data was reviewed.o Remove the if_baudrate_pf crutch.o Make all fields of struct if_data fixed machine independent size. The notion of data (packet counters, etc) are by no means MD. And it is a bug that on amd64 we've got a 64-bit counters, while on i386 32-bit, which at modern speeds overflow within a second. This also removes quite a lot of COMPAT_FREEBSD32 code.o Give 16 bit for the ifi_datalen field. This field was provided to make future changes to if_data less ABI breaking. Unfortunately the 8 bit size of it had effectively limited sizeof if_data to 256 bytes.o Give 32 bits to ifi_mtu and ifi_metric.o Give 64 bits to the rest of fields, since they are counters.__FreeBSD_version bumped.Discussed with: emaxSponsored by: NetflixSponsored by: Nginx, Inc.
Another round of removing historical mbuf(9) allocator flags.They are breeding! New ones arouse since last round.Sponsored by: Nginx, Inc.
Fix undefined behavior: (1 << 31) is not defined as 1 is an int and thisshifts into the sign bit. Instead use (1U << 31) which gets theexpected result.This fix is not ideal as it assumes a 32 bi
Fix undefined behavior: (1 << 31) is not defined as 1 is an int and thisshifts into the sign bit. Instead use (1U << 31) which gets theexpected result.This fix is not ideal as it assumes a 32 bit int, but does fix the issuefor most cases.A similar change was made in OpenBSD.Discussed with: -arch, rdivackyReviewed by: cperciva
Validate the buffer and its length passed to QLA_MPI_DUMP.copyout dump only if qls_mpi_core_dump() is successful.(like to credit x90c for pointing the issue)Submitted by:David C Somayajulu
Include necessary headers that now are available due to pollutionvia if_var.h.Sponsored by: NetflixSponsored by: Nginx, Inc.
Add Qlogic 10Gb Ethernet Driver for Qlogic 8100 Series CNA AdapterDriver version (v2.0.0)Submitted by: David C Somayajulu ([email protected]) QLogic CorporationApproved by: George Neville-Neil
Add Qlogic 10Gb Ethernet Driver for Qlogic 8100 Series CNA AdapterDriver version (v2.0.0)Submitted by: David C Somayajulu ([email protected]) QLogic CorporationApproved by: George Neville-Neil ([email protected])