ifnet: Replace if_addr_lock rwlock with epoch + mutexRun on LLNW canaries and tested by pho@gallatin:Using a 14-core, 28-HTT single socket E5-2697 v3 with a 40GbE MLX5based ConnectX 4-LX NIC, I
ifnet: Replace if_addr_lock rwlock with epoch + mutexRun on LLNW canaries and tested by pho@gallatin:Using a 14-core, 28-HTT single socket E5-2697 v3 with a 40GbE MLX5based ConnectX 4-LX NIC, I see an almost 12% improvement in receivedpacket rate, and a larger improvement in bytes delivered all the wayto userspace.When the host receiving 64 streams of netperf -H $DUT -t UDP_STREAM -- -m 1,I see, using nstat -I mce0 1 before the patch:InMpps OMpps InGbs OGbs err TCP Est %CPU syscalls csw irq GBfree4.98 0.00 4.42 0.00 4235592 33 83.80 4720653 2149771 1235 247.324.73 0.00 4.20 0.00 4025260 33 82.99 4724900 2139833 1204 247.324.72 0.00 4.20 0.00 4035252 33 82.14 4719162 2132023 1264 247.324.71 0.00 4.21 0.00 4073206 33 83.68 4744973 2123317 1347 247.324.72 0.00 4.21 0.00 4061118 33 80.82 4713615 2188091 1490 247.324.72 0.00 4.21 0.00 4051675 33 85.29 4727399 2109011 1205 247.324.73 0.00 4.21 0.00 4039056 33 84.65 4724735 2102603 1053 247.32After the patchInMpps OMpps InGbs OGbs err TCP Est %CPU syscalls csw irq GBfree5.43 0.00 4.20 0.00 3313143 33 84.96 5434214 1900162 2656 245.515.43 0.00 4.20 0.00 3308527 33 85.24 5439695 1809382 2521 245.515.42 0.00 4.19 0.00 3316778 33 87.54 5416028 1805835 2256 245.515.42 0.00 4.19 0.00 3317673 33 90.44 5426044 1763056 2332 245.515.42 0.00 4.19 0.00 3314839 33 88.11 5435732 1792218 2499 245.525.44 0.00 4.19 0.00 3293228 33 91.84 5426301 1668597 2121 245.52Similarly, netperf reports 230Mb/s before the patch, and 270Mb/s after the patchReviewed by: gallatinSponsored by: Limelight NetworksDifferential Revision: https://reviews.freebsd.org/D15366
show more ...
sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - error
sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - errorprone - task.The Software Package Data Exchange (SPDX) group provides a specificationto make it easier for automated tools to detect and summarize well knownopensource licenses. We are gradually adopting the specification, notingthat the tags are considered only advisory and do not, in any way,superceed or replace the license texts.
ql*_def.h: fix QL_ALIGN parenthesizationQL_ALIGN is a set of copies of roundup2, but it was missing an outer setof parentheses, which began to matter with r324538. Now, fully copy theparenthesiza
ql*_def.h: fix QL_ALIGN parenthesizationQL_ALIGN is a set of copies of roundup2, but it was missing an outer setof parentheses, which began to matter with r324538. Now, fully copy theparenthesization of roundup2.Reviewed by: davidcsDifferential Revision: https://reviews.freebsd.org/D12673
Remove register keyword from sys/ and ANSIfy prototypesA long long time ago the register keyword told the compiler to storethe corresponding variable in a CPU register, but it is not relevantfor
Remove register keyword from sys/ and ANSIfy prototypesA long long time ago the register keyword told the compiler to storethe corresponding variable in a CPU register, but it is not relevantfor any compiler used in the FreeBSD world today.ANSIfy related prototypes while here.Reviewed by: cem, jhbSponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D10193
sys/dev: minor spelling fixes.Most affect comments, very few have user-visible effects.
tcp/lro: Use tcp_lro_flush_all in device drivers to avoid code duplicationAnd factor out tcp_lro_rx_done, which deduplicates the same logic withnetinet/tcp_lro.cReviewed by: gallatin (1st versio
tcp/lro: Use tcp_lro_flush_all in device drivers to avoid code duplicationAnd factor out tcp_lro_rx_done, which deduplicates the same logic withnetinet/tcp_lro.cReviewed by: gallatin (1st version), hps, zbb, np, Dexuan Cui <decui microsoft com>Sponsored by: Microsoft OSTCDifferential Revision: https://reviews.freebsd.org/D5725
qlxgb: fix mismatch.Found by: PVS Static AnalysisReviewed by: davidcsMFC after: 1 month
CALLOUT_MPSAFE has lost its meaning since r141428, i.e., for more than tenyears for head. However, it is continuously misused as the mpsafe argumentfor callout_init(9). Deprecate the flag and cle
CALLOUT_MPSAFE has lost its meaning since r141428, i.e., for more than tenyears for head. However, it is continuously misused as the mpsafe argumentfor callout_init(9). Deprecate the flag and clean up callout_init() callsto make them more consistent.Differential Revision: https://reviews.freebsd.org/D2613Reviewed by: jhbMFC after: 2 weeks
Fix multiple incorrect SYSCTL arguments in the kernel:- Wrong integer type was specified.- Wrong or missing "access" specifier. The "access" specifiersometimes included the SYSCTL type, which it
Fix multiple incorrect SYSCTL arguments in the kernel:- Wrong integer type was specified.- Wrong or missing "access" specifier. The "access" specifiersometimes included the SYSCTL type, which it should not, except forprocedural SYSCTL nodes.- Logical OR where binary OR was expected.- Properly assert the "access" argument passed to all SYSCTL macros,using the CTASSERT macro. This applies to both static- and dynamicallycreated SYSCTLs.- Properly assert the the data type for both static and dynamicSYSCTLs. In the case of static SYSCTLs we only assert that the datapointed to by the SYSCTL data pointer has the correct size, hencethere is no easy way to assert types in the C language outside aC-function.- Rewrote some code which doesn't pass a constant "access" specifierwhen creating dynamic SYSCTL nodes, which is now a requirement.- Updated "EXAMPLES" section in SYSCTL manual page.MFC after: 3 daysSponsored by: Mellanox Technologies
Use define from if_var.h to access a field inside struct if_data,that resides in struct ifnet.Sponsored by: Nginx, Inc.
Unload maps for DMA buffers allocated via bus_dmamem_alloc() beforefreeing the buffers.Reviewed by: davidcs
Since 32-bit if_baudrate isn't enough to describe a baud rate of a 10 Gbitinterface, in the r241616 a crutch was provided. It didn't work well, andfinally we decided that it is time to break ABI an
Since 32-bit if_baudrate isn't enough to describe a baud rate of a 10 Gbitinterface, in the r241616 a crutch was provided. It didn't work well, andfinally we decided that it is time to break ABI and simply make if_baudratea 64-bit value. Meanwhile, the entire struct if_data was reviewed.o Remove the if_baudrate_pf crutch.o Make all fields of struct if_data fixed machine independent size. The notion of data (packet counters, etc) are by no means MD. And it is a bug that on amd64 we've got a 64-bit counters, while on i386 32-bit, which at modern speeds overflow within a second. This also removes quite a lot of COMPAT_FREEBSD32 code.o Give 16 bit for the ifi_datalen field. This field was provided to make future changes to if_data less ABI breaking. Unfortunately the 8 bit size of it had effectively limited sizeof if_data to 256 bytes.o Give 32 bits to ifi_mtu and ifi_metric.o Give 64 bits to the rest of fields, since they are counters.__FreeBSD_version bumped.Discussed with: emaxSponsored by: NetflixSponsored by: Nginx, Inc.
check for defrag only when bus_dmamap_load_mbuf_sg() returns EFBIG. Comment inqla_hw_send is moot.
Include necessary headers that now are available due to pollutionvia if_var.h.Sponsored by: NetflixSponsored by: Nginx, Inc.
Restructure the mbuf pkthdr to make it fit for upcoming capabilities andfeatures. The changes in particular are:o Remove rarely used "header" pointer and replace it with a 64bit protocol/ layer
Restructure the mbuf pkthdr to make it fit for upcoming capabilities andfeatures. The changes in particular are:o Remove rarely used "header" pointer and replace it with a 64bit protocol/ layer specific union PH_loc for local use. Protocols can flexibly overlay their own 8 to 64 bit fields to store information while the packet is worked on.o Mechanically convert IP reassembly, IGMP/MLD and ATM to use pkthdr.PH_loc instead of pkthdr.header.o Extend csum_flags to 64bits to allow for additional future offload information to be carried (e.g. iSCSI, IPsec offload, and others).o Move the RSS hash type enumerator from abusing m_flags to its own 8bit rsstype field. Adjust accessor macros.o Add cosqos field to store Class of Service / Quality of Service information with the packet. It is not yet supported in any drivers but allows us to get on par with Cisco/Juniper in routing applications (plus MPLS QoS) with a modernized ALTQ.o Add four 8 bit fields l[2-5]hlen to store the relative header offsets from the start of the packet. This is important for various offload capabilities and to relieve the drivers from having to parse the packet and protocol headers to find out location of checksums and other information. Header parsing in drivers is a lot of copy-paste and unhandled corner cases which we want to avoid.o Add another flexible 64bit union to map various additional persistent packet information, like ether_vtag, tso_segsz and csum fields. Depending on the csum_flags settings some fields may have different usage making it very flexible and adaptable to future capabilities.o Restructure the CSUM flags to better signify their outbound (down the stack) and inbound (up the stack) use. The CSUM flags used to be a bit chaotic and rather poorly documented leading to incorrect use in many places. Bring clarity into their use through better naming. Compatibility mappings are provided to preserve the API. The drivers can be corrected one by one and MFC'd without issue.o The size of pkthdr stays the same at 48/56bytes (32/64bit architectures).Sponsored by: The FreeBSD Foundation
No need to set if_mtu since it automatically updated by ether_ifattach().Use if_initbaudrate() to set baudrate.Add IFCAP_LINKSTATE to if_capabilities.Submitted by: David C Somayajulu <davidcs@fr
No need to set if_mtu since it automatically updated by ether_ifattach().Use if_initbaudrate() to set baudrate.Add IFCAP_LINKSTATE to if_capabilities.Submitted by: David C Somayajulu <[email protected]>Approved by: George Neville-Neil <[email protected]>
1. Updated Copyright Information2. Added Flash Read/Update Support3. Fixed TSO HandlingSubmitted by: David C Somayajulu ([email protected])Reviewed by: George Neville-Neil ([email protected])Ap
1. Updated Copyright Information2. Added Flash Read/Update Support3. Fixed TSO HandlingSubmitted by: David C Somayajulu ([email protected])Reviewed by: George Neville-Neil ([email protected])Approved by: George Neville-Neil ([email protected])
Mechanically substitute flags from historic mbuf allocator withmalloc(9) flags in sys/dev.
Do not announce IPv6 TSO support yet. The in-tree driver does not seemto fully handle this yet.Reviewed by: davidcsMFC after: 1 week
ether_ifattach() sets if_mtu to ETHERMTU, don't bother set it againReviewed by: yongari
Update recently added drivers to use the if_*addr_r*lock() wrapperfunctions instead of using the IF_ADDR_LOCK directly. The wrapperfunctions are the supported interface for device drivers.Review
Update recently added drivers to use the if_*addr_r*lock() wrapperfunctions instead of using the IF_ADDR_LOCK directly. The wrapperfunctions are the supported interface for device drivers.Reviewed by: bz, philipMFC after: 1 week
In sys/dev/qlxgb/qla_misc.c, fix a copy/paste issue. Clang complainedthe variable 'val' was uninitialized when used. Instead, 'sig' shouldhave been printed.Reviewed by: davidcsMFC after: 1 week
The maximum TSO frame size should be: maximum IP datagram size (65535 bytes) + Ethernet header size (14 bytes) + 2 * VLAN tag size (4 bytes) [1].[1] We need to multiply by 2 to account for the d
The maximum TSO frame size should be: maximum IP datagram size (65535 bytes) + Ethernet header size (14 bytes) + 2 * VLAN tag size (4 bytes) [1].[1] We need to multiply by 2 to account for the double VLAN tag provision added in IEEE 802.1ad.Submitted by: David Somayajulu (david.somayajulu qlogic.com)MFC after: 4 days
Add QLogic 10 Gigabit Ethernet & CNA Adapter Driver version 1.30for 3200 and 8200 series cards.Submitted by: David C Somayajulu ([email protected]), Qlogic CorporationMFC After: 3 days