| d8ded501 | 04-Mar-2022 |
Devendra Singh Rawat <[email protected]> |
net/qede: fix maximum Rx packet length
Size of CRC is not added to max_rx_pktlen, due to this bigger sized packets(size 1480, 1490 1500) are being dropped. This fix adds RTE_ETHER_CRC_LEN to max_rx_
net/qede: fix maximum Rx packet length
Size of CRC is not added to max_rx_pktlen, due to this bigger sized packets(size 1480, 1490 1500) are being dropped. This fix adds RTE_ETHER_CRC_LEN to max_rx_pktlen.
Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") Cc: [email protected]
Signed-off-by: Devendra Singh Rawat <[email protected]> Signed-off-by: Rasesh Mody <[email protected]>
show more ...
|
| f65c7fbc | 04-Mar-2022 |
Devendra Singh Rawat <[email protected]> |
net/qede: fix Rx bulk
qede_alloc_rx_bulk_mbufs() was trimming the number of requested mbufs count to QEDE_MAX_BULK_ALLOC_COUNT. The Rx callback was ignorant of this trimming and it was always resett
net/qede: fix Rx bulk
qede_alloc_rx_bulk_mbufs() was trimming the number of requested mbufs count to QEDE_MAX_BULK_ALLOC_COUNT. The Rx callback was ignorant of this trimming and it was always resetting the number of empty RX BD ring slots to 0. This resulted in Rx BD ring getting into an inconsistent state and ultimately the application fails to receive any traffic.
The fix trims the number of requested mbufs count before making call to qede_alloc_rx_bulk_mbufs(). After qede_alloc_rx_bulk_mbufs() returns successfully, the number of empty Rx BD ring slots are decremented by the correct count.
Fixes: 8f2312474529 ("net/qede: fix performance bottleneck in Rx path") Cc: [email protected]
Signed-off-by: Devendra Singh Rawat <[email protected]> Signed-off-by: Rasesh Mody <[email protected]>
show more ...
|
| dd4e429c | 18-Oct-2021 |
Ferruh Yigit <[email protected]> |
ethdev: move jumbo frame offload check to library
Setting MTU bigger than RTE_ETHER_MTU requires the jumbo frame support, and application should enable the jumbo frame offload support for it.
When
ethdev: move jumbo frame offload check to library
Setting MTU bigger than RTE_ETHER_MTU requires the jumbo frame support, and application should enable the jumbo frame offload support for it.
When jumbo frame offload is not enabled by application, but MTU bigger than RTE_ETHER_MTU is requested there are two options, either fail or enable jumbo frame offload implicitly.
Enabling jumbo frame offload implicitly is selected by many drivers since setting a big MTU value already implies it, and this increases usability.
This patch moves this logic from drivers to the library, both to reduce the duplicated code in the drivers and to make behaviour more visible.
Signed-off-by: Ferruh Yigit <[email protected]> Reviewed-by: Andrew Rybchenko <[email protected]> Reviewed-by: Rosen Xu <[email protected]> Acked-by: Ajit Khaparde <[email protected]> Acked-by: Somnath Kotur <[email protected]> Acked-by: Konstantin Ananyev <[email protected]> Acked-by: Huisong Li <[email protected]>
show more ...
|
| 11c2e4b4 | 08-Aug-2021 |
Thomas Monjalon <[email protected]> |
net/qede: fix minsize build
Error occurs when configuring meson with --buildtype=minsize with GCC 11.1.0:
In function ‘__internal_ram_wr_relaxed’, inlined from ‘internal_ram_wr’ at ecore_int_ap
net/qede: fix minsize build
Error occurs when configuring meson with --buildtype=minsize with GCC 11.1.0:
In function ‘__internal_ram_wr_relaxed’, inlined from ‘internal_ram_wr’ at ecore_int_api.h:166:2, inlined from ‘qede_update_rx_prod.constprop’ at qede_rxtx.c:736:2: drivers/net/qede/base/bcm_osal.h:136:9: error: ‘rx_prods’ is used uninitialized [-Werror=uninitialized] | rte_write32_relaxed((_val), (_reg_addr)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ecore_int_api.h:151:17: note: in expansion of macro ‘DIRECT_REG_WR_RELAXED’ | DIRECT_REG_WR_RELAXED(p_hwfn, &((u32 OSAL_IOMEM *)addr)[i], | ^~~~~~~~~~~~~~~~~~~~~ drivers/net/qede/qede_rxtx.c: In function ‘qede_update_rx_prod.constprop’: drivers/net/qede/qede_rxtx.c:724:33: note: ‘rx_prods’ declared here | struct eth_rx_prod_data rx_prods = { 0 }; | ^~~~~~~~
Signed-off-by: Thomas Monjalon <[email protected]> Acked-by: Devendra Singh Rawat <[email protected]> Acked-by: Rasesh Mody <[email protected]>
show more ...
|