Change filecheck default to dump input on failureHaving the input dumped on failure seems like a betterdefault: I debugged FileCheck tests for a while without knowingabout this option, which real
Change filecheck default to dump input on failureHaving the input dumped on failure seems like a betterdefault: I debugged FileCheck tests for a while without knowingabout this option, which really helps to understand failures.Remove `-dump-input-on-failure` and the environment variableFILECHECK_DUMP_INPUT_ON_FAILURE which are now obsolete.Differential Revision: https://reviews.llvm.org/D81422
show more ...
[FileCheck] Support comment directivesSometimes you want to disable a FileCheck directive without removingit entirely, or you want to write comments that mention a directive byname. The `COM:` d
[FileCheck] Support comment directivesSometimes you want to disable a FileCheck directive without removingit entirely, or you want to write comments that mention a directive byname. The `COM:` directive makes it easy to do this. For example,you might have:```; X32: pinsrd_1:; X32: pinsrd $1, 4(%esp), %xmm0; COM: FIXME: X64 isn't working correctly yet for this part of codegen, but; COM: X64 will have something similar to X32:; COM:; COM: X64: pinsrd_1:; COM: X64: pinsrd $1, %edi, %xmm0```Without this patch, you need to use some combination of rewording anddirective syntax mangling to prevent FileCheck from recognizing thecommented occurrences of `X32:` and `X64:` above as directives.Moreover, FileCheck diagnostics have been proposed that might complainabout the occurrences of `X64` that don't have the trailing `:`because they look like directive typos: <http://lists.llvm.org/pipermail/llvm-dev/2020-April/140610.html>I think dodging all these problems can prove tedious for test authors,and directive syntax mangling already makes the purpose of existingtest code unclear. `COM:` can avoid all these problems.This patch also updates the small set of existing tests that define`COM` as a check prefix:- clang/test/CodeGen/default-address-space.c- clang/test/CodeGenOpenCL/addr-space-struct-arg.cl- clang/test/Driver/hip-device-libs.hip- llvm/test/Assembler/drop-debug-info-nonzero-alloca.llI think lit should support `COM:` as well. Perhaps `clang -verify`should too.Reviewed By: jhenderson, thopreDifferential Revision: https://reviews.llvm.org/D79276
Revert "[FileCheck] Support comment directives"This reverts commit 9a9a5f9893c8db05cebc8818eb8485bff61f7c74 to try tofix a bot:http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-check
Revert "[FileCheck] Support comment directives"This reverts commit 9a9a5f9893c8db05cebc8818eb8485bff61f7c74 to try tofix a bot:http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/23489