Minor aesthetic fixes to PR #3264.

Comment format fixed + local var modified from camel case to underscore
separators as Redis code base normally does (camel case is mostly used
for global symbols l

Minor aesthetic fixes to PR #3264.

Comment format fixed + local var modified from camel case to underscore
separators as Redis code base normally does (camel case is mostly used
for global symbols like structure names, function names, global vars,
...).

show more ...

check WRONGTYPE in BITFIELD before looping on the operations.

optimization: lookup key only once, and grow at once to the max need
fixes #3259 and #3221, and also an early return if wrongtype is dis

check WRONGTYPE in BITFIELD before looping on the operations.

optimization: lookup key only once, and grow at once to the max need
fixes #3259 and #3221, and also an early return if wrongtype is discovered by SET

show more ...

fix crash in BITFIELD GET on non existing key or wrong type see #3259

this was a bug in the recent refactoring: bee963c4459223d874e3294a0d8638a588d33c8e

GETRANGE: return empty string with negative, inverted start/end.

Remove additional round brackets from fix for #3282.

bitcount bug:return non-zero value when start > end (both negative)

Avoid undefined behavior in BITFIELD implementation.

Probably there is no compiler that will actaully break the code or raise
a signal for unsigned -> signed overflowing conversion, still it was
app

Avoid undefined behavior in BITFIELD implementation.

Probably there is no compiler that will actaully break the code or raise
a signal for unsigned -> signed overflowing conversion, still it was
apparently possible to write it in a more correct way.

All tests passing.

show more ...

fix some compiler warnings

Code to access object string bytes repeated 3x refactored into 1 function.

fix crash in BITFIELD GET when key is integer encoded

BITFIELD: Farest bit set is offset+bits-1. Off by one error fixed.

More BITFIELD fixes. Overflow conditional simplified.

See issue #3114.

bitops/bitfield: fix length, overflow condition and *sign

BITFIELD: refactoring & fix of retval on FAIL.

BITFIELD: Fix #<index> form parsing.

BITFIELD: Support #<index> offsets form.

BITFIELD command initial implementation.

The new bitfield command is an extension to the Redis bit operations,
where not just single bit operations are performed, but the array of
bits composing a s

BITFIELD command initial implementation.

The new bitfield command is an extension to the Redis bit operations,
where not just single bit operations are performed, but the array of
bits composing a string, can be addressed at random, not aligned
offsets, with any width unsigned and signed integers like u8, s5, u10
(up to 64 bit signed integers and 63 bit unsigned integers).

The BITFIELD command supports subcommands that can SET, GET, or INCRBY
those arbitrary bit counters, with multiple overflow semantics.

Trivial and credits:

A similar command was imagined a few times in the past, but for
some reason looked a bit far fetched or not well specified.
Finally the command was proposed again in a clear form by
Yoav Steinberg from Redis Labs, that proposed a set of commands on
arbitrary sized integers stored at bit offsets.

Starting from this proposal I wrote an initial specification of a single
command with sub-commands similar to what Yoav envisioned, using short
names for types definitions, and adding control on the overflow.

This commit is the resulting implementation.

Examples:

BITFIELD mykey OVERFLOW wrap INCRBY i2 10 -1 GET i2 10

show more ...

RDMF: More consistent define names.

RDMF: REDIS_OK REDIS_ERR -> C_OK C_ERR.

RDMF: OBJ_ macros for object related stuff.

RDMF: use client instead of redisClient, like Disque.

RDMF (Redis/Disque merge friendlyness) refactoring WIP 1.

Bitops: Stop overallocating storage space on set

Previously the string was created empty then re-sized
to fit the offset, but sds resize causes the sds to
over-allocate by at least 1 MB (which is a

Bitops: Stop overallocating storage space on set

Previously the string was created empty then re-sized
to fit the offset, but sds resize causes the sds to
over-allocate by at least 1 MB (which is a lot when
you are operating at bit-level access).

This also improves the speed of initial sets by 2% to 6%
based on quick testing.

Patch logic provided by @oranagra

Fixes #1918

show more ...

bitops.c/bitopCommand: skip short minlen for FAST PATH

bitops.c/redisPopcount: little optimization in loop