Disable symbol on-demand feature for WindowsSymbol on-demand feature is never tested on Windows so it is not a surprisethat we are getting Buildbot failure from Windows:https://lab.llvm.org/build
Disable symbol on-demand feature for WindowsSymbol on-demand feature is never tested on Windows so it is not a surprisethat we are getting Buildbot failure from Windows:https://lab.llvm.org/buildbot/#/builders/83/builds/18228This patch disables symbol on-demand feature on Windows. I will find a Windowsmachine to test and re-enable symbol on-demand feature as follow-up.Differential Revision: https://reviews.llvm.org/D124471
show more ...
Introduce new symbol on-demand for debug infoThis diff introduces a new symbol on-demand which skipsloading a module's debug info unless explicitly asked ondemand. This provides significant perfo
Introduce new symbol on-demand for debug infoThis diff introduces a new symbol on-demand which skipsloading a module's debug info unless explicitly asked ondemand. This provides significant performance improvementfor application with dynamic linking mode which has largenumber of modules.The feature can be turned on with:"settings set symbols.load-on-demand true"The feature works by creating a new SymbolFileOnDemand class foreach module which wraps the actual SymbolFIle subclass as membervariable. By default, most virtual methods on SymbolFileOnDemand areskipped so that it looks like there is no debug info for that module.But once the module's debug info is explicitly requested tobe enabled (in the conditions mentioned below) SymbolFileOnDemandwill allow all methods to pass through and forward to the actual SymbolFilewhich would hydrate module's debug info on-demand.In an internal benchmark, we are seeing more than 95% improvementfor a 3000 modules application.Currently we are providing several ways to on demand hydratea module's debug info:* Source line breakpoint: matching in supported files* Stack trace: resolving symbol context for an address* Symbolic breakpoint: symbol table match guided promotion* Global variable: symbol table match guided promotionIn all above situations the module's debug info will be on-demandparsed and indexed.Some follow-ups for this feature:* Add a command that allows users to load debug info explicitly while using a new or existing command when this feature is enabled* Add settings for "never load any of these executables in Symbols On Demand" that takes a list of globs* Add settings for "always load the the debug info for executables in Symbols On Demand" that takes a list of globs* Add a new column in "image list" that shows up by default when Symbols On Demand is enable to show the status for each shlib like "not enabled for this", "debug info off" and "debug info on" (with a single character to short string, not the ones I just typed)Differential Revision: https://reviews.llvm.org/D121631