[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://r
[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://reviews.llvm.org/D128077
show more ...
[lldb] Fix race condition between lldb-vscode and stop hooks executorThe race is between these two pieces of code that are executed in two separatelldb-vscode threads (the first is in the main thr
[lldb] Fix race condition between lldb-vscode and stop hooks executorThe race is between these two pieces of code that are executed in two separatelldb-vscode threads (the first is in the main thread and another is in theevent-handling thread):```// lldb-vscode.cppg_vsc.debugger.SetAsync(false);g_vsc.target.Launch(launch_info, error);g_vsc.debugger.SetAsync(true);``````// Target.cppbool old_async = debugger.GetAsyncExecution();debugger.SetAsyncExecution(true);debugger.GetCommandInterpreter().HandleCommands(GetCommands(), exc_ctx, options, result);debugger.SetAsyncExecution(old_async);```The sequence that leads to the bug is this one:1. Main thread enables synchronous mode and launches the process.2. When the process is launched, it generates the first stop event.3. This stop event is catched by the event-handling thread and DoOnRemoval is invoked.4. Inside DoOnRemoval, this thread runs stop hooks. And before running stop hooks, the current synchronization mode is stored into old_async (and right now it is equal to "false").5. The main thread finishes the launch and returns to lldb-vscode, the synchronization mode is restored to asynchronous by lldb-vscode.6. Event-handling thread finishes stop hooks processing and restores the synchronization mode according to old_async (i.e. makes the mode synchronous)7. And now the mode is synchronous while lldb-vscode expects it to be asynchronous. Synchronous mode forbids the process to broadcast public stop events, so, VS Code just hangs because lldb-vscode doesn't notify it about stops.So, this diff makes the target intercept the first stop event if the process islaunched in the synchronous mode, thus preventing stop hooks execution.The bug is only present on Windows because other platforms alreadyintercept this event using their own hijacking listeners.So, this diff also fixes some problems with lldb-vscode tests on Windows to makeit possible to run the related test. Other tests still can't be enabled becausethe debugged program prints something into stdout and LLDB can't intercept thisoutput and redirect it to lldb-vscode properly.Reviewed By: jinghamDifferential Revision: https://reviews.llvm.org/D119548