[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://r
[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://reviews.llvm.org/D128077
show more ...
[lldb] Move PlatformPOSIX::ConnectToWaitingProcesses to RemoteAwarePlatformThe functionality is not posix specific. Also force the usage of thegdb-remote process plugin in the gdb platform class.
[lldb] Move PlatformPOSIX::ConnectToWaitingProcesses to RemoteAwarePlatformThe functionality is not posix specific. Also force the usage of thegdb-remote process plugin in the gdb platform class.This is not sufficient to make TestPlatformConnect pass on windows (itseems it suffers from module loading issues, unrelated to this test),but it at least makes it shut down correctly, so I change the skip to anxfail.
[lldb] Apply gdb-remote timeout to platform connections as wellWe have a plugin.process.gdb-remote.packet-timeout setting, which can beused to control how long the lldb client is willing to wait b
[lldb] Apply gdb-remote timeout to platform connections as wellWe have a plugin.process.gdb-remote.packet-timeout setting, which can beused to control how long the lldb client is willing to wait beforedeclaring the server side dead. Our test suite makes use of thisfeature, and sets the setting value fairly high, as the low defaultvalue can cause flaky tests, particularly on slower bots.After fixing TestPlatformConnect (one of the few tests exercising theremote platform capabilities of lldb) in 4b284b9ca, it immediatelystarted being flaky on the arm bots. It turns out this is because thepacket-timeout setting is not being applied to platform connections.This patch makes the platform connections also respect the value of thissetting. It also adds a test which checks that the timeout value isbeing honored.Differential Revision: https://reviews.llvm.org/D97769
[lldb/test] Move and improve TestPlatformProcessConnect.pyAlthough it is located under tools/lldb-server, this test is verydifferent that other lldb-server tests. The most important distinctionis
[lldb/test] Move and improve TestPlatformProcessConnect.pyAlthough it is located under tools/lldb-server, this test is verydifferent that other lldb-server tests. The most important distinctionis that it does not test lldb-server directly, but rather interacts withit through the lldb client. It also tests the relevant clientfunctionality (the platform connect command, which is even admitted inthe test name). The fact that this test is structured as a lldb-servertest means it cannot access most of the goodies available to the"normal" lldb tests (the runCmd function, which it reimplements; therun_break_set_by_symbol utility function; etc.).This patch makes it a full-fledged lldb this, and rewrites the relevantbits to make use of the standard features. I also move the test into the"commands" subtree to better reflect its new status.