[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://r
[lldb][tests] Automatically call compute_mydir (NFC)Eliminate boilerplate of having each test manually assign to `mydir` by calling`compute_mydir` in lldbtest.py.Differential Revision: https://reviews.llvm.org/D128077
show more ...
Revert "[lldb] Consider binary as module of last resort"This reverts commit a3c3482ceb529206b0ae4e7782e5496da5e0879d.It broke LLDB API test TestBadAddressBreakpoints.pyDifferential revision: htt
Revert "[lldb] Consider binary as module of last resort"This reverts commit a3c3482ceb529206b0ae4e7782e5496da5e0879d.It broke LLDB API test TestBadAddressBreakpoints.pyDifferential revision: https://reviews.llvm.org/D124731
[lldb] Consider binary as module of last resortWhen setting an address breakpoint using a non-section address in lldbbefore having ever run the program, the binary itself is not considereda modul
[lldb] Consider binary as module of last resortWhen setting an address breakpoint using a non-section address in lldbbefore having ever run the program, the binary itself is not considereda module. As a result, the breakpoint is unresolved (and never getsresolved subsequently).This patch changes that behavior: as a last resort, the binary isconsidered as a module when resolving a non-section address breakpoint.Differential revision: https://reviews.llvm.org/D124731
[lldb] Warn the user about starting the --func-regex parameter with an asteriskSummary:Sometimes users think that setting a function regex for all function that contain the word 'needle' in their
[lldb] Warn the user about starting the --func-regex parameter with an asteriskSummary:Sometimes users think that setting a function regex for all function that contain the word 'needle' in theirname looks like this: `*needle*`. However, LLDB only searches the function name and doesn't fully matchit against the regex, so the leading and trailing '*' operators don't do anything and actually just cause theregex engine to reject the regular expression with "repetition-operator operand invalid".This patch makes this a bit more obvious to the user by printing a warning that a leading '*' before thisregular expression here doesn't have any purpose (and will cause an error). This doesn't attempt to detecta case where there is only a trailing '*' as that would involve parsing the regex and it seems the mostcommon way to end up in this situation is by doing `rbreak *needle*`.Reviewers: JDevlieghereReviewed By: JDevlieghereDifferential Revision: https://reviews.llvm.org/D78809
[lldb] Improve error message when --func-regex parameter for the breakpoint command is invalidSummary:Currently the breakpoint command is prompting the user to file a bug report if the provided re
[lldb] Improve error message when --func-regex parameter for the breakpoint command is invalidSummary:Currently the breakpoint command is prompting the user to file a bug report if the provided regex is invalid:```(lldb) rbreak *fooerror: Function name regular expression could not be compiled: "Inconvertible error value. An error has occurred that could not be converted to a known std::error_code. Please file a bug. repetition-operator operand invalid"```The reason is simply that we are using the wrong StringError constructor (the one with the error code as the first parameteris also printing the string version of the error code, and the inconvertible error code is just an invalid place holder code withthat description). Switching the StringError constructor parameters will only print the error message we get from the regexengine when we convert the error into a string.I checked the rest of the code base and I couldn't find the same issue anywhere else.Fixes rdar://62233561Reviewers: JDevlieghereReviewed By: JDevlieghereSubscribers: lldb-commitsDifferential Revision: https://reviews.llvm.org/D78808