HID: Intel-thc-hid: Intel-quickspi: Correct device state names gramatically

Correct quickspi device state name and change the list order to follow
device state working flow.

Signed-off-by: Even Xu

HID: Intel-thc-hid: Intel-quickspi: Correct device state names gramatically

Correct quickspi device state name and change the list order to follow
device state working flow.

Signed-off-by: Even Xu <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>

show more ...

HID: Intel-thc-hid: Intel-quickspi: Correct device state after S4

During S4 retore flow, quickspi device was resetted by driver and state
was changed to RESETTED. It is needed to be change to ENABLE

HID: Intel-thc-hid: Intel-quickspi: Correct device state after S4

During S4 retore flow, quickspi device was resetted by driver and state
was changed to RESETTED. It is needed to be change to ENABLED state
after S4 re-initialization finished, otherwise, device will run in wrong
state and HID input data will be dropped.

Signed-off-by: Even Xu <[email protected]>
Fixes: 6912aaf3fd24 ("HID: intel-thc-hid: intel-quickspi: Add PM implementation")
Signed-off-by: Jiri Kosina <[email protected]>

show more ...

HID: intel-thc-hid: Fix spelling mistake "intput" -> "input"

There is a spelling mistake in a dev_err_once message. Fix it.

Signed-off-by: Colin Ian King <[email protected]>
Reviewed-by: Even

HID: intel-thc-hid: Fix spelling mistake "intput" -> "input"

There is a spelling mistake in a dev_err_once message. Fix it.

Signed-off-by: Colin Ian King <[email protected]>
Reviewed-by: Even Xu <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>

show more ...

Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x | !y" issue

Change to use "||" to make it more readable and avoid miss
understanding.

Signed-off-by: Even Xu <[email protected]>
Reported-by: kernel

Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x | !y" issue

Change to use "||" to make it more readable and avoid miss
understanding.

Signed-off-by: Even Xu <[email protected]>
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]
Signed-off-by: Jiri Kosina <[email protected]>

show more ...

HID: intel-thc-hid: Remove deprecated PCI API calls

intel-thc-hid reintroduced the already deprecated PCI API functions

pcim_iomap_table(),
pcim_iomap_regions(),
pcim_iounmap_regions(),

none of

HID: intel-thc-hid: Remove deprecated PCI API calls

intel-thc-hid reintroduced the already deprecated PCI API functions

pcim_iomap_table(),
pcim_iomap_regions(),
pcim_iounmap_regions(),

none of which should be used anymore.

Furthermore, calling managed (pcim_*) functions in remove() and probe()
for cleanup is not necessary, since the managed functions clean up
automatically.

Replace / remove the deprecated functions.

Fixes: 61bb2714dc3a1 ("HID: intel-thc-hid: intel-quicki2c: Add THC QuickI2C driver skeleton")
Signed-off-by: Philipp Stanner <[email protected]>
Reviewed-by: Even Xu <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>

show more ...