Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that arestill not MPSAFE (or already are but aren’t properly mark
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that arestill not MPSAFE (or already are but aren’t properly marked).Use it in preparation for a general review of all nodes.This is non-functional change that adds annotations to SYSCTL_NODE andSYSCTL_PROC nodes using one of the soon-to-be-required flags.Mark all obvious cases as MPSAFE. All entries that haven't been markedas MPSAFE before are by default marked as NEEDGIANTApproved by: kib (mentor, blanket)Commented by: kib, gallatin, melifaroDifferential Revision: https://reviews.freebsd.org/D23718
show more ...
add iic interface to ig4 driver, move isl and cyapa to iicbusSummary:The hardware does not expose a classic SMBus interface.Instead it has a lower level interface that can express a far richerI2
add iic interface to ig4 driver, move isl and cyapa to iicbusSummary:The hardware does not expose a classic SMBus interface.Instead it has a lower level interface that can express a far richerI2C protocol than what smbus offers. However, the interface does notprovide a way to explicitly generate the I2C stop and start conditions.It's only possible to request that the stop condition is generatedafter transferring the next byte in either direction. So, at leastone data byte must always be transferred.Thus, some I2C sequences are impossible to generate, e.g., an equivalentof smbus quick command (<start>-<slave addr>-<r/w bit>-<stop>).At the same time isl(4) and cyapa(4) are moved to iicbus and now they useiicbus_transfer for communication. Previously they used smbus_trans()interface that is not defined by the SMBus protocol and was implementedonly by ig4(4). In fact, that interface was impossible to implementfor the typical SMBus controllers like intpm(4) or ichsmb(4) wherea type of the SMBus command must be programmed.The plan is to remove smbus_trans() and all its uses.As an aside, the smbus_trans() method deviates from the standard,but perhaps backwards, FreeBSD convention of using 8-bit slaveaddresses (shifted by 1 bit to the left). The method expects7-bit addresses.There is a user facing consequence of this change.A user must now provide device hints for isl and cyapa that specify an iicbus to useand a slave address on it.On Chromebook hardware where isl and cyapa devices are commonly foundit is also possible to use a new chromebook_platform(4) driver thatautomatically configures isl and cyapa devices. There is no need toprovide the device hints in that case,Right now smbus(4) driver tries to discover all slaves on the bus.That is very dangerous. Fortunately, the probing code uses smbus_trans()to do its job, so it is really enabled for ig4 only.The plan is to remove that auto-probing code and smbus_trans().Tested by: grembo, Matthias Apitz <[email protected]> (w/o chromebook_platform)Discussed with: grembo, impReviewed by: wblock (docs)MFC after: 1 monthRelnotes: yesDifferential Revision: https://reviews.freebsd.org/D8172
Allow building a kernel with baked in ig4, isl and cyapa drivers.Also addresses jhb's remarks on D2811 and D3068.PR: 202059Differential Revision: https://reviews.freebsd.org/D3351Reviewed by:
Allow building a kernel with baked in ig4, isl and cyapa drivers.Also addresses jhb's remarks on D2811 and D3068.PR: 202059Differential Revision: https://reviews.freebsd.org/D3351Reviewed by: jhbApproved by: jhb
isl(4), driver for Intersil I2C ISL29018 Digital Ambient Light SensorDifferential Revision: https://reviews.freebsd.org/D2811Reviewed by: adrian, wblockApproved by: adrian, wblockRelnotes: yes