dma/idxd: configure maximum batch size to high value

When configuring an Intel DSA instance using the utility script
dpdk_idxd_cfg.py, explicitly set the max supported batch size value to a
high val

dma/idxd: configure maximum batch size to high value

When configuring an Intel DSA instance using the utility script
dpdk_idxd_cfg.py, explicitly set the max supported batch size value to a
high value, to ensure large bursts are supported if so desired. The
default in the linux kernel is now just 32 [1], which may not be
sufficient for all DPDK apps.

[1] https://lore.kernel.org/r/163528473483.3926048.7950067926287180976.stgit@djiang5-desk3.ch.intel.com

Cc: [email protected]

Signed-off-by: Bruce Richardson <[email protected]>
Reviewed-by: Kevin Laatz <[email protected]>

show more ...

dma/idxd: support allow/block list

Add support for allow or block list for devices bound
to the kernel driver.
When used the allow or block list applies as an additional
condition to the name prefix

dma/idxd: support allow/block list

Add support for allow or block list for devices bound
to the kernel driver.
When used the allow or block list applies as an additional
condition to the name prefix.

Signed-off-by: Radu Nicolau <[email protected]>
Reviewed-by: Bruce Richardson <[email protected]>
Acked-by: Bruce Richardson <[email protected]>
Acked-by: Kevin Laatz <[email protected]>

show more ...

dma/idxd: fix wrap-around in burst capacity calculation

The burst capacity calculation code assumes that the write and read
(i.e. ids_returned) values both wrap at the ring-size, but the read
value

dma/idxd: fix wrap-around in burst capacity calculation

The burst capacity calculation code assumes that the write and read
(i.e. ids_returned) values both wrap at the ring-size, but the read
value instead wraps as UINT16_MAX. Therefore, instead of just adding
ring-size to the write value in case the read is greater, we need to
just always mask the result to ensure a correct, in-range, value.

Fixes: 9459de4edc99 ("dma/idxd: add burst capacity")
Cc: [email protected]

Reported-by: Sunil Pai G <[email protected]>
Signed-off-by: Bruce Richardson <[email protected]>
Tested-by: Sunil Pai G <[email protected]>
Acked-by: Kevin Laatz <[email protected]>

show more ...

dma/idxd: fix paths to driver sysfs directory

Recent kernel changes[1][2] mean that we cannot guarantee that the paths
in sysfs used for creating/binding a DSA or workqueue instance will be
as given

dma/idxd: fix paths to driver sysfs directory

Recent kernel changes[1][2] mean that we cannot guarantee that the paths
in sysfs used for creating/binding a DSA or workqueue instance will be
as given in the utility script, since they are now "compatibility-mode
only". Update script to support both new paths and compatibility ones.

[1] https://lore.kernel.org/all/162637445139.744545.6008938867943724701.stgit@djiang5-desk3.ch.intel.com/
[2] https://lore.kernel.org/all/162637468705.744545.4399080971745974435.stgit@djiang5-desk3.ch.intel.com/

Fixes: 01863b9d2354 ("raw/ioat: include example configuration script")
Cc: [email protected]

Signed-off-by: Bruce Richardson <[email protected]>
Acked-by: Kevin Laatz <[email protected]>

show more ...

dma/idxd: fix burst capacity calculation

When the maximum burst size supported by HW is less than the available
ring space, incorrect capacity was returned when there was already some
jobs queued up

dma/idxd: fix burst capacity calculation

When the maximum burst size supported by HW is less than the available
ring space, incorrect capacity was returned when there was already some
jobs queued up for submission. This was because the capacity calculation
failed to subtract the number of already-enqueued jobs from the max
burst size. After subtraction is done, ensure that any negative values
(which should never occur if the user respects the reported limits), are
clamped to zero.

Fixes: 9459de4edc99 ("dma/idxd: add burst capacity")
Cc: [email protected]

Signed-off-by: Bruce Richardson <[email protected]>
Acked-by: Kevin Laatz <[email protected]>
Tested-by: Jiayu Hu <[email protected]>

show more ...

dma/idxd: fix truncated error code in status check

When checking if the DMA device is active, the result of the operand will
always be zero since the err_code is truncated to 8 bits which makes
chec

dma/idxd: fix truncated error code in status check

When checking if the DMA device is active, the result of the operand will
always be zero since the err_code is truncated to 8 bits which makes
checking the 31st bit impossible.

This is fixed by changing the type of err_code to uint32_t so that it is
not truncated.

Coverity issue: 373657
Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe")

Signed-off-by: Kevin Laatz <[email protected]>
Acked-by: Bruce Richardson <[email protected]>
Reviewed-by: Conor Walsh <[email protected]>

show more ...

dma/idxd: fix build on Windows

Windows compilation gives us a splat:
In file included from ../drivers/dma/idxd/idxd_pci.c:10:
In file included from ..\drivers\dma\idxd/idxd_internal.h:11:
..\drivers

dma/idxd: fix build on Windows

Windows compilation gives us a splat:
In file included from ../drivers/dma/idxd/idxd_pci.c:10:
In file included from ..\drivers\dma\idxd/idxd_internal.h:11:
..\drivers\dma\idxd/idxd_hw_defs.h:46:21: error: expected member name or
';' after declaration specifiers
uint16_t __reserved[13];
~~~~~~~~ ^
1 error generated.

Ironically, __reserved is probably a reserved token.
Some drivers that build fine on Windows have structs with a "reserved"
field, let's go with this.

Fixes: 82147042d062 ("dma/idxd: add datapath structures")

Signed-off-by: David Marchand <[email protected]>

show more ...

dma/idxd: move config script from raw driver

Move the example script for configuring IDXD devices bound to the IDXD
kernel driver from raw to dma, and create a symlink to still allow use from
raw.

dma/idxd: move config script from raw driver

Move the example script for configuring IDXD devices bound to the IDXD
kernel driver from raw to dma, and create a symlink to still allow use from
raw.

Signed-off-by: Conor Walsh <[email protected]>
Signed-off-by: Kevin Laatz <[email protected]>
Acked-by: Bruce Richardson <[email protected]>

show more ...

dma/idxd: add burst capacity

Add support for the burst capacity API. This API will provide the calling
application with the remaining capacity of the current burst (limited by
max HW batch size).

S

dma/idxd: add burst capacity

Add support for the burst capacity API. This API will provide the calling
application with the remaining capacity of the current burst (limited by
max HW batch size).

Signed-off-by: Kevin Laatz <[email protected]>
Reviewed-by: Conor Walsh <[email protected]>
Reviewed-by: Bruce Richardson <[email protected]>
Reviewed-by: Chengwen Feng <[email protected]>

show more ...

dma/idxd: add vchan status

When testing dmadev drivers, it is useful to have the HW device in a known
state. This patch adds the implementation of the function which will wait
for the device to be i

dma/idxd: add vchan status

When testing dmadev drivers, it is useful to have the HW device in a known
state. This patch adds the implementation of the function which will wait
for the device to be idle (all jobs completed) before proceeding.

Signed-off-by: Kevin Laatz <[email protected]>
Reviewed-by: Conor Walsh <[email protected]>

show more ...

dma/idxd: add operation statistic tracking

Add statistic tracking for DSA devices.

The dmadev library documentation is also updated to add a generic section
for using the library's statistics APIs.

dma/idxd: add operation statistic tracking

Add statistic tracking for DSA devices.

The dmadev library documentation is also updated to add a generic section
for using the library's statistics APIs.

Signed-off-by: Bruce Richardson <[email protected]>
Signed-off-by: Kevin Laatz <[email protected]>
Reviewed-by: Conor Walsh <[email protected]>
Reviewed-by: Chengwen Feng <[email protected]>

show more ...

dma/idxd: add data path job completion

Add the data path functions for gathering completed operations.

Signed-off-by: Bruce Richardson <[email protected]>
Signed-off-by: Kevin Laatz <kevin

dma/idxd: add data path job completion

Add the data path functions for gathering completed operations.

Signed-off-by: Bruce Richardson <[email protected]>
Signed-off-by: Kevin Laatz <[email protected]>
Reviewed-by: Conor Walsh <[email protected]>

show more ...

dma/idxd: add data path job submission

Add data path functions for enqueuing and submitting operations to DSA
devices.

Documentation updates are included for dmadev library and IDXD driver docs
as

dma/idxd: add data path job submission

Add data path functions for enqueuing and submitting operations to DSA
devices.

Documentation updates are included for dmadev library and IDXD driver docs
as appropriate.

Signed-off-by: Bruce Richardson <[email protected]>
Signed-off-by: Kevin Laatz <[email protected]>
Reviewed-by: Conor Walsh <[email protected]>
Reviewed-by: Chengwen Feng <[email protected]>