1 //===- SimplifyCFG.cpp - Code to perform CFG simplification ---------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // Peephole optimize the CFG. 10 // 11 //===----------------------------------------------------------------------===// 12 13 #include "llvm/ADT/APInt.h" 14 #include "llvm/ADT/ArrayRef.h" 15 #include "llvm/ADT/DenseMap.h" 16 #include "llvm/ADT/MapVector.h" 17 #include "llvm/ADT/Optional.h" 18 #include "llvm/ADT/STLExtras.h" 19 #include "llvm/ADT/ScopeExit.h" 20 #include "llvm/ADT/Sequence.h" 21 #include "llvm/ADT/SetOperations.h" 22 #include "llvm/ADT/SetVector.h" 23 #include "llvm/ADT/SmallPtrSet.h" 24 #include "llvm/ADT/SmallVector.h" 25 #include "llvm/ADT/Statistic.h" 26 #include "llvm/ADT/StringRef.h" 27 #include "llvm/Analysis/AssumptionCache.h" 28 #include "llvm/Analysis/CaptureTracking.h" 29 #include "llvm/Analysis/ConstantFolding.h" 30 #include "llvm/Analysis/DomTreeUpdater.h" 31 #include "llvm/Analysis/GuardUtils.h" 32 #include "llvm/Analysis/InstructionSimplify.h" 33 #include "llvm/Analysis/MemorySSA.h" 34 #include "llvm/Analysis/MemorySSAUpdater.h" 35 #include "llvm/Analysis/TargetTransformInfo.h" 36 #include "llvm/Analysis/ValueTracking.h" 37 #include "llvm/IR/Attributes.h" 38 #include "llvm/IR/BasicBlock.h" 39 #include "llvm/IR/CFG.h" 40 #include "llvm/IR/Constant.h" 41 #include "llvm/IR/ConstantRange.h" 42 #include "llvm/IR/Constants.h" 43 #include "llvm/IR/DataLayout.h" 44 #include "llvm/IR/DerivedTypes.h" 45 #include "llvm/IR/Function.h" 46 #include "llvm/IR/GlobalValue.h" 47 #include "llvm/IR/GlobalVariable.h" 48 #include "llvm/IR/IRBuilder.h" 49 #include "llvm/IR/InstrTypes.h" 50 #include "llvm/IR/Instruction.h" 51 #include "llvm/IR/Instructions.h" 52 #include "llvm/IR/IntrinsicInst.h" 53 #include "llvm/IR/LLVMContext.h" 54 #include "llvm/IR/MDBuilder.h" 55 #include "llvm/IR/Metadata.h" 56 #include "llvm/IR/Module.h" 57 #include "llvm/IR/NoFolder.h" 58 #include "llvm/IR/Operator.h" 59 #include "llvm/IR/PatternMatch.h" 60 #include "llvm/IR/Type.h" 61 #include "llvm/IR/Use.h" 62 #include "llvm/IR/User.h" 63 #include "llvm/IR/Value.h" 64 #include "llvm/IR/ValueHandle.h" 65 #include "llvm/Support/BranchProbability.h" 66 #include "llvm/Support/Casting.h" 67 #include "llvm/Support/CommandLine.h" 68 #include "llvm/Support/Debug.h" 69 #include "llvm/Support/ErrorHandling.h" 70 #include "llvm/Support/KnownBits.h" 71 #include "llvm/Support/MathExtras.h" 72 #include "llvm/Support/raw_ostream.h" 73 #include "llvm/Transforms/Utils/BasicBlockUtils.h" 74 #include "llvm/Transforms/Utils/Local.h" 75 #include "llvm/Transforms/Utils/ValueMapper.h" 76 #include <algorithm> 77 #include <cassert> 78 #include <climits> 79 #include <cstddef> 80 #include <cstdint> 81 #include <iterator> 82 #include <map> 83 #include <set> 84 #include <tuple> 85 #include <utility> 86 #include <vector> 87 88 using namespace llvm; 89 using namespace PatternMatch; 90 91 #define DEBUG_TYPE "simplifycfg" 92 93 cl::opt<bool> llvm::RequireAndPreserveDomTree( 94 "simplifycfg-require-and-preserve-domtree", cl::Hidden, 95 96 cl::desc("Temorary development switch used to gradually uplift SimplifyCFG " 97 "into preserving DomTree,")); 98 99 // Chosen as 2 so as to be cheap, but still to have enough power to fold 100 // a select, so the "clamp" idiom (of a min followed by a max) will be caught. 101 // To catch this, we need to fold a compare and a select, hence '2' being the 102 // minimum reasonable default. 103 static cl::opt<unsigned> PHINodeFoldingThreshold( 104 "phi-node-folding-threshold", cl::Hidden, cl::init(2), 105 cl::desc( 106 "Control the amount of phi node folding to perform (default = 2)")); 107 108 static cl::opt<unsigned> TwoEntryPHINodeFoldingThreshold( 109 "two-entry-phi-node-folding-threshold", cl::Hidden, cl::init(4), 110 cl::desc("Control the maximal total instruction cost that we are willing " 111 "to speculatively execute to fold a 2-entry PHI node into a " 112 "select (default = 4)")); 113 114 static cl::opt<bool> 115 HoistCommon("simplifycfg-hoist-common", cl::Hidden, cl::init(true), 116 cl::desc("Hoist common instructions up to the parent block")); 117 118 static cl::opt<bool> 119 SinkCommon("simplifycfg-sink-common", cl::Hidden, cl::init(true), 120 cl::desc("Sink common instructions down to the end block")); 121 122 static cl::opt<bool> HoistCondStores( 123 "simplifycfg-hoist-cond-stores", cl::Hidden, cl::init(true), 124 cl::desc("Hoist conditional stores if an unconditional store precedes")); 125 126 static cl::opt<bool> MergeCondStores( 127 "simplifycfg-merge-cond-stores", cl::Hidden, cl::init(true), 128 cl::desc("Hoist conditional stores even if an unconditional store does not " 129 "precede - hoist multiple conditional stores into a single " 130 "predicated store")); 131 132 static cl::opt<bool> MergeCondStoresAggressively( 133 "simplifycfg-merge-cond-stores-aggressively", cl::Hidden, cl::init(false), 134 cl::desc("When merging conditional stores, do so even if the resultant " 135 "basic blocks are unlikely to be if-converted as a result")); 136 137 static cl::opt<bool> SpeculateOneExpensiveInst( 138 "speculate-one-expensive-inst", cl::Hidden, cl::init(true), 139 cl::desc("Allow exactly one expensive instruction to be speculatively " 140 "executed")); 141 142 static cl::opt<unsigned> MaxSpeculationDepth( 143 "max-speculation-depth", cl::Hidden, cl::init(10), 144 cl::desc("Limit maximum recursion depth when calculating costs of " 145 "speculatively executed instructions")); 146 147 static cl::opt<int> 148 MaxSmallBlockSize("simplifycfg-max-small-block-size", cl::Hidden, 149 cl::init(10), 150 cl::desc("Max size of a block which is still considered " 151 "small enough to thread through")); 152 153 // Two is chosen to allow one negation and a logical combine. 154 static cl::opt<unsigned> 155 BranchFoldThreshold("simplifycfg-branch-fold-threshold", cl::Hidden, 156 cl::init(2), 157 cl::desc("Maximum cost of combining conditions when " 158 "folding branches")); 159 160 static cl::opt<unsigned> BranchFoldToCommonDestVectorMultiplier( 161 "simplifycfg-branch-fold-common-dest-vector-multiplier", cl::Hidden, 162 cl::init(2), 163 cl::desc("Multiplier to apply to threshold when determining whether or not " 164 "to fold branch to common destination when vector operations are " 165 "present")); 166 167 static cl::opt<bool> EnableMergeCompatibleInvokes( 168 "simplifycfg-merge-compatible-invokes", cl::Hidden, cl::init(true), 169 cl::desc("Allow SimplifyCFG to merge invokes together when appropriate")); 170 171 static cl::opt<unsigned> MaxSwitchCasesPerResult( 172 "max-switch-cases-per-result", cl::Hidden, cl::init(16), 173 cl::desc("Limit cases to analyze when converting a switch to select")); 174 175 STATISTIC(NumBitMaps, "Number of switch instructions turned into bitmaps"); 176 STATISTIC(NumLinearMaps, 177 "Number of switch instructions turned into linear mapping"); 178 STATISTIC(NumLookupTables, 179 "Number of switch instructions turned into lookup tables"); 180 STATISTIC( 181 NumLookupTablesHoles, 182 "Number of switch instructions turned into lookup tables (holes checked)"); 183 STATISTIC(NumTableCmpReuses, "Number of reused switch table lookup compares"); 184 STATISTIC(NumFoldValueComparisonIntoPredecessors, 185 "Number of value comparisons folded into predecessor basic blocks"); 186 STATISTIC(NumFoldBranchToCommonDest, 187 "Number of branches folded into predecessor basic block"); 188 STATISTIC( 189 NumHoistCommonCode, 190 "Number of common instruction 'blocks' hoisted up to the begin block"); 191 STATISTIC(NumHoistCommonInstrs, 192 "Number of common instructions hoisted up to the begin block"); 193 STATISTIC(NumSinkCommonCode, 194 "Number of common instruction 'blocks' sunk down to the end block"); 195 STATISTIC(NumSinkCommonInstrs, 196 "Number of common instructions sunk down to the end block"); 197 STATISTIC(NumSpeculations, "Number of speculative executed instructions"); 198 STATISTIC(NumInvokes, 199 "Number of invokes with empty resume blocks simplified into calls"); 200 STATISTIC(NumInvokesMerged, "Number of invokes that were merged together"); 201 STATISTIC(NumInvokeSetsFormed, "Number of invoke sets that were formed"); 202 203 namespace { 204 205 // The first field contains the value that the switch produces when a certain 206 // case group is selected, and the second field is a vector containing the 207 // cases composing the case group. 208 using SwitchCaseResultVectorTy = 209 SmallVector<std::pair<Constant *, SmallVector<ConstantInt *, 4>>, 2>; 210 211 // The first field contains the phi node that generates a result of the switch 212 // and the second field contains the value generated for a certain case in the 213 // switch for that PHI. 214 using SwitchCaseResultsTy = SmallVector<std::pair<PHINode *, Constant *>, 4>; 215 216 /// ValueEqualityComparisonCase - Represents a case of a switch. 217 struct ValueEqualityComparisonCase { 218 ConstantInt *Value; 219 BasicBlock *Dest; 220 221 ValueEqualityComparisonCase(ConstantInt *Value, BasicBlock *Dest) 222 : Value(Value), Dest(Dest) {} 223 224 bool operator<(ValueEqualityComparisonCase RHS) const { 225 // Comparing pointers is ok as we only rely on the order for uniquing. 226 return Value < RHS.Value; 227 } 228 229 bool operator==(BasicBlock *RHSDest) const { return Dest == RHSDest; } 230 }; 231 232 class SimplifyCFGOpt { 233 const TargetTransformInfo &TTI; 234 DomTreeUpdater *DTU; 235 const DataLayout &DL; 236 ArrayRef<WeakVH> LoopHeaders; 237 const SimplifyCFGOptions &Options; 238 bool Resimplify; 239 240 Value *isValueEqualityComparison(Instruction *TI); 241 BasicBlock *GetValueEqualityComparisonCases( 242 Instruction *TI, std::vector<ValueEqualityComparisonCase> &Cases); 243 bool SimplifyEqualityComparisonWithOnlyPredecessor(Instruction *TI, 244 BasicBlock *Pred, 245 IRBuilder<> &Builder); 246 bool PerformValueComparisonIntoPredecessorFolding(Instruction *TI, Value *&CV, 247 Instruction *PTI, 248 IRBuilder<> &Builder); 249 bool FoldValueComparisonIntoPredecessors(Instruction *TI, 250 IRBuilder<> &Builder); 251 252 bool simplifyResume(ResumeInst *RI, IRBuilder<> &Builder); 253 bool simplifySingleResume(ResumeInst *RI); 254 bool simplifyCommonResume(ResumeInst *RI); 255 bool simplifyCleanupReturn(CleanupReturnInst *RI); 256 bool simplifyUnreachable(UnreachableInst *UI); 257 bool simplifySwitch(SwitchInst *SI, IRBuilder<> &Builder); 258 bool simplifyIndirectBr(IndirectBrInst *IBI); 259 bool simplifyBranch(BranchInst *Branch, IRBuilder<> &Builder); 260 bool simplifyUncondBranch(BranchInst *BI, IRBuilder<> &Builder); 261 bool simplifyCondBranch(BranchInst *BI, IRBuilder<> &Builder); 262 263 bool tryToSimplifyUncondBranchWithICmpInIt(ICmpInst *ICI, 264 IRBuilder<> &Builder); 265 266 bool HoistThenElseCodeToIf(BranchInst *BI, const TargetTransformInfo &TTI, 267 bool EqTermsOnly); 268 bool SpeculativelyExecuteBB(BranchInst *BI, BasicBlock *ThenBB, 269 const TargetTransformInfo &TTI); 270 bool SimplifyTerminatorOnSelect(Instruction *OldTerm, Value *Cond, 271 BasicBlock *TrueBB, BasicBlock *FalseBB, 272 uint32_t TrueWeight, uint32_t FalseWeight); 273 bool SimplifyBranchOnICmpChain(BranchInst *BI, IRBuilder<> &Builder, 274 const DataLayout &DL); 275 bool SimplifySwitchOnSelect(SwitchInst *SI, SelectInst *Select); 276 bool SimplifyIndirectBrOnSelect(IndirectBrInst *IBI, SelectInst *SI); 277 bool TurnSwitchRangeIntoICmp(SwitchInst *SI, IRBuilder<> &Builder); 278 279 public: 280 SimplifyCFGOpt(const TargetTransformInfo &TTI, DomTreeUpdater *DTU, 281 const DataLayout &DL, ArrayRef<WeakVH> LoopHeaders, 282 const SimplifyCFGOptions &Opts) 283 : TTI(TTI), DTU(DTU), DL(DL), LoopHeaders(LoopHeaders), Options(Opts) { 284 assert((!DTU || !DTU->hasPostDomTree()) && 285 "SimplifyCFG is not yet capable of maintaining validity of a " 286 "PostDomTree, so don't ask for it."); 287 } 288 289 bool simplifyOnce(BasicBlock *BB); 290 bool run(BasicBlock *BB); 291 292 // Helper to set Resimplify and return change indication. 293 bool requestResimplify() { 294 Resimplify = true; 295 return true; 296 } 297 }; 298 299 } // end anonymous namespace 300 301 /// Return true if all the PHI nodes in the basic block \p BB 302 /// receive compatible (identical) incoming values when coming from 303 /// all of the predecessor blocks that are specified in \p IncomingBlocks. 304 /// 305 /// Note that if the values aren't exactly identical, but \p EquivalenceSet 306 /// is provided, and *both* of the values are present in the set, 307 /// then they are considered equal. 308 static bool IncomingValuesAreCompatible( 309 BasicBlock *BB, ArrayRef<BasicBlock *> IncomingBlocks, 310 SmallPtrSetImpl<Value *> *EquivalenceSet = nullptr) { 311 assert(IncomingBlocks.size() == 2 && 312 "Only for a pair of incoming blocks at the time!"); 313 314 // FIXME: it is okay if one of the incoming values is an `undef` value, 315 // iff the other incoming value is guaranteed to be a non-poison value. 316 // FIXME: it is okay if one of the incoming values is a `poison` value. 317 return all_of(BB->phis(), [IncomingBlocks, EquivalenceSet](PHINode &PN) { 318 Value *IV0 = PN.getIncomingValueForBlock(IncomingBlocks[0]); 319 Value *IV1 = PN.getIncomingValueForBlock(IncomingBlocks[1]); 320 if (IV0 == IV1) 321 return true; 322 if (EquivalenceSet && EquivalenceSet->contains(IV0) && 323 EquivalenceSet->contains(IV1)) 324 return true; 325 return false; 326 }); 327 } 328 329 /// Return true if it is safe to merge these two 330 /// terminator instructions together. 331 static bool 332 SafeToMergeTerminators(Instruction *SI1, Instruction *SI2, 333 SmallSetVector<BasicBlock *, 4> *FailBlocks = nullptr) { 334 if (SI1 == SI2) 335 return false; // Can't merge with self! 336 337 // It is not safe to merge these two switch instructions if they have a common 338 // successor, and if that successor has a PHI node, and if *that* PHI node has 339 // conflicting incoming values from the two switch blocks. 340 BasicBlock *SI1BB = SI1->getParent(); 341 BasicBlock *SI2BB = SI2->getParent(); 342 343 SmallPtrSet<BasicBlock *, 16> SI1Succs(succ_begin(SI1BB), succ_end(SI1BB)); 344 bool Fail = false; 345 for (BasicBlock *Succ : successors(SI2BB)) { 346 if (!SI1Succs.count(Succ)) 347 continue; 348 if (IncomingValuesAreCompatible(Succ, {SI1BB, SI2BB})) 349 continue; 350 Fail = true; 351 if (FailBlocks) 352 FailBlocks->insert(Succ); 353 else 354 break; 355 } 356 357 return !Fail; 358 } 359 360 /// Update PHI nodes in Succ to indicate that there will now be entries in it 361 /// from the 'NewPred' block. The values that will be flowing into the PHI nodes 362 /// will be the same as those coming in from ExistPred, an existing predecessor 363 /// of Succ. 364 static void AddPredecessorToBlock(BasicBlock *Succ, BasicBlock *NewPred, 365 BasicBlock *ExistPred, 366 MemorySSAUpdater *MSSAU = nullptr) { 367 for (PHINode &PN : Succ->phis()) 368 PN.addIncoming(PN.getIncomingValueForBlock(ExistPred), NewPred); 369 if (MSSAU) 370 if (auto *MPhi = MSSAU->getMemorySSA()->getMemoryAccess(Succ)) 371 MPhi->addIncoming(MPhi->getIncomingValueForBlock(ExistPred), NewPred); 372 } 373 374 /// Compute an abstract "cost" of speculating the given instruction, 375 /// which is assumed to be safe to speculate. TCC_Free means cheap, 376 /// TCC_Basic means less cheap, and TCC_Expensive means prohibitively 377 /// expensive. 378 static InstructionCost computeSpeculationCost(const User *I, 379 const TargetTransformInfo &TTI) { 380 assert(isSafeToSpeculativelyExecute(I) && 381 "Instruction is not safe to speculatively execute!"); 382 return TTI.getUserCost(I, TargetTransformInfo::TCK_SizeAndLatency); 383 } 384 385 /// Check whether this is a potentially trapping constant. 386 static bool canTrap(const Value *V) { 387 if (auto *C = dyn_cast<Constant>(V)) 388 return C->canTrap(); 389 return false; 390 } 391 392 /// If we have a merge point of an "if condition" as accepted above, 393 /// return true if the specified value dominates the block. We 394 /// don't handle the true generality of domination here, just a special case 395 /// which works well enough for us. 396 /// 397 /// If AggressiveInsts is non-null, and if V does not dominate BB, we check to 398 /// see if V (which must be an instruction) and its recursive operands 399 /// that do not dominate BB have a combined cost lower than Budget and 400 /// are non-trapping. If both are true, the instruction is inserted into the 401 /// set and true is returned. 402 /// 403 /// The cost for most non-trapping instructions is defined as 1 except for 404 /// Select whose cost is 2. 405 /// 406 /// After this function returns, Cost is increased by the cost of 407 /// V plus its non-dominating operands. If that cost is greater than 408 /// Budget, false is returned and Cost is undefined. 409 static bool dominatesMergePoint(Value *V, BasicBlock *BB, 410 SmallPtrSetImpl<Instruction *> &AggressiveInsts, 411 InstructionCost &Cost, 412 InstructionCost Budget, 413 const TargetTransformInfo &TTI, 414 unsigned Depth = 0) { 415 // It is possible to hit a zero-cost cycle (phi/gep instructions for example), 416 // so limit the recursion depth. 417 // TODO: While this recursion limit does prevent pathological behavior, it 418 // would be better to track visited instructions to avoid cycles. 419 if (Depth == MaxSpeculationDepth) 420 return false; 421 422 Instruction *I = dyn_cast<Instruction>(V); 423 if (!I) { 424 // Non-instructions all dominate instructions, but not all constantexprs 425 // can be executed unconditionally. 426 return !canTrap(V); 427 } 428 BasicBlock *PBB = I->getParent(); 429 430 // We don't want to allow weird loops that might have the "if condition" in 431 // the bottom of this block. 432 if (PBB == BB) 433 return false; 434 435 // If this instruction is defined in a block that contains an unconditional 436 // branch to BB, then it must be in the 'conditional' part of the "if 437 // statement". If not, it definitely dominates the region. 438 BranchInst *BI = dyn_cast<BranchInst>(PBB->getTerminator()); 439 if (!BI || BI->isConditional() || BI->getSuccessor(0) != BB) 440 return true; 441 442 // If we have seen this instruction before, don't count it again. 443 if (AggressiveInsts.count(I)) 444 return true; 445 446 // Okay, it looks like the instruction IS in the "condition". Check to 447 // see if it's a cheap instruction to unconditionally compute, and if it 448 // only uses stuff defined outside of the condition. If so, hoist it out. 449 if (!isSafeToSpeculativelyExecute(I)) 450 return false; 451 452 Cost += computeSpeculationCost(I, TTI); 453 454 // Allow exactly one instruction to be speculated regardless of its cost 455 // (as long as it is safe to do so). 456 // This is intended to flatten the CFG even if the instruction is a division 457 // or other expensive operation. The speculation of an expensive instruction 458 // is expected to be undone in CodeGenPrepare if the speculation has not 459 // enabled further IR optimizations. 460 if (Cost > Budget && 461 (!SpeculateOneExpensiveInst || !AggressiveInsts.empty() || Depth > 0 || 462 !Cost.isValid())) 463 return false; 464 465 // Okay, we can only really hoist these out if their operands do 466 // not take us over the cost threshold. 467 for (Use &Op : I->operands()) 468 if (!dominatesMergePoint(Op, BB, AggressiveInsts, Cost, Budget, TTI, 469 Depth + 1)) 470 return false; 471 // Okay, it's safe to do this! Remember this instruction. 472 AggressiveInsts.insert(I); 473 return true; 474 } 475 476 /// Extract ConstantInt from value, looking through IntToPtr 477 /// and PointerNullValue. Return NULL if value is not a constant int. 478 static ConstantInt *GetConstantInt(Value *V, const DataLayout &DL) { 479 // Normal constant int. 480 ConstantInt *CI = dyn_cast<ConstantInt>(V); 481 if (CI || !isa<Constant>(V) || !V->getType()->isPointerTy()) 482 return CI; 483 484 // This is some kind of pointer constant. Turn it into a pointer-sized 485 // ConstantInt if possible. 486 IntegerType *PtrTy = cast<IntegerType>(DL.getIntPtrType(V->getType())); 487 488 // Null pointer means 0, see SelectionDAGBuilder::getValue(const Value*). 489 if (isa<ConstantPointerNull>(V)) 490 return ConstantInt::get(PtrTy, 0); 491 492 // IntToPtr const int. 493 if (ConstantExpr *CE = dyn_cast<ConstantExpr>(V)) 494 if (CE->getOpcode() == Instruction::IntToPtr) 495 if (ConstantInt *CI = dyn_cast<ConstantInt>(CE->getOperand(0))) { 496 // The constant is very likely to have the right type already. 497 if (CI->getType() == PtrTy) 498 return CI; 499 else 500 return cast<ConstantInt>( 501 ConstantExpr::getIntegerCast(CI, PtrTy, /*isSigned=*/false)); 502 } 503 return nullptr; 504 } 505 506 namespace { 507 508 /// Given a chain of or (||) or and (&&) comparison of a value against a 509 /// constant, this will try to recover the information required for a switch 510 /// structure. 511 /// It will depth-first traverse the chain of comparison, seeking for patterns 512 /// like %a == 12 or %a < 4 and combine them to produce a set of integer 513 /// representing the different cases for the switch. 514 /// Note that if the chain is composed of '||' it will build the set of elements 515 /// that matches the comparisons (i.e. any of this value validate the chain) 516 /// while for a chain of '&&' it will build the set elements that make the test 517 /// fail. 518 struct ConstantComparesGatherer { 519 const DataLayout &DL; 520 521 /// Value found for the switch comparison 522 Value *CompValue = nullptr; 523 524 /// Extra clause to be checked before the switch 525 Value *Extra = nullptr; 526 527 /// Set of integers to match in switch 528 SmallVector<ConstantInt *, 8> Vals; 529 530 /// Number of comparisons matched in the and/or chain 531 unsigned UsedICmps = 0; 532 533 /// Construct and compute the result for the comparison instruction Cond 534 ConstantComparesGatherer(Instruction *Cond, const DataLayout &DL) : DL(DL) { 535 gather(Cond); 536 } 537 538 ConstantComparesGatherer(const ConstantComparesGatherer &) = delete; 539 ConstantComparesGatherer & 540 operator=(const ConstantComparesGatherer &) = delete; 541 542 private: 543 /// Try to set the current value used for the comparison, it succeeds only if 544 /// it wasn't set before or if the new value is the same as the old one 545 bool setValueOnce(Value *NewVal) { 546 if (CompValue && CompValue != NewVal) 547 return false; 548 CompValue = NewVal; 549 return (CompValue != nullptr); 550 } 551 552 /// Try to match Instruction "I" as a comparison against a constant and 553 /// populates the array Vals with the set of values that match (or do not 554 /// match depending on isEQ). 555 /// Return false on failure. On success, the Value the comparison matched 556 /// against is placed in CompValue. 557 /// If CompValue is already set, the function is expected to fail if a match 558 /// is found but the value compared to is different. 559 bool matchInstruction(Instruction *I, bool isEQ) { 560 // If this is an icmp against a constant, handle this as one of the cases. 561 ICmpInst *ICI; 562 ConstantInt *C; 563 if (!((ICI = dyn_cast<ICmpInst>(I)) && 564 (C = GetConstantInt(I->getOperand(1), DL)))) { 565 return false; 566 } 567 568 Value *RHSVal; 569 const APInt *RHSC; 570 571 // Pattern match a special case 572 // (x & ~2^z) == y --> x == y || x == y|2^z 573 // This undoes a transformation done by instcombine to fuse 2 compares. 574 if (ICI->getPredicate() == (isEQ ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE)) { 575 // It's a little bit hard to see why the following transformations are 576 // correct. Here is a CVC3 program to verify them for 64-bit values: 577 578 /* 579 ONE : BITVECTOR(64) = BVZEROEXTEND(0bin1, 63); 580 x : BITVECTOR(64); 581 y : BITVECTOR(64); 582 z : BITVECTOR(64); 583 mask : BITVECTOR(64) = BVSHL(ONE, z); 584 QUERY( (y & ~mask = y) => 585 ((x & ~mask = y) <=> (x = y OR x = (y | mask))) 586 ); 587 QUERY( (y | mask = y) => 588 ((x | mask = y) <=> (x = y OR x = (y & ~mask))) 589 ); 590 */ 591 592 // Please note that each pattern must be a dual implication (<--> or 593 // iff). One directional implication can create spurious matches. If the 594 // implication is only one-way, an unsatisfiable condition on the left 595 // side can imply a satisfiable condition on the right side. Dual 596 // implication ensures that satisfiable conditions are transformed to 597 // other satisfiable conditions and unsatisfiable conditions are 598 // transformed to other unsatisfiable conditions. 599 600 // Here is a concrete example of a unsatisfiable condition on the left 601 // implying a satisfiable condition on the right: 602 // 603 // mask = (1 << z) 604 // (x & ~mask) == y --> (x == y || x == (y | mask)) 605 // 606 // Substituting y = 3, z = 0 yields: 607 // (x & -2) == 3 --> (x == 3 || x == 2) 608 609 // Pattern match a special case: 610 /* 611 QUERY( (y & ~mask = y) => 612 ((x & ~mask = y) <=> (x = y OR x = (y | mask))) 613 ); 614 */ 615 if (match(ICI->getOperand(0), 616 m_And(m_Value(RHSVal), m_APInt(RHSC)))) { 617 APInt Mask = ~*RHSC; 618 if (Mask.isPowerOf2() && (C->getValue() & ~Mask) == C->getValue()) { 619 // If we already have a value for the switch, it has to match! 620 if (!setValueOnce(RHSVal)) 621 return false; 622 623 Vals.push_back(C); 624 Vals.push_back( 625 ConstantInt::get(C->getContext(), 626 C->getValue() | Mask)); 627 UsedICmps++; 628 return true; 629 } 630 } 631 632 // Pattern match a special case: 633 /* 634 QUERY( (y | mask = y) => 635 ((x | mask = y) <=> (x = y OR x = (y & ~mask))) 636 ); 637 */ 638 if (match(ICI->getOperand(0), 639 m_Or(m_Value(RHSVal), m_APInt(RHSC)))) { 640 APInt Mask = *RHSC; 641 if (Mask.isPowerOf2() && (C->getValue() | Mask) == C->getValue()) { 642 // If we already have a value for the switch, it has to match! 643 if (!setValueOnce(RHSVal)) 644 return false; 645 646 Vals.push_back(C); 647 Vals.push_back(ConstantInt::get(C->getContext(), 648 C->getValue() & ~Mask)); 649 UsedICmps++; 650 return true; 651 } 652 } 653 654 // If we already have a value for the switch, it has to match! 655 if (!setValueOnce(ICI->getOperand(0))) 656 return false; 657 658 UsedICmps++; 659 Vals.push_back(C); 660 return ICI->getOperand(0); 661 } 662 663 // If we have "x ult 3", for example, then we can add 0,1,2 to the set. 664 ConstantRange Span = 665 ConstantRange::makeExactICmpRegion(ICI->getPredicate(), C->getValue()); 666 667 // Shift the range if the compare is fed by an add. This is the range 668 // compare idiom as emitted by instcombine. 669 Value *CandidateVal = I->getOperand(0); 670 if (match(I->getOperand(0), m_Add(m_Value(RHSVal), m_APInt(RHSC)))) { 671 Span = Span.subtract(*RHSC); 672 CandidateVal = RHSVal; 673 } 674 675 // If this is an and/!= check, then we are looking to build the set of 676 // value that *don't* pass the and chain. I.e. to turn "x ugt 2" into 677 // x != 0 && x != 1. 678 if (!isEQ) 679 Span = Span.inverse(); 680 681 // If there are a ton of values, we don't want to make a ginormous switch. 682 if (Span.isSizeLargerThan(8) || Span.isEmptySet()) { 683 return false; 684 } 685 686 // If we already have a value for the switch, it has to match! 687 if (!setValueOnce(CandidateVal)) 688 return false; 689 690 // Add all values from the range to the set 691 for (APInt Tmp = Span.getLower(); Tmp != Span.getUpper(); ++Tmp) 692 Vals.push_back(ConstantInt::get(I->getContext(), Tmp)); 693 694 UsedICmps++; 695 return true; 696 } 697 698 /// Given a potentially 'or'd or 'and'd together collection of icmp 699 /// eq/ne/lt/gt instructions that compare a value against a constant, extract 700 /// the value being compared, and stick the list constants into the Vals 701 /// vector. 702 /// One "Extra" case is allowed to differ from the other. 703 void gather(Value *V) { 704 bool isEQ = match(V, m_LogicalOr(m_Value(), m_Value())); 705 706 // Keep a stack (SmallVector for efficiency) for depth-first traversal 707 SmallVector<Value *, 8> DFT; 708 SmallPtrSet<Value *, 8> Visited; 709 710 // Initialize 711 Visited.insert(V); 712 DFT.push_back(V); 713 714 while (!DFT.empty()) { 715 V = DFT.pop_back_val(); 716 717 if (Instruction *I = dyn_cast<Instruction>(V)) { 718 // If it is a || (or && depending on isEQ), process the operands. 719 Value *Op0, *Op1; 720 if (isEQ ? match(I, m_LogicalOr(m_Value(Op0), m_Value(Op1))) 721 : match(I, m_LogicalAnd(m_Value(Op0), m_Value(Op1)))) { 722 if (Visited.insert(Op1).second) 723 DFT.push_back(Op1); 724 if (Visited.insert(Op0).second) 725 DFT.push_back(Op0); 726 727 continue; 728 } 729 730 // Try to match the current instruction 731 if (matchInstruction(I, isEQ)) 732 // Match succeed, continue the loop 733 continue; 734 } 735 736 // One element of the sequence of || (or &&) could not be match as a 737 // comparison against the same value as the others. 738 // We allow only one "Extra" case to be checked before the switch 739 if (!Extra) { 740 Extra = V; 741 continue; 742 } 743 // Failed to parse a proper sequence, abort now 744 CompValue = nullptr; 745 break; 746 } 747 } 748 }; 749 750 } // end anonymous namespace 751 752 static void EraseTerminatorAndDCECond(Instruction *TI, 753 MemorySSAUpdater *MSSAU = nullptr) { 754 Instruction *Cond = nullptr; 755 if (SwitchInst *SI = dyn_cast<SwitchInst>(TI)) { 756 Cond = dyn_cast<Instruction>(SI->getCondition()); 757 } else if (BranchInst *BI = dyn_cast<BranchInst>(TI)) { 758 if (BI->isConditional()) 759 Cond = dyn_cast<Instruction>(BI->getCondition()); 760 } else if (IndirectBrInst *IBI = dyn_cast<IndirectBrInst>(TI)) { 761 Cond = dyn_cast<Instruction>(IBI->getAddress()); 762 } 763 764 TI->eraseFromParent(); 765 if (Cond) 766 RecursivelyDeleteTriviallyDeadInstructions(Cond, nullptr, MSSAU); 767 } 768 769 /// Return true if the specified terminator checks 770 /// to see if a value is equal to constant integer value. 771 Value *SimplifyCFGOpt::isValueEqualityComparison(Instruction *TI) { 772 Value *CV = nullptr; 773 if (SwitchInst *SI = dyn_cast<SwitchInst>(TI)) { 774 // Do not permit merging of large switch instructions into their 775 // predecessors unless there is only one predecessor. 776 if (!SI->getParent()->hasNPredecessorsOrMore(128 / SI->getNumSuccessors())) 777 CV = SI->getCondition(); 778 } else if (BranchInst *BI = dyn_cast<BranchInst>(TI)) 779 if (BI->isConditional() && BI->getCondition()->hasOneUse()) 780 if (ICmpInst *ICI = dyn_cast<ICmpInst>(BI->getCondition())) { 781 if (ICI->isEquality() && GetConstantInt(ICI->getOperand(1), DL)) 782 CV = ICI->getOperand(0); 783 } 784 785 // Unwrap any lossless ptrtoint cast. 786 if (CV) { 787 if (PtrToIntInst *PTII = dyn_cast<PtrToIntInst>(CV)) { 788 Value *Ptr = PTII->getPointerOperand(); 789 if (PTII->getType() == DL.getIntPtrType(Ptr->getType())) 790 CV = Ptr; 791 } 792 } 793 return CV; 794 } 795 796 /// Given a value comparison instruction, 797 /// decode all of the 'cases' that it represents and return the 'default' block. 798 BasicBlock *SimplifyCFGOpt::GetValueEqualityComparisonCases( 799 Instruction *TI, std::vector<ValueEqualityComparisonCase> &Cases) { 800 if (SwitchInst *SI = dyn_cast<SwitchInst>(TI)) { 801 Cases.reserve(SI->getNumCases()); 802 for (auto Case : SI->cases()) 803 Cases.push_back(ValueEqualityComparisonCase(Case.getCaseValue(), 804 Case.getCaseSuccessor())); 805 return SI->getDefaultDest(); 806 } 807 808 BranchInst *BI = cast<BranchInst>(TI); 809 ICmpInst *ICI = cast<ICmpInst>(BI->getCondition()); 810 BasicBlock *Succ = BI->getSuccessor(ICI->getPredicate() == ICmpInst::ICMP_NE); 811 Cases.push_back(ValueEqualityComparisonCase( 812 GetConstantInt(ICI->getOperand(1), DL), Succ)); 813 return BI->getSuccessor(ICI->getPredicate() == ICmpInst::ICMP_EQ); 814 } 815 816 /// Given a vector of bb/value pairs, remove any entries 817 /// in the list that match the specified block. 818 static void 819 EliminateBlockCases(BasicBlock *BB, 820 std::vector<ValueEqualityComparisonCase> &Cases) { 821 llvm::erase_value(Cases, BB); 822 } 823 824 /// Return true if there are any keys in C1 that exist in C2 as well. 825 static bool ValuesOverlap(std::vector<ValueEqualityComparisonCase> &C1, 826 std::vector<ValueEqualityComparisonCase> &C2) { 827 std::vector<ValueEqualityComparisonCase> *V1 = &C1, *V2 = &C2; 828 829 // Make V1 be smaller than V2. 830 if (V1->size() > V2->size()) 831 std::swap(V1, V2); 832 833 if (V1->empty()) 834 return false; 835 if (V1->size() == 1) { 836 // Just scan V2. 837 ConstantInt *TheVal = (*V1)[0].Value; 838 for (unsigned i = 0, e = V2->size(); i != e; ++i) 839 if (TheVal == (*V2)[i].Value) 840 return true; 841 } 842 843 // Otherwise, just sort both lists and compare element by element. 844 array_pod_sort(V1->begin(), V1->end()); 845 array_pod_sort(V2->begin(), V2->end()); 846 unsigned i1 = 0, i2 = 0, e1 = V1->size(), e2 = V2->size(); 847 while (i1 != e1 && i2 != e2) { 848 if ((*V1)[i1].Value == (*V2)[i2].Value) 849 return true; 850 if ((*V1)[i1].Value < (*V2)[i2].Value) 851 ++i1; 852 else 853 ++i2; 854 } 855 return false; 856 } 857 858 // Set branch weights on SwitchInst. This sets the metadata if there is at 859 // least one non-zero weight. 860 static void setBranchWeights(SwitchInst *SI, ArrayRef<uint32_t> Weights) { 861 // Check that there is at least one non-zero weight. Otherwise, pass 862 // nullptr to setMetadata which will erase the existing metadata. 863 MDNode *N = nullptr; 864 if (llvm::any_of(Weights, [](uint32_t W) { return W != 0; })) 865 N = MDBuilder(SI->getParent()->getContext()).createBranchWeights(Weights); 866 SI->setMetadata(LLVMContext::MD_prof, N); 867 } 868 869 // Similar to the above, but for branch and select instructions that take 870 // exactly 2 weights. 871 static void setBranchWeights(Instruction *I, uint32_t TrueWeight, 872 uint32_t FalseWeight) { 873 assert(isa<BranchInst>(I) || isa<SelectInst>(I)); 874 // Check that there is at least one non-zero weight. Otherwise, pass 875 // nullptr to setMetadata which will erase the existing metadata. 876 MDNode *N = nullptr; 877 if (TrueWeight || FalseWeight) 878 N = MDBuilder(I->getParent()->getContext()) 879 .createBranchWeights(TrueWeight, FalseWeight); 880 I->setMetadata(LLVMContext::MD_prof, N); 881 } 882 883 /// If TI is known to be a terminator instruction and its block is known to 884 /// only have a single predecessor block, check to see if that predecessor is 885 /// also a value comparison with the same value, and if that comparison 886 /// determines the outcome of this comparison. If so, simplify TI. This does a 887 /// very limited form of jump threading. 888 bool SimplifyCFGOpt::SimplifyEqualityComparisonWithOnlyPredecessor( 889 Instruction *TI, BasicBlock *Pred, IRBuilder<> &Builder) { 890 Value *PredVal = isValueEqualityComparison(Pred->getTerminator()); 891 if (!PredVal) 892 return false; // Not a value comparison in predecessor. 893 894 Value *ThisVal = isValueEqualityComparison(TI); 895 assert(ThisVal && "This isn't a value comparison!!"); 896 if (ThisVal != PredVal) 897 return false; // Different predicates. 898 899 // TODO: Preserve branch weight metadata, similarly to how 900 // FoldValueComparisonIntoPredecessors preserves it. 901 902 // Find out information about when control will move from Pred to TI's block. 903 std::vector<ValueEqualityComparisonCase> PredCases; 904 BasicBlock *PredDef = 905 GetValueEqualityComparisonCases(Pred->getTerminator(), PredCases); 906 EliminateBlockCases(PredDef, PredCases); // Remove default from cases. 907 908 // Find information about how control leaves this block. 909 std::vector<ValueEqualityComparisonCase> ThisCases; 910 BasicBlock *ThisDef = GetValueEqualityComparisonCases(TI, ThisCases); 911 EliminateBlockCases(ThisDef, ThisCases); // Remove default from cases. 912 913 // If TI's block is the default block from Pred's comparison, potentially 914 // simplify TI based on this knowledge. 915 if (PredDef == TI->getParent()) { 916 // If we are here, we know that the value is none of those cases listed in 917 // PredCases. If there are any cases in ThisCases that are in PredCases, we 918 // can simplify TI. 919 if (!ValuesOverlap(PredCases, ThisCases)) 920 return false; 921 922 if (isa<BranchInst>(TI)) { 923 // Okay, one of the successors of this condbr is dead. Convert it to a 924 // uncond br. 925 assert(ThisCases.size() == 1 && "Branch can only have one case!"); 926 // Insert the new branch. 927 Instruction *NI = Builder.CreateBr(ThisDef); 928 (void)NI; 929 930 // Remove PHI node entries for the dead edge. 931 ThisCases[0].Dest->removePredecessor(PredDef); 932 933 LLVM_DEBUG(dbgs() << "Threading pred instr: " << *Pred->getTerminator() 934 << "Through successor TI: " << *TI << "Leaving: " << *NI 935 << "\n"); 936 937 EraseTerminatorAndDCECond(TI); 938 939 if (DTU) 940 DTU->applyUpdates( 941 {{DominatorTree::Delete, PredDef, ThisCases[0].Dest}}); 942 943 return true; 944 } 945 946 SwitchInstProfUpdateWrapper SI = *cast<SwitchInst>(TI); 947 // Okay, TI has cases that are statically dead, prune them away. 948 SmallPtrSet<Constant *, 16> DeadCases; 949 for (unsigned i = 0, e = PredCases.size(); i != e; ++i) 950 DeadCases.insert(PredCases[i].Value); 951 952 LLVM_DEBUG(dbgs() << "Threading pred instr: " << *Pred->getTerminator() 953 << "Through successor TI: " << *TI); 954 955 SmallDenseMap<BasicBlock *, int, 8> NumPerSuccessorCases; 956 for (SwitchInst::CaseIt i = SI->case_end(), e = SI->case_begin(); i != e;) { 957 --i; 958 auto *Successor = i->getCaseSuccessor(); 959 if (DTU) 960 ++NumPerSuccessorCases[Successor]; 961 if (DeadCases.count(i->getCaseValue())) { 962 Successor->removePredecessor(PredDef); 963 SI.removeCase(i); 964 if (DTU) 965 --NumPerSuccessorCases[Successor]; 966 } 967 } 968 969 if (DTU) { 970 std::vector<DominatorTree::UpdateType> Updates; 971 for (const std::pair<BasicBlock *, int> &I : NumPerSuccessorCases) 972 if (I.second == 0) 973 Updates.push_back({DominatorTree::Delete, PredDef, I.first}); 974 DTU->applyUpdates(Updates); 975 } 976 977 LLVM_DEBUG(dbgs() << "Leaving: " << *TI << "\n"); 978 return true; 979 } 980 981 // Otherwise, TI's block must correspond to some matched value. Find out 982 // which value (or set of values) this is. 983 ConstantInt *TIV = nullptr; 984 BasicBlock *TIBB = TI->getParent(); 985 for (unsigned i = 0, e = PredCases.size(); i != e; ++i) 986 if (PredCases[i].Dest == TIBB) { 987 if (TIV) 988 return false; // Cannot handle multiple values coming to this block. 989 TIV = PredCases[i].Value; 990 } 991 assert(TIV && "No edge from pred to succ?"); 992 993 // Okay, we found the one constant that our value can be if we get into TI's 994 // BB. Find out which successor will unconditionally be branched to. 995 BasicBlock *TheRealDest = nullptr; 996 for (unsigned i = 0, e = ThisCases.size(); i != e; ++i) 997 if (ThisCases[i].Value == TIV) { 998 TheRealDest = ThisCases[i].Dest; 999 break; 1000 } 1001 1002 // If not handled by any explicit cases, it is handled by the default case. 1003 if (!TheRealDest) 1004 TheRealDest = ThisDef; 1005 1006 SmallPtrSet<BasicBlock *, 2> RemovedSuccs; 1007 1008 // Remove PHI node entries for dead edges. 1009 BasicBlock *CheckEdge = TheRealDest; 1010 for (BasicBlock *Succ : successors(TIBB)) 1011 if (Succ != CheckEdge) { 1012 if (Succ != TheRealDest) 1013 RemovedSuccs.insert(Succ); 1014 Succ->removePredecessor(TIBB); 1015 } else 1016 CheckEdge = nullptr; 1017 1018 // Insert the new branch. 1019 Instruction *NI = Builder.CreateBr(TheRealDest); 1020 (void)NI; 1021 1022 LLVM_DEBUG(dbgs() << "Threading pred instr: " << *Pred->getTerminator() 1023 << "Through successor TI: " << *TI << "Leaving: " << *NI 1024 << "\n"); 1025 1026 EraseTerminatorAndDCECond(TI); 1027 if (DTU) { 1028 SmallVector<DominatorTree::UpdateType, 2> Updates; 1029 Updates.reserve(RemovedSuccs.size()); 1030 for (auto *RemovedSucc : RemovedSuccs) 1031 Updates.push_back({DominatorTree::Delete, TIBB, RemovedSucc}); 1032 DTU->applyUpdates(Updates); 1033 } 1034 return true; 1035 } 1036 1037 namespace { 1038 1039 /// This class implements a stable ordering of constant 1040 /// integers that does not depend on their address. This is important for 1041 /// applications that sort ConstantInt's to ensure uniqueness. 1042 struct ConstantIntOrdering { 1043 bool operator()(const ConstantInt *LHS, const ConstantInt *RHS) const { 1044 return LHS->getValue().ult(RHS->getValue()); 1045 } 1046 }; 1047 1048 } // end anonymous namespace 1049 1050 static int ConstantIntSortPredicate(ConstantInt *const *P1, 1051 ConstantInt *const *P2) { 1052 const ConstantInt *LHS = *P1; 1053 const ConstantInt *RHS = *P2; 1054 if (LHS == RHS) 1055 return 0; 1056 return LHS->getValue().ult(RHS->getValue()) ? 1 : -1; 1057 } 1058 1059 static inline bool HasBranchWeights(const Instruction *I) { 1060 MDNode *ProfMD = I->getMetadata(LLVMContext::MD_prof); 1061 if (ProfMD && ProfMD->getOperand(0)) 1062 if (MDString *MDS = dyn_cast<MDString>(ProfMD->getOperand(0))) 1063 return MDS->getString().equals("branch_weights"); 1064 1065 return false; 1066 } 1067 1068 /// Get Weights of a given terminator, the default weight is at the front 1069 /// of the vector. If TI is a conditional eq, we need to swap the branch-weight 1070 /// metadata. 1071 static void GetBranchWeights(Instruction *TI, 1072 SmallVectorImpl<uint64_t> &Weights) { 1073 MDNode *MD = TI->getMetadata(LLVMContext::MD_prof); 1074 assert(MD); 1075 for (unsigned i = 1, e = MD->getNumOperands(); i < e; ++i) { 1076 ConstantInt *CI = mdconst::extract<ConstantInt>(MD->getOperand(i)); 1077 Weights.push_back(CI->getValue().getZExtValue()); 1078 } 1079 1080 // If TI is a conditional eq, the default case is the false case, 1081 // and the corresponding branch-weight data is at index 2. We swap the 1082 // default weight to be the first entry. 1083 if (BranchInst *BI = dyn_cast<BranchInst>(TI)) { 1084 assert(Weights.size() == 2); 1085 ICmpInst *ICI = cast<ICmpInst>(BI->getCondition()); 1086 if (ICI->getPredicate() == ICmpInst::ICMP_EQ) 1087 std::swap(Weights.front(), Weights.back()); 1088 } 1089 } 1090 1091 /// Keep halving the weights until all can fit in uint32_t. 1092 static void FitWeights(MutableArrayRef<uint64_t> Weights) { 1093 uint64_t Max = *std::max_element(Weights.begin(), Weights.end()); 1094 if (Max > UINT_MAX) { 1095 unsigned Offset = 32 - countLeadingZeros(Max); 1096 for (uint64_t &I : Weights) 1097 I >>= Offset; 1098 } 1099 } 1100 1101 static void CloneInstructionsIntoPredecessorBlockAndUpdateSSAUses( 1102 BasicBlock *BB, BasicBlock *PredBlock, ValueToValueMapTy &VMap) { 1103 Instruction *PTI = PredBlock->getTerminator(); 1104 1105 // If we have bonus instructions, clone them into the predecessor block. 1106 // Note that there may be multiple predecessor blocks, so we cannot move 1107 // bonus instructions to a predecessor block. 1108 for (Instruction &BonusInst : *BB) { 1109 if (isa<DbgInfoIntrinsic>(BonusInst) || BonusInst.isTerminator()) 1110 continue; 1111 1112 Instruction *NewBonusInst = BonusInst.clone(); 1113 1114 if (PTI->getDebugLoc() != NewBonusInst->getDebugLoc()) { 1115 // Unless the instruction has the same !dbg location as the original 1116 // branch, drop it. When we fold the bonus instructions we want to make 1117 // sure we reset their debug locations in order to avoid stepping on 1118 // dead code caused by folding dead branches. 1119 NewBonusInst->setDebugLoc(DebugLoc()); 1120 } 1121 1122 RemapInstruction(NewBonusInst, VMap, 1123 RF_NoModuleLevelChanges | RF_IgnoreMissingLocals); 1124 VMap[&BonusInst] = NewBonusInst; 1125 1126 // If we moved a load, we cannot any longer claim any knowledge about 1127 // its potential value. The previous information might have been valid 1128 // only given the branch precondition. 1129 // For an analogous reason, we must also drop all the metadata whose 1130 // semantics we don't understand. We *can* preserve !annotation, because 1131 // it is tied to the instruction itself, not the value or position. 1132 // Similarly strip attributes on call parameters that may cause UB in 1133 // location the call is moved to. 1134 NewBonusInst->dropUndefImplyingAttrsAndUnknownMetadata( 1135 LLVMContext::MD_annotation); 1136 1137 PredBlock->getInstList().insert(PTI->getIterator(), NewBonusInst); 1138 NewBonusInst->takeName(&BonusInst); 1139 BonusInst.setName(NewBonusInst->getName() + ".old"); 1140 1141 // Update (liveout) uses of bonus instructions, 1142 // now that the bonus instruction has been cloned into predecessor. 1143 // Note that we expect to be in a block-closed SSA form for this to work! 1144 for (Use &U : make_early_inc_range(BonusInst.uses())) { 1145 auto *UI = cast<Instruction>(U.getUser()); 1146 auto *PN = dyn_cast<PHINode>(UI); 1147 if (!PN) { 1148 assert(UI->getParent() == BB && BonusInst.comesBefore(UI) && 1149 "If the user is not a PHI node, then it should be in the same " 1150 "block as, and come after, the original bonus instruction."); 1151 continue; // Keep using the original bonus instruction. 1152 } 1153 // Is this the block-closed SSA form PHI node? 1154 if (PN->getIncomingBlock(U) == BB) 1155 continue; // Great, keep using the original bonus instruction. 1156 // The only other alternative is an "use" when coming from 1157 // the predecessor block - here we should refer to the cloned bonus instr. 1158 assert(PN->getIncomingBlock(U) == PredBlock && 1159 "Not in block-closed SSA form?"); 1160 U.set(NewBonusInst); 1161 } 1162 } 1163 } 1164 1165 bool SimplifyCFGOpt::PerformValueComparisonIntoPredecessorFolding( 1166 Instruction *TI, Value *&CV, Instruction *PTI, IRBuilder<> &Builder) { 1167 BasicBlock *BB = TI->getParent(); 1168 BasicBlock *Pred = PTI->getParent(); 1169 1170 SmallVector<DominatorTree::UpdateType, 32> Updates; 1171 1172 // Figure out which 'cases' to copy from SI to PSI. 1173 std::vector<ValueEqualityComparisonCase> BBCases; 1174 BasicBlock *BBDefault = GetValueEqualityComparisonCases(TI, BBCases); 1175 1176 std::vector<ValueEqualityComparisonCase> PredCases; 1177 BasicBlock *PredDefault = GetValueEqualityComparisonCases(PTI, PredCases); 1178 1179 // Based on whether the default edge from PTI goes to BB or not, fill in 1180 // PredCases and PredDefault with the new switch cases we would like to 1181 // build. 1182 SmallMapVector<BasicBlock *, int, 8> NewSuccessors; 1183 1184 // Update the branch weight metadata along the way 1185 SmallVector<uint64_t, 8> Weights; 1186 bool PredHasWeights = HasBranchWeights(PTI); 1187 bool SuccHasWeights = HasBranchWeights(TI); 1188 1189 if (PredHasWeights) { 1190 GetBranchWeights(PTI, Weights); 1191 // branch-weight metadata is inconsistent here. 1192 if (Weights.size() != 1 + PredCases.size()) 1193 PredHasWeights = SuccHasWeights = false; 1194 } else if (SuccHasWeights) 1195 // If there are no predecessor weights but there are successor weights, 1196 // populate Weights with 1, which will later be scaled to the sum of 1197 // successor's weights 1198 Weights.assign(1 + PredCases.size(), 1); 1199 1200 SmallVector<uint64_t, 8> SuccWeights; 1201 if (SuccHasWeights) { 1202 GetBranchWeights(TI, SuccWeights); 1203 // branch-weight metadata is inconsistent here. 1204 if (SuccWeights.size() != 1 + BBCases.size()) 1205 PredHasWeights = SuccHasWeights = false; 1206 } else if (PredHasWeights) 1207 SuccWeights.assign(1 + BBCases.size(), 1); 1208 1209 if (PredDefault == BB) { 1210 // If this is the default destination from PTI, only the edges in TI 1211 // that don't occur in PTI, or that branch to BB will be activated. 1212 std::set<ConstantInt *, ConstantIntOrdering> PTIHandled; 1213 for (unsigned i = 0, e = PredCases.size(); i != e; ++i) 1214 if (PredCases[i].Dest != BB) 1215 PTIHandled.insert(PredCases[i].Value); 1216 else { 1217 // The default destination is BB, we don't need explicit targets. 1218 std::swap(PredCases[i], PredCases.back()); 1219 1220 if (PredHasWeights || SuccHasWeights) { 1221 // Increase weight for the default case. 1222 Weights[0] += Weights[i + 1]; 1223 std::swap(Weights[i + 1], Weights.back()); 1224 Weights.pop_back(); 1225 } 1226 1227 PredCases.pop_back(); 1228 --i; 1229 --e; 1230 } 1231 1232 // Reconstruct the new switch statement we will be building. 1233 if (PredDefault != BBDefault) { 1234 PredDefault->removePredecessor(Pred); 1235 if (DTU && PredDefault != BB) 1236 Updates.push_back({DominatorTree::Delete, Pred, PredDefault}); 1237 PredDefault = BBDefault; 1238 ++NewSuccessors[BBDefault]; 1239 } 1240 1241 unsigned CasesFromPred = Weights.size(); 1242 uint64_t ValidTotalSuccWeight = 0; 1243 for (unsigned i = 0, e = BBCases.size(); i != e; ++i) 1244 if (!PTIHandled.count(BBCases[i].Value) && BBCases[i].Dest != BBDefault) { 1245 PredCases.push_back(BBCases[i]); 1246 ++NewSuccessors[BBCases[i].Dest]; 1247 if (SuccHasWeights || PredHasWeights) { 1248 // The default weight is at index 0, so weight for the ith case 1249 // should be at index i+1. Scale the cases from successor by 1250 // PredDefaultWeight (Weights[0]). 1251 Weights.push_back(Weights[0] * SuccWeights[i + 1]); 1252 ValidTotalSuccWeight += SuccWeights[i + 1]; 1253 } 1254 } 1255 1256 if (SuccHasWeights || PredHasWeights) { 1257 ValidTotalSuccWeight += SuccWeights[0]; 1258 // Scale the cases from predecessor by ValidTotalSuccWeight. 1259 for (unsigned i = 1; i < CasesFromPred; ++i) 1260 Weights[i] *= ValidTotalSuccWeight; 1261 // Scale the default weight by SuccDefaultWeight (SuccWeights[0]). 1262 Weights[0] *= SuccWeights[0]; 1263 } 1264 } else { 1265 // If this is not the default destination from PSI, only the edges 1266 // in SI that occur in PSI with a destination of BB will be 1267 // activated. 1268 std::set<ConstantInt *, ConstantIntOrdering> PTIHandled; 1269 std::map<ConstantInt *, uint64_t> WeightsForHandled; 1270 for (unsigned i = 0, e = PredCases.size(); i != e; ++i) 1271 if (PredCases[i].Dest == BB) { 1272 PTIHandled.insert(PredCases[i].Value); 1273 1274 if (PredHasWeights || SuccHasWeights) { 1275 WeightsForHandled[PredCases[i].Value] = Weights[i + 1]; 1276 std::swap(Weights[i + 1], Weights.back()); 1277 Weights.pop_back(); 1278 } 1279 1280 std::swap(PredCases[i], PredCases.back()); 1281 PredCases.pop_back(); 1282 --i; 1283 --e; 1284 } 1285 1286 // Okay, now we know which constants were sent to BB from the 1287 // predecessor. Figure out where they will all go now. 1288 for (unsigned i = 0, e = BBCases.size(); i != e; ++i) 1289 if (PTIHandled.count(BBCases[i].Value)) { 1290 // If this is one we are capable of getting... 1291 if (PredHasWeights || SuccHasWeights) 1292 Weights.push_back(WeightsForHandled[BBCases[i].Value]); 1293 PredCases.push_back(BBCases[i]); 1294 ++NewSuccessors[BBCases[i].Dest]; 1295 PTIHandled.erase(BBCases[i].Value); // This constant is taken care of 1296 } 1297 1298 // If there are any constants vectored to BB that TI doesn't handle, 1299 // they must go to the default destination of TI. 1300 for (ConstantInt *I : PTIHandled) { 1301 if (PredHasWeights || SuccHasWeights) 1302 Weights.push_back(WeightsForHandled[I]); 1303 PredCases.push_back(ValueEqualityComparisonCase(I, BBDefault)); 1304 ++NewSuccessors[BBDefault]; 1305 } 1306 } 1307 1308 // Okay, at this point, we know which new successor Pred will get. Make 1309 // sure we update the number of entries in the PHI nodes for these 1310 // successors. 1311 SmallPtrSet<BasicBlock *, 2> SuccsOfPred; 1312 if (DTU) { 1313 SuccsOfPred = {succ_begin(Pred), succ_end(Pred)}; 1314 Updates.reserve(Updates.size() + NewSuccessors.size()); 1315 } 1316 for (const std::pair<BasicBlock *, int /*Num*/> &NewSuccessor : 1317 NewSuccessors) { 1318 for (auto I : seq(0, NewSuccessor.second)) { 1319 (void)I; 1320 AddPredecessorToBlock(NewSuccessor.first, Pred, BB); 1321 } 1322 if (DTU && !SuccsOfPred.contains(NewSuccessor.first)) 1323 Updates.push_back({DominatorTree::Insert, Pred, NewSuccessor.first}); 1324 } 1325 1326 Builder.SetInsertPoint(PTI); 1327 // Convert pointer to int before we switch. 1328 if (CV->getType()->isPointerTy()) { 1329 CV = 1330 Builder.CreatePtrToInt(CV, DL.getIntPtrType(CV->getType()), "magicptr"); 1331 } 1332 1333 // Now that the successors are updated, create the new Switch instruction. 1334 SwitchInst *NewSI = Builder.CreateSwitch(CV, PredDefault, PredCases.size()); 1335 NewSI->setDebugLoc(PTI->getDebugLoc()); 1336 for (ValueEqualityComparisonCase &V : PredCases) 1337 NewSI->addCase(V.Value, V.Dest); 1338 1339 if (PredHasWeights || SuccHasWeights) { 1340 // Halve the weights if any of them cannot fit in an uint32_t 1341 FitWeights(Weights); 1342 1343 SmallVector<uint32_t, 8> MDWeights(Weights.begin(), Weights.end()); 1344 1345 setBranchWeights(NewSI, MDWeights); 1346 } 1347 1348 EraseTerminatorAndDCECond(PTI); 1349 1350 // Okay, last check. If BB is still a successor of PSI, then we must 1351 // have an infinite loop case. If so, add an infinitely looping block 1352 // to handle the case to preserve the behavior of the code. 1353 BasicBlock *InfLoopBlock = nullptr; 1354 for (unsigned i = 0, e = NewSI->getNumSuccessors(); i != e; ++i) 1355 if (NewSI->getSuccessor(i) == BB) { 1356 if (!InfLoopBlock) { 1357 // Insert it at the end of the function, because it's either code, 1358 // or it won't matter if it's hot. :) 1359 InfLoopBlock = 1360 BasicBlock::Create(BB->getContext(), "infloop", BB->getParent()); 1361 BranchInst::Create(InfLoopBlock, InfLoopBlock); 1362 if (DTU) 1363 Updates.push_back( 1364 {DominatorTree::Insert, InfLoopBlock, InfLoopBlock}); 1365 } 1366 NewSI->setSuccessor(i, InfLoopBlock); 1367 } 1368 1369 if (DTU) { 1370 if (InfLoopBlock) 1371 Updates.push_back({DominatorTree::Insert, Pred, InfLoopBlock}); 1372 1373 Updates.push_back({DominatorTree::Delete, Pred, BB}); 1374 1375 DTU->applyUpdates(Updates); 1376 } 1377 1378 ++NumFoldValueComparisonIntoPredecessors; 1379 return true; 1380 } 1381 1382 /// The specified terminator is a value equality comparison instruction 1383 /// (either a switch or a branch on "X == c"). 1384 /// See if any of the predecessors of the terminator block are value comparisons 1385 /// on the same value. If so, and if safe to do so, fold them together. 1386 bool SimplifyCFGOpt::FoldValueComparisonIntoPredecessors(Instruction *TI, 1387 IRBuilder<> &Builder) { 1388 BasicBlock *BB = TI->getParent(); 1389 Value *CV = isValueEqualityComparison(TI); // CondVal 1390 assert(CV && "Not a comparison?"); 1391 1392 bool Changed = false; 1393 1394 SmallSetVector<BasicBlock *, 16> Preds(pred_begin(BB), pred_end(BB)); 1395 while (!Preds.empty()) { 1396 BasicBlock *Pred = Preds.pop_back_val(); 1397 Instruction *PTI = Pred->getTerminator(); 1398 1399 // Don't try to fold into itself. 1400 if (Pred == BB) 1401 continue; 1402 1403 // See if the predecessor is a comparison with the same value. 1404 Value *PCV = isValueEqualityComparison(PTI); // PredCondVal 1405 if (PCV != CV) 1406 continue; 1407 1408 SmallSetVector<BasicBlock *, 4> FailBlocks; 1409 if (!SafeToMergeTerminators(TI, PTI, &FailBlocks)) { 1410 for (auto *Succ : FailBlocks) { 1411 if (!SplitBlockPredecessors(Succ, TI->getParent(), ".fold.split", DTU)) 1412 return false; 1413 } 1414 } 1415 1416 PerformValueComparisonIntoPredecessorFolding(TI, CV, PTI, Builder); 1417 Changed = true; 1418 } 1419 return Changed; 1420 } 1421 1422 // If we would need to insert a select that uses the value of this invoke 1423 // (comments in HoistThenElseCodeToIf explain why we would need to do this), we 1424 // can't hoist the invoke, as there is nowhere to put the select in this case. 1425 static bool isSafeToHoistInvoke(BasicBlock *BB1, BasicBlock *BB2, 1426 Instruction *I1, Instruction *I2) { 1427 for (BasicBlock *Succ : successors(BB1)) { 1428 for (const PHINode &PN : Succ->phis()) { 1429 Value *BB1V = PN.getIncomingValueForBlock(BB1); 1430 Value *BB2V = PN.getIncomingValueForBlock(BB2); 1431 if (BB1V != BB2V && (BB1V == I1 || BB2V == I2)) { 1432 return false; 1433 } 1434 } 1435 } 1436 return true; 1437 } 1438 1439 static bool passingValueIsAlwaysUndefined(Value *V, Instruction *I, bool PtrValueMayBeModified = false); 1440 1441 /// Given a conditional branch that goes to BB1 and BB2, hoist any common code 1442 /// in the two blocks up into the branch block. The caller of this function 1443 /// guarantees that BI's block dominates BB1 and BB2. If EqTermsOnly is given, 1444 /// only perform hoisting in case both blocks only contain a terminator. In that 1445 /// case, only the original BI will be replaced and selects for PHIs are added. 1446 bool SimplifyCFGOpt::HoistThenElseCodeToIf(BranchInst *BI, 1447 const TargetTransformInfo &TTI, 1448 bool EqTermsOnly) { 1449 // This does very trivial matching, with limited scanning, to find identical 1450 // instructions in the two blocks. In particular, we don't want to get into 1451 // O(M*N) situations here where M and N are the sizes of BB1 and BB2. As 1452 // such, we currently just scan for obviously identical instructions in an 1453 // identical order. 1454 BasicBlock *BB1 = BI->getSuccessor(0); // The true destination. 1455 BasicBlock *BB2 = BI->getSuccessor(1); // The false destination 1456 1457 // If either of the blocks has it's address taken, then we can't do this fold, 1458 // because the code we'd hoist would no longer run when we jump into the block 1459 // by it's address. 1460 if (BB1->hasAddressTaken() || BB2->hasAddressTaken()) 1461 return false; 1462 1463 BasicBlock::iterator BB1_Itr = BB1->begin(); 1464 BasicBlock::iterator BB2_Itr = BB2->begin(); 1465 1466 Instruction *I1 = &*BB1_Itr++, *I2 = &*BB2_Itr++; 1467 // Skip debug info if it is not identical. 1468 DbgInfoIntrinsic *DBI1 = dyn_cast<DbgInfoIntrinsic>(I1); 1469 DbgInfoIntrinsic *DBI2 = dyn_cast<DbgInfoIntrinsic>(I2); 1470 if (!DBI1 || !DBI2 || !DBI1->isIdenticalToWhenDefined(DBI2)) { 1471 while (isa<DbgInfoIntrinsic>(I1)) 1472 I1 = &*BB1_Itr++; 1473 while (isa<DbgInfoIntrinsic>(I2)) 1474 I2 = &*BB2_Itr++; 1475 } 1476 if (isa<PHINode>(I1) || !I1->isIdenticalToWhenDefined(I2)) 1477 return false; 1478 1479 BasicBlock *BIParent = BI->getParent(); 1480 1481 bool Changed = false; 1482 1483 auto _ = make_scope_exit([&]() { 1484 if (Changed) 1485 ++NumHoistCommonCode; 1486 }); 1487 1488 // Check if only hoisting terminators is allowed. This does not add new 1489 // instructions to the hoist location. 1490 if (EqTermsOnly) { 1491 // Skip any debug intrinsics, as they are free to hoist. 1492 auto *I1NonDbg = &*skipDebugIntrinsics(I1->getIterator()); 1493 auto *I2NonDbg = &*skipDebugIntrinsics(I2->getIterator()); 1494 if (!I1NonDbg->isIdenticalToWhenDefined(I2NonDbg)) 1495 return false; 1496 if (!I1NonDbg->isTerminator()) 1497 return false; 1498 // Now we know that we only need to hoist debug intrinsics and the 1499 // terminator. Let the loop below handle those 2 cases. 1500 } 1501 1502 do { 1503 // If we are hoisting the terminator instruction, don't move one (making a 1504 // broken BB), instead clone it, and remove BI. 1505 if (I1->isTerminator()) 1506 goto HoistTerminator; 1507 1508 // If we're going to hoist a call, make sure that the two instructions we're 1509 // commoning/hoisting are both marked with musttail, or neither of them is 1510 // marked as such. Otherwise, we might end up in a situation where we hoist 1511 // from a block where the terminator is a `ret` to a block where the terminator 1512 // is a `br`, and `musttail` calls expect to be followed by a return. 1513 auto *C1 = dyn_cast<CallInst>(I1); 1514 auto *C2 = dyn_cast<CallInst>(I2); 1515 if (C1 && C2) 1516 if (C1->isMustTailCall() != C2->isMustTailCall()) 1517 return Changed; 1518 1519 if (!TTI.isProfitableToHoist(I1) || !TTI.isProfitableToHoist(I2)) 1520 return Changed; 1521 1522 // If any of the two call sites has nomerge attribute, stop hoisting. 1523 if (const auto *CB1 = dyn_cast<CallBase>(I1)) 1524 if (CB1->cannotMerge()) 1525 return Changed; 1526 if (const auto *CB2 = dyn_cast<CallBase>(I2)) 1527 if (CB2->cannotMerge()) 1528 return Changed; 1529 1530 if (isa<DbgInfoIntrinsic>(I1) || isa<DbgInfoIntrinsic>(I2)) { 1531 assert (isa<DbgInfoIntrinsic>(I1) && isa<DbgInfoIntrinsic>(I2)); 1532 // The debug location is an integral part of a debug info intrinsic 1533 // and can't be separated from it or replaced. Instead of attempting 1534 // to merge locations, simply hoist both copies of the intrinsic. 1535 BIParent->getInstList().splice(BI->getIterator(), 1536 BB1->getInstList(), I1); 1537 BIParent->getInstList().splice(BI->getIterator(), 1538 BB2->getInstList(), I2); 1539 Changed = true; 1540 } else { 1541 // For a normal instruction, we just move one to right before the branch, 1542 // then replace all uses of the other with the first. Finally, we remove 1543 // the now redundant second instruction. 1544 BIParent->getInstList().splice(BI->getIterator(), 1545 BB1->getInstList(), I1); 1546 if (!I2->use_empty()) 1547 I2->replaceAllUsesWith(I1); 1548 I1->andIRFlags(I2); 1549 unsigned KnownIDs[] = {LLVMContext::MD_tbaa, 1550 LLVMContext::MD_range, 1551 LLVMContext::MD_fpmath, 1552 LLVMContext::MD_invariant_load, 1553 LLVMContext::MD_nonnull, 1554 LLVMContext::MD_invariant_group, 1555 LLVMContext::MD_align, 1556 LLVMContext::MD_dereferenceable, 1557 LLVMContext::MD_dereferenceable_or_null, 1558 LLVMContext::MD_mem_parallel_loop_access, 1559 LLVMContext::MD_access_group, 1560 LLVMContext::MD_preserve_access_index}; 1561 combineMetadata(I1, I2, KnownIDs, true); 1562 1563 // I1 and I2 are being combined into a single instruction. Its debug 1564 // location is the merged locations of the original instructions. 1565 I1->applyMergedLocation(I1->getDebugLoc(), I2->getDebugLoc()); 1566 1567 I2->eraseFromParent(); 1568 Changed = true; 1569 } 1570 ++NumHoistCommonInstrs; 1571 1572 I1 = &*BB1_Itr++; 1573 I2 = &*BB2_Itr++; 1574 // Skip debug info if it is not identical. 1575 DbgInfoIntrinsic *DBI1 = dyn_cast<DbgInfoIntrinsic>(I1); 1576 DbgInfoIntrinsic *DBI2 = dyn_cast<DbgInfoIntrinsic>(I2); 1577 if (!DBI1 || !DBI2 || !DBI1->isIdenticalToWhenDefined(DBI2)) { 1578 while (isa<DbgInfoIntrinsic>(I1)) 1579 I1 = &*BB1_Itr++; 1580 while (isa<DbgInfoIntrinsic>(I2)) 1581 I2 = &*BB2_Itr++; 1582 } 1583 } while (I1->isIdenticalToWhenDefined(I2)); 1584 1585 return true; 1586 1587 HoistTerminator: 1588 // It may not be possible to hoist an invoke. 1589 // FIXME: Can we define a safety predicate for CallBr? 1590 if (isa<InvokeInst>(I1) && !isSafeToHoistInvoke(BB1, BB2, I1, I2)) 1591 return Changed; 1592 1593 // TODO: callbr hoisting currently disabled pending further study. 1594 if (isa<CallBrInst>(I1)) 1595 return Changed; 1596 1597 for (BasicBlock *Succ : successors(BB1)) { 1598 for (PHINode &PN : Succ->phis()) { 1599 Value *BB1V = PN.getIncomingValueForBlock(BB1); 1600 Value *BB2V = PN.getIncomingValueForBlock(BB2); 1601 if (BB1V == BB2V) 1602 continue; 1603 1604 // Check for passingValueIsAlwaysUndefined here because we would rather 1605 // eliminate undefined control flow then converting it to a select. 1606 if (passingValueIsAlwaysUndefined(BB1V, &PN) || 1607 passingValueIsAlwaysUndefined(BB2V, &PN)) 1608 return Changed; 1609 1610 if (isa<ConstantExpr>(BB1V) && !isSafeToSpeculativelyExecute(BB1V)) 1611 return Changed; 1612 if (isa<ConstantExpr>(BB2V) && !isSafeToSpeculativelyExecute(BB2V)) 1613 return Changed; 1614 } 1615 } 1616 1617 // Okay, it is safe to hoist the terminator. 1618 Instruction *NT = I1->clone(); 1619 BIParent->getInstList().insert(BI->getIterator(), NT); 1620 if (!NT->getType()->isVoidTy()) { 1621 I1->replaceAllUsesWith(NT); 1622 I2->replaceAllUsesWith(NT); 1623 NT->takeName(I1); 1624 } 1625 Changed = true; 1626 ++NumHoistCommonInstrs; 1627 1628 // Ensure terminator gets a debug location, even an unknown one, in case 1629 // it involves inlinable calls. 1630 NT->applyMergedLocation(I1->getDebugLoc(), I2->getDebugLoc()); 1631 1632 // PHIs created below will adopt NT's merged DebugLoc. 1633 IRBuilder<NoFolder> Builder(NT); 1634 1635 // Hoisting one of the terminators from our successor is a great thing. 1636 // Unfortunately, the successors of the if/else blocks may have PHI nodes in 1637 // them. If they do, all PHI entries for BB1/BB2 must agree for all PHI 1638 // nodes, so we insert select instruction to compute the final result. 1639 std::map<std::pair<Value *, Value *>, SelectInst *> InsertedSelects; 1640 for (BasicBlock *Succ : successors(BB1)) { 1641 for (PHINode &PN : Succ->phis()) { 1642 Value *BB1V = PN.getIncomingValueForBlock(BB1); 1643 Value *BB2V = PN.getIncomingValueForBlock(BB2); 1644 if (BB1V == BB2V) 1645 continue; 1646 1647 // These values do not agree. Insert a select instruction before NT 1648 // that determines the right value. 1649 SelectInst *&SI = InsertedSelects[std::make_pair(BB1V, BB2V)]; 1650 if (!SI) { 1651 // Propagate fast-math-flags from phi node to its replacement select. 1652 IRBuilder<>::FastMathFlagGuard FMFGuard(Builder); 1653 if (isa<FPMathOperator>(PN)) 1654 Builder.setFastMathFlags(PN.getFastMathFlags()); 1655 1656 SI = cast<SelectInst>( 1657 Builder.CreateSelect(BI->getCondition(), BB1V, BB2V, 1658 BB1V->getName() + "." + BB2V->getName(), BI)); 1659 } 1660 1661 // Make the PHI node use the select for all incoming values for BB1/BB2 1662 for (unsigned i = 0, e = PN.getNumIncomingValues(); i != e; ++i) 1663 if (PN.getIncomingBlock(i) == BB1 || PN.getIncomingBlock(i) == BB2) 1664 PN.setIncomingValue(i, SI); 1665 } 1666 } 1667 1668 SmallVector<DominatorTree::UpdateType, 4> Updates; 1669 1670 // Update any PHI nodes in our new successors. 1671 for (BasicBlock *Succ : successors(BB1)) { 1672 AddPredecessorToBlock(Succ, BIParent, BB1); 1673 if (DTU) 1674 Updates.push_back({DominatorTree::Insert, BIParent, Succ}); 1675 } 1676 1677 if (DTU) 1678 for (BasicBlock *Succ : successors(BI)) 1679 Updates.push_back({DominatorTree::Delete, BIParent, Succ}); 1680 1681 EraseTerminatorAndDCECond(BI); 1682 if (DTU) 1683 DTU->applyUpdates(Updates); 1684 return Changed; 1685 } 1686 1687 // Check lifetime markers. 1688 static bool isLifeTimeMarker(const Instruction *I) { 1689 if (auto II = dyn_cast<IntrinsicInst>(I)) { 1690 switch (II->getIntrinsicID()) { 1691 default: 1692 break; 1693 case Intrinsic::lifetime_start: 1694 case Intrinsic::lifetime_end: 1695 return true; 1696 } 1697 } 1698 return false; 1699 } 1700 1701 // TODO: Refine this. This should avoid cases like turning constant memcpy sizes 1702 // into variables. 1703 static bool replacingOperandWithVariableIsCheap(const Instruction *I, 1704 int OpIdx) { 1705 return !isa<IntrinsicInst>(I); 1706 } 1707 1708 // All instructions in Insts belong to different blocks that all unconditionally 1709 // branch to a common successor. Analyze each instruction and return true if it 1710 // would be possible to sink them into their successor, creating one common 1711 // instruction instead. For every value that would be required to be provided by 1712 // PHI node (because an operand varies in each input block), add to PHIOperands. 1713 static bool canSinkInstructions( 1714 ArrayRef<Instruction *> Insts, 1715 DenseMap<Instruction *, SmallVector<Value *, 4>> &PHIOperands) { 1716 // Prune out obviously bad instructions to move. Each instruction must have 1717 // exactly zero or one use, and we check later that use is by a single, common 1718 // PHI instruction in the successor. 1719 bool HasUse = !Insts.front()->user_empty(); 1720 for (auto *I : Insts) { 1721 // These instructions may change or break semantics if moved. 1722 if (isa<PHINode>(I) || I->isEHPad() || isa<AllocaInst>(I) || 1723 I->getType()->isTokenTy()) 1724 return false; 1725 1726 // Do not try to sink an instruction in an infinite loop - it can cause 1727 // this algorithm to infinite loop. 1728 if (I->getParent()->getSingleSuccessor() == I->getParent()) 1729 return false; 1730 1731 // Conservatively return false if I is an inline-asm instruction. Sinking 1732 // and merging inline-asm instructions can potentially create arguments 1733 // that cannot satisfy the inline-asm constraints. 1734 // If the instruction has nomerge attribute, return false. 1735 if (const auto *C = dyn_cast<CallBase>(I)) 1736 if (C->isInlineAsm() || C->cannotMerge()) 1737 return false; 1738 1739 // Each instruction must have zero or one use. 1740 if (HasUse && !I->hasOneUse()) 1741 return false; 1742 if (!HasUse && !I->user_empty()) 1743 return false; 1744 } 1745 1746 const Instruction *I0 = Insts.front(); 1747 for (auto *I : Insts) 1748 if (!I->isSameOperationAs(I0)) 1749 return false; 1750 1751 // All instructions in Insts are known to be the same opcode. If they have a 1752 // use, check that the only user is a PHI or in the same block as the 1753 // instruction, because if a user is in the same block as an instruction we're 1754 // contemplating sinking, it must already be determined to be sinkable. 1755 if (HasUse) { 1756 auto *PNUse = dyn_cast<PHINode>(*I0->user_begin()); 1757 auto *Succ = I0->getParent()->getTerminator()->getSuccessor(0); 1758 if (!all_of(Insts, [&PNUse,&Succ](const Instruction *I) -> bool { 1759 auto *U = cast<Instruction>(*I->user_begin()); 1760 return (PNUse && 1761 PNUse->getParent() == Succ && 1762 PNUse->getIncomingValueForBlock(I->getParent()) == I) || 1763 U->getParent() == I->getParent(); 1764 })) 1765 return false; 1766 } 1767 1768 // Because SROA can't handle speculating stores of selects, try not to sink 1769 // loads, stores or lifetime markers of allocas when we'd have to create a 1770 // PHI for the address operand. Also, because it is likely that loads or 1771 // stores of allocas will disappear when Mem2Reg/SROA is run, don't sink 1772 // them. 1773 // This can cause code churn which can have unintended consequences down 1774 // the line - see https://llvm.org/bugs/show_bug.cgi?id=30244. 1775 // FIXME: This is a workaround for a deficiency in SROA - see 1776 // https://llvm.org/bugs/show_bug.cgi?id=30188 1777 if (isa<StoreInst>(I0) && any_of(Insts, [](const Instruction *I) { 1778 return isa<AllocaInst>(I->getOperand(1)->stripPointerCasts()); 1779 })) 1780 return false; 1781 if (isa<LoadInst>(I0) && any_of(Insts, [](const Instruction *I) { 1782 return isa<AllocaInst>(I->getOperand(0)->stripPointerCasts()); 1783 })) 1784 return false; 1785 if (isLifeTimeMarker(I0) && any_of(Insts, [](const Instruction *I) { 1786 return isa<AllocaInst>(I->getOperand(1)->stripPointerCasts()); 1787 })) 1788 return false; 1789 1790 // For calls to be sinkable, they must all be indirect, or have same callee. 1791 // I.e. if we have two direct calls to different callees, we don't want to 1792 // turn that into an indirect call. Likewise, if we have an indirect call, 1793 // and a direct call, we don't actually want to have a single indirect call. 1794 if (isa<CallBase>(I0)) { 1795 auto IsIndirectCall = [](const Instruction *I) { 1796 return cast<CallBase>(I)->isIndirectCall(); 1797 }; 1798 bool HaveIndirectCalls = any_of(Insts, IsIndirectCall); 1799 bool AllCallsAreIndirect = all_of(Insts, IsIndirectCall); 1800 if (HaveIndirectCalls) { 1801 if (!AllCallsAreIndirect) 1802 return false; 1803 } else { 1804 // All callees must be identical. 1805 Value *Callee = nullptr; 1806 for (const Instruction *I : Insts) { 1807 Value *CurrCallee = cast<CallBase>(I)->getCalledOperand(); 1808 if (!Callee) 1809 Callee = CurrCallee; 1810 else if (Callee != CurrCallee) 1811 return false; 1812 } 1813 } 1814 } 1815 1816 for (unsigned OI = 0, OE = I0->getNumOperands(); OI != OE; ++OI) { 1817 Value *Op = I0->getOperand(OI); 1818 if (Op->getType()->isTokenTy()) 1819 // Don't touch any operand of token type. 1820 return false; 1821 1822 auto SameAsI0 = [&I0, OI](const Instruction *I) { 1823 assert(I->getNumOperands() == I0->getNumOperands()); 1824 return I->getOperand(OI) == I0->getOperand(OI); 1825 }; 1826 if (!all_of(Insts, SameAsI0)) { 1827 if ((isa<Constant>(Op) && !replacingOperandWithVariableIsCheap(I0, OI)) || 1828 !canReplaceOperandWithVariable(I0, OI)) 1829 // We can't create a PHI from this GEP. 1830 return false; 1831 for (auto *I : Insts) 1832 PHIOperands[I].push_back(I->getOperand(OI)); 1833 } 1834 } 1835 return true; 1836 } 1837 1838 // Assuming canSinkInstructions(Blocks) has returned true, sink the last 1839 // instruction of every block in Blocks to their common successor, commoning 1840 // into one instruction. 1841 static bool sinkLastInstruction(ArrayRef<BasicBlock*> Blocks) { 1842 auto *BBEnd = Blocks[0]->getTerminator()->getSuccessor(0); 1843 1844 // canSinkInstructions returning true guarantees that every block has at 1845 // least one non-terminator instruction. 1846 SmallVector<Instruction*,4> Insts; 1847 for (auto *BB : Blocks) { 1848 Instruction *I = BB->getTerminator(); 1849 do { 1850 I = I->getPrevNode(); 1851 } while (isa<DbgInfoIntrinsic>(I) && I != &BB->front()); 1852 if (!isa<DbgInfoIntrinsic>(I)) 1853 Insts.push_back(I); 1854 } 1855 1856 // The only checking we need to do now is that all users of all instructions 1857 // are the same PHI node. canSinkInstructions should have checked this but 1858 // it is slightly over-aggressive - it gets confused by commutative 1859 // instructions so double-check it here. 1860 Instruction *I0 = Insts.front(); 1861 if (!I0->user_empty()) { 1862 auto *PNUse = dyn_cast<PHINode>(*I0->user_begin()); 1863 if (!all_of(Insts, [&PNUse](const Instruction *I) -> bool { 1864 auto *U = cast<Instruction>(*I->user_begin()); 1865 return U == PNUse; 1866 })) 1867 return false; 1868 } 1869 1870 // We don't need to do any more checking here; canSinkInstructions should 1871 // have done it all for us. 1872 SmallVector<Value*, 4> NewOperands; 1873 for (unsigned O = 0, E = I0->getNumOperands(); O != E; ++O) { 1874 // This check is different to that in canSinkInstructions. There, we 1875 // cared about the global view once simplifycfg (and instcombine) have 1876 // completed - it takes into account PHIs that become trivially 1877 // simplifiable. However here we need a more local view; if an operand 1878 // differs we create a PHI and rely on instcombine to clean up the very 1879 // small mess we may make. 1880 bool NeedPHI = any_of(Insts, [&I0, O](const Instruction *I) { 1881 return I->getOperand(O) != I0->getOperand(O); 1882 }); 1883 if (!NeedPHI) { 1884 NewOperands.push_back(I0->getOperand(O)); 1885 continue; 1886 } 1887 1888 // Create a new PHI in the successor block and populate it. 1889 auto *Op = I0->getOperand(O); 1890 assert(!Op->getType()->isTokenTy() && "Can't PHI tokens!"); 1891 auto *PN = PHINode::Create(Op->getType(), Insts.size(), 1892 Op->getName() + ".sink", &BBEnd->front()); 1893 for (auto *I : Insts) 1894 PN->addIncoming(I->getOperand(O), I->getParent()); 1895 NewOperands.push_back(PN); 1896 } 1897 1898 // Arbitrarily use I0 as the new "common" instruction; remap its operands 1899 // and move it to the start of the successor block. 1900 for (unsigned O = 0, E = I0->getNumOperands(); O != E; ++O) 1901 I0->getOperandUse(O).set(NewOperands[O]); 1902 I0->moveBefore(&*BBEnd->getFirstInsertionPt()); 1903 1904 // Update metadata and IR flags, and merge debug locations. 1905 for (auto *I : Insts) 1906 if (I != I0) { 1907 // The debug location for the "common" instruction is the merged locations 1908 // of all the commoned instructions. We start with the original location 1909 // of the "common" instruction and iteratively merge each location in the 1910 // loop below. 1911 // This is an N-way merge, which will be inefficient if I0 is a CallInst. 1912 // However, as N-way merge for CallInst is rare, so we use simplified API 1913 // instead of using complex API for N-way merge. 1914 I0->applyMergedLocation(I0->getDebugLoc(), I->getDebugLoc()); 1915 combineMetadataForCSE(I0, I, true); 1916 I0->andIRFlags(I); 1917 } 1918 1919 if (!I0->user_empty()) { 1920 // canSinkLastInstruction checked that all instructions were used by 1921 // one and only one PHI node. Find that now, RAUW it to our common 1922 // instruction and nuke it. 1923 auto *PN = cast<PHINode>(*I0->user_begin()); 1924 PN->replaceAllUsesWith(I0); 1925 PN->eraseFromParent(); 1926 } 1927 1928 // Finally nuke all instructions apart from the common instruction. 1929 for (auto *I : Insts) 1930 if (I != I0) 1931 I->eraseFromParent(); 1932 1933 return true; 1934 } 1935 1936 namespace { 1937 1938 // LockstepReverseIterator - Iterates through instructions 1939 // in a set of blocks in reverse order from the first non-terminator. 1940 // For example (assume all blocks have size n): 1941 // LockstepReverseIterator I([B1, B2, B3]); 1942 // *I-- = [B1[n], B2[n], B3[n]]; 1943 // *I-- = [B1[n-1], B2[n-1], B3[n-1]]; 1944 // *I-- = [B1[n-2], B2[n-2], B3[n-2]]; 1945 // ... 1946 class LockstepReverseIterator { 1947 ArrayRef<BasicBlock*> Blocks; 1948 SmallVector<Instruction*,4> Insts; 1949 bool Fail; 1950 1951 public: 1952 LockstepReverseIterator(ArrayRef<BasicBlock*> Blocks) : Blocks(Blocks) { 1953 reset(); 1954 } 1955 1956 void reset() { 1957 Fail = false; 1958 Insts.clear(); 1959 for (auto *BB : Blocks) { 1960 Instruction *Inst = BB->getTerminator(); 1961 for (Inst = Inst->getPrevNode(); Inst && isa<DbgInfoIntrinsic>(Inst);) 1962 Inst = Inst->getPrevNode(); 1963 if (!Inst) { 1964 // Block wasn't big enough. 1965 Fail = true; 1966 return; 1967 } 1968 Insts.push_back(Inst); 1969 } 1970 } 1971 1972 bool isValid() const { 1973 return !Fail; 1974 } 1975 1976 void operator--() { 1977 if (Fail) 1978 return; 1979 for (auto *&Inst : Insts) { 1980 for (Inst = Inst->getPrevNode(); Inst && isa<DbgInfoIntrinsic>(Inst);) 1981 Inst = Inst->getPrevNode(); 1982 // Already at beginning of block. 1983 if (!Inst) { 1984 Fail = true; 1985 return; 1986 } 1987 } 1988 } 1989 1990 void operator++() { 1991 if (Fail) 1992 return; 1993 for (auto *&Inst : Insts) { 1994 for (Inst = Inst->getNextNode(); Inst && isa<DbgInfoIntrinsic>(Inst);) 1995 Inst = Inst->getNextNode(); 1996 // Already at end of block. 1997 if (!Inst) { 1998 Fail = true; 1999 return; 2000 } 2001 } 2002 } 2003 2004 ArrayRef<Instruction*> operator * () const { 2005 return Insts; 2006 } 2007 }; 2008 2009 } // end anonymous namespace 2010 2011 /// Check whether BB's predecessors end with unconditional branches. If it is 2012 /// true, sink any common code from the predecessors to BB. 2013 static bool SinkCommonCodeFromPredecessors(BasicBlock *BB, 2014 DomTreeUpdater *DTU) { 2015 // We support two situations: 2016 // (1) all incoming arcs are unconditional 2017 // (2) there are non-unconditional incoming arcs 2018 // 2019 // (2) is very common in switch defaults and 2020 // else-if patterns; 2021 // 2022 // if (a) f(1); 2023 // else if (b) f(2); 2024 // 2025 // produces: 2026 // 2027 // [if] 2028 // / \ 2029 // [f(1)] [if] 2030 // | | \ 2031 // | | | 2032 // | [f(2)]| 2033 // \ | / 2034 // [ end ] 2035 // 2036 // [end] has two unconditional predecessor arcs and one conditional. The 2037 // conditional refers to the implicit empty 'else' arc. This conditional 2038 // arc can also be caused by an empty default block in a switch. 2039 // 2040 // In this case, we attempt to sink code from all *unconditional* arcs. 2041 // If we can sink instructions from these arcs (determined during the scan 2042 // phase below) we insert a common successor for all unconditional arcs and 2043 // connect that to [end], to enable sinking: 2044 // 2045 // [if] 2046 // / \ 2047 // [x(1)] [if] 2048 // | | \ 2049 // | | \ 2050 // | [x(2)] | 2051 // \ / | 2052 // [sink.split] | 2053 // \ / 2054 // [ end ] 2055 // 2056 SmallVector<BasicBlock*,4> UnconditionalPreds; 2057 bool HaveNonUnconditionalPredecessors = false; 2058 for (auto *PredBB : predecessors(BB)) { 2059 auto *PredBr = dyn_cast<BranchInst>(PredBB->getTerminator()); 2060 if (PredBr && PredBr->isUnconditional()) 2061 UnconditionalPreds.push_back(PredBB); 2062 else 2063 HaveNonUnconditionalPredecessors = true; 2064 } 2065 if (UnconditionalPreds.size() < 2) 2066 return false; 2067 2068 // We take a two-step approach to tail sinking. First we scan from the end of 2069 // each block upwards in lockstep. If the n'th instruction from the end of each 2070 // block can be sunk, those instructions are added to ValuesToSink and we 2071 // carry on. If we can sink an instruction but need to PHI-merge some operands 2072 // (because they're not identical in each instruction) we add these to 2073 // PHIOperands. 2074 int ScanIdx = 0; 2075 SmallPtrSet<Value*,4> InstructionsToSink; 2076 DenseMap<Instruction*, SmallVector<Value*,4>> PHIOperands; 2077 LockstepReverseIterator LRI(UnconditionalPreds); 2078 while (LRI.isValid() && 2079 canSinkInstructions(*LRI, PHIOperands)) { 2080 LLVM_DEBUG(dbgs() << "SINK: instruction can be sunk: " << *(*LRI)[0] 2081 << "\n"); 2082 InstructionsToSink.insert((*LRI).begin(), (*LRI).end()); 2083 ++ScanIdx; 2084 --LRI; 2085 } 2086 2087 // If no instructions can be sunk, early-return. 2088 if (ScanIdx == 0) 2089 return false; 2090 2091 bool followedByDeoptOrUnreachable = IsBlockFollowedByDeoptOrUnreachable(BB); 2092 2093 if (!followedByDeoptOrUnreachable) { 2094 // Okay, we *could* sink last ScanIdx instructions. But how many can we 2095 // actually sink before encountering instruction that is unprofitable to 2096 // sink? 2097 auto ProfitableToSinkInstruction = [&](LockstepReverseIterator &LRI) { 2098 unsigned NumPHIdValues = 0; 2099 for (auto *I : *LRI) 2100 for (auto *V : PHIOperands[I]) { 2101 if (!InstructionsToSink.contains(V)) 2102 ++NumPHIdValues; 2103 // FIXME: this check is overly optimistic. We may end up not sinking 2104 // said instruction, due to the very same profitability check. 2105 // See @creating_too_many_phis in sink-common-code.ll. 2106 } 2107 LLVM_DEBUG(dbgs() << "SINK: #phid values: " << NumPHIdValues << "\n"); 2108 unsigned NumPHIInsts = NumPHIdValues / UnconditionalPreds.size(); 2109 if ((NumPHIdValues % UnconditionalPreds.size()) != 0) 2110 NumPHIInsts++; 2111 2112 return NumPHIInsts <= 1; 2113 }; 2114 2115 // We've determined that we are going to sink last ScanIdx instructions, 2116 // and recorded them in InstructionsToSink. Now, some instructions may be 2117 // unprofitable to sink. But that determination depends on the instructions 2118 // that we are going to sink. 2119 2120 // First, forward scan: find the first instruction unprofitable to sink, 2121 // recording all the ones that are profitable to sink. 2122 // FIXME: would it be better, after we detect that not all are profitable. 2123 // to either record the profitable ones, or erase the unprofitable ones? 2124 // Maybe we need to choose (at runtime) the one that will touch least 2125 // instrs? 2126 LRI.reset(); 2127 int Idx = 0; 2128 SmallPtrSet<Value *, 4> InstructionsProfitableToSink; 2129 while (Idx < ScanIdx) { 2130 if (!ProfitableToSinkInstruction(LRI)) { 2131 // Too many PHIs would be created. 2132 LLVM_DEBUG( 2133 dbgs() << "SINK: stopping here, too many PHIs would be created!\n"); 2134 break; 2135 } 2136 InstructionsProfitableToSink.insert((*LRI).begin(), (*LRI).end()); 2137 --LRI; 2138 ++Idx; 2139 } 2140 2141 // If no instructions can be sunk, early-return. 2142 if (Idx == 0) 2143 return false; 2144 2145 // Did we determine that (only) some instructions are unprofitable to sink? 2146 if (Idx < ScanIdx) { 2147 // Okay, some instructions are unprofitable. 2148 ScanIdx = Idx; 2149 InstructionsToSink = InstructionsProfitableToSink; 2150 2151 // But, that may make other instructions unprofitable, too. 2152 // So, do a backward scan, do any earlier instructions become 2153 // unprofitable? 2154 assert( 2155 !ProfitableToSinkInstruction(LRI) && 2156 "We already know that the last instruction is unprofitable to sink"); 2157 ++LRI; 2158 --Idx; 2159 while (Idx >= 0) { 2160 // If we detect that an instruction becomes unprofitable to sink, 2161 // all earlier instructions won't be sunk either, 2162 // so preemptively keep InstructionsProfitableToSink in sync. 2163 // FIXME: is this the most performant approach? 2164 for (auto *I : *LRI) 2165 InstructionsProfitableToSink.erase(I); 2166 if (!ProfitableToSinkInstruction(LRI)) { 2167 // Everything starting with this instruction won't be sunk. 2168 ScanIdx = Idx; 2169 InstructionsToSink = InstructionsProfitableToSink; 2170 } 2171 ++LRI; 2172 --Idx; 2173 } 2174 } 2175 2176 // If no instructions can be sunk, early-return. 2177 if (ScanIdx == 0) 2178 return false; 2179 } 2180 2181 bool Changed = false; 2182 2183 if (HaveNonUnconditionalPredecessors) { 2184 if (!followedByDeoptOrUnreachable) { 2185 // It is always legal to sink common instructions from unconditional 2186 // predecessors. However, if not all predecessors are unconditional, 2187 // this transformation might be pessimizing. So as a rule of thumb, 2188 // don't do it unless we'd sink at least one non-speculatable instruction. 2189 // See https://bugs.llvm.org/show_bug.cgi?id=30244 2190 LRI.reset(); 2191 int Idx = 0; 2192 bool Profitable = false; 2193 while (Idx < ScanIdx) { 2194 if (!isSafeToSpeculativelyExecute((*LRI)[0])) { 2195 Profitable = true; 2196 break; 2197 } 2198 --LRI; 2199 ++Idx; 2200 } 2201 if (!Profitable) 2202 return false; 2203 } 2204 2205 LLVM_DEBUG(dbgs() << "SINK: Splitting edge\n"); 2206 // We have a conditional edge and we're going to sink some instructions. 2207 // Insert a new block postdominating all blocks we're going to sink from. 2208 if (!SplitBlockPredecessors(BB, UnconditionalPreds, ".sink.split", DTU)) 2209 // Edges couldn't be split. 2210 return false; 2211 Changed = true; 2212 } 2213 2214 // Now that we've analyzed all potential sinking candidates, perform the 2215 // actual sink. We iteratively sink the last non-terminator of the source 2216 // blocks into their common successor unless doing so would require too 2217 // many PHI instructions to be generated (currently only one PHI is allowed 2218 // per sunk instruction). 2219 // 2220 // We can use InstructionsToSink to discount values needing PHI-merging that will 2221 // actually be sunk in a later iteration. This allows us to be more 2222 // aggressive in what we sink. This does allow a false positive where we 2223 // sink presuming a later value will also be sunk, but stop half way through 2224 // and never actually sink it which means we produce more PHIs than intended. 2225 // This is unlikely in practice though. 2226 int SinkIdx = 0; 2227 for (; SinkIdx != ScanIdx; ++SinkIdx) { 2228 LLVM_DEBUG(dbgs() << "SINK: Sink: " 2229 << *UnconditionalPreds[0]->getTerminator()->getPrevNode() 2230 << "\n"); 2231 2232 // Because we've sunk every instruction in turn, the current instruction to 2233 // sink is always at index 0. 2234 LRI.reset(); 2235 2236 if (!sinkLastInstruction(UnconditionalPreds)) { 2237 LLVM_DEBUG( 2238 dbgs() 2239 << "SINK: stopping here, failed to actually sink instruction!\n"); 2240 break; 2241 } 2242 2243 NumSinkCommonInstrs++; 2244 Changed = true; 2245 } 2246 if (SinkIdx != 0) 2247 ++NumSinkCommonCode; 2248 return Changed; 2249 } 2250 2251 namespace { 2252 2253 struct CompatibleSets { 2254 using SetTy = SmallVector<InvokeInst *, 2>; 2255 2256 SmallVector<SetTy, 1> Sets; 2257 2258 static bool shouldBelongToSameSet(ArrayRef<InvokeInst *> Invokes); 2259 2260 SetTy &getCompatibleSet(InvokeInst *II); 2261 2262 void insert(InvokeInst *II); 2263 }; 2264 2265 CompatibleSets::SetTy &CompatibleSets::getCompatibleSet(InvokeInst *II) { 2266 // Perform a linear scan over all the existing sets, see if the new `invoke` 2267 // is compatible with any particular set. Since we know that all the `invokes` 2268 // within a set are compatible, only check the first `invoke` in each set. 2269 // WARNING: at worst, this has quadratic complexity. 2270 for (CompatibleSets::SetTy &Set : Sets) { 2271 if (CompatibleSets::shouldBelongToSameSet({Set.front(), II})) 2272 return Set; 2273 } 2274 2275 // Otherwise, we either had no sets yet, or this invoke forms a new set. 2276 return Sets.emplace_back(); 2277 } 2278 2279 void CompatibleSets::insert(InvokeInst *II) { 2280 getCompatibleSet(II).emplace_back(II); 2281 } 2282 2283 bool CompatibleSets::shouldBelongToSameSet(ArrayRef<InvokeInst *> Invokes) { 2284 assert(Invokes.size() == 2 && "Always called with exactly two candidates."); 2285 2286 // Can we theoretically merge these `invoke`s? 2287 auto IsIllegalToMerge = [](InvokeInst *II) { 2288 return II->cannotMerge() || II->isInlineAsm(); 2289 }; 2290 if (any_of(Invokes, IsIllegalToMerge)) 2291 return false; 2292 2293 // Either both `invoke`s must be direct, 2294 // or both `invoke`s must be indirect. 2295 auto IsIndirectCall = [](InvokeInst *II) { return II->isIndirectCall(); }; 2296 bool HaveIndirectCalls = any_of(Invokes, IsIndirectCall); 2297 bool AllCallsAreIndirect = all_of(Invokes, IsIndirectCall); 2298 if (HaveIndirectCalls) { 2299 if (!AllCallsAreIndirect) 2300 return false; 2301 } else { 2302 // All callees must be identical. 2303 Value *Callee = nullptr; 2304 for (InvokeInst *II : Invokes) { 2305 Value *CurrCallee = II->getCalledOperand(); 2306 assert(CurrCallee && "There is always a called operand."); 2307 if (!Callee) 2308 Callee = CurrCallee; 2309 else if (Callee != CurrCallee) 2310 return false; 2311 } 2312 } 2313 2314 // Either both `invoke`s must not have a normal destination, 2315 // or both `invoke`s must have a normal destination, 2316 auto HasNormalDest = [](InvokeInst *II) { 2317 return !isa<UnreachableInst>(II->getNormalDest()->getFirstNonPHIOrDbg()); 2318 }; 2319 if (any_of(Invokes, HasNormalDest)) { 2320 // Do not merge `invoke` that does not have a normal destination with one 2321 // that does have a normal destination, even though doing so would be legal. 2322 if (!all_of(Invokes, HasNormalDest)) 2323 return false; 2324 2325 // All normal destinations must be identical. 2326 BasicBlock *NormalBB = nullptr; 2327 for (InvokeInst *II : Invokes) { 2328 BasicBlock *CurrNormalBB = II->getNormalDest(); 2329 assert(CurrNormalBB && "There is always a 'continue to' basic block."); 2330 if (!NormalBB) 2331 NormalBB = CurrNormalBB; 2332 else if (NormalBB != CurrNormalBB) 2333 return false; 2334 } 2335 2336 // In the normal destination, the incoming values for these two `invoke`s 2337 // must be compatible. 2338 SmallPtrSet<Value *, 16> EquivalenceSet(Invokes.begin(), Invokes.end()); 2339 if (!IncomingValuesAreCompatible( 2340 NormalBB, {Invokes[0]->getParent(), Invokes[1]->getParent()}, 2341 &EquivalenceSet)) 2342 return false; 2343 } 2344 2345 #ifndef NDEBUG 2346 // All unwind destinations must be identical. 2347 // We know that because we have started from said unwind destination. 2348 BasicBlock *UnwindBB = nullptr; 2349 for (InvokeInst *II : Invokes) { 2350 BasicBlock *CurrUnwindBB = II->getUnwindDest(); 2351 assert(CurrUnwindBB && "There is always an 'unwind to' basic block."); 2352 if (!UnwindBB) 2353 UnwindBB = CurrUnwindBB; 2354 else 2355 assert(UnwindBB == CurrUnwindBB && "Unexpected unwind destination."); 2356 } 2357 #endif 2358 2359 // In the unwind destination, the incoming values for these two `invoke`s 2360 // must be compatible. 2361 if (!IncomingValuesAreCompatible( 2362 Invokes.front()->getUnwindDest(), 2363 {Invokes[0]->getParent(), Invokes[1]->getParent()})) 2364 return false; 2365 2366 // Ignoring arguments, these `invoke`s must be identical, 2367 // including operand bundles. 2368 const InvokeInst *II0 = Invokes.front(); 2369 for (auto *II : Invokes.drop_front()) 2370 if (!II->isSameOperationAs(II0)) 2371 return false; 2372 2373 // Can we theoretically form the data operands for the merged `invoke`? 2374 auto IsIllegalToMergeArguments = [](auto Ops) { 2375 Type *Ty = std::get<0>(Ops)->getType(); 2376 assert(Ty == std::get<1>(Ops)->getType() && "Incompatible types?"); 2377 return Ty->isTokenTy() && std::get<0>(Ops) != std::get<1>(Ops); 2378 }; 2379 assert(Invokes.size() == 2 && "Always called with exactly two candidates."); 2380 if (any_of(zip(Invokes[0]->data_ops(), Invokes[1]->data_ops()), 2381 IsIllegalToMergeArguments)) 2382 return false; 2383 2384 return true; 2385 } 2386 2387 } // namespace 2388 2389 // Merge all invokes in the provided set, all of which are compatible 2390 // as per the `CompatibleSets::shouldBelongToSameSet()`. 2391 static void MergeCompatibleInvokesImpl(ArrayRef<InvokeInst *> Invokes, 2392 DomTreeUpdater *DTU) { 2393 assert(Invokes.size() >= 2 && "Must have at least two invokes to merge."); 2394 2395 SmallVector<DominatorTree::UpdateType, 8> Updates; 2396 if (DTU) 2397 Updates.reserve(2 + 3 * Invokes.size()); 2398 2399 bool HasNormalDest = 2400 !isa<UnreachableInst>(Invokes[0]->getNormalDest()->getFirstNonPHIOrDbg()); 2401 2402 // Clone one of the invokes into a new basic block. 2403 // Since they are all compatible, it doesn't matter which invoke is cloned. 2404 InvokeInst *MergedInvoke = [&Invokes, HasNormalDest]() { 2405 InvokeInst *II0 = Invokes.front(); 2406 BasicBlock *II0BB = II0->getParent(); 2407 BasicBlock *InsertBeforeBlock = 2408 II0->getParent()->getIterator()->getNextNode(); 2409 Function *Func = II0BB->getParent(); 2410 LLVMContext &Ctx = II0->getContext(); 2411 2412 BasicBlock *MergedInvokeBB = BasicBlock::Create( 2413 Ctx, II0BB->getName() + ".invoke", Func, InsertBeforeBlock); 2414 2415 auto *MergedInvoke = cast<InvokeInst>(II0->clone()); 2416 // NOTE: all invokes have the same attributes, so no handling needed. 2417 MergedInvokeBB->getInstList().push_back(MergedInvoke); 2418 2419 if (!HasNormalDest) { 2420 // This set does not have a normal destination, 2421 // so just form a new block with unreachable terminator. 2422 BasicBlock *MergedNormalDest = BasicBlock::Create( 2423 Ctx, II0BB->getName() + ".cont", Func, InsertBeforeBlock); 2424 new UnreachableInst(Ctx, MergedNormalDest); 2425 MergedInvoke->setNormalDest(MergedNormalDest); 2426 } 2427 2428 // The unwind destination, however, remainds identical for all invokes here. 2429 2430 return MergedInvoke; 2431 }(); 2432 2433 if (DTU) { 2434 // Predecessor blocks that contained these invokes will now branch to 2435 // the new block that contains the merged invoke, ... 2436 for (InvokeInst *II : Invokes) 2437 Updates.push_back( 2438 {DominatorTree::Insert, II->getParent(), MergedInvoke->getParent()}); 2439 2440 // ... which has the new `unreachable` block as normal destination, 2441 // or unwinds to the (same for all `invoke`s in this set) `landingpad`, 2442 for (BasicBlock *SuccBBOfMergedInvoke : successors(MergedInvoke)) 2443 Updates.push_back({DominatorTree::Insert, MergedInvoke->getParent(), 2444 SuccBBOfMergedInvoke}); 2445 2446 // Since predecessor blocks now unconditionally branch to a new block, 2447 // they no longer branch to their original successors. 2448 for (InvokeInst *II : Invokes) 2449 for (BasicBlock *SuccOfPredBB : successors(II->getParent())) 2450 Updates.push_back( 2451 {DominatorTree::Delete, II->getParent(), SuccOfPredBB}); 2452 } 2453 2454 bool IsIndirectCall = Invokes[0]->isIndirectCall(); 2455 2456 // Form the merged operands for the merged invoke. 2457 for (Use &U : MergedInvoke->operands()) { 2458 // Only PHI together the indirect callees and data operands. 2459 if (MergedInvoke->isCallee(&U)) { 2460 if (!IsIndirectCall) 2461 continue; 2462 } else if (!MergedInvoke->isDataOperand(&U)) 2463 continue; 2464 2465 // Don't create trivial PHI's with all-identical incoming values. 2466 bool NeedPHI = any_of(Invokes, [&U](InvokeInst *II) { 2467 return II->getOperand(U.getOperandNo()) != U.get(); 2468 }); 2469 if (!NeedPHI) 2470 continue; 2471 2472 // Form a PHI out of all the data ops under this index. 2473 PHINode *PN = PHINode::Create( 2474 U->getType(), /*NumReservedValues=*/Invokes.size(), "", MergedInvoke); 2475 for (InvokeInst *II : Invokes) 2476 PN->addIncoming(II->getOperand(U.getOperandNo()), II->getParent()); 2477 2478 U.set(PN); 2479 } 2480 2481 // We've ensured that each PHI node has compatible (identical) incoming values 2482 // when coming from each of the `invoke`s in the current merge set, 2483 // so update the PHI nodes accordingly. 2484 for (BasicBlock *Succ : successors(MergedInvoke)) 2485 AddPredecessorToBlock(Succ, /*NewPred=*/MergedInvoke->getParent(), 2486 /*ExistPred=*/Invokes.front()->getParent()); 2487 2488 // And finally, replace the original `invoke`s with an unconditional branch 2489 // to the block with the merged `invoke`. Also, give that merged `invoke` 2490 // the merged debugloc of all the original `invoke`s. 2491 const DILocation *MergedDebugLoc = nullptr; 2492 for (InvokeInst *II : Invokes) { 2493 // Compute the debug location common to all the original `invoke`s. 2494 if (!MergedDebugLoc) 2495 MergedDebugLoc = II->getDebugLoc(); 2496 else 2497 MergedDebugLoc = 2498 DILocation::getMergedLocation(MergedDebugLoc, II->getDebugLoc()); 2499 2500 // And replace the old `invoke` with an unconditionally branch 2501 // to the block with the merged `invoke`. 2502 for (BasicBlock *OrigSuccBB : successors(II->getParent())) 2503 OrigSuccBB->removePredecessor(II->getParent()); 2504 BranchInst::Create(MergedInvoke->getParent(), II->getParent()); 2505 II->replaceAllUsesWith(MergedInvoke); 2506 II->eraseFromParent(); 2507 ++NumInvokesMerged; 2508 } 2509 MergedInvoke->setDebugLoc(MergedDebugLoc); 2510 ++NumInvokeSetsFormed; 2511 2512 if (DTU) 2513 DTU->applyUpdates(Updates); 2514 } 2515 2516 /// If this block is a `landingpad` exception handling block, categorize all 2517 /// the predecessor `invoke`s into sets, with all `invoke`s in each set 2518 /// being "mergeable" together, and then merge invokes in each set together. 2519 /// 2520 /// This is a weird mix of hoisting and sinking. Visually, it goes from: 2521 /// [...] [...] 2522 /// | | 2523 /// [invoke0] [invoke1] 2524 /// / \ / \ 2525 /// [cont0] [landingpad] [cont1] 2526 /// to: 2527 /// [...] [...] 2528 /// \ / 2529 /// [invoke] 2530 /// / \ 2531 /// [cont] [landingpad] 2532 /// 2533 /// But of course we can only do that if the invokes share the `landingpad`, 2534 /// edges invoke0->cont0 and invoke1->cont1 are "compatible", 2535 /// and the invoked functions are "compatible". 2536 static bool MergeCompatibleInvokes(BasicBlock *BB, DomTreeUpdater *DTU) { 2537 if (!EnableMergeCompatibleInvokes) 2538 return false; 2539 2540 bool Changed = false; 2541 2542 // FIXME: generalize to all exception handling blocks? 2543 if (!BB->isLandingPad()) 2544 return Changed; 2545 2546 CompatibleSets Grouper; 2547 2548 // Record all the predecessors of this `landingpad`. As per verifier, 2549 // the only allowed predecessor is the unwind edge of an `invoke`. 2550 // We want to group "compatible" `invokes` into the same set to be merged. 2551 for (BasicBlock *PredBB : predecessors(BB)) 2552 Grouper.insert(cast<InvokeInst>(PredBB->getTerminator())); 2553 2554 // And now, merge `invoke`s that were grouped togeter. 2555 for (ArrayRef<InvokeInst *> Invokes : Grouper.Sets) { 2556 if (Invokes.size() < 2) 2557 continue; 2558 Changed = true; 2559 MergeCompatibleInvokesImpl(Invokes, DTU); 2560 } 2561 2562 return Changed; 2563 } 2564 2565 /// Determine if we can hoist sink a sole store instruction out of a 2566 /// conditional block. 2567 /// 2568 /// We are looking for code like the following: 2569 /// BrBB: 2570 /// store i32 %add, i32* %arrayidx2 2571 /// ... // No other stores or function calls (we could be calling a memory 2572 /// ... // function). 2573 /// %cmp = icmp ult %x, %y 2574 /// br i1 %cmp, label %EndBB, label %ThenBB 2575 /// ThenBB: 2576 /// store i32 %add5, i32* %arrayidx2 2577 /// br label EndBB 2578 /// EndBB: 2579 /// ... 2580 /// We are going to transform this into: 2581 /// BrBB: 2582 /// store i32 %add, i32* %arrayidx2 2583 /// ... // 2584 /// %cmp = icmp ult %x, %y 2585 /// %add.add5 = select i1 %cmp, i32 %add, %add5 2586 /// store i32 %add.add5, i32* %arrayidx2 2587 /// ... 2588 /// 2589 /// \return The pointer to the value of the previous store if the store can be 2590 /// hoisted into the predecessor block. 0 otherwise. 2591 static Value *isSafeToSpeculateStore(Instruction *I, BasicBlock *BrBB, 2592 BasicBlock *StoreBB, BasicBlock *EndBB) { 2593 StoreInst *StoreToHoist = dyn_cast<StoreInst>(I); 2594 if (!StoreToHoist) 2595 return nullptr; 2596 2597 // Volatile or atomic. 2598 if (!StoreToHoist->isSimple()) 2599 return nullptr; 2600 2601 Value *StorePtr = StoreToHoist->getPointerOperand(); 2602 Type *StoreTy = StoreToHoist->getValueOperand()->getType(); 2603 2604 // Look for a store to the same pointer in BrBB. 2605 unsigned MaxNumInstToLookAt = 9; 2606 // Skip pseudo probe intrinsic calls which are not really killing any memory 2607 // accesses. 2608 for (Instruction &CurI : reverse(BrBB->instructionsWithoutDebug(true))) { 2609 if (!MaxNumInstToLookAt) 2610 break; 2611 --MaxNumInstToLookAt; 2612 2613 // Could be calling an instruction that affects memory like free(). 2614 if (CurI.mayWriteToMemory() && !isa<StoreInst>(CurI)) 2615 return nullptr; 2616 2617 if (auto *SI = dyn_cast<StoreInst>(&CurI)) { 2618 // Found the previous store to same location and type. Make sure it is 2619 // simple, to avoid introducing a spurious non-atomic write after an 2620 // atomic write. 2621 if (SI->getPointerOperand() == StorePtr && 2622 SI->getValueOperand()->getType() == StoreTy && SI->isSimple()) 2623 // Found the previous store, return its value operand. 2624 return SI->getValueOperand(); 2625 return nullptr; // Unknown store. 2626 } 2627 2628 if (auto *LI = dyn_cast<LoadInst>(&CurI)) { 2629 if (LI->getPointerOperand() == StorePtr && LI->getType() == StoreTy && 2630 LI->isSimple()) { 2631 // Local objects (created by an `alloca` instruction) are always 2632 // writable, so once we are past a read from a location it is valid to 2633 // also write to that same location. 2634 // If the address of the local object never escapes the function, that 2635 // means it's never concurrently read or written, hence moving the store 2636 // from under the condition will not introduce a data race. 2637 auto *AI = dyn_cast<AllocaInst>(getUnderlyingObject(StorePtr)); 2638 if (AI && !PointerMayBeCaptured(AI, false, true)) 2639 // Found a previous load, return it. 2640 return LI; 2641 } 2642 // The load didn't work out, but we may still find a store. 2643 } 2644 } 2645 2646 return nullptr; 2647 } 2648 2649 /// Estimate the cost of the insertion(s) and check that the PHI nodes can be 2650 /// converted to selects. 2651 static bool validateAndCostRequiredSelects(BasicBlock *BB, BasicBlock *ThenBB, 2652 BasicBlock *EndBB, 2653 unsigned &SpeculatedInstructions, 2654 InstructionCost &Cost, 2655 const TargetTransformInfo &TTI) { 2656 TargetTransformInfo::TargetCostKind CostKind = 2657 BB->getParent()->hasMinSize() 2658 ? TargetTransformInfo::TCK_CodeSize 2659 : TargetTransformInfo::TCK_SizeAndLatency; 2660 2661 bool HaveRewritablePHIs = false; 2662 for (PHINode &PN : EndBB->phis()) { 2663 Value *OrigV = PN.getIncomingValueForBlock(BB); 2664 Value *ThenV = PN.getIncomingValueForBlock(ThenBB); 2665 2666 // FIXME: Try to remove some of the duplication with HoistThenElseCodeToIf. 2667 // Skip PHIs which are trivial. 2668 if (ThenV == OrigV) 2669 continue; 2670 2671 Cost += TTI.getCmpSelInstrCost(Instruction::Select, PN.getType(), nullptr, 2672 CmpInst::BAD_ICMP_PREDICATE, CostKind); 2673 2674 // Don't convert to selects if we could remove undefined behavior instead. 2675 if (passingValueIsAlwaysUndefined(OrigV, &PN) || 2676 passingValueIsAlwaysUndefined(ThenV, &PN)) 2677 return false; 2678 2679 if (canTrap(OrigV) || canTrap(ThenV)) 2680 return false; 2681 2682 HaveRewritablePHIs = true; 2683 ConstantExpr *OrigCE = dyn_cast<ConstantExpr>(OrigV); 2684 ConstantExpr *ThenCE = dyn_cast<ConstantExpr>(ThenV); 2685 if (!OrigCE && !ThenCE) 2686 continue; // Known cheap (FIXME: Maybe not true for aggregates). 2687 2688 InstructionCost OrigCost = OrigCE ? computeSpeculationCost(OrigCE, TTI) : 0; 2689 InstructionCost ThenCost = ThenCE ? computeSpeculationCost(ThenCE, TTI) : 0; 2690 InstructionCost MaxCost = 2691 2 * PHINodeFoldingThreshold * TargetTransformInfo::TCC_Basic; 2692 if (OrigCost + ThenCost > MaxCost) 2693 return false; 2694 2695 // Account for the cost of an unfolded ConstantExpr which could end up 2696 // getting expanded into Instructions. 2697 // FIXME: This doesn't account for how many operations are combined in the 2698 // constant expression. 2699 ++SpeculatedInstructions; 2700 if (SpeculatedInstructions > 1) 2701 return false; 2702 } 2703 2704 return HaveRewritablePHIs; 2705 } 2706 2707 /// Speculate a conditional basic block flattening the CFG. 2708 /// 2709 /// Note that this is a very risky transform currently. Speculating 2710 /// instructions like this is most often not desirable. Instead, there is an MI 2711 /// pass which can do it with full awareness of the resource constraints. 2712 /// However, some cases are "obvious" and we should do directly. An example of 2713 /// this is speculating a single, reasonably cheap instruction. 2714 /// 2715 /// There is only one distinct advantage to flattening the CFG at the IR level: 2716 /// it makes very common but simplistic optimizations such as are common in 2717 /// instcombine and the DAG combiner more powerful by removing CFG edges and 2718 /// modeling their effects with easier to reason about SSA value graphs. 2719 /// 2720 /// 2721 /// An illustration of this transform is turning this IR: 2722 /// \code 2723 /// BB: 2724 /// %cmp = icmp ult %x, %y 2725 /// br i1 %cmp, label %EndBB, label %ThenBB 2726 /// ThenBB: 2727 /// %sub = sub %x, %y 2728 /// br label BB2 2729 /// EndBB: 2730 /// %phi = phi [ %sub, %ThenBB ], [ 0, %EndBB ] 2731 /// ... 2732 /// \endcode 2733 /// 2734 /// Into this IR: 2735 /// \code 2736 /// BB: 2737 /// %cmp = icmp ult %x, %y 2738 /// %sub = sub %x, %y 2739 /// %cond = select i1 %cmp, 0, %sub 2740 /// ... 2741 /// \endcode 2742 /// 2743 /// \returns true if the conditional block is removed. 2744 bool SimplifyCFGOpt::SpeculativelyExecuteBB(BranchInst *BI, BasicBlock *ThenBB, 2745 const TargetTransformInfo &TTI) { 2746 // Be conservative for now. FP select instruction can often be expensive. 2747 Value *BrCond = BI->getCondition(); 2748 if (isa<FCmpInst>(BrCond)) 2749 return false; 2750 2751 BasicBlock *BB = BI->getParent(); 2752 BasicBlock *EndBB = ThenBB->getTerminator()->getSuccessor(0); 2753 InstructionCost Budget = 2754 PHINodeFoldingThreshold * TargetTransformInfo::TCC_Basic; 2755 2756 // If ThenBB is actually on the false edge of the conditional branch, remember 2757 // to swap the select operands later. 2758 bool Invert = false; 2759 if (ThenBB != BI->getSuccessor(0)) { 2760 assert(ThenBB == BI->getSuccessor(1) && "No edge from 'if' block?"); 2761 Invert = true; 2762 } 2763 assert(EndBB == BI->getSuccessor(!Invert) && "No edge from to end block"); 2764 2765 // If the branch is non-unpredictable, and is predicted to *not* branch to 2766 // the `then` block, then avoid speculating it. 2767 if (!BI->getMetadata(LLVMContext::MD_unpredictable)) { 2768 uint64_t TWeight, FWeight; 2769 if (BI->extractProfMetadata(TWeight, FWeight) && (TWeight + FWeight) != 0) { 2770 uint64_t EndWeight = Invert ? TWeight : FWeight; 2771 BranchProbability BIEndProb = 2772 BranchProbability::getBranchProbability(EndWeight, TWeight + FWeight); 2773 BranchProbability Likely = TTI.getPredictableBranchThreshold(); 2774 if (BIEndProb >= Likely) 2775 return false; 2776 } 2777 } 2778 2779 // Keep a count of how many times instructions are used within ThenBB when 2780 // they are candidates for sinking into ThenBB. Specifically: 2781 // - They are defined in BB, and 2782 // - They have no side effects, and 2783 // - All of their uses are in ThenBB. 2784 SmallDenseMap<Instruction *, unsigned, 4> SinkCandidateUseCounts; 2785 2786 SmallVector<Instruction *, 4> SpeculatedDbgIntrinsics; 2787 2788 unsigned SpeculatedInstructions = 0; 2789 Value *SpeculatedStoreValue = nullptr; 2790 StoreInst *SpeculatedStore = nullptr; 2791 for (BasicBlock::iterator BBI = ThenBB->begin(), 2792 BBE = std::prev(ThenBB->end()); 2793 BBI != BBE; ++BBI) { 2794 Instruction *I = &*BBI; 2795 // Skip debug info. 2796 if (isa<DbgInfoIntrinsic>(I)) { 2797 SpeculatedDbgIntrinsics.push_back(I); 2798 continue; 2799 } 2800 2801 // Skip pseudo probes. The consequence is we lose track of the branch 2802 // probability for ThenBB, which is fine since the optimization here takes 2803 // place regardless of the branch probability. 2804 if (isa<PseudoProbeInst>(I)) { 2805 // The probe should be deleted so that it will not be over-counted when 2806 // the samples collected on the non-conditional path are counted towards 2807 // the conditional path. We leave it for the counts inference algorithm to 2808 // figure out a proper count for an unknown probe. 2809 SpeculatedDbgIntrinsics.push_back(I); 2810 continue; 2811 } 2812 2813 // Only speculatively execute a single instruction (not counting the 2814 // terminator) for now. 2815 ++SpeculatedInstructions; 2816 if (SpeculatedInstructions > 1) 2817 return false; 2818 2819 // Don't hoist the instruction if it's unsafe or expensive. 2820 if (!isSafeToSpeculativelyExecute(I) && 2821 !(HoistCondStores && (SpeculatedStoreValue = isSafeToSpeculateStore( 2822 I, BB, ThenBB, EndBB)))) 2823 return false; 2824 if (!SpeculatedStoreValue && 2825 computeSpeculationCost(I, TTI) > 2826 PHINodeFoldingThreshold * TargetTransformInfo::TCC_Basic) 2827 return false; 2828 2829 // Store the store speculation candidate. 2830 if (SpeculatedStoreValue) 2831 SpeculatedStore = cast<StoreInst>(I); 2832 2833 // Do not hoist the instruction if any of its operands are defined but not 2834 // used in BB. The transformation will prevent the operand from 2835 // being sunk into the use block. 2836 for (Use &Op : I->operands()) { 2837 Instruction *OpI = dyn_cast<Instruction>(Op); 2838 if (!OpI || OpI->getParent() != BB || OpI->mayHaveSideEffects()) 2839 continue; // Not a candidate for sinking. 2840 2841 ++SinkCandidateUseCounts[OpI]; 2842 } 2843 } 2844 2845 // Consider any sink candidates which are only used in ThenBB as costs for 2846 // speculation. Note, while we iterate over a DenseMap here, we are summing 2847 // and so iteration order isn't significant. 2848 for (SmallDenseMap<Instruction *, unsigned, 4>::iterator 2849 I = SinkCandidateUseCounts.begin(), 2850 E = SinkCandidateUseCounts.end(); 2851 I != E; ++I) 2852 if (I->first->hasNUses(I->second)) { 2853 ++SpeculatedInstructions; 2854 if (SpeculatedInstructions > 1) 2855 return false; 2856 } 2857 2858 // Check that we can insert the selects and that it's not too expensive to do 2859 // so. 2860 bool Convert = SpeculatedStore != nullptr; 2861 InstructionCost Cost = 0; 2862 Convert |= validateAndCostRequiredSelects(BB, ThenBB, EndBB, 2863 SpeculatedInstructions, 2864 Cost, TTI); 2865 if (!Convert || Cost > Budget) 2866 return false; 2867 2868 // If we get here, we can hoist the instruction and if-convert. 2869 LLVM_DEBUG(dbgs() << "SPECULATIVELY EXECUTING BB" << *ThenBB << "\n";); 2870 2871 // Insert a select of the value of the speculated store. 2872 if (SpeculatedStoreValue) { 2873 IRBuilder<NoFolder> Builder(BI); 2874 Value *TrueV = SpeculatedStore->getValueOperand(); 2875 Value *FalseV = SpeculatedStoreValue; 2876 if (Invert) 2877 std::swap(TrueV, FalseV); 2878 Value *S = Builder.CreateSelect( 2879 BrCond, TrueV, FalseV, "spec.store.select", BI); 2880 SpeculatedStore->setOperand(0, S); 2881 SpeculatedStore->applyMergedLocation(BI->getDebugLoc(), 2882 SpeculatedStore->getDebugLoc()); 2883 } 2884 2885 // Metadata can be dependent on the condition we are hoisting above. 2886 // Conservatively strip all metadata on the instruction. Drop the debug loc 2887 // to avoid making it appear as if the condition is a constant, which would 2888 // be misleading while debugging. 2889 // Similarly strip attributes that maybe dependent on condition we are 2890 // hoisting above. 2891 for (auto &I : *ThenBB) { 2892 if (!SpeculatedStoreValue || &I != SpeculatedStore) 2893 I.setDebugLoc(DebugLoc()); 2894 I.dropUndefImplyingAttrsAndUnknownMetadata(); 2895 } 2896 2897 // Hoist the instructions. 2898 BB->getInstList().splice(BI->getIterator(), ThenBB->getInstList(), 2899 ThenBB->begin(), std::prev(ThenBB->end())); 2900 2901 // Insert selects and rewrite the PHI operands. 2902 IRBuilder<NoFolder> Builder(BI); 2903 for (PHINode &PN : EndBB->phis()) { 2904 unsigned OrigI = PN.getBasicBlockIndex(BB); 2905 unsigned ThenI = PN.getBasicBlockIndex(ThenBB); 2906 Value *OrigV = PN.getIncomingValue(OrigI); 2907 Value *ThenV = PN.getIncomingValue(ThenI); 2908 2909 // Skip PHIs which are trivial. 2910 if (OrigV == ThenV) 2911 continue; 2912 2913 // Create a select whose true value is the speculatively executed value and 2914 // false value is the pre-existing value. Swap them if the branch 2915 // destinations were inverted. 2916 Value *TrueV = ThenV, *FalseV = OrigV; 2917 if (Invert) 2918 std::swap(TrueV, FalseV); 2919 Value *V = Builder.CreateSelect(BrCond, TrueV, FalseV, "spec.select", BI); 2920 PN.setIncomingValue(OrigI, V); 2921 PN.setIncomingValue(ThenI, V); 2922 } 2923 2924 // Remove speculated dbg intrinsics. 2925 // FIXME: Is it possible to do this in a more elegant way? Moving/merging the 2926 // dbg value for the different flows and inserting it after the select. 2927 for (Instruction *I : SpeculatedDbgIntrinsics) 2928 I->eraseFromParent(); 2929 2930 ++NumSpeculations; 2931 return true; 2932 } 2933 2934 /// Return true if we can thread a branch across this block. 2935 static bool BlockIsSimpleEnoughToThreadThrough(BasicBlock *BB) { 2936 int Size = 0; 2937 2938 SmallPtrSet<const Value *, 32> EphValues; 2939 auto IsEphemeral = [&](const Instruction *I) { 2940 if (isa<AssumeInst>(I)) 2941 return true; 2942 return !I->mayHaveSideEffects() && !I->isTerminator() && 2943 all_of(I->users(), 2944 [&](const User *U) { return EphValues.count(U); }); 2945 }; 2946 2947 // Walk the loop in reverse so that we can identify ephemeral values properly 2948 // (values only feeding assumes). 2949 for (Instruction &I : reverse(BB->instructionsWithoutDebug(false))) { 2950 // Can't fold blocks that contain noduplicate or convergent calls. 2951 if (CallInst *CI = dyn_cast<CallInst>(&I)) 2952 if (CI->cannotDuplicate() || CI->isConvergent()) 2953 return false; 2954 2955 // Ignore ephemeral values which are deleted during codegen. 2956 if (IsEphemeral(&I)) 2957 EphValues.insert(&I); 2958 // We will delete Phis while threading, so Phis should not be accounted in 2959 // block's size. 2960 else if (!isa<PHINode>(I)) { 2961 if (Size++ > MaxSmallBlockSize) 2962 return false; // Don't clone large BB's. 2963 } 2964 2965 // We can only support instructions that do not define values that are 2966 // live outside of the current basic block. 2967 for (User *U : I.users()) { 2968 Instruction *UI = cast<Instruction>(U); 2969 if (UI->getParent() != BB || isa<PHINode>(UI)) 2970 return false; 2971 } 2972 2973 // Looks ok, continue checking. 2974 } 2975 2976 return true; 2977 } 2978 2979 static ConstantInt *getKnownValueOnEdge(Value *V, BasicBlock *From, 2980 BasicBlock *To) { 2981 // Don't look past the block defining the value, we might get the value from 2982 // a previous loop iteration. 2983 auto *I = dyn_cast<Instruction>(V); 2984 if (I && I->getParent() == To) 2985 return nullptr; 2986 2987 // We know the value if the From block branches on it. 2988 auto *BI = dyn_cast<BranchInst>(From->getTerminator()); 2989 if (BI && BI->isConditional() && BI->getCondition() == V && 2990 BI->getSuccessor(0) != BI->getSuccessor(1)) 2991 return BI->getSuccessor(0) == To ? ConstantInt::getTrue(BI->getContext()) 2992 : ConstantInt::getFalse(BI->getContext()); 2993 2994 return nullptr; 2995 } 2996 2997 /// If we have a conditional branch on something for which we know the constant 2998 /// value in predecessors (e.g. a phi node in the current block), thread edges 2999 /// from the predecessor to their ultimate destination. 3000 static Optional<bool> 3001 FoldCondBranchOnValueKnownInPredecessorImpl(BranchInst *BI, DomTreeUpdater *DTU, 3002 const DataLayout &DL, 3003 AssumptionCache *AC) { 3004 SmallMapVector<ConstantInt *, SmallSetVector<BasicBlock *, 2>, 2> KnownValues; 3005 BasicBlock *BB = BI->getParent(); 3006 Value *Cond = BI->getCondition(); 3007 PHINode *PN = dyn_cast<PHINode>(Cond); 3008 if (PN && PN->getParent() == BB) { 3009 // Degenerate case of a single entry PHI. 3010 if (PN->getNumIncomingValues() == 1) { 3011 FoldSingleEntryPHINodes(PN->getParent()); 3012 return true; 3013 } 3014 3015 for (Use &U : PN->incoming_values()) 3016 if (auto *CB = dyn_cast<ConstantInt>(U)) 3017 KnownValues[CB].insert(PN->getIncomingBlock(U)); 3018 } else { 3019 for (BasicBlock *Pred : predecessors(BB)) { 3020 if (ConstantInt *CB = getKnownValueOnEdge(Cond, Pred, BB)) 3021 KnownValues[CB].insert(Pred); 3022 } 3023 } 3024 3025 if (KnownValues.empty()) 3026 return false; 3027 3028 // Now we know that this block has multiple preds and two succs. 3029 // Check that the block is small enough and values defined in the block are 3030 // not used outside of it. 3031 if (!BlockIsSimpleEnoughToThreadThrough(BB)) 3032 return false; 3033 3034 for (const auto &Pair : KnownValues) { 3035 // Okay, we now know that all edges from PredBB should be revectored to 3036 // branch to RealDest. 3037 ConstantInt *CB = Pair.first; 3038 ArrayRef<BasicBlock *> PredBBs = Pair.second.getArrayRef(); 3039 BasicBlock *RealDest = BI->getSuccessor(!CB->getZExtValue()); 3040 3041 if (RealDest == BB) 3042 continue; // Skip self loops. 3043 3044 // Skip if the predecessor's terminator is an indirect branch. 3045 if (any_of(PredBBs, [](BasicBlock *PredBB) { 3046 return isa<IndirectBrInst>(PredBB->getTerminator()); 3047 })) 3048 continue; 3049 3050 LLVM_DEBUG({ 3051 dbgs() << "Condition " << *Cond << " in " << BB->getName() 3052 << " has value " << *Pair.first << " in predecessors:\n"; 3053 for (const BasicBlock *PredBB : Pair.second) 3054 dbgs() << " " << PredBB->getName() << "\n"; 3055 dbgs() << "Threading to destination " << RealDest->getName() << ".\n"; 3056 }); 3057 3058 // Split the predecessors we are threading into a new edge block. We'll 3059 // clone the instructions into this block, and then redirect it to RealDest. 3060 BasicBlock *EdgeBB = SplitBlockPredecessors(BB, PredBBs, ".critedge", DTU); 3061 3062 // TODO: These just exist to reduce test diff, we can drop them if we like. 3063 EdgeBB->setName(RealDest->getName() + ".critedge"); 3064 EdgeBB->moveBefore(RealDest); 3065 3066 // Update PHI nodes. 3067 AddPredecessorToBlock(RealDest, EdgeBB, BB); 3068 3069 // BB may have instructions that are being threaded over. Clone these 3070 // instructions into EdgeBB. We know that there will be no uses of the 3071 // cloned instructions outside of EdgeBB. 3072 BasicBlock::iterator InsertPt = EdgeBB->getFirstInsertionPt(); 3073 DenseMap<Value *, Value *> TranslateMap; // Track translated values. 3074 TranslateMap[Cond] = CB; 3075 for (BasicBlock::iterator BBI = BB->begin(); &*BBI != BI; ++BBI) { 3076 if (PHINode *PN = dyn_cast<PHINode>(BBI)) { 3077 TranslateMap[PN] = PN->getIncomingValueForBlock(EdgeBB); 3078 continue; 3079 } 3080 // Clone the instruction. 3081 Instruction *N = BBI->clone(); 3082 if (BBI->hasName()) 3083 N->setName(BBI->getName() + ".c"); 3084 3085 // Update operands due to translation. 3086 for (Use &Op : N->operands()) { 3087 DenseMap<Value *, Value *>::iterator PI = TranslateMap.find(Op); 3088 if (PI != TranslateMap.end()) 3089 Op = PI->second; 3090 } 3091 3092 // Check for trivial simplification. 3093 if (Value *V = simplifyInstruction(N, {DL, nullptr, nullptr, AC})) { 3094 if (!BBI->use_empty()) 3095 TranslateMap[&*BBI] = V; 3096 if (!N->mayHaveSideEffects()) { 3097 N->deleteValue(); // Instruction folded away, don't need actual inst 3098 N = nullptr; 3099 } 3100 } else { 3101 if (!BBI->use_empty()) 3102 TranslateMap[&*BBI] = N; 3103 } 3104 if (N) { 3105 // Insert the new instruction into its new home. 3106 EdgeBB->getInstList().insert(InsertPt, N); 3107 3108 // Register the new instruction with the assumption cache if necessary. 3109 if (auto *Assume = dyn_cast<AssumeInst>(N)) 3110 if (AC) 3111 AC->registerAssumption(Assume); 3112 } 3113 } 3114 3115 BB->removePredecessor(EdgeBB); 3116 BranchInst *EdgeBI = cast<BranchInst>(EdgeBB->getTerminator()); 3117 EdgeBI->setSuccessor(0, RealDest); 3118 EdgeBI->setDebugLoc(BI->getDebugLoc()); 3119 3120 if (DTU) { 3121 SmallVector<DominatorTree::UpdateType, 2> Updates; 3122 Updates.push_back({DominatorTree::Delete, EdgeBB, BB}); 3123 Updates.push_back({DominatorTree::Insert, EdgeBB, RealDest}); 3124 DTU->applyUpdates(Updates); 3125 } 3126 3127 // For simplicity, we created a separate basic block for the edge. Merge 3128 // it back into the predecessor if possible. This not only avoids 3129 // unnecessary SimplifyCFG iterations, but also makes sure that we don't 3130 // bypass the check for trivial cycles above. 3131 MergeBlockIntoPredecessor(EdgeBB, DTU); 3132 3133 // Signal repeat, simplifying any other constants. 3134 return None; 3135 } 3136 3137 return false; 3138 } 3139 3140 static bool FoldCondBranchOnValueKnownInPredecessor(BranchInst *BI, 3141 DomTreeUpdater *DTU, 3142 const DataLayout &DL, 3143 AssumptionCache *AC) { 3144 Optional<bool> Result; 3145 bool EverChanged = false; 3146 do { 3147 // Note that None means "we changed things, but recurse further." 3148 Result = FoldCondBranchOnValueKnownInPredecessorImpl(BI, DTU, DL, AC); 3149 EverChanged |= Result == None || *Result; 3150 } while (Result == None); 3151 return EverChanged; 3152 } 3153 3154 /// Given a BB that starts with the specified two-entry PHI node, 3155 /// see if we can eliminate it. 3156 static bool FoldTwoEntryPHINode(PHINode *PN, const TargetTransformInfo &TTI, 3157 DomTreeUpdater *DTU, const DataLayout &DL) { 3158 // Ok, this is a two entry PHI node. Check to see if this is a simple "if 3159 // statement", which has a very simple dominance structure. Basically, we 3160 // are trying to find the condition that is being branched on, which 3161 // subsequently causes this merge to happen. We really want control 3162 // dependence information for this check, but simplifycfg can't keep it up 3163 // to date, and this catches most of the cases we care about anyway. 3164 BasicBlock *BB = PN->getParent(); 3165 3166 BasicBlock *IfTrue, *IfFalse; 3167 BranchInst *DomBI = GetIfCondition(BB, IfTrue, IfFalse); 3168 if (!DomBI) 3169 return false; 3170 Value *IfCond = DomBI->getCondition(); 3171 // Don't bother if the branch will be constant folded trivially. 3172 if (isa<ConstantInt>(IfCond)) 3173 return false; 3174 3175 BasicBlock *DomBlock = DomBI->getParent(); 3176 SmallVector<BasicBlock *, 2> IfBlocks; 3177 llvm::copy_if( 3178 PN->blocks(), std::back_inserter(IfBlocks), [](BasicBlock *IfBlock) { 3179 return cast<BranchInst>(IfBlock->getTerminator())->isUnconditional(); 3180 }); 3181 assert((IfBlocks.size() == 1 || IfBlocks.size() == 2) && 3182 "Will have either one or two blocks to speculate."); 3183 3184 // If the branch is non-unpredictable, see if we either predictably jump to 3185 // the merge bb (if we have only a single 'then' block), or if we predictably 3186 // jump to one specific 'then' block (if we have two of them). 3187 // It isn't beneficial to speculatively execute the code 3188 // from the block that we know is predictably not entered. 3189 if (!DomBI->getMetadata(LLVMContext::MD_unpredictable)) { 3190 uint64_t TWeight, FWeight; 3191 if (DomBI->extractProfMetadata(TWeight, FWeight) && 3192 (TWeight + FWeight) != 0) { 3193 BranchProbability BITrueProb = 3194 BranchProbability::getBranchProbability(TWeight, TWeight + FWeight); 3195 BranchProbability Likely = TTI.getPredictableBranchThreshold(); 3196 BranchProbability BIFalseProb = BITrueProb.getCompl(); 3197 if (IfBlocks.size() == 1) { 3198 BranchProbability BIBBProb = 3199 DomBI->getSuccessor(0) == BB ? BITrueProb : BIFalseProb; 3200 if (BIBBProb >= Likely) 3201 return false; 3202 } else { 3203 if (BITrueProb >= Likely || BIFalseProb >= Likely) 3204 return false; 3205 } 3206 } 3207 } 3208 3209 // Don't try to fold an unreachable block. For example, the phi node itself 3210 // can't be the candidate if-condition for a select that we want to form. 3211 if (auto *IfCondPhiInst = dyn_cast<PHINode>(IfCond)) 3212 if (IfCondPhiInst->getParent() == BB) 3213 return false; 3214 3215 // Okay, we found that we can merge this two-entry phi node into a select. 3216 // Doing so would require us to fold *all* two entry phi nodes in this block. 3217 // At some point this becomes non-profitable (particularly if the target 3218 // doesn't support cmov's). Only do this transformation if there are two or 3219 // fewer PHI nodes in this block. 3220 unsigned NumPhis = 0; 3221 for (BasicBlock::iterator I = BB->begin(); isa<PHINode>(I); ++NumPhis, ++I) 3222 if (NumPhis > 2) 3223 return false; 3224 3225 // Loop over the PHI's seeing if we can promote them all to select 3226 // instructions. While we are at it, keep track of the instructions 3227 // that need to be moved to the dominating block. 3228 SmallPtrSet<Instruction *, 4> AggressiveInsts; 3229 InstructionCost Cost = 0; 3230 InstructionCost Budget = 3231 TwoEntryPHINodeFoldingThreshold * TargetTransformInfo::TCC_Basic; 3232 3233 bool Changed = false; 3234 for (BasicBlock::iterator II = BB->begin(); isa<PHINode>(II);) { 3235 PHINode *PN = cast<PHINode>(II++); 3236 if (Value *V = simplifyInstruction(PN, {DL, PN})) { 3237 PN->replaceAllUsesWith(V); 3238 PN->eraseFromParent(); 3239 Changed = true; 3240 continue; 3241 } 3242 3243 if (!dominatesMergePoint(PN->getIncomingValue(0), BB, AggressiveInsts, 3244 Cost, Budget, TTI) || 3245 !dominatesMergePoint(PN->getIncomingValue(1), BB, AggressiveInsts, 3246 Cost, Budget, TTI)) 3247 return Changed; 3248 } 3249 3250 // If we folded the first phi, PN dangles at this point. Refresh it. If 3251 // we ran out of PHIs then we simplified them all. 3252 PN = dyn_cast<PHINode>(BB->begin()); 3253 if (!PN) 3254 return true; 3255 3256 // Return true if at least one of these is a 'not', and another is either 3257 // a 'not' too, or a constant. 3258 auto CanHoistNotFromBothValues = [](Value *V0, Value *V1) { 3259 if (!match(V0, m_Not(m_Value()))) 3260 std::swap(V0, V1); 3261 auto Invertible = m_CombineOr(m_Not(m_Value()), m_AnyIntegralConstant()); 3262 return match(V0, m_Not(m_Value())) && match(V1, Invertible); 3263 }; 3264 3265 // Don't fold i1 branches on PHIs which contain binary operators or 3266 // (possibly inverted) select form of or/ands, unless one of 3267 // the incoming values is an 'not' and another one is freely invertible. 3268 // These can often be turned into switches and other things. 3269 auto IsBinOpOrAnd = [](Value *V) { 3270 return match( 3271 V, m_CombineOr( 3272 m_BinOp(), 3273 m_CombineOr(m_Select(m_Value(), m_ImmConstant(), m_Value()), 3274 m_Select(m_Value(), m_Value(), m_ImmConstant())))); 3275 }; 3276 if (PN->getType()->isIntegerTy(1) && 3277 (IsBinOpOrAnd(PN->getIncomingValue(0)) || 3278 IsBinOpOrAnd(PN->getIncomingValue(1)) || IsBinOpOrAnd(IfCond)) && 3279 !CanHoistNotFromBothValues(PN->getIncomingValue(0), 3280 PN->getIncomingValue(1))) 3281 return Changed; 3282 3283 // If all PHI nodes are promotable, check to make sure that all instructions 3284 // in the predecessor blocks can be promoted as well. If not, we won't be able 3285 // to get rid of the control flow, so it's not worth promoting to select 3286 // instructions. 3287 for (BasicBlock *IfBlock : IfBlocks) 3288 for (BasicBlock::iterator I = IfBlock->begin(); !I->isTerminator(); ++I) 3289 if (!AggressiveInsts.count(&*I) && !I->isDebugOrPseudoInst()) { 3290 // This is not an aggressive instruction that we can promote. 3291 // Because of this, we won't be able to get rid of the control flow, so 3292 // the xform is not worth it. 3293 return Changed; 3294 } 3295 3296 // If either of the blocks has it's address taken, we can't do this fold. 3297 if (any_of(IfBlocks, 3298 [](BasicBlock *IfBlock) { return IfBlock->hasAddressTaken(); })) 3299 return Changed; 3300 3301 LLVM_DEBUG(dbgs() << "FOUND IF CONDITION! " << *IfCond 3302 << " T: " << IfTrue->getName() 3303 << " F: " << IfFalse->getName() << "\n"); 3304 3305 // If we can still promote the PHI nodes after this gauntlet of tests, 3306 // do all of the PHI's now. 3307 3308 // Move all 'aggressive' instructions, which are defined in the 3309 // conditional parts of the if's up to the dominating block. 3310 for (BasicBlock *IfBlock : IfBlocks) 3311 hoistAllInstructionsInto(DomBlock, DomBI, IfBlock); 3312 3313 IRBuilder<NoFolder> Builder(DomBI); 3314 // Propagate fast-math-flags from phi nodes to replacement selects. 3315 IRBuilder<>::FastMathFlagGuard FMFGuard(Builder); 3316 while (PHINode *PN = dyn_cast<PHINode>(BB->begin())) { 3317 if (isa<FPMathOperator>(PN)) 3318 Builder.setFastMathFlags(PN->getFastMathFlags()); 3319 3320 // Change the PHI node into a select instruction. 3321 Value *TrueVal = PN->getIncomingValueForBlock(IfTrue); 3322 Value *FalseVal = PN->getIncomingValueForBlock(IfFalse); 3323 3324 Value *Sel = Builder.CreateSelect(IfCond, TrueVal, FalseVal, "", DomBI); 3325 PN->replaceAllUsesWith(Sel); 3326 Sel->takeName(PN); 3327 PN->eraseFromParent(); 3328 } 3329 3330 // At this point, all IfBlocks are empty, so our if statement 3331 // has been flattened. Change DomBlock to jump directly to our new block to 3332 // avoid other simplifycfg's kicking in on the diamond. 3333 Builder.CreateBr(BB); 3334 3335 SmallVector<DominatorTree::UpdateType, 3> Updates; 3336 if (DTU) { 3337 Updates.push_back({DominatorTree::Insert, DomBlock, BB}); 3338 for (auto *Successor : successors(DomBlock)) 3339 Updates.push_back({DominatorTree::Delete, DomBlock, Successor}); 3340 } 3341 3342 DomBI->eraseFromParent(); 3343 if (DTU) 3344 DTU->applyUpdates(Updates); 3345 3346 return true; 3347 } 3348 3349 static Value *createLogicalOp(IRBuilderBase &Builder, 3350 Instruction::BinaryOps Opc, Value *LHS, 3351 Value *RHS, const Twine &Name = "") { 3352 // Try to relax logical op to binary op. 3353 if (impliesPoison(RHS, LHS)) 3354 return Builder.CreateBinOp(Opc, LHS, RHS, Name); 3355 if (Opc == Instruction::And) 3356 return Builder.CreateLogicalAnd(LHS, RHS, Name); 3357 if (Opc == Instruction::Or) 3358 return Builder.CreateLogicalOr(LHS, RHS, Name); 3359 llvm_unreachable("Invalid logical opcode"); 3360 } 3361 3362 /// Return true if either PBI or BI has branch weight available, and store 3363 /// the weights in {Pred|Succ}{True|False}Weight. If one of PBI and BI does 3364 /// not have branch weight, use 1:1 as its weight. 3365 static bool extractPredSuccWeights(BranchInst *PBI, BranchInst *BI, 3366 uint64_t &PredTrueWeight, 3367 uint64_t &PredFalseWeight, 3368 uint64_t &SuccTrueWeight, 3369 uint64_t &SuccFalseWeight) { 3370 bool PredHasWeights = 3371 PBI->extractProfMetadata(PredTrueWeight, PredFalseWeight); 3372 bool SuccHasWeights = 3373 BI->extractProfMetadata(SuccTrueWeight, SuccFalseWeight); 3374 if (PredHasWeights || SuccHasWeights) { 3375 if (!PredHasWeights) 3376 PredTrueWeight = PredFalseWeight = 1; 3377 if (!SuccHasWeights) 3378 SuccTrueWeight = SuccFalseWeight = 1; 3379 return true; 3380 } else { 3381 return false; 3382 } 3383 } 3384 3385 /// Determine if the two branches share a common destination and deduce a glue 3386 /// that joins the branches' conditions to arrive at the common destination if 3387 /// that would be profitable. 3388 static Optional<std::pair<Instruction::BinaryOps, bool>> 3389 shouldFoldCondBranchesToCommonDestination(BranchInst *BI, BranchInst *PBI, 3390 const TargetTransformInfo *TTI) { 3391 assert(BI && PBI && BI->isConditional() && PBI->isConditional() && 3392 "Both blocks must end with a conditional branches."); 3393 assert(is_contained(predecessors(BI->getParent()), PBI->getParent()) && 3394 "PredBB must be a predecessor of BB."); 3395 3396 // We have the potential to fold the conditions together, but if the 3397 // predecessor branch is predictable, we may not want to merge them. 3398 uint64_t PTWeight, PFWeight; 3399 BranchProbability PBITrueProb, Likely; 3400 if (TTI && !PBI->getMetadata(LLVMContext::MD_unpredictable) && 3401 PBI->extractProfMetadata(PTWeight, PFWeight) && 3402 (PTWeight + PFWeight) != 0) { 3403 PBITrueProb = 3404 BranchProbability::getBranchProbability(PTWeight, PTWeight + PFWeight); 3405 Likely = TTI->getPredictableBranchThreshold(); 3406 } 3407 3408 if (PBI->getSuccessor(0) == BI->getSuccessor(0)) { 3409 // Speculate the 2nd condition unless the 1st is probably true. 3410 if (PBITrueProb.isUnknown() || PBITrueProb < Likely) 3411 return {{Instruction::Or, false}}; 3412 } else if (PBI->getSuccessor(1) == BI->getSuccessor(1)) { 3413 // Speculate the 2nd condition unless the 1st is probably false. 3414 if (PBITrueProb.isUnknown() || PBITrueProb.getCompl() < Likely) 3415 return {{Instruction::And, false}}; 3416 } else if (PBI->getSuccessor(0) == BI->getSuccessor(1)) { 3417 // Speculate the 2nd condition unless the 1st is probably true. 3418 if (PBITrueProb.isUnknown() || PBITrueProb < Likely) 3419 return {{Instruction::And, true}}; 3420 } else if (PBI->getSuccessor(1) == BI->getSuccessor(0)) { 3421 // Speculate the 2nd condition unless the 1st is probably false. 3422 if (PBITrueProb.isUnknown() || PBITrueProb.getCompl() < Likely) 3423 return {{Instruction::Or, true}}; 3424 } 3425 return None; 3426 } 3427 3428 static bool performBranchToCommonDestFolding(BranchInst *BI, BranchInst *PBI, 3429 DomTreeUpdater *DTU, 3430 MemorySSAUpdater *MSSAU, 3431 const TargetTransformInfo *TTI) { 3432 BasicBlock *BB = BI->getParent(); 3433 BasicBlock *PredBlock = PBI->getParent(); 3434 3435 // Determine if the two branches share a common destination. 3436 Instruction::BinaryOps Opc; 3437 bool InvertPredCond; 3438 std::tie(Opc, InvertPredCond) = 3439 *shouldFoldCondBranchesToCommonDestination(BI, PBI, TTI); 3440 3441 LLVM_DEBUG(dbgs() << "FOLDING BRANCH TO COMMON DEST:\n" << *PBI << *BB); 3442 3443 IRBuilder<> Builder(PBI); 3444 // The builder is used to create instructions to eliminate the branch in BB. 3445 // If BB's terminator has !annotation metadata, add it to the new 3446 // instructions. 3447 Builder.CollectMetadataToCopy(BB->getTerminator(), 3448 {LLVMContext::MD_annotation}); 3449 3450 // If we need to invert the condition in the pred block to match, do so now. 3451 if (InvertPredCond) { 3452 Value *NewCond = PBI->getCondition(); 3453 if (NewCond->hasOneUse() && isa<CmpInst>(NewCond)) { 3454 CmpInst *CI = cast<CmpInst>(NewCond); 3455 CI->setPredicate(CI->getInversePredicate()); 3456 } else { 3457 NewCond = 3458 Builder.CreateNot(NewCond, PBI->getCondition()->getName() + ".not"); 3459 } 3460 3461 PBI->setCondition(NewCond); 3462 PBI->swapSuccessors(); 3463 } 3464 3465 BasicBlock *UniqueSucc = 3466 PBI->getSuccessor(0) == BB ? BI->getSuccessor(0) : BI->getSuccessor(1); 3467 3468 // Before cloning instructions, notify the successor basic block that it 3469 // is about to have a new predecessor. This will update PHI nodes, 3470 // which will allow us to update live-out uses of bonus instructions. 3471 AddPredecessorToBlock(UniqueSucc, PredBlock, BB, MSSAU); 3472 3473 // Try to update branch weights. 3474 uint64_t PredTrueWeight, PredFalseWeight, SuccTrueWeight, SuccFalseWeight; 3475 if (extractPredSuccWeights(PBI, BI, PredTrueWeight, PredFalseWeight, 3476 SuccTrueWeight, SuccFalseWeight)) { 3477 SmallVector<uint64_t, 8> NewWeights; 3478 3479 if (PBI->getSuccessor(0) == BB) { 3480 // PBI: br i1 %x, BB, FalseDest 3481 // BI: br i1 %y, UniqueSucc, FalseDest 3482 // TrueWeight is TrueWeight for PBI * TrueWeight for BI. 3483 NewWeights.push_back(PredTrueWeight * SuccTrueWeight); 3484 // FalseWeight is FalseWeight for PBI * TotalWeight for BI + 3485 // TrueWeight for PBI * FalseWeight for BI. 3486 // We assume that total weights of a BranchInst can fit into 32 bits. 3487 // Therefore, we will not have overflow using 64-bit arithmetic. 3488 NewWeights.push_back(PredFalseWeight * 3489 (SuccFalseWeight + SuccTrueWeight) + 3490 PredTrueWeight * SuccFalseWeight); 3491 } else { 3492 // PBI: br i1 %x, TrueDest, BB 3493 // BI: br i1 %y, TrueDest, UniqueSucc 3494 // TrueWeight is TrueWeight for PBI * TotalWeight for BI + 3495 // FalseWeight for PBI * TrueWeight for BI. 3496 NewWeights.push_back(PredTrueWeight * (SuccFalseWeight + SuccTrueWeight) + 3497 PredFalseWeight * SuccTrueWeight); 3498 // FalseWeight is FalseWeight for PBI * FalseWeight for BI. 3499 NewWeights.push_back(PredFalseWeight * SuccFalseWeight); 3500 } 3501 3502 // Halve the weights if any of them cannot fit in an uint32_t 3503 FitWeights(NewWeights); 3504 3505 SmallVector<uint32_t, 8> MDWeights(NewWeights.begin(), NewWeights.end()); 3506 setBranchWeights(PBI, MDWeights[0], MDWeights[1]); 3507 3508 // TODO: If BB is reachable from all paths through PredBlock, then we 3509 // could replace PBI's branch probabilities with BI's. 3510 } else 3511 PBI->setMetadata(LLVMContext::MD_prof, nullptr); 3512 3513 // Now, update the CFG. 3514 PBI->setSuccessor(PBI->getSuccessor(0) != BB, UniqueSucc); 3515 3516 if (DTU) 3517 DTU->applyUpdates({{DominatorTree::Insert, PredBlock, UniqueSucc}, 3518 {DominatorTree::Delete, PredBlock, BB}}); 3519 3520 // If BI was a loop latch, it may have had associated loop metadata. 3521 // We need to copy it to the new latch, that is, PBI. 3522 if (MDNode *LoopMD = BI->getMetadata(LLVMContext::MD_loop)) 3523 PBI->setMetadata(LLVMContext::MD_loop, LoopMD); 3524 3525 ValueToValueMapTy VMap; // maps original values to cloned values 3526 CloneInstructionsIntoPredecessorBlockAndUpdateSSAUses(BB, PredBlock, VMap); 3527 3528 // Now that the Cond was cloned into the predecessor basic block, 3529 // or/and the two conditions together. 3530 Value *BICond = VMap[BI->getCondition()]; 3531 PBI->setCondition( 3532 createLogicalOp(Builder, Opc, PBI->getCondition(), BICond, "or.cond")); 3533 3534 // Copy any debug value intrinsics into the end of PredBlock. 3535 for (Instruction &I : *BB) { 3536 if (isa<DbgInfoIntrinsic>(I)) { 3537 Instruction *NewI = I.clone(); 3538 RemapInstruction(NewI, VMap, 3539 RF_NoModuleLevelChanges | RF_IgnoreMissingLocals); 3540 NewI->insertBefore(PBI); 3541 } 3542 } 3543 3544 ++NumFoldBranchToCommonDest; 3545 return true; 3546 } 3547 3548 /// Return if an instruction's type or any of its operands' types are a vector 3549 /// type. 3550 static bool isVectorOp(Instruction &I) { 3551 return I.getType()->isVectorTy() || any_of(I.operands(), [](Use &U) { 3552 return U->getType()->isVectorTy(); 3553 }); 3554 } 3555 3556 /// If this basic block is simple enough, and if a predecessor branches to us 3557 /// and one of our successors, fold the block into the predecessor and use 3558 /// logical operations to pick the right destination. 3559 bool llvm::FoldBranchToCommonDest(BranchInst *BI, DomTreeUpdater *DTU, 3560 MemorySSAUpdater *MSSAU, 3561 const TargetTransformInfo *TTI, 3562 unsigned BonusInstThreshold) { 3563 // If this block ends with an unconditional branch, 3564 // let SpeculativelyExecuteBB() deal with it. 3565 if (!BI->isConditional()) 3566 return false; 3567 3568 BasicBlock *BB = BI->getParent(); 3569 TargetTransformInfo::TargetCostKind CostKind = 3570 BB->getParent()->hasMinSize() ? TargetTransformInfo::TCK_CodeSize 3571 : TargetTransformInfo::TCK_SizeAndLatency; 3572 3573 Instruction *Cond = dyn_cast<Instruction>(BI->getCondition()); 3574 3575 if (!Cond || 3576 (!isa<CmpInst>(Cond) && !isa<BinaryOperator>(Cond) && 3577 !isa<SelectInst>(Cond)) || 3578 Cond->getParent() != BB || !Cond->hasOneUse()) 3579 return false; 3580 3581 // Cond is known to be a compare or binary operator. Check to make sure that 3582 // neither operand is a potentially-trapping constant expression. 3583 if (canTrap(Cond->getOperand(0))) 3584 return false; 3585 if (canTrap(Cond->getOperand(1))) 3586 return false; 3587 3588 // Finally, don't infinitely unroll conditional loops. 3589 if (is_contained(successors(BB), BB)) 3590 return false; 3591 3592 // With which predecessors will we want to deal with? 3593 SmallVector<BasicBlock *, 8> Preds; 3594 for (BasicBlock *PredBlock : predecessors(BB)) { 3595 BranchInst *PBI = dyn_cast<BranchInst>(PredBlock->getTerminator()); 3596 3597 // Check that we have two conditional branches. If there is a PHI node in 3598 // the common successor, verify that the same value flows in from both 3599 // blocks. 3600 if (!PBI || PBI->isUnconditional() || !SafeToMergeTerminators(BI, PBI)) 3601 continue; 3602 3603 // Determine if the two branches share a common destination. 3604 Instruction::BinaryOps Opc; 3605 bool InvertPredCond; 3606 if (auto Recipe = shouldFoldCondBranchesToCommonDestination(BI, PBI, TTI)) 3607 std::tie(Opc, InvertPredCond) = *Recipe; 3608 else 3609 continue; 3610 3611 // Check the cost of inserting the necessary logic before performing the 3612 // transformation. 3613 if (TTI) { 3614 Type *Ty = BI->getCondition()->getType(); 3615 InstructionCost Cost = TTI->getArithmeticInstrCost(Opc, Ty, CostKind); 3616 if (InvertPredCond && (!PBI->getCondition()->hasOneUse() || 3617 !isa<CmpInst>(PBI->getCondition()))) 3618 Cost += TTI->getArithmeticInstrCost(Instruction::Xor, Ty, CostKind); 3619 3620 if (Cost > BranchFoldThreshold) 3621 continue; 3622 } 3623 3624 // Ok, we do want to deal with this predecessor. Record it. 3625 Preds.emplace_back(PredBlock); 3626 } 3627 3628 // If there aren't any predecessors into which we can fold, 3629 // don't bother checking the cost. 3630 if (Preds.empty()) 3631 return false; 3632 3633 // Only allow this transformation if computing the condition doesn't involve 3634 // too many instructions and these involved instructions can be executed 3635 // unconditionally. We denote all involved instructions except the condition 3636 // as "bonus instructions", and only allow this transformation when the 3637 // number of the bonus instructions we'll need to create when cloning into 3638 // each predecessor does not exceed a certain threshold. 3639 unsigned NumBonusInsts = 0; 3640 bool SawVectorOp = false; 3641 const unsigned PredCount = Preds.size(); 3642 for (Instruction &I : *BB) { 3643 // Don't check the branch condition comparison itself. 3644 if (&I == Cond) 3645 continue; 3646 // Ignore dbg intrinsics, and the terminator. 3647 if (isa<DbgInfoIntrinsic>(I) || isa<BranchInst>(I)) 3648 continue; 3649 // I must be safe to execute unconditionally. 3650 if (!isSafeToSpeculativelyExecute(&I)) 3651 return false; 3652 SawVectorOp |= isVectorOp(I); 3653 3654 // Account for the cost of duplicating this instruction into each 3655 // predecessor. Ignore free instructions. 3656 if (!TTI || 3657 TTI->getUserCost(&I, CostKind) != TargetTransformInfo::TCC_Free) { 3658 NumBonusInsts += PredCount; 3659 3660 // Early exits once we reach the limit. 3661 if (NumBonusInsts > 3662 BonusInstThreshold * BranchFoldToCommonDestVectorMultiplier) 3663 return false; 3664 } 3665 3666 auto IsBCSSAUse = [BB, &I](Use &U) { 3667 auto *UI = cast<Instruction>(U.getUser()); 3668 if (auto *PN = dyn_cast<PHINode>(UI)) 3669 return PN->getIncomingBlock(U) == BB; 3670 return UI->getParent() == BB && I.comesBefore(UI); 3671 }; 3672 3673 // Does this instruction require rewriting of uses? 3674 if (!all_of(I.uses(), IsBCSSAUse)) 3675 return false; 3676 } 3677 if (NumBonusInsts > 3678 BonusInstThreshold * 3679 (SawVectorOp ? BranchFoldToCommonDestVectorMultiplier : 1)) 3680 return false; 3681 3682 // Ok, we have the budget. Perform the transformation. 3683 for (BasicBlock *PredBlock : Preds) { 3684 auto *PBI = cast<BranchInst>(PredBlock->getTerminator()); 3685 return performBranchToCommonDestFolding(BI, PBI, DTU, MSSAU, TTI); 3686 } 3687 return false; 3688 } 3689 3690 // If there is only one store in BB1 and BB2, return it, otherwise return 3691 // nullptr. 3692 static StoreInst *findUniqueStoreInBlocks(BasicBlock *BB1, BasicBlock *BB2) { 3693 StoreInst *S = nullptr; 3694 for (auto *BB : {BB1, BB2}) { 3695 if (!BB) 3696 continue; 3697 for (auto &I : *BB) 3698 if (auto *SI = dyn_cast<StoreInst>(&I)) { 3699 if (S) 3700 // Multiple stores seen. 3701 return nullptr; 3702 else 3703 S = SI; 3704 } 3705 } 3706 return S; 3707 } 3708 3709 static Value *ensureValueAvailableInSuccessor(Value *V, BasicBlock *BB, 3710 Value *AlternativeV = nullptr) { 3711 // PHI is going to be a PHI node that allows the value V that is defined in 3712 // BB to be referenced in BB's only successor. 3713 // 3714 // If AlternativeV is nullptr, the only value we care about in PHI is V. It 3715 // doesn't matter to us what the other operand is (it'll never get used). We 3716 // could just create a new PHI with an undef incoming value, but that could 3717 // increase register pressure if EarlyCSE/InstCombine can't fold it with some 3718 // other PHI. So here we directly look for some PHI in BB's successor with V 3719 // as an incoming operand. If we find one, we use it, else we create a new 3720 // one. 3721 // 3722 // If AlternativeV is not nullptr, we care about both incoming values in PHI. 3723 // PHI must be exactly: phi <ty> [ %BB, %V ], [ %OtherBB, %AlternativeV] 3724 // where OtherBB is the single other predecessor of BB's only successor. 3725 PHINode *PHI = nullptr; 3726 BasicBlock *Succ = BB->getSingleSuccessor(); 3727 3728 for (auto I = Succ->begin(); isa<PHINode>(I); ++I) 3729 if (cast<PHINode>(I)->getIncomingValueForBlock(BB) == V) { 3730 PHI = cast<PHINode>(I); 3731 if (!AlternativeV) 3732 break; 3733 3734 assert(Succ->hasNPredecessors(2)); 3735 auto PredI = pred_begin(Succ); 3736 BasicBlock *OtherPredBB = *PredI == BB ? *++PredI : *PredI; 3737 if (PHI->getIncomingValueForBlock(OtherPredBB) == AlternativeV) 3738 break; 3739 PHI = nullptr; 3740 } 3741 if (PHI) 3742 return PHI; 3743 3744 // If V is not an instruction defined in BB, just return it. 3745 if (!AlternativeV && 3746 (!isa<Instruction>(V) || cast<Instruction>(V)->getParent() != BB)) 3747 return V; 3748 3749 PHI = PHINode::Create(V->getType(), 2, "simplifycfg.merge", &Succ->front()); 3750 PHI->addIncoming(V, BB); 3751 for (BasicBlock *PredBB : predecessors(Succ)) 3752 if (PredBB != BB) 3753 PHI->addIncoming( 3754 AlternativeV ? AlternativeV : UndefValue::get(V->getType()), PredBB); 3755 return PHI; 3756 } 3757 3758 static bool mergeConditionalStoreToAddress( 3759 BasicBlock *PTB, BasicBlock *PFB, BasicBlock *QTB, BasicBlock *QFB, 3760 BasicBlock *PostBB, Value *Address, bool InvertPCond, bool InvertQCond, 3761 DomTreeUpdater *DTU, const DataLayout &DL, const TargetTransformInfo &TTI) { 3762 // For every pointer, there must be exactly two stores, one coming from 3763 // PTB or PFB, and the other from QTB or QFB. We don't support more than one 3764 // store (to any address) in PTB,PFB or QTB,QFB. 3765 // FIXME: We could relax this restriction with a bit more work and performance 3766 // testing. 3767 StoreInst *PStore = findUniqueStoreInBlocks(PTB, PFB); 3768 StoreInst *QStore = findUniqueStoreInBlocks(QTB, QFB); 3769 if (!PStore || !QStore) 3770 return false; 3771 3772 // Now check the stores are compatible. 3773 if (!QStore->isUnordered() || !PStore->isUnordered() || 3774 PStore->getValueOperand()->getType() != 3775 QStore->getValueOperand()->getType()) 3776 return false; 3777 3778 // Check that sinking the store won't cause program behavior changes. Sinking 3779 // the store out of the Q blocks won't change any behavior as we're sinking 3780 // from a block to its unconditional successor. But we're moving a store from 3781 // the P blocks down through the middle block (QBI) and past both QFB and QTB. 3782 // So we need to check that there are no aliasing loads or stores in 3783 // QBI, QTB and QFB. We also need to check there are no conflicting memory 3784 // operations between PStore and the end of its parent block. 3785 // 3786 // The ideal way to do this is to query AliasAnalysis, but we don't 3787 // preserve AA currently so that is dangerous. Be super safe and just 3788 // check there are no other memory operations at all. 3789 for (auto &I : *QFB->getSinglePredecessor()) 3790 if (I.mayReadOrWriteMemory()) 3791 return false; 3792 for (auto &I : *QFB) 3793 if (&I != QStore && I.mayReadOrWriteMemory()) 3794 return false; 3795 if (QTB) 3796 for (auto &I : *QTB) 3797 if (&I != QStore && I.mayReadOrWriteMemory()) 3798 return false; 3799 for (auto I = BasicBlock::iterator(PStore), E = PStore->getParent()->end(); 3800 I != E; ++I) 3801 if (&*I != PStore && I->mayReadOrWriteMemory()) 3802 return false; 3803 3804 // If we're not in aggressive mode, we only optimize if we have some 3805 // confidence that by optimizing we'll allow P and/or Q to be if-converted. 3806 auto IsWorthwhile = [&](BasicBlock *BB, ArrayRef<StoreInst *> FreeStores) { 3807 if (!BB) 3808 return true; 3809 // Heuristic: if the block can be if-converted/phi-folded and the 3810 // instructions inside are all cheap (arithmetic/GEPs), it's worthwhile to 3811 // thread this store. 3812 InstructionCost Cost = 0; 3813 InstructionCost Budget = 3814 PHINodeFoldingThreshold * TargetTransformInfo::TCC_Basic; 3815 for (auto &I : BB->instructionsWithoutDebug(false)) { 3816 // Consider terminator instruction to be free. 3817 if (I.isTerminator()) 3818 continue; 3819 // If this is one the stores that we want to speculate out of this BB, 3820 // then don't count it's cost, consider it to be free. 3821 if (auto *S = dyn_cast<StoreInst>(&I)) 3822 if (llvm::find(FreeStores, S)) 3823 continue; 3824 // Else, we have a white-list of instructions that we are ak speculating. 3825 if (!isa<BinaryOperator>(I) && !isa<GetElementPtrInst>(I)) 3826 return false; // Not in white-list - not worthwhile folding. 3827 // And finally, if this is a non-free instruction that we are okay 3828 // speculating, ensure that we consider the speculation budget. 3829 Cost += TTI.getUserCost(&I, TargetTransformInfo::TCK_SizeAndLatency); 3830 if (Cost > Budget) 3831 return false; // Eagerly refuse to fold as soon as we're out of budget. 3832 } 3833 assert(Cost <= Budget && 3834 "When we run out of budget we will eagerly return from within the " 3835 "per-instruction loop."); 3836 return true; 3837 }; 3838 3839 const std::array<StoreInst *, 2> FreeStores = {PStore, QStore}; 3840 if (!MergeCondStoresAggressively && 3841 (!IsWorthwhile(PTB, FreeStores) || !IsWorthwhile(PFB, FreeStores) || 3842 !IsWorthwhile(QTB, FreeStores) || !IsWorthwhile(QFB, FreeStores))) 3843 return false; 3844 3845 // If PostBB has more than two predecessors, we need to split it so we can 3846 // sink the store. 3847 if (std::next(pred_begin(PostBB), 2) != pred_end(PostBB)) { 3848 // We know that QFB's only successor is PostBB. And QFB has a single 3849 // predecessor. If QTB exists, then its only successor is also PostBB. 3850 // If QTB does not exist, then QFB's only predecessor has a conditional 3851 // branch to QFB and PostBB. 3852 BasicBlock *TruePred = QTB ? QTB : QFB->getSinglePredecessor(); 3853 BasicBlock *NewBB = 3854 SplitBlockPredecessors(PostBB, {QFB, TruePred}, "condstore.split", DTU); 3855 if (!NewBB) 3856 return false; 3857 PostBB = NewBB; 3858 } 3859 3860 // OK, we're going to sink the stores to PostBB. The store has to be 3861 // conditional though, so first create the predicate. 3862 Value *PCond = cast<BranchInst>(PFB->getSinglePredecessor()->getTerminator()) 3863 ->getCondition(); 3864 Value *QCond = cast<BranchInst>(QFB->getSinglePredecessor()->getTerminator()) 3865 ->getCondition(); 3866 3867 Value *PPHI = ensureValueAvailableInSuccessor(PStore->getValueOperand(), 3868 PStore->getParent()); 3869 Value *QPHI = ensureValueAvailableInSuccessor(QStore->getValueOperand(), 3870 QStore->getParent(), PPHI); 3871 3872 IRBuilder<> QB(&*PostBB->getFirstInsertionPt()); 3873 3874 Value *PPred = PStore->getParent() == PTB ? PCond : QB.CreateNot(PCond); 3875 Value *QPred = QStore->getParent() == QTB ? QCond : QB.CreateNot(QCond); 3876 3877 if (InvertPCond) 3878 PPred = QB.CreateNot(PPred); 3879 if (InvertQCond) 3880 QPred = QB.CreateNot(QPred); 3881 Value *CombinedPred = QB.CreateOr(PPred, QPred); 3882 3883 auto *T = SplitBlockAndInsertIfThen(CombinedPred, &*QB.GetInsertPoint(), 3884 /*Unreachable=*/false, 3885 /*BranchWeights=*/nullptr, DTU); 3886 QB.SetInsertPoint(T); 3887 StoreInst *SI = cast<StoreInst>(QB.CreateStore(QPHI, Address)); 3888 SI->setAAMetadata(PStore->getAAMetadata().merge(QStore->getAAMetadata())); 3889 // Choose the minimum alignment. If we could prove both stores execute, we 3890 // could use biggest one. In this case, though, we only know that one of the 3891 // stores executes. And we don't know it's safe to take the alignment from a 3892 // store that doesn't execute. 3893 SI->setAlignment(std::min(PStore->getAlign(), QStore->getAlign())); 3894 3895 QStore->eraseFromParent(); 3896 PStore->eraseFromParent(); 3897 3898 return true; 3899 } 3900 3901 static bool mergeConditionalStores(BranchInst *PBI, BranchInst *QBI, 3902 DomTreeUpdater *DTU, const DataLayout &DL, 3903 const TargetTransformInfo &TTI) { 3904 // The intention here is to find diamonds or triangles (see below) where each 3905 // conditional block contains a store to the same address. Both of these 3906 // stores are conditional, so they can't be unconditionally sunk. But it may 3907 // be profitable to speculatively sink the stores into one merged store at the 3908 // end, and predicate the merged store on the union of the two conditions of 3909 // PBI and QBI. 3910 // 3911 // This can reduce the number of stores executed if both of the conditions are 3912 // true, and can allow the blocks to become small enough to be if-converted. 3913 // This optimization will also chain, so that ladders of test-and-set 3914 // sequences can be if-converted away. 3915 // 3916 // We only deal with simple diamonds or triangles: 3917 // 3918 // PBI or PBI or a combination of the two 3919 // / \ | \ 3920 // PTB PFB | PFB 3921 // \ / | / 3922 // QBI QBI 3923 // / \ | \ 3924 // QTB QFB | QFB 3925 // \ / | / 3926 // PostBB PostBB 3927 // 3928 // We model triangles as a type of diamond with a nullptr "true" block. 3929 // Triangles are canonicalized so that the fallthrough edge is represented by 3930 // a true condition, as in the diagram above. 3931 BasicBlock *PTB = PBI->getSuccessor(0); 3932 BasicBlock *PFB = PBI->getSuccessor(1); 3933 BasicBlock *QTB = QBI->getSuccessor(0); 3934 BasicBlock *QFB = QBI->getSuccessor(1); 3935 BasicBlock *PostBB = QFB->getSingleSuccessor(); 3936 3937 // Make sure we have a good guess for PostBB. If QTB's only successor is 3938 // QFB, then QFB is a better PostBB. 3939 if (QTB->getSingleSuccessor() == QFB) 3940 PostBB = QFB; 3941 3942 // If we couldn't find a good PostBB, stop. 3943 if (!PostBB) 3944 return false; 3945 3946 bool InvertPCond = false, InvertQCond = false; 3947 // Canonicalize fallthroughs to the true branches. 3948 if (PFB == QBI->getParent()) { 3949 std::swap(PFB, PTB); 3950 InvertPCond = true; 3951 } 3952 if (QFB == PostBB) { 3953 std::swap(QFB, QTB); 3954 InvertQCond = true; 3955 } 3956 3957 // From this point on we can assume PTB or QTB may be fallthroughs but PFB 3958 // and QFB may not. Model fallthroughs as a nullptr block. 3959 if (PTB == QBI->getParent()) 3960 PTB = nullptr; 3961 if (QTB == PostBB) 3962 QTB = nullptr; 3963 3964 // Legality bailouts. We must have at least the non-fallthrough blocks and 3965 // the post-dominating block, and the non-fallthroughs must only have one 3966 // predecessor. 3967 auto HasOnePredAndOneSucc = [](BasicBlock *BB, BasicBlock *P, BasicBlock *S) { 3968 return BB->getSinglePredecessor() == P && BB->getSingleSuccessor() == S; 3969 }; 3970 if (!HasOnePredAndOneSucc(PFB, PBI->getParent(), QBI->getParent()) || 3971 !HasOnePredAndOneSucc(QFB, QBI->getParent(), PostBB)) 3972 return false; 3973 if ((PTB && !HasOnePredAndOneSucc(PTB, PBI->getParent(), QBI->getParent())) || 3974 (QTB && !HasOnePredAndOneSucc(QTB, QBI->getParent(), PostBB))) 3975 return false; 3976 if (!QBI->getParent()->hasNUses(2)) 3977 return false; 3978 3979 // OK, this is a sequence of two diamonds or triangles. 3980 // Check if there are stores in PTB or PFB that are repeated in QTB or QFB. 3981 SmallPtrSet<Value *, 4> PStoreAddresses, QStoreAddresses; 3982 for (auto *BB : {PTB, PFB}) { 3983 if (!BB) 3984 continue; 3985 for (auto &I : *BB) 3986 if (StoreInst *SI = dyn_cast<StoreInst>(&I)) 3987 PStoreAddresses.insert(SI->getPointerOperand()); 3988 } 3989 for (auto *BB : {QTB, QFB}) { 3990 if (!BB) 3991 continue; 3992 for (auto &I : *BB) 3993 if (StoreInst *SI = dyn_cast<StoreInst>(&I)) 3994 QStoreAddresses.insert(SI->getPointerOperand()); 3995 } 3996 3997 set_intersect(PStoreAddresses, QStoreAddresses); 3998 // set_intersect mutates PStoreAddresses in place. Rename it here to make it 3999 // clear what it contains. 4000 auto &CommonAddresses = PStoreAddresses; 4001 4002 bool Changed = false; 4003 for (auto *Address : CommonAddresses) 4004 Changed |= 4005 mergeConditionalStoreToAddress(PTB, PFB, QTB, QFB, PostBB, Address, 4006 InvertPCond, InvertQCond, DTU, DL, TTI); 4007 return Changed; 4008 } 4009 4010 /// If the previous block ended with a widenable branch, determine if reusing 4011 /// the target block is profitable and legal. This will have the effect of 4012 /// "widening" PBI, but doesn't require us to reason about hosting safety. 4013 static bool tryWidenCondBranchToCondBranch(BranchInst *PBI, BranchInst *BI, 4014 DomTreeUpdater *DTU) { 4015 // TODO: This can be generalized in two important ways: 4016 // 1) We can allow phi nodes in IfFalseBB and simply reuse all the input 4017 // values from the PBI edge. 4018 // 2) We can sink side effecting instructions into BI's fallthrough 4019 // successor provided they doesn't contribute to computation of 4020 // BI's condition. 4021 Value *CondWB, *WC; 4022 BasicBlock *IfTrueBB, *IfFalseBB; 4023 if (!parseWidenableBranch(PBI, CondWB, WC, IfTrueBB, IfFalseBB) || 4024 IfTrueBB != BI->getParent() || !BI->getParent()->getSinglePredecessor()) 4025 return false; 4026 if (!IfFalseBB->phis().empty()) 4027 return false; // TODO 4028 // Use lambda to lazily compute expensive condition after cheap ones. 4029 auto NoSideEffects = [](BasicBlock &BB) { 4030 return llvm::none_of(BB, [](const Instruction &I) { 4031 return I.mayWriteToMemory() || I.mayHaveSideEffects(); 4032 }); 4033 }; 4034 if (BI->getSuccessor(1) != IfFalseBB && // no inf looping 4035 BI->getSuccessor(1)->getTerminatingDeoptimizeCall() && // profitability 4036 NoSideEffects(*BI->getParent())) { 4037 auto *OldSuccessor = BI->getSuccessor(1); 4038 OldSuccessor->removePredecessor(BI->getParent()); 4039 BI->setSuccessor(1, IfFalseBB); 4040 if (DTU) 4041 DTU->applyUpdates( 4042 {{DominatorTree::Insert, BI->getParent(), IfFalseBB}, 4043 {DominatorTree::Delete, BI->getParent(), OldSuccessor}}); 4044 return true; 4045 } 4046 if (BI->getSuccessor(0) != IfFalseBB && // no inf looping 4047 BI->getSuccessor(0)->getTerminatingDeoptimizeCall() && // profitability 4048 NoSideEffects(*BI->getParent())) { 4049 auto *OldSuccessor = BI->getSuccessor(0); 4050 OldSuccessor->removePredecessor(BI->getParent()); 4051 BI->setSuccessor(0, IfFalseBB); 4052 if (DTU) 4053 DTU->applyUpdates( 4054 {{DominatorTree::Insert, BI->getParent(), IfFalseBB}, 4055 {DominatorTree::Delete, BI->getParent(), OldSuccessor}}); 4056 return true; 4057 } 4058 return false; 4059 } 4060 4061 /// If we have a conditional branch as a predecessor of another block, 4062 /// this function tries to simplify it. We know 4063 /// that PBI and BI are both conditional branches, and BI is in one of the 4064 /// successor blocks of PBI - PBI branches to BI. 4065 static bool SimplifyCondBranchToCondBranch(BranchInst *PBI, BranchInst *BI, 4066 DomTreeUpdater *DTU, 4067 const DataLayout &DL, 4068 const TargetTransformInfo &TTI) { 4069 assert(PBI->isConditional() && BI->isConditional()); 4070 BasicBlock *BB = BI->getParent(); 4071 4072 // If this block ends with a branch instruction, and if there is a 4073 // predecessor that ends on a branch of the same condition, make 4074 // this conditional branch redundant. 4075 if (PBI->getCondition() == BI->getCondition() && 4076 PBI->getSuccessor(0) != PBI->getSuccessor(1)) { 4077 // Okay, the outcome of this conditional branch is statically 4078 // knowable. If this block had a single pred, handle specially, otherwise 4079 // FoldCondBranchOnValueKnownInPredecessor() will handle it. 4080 if (BB->getSinglePredecessor()) { 4081 // Turn this into a branch on constant. 4082 bool CondIsTrue = PBI->getSuccessor(0) == BB; 4083 BI->setCondition( 4084 ConstantInt::get(Type::getInt1Ty(BB->getContext()), CondIsTrue)); 4085 return true; // Nuke the branch on constant. 4086 } 4087 } 4088 4089 // If the previous block ended with a widenable branch, determine if reusing 4090 // the target block is profitable and legal. This will have the effect of 4091 // "widening" PBI, but doesn't require us to reason about hosting safety. 4092 if (tryWidenCondBranchToCondBranch(PBI, BI, DTU)) 4093 return true; 4094 4095 if (canTrap(BI->getCondition())) 4096 return false; 4097 4098 // If both branches are conditional and both contain stores to the same 4099 // address, remove the stores from the conditionals and create a conditional 4100 // merged store at the end. 4101 if (MergeCondStores && mergeConditionalStores(PBI, BI, DTU, DL, TTI)) 4102 return true; 4103 4104 // If this is a conditional branch in an empty block, and if any 4105 // predecessors are a conditional branch to one of our destinations, 4106 // fold the conditions into logical ops and one cond br. 4107 4108 // Ignore dbg intrinsics. 4109 if (&*BB->instructionsWithoutDebug(false).begin() != BI) 4110 return false; 4111 4112 int PBIOp, BIOp; 4113 if (PBI->getSuccessor(0) == BI->getSuccessor(0)) { 4114 PBIOp = 0; 4115 BIOp = 0; 4116 } else if (PBI->getSuccessor(0) == BI->getSuccessor(1)) { 4117 PBIOp = 0; 4118 BIOp = 1; 4119 } else if (PBI->getSuccessor(1) == BI->getSuccessor(0)) { 4120 PBIOp = 1; 4121 BIOp = 0; 4122 } else if (PBI->getSuccessor(1) == BI->getSuccessor(1)) { 4123 PBIOp = 1; 4124 BIOp = 1; 4125 } else { 4126 return false; 4127 } 4128 4129 // Check to make sure that the other destination of this branch 4130 // isn't BB itself. If so, this is an infinite loop that will 4131 // keep getting unwound. 4132 if (PBI->getSuccessor(PBIOp) == BB) 4133 return false; 4134 4135 // Do not perform this transformation if it would require 4136 // insertion of a large number of select instructions. For targets 4137 // without predication/cmovs, this is a big pessimization. 4138 4139 // Also do not perform this transformation if any phi node in the common 4140 // destination block can trap when reached by BB or PBB (PR17073). In that 4141 // case, it would be unsafe to hoist the operation into a select instruction. 4142 4143 BasicBlock *CommonDest = PBI->getSuccessor(PBIOp); 4144 BasicBlock *RemovedDest = PBI->getSuccessor(PBIOp ^ 1); 4145 unsigned NumPhis = 0; 4146 for (BasicBlock::iterator II = CommonDest->begin(); isa<PHINode>(II); 4147 ++II, ++NumPhis) { 4148 if (NumPhis > 2) // Disable this xform. 4149 return false; 4150 4151 PHINode *PN = cast<PHINode>(II); 4152 Value *BIV = PN->getIncomingValueForBlock(BB); 4153 if (canTrap(BIV)) 4154 return false; 4155 4156 unsigned PBBIdx = PN->getBasicBlockIndex(PBI->getParent()); 4157 Value *PBIV = PN->getIncomingValue(PBBIdx); 4158 if (canTrap(PBIV)) 4159 return false; 4160 } 4161 4162 // Finally, if everything is ok, fold the branches to logical ops. 4163 BasicBlock *OtherDest = BI->getSuccessor(BIOp ^ 1); 4164 4165 LLVM_DEBUG(dbgs() << "FOLDING BRs:" << *PBI->getParent() 4166 << "AND: " << *BI->getParent()); 4167 4168 SmallVector<DominatorTree::UpdateType, 5> Updates; 4169 4170 // If OtherDest *is* BB, then BB is a basic block with a single conditional 4171 // branch in it, where one edge (OtherDest) goes back to itself but the other 4172 // exits. We don't *know* that the program avoids the infinite loop 4173 // (even though that seems likely). If we do this xform naively, we'll end up 4174 // recursively unpeeling the loop. Since we know that (after the xform is 4175 // done) that the block *is* infinite if reached, we just make it an obviously 4176 // infinite loop with no cond branch. 4177 if (OtherDest == BB) { 4178 // Insert it at the end of the function, because it's either code, 4179 // or it won't matter if it's hot. :) 4180 BasicBlock *InfLoopBlock = 4181 BasicBlock::Create(BB->getContext(), "infloop", BB->getParent()); 4182 BranchInst::Create(InfLoopBlock, InfLoopBlock); 4183 if (DTU) 4184 Updates.push_back({DominatorTree::Insert, InfLoopBlock, InfLoopBlock}); 4185 OtherDest = InfLoopBlock; 4186 } 4187 4188 LLVM_DEBUG(dbgs() << *PBI->getParent()->getParent()); 4189 4190 // BI may have other predecessors. Because of this, we leave 4191 // it alone, but modify PBI. 4192 4193 // Make sure we get to CommonDest on True&True directions. 4194 Value *PBICond = PBI->getCondition(); 4195 IRBuilder<NoFolder> Builder(PBI); 4196 if (PBIOp) 4197 PBICond = Builder.CreateNot(PBICond, PBICond->getName() + ".not"); 4198 4199 Value *BICond = BI->getCondition(); 4200 if (BIOp) 4201 BICond = Builder.CreateNot(BICond, BICond->getName() + ".not"); 4202 4203 // Merge the conditions. 4204 Value *Cond = 4205 createLogicalOp(Builder, Instruction::Or, PBICond, BICond, "brmerge"); 4206 4207 // Modify PBI to branch on the new condition to the new dests. 4208 PBI->setCondition(Cond); 4209 PBI->setSuccessor(0, CommonDest); 4210 PBI->setSuccessor(1, OtherDest); 4211 4212 if (DTU) { 4213 Updates.push_back({DominatorTree::Insert, PBI->getParent(), OtherDest}); 4214 Updates.push_back({DominatorTree::Delete, PBI->getParent(), RemovedDest}); 4215 4216 DTU->applyUpdates(Updates); 4217 } 4218 4219 // Update branch weight for PBI. 4220 uint64_t PredTrueWeight, PredFalseWeight, SuccTrueWeight, SuccFalseWeight; 4221 uint64_t PredCommon, PredOther, SuccCommon, SuccOther; 4222 bool HasWeights = 4223 extractPredSuccWeights(PBI, BI, PredTrueWeight, PredFalseWeight, 4224 SuccTrueWeight, SuccFalseWeight); 4225 if (HasWeights) { 4226 PredCommon = PBIOp ? PredFalseWeight : PredTrueWeight; 4227 PredOther = PBIOp ? PredTrueWeight : PredFalseWeight; 4228 SuccCommon = BIOp ? SuccFalseWeight : SuccTrueWeight; 4229 SuccOther = BIOp ? SuccTrueWeight : SuccFalseWeight; 4230 // The weight to CommonDest should be PredCommon * SuccTotal + 4231 // PredOther * SuccCommon. 4232 // The weight to OtherDest should be PredOther * SuccOther. 4233 uint64_t NewWeights[2] = {PredCommon * (SuccCommon + SuccOther) + 4234 PredOther * SuccCommon, 4235 PredOther * SuccOther}; 4236 // Halve the weights if any of them cannot fit in an uint32_t 4237 FitWeights(NewWeights); 4238 4239 setBranchWeights(PBI, NewWeights[0], NewWeights[1]); 4240 } 4241 4242 // OtherDest may have phi nodes. If so, add an entry from PBI's 4243 // block that are identical to the entries for BI's block. 4244 AddPredecessorToBlock(OtherDest, PBI->getParent(), BB); 4245 4246 // We know that the CommonDest already had an edge from PBI to 4247 // it. If it has PHIs though, the PHIs may have different 4248 // entries for BB and PBI's BB. If so, insert a select to make 4249 // them agree. 4250 for (PHINode &PN : CommonDest->phis()) { 4251 Value *BIV = PN.getIncomingValueForBlock(BB); 4252 unsigned PBBIdx = PN.getBasicBlockIndex(PBI->getParent()); 4253 Value *PBIV = PN.getIncomingValue(PBBIdx); 4254 if (BIV != PBIV) { 4255 // Insert a select in PBI to pick the right value. 4256 SelectInst *NV = cast<SelectInst>( 4257 Builder.CreateSelect(PBICond, PBIV, BIV, PBIV->getName() + ".mux")); 4258 PN.setIncomingValue(PBBIdx, NV); 4259 // Although the select has the same condition as PBI, the original branch 4260 // weights for PBI do not apply to the new select because the select's 4261 // 'logical' edges are incoming edges of the phi that is eliminated, not 4262 // the outgoing edges of PBI. 4263 if (HasWeights) { 4264 uint64_t PredCommon = PBIOp ? PredFalseWeight : PredTrueWeight; 4265 uint64_t PredOther = PBIOp ? PredTrueWeight : PredFalseWeight; 4266 uint64_t SuccCommon = BIOp ? SuccFalseWeight : SuccTrueWeight; 4267 uint64_t SuccOther = BIOp ? SuccTrueWeight : SuccFalseWeight; 4268 // The weight to PredCommonDest should be PredCommon * SuccTotal. 4269 // The weight to PredOtherDest should be PredOther * SuccCommon. 4270 uint64_t NewWeights[2] = {PredCommon * (SuccCommon + SuccOther), 4271 PredOther * SuccCommon}; 4272 4273 FitWeights(NewWeights); 4274 4275 setBranchWeights(NV, NewWeights[0], NewWeights[1]); 4276 } 4277 } 4278 } 4279 4280 LLVM_DEBUG(dbgs() << "INTO: " << *PBI->getParent()); 4281 LLVM_DEBUG(dbgs() << *PBI->getParent()->getParent()); 4282 4283 // This basic block is probably dead. We know it has at least 4284 // one fewer predecessor. 4285 return true; 4286 } 4287 4288 // Simplifies a terminator by replacing it with a branch to TrueBB if Cond is 4289 // true or to FalseBB if Cond is false. 4290 // Takes care of updating the successors and removing the old terminator. 4291 // Also makes sure not to introduce new successors by assuming that edges to 4292 // non-successor TrueBBs and FalseBBs aren't reachable. 4293 bool SimplifyCFGOpt::SimplifyTerminatorOnSelect(Instruction *OldTerm, 4294 Value *Cond, BasicBlock *TrueBB, 4295 BasicBlock *FalseBB, 4296 uint32_t TrueWeight, 4297 uint32_t FalseWeight) { 4298 auto *BB = OldTerm->getParent(); 4299 // Remove any superfluous successor edges from the CFG. 4300 // First, figure out which successors to preserve. 4301 // If TrueBB and FalseBB are equal, only try to preserve one copy of that 4302 // successor. 4303 BasicBlock *KeepEdge1 = TrueBB; 4304 BasicBlock *KeepEdge2 = TrueBB != FalseBB ? FalseBB : nullptr; 4305 4306 SmallSetVector<BasicBlock *, 2> RemovedSuccessors; 4307 4308 // Then remove the rest. 4309 for (BasicBlock *Succ : successors(OldTerm)) { 4310 // Make sure only to keep exactly one copy of each edge. 4311 if (Succ == KeepEdge1) 4312 KeepEdge1 = nullptr; 4313 else if (Succ == KeepEdge2) 4314 KeepEdge2 = nullptr; 4315 else { 4316 Succ->removePredecessor(BB, 4317 /*KeepOneInputPHIs=*/true); 4318 4319 if (Succ != TrueBB && Succ != FalseBB) 4320 RemovedSuccessors.insert(Succ); 4321 } 4322 } 4323 4324 IRBuilder<> Builder(OldTerm); 4325 Builder.SetCurrentDebugLocation(OldTerm->getDebugLoc()); 4326 4327 // Insert an appropriate new terminator. 4328 if (!KeepEdge1 && !KeepEdge2) { 4329 if (TrueBB == FalseBB) { 4330 // We were only looking for one successor, and it was present. 4331 // Create an unconditional branch to it. 4332 Builder.CreateBr(TrueBB); 4333 } else { 4334 // We found both of the successors we were looking for. 4335 // Create a conditional branch sharing the condition of the select. 4336 BranchInst *NewBI = Builder.CreateCondBr(Cond, TrueBB, FalseBB); 4337 if (TrueWeight != FalseWeight) 4338 setBranchWeights(NewBI, TrueWeight, FalseWeight); 4339 } 4340 } else if (KeepEdge1 && (KeepEdge2 || TrueBB == FalseBB)) { 4341 // Neither of the selected blocks were successors, so this 4342 // terminator must be unreachable. 4343 new UnreachableInst(OldTerm->getContext(), OldTerm); 4344 } else { 4345 // One of the selected values was a successor, but the other wasn't. 4346 // Insert an unconditional branch to the one that was found; 4347 // the edge to the one that wasn't must be unreachable. 4348 if (!KeepEdge1) { 4349 // Only TrueBB was found. 4350 Builder.CreateBr(TrueBB); 4351 } else { 4352 // Only FalseBB was found. 4353 Builder.CreateBr(FalseBB); 4354 } 4355 } 4356 4357 EraseTerminatorAndDCECond(OldTerm); 4358 4359 if (DTU) { 4360 SmallVector<DominatorTree::UpdateType, 2> Updates; 4361 Updates.reserve(RemovedSuccessors.size()); 4362 for (auto *RemovedSuccessor : RemovedSuccessors) 4363 Updates.push_back({DominatorTree::Delete, BB, RemovedSuccessor}); 4364 DTU->applyUpdates(Updates); 4365 } 4366 4367 return true; 4368 } 4369 4370 // Replaces 4371 // (switch (select cond, X, Y)) on constant X, Y 4372 // with a branch - conditional if X and Y lead to distinct BBs, 4373 // unconditional otherwise. 4374 bool SimplifyCFGOpt::SimplifySwitchOnSelect(SwitchInst *SI, 4375 SelectInst *Select) { 4376 // Check for constant integer values in the select. 4377 ConstantInt *TrueVal = dyn_cast<ConstantInt>(Select->getTrueValue()); 4378 ConstantInt *FalseVal = dyn_cast<ConstantInt>(Select->getFalseValue()); 4379 if (!TrueVal || !FalseVal) 4380 return false; 4381 4382 // Find the relevant condition and destinations. 4383 Value *Condition = Select->getCondition(); 4384 BasicBlock *TrueBB = SI->findCaseValue(TrueVal)->getCaseSuccessor(); 4385 BasicBlock *FalseBB = SI->findCaseValue(FalseVal)->getCaseSuccessor(); 4386 4387 // Get weight for TrueBB and FalseBB. 4388 uint32_t TrueWeight = 0, FalseWeight = 0; 4389 SmallVector<uint64_t, 8> Weights; 4390 bool HasWeights = HasBranchWeights(SI); 4391 if (HasWeights) { 4392 GetBranchWeights(SI, Weights); 4393 if (Weights.size() == 1 + SI->getNumCases()) { 4394 TrueWeight = 4395 (uint32_t)Weights[SI->findCaseValue(TrueVal)->getSuccessorIndex()]; 4396 FalseWeight = 4397 (uint32_t)Weights[SI->findCaseValue(FalseVal)->getSuccessorIndex()]; 4398 } 4399 } 4400 4401 // Perform the actual simplification. 4402 return SimplifyTerminatorOnSelect(SI, Condition, TrueBB, FalseBB, TrueWeight, 4403 FalseWeight); 4404 } 4405 4406 // Replaces 4407 // (indirectbr (select cond, blockaddress(@fn, BlockA), 4408 // blockaddress(@fn, BlockB))) 4409 // with 4410 // (br cond, BlockA, BlockB). 4411 bool SimplifyCFGOpt::SimplifyIndirectBrOnSelect(IndirectBrInst *IBI, 4412 SelectInst *SI) { 4413 // Check that both operands of the select are block addresses. 4414 BlockAddress *TBA = dyn_cast<BlockAddress>(SI->getTrueValue()); 4415 BlockAddress *FBA = dyn_cast<BlockAddress>(SI->getFalseValue()); 4416 if (!TBA || !FBA) 4417 return false; 4418 4419 // Extract the actual blocks. 4420 BasicBlock *TrueBB = TBA->getBasicBlock(); 4421 BasicBlock *FalseBB = FBA->getBasicBlock(); 4422 4423 // Perform the actual simplification. 4424 return SimplifyTerminatorOnSelect(IBI, SI->getCondition(), TrueBB, FalseBB, 0, 4425 0); 4426 } 4427 4428 /// This is called when we find an icmp instruction 4429 /// (a seteq/setne with a constant) as the only instruction in a 4430 /// block that ends with an uncond branch. We are looking for a very specific 4431 /// pattern that occurs when "A == 1 || A == 2 || A == 3" gets simplified. In 4432 /// this case, we merge the first two "or's of icmp" into a switch, but then the 4433 /// default value goes to an uncond block with a seteq in it, we get something 4434 /// like: 4435 /// 4436 /// switch i8 %A, label %DEFAULT [ i8 1, label %end i8 2, label %end ] 4437 /// DEFAULT: 4438 /// %tmp = icmp eq i8 %A, 92 4439 /// br label %end 4440 /// end: 4441 /// ... = phi i1 [ true, %entry ], [ %tmp, %DEFAULT ], [ true, %entry ] 4442 /// 4443 /// We prefer to split the edge to 'end' so that there is a true/false entry to 4444 /// the PHI, merging the third icmp into the switch. 4445 bool SimplifyCFGOpt::tryToSimplifyUncondBranchWithICmpInIt( 4446 ICmpInst *ICI, IRBuilder<> &Builder) { 4447 BasicBlock *BB = ICI->getParent(); 4448 4449 // If the block has any PHIs in it or the icmp has multiple uses, it is too 4450 // complex. 4451 if (isa<PHINode>(BB->begin()) || !ICI->hasOneUse()) 4452 return false; 4453 4454 Value *V = ICI->getOperand(0); 4455 ConstantInt *Cst = cast<ConstantInt>(ICI->getOperand(1)); 4456 4457 // The pattern we're looking for is where our only predecessor is a switch on 4458 // 'V' and this block is the default case for the switch. In this case we can 4459 // fold the compared value into the switch to simplify things. 4460 BasicBlock *Pred = BB->getSinglePredecessor(); 4461 if (!Pred || !isa<SwitchInst>(Pred->getTerminator())) 4462 return false; 4463 4464 SwitchInst *SI = cast<SwitchInst>(Pred->getTerminator()); 4465 if (SI->getCondition() != V) 4466 return false; 4467 4468 // If BB is reachable on a non-default case, then we simply know the value of 4469 // V in this block. Substitute it and constant fold the icmp instruction 4470 // away. 4471 if (SI->getDefaultDest() != BB) { 4472 ConstantInt *VVal = SI->findCaseDest(BB); 4473 assert(VVal && "Should have a unique destination value"); 4474 ICI->setOperand(0, VVal); 4475 4476 if (Value *V = simplifyInstruction(ICI, {DL, ICI})) { 4477 ICI->replaceAllUsesWith(V); 4478 ICI->eraseFromParent(); 4479 } 4480 // BB is now empty, so it is likely to simplify away. 4481 return requestResimplify(); 4482 } 4483 4484 // Ok, the block is reachable from the default dest. If the constant we're 4485 // comparing exists in one of the other edges, then we can constant fold ICI 4486 // and zap it. 4487 if (SI->findCaseValue(Cst) != SI->case_default()) { 4488 Value *V; 4489 if (ICI->getPredicate() == ICmpInst::ICMP_EQ) 4490 V = ConstantInt::getFalse(BB->getContext()); 4491 else 4492 V = ConstantInt::getTrue(BB->getContext()); 4493 4494 ICI->replaceAllUsesWith(V); 4495 ICI->eraseFromParent(); 4496 // BB is now empty, so it is likely to simplify away. 4497 return requestResimplify(); 4498 } 4499 4500 // The use of the icmp has to be in the 'end' block, by the only PHI node in 4501 // the block. 4502 BasicBlock *SuccBlock = BB->getTerminator()->getSuccessor(0); 4503 PHINode *PHIUse = dyn_cast<PHINode>(ICI->user_back()); 4504 if (PHIUse == nullptr || PHIUse != &SuccBlock->front() || 4505 isa<PHINode>(++BasicBlock::iterator(PHIUse))) 4506 return false; 4507 4508 // If the icmp is a SETEQ, then the default dest gets false, the new edge gets 4509 // true in the PHI. 4510 Constant *DefaultCst = ConstantInt::getTrue(BB->getContext()); 4511 Constant *NewCst = ConstantInt::getFalse(BB->getContext()); 4512 4513 if (ICI->getPredicate() == ICmpInst::ICMP_EQ) 4514 std::swap(DefaultCst, NewCst); 4515 4516 // Replace ICI (which is used by the PHI for the default value) with true or 4517 // false depending on if it is EQ or NE. 4518 ICI->replaceAllUsesWith(DefaultCst); 4519 ICI->eraseFromParent(); 4520 4521 SmallVector<DominatorTree::UpdateType, 2> Updates; 4522 4523 // Okay, the switch goes to this block on a default value. Add an edge from 4524 // the switch to the merge point on the compared value. 4525 BasicBlock *NewBB = 4526 BasicBlock::Create(BB->getContext(), "switch.edge", BB->getParent(), BB); 4527 { 4528 SwitchInstProfUpdateWrapper SIW(*SI); 4529 auto W0 = SIW.getSuccessorWeight(0); 4530 SwitchInstProfUpdateWrapper::CaseWeightOpt NewW; 4531 if (W0) { 4532 NewW = ((uint64_t(*W0) + 1) >> 1); 4533 SIW.setSuccessorWeight(0, *NewW); 4534 } 4535 SIW.addCase(Cst, NewBB, NewW); 4536 if (DTU) 4537 Updates.push_back({DominatorTree::Insert, Pred, NewBB}); 4538 } 4539 4540 // NewBB branches to the phi block, add the uncond branch and the phi entry. 4541 Builder.SetInsertPoint(NewBB); 4542 Builder.SetCurrentDebugLocation(SI->getDebugLoc()); 4543 Builder.CreateBr(SuccBlock); 4544 PHIUse->addIncoming(NewCst, NewBB); 4545 if (DTU) { 4546 Updates.push_back({DominatorTree::Insert, NewBB, SuccBlock}); 4547 DTU->applyUpdates(Updates); 4548 } 4549 return true; 4550 } 4551 4552 /// The specified branch is a conditional branch. 4553 /// Check to see if it is branching on an or/and chain of icmp instructions, and 4554 /// fold it into a switch instruction if so. 4555 bool SimplifyCFGOpt::SimplifyBranchOnICmpChain(BranchInst *BI, 4556 IRBuilder<> &Builder, 4557 const DataLayout &DL) { 4558 Instruction *Cond = dyn_cast<Instruction>(BI->getCondition()); 4559 if (!Cond) 4560 return false; 4561 4562 // Change br (X == 0 | X == 1), T, F into a switch instruction. 4563 // If this is a bunch of seteq's or'd together, or if it's a bunch of 4564 // 'setne's and'ed together, collect them. 4565 4566 // Try to gather values from a chain of and/or to be turned into a switch 4567 ConstantComparesGatherer ConstantCompare(Cond, DL); 4568 // Unpack the result 4569 SmallVectorImpl<ConstantInt *> &Values = ConstantCompare.Vals; 4570 Value *CompVal = ConstantCompare.CompValue; 4571 unsigned UsedICmps = ConstantCompare.UsedICmps; 4572 Value *ExtraCase = ConstantCompare.Extra; 4573 4574 // If we didn't have a multiply compared value, fail. 4575 if (!CompVal) 4576 return false; 4577 4578 // Avoid turning single icmps into a switch. 4579 if (UsedICmps <= 1) 4580 return false; 4581 4582 bool TrueWhenEqual = match(Cond, m_LogicalOr(m_Value(), m_Value())); 4583 4584 // There might be duplicate constants in the list, which the switch 4585 // instruction can't handle, remove them now. 4586 array_pod_sort(Values.begin(), Values.end(), ConstantIntSortPredicate); 4587 Values.erase(std::unique(Values.begin(), Values.end()), Values.end()); 4588 4589 // If Extra was used, we require at least two switch values to do the 4590 // transformation. A switch with one value is just a conditional branch. 4591 if (ExtraCase && Values.size() < 2) 4592 return false; 4593 4594 // TODO: Preserve branch weight metadata, similarly to how 4595 // FoldValueComparisonIntoPredecessors preserves it. 4596 4597 // Figure out which block is which destination. 4598 BasicBlock *DefaultBB = BI->getSuccessor(1); 4599 BasicBlock *EdgeBB = BI->getSuccessor(0); 4600 if (!TrueWhenEqual) 4601 std::swap(DefaultBB, EdgeBB); 4602 4603 BasicBlock *BB = BI->getParent(); 4604 4605 LLVM_DEBUG(dbgs() << "Converting 'icmp' chain with " << Values.size() 4606 << " cases into SWITCH. BB is:\n" 4607 << *BB); 4608 4609 SmallVector<DominatorTree::UpdateType, 2> Updates; 4610 4611 // If there are any extra values that couldn't be folded into the switch 4612 // then we evaluate them with an explicit branch first. Split the block 4613 // right before the condbr to handle it. 4614 if (ExtraCase) { 4615 BasicBlock *NewBB = SplitBlock(BB, BI, DTU, /*LI=*/nullptr, 4616 /*MSSAU=*/nullptr, "switch.early.test"); 4617 4618 // Remove the uncond branch added to the old block. 4619 Instruction *OldTI = BB->getTerminator(); 4620 Builder.SetInsertPoint(OldTI); 4621 4622 // There can be an unintended UB if extra values are Poison. Before the 4623 // transformation, extra values may not be evaluated according to the 4624 // condition, and it will not raise UB. But after transformation, we are 4625 // evaluating extra values before checking the condition, and it will raise 4626 // UB. It can be solved by adding freeze instruction to extra values. 4627 AssumptionCache *AC = Options.AC; 4628 4629 if (!isGuaranteedNotToBeUndefOrPoison(ExtraCase, AC, BI, nullptr)) 4630 ExtraCase = Builder.CreateFreeze(ExtraCase); 4631 4632 if (TrueWhenEqual) 4633 Builder.CreateCondBr(ExtraCase, EdgeBB, NewBB); 4634 else 4635 Builder.CreateCondBr(ExtraCase, NewBB, EdgeBB); 4636 4637 OldTI->eraseFromParent(); 4638 4639 if (DTU) 4640 Updates.push_back({DominatorTree::Insert, BB, EdgeBB}); 4641 4642 // If there are PHI nodes in EdgeBB, then we need to add a new entry to them 4643 // for the edge we just added. 4644 AddPredecessorToBlock(EdgeBB, BB, NewBB); 4645 4646 LLVM_DEBUG(dbgs() << " ** 'icmp' chain unhandled condition: " << *ExtraCase 4647 << "\nEXTRABB = " << *BB); 4648 BB = NewBB; 4649 } 4650 4651 Builder.SetInsertPoint(BI); 4652 // Convert pointer to int before we switch. 4653 if (CompVal->getType()->isPointerTy()) { 4654 CompVal = Builder.CreatePtrToInt( 4655 CompVal, DL.getIntPtrType(CompVal->getType()), "magicptr"); 4656 } 4657 4658 // Create the new switch instruction now. 4659 SwitchInst *New = Builder.CreateSwitch(CompVal, DefaultBB, Values.size()); 4660 4661 // Add all of the 'cases' to the switch instruction. 4662 for (unsigned i = 0, e = Values.size(); i != e; ++i) 4663 New->addCase(Values[i], EdgeBB); 4664 4665 // We added edges from PI to the EdgeBB. As such, if there were any 4666 // PHI nodes in EdgeBB, they need entries to be added corresponding to 4667 // the number of edges added. 4668 for (BasicBlock::iterator BBI = EdgeBB->begin(); isa<PHINode>(BBI); ++BBI) { 4669 PHINode *PN = cast<PHINode>(BBI); 4670 Value *InVal = PN->getIncomingValueForBlock(BB); 4671 for (unsigned i = 0, e = Values.size() - 1; i != e; ++i) 4672 PN->addIncoming(InVal, BB); 4673 } 4674 4675 // Erase the old branch instruction. 4676 EraseTerminatorAndDCECond(BI); 4677 if (DTU) 4678 DTU->applyUpdates(Updates); 4679 4680 LLVM_DEBUG(dbgs() << " ** 'icmp' chain result is:\n" << *BB << '\n'); 4681 return true; 4682 } 4683 4684 bool SimplifyCFGOpt::simplifyResume(ResumeInst *RI, IRBuilder<> &Builder) { 4685 if (isa<PHINode>(RI->getValue())) 4686 return simplifyCommonResume(RI); 4687 else if (isa<LandingPadInst>(RI->getParent()->getFirstNonPHI()) && 4688 RI->getValue() == RI->getParent()->getFirstNonPHI()) 4689 // The resume must unwind the exception that caused control to branch here. 4690 return simplifySingleResume(RI); 4691 4692 return false; 4693 } 4694 4695 // Check if cleanup block is empty 4696 static bool isCleanupBlockEmpty(iterator_range<BasicBlock::iterator> R) { 4697 for (Instruction &I : R) { 4698 auto *II = dyn_cast<IntrinsicInst>(&I); 4699 if (!II) 4700 return false; 4701 4702 Intrinsic::ID IntrinsicID = II->getIntrinsicID(); 4703 switch (IntrinsicID) { 4704 case Intrinsic::dbg_declare: 4705 case Intrinsic::dbg_value: 4706 case Intrinsic::dbg_label: 4707 case Intrinsic::lifetime_end: 4708 break; 4709 default: 4710 return false; 4711 } 4712 } 4713 return true; 4714 } 4715 4716 // Simplify resume that is shared by several landing pads (phi of landing pad). 4717 bool SimplifyCFGOpt::simplifyCommonResume(ResumeInst *RI) { 4718 BasicBlock *BB = RI->getParent(); 4719 4720 // Check that there are no other instructions except for debug and lifetime 4721 // intrinsics between the phi's and resume instruction. 4722 if (!isCleanupBlockEmpty( 4723 make_range(RI->getParent()->getFirstNonPHI(), BB->getTerminator()))) 4724 return false; 4725 4726 SmallSetVector<BasicBlock *, 4> TrivialUnwindBlocks; 4727 auto *PhiLPInst = cast<PHINode>(RI->getValue()); 4728 4729 // Check incoming blocks to see if any of them are trivial. 4730 for (unsigned Idx = 0, End = PhiLPInst->getNumIncomingValues(); Idx != End; 4731 Idx++) { 4732 auto *IncomingBB = PhiLPInst->getIncomingBlock(Idx); 4733 auto *IncomingValue = PhiLPInst->getIncomingValue(Idx); 4734 4735 // If the block has other successors, we can not delete it because 4736 // it has other dependents. 4737 if (IncomingBB->getUniqueSuccessor() != BB) 4738 continue; 4739 4740 auto *LandingPad = dyn_cast<LandingPadInst>(IncomingBB->getFirstNonPHI()); 4741 // Not the landing pad that caused the control to branch here. 4742 if (IncomingValue != LandingPad) 4743 continue; 4744 4745 if (isCleanupBlockEmpty( 4746 make_range(LandingPad->getNextNode(), IncomingBB->getTerminator()))) 4747 TrivialUnwindBlocks.insert(IncomingBB); 4748 } 4749 4750 // If no trivial unwind blocks, don't do any simplifications. 4751 if (TrivialUnwindBlocks.empty()) 4752 return false; 4753 4754 // Turn all invokes that unwind here into calls. 4755 for (auto *TrivialBB : TrivialUnwindBlocks) { 4756 // Blocks that will be simplified should be removed from the phi node. 4757 // Note there could be multiple edges to the resume block, and we need 4758 // to remove them all. 4759 while (PhiLPInst->getBasicBlockIndex(TrivialBB) != -1) 4760 BB->removePredecessor(TrivialBB, true); 4761 4762 for (BasicBlock *Pred : 4763 llvm::make_early_inc_range(predecessors(TrivialBB))) { 4764 removeUnwindEdge(Pred, DTU); 4765 ++NumInvokes; 4766 } 4767 4768 // In each SimplifyCFG run, only the current processed block can be erased. 4769 // Otherwise, it will break the iteration of SimplifyCFG pass. So instead 4770 // of erasing TrivialBB, we only remove the branch to the common resume 4771 // block so that we can later erase the resume block since it has no 4772 // predecessors. 4773 TrivialBB->getTerminator()->eraseFromParent(); 4774 new UnreachableInst(RI->getContext(), TrivialBB); 4775 if (DTU) 4776 DTU->applyUpdates({{DominatorTree::Delete, TrivialBB, BB}}); 4777 } 4778 4779 // Delete the resume block if all its predecessors have been removed. 4780 if (pred_empty(BB)) 4781 DeleteDeadBlock(BB, DTU); 4782 4783 return !TrivialUnwindBlocks.empty(); 4784 } 4785 4786 // Simplify resume that is only used by a single (non-phi) landing pad. 4787 bool SimplifyCFGOpt::simplifySingleResume(ResumeInst *RI) { 4788 BasicBlock *BB = RI->getParent(); 4789 auto *LPInst = cast<LandingPadInst>(BB->getFirstNonPHI()); 4790 assert(RI->getValue() == LPInst && 4791 "Resume must unwind the exception that caused control to here"); 4792 4793 // Check that there are no other instructions except for debug intrinsics. 4794 if (!isCleanupBlockEmpty( 4795 make_range<Instruction *>(LPInst->getNextNode(), RI))) 4796 return false; 4797 4798 // Turn all invokes that unwind here into calls and delete the basic block. 4799 for (BasicBlock *Pred : llvm::make_early_inc_range(predecessors(BB))) { 4800 removeUnwindEdge(Pred, DTU); 4801 ++NumInvokes; 4802 } 4803 4804 // The landingpad is now unreachable. Zap it. 4805 DeleteDeadBlock(BB, DTU); 4806 return true; 4807 } 4808 4809 static bool removeEmptyCleanup(CleanupReturnInst *RI, DomTreeUpdater *DTU) { 4810 // If this is a trivial cleanup pad that executes no instructions, it can be 4811 // eliminated. If the cleanup pad continues to the caller, any predecessor 4812 // that is an EH pad will be updated to continue to the caller and any 4813 // predecessor that terminates with an invoke instruction will have its invoke 4814 // instruction converted to a call instruction. If the cleanup pad being 4815 // simplified does not continue to the caller, each predecessor will be 4816 // updated to continue to the unwind destination of the cleanup pad being 4817 // simplified. 4818 BasicBlock *BB = RI->getParent(); 4819 CleanupPadInst *CPInst = RI->getCleanupPad(); 4820 if (CPInst->getParent() != BB) 4821 // This isn't an empty cleanup. 4822 return false; 4823 4824 // We cannot kill the pad if it has multiple uses. This typically arises 4825 // from unreachable basic blocks. 4826 if (!CPInst->hasOneUse()) 4827 return false; 4828 4829 // Check that there are no other instructions except for benign intrinsics. 4830 if (!isCleanupBlockEmpty( 4831 make_range<Instruction *>(CPInst->getNextNode(), RI))) 4832 return false; 4833 4834 // If the cleanup return we are simplifying unwinds to the caller, this will 4835 // set UnwindDest to nullptr. 4836 BasicBlock *UnwindDest = RI->getUnwindDest(); 4837 Instruction *DestEHPad = UnwindDest ? UnwindDest->getFirstNonPHI() : nullptr; 4838 4839 // We're about to remove BB from the control flow. Before we do, sink any 4840 // PHINodes into the unwind destination. Doing this before changing the 4841 // control flow avoids some potentially slow checks, since we can currently 4842 // be certain that UnwindDest and BB have no common predecessors (since they 4843 // are both EH pads). 4844 if (UnwindDest) { 4845 // First, go through the PHI nodes in UnwindDest and update any nodes that 4846 // reference the block we are removing 4847 for (PHINode &DestPN : UnwindDest->phis()) { 4848 int Idx = DestPN.getBasicBlockIndex(BB); 4849 // Since BB unwinds to UnwindDest, it has to be in the PHI node. 4850 assert(Idx != -1); 4851 // This PHI node has an incoming value that corresponds to a control 4852 // path through the cleanup pad we are removing. If the incoming 4853 // value is in the cleanup pad, it must be a PHINode (because we 4854 // verified above that the block is otherwise empty). Otherwise, the 4855 // value is either a constant or a value that dominates the cleanup 4856 // pad being removed. 4857 // 4858 // Because BB and UnwindDest are both EH pads, all of their 4859 // predecessors must unwind to these blocks, and since no instruction 4860 // can have multiple unwind destinations, there will be no overlap in 4861 // incoming blocks between SrcPN and DestPN. 4862 Value *SrcVal = DestPN.getIncomingValue(Idx); 4863 PHINode *SrcPN = dyn_cast<PHINode>(SrcVal); 4864 4865 bool NeedPHITranslation = SrcPN && SrcPN->getParent() == BB; 4866 for (auto *Pred : predecessors(BB)) { 4867 Value *Incoming = 4868 NeedPHITranslation ? SrcPN->getIncomingValueForBlock(Pred) : SrcVal; 4869 DestPN.addIncoming(Incoming, Pred); 4870 } 4871 } 4872 4873 // Sink any remaining PHI nodes directly into UnwindDest. 4874 Instruction *InsertPt = DestEHPad; 4875 for (PHINode &PN : make_early_inc_range(BB->phis())) { 4876 if (PN.use_empty() || !PN.isUsedOutsideOfBlock(BB)) 4877 // If the PHI node has no uses or all of its uses are in this basic 4878 // block (meaning they are debug or lifetime intrinsics), just leave 4879 // it. It will be erased when we erase BB below. 4880 continue; 4881 4882 // Otherwise, sink this PHI node into UnwindDest. 4883 // Any predecessors to UnwindDest which are not already represented 4884 // must be back edges which inherit the value from the path through 4885 // BB. In this case, the PHI value must reference itself. 4886 for (auto *pred : predecessors(UnwindDest)) 4887 if (pred != BB) 4888 PN.addIncoming(&PN, pred); 4889 PN.moveBefore(InsertPt); 4890 // Also, add a dummy incoming value for the original BB itself, 4891 // so that the PHI is well-formed until we drop said predecessor. 4892 PN.addIncoming(UndefValue::get(PN.getType()), BB); 4893 } 4894 } 4895 4896 std::vector<DominatorTree::UpdateType> Updates; 4897 4898 // We use make_early_inc_range here because we will remove all predecessors. 4899 for (BasicBlock *PredBB : llvm::make_early_inc_range(predecessors(BB))) { 4900 if (UnwindDest == nullptr) { 4901 if (DTU) { 4902 DTU->applyUpdates(Updates); 4903 Updates.clear(); 4904 } 4905 removeUnwindEdge(PredBB, DTU); 4906 ++NumInvokes; 4907 } else { 4908 BB->removePredecessor(PredBB); 4909 Instruction *TI = PredBB->getTerminator(); 4910 TI->replaceUsesOfWith(BB, UnwindDest); 4911 if (DTU) { 4912 Updates.push_back({DominatorTree::Insert, PredBB, UnwindDest}); 4913 Updates.push_back({DominatorTree::Delete, PredBB, BB}); 4914 } 4915 } 4916 } 4917 4918 if (DTU) 4919 DTU->applyUpdates(Updates); 4920 4921 DeleteDeadBlock(BB, DTU); 4922 4923 return true; 4924 } 4925 4926 // Try to merge two cleanuppads together. 4927 static bool mergeCleanupPad(CleanupReturnInst *RI) { 4928 // Skip any cleanuprets which unwind to caller, there is nothing to merge 4929 // with. 4930 BasicBlock *UnwindDest = RI->getUnwindDest(); 4931 if (!UnwindDest) 4932 return false; 4933 4934 // This cleanupret isn't the only predecessor of this cleanuppad, it wouldn't 4935 // be safe to merge without code duplication. 4936 if (UnwindDest->getSinglePredecessor() != RI->getParent()) 4937 return false; 4938 4939 // Verify that our cleanuppad's unwind destination is another cleanuppad. 4940 auto *SuccessorCleanupPad = dyn_cast<CleanupPadInst>(&UnwindDest->front()); 4941 if (!SuccessorCleanupPad) 4942 return false; 4943 4944 CleanupPadInst *PredecessorCleanupPad = RI->getCleanupPad(); 4945 // Replace any uses of the successor cleanupad with the predecessor pad 4946 // The only cleanuppad uses should be this cleanupret, it's cleanupret and 4947 // funclet bundle operands. 4948 SuccessorCleanupPad->replaceAllUsesWith(PredecessorCleanupPad); 4949 // Remove the old cleanuppad. 4950 SuccessorCleanupPad->eraseFromParent(); 4951 // Now, we simply replace the cleanupret with a branch to the unwind 4952 // destination. 4953 BranchInst::Create(UnwindDest, RI->getParent()); 4954 RI->eraseFromParent(); 4955 4956 return true; 4957 } 4958 4959 bool SimplifyCFGOpt::simplifyCleanupReturn(CleanupReturnInst *RI) { 4960 // It is possible to transiantly have an undef cleanuppad operand because we 4961 // have deleted some, but not all, dead blocks. 4962 // Eventually, this block will be deleted. 4963 if (isa<UndefValue>(RI->getOperand(0))) 4964 return false; 4965 4966 if (mergeCleanupPad(RI)) 4967 return true; 4968 4969 if (removeEmptyCleanup(RI, DTU)) 4970 return true; 4971 4972 return false; 4973 } 4974 4975 // WARNING: keep in sync with InstCombinerImpl::visitUnreachableInst()! 4976 bool SimplifyCFGOpt::simplifyUnreachable(UnreachableInst *UI) { 4977 BasicBlock *BB = UI->getParent(); 4978 4979 bool Changed = false; 4980 4981 // If there are any instructions immediately before the unreachable that can 4982 // be removed, do so. 4983 while (UI->getIterator() != BB->begin()) { 4984 BasicBlock::iterator BBI = UI->getIterator(); 4985 --BBI; 4986 4987 if (!isGuaranteedToTransferExecutionToSuccessor(&*BBI)) 4988 break; // Can not drop any more instructions. We're done here. 4989 // Otherwise, this instruction can be freely erased, 4990 // even if it is not side-effect free. 4991 4992 // Note that deleting EH's here is in fact okay, although it involves a bit 4993 // of subtle reasoning. If this inst is an EH, all the predecessors of this 4994 // block will be the unwind edges of Invoke/CatchSwitch/CleanupReturn, 4995 // and we can therefore guarantee this block will be erased. 4996 4997 // Delete this instruction (any uses are guaranteed to be dead) 4998 BBI->replaceAllUsesWith(PoisonValue::get(BBI->getType())); 4999 BBI->eraseFromParent(); 5000 Changed = true; 5001 } 5002 5003 // If the unreachable instruction is the first in the block, take a gander 5004 // at all of the predecessors of this instruction, and simplify them. 5005 if (&BB->front() != UI) 5006 return Changed; 5007 5008 std::vector<DominatorTree::UpdateType> Updates; 5009 5010 SmallSetVector<BasicBlock *, 8> Preds(pred_begin(BB), pred_end(BB)); 5011 for (unsigned i = 0, e = Preds.size(); i != e; ++i) { 5012 auto *Predecessor = Preds[i]; 5013 Instruction *TI = Predecessor->getTerminator(); 5014 IRBuilder<> Builder(TI); 5015 if (auto *BI = dyn_cast<BranchInst>(TI)) { 5016 // We could either have a proper unconditional branch, 5017 // or a degenerate conditional branch with matching destinations. 5018 if (all_of(BI->successors(), 5019 [BB](auto *Successor) { return Successor == BB; })) { 5020 new UnreachableInst(TI->getContext(), TI); 5021 TI->eraseFromParent(); 5022 Changed = true; 5023 } else { 5024 assert(BI->isConditional() && "Can't get here with an uncond branch."); 5025 Value* Cond = BI->getCondition(); 5026 assert(BI->getSuccessor(0) != BI->getSuccessor(1) && 5027 "The destinations are guaranteed to be different here."); 5028 if (BI->getSuccessor(0) == BB) { 5029 Builder.CreateAssumption(Builder.CreateNot(Cond)); 5030 Builder.CreateBr(BI->getSuccessor(1)); 5031 } else { 5032 assert(BI->getSuccessor(1) == BB && "Incorrect CFG"); 5033 Builder.CreateAssumption(Cond); 5034 Builder.CreateBr(BI->getSuccessor(0)); 5035 } 5036 EraseTerminatorAndDCECond(BI); 5037 Changed = true; 5038 } 5039 if (DTU) 5040 Updates.push_back({DominatorTree::Delete, Predecessor, BB}); 5041 } else if (auto *SI = dyn_cast<SwitchInst>(TI)) { 5042 SwitchInstProfUpdateWrapper SU(*SI); 5043 for (auto i = SU->case_begin(), e = SU->case_end(); i != e;) { 5044 if (i->getCaseSuccessor() != BB) { 5045 ++i; 5046 continue; 5047 } 5048 BB->removePredecessor(SU->getParent()); 5049 i = SU.removeCase(i); 5050 e = SU->case_end(); 5051 Changed = true; 5052 } 5053 // Note that the default destination can't be removed! 5054 if (DTU && SI->getDefaultDest() != BB) 5055 Updates.push_back({DominatorTree::Delete, Predecessor, BB}); 5056 } else if (auto *II = dyn_cast<InvokeInst>(TI)) { 5057 if (II->getUnwindDest() == BB) { 5058 if (DTU) { 5059 DTU->applyUpdates(Updates); 5060 Updates.clear(); 5061 } 5062 removeUnwindEdge(TI->getParent(), DTU); 5063 Changed = true; 5064 } 5065 } else if (auto *CSI = dyn_cast<CatchSwitchInst>(TI)) { 5066 if (CSI->getUnwindDest() == BB) { 5067 if (DTU) { 5068 DTU->applyUpdates(Updates); 5069 Updates.clear(); 5070 } 5071 removeUnwindEdge(TI->getParent(), DTU); 5072 Changed = true; 5073 continue; 5074 } 5075 5076 for (CatchSwitchInst::handler_iterator I = CSI->handler_begin(), 5077 E = CSI->handler_end(); 5078 I != E; ++I) { 5079 if (*I == BB) { 5080 CSI->removeHandler(I); 5081 --I; 5082 --E; 5083 Changed = true; 5084 } 5085 } 5086 if (DTU) 5087 Updates.push_back({DominatorTree::Delete, Predecessor, BB}); 5088 if (CSI->getNumHandlers() == 0) { 5089 if (CSI->hasUnwindDest()) { 5090 // Redirect all predecessors of the block containing CatchSwitchInst 5091 // to instead branch to the CatchSwitchInst's unwind destination. 5092 if (DTU) { 5093 for (auto *PredecessorOfPredecessor : predecessors(Predecessor)) { 5094 Updates.push_back({DominatorTree::Insert, 5095 PredecessorOfPredecessor, 5096 CSI->getUnwindDest()}); 5097 Updates.push_back({DominatorTree::Delete, 5098 PredecessorOfPredecessor, Predecessor}); 5099 } 5100 } 5101 Predecessor->replaceAllUsesWith(CSI->getUnwindDest()); 5102 } else { 5103 // Rewrite all preds to unwind to caller (or from invoke to call). 5104 if (DTU) { 5105 DTU->applyUpdates(Updates); 5106 Updates.clear(); 5107 } 5108 SmallVector<BasicBlock *, 8> EHPreds(predecessors(Predecessor)); 5109 for (BasicBlock *EHPred : EHPreds) 5110 removeUnwindEdge(EHPred, DTU); 5111 } 5112 // The catchswitch is no longer reachable. 5113 new UnreachableInst(CSI->getContext(), CSI); 5114 CSI->eraseFromParent(); 5115 Changed = true; 5116 } 5117 } else if (auto *CRI = dyn_cast<CleanupReturnInst>(TI)) { 5118 (void)CRI; 5119 assert(CRI->hasUnwindDest() && CRI->getUnwindDest() == BB && 5120 "Expected to always have an unwind to BB."); 5121 if (DTU) 5122 Updates.push_back({DominatorTree::Delete, Predecessor, BB}); 5123 new UnreachableInst(TI->getContext(), TI); 5124 TI->eraseFromParent(); 5125 Changed = true; 5126 } 5127 } 5128 5129 if (DTU) 5130 DTU->applyUpdates(Updates); 5131 5132 // If this block is now dead, remove it. 5133 if (pred_empty(BB) && BB != &BB->getParent()->getEntryBlock()) { 5134 DeleteDeadBlock(BB, DTU); 5135 return true; 5136 } 5137 5138 return Changed; 5139 } 5140 5141 static bool CasesAreContiguous(SmallVectorImpl<ConstantInt *> &Cases) { 5142 assert(Cases.size() >= 1); 5143 5144 array_pod_sort(Cases.begin(), Cases.end(), ConstantIntSortPredicate); 5145 for (size_t I = 1, E = Cases.size(); I != E; ++I) { 5146 if (Cases[I - 1]->getValue() != Cases[I]->getValue() + 1) 5147 return false; 5148 } 5149 return true; 5150 } 5151 5152 static void createUnreachableSwitchDefault(SwitchInst *Switch, 5153 DomTreeUpdater *DTU) { 5154 LLVM_DEBUG(dbgs() << "SimplifyCFG: switch default is dead.\n"); 5155 auto *BB = Switch->getParent(); 5156 auto *OrigDefaultBlock = Switch->getDefaultDest(); 5157 OrigDefaultBlock->removePredecessor(BB); 5158 BasicBlock *NewDefaultBlock = BasicBlock::Create( 5159 BB->getContext(), BB->getName() + ".unreachabledefault", BB->getParent(), 5160 OrigDefaultBlock); 5161 new UnreachableInst(Switch->getContext(), NewDefaultBlock); 5162 Switch->setDefaultDest(&*NewDefaultBlock); 5163 if (DTU) { 5164 SmallVector<DominatorTree::UpdateType, 2> Updates; 5165 Updates.push_back({DominatorTree::Insert, BB, &*NewDefaultBlock}); 5166 if (!is_contained(successors(BB), OrigDefaultBlock)) 5167 Updates.push_back({DominatorTree::Delete, BB, &*OrigDefaultBlock}); 5168 DTU->applyUpdates(Updates); 5169 } 5170 } 5171 5172 /// Turn a switch into an integer range comparison and branch. 5173 /// Switches with more than 2 destinations are ignored. 5174 /// Switches with 1 destination are also ignored. 5175 bool SimplifyCFGOpt::TurnSwitchRangeIntoICmp(SwitchInst *SI, 5176 IRBuilder<> &Builder) { 5177 assert(SI->getNumCases() > 1 && "Degenerate switch?"); 5178 5179 bool HasDefault = 5180 !isa<UnreachableInst>(SI->getDefaultDest()->getFirstNonPHIOrDbg()); 5181 5182 auto *BB = SI->getParent(); 5183 5184 // Partition the cases into two sets with different destinations. 5185 BasicBlock *DestA = HasDefault ? SI->getDefaultDest() : nullptr; 5186 BasicBlock *DestB = nullptr; 5187 SmallVector<ConstantInt *, 16> CasesA; 5188 SmallVector<ConstantInt *, 16> CasesB; 5189 5190 for (auto Case : SI->cases()) { 5191 BasicBlock *Dest = Case.getCaseSuccessor(); 5192 if (!DestA) 5193 DestA = Dest; 5194 if (Dest == DestA) { 5195 CasesA.push_back(Case.getCaseValue()); 5196 continue; 5197 } 5198 if (!DestB) 5199 DestB = Dest; 5200 if (Dest == DestB) { 5201 CasesB.push_back(Case.getCaseValue()); 5202 continue; 5203 } 5204 return false; // More than two destinations. 5205 } 5206 if (!DestB) 5207 return false; // All destinations are the same and the default is unreachable 5208 5209 assert(DestA && DestB && 5210 "Single-destination switch should have been folded."); 5211 assert(DestA != DestB); 5212 assert(DestB != SI->getDefaultDest()); 5213 assert(!CasesB.empty() && "There must be non-default cases."); 5214 assert(!CasesA.empty() || HasDefault); 5215 5216 // Figure out if one of the sets of cases form a contiguous range. 5217 SmallVectorImpl<ConstantInt *> *ContiguousCases = nullptr; 5218 BasicBlock *ContiguousDest = nullptr; 5219 BasicBlock *OtherDest = nullptr; 5220 if (!CasesA.empty() && CasesAreContiguous(CasesA)) { 5221 ContiguousCases = &CasesA; 5222 ContiguousDest = DestA; 5223 OtherDest = DestB; 5224 } else if (CasesAreContiguous(CasesB)) { 5225 ContiguousCases = &CasesB; 5226 ContiguousDest = DestB; 5227 OtherDest = DestA; 5228 } else 5229 return false; 5230 5231 // Start building the compare and branch. 5232 5233 Constant *Offset = ConstantExpr::getNeg(ContiguousCases->back()); 5234 Constant *NumCases = 5235 ConstantInt::get(Offset->getType(), ContiguousCases->size()); 5236 5237 Value *Sub = SI->getCondition(); 5238 if (!Offset->isNullValue()) 5239 Sub = Builder.CreateAdd(Sub, Offset, Sub->getName() + ".off"); 5240 5241 Value *Cmp; 5242 // If NumCases overflowed, then all possible values jump to the successor. 5243 if (NumCases->isNullValue() && !ContiguousCases->empty()) 5244 Cmp = ConstantInt::getTrue(SI->getContext()); 5245 else 5246 Cmp = Builder.CreateICmpULT(Sub, NumCases, "switch"); 5247 BranchInst *NewBI = Builder.CreateCondBr(Cmp, ContiguousDest, OtherDest); 5248 5249 // Update weight for the newly-created conditional branch. 5250 if (HasBranchWeights(SI)) { 5251 SmallVector<uint64_t, 8> Weights; 5252 GetBranchWeights(SI, Weights); 5253 if (Weights.size() == 1 + SI->getNumCases()) { 5254 uint64_t TrueWeight = 0; 5255 uint64_t FalseWeight = 0; 5256 for (size_t I = 0, E = Weights.size(); I != E; ++I) { 5257 if (SI->getSuccessor(I) == ContiguousDest) 5258 TrueWeight += Weights[I]; 5259 else 5260 FalseWeight += Weights[I]; 5261 } 5262 while (TrueWeight > UINT32_MAX || FalseWeight > UINT32_MAX) { 5263 TrueWeight /= 2; 5264 FalseWeight /= 2; 5265 } 5266 setBranchWeights(NewBI, TrueWeight, FalseWeight); 5267 } 5268 } 5269 5270 // Prune obsolete incoming values off the successors' PHI nodes. 5271 for (auto BBI = ContiguousDest->begin(); isa<PHINode>(BBI); ++BBI) { 5272 unsigned PreviousEdges = ContiguousCases->size(); 5273 if (ContiguousDest == SI->getDefaultDest()) 5274 ++PreviousEdges; 5275 for (unsigned I = 0, E = PreviousEdges - 1; I != E; ++I) 5276 cast<PHINode>(BBI)->removeIncomingValue(SI->getParent()); 5277 } 5278 for (auto BBI = OtherDest->begin(); isa<PHINode>(BBI); ++BBI) { 5279 unsigned PreviousEdges = SI->getNumCases() - ContiguousCases->size(); 5280 if (OtherDest == SI->getDefaultDest()) 5281 ++PreviousEdges; 5282 for (unsigned I = 0, E = PreviousEdges - 1; I != E; ++I) 5283 cast<PHINode>(BBI)->removeIncomingValue(SI->getParent()); 5284 } 5285 5286 // Clean up the default block - it may have phis or other instructions before 5287 // the unreachable terminator. 5288 if (!HasDefault) 5289 createUnreachableSwitchDefault(SI, DTU); 5290 5291 auto *UnreachableDefault = SI->getDefaultDest(); 5292 5293 // Drop the switch. 5294 SI->eraseFromParent(); 5295 5296 if (!HasDefault && DTU) 5297 DTU->applyUpdates({{DominatorTree::Delete, BB, UnreachableDefault}}); 5298 5299 return true; 5300 } 5301 5302 /// Compute masked bits for the condition of a switch 5303 /// and use it to remove dead cases. 5304 static bool eliminateDeadSwitchCases(SwitchInst *SI, DomTreeUpdater *DTU, 5305 AssumptionCache *AC, 5306 const DataLayout &DL) { 5307 Value *Cond = SI->getCondition(); 5308 KnownBits Known = computeKnownBits(Cond, DL, 0, AC, SI); 5309 5310 // We can also eliminate cases by determining that their values are outside of 5311 // the limited range of the condition based on how many significant (non-sign) 5312 // bits are in the condition value. 5313 unsigned MaxSignificantBitsInCond = 5314 ComputeMaxSignificantBits(Cond, DL, 0, AC, SI); 5315 5316 // Gather dead cases. 5317 SmallVector<ConstantInt *, 8> DeadCases; 5318 SmallDenseMap<BasicBlock *, int, 8> NumPerSuccessorCases; 5319 SmallVector<BasicBlock *, 8> UniqueSuccessors; 5320 for (auto &Case : SI->cases()) { 5321 auto *Successor = Case.getCaseSuccessor(); 5322 if (DTU) { 5323 if (!NumPerSuccessorCases.count(Successor)) 5324 UniqueSuccessors.push_back(Successor); 5325 ++NumPerSuccessorCases[Successor]; 5326 } 5327 const APInt &CaseVal = Case.getCaseValue()->getValue(); 5328 if (Known.Zero.intersects(CaseVal) || !Known.One.isSubsetOf(CaseVal) || 5329 (CaseVal.getMinSignedBits() > MaxSignificantBitsInCond)) { 5330 DeadCases.push_back(Case.getCaseValue()); 5331 if (DTU) 5332 --NumPerSuccessorCases[Successor]; 5333 LLVM_DEBUG(dbgs() << "SimplifyCFG: switch case " << CaseVal 5334 << " is dead.\n"); 5335 } 5336 } 5337 5338 // If we can prove that the cases must cover all possible values, the 5339 // default destination becomes dead and we can remove it. If we know some 5340 // of the bits in the value, we can use that to more precisely compute the 5341 // number of possible unique case values. 5342 bool HasDefault = 5343 !isa<UnreachableInst>(SI->getDefaultDest()->getFirstNonPHIOrDbg()); 5344 const unsigned NumUnknownBits = 5345 Known.getBitWidth() - (Known.Zero | Known.One).countPopulation(); 5346 assert(NumUnknownBits <= Known.getBitWidth()); 5347 if (HasDefault && DeadCases.empty() && 5348 NumUnknownBits < 64 /* avoid overflow */ && 5349 SI->getNumCases() == (1ULL << NumUnknownBits)) { 5350 createUnreachableSwitchDefault(SI, DTU); 5351 return true; 5352 } 5353 5354 if (DeadCases.empty()) 5355 return false; 5356 5357 SwitchInstProfUpdateWrapper SIW(*SI); 5358 for (ConstantInt *DeadCase : DeadCases) { 5359 SwitchInst::CaseIt CaseI = SI->findCaseValue(DeadCase); 5360 assert(CaseI != SI->case_default() && 5361 "Case was not found. Probably mistake in DeadCases forming."); 5362 // Prune unused values from PHI nodes. 5363 CaseI->getCaseSuccessor()->removePredecessor(SI->getParent()); 5364 SIW.removeCase(CaseI); 5365 } 5366 5367 if (DTU) { 5368 std::vector<DominatorTree::UpdateType> Updates; 5369 for (auto *Successor : UniqueSuccessors) 5370 if (NumPerSuccessorCases[Successor] == 0) 5371 Updates.push_back({DominatorTree::Delete, SI->getParent(), Successor}); 5372 DTU->applyUpdates(Updates); 5373 } 5374 5375 return true; 5376 } 5377 5378 /// If BB would be eligible for simplification by 5379 /// TryToSimplifyUncondBranchFromEmptyBlock (i.e. it is empty and terminated 5380 /// by an unconditional branch), look at the phi node for BB in the successor 5381 /// block and see if the incoming value is equal to CaseValue. If so, return 5382 /// the phi node, and set PhiIndex to BB's index in the phi node. 5383 static PHINode *FindPHIForConditionForwarding(ConstantInt *CaseValue, 5384 BasicBlock *BB, int *PhiIndex) { 5385 if (BB->getFirstNonPHIOrDbg() != BB->getTerminator()) 5386 return nullptr; // BB must be empty to be a candidate for simplification. 5387 if (!BB->getSinglePredecessor()) 5388 return nullptr; // BB must be dominated by the switch. 5389 5390 BranchInst *Branch = dyn_cast<BranchInst>(BB->getTerminator()); 5391 if (!Branch || !Branch->isUnconditional()) 5392 return nullptr; // Terminator must be unconditional branch. 5393 5394 BasicBlock *Succ = Branch->getSuccessor(0); 5395 5396 for (PHINode &PHI : Succ->phis()) { 5397 int Idx = PHI.getBasicBlockIndex(BB); 5398 assert(Idx >= 0 && "PHI has no entry for predecessor?"); 5399 5400 Value *InValue = PHI.getIncomingValue(Idx); 5401 if (InValue != CaseValue) 5402 continue; 5403 5404 *PhiIndex = Idx; 5405 return &PHI; 5406 } 5407 5408 return nullptr; 5409 } 5410 5411 /// Try to forward the condition of a switch instruction to a phi node 5412 /// dominated by the switch, if that would mean that some of the destination 5413 /// blocks of the switch can be folded away. Return true if a change is made. 5414 static bool ForwardSwitchConditionToPHI(SwitchInst *SI) { 5415 using ForwardingNodesMap = DenseMap<PHINode *, SmallVector<int, 4>>; 5416 5417 ForwardingNodesMap ForwardingNodes; 5418 BasicBlock *SwitchBlock = SI->getParent(); 5419 bool Changed = false; 5420 for (auto &Case : SI->cases()) { 5421 ConstantInt *CaseValue = Case.getCaseValue(); 5422 BasicBlock *CaseDest = Case.getCaseSuccessor(); 5423 5424 // Replace phi operands in successor blocks that are using the constant case 5425 // value rather than the switch condition variable: 5426 // switchbb: 5427 // switch i32 %x, label %default [ 5428 // i32 17, label %succ 5429 // ... 5430 // succ: 5431 // %r = phi i32 ... [ 17, %switchbb ] ... 5432 // --> 5433 // %r = phi i32 ... [ %x, %switchbb ] ... 5434 5435 for (PHINode &Phi : CaseDest->phis()) { 5436 // This only works if there is exactly 1 incoming edge from the switch to 5437 // a phi. If there is >1, that means multiple cases of the switch map to 1 5438 // value in the phi, and that phi value is not the switch condition. Thus, 5439 // this transform would not make sense (the phi would be invalid because 5440 // a phi can't have different incoming values from the same block). 5441 int SwitchBBIdx = Phi.getBasicBlockIndex(SwitchBlock); 5442 if (Phi.getIncomingValue(SwitchBBIdx) == CaseValue && 5443 count(Phi.blocks(), SwitchBlock) == 1) { 5444 Phi.setIncomingValue(SwitchBBIdx, SI->getCondition()); 5445 Changed = true; 5446 } 5447 } 5448 5449 // Collect phi nodes that are indirectly using this switch's case constants. 5450 int PhiIdx; 5451 if (auto *Phi = FindPHIForConditionForwarding(CaseValue, CaseDest, &PhiIdx)) 5452 ForwardingNodes[Phi].push_back(PhiIdx); 5453 } 5454 5455 for (auto &ForwardingNode : ForwardingNodes) { 5456 PHINode *Phi = ForwardingNode.first; 5457 SmallVectorImpl<int> &Indexes = ForwardingNode.second; 5458 if (Indexes.size() < 2) 5459 continue; 5460 5461 for (int Index : Indexes) 5462 Phi->setIncomingValue(Index, SI->getCondition()); 5463 Changed = true; 5464 } 5465 5466 return Changed; 5467 } 5468 5469 /// Return true if the backend will be able to handle 5470 /// initializing an array of constants like C. 5471 static bool ValidLookupTableConstant(Constant *C, const TargetTransformInfo &TTI) { 5472 if (C->isThreadDependent()) 5473 return false; 5474 if (C->isDLLImportDependent()) 5475 return false; 5476 5477 if (!isa<ConstantFP>(C) && !isa<ConstantInt>(C) && 5478 !isa<ConstantPointerNull>(C) && !isa<GlobalValue>(C) && 5479 !isa<UndefValue>(C) && !isa<ConstantExpr>(C)) 5480 return false; 5481 5482 if (ConstantExpr *CE = dyn_cast<ConstantExpr>(C)) { 5483 // Pointer casts and in-bounds GEPs will not prohibit the backend from 5484 // materializing the array of constants. 5485 Constant *StrippedC = cast<Constant>(CE->stripInBoundsConstantOffsets()); 5486 if (StrippedC == C || !ValidLookupTableConstant(StrippedC, TTI)) 5487 return false; 5488 } 5489 5490 if (!TTI.shouldBuildLookupTablesForConstant(C)) 5491 return false; 5492 5493 return true; 5494 } 5495 5496 /// If V is a Constant, return it. Otherwise, try to look up 5497 /// its constant value in ConstantPool, returning 0 if it's not there. 5498 static Constant * 5499 LookupConstant(Value *V, 5500 const SmallDenseMap<Value *, Constant *> &ConstantPool) { 5501 if (Constant *C = dyn_cast<Constant>(V)) 5502 return C; 5503 return ConstantPool.lookup(V); 5504 } 5505 5506 /// Try to fold instruction I into a constant. This works for 5507 /// simple instructions such as binary operations where both operands are 5508 /// constant or can be replaced by constants from the ConstantPool. Returns the 5509 /// resulting constant on success, 0 otherwise. 5510 static Constant * 5511 ConstantFold(Instruction *I, const DataLayout &DL, 5512 const SmallDenseMap<Value *, Constant *> &ConstantPool) { 5513 if (SelectInst *Select = dyn_cast<SelectInst>(I)) { 5514 Constant *A = LookupConstant(Select->getCondition(), ConstantPool); 5515 if (!A) 5516 return nullptr; 5517 if (A->isAllOnesValue()) 5518 return LookupConstant(Select->getTrueValue(), ConstantPool); 5519 if (A->isNullValue()) 5520 return LookupConstant(Select->getFalseValue(), ConstantPool); 5521 return nullptr; 5522 } 5523 5524 SmallVector<Constant *, 4> COps; 5525 for (unsigned N = 0, E = I->getNumOperands(); N != E; ++N) { 5526 if (Constant *A = LookupConstant(I->getOperand(N), ConstantPool)) 5527 COps.push_back(A); 5528 else 5529 return nullptr; 5530 } 5531 5532 return ConstantFoldInstOperands(I, COps, DL); 5533 } 5534 5535 /// Try to determine the resulting constant values in phi nodes 5536 /// at the common destination basic block, *CommonDest, for one of the case 5537 /// destionations CaseDest corresponding to value CaseVal (0 for the default 5538 /// case), of a switch instruction SI. 5539 static bool 5540 getCaseResults(SwitchInst *SI, ConstantInt *CaseVal, BasicBlock *CaseDest, 5541 BasicBlock **CommonDest, 5542 SmallVectorImpl<std::pair<PHINode *, Constant *>> &Res, 5543 const DataLayout &DL, const TargetTransformInfo &TTI) { 5544 // The block from which we enter the common destination. 5545 BasicBlock *Pred = SI->getParent(); 5546 5547 // If CaseDest is empty except for some side-effect free instructions through 5548 // which we can constant-propagate the CaseVal, continue to its successor. 5549 SmallDenseMap<Value *, Constant *> ConstantPool; 5550 ConstantPool.insert(std::make_pair(SI->getCondition(), CaseVal)); 5551 for (Instruction &I : CaseDest->instructionsWithoutDebug(false)) { 5552 if (I.isTerminator()) { 5553 // If the terminator is a simple branch, continue to the next block. 5554 if (I.getNumSuccessors() != 1 || I.isExceptionalTerminator()) 5555 return false; 5556 Pred = CaseDest; 5557 CaseDest = I.getSuccessor(0); 5558 } else if (Constant *C = ConstantFold(&I, DL, ConstantPool)) { 5559 // Instruction is side-effect free and constant. 5560 5561 // If the instruction has uses outside this block or a phi node slot for 5562 // the block, it is not safe to bypass the instruction since it would then 5563 // no longer dominate all its uses. 5564 for (auto &Use : I.uses()) { 5565 User *User = Use.getUser(); 5566 if (Instruction *I = dyn_cast<Instruction>(User)) 5567 if (I->getParent() == CaseDest) 5568 continue; 5569 if (PHINode *Phi = dyn_cast<PHINode>(User)) 5570 if (Phi->getIncomingBlock(Use) == CaseDest) 5571 continue; 5572 return false; 5573 } 5574 5575 ConstantPool.insert(std::make_pair(&I, C)); 5576 } else { 5577 break; 5578 } 5579 } 5580 5581 // If we did not have a CommonDest before, use the current one. 5582 if (!*CommonDest) 5583 *CommonDest = CaseDest; 5584 // If the destination isn't the common one, abort. 5585 if (CaseDest != *CommonDest) 5586 return false; 5587 5588 // Get the values for this case from phi nodes in the destination block. 5589 for (PHINode &PHI : (*CommonDest)->phis()) { 5590 int Idx = PHI.getBasicBlockIndex(Pred); 5591 if (Idx == -1) 5592 continue; 5593 5594 Constant *ConstVal = 5595 LookupConstant(PHI.getIncomingValue(Idx), ConstantPool); 5596 if (!ConstVal) 5597 return false; 5598 5599 // Be conservative about which kinds of constants we support. 5600 if (!ValidLookupTableConstant(ConstVal, TTI)) 5601 return false; 5602 5603 Res.push_back(std::make_pair(&PHI, ConstVal)); 5604 } 5605 5606 return Res.size() > 0; 5607 } 5608 5609 // Helper function used to add CaseVal to the list of cases that generate 5610 // Result. Returns the updated number of cases that generate this result. 5611 static size_t mapCaseToResult(ConstantInt *CaseVal, 5612 SwitchCaseResultVectorTy &UniqueResults, 5613 Constant *Result) { 5614 for (auto &I : UniqueResults) { 5615 if (I.first == Result) { 5616 I.second.push_back(CaseVal); 5617 return I.second.size(); 5618 } 5619 } 5620 UniqueResults.push_back( 5621 std::make_pair(Result, SmallVector<ConstantInt *, 4>(1, CaseVal))); 5622 return 1; 5623 } 5624 5625 // Helper function that initializes a map containing 5626 // results for the PHI node of the common destination block for a switch 5627 // instruction. Returns false if multiple PHI nodes have been found or if 5628 // there is not a common destination block for the switch. 5629 static bool initializeUniqueCases(SwitchInst *SI, PHINode *&PHI, 5630 BasicBlock *&CommonDest, 5631 SwitchCaseResultVectorTy &UniqueResults, 5632 Constant *&DefaultResult, 5633 const DataLayout &DL, 5634 const TargetTransformInfo &TTI, 5635 uintptr_t MaxUniqueResults) { 5636 for (auto &I : SI->cases()) { 5637 ConstantInt *CaseVal = I.getCaseValue(); 5638 5639 // Resulting value at phi nodes for this case value. 5640 SwitchCaseResultsTy Results; 5641 if (!getCaseResults(SI, CaseVal, I.getCaseSuccessor(), &CommonDest, Results, 5642 DL, TTI)) 5643 return false; 5644 5645 // Only one value per case is permitted. 5646 if (Results.size() > 1) 5647 return false; 5648 5649 // Add the case->result mapping to UniqueResults. 5650 const size_t NumCasesForResult = 5651 mapCaseToResult(CaseVal, UniqueResults, Results.begin()->second); 5652 5653 // Early out if there are too many cases for this result. 5654 if (NumCasesForResult > MaxSwitchCasesPerResult) 5655 return false; 5656 5657 // Early out if there are too many unique results. 5658 if (UniqueResults.size() > MaxUniqueResults) 5659 return false; 5660 5661 // Check the PHI consistency. 5662 if (!PHI) 5663 PHI = Results[0].first; 5664 else if (PHI != Results[0].first) 5665 return false; 5666 } 5667 // Find the default result value. 5668 SmallVector<std::pair<PHINode *, Constant *>, 1> DefaultResults; 5669 BasicBlock *DefaultDest = SI->getDefaultDest(); 5670 getCaseResults(SI, nullptr, SI->getDefaultDest(), &CommonDest, DefaultResults, 5671 DL, TTI); 5672 // If the default value is not found abort unless the default destination 5673 // is unreachable. 5674 DefaultResult = 5675 DefaultResults.size() == 1 ? DefaultResults.begin()->second : nullptr; 5676 if ((!DefaultResult && 5677 !isa<UnreachableInst>(DefaultDest->getFirstNonPHIOrDbg()))) 5678 return false; 5679 5680 return true; 5681 } 5682 5683 // Helper function that checks if it is possible to transform a switch with only 5684 // two cases (or two cases + default) that produces a result into a select. 5685 // TODO: Handle switches with more than 2 cases that map to the same result. 5686 static Value *foldSwitchToSelect(const SwitchCaseResultVectorTy &ResultVector, 5687 Constant *DefaultResult, Value *Condition, 5688 IRBuilder<> &Builder) { 5689 // If we are selecting between only two cases transform into a simple 5690 // select or a two-way select if default is possible. 5691 // Example: 5692 // switch (a) { %0 = icmp eq i32 %a, 10 5693 // case 10: return 42; %1 = select i1 %0, i32 42, i32 4 5694 // case 20: return 2; ----> %2 = icmp eq i32 %a, 20 5695 // default: return 4; %3 = select i1 %2, i32 2, i32 %1 5696 // } 5697 if (ResultVector.size() == 2 && ResultVector[0].second.size() == 1 && 5698 ResultVector[1].second.size() == 1) { 5699 ConstantInt *FirstCase = ResultVector[0].second[0]; 5700 ConstantInt *SecondCase = ResultVector[1].second[0]; 5701 Value *SelectValue = ResultVector[1].first; 5702 if (DefaultResult) { 5703 Value *ValueCompare = 5704 Builder.CreateICmpEQ(Condition, SecondCase, "switch.selectcmp"); 5705 SelectValue = Builder.CreateSelect(ValueCompare, ResultVector[1].first, 5706 DefaultResult, "switch.select"); 5707 } 5708 Value *ValueCompare = 5709 Builder.CreateICmpEQ(Condition, FirstCase, "switch.selectcmp"); 5710 return Builder.CreateSelect(ValueCompare, ResultVector[0].first, 5711 SelectValue, "switch.select"); 5712 } 5713 5714 // Handle the degenerate case where two cases have the same result value. 5715 if (ResultVector.size() == 1 && DefaultResult) { 5716 ArrayRef<ConstantInt *> CaseValues = ResultVector[0].second; 5717 unsigned CaseCount = CaseValues.size(); 5718 // n bits group cases map to the same result: 5719 // case 0,4 -> Cond & 0b1..1011 == 0 ? result : default 5720 // case 0,2,4,6 -> Cond & 0b1..1001 == 0 ? result : default 5721 // case 0,2,8,10 -> Cond & 0b1..0101 == 0 ? result : default 5722 if (isPowerOf2_32(CaseCount)) { 5723 ConstantInt *MinCaseVal = CaseValues[0]; 5724 // Find mininal value. 5725 for (auto Case : CaseValues) 5726 if (Case->getValue().slt(MinCaseVal->getValue())) 5727 MinCaseVal = Case; 5728 5729 // Mark the bits case number touched. 5730 APInt BitMask = APInt::getZero(MinCaseVal->getBitWidth()); 5731 for (auto Case : CaseValues) 5732 BitMask |= (Case->getValue() - MinCaseVal->getValue()); 5733 5734 // Check if cases with the same result can cover all number 5735 // in touched bits. 5736 if (BitMask.countPopulation() == Log2_32(CaseCount)) { 5737 if (!MinCaseVal->isNullValue()) 5738 Condition = Builder.CreateSub(Condition, MinCaseVal); 5739 Value *And = Builder.CreateAnd(Condition, ~BitMask, "switch.and"); 5740 Value *Cmp = Builder.CreateICmpEQ( 5741 And, Constant::getNullValue(And->getType()), "switch.selectcmp"); 5742 return Builder.CreateSelect(Cmp, ResultVector[0].first, DefaultResult); 5743 } 5744 } 5745 5746 // Handle the degenerate case where two cases have the same value. 5747 if (CaseValues.size() == 2) { 5748 Value *Cmp1 = Builder.CreateICmpEQ(Condition, CaseValues[0], 5749 "switch.selectcmp.case1"); 5750 Value *Cmp2 = Builder.CreateICmpEQ(Condition, CaseValues[1], 5751 "switch.selectcmp.case2"); 5752 Value *Cmp = Builder.CreateOr(Cmp1, Cmp2, "switch.selectcmp"); 5753 return Builder.CreateSelect(Cmp, ResultVector[0].first, DefaultResult); 5754 } 5755 } 5756 5757 return nullptr; 5758 } 5759 5760 // Helper function to cleanup a switch instruction that has been converted into 5761 // a select, fixing up PHI nodes and basic blocks. 5762 static void removeSwitchAfterSelectFold(SwitchInst *SI, PHINode *PHI, 5763 Value *SelectValue, 5764 IRBuilder<> &Builder, 5765 DomTreeUpdater *DTU) { 5766 std::vector<DominatorTree::UpdateType> Updates; 5767 5768 BasicBlock *SelectBB = SI->getParent(); 5769 BasicBlock *DestBB = PHI->getParent(); 5770 5771 if (DTU && !is_contained(predecessors(DestBB), SelectBB)) 5772 Updates.push_back({DominatorTree::Insert, SelectBB, DestBB}); 5773 Builder.CreateBr(DestBB); 5774 5775 // Remove the switch. 5776 5777 while (PHI->getBasicBlockIndex(SelectBB) >= 0) 5778 PHI->removeIncomingValue(SelectBB); 5779 PHI->addIncoming(SelectValue, SelectBB); 5780 5781 SmallPtrSet<BasicBlock *, 4> RemovedSuccessors; 5782 for (unsigned i = 0, e = SI->getNumSuccessors(); i < e; ++i) { 5783 BasicBlock *Succ = SI->getSuccessor(i); 5784 5785 if (Succ == DestBB) 5786 continue; 5787 Succ->removePredecessor(SelectBB); 5788 if (DTU && RemovedSuccessors.insert(Succ).second) 5789 Updates.push_back({DominatorTree::Delete, SelectBB, Succ}); 5790 } 5791 SI->eraseFromParent(); 5792 if (DTU) 5793 DTU->applyUpdates(Updates); 5794 } 5795 5796 /// If a switch is only used to initialize one or more phi nodes in a common 5797 /// successor block with only two different constant values, try to replace the 5798 /// switch with a select. Returns true if the fold was made. 5799 static bool trySwitchToSelect(SwitchInst *SI, IRBuilder<> &Builder, 5800 DomTreeUpdater *DTU, const DataLayout &DL, 5801 const TargetTransformInfo &TTI) { 5802 Value *const Cond = SI->getCondition(); 5803 PHINode *PHI = nullptr; 5804 BasicBlock *CommonDest = nullptr; 5805 Constant *DefaultResult; 5806 SwitchCaseResultVectorTy UniqueResults; 5807 // Collect all the cases that will deliver the same value from the switch. 5808 if (!initializeUniqueCases(SI, PHI, CommonDest, UniqueResults, DefaultResult, 5809 DL, TTI, /*MaxUniqueResults*/ 2)) 5810 return false; 5811 5812 assert(PHI != nullptr && "PHI for value select not found"); 5813 Builder.SetInsertPoint(SI); 5814 Value *SelectValue = 5815 foldSwitchToSelect(UniqueResults, DefaultResult, Cond, Builder); 5816 if (!SelectValue) 5817 return false; 5818 5819 removeSwitchAfterSelectFold(SI, PHI, SelectValue, Builder, DTU); 5820 return true; 5821 } 5822 5823 namespace { 5824 5825 /// This class represents a lookup table that can be used to replace a switch. 5826 class SwitchLookupTable { 5827 public: 5828 /// Create a lookup table to use as a switch replacement with the contents 5829 /// of Values, using DefaultValue to fill any holes in the table. 5830 SwitchLookupTable( 5831 Module &M, uint64_t TableSize, ConstantInt *Offset, 5832 const SmallVectorImpl<std::pair<ConstantInt *, Constant *>> &Values, 5833 Constant *DefaultValue, const DataLayout &DL, const StringRef &FuncName); 5834 5835 /// Build instructions with Builder to retrieve the value at 5836 /// the position given by Index in the lookup table. 5837 Value *BuildLookup(Value *Index, IRBuilder<> &Builder); 5838 5839 /// Return true if a table with TableSize elements of 5840 /// type ElementType would fit in a target-legal register. 5841 static bool WouldFitInRegister(const DataLayout &DL, uint64_t TableSize, 5842 Type *ElementType); 5843 5844 private: 5845 // Depending on the contents of the table, it can be represented in 5846 // different ways. 5847 enum { 5848 // For tables where each element contains the same value, we just have to 5849 // store that single value and return it for each lookup. 5850 SingleValueKind, 5851 5852 // For tables where there is a linear relationship between table index 5853 // and values. We calculate the result with a simple multiplication 5854 // and addition instead of a table lookup. 5855 LinearMapKind, 5856 5857 // For small tables with integer elements, we can pack them into a bitmap 5858 // that fits into a target-legal register. Values are retrieved by 5859 // shift and mask operations. 5860 BitMapKind, 5861 5862 // The table is stored as an array of values. Values are retrieved by load 5863 // instructions from the table. 5864 ArrayKind 5865 } Kind; 5866 5867 // For SingleValueKind, this is the single value. 5868 Constant *SingleValue = nullptr; 5869 5870 // For BitMapKind, this is the bitmap. 5871 ConstantInt *BitMap = nullptr; 5872 IntegerType *BitMapElementTy = nullptr; 5873 5874 // For LinearMapKind, these are the constants used to derive the value. 5875 ConstantInt *LinearOffset = nullptr; 5876 ConstantInt *LinearMultiplier = nullptr; 5877 5878 // For ArrayKind, this is the array. 5879 GlobalVariable *Array = nullptr; 5880 }; 5881 5882 } // end anonymous namespace 5883 5884 SwitchLookupTable::SwitchLookupTable( 5885 Module &M, uint64_t TableSize, ConstantInt *Offset, 5886 const SmallVectorImpl<std::pair<ConstantInt *, Constant *>> &Values, 5887 Constant *DefaultValue, const DataLayout &DL, const StringRef &FuncName) { 5888 assert(Values.size() && "Can't build lookup table without values!"); 5889 assert(TableSize >= Values.size() && "Can't fit values in table!"); 5890 5891 // If all values in the table are equal, this is that value. 5892 SingleValue = Values.begin()->second; 5893 5894 Type *ValueType = Values.begin()->second->getType(); 5895 5896 // Build up the table contents. 5897 SmallVector<Constant *, 64> TableContents(TableSize); 5898 for (size_t I = 0, E = Values.size(); I != E; ++I) { 5899 ConstantInt *CaseVal = Values[I].first; 5900 Constant *CaseRes = Values[I].second; 5901 assert(CaseRes->getType() == ValueType); 5902 5903 uint64_t Idx = (CaseVal->getValue() - Offset->getValue()).getLimitedValue(); 5904 TableContents[Idx] = CaseRes; 5905 5906 if (CaseRes != SingleValue) 5907 SingleValue = nullptr; 5908 } 5909 5910 // Fill in any holes in the table with the default result. 5911 if (Values.size() < TableSize) { 5912 assert(DefaultValue && 5913 "Need a default value to fill the lookup table holes."); 5914 assert(DefaultValue->getType() == ValueType); 5915 for (uint64_t I = 0; I < TableSize; ++I) { 5916 if (!TableContents[I]) 5917 TableContents[I] = DefaultValue; 5918 } 5919 5920 if (DefaultValue != SingleValue) 5921 SingleValue = nullptr; 5922 } 5923 5924 // If each element in the table contains the same value, we only need to store 5925 // that single value. 5926 if (SingleValue) { 5927 Kind = SingleValueKind; 5928 return; 5929 } 5930 5931 // Check if we can derive the value with a linear transformation from the 5932 // table index. 5933 if (isa<IntegerType>(ValueType)) { 5934 bool LinearMappingPossible = true; 5935 APInt PrevVal; 5936 APInt DistToPrev; 5937 assert(TableSize >= 2 && "Should be a SingleValue table."); 5938 // Check if there is the same distance between two consecutive values. 5939 for (uint64_t I = 0; I < TableSize; ++I) { 5940 ConstantInt *ConstVal = dyn_cast<ConstantInt>(TableContents[I]); 5941 if (!ConstVal) { 5942 // This is an undef. We could deal with it, but undefs in lookup tables 5943 // are very seldom. It's probably not worth the additional complexity. 5944 LinearMappingPossible = false; 5945 break; 5946 } 5947 const APInt &Val = ConstVal->getValue(); 5948 if (I != 0) { 5949 APInt Dist = Val - PrevVal; 5950 if (I == 1) { 5951 DistToPrev = Dist; 5952 } else if (Dist != DistToPrev) { 5953 LinearMappingPossible = false; 5954 break; 5955 } 5956 } 5957 PrevVal = Val; 5958 } 5959 if (LinearMappingPossible) { 5960 LinearOffset = cast<ConstantInt>(TableContents[0]); 5961 LinearMultiplier = ConstantInt::get(M.getContext(), DistToPrev); 5962 Kind = LinearMapKind; 5963 ++NumLinearMaps; 5964 return; 5965 } 5966 } 5967 5968 // If the type is integer and the table fits in a register, build a bitmap. 5969 if (WouldFitInRegister(DL, TableSize, ValueType)) { 5970 IntegerType *IT = cast<IntegerType>(ValueType); 5971 APInt TableInt(TableSize * IT->getBitWidth(), 0); 5972 for (uint64_t I = TableSize; I > 0; --I) { 5973 TableInt <<= IT->getBitWidth(); 5974 // Insert values into the bitmap. Undef values are set to zero. 5975 if (!isa<UndefValue>(TableContents[I - 1])) { 5976 ConstantInt *Val = cast<ConstantInt>(TableContents[I - 1]); 5977 TableInt |= Val->getValue().zext(TableInt.getBitWidth()); 5978 } 5979 } 5980 BitMap = ConstantInt::get(M.getContext(), TableInt); 5981 BitMapElementTy = IT; 5982 Kind = BitMapKind; 5983 ++NumBitMaps; 5984 return; 5985 } 5986 5987 // Store the table in an array. 5988 ArrayType *ArrayTy = ArrayType::get(ValueType, TableSize); 5989 Constant *Initializer = ConstantArray::get(ArrayTy, TableContents); 5990 5991 Array = new GlobalVariable(M, ArrayTy, /*isConstant=*/true, 5992 GlobalVariable::PrivateLinkage, Initializer, 5993 "switch.table." + FuncName); 5994 Array->setUnnamedAddr(GlobalValue::UnnamedAddr::Global); 5995 // Set the alignment to that of an array items. We will be only loading one 5996 // value out of it. 5997 Array->setAlignment(Align(DL.getPrefTypeAlignment(ValueType))); 5998 Kind = ArrayKind; 5999 } 6000 6001 Value *SwitchLookupTable::BuildLookup(Value *Index, IRBuilder<> &Builder) { 6002 switch (Kind) { 6003 case SingleValueKind: 6004 return SingleValue; 6005 case LinearMapKind: { 6006 // Derive the result value from the input value. 6007 Value *Result = Builder.CreateIntCast(Index, LinearMultiplier->getType(), 6008 false, "switch.idx.cast"); 6009 if (!LinearMultiplier->isOne()) 6010 Result = Builder.CreateMul(Result, LinearMultiplier, "switch.idx.mult"); 6011 if (!LinearOffset->isZero()) 6012 Result = Builder.CreateAdd(Result, LinearOffset, "switch.offset"); 6013 return Result; 6014 } 6015 case BitMapKind: { 6016 // Type of the bitmap (e.g. i59). 6017 IntegerType *MapTy = BitMap->getType(); 6018 6019 // Cast Index to the same type as the bitmap. 6020 // Note: The Index is <= the number of elements in the table, so 6021 // truncating it to the width of the bitmask is safe. 6022 Value *ShiftAmt = Builder.CreateZExtOrTrunc(Index, MapTy, "switch.cast"); 6023 6024 // Multiply the shift amount by the element width. 6025 ShiftAmt = Builder.CreateMul( 6026 ShiftAmt, ConstantInt::get(MapTy, BitMapElementTy->getBitWidth()), 6027 "switch.shiftamt"); 6028 6029 // Shift down. 6030 Value *DownShifted = 6031 Builder.CreateLShr(BitMap, ShiftAmt, "switch.downshift"); 6032 // Mask off. 6033 return Builder.CreateTrunc(DownShifted, BitMapElementTy, "switch.masked"); 6034 } 6035 case ArrayKind: { 6036 // Make sure the table index will not overflow when treated as signed. 6037 IntegerType *IT = cast<IntegerType>(Index->getType()); 6038 uint64_t TableSize = 6039 Array->getInitializer()->getType()->getArrayNumElements(); 6040 if (TableSize > (1ULL << std::min(IT->getBitWidth() - 1, 63u))) 6041 Index = Builder.CreateZExt( 6042 Index, IntegerType::get(IT->getContext(), IT->getBitWidth() + 1), 6043 "switch.tableidx.zext"); 6044 6045 Value *GEPIndices[] = {Builder.getInt32(0), Index}; 6046 Value *GEP = Builder.CreateInBoundsGEP(Array->getValueType(), Array, 6047 GEPIndices, "switch.gep"); 6048 return Builder.CreateLoad( 6049 cast<ArrayType>(Array->getValueType())->getElementType(), GEP, 6050 "switch.load"); 6051 } 6052 } 6053 llvm_unreachable("Unknown lookup table kind!"); 6054 } 6055 6056 bool SwitchLookupTable::WouldFitInRegister(const DataLayout &DL, 6057 uint64_t TableSize, 6058 Type *ElementType) { 6059 auto *IT = dyn_cast<IntegerType>(ElementType); 6060 if (!IT) 6061 return false; 6062 // FIXME: If the type is wider than it needs to be, e.g. i8 but all values 6063 // are <= 15, we could try to narrow the type. 6064 6065 // Avoid overflow, fitsInLegalInteger uses unsigned int for the width. 6066 if (TableSize >= UINT_MAX / IT->getBitWidth()) 6067 return false; 6068 return DL.fitsInLegalInteger(TableSize * IT->getBitWidth()); 6069 } 6070 6071 static bool isTypeLegalForLookupTable(Type *Ty, const TargetTransformInfo &TTI, 6072 const DataLayout &DL) { 6073 // Allow any legal type. 6074 if (TTI.isTypeLegal(Ty)) 6075 return true; 6076 6077 auto *IT = dyn_cast<IntegerType>(Ty); 6078 if (!IT) 6079 return false; 6080 6081 // Also allow power of 2 integer types that have at least 8 bits and fit in 6082 // a register. These types are common in frontend languages and targets 6083 // usually support loads of these types. 6084 // TODO: We could relax this to any integer that fits in a register and rely 6085 // on ABI alignment and padding in the table to allow the load to be widened. 6086 // Or we could widen the constants and truncate the load. 6087 unsigned BitWidth = IT->getBitWidth(); 6088 return BitWidth >= 8 && isPowerOf2_32(BitWidth) && 6089 DL.fitsInLegalInteger(IT->getBitWidth()); 6090 } 6091 6092 static bool isSwitchDense(uint64_t NumCases, uint64_t CaseRange) { 6093 // 40% is the default density for building a jump table in optsize/minsize 6094 // mode. See also TargetLoweringBase::isSuitableForJumpTable(), which this 6095 // function was based on. 6096 const uint64_t MinDensity = 40; 6097 6098 if (CaseRange >= UINT64_MAX / 100) 6099 return false; // Avoid multiplication overflows below. 6100 6101 return NumCases * 100 >= CaseRange * MinDensity; 6102 } 6103 6104 static bool isSwitchDense(ArrayRef<int64_t> Values) { 6105 uint64_t Diff = (uint64_t)Values.back() - (uint64_t)Values.front(); 6106 uint64_t Range = Diff + 1; 6107 if (Range < Diff) 6108 return false; // Overflow. 6109 6110 return isSwitchDense(Values.size(), Range); 6111 } 6112 6113 /// Determine whether a lookup table should be built for this switch, based on 6114 /// the number of cases, size of the table, and the types of the results. 6115 // TODO: We could support larger than legal types by limiting based on the 6116 // number of loads required and/or table size. If the constants are small we 6117 // could use smaller table entries and extend after the load. 6118 static bool 6119 ShouldBuildLookupTable(SwitchInst *SI, uint64_t TableSize, 6120 const TargetTransformInfo &TTI, const DataLayout &DL, 6121 const SmallDenseMap<PHINode *, Type *> &ResultTypes) { 6122 if (SI->getNumCases() > TableSize) 6123 return false; // TableSize overflowed. 6124 6125 bool AllTablesFitInRegister = true; 6126 bool HasIllegalType = false; 6127 for (const auto &I : ResultTypes) { 6128 Type *Ty = I.second; 6129 6130 // Saturate this flag to true. 6131 HasIllegalType = HasIllegalType || !isTypeLegalForLookupTable(Ty, TTI, DL); 6132 6133 // Saturate this flag to false. 6134 AllTablesFitInRegister = 6135 AllTablesFitInRegister && 6136 SwitchLookupTable::WouldFitInRegister(DL, TableSize, Ty); 6137 6138 // If both flags saturate, we're done. NOTE: This *only* works with 6139 // saturating flags, and all flags have to saturate first due to the 6140 // non-deterministic behavior of iterating over a dense map. 6141 if (HasIllegalType && !AllTablesFitInRegister) 6142 break; 6143 } 6144 6145 // If each table would fit in a register, we should build it anyway. 6146 if (AllTablesFitInRegister) 6147 return true; 6148 6149 // Don't build a table that doesn't fit in-register if it has illegal types. 6150 if (HasIllegalType) 6151 return false; 6152 6153 return isSwitchDense(SI->getNumCases(), TableSize); 6154 } 6155 6156 /// Try to reuse the switch table index compare. Following pattern: 6157 /// \code 6158 /// if (idx < tablesize) 6159 /// r = table[idx]; // table does not contain default_value 6160 /// else 6161 /// r = default_value; 6162 /// if (r != default_value) 6163 /// ... 6164 /// \endcode 6165 /// Is optimized to: 6166 /// \code 6167 /// cond = idx < tablesize; 6168 /// if (cond) 6169 /// r = table[idx]; 6170 /// else 6171 /// r = default_value; 6172 /// if (cond) 6173 /// ... 6174 /// \endcode 6175 /// Jump threading will then eliminate the second if(cond). 6176 static void reuseTableCompare( 6177 User *PhiUser, BasicBlock *PhiBlock, BranchInst *RangeCheckBranch, 6178 Constant *DefaultValue, 6179 const SmallVectorImpl<std::pair<ConstantInt *, Constant *>> &Values) { 6180 ICmpInst *CmpInst = dyn_cast<ICmpInst>(PhiUser); 6181 if (!CmpInst) 6182 return; 6183 6184 // We require that the compare is in the same block as the phi so that jump 6185 // threading can do its work afterwards. 6186 if (CmpInst->getParent() != PhiBlock) 6187 return; 6188 6189 Constant *CmpOp1 = dyn_cast<Constant>(CmpInst->getOperand(1)); 6190 if (!CmpOp1) 6191 return; 6192 6193 Value *RangeCmp = RangeCheckBranch->getCondition(); 6194 Constant *TrueConst = ConstantInt::getTrue(RangeCmp->getType()); 6195 Constant *FalseConst = ConstantInt::getFalse(RangeCmp->getType()); 6196 6197 // Check if the compare with the default value is constant true or false. 6198 Constant *DefaultConst = ConstantExpr::getICmp(CmpInst->getPredicate(), 6199 DefaultValue, CmpOp1, true); 6200 if (DefaultConst != TrueConst && DefaultConst != FalseConst) 6201 return; 6202 6203 // Check if the compare with the case values is distinct from the default 6204 // compare result. 6205 for (auto ValuePair : Values) { 6206 Constant *CaseConst = ConstantExpr::getICmp(CmpInst->getPredicate(), 6207 ValuePair.second, CmpOp1, true); 6208 if (!CaseConst || CaseConst == DefaultConst || 6209 (CaseConst != TrueConst && CaseConst != FalseConst)) 6210 return; 6211 } 6212 6213 // Check if the branch instruction dominates the phi node. It's a simple 6214 // dominance check, but sufficient for our needs. 6215 // Although this check is invariant in the calling loops, it's better to do it 6216 // at this late stage. Practically we do it at most once for a switch. 6217 BasicBlock *BranchBlock = RangeCheckBranch->getParent(); 6218 for (BasicBlock *Pred : predecessors(PhiBlock)) { 6219 if (Pred != BranchBlock && Pred->getUniquePredecessor() != BranchBlock) 6220 return; 6221 } 6222 6223 if (DefaultConst == FalseConst) { 6224 // The compare yields the same result. We can replace it. 6225 CmpInst->replaceAllUsesWith(RangeCmp); 6226 ++NumTableCmpReuses; 6227 } else { 6228 // The compare yields the same result, just inverted. We can replace it. 6229 Value *InvertedTableCmp = BinaryOperator::CreateXor( 6230 RangeCmp, ConstantInt::get(RangeCmp->getType(), 1), "inverted.cmp", 6231 RangeCheckBranch); 6232 CmpInst->replaceAllUsesWith(InvertedTableCmp); 6233 ++NumTableCmpReuses; 6234 } 6235 } 6236 6237 /// If the switch is only used to initialize one or more phi nodes in a common 6238 /// successor block with different constant values, replace the switch with 6239 /// lookup tables. 6240 static bool SwitchToLookupTable(SwitchInst *SI, IRBuilder<> &Builder, 6241 DomTreeUpdater *DTU, const DataLayout &DL, 6242 const TargetTransformInfo &TTI) { 6243 assert(SI->getNumCases() > 1 && "Degenerate switch?"); 6244 6245 BasicBlock *BB = SI->getParent(); 6246 Function *Fn = BB->getParent(); 6247 // Only build lookup table when we have a target that supports it or the 6248 // attribute is not set. 6249 if (!TTI.shouldBuildLookupTables() || 6250 (Fn->getFnAttribute("no-jump-tables").getValueAsBool())) 6251 return false; 6252 6253 // FIXME: If the switch is too sparse for a lookup table, perhaps we could 6254 // split off a dense part and build a lookup table for that. 6255 6256 // FIXME: This creates arrays of GEPs to constant strings, which means each 6257 // GEP needs a runtime relocation in PIC code. We should just build one big 6258 // string and lookup indices into that. 6259 6260 // Ignore switches with less than three cases. Lookup tables will not make 6261 // them faster, so we don't analyze them. 6262 if (SI->getNumCases() < 3) 6263 return false; 6264 6265 // Figure out the corresponding result for each case value and phi node in the 6266 // common destination, as well as the min and max case values. 6267 assert(!SI->cases().empty()); 6268 SwitchInst::CaseIt CI = SI->case_begin(); 6269 ConstantInt *MinCaseVal = CI->getCaseValue(); 6270 ConstantInt *MaxCaseVal = CI->getCaseValue(); 6271 6272 BasicBlock *CommonDest = nullptr; 6273 6274 using ResultListTy = SmallVector<std::pair<ConstantInt *, Constant *>, 4>; 6275 SmallDenseMap<PHINode *, ResultListTy> ResultLists; 6276 6277 SmallDenseMap<PHINode *, Constant *> DefaultResults; 6278 SmallDenseMap<PHINode *, Type *> ResultTypes; 6279 SmallVector<PHINode *, 4> PHIs; 6280 6281 for (SwitchInst::CaseIt E = SI->case_end(); CI != E; ++CI) { 6282 ConstantInt *CaseVal = CI->getCaseValue(); 6283 if (CaseVal->getValue().slt(MinCaseVal->getValue())) 6284 MinCaseVal = CaseVal; 6285 if (CaseVal->getValue().sgt(MaxCaseVal->getValue())) 6286 MaxCaseVal = CaseVal; 6287 6288 // Resulting value at phi nodes for this case value. 6289 using ResultsTy = SmallVector<std::pair<PHINode *, Constant *>, 4>; 6290 ResultsTy Results; 6291 if (!getCaseResults(SI, CaseVal, CI->getCaseSuccessor(), &CommonDest, 6292 Results, DL, TTI)) 6293 return false; 6294 6295 // Append the result from this case to the list for each phi. 6296 for (const auto &I : Results) { 6297 PHINode *PHI = I.first; 6298 Constant *Value = I.second; 6299 if (!ResultLists.count(PHI)) 6300 PHIs.push_back(PHI); 6301 ResultLists[PHI].push_back(std::make_pair(CaseVal, Value)); 6302 } 6303 } 6304 6305 // Keep track of the result types. 6306 for (PHINode *PHI : PHIs) { 6307 ResultTypes[PHI] = ResultLists[PHI][0].second->getType(); 6308 } 6309 6310 uint64_t NumResults = ResultLists[PHIs[0]].size(); 6311 APInt RangeSpread = MaxCaseVal->getValue() - MinCaseVal->getValue(); 6312 uint64_t TableSize = RangeSpread.getLimitedValue() + 1; 6313 bool TableHasHoles = (NumResults < TableSize); 6314 6315 // If the table has holes, we need a constant result for the default case 6316 // or a bitmask that fits in a register. 6317 SmallVector<std::pair<PHINode *, Constant *>, 4> DefaultResultsList; 6318 bool HasDefaultResults = 6319 getCaseResults(SI, nullptr, SI->getDefaultDest(), &CommonDest, 6320 DefaultResultsList, DL, TTI); 6321 6322 bool NeedMask = (TableHasHoles && !HasDefaultResults); 6323 if (NeedMask) { 6324 // As an extra penalty for the validity test we require more cases. 6325 if (SI->getNumCases() < 4) // FIXME: Find best threshold value (benchmark). 6326 return false; 6327 if (!DL.fitsInLegalInteger(TableSize)) 6328 return false; 6329 } 6330 6331 for (const auto &I : DefaultResultsList) { 6332 PHINode *PHI = I.first; 6333 Constant *Result = I.second; 6334 DefaultResults[PHI] = Result; 6335 } 6336 6337 if (!ShouldBuildLookupTable(SI, TableSize, TTI, DL, ResultTypes)) 6338 return false; 6339 6340 std::vector<DominatorTree::UpdateType> Updates; 6341 6342 // Create the BB that does the lookups. 6343 Module &Mod = *CommonDest->getParent()->getParent(); 6344 BasicBlock *LookupBB = BasicBlock::Create( 6345 Mod.getContext(), "switch.lookup", CommonDest->getParent(), CommonDest); 6346 6347 // Compute the table index value. 6348 Builder.SetInsertPoint(SI); 6349 Value *TableIndex; 6350 if (MinCaseVal->isNullValue()) 6351 TableIndex = SI->getCondition(); 6352 else 6353 TableIndex = Builder.CreateSub(SI->getCondition(), MinCaseVal, 6354 "switch.tableidx"); 6355 6356 // Compute the maximum table size representable by the integer type we are 6357 // switching upon. 6358 unsigned CaseSize = MinCaseVal->getType()->getPrimitiveSizeInBits(); 6359 uint64_t MaxTableSize = CaseSize > 63 ? UINT64_MAX : 1ULL << CaseSize; 6360 assert(MaxTableSize >= TableSize && 6361 "It is impossible for a switch to have more entries than the max " 6362 "representable value of its input integer type's size."); 6363 6364 // If the default destination is unreachable, or if the lookup table covers 6365 // all values of the conditional variable, branch directly to the lookup table 6366 // BB. Otherwise, check that the condition is within the case range. 6367 const bool DefaultIsReachable = 6368 !isa<UnreachableInst>(SI->getDefaultDest()->getFirstNonPHIOrDbg()); 6369 const bool GeneratingCoveredLookupTable = (MaxTableSize == TableSize); 6370 BranchInst *RangeCheckBranch = nullptr; 6371 6372 if (!DefaultIsReachable || GeneratingCoveredLookupTable) { 6373 Builder.CreateBr(LookupBB); 6374 if (DTU) 6375 Updates.push_back({DominatorTree::Insert, BB, LookupBB}); 6376 // Note: We call removeProdecessor later since we need to be able to get the 6377 // PHI value for the default case in case we're using a bit mask. 6378 } else { 6379 Value *Cmp = Builder.CreateICmpULT( 6380 TableIndex, ConstantInt::get(MinCaseVal->getType(), TableSize)); 6381 RangeCheckBranch = 6382 Builder.CreateCondBr(Cmp, LookupBB, SI->getDefaultDest()); 6383 if (DTU) 6384 Updates.push_back({DominatorTree::Insert, BB, LookupBB}); 6385 } 6386 6387 // Populate the BB that does the lookups. 6388 Builder.SetInsertPoint(LookupBB); 6389 6390 if (NeedMask) { 6391 // Before doing the lookup, we do the hole check. The LookupBB is therefore 6392 // re-purposed to do the hole check, and we create a new LookupBB. 6393 BasicBlock *MaskBB = LookupBB; 6394 MaskBB->setName("switch.hole_check"); 6395 LookupBB = BasicBlock::Create(Mod.getContext(), "switch.lookup", 6396 CommonDest->getParent(), CommonDest); 6397 6398 // Make the mask's bitwidth at least 8-bit and a power-of-2 to avoid 6399 // unnecessary illegal types. 6400 uint64_t TableSizePowOf2 = NextPowerOf2(std::max(7ULL, TableSize - 1ULL)); 6401 APInt MaskInt(TableSizePowOf2, 0); 6402 APInt One(TableSizePowOf2, 1); 6403 // Build bitmask; fill in a 1 bit for every case. 6404 const ResultListTy &ResultList = ResultLists[PHIs[0]]; 6405 for (size_t I = 0, E = ResultList.size(); I != E; ++I) { 6406 uint64_t Idx = (ResultList[I].first->getValue() - MinCaseVal->getValue()) 6407 .getLimitedValue(); 6408 MaskInt |= One << Idx; 6409 } 6410 ConstantInt *TableMask = ConstantInt::get(Mod.getContext(), MaskInt); 6411 6412 // Get the TableIndex'th bit of the bitmask. 6413 // If this bit is 0 (meaning hole) jump to the default destination, 6414 // else continue with table lookup. 6415 IntegerType *MapTy = TableMask->getType(); 6416 Value *MaskIndex = 6417 Builder.CreateZExtOrTrunc(TableIndex, MapTy, "switch.maskindex"); 6418 Value *Shifted = Builder.CreateLShr(TableMask, MaskIndex, "switch.shifted"); 6419 Value *LoBit = Builder.CreateTrunc( 6420 Shifted, Type::getInt1Ty(Mod.getContext()), "switch.lobit"); 6421 Builder.CreateCondBr(LoBit, LookupBB, SI->getDefaultDest()); 6422 if (DTU) { 6423 Updates.push_back({DominatorTree::Insert, MaskBB, LookupBB}); 6424 Updates.push_back({DominatorTree::Insert, MaskBB, SI->getDefaultDest()}); 6425 } 6426 Builder.SetInsertPoint(LookupBB); 6427 AddPredecessorToBlock(SI->getDefaultDest(), MaskBB, BB); 6428 } 6429 6430 if (!DefaultIsReachable || GeneratingCoveredLookupTable) { 6431 // We cached PHINodes in PHIs. To avoid accessing deleted PHINodes later, 6432 // do not delete PHINodes here. 6433 SI->getDefaultDest()->removePredecessor(BB, 6434 /*KeepOneInputPHIs=*/true); 6435 if (DTU) 6436 Updates.push_back({DominatorTree::Delete, BB, SI->getDefaultDest()}); 6437 } 6438 6439 for (PHINode *PHI : PHIs) { 6440 const ResultListTy &ResultList = ResultLists[PHI]; 6441 6442 // If using a bitmask, use any value to fill the lookup table holes. 6443 Constant *DV = NeedMask ? ResultLists[PHI][0].second : DefaultResults[PHI]; 6444 StringRef FuncName = Fn->getName(); 6445 SwitchLookupTable Table(Mod, TableSize, MinCaseVal, ResultList, DV, DL, 6446 FuncName); 6447 6448 Value *Result = Table.BuildLookup(TableIndex, Builder); 6449 6450 // Do a small peephole optimization: re-use the switch table compare if 6451 // possible. 6452 if (!TableHasHoles && HasDefaultResults && RangeCheckBranch) { 6453 BasicBlock *PhiBlock = PHI->getParent(); 6454 // Search for compare instructions which use the phi. 6455 for (auto *User : PHI->users()) { 6456 reuseTableCompare(User, PhiBlock, RangeCheckBranch, DV, ResultList); 6457 } 6458 } 6459 6460 PHI->addIncoming(Result, LookupBB); 6461 } 6462 6463 Builder.CreateBr(CommonDest); 6464 if (DTU) 6465 Updates.push_back({DominatorTree::Insert, LookupBB, CommonDest}); 6466 6467 // Remove the switch. 6468 SmallPtrSet<BasicBlock *, 8> RemovedSuccessors; 6469 for (unsigned i = 0, e = SI->getNumSuccessors(); i < e; ++i) { 6470 BasicBlock *Succ = SI->getSuccessor(i); 6471 6472 if (Succ == SI->getDefaultDest()) 6473 continue; 6474 Succ->removePredecessor(BB); 6475 if (DTU && RemovedSuccessors.insert(Succ).second) 6476 Updates.push_back({DominatorTree::Delete, BB, Succ}); 6477 } 6478 SI->eraseFromParent(); 6479 6480 if (DTU) 6481 DTU->applyUpdates(Updates); 6482 6483 ++NumLookupTables; 6484 if (NeedMask) 6485 ++NumLookupTablesHoles; 6486 return true; 6487 } 6488 6489 /// Try to transform a switch that has "holes" in it to a contiguous sequence 6490 /// of cases. 6491 /// 6492 /// A switch such as: switch(i) {case 5: case 9: case 13: case 17:} can be 6493 /// range-reduced to: switch ((i-5) / 4) {case 0: case 1: case 2: case 3:}. 6494 /// 6495 /// This converts a sparse switch into a dense switch which allows better 6496 /// lowering and could also allow transforming into a lookup table. 6497 static bool ReduceSwitchRange(SwitchInst *SI, IRBuilder<> &Builder, 6498 const DataLayout &DL, 6499 const TargetTransformInfo &TTI) { 6500 auto *CondTy = cast<IntegerType>(SI->getCondition()->getType()); 6501 if (CondTy->getIntegerBitWidth() > 64 || 6502 !DL.fitsInLegalInteger(CondTy->getIntegerBitWidth())) 6503 return false; 6504 // Only bother with this optimization if there are more than 3 switch cases; 6505 // SDAG will only bother creating jump tables for 4 or more cases. 6506 if (SI->getNumCases() < 4) 6507 return false; 6508 6509 // This transform is agnostic to the signedness of the input or case values. We 6510 // can treat the case values as signed or unsigned. We can optimize more common 6511 // cases such as a sequence crossing zero {-4,0,4,8} if we interpret case values 6512 // as signed. 6513 SmallVector<int64_t,4> Values; 6514 for (auto &C : SI->cases()) 6515 Values.push_back(C.getCaseValue()->getValue().getSExtValue()); 6516 llvm::sort(Values); 6517 6518 // If the switch is already dense, there's nothing useful to do here. 6519 if (isSwitchDense(Values)) 6520 return false; 6521 6522 // First, transform the values such that they start at zero and ascend. 6523 int64_t Base = Values[0]; 6524 for (auto &V : Values) 6525 V -= (uint64_t)(Base); 6526 6527 // Now we have signed numbers that have been shifted so that, given enough 6528 // precision, there are no negative values. Since the rest of the transform 6529 // is bitwise only, we switch now to an unsigned representation. 6530 6531 // This transform can be done speculatively because it is so cheap - it 6532 // results in a single rotate operation being inserted. 6533 // FIXME: It's possible that optimizing a switch on powers of two might also 6534 // be beneficial - flag values are often powers of two and we could use a CLZ 6535 // as the key function. 6536 6537 // countTrailingZeros(0) returns 64. As Values is guaranteed to have more than 6538 // one element and LLVM disallows duplicate cases, Shift is guaranteed to be 6539 // less than 64. 6540 unsigned Shift = 64; 6541 for (auto &V : Values) 6542 Shift = std::min(Shift, countTrailingZeros((uint64_t)V)); 6543 assert(Shift < 64); 6544 if (Shift > 0) 6545 for (auto &V : Values) 6546 V = (int64_t)((uint64_t)V >> Shift); 6547 6548 if (!isSwitchDense(Values)) 6549 // Transform didn't create a dense switch. 6550 return false; 6551 6552 // The obvious transform is to shift the switch condition right and emit a 6553 // check that the condition actually cleanly divided by GCD, i.e. 6554 // C & (1 << Shift - 1) == 0 6555 // inserting a new CFG edge to handle the case where it didn't divide cleanly. 6556 // 6557 // A cheaper way of doing this is a simple ROTR(C, Shift). This performs the 6558 // shift and puts the shifted-off bits in the uppermost bits. If any of these 6559 // are nonzero then the switch condition will be very large and will hit the 6560 // default case. 6561 6562 auto *Ty = cast<IntegerType>(SI->getCondition()->getType()); 6563 Builder.SetInsertPoint(SI); 6564 auto *ShiftC = ConstantInt::get(Ty, Shift); 6565 auto *Sub = Builder.CreateSub(SI->getCondition(), ConstantInt::get(Ty, Base)); 6566 auto *LShr = Builder.CreateLShr(Sub, ShiftC); 6567 auto *Shl = Builder.CreateShl(Sub, Ty->getBitWidth() - Shift); 6568 auto *Rot = Builder.CreateOr(LShr, Shl); 6569 SI->replaceUsesOfWith(SI->getCondition(), Rot); 6570 6571 for (auto Case : SI->cases()) { 6572 auto *Orig = Case.getCaseValue(); 6573 auto Sub = Orig->getValue() - APInt(Ty->getBitWidth(), Base); 6574 Case.setValue( 6575 cast<ConstantInt>(ConstantInt::get(Ty, Sub.lshr(ShiftC->getValue())))); 6576 } 6577 return true; 6578 } 6579 6580 bool SimplifyCFGOpt::simplifySwitch(SwitchInst *SI, IRBuilder<> &Builder) { 6581 BasicBlock *BB = SI->getParent(); 6582 6583 if (isValueEqualityComparison(SI)) { 6584 // If we only have one predecessor, and if it is a branch on this value, 6585 // see if that predecessor totally determines the outcome of this switch. 6586 if (BasicBlock *OnlyPred = BB->getSinglePredecessor()) 6587 if (SimplifyEqualityComparisonWithOnlyPredecessor(SI, OnlyPred, Builder)) 6588 return requestResimplify(); 6589 6590 Value *Cond = SI->getCondition(); 6591 if (SelectInst *Select = dyn_cast<SelectInst>(Cond)) 6592 if (SimplifySwitchOnSelect(SI, Select)) 6593 return requestResimplify(); 6594 6595 // If the block only contains the switch, see if we can fold the block 6596 // away into any preds. 6597 if (SI == &*BB->instructionsWithoutDebug(false).begin()) 6598 if (FoldValueComparisonIntoPredecessors(SI, Builder)) 6599 return requestResimplify(); 6600 } 6601 6602 // Try to transform the switch into an icmp and a branch. 6603 // The conversion from switch to comparison may lose information on 6604 // impossible switch values, so disable it early in the pipeline. 6605 if (Options.ConvertSwitchRangeToICmp && TurnSwitchRangeIntoICmp(SI, Builder)) 6606 return requestResimplify(); 6607 6608 // Remove unreachable cases. 6609 if (eliminateDeadSwitchCases(SI, DTU, Options.AC, DL)) 6610 return requestResimplify(); 6611 6612 if (trySwitchToSelect(SI, Builder, DTU, DL, TTI)) 6613 return requestResimplify(); 6614 6615 if (Options.ForwardSwitchCondToPhi && ForwardSwitchConditionToPHI(SI)) 6616 return requestResimplify(); 6617 6618 // The conversion from switch to lookup tables results in difficult-to-analyze 6619 // code and makes pruning branches much harder. This is a problem if the 6620 // switch expression itself can still be restricted as a result of inlining or 6621 // CVP. Therefore, only apply this transformation during late stages of the 6622 // optimisation pipeline. 6623 if (Options.ConvertSwitchToLookupTable && 6624 SwitchToLookupTable(SI, Builder, DTU, DL, TTI)) 6625 return requestResimplify(); 6626 6627 if (ReduceSwitchRange(SI, Builder, DL, TTI)) 6628 return requestResimplify(); 6629 6630 return false; 6631 } 6632 6633 bool SimplifyCFGOpt::simplifyIndirectBr(IndirectBrInst *IBI) { 6634 BasicBlock *BB = IBI->getParent(); 6635 bool Changed = false; 6636 6637 // Eliminate redundant destinations. 6638 SmallPtrSet<Value *, 8> Succs; 6639 SmallSetVector<BasicBlock *, 8> RemovedSuccs; 6640 for (unsigned i = 0, e = IBI->getNumDestinations(); i != e; ++i) { 6641 BasicBlock *Dest = IBI->getDestination(i); 6642 if (!Dest->hasAddressTaken() || !Succs.insert(Dest).second) { 6643 if (!Dest->hasAddressTaken()) 6644 RemovedSuccs.insert(Dest); 6645 Dest->removePredecessor(BB); 6646 IBI->removeDestination(i); 6647 --i; 6648 --e; 6649 Changed = true; 6650 } 6651 } 6652 6653 if (DTU) { 6654 std::vector<DominatorTree::UpdateType> Updates; 6655 Updates.reserve(RemovedSuccs.size()); 6656 for (auto *RemovedSucc : RemovedSuccs) 6657 Updates.push_back({DominatorTree::Delete, BB, RemovedSucc}); 6658 DTU->applyUpdates(Updates); 6659 } 6660 6661 if (IBI->getNumDestinations() == 0) { 6662 // If the indirectbr has no successors, change it to unreachable. 6663 new UnreachableInst(IBI->getContext(), IBI); 6664 EraseTerminatorAndDCECond(IBI); 6665 return true; 6666 } 6667 6668 if (IBI->getNumDestinations() == 1) { 6669 // If the indirectbr has one successor, change it to a direct branch. 6670 BranchInst::Create(IBI->getDestination(0), IBI); 6671 EraseTerminatorAndDCECond(IBI); 6672 return true; 6673 } 6674 6675 if (SelectInst *SI = dyn_cast<SelectInst>(IBI->getAddress())) { 6676 if (SimplifyIndirectBrOnSelect(IBI, SI)) 6677 return requestResimplify(); 6678 } 6679 return Changed; 6680 } 6681 6682 /// Given an block with only a single landing pad and a unconditional branch 6683 /// try to find another basic block which this one can be merged with. This 6684 /// handles cases where we have multiple invokes with unique landing pads, but 6685 /// a shared handler. 6686 /// 6687 /// We specifically choose to not worry about merging non-empty blocks 6688 /// here. That is a PRE/scheduling problem and is best solved elsewhere. In 6689 /// practice, the optimizer produces empty landing pad blocks quite frequently 6690 /// when dealing with exception dense code. (see: instcombine, gvn, if-else 6691 /// sinking in this file) 6692 /// 6693 /// This is primarily a code size optimization. We need to avoid performing 6694 /// any transform which might inhibit optimization (such as our ability to 6695 /// specialize a particular handler via tail commoning). We do this by not 6696 /// merging any blocks which require us to introduce a phi. Since the same 6697 /// values are flowing through both blocks, we don't lose any ability to 6698 /// specialize. If anything, we make such specialization more likely. 6699 /// 6700 /// TODO - This transformation could remove entries from a phi in the target 6701 /// block when the inputs in the phi are the same for the two blocks being 6702 /// merged. In some cases, this could result in removal of the PHI entirely. 6703 static bool TryToMergeLandingPad(LandingPadInst *LPad, BranchInst *BI, 6704 BasicBlock *BB, DomTreeUpdater *DTU) { 6705 auto Succ = BB->getUniqueSuccessor(); 6706 assert(Succ); 6707 // If there's a phi in the successor block, we'd likely have to introduce 6708 // a phi into the merged landing pad block. 6709 if (isa<PHINode>(*Succ->begin())) 6710 return false; 6711 6712 for (BasicBlock *OtherPred : predecessors(Succ)) { 6713 if (BB == OtherPred) 6714 continue; 6715 BasicBlock::iterator I = OtherPred->begin(); 6716 LandingPadInst *LPad2 = dyn_cast<LandingPadInst>(I); 6717 if (!LPad2 || !LPad2->isIdenticalTo(LPad)) 6718 continue; 6719 for (++I; isa<DbgInfoIntrinsic>(I); ++I) 6720 ; 6721 BranchInst *BI2 = dyn_cast<BranchInst>(I); 6722 if (!BI2 || !BI2->isIdenticalTo(BI)) 6723 continue; 6724 6725 std::vector<DominatorTree::UpdateType> Updates; 6726 6727 // We've found an identical block. Update our predecessors to take that 6728 // path instead and make ourselves dead. 6729 SmallSetVector<BasicBlock *, 16> UniquePreds(pred_begin(BB), pred_end(BB)); 6730 for (BasicBlock *Pred : UniquePreds) { 6731 InvokeInst *II = cast<InvokeInst>(Pred->getTerminator()); 6732 assert(II->getNormalDest() != BB && II->getUnwindDest() == BB && 6733 "unexpected successor"); 6734 II->setUnwindDest(OtherPred); 6735 if (DTU) { 6736 Updates.push_back({DominatorTree::Insert, Pred, OtherPred}); 6737 Updates.push_back({DominatorTree::Delete, Pred, BB}); 6738 } 6739 } 6740 6741 // The debug info in OtherPred doesn't cover the merged control flow that 6742 // used to go through BB. We need to delete it or update it. 6743 for (Instruction &Inst : llvm::make_early_inc_range(*OtherPred)) 6744 if (isa<DbgInfoIntrinsic>(Inst)) 6745 Inst.eraseFromParent(); 6746 6747 SmallSetVector<BasicBlock *, 16> UniqueSuccs(succ_begin(BB), succ_end(BB)); 6748 for (BasicBlock *Succ : UniqueSuccs) { 6749 Succ->removePredecessor(BB); 6750 if (DTU) 6751 Updates.push_back({DominatorTree::Delete, BB, Succ}); 6752 } 6753 6754 IRBuilder<> Builder(BI); 6755 Builder.CreateUnreachable(); 6756 BI->eraseFromParent(); 6757 if (DTU) 6758 DTU->applyUpdates(Updates); 6759 return true; 6760 } 6761 return false; 6762 } 6763 6764 bool SimplifyCFGOpt::simplifyBranch(BranchInst *Branch, IRBuilder<> &Builder) { 6765 return Branch->isUnconditional() ? simplifyUncondBranch(Branch, Builder) 6766 : simplifyCondBranch(Branch, Builder); 6767 } 6768 6769 bool SimplifyCFGOpt::simplifyUncondBranch(BranchInst *BI, 6770 IRBuilder<> &Builder) { 6771 BasicBlock *BB = BI->getParent(); 6772 BasicBlock *Succ = BI->getSuccessor(0); 6773 6774 // If the Terminator is the only non-phi instruction, simplify the block. 6775 // If LoopHeader is provided, check if the block or its successor is a loop 6776 // header. (This is for early invocations before loop simplify and 6777 // vectorization to keep canonical loop forms for nested loops. These blocks 6778 // can be eliminated when the pass is invoked later in the back-end.) 6779 // Note that if BB has only one predecessor then we do not introduce new 6780 // backedge, so we can eliminate BB. 6781 bool NeedCanonicalLoop = 6782 Options.NeedCanonicalLoop && 6783 (!LoopHeaders.empty() && BB->hasNPredecessorsOrMore(2) && 6784 (is_contained(LoopHeaders, BB) || is_contained(LoopHeaders, Succ))); 6785 BasicBlock::iterator I = BB->getFirstNonPHIOrDbg(true)->getIterator(); 6786 if (I->isTerminator() && BB != &BB->getParent()->getEntryBlock() && 6787 !NeedCanonicalLoop && TryToSimplifyUncondBranchFromEmptyBlock(BB, DTU)) 6788 return true; 6789 6790 // If the only instruction in the block is a seteq/setne comparison against a 6791 // constant, try to simplify the block. 6792 if (ICmpInst *ICI = dyn_cast<ICmpInst>(I)) 6793 if (ICI->isEquality() && isa<ConstantInt>(ICI->getOperand(1))) { 6794 for (++I; isa<DbgInfoIntrinsic>(I); ++I) 6795 ; 6796 if (I->isTerminator() && 6797 tryToSimplifyUncondBranchWithICmpInIt(ICI, Builder)) 6798 return true; 6799 } 6800 6801 // See if we can merge an empty landing pad block with another which is 6802 // equivalent. 6803 if (LandingPadInst *LPad = dyn_cast<LandingPadInst>(I)) { 6804 for (++I; isa<DbgInfoIntrinsic>(I); ++I) 6805 ; 6806 if (I->isTerminator() && TryToMergeLandingPad(LPad, BI, BB, DTU)) 6807 return true; 6808 } 6809 6810 // If this basic block is ONLY a compare and a branch, and if a predecessor 6811 // branches to us and our successor, fold the comparison into the 6812 // predecessor and use logical operations to update the incoming value 6813 // for PHI nodes in common successor. 6814 if (FoldBranchToCommonDest(BI, DTU, /*MSSAU=*/nullptr, &TTI, 6815 Options.BonusInstThreshold)) 6816 return requestResimplify(); 6817 return false; 6818 } 6819 6820 static BasicBlock *allPredecessorsComeFromSameSource(BasicBlock *BB) { 6821 BasicBlock *PredPred = nullptr; 6822 for (auto *P : predecessors(BB)) { 6823 BasicBlock *PPred = P->getSinglePredecessor(); 6824 if (!PPred || (PredPred && PredPred != PPred)) 6825 return nullptr; 6826 PredPred = PPred; 6827 } 6828 return PredPred; 6829 } 6830 6831 bool SimplifyCFGOpt::simplifyCondBranch(BranchInst *BI, IRBuilder<> &Builder) { 6832 assert( 6833 !isa<ConstantInt>(BI->getCondition()) && 6834 BI->getSuccessor(0) != BI->getSuccessor(1) && 6835 "Tautological conditional branch should have been eliminated already."); 6836 6837 BasicBlock *BB = BI->getParent(); 6838 if (!Options.SimplifyCondBranch) 6839 return false; 6840 6841 // Conditional branch 6842 if (isValueEqualityComparison(BI)) { 6843 // If we only have one predecessor, and if it is a branch on this value, 6844 // see if that predecessor totally determines the outcome of this 6845 // switch. 6846 if (BasicBlock *OnlyPred = BB->getSinglePredecessor()) 6847 if (SimplifyEqualityComparisonWithOnlyPredecessor(BI, OnlyPred, Builder)) 6848 return requestResimplify(); 6849 6850 // This block must be empty, except for the setcond inst, if it exists. 6851 // Ignore dbg and pseudo intrinsics. 6852 auto I = BB->instructionsWithoutDebug(true).begin(); 6853 if (&*I == BI) { 6854 if (FoldValueComparisonIntoPredecessors(BI, Builder)) 6855 return requestResimplify(); 6856 } else if (&*I == cast<Instruction>(BI->getCondition())) { 6857 ++I; 6858 if (&*I == BI && FoldValueComparisonIntoPredecessors(BI, Builder)) 6859 return requestResimplify(); 6860 } 6861 } 6862 6863 // Try to turn "br (X == 0 | X == 1), T, F" into a switch instruction. 6864 if (SimplifyBranchOnICmpChain(BI, Builder, DL)) 6865 return true; 6866 6867 // If this basic block has dominating predecessor blocks and the dominating 6868 // blocks' conditions imply BI's condition, we know the direction of BI. 6869 Optional<bool> Imp = isImpliedByDomCondition(BI->getCondition(), BI, DL); 6870 if (Imp) { 6871 // Turn this into a branch on constant. 6872 auto *OldCond = BI->getCondition(); 6873 ConstantInt *TorF = *Imp ? ConstantInt::getTrue(BB->getContext()) 6874 : ConstantInt::getFalse(BB->getContext()); 6875 BI->setCondition(TorF); 6876 RecursivelyDeleteTriviallyDeadInstructions(OldCond); 6877 return requestResimplify(); 6878 } 6879 6880 // If this basic block is ONLY a compare and a branch, and if a predecessor 6881 // branches to us and one of our successors, fold the comparison into the 6882 // predecessor and use logical operations to pick the right destination. 6883 if (FoldBranchToCommonDest(BI, DTU, /*MSSAU=*/nullptr, &TTI, 6884 Options.BonusInstThreshold)) 6885 return requestResimplify(); 6886 6887 // We have a conditional branch to two blocks that are only reachable 6888 // from BI. We know that the condbr dominates the two blocks, so see if 6889 // there is any identical code in the "then" and "else" blocks. If so, we 6890 // can hoist it up to the branching block. 6891 if (BI->getSuccessor(0)->getSinglePredecessor()) { 6892 if (BI->getSuccessor(1)->getSinglePredecessor()) { 6893 if (HoistCommon && 6894 HoistThenElseCodeToIf(BI, TTI, !Options.HoistCommonInsts)) 6895 return requestResimplify(); 6896 } else { 6897 // If Successor #1 has multiple preds, we may be able to conditionally 6898 // execute Successor #0 if it branches to Successor #1. 6899 Instruction *Succ0TI = BI->getSuccessor(0)->getTerminator(); 6900 if (Succ0TI->getNumSuccessors() == 1 && 6901 Succ0TI->getSuccessor(0) == BI->getSuccessor(1)) 6902 if (SpeculativelyExecuteBB(BI, BI->getSuccessor(0), TTI)) 6903 return requestResimplify(); 6904 } 6905 } else if (BI->getSuccessor(1)->getSinglePredecessor()) { 6906 // If Successor #0 has multiple preds, we may be able to conditionally 6907 // execute Successor #1 if it branches to Successor #0. 6908 Instruction *Succ1TI = BI->getSuccessor(1)->getTerminator(); 6909 if (Succ1TI->getNumSuccessors() == 1 && 6910 Succ1TI->getSuccessor(0) == BI->getSuccessor(0)) 6911 if (SpeculativelyExecuteBB(BI, BI->getSuccessor(1), TTI)) 6912 return requestResimplify(); 6913 } 6914 6915 // If this is a branch on something for which we know the constant value in 6916 // predecessors (e.g. a phi node in the current block), thread control 6917 // through this block. 6918 if (FoldCondBranchOnValueKnownInPredecessor(BI, DTU, DL, Options.AC)) 6919 return requestResimplify(); 6920 6921 // Scan predecessor blocks for conditional branches. 6922 for (BasicBlock *Pred : predecessors(BB)) 6923 if (BranchInst *PBI = dyn_cast<BranchInst>(Pred->getTerminator())) 6924 if (PBI != BI && PBI->isConditional()) 6925 if (SimplifyCondBranchToCondBranch(PBI, BI, DTU, DL, TTI)) 6926 return requestResimplify(); 6927 6928 // Look for diamond patterns. 6929 if (MergeCondStores) 6930 if (BasicBlock *PrevBB = allPredecessorsComeFromSameSource(BB)) 6931 if (BranchInst *PBI = dyn_cast<BranchInst>(PrevBB->getTerminator())) 6932 if (PBI != BI && PBI->isConditional()) 6933 if (mergeConditionalStores(PBI, BI, DTU, DL, TTI)) 6934 return requestResimplify(); 6935 6936 return false; 6937 } 6938 6939 /// Check if passing a value to an instruction will cause undefined behavior. 6940 static bool passingValueIsAlwaysUndefined(Value *V, Instruction *I, bool PtrValueMayBeModified) { 6941 Constant *C = dyn_cast<Constant>(V); 6942 if (!C) 6943 return false; 6944 6945 if (I->use_empty()) 6946 return false; 6947 6948 if (C->isNullValue() || isa<UndefValue>(C)) { 6949 // Only look at the first use, avoid hurting compile time with long uselists 6950 auto *Use = cast<Instruction>(*I->user_begin()); 6951 // Bail out if Use is not in the same BB as I or Use == I or Use comes 6952 // before I in the block. The latter two can be the case if Use is a PHI 6953 // node. 6954 if (Use->getParent() != I->getParent() || Use == I || Use->comesBefore(I)) 6955 return false; 6956 6957 // Now make sure that there are no instructions in between that can alter 6958 // control flow (eg. calls) 6959 auto InstrRange = 6960 make_range(std::next(I->getIterator()), Use->getIterator()); 6961 if (any_of(InstrRange, [](Instruction &I) { 6962 return !isGuaranteedToTransferExecutionToSuccessor(&I); 6963 })) 6964 return false; 6965 6966 // Look through GEPs. A load from a GEP derived from NULL is still undefined 6967 if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(Use)) 6968 if (GEP->getPointerOperand() == I) { 6969 if (!GEP->isInBounds() || !GEP->hasAllZeroIndices()) 6970 PtrValueMayBeModified = true; 6971 return passingValueIsAlwaysUndefined(V, GEP, PtrValueMayBeModified); 6972 } 6973 6974 // Look through bitcasts. 6975 if (BitCastInst *BC = dyn_cast<BitCastInst>(Use)) 6976 return passingValueIsAlwaysUndefined(V, BC, PtrValueMayBeModified); 6977 6978 // Load from null is undefined. 6979 if (LoadInst *LI = dyn_cast<LoadInst>(Use)) 6980 if (!LI->isVolatile()) 6981 return !NullPointerIsDefined(LI->getFunction(), 6982 LI->getPointerAddressSpace()); 6983 6984 // Store to null is undefined. 6985 if (StoreInst *SI = dyn_cast<StoreInst>(Use)) 6986 if (!SI->isVolatile()) 6987 return (!NullPointerIsDefined(SI->getFunction(), 6988 SI->getPointerAddressSpace())) && 6989 SI->getPointerOperand() == I; 6990 6991 if (auto *CB = dyn_cast<CallBase>(Use)) { 6992 if (C->isNullValue() && NullPointerIsDefined(CB->getFunction())) 6993 return false; 6994 // A call to null is undefined. 6995 if (CB->getCalledOperand() == I) 6996 return true; 6997 6998 if (C->isNullValue()) { 6999 for (const llvm::Use &Arg : CB->args()) 7000 if (Arg == I) { 7001 unsigned ArgIdx = CB->getArgOperandNo(&Arg); 7002 if (CB->isPassingUndefUB(ArgIdx) && 7003 CB->paramHasAttr(ArgIdx, Attribute::NonNull)) { 7004 // Passing null to a nonnnull+noundef argument is undefined. 7005 return !PtrValueMayBeModified; 7006 } 7007 } 7008 } else if (isa<UndefValue>(C)) { 7009 // Passing undef to a noundef argument is undefined. 7010 for (const llvm::Use &Arg : CB->args()) 7011 if (Arg == I) { 7012 unsigned ArgIdx = CB->getArgOperandNo(&Arg); 7013 if (CB->isPassingUndefUB(ArgIdx)) { 7014 // Passing undef to a noundef argument is undefined. 7015 return true; 7016 } 7017 } 7018 } 7019 } 7020 } 7021 return false; 7022 } 7023 7024 /// If BB has an incoming value that will always trigger undefined behavior 7025 /// (eg. null pointer dereference), remove the branch leading here. 7026 static bool removeUndefIntroducingPredecessor(BasicBlock *BB, 7027 DomTreeUpdater *DTU) { 7028 for (PHINode &PHI : BB->phis()) 7029 for (unsigned i = 0, e = PHI.getNumIncomingValues(); i != e; ++i) 7030 if (passingValueIsAlwaysUndefined(PHI.getIncomingValue(i), &PHI)) { 7031 BasicBlock *Predecessor = PHI.getIncomingBlock(i); 7032 Instruction *T = Predecessor->getTerminator(); 7033 IRBuilder<> Builder(T); 7034 if (BranchInst *BI = dyn_cast<BranchInst>(T)) { 7035 BB->removePredecessor(Predecessor); 7036 // Turn uncoditional branches into unreachables and remove the dead 7037 // destination from conditional branches. 7038 if (BI->isUnconditional()) 7039 Builder.CreateUnreachable(); 7040 else { 7041 // Preserve guarding condition in assume, because it might not be 7042 // inferrable from any dominating condition. 7043 Value *Cond = BI->getCondition(); 7044 if (BI->getSuccessor(0) == BB) 7045 Builder.CreateAssumption(Builder.CreateNot(Cond)); 7046 else 7047 Builder.CreateAssumption(Cond); 7048 Builder.CreateBr(BI->getSuccessor(0) == BB ? BI->getSuccessor(1) 7049 : BI->getSuccessor(0)); 7050 } 7051 BI->eraseFromParent(); 7052 if (DTU) 7053 DTU->applyUpdates({{DominatorTree::Delete, Predecessor, BB}}); 7054 return true; 7055 } else if (SwitchInst *SI = dyn_cast<SwitchInst>(T)) { 7056 // Redirect all branches leading to UB into 7057 // a newly created unreachable block. 7058 BasicBlock *Unreachable = BasicBlock::Create( 7059 Predecessor->getContext(), "unreachable", BB->getParent(), BB); 7060 Builder.SetInsertPoint(Unreachable); 7061 // The new block contains only one instruction: Unreachable 7062 Builder.CreateUnreachable(); 7063 for (auto &Case : SI->cases()) 7064 if (Case.getCaseSuccessor() == BB) { 7065 BB->removePredecessor(Predecessor); 7066 Case.setSuccessor(Unreachable); 7067 } 7068 if (SI->getDefaultDest() == BB) { 7069 BB->removePredecessor(Predecessor); 7070 SI->setDefaultDest(Unreachable); 7071 } 7072 7073 if (DTU) 7074 DTU->applyUpdates( 7075 { { DominatorTree::Insert, Predecessor, Unreachable }, 7076 { DominatorTree::Delete, Predecessor, BB } }); 7077 return true; 7078 } 7079 } 7080 7081 return false; 7082 } 7083 7084 bool SimplifyCFGOpt::simplifyOnce(BasicBlock *BB) { 7085 bool Changed = false; 7086 7087 assert(BB && BB->getParent() && "Block not embedded in function!"); 7088 assert(BB->getTerminator() && "Degenerate basic block encountered!"); 7089 7090 // Remove basic blocks that have no predecessors (except the entry block)... 7091 // or that just have themself as a predecessor. These are unreachable. 7092 if ((pred_empty(BB) && BB != &BB->getParent()->getEntryBlock()) || 7093 BB->getSinglePredecessor() == BB) { 7094 LLVM_DEBUG(dbgs() << "Removing BB: \n" << *BB); 7095 DeleteDeadBlock(BB, DTU); 7096 return true; 7097 } 7098 7099 // Check to see if we can constant propagate this terminator instruction 7100 // away... 7101 Changed |= ConstantFoldTerminator(BB, /*DeleteDeadConditions=*/true, 7102 /*TLI=*/nullptr, DTU); 7103 7104 // Check for and eliminate duplicate PHI nodes in this block. 7105 Changed |= EliminateDuplicatePHINodes(BB); 7106 7107 // Check for and remove branches that will always cause undefined behavior. 7108 if (removeUndefIntroducingPredecessor(BB, DTU)) 7109 return requestResimplify(); 7110 7111 // Merge basic blocks into their predecessor if there is only one distinct 7112 // pred, and if there is only one distinct successor of the predecessor, and 7113 // if there are no PHI nodes. 7114 if (MergeBlockIntoPredecessor(BB, DTU)) 7115 return true; 7116 7117 if (SinkCommon && Options.SinkCommonInsts) 7118 if (SinkCommonCodeFromPredecessors(BB, DTU) || 7119 MergeCompatibleInvokes(BB, DTU)) { 7120 // SinkCommonCodeFromPredecessors() does not automatically CSE PHI's, 7121 // so we may now how duplicate PHI's. 7122 // Let's rerun EliminateDuplicatePHINodes() first, 7123 // before FoldTwoEntryPHINode() potentially converts them into select's, 7124 // after which we'd need a whole EarlyCSE pass run to cleanup them. 7125 return true; 7126 } 7127 7128 IRBuilder<> Builder(BB); 7129 7130 if (Options.FoldTwoEntryPHINode) { 7131 // If there is a trivial two-entry PHI node in this basic block, and we can 7132 // eliminate it, do so now. 7133 if (auto *PN = dyn_cast<PHINode>(BB->begin())) 7134 if (PN->getNumIncomingValues() == 2) 7135 if (FoldTwoEntryPHINode(PN, TTI, DTU, DL)) 7136 return true; 7137 } 7138 7139 Instruction *Terminator = BB->getTerminator(); 7140 Builder.SetInsertPoint(Terminator); 7141 switch (Terminator->getOpcode()) { 7142 case Instruction::Br: 7143 Changed |= simplifyBranch(cast<BranchInst>(Terminator), Builder); 7144 break; 7145 case Instruction::Resume: 7146 Changed |= simplifyResume(cast<ResumeInst>(Terminator), Builder); 7147 break; 7148 case Instruction::CleanupRet: 7149 Changed |= simplifyCleanupReturn(cast<CleanupReturnInst>(Terminator)); 7150 break; 7151 case Instruction::Switch: 7152 Changed |= simplifySwitch(cast<SwitchInst>(Terminator), Builder); 7153 break; 7154 case Instruction::Unreachable: 7155 Changed |= simplifyUnreachable(cast<UnreachableInst>(Terminator)); 7156 break; 7157 case Instruction::IndirectBr: 7158 Changed |= simplifyIndirectBr(cast<IndirectBrInst>(Terminator)); 7159 break; 7160 } 7161 7162 return Changed; 7163 } 7164 7165 bool SimplifyCFGOpt::run(BasicBlock *BB) { 7166 bool Changed = false; 7167 7168 // Repeated simplify BB as long as resimplification is requested. 7169 do { 7170 Resimplify = false; 7171 7172 // Perform one round of simplifcation. Resimplify flag will be set if 7173 // another iteration is requested. 7174 Changed |= simplifyOnce(BB); 7175 } while (Resimplify); 7176 7177 return Changed; 7178 } 7179 7180 bool llvm::simplifyCFG(BasicBlock *BB, const TargetTransformInfo &TTI, 7181 DomTreeUpdater *DTU, const SimplifyCFGOptions &Options, 7182 ArrayRef<WeakVH> LoopHeaders) { 7183 return SimplifyCFGOpt(TTI, DTU, BB->getModule()->getDataLayout(), LoopHeaders, 7184 Options) 7185 .run(BB); 7186 } 7187