1 //===- Reassociate.cpp - Reassociate binary expressions -------------------===//
2 //
3 //                     The LLVM Compiler Infrastructure
4 //
5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details.
7 //
8 //===----------------------------------------------------------------------===//
9 //
10 // This pass reassociates commutative expressions in an order that is designed
11 // to promote better constant propagation, GCSE, LICM, PRE, etc.
12 //
13 // For example: 4 + (x + 5) -> x + (4 + 5)
14 //
15 // In the implementation of this algorithm, constants are assigned rank = 0,
16 // function arguments are rank = 1, and other values are assigned ranks
17 // corresponding to the reverse post order traversal of current function
18 // (starting at 2), which effectively gives values in deep loops higher rank
19 // than values not in loops.
20 //
21 //===----------------------------------------------------------------------===//
22 
23 #include "llvm/Transforms/Scalar/Reassociate.h"
24 #include "llvm/ADT/DenseMap.h"
25 #include "llvm/ADT/PostOrderIterator.h"
26 #include "llvm/ADT/STLExtras.h"
27 #include "llvm/ADT/SetVector.h"
28 #include "llvm/ADT/Statistic.h"
29 #include "llvm/Analysis/GlobalsModRef.h"
30 #include "llvm/Analysis/ValueTracking.h"
31 #include "llvm/IR/CFG.h"
32 #include "llvm/IR/Constants.h"
33 #include "llvm/IR/DerivedTypes.h"
34 #include "llvm/IR/Function.h"
35 #include "llvm/IR/IRBuilder.h"
36 #include "llvm/IR/Instructions.h"
37 #include "llvm/IR/IntrinsicInst.h"
38 #include "llvm/IR/ValueHandle.h"
39 #include "llvm/Pass.h"
40 #include "llvm/Support/Debug.h"
41 #include "llvm/Support/raw_ostream.h"
42 #include "llvm/Transforms/Scalar.h"
43 #include "llvm/Transforms/Utils/Local.h"
44 #include <algorithm>
45 using namespace llvm;
46 using namespace reassociate;
47 
48 #define DEBUG_TYPE "reassociate"
49 
50 STATISTIC(NumChanged, "Number of insts reassociated");
51 STATISTIC(NumAnnihil, "Number of expr tree annihilated");
52 STATISTIC(NumFactor , "Number of multiplies factored");
53 
54 #ifndef NDEBUG
55 /// Print out the expression identified in the Ops list.
56 ///
57 static void PrintOps(Instruction *I, const SmallVectorImpl<ValueEntry> &Ops) {
58   Module *M = I->getModule();
59   dbgs() << Instruction::getOpcodeName(I->getOpcode()) << " "
60        << *Ops[0].Op->getType() << '\t';
61   for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
62     dbgs() << "[ ";
63     Ops[i].Op->printAsOperand(dbgs(), false, M);
64     dbgs() << ", #" << Ops[i].Rank << "] ";
65   }
66 }
67 #endif
68 
69 /// Utility class representing a non-constant Xor-operand. We classify
70 /// non-constant Xor-Operands into two categories:
71 ///  C1) The operand is in the form "X & C", where C is a constant and C != ~0
72 ///  C2)
73 ///    C2.1) The operand is in the form of "X | C", where C is a non-zero
74 ///          constant.
75 ///    C2.2) Any operand E which doesn't fall into C1 and C2.1, we view this
76 ///          operand as "E | 0"
77 class llvm::reassociate::XorOpnd {
78 public:
79   XorOpnd(Value *V);
80 
81   bool isInvalid() const { return SymbolicPart == nullptr; }
82   bool isOrExpr() const { return isOr; }
83   Value *getValue() const { return OrigVal; }
84   Value *getSymbolicPart() const { return SymbolicPart; }
85   unsigned getSymbolicRank() const { return SymbolicRank; }
86   const APInt &getConstPart() const { return ConstPart; }
87 
88   void Invalidate() { SymbolicPart = OrigVal = nullptr; }
89   void setSymbolicRank(unsigned R) { SymbolicRank = R; }
90 
91 private:
92   Value *OrigVal;
93   Value *SymbolicPart;
94   APInt ConstPart;
95   unsigned SymbolicRank;
96   bool isOr;
97 };
98 
99 XorOpnd::XorOpnd(Value *V) {
100   assert(!isa<ConstantInt>(V) && "No ConstantInt");
101   OrigVal = V;
102   Instruction *I = dyn_cast<Instruction>(V);
103   SymbolicRank = 0;
104 
105   if (I && (I->getOpcode() == Instruction::Or ||
106             I->getOpcode() == Instruction::And)) {
107     Value *V0 = I->getOperand(0);
108     Value *V1 = I->getOperand(1);
109     if (isa<ConstantInt>(V0))
110       std::swap(V0, V1);
111 
112     if (ConstantInt *C = dyn_cast<ConstantInt>(V1)) {
113       ConstPart = C->getValue();
114       SymbolicPart = V0;
115       isOr = (I->getOpcode() == Instruction::Or);
116       return;
117     }
118   }
119 
120   // view the operand as "V | 0"
121   SymbolicPart = V;
122   ConstPart = APInt::getNullValue(V->getType()->getIntegerBitWidth());
123   isOr = true;
124 }
125 
126 /// Return true if V is an instruction of the specified opcode and if it
127 /// only has one use.
128 static BinaryOperator *isReassociableOp(Value *V, unsigned Opcode) {
129   if (V->hasOneUse() && isa<Instruction>(V) &&
130       cast<Instruction>(V)->getOpcode() == Opcode &&
131       (!isa<FPMathOperator>(V) ||
132        cast<Instruction>(V)->hasUnsafeAlgebra()))
133     return cast<BinaryOperator>(V);
134   return nullptr;
135 }
136 
137 static BinaryOperator *isReassociableOp(Value *V, unsigned Opcode1,
138                                         unsigned Opcode2) {
139   if (V->hasOneUse() && isa<Instruction>(V) &&
140       (cast<Instruction>(V)->getOpcode() == Opcode1 ||
141        cast<Instruction>(V)->getOpcode() == Opcode2) &&
142       (!isa<FPMathOperator>(V) ||
143        cast<Instruction>(V)->hasUnsafeAlgebra()))
144     return cast<BinaryOperator>(V);
145   return nullptr;
146 }
147 
148 void ReassociatePass::BuildRankMap(
149     Function &F, ReversePostOrderTraversal<Function *> &RPOT) {
150   unsigned i = 2;
151 
152   // Assign distinct ranks to function arguments.
153   for (Function::arg_iterator I = F.arg_begin(), E = F.arg_end(); I != E; ++I) {
154     ValueRankMap[&*I] = ++i;
155     DEBUG(dbgs() << "Calculated Rank[" << I->getName() << "] = " << i << "\n");
156   }
157 
158   for (ReversePostOrderTraversal<Function*>::rpo_iterator I = RPOT.begin(),
159          E = RPOT.end(); I != E; ++I) {
160     BasicBlock *BB = *I;
161     unsigned BBRank = RankMap[BB] = ++i << 16;
162 
163     // Walk the basic block, adding precomputed ranks for any instructions that
164     // we cannot move.  This ensures that the ranks for these instructions are
165     // all different in the block.
166     for (BasicBlock::iterator I = BB->begin(), E = BB->end(); I != E; ++I)
167       if (mayBeMemoryDependent(*I))
168         ValueRankMap[&*I] = ++BBRank;
169   }
170 }
171 
172 unsigned ReassociatePass::getRank(Value *V) {
173   Instruction *I = dyn_cast<Instruction>(V);
174   if (!I) {
175     if (isa<Argument>(V)) return ValueRankMap[V];   // Function argument.
176     return 0;  // Otherwise it's a global or constant, rank 0.
177   }
178 
179   if (unsigned Rank = ValueRankMap[I])
180     return Rank;    // Rank already known?
181 
182   // If this is an expression, return the 1+MAX(rank(LHS), rank(RHS)) so that
183   // we can reassociate expressions for code motion!  Since we do not recurse
184   // for PHI nodes, we cannot have infinite recursion here, because there
185   // cannot be loops in the value graph that do not go through PHI nodes.
186   unsigned Rank = 0, MaxRank = RankMap[I->getParent()];
187   for (unsigned i = 0, e = I->getNumOperands();
188        i != e && Rank != MaxRank; ++i)
189     Rank = std::max(Rank, getRank(I->getOperand(i)));
190 
191   // If this is a not or neg instruction, do not count it for rank.  This
192   // assures us that X and ~X will have the same rank.
193   if  (!BinaryOperator::isNot(I) && !BinaryOperator::isNeg(I) &&
194        !BinaryOperator::isFNeg(I))
195     ++Rank;
196 
197   DEBUG(dbgs() << "Calculated Rank[" << V->getName() << "] = " << Rank << "\n");
198 
199   return ValueRankMap[I] = Rank;
200 }
201 
202 // Canonicalize constants to RHS.  Otherwise, sort the operands by rank.
203 void ReassociatePass::canonicalizeOperands(Instruction *I) {
204   assert(isa<BinaryOperator>(I) && "Expected binary operator.");
205   assert(I->isCommutative() && "Expected commutative operator.");
206 
207   Value *LHS = I->getOperand(0);
208   Value *RHS = I->getOperand(1);
209   unsigned LHSRank = getRank(LHS);
210   unsigned RHSRank = getRank(RHS);
211 
212   if (isa<Constant>(RHS))
213     return;
214 
215   if (isa<Constant>(LHS) || RHSRank < LHSRank)
216     cast<BinaryOperator>(I)->swapOperands();
217 }
218 
219 static BinaryOperator *CreateAdd(Value *S1, Value *S2, const Twine &Name,
220                                  Instruction *InsertBefore, Value *FlagsOp) {
221   if (S1->getType()->isIntOrIntVectorTy())
222     return BinaryOperator::CreateAdd(S1, S2, Name, InsertBefore);
223   else {
224     BinaryOperator *Res =
225         BinaryOperator::CreateFAdd(S1, S2, Name, InsertBefore);
226     Res->setFastMathFlags(cast<FPMathOperator>(FlagsOp)->getFastMathFlags());
227     return Res;
228   }
229 }
230 
231 static BinaryOperator *CreateMul(Value *S1, Value *S2, const Twine &Name,
232                                  Instruction *InsertBefore, Value *FlagsOp) {
233   if (S1->getType()->isIntOrIntVectorTy())
234     return BinaryOperator::CreateMul(S1, S2, Name, InsertBefore);
235   else {
236     BinaryOperator *Res =
237       BinaryOperator::CreateFMul(S1, S2, Name, InsertBefore);
238     Res->setFastMathFlags(cast<FPMathOperator>(FlagsOp)->getFastMathFlags());
239     return Res;
240   }
241 }
242 
243 static BinaryOperator *CreateNeg(Value *S1, const Twine &Name,
244                                  Instruction *InsertBefore, Value *FlagsOp) {
245   if (S1->getType()->isIntOrIntVectorTy())
246     return BinaryOperator::CreateNeg(S1, Name, InsertBefore);
247   else {
248     BinaryOperator *Res = BinaryOperator::CreateFNeg(S1, Name, InsertBefore);
249     Res->setFastMathFlags(cast<FPMathOperator>(FlagsOp)->getFastMathFlags());
250     return Res;
251   }
252 }
253 
254 /// Replace 0-X with X*-1.
255 static BinaryOperator *LowerNegateToMultiply(Instruction *Neg) {
256   Type *Ty = Neg->getType();
257   Constant *NegOne = Ty->isIntOrIntVectorTy() ?
258     ConstantInt::getAllOnesValue(Ty) : ConstantFP::get(Ty, -1.0);
259 
260   BinaryOperator *Res = CreateMul(Neg->getOperand(1), NegOne, "", Neg, Neg);
261   Neg->setOperand(1, Constant::getNullValue(Ty)); // Drop use of op.
262   Res->takeName(Neg);
263   Neg->replaceAllUsesWith(Res);
264   Res->setDebugLoc(Neg->getDebugLoc());
265   return Res;
266 }
267 
268 /// Returns k such that lambda(2^Bitwidth) = 2^k, where lambda is the Carmichael
269 /// function. This means that x^(2^k) === 1 mod 2^Bitwidth for
270 /// every odd x, i.e. x^(2^k) = 1 for every odd x in Bitwidth-bit arithmetic.
271 /// Note that 0 <= k < Bitwidth, and if Bitwidth > 3 then x^(2^k) = 0 for every
272 /// even x in Bitwidth-bit arithmetic.
273 static unsigned CarmichaelShift(unsigned Bitwidth) {
274   if (Bitwidth < 3)
275     return Bitwidth - 1;
276   return Bitwidth - 2;
277 }
278 
279 /// Add the extra weight 'RHS' to the existing weight 'LHS',
280 /// reducing the combined weight using any special properties of the operation.
281 /// The existing weight LHS represents the computation X op X op ... op X where
282 /// X occurs LHS times.  The combined weight represents  X op X op ... op X with
283 /// X occurring LHS + RHS times.  If op is "Xor" for example then the combined
284 /// operation is equivalent to X if LHS + RHS is odd, or 0 if LHS + RHS is even;
285 /// the routine returns 1 in LHS in the first case, and 0 in LHS in the second.
286 static void IncorporateWeight(APInt &LHS, const APInt &RHS, unsigned Opcode) {
287   // If we were working with infinite precision arithmetic then the combined
288   // weight would be LHS + RHS.  But we are using finite precision arithmetic,
289   // and the APInt sum LHS + RHS may not be correct if it wraps (it is correct
290   // for nilpotent operations and addition, but not for idempotent operations
291   // and multiplication), so it is important to correctly reduce the combined
292   // weight back into range if wrapping would be wrong.
293 
294   // If RHS is zero then the weight didn't change.
295   if (RHS.isMinValue())
296     return;
297   // If LHS is zero then the combined weight is RHS.
298   if (LHS.isMinValue()) {
299     LHS = RHS;
300     return;
301   }
302   // From this point on we know that neither LHS nor RHS is zero.
303 
304   if (Instruction::isIdempotent(Opcode)) {
305     // Idempotent means X op X === X, so any non-zero weight is equivalent to a
306     // weight of 1.  Keeping weights at zero or one also means that wrapping is
307     // not a problem.
308     assert(LHS == 1 && RHS == 1 && "Weights not reduced!");
309     return; // Return a weight of 1.
310   }
311   if (Instruction::isNilpotent(Opcode)) {
312     // Nilpotent means X op X === 0, so reduce weights modulo 2.
313     assert(LHS == 1 && RHS == 1 && "Weights not reduced!");
314     LHS = 0; // 1 + 1 === 0 modulo 2.
315     return;
316   }
317   if (Opcode == Instruction::Add || Opcode == Instruction::FAdd) {
318     // TODO: Reduce the weight by exploiting nsw/nuw?
319     LHS += RHS;
320     return;
321   }
322 
323   assert((Opcode == Instruction::Mul || Opcode == Instruction::FMul) &&
324          "Unknown associative operation!");
325   unsigned Bitwidth = LHS.getBitWidth();
326   // If CM is the Carmichael number then a weight W satisfying W >= CM+Bitwidth
327   // can be replaced with W-CM.  That's because x^W=x^(W-CM) for every Bitwidth
328   // bit number x, since either x is odd in which case x^CM = 1, or x is even in
329   // which case both x^W and x^(W - CM) are zero.  By subtracting off multiples
330   // of CM like this weights can always be reduced to the range [0, CM+Bitwidth)
331   // which by a happy accident means that they can always be represented using
332   // Bitwidth bits.
333   // TODO: Reduce the weight by exploiting nsw/nuw?  (Could do much better than
334   // the Carmichael number).
335   if (Bitwidth > 3) {
336     /// CM - The value of Carmichael's lambda function.
337     APInt CM = APInt::getOneBitSet(Bitwidth, CarmichaelShift(Bitwidth));
338     // Any weight W >= Threshold can be replaced with W - CM.
339     APInt Threshold = CM + Bitwidth;
340     assert(LHS.ult(Threshold) && RHS.ult(Threshold) && "Weights not reduced!");
341     // For Bitwidth 4 or more the following sum does not overflow.
342     LHS += RHS;
343     while (LHS.uge(Threshold))
344       LHS -= CM;
345   } else {
346     // To avoid problems with overflow do everything the same as above but using
347     // a larger type.
348     unsigned CM = 1U << CarmichaelShift(Bitwidth);
349     unsigned Threshold = CM + Bitwidth;
350     assert(LHS.getZExtValue() < Threshold && RHS.getZExtValue() < Threshold &&
351            "Weights not reduced!");
352     unsigned Total = LHS.getZExtValue() + RHS.getZExtValue();
353     while (Total >= Threshold)
354       Total -= CM;
355     LHS = Total;
356   }
357 }
358 
359 typedef std::pair<Value*, APInt> RepeatedValue;
360 
361 /// Given an associative binary expression, return the leaf
362 /// nodes in Ops along with their weights (how many times the leaf occurs).  The
363 /// original expression is the same as
364 ///   (Ops[0].first op Ops[0].first op ... Ops[0].first)  <- Ops[0].second times
365 /// op
366 ///   (Ops[1].first op Ops[1].first op ... Ops[1].first)  <- Ops[1].second times
367 /// op
368 ///   ...
369 /// op
370 ///   (Ops[N].first op Ops[N].first op ... Ops[N].first)  <- Ops[N].second times
371 ///
372 /// Note that the values Ops[0].first, ..., Ops[N].first are all distinct.
373 ///
374 /// This routine may modify the function, in which case it returns 'true'.  The
375 /// changes it makes may well be destructive, changing the value computed by 'I'
376 /// to something completely different.  Thus if the routine returns 'true' then
377 /// you MUST either replace I with a new expression computed from the Ops array,
378 /// or use RewriteExprTree to put the values back in.
379 ///
380 /// A leaf node is either not a binary operation of the same kind as the root
381 /// node 'I' (i.e. is not a binary operator at all, or is, but with a different
382 /// opcode), or is the same kind of binary operator but has a use which either
383 /// does not belong to the expression, or does belong to the expression but is
384 /// a leaf node.  Every leaf node has at least one use that is a non-leaf node
385 /// of the expression, while for non-leaf nodes (except for the root 'I') every
386 /// use is a non-leaf node of the expression.
387 ///
388 /// For example:
389 ///           expression graph        node names
390 ///
391 ///                     +        |        I
392 ///                    / \       |
393 ///                   +   +      |      A,  B
394 ///                  / \ / \     |
395 ///                 *   +   *    |    C,  D,  E
396 ///                / \ / \ / \   |
397 ///                   +   *      |      F,  G
398 ///
399 /// The leaf nodes are C, E, F and G.  The Ops array will contain (maybe not in
400 /// that order) (C, 1), (E, 1), (F, 2), (G, 2).
401 ///
402 /// The expression is maximal: if some instruction is a binary operator of the
403 /// same kind as 'I', and all of its uses are non-leaf nodes of the expression,
404 /// then the instruction also belongs to the expression, is not a leaf node of
405 /// it, and its operands also belong to the expression (but may be leaf nodes).
406 ///
407 /// NOTE: This routine will set operands of non-leaf non-root nodes to undef in
408 /// order to ensure that every non-root node in the expression has *exactly one*
409 /// use by a non-leaf node of the expression.  This destruction means that the
410 /// caller MUST either replace 'I' with a new expression or use something like
411 /// RewriteExprTree to put the values back in if the routine indicates that it
412 /// made a change by returning 'true'.
413 ///
414 /// In the above example either the right operand of A or the left operand of B
415 /// will be replaced by undef.  If it is B's operand then this gives:
416 ///
417 ///                     +        |        I
418 ///                    / \       |
419 ///                   +   +      |      A,  B - operand of B replaced with undef
420 ///                  / \   \     |
421 ///                 *   +   *    |    C,  D,  E
422 ///                / \ / \ / \   |
423 ///                   +   *      |      F,  G
424 ///
425 /// Note that such undef operands can only be reached by passing through 'I'.
426 /// For example, if you visit operands recursively starting from a leaf node
427 /// then you will never see such an undef operand unless you get back to 'I',
428 /// which requires passing through a phi node.
429 ///
430 /// Note that this routine may also mutate binary operators of the wrong type
431 /// that have all uses inside the expression (i.e. only used by non-leaf nodes
432 /// of the expression) if it can turn them into binary operators of the right
433 /// type and thus make the expression bigger.
434 
435 static bool LinearizeExprTree(BinaryOperator *I,
436                               SmallVectorImpl<RepeatedValue> &Ops) {
437   DEBUG(dbgs() << "LINEARIZE: " << *I << '\n');
438   unsigned Bitwidth = I->getType()->getScalarType()->getPrimitiveSizeInBits();
439   unsigned Opcode = I->getOpcode();
440   assert(I->isAssociative() && I->isCommutative() &&
441          "Expected an associative and commutative operation!");
442 
443   // Visit all operands of the expression, keeping track of their weight (the
444   // number of paths from the expression root to the operand, or if you like
445   // the number of times that operand occurs in the linearized expression).
446   // For example, if I = X + A, where X = A + B, then I, X and B have weight 1
447   // while A has weight two.
448 
449   // Worklist of non-leaf nodes (their operands are in the expression too) along
450   // with their weights, representing a certain number of paths to the operator.
451   // If an operator occurs in the worklist multiple times then we found multiple
452   // ways to get to it.
453   SmallVector<std::pair<BinaryOperator*, APInt>, 8> Worklist; // (Op, Weight)
454   Worklist.push_back(std::make_pair(I, APInt(Bitwidth, 1)));
455   bool Changed = false;
456 
457   // Leaves of the expression are values that either aren't the right kind of
458   // operation (eg: a constant, or a multiply in an add tree), or are, but have
459   // some uses that are not inside the expression.  For example, in I = X + X,
460   // X = A + B, the value X has two uses (by I) that are in the expression.  If
461   // X has any other uses, for example in a return instruction, then we consider
462   // X to be a leaf, and won't analyze it further.  When we first visit a value,
463   // if it has more than one use then at first we conservatively consider it to
464   // be a leaf.  Later, as the expression is explored, we may discover some more
465   // uses of the value from inside the expression.  If all uses turn out to be
466   // from within the expression (and the value is a binary operator of the right
467   // kind) then the value is no longer considered to be a leaf, and its operands
468   // are explored.
469 
470   // Leaves - Keeps track of the set of putative leaves as well as the number of
471   // paths to each leaf seen so far.
472   typedef DenseMap<Value*, APInt> LeafMap;
473   LeafMap Leaves; // Leaf -> Total weight so far.
474   SmallVector<Value*, 8> LeafOrder; // Ensure deterministic leaf output order.
475 
476 #ifndef NDEBUG
477   SmallPtrSet<Value*, 8> Visited; // For sanity checking the iteration scheme.
478 #endif
479   while (!Worklist.empty()) {
480     std::pair<BinaryOperator*, APInt> P = Worklist.pop_back_val();
481     I = P.first; // We examine the operands of this binary operator.
482 
483     for (unsigned OpIdx = 0; OpIdx < 2; ++OpIdx) { // Visit operands.
484       Value *Op = I->getOperand(OpIdx);
485       APInt Weight = P.second; // Number of paths to this operand.
486       DEBUG(dbgs() << "OPERAND: " << *Op << " (" << Weight << ")\n");
487       assert(!Op->use_empty() && "No uses, so how did we get to it?!");
488 
489       // If this is a binary operation of the right kind with only one use then
490       // add its operands to the expression.
491       if (BinaryOperator *BO = isReassociableOp(Op, Opcode)) {
492         assert(Visited.insert(Op).second && "Not first visit!");
493         DEBUG(dbgs() << "DIRECT ADD: " << *Op << " (" << Weight << ")\n");
494         Worklist.push_back(std::make_pair(BO, Weight));
495         continue;
496       }
497 
498       // Appears to be a leaf.  Is the operand already in the set of leaves?
499       LeafMap::iterator It = Leaves.find(Op);
500       if (It == Leaves.end()) {
501         // Not in the leaf map.  Must be the first time we saw this operand.
502         assert(Visited.insert(Op).second && "Not first visit!");
503         if (!Op->hasOneUse()) {
504           // This value has uses not accounted for by the expression, so it is
505           // not safe to modify.  Mark it as being a leaf.
506           DEBUG(dbgs() << "ADD USES LEAF: " << *Op << " (" << Weight << ")\n");
507           LeafOrder.push_back(Op);
508           Leaves[Op] = Weight;
509           continue;
510         }
511         // No uses outside the expression, try morphing it.
512       } else if (It != Leaves.end()) {
513         // Already in the leaf map.
514         assert(Visited.count(Op) && "In leaf map but not visited!");
515 
516         // Update the number of paths to the leaf.
517         IncorporateWeight(It->second, Weight, Opcode);
518 
519 #if 0   // TODO: Re-enable once PR13021 is fixed.
520         // The leaf already has one use from inside the expression.  As we want
521         // exactly one such use, drop this new use of the leaf.
522         assert(!Op->hasOneUse() && "Only one use, but we got here twice!");
523         I->setOperand(OpIdx, UndefValue::get(I->getType()));
524         Changed = true;
525 
526         // If the leaf is a binary operation of the right kind and we now see
527         // that its multiple original uses were in fact all by nodes belonging
528         // to the expression, then no longer consider it to be a leaf and add
529         // its operands to the expression.
530         if (BinaryOperator *BO = isReassociableOp(Op, Opcode)) {
531           DEBUG(dbgs() << "UNLEAF: " << *Op << " (" << It->second << ")\n");
532           Worklist.push_back(std::make_pair(BO, It->second));
533           Leaves.erase(It);
534           continue;
535         }
536 #endif
537 
538         // If we still have uses that are not accounted for by the expression
539         // then it is not safe to modify the value.
540         if (!Op->hasOneUse())
541           continue;
542 
543         // No uses outside the expression, try morphing it.
544         Weight = It->second;
545         Leaves.erase(It); // Since the value may be morphed below.
546       }
547 
548       // At this point we have a value which, first of all, is not a binary
549       // expression of the right kind, and secondly, is only used inside the
550       // expression.  This means that it can safely be modified.  See if we
551       // can usefully morph it into an expression of the right kind.
552       assert((!isa<Instruction>(Op) ||
553               cast<Instruction>(Op)->getOpcode() != Opcode
554               || (isa<FPMathOperator>(Op) &&
555                   !cast<Instruction>(Op)->hasUnsafeAlgebra())) &&
556              "Should have been handled above!");
557       assert(Op->hasOneUse() && "Has uses outside the expression tree!");
558 
559       // If this is a multiply expression, turn any internal negations into
560       // multiplies by -1 so they can be reassociated.
561       if (BinaryOperator *BO = dyn_cast<BinaryOperator>(Op))
562         if ((Opcode == Instruction::Mul && BinaryOperator::isNeg(BO)) ||
563             (Opcode == Instruction::FMul && BinaryOperator::isFNeg(BO))) {
564           DEBUG(dbgs() << "MORPH LEAF: " << *Op << " (" << Weight << ") TO ");
565           BO = LowerNegateToMultiply(BO);
566           DEBUG(dbgs() << *BO << '\n');
567           Worklist.push_back(std::make_pair(BO, Weight));
568           Changed = true;
569           continue;
570         }
571 
572       // Failed to morph into an expression of the right type.  This really is
573       // a leaf.
574       DEBUG(dbgs() << "ADD LEAF: " << *Op << " (" << Weight << ")\n");
575       assert(!isReassociableOp(Op, Opcode) && "Value was morphed?");
576       LeafOrder.push_back(Op);
577       Leaves[Op] = Weight;
578     }
579   }
580 
581   // The leaves, repeated according to their weights, represent the linearized
582   // form of the expression.
583   for (unsigned i = 0, e = LeafOrder.size(); i != e; ++i) {
584     Value *V = LeafOrder[i];
585     LeafMap::iterator It = Leaves.find(V);
586     if (It == Leaves.end())
587       // Node initially thought to be a leaf wasn't.
588       continue;
589     assert(!isReassociableOp(V, Opcode) && "Shouldn't be a leaf!");
590     APInt Weight = It->second;
591     if (Weight.isMinValue())
592       // Leaf already output or weight reduction eliminated it.
593       continue;
594     // Ensure the leaf is only output once.
595     It->second = 0;
596     Ops.push_back(std::make_pair(V, Weight));
597   }
598 
599   // For nilpotent operations or addition there may be no operands, for example
600   // because the expression was "X xor X" or consisted of 2^Bitwidth additions:
601   // in both cases the weight reduces to 0 causing the value to be skipped.
602   if (Ops.empty()) {
603     Constant *Identity = ConstantExpr::getBinOpIdentity(Opcode, I->getType());
604     assert(Identity && "Associative operation without identity!");
605     Ops.emplace_back(Identity, APInt(Bitwidth, 1));
606   }
607 
608   return Changed;
609 }
610 
611 /// Now that the operands for this expression tree are
612 /// linearized and optimized, emit them in-order.
613 void ReassociatePass::RewriteExprTree(BinaryOperator *I,
614                                       SmallVectorImpl<ValueEntry> &Ops) {
615   assert(Ops.size() > 1 && "Single values should be used directly!");
616 
617   // Since our optimizations should never increase the number of operations, the
618   // new expression can usually be written reusing the existing binary operators
619   // from the original expression tree, without creating any new instructions,
620   // though the rewritten expression may have a completely different topology.
621   // We take care to not change anything if the new expression will be the same
622   // as the original.  If more than trivial changes (like commuting operands)
623   // were made then we are obliged to clear out any optional subclass data like
624   // nsw flags.
625 
626   /// NodesToRewrite - Nodes from the original expression available for writing
627   /// the new expression into.
628   SmallVector<BinaryOperator*, 8> NodesToRewrite;
629   unsigned Opcode = I->getOpcode();
630   BinaryOperator *Op = I;
631 
632   /// NotRewritable - The operands being written will be the leaves of the new
633   /// expression and must not be used as inner nodes (via NodesToRewrite) by
634   /// mistake.  Inner nodes are always reassociable, and usually leaves are not
635   /// (if they were they would have been incorporated into the expression and so
636   /// would not be leaves), so most of the time there is no danger of this.  But
637   /// in rare cases a leaf may become reassociable if an optimization kills uses
638   /// of it, or it may momentarily become reassociable during rewriting (below)
639   /// due it being removed as an operand of one of its uses.  Ensure that misuse
640   /// of leaf nodes as inner nodes cannot occur by remembering all of the future
641   /// leaves and refusing to reuse any of them as inner nodes.
642   SmallPtrSet<Value*, 8> NotRewritable;
643   for (unsigned i = 0, e = Ops.size(); i != e; ++i)
644     NotRewritable.insert(Ops[i].Op);
645 
646   // ExpressionChanged - Non-null if the rewritten expression differs from the
647   // original in some non-trivial way, requiring the clearing of optional flags.
648   // Flags are cleared from the operator in ExpressionChanged up to I inclusive.
649   BinaryOperator *ExpressionChanged = nullptr;
650   for (unsigned i = 0; ; ++i) {
651     // The last operation (which comes earliest in the IR) is special as both
652     // operands will come from Ops, rather than just one with the other being
653     // a subexpression.
654     if (i+2 == Ops.size()) {
655       Value *NewLHS = Ops[i].Op;
656       Value *NewRHS = Ops[i+1].Op;
657       Value *OldLHS = Op->getOperand(0);
658       Value *OldRHS = Op->getOperand(1);
659 
660       if (NewLHS == OldLHS && NewRHS == OldRHS)
661         // Nothing changed, leave it alone.
662         break;
663 
664       if (NewLHS == OldRHS && NewRHS == OldLHS) {
665         // The order of the operands was reversed.  Swap them.
666         DEBUG(dbgs() << "RA: " << *Op << '\n');
667         Op->swapOperands();
668         DEBUG(dbgs() << "TO: " << *Op << '\n');
669         MadeChange = true;
670         ++NumChanged;
671         break;
672       }
673 
674       // The new operation differs non-trivially from the original. Overwrite
675       // the old operands with the new ones.
676       DEBUG(dbgs() << "RA: " << *Op << '\n');
677       if (NewLHS != OldLHS) {
678         BinaryOperator *BO = isReassociableOp(OldLHS, Opcode);
679         if (BO && !NotRewritable.count(BO))
680           NodesToRewrite.push_back(BO);
681         Op->setOperand(0, NewLHS);
682       }
683       if (NewRHS != OldRHS) {
684         BinaryOperator *BO = isReassociableOp(OldRHS, Opcode);
685         if (BO && !NotRewritable.count(BO))
686           NodesToRewrite.push_back(BO);
687         Op->setOperand(1, NewRHS);
688       }
689       DEBUG(dbgs() << "TO: " << *Op << '\n');
690 
691       ExpressionChanged = Op;
692       MadeChange = true;
693       ++NumChanged;
694 
695       break;
696     }
697 
698     // Not the last operation.  The left-hand side will be a sub-expression
699     // while the right-hand side will be the current element of Ops.
700     Value *NewRHS = Ops[i].Op;
701     if (NewRHS != Op->getOperand(1)) {
702       DEBUG(dbgs() << "RA: " << *Op << '\n');
703       if (NewRHS == Op->getOperand(0)) {
704         // The new right-hand side was already present as the left operand.  If
705         // we are lucky then swapping the operands will sort out both of them.
706         Op->swapOperands();
707       } else {
708         // Overwrite with the new right-hand side.
709         BinaryOperator *BO = isReassociableOp(Op->getOperand(1), Opcode);
710         if (BO && !NotRewritable.count(BO))
711           NodesToRewrite.push_back(BO);
712         Op->setOperand(1, NewRHS);
713         ExpressionChanged = Op;
714       }
715       DEBUG(dbgs() << "TO: " << *Op << '\n');
716       MadeChange = true;
717       ++NumChanged;
718     }
719 
720     // Now deal with the left-hand side.  If this is already an operation node
721     // from the original expression then just rewrite the rest of the expression
722     // into it.
723     BinaryOperator *BO = isReassociableOp(Op->getOperand(0), Opcode);
724     if (BO && !NotRewritable.count(BO)) {
725       Op = BO;
726       continue;
727     }
728 
729     // Otherwise, grab a spare node from the original expression and use that as
730     // the left-hand side.  If there are no nodes left then the optimizers made
731     // an expression with more nodes than the original!  This usually means that
732     // they did something stupid but it might mean that the problem was just too
733     // hard (finding the mimimal number of multiplications needed to realize a
734     // multiplication expression is NP-complete).  Whatever the reason, smart or
735     // stupid, create a new node if there are none left.
736     BinaryOperator *NewOp;
737     if (NodesToRewrite.empty()) {
738       Constant *Undef = UndefValue::get(I->getType());
739       NewOp = BinaryOperator::Create(Instruction::BinaryOps(Opcode),
740                                      Undef, Undef, "", I);
741       if (NewOp->getType()->isFPOrFPVectorTy())
742         NewOp->setFastMathFlags(I->getFastMathFlags());
743     } else {
744       NewOp = NodesToRewrite.pop_back_val();
745     }
746 
747     DEBUG(dbgs() << "RA: " << *Op << '\n');
748     Op->setOperand(0, NewOp);
749     DEBUG(dbgs() << "TO: " << *Op << '\n');
750     ExpressionChanged = Op;
751     MadeChange = true;
752     ++NumChanged;
753     Op = NewOp;
754   }
755 
756   // If the expression changed non-trivially then clear out all subclass data
757   // starting from the operator specified in ExpressionChanged, and compactify
758   // the operators to just before the expression root to guarantee that the
759   // expression tree is dominated by all of Ops.
760   if (ExpressionChanged)
761     do {
762       // Preserve FastMathFlags.
763       if (isa<FPMathOperator>(I)) {
764         FastMathFlags Flags = I->getFastMathFlags();
765         ExpressionChanged->clearSubclassOptionalData();
766         ExpressionChanged->setFastMathFlags(Flags);
767       } else
768         ExpressionChanged->clearSubclassOptionalData();
769 
770       if (ExpressionChanged == I)
771         break;
772       ExpressionChanged->moveBefore(I);
773       ExpressionChanged = cast<BinaryOperator>(*ExpressionChanged->user_begin());
774     } while (1);
775 
776   // Throw away any left over nodes from the original expression.
777   for (unsigned i = 0, e = NodesToRewrite.size(); i != e; ++i)
778     RedoInsts.insert(NodesToRewrite[i]);
779 }
780 
781 /// Insert instructions before the instruction pointed to by BI,
782 /// that computes the negative version of the value specified.  The negative
783 /// version of the value is returned, and BI is left pointing at the instruction
784 /// that should be processed next by the reassociation pass.
785 /// Also add intermediate instructions to the redo list that are modified while
786 /// pushing the negates through adds.  These will be revisited to see if
787 /// additional opportunities have been exposed.
788 static Value *NegateValue(Value *V, Instruction *BI,
789                           SetVector<AssertingVH<Instruction>> &ToRedo) {
790   if (Constant *C = dyn_cast<Constant>(V)) {
791     if (C->getType()->isFPOrFPVectorTy()) {
792       return ConstantExpr::getFNeg(C);
793     }
794     return ConstantExpr::getNeg(C);
795   }
796 
797 
798   // We are trying to expose opportunity for reassociation.  One of the things
799   // that we want to do to achieve this is to push a negation as deep into an
800   // expression chain as possible, to expose the add instructions.  In practice,
801   // this means that we turn this:
802   //   X = -(A+12+C+D)   into    X = -A + -12 + -C + -D = -12 + -A + -C + -D
803   // so that later, a: Y = 12+X could get reassociated with the -12 to eliminate
804   // the constants.  We assume that instcombine will clean up the mess later if
805   // we introduce tons of unnecessary negation instructions.
806   //
807   if (BinaryOperator *I =
808           isReassociableOp(V, Instruction::Add, Instruction::FAdd)) {
809     // Push the negates through the add.
810     I->setOperand(0, NegateValue(I->getOperand(0), BI, ToRedo));
811     I->setOperand(1, NegateValue(I->getOperand(1), BI, ToRedo));
812     if (I->getOpcode() == Instruction::Add) {
813       I->setHasNoUnsignedWrap(false);
814       I->setHasNoSignedWrap(false);
815     }
816 
817     // We must move the add instruction here, because the neg instructions do
818     // not dominate the old add instruction in general.  By moving it, we are
819     // assured that the neg instructions we just inserted dominate the
820     // instruction we are about to insert after them.
821     //
822     I->moveBefore(BI);
823     I->setName(I->getName()+".neg");
824 
825     // Add the intermediate negates to the redo list as processing them later
826     // could expose more reassociating opportunities.
827     ToRedo.insert(I);
828     return I;
829   }
830 
831   // Okay, we need to materialize a negated version of V with an instruction.
832   // Scan the use lists of V to see if we have one already.
833   for (User *U : V->users()) {
834     if (!BinaryOperator::isNeg(U) && !BinaryOperator::isFNeg(U))
835       continue;
836 
837     // We found one!  Now we have to make sure that the definition dominates
838     // this use.  We do this by moving it to the entry block (if it is a
839     // non-instruction value) or right after the definition.  These negates will
840     // be zapped by reassociate later, so we don't need much finesse here.
841     BinaryOperator *TheNeg = cast<BinaryOperator>(U);
842 
843     // Verify that the negate is in this function, V might be a constant expr.
844     if (TheNeg->getParent()->getParent() != BI->getParent()->getParent())
845       continue;
846 
847     BasicBlock::iterator InsertPt;
848     if (Instruction *InstInput = dyn_cast<Instruction>(V)) {
849       if (InvokeInst *II = dyn_cast<InvokeInst>(InstInput)) {
850         InsertPt = II->getNormalDest()->begin();
851       } else {
852         InsertPt = ++InstInput->getIterator();
853       }
854       while (isa<PHINode>(InsertPt)) ++InsertPt;
855     } else {
856       InsertPt = TheNeg->getParent()->getParent()->getEntryBlock().begin();
857     }
858     TheNeg->moveBefore(&*InsertPt);
859     if (TheNeg->getOpcode() == Instruction::Sub) {
860       TheNeg->setHasNoUnsignedWrap(false);
861       TheNeg->setHasNoSignedWrap(false);
862     } else {
863       TheNeg->andIRFlags(BI);
864     }
865     ToRedo.insert(TheNeg);
866     return TheNeg;
867   }
868 
869   // Insert a 'neg' instruction that subtracts the value from zero to get the
870   // negation.
871   BinaryOperator *NewNeg = CreateNeg(V, V->getName() + ".neg", BI, BI);
872   ToRedo.insert(NewNeg);
873   return NewNeg;
874 }
875 
876 /// Return true if we should break up this subtract of X-Y into (X + -Y).
877 static bool ShouldBreakUpSubtract(Instruction *Sub) {
878   // If this is a negation, we can't split it up!
879   if (BinaryOperator::isNeg(Sub) || BinaryOperator::isFNeg(Sub))
880     return false;
881 
882   // Don't breakup X - undef.
883   if (isa<UndefValue>(Sub->getOperand(1)))
884     return false;
885 
886   // Don't bother to break this up unless either the LHS is an associable add or
887   // subtract or if this is only used by one.
888   Value *V0 = Sub->getOperand(0);
889   if (isReassociableOp(V0, Instruction::Add, Instruction::FAdd) ||
890       isReassociableOp(V0, Instruction::Sub, Instruction::FSub))
891     return true;
892   Value *V1 = Sub->getOperand(1);
893   if (isReassociableOp(V1, Instruction::Add, Instruction::FAdd) ||
894       isReassociableOp(V1, Instruction::Sub, Instruction::FSub))
895     return true;
896   Value *VB = Sub->user_back();
897   if (Sub->hasOneUse() &&
898       (isReassociableOp(VB, Instruction::Add, Instruction::FAdd) ||
899        isReassociableOp(VB, Instruction::Sub, Instruction::FSub)))
900     return true;
901 
902   return false;
903 }
904 
905 /// If we have (X-Y), and if either X is an add, or if this is only used by an
906 /// add, transform this into (X+(0-Y)) to promote better reassociation.
907 static BinaryOperator *
908 BreakUpSubtract(Instruction *Sub, SetVector<AssertingVH<Instruction>> &ToRedo) {
909   // Convert a subtract into an add and a neg instruction. This allows sub
910   // instructions to be commuted with other add instructions.
911   //
912   // Calculate the negative value of Operand 1 of the sub instruction,
913   // and set it as the RHS of the add instruction we just made.
914   //
915   Value *NegVal = NegateValue(Sub->getOperand(1), Sub, ToRedo);
916   BinaryOperator *New = CreateAdd(Sub->getOperand(0), NegVal, "", Sub, Sub);
917   Sub->setOperand(0, Constant::getNullValue(Sub->getType())); // Drop use of op.
918   Sub->setOperand(1, Constant::getNullValue(Sub->getType())); // Drop use of op.
919   New->takeName(Sub);
920 
921   // Everyone now refers to the add instruction.
922   Sub->replaceAllUsesWith(New);
923   New->setDebugLoc(Sub->getDebugLoc());
924 
925   DEBUG(dbgs() << "Negated: " << *New << '\n');
926   return New;
927 }
928 
929 /// If this is a shift of a reassociable multiply or is used by one, change
930 /// this into a multiply by a constant to assist with further reassociation.
931 static BinaryOperator *ConvertShiftToMul(Instruction *Shl) {
932   Constant *MulCst = ConstantInt::get(Shl->getType(), 1);
933   MulCst = ConstantExpr::getShl(MulCst, cast<Constant>(Shl->getOperand(1)));
934 
935   BinaryOperator *Mul =
936     BinaryOperator::CreateMul(Shl->getOperand(0), MulCst, "", Shl);
937   Shl->setOperand(0, UndefValue::get(Shl->getType())); // Drop use of op.
938   Mul->takeName(Shl);
939 
940   // Everyone now refers to the mul instruction.
941   Shl->replaceAllUsesWith(Mul);
942   Mul->setDebugLoc(Shl->getDebugLoc());
943 
944   // We can safely preserve the nuw flag in all cases.  It's also safe to turn a
945   // nuw nsw shl into a nuw nsw mul.  However, nsw in isolation requires special
946   // handling.
947   bool NSW = cast<BinaryOperator>(Shl)->hasNoSignedWrap();
948   bool NUW = cast<BinaryOperator>(Shl)->hasNoUnsignedWrap();
949   if (NSW && NUW)
950     Mul->setHasNoSignedWrap(true);
951   Mul->setHasNoUnsignedWrap(NUW);
952   return Mul;
953 }
954 
955 /// Scan backwards and forwards among values with the same rank as element i
956 /// to see if X exists.  If X does not exist, return i.  This is useful when
957 /// scanning for 'x' when we see '-x' because they both get the same rank.
958 static unsigned FindInOperandList(SmallVectorImpl<ValueEntry> &Ops, unsigned i,
959                                   Value *X) {
960   unsigned XRank = Ops[i].Rank;
961   unsigned e = Ops.size();
962   for (unsigned j = i+1; j != e && Ops[j].Rank == XRank; ++j) {
963     if (Ops[j].Op == X)
964       return j;
965     if (Instruction *I1 = dyn_cast<Instruction>(Ops[j].Op))
966       if (Instruction *I2 = dyn_cast<Instruction>(X))
967         if (I1->isIdenticalTo(I2))
968           return j;
969   }
970   // Scan backwards.
971   for (unsigned j = i-1; j != ~0U && Ops[j].Rank == XRank; --j) {
972     if (Ops[j].Op == X)
973       return j;
974     if (Instruction *I1 = dyn_cast<Instruction>(Ops[j].Op))
975       if (Instruction *I2 = dyn_cast<Instruction>(X))
976         if (I1->isIdenticalTo(I2))
977           return j;
978   }
979   return i;
980 }
981 
982 /// Emit a tree of add instructions, summing Ops together
983 /// and returning the result.  Insert the tree before I.
984 static Value *EmitAddTreeOfValues(Instruction *I,
985                                   SmallVectorImpl<WeakVH> &Ops){
986   if (Ops.size() == 1) return Ops.back();
987 
988   Value *V1 = Ops.back();
989   Ops.pop_back();
990   Value *V2 = EmitAddTreeOfValues(I, Ops);
991   return CreateAdd(V2, V1, "tmp", I, I);
992 }
993 
994 /// If V is an expression tree that is a multiplication sequence,
995 /// and if this sequence contains a multiply by Factor,
996 /// remove Factor from the tree and return the new tree.
997 Value *ReassociatePass::RemoveFactorFromExpression(Value *V, Value *Factor) {
998   BinaryOperator *BO = isReassociableOp(V, Instruction::Mul, Instruction::FMul);
999   if (!BO)
1000     return nullptr;
1001 
1002   SmallVector<RepeatedValue, 8> Tree;
1003   MadeChange |= LinearizeExprTree(BO, Tree);
1004   SmallVector<ValueEntry, 8> Factors;
1005   Factors.reserve(Tree.size());
1006   for (unsigned i = 0, e = Tree.size(); i != e; ++i) {
1007     RepeatedValue E = Tree[i];
1008     Factors.append(E.second.getZExtValue(),
1009                    ValueEntry(getRank(E.first), E.first));
1010   }
1011 
1012   bool FoundFactor = false;
1013   bool NeedsNegate = false;
1014   for (unsigned i = 0, e = Factors.size(); i != e; ++i) {
1015     if (Factors[i].Op == Factor) {
1016       FoundFactor = true;
1017       Factors.erase(Factors.begin()+i);
1018       break;
1019     }
1020 
1021     // If this is a negative version of this factor, remove it.
1022     if (ConstantInt *FC1 = dyn_cast<ConstantInt>(Factor)) {
1023       if (ConstantInt *FC2 = dyn_cast<ConstantInt>(Factors[i].Op))
1024         if (FC1->getValue() == -FC2->getValue()) {
1025           FoundFactor = NeedsNegate = true;
1026           Factors.erase(Factors.begin()+i);
1027           break;
1028         }
1029     } else if (ConstantFP *FC1 = dyn_cast<ConstantFP>(Factor)) {
1030       if (ConstantFP *FC2 = dyn_cast<ConstantFP>(Factors[i].Op)) {
1031         APFloat F1(FC1->getValueAPF());
1032         APFloat F2(FC2->getValueAPF());
1033         F2.changeSign();
1034         if (F1.compare(F2) == APFloat::cmpEqual) {
1035           FoundFactor = NeedsNegate = true;
1036           Factors.erase(Factors.begin() + i);
1037           break;
1038         }
1039       }
1040     }
1041   }
1042 
1043   if (!FoundFactor) {
1044     // Make sure to restore the operands to the expression tree.
1045     RewriteExprTree(BO, Factors);
1046     return nullptr;
1047   }
1048 
1049   BasicBlock::iterator InsertPt = ++BO->getIterator();
1050 
1051   // If this was just a single multiply, remove the multiply and return the only
1052   // remaining operand.
1053   if (Factors.size() == 1) {
1054     RedoInsts.insert(BO);
1055     V = Factors[0].Op;
1056   } else {
1057     RewriteExprTree(BO, Factors);
1058     V = BO;
1059   }
1060 
1061   if (NeedsNegate)
1062     V = CreateNeg(V, "neg", &*InsertPt, BO);
1063 
1064   return V;
1065 }
1066 
1067 /// If V is a single-use multiply, recursively add its operands as factors,
1068 /// otherwise add V to the list of factors.
1069 ///
1070 /// Ops is the top-level list of add operands we're trying to factor.
1071 static void FindSingleUseMultiplyFactors(Value *V,
1072                                          SmallVectorImpl<Value*> &Factors,
1073                                        const SmallVectorImpl<ValueEntry> &Ops) {
1074   BinaryOperator *BO = isReassociableOp(V, Instruction::Mul, Instruction::FMul);
1075   if (!BO) {
1076     Factors.push_back(V);
1077     return;
1078   }
1079 
1080   // Otherwise, add the LHS and RHS to the list of factors.
1081   FindSingleUseMultiplyFactors(BO->getOperand(1), Factors, Ops);
1082   FindSingleUseMultiplyFactors(BO->getOperand(0), Factors, Ops);
1083 }
1084 
1085 /// Optimize a series of operands to an 'and', 'or', or 'xor' instruction.
1086 /// This optimizes based on identities.  If it can be reduced to a single Value,
1087 /// it is returned, otherwise the Ops list is mutated as necessary.
1088 static Value *OptimizeAndOrXor(unsigned Opcode,
1089                                SmallVectorImpl<ValueEntry> &Ops) {
1090   // Scan the operand lists looking for X and ~X pairs, along with X,X pairs.
1091   // If we find any, we can simplify the expression. X&~X == 0, X|~X == -1.
1092   for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
1093     // First, check for X and ~X in the operand list.
1094     assert(i < Ops.size());
1095     if (BinaryOperator::isNot(Ops[i].Op)) {    // Cannot occur for ^.
1096       Value *X = BinaryOperator::getNotArgument(Ops[i].Op);
1097       unsigned FoundX = FindInOperandList(Ops, i, X);
1098       if (FoundX != i) {
1099         if (Opcode == Instruction::And)   // ...&X&~X = 0
1100           return Constant::getNullValue(X->getType());
1101 
1102         if (Opcode == Instruction::Or)    // ...|X|~X = -1
1103           return Constant::getAllOnesValue(X->getType());
1104       }
1105     }
1106 
1107     // Next, check for duplicate pairs of values, which we assume are next to
1108     // each other, due to our sorting criteria.
1109     assert(i < Ops.size());
1110     if (i+1 != Ops.size() && Ops[i+1].Op == Ops[i].Op) {
1111       if (Opcode == Instruction::And || Opcode == Instruction::Or) {
1112         // Drop duplicate values for And and Or.
1113         Ops.erase(Ops.begin()+i);
1114         --i; --e;
1115         ++NumAnnihil;
1116         continue;
1117       }
1118 
1119       // Drop pairs of values for Xor.
1120       assert(Opcode == Instruction::Xor);
1121       if (e == 2)
1122         return Constant::getNullValue(Ops[0].Op->getType());
1123 
1124       // Y ^ X^X -> Y
1125       Ops.erase(Ops.begin()+i, Ops.begin()+i+2);
1126       i -= 1; e -= 2;
1127       ++NumAnnihil;
1128     }
1129   }
1130   return nullptr;
1131 }
1132 
1133 /// Helper function of CombineXorOpnd(). It creates a bitwise-and
1134 /// instruction with the given two operands, and return the resulting
1135 /// instruction. There are two special cases: 1) if the constant operand is 0,
1136 /// it will return NULL. 2) if the constant is ~0, the symbolic operand will
1137 /// be returned.
1138 static Value *createAndInstr(Instruction *InsertBefore, Value *Opnd,
1139                              const APInt &ConstOpnd) {
1140   if (ConstOpnd != 0) {
1141     if (!ConstOpnd.isAllOnesValue()) {
1142       LLVMContext &Ctx = Opnd->getType()->getContext();
1143       Instruction *I;
1144       I = BinaryOperator::CreateAnd(Opnd, ConstantInt::get(Ctx, ConstOpnd),
1145                                     "and.ra", InsertBefore);
1146       I->setDebugLoc(InsertBefore->getDebugLoc());
1147       return I;
1148     }
1149     return Opnd;
1150   }
1151   return nullptr;
1152 }
1153 
1154 // Helper function of OptimizeXor(). It tries to simplify "Opnd1 ^ ConstOpnd"
1155 // into "R ^ C", where C would be 0, and R is a symbolic value.
1156 //
1157 // If it was successful, true is returned, and the "R" and "C" is returned
1158 // via "Res" and "ConstOpnd", respectively; otherwise, false is returned,
1159 // and both "Res" and "ConstOpnd" remain unchanged.
1160 //
1161 bool ReassociatePass::CombineXorOpnd(Instruction *I, XorOpnd *Opnd1,
1162                                      APInt &ConstOpnd, Value *&Res) {
1163   // Xor-Rule 1: (x | c1) ^ c2 = (x | c1) ^ (c1 ^ c1) ^ c2
1164   //                       = ((x | c1) ^ c1) ^ (c1 ^ c2)
1165   //                       = (x & ~c1) ^ (c1 ^ c2)
1166   // It is useful only when c1 == c2.
1167   if (Opnd1->isOrExpr() && Opnd1->getConstPart() != 0) {
1168     if (!Opnd1->getValue()->hasOneUse())
1169       return false;
1170 
1171     const APInt &C1 = Opnd1->getConstPart();
1172     if (C1 != ConstOpnd)
1173       return false;
1174 
1175     Value *X = Opnd1->getSymbolicPart();
1176     Res = createAndInstr(I, X, ~C1);
1177     // ConstOpnd was C2, now C1 ^ C2.
1178     ConstOpnd ^= C1;
1179 
1180     if (Instruction *T = dyn_cast<Instruction>(Opnd1->getValue()))
1181       RedoInsts.insert(T);
1182     return true;
1183   }
1184   return false;
1185 }
1186 
1187 
1188 // Helper function of OptimizeXor(). It tries to simplify
1189 // "Opnd1 ^ Opnd2 ^ ConstOpnd" into "R ^ C", where C would be 0, and R is a
1190 // symbolic value.
1191 //
1192 // If it was successful, true is returned, and the "R" and "C" is returned
1193 // via "Res" and "ConstOpnd", respectively (If the entire expression is
1194 // evaluated to a constant, the Res is set to NULL); otherwise, false is
1195 // returned, and both "Res" and "ConstOpnd" remain unchanged.
1196 bool ReassociatePass::CombineXorOpnd(Instruction *I, XorOpnd *Opnd1,
1197                                      XorOpnd *Opnd2, APInt &ConstOpnd,
1198                                      Value *&Res) {
1199   Value *X = Opnd1->getSymbolicPart();
1200   if (X != Opnd2->getSymbolicPart())
1201     return false;
1202 
1203   // This many instruction become dead.(At least "Opnd1 ^ Opnd2" will die.)
1204   int DeadInstNum = 1;
1205   if (Opnd1->getValue()->hasOneUse())
1206     DeadInstNum++;
1207   if (Opnd2->getValue()->hasOneUse())
1208     DeadInstNum++;
1209 
1210   // Xor-Rule 2:
1211   //  (x | c1) ^ (x & c2)
1212   //   = (x|c1) ^ (x&c2) ^ (c1 ^ c1) = ((x|c1) ^ c1) ^ (x & c2) ^ c1
1213   //   = (x & ~c1) ^ (x & c2) ^ c1               // Xor-Rule 1
1214   //   = (x & c3) ^ c1, where c3 = ~c1 ^ c2      // Xor-rule 3
1215   //
1216   if (Opnd1->isOrExpr() != Opnd2->isOrExpr()) {
1217     if (Opnd2->isOrExpr())
1218       std::swap(Opnd1, Opnd2);
1219 
1220     const APInt &C1 = Opnd1->getConstPart();
1221     const APInt &C2 = Opnd2->getConstPart();
1222     APInt C3((~C1) ^ C2);
1223 
1224     // Do not increase code size!
1225     if (C3 != 0 && !C3.isAllOnesValue()) {
1226       int NewInstNum = ConstOpnd != 0 ? 1 : 2;
1227       if (NewInstNum > DeadInstNum)
1228         return false;
1229     }
1230 
1231     Res = createAndInstr(I, X, C3);
1232     ConstOpnd ^= C1;
1233 
1234   } else if (Opnd1->isOrExpr()) {
1235     // Xor-Rule 3: (x | c1) ^ (x | c2) = (x & c3) ^ c3 where c3 = c1 ^ c2
1236     //
1237     const APInt &C1 = Opnd1->getConstPart();
1238     const APInt &C2 = Opnd2->getConstPart();
1239     APInt C3 = C1 ^ C2;
1240 
1241     // Do not increase code size
1242     if (C3 != 0 && !C3.isAllOnesValue()) {
1243       int NewInstNum = ConstOpnd != 0 ? 1 : 2;
1244       if (NewInstNum > DeadInstNum)
1245         return false;
1246     }
1247 
1248     Res = createAndInstr(I, X, C3);
1249     ConstOpnd ^= C3;
1250   } else {
1251     // Xor-Rule 4: (x & c1) ^ (x & c2) = (x & (c1^c2))
1252     //
1253     const APInt &C1 = Opnd1->getConstPart();
1254     const APInt &C2 = Opnd2->getConstPart();
1255     APInt C3 = C1 ^ C2;
1256     Res = createAndInstr(I, X, C3);
1257   }
1258 
1259   // Put the original operands in the Redo list; hope they will be deleted
1260   // as dead code.
1261   if (Instruction *T = dyn_cast<Instruction>(Opnd1->getValue()))
1262     RedoInsts.insert(T);
1263   if (Instruction *T = dyn_cast<Instruction>(Opnd2->getValue()))
1264     RedoInsts.insert(T);
1265 
1266   return true;
1267 }
1268 
1269 /// Optimize a series of operands to an 'xor' instruction. If it can be reduced
1270 /// to a single Value, it is returned, otherwise the Ops list is mutated as
1271 /// necessary.
1272 Value *ReassociatePass::OptimizeXor(Instruction *I,
1273                                     SmallVectorImpl<ValueEntry> &Ops) {
1274   if (Value *V = OptimizeAndOrXor(Instruction::Xor, Ops))
1275     return V;
1276 
1277   if (Ops.size() == 1)
1278     return nullptr;
1279 
1280   SmallVector<XorOpnd, 8> Opnds;
1281   SmallVector<XorOpnd*, 8> OpndPtrs;
1282   Type *Ty = Ops[0].Op->getType();
1283   APInt ConstOpnd(Ty->getIntegerBitWidth(), 0);
1284 
1285   // Step 1: Convert ValueEntry to XorOpnd
1286   for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
1287     Value *V = Ops[i].Op;
1288     if (!isa<ConstantInt>(V)) {
1289       XorOpnd O(V);
1290       O.setSymbolicRank(getRank(O.getSymbolicPart()));
1291       Opnds.push_back(O);
1292     } else
1293       ConstOpnd ^= cast<ConstantInt>(V)->getValue();
1294   }
1295 
1296   // NOTE: From this point on, do *NOT* add/delete element to/from "Opnds".
1297   //  It would otherwise invalidate the "Opnds"'s iterator, and hence invalidate
1298   //  the "OpndPtrs" as well. For the similar reason, do not fuse this loop
1299   //  with the previous loop --- the iterator of the "Opnds" may be invalidated
1300   //  when new elements are added to the vector.
1301   for (unsigned i = 0, e = Opnds.size(); i != e; ++i)
1302     OpndPtrs.push_back(&Opnds[i]);
1303 
1304   // Step 2: Sort the Xor-Operands in a way such that the operands containing
1305   //  the same symbolic value cluster together. For instance, the input operand
1306   //  sequence ("x | 123", "y & 456", "x & 789") will be sorted into:
1307   //  ("x | 123", "x & 789", "y & 456").
1308   //
1309   //  The purpose is twofold:
1310   //  1) Cluster together the operands sharing the same symbolic-value.
1311   //  2) Operand having smaller symbolic-value-rank is permuted earlier, which
1312   //     could potentially shorten crital path, and expose more loop-invariants.
1313   //     Note that values' rank are basically defined in RPO order (FIXME).
1314   //     So, if Rank(X) < Rank(Y) < Rank(Z), it means X is defined earlier
1315   //     than Y which is defined earlier than Z. Permute "x | 1", "Y & 2",
1316   //     "z" in the order of X-Y-Z is better than any other orders.
1317   std::stable_sort(OpndPtrs.begin(), OpndPtrs.end(),
1318                    [](XorOpnd *LHS, XorOpnd *RHS) {
1319     return LHS->getSymbolicRank() < RHS->getSymbolicRank();
1320   });
1321 
1322   // Step 3: Combine adjacent operands
1323   XorOpnd *PrevOpnd = nullptr;
1324   bool Changed = false;
1325   for (unsigned i = 0, e = Opnds.size(); i < e; i++) {
1326     XorOpnd *CurrOpnd = OpndPtrs[i];
1327     // The combined value
1328     Value *CV;
1329 
1330     // Step 3.1: Try simplifying "CurrOpnd ^ ConstOpnd"
1331     if (ConstOpnd != 0 && CombineXorOpnd(I, CurrOpnd, ConstOpnd, CV)) {
1332       Changed = true;
1333       if (CV)
1334         *CurrOpnd = XorOpnd(CV);
1335       else {
1336         CurrOpnd->Invalidate();
1337         continue;
1338       }
1339     }
1340 
1341     if (!PrevOpnd || CurrOpnd->getSymbolicPart() != PrevOpnd->getSymbolicPart()) {
1342       PrevOpnd = CurrOpnd;
1343       continue;
1344     }
1345 
1346     // step 3.2: When previous and current operands share the same symbolic
1347     //  value, try to simplify "PrevOpnd ^ CurrOpnd ^ ConstOpnd"
1348     //
1349     if (CombineXorOpnd(I, CurrOpnd, PrevOpnd, ConstOpnd, CV)) {
1350       // Remove previous operand
1351       PrevOpnd->Invalidate();
1352       if (CV) {
1353         *CurrOpnd = XorOpnd(CV);
1354         PrevOpnd = CurrOpnd;
1355       } else {
1356         CurrOpnd->Invalidate();
1357         PrevOpnd = nullptr;
1358       }
1359       Changed = true;
1360     }
1361   }
1362 
1363   // Step 4: Reassemble the Ops
1364   if (Changed) {
1365     Ops.clear();
1366     for (unsigned int i = 0, e = Opnds.size(); i < e; i++) {
1367       XorOpnd &O = Opnds[i];
1368       if (O.isInvalid())
1369         continue;
1370       ValueEntry VE(getRank(O.getValue()), O.getValue());
1371       Ops.push_back(VE);
1372     }
1373     if (ConstOpnd != 0) {
1374       Value *C = ConstantInt::get(Ty->getContext(), ConstOpnd);
1375       ValueEntry VE(getRank(C), C);
1376       Ops.push_back(VE);
1377     }
1378     int Sz = Ops.size();
1379     if (Sz == 1)
1380       return Ops.back().Op;
1381     else if (Sz == 0) {
1382       assert(ConstOpnd == 0);
1383       return ConstantInt::get(Ty->getContext(), ConstOpnd);
1384     }
1385   }
1386 
1387   return nullptr;
1388 }
1389 
1390 /// Optimize a series of operands to an 'add' instruction.  This
1391 /// optimizes based on identities.  If it can be reduced to a single Value, it
1392 /// is returned, otherwise the Ops list is mutated as necessary.
1393 Value *ReassociatePass::OptimizeAdd(Instruction *I,
1394                                     SmallVectorImpl<ValueEntry> &Ops) {
1395   // Scan the operand lists looking for X and -X pairs.  If we find any, we
1396   // can simplify expressions like X+-X == 0 and X+~X ==-1.  While we're at it,
1397   // scan for any
1398   // duplicates.  We want to canonicalize Y+Y+Y+Z -> 3*Y+Z.
1399 
1400   for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
1401     Value *TheOp = Ops[i].Op;
1402     // Check to see if we've seen this operand before.  If so, we factor all
1403     // instances of the operand together.  Due to our sorting criteria, we know
1404     // that these need to be next to each other in the vector.
1405     if (i+1 != Ops.size() && Ops[i+1].Op == TheOp) {
1406       // Rescan the list, remove all instances of this operand from the expr.
1407       unsigned NumFound = 0;
1408       do {
1409         Ops.erase(Ops.begin()+i);
1410         ++NumFound;
1411       } while (i != Ops.size() && Ops[i].Op == TheOp);
1412 
1413       DEBUG(dbgs() << "\nFACTORING [" << NumFound << "]: " << *TheOp << '\n');
1414       ++NumFactor;
1415 
1416       // Insert a new multiply.
1417       Type *Ty = TheOp->getType();
1418       Constant *C = Ty->isIntOrIntVectorTy() ?
1419         ConstantInt::get(Ty, NumFound) : ConstantFP::get(Ty, NumFound);
1420       Instruction *Mul = CreateMul(TheOp, C, "factor", I, I);
1421 
1422       // Now that we have inserted a multiply, optimize it. This allows us to
1423       // handle cases that require multiple factoring steps, such as this:
1424       // (X*2) + (X*2) + (X*2) -> (X*2)*3 -> X*6
1425       RedoInsts.insert(Mul);
1426 
1427       // If every add operand was a duplicate, return the multiply.
1428       if (Ops.empty())
1429         return Mul;
1430 
1431       // Otherwise, we had some input that didn't have the dupe, such as
1432       // "A + A + B" -> "A*2 + B".  Add the new multiply to the list of
1433       // things being added by this operation.
1434       Ops.insert(Ops.begin(), ValueEntry(getRank(Mul), Mul));
1435 
1436       --i;
1437       e = Ops.size();
1438       continue;
1439     }
1440 
1441     // Check for X and -X or X and ~X in the operand list.
1442     if (!BinaryOperator::isNeg(TheOp) && !BinaryOperator::isFNeg(TheOp) &&
1443         !BinaryOperator::isNot(TheOp))
1444       continue;
1445 
1446     Value *X = nullptr;
1447     if (BinaryOperator::isNeg(TheOp) || BinaryOperator::isFNeg(TheOp))
1448       X = BinaryOperator::getNegArgument(TheOp);
1449     else if (BinaryOperator::isNot(TheOp))
1450       X = BinaryOperator::getNotArgument(TheOp);
1451 
1452     unsigned FoundX = FindInOperandList(Ops, i, X);
1453     if (FoundX == i)
1454       continue;
1455 
1456     // Remove X and -X from the operand list.
1457     if (Ops.size() == 2 &&
1458         (BinaryOperator::isNeg(TheOp) || BinaryOperator::isFNeg(TheOp)))
1459       return Constant::getNullValue(X->getType());
1460 
1461     // Remove X and ~X from the operand list.
1462     if (Ops.size() == 2 && BinaryOperator::isNot(TheOp))
1463       return Constant::getAllOnesValue(X->getType());
1464 
1465     Ops.erase(Ops.begin()+i);
1466     if (i < FoundX)
1467       --FoundX;
1468     else
1469       --i;   // Need to back up an extra one.
1470     Ops.erase(Ops.begin()+FoundX);
1471     ++NumAnnihil;
1472     --i;     // Revisit element.
1473     e -= 2;  // Removed two elements.
1474 
1475     // if X and ~X we append -1 to the operand list.
1476     if (BinaryOperator::isNot(TheOp)) {
1477       Value *V = Constant::getAllOnesValue(X->getType());
1478       Ops.insert(Ops.end(), ValueEntry(getRank(V), V));
1479       e += 1;
1480     }
1481   }
1482 
1483   // Scan the operand list, checking to see if there are any common factors
1484   // between operands.  Consider something like A*A+A*B*C+D.  We would like to
1485   // reassociate this to A*(A+B*C)+D, which reduces the number of multiplies.
1486   // To efficiently find this, we count the number of times a factor occurs
1487   // for any ADD operands that are MULs.
1488   DenseMap<Value*, unsigned> FactorOccurrences;
1489 
1490   // Keep track of each multiply we see, to avoid triggering on (X*4)+(X*4)
1491   // where they are actually the same multiply.
1492   unsigned MaxOcc = 0;
1493   Value *MaxOccVal = nullptr;
1494   for (unsigned i = 0, e = Ops.size(); i != e; ++i) {
1495     BinaryOperator *BOp =
1496         isReassociableOp(Ops[i].Op, Instruction::Mul, Instruction::FMul);
1497     if (!BOp)
1498       continue;
1499 
1500     // Compute all of the factors of this added value.
1501     SmallVector<Value*, 8> Factors;
1502     FindSingleUseMultiplyFactors(BOp, Factors, Ops);
1503     assert(Factors.size() > 1 && "Bad linearize!");
1504 
1505     // Add one to FactorOccurrences for each unique factor in this op.
1506     SmallPtrSet<Value*, 8> Duplicates;
1507     for (unsigned i = 0, e = Factors.size(); i != e; ++i) {
1508       Value *Factor = Factors[i];
1509       if (!Duplicates.insert(Factor).second)
1510         continue;
1511 
1512       unsigned Occ = ++FactorOccurrences[Factor];
1513       if (Occ > MaxOcc) {
1514         MaxOcc = Occ;
1515         MaxOccVal = Factor;
1516       }
1517 
1518       // If Factor is a negative constant, add the negated value as a factor
1519       // because we can percolate the negate out.  Watch for minint, which
1520       // cannot be positivified.
1521       if (ConstantInt *CI = dyn_cast<ConstantInt>(Factor)) {
1522         if (CI->isNegative() && !CI->isMinValue(true)) {
1523           Factor = ConstantInt::get(CI->getContext(), -CI->getValue());
1524           assert(!Duplicates.count(Factor) &&
1525                  "Shouldn't have two constant factors, missed a canonicalize");
1526           unsigned Occ = ++FactorOccurrences[Factor];
1527           if (Occ > MaxOcc) {
1528             MaxOcc = Occ;
1529             MaxOccVal = Factor;
1530           }
1531         }
1532       } else if (ConstantFP *CF = dyn_cast<ConstantFP>(Factor)) {
1533         if (CF->isNegative()) {
1534           APFloat F(CF->getValueAPF());
1535           F.changeSign();
1536           Factor = ConstantFP::get(CF->getContext(), F);
1537           assert(!Duplicates.count(Factor) &&
1538                  "Shouldn't have two constant factors, missed a canonicalize");
1539           unsigned Occ = ++FactorOccurrences[Factor];
1540           if (Occ > MaxOcc) {
1541             MaxOcc = Occ;
1542             MaxOccVal = Factor;
1543           }
1544         }
1545       }
1546     }
1547   }
1548 
1549   // If any factor occurred more than one time, we can pull it out.
1550   if (MaxOcc > 1) {
1551     DEBUG(dbgs() << "\nFACTORING [" << MaxOcc << "]: " << *MaxOccVal << '\n');
1552     ++NumFactor;
1553 
1554     // Create a new instruction that uses the MaxOccVal twice.  If we don't do
1555     // this, we could otherwise run into situations where removing a factor
1556     // from an expression will drop a use of maxocc, and this can cause
1557     // RemoveFactorFromExpression on successive values to behave differently.
1558     Instruction *DummyInst =
1559         I->getType()->isIntOrIntVectorTy()
1560             ? BinaryOperator::CreateAdd(MaxOccVal, MaxOccVal)
1561             : BinaryOperator::CreateFAdd(MaxOccVal, MaxOccVal);
1562 
1563     SmallVector<WeakVH, 4> NewMulOps;
1564     for (unsigned i = 0; i != Ops.size(); ++i) {
1565       // Only try to remove factors from expressions we're allowed to.
1566       BinaryOperator *BOp =
1567           isReassociableOp(Ops[i].Op, Instruction::Mul, Instruction::FMul);
1568       if (!BOp)
1569         continue;
1570 
1571       if (Value *V = RemoveFactorFromExpression(Ops[i].Op, MaxOccVal)) {
1572         // The factorized operand may occur several times.  Convert them all in
1573         // one fell swoop.
1574         for (unsigned j = Ops.size(); j != i;) {
1575           --j;
1576           if (Ops[j].Op == Ops[i].Op) {
1577             NewMulOps.push_back(V);
1578             Ops.erase(Ops.begin()+j);
1579           }
1580         }
1581         --i;
1582       }
1583     }
1584 
1585     // No need for extra uses anymore.
1586     delete DummyInst;
1587 
1588     unsigned NumAddedValues = NewMulOps.size();
1589     Value *V = EmitAddTreeOfValues(I, NewMulOps);
1590 
1591     // Now that we have inserted the add tree, optimize it. This allows us to
1592     // handle cases that require multiple factoring steps, such as this:
1593     // A*A*B + A*A*C   -->   A*(A*B+A*C)   -->   A*(A*(B+C))
1594     assert(NumAddedValues > 1 && "Each occurrence should contribute a value");
1595     (void)NumAddedValues;
1596     if (Instruction *VI = dyn_cast<Instruction>(V))
1597       RedoInsts.insert(VI);
1598 
1599     // Create the multiply.
1600     Instruction *V2 = CreateMul(V, MaxOccVal, "tmp", I, I);
1601 
1602     // Rerun associate on the multiply in case the inner expression turned into
1603     // a multiply.  We want to make sure that we keep things in canonical form.
1604     RedoInsts.insert(V2);
1605 
1606     // If every add operand included the factor (e.g. "A*B + A*C"), then the
1607     // entire result expression is just the multiply "A*(B+C)".
1608     if (Ops.empty())
1609       return V2;
1610 
1611     // Otherwise, we had some input that didn't have the factor, such as
1612     // "A*B + A*C + D" -> "A*(B+C) + D".  Add the new multiply to the list of
1613     // things being added by this operation.
1614     Ops.insert(Ops.begin(), ValueEntry(getRank(V2), V2));
1615   }
1616 
1617   return nullptr;
1618 }
1619 
1620 /// \brief Build up a vector of value/power pairs factoring a product.
1621 ///
1622 /// Given a series of multiplication operands, build a vector of factors and
1623 /// the powers each is raised to when forming the final product. Sort them in
1624 /// the order of descending power.
1625 ///
1626 ///      (x*x)          -> [(x, 2)]
1627 ///     ((x*x)*x)       -> [(x, 3)]
1628 ///   ((((x*y)*x)*y)*x) -> [(x, 3), (y, 2)]
1629 ///
1630 /// \returns Whether any factors have a power greater than one.
1631 bool ReassociatePass::collectMultiplyFactors(SmallVectorImpl<ValueEntry> &Ops,
1632                                              SmallVectorImpl<Factor> &Factors) {
1633   // FIXME: Have Ops be (ValueEntry, Multiplicity) pairs, simplifying this.
1634   // Compute the sum of powers of simplifiable factors.
1635   unsigned FactorPowerSum = 0;
1636   for (unsigned Idx = 1, Size = Ops.size(); Idx < Size; ++Idx) {
1637     Value *Op = Ops[Idx-1].Op;
1638 
1639     // Count the number of occurrences of this value.
1640     unsigned Count = 1;
1641     for (; Idx < Size && Ops[Idx].Op == Op; ++Idx)
1642       ++Count;
1643     // Track for simplification all factors which occur 2 or more times.
1644     if (Count > 1)
1645       FactorPowerSum += Count;
1646   }
1647 
1648   // We can only simplify factors if the sum of the powers of our simplifiable
1649   // factors is 4 or higher. When that is the case, we will *always* have
1650   // a simplification. This is an important invariant to prevent cyclicly
1651   // trying to simplify already minimal formations.
1652   if (FactorPowerSum < 4)
1653     return false;
1654 
1655   // Now gather the simplifiable factors, removing them from Ops.
1656   FactorPowerSum = 0;
1657   for (unsigned Idx = 1; Idx < Ops.size(); ++Idx) {
1658     Value *Op = Ops[Idx-1].Op;
1659 
1660     // Count the number of occurrences of this value.
1661     unsigned Count = 1;
1662     for (; Idx < Ops.size() && Ops[Idx].Op == Op; ++Idx)
1663       ++Count;
1664     if (Count == 1)
1665       continue;
1666     // Move an even number of occurrences to Factors.
1667     Count &= ~1U;
1668     Idx -= Count;
1669     FactorPowerSum += Count;
1670     Factors.push_back(Factor(Op, Count));
1671     Ops.erase(Ops.begin()+Idx, Ops.begin()+Idx+Count);
1672   }
1673 
1674   // None of the adjustments above should have reduced the sum of factor powers
1675   // below our mininum of '4'.
1676   assert(FactorPowerSum >= 4);
1677 
1678   std::stable_sort(Factors.begin(), Factors.end(),
1679                    [](const Factor &LHS, const Factor &RHS) {
1680     return LHS.Power > RHS.Power;
1681   });
1682   return true;
1683 }
1684 
1685 /// \brief Build a tree of multiplies, computing the product of Ops.
1686 static Value *buildMultiplyTree(IRBuilder<> &Builder,
1687                                 SmallVectorImpl<Value*> &Ops) {
1688   if (Ops.size() == 1)
1689     return Ops.back();
1690 
1691   Value *LHS = Ops.pop_back_val();
1692   do {
1693     if (LHS->getType()->isIntOrIntVectorTy())
1694       LHS = Builder.CreateMul(LHS, Ops.pop_back_val());
1695     else
1696       LHS = Builder.CreateFMul(LHS, Ops.pop_back_val());
1697   } while (!Ops.empty());
1698 
1699   return LHS;
1700 }
1701 
1702 /// \brief Build a minimal multiplication DAG for (a^x)*(b^y)*(c^z)*...
1703 ///
1704 /// Given a vector of values raised to various powers, where no two values are
1705 /// equal and the powers are sorted in decreasing order, compute the minimal
1706 /// DAG of multiplies to compute the final product, and return that product
1707 /// value.
1708 Value *
1709 ReassociatePass::buildMinimalMultiplyDAG(IRBuilder<> &Builder,
1710                                          SmallVectorImpl<Factor> &Factors) {
1711   assert(Factors[0].Power);
1712   SmallVector<Value *, 4> OuterProduct;
1713   for (unsigned LastIdx = 0, Idx = 1, Size = Factors.size();
1714        Idx < Size && Factors[Idx].Power > 0; ++Idx) {
1715     if (Factors[Idx].Power != Factors[LastIdx].Power) {
1716       LastIdx = Idx;
1717       continue;
1718     }
1719 
1720     // We want to multiply across all the factors with the same power so that
1721     // we can raise them to that power as a single entity. Build a mini tree
1722     // for that.
1723     SmallVector<Value *, 4> InnerProduct;
1724     InnerProduct.push_back(Factors[LastIdx].Base);
1725     do {
1726       InnerProduct.push_back(Factors[Idx].Base);
1727       ++Idx;
1728     } while (Idx < Size && Factors[Idx].Power == Factors[LastIdx].Power);
1729 
1730     // Reset the base value of the first factor to the new expression tree.
1731     // We'll remove all the factors with the same power in a second pass.
1732     Value *M = Factors[LastIdx].Base = buildMultiplyTree(Builder, InnerProduct);
1733     if (Instruction *MI = dyn_cast<Instruction>(M))
1734       RedoInsts.insert(MI);
1735 
1736     LastIdx = Idx;
1737   }
1738   // Unique factors with equal powers -- we've folded them into the first one's
1739   // base.
1740   Factors.erase(std::unique(Factors.begin(), Factors.end(),
1741                             [](const Factor &LHS, const Factor &RHS) {
1742                               return LHS.Power == RHS.Power;
1743                             }),
1744                 Factors.end());
1745 
1746   // Iteratively collect the base of each factor with an add power into the
1747   // outer product, and halve each power in preparation for squaring the
1748   // expression.
1749   for (unsigned Idx = 0, Size = Factors.size(); Idx != Size; ++Idx) {
1750     if (Factors[Idx].Power & 1)
1751       OuterProduct.push_back(Factors[Idx].Base);
1752     Factors[Idx].Power >>= 1;
1753   }
1754   if (Factors[0].Power) {
1755     Value *SquareRoot = buildMinimalMultiplyDAG(Builder, Factors);
1756     OuterProduct.push_back(SquareRoot);
1757     OuterProduct.push_back(SquareRoot);
1758   }
1759   if (OuterProduct.size() == 1)
1760     return OuterProduct.front();
1761 
1762   Value *V = buildMultiplyTree(Builder, OuterProduct);
1763   return V;
1764 }
1765 
1766 Value *ReassociatePass::OptimizeMul(BinaryOperator *I,
1767                                     SmallVectorImpl<ValueEntry> &Ops) {
1768   // We can only optimize the multiplies when there is a chain of more than
1769   // three, such that a balanced tree might require fewer total multiplies.
1770   if (Ops.size() < 4)
1771     return nullptr;
1772 
1773   // Try to turn linear trees of multiplies without other uses of the
1774   // intermediate stages into minimal multiply DAGs with perfect sub-expression
1775   // re-use.
1776   SmallVector<Factor, 4> Factors;
1777   if (!collectMultiplyFactors(Ops, Factors))
1778     return nullptr; // All distinct factors, so nothing left for us to do.
1779 
1780   IRBuilder<> Builder(I);
1781   Value *V = buildMinimalMultiplyDAG(Builder, Factors);
1782   if (Ops.empty())
1783     return V;
1784 
1785   ValueEntry NewEntry = ValueEntry(getRank(V), V);
1786   Ops.insert(std::lower_bound(Ops.begin(), Ops.end(), NewEntry), NewEntry);
1787   return nullptr;
1788 }
1789 
1790 Value *ReassociatePass::OptimizeExpression(BinaryOperator *I,
1791                                            SmallVectorImpl<ValueEntry> &Ops) {
1792   // Now that we have the linearized expression tree, try to optimize it.
1793   // Start by folding any constants that we found.
1794   Constant *Cst = nullptr;
1795   unsigned Opcode = I->getOpcode();
1796   while (!Ops.empty() && isa<Constant>(Ops.back().Op)) {
1797     Constant *C = cast<Constant>(Ops.pop_back_val().Op);
1798     Cst = Cst ? ConstantExpr::get(Opcode, C, Cst) : C;
1799   }
1800   // If there was nothing but constants then we are done.
1801   if (Ops.empty())
1802     return Cst;
1803 
1804   // Put the combined constant back at the end of the operand list, except if
1805   // there is no point.  For example, an add of 0 gets dropped here, while a
1806   // multiplication by zero turns the whole expression into zero.
1807   if (Cst && Cst != ConstantExpr::getBinOpIdentity(Opcode, I->getType())) {
1808     if (Cst == ConstantExpr::getBinOpAbsorber(Opcode, I->getType()))
1809       return Cst;
1810     Ops.push_back(ValueEntry(0, Cst));
1811   }
1812 
1813   if (Ops.size() == 1) return Ops[0].Op;
1814 
1815   // Handle destructive annihilation due to identities between elements in the
1816   // argument list here.
1817   unsigned NumOps = Ops.size();
1818   switch (Opcode) {
1819   default: break;
1820   case Instruction::And:
1821   case Instruction::Or:
1822     if (Value *Result = OptimizeAndOrXor(Opcode, Ops))
1823       return Result;
1824     break;
1825 
1826   case Instruction::Xor:
1827     if (Value *Result = OptimizeXor(I, Ops))
1828       return Result;
1829     break;
1830 
1831   case Instruction::Add:
1832   case Instruction::FAdd:
1833     if (Value *Result = OptimizeAdd(I, Ops))
1834       return Result;
1835     break;
1836 
1837   case Instruction::Mul:
1838   case Instruction::FMul:
1839     if (Value *Result = OptimizeMul(I, Ops))
1840       return Result;
1841     break;
1842   }
1843 
1844   if (Ops.size() != NumOps)
1845     return OptimizeExpression(I, Ops);
1846   return nullptr;
1847 }
1848 
1849 // Remove dead instructions and if any operands are trivially dead add them to
1850 // Insts so they will be removed as well.
1851 void ReassociatePass::RecursivelyEraseDeadInsts(
1852     Instruction *I, SetVector<AssertingVH<Instruction>> &Insts) {
1853   assert(isInstructionTriviallyDead(I) && "Trivially dead instructions only!");
1854   SmallVector<Value *, 4> Ops(I->op_begin(), I->op_end());
1855   ValueRankMap.erase(I);
1856   Insts.remove(I);
1857   RedoInsts.remove(I);
1858   I->eraseFromParent();
1859   for (auto Op : Ops)
1860     if (Instruction *OpInst = dyn_cast<Instruction>(Op))
1861       if (OpInst->use_empty())
1862         Insts.insert(OpInst);
1863 }
1864 
1865 /// Zap the given instruction, adding interesting operands to the work list.
1866 void ReassociatePass::EraseInst(Instruction *I) {
1867   assert(isInstructionTriviallyDead(I) && "Trivially dead instructions only!");
1868   SmallVector<Value*, 8> Ops(I->op_begin(), I->op_end());
1869   // Erase the dead instruction.
1870   ValueRankMap.erase(I);
1871   RedoInsts.remove(I);
1872   I->eraseFromParent();
1873   // Optimize its operands.
1874   SmallPtrSet<Instruction *, 8> Visited; // Detect self-referential nodes.
1875   for (unsigned i = 0, e = Ops.size(); i != e; ++i)
1876     if (Instruction *Op = dyn_cast<Instruction>(Ops[i])) {
1877       // If this is a node in an expression tree, climb to the expression root
1878       // and add that since that's where optimization actually happens.
1879       unsigned Opcode = Op->getOpcode();
1880       while (Op->hasOneUse() && Op->user_back()->getOpcode() == Opcode &&
1881              Visited.insert(Op).second)
1882         Op = Op->user_back();
1883       RedoInsts.insert(Op);
1884     }
1885 }
1886 
1887 // Canonicalize expressions of the following form:
1888 //  x + (-Constant * y) -> x - (Constant * y)
1889 //  x - (-Constant * y) -> x + (Constant * y)
1890 Instruction *ReassociatePass::canonicalizeNegConstExpr(Instruction *I) {
1891   if (!I->hasOneUse() || I->getType()->isVectorTy())
1892     return nullptr;
1893 
1894   // Must be a fmul or fdiv instruction.
1895   unsigned Opcode = I->getOpcode();
1896   if (Opcode != Instruction::FMul && Opcode != Instruction::FDiv)
1897     return nullptr;
1898 
1899   auto *C0 = dyn_cast<ConstantFP>(I->getOperand(0));
1900   auto *C1 = dyn_cast<ConstantFP>(I->getOperand(1));
1901 
1902   // Both operands are constant, let it get constant folded away.
1903   if (C0 && C1)
1904     return nullptr;
1905 
1906   ConstantFP *CF = C0 ? C0 : C1;
1907 
1908   // Must have one constant operand.
1909   if (!CF)
1910     return nullptr;
1911 
1912   // Must be a negative ConstantFP.
1913   if (!CF->isNegative())
1914     return nullptr;
1915 
1916   // User must be a binary operator with one or more uses.
1917   Instruction *User = I->user_back();
1918   if (!isa<BinaryOperator>(User) || !User->hasNUsesOrMore(1))
1919     return nullptr;
1920 
1921   unsigned UserOpcode = User->getOpcode();
1922   if (UserOpcode != Instruction::FAdd && UserOpcode != Instruction::FSub)
1923     return nullptr;
1924 
1925   // Subtraction is not commutative. Explicitly, the following transform is
1926   // not valid: (-Constant * y) - x  -> x + (Constant * y)
1927   if (!User->isCommutative() && User->getOperand(1) != I)
1928     return nullptr;
1929 
1930   // Change the sign of the constant.
1931   APFloat Val = CF->getValueAPF();
1932   Val.changeSign();
1933   I->setOperand(C0 ? 0 : 1, ConstantFP::get(CF->getContext(), Val));
1934 
1935   // Canonicalize I to RHS to simplify the next bit of logic. E.g.,
1936   // ((-Const*y) + x) -> (x + (-Const*y)).
1937   if (User->getOperand(0) == I && User->isCommutative())
1938     cast<BinaryOperator>(User)->swapOperands();
1939 
1940   Value *Op0 = User->getOperand(0);
1941   Value *Op1 = User->getOperand(1);
1942   BinaryOperator *NI;
1943   switch (UserOpcode) {
1944   default:
1945     llvm_unreachable("Unexpected Opcode!");
1946   case Instruction::FAdd:
1947     NI = BinaryOperator::CreateFSub(Op0, Op1);
1948     NI->setFastMathFlags(cast<FPMathOperator>(User)->getFastMathFlags());
1949     break;
1950   case Instruction::FSub:
1951     NI = BinaryOperator::CreateFAdd(Op0, Op1);
1952     NI->setFastMathFlags(cast<FPMathOperator>(User)->getFastMathFlags());
1953     break;
1954   }
1955 
1956   NI->insertBefore(User);
1957   NI->setName(User->getName());
1958   User->replaceAllUsesWith(NI);
1959   NI->setDebugLoc(I->getDebugLoc());
1960   RedoInsts.insert(I);
1961   MadeChange = true;
1962   return NI;
1963 }
1964 
1965 /// Inspect and optimize the given instruction. Note that erasing
1966 /// instructions is not allowed.
1967 void ReassociatePass::OptimizeInst(Instruction *I) {
1968   // Only consider operations that we understand.
1969   if (!isa<BinaryOperator>(I))
1970     return;
1971 
1972   if (I->getOpcode() == Instruction::Shl && isa<ConstantInt>(I->getOperand(1)))
1973     // If an operand of this shift is a reassociable multiply, or if the shift
1974     // is used by a reassociable multiply or add, turn into a multiply.
1975     if (isReassociableOp(I->getOperand(0), Instruction::Mul) ||
1976         (I->hasOneUse() &&
1977          (isReassociableOp(I->user_back(), Instruction::Mul) ||
1978           isReassociableOp(I->user_back(), Instruction::Add)))) {
1979       Instruction *NI = ConvertShiftToMul(I);
1980       RedoInsts.insert(I);
1981       MadeChange = true;
1982       I = NI;
1983     }
1984 
1985   // Canonicalize negative constants out of expressions.
1986   if (Instruction *Res = canonicalizeNegConstExpr(I))
1987     I = Res;
1988 
1989   // Commute binary operators, to canonicalize the order of their operands.
1990   // This can potentially expose more CSE opportunities, and makes writing other
1991   // transformations simpler.
1992   if (I->isCommutative())
1993     canonicalizeOperands(I);
1994 
1995   // TODO: We should optimize vector Xor instructions, but they are
1996   // currently unsupported.
1997   if (I->getType()->isVectorTy() && I->getOpcode() == Instruction::Xor)
1998     return;
1999 
2000   // Don't optimize floating point instructions that don't have unsafe algebra.
2001   if (I->getType()->isFPOrFPVectorTy() && !I->hasUnsafeAlgebra())
2002     return;
2003 
2004   // Do not reassociate boolean (i1) expressions.  We want to preserve the
2005   // original order of evaluation for short-circuited comparisons that
2006   // SimplifyCFG has folded to AND/OR expressions.  If the expression
2007   // is not further optimized, it is likely to be transformed back to a
2008   // short-circuited form for code gen, and the source order may have been
2009   // optimized for the most likely conditions.
2010   if (I->getType()->isIntegerTy(1))
2011     return;
2012 
2013   // If this is a subtract instruction which is not already in negate form,
2014   // see if we can convert it to X+-Y.
2015   if (I->getOpcode() == Instruction::Sub) {
2016     if (ShouldBreakUpSubtract(I)) {
2017       Instruction *NI = BreakUpSubtract(I, RedoInsts);
2018       RedoInsts.insert(I);
2019       MadeChange = true;
2020       I = NI;
2021     } else if (BinaryOperator::isNeg(I)) {
2022       // Otherwise, this is a negation.  See if the operand is a multiply tree
2023       // and if this is not an inner node of a multiply tree.
2024       if (isReassociableOp(I->getOperand(1), Instruction::Mul) &&
2025           (!I->hasOneUse() ||
2026            !isReassociableOp(I->user_back(), Instruction::Mul))) {
2027         Instruction *NI = LowerNegateToMultiply(I);
2028         // If the negate was simplified, revisit the users to see if we can
2029         // reassociate further.
2030         for (User *U : NI->users()) {
2031           if (BinaryOperator *Tmp = dyn_cast<BinaryOperator>(U))
2032             RedoInsts.insert(Tmp);
2033         }
2034         RedoInsts.insert(I);
2035         MadeChange = true;
2036         I = NI;
2037       }
2038     }
2039   } else if (I->getOpcode() == Instruction::FSub) {
2040     if (ShouldBreakUpSubtract(I)) {
2041       Instruction *NI = BreakUpSubtract(I, RedoInsts);
2042       RedoInsts.insert(I);
2043       MadeChange = true;
2044       I = NI;
2045     } else if (BinaryOperator::isFNeg(I)) {
2046       // Otherwise, this is a negation.  See if the operand is a multiply tree
2047       // and if this is not an inner node of a multiply tree.
2048       if (isReassociableOp(I->getOperand(1), Instruction::FMul) &&
2049           (!I->hasOneUse() ||
2050            !isReassociableOp(I->user_back(), Instruction::FMul))) {
2051         // If the negate was simplified, revisit the users to see if we can
2052         // reassociate further.
2053         Instruction *NI = LowerNegateToMultiply(I);
2054         for (User *U : NI->users()) {
2055           if (BinaryOperator *Tmp = dyn_cast<BinaryOperator>(U))
2056             RedoInsts.insert(Tmp);
2057         }
2058         RedoInsts.insert(I);
2059         MadeChange = true;
2060         I = NI;
2061       }
2062     }
2063   }
2064 
2065   // If this instruction is an associative binary operator, process it.
2066   if (!I->isAssociative()) return;
2067   BinaryOperator *BO = cast<BinaryOperator>(I);
2068 
2069   // If this is an interior node of a reassociable tree, ignore it until we
2070   // get to the root of the tree, to avoid N^2 analysis.
2071   unsigned Opcode = BO->getOpcode();
2072   if (BO->hasOneUse() && BO->user_back()->getOpcode() == Opcode) {
2073     // During the initial run we will get to the root of the tree.
2074     // But if we get here while we are redoing instructions, there is no
2075     // guarantee that the root will be visited. So Redo later
2076     if (BO->user_back() != BO &&
2077         BO->getParent() == BO->user_back()->getParent())
2078       RedoInsts.insert(BO->user_back());
2079     return;
2080   }
2081 
2082   // If this is an add tree that is used by a sub instruction, ignore it
2083   // until we process the subtract.
2084   if (BO->hasOneUse() && BO->getOpcode() == Instruction::Add &&
2085       cast<Instruction>(BO->user_back())->getOpcode() == Instruction::Sub)
2086     return;
2087   if (BO->hasOneUse() && BO->getOpcode() == Instruction::FAdd &&
2088       cast<Instruction>(BO->user_back())->getOpcode() == Instruction::FSub)
2089     return;
2090 
2091   ReassociateExpression(BO);
2092 }
2093 
2094 void ReassociatePass::ReassociateExpression(BinaryOperator *I) {
2095   // First, walk the expression tree, linearizing the tree, collecting the
2096   // operand information.
2097   SmallVector<RepeatedValue, 8> Tree;
2098   MadeChange |= LinearizeExprTree(I, Tree);
2099   SmallVector<ValueEntry, 8> Ops;
2100   Ops.reserve(Tree.size());
2101   for (unsigned i = 0, e = Tree.size(); i != e; ++i) {
2102     RepeatedValue E = Tree[i];
2103     Ops.append(E.second.getZExtValue(),
2104                ValueEntry(getRank(E.first), E.first));
2105   }
2106 
2107   DEBUG(dbgs() << "RAIn:\t"; PrintOps(I, Ops); dbgs() << '\n');
2108 
2109   // Now that we have linearized the tree to a list and have gathered all of
2110   // the operands and their ranks, sort the operands by their rank.  Use a
2111   // stable_sort so that values with equal ranks will have their relative
2112   // positions maintained (and so the compiler is deterministic).  Note that
2113   // this sorts so that the highest ranking values end up at the beginning of
2114   // the vector.
2115   std::stable_sort(Ops.begin(), Ops.end());
2116 
2117   // Now that we have the expression tree in a convenient
2118   // sorted form, optimize it globally if possible.
2119   if (Value *V = OptimizeExpression(I, Ops)) {
2120     if (V == I)
2121       // Self-referential expression in unreachable code.
2122       return;
2123     // This expression tree simplified to something that isn't a tree,
2124     // eliminate it.
2125     DEBUG(dbgs() << "Reassoc to scalar: " << *V << '\n');
2126     I->replaceAllUsesWith(V);
2127     if (Instruction *VI = dyn_cast<Instruction>(V))
2128       VI->setDebugLoc(I->getDebugLoc());
2129     RedoInsts.insert(I);
2130     ++NumAnnihil;
2131     return;
2132   }
2133 
2134   // We want to sink immediates as deeply as possible except in the case where
2135   // this is a multiply tree used only by an add, and the immediate is a -1.
2136   // In this case we reassociate to put the negation on the outside so that we
2137   // can fold the negation into the add: (-X)*Y + Z -> Z-X*Y
2138   if (I->hasOneUse()) {
2139     if (I->getOpcode() == Instruction::Mul &&
2140         cast<Instruction>(I->user_back())->getOpcode() == Instruction::Add &&
2141         isa<ConstantInt>(Ops.back().Op) &&
2142         cast<ConstantInt>(Ops.back().Op)->isAllOnesValue()) {
2143       ValueEntry Tmp = Ops.pop_back_val();
2144       Ops.insert(Ops.begin(), Tmp);
2145     } else if (I->getOpcode() == Instruction::FMul &&
2146                cast<Instruction>(I->user_back())->getOpcode() ==
2147                    Instruction::FAdd &&
2148                isa<ConstantFP>(Ops.back().Op) &&
2149                cast<ConstantFP>(Ops.back().Op)->isExactlyValue(-1.0)) {
2150       ValueEntry Tmp = Ops.pop_back_val();
2151       Ops.insert(Ops.begin(), Tmp);
2152     }
2153   }
2154 
2155   DEBUG(dbgs() << "RAOut:\t"; PrintOps(I, Ops); dbgs() << '\n');
2156 
2157   if (Ops.size() == 1) {
2158     if (Ops[0].Op == I)
2159       // Self-referential expression in unreachable code.
2160       return;
2161 
2162     // This expression tree simplified to something that isn't a tree,
2163     // eliminate it.
2164     I->replaceAllUsesWith(Ops[0].Op);
2165     if (Instruction *OI = dyn_cast<Instruction>(Ops[0].Op))
2166       OI->setDebugLoc(I->getDebugLoc());
2167     RedoInsts.insert(I);
2168     return;
2169   }
2170 
2171   // Now that we ordered and optimized the expressions, splat them back into
2172   // the expression tree, removing any unneeded nodes.
2173   RewriteExprTree(I, Ops);
2174 }
2175 
2176 PreservedAnalyses ReassociatePass::run(Function &F) {
2177   // Reassociate needs for each instruction to have its operands already
2178   // processed, so we first perform a RPOT of the basic blocks so that
2179   // when we process a basic block, all its dominators have been processed
2180   // before.
2181   ReversePostOrderTraversal<Function *> RPOT(&F);
2182   BuildRankMap(F, RPOT);
2183 
2184   MadeChange = false;
2185   for (BasicBlock *BI : RPOT) {
2186     // Use a worklist to keep track of which instructions have been processed
2187     // (and which insts won't be optimized again) so when redoing insts,
2188     // optimize insts rightaway which won't be processed later.
2189     SmallSet<Instruction *, 8> Worklist;
2190 
2191     // Insert all instructions in the BB
2192     for (Instruction &I : *BI)
2193       Worklist.insert(&I);
2194 
2195     // Optimize every instruction in the basic block.
2196     for (BasicBlock::iterator II = BI->begin(), IE = BI->end(); II != IE;) {
2197       // This instruction has been processed.
2198       Worklist.erase(&*II);
2199       if (isInstructionTriviallyDead(&*II)) {
2200         EraseInst(&*II++);
2201       } else {
2202         OptimizeInst(&*II);
2203         assert(II->getParent() == &*BI && "Moved to a different block!");
2204         ++II;
2205       }
2206 
2207       // If the above optimizations produced new instructions to optimize or
2208       // made modifications which need to be redone, do them now if they won't
2209       // be handled later.
2210       while (!RedoInsts.empty()) {
2211         Instruction *I = RedoInsts.pop_back_val();
2212         // Process instructions that won't be processed later, either
2213         // inside the block itself or in another basic block (based on rank),
2214         // since these will be processed later.
2215         if ((I->getParent() != BI || !Worklist.count(I)) &&
2216             RankMap[I->getParent()] <= RankMap[BI]) {
2217           if (isInstructionTriviallyDead(I))
2218             EraseInst(I);
2219           else
2220             OptimizeInst(I);
2221         }
2222       }
2223     }
2224   }
2225 
2226   // We are done with the rank map.
2227   RankMap.clear();
2228   ValueRankMap.clear();
2229 
2230   if (MadeChange) {
2231     // FIXME: Reassociate should also 'preserve the CFG'.
2232     // The new pass manager has currently no way to do it.
2233     auto PA = PreservedAnalyses();
2234     PA.preserve<GlobalsAA>();
2235     return PA;
2236   }
2237 
2238   return PreservedAnalyses::all();
2239 }
2240 
2241 namespace {
2242   class ReassociateLegacyPass : public FunctionPass {
2243     ReassociatePass Impl;
2244   public:
2245     static char ID; // Pass identification, replacement for typeid
2246     ReassociateLegacyPass() : FunctionPass(ID) {
2247       initializeReassociateLegacyPassPass(*PassRegistry::getPassRegistry());
2248     }
2249 
2250     bool runOnFunction(Function &F) override {
2251       if (skipFunction(F))
2252         return false;
2253 
2254       auto PA = Impl.run(F);
2255       return !PA.areAllPreserved();
2256     }
2257 
2258     void getAnalysisUsage(AnalysisUsage &AU) const override {
2259       AU.setPreservesCFG();
2260       AU.addPreserved<GlobalsAAWrapperPass>();
2261     }
2262   };
2263 }
2264 
2265 char ReassociateLegacyPass::ID = 0;
2266 INITIALIZE_PASS(ReassociateLegacyPass, "reassociate",
2267                 "Reassociate expressions", false, false)
2268 
2269 // Public interface to the Reassociate pass
2270 FunctionPass *llvm::createReassociatePass() {
2271   return new ReassociateLegacyPass();
2272 }
2273