1 //===- Reassociate.cpp - Reassociate binary expressions -------------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // This pass reassociates commutative expressions in an order that is designed 10 // to promote better constant propagation, GCSE, LICM, PRE, etc. 11 // 12 // For example: 4 + (x + 5) -> x + (4 + 5) 13 // 14 // In the implementation of this algorithm, constants are assigned rank = 0, 15 // function arguments are rank = 1, and other values are assigned ranks 16 // corresponding to the reverse post order traversal of current function 17 // (starting at 2), which effectively gives values in deep loops higher rank 18 // than values not in loops. 19 // 20 //===----------------------------------------------------------------------===// 21 22 #include "llvm/Transforms/Scalar/Reassociate.h" 23 #include "llvm/ADT/APFloat.h" 24 #include "llvm/ADT/APInt.h" 25 #include "llvm/ADT/DenseMap.h" 26 #include "llvm/ADT/PostOrderIterator.h" 27 #include "llvm/ADT/SetVector.h" 28 #include "llvm/ADT/SmallPtrSet.h" 29 #include "llvm/ADT/SmallSet.h" 30 #include "llvm/ADT/SmallVector.h" 31 #include "llvm/ADT/Statistic.h" 32 #include "llvm/Analysis/BasicAliasAnalysis.h" 33 #include "llvm/Analysis/GlobalsModRef.h" 34 #include "llvm/Analysis/ValueTracking.h" 35 #include "llvm/IR/Argument.h" 36 #include "llvm/IR/BasicBlock.h" 37 #include "llvm/IR/CFG.h" 38 #include "llvm/IR/Constant.h" 39 #include "llvm/IR/Constants.h" 40 #include "llvm/IR/Function.h" 41 #include "llvm/IR/IRBuilder.h" 42 #include "llvm/IR/InstrTypes.h" 43 #include "llvm/IR/Instruction.h" 44 #include "llvm/IR/Instructions.h" 45 #include "llvm/IR/IntrinsicInst.h" 46 #include "llvm/IR/Operator.h" 47 #include "llvm/IR/PassManager.h" 48 #include "llvm/IR/PatternMatch.h" 49 #include "llvm/IR/Type.h" 50 #include "llvm/IR/User.h" 51 #include "llvm/IR/Value.h" 52 #include "llvm/IR/ValueHandle.h" 53 #include "llvm/InitializePasses.h" 54 #include "llvm/Pass.h" 55 #include "llvm/Support/Casting.h" 56 #include "llvm/Support/Debug.h" 57 #include "llvm/Support/ErrorHandling.h" 58 #include "llvm/Support/raw_ostream.h" 59 #include "llvm/Transforms/Scalar.h" 60 #include "llvm/Transforms/Utils/Local.h" 61 #include <algorithm> 62 #include <cassert> 63 #include <utility> 64 65 using namespace llvm; 66 using namespace reassociate; 67 using namespace PatternMatch; 68 69 #define DEBUG_TYPE "reassociate" 70 71 STATISTIC(NumChanged, "Number of insts reassociated"); 72 STATISTIC(NumAnnihil, "Number of expr tree annihilated"); 73 STATISTIC(NumFactor , "Number of multiplies factored"); 74 75 #ifndef NDEBUG 76 /// Print out the expression identified in the Ops list. 77 static void PrintOps(Instruction *I, const SmallVectorImpl<ValueEntry> &Ops) { 78 Module *M = I->getModule(); 79 dbgs() << Instruction::getOpcodeName(I->getOpcode()) << " " 80 << *Ops[0].Op->getType() << '\t'; 81 for (unsigned i = 0, e = Ops.size(); i != e; ++i) { 82 dbgs() << "[ "; 83 Ops[i].Op->printAsOperand(dbgs(), false, M); 84 dbgs() << ", #" << Ops[i].Rank << "] "; 85 } 86 } 87 #endif 88 89 /// Utility class representing a non-constant Xor-operand. We classify 90 /// non-constant Xor-Operands into two categories: 91 /// C1) The operand is in the form "X & C", where C is a constant and C != ~0 92 /// C2) 93 /// C2.1) The operand is in the form of "X | C", where C is a non-zero 94 /// constant. 95 /// C2.2) Any operand E which doesn't fall into C1 and C2.1, we view this 96 /// operand as "E | 0" 97 class llvm::reassociate::XorOpnd { 98 public: 99 XorOpnd(Value *V); 100 101 bool isInvalid() const { return SymbolicPart == nullptr; } 102 bool isOrExpr() const { return isOr; } 103 Value *getValue() const { return OrigVal; } 104 Value *getSymbolicPart() const { return SymbolicPart; } 105 unsigned getSymbolicRank() const { return SymbolicRank; } 106 const APInt &getConstPart() const { return ConstPart; } 107 108 void Invalidate() { SymbolicPart = OrigVal = nullptr; } 109 void setSymbolicRank(unsigned R) { SymbolicRank = R; } 110 111 private: 112 Value *OrigVal; 113 Value *SymbolicPart; 114 APInt ConstPart; 115 unsigned SymbolicRank; 116 bool isOr; 117 }; 118 119 XorOpnd::XorOpnd(Value *V) { 120 assert(!isa<ConstantInt>(V) && "No ConstantInt"); 121 OrigVal = V; 122 Instruction *I = dyn_cast<Instruction>(V); 123 SymbolicRank = 0; 124 125 if (I && (I->getOpcode() == Instruction::Or || 126 I->getOpcode() == Instruction::And)) { 127 Value *V0 = I->getOperand(0); 128 Value *V1 = I->getOperand(1); 129 const APInt *C; 130 if (match(V0, m_APInt(C))) 131 std::swap(V0, V1); 132 133 if (match(V1, m_APInt(C))) { 134 ConstPart = *C; 135 SymbolicPart = V0; 136 isOr = (I->getOpcode() == Instruction::Or); 137 return; 138 } 139 } 140 141 // view the operand as "V | 0" 142 SymbolicPart = V; 143 ConstPart = APInt::getNullValue(V->getType()->getScalarSizeInBits()); 144 isOr = true; 145 } 146 147 /// Return true if V is an instruction of the specified opcode and if it 148 /// only has one use. 149 static BinaryOperator *isReassociableOp(Value *V, unsigned Opcode) { 150 auto *I = dyn_cast<Instruction>(V); 151 if (I && I->hasOneUse() && I->getOpcode() == Opcode) 152 if (!isa<FPMathOperator>(I) || I->isFast()) 153 return cast<BinaryOperator>(I); 154 return nullptr; 155 } 156 157 static BinaryOperator *isReassociableOp(Value *V, unsigned Opcode1, 158 unsigned Opcode2) { 159 auto *I = dyn_cast<Instruction>(V); 160 if (I && I->hasOneUse() && 161 (I->getOpcode() == Opcode1 || I->getOpcode() == Opcode2)) 162 if (!isa<FPMathOperator>(I) || I->isFast()) 163 return cast<BinaryOperator>(I); 164 return nullptr; 165 } 166 167 void ReassociatePass::BuildRankMap(Function &F, 168 ReversePostOrderTraversal<Function*> &RPOT) { 169 unsigned Rank = 2; 170 171 // Assign distinct ranks to function arguments. 172 for (auto &Arg : F.args()) { 173 ValueRankMap[&Arg] = ++Rank; 174 LLVM_DEBUG(dbgs() << "Calculated Rank[" << Arg.getName() << "] = " << Rank 175 << "\n"); 176 } 177 178 // Traverse basic blocks in ReversePostOrder. 179 for (BasicBlock *BB : RPOT) { 180 unsigned BBRank = RankMap[BB] = ++Rank << 16; 181 182 // Walk the basic block, adding precomputed ranks for any instructions that 183 // we cannot move. This ensures that the ranks for these instructions are 184 // all different in the block. 185 for (Instruction &I : *BB) 186 if (mayBeMemoryDependent(I)) 187 ValueRankMap[&I] = ++BBRank; 188 } 189 } 190 191 unsigned ReassociatePass::getRank(Value *V) { 192 Instruction *I = dyn_cast<Instruction>(V); 193 if (!I) { 194 if (isa<Argument>(V)) return ValueRankMap[V]; // Function argument. 195 return 0; // Otherwise it's a global or constant, rank 0. 196 } 197 198 if (unsigned Rank = ValueRankMap[I]) 199 return Rank; // Rank already known? 200 201 // If this is an expression, return the 1+MAX(rank(LHS), rank(RHS)) so that 202 // we can reassociate expressions for code motion! Since we do not recurse 203 // for PHI nodes, we cannot have infinite recursion here, because there 204 // cannot be loops in the value graph that do not go through PHI nodes. 205 unsigned Rank = 0, MaxRank = RankMap[I->getParent()]; 206 for (unsigned i = 0, e = I->getNumOperands(); i != e && Rank != MaxRank; ++i) 207 Rank = std::max(Rank, getRank(I->getOperand(i))); 208 209 // If this is a 'not' or 'neg' instruction, do not count it for rank. This 210 // assures us that X and ~X will have the same rank. 211 if (!match(I, m_Not(m_Value())) && !match(I, m_Neg(m_Value())) && 212 !match(I, m_FNeg(m_Value()))) 213 ++Rank; 214 215 LLVM_DEBUG(dbgs() << "Calculated Rank[" << V->getName() << "] = " << Rank 216 << "\n"); 217 218 return ValueRankMap[I] = Rank; 219 } 220 221 // Canonicalize constants to RHS. Otherwise, sort the operands by rank. 222 void ReassociatePass::canonicalizeOperands(Instruction *I) { 223 assert(isa<BinaryOperator>(I) && "Expected binary operator."); 224 assert(I->isCommutative() && "Expected commutative operator."); 225 226 Value *LHS = I->getOperand(0); 227 Value *RHS = I->getOperand(1); 228 if (LHS == RHS || isa<Constant>(RHS)) 229 return; 230 if (isa<Constant>(LHS) || getRank(RHS) < getRank(LHS)) 231 cast<BinaryOperator>(I)->swapOperands(); 232 } 233 234 static BinaryOperator *CreateAdd(Value *S1, Value *S2, const Twine &Name, 235 Instruction *InsertBefore, Value *FlagsOp) { 236 if (S1->getType()->isIntOrIntVectorTy()) 237 return BinaryOperator::CreateAdd(S1, S2, Name, InsertBefore); 238 else { 239 BinaryOperator *Res = 240 BinaryOperator::CreateFAdd(S1, S2, Name, InsertBefore); 241 Res->setFastMathFlags(cast<FPMathOperator>(FlagsOp)->getFastMathFlags()); 242 return Res; 243 } 244 } 245 246 static BinaryOperator *CreateMul(Value *S1, Value *S2, const Twine &Name, 247 Instruction *InsertBefore, Value *FlagsOp) { 248 if (S1->getType()->isIntOrIntVectorTy()) 249 return BinaryOperator::CreateMul(S1, S2, Name, InsertBefore); 250 else { 251 BinaryOperator *Res = 252 BinaryOperator::CreateFMul(S1, S2, Name, InsertBefore); 253 Res->setFastMathFlags(cast<FPMathOperator>(FlagsOp)->getFastMathFlags()); 254 return Res; 255 } 256 } 257 258 static Instruction *CreateNeg(Value *S1, const Twine &Name, 259 Instruction *InsertBefore, Value *FlagsOp) { 260 if (S1->getType()->isIntOrIntVectorTy()) 261 return BinaryOperator::CreateNeg(S1, Name, InsertBefore); 262 263 if (auto *FMFSource = dyn_cast<Instruction>(FlagsOp)) 264 return UnaryOperator::CreateFNegFMF(S1, FMFSource, Name, InsertBefore); 265 266 return UnaryOperator::CreateFNeg(S1, Name, InsertBefore); 267 } 268 269 /// Replace 0-X with X*-1. 270 static BinaryOperator *LowerNegateToMultiply(Instruction *Neg) { 271 assert((isa<UnaryOperator>(Neg) || isa<BinaryOperator>(Neg)) && 272 "Expected a Negate!"); 273 // FIXME: It's not safe to lower a unary FNeg into a FMul by -1.0. 274 unsigned OpNo = isa<BinaryOperator>(Neg) ? 1 : 0; 275 Type *Ty = Neg->getType(); 276 Constant *NegOne = Ty->isIntOrIntVectorTy() ? 277 ConstantInt::getAllOnesValue(Ty) : ConstantFP::get(Ty, -1.0); 278 279 BinaryOperator *Res = CreateMul(Neg->getOperand(OpNo), NegOne, "", Neg, Neg); 280 Neg->setOperand(OpNo, Constant::getNullValue(Ty)); // Drop use of op. 281 Res->takeName(Neg); 282 Neg->replaceAllUsesWith(Res); 283 Res->setDebugLoc(Neg->getDebugLoc()); 284 return Res; 285 } 286 287 /// Returns k such that lambda(2^Bitwidth) = 2^k, where lambda is the Carmichael 288 /// function. This means that x^(2^k) === 1 mod 2^Bitwidth for 289 /// every odd x, i.e. x^(2^k) = 1 for every odd x in Bitwidth-bit arithmetic. 290 /// Note that 0 <= k < Bitwidth, and if Bitwidth > 3 then x^(2^k) = 0 for every 291 /// even x in Bitwidth-bit arithmetic. 292 static unsigned CarmichaelShift(unsigned Bitwidth) { 293 if (Bitwidth < 3) 294 return Bitwidth - 1; 295 return Bitwidth - 2; 296 } 297 298 /// Add the extra weight 'RHS' to the existing weight 'LHS', 299 /// reducing the combined weight using any special properties of the operation. 300 /// The existing weight LHS represents the computation X op X op ... op X where 301 /// X occurs LHS times. The combined weight represents X op X op ... op X with 302 /// X occurring LHS + RHS times. If op is "Xor" for example then the combined 303 /// operation is equivalent to X if LHS + RHS is odd, or 0 if LHS + RHS is even; 304 /// the routine returns 1 in LHS in the first case, and 0 in LHS in the second. 305 static void IncorporateWeight(APInt &LHS, const APInt &RHS, unsigned Opcode) { 306 // If we were working with infinite precision arithmetic then the combined 307 // weight would be LHS + RHS. But we are using finite precision arithmetic, 308 // and the APInt sum LHS + RHS may not be correct if it wraps (it is correct 309 // for nilpotent operations and addition, but not for idempotent operations 310 // and multiplication), so it is important to correctly reduce the combined 311 // weight back into range if wrapping would be wrong. 312 313 // If RHS is zero then the weight didn't change. 314 if (RHS.isMinValue()) 315 return; 316 // If LHS is zero then the combined weight is RHS. 317 if (LHS.isMinValue()) { 318 LHS = RHS; 319 return; 320 } 321 // From this point on we know that neither LHS nor RHS is zero. 322 323 if (Instruction::isIdempotent(Opcode)) { 324 // Idempotent means X op X === X, so any non-zero weight is equivalent to a 325 // weight of 1. Keeping weights at zero or one also means that wrapping is 326 // not a problem. 327 assert(LHS == 1 && RHS == 1 && "Weights not reduced!"); 328 return; // Return a weight of 1. 329 } 330 if (Instruction::isNilpotent(Opcode)) { 331 // Nilpotent means X op X === 0, so reduce weights modulo 2. 332 assert(LHS == 1 && RHS == 1 && "Weights not reduced!"); 333 LHS = 0; // 1 + 1 === 0 modulo 2. 334 return; 335 } 336 if (Opcode == Instruction::Add || Opcode == Instruction::FAdd) { 337 // TODO: Reduce the weight by exploiting nsw/nuw? 338 LHS += RHS; 339 return; 340 } 341 342 assert((Opcode == Instruction::Mul || Opcode == Instruction::FMul) && 343 "Unknown associative operation!"); 344 unsigned Bitwidth = LHS.getBitWidth(); 345 // If CM is the Carmichael number then a weight W satisfying W >= CM+Bitwidth 346 // can be replaced with W-CM. That's because x^W=x^(W-CM) for every Bitwidth 347 // bit number x, since either x is odd in which case x^CM = 1, or x is even in 348 // which case both x^W and x^(W - CM) are zero. By subtracting off multiples 349 // of CM like this weights can always be reduced to the range [0, CM+Bitwidth) 350 // which by a happy accident means that they can always be represented using 351 // Bitwidth bits. 352 // TODO: Reduce the weight by exploiting nsw/nuw? (Could do much better than 353 // the Carmichael number). 354 if (Bitwidth > 3) { 355 /// CM - The value of Carmichael's lambda function. 356 APInt CM = APInt::getOneBitSet(Bitwidth, CarmichaelShift(Bitwidth)); 357 // Any weight W >= Threshold can be replaced with W - CM. 358 APInt Threshold = CM + Bitwidth; 359 assert(LHS.ult(Threshold) && RHS.ult(Threshold) && "Weights not reduced!"); 360 // For Bitwidth 4 or more the following sum does not overflow. 361 LHS += RHS; 362 while (LHS.uge(Threshold)) 363 LHS -= CM; 364 } else { 365 // To avoid problems with overflow do everything the same as above but using 366 // a larger type. 367 unsigned CM = 1U << CarmichaelShift(Bitwidth); 368 unsigned Threshold = CM + Bitwidth; 369 assert(LHS.getZExtValue() < Threshold && RHS.getZExtValue() < Threshold && 370 "Weights not reduced!"); 371 unsigned Total = LHS.getZExtValue() + RHS.getZExtValue(); 372 while (Total >= Threshold) 373 Total -= CM; 374 LHS = Total; 375 } 376 } 377 378 using RepeatedValue = std::pair<Value*, APInt>; 379 380 /// Given an associative binary expression, return the leaf 381 /// nodes in Ops along with their weights (how many times the leaf occurs). The 382 /// original expression is the same as 383 /// (Ops[0].first op Ops[0].first op ... Ops[0].first) <- Ops[0].second times 384 /// op 385 /// (Ops[1].first op Ops[1].first op ... Ops[1].first) <- Ops[1].second times 386 /// op 387 /// ... 388 /// op 389 /// (Ops[N].first op Ops[N].first op ... Ops[N].first) <- Ops[N].second times 390 /// 391 /// Note that the values Ops[0].first, ..., Ops[N].first are all distinct. 392 /// 393 /// This routine may modify the function, in which case it returns 'true'. The 394 /// changes it makes may well be destructive, changing the value computed by 'I' 395 /// to something completely different. Thus if the routine returns 'true' then 396 /// you MUST either replace I with a new expression computed from the Ops array, 397 /// or use RewriteExprTree to put the values back in. 398 /// 399 /// A leaf node is either not a binary operation of the same kind as the root 400 /// node 'I' (i.e. is not a binary operator at all, or is, but with a different 401 /// opcode), or is the same kind of binary operator but has a use which either 402 /// does not belong to the expression, or does belong to the expression but is 403 /// a leaf node. Every leaf node has at least one use that is a non-leaf node 404 /// of the expression, while for non-leaf nodes (except for the root 'I') every 405 /// use is a non-leaf node of the expression. 406 /// 407 /// For example: 408 /// expression graph node names 409 /// 410 /// + | I 411 /// / \ | 412 /// + + | A, B 413 /// / \ / \ | 414 /// * + * | C, D, E 415 /// / \ / \ / \ | 416 /// + * | F, G 417 /// 418 /// The leaf nodes are C, E, F and G. The Ops array will contain (maybe not in 419 /// that order) (C, 1), (E, 1), (F, 2), (G, 2). 420 /// 421 /// The expression is maximal: if some instruction is a binary operator of the 422 /// same kind as 'I', and all of its uses are non-leaf nodes of the expression, 423 /// then the instruction also belongs to the expression, is not a leaf node of 424 /// it, and its operands also belong to the expression (but may be leaf nodes). 425 /// 426 /// NOTE: This routine will set operands of non-leaf non-root nodes to undef in 427 /// order to ensure that every non-root node in the expression has *exactly one* 428 /// use by a non-leaf node of the expression. This destruction means that the 429 /// caller MUST either replace 'I' with a new expression or use something like 430 /// RewriteExprTree to put the values back in if the routine indicates that it 431 /// made a change by returning 'true'. 432 /// 433 /// In the above example either the right operand of A or the left operand of B 434 /// will be replaced by undef. If it is B's operand then this gives: 435 /// 436 /// + | I 437 /// / \ | 438 /// + + | A, B - operand of B replaced with undef 439 /// / \ \ | 440 /// * + * | C, D, E 441 /// / \ / \ / \ | 442 /// + * | F, G 443 /// 444 /// Note that such undef operands can only be reached by passing through 'I'. 445 /// For example, if you visit operands recursively starting from a leaf node 446 /// then you will never see such an undef operand unless you get back to 'I', 447 /// which requires passing through a phi node. 448 /// 449 /// Note that this routine may also mutate binary operators of the wrong type 450 /// that have all uses inside the expression (i.e. only used by non-leaf nodes 451 /// of the expression) if it can turn them into binary operators of the right 452 /// type and thus make the expression bigger. 453 static bool LinearizeExprTree(Instruction *I, 454 SmallVectorImpl<RepeatedValue> &Ops) { 455 assert((isa<UnaryOperator>(I) || isa<BinaryOperator>(I)) && 456 "Expected a UnaryOperator or BinaryOperator!"); 457 LLVM_DEBUG(dbgs() << "LINEARIZE: " << *I << '\n'); 458 unsigned Bitwidth = I->getType()->getScalarType()->getPrimitiveSizeInBits(); 459 unsigned Opcode = I->getOpcode(); 460 assert(I->isAssociative() && I->isCommutative() && 461 "Expected an associative and commutative operation!"); 462 463 // Visit all operands of the expression, keeping track of their weight (the 464 // number of paths from the expression root to the operand, or if you like 465 // the number of times that operand occurs in the linearized expression). 466 // For example, if I = X + A, where X = A + B, then I, X and B have weight 1 467 // while A has weight two. 468 469 // Worklist of non-leaf nodes (their operands are in the expression too) along 470 // with their weights, representing a certain number of paths to the operator. 471 // If an operator occurs in the worklist multiple times then we found multiple 472 // ways to get to it. 473 SmallVector<std::pair<Instruction*, APInt>, 8> Worklist; // (Op, Weight) 474 Worklist.push_back(std::make_pair(I, APInt(Bitwidth, 1))); 475 bool Changed = false; 476 477 // Leaves of the expression are values that either aren't the right kind of 478 // operation (eg: a constant, or a multiply in an add tree), or are, but have 479 // some uses that are not inside the expression. For example, in I = X + X, 480 // X = A + B, the value X has two uses (by I) that are in the expression. If 481 // X has any other uses, for example in a return instruction, then we consider 482 // X to be a leaf, and won't analyze it further. When we first visit a value, 483 // if it has more than one use then at first we conservatively consider it to 484 // be a leaf. Later, as the expression is explored, we may discover some more 485 // uses of the value from inside the expression. If all uses turn out to be 486 // from within the expression (and the value is a binary operator of the right 487 // kind) then the value is no longer considered to be a leaf, and its operands 488 // are explored. 489 490 // Leaves - Keeps track of the set of putative leaves as well as the number of 491 // paths to each leaf seen so far. 492 using LeafMap = DenseMap<Value *, APInt>; 493 LeafMap Leaves; // Leaf -> Total weight so far. 494 SmallVector<Value *, 8> LeafOrder; // Ensure deterministic leaf output order. 495 496 #ifndef NDEBUG 497 SmallPtrSet<Value *, 8> Visited; // For sanity checking the iteration scheme. 498 #endif 499 while (!Worklist.empty()) { 500 std::pair<Instruction*, APInt> P = Worklist.pop_back_val(); 501 I = P.first; // We examine the operands of this binary operator. 502 503 for (unsigned OpIdx = 0; OpIdx < I->getNumOperands(); ++OpIdx) { // Visit operands. 504 Value *Op = I->getOperand(OpIdx); 505 APInt Weight = P.second; // Number of paths to this operand. 506 LLVM_DEBUG(dbgs() << "OPERAND: " << *Op << " (" << Weight << ")\n"); 507 assert(!Op->use_empty() && "No uses, so how did we get to it?!"); 508 509 // If this is a binary operation of the right kind with only one use then 510 // add its operands to the expression. 511 if (BinaryOperator *BO = isReassociableOp(Op, Opcode)) { 512 assert(Visited.insert(Op).second && "Not first visit!"); 513 LLVM_DEBUG(dbgs() << "DIRECT ADD: " << *Op << " (" << Weight << ")\n"); 514 Worklist.push_back(std::make_pair(BO, Weight)); 515 continue; 516 } 517 518 // Appears to be a leaf. Is the operand already in the set of leaves? 519 LeafMap::iterator It = Leaves.find(Op); 520 if (It == Leaves.end()) { 521 // Not in the leaf map. Must be the first time we saw this operand. 522 assert(Visited.insert(Op).second && "Not first visit!"); 523 if (!Op->hasOneUse()) { 524 // This value has uses not accounted for by the expression, so it is 525 // not safe to modify. Mark it as being a leaf. 526 LLVM_DEBUG(dbgs() 527 << "ADD USES LEAF: " << *Op << " (" << Weight << ")\n"); 528 LeafOrder.push_back(Op); 529 Leaves[Op] = Weight; 530 continue; 531 } 532 // No uses outside the expression, try morphing it. 533 } else { 534 // Already in the leaf map. 535 assert(It != Leaves.end() && Visited.count(Op) && 536 "In leaf map but not visited!"); 537 538 // Update the number of paths to the leaf. 539 IncorporateWeight(It->second, Weight, Opcode); 540 541 #if 0 // TODO: Re-enable once PR13021 is fixed. 542 // The leaf already has one use from inside the expression. As we want 543 // exactly one such use, drop this new use of the leaf. 544 assert(!Op->hasOneUse() && "Only one use, but we got here twice!"); 545 I->setOperand(OpIdx, UndefValue::get(I->getType())); 546 Changed = true; 547 548 // If the leaf is a binary operation of the right kind and we now see 549 // that its multiple original uses were in fact all by nodes belonging 550 // to the expression, then no longer consider it to be a leaf and add 551 // its operands to the expression. 552 if (BinaryOperator *BO = isReassociableOp(Op, Opcode)) { 553 LLVM_DEBUG(dbgs() << "UNLEAF: " << *Op << " (" << It->second << ")\n"); 554 Worklist.push_back(std::make_pair(BO, It->second)); 555 Leaves.erase(It); 556 continue; 557 } 558 #endif 559 560 // If we still have uses that are not accounted for by the expression 561 // then it is not safe to modify the value. 562 if (!Op->hasOneUse()) 563 continue; 564 565 // No uses outside the expression, try morphing it. 566 Weight = It->second; 567 Leaves.erase(It); // Since the value may be morphed below. 568 } 569 570 // At this point we have a value which, first of all, is not a binary 571 // expression of the right kind, and secondly, is only used inside the 572 // expression. This means that it can safely be modified. See if we 573 // can usefully morph it into an expression of the right kind. 574 assert((!isa<Instruction>(Op) || 575 cast<Instruction>(Op)->getOpcode() != Opcode 576 || (isa<FPMathOperator>(Op) && 577 !cast<Instruction>(Op)->isFast())) && 578 "Should have been handled above!"); 579 assert(Op->hasOneUse() && "Has uses outside the expression tree!"); 580 581 // If this is a multiply expression, turn any internal negations into 582 // multiplies by -1 so they can be reassociated. 583 if (Instruction *Tmp = dyn_cast<Instruction>(Op)) 584 if ((Opcode == Instruction::Mul && match(Tmp, m_Neg(m_Value()))) || 585 (Opcode == Instruction::FMul && match(Tmp, m_FNeg(m_Value())))) { 586 LLVM_DEBUG(dbgs() 587 << "MORPH LEAF: " << *Op << " (" << Weight << ") TO "); 588 Tmp = LowerNegateToMultiply(Tmp); 589 LLVM_DEBUG(dbgs() << *Tmp << '\n'); 590 Worklist.push_back(std::make_pair(Tmp, Weight)); 591 Changed = true; 592 continue; 593 } 594 595 // Failed to morph into an expression of the right type. This really is 596 // a leaf. 597 LLVM_DEBUG(dbgs() << "ADD LEAF: " << *Op << " (" << Weight << ")\n"); 598 assert(!isReassociableOp(Op, Opcode) && "Value was morphed?"); 599 LeafOrder.push_back(Op); 600 Leaves[Op] = Weight; 601 } 602 } 603 604 // The leaves, repeated according to their weights, represent the linearized 605 // form of the expression. 606 for (unsigned i = 0, e = LeafOrder.size(); i != e; ++i) { 607 Value *V = LeafOrder[i]; 608 LeafMap::iterator It = Leaves.find(V); 609 if (It == Leaves.end()) 610 // Node initially thought to be a leaf wasn't. 611 continue; 612 assert(!isReassociableOp(V, Opcode) && "Shouldn't be a leaf!"); 613 APInt Weight = It->second; 614 if (Weight.isMinValue()) 615 // Leaf already output or weight reduction eliminated it. 616 continue; 617 // Ensure the leaf is only output once. 618 It->second = 0; 619 Ops.push_back(std::make_pair(V, Weight)); 620 } 621 622 // For nilpotent operations or addition there may be no operands, for example 623 // because the expression was "X xor X" or consisted of 2^Bitwidth additions: 624 // in both cases the weight reduces to 0 causing the value to be skipped. 625 if (Ops.empty()) { 626 Constant *Identity = ConstantExpr::getBinOpIdentity(Opcode, I->getType()); 627 assert(Identity && "Associative operation without identity!"); 628 Ops.emplace_back(Identity, APInt(Bitwidth, 1)); 629 } 630 631 return Changed; 632 } 633 634 /// Now that the operands for this expression tree are 635 /// linearized and optimized, emit them in-order. 636 void ReassociatePass::RewriteExprTree(BinaryOperator *I, 637 SmallVectorImpl<ValueEntry> &Ops) { 638 assert(Ops.size() > 1 && "Single values should be used directly!"); 639 640 // Since our optimizations should never increase the number of operations, the 641 // new expression can usually be written reusing the existing binary operators 642 // from the original expression tree, without creating any new instructions, 643 // though the rewritten expression may have a completely different topology. 644 // We take care to not change anything if the new expression will be the same 645 // as the original. If more than trivial changes (like commuting operands) 646 // were made then we are obliged to clear out any optional subclass data like 647 // nsw flags. 648 649 /// NodesToRewrite - Nodes from the original expression available for writing 650 /// the new expression into. 651 SmallVector<BinaryOperator*, 8> NodesToRewrite; 652 unsigned Opcode = I->getOpcode(); 653 BinaryOperator *Op = I; 654 655 /// NotRewritable - The operands being written will be the leaves of the new 656 /// expression and must not be used as inner nodes (via NodesToRewrite) by 657 /// mistake. Inner nodes are always reassociable, and usually leaves are not 658 /// (if they were they would have been incorporated into the expression and so 659 /// would not be leaves), so most of the time there is no danger of this. But 660 /// in rare cases a leaf may become reassociable if an optimization kills uses 661 /// of it, or it may momentarily become reassociable during rewriting (below) 662 /// due it being removed as an operand of one of its uses. Ensure that misuse 663 /// of leaf nodes as inner nodes cannot occur by remembering all of the future 664 /// leaves and refusing to reuse any of them as inner nodes. 665 SmallPtrSet<Value*, 8> NotRewritable; 666 for (unsigned i = 0, e = Ops.size(); i != e; ++i) 667 NotRewritable.insert(Ops[i].Op); 668 669 // ExpressionChanged - Non-null if the rewritten expression differs from the 670 // original in some non-trivial way, requiring the clearing of optional flags. 671 // Flags are cleared from the operator in ExpressionChanged up to I inclusive. 672 BinaryOperator *ExpressionChanged = nullptr; 673 for (unsigned i = 0; ; ++i) { 674 // The last operation (which comes earliest in the IR) is special as both 675 // operands will come from Ops, rather than just one with the other being 676 // a subexpression. 677 if (i+2 == Ops.size()) { 678 Value *NewLHS = Ops[i].Op; 679 Value *NewRHS = Ops[i+1].Op; 680 Value *OldLHS = Op->getOperand(0); 681 Value *OldRHS = Op->getOperand(1); 682 683 if (NewLHS == OldLHS && NewRHS == OldRHS) 684 // Nothing changed, leave it alone. 685 break; 686 687 if (NewLHS == OldRHS && NewRHS == OldLHS) { 688 // The order of the operands was reversed. Swap them. 689 LLVM_DEBUG(dbgs() << "RA: " << *Op << '\n'); 690 Op->swapOperands(); 691 LLVM_DEBUG(dbgs() << "TO: " << *Op << '\n'); 692 MadeChange = true; 693 ++NumChanged; 694 break; 695 } 696 697 // The new operation differs non-trivially from the original. Overwrite 698 // the old operands with the new ones. 699 LLVM_DEBUG(dbgs() << "RA: " << *Op << '\n'); 700 if (NewLHS != OldLHS) { 701 BinaryOperator *BO = isReassociableOp(OldLHS, Opcode); 702 if (BO && !NotRewritable.count(BO)) 703 NodesToRewrite.push_back(BO); 704 Op->setOperand(0, NewLHS); 705 } 706 if (NewRHS != OldRHS) { 707 BinaryOperator *BO = isReassociableOp(OldRHS, Opcode); 708 if (BO && !NotRewritable.count(BO)) 709 NodesToRewrite.push_back(BO); 710 Op->setOperand(1, NewRHS); 711 } 712 LLVM_DEBUG(dbgs() << "TO: " << *Op << '\n'); 713 714 ExpressionChanged = Op; 715 MadeChange = true; 716 ++NumChanged; 717 718 break; 719 } 720 721 // Not the last operation. The left-hand side will be a sub-expression 722 // while the right-hand side will be the current element of Ops. 723 Value *NewRHS = Ops[i].Op; 724 if (NewRHS != Op->getOperand(1)) { 725 LLVM_DEBUG(dbgs() << "RA: " << *Op << '\n'); 726 if (NewRHS == Op->getOperand(0)) { 727 // The new right-hand side was already present as the left operand. If 728 // we are lucky then swapping the operands will sort out both of them. 729 Op->swapOperands(); 730 } else { 731 // Overwrite with the new right-hand side. 732 BinaryOperator *BO = isReassociableOp(Op->getOperand(1), Opcode); 733 if (BO && !NotRewritable.count(BO)) 734 NodesToRewrite.push_back(BO); 735 Op->setOperand(1, NewRHS); 736 ExpressionChanged = Op; 737 } 738 LLVM_DEBUG(dbgs() << "TO: " << *Op << '\n'); 739 MadeChange = true; 740 ++NumChanged; 741 } 742 743 // Now deal with the left-hand side. If this is already an operation node 744 // from the original expression then just rewrite the rest of the expression 745 // into it. 746 BinaryOperator *BO = isReassociableOp(Op->getOperand(0), Opcode); 747 if (BO && !NotRewritable.count(BO)) { 748 Op = BO; 749 continue; 750 } 751 752 // Otherwise, grab a spare node from the original expression and use that as 753 // the left-hand side. If there are no nodes left then the optimizers made 754 // an expression with more nodes than the original! This usually means that 755 // they did something stupid but it might mean that the problem was just too 756 // hard (finding the mimimal number of multiplications needed to realize a 757 // multiplication expression is NP-complete). Whatever the reason, smart or 758 // stupid, create a new node if there are none left. 759 BinaryOperator *NewOp; 760 if (NodesToRewrite.empty()) { 761 Constant *Undef = UndefValue::get(I->getType()); 762 NewOp = BinaryOperator::Create(Instruction::BinaryOps(Opcode), 763 Undef, Undef, "", I); 764 if (NewOp->getType()->isFPOrFPVectorTy()) 765 NewOp->setFastMathFlags(I->getFastMathFlags()); 766 } else { 767 NewOp = NodesToRewrite.pop_back_val(); 768 } 769 770 LLVM_DEBUG(dbgs() << "RA: " << *Op << '\n'); 771 Op->setOperand(0, NewOp); 772 LLVM_DEBUG(dbgs() << "TO: " << *Op << '\n'); 773 ExpressionChanged = Op; 774 MadeChange = true; 775 ++NumChanged; 776 Op = NewOp; 777 } 778 779 // If the expression changed non-trivially then clear out all subclass data 780 // starting from the operator specified in ExpressionChanged, and compactify 781 // the operators to just before the expression root to guarantee that the 782 // expression tree is dominated by all of Ops. 783 if (ExpressionChanged) 784 do { 785 // Preserve FastMathFlags. 786 if (isa<FPMathOperator>(I)) { 787 FastMathFlags Flags = I->getFastMathFlags(); 788 ExpressionChanged->clearSubclassOptionalData(); 789 ExpressionChanged->setFastMathFlags(Flags); 790 } else 791 ExpressionChanged->clearSubclassOptionalData(); 792 793 if (ExpressionChanged == I) 794 break; 795 796 // Discard any debug info related to the expressions that has changed (we 797 // can leave debug infor related to the root, since the result of the 798 // expression tree should be the same even after reassociation). 799 replaceDbgUsesWithUndef(ExpressionChanged); 800 801 ExpressionChanged->moveBefore(I); 802 ExpressionChanged = cast<BinaryOperator>(*ExpressionChanged->user_begin()); 803 } while (true); 804 805 // Throw away any left over nodes from the original expression. 806 for (unsigned i = 0, e = NodesToRewrite.size(); i != e; ++i) 807 RedoInsts.insert(NodesToRewrite[i]); 808 } 809 810 /// Insert instructions before the instruction pointed to by BI, 811 /// that computes the negative version of the value specified. The negative 812 /// version of the value is returned, and BI is left pointing at the instruction 813 /// that should be processed next by the reassociation pass. 814 /// Also add intermediate instructions to the redo list that are modified while 815 /// pushing the negates through adds. These will be revisited to see if 816 /// additional opportunities have been exposed. 817 static Value *NegateValue(Value *V, Instruction *BI, 818 ReassociatePass::OrderedSet &ToRedo) { 819 if (auto *C = dyn_cast<Constant>(V)) 820 return C->getType()->isFPOrFPVectorTy() ? ConstantExpr::getFNeg(C) : 821 ConstantExpr::getNeg(C); 822 823 // We are trying to expose opportunity for reassociation. One of the things 824 // that we want to do to achieve this is to push a negation as deep into an 825 // expression chain as possible, to expose the add instructions. In practice, 826 // this means that we turn this: 827 // X = -(A+12+C+D) into X = -A + -12 + -C + -D = -12 + -A + -C + -D 828 // so that later, a: Y = 12+X could get reassociated with the -12 to eliminate 829 // the constants. We assume that instcombine will clean up the mess later if 830 // we introduce tons of unnecessary negation instructions. 831 // 832 if (BinaryOperator *I = 833 isReassociableOp(V, Instruction::Add, Instruction::FAdd)) { 834 // Push the negates through the add. 835 I->setOperand(0, NegateValue(I->getOperand(0), BI, ToRedo)); 836 I->setOperand(1, NegateValue(I->getOperand(1), BI, ToRedo)); 837 if (I->getOpcode() == Instruction::Add) { 838 I->setHasNoUnsignedWrap(false); 839 I->setHasNoSignedWrap(false); 840 } 841 842 // We must move the add instruction here, because the neg instructions do 843 // not dominate the old add instruction in general. By moving it, we are 844 // assured that the neg instructions we just inserted dominate the 845 // instruction we are about to insert after them. 846 // 847 I->moveBefore(BI); 848 I->setName(I->getName()+".neg"); 849 850 // Add the intermediate negates to the redo list as processing them later 851 // could expose more reassociating opportunities. 852 ToRedo.insert(I); 853 return I; 854 } 855 856 // Okay, we need to materialize a negated version of V with an instruction. 857 // Scan the use lists of V to see if we have one already. 858 for (User *U : V->users()) { 859 if (!match(U, m_Neg(m_Value())) && !match(U, m_FNeg(m_Value()))) 860 continue; 861 862 // We found one! Now we have to make sure that the definition dominates 863 // this use. We do this by moving it to the entry block (if it is a 864 // non-instruction value) or right after the definition. These negates will 865 // be zapped by reassociate later, so we don't need much finesse here. 866 Instruction *TheNeg = cast<Instruction>(U); 867 868 // Verify that the negate is in this function, V might be a constant expr. 869 if (TheNeg->getParent()->getParent() != BI->getParent()->getParent()) 870 continue; 871 872 bool FoundCatchSwitch = false; 873 874 BasicBlock::iterator InsertPt; 875 if (Instruction *InstInput = dyn_cast<Instruction>(V)) { 876 if (InvokeInst *II = dyn_cast<InvokeInst>(InstInput)) { 877 InsertPt = II->getNormalDest()->begin(); 878 } else { 879 InsertPt = ++InstInput->getIterator(); 880 } 881 882 const BasicBlock *BB = InsertPt->getParent(); 883 884 // Make sure we don't move anything before PHIs or exception 885 // handling pads. 886 while (InsertPt != BB->end() && (isa<PHINode>(InsertPt) || 887 InsertPt->isEHPad())) { 888 if (isa<CatchSwitchInst>(InsertPt)) 889 // A catchswitch cannot have anything in the block except 890 // itself and PHIs. We'll bail out below. 891 FoundCatchSwitch = true; 892 ++InsertPt; 893 } 894 } else { 895 InsertPt = TheNeg->getParent()->getParent()->getEntryBlock().begin(); 896 } 897 898 // We found a catchswitch in the block where we want to move the 899 // neg. We cannot move anything into that block. Bail and just 900 // create the neg before BI, as if we hadn't found an existing 901 // neg. 902 if (FoundCatchSwitch) 903 break; 904 905 TheNeg->moveBefore(&*InsertPt); 906 if (TheNeg->getOpcode() == Instruction::Sub) { 907 TheNeg->setHasNoUnsignedWrap(false); 908 TheNeg->setHasNoSignedWrap(false); 909 } else { 910 TheNeg->andIRFlags(BI); 911 } 912 ToRedo.insert(TheNeg); 913 return TheNeg; 914 } 915 916 // Insert a 'neg' instruction that subtracts the value from zero to get the 917 // negation. 918 Instruction *NewNeg = CreateNeg(V, V->getName() + ".neg", BI, BI); 919 ToRedo.insert(NewNeg); 920 return NewNeg; 921 } 922 923 // See if this `or` looks like an load widening reduction, i.e. that it 924 // consists of an `or`/`shl`/`zext`/`load` nodes only. Note that we don't 925 // ensure that the pattern is *really* a load widening reduction, 926 // we do not ensure that it can really be replaced with a widened load, 927 // only that it mostly looks like one. 928 static bool isLoadCombineCandidate(Instruction *Or) { 929 SmallVector<Instruction *, 8> Worklist; 930 SmallSet<Instruction *, 8> Visited; 931 932 auto Enqueue = [&](Value *V) { 933 auto *I = dyn_cast<Instruction>(V); 934 // Each node of an `or` reduction must be an instruction, 935 if (!I) 936 return false; // Node is certainly not part of an `or` load reduction. 937 // Only process instructions we have never processed before. 938 if (Visited.insert(I).second) 939 Worklist.emplace_back(I); 940 return true; // Will need to look at parent nodes. 941 }; 942 943 if (!Enqueue(Or)) 944 return false; // Not an `or` reduction pattern. 945 946 while (!Worklist.empty()) { 947 auto *I = Worklist.pop_back_val(); 948 949 // Okay, which instruction is this node? 950 switch (I->getOpcode()) { 951 case Instruction::Or: 952 // Got an `or` node. That's fine, just recurse into it's operands. 953 for (Value *Op : I->operands()) 954 if (!Enqueue(Op)) 955 return false; // Not an `or` reduction pattern. 956 continue; 957 958 case Instruction::Shl: 959 case Instruction::ZExt: 960 // `shl`/`zext` nodes are fine, just recurse into their base operand. 961 if (!Enqueue(I->getOperand(0))) 962 return false; // Not an `or` reduction pattern. 963 continue; 964 965 case Instruction::Load: 966 // Perfect, `load` node means we've reached an edge of the graph. 967 continue; 968 969 default: // Unknown node. 970 return false; // Not an `or` reduction pattern. 971 } 972 } 973 974 return true; 975 } 976 977 /// Return true if it may be profitable to convert this (X|Y) into (X+Y). 978 static bool ShouldConvertOrWithNoCommonBitsToAdd(Instruction *Or) { 979 // If this `or` appears to be a part of an load widening reduction, ignore it. 980 if (isLoadCombineCandidate(Or)) 981 return false; 982 983 // Don't bother to convert this up unless either the LHS is an associable add 984 // or subtract or mul or if this is only used by one of the above. 985 // This is only a compile-time improvement, it is not needed for correctness! 986 auto isInteresting = [](Value *V) { 987 for (auto Op : {Instruction::Add, Instruction::Sub, Instruction::Mul}) 988 if (isReassociableOp(V, Op)) 989 return true; 990 return false; 991 }; 992 993 if (any_of(Or->operands(), isInteresting)) 994 return true; 995 996 Value *VB = Or->user_back(); 997 if (Or->hasOneUse() && isInteresting(VB)) 998 return true; 999 1000 return false; 1001 } 1002 1003 /// If we have (X|Y), and iff X and Y have no common bits set, 1004 /// transform this into (X+Y) to allow arithmetics reassociation. 1005 static BinaryOperator *ConvertOrWithNoCommonBitsToAdd(Instruction *Or) { 1006 // Convert an or into an add. 1007 BinaryOperator *New = 1008 CreateAdd(Or->getOperand(0), Or->getOperand(1), "", Or, Or); 1009 New->setHasNoSignedWrap(); 1010 New->setHasNoUnsignedWrap(); 1011 New->takeName(Or); 1012 1013 // Everyone now refers to the add instruction. 1014 Or->replaceAllUsesWith(New); 1015 New->setDebugLoc(Or->getDebugLoc()); 1016 1017 LLVM_DEBUG(dbgs() << "Converted or into an add: " << *New << '\n'); 1018 return New; 1019 } 1020 1021 /// Return true if we should break up this subtract of X-Y into (X + -Y). 1022 static bool ShouldBreakUpSubtract(Instruction *Sub) { 1023 // If this is a negation, we can't split it up! 1024 if (match(Sub, m_Neg(m_Value())) || match(Sub, m_FNeg(m_Value()))) 1025 return false; 1026 1027 // Don't breakup X - undef. 1028 if (isa<UndefValue>(Sub->getOperand(1))) 1029 return false; 1030 1031 // Don't bother to break this up unless either the LHS is an associable add or 1032 // subtract or if this is only used by one. 1033 Value *V0 = Sub->getOperand(0); 1034 if (isReassociableOp(V0, Instruction::Add, Instruction::FAdd) || 1035 isReassociableOp(V0, Instruction::Sub, Instruction::FSub)) 1036 return true; 1037 Value *V1 = Sub->getOperand(1); 1038 if (isReassociableOp(V1, Instruction::Add, Instruction::FAdd) || 1039 isReassociableOp(V1, Instruction::Sub, Instruction::FSub)) 1040 return true; 1041 Value *VB = Sub->user_back(); 1042 if (Sub->hasOneUse() && 1043 (isReassociableOp(VB, Instruction::Add, Instruction::FAdd) || 1044 isReassociableOp(VB, Instruction::Sub, Instruction::FSub))) 1045 return true; 1046 1047 return false; 1048 } 1049 1050 /// If we have (X-Y), and if either X is an add, or if this is only used by an 1051 /// add, transform this into (X+(0-Y)) to promote better reassociation. 1052 static BinaryOperator *BreakUpSubtract(Instruction *Sub, 1053 ReassociatePass::OrderedSet &ToRedo) { 1054 // Convert a subtract into an add and a neg instruction. This allows sub 1055 // instructions to be commuted with other add instructions. 1056 // 1057 // Calculate the negative value of Operand 1 of the sub instruction, 1058 // and set it as the RHS of the add instruction we just made. 1059 Value *NegVal = NegateValue(Sub->getOperand(1), Sub, ToRedo); 1060 BinaryOperator *New = CreateAdd(Sub->getOperand(0), NegVal, "", Sub, Sub); 1061 Sub->setOperand(0, Constant::getNullValue(Sub->getType())); // Drop use of op. 1062 Sub->setOperand(1, Constant::getNullValue(Sub->getType())); // Drop use of op. 1063 New->takeName(Sub); 1064 1065 // Everyone now refers to the add instruction. 1066 Sub->replaceAllUsesWith(New); 1067 New->setDebugLoc(Sub->getDebugLoc()); 1068 1069 LLVM_DEBUG(dbgs() << "Negated: " << *New << '\n'); 1070 return New; 1071 } 1072 1073 /// If this is a shift of a reassociable multiply or is used by one, change 1074 /// this into a multiply by a constant to assist with further reassociation. 1075 static BinaryOperator *ConvertShiftToMul(Instruction *Shl) { 1076 Constant *MulCst = ConstantInt::get(Shl->getType(), 1); 1077 auto *SA = cast<ConstantInt>(Shl->getOperand(1)); 1078 MulCst = ConstantExpr::getShl(MulCst, SA); 1079 1080 BinaryOperator *Mul = 1081 BinaryOperator::CreateMul(Shl->getOperand(0), MulCst, "", Shl); 1082 Shl->setOperand(0, UndefValue::get(Shl->getType())); // Drop use of op. 1083 Mul->takeName(Shl); 1084 1085 // Everyone now refers to the mul instruction. 1086 Shl->replaceAllUsesWith(Mul); 1087 Mul->setDebugLoc(Shl->getDebugLoc()); 1088 1089 // We can safely preserve the nuw flag in all cases. It's also safe to turn a 1090 // nuw nsw shl into a nuw nsw mul. However, nsw in isolation requires special 1091 // handling. It can be preserved as long as we're not left shifting by 1092 // bitwidth - 1. 1093 bool NSW = cast<BinaryOperator>(Shl)->hasNoSignedWrap(); 1094 bool NUW = cast<BinaryOperator>(Shl)->hasNoUnsignedWrap(); 1095 unsigned BitWidth = Shl->getType()->getIntegerBitWidth(); 1096 if (NSW && (NUW || SA->getValue().ult(BitWidth - 1))) 1097 Mul->setHasNoSignedWrap(true); 1098 Mul->setHasNoUnsignedWrap(NUW); 1099 return Mul; 1100 } 1101 1102 /// Scan backwards and forwards among values with the same rank as element i 1103 /// to see if X exists. If X does not exist, return i. This is useful when 1104 /// scanning for 'x' when we see '-x' because they both get the same rank. 1105 static unsigned FindInOperandList(const SmallVectorImpl<ValueEntry> &Ops, 1106 unsigned i, Value *X) { 1107 unsigned XRank = Ops[i].Rank; 1108 unsigned e = Ops.size(); 1109 for (unsigned j = i+1; j != e && Ops[j].Rank == XRank; ++j) { 1110 if (Ops[j].Op == X) 1111 return j; 1112 if (Instruction *I1 = dyn_cast<Instruction>(Ops[j].Op)) 1113 if (Instruction *I2 = dyn_cast<Instruction>(X)) 1114 if (I1->isIdenticalTo(I2)) 1115 return j; 1116 } 1117 // Scan backwards. 1118 for (unsigned j = i-1; j != ~0U && Ops[j].Rank == XRank; --j) { 1119 if (Ops[j].Op == X) 1120 return j; 1121 if (Instruction *I1 = dyn_cast<Instruction>(Ops[j].Op)) 1122 if (Instruction *I2 = dyn_cast<Instruction>(X)) 1123 if (I1->isIdenticalTo(I2)) 1124 return j; 1125 } 1126 return i; 1127 } 1128 1129 /// Emit a tree of add instructions, summing Ops together 1130 /// and returning the result. Insert the tree before I. 1131 static Value *EmitAddTreeOfValues(Instruction *I, 1132 SmallVectorImpl<WeakTrackingVH> &Ops) { 1133 if (Ops.size() == 1) return Ops.back(); 1134 1135 Value *V1 = Ops.back(); 1136 Ops.pop_back(); 1137 Value *V2 = EmitAddTreeOfValues(I, Ops); 1138 return CreateAdd(V2, V1, "reass.add", I, I); 1139 } 1140 1141 /// If V is an expression tree that is a multiplication sequence, 1142 /// and if this sequence contains a multiply by Factor, 1143 /// remove Factor from the tree and return the new tree. 1144 Value *ReassociatePass::RemoveFactorFromExpression(Value *V, Value *Factor) { 1145 BinaryOperator *BO = isReassociableOp(V, Instruction::Mul, Instruction::FMul); 1146 if (!BO) 1147 return nullptr; 1148 1149 SmallVector<RepeatedValue, 8> Tree; 1150 MadeChange |= LinearizeExprTree(BO, Tree); 1151 SmallVector<ValueEntry, 8> Factors; 1152 Factors.reserve(Tree.size()); 1153 for (unsigned i = 0, e = Tree.size(); i != e; ++i) { 1154 RepeatedValue E = Tree[i]; 1155 Factors.append(E.second.getZExtValue(), 1156 ValueEntry(getRank(E.first), E.first)); 1157 } 1158 1159 bool FoundFactor = false; 1160 bool NeedsNegate = false; 1161 for (unsigned i = 0, e = Factors.size(); i != e; ++i) { 1162 if (Factors[i].Op == Factor) { 1163 FoundFactor = true; 1164 Factors.erase(Factors.begin()+i); 1165 break; 1166 } 1167 1168 // If this is a negative version of this factor, remove it. 1169 if (ConstantInt *FC1 = dyn_cast<ConstantInt>(Factor)) { 1170 if (ConstantInt *FC2 = dyn_cast<ConstantInt>(Factors[i].Op)) 1171 if (FC1->getValue() == -FC2->getValue()) { 1172 FoundFactor = NeedsNegate = true; 1173 Factors.erase(Factors.begin()+i); 1174 break; 1175 } 1176 } else if (ConstantFP *FC1 = dyn_cast<ConstantFP>(Factor)) { 1177 if (ConstantFP *FC2 = dyn_cast<ConstantFP>(Factors[i].Op)) { 1178 const APFloat &F1 = FC1->getValueAPF(); 1179 APFloat F2(FC2->getValueAPF()); 1180 F2.changeSign(); 1181 if (F1 == F2) { 1182 FoundFactor = NeedsNegate = true; 1183 Factors.erase(Factors.begin() + i); 1184 break; 1185 } 1186 } 1187 } 1188 } 1189 1190 if (!FoundFactor) { 1191 // Make sure to restore the operands to the expression tree. 1192 RewriteExprTree(BO, Factors); 1193 return nullptr; 1194 } 1195 1196 BasicBlock::iterator InsertPt = ++BO->getIterator(); 1197 1198 // If this was just a single multiply, remove the multiply and return the only 1199 // remaining operand. 1200 if (Factors.size() == 1) { 1201 RedoInsts.insert(BO); 1202 V = Factors[0].Op; 1203 } else { 1204 RewriteExprTree(BO, Factors); 1205 V = BO; 1206 } 1207 1208 if (NeedsNegate) 1209 V = CreateNeg(V, "neg", &*InsertPt, BO); 1210 1211 return V; 1212 } 1213 1214 /// If V is a single-use multiply, recursively add its operands as factors, 1215 /// otherwise add V to the list of factors. 1216 /// 1217 /// Ops is the top-level list of add operands we're trying to factor. 1218 static void FindSingleUseMultiplyFactors(Value *V, 1219 SmallVectorImpl<Value*> &Factors) { 1220 BinaryOperator *BO = isReassociableOp(V, Instruction::Mul, Instruction::FMul); 1221 if (!BO) { 1222 Factors.push_back(V); 1223 return; 1224 } 1225 1226 // Otherwise, add the LHS and RHS to the list of factors. 1227 FindSingleUseMultiplyFactors(BO->getOperand(1), Factors); 1228 FindSingleUseMultiplyFactors(BO->getOperand(0), Factors); 1229 } 1230 1231 /// Optimize a series of operands to an 'and', 'or', or 'xor' instruction. 1232 /// This optimizes based on identities. If it can be reduced to a single Value, 1233 /// it is returned, otherwise the Ops list is mutated as necessary. 1234 static Value *OptimizeAndOrXor(unsigned Opcode, 1235 SmallVectorImpl<ValueEntry> &Ops) { 1236 // Scan the operand lists looking for X and ~X pairs, along with X,X pairs. 1237 // If we find any, we can simplify the expression. X&~X == 0, X|~X == -1. 1238 for (unsigned i = 0, e = Ops.size(); i != e; ++i) { 1239 // First, check for X and ~X in the operand list. 1240 assert(i < Ops.size()); 1241 Value *X; 1242 if (match(Ops[i].Op, m_Not(m_Value(X)))) { // Cannot occur for ^. 1243 unsigned FoundX = FindInOperandList(Ops, i, X); 1244 if (FoundX != i) { 1245 if (Opcode == Instruction::And) // ...&X&~X = 0 1246 return Constant::getNullValue(X->getType()); 1247 1248 if (Opcode == Instruction::Or) // ...|X|~X = -1 1249 return Constant::getAllOnesValue(X->getType()); 1250 } 1251 } 1252 1253 // Next, check for duplicate pairs of values, which we assume are next to 1254 // each other, due to our sorting criteria. 1255 assert(i < Ops.size()); 1256 if (i+1 != Ops.size() && Ops[i+1].Op == Ops[i].Op) { 1257 if (Opcode == Instruction::And || Opcode == Instruction::Or) { 1258 // Drop duplicate values for And and Or. 1259 Ops.erase(Ops.begin()+i); 1260 --i; --e; 1261 ++NumAnnihil; 1262 continue; 1263 } 1264 1265 // Drop pairs of values for Xor. 1266 assert(Opcode == Instruction::Xor); 1267 if (e == 2) 1268 return Constant::getNullValue(Ops[0].Op->getType()); 1269 1270 // Y ^ X^X -> Y 1271 Ops.erase(Ops.begin()+i, Ops.begin()+i+2); 1272 i -= 1; e -= 2; 1273 ++NumAnnihil; 1274 } 1275 } 1276 return nullptr; 1277 } 1278 1279 /// Helper function of CombineXorOpnd(). It creates a bitwise-and 1280 /// instruction with the given two operands, and return the resulting 1281 /// instruction. There are two special cases: 1) if the constant operand is 0, 1282 /// it will return NULL. 2) if the constant is ~0, the symbolic operand will 1283 /// be returned. 1284 static Value *createAndInstr(Instruction *InsertBefore, Value *Opnd, 1285 const APInt &ConstOpnd) { 1286 if (ConstOpnd.isNullValue()) 1287 return nullptr; 1288 1289 if (ConstOpnd.isAllOnesValue()) 1290 return Opnd; 1291 1292 Instruction *I = BinaryOperator::CreateAnd( 1293 Opnd, ConstantInt::get(Opnd->getType(), ConstOpnd), "and.ra", 1294 InsertBefore); 1295 I->setDebugLoc(InsertBefore->getDebugLoc()); 1296 return I; 1297 } 1298 1299 // Helper function of OptimizeXor(). It tries to simplify "Opnd1 ^ ConstOpnd" 1300 // into "R ^ C", where C would be 0, and R is a symbolic value. 1301 // 1302 // If it was successful, true is returned, and the "R" and "C" is returned 1303 // via "Res" and "ConstOpnd", respectively; otherwise, false is returned, 1304 // and both "Res" and "ConstOpnd" remain unchanged. 1305 bool ReassociatePass::CombineXorOpnd(Instruction *I, XorOpnd *Opnd1, 1306 APInt &ConstOpnd, Value *&Res) { 1307 // Xor-Rule 1: (x | c1) ^ c2 = (x | c1) ^ (c1 ^ c1) ^ c2 1308 // = ((x | c1) ^ c1) ^ (c1 ^ c2) 1309 // = (x & ~c1) ^ (c1 ^ c2) 1310 // It is useful only when c1 == c2. 1311 if (!Opnd1->isOrExpr() || Opnd1->getConstPart().isNullValue()) 1312 return false; 1313 1314 if (!Opnd1->getValue()->hasOneUse()) 1315 return false; 1316 1317 const APInt &C1 = Opnd1->getConstPart(); 1318 if (C1 != ConstOpnd) 1319 return false; 1320 1321 Value *X = Opnd1->getSymbolicPart(); 1322 Res = createAndInstr(I, X, ~C1); 1323 // ConstOpnd was C2, now C1 ^ C2. 1324 ConstOpnd ^= C1; 1325 1326 if (Instruction *T = dyn_cast<Instruction>(Opnd1->getValue())) 1327 RedoInsts.insert(T); 1328 return true; 1329 } 1330 1331 // Helper function of OptimizeXor(). It tries to simplify 1332 // "Opnd1 ^ Opnd2 ^ ConstOpnd" into "R ^ C", where C would be 0, and R is a 1333 // symbolic value. 1334 // 1335 // If it was successful, true is returned, and the "R" and "C" is returned 1336 // via "Res" and "ConstOpnd", respectively (If the entire expression is 1337 // evaluated to a constant, the Res is set to NULL); otherwise, false is 1338 // returned, and both "Res" and "ConstOpnd" remain unchanged. 1339 bool ReassociatePass::CombineXorOpnd(Instruction *I, XorOpnd *Opnd1, 1340 XorOpnd *Opnd2, APInt &ConstOpnd, 1341 Value *&Res) { 1342 Value *X = Opnd1->getSymbolicPart(); 1343 if (X != Opnd2->getSymbolicPart()) 1344 return false; 1345 1346 // This many instruction become dead.(At least "Opnd1 ^ Opnd2" will die.) 1347 int DeadInstNum = 1; 1348 if (Opnd1->getValue()->hasOneUse()) 1349 DeadInstNum++; 1350 if (Opnd2->getValue()->hasOneUse()) 1351 DeadInstNum++; 1352 1353 // Xor-Rule 2: 1354 // (x | c1) ^ (x & c2) 1355 // = (x|c1) ^ (x&c2) ^ (c1 ^ c1) = ((x|c1) ^ c1) ^ (x & c2) ^ c1 1356 // = (x & ~c1) ^ (x & c2) ^ c1 // Xor-Rule 1 1357 // = (x & c3) ^ c1, where c3 = ~c1 ^ c2 // Xor-rule 3 1358 // 1359 if (Opnd1->isOrExpr() != Opnd2->isOrExpr()) { 1360 if (Opnd2->isOrExpr()) 1361 std::swap(Opnd1, Opnd2); 1362 1363 const APInt &C1 = Opnd1->getConstPart(); 1364 const APInt &C2 = Opnd2->getConstPart(); 1365 APInt C3((~C1) ^ C2); 1366 1367 // Do not increase code size! 1368 if (!C3.isNullValue() && !C3.isAllOnesValue()) { 1369 int NewInstNum = ConstOpnd.getBoolValue() ? 1 : 2; 1370 if (NewInstNum > DeadInstNum) 1371 return false; 1372 } 1373 1374 Res = createAndInstr(I, X, C3); 1375 ConstOpnd ^= C1; 1376 } else if (Opnd1->isOrExpr()) { 1377 // Xor-Rule 3: (x | c1) ^ (x | c2) = (x & c3) ^ c3 where c3 = c1 ^ c2 1378 // 1379 const APInt &C1 = Opnd1->getConstPart(); 1380 const APInt &C2 = Opnd2->getConstPart(); 1381 APInt C3 = C1 ^ C2; 1382 1383 // Do not increase code size 1384 if (!C3.isNullValue() && !C3.isAllOnesValue()) { 1385 int NewInstNum = ConstOpnd.getBoolValue() ? 1 : 2; 1386 if (NewInstNum > DeadInstNum) 1387 return false; 1388 } 1389 1390 Res = createAndInstr(I, X, C3); 1391 ConstOpnd ^= C3; 1392 } else { 1393 // Xor-Rule 4: (x & c1) ^ (x & c2) = (x & (c1^c2)) 1394 // 1395 const APInt &C1 = Opnd1->getConstPart(); 1396 const APInt &C2 = Opnd2->getConstPart(); 1397 APInt C3 = C1 ^ C2; 1398 Res = createAndInstr(I, X, C3); 1399 } 1400 1401 // Put the original operands in the Redo list; hope they will be deleted 1402 // as dead code. 1403 if (Instruction *T = dyn_cast<Instruction>(Opnd1->getValue())) 1404 RedoInsts.insert(T); 1405 if (Instruction *T = dyn_cast<Instruction>(Opnd2->getValue())) 1406 RedoInsts.insert(T); 1407 1408 return true; 1409 } 1410 1411 /// Optimize a series of operands to an 'xor' instruction. If it can be reduced 1412 /// to a single Value, it is returned, otherwise the Ops list is mutated as 1413 /// necessary. 1414 Value *ReassociatePass::OptimizeXor(Instruction *I, 1415 SmallVectorImpl<ValueEntry> &Ops) { 1416 if (Value *V = OptimizeAndOrXor(Instruction::Xor, Ops)) 1417 return V; 1418 1419 if (Ops.size() == 1) 1420 return nullptr; 1421 1422 SmallVector<XorOpnd, 8> Opnds; 1423 SmallVector<XorOpnd*, 8> OpndPtrs; 1424 Type *Ty = Ops[0].Op->getType(); 1425 APInt ConstOpnd(Ty->getScalarSizeInBits(), 0); 1426 1427 // Step 1: Convert ValueEntry to XorOpnd 1428 for (unsigned i = 0, e = Ops.size(); i != e; ++i) { 1429 Value *V = Ops[i].Op; 1430 const APInt *C; 1431 // TODO: Support non-splat vectors. 1432 if (match(V, m_APInt(C))) { 1433 ConstOpnd ^= *C; 1434 } else { 1435 XorOpnd O(V); 1436 O.setSymbolicRank(getRank(O.getSymbolicPart())); 1437 Opnds.push_back(O); 1438 } 1439 } 1440 1441 // NOTE: From this point on, do *NOT* add/delete element to/from "Opnds". 1442 // It would otherwise invalidate the "Opnds"'s iterator, and hence invalidate 1443 // the "OpndPtrs" as well. For the similar reason, do not fuse this loop 1444 // with the previous loop --- the iterator of the "Opnds" may be invalidated 1445 // when new elements are added to the vector. 1446 for (unsigned i = 0, e = Opnds.size(); i != e; ++i) 1447 OpndPtrs.push_back(&Opnds[i]); 1448 1449 // Step 2: Sort the Xor-Operands in a way such that the operands containing 1450 // the same symbolic value cluster together. For instance, the input operand 1451 // sequence ("x | 123", "y & 456", "x & 789") will be sorted into: 1452 // ("x | 123", "x & 789", "y & 456"). 1453 // 1454 // The purpose is twofold: 1455 // 1) Cluster together the operands sharing the same symbolic-value. 1456 // 2) Operand having smaller symbolic-value-rank is permuted earlier, which 1457 // could potentially shorten crital path, and expose more loop-invariants. 1458 // Note that values' rank are basically defined in RPO order (FIXME). 1459 // So, if Rank(X) < Rank(Y) < Rank(Z), it means X is defined earlier 1460 // than Y which is defined earlier than Z. Permute "x | 1", "Y & 2", 1461 // "z" in the order of X-Y-Z is better than any other orders. 1462 llvm::stable_sort(OpndPtrs, [](XorOpnd *LHS, XorOpnd *RHS) { 1463 return LHS->getSymbolicRank() < RHS->getSymbolicRank(); 1464 }); 1465 1466 // Step 3: Combine adjacent operands 1467 XorOpnd *PrevOpnd = nullptr; 1468 bool Changed = false; 1469 for (unsigned i = 0, e = Opnds.size(); i < e; i++) { 1470 XorOpnd *CurrOpnd = OpndPtrs[i]; 1471 // The combined value 1472 Value *CV; 1473 1474 // Step 3.1: Try simplifying "CurrOpnd ^ ConstOpnd" 1475 if (!ConstOpnd.isNullValue() && 1476 CombineXorOpnd(I, CurrOpnd, ConstOpnd, CV)) { 1477 Changed = true; 1478 if (CV) 1479 *CurrOpnd = XorOpnd(CV); 1480 else { 1481 CurrOpnd->Invalidate(); 1482 continue; 1483 } 1484 } 1485 1486 if (!PrevOpnd || CurrOpnd->getSymbolicPart() != PrevOpnd->getSymbolicPart()) { 1487 PrevOpnd = CurrOpnd; 1488 continue; 1489 } 1490 1491 // step 3.2: When previous and current operands share the same symbolic 1492 // value, try to simplify "PrevOpnd ^ CurrOpnd ^ ConstOpnd" 1493 if (CombineXorOpnd(I, CurrOpnd, PrevOpnd, ConstOpnd, CV)) { 1494 // Remove previous operand 1495 PrevOpnd->Invalidate(); 1496 if (CV) { 1497 *CurrOpnd = XorOpnd(CV); 1498 PrevOpnd = CurrOpnd; 1499 } else { 1500 CurrOpnd->Invalidate(); 1501 PrevOpnd = nullptr; 1502 } 1503 Changed = true; 1504 } 1505 } 1506 1507 // Step 4: Reassemble the Ops 1508 if (Changed) { 1509 Ops.clear(); 1510 for (unsigned int i = 0, e = Opnds.size(); i < e; i++) { 1511 XorOpnd &O = Opnds[i]; 1512 if (O.isInvalid()) 1513 continue; 1514 ValueEntry VE(getRank(O.getValue()), O.getValue()); 1515 Ops.push_back(VE); 1516 } 1517 if (!ConstOpnd.isNullValue()) { 1518 Value *C = ConstantInt::get(Ty, ConstOpnd); 1519 ValueEntry VE(getRank(C), C); 1520 Ops.push_back(VE); 1521 } 1522 unsigned Sz = Ops.size(); 1523 if (Sz == 1) 1524 return Ops.back().Op; 1525 if (Sz == 0) { 1526 assert(ConstOpnd.isNullValue()); 1527 return ConstantInt::get(Ty, ConstOpnd); 1528 } 1529 } 1530 1531 return nullptr; 1532 } 1533 1534 /// Optimize a series of operands to an 'add' instruction. This 1535 /// optimizes based on identities. If it can be reduced to a single Value, it 1536 /// is returned, otherwise the Ops list is mutated as necessary. 1537 Value *ReassociatePass::OptimizeAdd(Instruction *I, 1538 SmallVectorImpl<ValueEntry> &Ops) { 1539 // Scan the operand lists looking for X and -X pairs. If we find any, we 1540 // can simplify expressions like X+-X == 0 and X+~X ==-1. While we're at it, 1541 // scan for any 1542 // duplicates. We want to canonicalize Y+Y+Y+Z -> 3*Y+Z. 1543 1544 for (unsigned i = 0, e = Ops.size(); i != e; ++i) { 1545 Value *TheOp = Ops[i].Op; 1546 // Check to see if we've seen this operand before. If so, we factor all 1547 // instances of the operand together. Due to our sorting criteria, we know 1548 // that these need to be next to each other in the vector. 1549 if (i+1 != Ops.size() && Ops[i+1].Op == TheOp) { 1550 // Rescan the list, remove all instances of this operand from the expr. 1551 unsigned NumFound = 0; 1552 do { 1553 Ops.erase(Ops.begin()+i); 1554 ++NumFound; 1555 } while (i != Ops.size() && Ops[i].Op == TheOp); 1556 1557 LLVM_DEBUG(dbgs() << "\nFACTORING [" << NumFound << "]: " << *TheOp 1558 << '\n'); 1559 ++NumFactor; 1560 1561 // Insert a new multiply. 1562 Type *Ty = TheOp->getType(); 1563 Constant *C = Ty->isIntOrIntVectorTy() ? 1564 ConstantInt::get(Ty, NumFound) : ConstantFP::get(Ty, NumFound); 1565 Instruction *Mul = CreateMul(TheOp, C, "factor", I, I); 1566 1567 // Now that we have inserted a multiply, optimize it. This allows us to 1568 // handle cases that require multiple factoring steps, such as this: 1569 // (X*2) + (X*2) + (X*2) -> (X*2)*3 -> X*6 1570 RedoInsts.insert(Mul); 1571 1572 // If every add operand was a duplicate, return the multiply. 1573 if (Ops.empty()) 1574 return Mul; 1575 1576 // Otherwise, we had some input that didn't have the dupe, such as 1577 // "A + A + B" -> "A*2 + B". Add the new multiply to the list of 1578 // things being added by this operation. 1579 Ops.insert(Ops.begin(), ValueEntry(getRank(Mul), Mul)); 1580 1581 --i; 1582 e = Ops.size(); 1583 continue; 1584 } 1585 1586 // Check for X and -X or X and ~X in the operand list. 1587 Value *X; 1588 if (!match(TheOp, m_Neg(m_Value(X))) && !match(TheOp, m_Not(m_Value(X))) && 1589 !match(TheOp, m_FNeg(m_Value(X)))) 1590 continue; 1591 1592 unsigned FoundX = FindInOperandList(Ops, i, X); 1593 if (FoundX == i) 1594 continue; 1595 1596 // Remove X and -X from the operand list. 1597 if (Ops.size() == 2 && 1598 (match(TheOp, m_Neg(m_Value())) || match(TheOp, m_FNeg(m_Value())))) 1599 return Constant::getNullValue(X->getType()); 1600 1601 // Remove X and ~X from the operand list. 1602 if (Ops.size() == 2 && match(TheOp, m_Not(m_Value()))) 1603 return Constant::getAllOnesValue(X->getType()); 1604 1605 Ops.erase(Ops.begin()+i); 1606 if (i < FoundX) 1607 --FoundX; 1608 else 1609 --i; // Need to back up an extra one. 1610 Ops.erase(Ops.begin()+FoundX); 1611 ++NumAnnihil; 1612 --i; // Revisit element. 1613 e -= 2; // Removed two elements. 1614 1615 // if X and ~X we append -1 to the operand list. 1616 if (match(TheOp, m_Not(m_Value()))) { 1617 Value *V = Constant::getAllOnesValue(X->getType()); 1618 Ops.insert(Ops.end(), ValueEntry(getRank(V), V)); 1619 e += 1; 1620 } 1621 } 1622 1623 // Scan the operand list, checking to see if there are any common factors 1624 // between operands. Consider something like A*A+A*B*C+D. We would like to 1625 // reassociate this to A*(A+B*C)+D, which reduces the number of multiplies. 1626 // To efficiently find this, we count the number of times a factor occurs 1627 // for any ADD operands that are MULs. 1628 DenseMap<Value*, unsigned> FactorOccurrences; 1629 1630 // Keep track of each multiply we see, to avoid triggering on (X*4)+(X*4) 1631 // where they are actually the same multiply. 1632 unsigned MaxOcc = 0; 1633 Value *MaxOccVal = nullptr; 1634 for (unsigned i = 0, e = Ops.size(); i != e; ++i) { 1635 BinaryOperator *BOp = 1636 isReassociableOp(Ops[i].Op, Instruction::Mul, Instruction::FMul); 1637 if (!BOp) 1638 continue; 1639 1640 // Compute all of the factors of this added value. 1641 SmallVector<Value*, 8> Factors; 1642 FindSingleUseMultiplyFactors(BOp, Factors); 1643 assert(Factors.size() > 1 && "Bad linearize!"); 1644 1645 // Add one to FactorOccurrences for each unique factor in this op. 1646 SmallPtrSet<Value*, 8> Duplicates; 1647 for (unsigned i = 0, e = Factors.size(); i != e; ++i) { 1648 Value *Factor = Factors[i]; 1649 if (!Duplicates.insert(Factor).second) 1650 continue; 1651 1652 unsigned Occ = ++FactorOccurrences[Factor]; 1653 if (Occ > MaxOcc) { 1654 MaxOcc = Occ; 1655 MaxOccVal = Factor; 1656 } 1657 1658 // If Factor is a negative constant, add the negated value as a factor 1659 // because we can percolate the negate out. Watch for minint, which 1660 // cannot be positivified. 1661 if (ConstantInt *CI = dyn_cast<ConstantInt>(Factor)) { 1662 if (CI->isNegative() && !CI->isMinValue(true)) { 1663 Factor = ConstantInt::get(CI->getContext(), -CI->getValue()); 1664 if (!Duplicates.insert(Factor).second) 1665 continue; 1666 unsigned Occ = ++FactorOccurrences[Factor]; 1667 if (Occ > MaxOcc) { 1668 MaxOcc = Occ; 1669 MaxOccVal = Factor; 1670 } 1671 } 1672 } else if (ConstantFP *CF = dyn_cast<ConstantFP>(Factor)) { 1673 if (CF->isNegative()) { 1674 APFloat F(CF->getValueAPF()); 1675 F.changeSign(); 1676 Factor = ConstantFP::get(CF->getContext(), F); 1677 if (!Duplicates.insert(Factor).second) 1678 continue; 1679 unsigned Occ = ++FactorOccurrences[Factor]; 1680 if (Occ > MaxOcc) { 1681 MaxOcc = Occ; 1682 MaxOccVal = Factor; 1683 } 1684 } 1685 } 1686 } 1687 } 1688 1689 // If any factor occurred more than one time, we can pull it out. 1690 if (MaxOcc > 1) { 1691 LLVM_DEBUG(dbgs() << "\nFACTORING [" << MaxOcc << "]: " << *MaxOccVal 1692 << '\n'); 1693 ++NumFactor; 1694 1695 // Create a new instruction that uses the MaxOccVal twice. If we don't do 1696 // this, we could otherwise run into situations where removing a factor 1697 // from an expression will drop a use of maxocc, and this can cause 1698 // RemoveFactorFromExpression on successive values to behave differently. 1699 Instruction *DummyInst = 1700 I->getType()->isIntOrIntVectorTy() 1701 ? BinaryOperator::CreateAdd(MaxOccVal, MaxOccVal) 1702 : BinaryOperator::CreateFAdd(MaxOccVal, MaxOccVal); 1703 1704 SmallVector<WeakTrackingVH, 4> NewMulOps; 1705 for (unsigned i = 0; i != Ops.size(); ++i) { 1706 // Only try to remove factors from expressions we're allowed to. 1707 BinaryOperator *BOp = 1708 isReassociableOp(Ops[i].Op, Instruction::Mul, Instruction::FMul); 1709 if (!BOp) 1710 continue; 1711 1712 if (Value *V = RemoveFactorFromExpression(Ops[i].Op, MaxOccVal)) { 1713 // The factorized operand may occur several times. Convert them all in 1714 // one fell swoop. 1715 for (unsigned j = Ops.size(); j != i;) { 1716 --j; 1717 if (Ops[j].Op == Ops[i].Op) { 1718 NewMulOps.push_back(V); 1719 Ops.erase(Ops.begin()+j); 1720 } 1721 } 1722 --i; 1723 } 1724 } 1725 1726 // No need for extra uses anymore. 1727 DummyInst->deleteValue(); 1728 1729 unsigned NumAddedValues = NewMulOps.size(); 1730 Value *V = EmitAddTreeOfValues(I, NewMulOps); 1731 1732 // Now that we have inserted the add tree, optimize it. This allows us to 1733 // handle cases that require multiple factoring steps, such as this: 1734 // A*A*B + A*A*C --> A*(A*B+A*C) --> A*(A*(B+C)) 1735 assert(NumAddedValues > 1 && "Each occurrence should contribute a value"); 1736 (void)NumAddedValues; 1737 if (Instruction *VI = dyn_cast<Instruction>(V)) 1738 RedoInsts.insert(VI); 1739 1740 // Create the multiply. 1741 Instruction *V2 = CreateMul(V, MaxOccVal, "reass.mul", I, I); 1742 1743 // Rerun associate on the multiply in case the inner expression turned into 1744 // a multiply. We want to make sure that we keep things in canonical form. 1745 RedoInsts.insert(V2); 1746 1747 // If every add operand included the factor (e.g. "A*B + A*C"), then the 1748 // entire result expression is just the multiply "A*(B+C)". 1749 if (Ops.empty()) 1750 return V2; 1751 1752 // Otherwise, we had some input that didn't have the factor, such as 1753 // "A*B + A*C + D" -> "A*(B+C) + D". Add the new multiply to the list of 1754 // things being added by this operation. 1755 Ops.insert(Ops.begin(), ValueEntry(getRank(V2), V2)); 1756 } 1757 1758 return nullptr; 1759 } 1760 1761 /// Build up a vector of value/power pairs factoring a product. 1762 /// 1763 /// Given a series of multiplication operands, build a vector of factors and 1764 /// the powers each is raised to when forming the final product. Sort them in 1765 /// the order of descending power. 1766 /// 1767 /// (x*x) -> [(x, 2)] 1768 /// ((x*x)*x) -> [(x, 3)] 1769 /// ((((x*y)*x)*y)*x) -> [(x, 3), (y, 2)] 1770 /// 1771 /// \returns Whether any factors have a power greater than one. 1772 static bool collectMultiplyFactors(SmallVectorImpl<ValueEntry> &Ops, 1773 SmallVectorImpl<Factor> &Factors) { 1774 // FIXME: Have Ops be (ValueEntry, Multiplicity) pairs, simplifying this. 1775 // Compute the sum of powers of simplifiable factors. 1776 unsigned FactorPowerSum = 0; 1777 for (unsigned Idx = 1, Size = Ops.size(); Idx < Size; ++Idx) { 1778 Value *Op = Ops[Idx-1].Op; 1779 1780 // Count the number of occurrences of this value. 1781 unsigned Count = 1; 1782 for (; Idx < Size && Ops[Idx].Op == Op; ++Idx) 1783 ++Count; 1784 // Track for simplification all factors which occur 2 or more times. 1785 if (Count > 1) 1786 FactorPowerSum += Count; 1787 } 1788 1789 // We can only simplify factors if the sum of the powers of our simplifiable 1790 // factors is 4 or higher. When that is the case, we will *always* have 1791 // a simplification. This is an important invariant to prevent cyclicly 1792 // trying to simplify already minimal formations. 1793 if (FactorPowerSum < 4) 1794 return false; 1795 1796 // Now gather the simplifiable factors, removing them from Ops. 1797 FactorPowerSum = 0; 1798 for (unsigned Idx = 1; Idx < Ops.size(); ++Idx) { 1799 Value *Op = Ops[Idx-1].Op; 1800 1801 // Count the number of occurrences of this value. 1802 unsigned Count = 1; 1803 for (; Idx < Ops.size() && Ops[Idx].Op == Op; ++Idx) 1804 ++Count; 1805 if (Count == 1) 1806 continue; 1807 // Move an even number of occurrences to Factors. 1808 Count &= ~1U; 1809 Idx -= Count; 1810 FactorPowerSum += Count; 1811 Factors.push_back(Factor(Op, Count)); 1812 Ops.erase(Ops.begin()+Idx, Ops.begin()+Idx+Count); 1813 } 1814 1815 // None of the adjustments above should have reduced the sum of factor powers 1816 // below our mininum of '4'. 1817 assert(FactorPowerSum >= 4); 1818 1819 llvm::stable_sort(Factors, [](const Factor &LHS, const Factor &RHS) { 1820 return LHS.Power > RHS.Power; 1821 }); 1822 return true; 1823 } 1824 1825 /// Build a tree of multiplies, computing the product of Ops. 1826 static Value *buildMultiplyTree(IRBuilderBase &Builder, 1827 SmallVectorImpl<Value*> &Ops) { 1828 if (Ops.size() == 1) 1829 return Ops.back(); 1830 1831 Value *LHS = Ops.pop_back_val(); 1832 do { 1833 if (LHS->getType()->isIntOrIntVectorTy()) 1834 LHS = Builder.CreateMul(LHS, Ops.pop_back_val()); 1835 else 1836 LHS = Builder.CreateFMul(LHS, Ops.pop_back_val()); 1837 } while (!Ops.empty()); 1838 1839 return LHS; 1840 } 1841 1842 /// Build a minimal multiplication DAG for (a^x)*(b^y)*(c^z)*... 1843 /// 1844 /// Given a vector of values raised to various powers, where no two values are 1845 /// equal and the powers are sorted in decreasing order, compute the minimal 1846 /// DAG of multiplies to compute the final product, and return that product 1847 /// value. 1848 Value * 1849 ReassociatePass::buildMinimalMultiplyDAG(IRBuilderBase &Builder, 1850 SmallVectorImpl<Factor> &Factors) { 1851 assert(Factors[0].Power); 1852 SmallVector<Value *, 4> OuterProduct; 1853 for (unsigned LastIdx = 0, Idx = 1, Size = Factors.size(); 1854 Idx < Size && Factors[Idx].Power > 0; ++Idx) { 1855 if (Factors[Idx].Power != Factors[LastIdx].Power) { 1856 LastIdx = Idx; 1857 continue; 1858 } 1859 1860 // We want to multiply across all the factors with the same power so that 1861 // we can raise them to that power as a single entity. Build a mini tree 1862 // for that. 1863 SmallVector<Value *, 4> InnerProduct; 1864 InnerProduct.push_back(Factors[LastIdx].Base); 1865 do { 1866 InnerProduct.push_back(Factors[Idx].Base); 1867 ++Idx; 1868 } while (Idx < Size && Factors[Idx].Power == Factors[LastIdx].Power); 1869 1870 // Reset the base value of the first factor to the new expression tree. 1871 // We'll remove all the factors with the same power in a second pass. 1872 Value *M = Factors[LastIdx].Base = buildMultiplyTree(Builder, InnerProduct); 1873 if (Instruction *MI = dyn_cast<Instruction>(M)) 1874 RedoInsts.insert(MI); 1875 1876 LastIdx = Idx; 1877 } 1878 // Unique factors with equal powers -- we've folded them into the first one's 1879 // base. 1880 Factors.erase(std::unique(Factors.begin(), Factors.end(), 1881 [](const Factor &LHS, const Factor &RHS) { 1882 return LHS.Power == RHS.Power; 1883 }), 1884 Factors.end()); 1885 1886 // Iteratively collect the base of each factor with an add power into the 1887 // outer product, and halve each power in preparation for squaring the 1888 // expression. 1889 for (unsigned Idx = 0, Size = Factors.size(); Idx != Size; ++Idx) { 1890 if (Factors[Idx].Power & 1) 1891 OuterProduct.push_back(Factors[Idx].Base); 1892 Factors[Idx].Power >>= 1; 1893 } 1894 if (Factors[0].Power) { 1895 Value *SquareRoot = buildMinimalMultiplyDAG(Builder, Factors); 1896 OuterProduct.push_back(SquareRoot); 1897 OuterProduct.push_back(SquareRoot); 1898 } 1899 if (OuterProduct.size() == 1) 1900 return OuterProduct.front(); 1901 1902 Value *V = buildMultiplyTree(Builder, OuterProduct); 1903 return V; 1904 } 1905 1906 Value *ReassociatePass::OptimizeMul(BinaryOperator *I, 1907 SmallVectorImpl<ValueEntry> &Ops) { 1908 // We can only optimize the multiplies when there is a chain of more than 1909 // three, such that a balanced tree might require fewer total multiplies. 1910 if (Ops.size() < 4) 1911 return nullptr; 1912 1913 // Try to turn linear trees of multiplies without other uses of the 1914 // intermediate stages into minimal multiply DAGs with perfect sub-expression 1915 // re-use. 1916 SmallVector<Factor, 4> Factors; 1917 if (!collectMultiplyFactors(Ops, Factors)) 1918 return nullptr; // All distinct factors, so nothing left for us to do. 1919 1920 IRBuilder<> Builder(I); 1921 // The reassociate transformation for FP operations is performed only 1922 // if unsafe algebra is permitted by FastMathFlags. Propagate those flags 1923 // to the newly generated operations. 1924 if (auto FPI = dyn_cast<FPMathOperator>(I)) 1925 Builder.setFastMathFlags(FPI->getFastMathFlags()); 1926 1927 Value *V = buildMinimalMultiplyDAG(Builder, Factors); 1928 if (Ops.empty()) 1929 return V; 1930 1931 ValueEntry NewEntry = ValueEntry(getRank(V), V); 1932 Ops.insert(llvm::lower_bound(Ops, NewEntry), NewEntry); 1933 return nullptr; 1934 } 1935 1936 Value *ReassociatePass::OptimizeExpression(BinaryOperator *I, 1937 SmallVectorImpl<ValueEntry> &Ops) { 1938 // Now that we have the linearized expression tree, try to optimize it. 1939 // Start by folding any constants that we found. 1940 Constant *Cst = nullptr; 1941 unsigned Opcode = I->getOpcode(); 1942 while (!Ops.empty() && isa<Constant>(Ops.back().Op)) { 1943 Constant *C = cast<Constant>(Ops.pop_back_val().Op); 1944 Cst = Cst ? ConstantExpr::get(Opcode, C, Cst) : C; 1945 } 1946 // If there was nothing but constants then we are done. 1947 if (Ops.empty()) 1948 return Cst; 1949 1950 // Put the combined constant back at the end of the operand list, except if 1951 // there is no point. For example, an add of 0 gets dropped here, while a 1952 // multiplication by zero turns the whole expression into zero. 1953 if (Cst && Cst != ConstantExpr::getBinOpIdentity(Opcode, I->getType())) { 1954 if (Cst == ConstantExpr::getBinOpAbsorber(Opcode, I->getType())) 1955 return Cst; 1956 Ops.push_back(ValueEntry(0, Cst)); 1957 } 1958 1959 if (Ops.size() == 1) return Ops[0].Op; 1960 1961 // Handle destructive annihilation due to identities between elements in the 1962 // argument list here. 1963 unsigned NumOps = Ops.size(); 1964 switch (Opcode) { 1965 default: break; 1966 case Instruction::And: 1967 case Instruction::Or: 1968 if (Value *Result = OptimizeAndOrXor(Opcode, Ops)) 1969 return Result; 1970 break; 1971 1972 case Instruction::Xor: 1973 if (Value *Result = OptimizeXor(I, Ops)) 1974 return Result; 1975 break; 1976 1977 case Instruction::Add: 1978 case Instruction::FAdd: 1979 if (Value *Result = OptimizeAdd(I, Ops)) 1980 return Result; 1981 break; 1982 1983 case Instruction::Mul: 1984 case Instruction::FMul: 1985 if (Value *Result = OptimizeMul(I, Ops)) 1986 return Result; 1987 break; 1988 } 1989 1990 if (Ops.size() != NumOps) 1991 return OptimizeExpression(I, Ops); 1992 return nullptr; 1993 } 1994 1995 // Remove dead instructions and if any operands are trivially dead add them to 1996 // Insts so they will be removed as well. 1997 void ReassociatePass::RecursivelyEraseDeadInsts(Instruction *I, 1998 OrderedSet &Insts) { 1999 assert(isInstructionTriviallyDead(I) && "Trivially dead instructions only!"); 2000 SmallVector<Value *, 4> Ops(I->op_begin(), I->op_end()); 2001 ValueRankMap.erase(I); 2002 Insts.remove(I); 2003 RedoInsts.remove(I); 2004 llvm::salvageDebugInfo(*I); 2005 I->eraseFromParent(); 2006 for (auto Op : Ops) 2007 if (Instruction *OpInst = dyn_cast<Instruction>(Op)) 2008 if (OpInst->use_empty()) 2009 Insts.insert(OpInst); 2010 } 2011 2012 /// Zap the given instruction, adding interesting operands to the work list. 2013 void ReassociatePass::EraseInst(Instruction *I) { 2014 assert(isInstructionTriviallyDead(I) && "Trivially dead instructions only!"); 2015 LLVM_DEBUG(dbgs() << "Erasing dead inst: "; I->dump()); 2016 2017 SmallVector<Value*, 8> Ops(I->op_begin(), I->op_end()); 2018 // Erase the dead instruction. 2019 ValueRankMap.erase(I); 2020 RedoInsts.remove(I); 2021 llvm::salvageDebugInfo(*I); 2022 I->eraseFromParent(); 2023 // Optimize its operands. 2024 SmallPtrSet<Instruction *, 8> Visited; // Detect self-referential nodes. 2025 for (unsigned i = 0, e = Ops.size(); i != e; ++i) 2026 if (Instruction *Op = dyn_cast<Instruction>(Ops[i])) { 2027 // If this is a node in an expression tree, climb to the expression root 2028 // and add that since that's where optimization actually happens. 2029 unsigned Opcode = Op->getOpcode(); 2030 while (Op->hasOneUse() && Op->user_back()->getOpcode() == Opcode && 2031 Visited.insert(Op).second) 2032 Op = Op->user_back(); 2033 2034 // The instruction we're going to push may be coming from a 2035 // dead block, and Reassociate skips the processing of unreachable 2036 // blocks because it's a waste of time and also because it can 2037 // lead to infinite loop due to LLVM's non-standard definition 2038 // of dominance. 2039 if (ValueRankMap.find(Op) != ValueRankMap.end()) 2040 RedoInsts.insert(Op); 2041 } 2042 2043 MadeChange = true; 2044 } 2045 2046 /// Recursively analyze an expression to build a list of instructions that have 2047 /// negative floating-point constant operands. The caller can then transform 2048 /// the list to create positive constants for better reassociation and CSE. 2049 static void getNegatibleInsts(Value *V, 2050 SmallVectorImpl<Instruction *> &Candidates) { 2051 // Handle only one-use instructions. Combining negations does not justify 2052 // replicating instructions. 2053 Instruction *I; 2054 if (!match(V, m_OneUse(m_Instruction(I)))) 2055 return; 2056 2057 // Handle expressions of multiplications and divisions. 2058 // TODO: This could look through floating-point casts. 2059 const APFloat *C; 2060 switch (I->getOpcode()) { 2061 case Instruction::FMul: 2062 // Not expecting non-canonical code here. Bail out and wait. 2063 if (match(I->getOperand(0), m_Constant())) 2064 break; 2065 2066 if (match(I->getOperand(1), m_APFloat(C)) && C->isNegative()) { 2067 Candidates.push_back(I); 2068 LLVM_DEBUG(dbgs() << "FMul with negative constant: " << *I << '\n'); 2069 } 2070 getNegatibleInsts(I->getOperand(0), Candidates); 2071 getNegatibleInsts(I->getOperand(1), Candidates); 2072 break; 2073 case Instruction::FDiv: 2074 // Not expecting non-canonical code here. Bail out and wait. 2075 if (match(I->getOperand(0), m_Constant()) && 2076 match(I->getOperand(1), m_Constant())) 2077 break; 2078 2079 if ((match(I->getOperand(0), m_APFloat(C)) && C->isNegative()) || 2080 (match(I->getOperand(1), m_APFloat(C)) && C->isNegative())) { 2081 Candidates.push_back(I); 2082 LLVM_DEBUG(dbgs() << "FDiv with negative constant: " << *I << '\n'); 2083 } 2084 getNegatibleInsts(I->getOperand(0), Candidates); 2085 getNegatibleInsts(I->getOperand(1), Candidates); 2086 break; 2087 default: 2088 break; 2089 } 2090 } 2091 2092 /// Given an fadd/fsub with an operand that is a one-use instruction 2093 /// (the fadd/fsub), try to change negative floating-point constants into 2094 /// positive constants to increase potential for reassociation and CSE. 2095 Instruction *ReassociatePass::canonicalizeNegFPConstantsForOp(Instruction *I, 2096 Instruction *Op, 2097 Value *OtherOp) { 2098 assert((I->getOpcode() == Instruction::FAdd || 2099 I->getOpcode() == Instruction::FSub) && "Expected fadd/fsub"); 2100 2101 // Collect instructions with negative FP constants from the subtree that ends 2102 // in Op. 2103 SmallVector<Instruction *, 4> Candidates; 2104 getNegatibleInsts(Op, Candidates); 2105 if (Candidates.empty()) 2106 return nullptr; 2107 2108 // Don't canonicalize x + (-Constant * y) -> x - (Constant * y), if the 2109 // resulting subtract will be broken up later. This can get us into an 2110 // infinite loop during reassociation. 2111 bool IsFSub = I->getOpcode() == Instruction::FSub; 2112 bool NeedsSubtract = !IsFSub && Candidates.size() % 2 == 1; 2113 if (NeedsSubtract && ShouldBreakUpSubtract(I)) 2114 return nullptr; 2115 2116 for (Instruction *Negatible : Candidates) { 2117 const APFloat *C; 2118 if (match(Negatible->getOperand(0), m_APFloat(C))) { 2119 assert(!match(Negatible->getOperand(1), m_Constant()) && 2120 "Expecting only 1 constant operand"); 2121 assert(C->isNegative() && "Expected negative FP constant"); 2122 Negatible->setOperand(0, ConstantFP::get(Negatible->getType(), abs(*C))); 2123 MadeChange = true; 2124 } 2125 if (match(Negatible->getOperand(1), m_APFloat(C))) { 2126 assert(!match(Negatible->getOperand(0), m_Constant()) && 2127 "Expecting only 1 constant operand"); 2128 assert(C->isNegative() && "Expected negative FP constant"); 2129 Negatible->setOperand(1, ConstantFP::get(Negatible->getType(), abs(*C))); 2130 MadeChange = true; 2131 } 2132 } 2133 assert(MadeChange == true && "Negative constant candidate was not changed"); 2134 2135 // Negations cancelled out. 2136 if (Candidates.size() % 2 == 0) 2137 return I; 2138 2139 // Negate the final operand in the expression by flipping the opcode of this 2140 // fadd/fsub. 2141 assert(Candidates.size() % 2 == 1 && "Expected odd number"); 2142 IRBuilder<> Builder(I); 2143 Value *NewInst = IsFSub ? Builder.CreateFAddFMF(OtherOp, Op, I) 2144 : Builder.CreateFSubFMF(OtherOp, Op, I); 2145 I->replaceAllUsesWith(NewInst); 2146 RedoInsts.insert(I); 2147 return dyn_cast<Instruction>(NewInst); 2148 } 2149 2150 /// Canonicalize expressions that contain a negative floating-point constant 2151 /// of the following form: 2152 /// OtherOp + (subtree) -> OtherOp {+/-} (canonical subtree) 2153 /// (subtree) + OtherOp -> OtherOp {+/-} (canonical subtree) 2154 /// OtherOp - (subtree) -> OtherOp {+/-} (canonical subtree) 2155 /// 2156 /// The fadd/fsub opcode may be switched to allow folding a negation into the 2157 /// input instruction. 2158 Instruction *ReassociatePass::canonicalizeNegFPConstants(Instruction *I) { 2159 LLVM_DEBUG(dbgs() << "Combine negations for: " << *I << '\n'); 2160 Value *X; 2161 Instruction *Op; 2162 if (match(I, m_FAdd(m_Value(X), m_OneUse(m_Instruction(Op))))) 2163 if (Instruction *R = canonicalizeNegFPConstantsForOp(I, Op, X)) 2164 I = R; 2165 if (match(I, m_FAdd(m_OneUse(m_Instruction(Op)), m_Value(X)))) 2166 if (Instruction *R = canonicalizeNegFPConstantsForOp(I, Op, X)) 2167 I = R; 2168 if (match(I, m_FSub(m_Value(X), m_OneUse(m_Instruction(Op))))) 2169 if (Instruction *R = canonicalizeNegFPConstantsForOp(I, Op, X)) 2170 I = R; 2171 return I; 2172 } 2173 2174 /// Inspect and optimize the given instruction. Note that erasing 2175 /// instructions is not allowed. 2176 void ReassociatePass::OptimizeInst(Instruction *I) { 2177 // Only consider operations that we understand. 2178 if (!isa<UnaryOperator>(I) && !isa<BinaryOperator>(I)) 2179 return; 2180 2181 if (I->getOpcode() == Instruction::Shl && isa<ConstantInt>(I->getOperand(1))) 2182 // If an operand of this shift is a reassociable multiply, or if the shift 2183 // is used by a reassociable multiply or add, turn into a multiply. 2184 if (isReassociableOp(I->getOperand(0), Instruction::Mul) || 2185 (I->hasOneUse() && 2186 (isReassociableOp(I->user_back(), Instruction::Mul) || 2187 isReassociableOp(I->user_back(), Instruction::Add)))) { 2188 Instruction *NI = ConvertShiftToMul(I); 2189 RedoInsts.insert(I); 2190 MadeChange = true; 2191 I = NI; 2192 } 2193 2194 // Commute binary operators, to canonicalize the order of their operands. 2195 // This can potentially expose more CSE opportunities, and makes writing other 2196 // transformations simpler. 2197 if (I->isCommutative()) 2198 canonicalizeOperands(I); 2199 2200 // Canonicalize negative constants out of expressions. 2201 if (Instruction *Res = canonicalizeNegFPConstants(I)) 2202 I = Res; 2203 2204 // Don't optimize floating-point instructions unless they are 'fast'. 2205 if (I->getType()->isFPOrFPVectorTy() && !I->isFast()) 2206 return; 2207 2208 // Do not reassociate boolean (i1) expressions. We want to preserve the 2209 // original order of evaluation for short-circuited comparisons that 2210 // SimplifyCFG has folded to AND/OR expressions. If the expression 2211 // is not further optimized, it is likely to be transformed back to a 2212 // short-circuited form for code gen, and the source order may have been 2213 // optimized for the most likely conditions. 2214 if (I->getType()->isIntegerTy(1)) 2215 return; 2216 2217 // If this is a bitwise or instruction of operands 2218 // with no common bits set, convert it to X+Y. 2219 if (I->getOpcode() == Instruction::Or && 2220 ShouldConvertOrWithNoCommonBitsToAdd(I) && 2221 haveNoCommonBitsSet(I->getOperand(0), I->getOperand(1), 2222 I->getModule()->getDataLayout(), /*AC=*/nullptr, I, 2223 /*DT=*/nullptr)) { 2224 Instruction *NI = ConvertOrWithNoCommonBitsToAdd(I); 2225 RedoInsts.insert(I); 2226 MadeChange = true; 2227 I = NI; 2228 } 2229 2230 // If this is a subtract instruction which is not already in negate form, 2231 // see if we can convert it to X+-Y. 2232 if (I->getOpcode() == Instruction::Sub) { 2233 if (ShouldBreakUpSubtract(I)) { 2234 Instruction *NI = BreakUpSubtract(I, RedoInsts); 2235 RedoInsts.insert(I); 2236 MadeChange = true; 2237 I = NI; 2238 } else if (match(I, m_Neg(m_Value()))) { 2239 // Otherwise, this is a negation. See if the operand is a multiply tree 2240 // and if this is not an inner node of a multiply tree. 2241 if (isReassociableOp(I->getOperand(1), Instruction::Mul) && 2242 (!I->hasOneUse() || 2243 !isReassociableOp(I->user_back(), Instruction::Mul))) { 2244 Instruction *NI = LowerNegateToMultiply(I); 2245 // If the negate was simplified, revisit the users to see if we can 2246 // reassociate further. 2247 for (User *U : NI->users()) { 2248 if (BinaryOperator *Tmp = dyn_cast<BinaryOperator>(U)) 2249 RedoInsts.insert(Tmp); 2250 } 2251 RedoInsts.insert(I); 2252 MadeChange = true; 2253 I = NI; 2254 } 2255 } 2256 } else if (I->getOpcode() == Instruction::FNeg || 2257 I->getOpcode() == Instruction::FSub) { 2258 if (ShouldBreakUpSubtract(I)) { 2259 Instruction *NI = BreakUpSubtract(I, RedoInsts); 2260 RedoInsts.insert(I); 2261 MadeChange = true; 2262 I = NI; 2263 } else if (match(I, m_FNeg(m_Value()))) { 2264 // Otherwise, this is a negation. See if the operand is a multiply tree 2265 // and if this is not an inner node of a multiply tree. 2266 Value *Op = isa<BinaryOperator>(I) ? I->getOperand(1) : 2267 I->getOperand(0); 2268 if (isReassociableOp(Op, Instruction::FMul) && 2269 (!I->hasOneUse() || 2270 !isReassociableOp(I->user_back(), Instruction::FMul))) { 2271 // If the negate was simplified, revisit the users to see if we can 2272 // reassociate further. 2273 Instruction *NI = LowerNegateToMultiply(I); 2274 for (User *U : NI->users()) { 2275 if (BinaryOperator *Tmp = dyn_cast<BinaryOperator>(U)) 2276 RedoInsts.insert(Tmp); 2277 } 2278 RedoInsts.insert(I); 2279 MadeChange = true; 2280 I = NI; 2281 } 2282 } 2283 } 2284 2285 // If this instruction is an associative binary operator, process it. 2286 if (!I->isAssociative()) return; 2287 BinaryOperator *BO = cast<BinaryOperator>(I); 2288 2289 // If this is an interior node of a reassociable tree, ignore it until we 2290 // get to the root of the tree, to avoid N^2 analysis. 2291 unsigned Opcode = BO->getOpcode(); 2292 if (BO->hasOneUse() && BO->user_back()->getOpcode() == Opcode) { 2293 // During the initial run we will get to the root of the tree. 2294 // But if we get here while we are redoing instructions, there is no 2295 // guarantee that the root will be visited. So Redo later 2296 if (BO->user_back() != BO && 2297 BO->getParent() == BO->user_back()->getParent()) 2298 RedoInsts.insert(BO->user_back()); 2299 return; 2300 } 2301 2302 // If this is an add tree that is used by a sub instruction, ignore it 2303 // until we process the subtract. 2304 if (BO->hasOneUse() && BO->getOpcode() == Instruction::Add && 2305 cast<Instruction>(BO->user_back())->getOpcode() == Instruction::Sub) 2306 return; 2307 if (BO->hasOneUse() && BO->getOpcode() == Instruction::FAdd && 2308 cast<Instruction>(BO->user_back())->getOpcode() == Instruction::FSub) 2309 return; 2310 2311 ReassociateExpression(BO); 2312 } 2313 2314 void ReassociatePass::ReassociateExpression(BinaryOperator *I) { 2315 // First, walk the expression tree, linearizing the tree, collecting the 2316 // operand information. 2317 SmallVector<RepeatedValue, 8> Tree; 2318 MadeChange |= LinearizeExprTree(I, Tree); 2319 SmallVector<ValueEntry, 8> Ops; 2320 Ops.reserve(Tree.size()); 2321 for (unsigned i = 0, e = Tree.size(); i != e; ++i) { 2322 RepeatedValue E = Tree[i]; 2323 Ops.append(E.second.getZExtValue(), 2324 ValueEntry(getRank(E.first), E.first)); 2325 } 2326 2327 LLVM_DEBUG(dbgs() << "RAIn:\t"; PrintOps(I, Ops); dbgs() << '\n'); 2328 2329 // Now that we have linearized the tree to a list and have gathered all of 2330 // the operands and their ranks, sort the operands by their rank. Use a 2331 // stable_sort so that values with equal ranks will have their relative 2332 // positions maintained (and so the compiler is deterministic). Note that 2333 // this sorts so that the highest ranking values end up at the beginning of 2334 // the vector. 2335 llvm::stable_sort(Ops); 2336 2337 // Now that we have the expression tree in a convenient 2338 // sorted form, optimize it globally if possible. 2339 if (Value *V = OptimizeExpression(I, Ops)) { 2340 if (V == I) 2341 // Self-referential expression in unreachable code. 2342 return; 2343 // This expression tree simplified to something that isn't a tree, 2344 // eliminate it. 2345 LLVM_DEBUG(dbgs() << "Reassoc to scalar: " << *V << '\n'); 2346 I->replaceAllUsesWith(V); 2347 if (Instruction *VI = dyn_cast<Instruction>(V)) 2348 if (I->getDebugLoc()) 2349 VI->setDebugLoc(I->getDebugLoc()); 2350 RedoInsts.insert(I); 2351 ++NumAnnihil; 2352 return; 2353 } 2354 2355 // We want to sink immediates as deeply as possible except in the case where 2356 // this is a multiply tree used only by an add, and the immediate is a -1. 2357 // In this case we reassociate to put the negation on the outside so that we 2358 // can fold the negation into the add: (-X)*Y + Z -> Z-X*Y 2359 if (I->hasOneUse()) { 2360 if (I->getOpcode() == Instruction::Mul && 2361 cast<Instruction>(I->user_back())->getOpcode() == Instruction::Add && 2362 isa<ConstantInt>(Ops.back().Op) && 2363 cast<ConstantInt>(Ops.back().Op)->isMinusOne()) { 2364 ValueEntry Tmp = Ops.pop_back_val(); 2365 Ops.insert(Ops.begin(), Tmp); 2366 } else if (I->getOpcode() == Instruction::FMul && 2367 cast<Instruction>(I->user_back())->getOpcode() == 2368 Instruction::FAdd && 2369 isa<ConstantFP>(Ops.back().Op) && 2370 cast<ConstantFP>(Ops.back().Op)->isExactlyValue(-1.0)) { 2371 ValueEntry Tmp = Ops.pop_back_val(); 2372 Ops.insert(Ops.begin(), Tmp); 2373 } 2374 } 2375 2376 LLVM_DEBUG(dbgs() << "RAOut:\t"; PrintOps(I, Ops); dbgs() << '\n'); 2377 2378 if (Ops.size() == 1) { 2379 if (Ops[0].Op == I) 2380 // Self-referential expression in unreachable code. 2381 return; 2382 2383 // This expression tree simplified to something that isn't a tree, 2384 // eliminate it. 2385 I->replaceAllUsesWith(Ops[0].Op); 2386 if (Instruction *OI = dyn_cast<Instruction>(Ops[0].Op)) 2387 OI->setDebugLoc(I->getDebugLoc()); 2388 RedoInsts.insert(I); 2389 return; 2390 } 2391 2392 if (Ops.size() > 2 && Ops.size() <= GlobalReassociateLimit) { 2393 // Find the pair with the highest count in the pairmap and move it to the 2394 // back of the list so that it can later be CSE'd. 2395 // example: 2396 // a*b*c*d*e 2397 // if c*e is the most "popular" pair, we can express this as 2398 // (((c*e)*d)*b)*a 2399 unsigned Max = 1; 2400 unsigned BestRank = 0; 2401 std::pair<unsigned, unsigned> BestPair; 2402 unsigned Idx = I->getOpcode() - Instruction::BinaryOpsBegin; 2403 for (unsigned i = 0; i < Ops.size() - 1; ++i) 2404 for (unsigned j = i + 1; j < Ops.size(); ++j) { 2405 unsigned Score = 0; 2406 Value *Op0 = Ops[i].Op; 2407 Value *Op1 = Ops[j].Op; 2408 if (std::less<Value *>()(Op1, Op0)) 2409 std::swap(Op0, Op1); 2410 auto it = PairMap[Idx].find({Op0, Op1}); 2411 if (it != PairMap[Idx].end()) { 2412 // Functions like BreakUpSubtract() can erase the Values we're using 2413 // as keys and create new Values after we built the PairMap. There's a 2414 // small chance that the new nodes can have the same address as 2415 // something already in the table. We shouldn't accumulate the stored 2416 // score in that case as it refers to the wrong Value. 2417 if (it->second.isValid()) 2418 Score += it->second.Score; 2419 } 2420 2421 unsigned MaxRank = std::max(Ops[i].Rank, Ops[j].Rank); 2422 if (Score > Max || (Score == Max && MaxRank < BestRank)) { 2423 BestPair = {i, j}; 2424 Max = Score; 2425 BestRank = MaxRank; 2426 } 2427 } 2428 if (Max > 1) { 2429 auto Op0 = Ops[BestPair.first]; 2430 auto Op1 = Ops[BestPair.second]; 2431 Ops.erase(&Ops[BestPair.second]); 2432 Ops.erase(&Ops[BestPair.first]); 2433 Ops.push_back(Op0); 2434 Ops.push_back(Op1); 2435 } 2436 } 2437 // Now that we ordered and optimized the expressions, splat them back into 2438 // the expression tree, removing any unneeded nodes. 2439 RewriteExprTree(I, Ops); 2440 } 2441 2442 void 2443 ReassociatePass::BuildPairMap(ReversePostOrderTraversal<Function *> &RPOT) { 2444 // Make a "pairmap" of how often each operand pair occurs. 2445 for (BasicBlock *BI : RPOT) { 2446 for (Instruction &I : *BI) { 2447 if (!I.isAssociative()) 2448 continue; 2449 2450 // Ignore nodes that aren't at the root of trees. 2451 if (I.hasOneUse() && I.user_back()->getOpcode() == I.getOpcode()) 2452 continue; 2453 2454 // Collect all operands in a single reassociable expression. 2455 // Since Reassociate has already been run once, we can assume things 2456 // are already canonical according to Reassociation's regime. 2457 SmallVector<Value *, 8> Worklist = { I.getOperand(0), I.getOperand(1) }; 2458 SmallVector<Value *, 8> Ops; 2459 while (!Worklist.empty() && Ops.size() <= GlobalReassociateLimit) { 2460 Value *Op = Worklist.pop_back_val(); 2461 Instruction *OpI = dyn_cast<Instruction>(Op); 2462 if (!OpI || OpI->getOpcode() != I.getOpcode() || !OpI->hasOneUse()) { 2463 Ops.push_back(Op); 2464 continue; 2465 } 2466 // Be paranoid about self-referencing expressions in unreachable code. 2467 if (OpI->getOperand(0) != OpI) 2468 Worklist.push_back(OpI->getOperand(0)); 2469 if (OpI->getOperand(1) != OpI) 2470 Worklist.push_back(OpI->getOperand(1)); 2471 } 2472 // Skip extremely long expressions. 2473 if (Ops.size() > GlobalReassociateLimit) 2474 continue; 2475 2476 // Add all pairwise combinations of operands to the pair map. 2477 unsigned BinaryIdx = I.getOpcode() - Instruction::BinaryOpsBegin; 2478 SmallSet<std::pair<Value *, Value*>, 32> Visited; 2479 for (unsigned i = 0; i < Ops.size() - 1; ++i) { 2480 for (unsigned j = i + 1; j < Ops.size(); ++j) { 2481 // Canonicalize operand orderings. 2482 Value *Op0 = Ops[i]; 2483 Value *Op1 = Ops[j]; 2484 if (std::less<Value *>()(Op1, Op0)) 2485 std::swap(Op0, Op1); 2486 if (!Visited.insert({Op0, Op1}).second) 2487 continue; 2488 auto res = PairMap[BinaryIdx].insert({{Op0, Op1}, {Op0, Op1, 1}}); 2489 if (!res.second) { 2490 // If either key value has been erased then we've got the same 2491 // address by coincidence. That can't happen here because nothing is 2492 // erasing values but it can happen by the time we're querying the 2493 // map. 2494 assert(res.first->second.isValid() && "WeakVH invalidated"); 2495 ++res.first->second.Score; 2496 } 2497 } 2498 } 2499 } 2500 } 2501 } 2502 2503 PreservedAnalyses ReassociatePass::run(Function &F, FunctionAnalysisManager &) { 2504 // Get the functions basic blocks in Reverse Post Order. This order is used by 2505 // BuildRankMap to pre calculate ranks correctly. It also excludes dead basic 2506 // blocks (it has been seen that the analysis in this pass could hang when 2507 // analysing dead basic blocks). 2508 ReversePostOrderTraversal<Function *> RPOT(&F); 2509 2510 // Calculate the rank map for F. 2511 BuildRankMap(F, RPOT); 2512 2513 // Build the pair map before running reassociate. 2514 // Technically this would be more accurate if we did it after one round 2515 // of reassociation, but in practice it doesn't seem to help much on 2516 // real-world code, so don't waste the compile time running reassociate 2517 // twice. 2518 // If a user wants, they could expicitly run reassociate twice in their 2519 // pass pipeline for further potential gains. 2520 // It might also be possible to update the pair map during runtime, but the 2521 // overhead of that may be large if there's many reassociable chains. 2522 BuildPairMap(RPOT); 2523 2524 MadeChange = false; 2525 2526 // Traverse the same blocks that were analysed by BuildRankMap. 2527 for (BasicBlock *BI : RPOT) { 2528 assert(RankMap.count(&*BI) && "BB should be ranked."); 2529 // Optimize every instruction in the basic block. 2530 for (BasicBlock::iterator II = BI->begin(), IE = BI->end(); II != IE;) 2531 if (isInstructionTriviallyDead(&*II)) { 2532 EraseInst(&*II++); 2533 } else { 2534 OptimizeInst(&*II); 2535 assert(II->getParent() == &*BI && "Moved to a different block!"); 2536 ++II; 2537 } 2538 2539 // Make a copy of all the instructions to be redone so we can remove dead 2540 // instructions. 2541 OrderedSet ToRedo(RedoInsts); 2542 // Iterate over all instructions to be reevaluated and remove trivially dead 2543 // instructions. If any operand of the trivially dead instruction becomes 2544 // dead mark it for deletion as well. Continue this process until all 2545 // trivially dead instructions have been removed. 2546 while (!ToRedo.empty()) { 2547 Instruction *I = ToRedo.pop_back_val(); 2548 if (isInstructionTriviallyDead(I)) { 2549 RecursivelyEraseDeadInsts(I, ToRedo); 2550 MadeChange = true; 2551 } 2552 } 2553 2554 // Now that we have removed dead instructions, we can reoptimize the 2555 // remaining instructions. 2556 while (!RedoInsts.empty()) { 2557 Instruction *I = RedoInsts.front(); 2558 RedoInsts.erase(RedoInsts.begin()); 2559 if (isInstructionTriviallyDead(I)) 2560 EraseInst(I); 2561 else 2562 OptimizeInst(I); 2563 } 2564 } 2565 2566 // We are done with the rank map and pair map. 2567 RankMap.clear(); 2568 ValueRankMap.clear(); 2569 for (auto &Entry : PairMap) 2570 Entry.clear(); 2571 2572 if (MadeChange) { 2573 PreservedAnalyses PA; 2574 PA.preserveSet<CFGAnalyses>(); 2575 PA.preserve<AAManager>(); 2576 PA.preserve<BasicAA>(); 2577 PA.preserve<GlobalsAA>(); 2578 return PA; 2579 } 2580 2581 return PreservedAnalyses::all(); 2582 } 2583 2584 namespace { 2585 2586 class ReassociateLegacyPass : public FunctionPass { 2587 ReassociatePass Impl; 2588 2589 public: 2590 static char ID; // Pass identification, replacement for typeid 2591 2592 ReassociateLegacyPass() : FunctionPass(ID) { 2593 initializeReassociateLegacyPassPass(*PassRegistry::getPassRegistry()); 2594 } 2595 2596 bool runOnFunction(Function &F) override { 2597 if (skipFunction(F)) 2598 return false; 2599 2600 FunctionAnalysisManager DummyFAM; 2601 auto PA = Impl.run(F, DummyFAM); 2602 return !PA.areAllPreserved(); 2603 } 2604 2605 void getAnalysisUsage(AnalysisUsage &AU) const override { 2606 AU.setPreservesCFG(); 2607 AU.addPreserved<AAResultsWrapperPass>(); 2608 AU.addPreserved<BasicAAWrapperPass>(); 2609 AU.addPreserved<GlobalsAAWrapperPass>(); 2610 } 2611 }; 2612 2613 } // end anonymous namespace 2614 2615 char ReassociateLegacyPass::ID = 0; 2616 2617 INITIALIZE_PASS(ReassociateLegacyPass, "reassociate", 2618 "Reassociate expressions", false, false) 2619 2620 // Public interface to the Reassociate pass 2621 FunctionPass *llvm::createReassociatePass() { 2622 return new ReassociateLegacyPass(); 2623 } 2624