1 //===- Reassociate.cpp - Reassociate binary expressions -------------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // This pass reassociates commutative expressions in an order that is designed 10 // to promote better constant propagation, GCSE, LICM, PRE, etc. 11 // 12 // For example: 4 + (x + 5) -> x + (4 + 5) 13 // 14 // In the implementation of this algorithm, constants are assigned rank = 0, 15 // function arguments are rank = 1, and other values are assigned ranks 16 // corresponding to the reverse post order traversal of current function 17 // (starting at 2), which effectively gives values in deep loops higher rank 18 // than values not in loops. 19 // 20 //===----------------------------------------------------------------------===// 21 22 #include "llvm/Transforms/Scalar/Reassociate.h" 23 #include "llvm/ADT/APFloat.h" 24 #include "llvm/ADT/APInt.h" 25 #include "llvm/ADT/DenseMap.h" 26 #include "llvm/ADT/PostOrderIterator.h" 27 #include "llvm/ADT/SetVector.h" 28 #include "llvm/ADT/SmallPtrSet.h" 29 #include "llvm/ADT/SmallSet.h" 30 #include "llvm/ADT/SmallVector.h" 31 #include "llvm/ADT/Statistic.h" 32 #include "llvm/Analysis/GlobalsModRef.h" 33 #include "llvm/Transforms/Utils/Local.h" 34 #include "llvm/Analysis/ValueTracking.h" 35 #include "llvm/IR/Argument.h" 36 #include "llvm/IR/BasicBlock.h" 37 #include "llvm/IR/CFG.h" 38 #include "llvm/IR/Constant.h" 39 #include "llvm/IR/Constants.h" 40 #include "llvm/IR/Function.h" 41 #include "llvm/IR/IRBuilder.h" 42 #include "llvm/IR/InstrTypes.h" 43 #include "llvm/IR/Instruction.h" 44 #include "llvm/IR/Instructions.h" 45 #include "llvm/IR/IntrinsicInst.h" 46 #include "llvm/IR/Operator.h" 47 #include "llvm/IR/PassManager.h" 48 #include "llvm/IR/PatternMatch.h" 49 #include "llvm/IR/Type.h" 50 #include "llvm/IR/User.h" 51 #include "llvm/IR/Value.h" 52 #include "llvm/IR/ValueHandle.h" 53 #include "llvm/Pass.h" 54 #include "llvm/Support/Casting.h" 55 #include "llvm/Support/Debug.h" 56 #include "llvm/Support/ErrorHandling.h" 57 #include "llvm/Support/raw_ostream.h" 58 #include "llvm/Transforms/Scalar.h" 59 #include <algorithm> 60 #include <cassert> 61 #include <utility> 62 63 using namespace llvm; 64 using namespace reassociate; 65 using namespace PatternMatch; 66 67 #define DEBUG_TYPE "reassociate" 68 69 STATISTIC(NumChanged, "Number of insts reassociated"); 70 STATISTIC(NumAnnihil, "Number of expr tree annihilated"); 71 STATISTIC(NumFactor , "Number of multiplies factored"); 72 73 #ifndef NDEBUG 74 /// Print out the expression identified in the Ops list. 75 static void PrintOps(Instruction *I, const SmallVectorImpl<ValueEntry> &Ops) { 76 Module *M = I->getModule(); 77 dbgs() << Instruction::getOpcodeName(I->getOpcode()) << " " 78 << *Ops[0].Op->getType() << '\t'; 79 for (unsigned i = 0, e = Ops.size(); i != e; ++i) { 80 dbgs() << "[ "; 81 Ops[i].Op->printAsOperand(dbgs(), false, M); 82 dbgs() << ", #" << Ops[i].Rank << "] "; 83 } 84 } 85 #endif 86 87 /// Utility class representing a non-constant Xor-operand. We classify 88 /// non-constant Xor-Operands into two categories: 89 /// C1) The operand is in the form "X & C", where C is a constant and C != ~0 90 /// C2) 91 /// C2.1) The operand is in the form of "X | C", where C is a non-zero 92 /// constant. 93 /// C2.2) Any operand E which doesn't fall into C1 and C2.1, we view this 94 /// operand as "E | 0" 95 class llvm::reassociate::XorOpnd { 96 public: 97 XorOpnd(Value *V); 98 99 bool isInvalid() const { return SymbolicPart == nullptr; } 100 bool isOrExpr() const { return isOr; } 101 Value *getValue() const { return OrigVal; } 102 Value *getSymbolicPart() const { return SymbolicPart; } 103 unsigned getSymbolicRank() const { return SymbolicRank; } 104 const APInt &getConstPart() const { return ConstPart; } 105 106 void Invalidate() { SymbolicPart = OrigVal = nullptr; } 107 void setSymbolicRank(unsigned R) { SymbolicRank = R; } 108 109 private: 110 Value *OrigVal; 111 Value *SymbolicPart; 112 APInt ConstPart; 113 unsigned SymbolicRank; 114 bool isOr; 115 }; 116 117 XorOpnd::XorOpnd(Value *V) { 118 assert(!isa<ConstantInt>(V) && "No ConstantInt"); 119 OrigVal = V; 120 Instruction *I = dyn_cast<Instruction>(V); 121 SymbolicRank = 0; 122 123 if (I && (I->getOpcode() == Instruction::Or || 124 I->getOpcode() == Instruction::And)) { 125 Value *V0 = I->getOperand(0); 126 Value *V1 = I->getOperand(1); 127 const APInt *C; 128 if (match(V0, m_APInt(C))) 129 std::swap(V0, V1); 130 131 if (match(V1, m_APInt(C))) { 132 ConstPart = *C; 133 SymbolicPart = V0; 134 isOr = (I->getOpcode() == Instruction::Or); 135 return; 136 } 137 } 138 139 // view the operand as "V | 0" 140 SymbolicPart = V; 141 ConstPart = APInt::getNullValue(V->getType()->getScalarSizeInBits()); 142 isOr = true; 143 } 144 145 /// Return true if V is an instruction of the specified opcode and if it 146 /// only has one use. 147 static BinaryOperator *isReassociableOp(Value *V, unsigned Opcode) { 148 auto *I = dyn_cast<Instruction>(V); 149 if (I && I->hasOneUse() && I->getOpcode() == Opcode) 150 if (!isa<FPMathOperator>(I) || I->isFast()) 151 return cast<BinaryOperator>(I); 152 return nullptr; 153 } 154 155 static BinaryOperator *isReassociableOp(Value *V, unsigned Opcode1, 156 unsigned Opcode2) { 157 auto *I = dyn_cast<Instruction>(V); 158 if (I && I->hasOneUse() && 159 (I->getOpcode() == Opcode1 || I->getOpcode() == Opcode2)) 160 if (!isa<FPMathOperator>(I) || I->isFast()) 161 return cast<BinaryOperator>(I); 162 return nullptr; 163 } 164 165 void ReassociatePass::BuildRankMap(Function &F, 166 ReversePostOrderTraversal<Function*> &RPOT) { 167 unsigned Rank = 2; 168 169 // Assign distinct ranks to function arguments. 170 for (auto &Arg : F.args()) { 171 ValueRankMap[&Arg] = ++Rank; 172 LLVM_DEBUG(dbgs() << "Calculated Rank[" << Arg.getName() << "] = " << Rank 173 << "\n"); 174 } 175 176 // Traverse basic blocks in ReversePostOrder 177 for (BasicBlock *BB : RPOT) { 178 unsigned BBRank = RankMap[BB] = ++Rank << 16; 179 180 // Walk the basic block, adding precomputed ranks for any instructions that 181 // we cannot move. This ensures that the ranks for these instructions are 182 // all different in the block. 183 for (Instruction &I : *BB) 184 if (mayBeMemoryDependent(I)) 185 ValueRankMap[&I] = ++BBRank; 186 } 187 } 188 189 unsigned ReassociatePass::getRank(Value *V) { 190 Instruction *I = dyn_cast<Instruction>(V); 191 if (!I) { 192 if (isa<Argument>(V)) return ValueRankMap[V]; // Function argument. 193 return 0; // Otherwise it's a global or constant, rank 0. 194 } 195 196 if (unsigned Rank = ValueRankMap[I]) 197 return Rank; // Rank already known? 198 199 // If this is an expression, return the 1+MAX(rank(LHS), rank(RHS)) so that 200 // we can reassociate expressions for code motion! Since we do not recurse 201 // for PHI nodes, we cannot have infinite recursion here, because there 202 // cannot be loops in the value graph that do not go through PHI nodes. 203 unsigned Rank = 0, MaxRank = RankMap[I->getParent()]; 204 for (unsigned i = 0, e = I->getNumOperands(); i != e && Rank != MaxRank; ++i) 205 Rank = std::max(Rank, getRank(I->getOperand(i))); 206 207 // If this is a 'not' or 'neg' instruction, do not count it for rank. This 208 // assures us that X and ~X will have the same rank. 209 if (!match(I, m_Not(m_Value())) && !match(I, m_Neg(m_Value())) && 210 !match(I, m_FNeg(m_Value()))) 211 ++Rank; 212 213 LLVM_DEBUG(dbgs() << "Calculated Rank[" << V->getName() << "] = " << Rank 214 << "\n"); 215 216 return ValueRankMap[I] = Rank; 217 } 218 219 // Canonicalize constants to RHS. Otherwise, sort the operands by rank. 220 void ReassociatePass::canonicalizeOperands(Instruction *I) { 221 assert(isa<BinaryOperator>(I) && "Expected binary operator."); 222 assert(I->isCommutative() && "Expected commutative operator."); 223 224 Value *LHS = I->getOperand(0); 225 Value *RHS = I->getOperand(1); 226 if (LHS == RHS || isa<Constant>(RHS)) 227 return; 228 if (isa<Constant>(LHS) || getRank(RHS) < getRank(LHS)) 229 cast<BinaryOperator>(I)->swapOperands(); 230 } 231 232 static BinaryOperator *CreateAdd(Value *S1, Value *S2, const Twine &Name, 233 Instruction *InsertBefore, Value *FlagsOp) { 234 if (S1->getType()->isIntOrIntVectorTy()) 235 return BinaryOperator::CreateAdd(S1, S2, Name, InsertBefore); 236 else { 237 BinaryOperator *Res = 238 BinaryOperator::CreateFAdd(S1, S2, Name, InsertBefore); 239 Res->setFastMathFlags(cast<FPMathOperator>(FlagsOp)->getFastMathFlags()); 240 return Res; 241 } 242 } 243 244 static BinaryOperator *CreateMul(Value *S1, Value *S2, const Twine &Name, 245 Instruction *InsertBefore, Value *FlagsOp) { 246 if (S1->getType()->isIntOrIntVectorTy()) 247 return BinaryOperator::CreateMul(S1, S2, Name, InsertBefore); 248 else { 249 BinaryOperator *Res = 250 BinaryOperator::CreateFMul(S1, S2, Name, InsertBefore); 251 Res->setFastMathFlags(cast<FPMathOperator>(FlagsOp)->getFastMathFlags()); 252 return Res; 253 } 254 } 255 256 static BinaryOperator *CreateNeg(Value *S1, const Twine &Name, 257 Instruction *InsertBefore, Value *FlagsOp) { 258 if (S1->getType()->isIntOrIntVectorTy()) 259 return BinaryOperator::CreateNeg(S1, Name, InsertBefore); 260 else { 261 BinaryOperator *Res = BinaryOperator::CreateFNeg(S1, Name, InsertBefore); 262 Res->setFastMathFlags(cast<FPMathOperator>(FlagsOp)->getFastMathFlags()); 263 return Res; 264 } 265 } 266 267 /// Replace 0-X with X*-1. 268 static BinaryOperator *LowerNegateToMultiply(Instruction *Neg) { 269 assert((isa<UnaryOperator>(Neg) || isa<BinaryOperator>(Neg)) && 270 "Expected a Negate!"); 271 // It's not safe to lower a unary FNeg into a FMul by -1.0. However, 272 // we can only reach this function with fast flags set, so it's 273 // safe to do with nnan. 274 assert((!isa<FPMathOperator>(Neg) || Neg->isFast()) && 275 "Expecting FastMathFlags!"); 276 unsigned OpNo = isa<BinaryOperator>(Neg) ? 1 : 0; 277 Type *Ty = Neg->getType(); 278 Constant *NegOne = Ty->isIntOrIntVectorTy() ? 279 ConstantInt::getAllOnesValue(Ty) : ConstantFP::get(Ty, -1.0); 280 281 BinaryOperator *Res = CreateMul(Neg->getOperand(OpNo), NegOne, "", Neg, Neg); 282 Neg->setOperand(OpNo, Constant::getNullValue(Ty)); // Drop use of op. 283 Res->takeName(Neg); 284 Neg->replaceAllUsesWith(Res); 285 Res->setDebugLoc(Neg->getDebugLoc()); 286 return Res; 287 } 288 289 /// Returns k such that lambda(2^Bitwidth) = 2^k, where lambda is the Carmichael 290 /// function. This means that x^(2^k) === 1 mod 2^Bitwidth for 291 /// every odd x, i.e. x^(2^k) = 1 for every odd x in Bitwidth-bit arithmetic. 292 /// Note that 0 <= k < Bitwidth, and if Bitwidth > 3 then x^(2^k) = 0 for every 293 /// even x in Bitwidth-bit arithmetic. 294 static unsigned CarmichaelShift(unsigned Bitwidth) { 295 if (Bitwidth < 3) 296 return Bitwidth - 1; 297 return Bitwidth - 2; 298 } 299 300 /// Add the extra weight 'RHS' to the existing weight 'LHS', 301 /// reducing the combined weight using any special properties of the operation. 302 /// The existing weight LHS represents the computation X op X op ... op X where 303 /// X occurs LHS times. The combined weight represents X op X op ... op X with 304 /// X occurring LHS + RHS times. If op is "Xor" for example then the combined 305 /// operation is equivalent to X if LHS + RHS is odd, or 0 if LHS + RHS is even; 306 /// the routine returns 1 in LHS in the first case, and 0 in LHS in the second. 307 static void IncorporateWeight(APInt &LHS, const APInt &RHS, unsigned Opcode) { 308 // If we were working with infinite precision arithmetic then the combined 309 // weight would be LHS + RHS. But we are using finite precision arithmetic, 310 // and the APInt sum LHS + RHS may not be correct if it wraps (it is correct 311 // for nilpotent operations and addition, but not for idempotent operations 312 // and multiplication), so it is important to correctly reduce the combined 313 // weight back into range if wrapping would be wrong. 314 315 // If RHS is zero then the weight didn't change. 316 if (RHS.isMinValue()) 317 return; 318 // If LHS is zero then the combined weight is RHS. 319 if (LHS.isMinValue()) { 320 LHS = RHS; 321 return; 322 } 323 // From this point on we know that neither LHS nor RHS is zero. 324 325 if (Instruction::isIdempotent(Opcode)) { 326 // Idempotent means X op X === X, so any non-zero weight is equivalent to a 327 // weight of 1. Keeping weights at zero or one also means that wrapping is 328 // not a problem. 329 assert(LHS == 1 && RHS == 1 && "Weights not reduced!"); 330 return; // Return a weight of 1. 331 } 332 if (Instruction::isNilpotent(Opcode)) { 333 // Nilpotent means X op X === 0, so reduce weights modulo 2. 334 assert(LHS == 1 && RHS == 1 && "Weights not reduced!"); 335 LHS = 0; // 1 + 1 === 0 modulo 2. 336 return; 337 } 338 if (Opcode == Instruction::Add || Opcode == Instruction::FAdd) { 339 // TODO: Reduce the weight by exploiting nsw/nuw? 340 LHS += RHS; 341 return; 342 } 343 344 assert((Opcode == Instruction::Mul || Opcode == Instruction::FMul) && 345 "Unknown associative operation!"); 346 unsigned Bitwidth = LHS.getBitWidth(); 347 // If CM is the Carmichael number then a weight W satisfying W >= CM+Bitwidth 348 // can be replaced with W-CM. That's because x^W=x^(W-CM) for every Bitwidth 349 // bit number x, since either x is odd in which case x^CM = 1, or x is even in 350 // which case both x^W and x^(W - CM) are zero. By subtracting off multiples 351 // of CM like this weights can always be reduced to the range [0, CM+Bitwidth) 352 // which by a happy accident means that they can always be represented using 353 // Bitwidth bits. 354 // TODO: Reduce the weight by exploiting nsw/nuw? (Could do much better than 355 // the Carmichael number). 356 if (Bitwidth > 3) { 357 /// CM - The value of Carmichael's lambda function. 358 APInt CM = APInt::getOneBitSet(Bitwidth, CarmichaelShift(Bitwidth)); 359 // Any weight W >= Threshold can be replaced with W - CM. 360 APInt Threshold = CM + Bitwidth; 361 assert(LHS.ult(Threshold) && RHS.ult(Threshold) && "Weights not reduced!"); 362 // For Bitwidth 4 or more the following sum does not overflow. 363 LHS += RHS; 364 while (LHS.uge(Threshold)) 365 LHS -= CM; 366 } else { 367 // To avoid problems with overflow do everything the same as above but using 368 // a larger type. 369 unsigned CM = 1U << CarmichaelShift(Bitwidth); 370 unsigned Threshold = CM + Bitwidth; 371 assert(LHS.getZExtValue() < Threshold && RHS.getZExtValue() < Threshold && 372 "Weights not reduced!"); 373 unsigned Total = LHS.getZExtValue() + RHS.getZExtValue(); 374 while (Total >= Threshold) 375 Total -= CM; 376 LHS = Total; 377 } 378 } 379 380 using RepeatedValue = std::pair<Value*, APInt>; 381 382 /// Given an associative binary expression, return the leaf 383 /// nodes in Ops along with their weights (how many times the leaf occurs). The 384 /// original expression is the same as 385 /// (Ops[0].first op Ops[0].first op ... Ops[0].first) <- Ops[0].second times 386 /// op 387 /// (Ops[1].first op Ops[1].first op ... Ops[1].first) <- Ops[1].second times 388 /// op 389 /// ... 390 /// op 391 /// (Ops[N].first op Ops[N].first op ... Ops[N].first) <- Ops[N].second times 392 /// 393 /// Note that the values Ops[0].first, ..., Ops[N].first are all distinct. 394 /// 395 /// This routine may modify the function, in which case it returns 'true'. The 396 /// changes it makes may well be destructive, changing the value computed by 'I' 397 /// to something completely different. Thus if the routine returns 'true' then 398 /// you MUST either replace I with a new expression computed from the Ops array, 399 /// or use RewriteExprTree to put the values back in. 400 /// 401 /// A leaf node is either not a binary operation of the same kind as the root 402 /// node 'I' (i.e. is not a binary operator at all, or is, but with a different 403 /// opcode), or is the same kind of binary operator but has a use which either 404 /// does not belong to the expression, or does belong to the expression but is 405 /// a leaf node. Every leaf node has at least one use that is a non-leaf node 406 /// of the expression, while for non-leaf nodes (except for the root 'I') every 407 /// use is a non-leaf node of the expression. 408 /// 409 /// For example: 410 /// expression graph node names 411 /// 412 /// + | I 413 /// / \ | 414 /// + + | A, B 415 /// / \ / \ | 416 /// * + * | C, D, E 417 /// / \ / \ / \ | 418 /// + * | F, G 419 /// 420 /// The leaf nodes are C, E, F and G. The Ops array will contain (maybe not in 421 /// that order) (C, 1), (E, 1), (F, 2), (G, 2). 422 /// 423 /// The expression is maximal: if some instruction is a binary operator of the 424 /// same kind as 'I', and all of its uses are non-leaf nodes of the expression, 425 /// then the instruction also belongs to the expression, is not a leaf node of 426 /// it, and its operands also belong to the expression (but may be leaf nodes). 427 /// 428 /// NOTE: This routine will set operands of non-leaf non-root nodes to undef in 429 /// order to ensure that every non-root node in the expression has *exactly one* 430 /// use by a non-leaf node of the expression. This destruction means that the 431 /// caller MUST either replace 'I' with a new expression or use something like 432 /// RewriteExprTree to put the values back in if the routine indicates that it 433 /// made a change by returning 'true'. 434 /// 435 /// In the above example either the right operand of A or the left operand of B 436 /// will be replaced by undef. If it is B's operand then this gives: 437 /// 438 /// + | I 439 /// / \ | 440 /// + + | A, B - operand of B replaced with undef 441 /// / \ \ | 442 /// * + * | C, D, E 443 /// / \ / \ / \ | 444 /// + * | F, G 445 /// 446 /// Note that such undef operands can only be reached by passing through 'I'. 447 /// For example, if you visit operands recursively starting from a leaf node 448 /// then you will never see such an undef operand unless you get back to 'I', 449 /// which requires passing through a phi node. 450 /// 451 /// Note that this routine may also mutate binary operators of the wrong type 452 /// that have all uses inside the expression (i.e. only used by non-leaf nodes 453 /// of the expression) if it can turn them into binary operators of the right 454 /// type and thus make the expression bigger. 455 static bool LinearizeExprTree(Instruction *I, 456 SmallVectorImpl<RepeatedValue> &Ops) { 457 assert((isa<UnaryOperator>(I) || isa<BinaryOperator>(I)) && 458 "Expected a UnaryOperator or BinaryOperator!"); 459 LLVM_DEBUG(dbgs() << "LINEARIZE: " << *I << '\n'); 460 unsigned Bitwidth = I->getType()->getScalarType()->getPrimitiveSizeInBits(); 461 unsigned Opcode = I->getOpcode(); 462 assert(I->isAssociative() && I->isCommutative() && 463 "Expected an associative and commutative operation!"); 464 465 // Visit all operands of the expression, keeping track of their weight (the 466 // number of paths from the expression root to the operand, or if you like 467 // the number of times that operand occurs in the linearized expression). 468 // For example, if I = X + A, where X = A + B, then I, X and B have weight 1 469 // while A has weight two. 470 471 // Worklist of non-leaf nodes (their operands are in the expression too) along 472 // with their weights, representing a certain number of paths to the operator. 473 // If an operator occurs in the worklist multiple times then we found multiple 474 // ways to get to it. 475 SmallVector<std::pair<Instruction*, APInt>, 8> Worklist; // (Op, Weight) 476 Worklist.push_back(std::make_pair(I, APInt(Bitwidth, 1))); 477 bool Changed = false; 478 479 // Leaves of the expression are values that either aren't the right kind of 480 // operation (eg: a constant, or a multiply in an add tree), or are, but have 481 // some uses that are not inside the expression. For example, in I = X + X, 482 // X = A + B, the value X has two uses (by I) that are in the expression. If 483 // X has any other uses, for example in a return instruction, then we consider 484 // X to be a leaf, and won't analyze it further. When we first visit a value, 485 // if it has more than one use then at first we conservatively consider it to 486 // be a leaf. Later, as the expression is explored, we may discover some more 487 // uses of the value from inside the expression. If all uses turn out to be 488 // from within the expression (and the value is a binary operator of the right 489 // kind) then the value is no longer considered to be a leaf, and its operands 490 // are explored. 491 492 // Leaves - Keeps track of the set of putative leaves as well as the number of 493 // paths to each leaf seen so far. 494 using LeafMap = DenseMap<Value *, APInt>; 495 LeafMap Leaves; // Leaf -> Total weight so far. 496 SmallVector<Value *, 8> LeafOrder; // Ensure deterministic leaf output order. 497 498 #ifndef NDEBUG 499 SmallPtrSet<Value *, 8> Visited; // For sanity checking the iteration scheme. 500 #endif 501 while (!Worklist.empty()) { 502 std::pair<Instruction*, APInt> P = Worklist.pop_back_val(); 503 I = P.first; // We examine the operands of this binary operator. 504 505 for (unsigned OpIdx = 0; OpIdx < I->getNumOperands(); ++OpIdx) { // Visit operands. 506 Value *Op = I->getOperand(OpIdx); 507 APInt Weight = P.second; // Number of paths to this operand. 508 LLVM_DEBUG(dbgs() << "OPERAND: " << *Op << " (" << Weight << ")\n"); 509 assert(!Op->use_empty() && "No uses, so how did we get to it?!"); 510 511 // If this is a binary operation of the right kind with only one use then 512 // add its operands to the expression. 513 if (BinaryOperator *BO = isReassociableOp(Op, Opcode)) { 514 assert(Visited.insert(Op).second && "Not first visit!"); 515 LLVM_DEBUG(dbgs() << "DIRECT ADD: " << *Op << " (" << Weight << ")\n"); 516 Worklist.push_back(std::make_pair(BO, Weight)); 517 continue; 518 } 519 520 // Appears to be a leaf. Is the operand already in the set of leaves? 521 LeafMap::iterator It = Leaves.find(Op); 522 if (It == Leaves.end()) { 523 // Not in the leaf map. Must be the first time we saw this operand. 524 assert(Visited.insert(Op).second && "Not first visit!"); 525 if (!Op->hasOneUse()) { 526 // This value has uses not accounted for by the expression, so it is 527 // not safe to modify. Mark it as being a leaf. 528 LLVM_DEBUG(dbgs() 529 << "ADD USES LEAF: " << *Op << " (" << Weight << ")\n"); 530 LeafOrder.push_back(Op); 531 Leaves[Op] = Weight; 532 continue; 533 } 534 // No uses outside the expression, try morphing it. 535 } else { 536 // Already in the leaf map. 537 assert(It != Leaves.end() && Visited.count(Op) && 538 "In leaf map but not visited!"); 539 540 // Update the number of paths to the leaf. 541 IncorporateWeight(It->second, Weight, Opcode); 542 543 #if 0 // TODO: Re-enable once PR13021 is fixed. 544 // The leaf already has one use from inside the expression. As we want 545 // exactly one such use, drop this new use of the leaf. 546 assert(!Op->hasOneUse() && "Only one use, but we got here twice!"); 547 I->setOperand(OpIdx, UndefValue::get(I->getType())); 548 Changed = true; 549 550 // If the leaf is a binary operation of the right kind and we now see 551 // that its multiple original uses were in fact all by nodes belonging 552 // to the expression, then no longer consider it to be a leaf and add 553 // its operands to the expression. 554 if (BinaryOperator *BO = isReassociableOp(Op, Opcode)) { 555 LLVM_DEBUG(dbgs() << "UNLEAF: " << *Op << " (" << It->second << ")\n"); 556 Worklist.push_back(std::make_pair(BO, It->second)); 557 Leaves.erase(It); 558 continue; 559 } 560 #endif 561 562 // If we still have uses that are not accounted for by the expression 563 // then it is not safe to modify the value. 564 if (!Op->hasOneUse()) 565 continue; 566 567 // No uses outside the expression, try morphing it. 568 Weight = It->second; 569 Leaves.erase(It); // Since the value may be morphed below. 570 } 571 572 // At this point we have a value which, first of all, is not a binary 573 // expression of the right kind, and secondly, is only used inside the 574 // expression. This means that it can safely be modified. See if we 575 // can usefully morph it into an expression of the right kind. 576 assert((!isa<Instruction>(Op) || 577 cast<Instruction>(Op)->getOpcode() != Opcode 578 || (isa<FPMathOperator>(Op) && 579 !cast<Instruction>(Op)->isFast())) && 580 "Should have been handled above!"); 581 assert(Op->hasOneUse() && "Has uses outside the expression tree!"); 582 583 // If this is a multiply expression, turn any internal negations into 584 // multiplies by -1 so they can be reassociated. 585 if (Instruction *Tmp = dyn_cast<Instruction>(Op)) 586 if ((Opcode == Instruction::Mul && match(Tmp, m_Neg(m_Value()))) || 587 (Opcode == Instruction::FMul && match(Tmp, m_FNeg(m_Value())))) { 588 LLVM_DEBUG(dbgs() 589 << "MORPH LEAF: " << *Op << " (" << Weight << ") TO "); 590 Tmp = LowerNegateToMultiply(Tmp); 591 LLVM_DEBUG(dbgs() << *Tmp << '\n'); 592 Worklist.push_back(std::make_pair(Tmp, Weight)); 593 Changed = true; 594 continue; 595 } 596 597 // Failed to morph into an expression of the right type. This really is 598 // a leaf. 599 LLVM_DEBUG(dbgs() << "ADD LEAF: " << *Op << " (" << Weight << ")\n"); 600 assert(!isReassociableOp(Op, Opcode) && "Value was morphed?"); 601 LeafOrder.push_back(Op); 602 Leaves[Op] = Weight; 603 } 604 } 605 606 // The leaves, repeated according to their weights, represent the linearized 607 // form of the expression. 608 for (unsigned i = 0, e = LeafOrder.size(); i != e; ++i) { 609 Value *V = LeafOrder[i]; 610 LeafMap::iterator It = Leaves.find(V); 611 if (It == Leaves.end()) 612 // Node initially thought to be a leaf wasn't. 613 continue; 614 assert(!isReassociableOp(V, Opcode) && "Shouldn't be a leaf!"); 615 APInt Weight = It->second; 616 if (Weight.isMinValue()) 617 // Leaf already output or weight reduction eliminated it. 618 continue; 619 // Ensure the leaf is only output once. 620 It->second = 0; 621 Ops.push_back(std::make_pair(V, Weight)); 622 } 623 624 // For nilpotent operations or addition there may be no operands, for example 625 // because the expression was "X xor X" or consisted of 2^Bitwidth additions: 626 // in both cases the weight reduces to 0 causing the value to be skipped. 627 if (Ops.empty()) { 628 Constant *Identity = ConstantExpr::getBinOpIdentity(Opcode, I->getType()); 629 assert(Identity && "Associative operation without identity!"); 630 Ops.emplace_back(Identity, APInt(Bitwidth, 1)); 631 } 632 633 return Changed; 634 } 635 636 /// Now that the operands for this expression tree are 637 /// linearized and optimized, emit them in-order. 638 void ReassociatePass::RewriteExprTree(BinaryOperator *I, 639 SmallVectorImpl<ValueEntry> &Ops) { 640 assert(Ops.size() > 1 && "Single values should be used directly!"); 641 642 // Since our optimizations should never increase the number of operations, the 643 // new expression can usually be written reusing the existing binary operators 644 // from the original expression tree, without creating any new instructions, 645 // though the rewritten expression may have a completely different topology. 646 // We take care to not change anything if the new expression will be the same 647 // as the original. If more than trivial changes (like commuting operands) 648 // were made then we are obliged to clear out any optional subclass data like 649 // nsw flags. 650 651 /// NodesToRewrite - Nodes from the original expression available for writing 652 /// the new expression into. 653 SmallVector<BinaryOperator*, 8> NodesToRewrite; 654 unsigned Opcode = I->getOpcode(); 655 BinaryOperator *Op = I; 656 657 /// NotRewritable - The operands being written will be the leaves of the new 658 /// expression and must not be used as inner nodes (via NodesToRewrite) by 659 /// mistake. Inner nodes are always reassociable, and usually leaves are not 660 /// (if they were they would have been incorporated into the expression and so 661 /// would not be leaves), so most of the time there is no danger of this. But 662 /// in rare cases a leaf may become reassociable if an optimization kills uses 663 /// of it, or it may momentarily become reassociable during rewriting (below) 664 /// due it being removed as an operand of one of its uses. Ensure that misuse 665 /// of leaf nodes as inner nodes cannot occur by remembering all of the future 666 /// leaves and refusing to reuse any of them as inner nodes. 667 SmallPtrSet<Value*, 8> NotRewritable; 668 for (unsigned i = 0, e = Ops.size(); i != e; ++i) 669 NotRewritable.insert(Ops[i].Op); 670 671 // ExpressionChanged - Non-null if the rewritten expression differs from the 672 // original in some non-trivial way, requiring the clearing of optional flags. 673 // Flags are cleared from the operator in ExpressionChanged up to I inclusive. 674 BinaryOperator *ExpressionChanged = nullptr; 675 for (unsigned i = 0; ; ++i) { 676 // The last operation (which comes earliest in the IR) is special as both 677 // operands will come from Ops, rather than just one with the other being 678 // a subexpression. 679 if (i+2 == Ops.size()) { 680 Value *NewLHS = Ops[i].Op; 681 Value *NewRHS = Ops[i+1].Op; 682 Value *OldLHS = Op->getOperand(0); 683 Value *OldRHS = Op->getOperand(1); 684 685 if (NewLHS == OldLHS && NewRHS == OldRHS) 686 // Nothing changed, leave it alone. 687 break; 688 689 if (NewLHS == OldRHS && NewRHS == OldLHS) { 690 // The order of the operands was reversed. Swap them. 691 LLVM_DEBUG(dbgs() << "RA: " << *Op << '\n'); 692 Op->swapOperands(); 693 LLVM_DEBUG(dbgs() << "TO: " << *Op << '\n'); 694 MadeChange = true; 695 ++NumChanged; 696 break; 697 } 698 699 // The new operation differs non-trivially from the original. Overwrite 700 // the old operands with the new ones. 701 LLVM_DEBUG(dbgs() << "RA: " << *Op << '\n'); 702 if (NewLHS != OldLHS) { 703 BinaryOperator *BO = isReassociableOp(OldLHS, Opcode); 704 if (BO && !NotRewritable.count(BO)) 705 NodesToRewrite.push_back(BO); 706 Op->setOperand(0, NewLHS); 707 } 708 if (NewRHS != OldRHS) { 709 BinaryOperator *BO = isReassociableOp(OldRHS, Opcode); 710 if (BO && !NotRewritable.count(BO)) 711 NodesToRewrite.push_back(BO); 712 Op->setOperand(1, NewRHS); 713 } 714 LLVM_DEBUG(dbgs() << "TO: " << *Op << '\n'); 715 716 ExpressionChanged = Op; 717 MadeChange = true; 718 ++NumChanged; 719 720 break; 721 } 722 723 // Not the last operation. The left-hand side will be a sub-expression 724 // while the right-hand side will be the current element of Ops. 725 Value *NewRHS = Ops[i].Op; 726 if (NewRHS != Op->getOperand(1)) { 727 LLVM_DEBUG(dbgs() << "RA: " << *Op << '\n'); 728 if (NewRHS == Op->getOperand(0)) { 729 // The new right-hand side was already present as the left operand. If 730 // we are lucky then swapping the operands will sort out both of them. 731 Op->swapOperands(); 732 } else { 733 // Overwrite with the new right-hand side. 734 BinaryOperator *BO = isReassociableOp(Op->getOperand(1), Opcode); 735 if (BO && !NotRewritable.count(BO)) 736 NodesToRewrite.push_back(BO); 737 Op->setOperand(1, NewRHS); 738 ExpressionChanged = Op; 739 } 740 LLVM_DEBUG(dbgs() << "TO: " << *Op << '\n'); 741 MadeChange = true; 742 ++NumChanged; 743 } 744 745 // Now deal with the left-hand side. If this is already an operation node 746 // from the original expression then just rewrite the rest of the expression 747 // into it. 748 BinaryOperator *BO = isReassociableOp(Op->getOperand(0), Opcode); 749 if (BO && !NotRewritable.count(BO)) { 750 Op = BO; 751 continue; 752 } 753 754 // Otherwise, grab a spare node from the original expression and use that as 755 // the left-hand side. If there are no nodes left then the optimizers made 756 // an expression with more nodes than the original! This usually means that 757 // they did something stupid but it might mean that the problem was just too 758 // hard (finding the mimimal number of multiplications needed to realize a 759 // multiplication expression is NP-complete). Whatever the reason, smart or 760 // stupid, create a new node if there are none left. 761 BinaryOperator *NewOp; 762 if (NodesToRewrite.empty()) { 763 Constant *Undef = UndefValue::get(I->getType()); 764 NewOp = BinaryOperator::Create(Instruction::BinaryOps(Opcode), 765 Undef, Undef, "", I); 766 if (NewOp->getType()->isFPOrFPVectorTy()) 767 NewOp->setFastMathFlags(I->getFastMathFlags()); 768 } else { 769 NewOp = NodesToRewrite.pop_back_val(); 770 } 771 772 LLVM_DEBUG(dbgs() << "RA: " << *Op << '\n'); 773 Op->setOperand(0, NewOp); 774 LLVM_DEBUG(dbgs() << "TO: " << *Op << '\n'); 775 ExpressionChanged = Op; 776 MadeChange = true; 777 ++NumChanged; 778 Op = NewOp; 779 } 780 781 // If the expression changed non-trivially then clear out all subclass data 782 // starting from the operator specified in ExpressionChanged, and compactify 783 // the operators to just before the expression root to guarantee that the 784 // expression tree is dominated by all of Ops. 785 if (ExpressionChanged) 786 do { 787 // Preserve FastMathFlags. 788 if (isa<FPMathOperator>(I)) { 789 FastMathFlags Flags = I->getFastMathFlags(); 790 ExpressionChanged->clearSubclassOptionalData(); 791 ExpressionChanged->setFastMathFlags(Flags); 792 } else 793 ExpressionChanged->clearSubclassOptionalData(); 794 795 if (ExpressionChanged == I) 796 break; 797 798 // Discard any debug info related to the expressions that has changed (we 799 // can leave debug infor related to the root, since the result of the 800 // expression tree should be the same even after reassociation). 801 replaceDbgUsesWithUndef(ExpressionChanged); 802 803 ExpressionChanged->moveBefore(I); 804 ExpressionChanged = cast<BinaryOperator>(*ExpressionChanged->user_begin()); 805 } while (true); 806 807 // Throw away any left over nodes from the original expression. 808 for (unsigned i = 0, e = NodesToRewrite.size(); i != e; ++i) 809 RedoInsts.insert(NodesToRewrite[i]); 810 } 811 812 /// Insert instructions before the instruction pointed to by BI, 813 /// that computes the negative version of the value specified. The negative 814 /// version of the value is returned, and BI is left pointing at the instruction 815 /// that should be processed next by the reassociation pass. 816 /// Also add intermediate instructions to the redo list that are modified while 817 /// pushing the negates through adds. These will be revisited to see if 818 /// additional opportunities have been exposed. 819 static Value *NegateValue(Value *V, Instruction *BI, 820 ReassociatePass::OrderedSet &ToRedo) { 821 if (auto *C = dyn_cast<Constant>(V)) 822 return C->getType()->isFPOrFPVectorTy() ? ConstantExpr::getFNeg(C) : 823 ConstantExpr::getNeg(C); 824 825 // We are trying to expose opportunity for reassociation. One of the things 826 // that we want to do to achieve this is to push a negation as deep into an 827 // expression chain as possible, to expose the add instructions. In practice, 828 // this means that we turn this: 829 // X = -(A+12+C+D) into X = -A + -12 + -C + -D = -12 + -A + -C + -D 830 // so that later, a: Y = 12+X could get reassociated with the -12 to eliminate 831 // the constants. We assume that instcombine will clean up the mess later if 832 // we introduce tons of unnecessary negation instructions. 833 // 834 if (BinaryOperator *I = 835 isReassociableOp(V, Instruction::Add, Instruction::FAdd)) { 836 // Push the negates through the add. 837 I->setOperand(0, NegateValue(I->getOperand(0), BI, ToRedo)); 838 I->setOperand(1, NegateValue(I->getOperand(1), BI, ToRedo)); 839 if (I->getOpcode() == Instruction::Add) { 840 I->setHasNoUnsignedWrap(false); 841 I->setHasNoSignedWrap(false); 842 } 843 844 // We must move the add instruction here, because the neg instructions do 845 // not dominate the old add instruction in general. By moving it, we are 846 // assured that the neg instructions we just inserted dominate the 847 // instruction we are about to insert after them. 848 // 849 I->moveBefore(BI); 850 I->setName(I->getName()+".neg"); 851 852 // Add the intermediate negates to the redo list as processing them later 853 // could expose more reassociating opportunities. 854 ToRedo.insert(I); 855 return I; 856 } 857 858 // Okay, we need to materialize a negated version of V with an instruction. 859 // Scan the use lists of V to see if we have one already. 860 for (User *U : V->users()) { 861 if (!match(U, m_Neg(m_Value())) && !match(U, m_FNeg(m_Value()))) 862 continue; 863 864 // We found one! Now we have to make sure that the definition dominates 865 // this use. We do this by moving it to the entry block (if it is a 866 // non-instruction value) or right after the definition. These negates will 867 // be zapped by reassociate later, so we don't need much finesse here. 868 BinaryOperator *TheNeg = cast<BinaryOperator>(U); 869 870 // Verify that the negate is in this function, V might be a constant expr. 871 if (TheNeg->getParent()->getParent() != BI->getParent()->getParent()) 872 continue; 873 874 bool FoundCatchSwitch = false; 875 876 BasicBlock::iterator InsertPt; 877 if (Instruction *InstInput = dyn_cast<Instruction>(V)) { 878 if (InvokeInst *II = dyn_cast<InvokeInst>(InstInput)) { 879 InsertPt = II->getNormalDest()->begin(); 880 } else { 881 InsertPt = ++InstInput->getIterator(); 882 } 883 884 const BasicBlock *BB = InsertPt->getParent(); 885 886 // Make sure we don't move anything before PHIs or exception 887 // handling pads. 888 while (InsertPt != BB->end() && (isa<PHINode>(InsertPt) || 889 InsertPt->isEHPad())) { 890 if (isa<CatchSwitchInst>(InsertPt)) 891 // A catchswitch cannot have anything in the block except 892 // itself and PHIs. We'll bail out below. 893 FoundCatchSwitch = true; 894 ++InsertPt; 895 } 896 } else { 897 InsertPt = TheNeg->getParent()->getParent()->getEntryBlock().begin(); 898 } 899 900 // We found a catchswitch in the block where we want to move the 901 // neg. We cannot move anything into that block. Bail and just 902 // create the neg before BI, as if we hadn't found an existing 903 // neg. 904 if (FoundCatchSwitch) 905 break; 906 907 TheNeg->moveBefore(&*InsertPt); 908 if (TheNeg->getOpcode() == Instruction::Sub) { 909 TheNeg->setHasNoUnsignedWrap(false); 910 TheNeg->setHasNoSignedWrap(false); 911 } else { 912 TheNeg->andIRFlags(BI); 913 } 914 ToRedo.insert(TheNeg); 915 return TheNeg; 916 } 917 918 // Insert a 'neg' instruction that subtracts the value from zero to get the 919 // negation. 920 BinaryOperator *NewNeg = CreateNeg(V, V->getName() + ".neg", BI, BI); 921 ToRedo.insert(NewNeg); 922 return NewNeg; 923 } 924 925 /// Return true if we should break up this subtract of X-Y into (X + -Y). 926 static bool ShouldBreakUpSubtract(Instruction *Sub) { 927 // If this is a negation, we can't split it up! 928 if (match(Sub, m_Neg(m_Value())) || match(Sub, m_FNeg(m_Value()))) 929 return false; 930 931 // Don't breakup X - undef. 932 if (isa<UndefValue>(Sub->getOperand(1))) 933 return false; 934 935 // Don't bother to break this up unless either the LHS is an associable add or 936 // subtract or if this is only used by one. 937 Value *V0 = Sub->getOperand(0); 938 if (isReassociableOp(V0, Instruction::Add, Instruction::FAdd) || 939 isReassociableOp(V0, Instruction::Sub, Instruction::FSub)) 940 return true; 941 Value *V1 = Sub->getOperand(1); 942 if (isReassociableOp(V1, Instruction::Add, Instruction::FAdd) || 943 isReassociableOp(V1, Instruction::Sub, Instruction::FSub)) 944 return true; 945 Value *VB = Sub->user_back(); 946 if (Sub->hasOneUse() && 947 (isReassociableOp(VB, Instruction::Add, Instruction::FAdd) || 948 isReassociableOp(VB, Instruction::Sub, Instruction::FSub))) 949 return true; 950 951 return false; 952 } 953 954 /// If we have (X-Y), and if either X is an add, or if this is only used by an 955 /// add, transform this into (X+(0-Y)) to promote better reassociation. 956 static BinaryOperator *BreakUpSubtract(Instruction *Sub, 957 ReassociatePass::OrderedSet &ToRedo) { 958 // Convert a subtract into an add and a neg instruction. This allows sub 959 // instructions to be commuted with other add instructions. 960 // 961 // Calculate the negative value of Operand 1 of the sub instruction, 962 // and set it as the RHS of the add instruction we just made. 963 Value *NegVal = NegateValue(Sub->getOperand(1), Sub, ToRedo); 964 BinaryOperator *New = CreateAdd(Sub->getOperand(0), NegVal, "", Sub, Sub); 965 Sub->setOperand(0, Constant::getNullValue(Sub->getType())); // Drop use of op. 966 Sub->setOperand(1, Constant::getNullValue(Sub->getType())); // Drop use of op. 967 New->takeName(Sub); 968 969 // Everyone now refers to the add instruction. 970 Sub->replaceAllUsesWith(New); 971 New->setDebugLoc(Sub->getDebugLoc()); 972 973 LLVM_DEBUG(dbgs() << "Negated: " << *New << '\n'); 974 return New; 975 } 976 977 /// If this is a shift of a reassociable multiply or is used by one, change 978 /// this into a multiply by a constant to assist with further reassociation. 979 static BinaryOperator *ConvertShiftToMul(Instruction *Shl) { 980 Constant *MulCst = ConstantInt::get(Shl->getType(), 1); 981 MulCst = ConstantExpr::getShl(MulCst, cast<Constant>(Shl->getOperand(1))); 982 983 BinaryOperator *Mul = 984 BinaryOperator::CreateMul(Shl->getOperand(0), MulCst, "", Shl); 985 Shl->setOperand(0, UndefValue::get(Shl->getType())); // Drop use of op. 986 Mul->takeName(Shl); 987 988 // Everyone now refers to the mul instruction. 989 Shl->replaceAllUsesWith(Mul); 990 Mul->setDebugLoc(Shl->getDebugLoc()); 991 992 // We can safely preserve the nuw flag in all cases. It's also safe to turn a 993 // nuw nsw shl into a nuw nsw mul. However, nsw in isolation requires special 994 // handling. 995 bool NSW = cast<BinaryOperator>(Shl)->hasNoSignedWrap(); 996 bool NUW = cast<BinaryOperator>(Shl)->hasNoUnsignedWrap(); 997 if (NSW && NUW) 998 Mul->setHasNoSignedWrap(true); 999 Mul->setHasNoUnsignedWrap(NUW); 1000 return Mul; 1001 } 1002 1003 /// Scan backwards and forwards among values with the same rank as element i 1004 /// to see if X exists. If X does not exist, return i. This is useful when 1005 /// scanning for 'x' when we see '-x' because they both get the same rank. 1006 static unsigned FindInOperandList(const SmallVectorImpl<ValueEntry> &Ops, 1007 unsigned i, Value *X) { 1008 unsigned XRank = Ops[i].Rank; 1009 unsigned e = Ops.size(); 1010 for (unsigned j = i+1; j != e && Ops[j].Rank == XRank; ++j) { 1011 if (Ops[j].Op == X) 1012 return j; 1013 if (Instruction *I1 = dyn_cast<Instruction>(Ops[j].Op)) 1014 if (Instruction *I2 = dyn_cast<Instruction>(X)) 1015 if (I1->isIdenticalTo(I2)) 1016 return j; 1017 } 1018 // Scan backwards. 1019 for (unsigned j = i-1; j != ~0U && Ops[j].Rank == XRank; --j) { 1020 if (Ops[j].Op == X) 1021 return j; 1022 if (Instruction *I1 = dyn_cast<Instruction>(Ops[j].Op)) 1023 if (Instruction *I2 = dyn_cast<Instruction>(X)) 1024 if (I1->isIdenticalTo(I2)) 1025 return j; 1026 } 1027 return i; 1028 } 1029 1030 /// Emit a tree of add instructions, summing Ops together 1031 /// and returning the result. Insert the tree before I. 1032 static Value *EmitAddTreeOfValues(Instruction *I, 1033 SmallVectorImpl<WeakTrackingVH> &Ops) { 1034 if (Ops.size() == 1) return Ops.back(); 1035 1036 Value *V1 = Ops.back(); 1037 Ops.pop_back(); 1038 Value *V2 = EmitAddTreeOfValues(I, Ops); 1039 return CreateAdd(V2, V1, "reass.add", I, I); 1040 } 1041 1042 /// If V is an expression tree that is a multiplication sequence, 1043 /// and if this sequence contains a multiply by Factor, 1044 /// remove Factor from the tree and return the new tree. 1045 Value *ReassociatePass::RemoveFactorFromExpression(Value *V, Value *Factor) { 1046 BinaryOperator *BO = isReassociableOp(V, Instruction::Mul, Instruction::FMul); 1047 if (!BO) 1048 return nullptr; 1049 1050 SmallVector<RepeatedValue, 8> Tree; 1051 MadeChange |= LinearizeExprTree(BO, Tree); 1052 SmallVector<ValueEntry, 8> Factors; 1053 Factors.reserve(Tree.size()); 1054 for (unsigned i = 0, e = Tree.size(); i != e; ++i) { 1055 RepeatedValue E = Tree[i]; 1056 Factors.append(E.second.getZExtValue(), 1057 ValueEntry(getRank(E.first), E.first)); 1058 } 1059 1060 bool FoundFactor = false; 1061 bool NeedsNegate = false; 1062 for (unsigned i = 0, e = Factors.size(); i != e; ++i) { 1063 if (Factors[i].Op == Factor) { 1064 FoundFactor = true; 1065 Factors.erase(Factors.begin()+i); 1066 break; 1067 } 1068 1069 // If this is a negative version of this factor, remove it. 1070 if (ConstantInt *FC1 = dyn_cast<ConstantInt>(Factor)) { 1071 if (ConstantInt *FC2 = dyn_cast<ConstantInt>(Factors[i].Op)) 1072 if (FC1->getValue() == -FC2->getValue()) { 1073 FoundFactor = NeedsNegate = true; 1074 Factors.erase(Factors.begin()+i); 1075 break; 1076 } 1077 } else if (ConstantFP *FC1 = dyn_cast<ConstantFP>(Factor)) { 1078 if (ConstantFP *FC2 = dyn_cast<ConstantFP>(Factors[i].Op)) { 1079 const APFloat &F1 = FC1->getValueAPF(); 1080 APFloat F2(FC2->getValueAPF()); 1081 F2.changeSign(); 1082 if (F1.compare(F2) == APFloat::cmpEqual) { 1083 FoundFactor = NeedsNegate = true; 1084 Factors.erase(Factors.begin() + i); 1085 break; 1086 } 1087 } 1088 } 1089 } 1090 1091 if (!FoundFactor) { 1092 // Make sure to restore the operands to the expression tree. 1093 RewriteExprTree(BO, Factors); 1094 return nullptr; 1095 } 1096 1097 BasicBlock::iterator InsertPt = ++BO->getIterator(); 1098 1099 // If this was just a single multiply, remove the multiply and return the only 1100 // remaining operand. 1101 if (Factors.size() == 1) { 1102 RedoInsts.insert(BO); 1103 V = Factors[0].Op; 1104 } else { 1105 RewriteExprTree(BO, Factors); 1106 V = BO; 1107 } 1108 1109 if (NeedsNegate) 1110 V = CreateNeg(V, "neg", &*InsertPt, BO); 1111 1112 return V; 1113 } 1114 1115 /// If V is a single-use multiply, recursively add its operands as factors, 1116 /// otherwise add V to the list of factors. 1117 /// 1118 /// Ops is the top-level list of add operands we're trying to factor. 1119 static void FindSingleUseMultiplyFactors(Value *V, 1120 SmallVectorImpl<Value*> &Factors) { 1121 BinaryOperator *BO = isReassociableOp(V, Instruction::Mul, Instruction::FMul); 1122 if (!BO) { 1123 Factors.push_back(V); 1124 return; 1125 } 1126 1127 // Otherwise, add the LHS and RHS to the list of factors. 1128 FindSingleUseMultiplyFactors(BO->getOperand(1), Factors); 1129 FindSingleUseMultiplyFactors(BO->getOperand(0), Factors); 1130 } 1131 1132 /// Optimize a series of operands to an 'and', 'or', or 'xor' instruction. 1133 /// This optimizes based on identities. If it can be reduced to a single Value, 1134 /// it is returned, otherwise the Ops list is mutated as necessary. 1135 static Value *OptimizeAndOrXor(unsigned Opcode, 1136 SmallVectorImpl<ValueEntry> &Ops) { 1137 // Scan the operand lists looking for X and ~X pairs, along with X,X pairs. 1138 // If we find any, we can simplify the expression. X&~X == 0, X|~X == -1. 1139 for (unsigned i = 0, e = Ops.size(); i != e; ++i) { 1140 // First, check for X and ~X in the operand list. 1141 assert(i < Ops.size()); 1142 Value *X; 1143 if (match(Ops[i].Op, m_Not(m_Value(X)))) { // Cannot occur for ^. 1144 unsigned FoundX = FindInOperandList(Ops, i, X); 1145 if (FoundX != i) { 1146 if (Opcode == Instruction::And) // ...&X&~X = 0 1147 return Constant::getNullValue(X->getType()); 1148 1149 if (Opcode == Instruction::Or) // ...|X|~X = -1 1150 return Constant::getAllOnesValue(X->getType()); 1151 } 1152 } 1153 1154 // Next, check for duplicate pairs of values, which we assume are next to 1155 // each other, due to our sorting criteria. 1156 assert(i < Ops.size()); 1157 if (i+1 != Ops.size() && Ops[i+1].Op == Ops[i].Op) { 1158 if (Opcode == Instruction::And || Opcode == Instruction::Or) { 1159 // Drop duplicate values for And and Or. 1160 Ops.erase(Ops.begin()+i); 1161 --i; --e; 1162 ++NumAnnihil; 1163 continue; 1164 } 1165 1166 // Drop pairs of values for Xor. 1167 assert(Opcode == Instruction::Xor); 1168 if (e == 2) 1169 return Constant::getNullValue(Ops[0].Op->getType()); 1170 1171 // Y ^ X^X -> Y 1172 Ops.erase(Ops.begin()+i, Ops.begin()+i+2); 1173 i -= 1; e -= 2; 1174 ++NumAnnihil; 1175 } 1176 } 1177 return nullptr; 1178 } 1179 1180 /// Helper function of CombineXorOpnd(). It creates a bitwise-and 1181 /// instruction with the given two operands, and return the resulting 1182 /// instruction. There are two special cases: 1) if the constant operand is 0, 1183 /// it will return NULL. 2) if the constant is ~0, the symbolic operand will 1184 /// be returned. 1185 static Value *createAndInstr(Instruction *InsertBefore, Value *Opnd, 1186 const APInt &ConstOpnd) { 1187 if (ConstOpnd.isNullValue()) 1188 return nullptr; 1189 1190 if (ConstOpnd.isAllOnesValue()) 1191 return Opnd; 1192 1193 Instruction *I = BinaryOperator::CreateAnd( 1194 Opnd, ConstantInt::get(Opnd->getType(), ConstOpnd), "and.ra", 1195 InsertBefore); 1196 I->setDebugLoc(InsertBefore->getDebugLoc()); 1197 return I; 1198 } 1199 1200 // Helper function of OptimizeXor(). It tries to simplify "Opnd1 ^ ConstOpnd" 1201 // into "R ^ C", where C would be 0, and R is a symbolic value. 1202 // 1203 // If it was successful, true is returned, and the "R" and "C" is returned 1204 // via "Res" and "ConstOpnd", respectively; otherwise, false is returned, 1205 // and both "Res" and "ConstOpnd" remain unchanged. 1206 bool ReassociatePass::CombineXorOpnd(Instruction *I, XorOpnd *Opnd1, 1207 APInt &ConstOpnd, Value *&Res) { 1208 // Xor-Rule 1: (x | c1) ^ c2 = (x | c1) ^ (c1 ^ c1) ^ c2 1209 // = ((x | c1) ^ c1) ^ (c1 ^ c2) 1210 // = (x & ~c1) ^ (c1 ^ c2) 1211 // It is useful only when c1 == c2. 1212 if (!Opnd1->isOrExpr() || Opnd1->getConstPart().isNullValue()) 1213 return false; 1214 1215 if (!Opnd1->getValue()->hasOneUse()) 1216 return false; 1217 1218 const APInt &C1 = Opnd1->getConstPart(); 1219 if (C1 != ConstOpnd) 1220 return false; 1221 1222 Value *X = Opnd1->getSymbolicPart(); 1223 Res = createAndInstr(I, X, ~C1); 1224 // ConstOpnd was C2, now C1 ^ C2. 1225 ConstOpnd ^= C1; 1226 1227 if (Instruction *T = dyn_cast<Instruction>(Opnd1->getValue())) 1228 RedoInsts.insert(T); 1229 return true; 1230 } 1231 1232 // Helper function of OptimizeXor(). It tries to simplify 1233 // "Opnd1 ^ Opnd2 ^ ConstOpnd" into "R ^ C", where C would be 0, and R is a 1234 // symbolic value. 1235 // 1236 // If it was successful, true is returned, and the "R" and "C" is returned 1237 // via "Res" and "ConstOpnd", respectively (If the entire expression is 1238 // evaluated to a constant, the Res is set to NULL); otherwise, false is 1239 // returned, and both "Res" and "ConstOpnd" remain unchanged. 1240 bool ReassociatePass::CombineXorOpnd(Instruction *I, XorOpnd *Opnd1, 1241 XorOpnd *Opnd2, APInt &ConstOpnd, 1242 Value *&Res) { 1243 Value *X = Opnd1->getSymbolicPart(); 1244 if (X != Opnd2->getSymbolicPart()) 1245 return false; 1246 1247 // This many instruction become dead.(At least "Opnd1 ^ Opnd2" will die.) 1248 int DeadInstNum = 1; 1249 if (Opnd1->getValue()->hasOneUse()) 1250 DeadInstNum++; 1251 if (Opnd2->getValue()->hasOneUse()) 1252 DeadInstNum++; 1253 1254 // Xor-Rule 2: 1255 // (x | c1) ^ (x & c2) 1256 // = (x|c1) ^ (x&c2) ^ (c1 ^ c1) = ((x|c1) ^ c1) ^ (x & c2) ^ c1 1257 // = (x & ~c1) ^ (x & c2) ^ c1 // Xor-Rule 1 1258 // = (x & c3) ^ c1, where c3 = ~c1 ^ c2 // Xor-rule 3 1259 // 1260 if (Opnd1->isOrExpr() != Opnd2->isOrExpr()) { 1261 if (Opnd2->isOrExpr()) 1262 std::swap(Opnd1, Opnd2); 1263 1264 const APInt &C1 = Opnd1->getConstPart(); 1265 const APInt &C2 = Opnd2->getConstPart(); 1266 APInt C3((~C1) ^ C2); 1267 1268 // Do not increase code size! 1269 if (!C3.isNullValue() && !C3.isAllOnesValue()) { 1270 int NewInstNum = ConstOpnd.getBoolValue() ? 1 : 2; 1271 if (NewInstNum > DeadInstNum) 1272 return false; 1273 } 1274 1275 Res = createAndInstr(I, X, C3); 1276 ConstOpnd ^= C1; 1277 } else if (Opnd1->isOrExpr()) { 1278 // Xor-Rule 3: (x | c1) ^ (x | c2) = (x & c3) ^ c3 where c3 = c1 ^ c2 1279 // 1280 const APInt &C1 = Opnd1->getConstPart(); 1281 const APInt &C2 = Opnd2->getConstPart(); 1282 APInt C3 = C1 ^ C2; 1283 1284 // Do not increase code size 1285 if (!C3.isNullValue() && !C3.isAllOnesValue()) { 1286 int NewInstNum = ConstOpnd.getBoolValue() ? 1 : 2; 1287 if (NewInstNum > DeadInstNum) 1288 return false; 1289 } 1290 1291 Res = createAndInstr(I, X, C3); 1292 ConstOpnd ^= C3; 1293 } else { 1294 // Xor-Rule 4: (x & c1) ^ (x & c2) = (x & (c1^c2)) 1295 // 1296 const APInt &C1 = Opnd1->getConstPart(); 1297 const APInt &C2 = Opnd2->getConstPart(); 1298 APInt C3 = C1 ^ C2; 1299 Res = createAndInstr(I, X, C3); 1300 } 1301 1302 // Put the original operands in the Redo list; hope they will be deleted 1303 // as dead code. 1304 if (Instruction *T = dyn_cast<Instruction>(Opnd1->getValue())) 1305 RedoInsts.insert(T); 1306 if (Instruction *T = dyn_cast<Instruction>(Opnd2->getValue())) 1307 RedoInsts.insert(T); 1308 1309 return true; 1310 } 1311 1312 /// Optimize a series of operands to an 'xor' instruction. If it can be reduced 1313 /// to a single Value, it is returned, otherwise the Ops list is mutated as 1314 /// necessary. 1315 Value *ReassociatePass::OptimizeXor(Instruction *I, 1316 SmallVectorImpl<ValueEntry> &Ops) { 1317 if (Value *V = OptimizeAndOrXor(Instruction::Xor, Ops)) 1318 return V; 1319 1320 if (Ops.size() == 1) 1321 return nullptr; 1322 1323 SmallVector<XorOpnd, 8> Opnds; 1324 SmallVector<XorOpnd*, 8> OpndPtrs; 1325 Type *Ty = Ops[0].Op->getType(); 1326 APInt ConstOpnd(Ty->getScalarSizeInBits(), 0); 1327 1328 // Step 1: Convert ValueEntry to XorOpnd 1329 for (unsigned i = 0, e = Ops.size(); i != e; ++i) { 1330 Value *V = Ops[i].Op; 1331 const APInt *C; 1332 // TODO: Support non-splat vectors. 1333 if (match(V, m_APInt(C))) { 1334 ConstOpnd ^= *C; 1335 } else { 1336 XorOpnd O(V); 1337 O.setSymbolicRank(getRank(O.getSymbolicPart())); 1338 Opnds.push_back(O); 1339 } 1340 } 1341 1342 // NOTE: From this point on, do *NOT* add/delete element to/from "Opnds". 1343 // It would otherwise invalidate the "Opnds"'s iterator, and hence invalidate 1344 // the "OpndPtrs" as well. For the similar reason, do not fuse this loop 1345 // with the previous loop --- the iterator of the "Opnds" may be invalidated 1346 // when new elements are added to the vector. 1347 for (unsigned i = 0, e = Opnds.size(); i != e; ++i) 1348 OpndPtrs.push_back(&Opnds[i]); 1349 1350 // Step 2: Sort the Xor-Operands in a way such that the operands containing 1351 // the same symbolic value cluster together. For instance, the input operand 1352 // sequence ("x | 123", "y & 456", "x & 789") will be sorted into: 1353 // ("x | 123", "x & 789", "y & 456"). 1354 // 1355 // The purpose is twofold: 1356 // 1) Cluster together the operands sharing the same symbolic-value. 1357 // 2) Operand having smaller symbolic-value-rank is permuted earlier, which 1358 // could potentially shorten crital path, and expose more loop-invariants. 1359 // Note that values' rank are basically defined in RPO order (FIXME). 1360 // So, if Rank(X) < Rank(Y) < Rank(Z), it means X is defined earlier 1361 // than Y which is defined earlier than Z. Permute "x | 1", "Y & 2", 1362 // "z" in the order of X-Y-Z is better than any other orders. 1363 llvm::stable_sort(OpndPtrs, [](XorOpnd *LHS, XorOpnd *RHS) { 1364 return LHS->getSymbolicRank() < RHS->getSymbolicRank(); 1365 }); 1366 1367 // Step 3: Combine adjacent operands 1368 XorOpnd *PrevOpnd = nullptr; 1369 bool Changed = false; 1370 for (unsigned i = 0, e = Opnds.size(); i < e; i++) { 1371 XorOpnd *CurrOpnd = OpndPtrs[i]; 1372 // The combined value 1373 Value *CV; 1374 1375 // Step 3.1: Try simplifying "CurrOpnd ^ ConstOpnd" 1376 if (!ConstOpnd.isNullValue() && 1377 CombineXorOpnd(I, CurrOpnd, ConstOpnd, CV)) { 1378 Changed = true; 1379 if (CV) 1380 *CurrOpnd = XorOpnd(CV); 1381 else { 1382 CurrOpnd->Invalidate(); 1383 continue; 1384 } 1385 } 1386 1387 if (!PrevOpnd || CurrOpnd->getSymbolicPart() != PrevOpnd->getSymbolicPart()) { 1388 PrevOpnd = CurrOpnd; 1389 continue; 1390 } 1391 1392 // step 3.2: When previous and current operands share the same symbolic 1393 // value, try to simplify "PrevOpnd ^ CurrOpnd ^ ConstOpnd" 1394 if (CombineXorOpnd(I, CurrOpnd, PrevOpnd, ConstOpnd, CV)) { 1395 // Remove previous operand 1396 PrevOpnd->Invalidate(); 1397 if (CV) { 1398 *CurrOpnd = XorOpnd(CV); 1399 PrevOpnd = CurrOpnd; 1400 } else { 1401 CurrOpnd->Invalidate(); 1402 PrevOpnd = nullptr; 1403 } 1404 Changed = true; 1405 } 1406 } 1407 1408 // Step 4: Reassemble the Ops 1409 if (Changed) { 1410 Ops.clear(); 1411 for (unsigned int i = 0, e = Opnds.size(); i < e; i++) { 1412 XorOpnd &O = Opnds[i]; 1413 if (O.isInvalid()) 1414 continue; 1415 ValueEntry VE(getRank(O.getValue()), O.getValue()); 1416 Ops.push_back(VE); 1417 } 1418 if (!ConstOpnd.isNullValue()) { 1419 Value *C = ConstantInt::get(Ty, ConstOpnd); 1420 ValueEntry VE(getRank(C), C); 1421 Ops.push_back(VE); 1422 } 1423 unsigned Sz = Ops.size(); 1424 if (Sz == 1) 1425 return Ops.back().Op; 1426 if (Sz == 0) { 1427 assert(ConstOpnd.isNullValue()); 1428 return ConstantInt::get(Ty, ConstOpnd); 1429 } 1430 } 1431 1432 return nullptr; 1433 } 1434 1435 /// Optimize a series of operands to an 'add' instruction. This 1436 /// optimizes based on identities. If it can be reduced to a single Value, it 1437 /// is returned, otherwise the Ops list is mutated as necessary. 1438 Value *ReassociatePass::OptimizeAdd(Instruction *I, 1439 SmallVectorImpl<ValueEntry> &Ops) { 1440 // Scan the operand lists looking for X and -X pairs. If we find any, we 1441 // can simplify expressions like X+-X == 0 and X+~X ==-1. While we're at it, 1442 // scan for any 1443 // duplicates. We want to canonicalize Y+Y+Y+Z -> 3*Y+Z. 1444 1445 for (unsigned i = 0, e = Ops.size(); i != e; ++i) { 1446 Value *TheOp = Ops[i].Op; 1447 // Check to see if we've seen this operand before. If so, we factor all 1448 // instances of the operand together. Due to our sorting criteria, we know 1449 // that these need to be next to each other in the vector. 1450 if (i+1 != Ops.size() && Ops[i+1].Op == TheOp) { 1451 // Rescan the list, remove all instances of this operand from the expr. 1452 unsigned NumFound = 0; 1453 do { 1454 Ops.erase(Ops.begin()+i); 1455 ++NumFound; 1456 } while (i != Ops.size() && Ops[i].Op == TheOp); 1457 1458 LLVM_DEBUG(dbgs() << "\nFACTORING [" << NumFound << "]: " << *TheOp 1459 << '\n'); 1460 ++NumFactor; 1461 1462 // Insert a new multiply. 1463 Type *Ty = TheOp->getType(); 1464 Constant *C = Ty->isIntOrIntVectorTy() ? 1465 ConstantInt::get(Ty, NumFound) : ConstantFP::get(Ty, NumFound); 1466 Instruction *Mul = CreateMul(TheOp, C, "factor", I, I); 1467 1468 // Now that we have inserted a multiply, optimize it. This allows us to 1469 // handle cases that require multiple factoring steps, such as this: 1470 // (X*2) + (X*2) + (X*2) -> (X*2)*3 -> X*6 1471 RedoInsts.insert(Mul); 1472 1473 // If every add operand was a duplicate, return the multiply. 1474 if (Ops.empty()) 1475 return Mul; 1476 1477 // Otherwise, we had some input that didn't have the dupe, such as 1478 // "A + A + B" -> "A*2 + B". Add the new multiply to the list of 1479 // things being added by this operation. 1480 Ops.insert(Ops.begin(), ValueEntry(getRank(Mul), Mul)); 1481 1482 --i; 1483 e = Ops.size(); 1484 continue; 1485 } 1486 1487 // Check for X and -X or X and ~X in the operand list. 1488 Value *X; 1489 if (!match(TheOp, m_Neg(m_Value(X))) && !match(TheOp, m_Not(m_Value(X))) && 1490 !match(TheOp, m_FNeg(m_Value(X)))) 1491 continue; 1492 1493 unsigned FoundX = FindInOperandList(Ops, i, X); 1494 if (FoundX == i) 1495 continue; 1496 1497 // Remove X and -X from the operand list. 1498 if (Ops.size() == 2 && 1499 (match(TheOp, m_Neg(m_Value())) || match(TheOp, m_FNeg(m_Value())))) 1500 return Constant::getNullValue(X->getType()); 1501 1502 // Remove X and ~X from the operand list. 1503 if (Ops.size() == 2 && match(TheOp, m_Not(m_Value()))) 1504 return Constant::getAllOnesValue(X->getType()); 1505 1506 Ops.erase(Ops.begin()+i); 1507 if (i < FoundX) 1508 --FoundX; 1509 else 1510 --i; // Need to back up an extra one. 1511 Ops.erase(Ops.begin()+FoundX); 1512 ++NumAnnihil; 1513 --i; // Revisit element. 1514 e -= 2; // Removed two elements. 1515 1516 // if X and ~X we append -1 to the operand list. 1517 if (match(TheOp, m_Not(m_Value()))) { 1518 Value *V = Constant::getAllOnesValue(X->getType()); 1519 Ops.insert(Ops.end(), ValueEntry(getRank(V), V)); 1520 e += 1; 1521 } 1522 } 1523 1524 // Scan the operand list, checking to see if there are any common factors 1525 // between operands. Consider something like A*A+A*B*C+D. We would like to 1526 // reassociate this to A*(A+B*C)+D, which reduces the number of multiplies. 1527 // To efficiently find this, we count the number of times a factor occurs 1528 // for any ADD operands that are MULs. 1529 DenseMap<Value*, unsigned> FactorOccurrences; 1530 1531 // Keep track of each multiply we see, to avoid triggering on (X*4)+(X*4) 1532 // where they are actually the same multiply. 1533 unsigned MaxOcc = 0; 1534 Value *MaxOccVal = nullptr; 1535 for (unsigned i = 0, e = Ops.size(); i != e; ++i) { 1536 BinaryOperator *BOp = 1537 isReassociableOp(Ops[i].Op, Instruction::Mul, Instruction::FMul); 1538 if (!BOp) 1539 continue; 1540 1541 // Compute all of the factors of this added value. 1542 SmallVector<Value*, 8> Factors; 1543 FindSingleUseMultiplyFactors(BOp, Factors); 1544 assert(Factors.size() > 1 && "Bad linearize!"); 1545 1546 // Add one to FactorOccurrences for each unique factor in this op. 1547 SmallPtrSet<Value*, 8> Duplicates; 1548 for (unsigned i = 0, e = Factors.size(); i != e; ++i) { 1549 Value *Factor = Factors[i]; 1550 if (!Duplicates.insert(Factor).second) 1551 continue; 1552 1553 unsigned Occ = ++FactorOccurrences[Factor]; 1554 if (Occ > MaxOcc) { 1555 MaxOcc = Occ; 1556 MaxOccVal = Factor; 1557 } 1558 1559 // If Factor is a negative constant, add the negated value as a factor 1560 // because we can percolate the negate out. Watch for minint, which 1561 // cannot be positivified. 1562 if (ConstantInt *CI = dyn_cast<ConstantInt>(Factor)) { 1563 if (CI->isNegative() && !CI->isMinValue(true)) { 1564 Factor = ConstantInt::get(CI->getContext(), -CI->getValue()); 1565 if (!Duplicates.insert(Factor).second) 1566 continue; 1567 unsigned Occ = ++FactorOccurrences[Factor]; 1568 if (Occ > MaxOcc) { 1569 MaxOcc = Occ; 1570 MaxOccVal = Factor; 1571 } 1572 } 1573 } else if (ConstantFP *CF = dyn_cast<ConstantFP>(Factor)) { 1574 if (CF->isNegative()) { 1575 APFloat F(CF->getValueAPF()); 1576 F.changeSign(); 1577 Factor = ConstantFP::get(CF->getContext(), F); 1578 if (!Duplicates.insert(Factor).second) 1579 continue; 1580 unsigned Occ = ++FactorOccurrences[Factor]; 1581 if (Occ > MaxOcc) { 1582 MaxOcc = Occ; 1583 MaxOccVal = Factor; 1584 } 1585 } 1586 } 1587 } 1588 } 1589 1590 // If any factor occurred more than one time, we can pull it out. 1591 if (MaxOcc > 1) { 1592 LLVM_DEBUG(dbgs() << "\nFACTORING [" << MaxOcc << "]: " << *MaxOccVal 1593 << '\n'); 1594 ++NumFactor; 1595 1596 // Create a new instruction that uses the MaxOccVal twice. If we don't do 1597 // this, we could otherwise run into situations where removing a factor 1598 // from an expression will drop a use of maxocc, and this can cause 1599 // RemoveFactorFromExpression on successive values to behave differently. 1600 Instruction *DummyInst = 1601 I->getType()->isIntOrIntVectorTy() 1602 ? BinaryOperator::CreateAdd(MaxOccVal, MaxOccVal) 1603 : BinaryOperator::CreateFAdd(MaxOccVal, MaxOccVal); 1604 1605 SmallVector<WeakTrackingVH, 4> NewMulOps; 1606 for (unsigned i = 0; i != Ops.size(); ++i) { 1607 // Only try to remove factors from expressions we're allowed to. 1608 BinaryOperator *BOp = 1609 isReassociableOp(Ops[i].Op, Instruction::Mul, Instruction::FMul); 1610 if (!BOp) 1611 continue; 1612 1613 if (Value *V = RemoveFactorFromExpression(Ops[i].Op, MaxOccVal)) { 1614 // The factorized operand may occur several times. Convert them all in 1615 // one fell swoop. 1616 for (unsigned j = Ops.size(); j != i;) { 1617 --j; 1618 if (Ops[j].Op == Ops[i].Op) { 1619 NewMulOps.push_back(V); 1620 Ops.erase(Ops.begin()+j); 1621 } 1622 } 1623 --i; 1624 } 1625 } 1626 1627 // No need for extra uses anymore. 1628 DummyInst->deleteValue(); 1629 1630 unsigned NumAddedValues = NewMulOps.size(); 1631 Value *V = EmitAddTreeOfValues(I, NewMulOps); 1632 1633 // Now that we have inserted the add tree, optimize it. This allows us to 1634 // handle cases that require multiple factoring steps, such as this: 1635 // A*A*B + A*A*C --> A*(A*B+A*C) --> A*(A*(B+C)) 1636 assert(NumAddedValues > 1 && "Each occurrence should contribute a value"); 1637 (void)NumAddedValues; 1638 if (Instruction *VI = dyn_cast<Instruction>(V)) 1639 RedoInsts.insert(VI); 1640 1641 // Create the multiply. 1642 Instruction *V2 = CreateMul(V, MaxOccVal, "reass.mul", I, I); 1643 1644 // Rerun associate on the multiply in case the inner expression turned into 1645 // a multiply. We want to make sure that we keep things in canonical form. 1646 RedoInsts.insert(V2); 1647 1648 // If every add operand included the factor (e.g. "A*B + A*C"), then the 1649 // entire result expression is just the multiply "A*(B+C)". 1650 if (Ops.empty()) 1651 return V2; 1652 1653 // Otherwise, we had some input that didn't have the factor, such as 1654 // "A*B + A*C + D" -> "A*(B+C) + D". Add the new multiply to the list of 1655 // things being added by this operation. 1656 Ops.insert(Ops.begin(), ValueEntry(getRank(V2), V2)); 1657 } 1658 1659 return nullptr; 1660 } 1661 1662 /// Build up a vector of value/power pairs factoring a product. 1663 /// 1664 /// Given a series of multiplication operands, build a vector of factors and 1665 /// the powers each is raised to when forming the final product. Sort them in 1666 /// the order of descending power. 1667 /// 1668 /// (x*x) -> [(x, 2)] 1669 /// ((x*x)*x) -> [(x, 3)] 1670 /// ((((x*y)*x)*y)*x) -> [(x, 3), (y, 2)] 1671 /// 1672 /// \returns Whether any factors have a power greater than one. 1673 static bool collectMultiplyFactors(SmallVectorImpl<ValueEntry> &Ops, 1674 SmallVectorImpl<Factor> &Factors) { 1675 // FIXME: Have Ops be (ValueEntry, Multiplicity) pairs, simplifying this. 1676 // Compute the sum of powers of simplifiable factors. 1677 unsigned FactorPowerSum = 0; 1678 for (unsigned Idx = 1, Size = Ops.size(); Idx < Size; ++Idx) { 1679 Value *Op = Ops[Idx-1].Op; 1680 1681 // Count the number of occurrences of this value. 1682 unsigned Count = 1; 1683 for (; Idx < Size && Ops[Idx].Op == Op; ++Idx) 1684 ++Count; 1685 // Track for simplification all factors which occur 2 or more times. 1686 if (Count > 1) 1687 FactorPowerSum += Count; 1688 } 1689 1690 // We can only simplify factors if the sum of the powers of our simplifiable 1691 // factors is 4 or higher. When that is the case, we will *always* have 1692 // a simplification. This is an important invariant to prevent cyclicly 1693 // trying to simplify already minimal formations. 1694 if (FactorPowerSum < 4) 1695 return false; 1696 1697 // Now gather the simplifiable factors, removing them from Ops. 1698 FactorPowerSum = 0; 1699 for (unsigned Idx = 1; Idx < Ops.size(); ++Idx) { 1700 Value *Op = Ops[Idx-1].Op; 1701 1702 // Count the number of occurrences of this value. 1703 unsigned Count = 1; 1704 for (; Idx < Ops.size() && Ops[Idx].Op == Op; ++Idx) 1705 ++Count; 1706 if (Count == 1) 1707 continue; 1708 // Move an even number of occurrences to Factors. 1709 Count &= ~1U; 1710 Idx -= Count; 1711 FactorPowerSum += Count; 1712 Factors.push_back(Factor(Op, Count)); 1713 Ops.erase(Ops.begin()+Idx, Ops.begin()+Idx+Count); 1714 } 1715 1716 // None of the adjustments above should have reduced the sum of factor powers 1717 // below our mininum of '4'. 1718 assert(FactorPowerSum >= 4); 1719 1720 llvm::stable_sort(Factors, [](const Factor &LHS, const Factor &RHS) { 1721 return LHS.Power > RHS.Power; 1722 }); 1723 return true; 1724 } 1725 1726 /// Build a tree of multiplies, computing the product of Ops. 1727 static Value *buildMultiplyTree(IRBuilder<> &Builder, 1728 SmallVectorImpl<Value*> &Ops) { 1729 if (Ops.size() == 1) 1730 return Ops.back(); 1731 1732 Value *LHS = Ops.pop_back_val(); 1733 do { 1734 if (LHS->getType()->isIntOrIntVectorTy()) 1735 LHS = Builder.CreateMul(LHS, Ops.pop_back_val()); 1736 else 1737 LHS = Builder.CreateFMul(LHS, Ops.pop_back_val()); 1738 } while (!Ops.empty()); 1739 1740 return LHS; 1741 } 1742 1743 /// Build a minimal multiplication DAG for (a^x)*(b^y)*(c^z)*... 1744 /// 1745 /// Given a vector of values raised to various powers, where no two values are 1746 /// equal and the powers are sorted in decreasing order, compute the minimal 1747 /// DAG of multiplies to compute the final product, and return that product 1748 /// value. 1749 Value * 1750 ReassociatePass::buildMinimalMultiplyDAG(IRBuilder<> &Builder, 1751 SmallVectorImpl<Factor> &Factors) { 1752 assert(Factors[0].Power); 1753 SmallVector<Value *, 4> OuterProduct; 1754 for (unsigned LastIdx = 0, Idx = 1, Size = Factors.size(); 1755 Idx < Size && Factors[Idx].Power > 0; ++Idx) { 1756 if (Factors[Idx].Power != Factors[LastIdx].Power) { 1757 LastIdx = Idx; 1758 continue; 1759 } 1760 1761 // We want to multiply across all the factors with the same power so that 1762 // we can raise them to that power as a single entity. Build a mini tree 1763 // for that. 1764 SmallVector<Value *, 4> InnerProduct; 1765 InnerProduct.push_back(Factors[LastIdx].Base); 1766 do { 1767 InnerProduct.push_back(Factors[Idx].Base); 1768 ++Idx; 1769 } while (Idx < Size && Factors[Idx].Power == Factors[LastIdx].Power); 1770 1771 // Reset the base value of the first factor to the new expression tree. 1772 // We'll remove all the factors with the same power in a second pass. 1773 Value *M = Factors[LastIdx].Base = buildMultiplyTree(Builder, InnerProduct); 1774 if (Instruction *MI = dyn_cast<Instruction>(M)) 1775 RedoInsts.insert(MI); 1776 1777 LastIdx = Idx; 1778 } 1779 // Unique factors with equal powers -- we've folded them into the first one's 1780 // base. 1781 Factors.erase(std::unique(Factors.begin(), Factors.end(), 1782 [](const Factor &LHS, const Factor &RHS) { 1783 return LHS.Power == RHS.Power; 1784 }), 1785 Factors.end()); 1786 1787 // Iteratively collect the base of each factor with an add power into the 1788 // outer product, and halve each power in preparation for squaring the 1789 // expression. 1790 for (unsigned Idx = 0, Size = Factors.size(); Idx != Size; ++Idx) { 1791 if (Factors[Idx].Power & 1) 1792 OuterProduct.push_back(Factors[Idx].Base); 1793 Factors[Idx].Power >>= 1; 1794 } 1795 if (Factors[0].Power) { 1796 Value *SquareRoot = buildMinimalMultiplyDAG(Builder, Factors); 1797 OuterProduct.push_back(SquareRoot); 1798 OuterProduct.push_back(SquareRoot); 1799 } 1800 if (OuterProduct.size() == 1) 1801 return OuterProduct.front(); 1802 1803 Value *V = buildMultiplyTree(Builder, OuterProduct); 1804 return V; 1805 } 1806 1807 Value *ReassociatePass::OptimizeMul(BinaryOperator *I, 1808 SmallVectorImpl<ValueEntry> &Ops) { 1809 // We can only optimize the multiplies when there is a chain of more than 1810 // three, such that a balanced tree might require fewer total multiplies. 1811 if (Ops.size() < 4) 1812 return nullptr; 1813 1814 // Try to turn linear trees of multiplies without other uses of the 1815 // intermediate stages into minimal multiply DAGs with perfect sub-expression 1816 // re-use. 1817 SmallVector<Factor, 4> Factors; 1818 if (!collectMultiplyFactors(Ops, Factors)) 1819 return nullptr; // All distinct factors, so nothing left for us to do. 1820 1821 IRBuilder<> Builder(I); 1822 // The reassociate transformation for FP operations is performed only 1823 // if unsafe algebra is permitted by FastMathFlags. Propagate those flags 1824 // to the newly generated operations. 1825 if (auto FPI = dyn_cast<FPMathOperator>(I)) 1826 Builder.setFastMathFlags(FPI->getFastMathFlags()); 1827 1828 Value *V = buildMinimalMultiplyDAG(Builder, Factors); 1829 if (Ops.empty()) 1830 return V; 1831 1832 ValueEntry NewEntry = ValueEntry(getRank(V), V); 1833 Ops.insert(std::lower_bound(Ops.begin(), Ops.end(), NewEntry), NewEntry); 1834 return nullptr; 1835 } 1836 1837 Value *ReassociatePass::OptimizeExpression(BinaryOperator *I, 1838 SmallVectorImpl<ValueEntry> &Ops) { 1839 // Now that we have the linearized expression tree, try to optimize it. 1840 // Start by folding any constants that we found. 1841 Constant *Cst = nullptr; 1842 unsigned Opcode = I->getOpcode(); 1843 while (!Ops.empty() && isa<Constant>(Ops.back().Op)) { 1844 Constant *C = cast<Constant>(Ops.pop_back_val().Op); 1845 Cst = Cst ? ConstantExpr::get(Opcode, C, Cst) : C; 1846 } 1847 // If there was nothing but constants then we are done. 1848 if (Ops.empty()) 1849 return Cst; 1850 1851 // Put the combined constant back at the end of the operand list, except if 1852 // there is no point. For example, an add of 0 gets dropped here, while a 1853 // multiplication by zero turns the whole expression into zero. 1854 if (Cst && Cst != ConstantExpr::getBinOpIdentity(Opcode, I->getType())) { 1855 if (Cst == ConstantExpr::getBinOpAbsorber(Opcode, I->getType())) 1856 return Cst; 1857 Ops.push_back(ValueEntry(0, Cst)); 1858 } 1859 1860 if (Ops.size() == 1) return Ops[0].Op; 1861 1862 // Handle destructive annihilation due to identities between elements in the 1863 // argument list here. 1864 unsigned NumOps = Ops.size(); 1865 switch (Opcode) { 1866 default: break; 1867 case Instruction::And: 1868 case Instruction::Or: 1869 if (Value *Result = OptimizeAndOrXor(Opcode, Ops)) 1870 return Result; 1871 break; 1872 1873 case Instruction::Xor: 1874 if (Value *Result = OptimizeXor(I, Ops)) 1875 return Result; 1876 break; 1877 1878 case Instruction::Add: 1879 case Instruction::FAdd: 1880 if (Value *Result = OptimizeAdd(I, Ops)) 1881 return Result; 1882 break; 1883 1884 case Instruction::Mul: 1885 case Instruction::FMul: 1886 if (Value *Result = OptimizeMul(I, Ops)) 1887 return Result; 1888 break; 1889 } 1890 1891 if (Ops.size() != NumOps) 1892 return OptimizeExpression(I, Ops); 1893 return nullptr; 1894 } 1895 1896 // Remove dead instructions and if any operands are trivially dead add them to 1897 // Insts so they will be removed as well. 1898 void ReassociatePass::RecursivelyEraseDeadInsts(Instruction *I, 1899 OrderedSet &Insts) { 1900 assert(isInstructionTriviallyDead(I) && "Trivially dead instructions only!"); 1901 SmallVector<Value *, 4> Ops(I->op_begin(), I->op_end()); 1902 ValueRankMap.erase(I); 1903 Insts.remove(I); 1904 RedoInsts.remove(I); 1905 I->eraseFromParent(); 1906 for (auto Op : Ops) 1907 if (Instruction *OpInst = dyn_cast<Instruction>(Op)) 1908 if (OpInst->use_empty()) 1909 Insts.insert(OpInst); 1910 } 1911 1912 /// Zap the given instruction, adding interesting operands to the work list. 1913 void ReassociatePass::EraseInst(Instruction *I) { 1914 assert(isInstructionTriviallyDead(I) && "Trivially dead instructions only!"); 1915 LLVM_DEBUG(dbgs() << "Erasing dead inst: "; I->dump()); 1916 1917 SmallVector<Value*, 8> Ops(I->op_begin(), I->op_end()); 1918 // Erase the dead instruction. 1919 ValueRankMap.erase(I); 1920 RedoInsts.remove(I); 1921 I->eraseFromParent(); 1922 // Optimize its operands. 1923 SmallPtrSet<Instruction *, 8> Visited; // Detect self-referential nodes. 1924 for (unsigned i = 0, e = Ops.size(); i != e; ++i) 1925 if (Instruction *Op = dyn_cast<Instruction>(Ops[i])) { 1926 // If this is a node in an expression tree, climb to the expression root 1927 // and add that since that's where optimization actually happens. 1928 unsigned Opcode = Op->getOpcode(); 1929 while (Op->hasOneUse() && Op->user_back()->getOpcode() == Opcode && 1930 Visited.insert(Op).second) 1931 Op = Op->user_back(); 1932 1933 // The instruction we're going to push may be coming from a 1934 // dead block, and Reassociate skips the processing of unreachable 1935 // blocks because it's a waste of time and also because it can 1936 // lead to infinite loop due to LLVM's non-standard definition 1937 // of dominance. 1938 if (ValueRankMap.find(Op) != ValueRankMap.end()) 1939 RedoInsts.insert(Op); 1940 } 1941 1942 MadeChange = true; 1943 } 1944 1945 // Canonicalize expressions of the following form: 1946 // x + (-Constant * y) -> x - (Constant * y) 1947 // x - (-Constant * y) -> x + (Constant * y) 1948 Instruction *ReassociatePass::canonicalizeNegConstExpr(Instruction *I) { 1949 if (!I->hasOneUse() || I->getType()->isVectorTy()) 1950 return nullptr; 1951 1952 // Must be a fmul or fdiv instruction. 1953 unsigned Opcode = I->getOpcode(); 1954 if (Opcode != Instruction::FMul && Opcode != Instruction::FDiv) 1955 return nullptr; 1956 1957 auto *C0 = dyn_cast<ConstantFP>(I->getOperand(0)); 1958 auto *C1 = dyn_cast<ConstantFP>(I->getOperand(1)); 1959 1960 // Both operands are constant, let it get constant folded away. 1961 if (C0 && C1) 1962 return nullptr; 1963 1964 ConstantFP *CF = C0 ? C0 : C1; 1965 1966 // Must have one constant operand. 1967 if (!CF) 1968 return nullptr; 1969 1970 // Must be a negative ConstantFP. 1971 if (!CF->isNegative()) 1972 return nullptr; 1973 1974 // User must be a binary operator with one or more uses. 1975 Instruction *User = I->user_back(); 1976 if (!isa<BinaryOperator>(User) || User->use_empty()) 1977 return nullptr; 1978 1979 unsigned UserOpcode = User->getOpcode(); 1980 if (UserOpcode != Instruction::FAdd && UserOpcode != Instruction::FSub) 1981 return nullptr; 1982 1983 // Subtraction is not commutative. Explicitly, the following transform is 1984 // not valid: (-Constant * y) - x -> x + (Constant * y) 1985 if (!User->isCommutative() && User->getOperand(1) != I) 1986 return nullptr; 1987 1988 // Don't canonicalize x + (-Constant * y) -> x - (Constant * y), if the 1989 // resulting subtract will be broken up later. This can get us into an 1990 // infinite loop during reassociation. 1991 if (UserOpcode == Instruction::FAdd && ShouldBreakUpSubtract(User)) 1992 return nullptr; 1993 1994 // Change the sign of the constant. 1995 APFloat Val = CF->getValueAPF(); 1996 Val.changeSign(); 1997 I->setOperand(C0 ? 0 : 1, ConstantFP::get(CF->getContext(), Val)); 1998 1999 // Canonicalize I to RHS to simplify the next bit of logic. E.g., 2000 // ((-Const*y) + x) -> (x + (-Const*y)). 2001 if (User->getOperand(0) == I && User->isCommutative()) 2002 cast<BinaryOperator>(User)->swapOperands(); 2003 2004 Value *Op0 = User->getOperand(0); 2005 Value *Op1 = User->getOperand(1); 2006 BinaryOperator *NI; 2007 switch (UserOpcode) { 2008 default: 2009 llvm_unreachable("Unexpected Opcode!"); 2010 case Instruction::FAdd: 2011 NI = BinaryOperator::CreateFSub(Op0, Op1); 2012 NI->setFastMathFlags(cast<FPMathOperator>(User)->getFastMathFlags()); 2013 break; 2014 case Instruction::FSub: 2015 NI = BinaryOperator::CreateFAdd(Op0, Op1); 2016 NI->setFastMathFlags(cast<FPMathOperator>(User)->getFastMathFlags()); 2017 break; 2018 } 2019 2020 NI->insertBefore(User); 2021 NI->setName(User->getName()); 2022 User->replaceAllUsesWith(NI); 2023 NI->setDebugLoc(I->getDebugLoc()); 2024 RedoInsts.insert(I); 2025 MadeChange = true; 2026 return NI; 2027 } 2028 2029 /// Inspect and optimize the given instruction. Note that erasing 2030 /// instructions is not allowed. 2031 void ReassociatePass::OptimizeInst(Instruction *I) { 2032 // Only consider operations that we understand. 2033 if (!isa<UnaryOperator>(I) && !isa<BinaryOperator>(I)) 2034 return; 2035 2036 if (I->getOpcode() == Instruction::Shl && isa<ConstantInt>(I->getOperand(1))) 2037 // If an operand of this shift is a reassociable multiply, or if the shift 2038 // is used by a reassociable multiply or add, turn into a multiply. 2039 if (isReassociableOp(I->getOperand(0), Instruction::Mul) || 2040 (I->hasOneUse() && 2041 (isReassociableOp(I->user_back(), Instruction::Mul) || 2042 isReassociableOp(I->user_back(), Instruction::Add)))) { 2043 Instruction *NI = ConvertShiftToMul(I); 2044 RedoInsts.insert(I); 2045 MadeChange = true; 2046 I = NI; 2047 } 2048 2049 // Canonicalize negative constants out of expressions. 2050 if (Instruction *Res = canonicalizeNegConstExpr(I)) 2051 I = Res; 2052 2053 // Commute binary operators, to canonicalize the order of their operands. 2054 // This can potentially expose more CSE opportunities, and makes writing other 2055 // transformations simpler. 2056 if (I->isCommutative()) 2057 canonicalizeOperands(I); 2058 2059 // Don't optimize floating-point instructions unless they are 'fast'. 2060 if (I->getType()->isFPOrFPVectorTy() && !I->isFast()) 2061 return; 2062 2063 // Do not reassociate boolean (i1) expressions. We want to preserve the 2064 // original order of evaluation for short-circuited comparisons that 2065 // SimplifyCFG has folded to AND/OR expressions. If the expression 2066 // is not further optimized, it is likely to be transformed back to a 2067 // short-circuited form for code gen, and the source order may have been 2068 // optimized for the most likely conditions. 2069 if (I->getType()->isIntegerTy(1)) 2070 return; 2071 2072 // If this is a subtract instruction which is not already in negate form, 2073 // see if we can convert it to X+-Y. 2074 if (I->getOpcode() == Instruction::Sub) { 2075 if (ShouldBreakUpSubtract(I)) { 2076 Instruction *NI = BreakUpSubtract(I, RedoInsts); 2077 RedoInsts.insert(I); 2078 MadeChange = true; 2079 I = NI; 2080 } else if (match(I, m_Neg(m_Value()))) { 2081 // Otherwise, this is a negation. See if the operand is a multiply tree 2082 // and if this is not an inner node of a multiply tree. 2083 if (isReassociableOp(I->getOperand(1), Instruction::Mul) && 2084 (!I->hasOneUse() || 2085 !isReassociableOp(I->user_back(), Instruction::Mul))) { 2086 Instruction *NI = LowerNegateToMultiply(I); 2087 // If the negate was simplified, revisit the users to see if we can 2088 // reassociate further. 2089 for (User *U : NI->users()) { 2090 if (BinaryOperator *Tmp = dyn_cast<BinaryOperator>(U)) 2091 RedoInsts.insert(Tmp); 2092 } 2093 RedoInsts.insert(I); 2094 MadeChange = true; 2095 I = NI; 2096 } 2097 } 2098 } else if (I->getOpcode() == Instruction::FNeg || 2099 I->getOpcode() == Instruction::FSub) { 2100 if (ShouldBreakUpSubtract(I)) { 2101 Instruction *NI = BreakUpSubtract(I, RedoInsts); 2102 RedoInsts.insert(I); 2103 MadeChange = true; 2104 I = NI; 2105 } else if (match(I, m_FNeg(m_Value()))) { 2106 // Otherwise, this is a negation. See if the operand is a multiply tree 2107 // and if this is not an inner node of a multiply tree. 2108 Value *Op = isa<BinaryOperator>(I) ? I->getOperand(1) : 2109 I->getOperand(0); 2110 if (isReassociableOp(Op, Instruction::FMul) && 2111 (!I->hasOneUse() || 2112 !isReassociableOp(I->user_back(), Instruction::FMul))) { 2113 // If the negate was simplified, revisit the users to see if we can 2114 // reassociate further. 2115 Instruction *NI = LowerNegateToMultiply(I); 2116 for (User *U : NI->users()) { 2117 if (BinaryOperator *Tmp = dyn_cast<BinaryOperator>(U)) 2118 RedoInsts.insert(Tmp); 2119 } 2120 RedoInsts.insert(I); 2121 MadeChange = true; 2122 I = NI; 2123 } 2124 } 2125 } 2126 2127 // If this instruction is an associative binary operator, process it. 2128 if (!I->isAssociative()) return; 2129 BinaryOperator *BO = cast<BinaryOperator>(I); 2130 2131 // If this is an interior node of a reassociable tree, ignore it until we 2132 // get to the root of the tree, to avoid N^2 analysis. 2133 unsigned Opcode = BO->getOpcode(); 2134 if (BO->hasOneUse() && BO->user_back()->getOpcode() == Opcode) { 2135 // During the initial run we will get to the root of the tree. 2136 // But if we get here while we are redoing instructions, there is no 2137 // guarantee that the root will be visited. So Redo later 2138 if (BO->user_back() != BO && 2139 BO->getParent() == BO->user_back()->getParent()) 2140 RedoInsts.insert(BO->user_back()); 2141 return; 2142 } 2143 2144 // If this is an add tree that is used by a sub instruction, ignore it 2145 // until we process the subtract. 2146 if (BO->hasOneUse() && BO->getOpcode() == Instruction::Add && 2147 cast<Instruction>(BO->user_back())->getOpcode() == Instruction::Sub) 2148 return; 2149 if (BO->hasOneUse() && BO->getOpcode() == Instruction::FAdd && 2150 cast<Instruction>(BO->user_back())->getOpcode() == Instruction::FSub) 2151 return; 2152 2153 ReassociateExpression(BO); 2154 } 2155 2156 void ReassociatePass::ReassociateExpression(BinaryOperator *I) { 2157 // First, walk the expression tree, linearizing the tree, collecting the 2158 // operand information. 2159 SmallVector<RepeatedValue, 8> Tree; 2160 MadeChange |= LinearizeExprTree(I, Tree); 2161 SmallVector<ValueEntry, 8> Ops; 2162 Ops.reserve(Tree.size()); 2163 for (unsigned i = 0, e = Tree.size(); i != e; ++i) { 2164 RepeatedValue E = Tree[i]; 2165 Ops.append(E.second.getZExtValue(), 2166 ValueEntry(getRank(E.first), E.first)); 2167 } 2168 2169 LLVM_DEBUG(dbgs() << "RAIn:\t"; PrintOps(I, Ops); dbgs() << '\n'); 2170 2171 // Now that we have linearized the tree to a list and have gathered all of 2172 // the operands and their ranks, sort the operands by their rank. Use a 2173 // stable_sort so that values with equal ranks will have their relative 2174 // positions maintained (and so the compiler is deterministic). Note that 2175 // this sorts so that the highest ranking values end up at the beginning of 2176 // the vector. 2177 llvm::stable_sort(Ops); 2178 2179 // Now that we have the expression tree in a convenient 2180 // sorted form, optimize it globally if possible. 2181 if (Value *V = OptimizeExpression(I, Ops)) { 2182 if (V == I) 2183 // Self-referential expression in unreachable code. 2184 return; 2185 // This expression tree simplified to something that isn't a tree, 2186 // eliminate it. 2187 LLVM_DEBUG(dbgs() << "Reassoc to scalar: " << *V << '\n'); 2188 I->replaceAllUsesWith(V); 2189 if (Instruction *VI = dyn_cast<Instruction>(V)) 2190 if (I->getDebugLoc()) 2191 VI->setDebugLoc(I->getDebugLoc()); 2192 RedoInsts.insert(I); 2193 ++NumAnnihil; 2194 return; 2195 } 2196 2197 // We want to sink immediates as deeply as possible except in the case where 2198 // this is a multiply tree used only by an add, and the immediate is a -1. 2199 // In this case we reassociate to put the negation on the outside so that we 2200 // can fold the negation into the add: (-X)*Y + Z -> Z-X*Y 2201 if (I->hasOneUse()) { 2202 if (I->getOpcode() == Instruction::Mul && 2203 cast<Instruction>(I->user_back())->getOpcode() == Instruction::Add && 2204 isa<ConstantInt>(Ops.back().Op) && 2205 cast<ConstantInt>(Ops.back().Op)->isMinusOne()) { 2206 ValueEntry Tmp = Ops.pop_back_val(); 2207 Ops.insert(Ops.begin(), Tmp); 2208 } else if (I->getOpcode() == Instruction::FMul && 2209 cast<Instruction>(I->user_back())->getOpcode() == 2210 Instruction::FAdd && 2211 isa<ConstantFP>(Ops.back().Op) && 2212 cast<ConstantFP>(Ops.back().Op)->isExactlyValue(-1.0)) { 2213 ValueEntry Tmp = Ops.pop_back_val(); 2214 Ops.insert(Ops.begin(), Tmp); 2215 } 2216 } 2217 2218 LLVM_DEBUG(dbgs() << "RAOut:\t"; PrintOps(I, Ops); dbgs() << '\n'); 2219 2220 if (Ops.size() == 1) { 2221 if (Ops[0].Op == I) 2222 // Self-referential expression in unreachable code. 2223 return; 2224 2225 // This expression tree simplified to something that isn't a tree, 2226 // eliminate it. 2227 I->replaceAllUsesWith(Ops[0].Op); 2228 if (Instruction *OI = dyn_cast<Instruction>(Ops[0].Op)) 2229 OI->setDebugLoc(I->getDebugLoc()); 2230 RedoInsts.insert(I); 2231 return; 2232 } 2233 2234 if (Ops.size() > 2 && Ops.size() <= GlobalReassociateLimit) { 2235 // Find the pair with the highest count in the pairmap and move it to the 2236 // back of the list so that it can later be CSE'd. 2237 // example: 2238 // a*b*c*d*e 2239 // if c*e is the most "popular" pair, we can express this as 2240 // (((c*e)*d)*b)*a 2241 unsigned Max = 1; 2242 unsigned BestRank = 0; 2243 std::pair<unsigned, unsigned> BestPair; 2244 unsigned Idx = I->getOpcode() - Instruction::BinaryOpsBegin; 2245 for (unsigned i = 0; i < Ops.size() - 1; ++i) 2246 for (unsigned j = i + 1; j < Ops.size(); ++j) { 2247 unsigned Score = 0; 2248 Value *Op0 = Ops[i].Op; 2249 Value *Op1 = Ops[j].Op; 2250 if (std::less<Value *>()(Op1, Op0)) 2251 std::swap(Op0, Op1); 2252 auto it = PairMap[Idx].find({Op0, Op1}); 2253 if (it != PairMap[Idx].end()) { 2254 // Functions like BreakUpSubtract() can erase the Values we're using 2255 // as keys and create new Values after we built the PairMap. There's a 2256 // small chance that the new nodes can have the same address as 2257 // something already in the table. We shouldn't accumulate the stored 2258 // score in that case as it refers to the wrong Value. 2259 if (it->second.isValid()) 2260 Score += it->second.Score; 2261 } 2262 2263 unsigned MaxRank = std::max(Ops[i].Rank, Ops[j].Rank); 2264 if (Score > Max || (Score == Max && MaxRank < BestRank)) { 2265 BestPair = {i, j}; 2266 Max = Score; 2267 BestRank = MaxRank; 2268 } 2269 } 2270 if (Max > 1) { 2271 auto Op0 = Ops[BestPair.first]; 2272 auto Op1 = Ops[BestPair.second]; 2273 Ops.erase(&Ops[BestPair.second]); 2274 Ops.erase(&Ops[BestPair.first]); 2275 Ops.push_back(Op0); 2276 Ops.push_back(Op1); 2277 } 2278 } 2279 // Now that we ordered and optimized the expressions, splat them back into 2280 // the expression tree, removing any unneeded nodes. 2281 RewriteExprTree(I, Ops); 2282 } 2283 2284 void 2285 ReassociatePass::BuildPairMap(ReversePostOrderTraversal<Function *> &RPOT) { 2286 // Make a "pairmap" of how often each operand pair occurs. 2287 for (BasicBlock *BI : RPOT) { 2288 for (Instruction &I : *BI) { 2289 if (!I.isAssociative()) 2290 continue; 2291 2292 // Ignore nodes that aren't at the root of trees. 2293 if (I.hasOneUse() && I.user_back()->getOpcode() == I.getOpcode()) 2294 continue; 2295 2296 // Collect all operands in a single reassociable expression. 2297 // Since Reassociate has already been run once, we can assume things 2298 // are already canonical according to Reassociation's regime. 2299 SmallVector<Value *, 8> Worklist = { I.getOperand(0), I.getOperand(1) }; 2300 SmallVector<Value *, 8> Ops; 2301 while (!Worklist.empty() && Ops.size() <= GlobalReassociateLimit) { 2302 Value *Op = Worklist.pop_back_val(); 2303 Instruction *OpI = dyn_cast<Instruction>(Op); 2304 if (!OpI || OpI->getOpcode() != I.getOpcode() || !OpI->hasOneUse()) { 2305 Ops.push_back(Op); 2306 continue; 2307 } 2308 // Be paranoid about self-referencing expressions in unreachable code. 2309 if (OpI->getOperand(0) != OpI) 2310 Worklist.push_back(OpI->getOperand(0)); 2311 if (OpI->getOperand(1) != OpI) 2312 Worklist.push_back(OpI->getOperand(1)); 2313 } 2314 // Skip extremely long expressions. 2315 if (Ops.size() > GlobalReassociateLimit) 2316 continue; 2317 2318 // Add all pairwise combinations of operands to the pair map. 2319 unsigned BinaryIdx = I.getOpcode() - Instruction::BinaryOpsBegin; 2320 SmallSet<std::pair<Value *, Value*>, 32> Visited; 2321 for (unsigned i = 0; i < Ops.size() - 1; ++i) { 2322 for (unsigned j = i + 1; j < Ops.size(); ++j) { 2323 // Canonicalize operand orderings. 2324 Value *Op0 = Ops[i]; 2325 Value *Op1 = Ops[j]; 2326 if (std::less<Value *>()(Op1, Op0)) 2327 std::swap(Op0, Op1); 2328 if (!Visited.insert({Op0, Op1}).second) 2329 continue; 2330 auto res = PairMap[BinaryIdx].insert({{Op0, Op1}, {Op0, Op1, 1}}); 2331 if (!res.second) { 2332 // If either key value has been erased then we've got the same 2333 // address by coincidence. That can't happen here because nothing is 2334 // erasing values but it can happen by the time we're querying the 2335 // map. 2336 assert(res.first->second.isValid() && "WeakVH invalidated"); 2337 ++res.first->second.Score; 2338 } 2339 } 2340 } 2341 } 2342 } 2343 } 2344 2345 PreservedAnalyses ReassociatePass::run(Function &F, FunctionAnalysisManager &) { 2346 // Get the functions basic blocks in Reverse Post Order. This order is used by 2347 // BuildRankMap to pre calculate ranks correctly. It also excludes dead basic 2348 // blocks (it has been seen that the analysis in this pass could hang when 2349 // analysing dead basic blocks). 2350 ReversePostOrderTraversal<Function *> RPOT(&F); 2351 2352 // Calculate the rank map for F. 2353 BuildRankMap(F, RPOT); 2354 2355 // Build the pair map before running reassociate. 2356 // Technically this would be more accurate if we did it after one round 2357 // of reassociation, but in practice it doesn't seem to help much on 2358 // real-world code, so don't waste the compile time running reassociate 2359 // twice. 2360 // If a user wants, they could expicitly run reassociate twice in their 2361 // pass pipeline for further potential gains. 2362 // It might also be possible to update the pair map during runtime, but the 2363 // overhead of that may be large if there's many reassociable chains. 2364 BuildPairMap(RPOT); 2365 2366 MadeChange = false; 2367 2368 // Traverse the same blocks that were analysed by BuildRankMap. 2369 for (BasicBlock *BI : RPOT) { 2370 assert(RankMap.count(&*BI) && "BB should be ranked."); 2371 // Optimize every instruction in the basic block. 2372 for (BasicBlock::iterator II = BI->begin(), IE = BI->end(); II != IE;) 2373 if (isInstructionTriviallyDead(&*II)) { 2374 EraseInst(&*II++); 2375 } else { 2376 OptimizeInst(&*II); 2377 assert(II->getParent() == &*BI && "Moved to a different block!"); 2378 ++II; 2379 } 2380 2381 // Make a copy of all the instructions to be redone so we can remove dead 2382 // instructions. 2383 OrderedSet ToRedo(RedoInsts); 2384 // Iterate over all instructions to be reevaluated and remove trivially dead 2385 // instructions. If any operand of the trivially dead instruction becomes 2386 // dead mark it for deletion as well. Continue this process until all 2387 // trivially dead instructions have been removed. 2388 while (!ToRedo.empty()) { 2389 Instruction *I = ToRedo.pop_back_val(); 2390 if (isInstructionTriviallyDead(I)) { 2391 RecursivelyEraseDeadInsts(I, ToRedo); 2392 MadeChange = true; 2393 } 2394 } 2395 2396 // Now that we have removed dead instructions, we can reoptimize the 2397 // remaining instructions. 2398 while (!RedoInsts.empty()) { 2399 Instruction *I = RedoInsts.front(); 2400 RedoInsts.erase(RedoInsts.begin()); 2401 if (isInstructionTriviallyDead(I)) 2402 EraseInst(I); 2403 else 2404 OptimizeInst(I); 2405 } 2406 } 2407 2408 // We are done with the rank map and pair map. 2409 RankMap.clear(); 2410 ValueRankMap.clear(); 2411 for (auto &Entry : PairMap) 2412 Entry.clear(); 2413 2414 if (MadeChange) { 2415 PreservedAnalyses PA; 2416 PA.preserveSet<CFGAnalyses>(); 2417 PA.preserve<GlobalsAA>(); 2418 return PA; 2419 } 2420 2421 return PreservedAnalyses::all(); 2422 } 2423 2424 namespace { 2425 2426 class ReassociateLegacyPass : public FunctionPass { 2427 ReassociatePass Impl; 2428 2429 public: 2430 static char ID; // Pass identification, replacement for typeid 2431 2432 ReassociateLegacyPass() : FunctionPass(ID) { 2433 initializeReassociateLegacyPassPass(*PassRegistry::getPassRegistry()); 2434 } 2435 2436 bool runOnFunction(Function &F) override { 2437 if (skipFunction(F)) 2438 return false; 2439 2440 FunctionAnalysisManager DummyFAM; 2441 auto PA = Impl.run(F, DummyFAM); 2442 return !PA.areAllPreserved(); 2443 } 2444 2445 void getAnalysisUsage(AnalysisUsage &AU) const override { 2446 AU.setPreservesCFG(); 2447 AU.addPreserved<GlobalsAAWrapperPass>(); 2448 } 2449 }; 2450 2451 } // end anonymous namespace 2452 2453 char ReassociateLegacyPass::ID = 0; 2454 2455 INITIALIZE_PASS(ReassociateLegacyPass, "reassociate", 2456 "Reassociate expressions", false, false) 2457 2458 // Public interface to the Reassociate pass 2459 FunctionPass *llvm::createReassociatePass() { 2460 return new ReassociateLegacyPass(); 2461 } 2462