1 //===- InstCombineShifts.cpp ----------------------------------------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // This file implements the visitShl, visitLShr, and visitAShr functions. 10 // 11 //===----------------------------------------------------------------------===// 12 13 #include "InstCombineInternal.h" 14 #include "llvm/Analysis/InstructionSimplify.h" 15 #include "llvm/IR/IntrinsicInst.h" 16 #include "llvm/IR/PatternMatch.h" 17 #include "llvm/Transforms/InstCombine/InstCombiner.h" 18 using namespace llvm; 19 using namespace PatternMatch; 20 21 #define DEBUG_TYPE "instcombine" 22 23 bool canTryToConstantAddTwoShiftAmounts(Value *Sh0, Value *ShAmt0, Value *Sh1, 24 Value *ShAmt1) { 25 // We have two shift amounts from two different shifts. The types of those 26 // shift amounts may not match. If that's the case let's bailout now.. 27 if (ShAmt0->getType() != ShAmt1->getType()) 28 return false; 29 30 // As input, we have the following pattern: 31 // Sh0 (Sh1 X, Q), K 32 // We want to rewrite that as: 33 // Sh x, (Q+K) iff (Q+K) u< bitwidth(x) 34 // While we know that originally (Q+K) would not overflow 35 // (because 2 * (N-1) u<= iN -1), we have looked past extensions of 36 // shift amounts. so it may now overflow in smaller bitwidth. 37 // To ensure that does not happen, we need to ensure that the total maximal 38 // shift amount is still representable in that smaller bit width. 39 unsigned MaximalPossibleTotalShiftAmount = 40 (Sh0->getType()->getScalarSizeInBits() - 1) + 41 (Sh1->getType()->getScalarSizeInBits() - 1); 42 APInt MaximalRepresentableShiftAmount = 43 APInt::getAllOnes(ShAmt0->getType()->getScalarSizeInBits()); 44 return MaximalRepresentableShiftAmount.uge(MaximalPossibleTotalShiftAmount); 45 } 46 47 // Given pattern: 48 // (x shiftopcode Q) shiftopcode K 49 // we should rewrite it as 50 // x shiftopcode (Q+K) iff (Q+K) u< bitwidth(x) and 51 // 52 // This is valid for any shift, but they must be identical, and we must be 53 // careful in case we have (zext(Q)+zext(K)) and look past extensions, 54 // (Q+K) must not overflow or else (Q+K) u< bitwidth(x) is bogus. 55 // 56 // AnalyzeForSignBitExtraction indicates that we will only analyze whether this 57 // pattern has any 2 right-shifts that sum to 1 less than original bit width. 58 Value *InstCombinerImpl::reassociateShiftAmtsOfTwoSameDirectionShifts( 59 BinaryOperator *Sh0, const SimplifyQuery &SQ, 60 bool AnalyzeForSignBitExtraction) { 61 // Look for a shift of some instruction, ignore zext of shift amount if any. 62 Instruction *Sh0Op0; 63 Value *ShAmt0; 64 if (!match(Sh0, 65 m_Shift(m_Instruction(Sh0Op0), m_ZExtOrSelf(m_Value(ShAmt0))))) 66 return nullptr; 67 68 // If there is a truncation between the two shifts, we must make note of it 69 // and look through it. The truncation imposes additional constraints on the 70 // transform. 71 Instruction *Sh1; 72 Value *Trunc = nullptr; 73 match(Sh0Op0, 74 m_CombineOr(m_CombineAnd(m_Trunc(m_Instruction(Sh1)), m_Value(Trunc)), 75 m_Instruction(Sh1))); 76 77 // Inner shift: (x shiftopcode ShAmt1) 78 // Like with other shift, ignore zext of shift amount if any. 79 Value *X, *ShAmt1; 80 if (!match(Sh1, m_Shift(m_Value(X), m_ZExtOrSelf(m_Value(ShAmt1))))) 81 return nullptr; 82 83 // Verify that it would be safe to try to add those two shift amounts. 84 if (!canTryToConstantAddTwoShiftAmounts(Sh0, ShAmt0, Sh1, ShAmt1)) 85 return nullptr; 86 87 // We are only looking for signbit extraction if we have two right shifts. 88 bool HadTwoRightShifts = match(Sh0, m_Shr(m_Value(), m_Value())) && 89 match(Sh1, m_Shr(m_Value(), m_Value())); 90 // ... and if it's not two right-shifts, we know the answer already. 91 if (AnalyzeForSignBitExtraction && !HadTwoRightShifts) 92 return nullptr; 93 94 // The shift opcodes must be identical, unless we are just checking whether 95 // this pattern can be interpreted as a sign-bit-extraction. 96 Instruction::BinaryOps ShiftOpcode = Sh0->getOpcode(); 97 bool IdenticalShOpcodes = Sh0->getOpcode() == Sh1->getOpcode(); 98 if (!IdenticalShOpcodes && !AnalyzeForSignBitExtraction) 99 return nullptr; 100 101 // If we saw truncation, we'll need to produce extra instruction, 102 // and for that one of the operands of the shift must be one-use, 103 // unless of course we don't actually plan to produce any instructions here. 104 if (Trunc && !AnalyzeForSignBitExtraction && 105 !match(Sh0, m_c_BinOp(m_OneUse(m_Value()), m_Value()))) 106 return nullptr; 107 108 // Can we fold (ShAmt0+ShAmt1) ? 109 auto *NewShAmt = dyn_cast_or_null<Constant>( 110 SimplifyAddInst(ShAmt0, ShAmt1, /*isNSW=*/false, /*isNUW=*/false, 111 SQ.getWithInstruction(Sh0))); 112 if (!NewShAmt) 113 return nullptr; // Did not simplify. 114 unsigned NewShAmtBitWidth = NewShAmt->getType()->getScalarSizeInBits(); 115 unsigned XBitWidth = X->getType()->getScalarSizeInBits(); 116 // Is the new shift amount smaller than the bit width of inner/new shift? 117 if (!match(NewShAmt, m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_ULT, 118 APInt(NewShAmtBitWidth, XBitWidth)))) 119 return nullptr; // FIXME: could perform constant-folding. 120 121 // If there was a truncation, and we have a right-shift, we can only fold if 122 // we are left with the original sign bit. Likewise, if we were just checking 123 // that this is a sighbit extraction, this is the place to check it. 124 // FIXME: zero shift amount is also legal here, but we can't *easily* check 125 // more than one predicate so it's not really worth it. 126 if (HadTwoRightShifts && (Trunc || AnalyzeForSignBitExtraction)) { 127 // If it's not a sign bit extraction, then we're done. 128 if (!match(NewShAmt, 129 m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_EQ, 130 APInt(NewShAmtBitWidth, XBitWidth - 1)))) 131 return nullptr; 132 // If it is, and that was the question, return the base value. 133 if (AnalyzeForSignBitExtraction) 134 return X; 135 } 136 137 assert(IdenticalShOpcodes && "Should not get here with different shifts."); 138 139 // All good, we can do this fold. 140 NewShAmt = ConstantExpr::getZExtOrBitCast(NewShAmt, X->getType()); 141 142 BinaryOperator *NewShift = BinaryOperator::Create(ShiftOpcode, X, NewShAmt); 143 144 // The flags can only be propagated if there wasn't a trunc. 145 if (!Trunc) { 146 // If the pattern did not involve trunc, and both of the original shifts 147 // had the same flag set, preserve the flag. 148 if (ShiftOpcode == Instruction::BinaryOps::Shl) { 149 NewShift->setHasNoUnsignedWrap(Sh0->hasNoUnsignedWrap() && 150 Sh1->hasNoUnsignedWrap()); 151 NewShift->setHasNoSignedWrap(Sh0->hasNoSignedWrap() && 152 Sh1->hasNoSignedWrap()); 153 } else { 154 NewShift->setIsExact(Sh0->isExact() && Sh1->isExact()); 155 } 156 } 157 158 Instruction *Ret = NewShift; 159 if (Trunc) { 160 Builder.Insert(NewShift); 161 Ret = CastInst::Create(Instruction::Trunc, NewShift, Sh0->getType()); 162 } 163 164 return Ret; 165 } 166 167 // If we have some pattern that leaves only some low bits set, and then performs 168 // left-shift of those bits, if none of the bits that are left after the final 169 // shift are modified by the mask, we can omit the mask. 170 // 171 // There are many variants to this pattern: 172 // a) (x & ((1 << MaskShAmt) - 1)) << ShiftShAmt 173 // b) (x & (~(-1 << MaskShAmt))) << ShiftShAmt 174 // c) (x & (-1 l>> MaskShAmt)) << ShiftShAmt 175 // d) (x & ((-1 << MaskShAmt) l>> MaskShAmt)) << ShiftShAmt 176 // e) ((x << MaskShAmt) l>> MaskShAmt) << ShiftShAmt 177 // f) ((x << MaskShAmt) a>> MaskShAmt) << ShiftShAmt 178 // All these patterns can be simplified to just: 179 // x << ShiftShAmt 180 // iff: 181 // a,b) (MaskShAmt+ShiftShAmt) u>= bitwidth(x) 182 // c,d,e,f) (ShiftShAmt-MaskShAmt) s>= 0 (i.e. ShiftShAmt u>= MaskShAmt) 183 static Instruction * 184 dropRedundantMaskingOfLeftShiftInput(BinaryOperator *OuterShift, 185 const SimplifyQuery &Q, 186 InstCombiner::BuilderTy &Builder) { 187 assert(OuterShift->getOpcode() == Instruction::BinaryOps::Shl && 188 "The input must be 'shl'!"); 189 190 Value *Masked, *ShiftShAmt; 191 match(OuterShift, 192 m_Shift(m_Value(Masked), m_ZExtOrSelf(m_Value(ShiftShAmt)))); 193 194 // *If* there is a truncation between an outer shift and a possibly-mask, 195 // then said truncation *must* be one-use, else we can't perform the fold. 196 Value *Trunc; 197 if (match(Masked, m_CombineAnd(m_Trunc(m_Value(Masked)), m_Value(Trunc))) && 198 !Trunc->hasOneUse()) 199 return nullptr; 200 201 Type *NarrowestTy = OuterShift->getType(); 202 Type *WidestTy = Masked->getType(); 203 bool HadTrunc = WidestTy != NarrowestTy; 204 205 // The mask must be computed in a type twice as wide to ensure 206 // that no bits are lost if the sum-of-shifts is wider than the base type. 207 Type *ExtendedTy = WidestTy->getExtendedType(); 208 209 Value *MaskShAmt; 210 211 // ((1 << MaskShAmt) - 1) 212 auto MaskA = m_Add(m_Shl(m_One(), m_Value(MaskShAmt)), m_AllOnes()); 213 // (~(-1 << maskNbits)) 214 auto MaskB = m_Xor(m_Shl(m_AllOnes(), m_Value(MaskShAmt)), m_AllOnes()); 215 // (-1 l>> MaskShAmt) 216 auto MaskC = m_LShr(m_AllOnes(), m_Value(MaskShAmt)); 217 // ((-1 << MaskShAmt) l>> MaskShAmt) 218 auto MaskD = 219 m_LShr(m_Shl(m_AllOnes(), m_Value(MaskShAmt)), m_Deferred(MaskShAmt)); 220 221 Value *X; 222 Constant *NewMask; 223 224 if (match(Masked, m_c_And(m_CombineOr(MaskA, MaskB), m_Value(X)))) { 225 // Peek through an optional zext of the shift amount. 226 match(MaskShAmt, m_ZExtOrSelf(m_Value(MaskShAmt))); 227 228 // Verify that it would be safe to try to add those two shift amounts. 229 if (!canTryToConstantAddTwoShiftAmounts(OuterShift, ShiftShAmt, Masked, 230 MaskShAmt)) 231 return nullptr; 232 233 // Can we simplify (MaskShAmt+ShiftShAmt) ? 234 auto *SumOfShAmts = dyn_cast_or_null<Constant>(SimplifyAddInst( 235 MaskShAmt, ShiftShAmt, /*IsNSW=*/false, /*IsNUW=*/false, Q)); 236 if (!SumOfShAmts) 237 return nullptr; // Did not simplify. 238 // In this pattern SumOfShAmts correlates with the number of low bits 239 // that shall remain in the root value (OuterShift). 240 241 // An extend of an undef value becomes zero because the high bits are never 242 // completely unknown. Replace the `undef` shift amounts with final 243 // shift bitwidth to ensure that the value remains undef when creating the 244 // subsequent shift op. 245 SumOfShAmts = Constant::replaceUndefsWith( 246 SumOfShAmts, ConstantInt::get(SumOfShAmts->getType()->getScalarType(), 247 ExtendedTy->getScalarSizeInBits())); 248 auto *ExtendedSumOfShAmts = ConstantExpr::getZExt(SumOfShAmts, ExtendedTy); 249 // And compute the mask as usual: ~(-1 << (SumOfShAmts)) 250 auto *ExtendedAllOnes = ConstantExpr::getAllOnesValue(ExtendedTy); 251 auto *ExtendedInvertedMask = 252 ConstantExpr::getShl(ExtendedAllOnes, ExtendedSumOfShAmts); 253 NewMask = ConstantExpr::getNot(ExtendedInvertedMask); 254 } else if (match(Masked, m_c_And(m_CombineOr(MaskC, MaskD), m_Value(X))) || 255 match(Masked, m_Shr(m_Shl(m_Value(X), m_Value(MaskShAmt)), 256 m_Deferred(MaskShAmt)))) { 257 // Peek through an optional zext of the shift amount. 258 match(MaskShAmt, m_ZExtOrSelf(m_Value(MaskShAmt))); 259 260 // Verify that it would be safe to try to add those two shift amounts. 261 if (!canTryToConstantAddTwoShiftAmounts(OuterShift, ShiftShAmt, Masked, 262 MaskShAmt)) 263 return nullptr; 264 265 // Can we simplify (ShiftShAmt-MaskShAmt) ? 266 auto *ShAmtsDiff = dyn_cast_or_null<Constant>(SimplifySubInst( 267 ShiftShAmt, MaskShAmt, /*IsNSW=*/false, /*IsNUW=*/false, Q)); 268 if (!ShAmtsDiff) 269 return nullptr; // Did not simplify. 270 // In this pattern ShAmtsDiff correlates with the number of high bits that 271 // shall be unset in the root value (OuterShift). 272 273 // An extend of an undef value becomes zero because the high bits are never 274 // completely unknown. Replace the `undef` shift amounts with negated 275 // bitwidth of innermost shift to ensure that the value remains undef when 276 // creating the subsequent shift op. 277 unsigned WidestTyBitWidth = WidestTy->getScalarSizeInBits(); 278 ShAmtsDiff = Constant::replaceUndefsWith( 279 ShAmtsDiff, ConstantInt::get(ShAmtsDiff->getType()->getScalarType(), 280 -WidestTyBitWidth)); 281 auto *ExtendedNumHighBitsToClear = ConstantExpr::getZExt( 282 ConstantExpr::getSub(ConstantInt::get(ShAmtsDiff->getType(), 283 WidestTyBitWidth, 284 /*isSigned=*/false), 285 ShAmtsDiff), 286 ExtendedTy); 287 // And compute the mask as usual: (-1 l>> (NumHighBitsToClear)) 288 auto *ExtendedAllOnes = ConstantExpr::getAllOnesValue(ExtendedTy); 289 NewMask = 290 ConstantExpr::getLShr(ExtendedAllOnes, ExtendedNumHighBitsToClear); 291 } else 292 return nullptr; // Don't know anything about this pattern. 293 294 NewMask = ConstantExpr::getTrunc(NewMask, NarrowestTy); 295 296 // Does this mask has any unset bits? If not then we can just not apply it. 297 bool NeedMask = !match(NewMask, m_AllOnes()); 298 299 // If we need to apply a mask, there are several more restrictions we have. 300 if (NeedMask) { 301 // The old masking instruction must go away. 302 if (!Masked->hasOneUse()) 303 return nullptr; 304 // The original "masking" instruction must not have been`ashr`. 305 if (match(Masked, m_AShr(m_Value(), m_Value()))) 306 return nullptr; 307 } 308 309 // If we need to apply truncation, let's do it first, since we can. 310 // We have already ensured that the old truncation will go away. 311 if (HadTrunc) 312 X = Builder.CreateTrunc(X, NarrowestTy); 313 314 // No 'NUW'/'NSW'! We no longer know that we won't shift-out non-0 bits. 315 // We didn't change the Type of this outermost shift, so we can just do it. 316 auto *NewShift = BinaryOperator::Create(OuterShift->getOpcode(), X, 317 OuterShift->getOperand(1)); 318 if (!NeedMask) 319 return NewShift; 320 321 Builder.Insert(NewShift); 322 return BinaryOperator::Create(Instruction::And, NewShift, NewMask); 323 } 324 325 /// If we have a shift-by-constant of a bitwise logic op that itself has a 326 /// shift-by-constant operand with identical opcode, we may be able to convert 327 /// that into 2 independent shifts followed by the logic op. This eliminates a 328 /// a use of an intermediate value (reduces dependency chain). 329 static Instruction *foldShiftOfShiftedLogic(BinaryOperator &I, 330 InstCombiner::BuilderTy &Builder) { 331 assert(I.isShift() && "Expected a shift as input"); 332 auto *LogicInst = dyn_cast<BinaryOperator>(I.getOperand(0)); 333 if (!LogicInst || !LogicInst->isBitwiseLogicOp() || !LogicInst->hasOneUse()) 334 return nullptr; 335 336 Constant *C0, *C1; 337 if (!match(I.getOperand(1), m_Constant(C1))) 338 return nullptr; 339 340 Instruction::BinaryOps ShiftOpcode = I.getOpcode(); 341 Type *Ty = I.getType(); 342 343 // Find a matching one-use shift by constant. The fold is not valid if the sum 344 // of the shift values equals or exceeds bitwidth. 345 // TODO: Remove the one-use check if the other logic operand (Y) is constant. 346 Value *X, *Y; 347 auto matchFirstShift = [&](Value *V) { 348 APInt Threshold(Ty->getScalarSizeInBits(), Ty->getScalarSizeInBits()); 349 return match(V, m_BinOp(ShiftOpcode, m_Value(), m_Value())) && 350 match(V, m_OneUse(m_Shift(m_Value(X), m_Constant(C0)))) && 351 match(ConstantExpr::getAdd(C0, C1), 352 m_SpecificInt_ICMP(ICmpInst::ICMP_ULT, Threshold)); 353 }; 354 355 // Logic ops are commutative, so check each operand for a match. 356 if (matchFirstShift(LogicInst->getOperand(0))) 357 Y = LogicInst->getOperand(1); 358 else if (matchFirstShift(LogicInst->getOperand(1))) 359 Y = LogicInst->getOperand(0); 360 else 361 return nullptr; 362 363 // shift (logic (shift X, C0), Y), C1 -> logic (shift X, C0+C1), (shift Y, C1) 364 Constant *ShiftSumC = ConstantExpr::getAdd(C0, C1); 365 Value *NewShift1 = Builder.CreateBinOp(ShiftOpcode, X, ShiftSumC); 366 Value *NewShift2 = Builder.CreateBinOp(ShiftOpcode, Y, I.getOperand(1)); 367 return BinaryOperator::Create(LogicInst->getOpcode(), NewShift1, NewShift2); 368 } 369 370 Instruction *InstCombinerImpl::commonShiftTransforms(BinaryOperator &I) { 371 if (Instruction *Phi = foldBinopWithPhiOperands(I)) 372 return Phi; 373 374 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 375 assert(Op0->getType() == Op1->getType()); 376 377 // If the shift amount is a one-use `sext`, we can demote it to `zext`. 378 Value *Y; 379 if (match(Op1, m_OneUse(m_SExt(m_Value(Y))))) { 380 Value *NewExt = Builder.CreateZExt(Y, I.getType(), Op1->getName()); 381 return BinaryOperator::Create(I.getOpcode(), Op0, NewExt); 382 } 383 384 // See if we can fold away this shift. 385 if (SimplifyDemandedInstructionBits(I)) 386 return &I; 387 388 // Try to fold constant and into select arguments. 389 if (isa<Constant>(Op0)) 390 if (SelectInst *SI = dyn_cast<SelectInst>(Op1)) 391 if (Instruction *R = FoldOpIntoSelect(I, SI)) 392 return R; 393 394 if (Constant *CUI = dyn_cast<Constant>(Op1)) 395 if (Instruction *Res = FoldShiftByConstant(Op0, CUI, I)) 396 return Res; 397 398 if (auto *NewShift = cast_or_null<Instruction>( 399 reassociateShiftAmtsOfTwoSameDirectionShifts(&I, SQ))) 400 return NewShift; 401 402 // (C1 shift (A add C2)) -> (C1 shift C2) shift A) 403 // iff A and C2 are both positive. 404 Value *A; 405 Constant *C; 406 if (match(Op0, m_Constant()) && match(Op1, m_Add(m_Value(A), m_Constant(C)))) 407 if (isKnownNonNegative(A, DL, 0, &AC, &I, &DT) && 408 isKnownNonNegative(C, DL, 0, &AC, &I, &DT)) 409 return BinaryOperator::Create( 410 I.getOpcode(), Builder.CreateBinOp(I.getOpcode(), Op0, C), A); 411 412 // X shift (A srem C) -> X shift (A and (C - 1)) iff C is a power of 2. 413 // Because shifts by negative values (which could occur if A were negative) 414 // are undefined. 415 if (Op1->hasOneUse() && match(Op1, m_SRem(m_Value(A), m_Constant(C))) && 416 match(C, m_Power2())) { 417 // FIXME: Should this get moved into SimplifyDemandedBits by saying we don't 418 // demand the sign bit (and many others) here?? 419 Constant *Mask = ConstantExpr::getSub(C, ConstantInt::get(I.getType(), 1)); 420 Value *Rem = Builder.CreateAnd(A, Mask, Op1->getName()); 421 return replaceOperand(I, 1, Rem); 422 } 423 424 if (Instruction *Logic = foldShiftOfShiftedLogic(I, Builder)) 425 return Logic; 426 427 return nullptr; 428 } 429 430 /// Return true if we can simplify two logical (either left or right) shifts 431 /// that have constant shift amounts: OuterShift (InnerShift X, C1), C2. 432 static bool canEvaluateShiftedShift(unsigned OuterShAmt, bool IsOuterShl, 433 Instruction *InnerShift, 434 InstCombinerImpl &IC, Instruction *CxtI) { 435 assert(InnerShift->isLogicalShift() && "Unexpected instruction type"); 436 437 // We need constant scalar or constant splat shifts. 438 const APInt *InnerShiftConst; 439 if (!match(InnerShift->getOperand(1), m_APInt(InnerShiftConst))) 440 return false; 441 442 // Two logical shifts in the same direction: 443 // shl (shl X, C1), C2 --> shl X, C1 + C2 444 // lshr (lshr X, C1), C2 --> lshr X, C1 + C2 445 bool IsInnerShl = InnerShift->getOpcode() == Instruction::Shl; 446 if (IsInnerShl == IsOuterShl) 447 return true; 448 449 // Equal shift amounts in opposite directions become bitwise 'and': 450 // lshr (shl X, C), C --> and X, C' 451 // shl (lshr X, C), C --> and X, C' 452 if (*InnerShiftConst == OuterShAmt) 453 return true; 454 455 // If the 2nd shift is bigger than the 1st, we can fold: 456 // lshr (shl X, C1), C2 --> and (shl X, C1 - C2), C3 457 // shl (lshr X, C1), C2 --> and (lshr X, C1 - C2), C3 458 // but it isn't profitable unless we know the and'd out bits are already zero. 459 // Also, check that the inner shift is valid (less than the type width) or 460 // we'll crash trying to produce the bit mask for the 'and'. 461 unsigned TypeWidth = InnerShift->getType()->getScalarSizeInBits(); 462 if (InnerShiftConst->ugt(OuterShAmt) && InnerShiftConst->ult(TypeWidth)) { 463 unsigned InnerShAmt = InnerShiftConst->getZExtValue(); 464 unsigned MaskShift = 465 IsInnerShl ? TypeWidth - InnerShAmt : InnerShAmt - OuterShAmt; 466 APInt Mask = APInt::getLowBitsSet(TypeWidth, OuterShAmt) << MaskShift; 467 if (IC.MaskedValueIsZero(InnerShift->getOperand(0), Mask, 0, CxtI)) 468 return true; 469 } 470 471 return false; 472 } 473 474 /// See if we can compute the specified value, but shifted logically to the left 475 /// or right by some number of bits. This should return true if the expression 476 /// can be computed for the same cost as the current expression tree. This is 477 /// used to eliminate extraneous shifting from things like: 478 /// %C = shl i128 %A, 64 479 /// %D = shl i128 %B, 96 480 /// %E = or i128 %C, %D 481 /// %F = lshr i128 %E, 64 482 /// where the client will ask if E can be computed shifted right by 64-bits. If 483 /// this succeeds, getShiftedValue() will be called to produce the value. 484 static bool canEvaluateShifted(Value *V, unsigned NumBits, bool IsLeftShift, 485 InstCombinerImpl &IC, Instruction *CxtI) { 486 // We can always evaluate constants shifted. 487 if (isa<Constant>(V)) 488 return true; 489 490 Instruction *I = dyn_cast<Instruction>(V); 491 if (!I) return false; 492 493 // We can't mutate something that has multiple uses: doing so would 494 // require duplicating the instruction in general, which isn't profitable. 495 if (!I->hasOneUse()) return false; 496 497 switch (I->getOpcode()) { 498 default: return false; 499 case Instruction::And: 500 case Instruction::Or: 501 case Instruction::Xor: 502 // Bitwise operators can all arbitrarily be arbitrarily evaluated shifted. 503 return canEvaluateShifted(I->getOperand(0), NumBits, IsLeftShift, IC, I) && 504 canEvaluateShifted(I->getOperand(1), NumBits, IsLeftShift, IC, I); 505 506 case Instruction::Shl: 507 case Instruction::LShr: 508 return canEvaluateShiftedShift(NumBits, IsLeftShift, I, IC, CxtI); 509 510 case Instruction::Select: { 511 SelectInst *SI = cast<SelectInst>(I); 512 Value *TrueVal = SI->getTrueValue(); 513 Value *FalseVal = SI->getFalseValue(); 514 return canEvaluateShifted(TrueVal, NumBits, IsLeftShift, IC, SI) && 515 canEvaluateShifted(FalseVal, NumBits, IsLeftShift, IC, SI); 516 } 517 case Instruction::PHI: { 518 // We can change a phi if we can change all operands. Note that we never 519 // get into trouble with cyclic PHIs here because we only consider 520 // instructions with a single use. 521 PHINode *PN = cast<PHINode>(I); 522 for (Value *IncValue : PN->incoming_values()) 523 if (!canEvaluateShifted(IncValue, NumBits, IsLeftShift, IC, PN)) 524 return false; 525 return true; 526 } 527 } 528 } 529 530 /// Fold OuterShift (InnerShift X, C1), C2. 531 /// See canEvaluateShiftedShift() for the constraints on these instructions. 532 static Value *foldShiftedShift(BinaryOperator *InnerShift, unsigned OuterShAmt, 533 bool IsOuterShl, 534 InstCombiner::BuilderTy &Builder) { 535 bool IsInnerShl = InnerShift->getOpcode() == Instruction::Shl; 536 Type *ShType = InnerShift->getType(); 537 unsigned TypeWidth = ShType->getScalarSizeInBits(); 538 539 // We only accept shifts-by-a-constant in canEvaluateShifted(). 540 const APInt *C1; 541 match(InnerShift->getOperand(1), m_APInt(C1)); 542 unsigned InnerShAmt = C1->getZExtValue(); 543 544 // Change the shift amount and clear the appropriate IR flags. 545 auto NewInnerShift = [&](unsigned ShAmt) { 546 InnerShift->setOperand(1, ConstantInt::get(ShType, ShAmt)); 547 if (IsInnerShl) { 548 InnerShift->setHasNoUnsignedWrap(false); 549 InnerShift->setHasNoSignedWrap(false); 550 } else { 551 InnerShift->setIsExact(false); 552 } 553 return InnerShift; 554 }; 555 556 // Two logical shifts in the same direction: 557 // shl (shl X, C1), C2 --> shl X, C1 + C2 558 // lshr (lshr X, C1), C2 --> lshr X, C1 + C2 559 if (IsInnerShl == IsOuterShl) { 560 // If this is an oversized composite shift, then unsigned shifts get 0. 561 if (InnerShAmt + OuterShAmt >= TypeWidth) 562 return Constant::getNullValue(ShType); 563 564 return NewInnerShift(InnerShAmt + OuterShAmt); 565 } 566 567 // Equal shift amounts in opposite directions become bitwise 'and': 568 // lshr (shl X, C), C --> and X, C' 569 // shl (lshr X, C), C --> and X, C' 570 if (InnerShAmt == OuterShAmt) { 571 APInt Mask = IsInnerShl 572 ? APInt::getLowBitsSet(TypeWidth, TypeWidth - OuterShAmt) 573 : APInt::getHighBitsSet(TypeWidth, TypeWidth - OuterShAmt); 574 Value *And = Builder.CreateAnd(InnerShift->getOperand(0), 575 ConstantInt::get(ShType, Mask)); 576 if (auto *AndI = dyn_cast<Instruction>(And)) { 577 AndI->moveBefore(InnerShift); 578 AndI->takeName(InnerShift); 579 } 580 return And; 581 } 582 583 assert(InnerShAmt > OuterShAmt && 584 "Unexpected opposite direction logical shift pair"); 585 586 // In general, we would need an 'and' for this transform, but 587 // canEvaluateShiftedShift() guarantees that the masked-off bits are not used. 588 // lshr (shl X, C1), C2 --> shl X, C1 - C2 589 // shl (lshr X, C1), C2 --> lshr X, C1 - C2 590 return NewInnerShift(InnerShAmt - OuterShAmt); 591 } 592 593 /// When canEvaluateShifted() returns true for an expression, this function 594 /// inserts the new computation that produces the shifted value. 595 static Value *getShiftedValue(Value *V, unsigned NumBits, bool isLeftShift, 596 InstCombinerImpl &IC, const DataLayout &DL) { 597 // We can always evaluate constants shifted. 598 if (Constant *C = dyn_cast<Constant>(V)) { 599 if (isLeftShift) 600 return IC.Builder.CreateShl(C, NumBits); 601 else 602 return IC.Builder.CreateLShr(C, NumBits); 603 } 604 605 Instruction *I = cast<Instruction>(V); 606 IC.addToWorklist(I); 607 608 switch (I->getOpcode()) { 609 default: llvm_unreachable("Inconsistency with CanEvaluateShifted"); 610 case Instruction::And: 611 case Instruction::Or: 612 case Instruction::Xor: 613 // Bitwise operators can all arbitrarily be arbitrarily evaluated shifted. 614 I->setOperand( 615 0, getShiftedValue(I->getOperand(0), NumBits, isLeftShift, IC, DL)); 616 I->setOperand( 617 1, getShiftedValue(I->getOperand(1), NumBits, isLeftShift, IC, DL)); 618 return I; 619 620 case Instruction::Shl: 621 case Instruction::LShr: 622 return foldShiftedShift(cast<BinaryOperator>(I), NumBits, isLeftShift, 623 IC.Builder); 624 625 case Instruction::Select: 626 I->setOperand( 627 1, getShiftedValue(I->getOperand(1), NumBits, isLeftShift, IC, DL)); 628 I->setOperand( 629 2, getShiftedValue(I->getOperand(2), NumBits, isLeftShift, IC, DL)); 630 return I; 631 case Instruction::PHI: { 632 // We can change a phi if we can change all operands. Note that we never 633 // get into trouble with cyclic PHIs here because we only consider 634 // instructions with a single use. 635 PHINode *PN = cast<PHINode>(I); 636 for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) 637 PN->setIncomingValue(i, getShiftedValue(PN->getIncomingValue(i), NumBits, 638 isLeftShift, IC, DL)); 639 return PN; 640 } 641 } 642 } 643 644 // If this is a bitwise operator or add with a constant RHS we might be able 645 // to pull it through a shift. 646 static bool canShiftBinOpWithConstantRHS(BinaryOperator &Shift, 647 BinaryOperator *BO) { 648 switch (BO->getOpcode()) { 649 default: 650 return false; // Do not perform transform! 651 case Instruction::Add: 652 return Shift.getOpcode() == Instruction::Shl; 653 case Instruction::Or: 654 case Instruction::And: 655 return true; 656 case Instruction::Xor: 657 // Do not change a 'not' of logical shift because that would create a normal 658 // 'xor'. The 'not' is likely better for analysis, SCEV, and codegen. 659 return !(Shift.isLogicalShift() && match(BO, m_Not(m_Value()))); 660 } 661 } 662 663 Instruction *InstCombinerImpl::FoldShiftByConstant(Value *Op0, Constant *Op1, 664 BinaryOperator &I) { 665 const APInt *Op1C; 666 if (!match(Op1, m_APInt(Op1C))) 667 return nullptr; 668 669 // See if we can propagate this shift into the input, this covers the trivial 670 // cast of lshr(shl(x,c1),c2) as well as other more complex cases. 671 bool IsLeftShift = I.getOpcode() == Instruction::Shl; 672 if (I.getOpcode() != Instruction::AShr && 673 canEvaluateShifted(Op0, Op1C->getZExtValue(), IsLeftShift, *this, &I)) { 674 LLVM_DEBUG( 675 dbgs() << "ICE: GetShiftedValue propagating shift through expression" 676 " to eliminate shift:\n IN: " 677 << *Op0 << "\n SH: " << I << "\n"); 678 679 return replaceInstUsesWith( 680 I, getShiftedValue(Op0, Op1C->getZExtValue(), IsLeftShift, *this, DL)); 681 } 682 683 // See if we can simplify any instructions used by the instruction whose sole 684 // purpose is to compute bits we don't care about. 685 Type *Ty = I.getType(); 686 unsigned TypeBits = Ty->getScalarSizeInBits(); 687 assert(!Op1C->uge(TypeBits) && 688 "Shift over the type width should have been removed already"); 689 (void)TypeBits; 690 691 if (Instruction *FoldedShift = foldBinOpIntoSelectOrPhi(I)) 692 return FoldedShift; 693 694 if (!Op0->hasOneUse()) 695 return nullptr; 696 697 if (auto *Op0BO = dyn_cast<BinaryOperator>(Op0)) { 698 // If the operand is a bitwise operator with a constant RHS, and the 699 // shift is the only use, we can pull it out of the shift. 700 const APInt *Op0C; 701 if (match(Op0BO->getOperand(1), m_APInt(Op0C))) { 702 if (canShiftBinOpWithConstantRHS(I, Op0BO)) { 703 Constant *NewRHS = ConstantExpr::get( 704 I.getOpcode(), cast<Constant>(Op0BO->getOperand(1)), Op1); 705 706 Value *NewShift = 707 Builder.CreateBinOp(I.getOpcode(), Op0BO->getOperand(0), Op1); 708 NewShift->takeName(Op0BO); 709 710 return BinaryOperator::Create(Op0BO->getOpcode(), NewShift, NewRHS); 711 } 712 } 713 } 714 715 // If we have a select that conditionally executes some binary operator, 716 // see if we can pull it the select and operator through the shift. 717 // 718 // For example, turning: 719 // shl (select C, (add X, C1), X), C2 720 // Into: 721 // Y = shl X, C2 722 // select C, (add Y, C1 << C2), Y 723 Value *Cond; 724 BinaryOperator *TBO; 725 Value *FalseVal; 726 if (match(Op0, m_Select(m_Value(Cond), m_OneUse(m_BinOp(TBO)), 727 m_Value(FalseVal)))) { 728 const APInt *C; 729 if (!isa<Constant>(FalseVal) && TBO->getOperand(0) == FalseVal && 730 match(TBO->getOperand(1), m_APInt(C)) && 731 canShiftBinOpWithConstantRHS(I, TBO)) { 732 Constant *NewRHS = ConstantExpr::get( 733 I.getOpcode(), cast<Constant>(TBO->getOperand(1)), Op1); 734 735 Value *NewShift = Builder.CreateBinOp(I.getOpcode(), FalseVal, Op1); 736 Value *NewOp = Builder.CreateBinOp(TBO->getOpcode(), NewShift, NewRHS); 737 return SelectInst::Create(Cond, NewOp, NewShift); 738 } 739 } 740 741 BinaryOperator *FBO; 742 Value *TrueVal; 743 if (match(Op0, m_Select(m_Value(Cond), m_Value(TrueVal), 744 m_OneUse(m_BinOp(FBO))))) { 745 const APInt *C; 746 if (!isa<Constant>(TrueVal) && FBO->getOperand(0) == TrueVal && 747 match(FBO->getOperand(1), m_APInt(C)) && 748 canShiftBinOpWithConstantRHS(I, FBO)) { 749 Constant *NewRHS = ConstantExpr::get( 750 I.getOpcode(), cast<Constant>(FBO->getOperand(1)), Op1); 751 752 Value *NewShift = Builder.CreateBinOp(I.getOpcode(), TrueVal, Op1); 753 Value *NewOp = Builder.CreateBinOp(FBO->getOpcode(), NewShift, NewRHS); 754 return SelectInst::Create(Cond, NewShift, NewOp); 755 } 756 } 757 758 return nullptr; 759 } 760 761 Instruction *InstCombinerImpl::visitShl(BinaryOperator &I) { 762 const SimplifyQuery Q = SQ.getWithInstruction(&I); 763 764 if (Value *V = SimplifyShlInst(I.getOperand(0), I.getOperand(1), 765 I.hasNoSignedWrap(), I.hasNoUnsignedWrap(), Q)) 766 return replaceInstUsesWith(I, V); 767 768 if (Instruction *X = foldVectorBinop(I)) 769 return X; 770 771 if (Instruction *V = commonShiftTransforms(I)) 772 return V; 773 774 if (Instruction *V = dropRedundantMaskingOfLeftShiftInput(&I, Q, Builder)) 775 return V; 776 777 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 778 Type *Ty = I.getType(); 779 unsigned BitWidth = Ty->getScalarSizeInBits(); 780 781 const APInt *C; 782 if (match(Op1, m_APInt(C))) { 783 unsigned ShAmtC = C->getZExtValue(); 784 785 // shl (zext X), C --> zext (shl X, C) 786 // This is only valid if X would have zeros shifted out. 787 Value *X; 788 if (match(Op0, m_OneUse(m_ZExt(m_Value(X))))) { 789 unsigned SrcWidth = X->getType()->getScalarSizeInBits(); 790 if (ShAmtC < SrcWidth && 791 MaskedValueIsZero(X, APInt::getHighBitsSet(SrcWidth, ShAmtC), 0, &I)) 792 return new ZExtInst(Builder.CreateShl(X, ShAmtC), Ty); 793 } 794 795 // (X >> C) << C --> X & (-1 << C) 796 if (match(Op0, m_Shr(m_Value(X), m_Specific(Op1)))) { 797 APInt Mask(APInt::getHighBitsSet(BitWidth, BitWidth - ShAmtC)); 798 return BinaryOperator::CreateAnd(X, ConstantInt::get(Ty, Mask)); 799 } 800 801 const APInt *C1; 802 if (match(Op0, m_Exact(m_Shr(m_Value(X), m_APInt(C1)))) && 803 C1->ult(BitWidth)) { 804 unsigned ShrAmt = C1->getZExtValue(); 805 if (ShrAmt < ShAmtC) { 806 // If C1 < C: (X >>?,exact C1) << C --> X << (C - C1) 807 Constant *ShiftDiff = ConstantInt::get(Ty, ShAmtC - ShrAmt); 808 auto *NewShl = BinaryOperator::CreateShl(X, ShiftDiff); 809 NewShl->setHasNoUnsignedWrap(I.hasNoUnsignedWrap()); 810 NewShl->setHasNoSignedWrap(I.hasNoSignedWrap()); 811 return NewShl; 812 } 813 if (ShrAmt > ShAmtC) { 814 // If C1 > C: (X >>?exact C1) << C --> X >>?exact (C1 - C) 815 Constant *ShiftDiff = ConstantInt::get(Ty, ShrAmt - ShAmtC); 816 auto *NewShr = BinaryOperator::Create( 817 cast<BinaryOperator>(Op0)->getOpcode(), X, ShiftDiff); 818 NewShr->setIsExact(true); 819 return NewShr; 820 } 821 } 822 823 if (match(Op0, m_OneUse(m_Shr(m_Value(X), m_APInt(C1)))) && 824 C1->ult(BitWidth)) { 825 unsigned ShrAmt = C1->getZExtValue(); 826 if (ShrAmt < ShAmtC) { 827 // If C1 < C: (X >>? C1) << C --> (X << (C - C1)) & (-1 << C) 828 Constant *ShiftDiff = ConstantInt::get(Ty, ShAmtC - ShrAmt); 829 auto *NewShl = BinaryOperator::CreateShl(X, ShiftDiff); 830 NewShl->setHasNoUnsignedWrap(I.hasNoUnsignedWrap()); 831 NewShl->setHasNoSignedWrap(I.hasNoSignedWrap()); 832 Builder.Insert(NewShl); 833 APInt Mask(APInt::getHighBitsSet(BitWidth, BitWidth - ShAmtC)); 834 return BinaryOperator::CreateAnd(NewShl, ConstantInt::get(Ty, Mask)); 835 } 836 if (ShrAmt > ShAmtC) { 837 // If C1 > C: (X >>? C1) << C --> (X >>? (C1 - C)) & (-1 << C) 838 Constant *ShiftDiff = ConstantInt::get(Ty, ShrAmt - ShAmtC); 839 auto *OldShr = cast<BinaryOperator>(Op0); 840 auto *NewShr = 841 BinaryOperator::Create(OldShr->getOpcode(), X, ShiftDiff); 842 NewShr->setIsExact(OldShr->isExact()); 843 Builder.Insert(NewShr); 844 APInt Mask(APInt::getHighBitsSet(BitWidth, BitWidth - ShAmtC)); 845 return BinaryOperator::CreateAnd(NewShr, ConstantInt::get(Ty, Mask)); 846 } 847 } 848 849 // Similar to above, but look through an intermediate trunc instruction. 850 BinaryOperator *Shr; 851 if (match(Op0, m_OneUse(m_Trunc(m_OneUse(m_BinOp(Shr))))) && 852 match(Shr, m_Shr(m_Value(X), m_APInt(C1)))) { 853 // The larger shift direction survives through the transform. 854 unsigned ShrAmtC = C1->getZExtValue(); 855 unsigned ShDiff = ShrAmtC > ShAmtC ? ShrAmtC - ShAmtC : ShAmtC - ShrAmtC; 856 Constant *ShiftDiffC = ConstantInt::get(X->getType(), ShDiff); 857 auto ShiftOpc = ShrAmtC > ShAmtC ? Shr->getOpcode() : Instruction::Shl; 858 859 // If C1 > C: 860 // (trunc (X >> C1)) << C --> (trunc (X >> (C1 - C))) && (-1 << C) 861 // If C > C1: 862 // (trunc (X >> C1)) << C --> (trunc (X << (C - C1))) && (-1 << C) 863 Value *NewShift = Builder.CreateBinOp(ShiftOpc, X, ShiftDiffC, "sh.diff"); 864 Value *Trunc = Builder.CreateTrunc(NewShift, Ty, "tr.sh.diff"); 865 APInt Mask(APInt::getHighBitsSet(BitWidth, BitWidth - ShAmtC)); 866 return BinaryOperator::CreateAnd(Trunc, ConstantInt::get(Ty, Mask)); 867 } 868 869 if (match(Op0, m_Shl(m_Value(X), m_APInt(C1))) && C1->ult(BitWidth)) { 870 unsigned AmtSum = ShAmtC + C1->getZExtValue(); 871 // Oversized shifts are simplified to zero in InstSimplify. 872 if (AmtSum < BitWidth) 873 // (X << C1) << C2 --> X << (C1 + C2) 874 return BinaryOperator::CreateShl(X, ConstantInt::get(Ty, AmtSum)); 875 } 876 877 // If we have an opposite shift by the same amount, we may be able to 878 // reorder binops and shifts to eliminate math/logic. 879 auto isSuitableBinOpcode = [](Instruction::BinaryOps BinOpcode) { 880 switch (BinOpcode) { 881 default: 882 return false; 883 case Instruction::Add: 884 case Instruction::And: 885 case Instruction::Or: 886 case Instruction::Xor: 887 case Instruction::Sub: 888 // NOTE: Sub is not commutable and the tranforms below may not be valid 889 // when the shift-right is operand 1 (RHS) of the sub. 890 return true; 891 } 892 }; 893 BinaryOperator *Op0BO; 894 if (match(Op0, m_OneUse(m_BinOp(Op0BO))) && 895 isSuitableBinOpcode(Op0BO->getOpcode())) { 896 // Commute so shift-right is on LHS of the binop. 897 // (Y bop (X >> C)) << C -> ((X >> C) bop Y) << C 898 // (Y bop ((X >> C) & CC)) << C -> (((X >> C) & CC) bop Y) << C 899 Value *Shr = Op0BO->getOperand(0); 900 Value *Y = Op0BO->getOperand(1); 901 Value *X; 902 const APInt *CC; 903 if (Op0BO->isCommutative() && Y->hasOneUse() && 904 (match(Y, m_Shr(m_Value(), m_Specific(Op1))) || 905 match(Y, m_And(m_OneUse(m_Shr(m_Value(), m_Specific(Op1))), 906 m_APInt(CC))))) 907 std::swap(Shr, Y); 908 909 // ((X >> C) bop Y) << C -> (X bop (Y << C)) & (~0 << C) 910 if (match(Shr, m_OneUse(m_Shr(m_Value(X), m_Specific(Op1))))) { 911 // Y << C 912 Value *YS = Builder.CreateShl(Y, Op1, Op0BO->getName()); 913 // (X bop (Y << C)) 914 Value *B = 915 Builder.CreateBinOp(Op0BO->getOpcode(), X, YS, Shr->getName()); 916 unsigned Op1Val = C->getLimitedValue(BitWidth); 917 APInt Bits = APInt::getHighBitsSet(BitWidth, BitWidth - Op1Val); 918 Constant *Mask = ConstantInt::get(Ty, Bits); 919 return BinaryOperator::CreateAnd(B, Mask); 920 } 921 922 // (((X >> C) & CC) bop Y) << C -> (X & (CC << C)) bop (Y << C) 923 if (match(Shr, 924 m_OneUse(m_And(m_OneUse(m_Shr(m_Value(X), m_Specific(Op1))), 925 m_APInt(CC))))) { 926 // Y << C 927 Value *YS = Builder.CreateShl(Y, Op1, Op0BO->getName()); 928 // X & (CC << C) 929 Value *M = Builder.CreateAnd(X, ConstantInt::get(Ty, CC->shl(*C)), 930 X->getName() + ".mask"); 931 return BinaryOperator::Create(Op0BO->getOpcode(), M, YS); 932 } 933 } 934 935 // (C1 - X) << C --> (C1 << C) - (X << C) 936 if (match(Op0, m_OneUse(m_Sub(m_APInt(C1), m_Value(X))))) { 937 Constant *NewLHS = ConstantInt::get(Ty, C1->shl(*C)); 938 Value *NewShift = Builder.CreateShl(X, Op1); 939 return BinaryOperator::CreateSub(NewLHS, NewShift); 940 } 941 942 // If the shifted-out value is known-zero, then this is a NUW shift. 943 if (!I.hasNoUnsignedWrap() && 944 MaskedValueIsZero(Op0, APInt::getHighBitsSet(BitWidth, ShAmtC), 0, 945 &I)) { 946 I.setHasNoUnsignedWrap(); 947 return &I; 948 } 949 950 // If the shifted-out value is all signbits, then this is a NSW shift. 951 if (!I.hasNoSignedWrap() && ComputeNumSignBits(Op0, 0, &I) > ShAmtC) { 952 I.setHasNoSignedWrap(); 953 return &I; 954 } 955 } 956 957 // Transform (x >> y) << y to x & (-1 << y) 958 // Valid for any type of right-shift. 959 Value *X; 960 if (match(Op0, m_OneUse(m_Shr(m_Value(X), m_Specific(Op1))))) { 961 Constant *AllOnes = ConstantInt::getAllOnesValue(Ty); 962 Value *Mask = Builder.CreateShl(AllOnes, Op1); 963 return BinaryOperator::CreateAnd(Mask, X); 964 } 965 966 Constant *C1; 967 if (match(Op1, m_Constant(C1))) { 968 Constant *C2; 969 Value *X; 970 // (C2 << X) << C1 --> (C2 << C1) << X 971 if (match(Op0, m_OneUse(m_Shl(m_Constant(C2), m_Value(X))))) 972 return BinaryOperator::CreateShl(ConstantExpr::getShl(C2, C1), X); 973 974 // (X * C2) << C1 --> X * (C2 << C1) 975 if (match(Op0, m_Mul(m_Value(X), m_Constant(C2)))) 976 return BinaryOperator::CreateMul(X, ConstantExpr::getShl(C2, C1)); 977 978 // shl (zext i1 X), C1 --> select (X, 1 << C1, 0) 979 if (match(Op0, m_ZExt(m_Value(X))) && X->getType()->isIntOrIntVectorTy(1)) { 980 auto *NewC = ConstantExpr::getShl(ConstantInt::get(Ty, 1), C1); 981 return SelectInst::Create(X, NewC, ConstantInt::getNullValue(Ty)); 982 } 983 } 984 985 // (1 << (C - x)) -> ((1 << C) >> x) if C is bitwidth - 1 986 if (match(Op0, m_One()) && 987 match(Op1, m_Sub(m_SpecificInt(BitWidth - 1), m_Value(X)))) 988 return BinaryOperator::CreateLShr( 989 ConstantInt::get(Ty, APInt::getSignMask(BitWidth)), X); 990 991 return nullptr; 992 } 993 994 Instruction *InstCombinerImpl::visitLShr(BinaryOperator &I) { 995 if (Value *V = SimplifyLShrInst(I.getOperand(0), I.getOperand(1), I.isExact(), 996 SQ.getWithInstruction(&I))) 997 return replaceInstUsesWith(I, V); 998 999 if (Instruction *X = foldVectorBinop(I)) 1000 return X; 1001 1002 if (Instruction *R = commonShiftTransforms(I)) 1003 return R; 1004 1005 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 1006 Type *Ty = I.getType(); 1007 const APInt *C; 1008 if (match(Op1, m_APInt(C))) { 1009 unsigned ShAmtC = C->getZExtValue(); 1010 unsigned BitWidth = Ty->getScalarSizeInBits(); 1011 auto *II = dyn_cast<IntrinsicInst>(Op0); 1012 if (II && isPowerOf2_32(BitWidth) && Log2_32(BitWidth) == ShAmtC && 1013 (II->getIntrinsicID() == Intrinsic::ctlz || 1014 II->getIntrinsicID() == Intrinsic::cttz || 1015 II->getIntrinsicID() == Intrinsic::ctpop)) { 1016 // ctlz.i32(x)>>5 --> zext(x == 0) 1017 // cttz.i32(x)>>5 --> zext(x == 0) 1018 // ctpop.i32(x)>>5 --> zext(x == -1) 1019 bool IsPop = II->getIntrinsicID() == Intrinsic::ctpop; 1020 Constant *RHS = ConstantInt::getSigned(Ty, IsPop ? -1 : 0); 1021 Value *Cmp = Builder.CreateICmpEQ(II->getArgOperand(0), RHS); 1022 return new ZExtInst(Cmp, Ty); 1023 } 1024 1025 Value *X; 1026 const APInt *C1; 1027 if (match(Op0, m_Shl(m_Value(X), m_APInt(C1))) && C1->ult(BitWidth)) { 1028 if (C1->ult(ShAmtC)) { 1029 unsigned ShlAmtC = C1->getZExtValue(); 1030 Constant *ShiftDiff = ConstantInt::get(Ty, ShAmtC - ShlAmtC); 1031 if (cast<BinaryOperator>(Op0)->hasNoUnsignedWrap()) { 1032 // (X <<nuw C1) >>u C --> X >>u (C - C1) 1033 auto *NewLShr = BinaryOperator::CreateLShr(X, ShiftDiff); 1034 NewLShr->setIsExact(I.isExact()); 1035 return NewLShr; 1036 } 1037 if (Op0->hasOneUse()) { 1038 // (X << C1) >>u C --> (X >>u (C - C1)) & (-1 >> C) 1039 Value *NewLShr = Builder.CreateLShr(X, ShiftDiff, "", I.isExact()); 1040 APInt Mask(APInt::getLowBitsSet(BitWidth, BitWidth - ShAmtC)); 1041 return BinaryOperator::CreateAnd(NewLShr, ConstantInt::get(Ty, Mask)); 1042 } 1043 } else if (C1->ugt(ShAmtC)) { 1044 unsigned ShlAmtC = C1->getZExtValue(); 1045 Constant *ShiftDiff = ConstantInt::get(Ty, ShlAmtC - ShAmtC); 1046 if (cast<BinaryOperator>(Op0)->hasNoUnsignedWrap()) { 1047 // (X <<nuw C1) >>u C --> X <<nuw (C1 - C) 1048 auto *NewShl = BinaryOperator::CreateShl(X, ShiftDiff); 1049 NewShl->setHasNoUnsignedWrap(true); 1050 return NewShl; 1051 } 1052 if (Op0->hasOneUse()) { 1053 // (X << C1) >>u C --> X << (C1 - C) & (-1 >> C) 1054 Value *NewShl = Builder.CreateShl(X, ShiftDiff); 1055 APInt Mask(APInt::getLowBitsSet(BitWidth, BitWidth - ShAmtC)); 1056 return BinaryOperator::CreateAnd(NewShl, ConstantInt::get(Ty, Mask)); 1057 } 1058 } else { 1059 assert(*C1 == ShAmtC); 1060 // (X << C) >>u C --> X & (-1 >>u C) 1061 APInt Mask(APInt::getLowBitsSet(BitWidth, BitWidth - ShAmtC)); 1062 return BinaryOperator::CreateAnd(X, ConstantInt::get(Ty, Mask)); 1063 } 1064 } 1065 1066 // ((X << C) + Y) >>u C --> (X + (Y >>u C)) & (-1 >>u C) 1067 // TODO: Consolidate with the more general transform that starts from shl 1068 // (the shifts are in the opposite order). 1069 Value *Y; 1070 if (match(Op0, 1071 m_OneUse(m_c_Add(m_OneUse(m_Shl(m_Value(X), m_Specific(Op1))), 1072 m_Value(Y))))) { 1073 Value *NewLshr = Builder.CreateLShr(Y, Op1); 1074 Value *NewAdd = Builder.CreateAdd(NewLshr, X); 1075 unsigned Op1Val = C->getLimitedValue(BitWidth); 1076 APInt Bits = APInt::getLowBitsSet(BitWidth, BitWidth - Op1Val); 1077 Constant *Mask = ConstantInt::get(Ty, Bits); 1078 return BinaryOperator::CreateAnd(NewAdd, Mask); 1079 } 1080 1081 if (match(Op0, m_OneUse(m_ZExt(m_Value(X)))) && 1082 (!Ty->isIntegerTy() || shouldChangeType(Ty, X->getType()))) { 1083 assert(ShAmtC < X->getType()->getScalarSizeInBits() && 1084 "Big shift not simplified to zero?"); 1085 // lshr (zext iM X to iN), C --> zext (lshr X, C) to iN 1086 Value *NewLShr = Builder.CreateLShr(X, ShAmtC); 1087 return new ZExtInst(NewLShr, Ty); 1088 } 1089 1090 if (match(Op0, m_SExt(m_Value(X)))) { 1091 unsigned SrcTyBitWidth = X->getType()->getScalarSizeInBits(); 1092 // lshr (sext i1 X to iN), C --> select (X, -1 >> C, 0) 1093 if (SrcTyBitWidth == 1) { 1094 auto *NewC = ConstantInt::get( 1095 Ty, APInt::getLowBitsSet(BitWidth, BitWidth - ShAmtC)); 1096 return SelectInst::Create(X, NewC, ConstantInt::getNullValue(Ty)); 1097 } 1098 1099 if ((!Ty->isIntegerTy() || shouldChangeType(Ty, X->getType())) && 1100 Op0->hasOneUse()) { 1101 // Are we moving the sign bit to the low bit and widening with high 1102 // zeros? lshr (sext iM X to iN), N-1 --> zext (lshr X, M-1) to iN 1103 if (ShAmtC == BitWidth - 1) { 1104 Value *NewLShr = Builder.CreateLShr(X, SrcTyBitWidth - 1); 1105 return new ZExtInst(NewLShr, Ty); 1106 } 1107 1108 // lshr (sext iM X to iN), N-M --> zext (ashr X, min(N-M, M-1)) to iN 1109 if (ShAmtC == BitWidth - SrcTyBitWidth) { 1110 // The new shift amount can't be more than the narrow source type. 1111 unsigned NewShAmt = std::min(ShAmtC, SrcTyBitWidth - 1); 1112 Value *AShr = Builder.CreateAShr(X, NewShAmt); 1113 return new ZExtInst(AShr, Ty); 1114 } 1115 } 1116 } 1117 1118 if (ShAmtC == BitWidth - 1) { 1119 // lshr i32 or(X,-X), 31 --> zext (X != 0) 1120 if (match(Op0, m_OneUse(m_c_Or(m_Neg(m_Value(X)), m_Deferred(X))))) 1121 return new ZExtInst(Builder.CreateIsNotNull(X), Ty); 1122 1123 // lshr i32 (X -nsw Y), 31 --> zext (X < Y) 1124 if (match(Op0, m_OneUse(m_NSWSub(m_Value(X), m_Value(Y))))) 1125 return new ZExtInst(Builder.CreateICmpSLT(X, Y), Ty); 1126 1127 // Check if a number is negative and odd: 1128 // lshr i32 (srem X, 2), 31 --> and (X >> 31), X 1129 if (match(Op0, m_OneUse(m_SRem(m_Value(X), m_SpecificInt(2))))) { 1130 Value *Signbit = Builder.CreateLShr(X, ShAmtC); 1131 return BinaryOperator::CreateAnd(Signbit, X); 1132 } 1133 } 1134 1135 // (X >>u C1) >>u C --> X >>u (C1 + C) 1136 if (match(Op0, m_LShr(m_Value(X), m_APInt(C1)))) { 1137 // Oversized shifts are simplified to zero in InstSimplify. 1138 unsigned AmtSum = ShAmtC + C1->getZExtValue(); 1139 if (AmtSum < BitWidth) 1140 return BinaryOperator::CreateLShr(X, ConstantInt::get(Ty, AmtSum)); 1141 } 1142 1143 Instruction *TruncSrc; 1144 if (match(Op0, m_OneUse(m_Trunc(m_Instruction(TruncSrc)))) && 1145 match(TruncSrc, m_LShr(m_Value(X), m_APInt(C1)))) { 1146 unsigned SrcWidth = X->getType()->getScalarSizeInBits(); 1147 unsigned AmtSum = ShAmtC + C1->getZExtValue(); 1148 1149 // If the combined shift fits in the source width: 1150 // (trunc (X >>u C1)) >>u C --> and (trunc (X >>u (C1 + C)), MaskC 1151 // 1152 // If the first shift covers the number of bits truncated, then the 1153 // mask instruction is eliminated (and so the use check is relaxed). 1154 if (AmtSum < SrcWidth && 1155 (TruncSrc->hasOneUse() || C1->uge(SrcWidth - BitWidth))) { 1156 Value *SumShift = Builder.CreateLShr(X, AmtSum, "sum.shift"); 1157 Value *Trunc = Builder.CreateTrunc(SumShift, Ty, I.getName()); 1158 1159 // If the first shift does not cover the number of bits truncated, then 1160 // we require a mask to get rid of high bits in the result. 1161 APInt MaskC = APInt::getAllOnes(BitWidth).lshr(ShAmtC); 1162 return BinaryOperator::CreateAnd(Trunc, ConstantInt::get(Ty, MaskC)); 1163 } 1164 } 1165 1166 // Look for a "splat" mul pattern - it replicates bits across each half of 1167 // a value, so a right shift is just a mask of the low bits: 1168 // lshr i32 (mul nuw X, Pow2+1), 16 --> and X, Pow2-1 1169 // TODO: Generalize to allow more than just half-width shifts? 1170 const APInt *MulC; 1171 if (match(Op0, m_NUWMul(m_Value(X), m_APInt(MulC))) && 1172 ShAmtC * 2 == BitWidth && (*MulC - 1).isPowerOf2() && 1173 MulC->logBase2() == ShAmtC) 1174 return BinaryOperator::CreateAnd(X, ConstantInt::get(Ty, *MulC - 2)); 1175 1176 // If the shifted-out value is known-zero, then this is an exact shift. 1177 if (!I.isExact() && 1178 MaskedValueIsZero(Op0, APInt::getLowBitsSet(BitWidth, ShAmtC), 0, &I)) { 1179 I.setIsExact(); 1180 return &I; 1181 } 1182 } 1183 1184 // Transform (x << y) >> y to x & (-1 >> y) 1185 Value *X; 1186 if (match(Op0, m_OneUse(m_Shl(m_Value(X), m_Specific(Op1))))) { 1187 Constant *AllOnes = ConstantInt::getAllOnesValue(Ty); 1188 Value *Mask = Builder.CreateLShr(AllOnes, Op1); 1189 return BinaryOperator::CreateAnd(Mask, X); 1190 } 1191 1192 return nullptr; 1193 } 1194 1195 Instruction * 1196 InstCombinerImpl::foldVariableSignZeroExtensionOfVariableHighBitExtract( 1197 BinaryOperator &OldAShr) { 1198 assert(OldAShr.getOpcode() == Instruction::AShr && 1199 "Must be called with arithmetic right-shift instruction only."); 1200 1201 // Check that constant C is a splat of the element-wise bitwidth of V. 1202 auto BitWidthSplat = [](Constant *C, Value *V) { 1203 return match( 1204 C, m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_EQ, 1205 APInt(C->getType()->getScalarSizeInBits(), 1206 V->getType()->getScalarSizeInBits()))); 1207 }; 1208 1209 // It should look like variable-length sign-extension on the outside: 1210 // (Val << (bitwidth(Val)-Nbits)) a>> (bitwidth(Val)-Nbits) 1211 Value *NBits; 1212 Instruction *MaybeTrunc; 1213 Constant *C1, *C2; 1214 if (!match(&OldAShr, 1215 m_AShr(m_Shl(m_Instruction(MaybeTrunc), 1216 m_ZExtOrSelf(m_Sub(m_Constant(C1), 1217 m_ZExtOrSelf(m_Value(NBits))))), 1218 m_ZExtOrSelf(m_Sub(m_Constant(C2), 1219 m_ZExtOrSelf(m_Deferred(NBits)))))) || 1220 !BitWidthSplat(C1, &OldAShr) || !BitWidthSplat(C2, &OldAShr)) 1221 return nullptr; 1222 1223 // There may or may not be a truncation after outer two shifts. 1224 Instruction *HighBitExtract; 1225 match(MaybeTrunc, m_TruncOrSelf(m_Instruction(HighBitExtract))); 1226 bool HadTrunc = MaybeTrunc != HighBitExtract; 1227 1228 // And finally, the innermost part of the pattern must be a right-shift. 1229 Value *X, *NumLowBitsToSkip; 1230 if (!match(HighBitExtract, m_Shr(m_Value(X), m_Value(NumLowBitsToSkip)))) 1231 return nullptr; 1232 1233 // Said right-shift must extract high NBits bits - C0 must be it's bitwidth. 1234 Constant *C0; 1235 if (!match(NumLowBitsToSkip, 1236 m_ZExtOrSelf( 1237 m_Sub(m_Constant(C0), m_ZExtOrSelf(m_Specific(NBits))))) || 1238 !BitWidthSplat(C0, HighBitExtract)) 1239 return nullptr; 1240 1241 // Since the NBits is identical for all shifts, if the outermost and 1242 // innermost shifts are identical, then outermost shifts are redundant. 1243 // If we had truncation, do keep it though. 1244 if (HighBitExtract->getOpcode() == OldAShr.getOpcode()) 1245 return replaceInstUsesWith(OldAShr, MaybeTrunc); 1246 1247 // Else, if there was a truncation, then we need to ensure that one 1248 // instruction will go away. 1249 if (HadTrunc && !match(&OldAShr, m_c_BinOp(m_OneUse(m_Value()), m_Value()))) 1250 return nullptr; 1251 1252 // Finally, bypass two innermost shifts, and perform the outermost shift on 1253 // the operands of the innermost shift. 1254 Instruction *NewAShr = 1255 BinaryOperator::Create(OldAShr.getOpcode(), X, NumLowBitsToSkip); 1256 NewAShr->copyIRFlags(HighBitExtract); // We can preserve 'exact'-ness. 1257 if (!HadTrunc) 1258 return NewAShr; 1259 1260 Builder.Insert(NewAShr); 1261 return TruncInst::CreateTruncOrBitCast(NewAShr, OldAShr.getType()); 1262 } 1263 1264 Instruction *InstCombinerImpl::visitAShr(BinaryOperator &I) { 1265 if (Value *V = SimplifyAShrInst(I.getOperand(0), I.getOperand(1), I.isExact(), 1266 SQ.getWithInstruction(&I))) 1267 return replaceInstUsesWith(I, V); 1268 1269 if (Instruction *X = foldVectorBinop(I)) 1270 return X; 1271 1272 if (Instruction *R = commonShiftTransforms(I)) 1273 return R; 1274 1275 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 1276 Type *Ty = I.getType(); 1277 unsigned BitWidth = Ty->getScalarSizeInBits(); 1278 const APInt *ShAmtAPInt; 1279 if (match(Op1, m_APInt(ShAmtAPInt)) && ShAmtAPInt->ult(BitWidth)) { 1280 unsigned ShAmt = ShAmtAPInt->getZExtValue(); 1281 1282 // If the shift amount equals the difference in width of the destination 1283 // and source scalar types: 1284 // ashr (shl (zext X), C), C --> sext X 1285 Value *X; 1286 if (match(Op0, m_Shl(m_ZExt(m_Value(X)), m_Specific(Op1))) && 1287 ShAmt == BitWidth - X->getType()->getScalarSizeInBits()) 1288 return new SExtInst(X, Ty); 1289 1290 // We can't handle (X << C1) >>s C2. It shifts arbitrary bits in. However, 1291 // we can handle (X <<nsw C1) >>s C2 since it only shifts in sign bits. 1292 const APInt *ShOp1; 1293 if (match(Op0, m_NSWShl(m_Value(X), m_APInt(ShOp1))) && 1294 ShOp1->ult(BitWidth)) { 1295 unsigned ShlAmt = ShOp1->getZExtValue(); 1296 if (ShlAmt < ShAmt) { 1297 // (X <<nsw C1) >>s C2 --> X >>s (C2 - C1) 1298 Constant *ShiftDiff = ConstantInt::get(Ty, ShAmt - ShlAmt); 1299 auto *NewAShr = BinaryOperator::CreateAShr(X, ShiftDiff); 1300 NewAShr->setIsExact(I.isExact()); 1301 return NewAShr; 1302 } 1303 if (ShlAmt > ShAmt) { 1304 // (X <<nsw C1) >>s C2 --> X <<nsw (C1 - C2) 1305 Constant *ShiftDiff = ConstantInt::get(Ty, ShlAmt - ShAmt); 1306 auto *NewShl = BinaryOperator::Create(Instruction::Shl, X, ShiftDiff); 1307 NewShl->setHasNoSignedWrap(true); 1308 return NewShl; 1309 } 1310 } 1311 1312 if (match(Op0, m_AShr(m_Value(X), m_APInt(ShOp1))) && 1313 ShOp1->ult(BitWidth)) { 1314 unsigned AmtSum = ShAmt + ShOp1->getZExtValue(); 1315 // Oversized arithmetic shifts replicate the sign bit. 1316 AmtSum = std::min(AmtSum, BitWidth - 1); 1317 // (X >>s C1) >>s C2 --> X >>s (C1 + C2) 1318 return BinaryOperator::CreateAShr(X, ConstantInt::get(Ty, AmtSum)); 1319 } 1320 1321 if (match(Op0, m_OneUse(m_SExt(m_Value(X)))) && 1322 (Ty->isVectorTy() || shouldChangeType(Ty, X->getType()))) { 1323 // ashr (sext X), C --> sext (ashr X, C') 1324 Type *SrcTy = X->getType(); 1325 ShAmt = std::min(ShAmt, SrcTy->getScalarSizeInBits() - 1); 1326 Value *NewSh = Builder.CreateAShr(X, ConstantInt::get(SrcTy, ShAmt)); 1327 return new SExtInst(NewSh, Ty); 1328 } 1329 1330 if (ShAmt == BitWidth - 1) { 1331 // ashr i32 or(X,-X), 31 --> sext (X != 0) 1332 if (match(Op0, m_OneUse(m_c_Or(m_Neg(m_Value(X)), m_Deferred(X))))) 1333 return new SExtInst(Builder.CreateIsNotNull(X), Ty); 1334 1335 // ashr i32 (X -nsw Y), 31 --> sext (X < Y) 1336 Value *Y; 1337 if (match(Op0, m_OneUse(m_NSWSub(m_Value(X), m_Value(Y))))) 1338 return new SExtInst(Builder.CreateICmpSLT(X, Y), Ty); 1339 } 1340 1341 // If the shifted-out value is known-zero, then this is an exact shift. 1342 if (!I.isExact() && 1343 MaskedValueIsZero(Op0, APInt::getLowBitsSet(BitWidth, ShAmt), 0, &I)) { 1344 I.setIsExact(); 1345 return &I; 1346 } 1347 } 1348 1349 // Prefer `-(x & 1)` over `(x << (bitwidth(x)-1)) a>> (bitwidth(x)-1)` 1350 // as the pattern to splat the lowest bit. 1351 // FIXME: iff X is already masked, we don't need the one-use check. 1352 Value *X; 1353 if (match(Op1, m_SpecificIntAllowUndef(BitWidth - 1)) && 1354 match(Op0, m_OneUse(m_Shl(m_Value(X), 1355 m_SpecificIntAllowUndef(BitWidth - 1))))) { 1356 Constant *Mask = ConstantInt::get(Ty, 1); 1357 // Retain the knowledge about the ignored lanes. 1358 Mask = Constant::mergeUndefsWith( 1359 Constant::mergeUndefsWith(Mask, cast<Constant>(Op1)), 1360 cast<Constant>(cast<Instruction>(Op0)->getOperand(1))); 1361 X = Builder.CreateAnd(X, Mask); 1362 return BinaryOperator::CreateNeg(X); 1363 } 1364 1365 if (Instruction *R = foldVariableSignZeroExtensionOfVariableHighBitExtract(I)) 1366 return R; 1367 1368 // See if we can turn a signed shr into an unsigned shr. 1369 if (MaskedValueIsZero(Op0, APInt::getSignMask(BitWidth), 0, &I)) 1370 return BinaryOperator::CreateLShr(Op0, Op1); 1371 1372 // ashr (xor %x, -1), %y --> xor (ashr %x, %y), -1 1373 if (match(Op0, m_OneUse(m_Not(m_Value(X))))) { 1374 // Note that we must drop 'exact'-ness of the shift! 1375 // Note that we can't keep undef's in -1 vector constant! 1376 auto *NewAShr = Builder.CreateAShr(X, Op1, Op0->getName() + ".not"); 1377 return BinaryOperator::CreateNot(NewAShr); 1378 } 1379 1380 return nullptr; 1381 } 1382