1 //===- InstCombineShifts.cpp ----------------------------------------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // This file implements the visitShl, visitLShr, and visitAShr functions. 10 // 11 //===----------------------------------------------------------------------===// 12 13 #include "InstCombineInternal.h" 14 #include "llvm/Analysis/ConstantFolding.h" 15 #include "llvm/Analysis/InstructionSimplify.h" 16 #include "llvm/IR/IntrinsicInst.h" 17 #include "llvm/IR/PatternMatch.h" 18 #include "llvm/Transforms/InstCombine/InstCombiner.h" 19 using namespace llvm; 20 using namespace PatternMatch; 21 22 #define DEBUG_TYPE "instcombine" 23 24 bool canTryToConstantAddTwoShiftAmounts(Value *Sh0, Value *ShAmt0, Value *Sh1, 25 Value *ShAmt1) { 26 // We have two shift amounts from two different shifts. The types of those 27 // shift amounts may not match. If that's the case let's bailout now.. 28 if (ShAmt0->getType() != ShAmt1->getType()) 29 return false; 30 31 // As input, we have the following pattern: 32 // Sh0 (Sh1 X, Q), K 33 // We want to rewrite that as: 34 // Sh x, (Q+K) iff (Q+K) u< bitwidth(x) 35 // While we know that originally (Q+K) would not overflow 36 // (because 2 * (N-1) u<= iN -1), we have looked past extensions of 37 // shift amounts. so it may now overflow in smaller bitwidth. 38 // To ensure that does not happen, we need to ensure that the total maximal 39 // shift amount is still representable in that smaller bit width. 40 unsigned MaximalPossibleTotalShiftAmount = 41 (Sh0->getType()->getScalarSizeInBits() - 1) + 42 (Sh1->getType()->getScalarSizeInBits() - 1); 43 APInt MaximalRepresentableShiftAmount = 44 APInt::getAllOnes(ShAmt0->getType()->getScalarSizeInBits()); 45 return MaximalRepresentableShiftAmount.uge(MaximalPossibleTotalShiftAmount); 46 } 47 48 // Given pattern: 49 // (x shiftopcode Q) shiftopcode K 50 // we should rewrite it as 51 // x shiftopcode (Q+K) iff (Q+K) u< bitwidth(x) and 52 // 53 // This is valid for any shift, but they must be identical, and we must be 54 // careful in case we have (zext(Q)+zext(K)) and look past extensions, 55 // (Q+K) must not overflow or else (Q+K) u< bitwidth(x) is bogus. 56 // 57 // AnalyzeForSignBitExtraction indicates that we will only analyze whether this 58 // pattern has any 2 right-shifts that sum to 1 less than original bit width. 59 Value *InstCombinerImpl::reassociateShiftAmtsOfTwoSameDirectionShifts( 60 BinaryOperator *Sh0, const SimplifyQuery &SQ, 61 bool AnalyzeForSignBitExtraction) { 62 // Look for a shift of some instruction, ignore zext of shift amount if any. 63 Instruction *Sh0Op0; 64 Value *ShAmt0; 65 if (!match(Sh0, 66 m_Shift(m_Instruction(Sh0Op0), m_ZExtOrSelf(m_Value(ShAmt0))))) 67 return nullptr; 68 69 // If there is a truncation between the two shifts, we must make note of it 70 // and look through it. The truncation imposes additional constraints on the 71 // transform. 72 Instruction *Sh1; 73 Value *Trunc = nullptr; 74 match(Sh0Op0, 75 m_CombineOr(m_CombineAnd(m_Trunc(m_Instruction(Sh1)), m_Value(Trunc)), 76 m_Instruction(Sh1))); 77 78 // Inner shift: (x shiftopcode ShAmt1) 79 // Like with other shift, ignore zext of shift amount if any. 80 Value *X, *ShAmt1; 81 if (!match(Sh1, m_Shift(m_Value(X), m_ZExtOrSelf(m_Value(ShAmt1))))) 82 return nullptr; 83 84 // Verify that it would be safe to try to add those two shift amounts. 85 if (!canTryToConstantAddTwoShiftAmounts(Sh0, ShAmt0, Sh1, ShAmt1)) 86 return nullptr; 87 88 // We are only looking for signbit extraction if we have two right shifts. 89 bool HadTwoRightShifts = match(Sh0, m_Shr(m_Value(), m_Value())) && 90 match(Sh1, m_Shr(m_Value(), m_Value())); 91 // ... and if it's not two right-shifts, we know the answer already. 92 if (AnalyzeForSignBitExtraction && !HadTwoRightShifts) 93 return nullptr; 94 95 // The shift opcodes must be identical, unless we are just checking whether 96 // this pattern can be interpreted as a sign-bit-extraction. 97 Instruction::BinaryOps ShiftOpcode = Sh0->getOpcode(); 98 bool IdenticalShOpcodes = Sh0->getOpcode() == Sh1->getOpcode(); 99 if (!IdenticalShOpcodes && !AnalyzeForSignBitExtraction) 100 return nullptr; 101 102 // If we saw truncation, we'll need to produce extra instruction, 103 // and for that one of the operands of the shift must be one-use, 104 // unless of course we don't actually plan to produce any instructions here. 105 if (Trunc && !AnalyzeForSignBitExtraction && 106 !match(Sh0, m_c_BinOp(m_OneUse(m_Value()), m_Value()))) 107 return nullptr; 108 109 // Can we fold (ShAmt0+ShAmt1) ? 110 auto *NewShAmt = dyn_cast_or_null<Constant>( 111 SimplifyAddInst(ShAmt0, ShAmt1, /*isNSW=*/false, /*isNUW=*/false, 112 SQ.getWithInstruction(Sh0))); 113 if (!NewShAmt) 114 return nullptr; // Did not simplify. 115 unsigned NewShAmtBitWidth = NewShAmt->getType()->getScalarSizeInBits(); 116 unsigned XBitWidth = X->getType()->getScalarSizeInBits(); 117 // Is the new shift amount smaller than the bit width of inner/new shift? 118 if (!match(NewShAmt, m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_ULT, 119 APInt(NewShAmtBitWidth, XBitWidth)))) 120 return nullptr; // FIXME: could perform constant-folding. 121 122 // If there was a truncation, and we have a right-shift, we can only fold if 123 // we are left with the original sign bit. Likewise, if we were just checking 124 // that this is a sighbit extraction, this is the place to check it. 125 // FIXME: zero shift amount is also legal here, but we can't *easily* check 126 // more than one predicate so it's not really worth it. 127 if (HadTwoRightShifts && (Trunc || AnalyzeForSignBitExtraction)) { 128 // If it's not a sign bit extraction, then we're done. 129 if (!match(NewShAmt, 130 m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_EQ, 131 APInt(NewShAmtBitWidth, XBitWidth - 1)))) 132 return nullptr; 133 // If it is, and that was the question, return the base value. 134 if (AnalyzeForSignBitExtraction) 135 return X; 136 } 137 138 assert(IdenticalShOpcodes && "Should not get here with different shifts."); 139 140 // All good, we can do this fold. 141 NewShAmt = ConstantExpr::getZExtOrBitCast(NewShAmt, X->getType()); 142 143 BinaryOperator *NewShift = BinaryOperator::Create(ShiftOpcode, X, NewShAmt); 144 145 // The flags can only be propagated if there wasn't a trunc. 146 if (!Trunc) { 147 // If the pattern did not involve trunc, and both of the original shifts 148 // had the same flag set, preserve the flag. 149 if (ShiftOpcode == Instruction::BinaryOps::Shl) { 150 NewShift->setHasNoUnsignedWrap(Sh0->hasNoUnsignedWrap() && 151 Sh1->hasNoUnsignedWrap()); 152 NewShift->setHasNoSignedWrap(Sh0->hasNoSignedWrap() && 153 Sh1->hasNoSignedWrap()); 154 } else { 155 NewShift->setIsExact(Sh0->isExact() && Sh1->isExact()); 156 } 157 } 158 159 Instruction *Ret = NewShift; 160 if (Trunc) { 161 Builder.Insert(NewShift); 162 Ret = CastInst::Create(Instruction::Trunc, NewShift, Sh0->getType()); 163 } 164 165 return Ret; 166 } 167 168 // If we have some pattern that leaves only some low bits set, and then performs 169 // left-shift of those bits, if none of the bits that are left after the final 170 // shift are modified by the mask, we can omit the mask. 171 // 172 // There are many variants to this pattern: 173 // a) (x & ((1 << MaskShAmt) - 1)) << ShiftShAmt 174 // b) (x & (~(-1 << MaskShAmt))) << ShiftShAmt 175 // c) (x & (-1 l>> MaskShAmt)) << ShiftShAmt 176 // d) (x & ((-1 << MaskShAmt) l>> MaskShAmt)) << ShiftShAmt 177 // e) ((x << MaskShAmt) l>> MaskShAmt) << ShiftShAmt 178 // f) ((x << MaskShAmt) a>> MaskShAmt) << ShiftShAmt 179 // All these patterns can be simplified to just: 180 // x << ShiftShAmt 181 // iff: 182 // a,b) (MaskShAmt+ShiftShAmt) u>= bitwidth(x) 183 // c,d,e,f) (ShiftShAmt-MaskShAmt) s>= 0 (i.e. ShiftShAmt u>= MaskShAmt) 184 static Instruction * 185 dropRedundantMaskingOfLeftShiftInput(BinaryOperator *OuterShift, 186 const SimplifyQuery &Q, 187 InstCombiner::BuilderTy &Builder) { 188 assert(OuterShift->getOpcode() == Instruction::BinaryOps::Shl && 189 "The input must be 'shl'!"); 190 191 Value *Masked, *ShiftShAmt; 192 match(OuterShift, 193 m_Shift(m_Value(Masked), m_ZExtOrSelf(m_Value(ShiftShAmt)))); 194 195 // *If* there is a truncation between an outer shift and a possibly-mask, 196 // then said truncation *must* be one-use, else we can't perform the fold. 197 Value *Trunc; 198 if (match(Masked, m_CombineAnd(m_Trunc(m_Value(Masked)), m_Value(Trunc))) && 199 !Trunc->hasOneUse()) 200 return nullptr; 201 202 Type *NarrowestTy = OuterShift->getType(); 203 Type *WidestTy = Masked->getType(); 204 bool HadTrunc = WidestTy != NarrowestTy; 205 206 // The mask must be computed in a type twice as wide to ensure 207 // that no bits are lost if the sum-of-shifts is wider than the base type. 208 Type *ExtendedTy = WidestTy->getExtendedType(); 209 210 Value *MaskShAmt; 211 212 // ((1 << MaskShAmt) - 1) 213 auto MaskA = m_Add(m_Shl(m_One(), m_Value(MaskShAmt)), m_AllOnes()); 214 // (~(-1 << maskNbits)) 215 auto MaskB = m_Xor(m_Shl(m_AllOnes(), m_Value(MaskShAmt)), m_AllOnes()); 216 // (-1 l>> MaskShAmt) 217 auto MaskC = m_LShr(m_AllOnes(), m_Value(MaskShAmt)); 218 // ((-1 << MaskShAmt) l>> MaskShAmt) 219 auto MaskD = 220 m_LShr(m_Shl(m_AllOnes(), m_Value(MaskShAmt)), m_Deferred(MaskShAmt)); 221 222 Value *X; 223 Constant *NewMask; 224 225 if (match(Masked, m_c_And(m_CombineOr(MaskA, MaskB), m_Value(X)))) { 226 // Peek through an optional zext of the shift amount. 227 match(MaskShAmt, m_ZExtOrSelf(m_Value(MaskShAmt))); 228 229 // Verify that it would be safe to try to add those two shift amounts. 230 if (!canTryToConstantAddTwoShiftAmounts(OuterShift, ShiftShAmt, Masked, 231 MaskShAmt)) 232 return nullptr; 233 234 // Can we simplify (MaskShAmt+ShiftShAmt) ? 235 auto *SumOfShAmts = dyn_cast_or_null<Constant>(SimplifyAddInst( 236 MaskShAmt, ShiftShAmt, /*IsNSW=*/false, /*IsNUW=*/false, Q)); 237 if (!SumOfShAmts) 238 return nullptr; // Did not simplify. 239 // In this pattern SumOfShAmts correlates with the number of low bits 240 // that shall remain in the root value (OuterShift). 241 242 // An extend of an undef value becomes zero because the high bits are never 243 // completely unknown. Replace the `undef` shift amounts with final 244 // shift bitwidth to ensure that the value remains undef when creating the 245 // subsequent shift op. 246 SumOfShAmts = Constant::replaceUndefsWith( 247 SumOfShAmts, ConstantInt::get(SumOfShAmts->getType()->getScalarType(), 248 ExtendedTy->getScalarSizeInBits())); 249 auto *ExtendedSumOfShAmts = ConstantExpr::getZExt(SumOfShAmts, ExtendedTy); 250 // And compute the mask as usual: ~(-1 << (SumOfShAmts)) 251 auto *ExtendedAllOnes = ConstantExpr::getAllOnesValue(ExtendedTy); 252 auto *ExtendedInvertedMask = 253 ConstantExpr::getShl(ExtendedAllOnes, ExtendedSumOfShAmts); 254 NewMask = ConstantExpr::getNot(ExtendedInvertedMask); 255 } else if (match(Masked, m_c_And(m_CombineOr(MaskC, MaskD), m_Value(X))) || 256 match(Masked, m_Shr(m_Shl(m_Value(X), m_Value(MaskShAmt)), 257 m_Deferred(MaskShAmt)))) { 258 // Peek through an optional zext of the shift amount. 259 match(MaskShAmt, m_ZExtOrSelf(m_Value(MaskShAmt))); 260 261 // Verify that it would be safe to try to add those two shift amounts. 262 if (!canTryToConstantAddTwoShiftAmounts(OuterShift, ShiftShAmt, Masked, 263 MaskShAmt)) 264 return nullptr; 265 266 // Can we simplify (ShiftShAmt-MaskShAmt) ? 267 auto *ShAmtsDiff = dyn_cast_or_null<Constant>(SimplifySubInst( 268 ShiftShAmt, MaskShAmt, /*IsNSW=*/false, /*IsNUW=*/false, Q)); 269 if (!ShAmtsDiff) 270 return nullptr; // Did not simplify. 271 // In this pattern ShAmtsDiff correlates with the number of high bits that 272 // shall be unset in the root value (OuterShift). 273 274 // An extend of an undef value becomes zero because the high bits are never 275 // completely unknown. Replace the `undef` shift amounts with negated 276 // bitwidth of innermost shift to ensure that the value remains undef when 277 // creating the subsequent shift op. 278 unsigned WidestTyBitWidth = WidestTy->getScalarSizeInBits(); 279 ShAmtsDiff = Constant::replaceUndefsWith( 280 ShAmtsDiff, ConstantInt::get(ShAmtsDiff->getType()->getScalarType(), 281 -WidestTyBitWidth)); 282 auto *ExtendedNumHighBitsToClear = ConstantExpr::getZExt( 283 ConstantExpr::getSub(ConstantInt::get(ShAmtsDiff->getType(), 284 WidestTyBitWidth, 285 /*isSigned=*/false), 286 ShAmtsDiff), 287 ExtendedTy); 288 // And compute the mask as usual: (-1 l>> (NumHighBitsToClear)) 289 auto *ExtendedAllOnes = ConstantExpr::getAllOnesValue(ExtendedTy); 290 NewMask = 291 ConstantExpr::getLShr(ExtendedAllOnes, ExtendedNumHighBitsToClear); 292 } else 293 return nullptr; // Don't know anything about this pattern. 294 295 NewMask = ConstantExpr::getTrunc(NewMask, NarrowestTy); 296 297 // Does this mask has any unset bits? If not then we can just not apply it. 298 bool NeedMask = !match(NewMask, m_AllOnes()); 299 300 // If we need to apply a mask, there are several more restrictions we have. 301 if (NeedMask) { 302 // The old masking instruction must go away. 303 if (!Masked->hasOneUse()) 304 return nullptr; 305 // The original "masking" instruction must not have been`ashr`. 306 if (match(Masked, m_AShr(m_Value(), m_Value()))) 307 return nullptr; 308 } 309 310 // If we need to apply truncation, let's do it first, since we can. 311 // We have already ensured that the old truncation will go away. 312 if (HadTrunc) 313 X = Builder.CreateTrunc(X, NarrowestTy); 314 315 // No 'NUW'/'NSW'! We no longer know that we won't shift-out non-0 bits. 316 // We didn't change the Type of this outermost shift, so we can just do it. 317 auto *NewShift = BinaryOperator::Create(OuterShift->getOpcode(), X, 318 OuterShift->getOperand(1)); 319 if (!NeedMask) 320 return NewShift; 321 322 Builder.Insert(NewShift); 323 return BinaryOperator::Create(Instruction::And, NewShift, NewMask); 324 } 325 326 /// If we have a shift-by-constant of a bitwise logic op that itself has a 327 /// shift-by-constant operand with identical opcode, we may be able to convert 328 /// that into 2 independent shifts followed by the logic op. This eliminates a 329 /// a use of an intermediate value (reduces dependency chain). 330 static Instruction *foldShiftOfShiftedLogic(BinaryOperator &I, 331 InstCombiner::BuilderTy &Builder) { 332 assert(I.isShift() && "Expected a shift as input"); 333 auto *LogicInst = dyn_cast<BinaryOperator>(I.getOperand(0)); 334 if (!LogicInst || !LogicInst->isBitwiseLogicOp() || !LogicInst->hasOneUse()) 335 return nullptr; 336 337 Constant *C0, *C1; 338 if (!match(I.getOperand(1), m_Constant(C1))) 339 return nullptr; 340 341 Instruction::BinaryOps ShiftOpcode = I.getOpcode(); 342 Type *Ty = I.getType(); 343 344 // Find a matching one-use shift by constant. The fold is not valid if the sum 345 // of the shift values equals or exceeds bitwidth. 346 // TODO: Remove the one-use check if the other logic operand (Y) is constant. 347 Value *X, *Y; 348 auto matchFirstShift = [&](Value *V) { 349 BinaryOperator *BO; 350 APInt Threshold(Ty->getScalarSizeInBits(), Ty->getScalarSizeInBits()); 351 return match(V, m_BinOp(BO)) && BO->getOpcode() == ShiftOpcode && 352 match(V, m_OneUse(m_Shift(m_Value(X), m_Constant(C0)))) && 353 match(ConstantExpr::getAdd(C0, C1), 354 m_SpecificInt_ICMP(ICmpInst::ICMP_ULT, Threshold)); 355 }; 356 357 // Logic ops are commutative, so check each operand for a match. 358 if (matchFirstShift(LogicInst->getOperand(0))) 359 Y = LogicInst->getOperand(1); 360 else if (matchFirstShift(LogicInst->getOperand(1))) 361 Y = LogicInst->getOperand(0); 362 else 363 return nullptr; 364 365 // shift (logic (shift X, C0), Y), C1 -> logic (shift X, C0+C1), (shift Y, C1) 366 Constant *ShiftSumC = ConstantExpr::getAdd(C0, C1); 367 Value *NewShift1 = Builder.CreateBinOp(ShiftOpcode, X, ShiftSumC); 368 Value *NewShift2 = Builder.CreateBinOp(ShiftOpcode, Y, I.getOperand(1)); 369 return BinaryOperator::Create(LogicInst->getOpcode(), NewShift1, NewShift2); 370 } 371 372 Instruction *InstCombinerImpl::commonShiftTransforms(BinaryOperator &I) { 373 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 374 assert(Op0->getType() == Op1->getType()); 375 376 // If the shift amount is a one-use `sext`, we can demote it to `zext`. 377 Value *Y; 378 if (match(Op1, m_OneUse(m_SExt(m_Value(Y))))) { 379 Value *NewExt = Builder.CreateZExt(Y, I.getType(), Op1->getName()); 380 return BinaryOperator::Create(I.getOpcode(), Op0, NewExt); 381 } 382 383 // See if we can fold away this shift. 384 if (SimplifyDemandedInstructionBits(I)) 385 return &I; 386 387 // Try to fold constant and into select arguments. 388 if (isa<Constant>(Op0)) 389 if (SelectInst *SI = dyn_cast<SelectInst>(Op1)) 390 if (Instruction *R = FoldOpIntoSelect(I, SI)) 391 return R; 392 393 if (Constant *CUI = dyn_cast<Constant>(Op1)) 394 if (Instruction *Res = FoldShiftByConstant(Op0, CUI, I)) 395 return Res; 396 397 if (auto *NewShift = cast_or_null<Instruction>( 398 reassociateShiftAmtsOfTwoSameDirectionShifts(&I, SQ))) 399 return NewShift; 400 401 // (C1 shift (A add C2)) -> (C1 shift C2) shift A) 402 // iff A and C2 are both positive. 403 Value *A; 404 Constant *C; 405 if (match(Op0, m_Constant()) && match(Op1, m_Add(m_Value(A), m_Constant(C)))) 406 if (isKnownNonNegative(A, DL, 0, &AC, &I, &DT) && 407 isKnownNonNegative(C, DL, 0, &AC, &I, &DT)) 408 return BinaryOperator::Create( 409 I.getOpcode(), Builder.CreateBinOp(I.getOpcode(), Op0, C), A); 410 411 // X shift (A srem C) -> X shift (A and (C - 1)) iff C is a power of 2. 412 // Because shifts by negative values (which could occur if A were negative) 413 // are undefined. 414 if (Op1->hasOneUse() && match(Op1, m_SRem(m_Value(A), m_Constant(C))) && 415 match(C, m_Power2())) { 416 // FIXME: Should this get moved into SimplifyDemandedBits by saying we don't 417 // demand the sign bit (and many others) here?? 418 Constant *Mask = ConstantExpr::getSub(C, ConstantInt::get(I.getType(), 1)); 419 Value *Rem = Builder.CreateAnd(A, Mask, Op1->getName()); 420 return replaceOperand(I, 1, Rem); 421 } 422 423 if (Instruction *Logic = foldShiftOfShiftedLogic(I, Builder)) 424 return Logic; 425 426 return nullptr; 427 } 428 429 /// Return true if we can simplify two logical (either left or right) shifts 430 /// that have constant shift amounts: OuterShift (InnerShift X, C1), C2. 431 static bool canEvaluateShiftedShift(unsigned OuterShAmt, bool IsOuterShl, 432 Instruction *InnerShift, 433 InstCombinerImpl &IC, Instruction *CxtI) { 434 assert(InnerShift->isLogicalShift() && "Unexpected instruction type"); 435 436 // We need constant scalar or constant splat shifts. 437 const APInt *InnerShiftConst; 438 if (!match(InnerShift->getOperand(1), m_APInt(InnerShiftConst))) 439 return false; 440 441 // Two logical shifts in the same direction: 442 // shl (shl X, C1), C2 --> shl X, C1 + C2 443 // lshr (lshr X, C1), C2 --> lshr X, C1 + C2 444 bool IsInnerShl = InnerShift->getOpcode() == Instruction::Shl; 445 if (IsInnerShl == IsOuterShl) 446 return true; 447 448 // Equal shift amounts in opposite directions become bitwise 'and': 449 // lshr (shl X, C), C --> and X, C' 450 // shl (lshr X, C), C --> and X, C' 451 if (*InnerShiftConst == OuterShAmt) 452 return true; 453 454 // If the 2nd shift is bigger than the 1st, we can fold: 455 // lshr (shl X, C1), C2 --> and (shl X, C1 - C2), C3 456 // shl (lshr X, C1), C2 --> and (lshr X, C1 - C2), C3 457 // but it isn't profitable unless we know the and'd out bits are already zero. 458 // Also, check that the inner shift is valid (less than the type width) or 459 // we'll crash trying to produce the bit mask for the 'and'. 460 unsigned TypeWidth = InnerShift->getType()->getScalarSizeInBits(); 461 if (InnerShiftConst->ugt(OuterShAmt) && InnerShiftConst->ult(TypeWidth)) { 462 unsigned InnerShAmt = InnerShiftConst->getZExtValue(); 463 unsigned MaskShift = 464 IsInnerShl ? TypeWidth - InnerShAmt : InnerShAmt - OuterShAmt; 465 APInt Mask = APInt::getLowBitsSet(TypeWidth, OuterShAmt) << MaskShift; 466 if (IC.MaskedValueIsZero(InnerShift->getOperand(0), Mask, 0, CxtI)) 467 return true; 468 } 469 470 return false; 471 } 472 473 /// See if we can compute the specified value, but shifted logically to the left 474 /// or right by some number of bits. This should return true if the expression 475 /// can be computed for the same cost as the current expression tree. This is 476 /// used to eliminate extraneous shifting from things like: 477 /// %C = shl i128 %A, 64 478 /// %D = shl i128 %B, 96 479 /// %E = or i128 %C, %D 480 /// %F = lshr i128 %E, 64 481 /// where the client will ask if E can be computed shifted right by 64-bits. If 482 /// this succeeds, getShiftedValue() will be called to produce the value. 483 static bool canEvaluateShifted(Value *V, unsigned NumBits, bool IsLeftShift, 484 InstCombinerImpl &IC, Instruction *CxtI) { 485 // We can always evaluate constants shifted. 486 if (isa<Constant>(V)) 487 return true; 488 489 Instruction *I = dyn_cast<Instruction>(V); 490 if (!I) return false; 491 492 // We can't mutate something that has multiple uses: doing so would 493 // require duplicating the instruction in general, which isn't profitable. 494 if (!I->hasOneUse()) return false; 495 496 switch (I->getOpcode()) { 497 default: return false; 498 case Instruction::And: 499 case Instruction::Or: 500 case Instruction::Xor: 501 // Bitwise operators can all arbitrarily be arbitrarily evaluated shifted. 502 return canEvaluateShifted(I->getOperand(0), NumBits, IsLeftShift, IC, I) && 503 canEvaluateShifted(I->getOperand(1), NumBits, IsLeftShift, IC, I); 504 505 case Instruction::Shl: 506 case Instruction::LShr: 507 return canEvaluateShiftedShift(NumBits, IsLeftShift, I, IC, CxtI); 508 509 case Instruction::Select: { 510 SelectInst *SI = cast<SelectInst>(I); 511 Value *TrueVal = SI->getTrueValue(); 512 Value *FalseVal = SI->getFalseValue(); 513 return canEvaluateShifted(TrueVal, NumBits, IsLeftShift, IC, SI) && 514 canEvaluateShifted(FalseVal, NumBits, IsLeftShift, IC, SI); 515 } 516 case Instruction::PHI: { 517 // We can change a phi if we can change all operands. Note that we never 518 // get into trouble with cyclic PHIs here because we only consider 519 // instructions with a single use. 520 PHINode *PN = cast<PHINode>(I); 521 for (Value *IncValue : PN->incoming_values()) 522 if (!canEvaluateShifted(IncValue, NumBits, IsLeftShift, IC, PN)) 523 return false; 524 return true; 525 } 526 } 527 } 528 529 /// Fold OuterShift (InnerShift X, C1), C2. 530 /// See canEvaluateShiftedShift() for the constraints on these instructions. 531 static Value *foldShiftedShift(BinaryOperator *InnerShift, unsigned OuterShAmt, 532 bool IsOuterShl, 533 InstCombiner::BuilderTy &Builder) { 534 bool IsInnerShl = InnerShift->getOpcode() == Instruction::Shl; 535 Type *ShType = InnerShift->getType(); 536 unsigned TypeWidth = ShType->getScalarSizeInBits(); 537 538 // We only accept shifts-by-a-constant in canEvaluateShifted(). 539 const APInt *C1; 540 match(InnerShift->getOperand(1), m_APInt(C1)); 541 unsigned InnerShAmt = C1->getZExtValue(); 542 543 // Change the shift amount and clear the appropriate IR flags. 544 auto NewInnerShift = [&](unsigned ShAmt) { 545 InnerShift->setOperand(1, ConstantInt::get(ShType, ShAmt)); 546 if (IsInnerShl) { 547 InnerShift->setHasNoUnsignedWrap(false); 548 InnerShift->setHasNoSignedWrap(false); 549 } else { 550 InnerShift->setIsExact(false); 551 } 552 return InnerShift; 553 }; 554 555 // Two logical shifts in the same direction: 556 // shl (shl X, C1), C2 --> shl X, C1 + C2 557 // lshr (lshr X, C1), C2 --> lshr X, C1 + C2 558 if (IsInnerShl == IsOuterShl) { 559 // If this is an oversized composite shift, then unsigned shifts get 0. 560 if (InnerShAmt + OuterShAmt >= TypeWidth) 561 return Constant::getNullValue(ShType); 562 563 return NewInnerShift(InnerShAmt + OuterShAmt); 564 } 565 566 // Equal shift amounts in opposite directions become bitwise 'and': 567 // lshr (shl X, C), C --> and X, C' 568 // shl (lshr X, C), C --> and X, C' 569 if (InnerShAmt == OuterShAmt) { 570 APInt Mask = IsInnerShl 571 ? APInt::getLowBitsSet(TypeWidth, TypeWidth - OuterShAmt) 572 : APInt::getHighBitsSet(TypeWidth, TypeWidth - OuterShAmt); 573 Value *And = Builder.CreateAnd(InnerShift->getOperand(0), 574 ConstantInt::get(ShType, Mask)); 575 if (auto *AndI = dyn_cast<Instruction>(And)) { 576 AndI->moveBefore(InnerShift); 577 AndI->takeName(InnerShift); 578 } 579 return And; 580 } 581 582 assert(InnerShAmt > OuterShAmt && 583 "Unexpected opposite direction logical shift pair"); 584 585 // In general, we would need an 'and' for this transform, but 586 // canEvaluateShiftedShift() guarantees that the masked-off bits are not used. 587 // lshr (shl X, C1), C2 --> shl X, C1 - C2 588 // shl (lshr X, C1), C2 --> lshr X, C1 - C2 589 return NewInnerShift(InnerShAmt - OuterShAmt); 590 } 591 592 /// When canEvaluateShifted() returns true for an expression, this function 593 /// inserts the new computation that produces the shifted value. 594 static Value *getShiftedValue(Value *V, unsigned NumBits, bool isLeftShift, 595 InstCombinerImpl &IC, const DataLayout &DL) { 596 // We can always evaluate constants shifted. 597 if (Constant *C = dyn_cast<Constant>(V)) { 598 if (isLeftShift) 599 return IC.Builder.CreateShl(C, NumBits); 600 else 601 return IC.Builder.CreateLShr(C, NumBits); 602 } 603 604 Instruction *I = cast<Instruction>(V); 605 IC.addToWorklist(I); 606 607 switch (I->getOpcode()) { 608 default: llvm_unreachable("Inconsistency with CanEvaluateShifted"); 609 case Instruction::And: 610 case Instruction::Or: 611 case Instruction::Xor: 612 // Bitwise operators can all arbitrarily be arbitrarily evaluated shifted. 613 I->setOperand( 614 0, getShiftedValue(I->getOperand(0), NumBits, isLeftShift, IC, DL)); 615 I->setOperand( 616 1, getShiftedValue(I->getOperand(1), NumBits, isLeftShift, IC, DL)); 617 return I; 618 619 case Instruction::Shl: 620 case Instruction::LShr: 621 return foldShiftedShift(cast<BinaryOperator>(I), NumBits, isLeftShift, 622 IC.Builder); 623 624 case Instruction::Select: 625 I->setOperand( 626 1, getShiftedValue(I->getOperand(1), NumBits, isLeftShift, IC, DL)); 627 I->setOperand( 628 2, getShiftedValue(I->getOperand(2), NumBits, isLeftShift, IC, DL)); 629 return I; 630 case Instruction::PHI: { 631 // We can change a phi if we can change all operands. Note that we never 632 // get into trouble with cyclic PHIs here because we only consider 633 // instructions with a single use. 634 PHINode *PN = cast<PHINode>(I); 635 for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) 636 PN->setIncomingValue(i, getShiftedValue(PN->getIncomingValue(i), NumBits, 637 isLeftShift, IC, DL)); 638 return PN; 639 } 640 } 641 } 642 643 // If this is a bitwise operator or add with a constant RHS we might be able 644 // to pull it through a shift. 645 static bool canShiftBinOpWithConstantRHS(BinaryOperator &Shift, 646 BinaryOperator *BO) { 647 switch (BO->getOpcode()) { 648 default: 649 return false; // Do not perform transform! 650 case Instruction::Add: 651 return Shift.getOpcode() == Instruction::Shl; 652 case Instruction::Or: 653 case Instruction::And: 654 return true; 655 case Instruction::Xor: 656 // Do not change a 'not' of logical shift because that would create a normal 657 // 'xor'. The 'not' is likely better for analysis, SCEV, and codegen. 658 return !(Shift.isLogicalShift() && match(BO, m_Not(m_Value()))); 659 } 660 } 661 662 Instruction *InstCombinerImpl::FoldShiftByConstant(Value *Op0, Constant *Op1, 663 BinaryOperator &I) { 664 const APInt *Op1C; 665 if (!match(Op1, m_APInt(Op1C))) 666 return nullptr; 667 668 // See if we can propagate this shift into the input, this covers the trivial 669 // cast of lshr(shl(x,c1),c2) as well as other more complex cases. 670 bool IsLeftShift = I.getOpcode() == Instruction::Shl; 671 if (I.getOpcode() != Instruction::AShr && 672 canEvaluateShifted(Op0, Op1C->getZExtValue(), IsLeftShift, *this, &I)) { 673 LLVM_DEBUG( 674 dbgs() << "ICE: GetShiftedValue propagating shift through expression" 675 " to eliminate shift:\n IN: " 676 << *Op0 << "\n SH: " << I << "\n"); 677 678 return replaceInstUsesWith( 679 I, getShiftedValue(Op0, Op1C->getZExtValue(), IsLeftShift, *this, DL)); 680 } 681 682 // See if we can simplify any instructions used by the instruction whose sole 683 // purpose is to compute bits we don't care about. 684 Type *Ty = I.getType(); 685 unsigned TypeBits = Ty->getScalarSizeInBits(); 686 assert(!Op1C->uge(TypeBits) && 687 "Shift over the type width should have been removed already"); 688 (void)TypeBits; 689 690 if (Instruction *FoldedShift = foldBinOpIntoSelectOrPhi(I)) 691 return FoldedShift; 692 693 if (!Op0->hasOneUse()) 694 return nullptr; 695 696 if (auto *Op0BO = dyn_cast<BinaryOperator>(Op0)) { 697 // If the operand is a bitwise operator with a constant RHS, and the 698 // shift is the only use, we can pull it out of the shift. 699 const APInt *Op0C; 700 if (match(Op0BO->getOperand(1), m_APInt(Op0C))) { 701 if (canShiftBinOpWithConstantRHS(I, Op0BO)) { 702 Constant *NewRHS = ConstantExpr::get( 703 I.getOpcode(), cast<Constant>(Op0BO->getOperand(1)), Op1); 704 705 Value *NewShift = 706 Builder.CreateBinOp(I.getOpcode(), Op0BO->getOperand(0), Op1); 707 NewShift->takeName(Op0BO); 708 709 return BinaryOperator::Create(Op0BO->getOpcode(), NewShift, NewRHS); 710 } 711 } 712 } 713 714 // If we have a select that conditionally executes some binary operator, 715 // see if we can pull it the select and operator through the shift. 716 // 717 // For example, turning: 718 // shl (select C, (add X, C1), X), C2 719 // Into: 720 // Y = shl X, C2 721 // select C, (add Y, C1 << C2), Y 722 Value *Cond; 723 BinaryOperator *TBO; 724 Value *FalseVal; 725 if (match(Op0, m_Select(m_Value(Cond), m_OneUse(m_BinOp(TBO)), 726 m_Value(FalseVal)))) { 727 const APInt *C; 728 if (!isa<Constant>(FalseVal) && TBO->getOperand(0) == FalseVal && 729 match(TBO->getOperand(1), m_APInt(C)) && 730 canShiftBinOpWithConstantRHS(I, TBO)) { 731 Constant *NewRHS = ConstantExpr::get( 732 I.getOpcode(), cast<Constant>(TBO->getOperand(1)), Op1); 733 734 Value *NewShift = Builder.CreateBinOp(I.getOpcode(), FalseVal, Op1); 735 Value *NewOp = Builder.CreateBinOp(TBO->getOpcode(), NewShift, NewRHS); 736 return SelectInst::Create(Cond, NewOp, NewShift); 737 } 738 } 739 740 BinaryOperator *FBO; 741 Value *TrueVal; 742 if (match(Op0, m_Select(m_Value(Cond), m_Value(TrueVal), 743 m_OneUse(m_BinOp(FBO))))) { 744 const APInt *C; 745 if (!isa<Constant>(TrueVal) && FBO->getOperand(0) == TrueVal && 746 match(FBO->getOperand(1), m_APInt(C)) && 747 canShiftBinOpWithConstantRHS(I, FBO)) { 748 Constant *NewRHS = ConstantExpr::get( 749 I.getOpcode(), cast<Constant>(FBO->getOperand(1)), Op1); 750 751 Value *NewShift = Builder.CreateBinOp(I.getOpcode(), TrueVal, Op1); 752 Value *NewOp = Builder.CreateBinOp(FBO->getOpcode(), NewShift, NewRHS); 753 return SelectInst::Create(Cond, NewShift, NewOp); 754 } 755 } 756 757 return nullptr; 758 } 759 760 Instruction *InstCombinerImpl::visitShl(BinaryOperator &I) { 761 const SimplifyQuery Q = SQ.getWithInstruction(&I); 762 763 if (Value *V = SimplifyShlInst(I.getOperand(0), I.getOperand(1), 764 I.hasNoSignedWrap(), I.hasNoUnsignedWrap(), Q)) 765 return replaceInstUsesWith(I, V); 766 767 if (Instruction *X = foldVectorBinop(I)) 768 return X; 769 770 if (Instruction *V = commonShiftTransforms(I)) 771 return V; 772 773 if (Instruction *V = dropRedundantMaskingOfLeftShiftInput(&I, Q, Builder)) 774 return V; 775 776 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 777 Type *Ty = I.getType(); 778 unsigned BitWidth = Ty->getScalarSizeInBits(); 779 780 const APInt *C; 781 if (match(Op1, m_APInt(C))) { 782 unsigned ShAmtC = C->getZExtValue(); 783 784 // shl (zext X), C --> zext (shl X, C) 785 // This is only valid if X would have zeros shifted out. 786 Value *X; 787 if (match(Op0, m_OneUse(m_ZExt(m_Value(X))))) { 788 unsigned SrcWidth = X->getType()->getScalarSizeInBits(); 789 if (ShAmtC < SrcWidth && 790 MaskedValueIsZero(X, APInt::getHighBitsSet(SrcWidth, ShAmtC), 0, &I)) 791 return new ZExtInst(Builder.CreateShl(X, ShAmtC), Ty); 792 } 793 794 // (X >> C) << C --> X & (-1 << C) 795 if (match(Op0, m_Shr(m_Value(X), m_Specific(Op1)))) { 796 APInt Mask(APInt::getHighBitsSet(BitWidth, BitWidth - ShAmtC)); 797 return BinaryOperator::CreateAnd(X, ConstantInt::get(Ty, Mask)); 798 } 799 800 const APInt *C1; 801 if (match(Op0, m_Exact(m_Shr(m_Value(X), m_APInt(C1)))) && 802 C1->ult(BitWidth)) { 803 unsigned ShrAmt = C1->getZExtValue(); 804 if (ShrAmt < ShAmtC) { 805 // If C1 < C: (X >>?,exact C1) << C --> X << (C - C1) 806 Constant *ShiftDiff = ConstantInt::get(Ty, ShAmtC - ShrAmt); 807 auto *NewShl = BinaryOperator::CreateShl(X, ShiftDiff); 808 NewShl->setHasNoUnsignedWrap(I.hasNoUnsignedWrap()); 809 NewShl->setHasNoSignedWrap(I.hasNoSignedWrap()); 810 return NewShl; 811 } 812 if (ShrAmt > ShAmtC) { 813 // If C1 > C: (X >>?exact C1) << C --> X >>?exact (C1 - C) 814 Constant *ShiftDiff = ConstantInt::get(Ty, ShrAmt - ShAmtC); 815 auto *NewShr = BinaryOperator::Create( 816 cast<BinaryOperator>(Op0)->getOpcode(), X, ShiftDiff); 817 NewShr->setIsExact(true); 818 return NewShr; 819 } 820 } 821 822 if (match(Op0, m_OneUse(m_Shr(m_Value(X), m_APInt(C1)))) && 823 C1->ult(BitWidth)) { 824 unsigned ShrAmt = C1->getZExtValue(); 825 if (ShrAmt < ShAmtC) { 826 // If C1 < C: (X >>? C1) << C --> (X << (C - C1)) & (-1 << C) 827 Constant *ShiftDiff = ConstantInt::get(Ty, ShAmtC - ShrAmt); 828 auto *NewShl = BinaryOperator::CreateShl(X, ShiftDiff); 829 NewShl->setHasNoUnsignedWrap(I.hasNoUnsignedWrap()); 830 NewShl->setHasNoSignedWrap(I.hasNoSignedWrap()); 831 Builder.Insert(NewShl); 832 APInt Mask(APInt::getHighBitsSet(BitWidth, BitWidth - ShAmtC)); 833 return BinaryOperator::CreateAnd(NewShl, ConstantInt::get(Ty, Mask)); 834 } 835 if (ShrAmt > ShAmtC) { 836 // If C1 > C: (X >>? C1) << C --> (X >>? (C1 - C)) & (-1 << C) 837 Constant *ShiftDiff = ConstantInt::get(Ty, ShrAmt - ShAmtC); 838 auto *OldShr = cast<BinaryOperator>(Op0); 839 auto *NewShr = 840 BinaryOperator::Create(OldShr->getOpcode(), X, ShiftDiff); 841 NewShr->setIsExact(OldShr->isExact()); 842 Builder.Insert(NewShr); 843 APInt Mask(APInt::getHighBitsSet(BitWidth, BitWidth - ShAmtC)); 844 return BinaryOperator::CreateAnd(NewShr, ConstantInt::get(Ty, Mask)); 845 } 846 } 847 848 // Similar to above, but look through an intermediate trunc instruction. 849 BinaryOperator *Shr; 850 if (match(Op0, m_OneUse(m_Trunc(m_OneUse(m_BinOp(Shr))))) && 851 match(Shr, m_Shr(m_Value(X), m_APInt(C1)))) { 852 // The larger shift direction survives through the transform. 853 unsigned ShrAmtC = C1->getZExtValue(); 854 unsigned ShDiff = ShrAmtC > ShAmtC ? ShrAmtC - ShAmtC : ShAmtC - ShrAmtC; 855 Constant *ShiftDiffC = ConstantInt::get(X->getType(), ShDiff); 856 auto ShiftOpc = ShrAmtC > ShAmtC ? Shr->getOpcode() : Instruction::Shl; 857 858 // If C1 > C: 859 // (trunc (X >> C1)) << C --> (trunc (X >> (C1 - C))) && (-1 << C) 860 // If C > C1: 861 // (trunc (X >> C1)) << C --> (trunc (X << (C - C1))) && (-1 << C) 862 Value *NewShift = Builder.CreateBinOp(ShiftOpc, X, ShiftDiffC, "sh.diff"); 863 Value *Trunc = Builder.CreateTrunc(NewShift, Ty, "tr.sh.diff"); 864 APInt Mask(APInt::getHighBitsSet(BitWidth, BitWidth - ShAmtC)); 865 return BinaryOperator::CreateAnd(Trunc, ConstantInt::get(Ty, Mask)); 866 } 867 868 if (match(Op0, m_Shl(m_Value(X), m_APInt(C1))) && C1->ult(BitWidth)) { 869 unsigned AmtSum = ShAmtC + C1->getZExtValue(); 870 // Oversized shifts are simplified to zero in InstSimplify. 871 if (AmtSum < BitWidth) 872 // (X << C1) << C2 --> X << (C1 + C2) 873 return BinaryOperator::CreateShl(X, ConstantInt::get(Ty, AmtSum)); 874 } 875 876 // If we have an opposite shift by the same amount, we may be able to 877 // reorder binops and shifts to eliminate math/logic. 878 auto isSuitableBinOpcode = [](Instruction::BinaryOps BinOpcode) { 879 switch (BinOpcode) { 880 default: 881 return false; 882 case Instruction::Add: 883 case Instruction::And: 884 case Instruction::Or: 885 case Instruction::Xor: 886 case Instruction::Sub: 887 // NOTE: Sub is not commutable and the tranforms below may not be valid 888 // when the shift-right is operand 1 (RHS) of the sub. 889 return true; 890 } 891 }; 892 BinaryOperator *Op0BO; 893 if (match(Op0, m_OneUse(m_BinOp(Op0BO))) && 894 isSuitableBinOpcode(Op0BO->getOpcode())) { 895 // Commute so shift-right is on LHS of the binop. 896 // (Y bop (X >> C)) << C -> ((X >> C) bop Y) << C 897 // (Y bop ((X >> C) & CC)) << C -> (((X >> C) & CC) bop Y) << C 898 Value *Shr = Op0BO->getOperand(0); 899 Value *Y = Op0BO->getOperand(1); 900 Value *X; 901 const APInt *CC; 902 if (Op0BO->isCommutative() && Y->hasOneUse() && 903 (match(Y, m_Shr(m_Value(), m_Specific(Op1))) || 904 match(Y, m_And(m_OneUse(m_Shr(m_Value(), m_Specific(Op1))), 905 m_APInt(CC))))) 906 std::swap(Shr, Y); 907 908 // ((X >> C) bop Y) << C -> (X bop (Y << C)) & (~0 << C) 909 if (match(Shr, m_OneUse(m_Shr(m_Value(X), m_Specific(Op1))))) { 910 // Y << C 911 Value *YS = Builder.CreateShl(Y, Op1, Op0BO->getName()); 912 // (X bop (Y << C)) 913 Value *B = 914 Builder.CreateBinOp(Op0BO->getOpcode(), X, YS, Shr->getName()); 915 unsigned Op1Val = C->getLimitedValue(BitWidth); 916 APInt Bits = APInt::getHighBitsSet(BitWidth, BitWidth - Op1Val); 917 Constant *Mask = ConstantInt::get(Ty, Bits); 918 return BinaryOperator::CreateAnd(B, Mask); 919 } 920 921 // (((X >> C) & CC) bop Y) << C -> (X & (CC << C)) bop (Y << C) 922 if (match(Shr, 923 m_OneUse(m_And(m_OneUse(m_Shr(m_Value(X), m_Specific(Op1))), 924 m_APInt(CC))))) { 925 // Y << C 926 Value *YS = Builder.CreateShl(Y, Op1, Op0BO->getName()); 927 // X & (CC << C) 928 Value *M = Builder.CreateAnd(X, ConstantInt::get(Ty, CC->shl(*C)), 929 X->getName() + ".mask"); 930 return BinaryOperator::Create(Op0BO->getOpcode(), M, YS); 931 } 932 } 933 934 // (C1 - X) << C --> (C1 << C) - (X << C) 935 if (match(Op0, m_OneUse(m_Sub(m_APInt(C1), m_Value(X))))) { 936 Constant *NewLHS = ConstantInt::get(Ty, C1->shl(*C)); 937 Value *NewShift = Builder.CreateShl(X, Op1); 938 return BinaryOperator::CreateSub(NewLHS, NewShift); 939 } 940 941 // If the shifted-out value is known-zero, then this is a NUW shift. 942 if (!I.hasNoUnsignedWrap() && 943 MaskedValueIsZero(Op0, APInt::getHighBitsSet(BitWidth, ShAmtC), 0, 944 &I)) { 945 I.setHasNoUnsignedWrap(); 946 return &I; 947 } 948 949 // If the shifted-out value is all signbits, then this is a NSW shift. 950 if (!I.hasNoSignedWrap() && ComputeNumSignBits(Op0, 0, &I) > ShAmtC) { 951 I.setHasNoSignedWrap(); 952 return &I; 953 } 954 } 955 956 // Transform (x >> y) << y to x & (-1 << y) 957 // Valid for any type of right-shift. 958 Value *X; 959 if (match(Op0, m_OneUse(m_Shr(m_Value(X), m_Specific(Op1))))) { 960 Constant *AllOnes = ConstantInt::getAllOnesValue(Ty); 961 Value *Mask = Builder.CreateShl(AllOnes, Op1); 962 return BinaryOperator::CreateAnd(Mask, X); 963 } 964 965 Constant *C1; 966 if (match(Op1, m_Constant(C1))) { 967 Constant *C2; 968 Value *X; 969 // (C2 << X) << C1 --> (C2 << C1) << X 970 if (match(Op0, m_OneUse(m_Shl(m_Constant(C2), m_Value(X))))) 971 return BinaryOperator::CreateShl(ConstantExpr::getShl(C2, C1), X); 972 973 // (X * C2) << C1 --> X * (C2 << C1) 974 if (match(Op0, m_Mul(m_Value(X), m_Constant(C2)))) 975 return BinaryOperator::CreateMul(X, ConstantExpr::getShl(C2, C1)); 976 977 // shl (zext i1 X), C1 --> select (X, 1 << C1, 0) 978 if (match(Op0, m_ZExt(m_Value(X))) && X->getType()->isIntOrIntVectorTy(1)) { 979 auto *NewC = ConstantExpr::getShl(ConstantInt::get(Ty, 1), C1); 980 return SelectInst::Create(X, NewC, ConstantInt::getNullValue(Ty)); 981 } 982 } 983 984 // (1 << (C - x)) -> ((1 << C) >> x) if C is bitwidth - 1 985 if (match(Op0, m_One()) && 986 match(Op1, m_Sub(m_SpecificInt(BitWidth - 1), m_Value(X)))) 987 return BinaryOperator::CreateLShr( 988 ConstantInt::get(Ty, APInt::getSignMask(BitWidth)), X); 989 990 return nullptr; 991 } 992 993 Instruction *InstCombinerImpl::visitLShr(BinaryOperator &I) { 994 if (Value *V = SimplifyLShrInst(I.getOperand(0), I.getOperand(1), I.isExact(), 995 SQ.getWithInstruction(&I))) 996 return replaceInstUsesWith(I, V); 997 998 if (Instruction *X = foldVectorBinop(I)) 999 return X; 1000 1001 if (Instruction *R = commonShiftTransforms(I)) 1002 return R; 1003 1004 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 1005 Type *Ty = I.getType(); 1006 const APInt *C; 1007 if (match(Op1, m_APInt(C))) { 1008 unsigned ShAmtC = C->getZExtValue(); 1009 unsigned BitWidth = Ty->getScalarSizeInBits(); 1010 auto *II = dyn_cast<IntrinsicInst>(Op0); 1011 if (II && isPowerOf2_32(BitWidth) && Log2_32(BitWidth) == ShAmtC && 1012 (II->getIntrinsicID() == Intrinsic::ctlz || 1013 II->getIntrinsicID() == Intrinsic::cttz || 1014 II->getIntrinsicID() == Intrinsic::ctpop)) { 1015 // ctlz.i32(x)>>5 --> zext(x == 0) 1016 // cttz.i32(x)>>5 --> zext(x == 0) 1017 // ctpop.i32(x)>>5 --> zext(x == -1) 1018 bool IsPop = II->getIntrinsicID() == Intrinsic::ctpop; 1019 Constant *RHS = ConstantInt::getSigned(Ty, IsPop ? -1 : 0); 1020 Value *Cmp = Builder.CreateICmpEQ(II->getArgOperand(0), RHS); 1021 return new ZExtInst(Cmp, Ty); 1022 } 1023 1024 Value *X; 1025 const APInt *C1; 1026 if (match(Op0, m_Shl(m_Value(X), m_APInt(C1))) && C1->ult(BitWidth)) { 1027 if (C1->ult(ShAmtC)) { 1028 unsigned ShlAmtC = C1->getZExtValue(); 1029 Constant *ShiftDiff = ConstantInt::get(Ty, ShAmtC - ShlAmtC); 1030 if (cast<BinaryOperator>(Op0)->hasNoUnsignedWrap()) { 1031 // (X <<nuw C1) >>u C --> X >>u (C - C1) 1032 auto *NewLShr = BinaryOperator::CreateLShr(X, ShiftDiff); 1033 NewLShr->setIsExact(I.isExact()); 1034 return NewLShr; 1035 } 1036 // (X << C1) >>u C --> (X >>u (C - C1)) & (-1 >> C) 1037 Value *NewLShr = Builder.CreateLShr(X, ShiftDiff, "", I.isExact()); 1038 APInt Mask(APInt::getLowBitsSet(BitWidth, BitWidth - ShAmtC)); 1039 return BinaryOperator::CreateAnd(NewLShr, ConstantInt::get(Ty, Mask)); 1040 } 1041 if (C1->ugt(ShAmtC)) { 1042 unsigned ShlAmtC = C1->getZExtValue(); 1043 Constant *ShiftDiff = ConstantInt::get(Ty, ShlAmtC - ShAmtC); 1044 if (cast<BinaryOperator>(Op0)->hasNoUnsignedWrap()) { 1045 // (X <<nuw C1) >>u C --> X <<nuw (C1 - C) 1046 auto *NewShl = BinaryOperator::CreateShl(X, ShiftDiff); 1047 NewShl->setHasNoUnsignedWrap(true); 1048 return NewShl; 1049 } 1050 // (X << C1) >>u C --> X << (C1 - C) & (-1 >> C) 1051 Value *NewShl = Builder.CreateShl(X, ShiftDiff); 1052 APInt Mask(APInt::getLowBitsSet(BitWidth, BitWidth - ShAmtC)); 1053 return BinaryOperator::CreateAnd(NewShl, ConstantInt::get(Ty, Mask)); 1054 } 1055 assert(*C1 == ShAmtC); 1056 // (X << C) >>u C --> X & (-1 >>u C) 1057 APInt Mask(APInt::getLowBitsSet(BitWidth, BitWidth - ShAmtC)); 1058 return BinaryOperator::CreateAnd(X, ConstantInt::get(Ty, Mask)); 1059 } 1060 1061 if (match(Op0, m_OneUse(m_ZExt(m_Value(X)))) && 1062 (!Ty->isIntegerTy() || shouldChangeType(Ty, X->getType()))) { 1063 assert(ShAmtC < X->getType()->getScalarSizeInBits() && 1064 "Big shift not simplified to zero?"); 1065 // lshr (zext iM X to iN), C --> zext (lshr X, C) to iN 1066 Value *NewLShr = Builder.CreateLShr(X, ShAmtC); 1067 return new ZExtInst(NewLShr, Ty); 1068 } 1069 1070 if (match(Op0, m_SExt(m_Value(X)))) { 1071 unsigned SrcTyBitWidth = X->getType()->getScalarSizeInBits(); 1072 // lshr (sext i1 X to iN), C --> select (X, -1 >> C, 0) 1073 if (SrcTyBitWidth == 1) { 1074 auto *NewC = ConstantInt::get( 1075 Ty, APInt::getLowBitsSet(BitWidth, BitWidth - ShAmtC)); 1076 return SelectInst::Create(X, NewC, ConstantInt::getNullValue(Ty)); 1077 } 1078 1079 if ((!Ty->isIntegerTy() || shouldChangeType(Ty, X->getType())) && 1080 Op0->hasOneUse()) { 1081 // Are we moving the sign bit to the low bit and widening with high 1082 // zeros? lshr (sext iM X to iN), N-1 --> zext (lshr X, M-1) to iN 1083 if (ShAmtC == BitWidth - 1) { 1084 Value *NewLShr = Builder.CreateLShr(X, SrcTyBitWidth - 1); 1085 return new ZExtInst(NewLShr, Ty); 1086 } 1087 1088 // lshr (sext iM X to iN), N-M --> zext (ashr X, min(N-M, M-1)) to iN 1089 if (ShAmtC == BitWidth - SrcTyBitWidth) { 1090 // The new shift amount can't be more than the narrow source type. 1091 unsigned NewShAmt = std::min(ShAmtC, SrcTyBitWidth - 1); 1092 Value *AShr = Builder.CreateAShr(X, NewShAmt); 1093 return new ZExtInst(AShr, Ty); 1094 } 1095 } 1096 } 1097 1098 Value *Y; 1099 if (ShAmtC == BitWidth - 1) { 1100 // lshr i32 or(X,-X), 31 --> zext (X != 0) 1101 if (match(Op0, m_OneUse(m_c_Or(m_Neg(m_Value(X)), m_Deferred(X))))) 1102 return new ZExtInst(Builder.CreateIsNotNull(X), Ty); 1103 1104 // lshr i32 (X -nsw Y), 31 --> zext (X < Y) 1105 if (match(Op0, m_OneUse(m_NSWSub(m_Value(X), m_Value(Y))))) 1106 return new ZExtInst(Builder.CreateICmpSLT(X, Y), Ty); 1107 1108 // Check if a number is negative and odd: 1109 // lshr i32 (srem X, 2), 31 --> and (X >> 31), X 1110 if (match(Op0, m_OneUse(m_SRem(m_Value(X), m_SpecificInt(2))))) { 1111 Value *Signbit = Builder.CreateLShr(X, ShAmtC); 1112 return BinaryOperator::CreateAnd(Signbit, X); 1113 } 1114 } 1115 1116 // (X >>u C1) >>u C --> X >>u (C1 + C) 1117 if (match(Op0, m_LShr(m_Value(X), m_APInt(C1)))) { 1118 // Oversized shifts are simplified to zero in InstSimplify. 1119 unsigned AmtSum = ShAmtC + C1->getZExtValue(); 1120 if (AmtSum < BitWidth) 1121 return BinaryOperator::CreateLShr(X, ConstantInt::get(Ty, AmtSum)); 1122 } 1123 1124 Instruction *TruncSrc; 1125 if (match(Op0, m_OneUse(m_Trunc(m_Instruction(TruncSrc)))) && 1126 match(TruncSrc, m_LShr(m_Value(X), m_APInt(C1)))) { 1127 unsigned SrcWidth = X->getType()->getScalarSizeInBits(); 1128 unsigned AmtSum = ShAmtC + C1->getZExtValue(); 1129 1130 // If the combined shift fits in the source width: 1131 // (trunc (X >>u C1)) >>u C --> and (trunc (X >>u (C1 + C)), MaskC 1132 // 1133 // If the first shift covers the number of bits truncated, then the 1134 // mask instruction is eliminated (and so the use check is relaxed). 1135 if (AmtSum < SrcWidth && 1136 (TruncSrc->hasOneUse() || C1->uge(SrcWidth - BitWidth))) { 1137 Value *SumShift = Builder.CreateLShr(X, AmtSum, "sum.shift"); 1138 Value *Trunc = Builder.CreateTrunc(SumShift, Ty, I.getName()); 1139 1140 // If the first shift does not cover the number of bits truncated, then 1141 // we require a mask to get rid of high bits in the result. 1142 APInt MaskC = APInt::getAllOnes(BitWidth).lshr(ShAmtC); 1143 return BinaryOperator::CreateAnd(Trunc, ConstantInt::get(Ty, MaskC)); 1144 } 1145 } 1146 1147 // Look for a "splat" mul pattern - it replicates bits across each half of 1148 // a value, so a right shift is just a mask of the low bits: 1149 // lshr i32 (mul nuw X, Pow2+1), 16 --> and X, Pow2-1 1150 // TODO: Generalize to allow more than just half-width shifts? 1151 const APInt *MulC; 1152 if (match(Op0, m_NUWMul(m_Value(X), m_APInt(MulC))) && 1153 ShAmtC * 2 == BitWidth && (*MulC - 1).isPowerOf2() && 1154 MulC->logBase2() == ShAmtC) 1155 return BinaryOperator::CreateAnd(X, ConstantInt::get(Ty, *MulC - 2)); 1156 1157 // If the shifted-out value is known-zero, then this is an exact shift. 1158 if (!I.isExact() && 1159 MaskedValueIsZero(Op0, APInt::getLowBitsSet(BitWidth, ShAmtC), 0, &I)) { 1160 I.setIsExact(); 1161 return &I; 1162 } 1163 } 1164 1165 // Transform (x << y) >> y to x & (-1 >> y) 1166 Value *X; 1167 if (match(Op0, m_OneUse(m_Shl(m_Value(X), m_Specific(Op1))))) { 1168 Constant *AllOnes = ConstantInt::getAllOnesValue(Ty); 1169 Value *Mask = Builder.CreateLShr(AllOnes, Op1); 1170 return BinaryOperator::CreateAnd(Mask, X); 1171 } 1172 1173 return nullptr; 1174 } 1175 1176 Instruction * 1177 InstCombinerImpl::foldVariableSignZeroExtensionOfVariableHighBitExtract( 1178 BinaryOperator &OldAShr) { 1179 assert(OldAShr.getOpcode() == Instruction::AShr && 1180 "Must be called with arithmetic right-shift instruction only."); 1181 1182 // Check that constant C is a splat of the element-wise bitwidth of V. 1183 auto BitWidthSplat = [](Constant *C, Value *V) { 1184 return match( 1185 C, m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_EQ, 1186 APInt(C->getType()->getScalarSizeInBits(), 1187 V->getType()->getScalarSizeInBits()))); 1188 }; 1189 1190 // It should look like variable-length sign-extension on the outside: 1191 // (Val << (bitwidth(Val)-Nbits)) a>> (bitwidth(Val)-Nbits) 1192 Value *NBits; 1193 Instruction *MaybeTrunc; 1194 Constant *C1, *C2; 1195 if (!match(&OldAShr, 1196 m_AShr(m_Shl(m_Instruction(MaybeTrunc), 1197 m_ZExtOrSelf(m_Sub(m_Constant(C1), 1198 m_ZExtOrSelf(m_Value(NBits))))), 1199 m_ZExtOrSelf(m_Sub(m_Constant(C2), 1200 m_ZExtOrSelf(m_Deferred(NBits)))))) || 1201 !BitWidthSplat(C1, &OldAShr) || !BitWidthSplat(C2, &OldAShr)) 1202 return nullptr; 1203 1204 // There may or may not be a truncation after outer two shifts. 1205 Instruction *HighBitExtract; 1206 match(MaybeTrunc, m_TruncOrSelf(m_Instruction(HighBitExtract))); 1207 bool HadTrunc = MaybeTrunc != HighBitExtract; 1208 1209 // And finally, the innermost part of the pattern must be a right-shift. 1210 Value *X, *NumLowBitsToSkip; 1211 if (!match(HighBitExtract, m_Shr(m_Value(X), m_Value(NumLowBitsToSkip)))) 1212 return nullptr; 1213 1214 // Said right-shift must extract high NBits bits - C0 must be it's bitwidth. 1215 Constant *C0; 1216 if (!match(NumLowBitsToSkip, 1217 m_ZExtOrSelf( 1218 m_Sub(m_Constant(C0), m_ZExtOrSelf(m_Specific(NBits))))) || 1219 !BitWidthSplat(C0, HighBitExtract)) 1220 return nullptr; 1221 1222 // Since the NBits is identical for all shifts, if the outermost and 1223 // innermost shifts are identical, then outermost shifts are redundant. 1224 // If we had truncation, do keep it though. 1225 if (HighBitExtract->getOpcode() == OldAShr.getOpcode()) 1226 return replaceInstUsesWith(OldAShr, MaybeTrunc); 1227 1228 // Else, if there was a truncation, then we need to ensure that one 1229 // instruction will go away. 1230 if (HadTrunc && !match(&OldAShr, m_c_BinOp(m_OneUse(m_Value()), m_Value()))) 1231 return nullptr; 1232 1233 // Finally, bypass two innermost shifts, and perform the outermost shift on 1234 // the operands of the innermost shift. 1235 Instruction *NewAShr = 1236 BinaryOperator::Create(OldAShr.getOpcode(), X, NumLowBitsToSkip); 1237 NewAShr->copyIRFlags(HighBitExtract); // We can preserve 'exact'-ness. 1238 if (!HadTrunc) 1239 return NewAShr; 1240 1241 Builder.Insert(NewAShr); 1242 return TruncInst::CreateTruncOrBitCast(NewAShr, OldAShr.getType()); 1243 } 1244 1245 Instruction *InstCombinerImpl::visitAShr(BinaryOperator &I) { 1246 if (Value *V = SimplifyAShrInst(I.getOperand(0), I.getOperand(1), I.isExact(), 1247 SQ.getWithInstruction(&I))) 1248 return replaceInstUsesWith(I, V); 1249 1250 if (Instruction *X = foldVectorBinop(I)) 1251 return X; 1252 1253 if (Instruction *R = commonShiftTransforms(I)) 1254 return R; 1255 1256 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 1257 Type *Ty = I.getType(); 1258 unsigned BitWidth = Ty->getScalarSizeInBits(); 1259 const APInt *ShAmtAPInt; 1260 if (match(Op1, m_APInt(ShAmtAPInt)) && ShAmtAPInt->ult(BitWidth)) { 1261 unsigned ShAmt = ShAmtAPInt->getZExtValue(); 1262 1263 // If the shift amount equals the difference in width of the destination 1264 // and source scalar types: 1265 // ashr (shl (zext X), C), C --> sext X 1266 Value *X; 1267 if (match(Op0, m_Shl(m_ZExt(m_Value(X)), m_Specific(Op1))) && 1268 ShAmt == BitWidth - X->getType()->getScalarSizeInBits()) 1269 return new SExtInst(X, Ty); 1270 1271 // We can't handle (X << C1) >>s C2. It shifts arbitrary bits in. However, 1272 // we can handle (X <<nsw C1) >>s C2 since it only shifts in sign bits. 1273 const APInt *ShOp1; 1274 if (match(Op0, m_NSWShl(m_Value(X), m_APInt(ShOp1))) && 1275 ShOp1->ult(BitWidth)) { 1276 unsigned ShlAmt = ShOp1->getZExtValue(); 1277 if (ShlAmt < ShAmt) { 1278 // (X <<nsw C1) >>s C2 --> X >>s (C2 - C1) 1279 Constant *ShiftDiff = ConstantInt::get(Ty, ShAmt - ShlAmt); 1280 auto *NewAShr = BinaryOperator::CreateAShr(X, ShiftDiff); 1281 NewAShr->setIsExact(I.isExact()); 1282 return NewAShr; 1283 } 1284 if (ShlAmt > ShAmt) { 1285 // (X <<nsw C1) >>s C2 --> X <<nsw (C1 - C2) 1286 Constant *ShiftDiff = ConstantInt::get(Ty, ShlAmt - ShAmt); 1287 auto *NewShl = BinaryOperator::Create(Instruction::Shl, X, ShiftDiff); 1288 NewShl->setHasNoSignedWrap(true); 1289 return NewShl; 1290 } 1291 } 1292 1293 if (match(Op0, m_AShr(m_Value(X), m_APInt(ShOp1))) && 1294 ShOp1->ult(BitWidth)) { 1295 unsigned AmtSum = ShAmt + ShOp1->getZExtValue(); 1296 // Oversized arithmetic shifts replicate the sign bit. 1297 AmtSum = std::min(AmtSum, BitWidth - 1); 1298 // (X >>s C1) >>s C2 --> X >>s (C1 + C2) 1299 return BinaryOperator::CreateAShr(X, ConstantInt::get(Ty, AmtSum)); 1300 } 1301 1302 if (match(Op0, m_OneUse(m_SExt(m_Value(X)))) && 1303 (Ty->isVectorTy() || shouldChangeType(Ty, X->getType()))) { 1304 // ashr (sext X), C --> sext (ashr X, C') 1305 Type *SrcTy = X->getType(); 1306 ShAmt = std::min(ShAmt, SrcTy->getScalarSizeInBits() - 1); 1307 Value *NewSh = Builder.CreateAShr(X, ConstantInt::get(SrcTy, ShAmt)); 1308 return new SExtInst(NewSh, Ty); 1309 } 1310 1311 if (ShAmt == BitWidth - 1) { 1312 // ashr i32 or(X,-X), 31 --> sext (X != 0) 1313 if (match(Op0, m_OneUse(m_c_Or(m_Neg(m_Value(X)), m_Deferred(X))))) 1314 return new SExtInst(Builder.CreateIsNotNull(X), Ty); 1315 1316 // ashr i32 (X -nsw Y), 31 --> sext (X < Y) 1317 Value *Y; 1318 if (match(Op0, m_OneUse(m_NSWSub(m_Value(X), m_Value(Y))))) 1319 return new SExtInst(Builder.CreateICmpSLT(X, Y), Ty); 1320 } 1321 1322 // If the shifted-out value is known-zero, then this is an exact shift. 1323 if (!I.isExact() && 1324 MaskedValueIsZero(Op0, APInt::getLowBitsSet(BitWidth, ShAmt), 0, &I)) { 1325 I.setIsExact(); 1326 return &I; 1327 } 1328 } 1329 1330 // Prefer `-(x & 1)` over `(x << (bitwidth(x)-1)) a>> (bitwidth(x)-1)` 1331 // as the pattern to splat the lowest bit. 1332 // FIXME: iff X is already masked, we don't need the one-use check. 1333 Value *X; 1334 if (match(Op1, m_SpecificIntAllowUndef(BitWidth - 1)) && 1335 match(Op0, m_OneUse(m_Shl(m_Value(X), 1336 m_SpecificIntAllowUndef(BitWidth - 1))))) { 1337 Constant *Mask = ConstantInt::get(Ty, 1); 1338 // Retain the knowledge about the ignored lanes. 1339 Mask = Constant::mergeUndefsWith( 1340 Constant::mergeUndefsWith(Mask, cast<Constant>(Op1)), 1341 cast<Constant>(cast<Instruction>(Op0)->getOperand(1))); 1342 X = Builder.CreateAnd(X, Mask); 1343 return BinaryOperator::CreateNeg(X); 1344 } 1345 1346 if (Instruction *R = foldVariableSignZeroExtensionOfVariableHighBitExtract(I)) 1347 return R; 1348 1349 // See if we can turn a signed shr into an unsigned shr. 1350 if (MaskedValueIsZero(Op0, APInt::getSignMask(BitWidth), 0, &I)) 1351 return BinaryOperator::CreateLShr(Op0, Op1); 1352 1353 // ashr (xor %x, -1), %y --> xor (ashr %x, %y), -1 1354 if (match(Op0, m_OneUse(m_Not(m_Value(X))))) { 1355 // Note that we must drop 'exact'-ness of the shift! 1356 // Note that we can't keep undef's in -1 vector constant! 1357 auto *NewAShr = Builder.CreateAShr(X, Op1, Op0->getName() + ".not"); 1358 return BinaryOperator::CreateNot(NewAShr); 1359 } 1360 1361 return nullptr; 1362 } 1363