xref: /llvm-project-15.0.7/lld/ELF/Symbols.cpp (revision 5fedf7f4)
1 //===- Symbols.cpp --------------------------------------------------------===//
2 //
3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4 // See https://llvm.org/LICENSE.txt for license information.
5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6 //
7 //===----------------------------------------------------------------------===//
8 
9 #include "Symbols.h"
10 #include "InputFiles.h"
11 #include "InputSection.h"
12 #include "OutputSections.h"
13 #include "SyntheticSections.h"
14 #include "Target.h"
15 #include "Writer.h"
16 #include "lld/Common/ErrorHandler.h"
17 #include "lld/Common/Strings.h"
18 #include "llvm/ADT/STLExtras.h"
19 #include "llvm/Support/Path.h"
20 #include <cstring>
21 
22 using namespace llvm;
23 using namespace llvm::object;
24 using namespace llvm::ELF;
25 
26 namespace lld {
27 // Returns a symbol for an error message.
28 static std::string demangle(StringRef symName) {
29   if (elf::config->demangle)
30     return demangleItanium(symName);
31   return std::string(symName);
32 }
33 
34 std::string toString(const elf::Symbol &sym) {
35   StringRef name = sym.getName();
36   std::string ret = demangle(name);
37 
38   // If sym has a non-default version, its name may have been truncated at '@'
39   // by Symbol::parseSymbolVersion(). Add the trailing part. This check is safe
40   // because every symbol name ends with '\0'.
41   if (name.data()[name.size()] == '@')
42     ret += name.data() + name.size();
43   return ret;
44 }
45 
46 std::string toELFString(const Archive::Symbol &b) {
47   return demangle(b.getName());
48 }
49 
50 namespace elf {
51 Defined *ElfSym::bss;
52 Defined *ElfSym::etext1;
53 Defined *ElfSym::etext2;
54 Defined *ElfSym::edata1;
55 Defined *ElfSym::edata2;
56 Defined *ElfSym::end1;
57 Defined *ElfSym::end2;
58 Defined *ElfSym::globalOffsetTable;
59 Defined *ElfSym::mipsGp;
60 Defined *ElfSym::mipsGpDisp;
61 Defined *ElfSym::mipsLocalGp;
62 Defined *ElfSym::relaIpltStart;
63 Defined *ElfSym::relaIpltEnd;
64 Defined *ElfSym::riscvGlobalPointer;
65 Defined *ElfSym::tlsModuleBase;
66 DenseMap<const Symbol *, const InputFile *> backwardReferences;
67 
68 static uint64_t getSymVA(const Symbol &sym, int64_t &addend) {
69   switch (sym.kind()) {
70   case Symbol::DefinedKind: {
71     auto &d = cast<Defined>(sym);
72     SectionBase *isec = d.section;
73 
74     // This is an absolute symbol.
75     if (!isec)
76       return d.value;
77 
78     assert(isec != &InputSection::discarded);
79     isec = isec->repl;
80 
81     uint64_t offset = d.value;
82 
83     // An object in an SHF_MERGE section might be referenced via a
84     // section symbol (as a hack for reducing the number of local
85     // symbols).
86     // Depending on the addend, the reference via a section symbol
87     // refers to a different object in the merge section.
88     // Since the objects in the merge section are not necessarily
89     // contiguous in the output, the addend can thus affect the final
90     // VA in a non-linear way.
91     // To make this work, we incorporate the addend into the section
92     // offset (and zero out the addend for later processing) so that
93     // we find the right object in the section.
94     if (d.isSection()) {
95       offset += addend;
96       addend = 0;
97     }
98 
99     // In the typical case, this is actually very simple and boils
100     // down to adding together 3 numbers:
101     // 1. The address of the output section.
102     // 2. The offset of the input section within the output section.
103     // 3. The offset within the input section (this addition happens
104     //    inside InputSection::getOffset).
105     //
106     // If you understand the data structures involved with this next
107     // line (and how they get built), then you have a pretty good
108     // understanding of the linker.
109     uint64_t va = isec->getVA(offset);
110 
111     // MIPS relocatable files can mix regular and microMIPS code.
112     // Linker needs to distinguish such code. To do so microMIPS
113     // symbols has the `STO_MIPS_MICROMIPS` flag in the `st_other`
114     // field. Unfortunately, the `MIPS::relocate()` method has
115     // a symbol value only. To pass type of the symbol (regular/microMIPS)
116     // to that routine as well as other places where we write
117     // a symbol value as-is (.dynamic section, `Elf_Ehdr::e_entry`
118     // field etc) do the same trick as compiler uses to mark microMIPS
119     // for CPU - set the less-significant bit.
120     if (config->emachine == EM_MIPS && isMicroMips() &&
121         ((sym.stOther & STO_MIPS_MICROMIPS) || sym.needsPltAddr))
122       va |= 1;
123 
124     if (d.isTls() && !config->relocatable) {
125       // Use the address of the TLS segment's first section rather than the
126       // segment's address, because segment addresses aren't initialized until
127       // after sections are finalized. (e.g. Measuring the size of .rela.dyn
128       // for Android relocation packing requires knowing TLS symbol addresses
129       // during section finalization.)
130       if (!Out::tlsPhdr || !Out::tlsPhdr->firstSec)
131         fatal(toString(d.file) +
132               " has an STT_TLS symbol but doesn't have an SHF_TLS section");
133       return va - Out::tlsPhdr->firstSec->addr;
134     }
135     return va;
136   }
137   case Symbol::SharedKind:
138   case Symbol::UndefinedKind:
139     return 0;
140   case Symbol::LazyArchiveKind:
141   case Symbol::LazyObjectKind:
142     assert(sym.isUsedInRegularObj && "lazy symbol reached writer");
143     return 0;
144   case Symbol::CommonKind:
145     llvm_unreachable("common symbol reached writer");
146   case Symbol::PlaceholderKind:
147     llvm_unreachable("placeholder symbol reached writer");
148   }
149   llvm_unreachable("invalid symbol kind");
150 }
151 
152 uint64_t Symbol::getVA(int64_t addend) const {
153   uint64_t outVA = getSymVA(*this, addend);
154   return outVA + addend;
155 }
156 
157 uint64_t Symbol::getGotVA() const {
158   if (gotInIgot)
159     return in.igotPlt->getVA() + getGotPltOffset();
160   return in.got->getVA() + getGotOffset();
161 }
162 
163 uint64_t Symbol::getGotOffset() const { return gotIndex * config->wordsize; }
164 
165 uint64_t Symbol::getGotPltVA() const {
166   if (isInIplt)
167     return in.igotPlt->getVA() + getGotPltOffset();
168   return in.gotPlt->getVA() + getGotPltOffset();
169 }
170 
171 uint64_t Symbol::getGotPltOffset() const {
172   if (isInIplt)
173     return pltIndex * config->wordsize;
174   return (pltIndex + target->gotPltHeaderEntriesNum) * config->wordsize;
175 }
176 
177 uint64_t Symbol::getPltVA() const {
178   uint64_t outVA = isInIplt
179                        ? in.iplt->getVA() + pltIndex * target->ipltEntrySize
180                        : in.plt->getVA() + in.plt->headerSize +
181                              pltIndex * target->pltEntrySize;
182 
183   // While linking microMIPS code PLT code are always microMIPS
184   // code. Set the less-significant bit to track that fact.
185   // See detailed comment in the `getSymVA` function.
186   if (config->emachine == EM_MIPS && isMicroMips())
187     outVA |= 1;
188   return outVA;
189 }
190 
191 uint64_t Symbol::getSize() const {
192   if (const auto *dr = dyn_cast<Defined>(this))
193     return dr->size;
194   return cast<SharedSymbol>(this)->size;
195 }
196 
197 OutputSection *Symbol::getOutputSection() const {
198   if (auto *s = dyn_cast<Defined>(this)) {
199     if (auto *sec = s->section)
200       return sec->repl->getOutputSection();
201     return nullptr;
202   }
203   return nullptr;
204 }
205 
206 // If a symbol name contains '@', the characters after that is
207 // a symbol version name. This function parses that.
208 void Symbol::parseSymbolVersion() {
209   StringRef s = getName();
210   size_t pos = s.find('@');
211   if (pos == 0 || pos == StringRef::npos)
212     return;
213   StringRef verstr = s.substr(pos + 1);
214   if (verstr.empty())
215     return;
216 
217   // Truncate the symbol name so that it doesn't include the version string.
218   nameSize = pos;
219 
220   // If this is not in this DSO, it is not a definition.
221   if (!isDefined())
222     return;
223 
224   // '@@' in a symbol name means the default version.
225   // It is usually the most recent one.
226   bool isDefault = (verstr[0] == '@');
227   if (isDefault)
228     verstr = verstr.substr(1);
229 
230   for (const VersionDefinition &ver : namedVersionDefs()) {
231     if (ver.name != verstr)
232       continue;
233 
234     if (isDefault)
235       versionId = ver.id;
236     else
237       versionId = ver.id | VERSYM_HIDDEN;
238     return;
239   }
240 
241   // It is an error if the specified version is not defined.
242   // Usually version script is not provided when linking executable,
243   // but we may still want to override a versioned symbol from DSO,
244   // so we do not report error in this case. We also do not error
245   // if the symbol has a local version as it won't be in the dynamic
246   // symbol table.
247   if (config->shared && versionId != VER_NDX_LOCAL)
248     error(toString(file) + ": symbol " + s + " has undefined version " +
249           verstr);
250 }
251 
252 void Symbol::fetch() const {
253   if (auto *sym = dyn_cast<LazyArchive>(this)) {
254     cast<ArchiveFile>(sym->file)->fetch(sym->sym);
255     return;
256   }
257 
258   if (auto *sym = dyn_cast<LazyObject>(this)) {
259     dyn_cast<LazyObjFile>(sym->file)->fetch();
260     return;
261   }
262 
263   llvm_unreachable("Symbol::fetch() is called on a non-lazy symbol");
264 }
265 
266 MemoryBufferRef LazyArchive::getMemberBuffer() {
267   Archive::Child c =
268       CHECK(sym.getMember(),
269             "could not get the member for symbol " + toELFString(sym));
270 
271   return CHECK(c.getMemoryBufferRef(),
272                "could not get the buffer for the member defining symbol " +
273                    toELFString(sym));
274 }
275 
276 uint8_t Symbol::computeBinding() const {
277   if (config->relocatable)
278     return binding;
279   if ((visibility != STV_DEFAULT && visibility != STV_PROTECTED) ||
280       (versionId == VER_NDX_LOCAL && isDefined()))
281     return STB_LOCAL;
282   if (!config->gnuUnique && binding == STB_GNU_UNIQUE)
283     return STB_GLOBAL;
284   return binding;
285 }
286 
287 bool Symbol::includeInDynsym() const {
288   if (!config->hasDynSymTab)
289     return false;
290   if (computeBinding() == STB_LOCAL)
291     return false;
292   if (!isDefined() && !isCommon())
293     // This should unconditionally return true, unfortunately glibc -static-pie
294     // expects undefined weak symbols not to exist in .dynsym, e.g.
295     // __pthread_mutex_lock reference in _dl_add_to_namespace_list,
296     // __pthread_initialize_minimal reference in csu/libc-start.c.
297     return !(config->noDynamicLinker && isUndefWeak());
298 
299   return exportDynamic || inDynamicList;
300 }
301 
302 // Print out a log message for --trace-symbol.
303 void printTraceSymbol(const Symbol *sym) {
304   std::string s;
305   if (sym->isUndefined())
306     s = ": reference to ";
307   else if (sym->isLazy())
308     s = ": lazy definition of ";
309   else if (sym->isShared())
310     s = ": shared definition of ";
311   else if (sym->isCommon())
312     s = ": common definition of ";
313   else
314     s = ": definition of ";
315 
316   message(toString(sym->file) + s + sym->getName());
317 }
318 
319 void maybeWarnUnorderableSymbol(const Symbol *sym) {
320   if (!config->warnSymbolOrdering)
321     return;
322 
323   // If UnresolvedPolicy::Ignore is used, no "undefined symbol" error/warning
324   // is emitted. It makes sense to not warn on undefined symbols.
325   //
326   // Note, ld.bfd --symbol-ordering-file= does not warn on undefined symbols,
327   // but we don't have to be compatible here.
328   if (sym->isUndefined() &&
329       config->unresolvedSymbols == UnresolvedPolicy::Ignore)
330     return;
331 
332   const InputFile *file = sym->file;
333   auto *d = dyn_cast<Defined>(sym);
334 
335   auto report = [&](StringRef s) { warn(toString(file) + s + sym->getName()); };
336 
337   if (sym->isUndefined())
338     report(": unable to order undefined symbol: ");
339   else if (sym->isShared())
340     report(": unable to order shared symbol: ");
341   else if (d && !d->section)
342     report(": unable to order absolute symbol: ");
343   else if (d && isa<OutputSection>(d->section))
344     report(": unable to order synthetic symbol: ");
345   else if (d && !d->section->repl->isLive())
346     report(": unable to order discarded symbol: ");
347 }
348 
349 // Returns true if a symbol can be replaced at load-time by a symbol
350 // with the same name defined in other ELF executable or DSO.
351 bool computeIsPreemptible(const Symbol &sym) {
352   assert(!sym.isLocal());
353 
354   // Only symbols with default visibility that appear in dynsym can be
355   // preempted. Symbols with protected visibility cannot be preempted.
356   if (!sym.includeInDynsym() || sym.visibility != STV_DEFAULT)
357     return false;
358 
359   // At this point copy relocations have not been created yet, so any
360   // symbol that is not defined locally is preemptible.
361   if (!sym.isDefined())
362     return true;
363 
364   if (!config->shared)
365     return false;
366 
367   // If the dynamic list is present, it specifies preemptable symbols in a DSO.
368   if (config->hasDynamicList)
369     return sym.inDynamicList;
370 
371   // -Bsymbolic means that definitions are not preempted.
372   if (config->bsymbolic || (config->bsymbolicFunctions && sym.isFunc()))
373     return false;
374   return true;
375 }
376 
377 void reportBackrefs() {
378   for (auto &it : backwardReferences) {
379     const Symbol &sym = *it.first;
380     warn("backward reference detected: " + sym.getName() + " in " +
381          toString(it.second) + " refers to " + toString(sym.file));
382   }
383 }
384 
385 static uint8_t getMinVisibility(uint8_t va, uint8_t vb) {
386   if (va == STV_DEFAULT)
387     return vb;
388   if (vb == STV_DEFAULT)
389     return va;
390   return std::min(va, vb);
391 }
392 
393 // Merge symbol properties.
394 //
395 // When we have many symbols of the same name, we choose one of them,
396 // and that's the result of symbol resolution. However, symbols that
397 // were not chosen still affect some symbol properties.
398 void Symbol::mergeProperties(const Symbol &other) {
399   if (other.exportDynamic)
400     exportDynamic = true;
401   if (other.isUsedInRegularObj)
402     isUsedInRegularObj = true;
403 
404   // DSO symbols do not affect visibility in the output.
405   if (!other.isShared())
406     visibility = getMinVisibility(visibility, other.visibility);
407 }
408 
409 void Symbol::resolve(const Symbol &other) {
410   mergeProperties(other);
411 
412   if (isPlaceholder()) {
413     replace(other);
414     return;
415   }
416 
417   switch (other.kind()) {
418   case Symbol::UndefinedKind:
419     resolveUndefined(cast<Undefined>(other));
420     break;
421   case Symbol::CommonKind:
422     resolveCommon(cast<CommonSymbol>(other));
423     break;
424   case Symbol::DefinedKind:
425     resolveDefined(cast<Defined>(other));
426     break;
427   case Symbol::LazyArchiveKind:
428     resolveLazy(cast<LazyArchive>(other));
429     break;
430   case Symbol::LazyObjectKind:
431     resolveLazy(cast<LazyObject>(other));
432     break;
433   case Symbol::SharedKind:
434     resolveShared(cast<SharedSymbol>(other));
435     break;
436   case Symbol::PlaceholderKind:
437     llvm_unreachable("bad symbol kind");
438   }
439 }
440 
441 void Symbol::resolveUndefined(const Undefined &other) {
442   // An undefined symbol with non default visibility must be satisfied
443   // in the same DSO.
444   //
445   // If this is a non-weak defined symbol in a discarded section, override the
446   // existing undefined symbol for better error message later.
447   if ((isShared() && other.visibility != STV_DEFAULT) ||
448       (isUndefined() && other.binding != STB_WEAK && other.discardedSecIdx)) {
449     replace(other);
450     return;
451   }
452 
453   if (traced)
454     printTraceSymbol(&other);
455 
456   if (isLazy()) {
457     // An undefined weak will not fetch archive members. See comment on Lazy in
458     // Symbols.h for the details.
459     if (other.binding == STB_WEAK) {
460       binding = STB_WEAK;
461       type = other.type;
462       return;
463     }
464 
465     // Do extra check for --warn-backrefs.
466     //
467     // --warn-backrefs is an option to prevent an undefined reference from
468     // fetching an archive member written earlier in the command line. It can be
469     // used to keep compatibility with GNU linkers to some degree.
470     // I'll explain the feature and why you may find it useful in this comment.
471     //
472     // lld's symbol resolution semantics is more relaxed than traditional Unix
473     // linkers. For example,
474     //
475     //   ld.lld foo.a bar.o
476     //
477     // succeeds even if bar.o contains an undefined symbol that has to be
478     // resolved by some object file in foo.a. Traditional Unix linkers don't
479     // allow this kind of backward reference, as they visit each file only once
480     // from left to right in the command line while resolving all undefined
481     // symbols at the moment of visiting.
482     //
483     // In the above case, since there's no undefined symbol when a linker visits
484     // foo.a, no files are pulled out from foo.a, and because the linker forgets
485     // about foo.a after visiting, it can't resolve undefined symbols in bar.o
486     // that could have been resolved otherwise.
487     //
488     // That lld accepts more relaxed form means that (besides it'd make more
489     // sense) you can accidentally write a command line or a build file that
490     // works only with lld, even if you have a plan to distribute it to wider
491     // users who may be using GNU linkers. With --warn-backrefs, you can detect
492     // a library order that doesn't work with other Unix linkers.
493     //
494     // The option is also useful to detect cyclic dependencies between static
495     // archives. Again, lld accepts
496     //
497     //   ld.lld foo.a bar.a
498     //
499     // even if foo.a and bar.a depend on each other. With --warn-backrefs, it is
500     // handled as an error.
501     //
502     // Here is how the option works. We assign a group ID to each file. A file
503     // with a smaller group ID can pull out object files from an archive file
504     // with an equal or greater group ID. Otherwise, it is a reverse dependency
505     // and an error.
506     //
507     // A file outside --{start,end}-group gets a fresh ID when instantiated. All
508     // files within the same --{start,end}-group get the same group ID. E.g.
509     //
510     //   ld.lld A B --start-group C D --end-group E
511     //
512     // A forms group 0. B form group 1. C and D (including their member object
513     // files) form group 2. E forms group 3. I think that you can see how this
514     // group assignment rule simulates the traditional linker's semantics.
515     bool backref = config->warnBackrefs && other.file &&
516                    file->groupId < other.file->groupId;
517     fetch();
518 
519     // We don't report backward references to weak symbols as they can be
520     // overridden later.
521     //
522     // A traditional linker does not error for -ldef1 -lref -ldef2 (linking
523     // sandwich), where def2 may or may not be the same as def1. We don't want
524     // to warn for this case, so dismiss the warning if we see a subsequent lazy
525     // definition.
526     if (backref && !isWeak())
527       backwardReferences.try_emplace(this, other.file);
528     return;
529   }
530 
531   // Undefined symbols in a SharedFile do not change the binding.
532   if (dyn_cast_or_null<SharedFile>(other.file))
533     return;
534 
535   if (isUndefined() || isShared()) {
536     // The binding will be weak if there is at least one reference and all are
537     // weak. The binding has one opportunity to change to weak: if the first
538     // reference is weak.
539     if (other.binding != STB_WEAK || !referenced)
540       binding = other.binding;
541   }
542 }
543 
544 // Using .symver foo,foo@@VER unfortunately creates two symbols: foo and
545 // foo@@VER. We want to effectively ignore foo, so give precedence to
546 // foo@@VER.
547 // FIXME: If users can transition to using
548 // .symver foo,foo@@@VER
549 // we can delete this hack.
550 static int compareVersion(StringRef a, StringRef b) {
551   bool x = a.contains("@@");
552   bool y = b.contains("@@");
553   if (!x && y)
554     return 1;
555   if (x && !y)
556     return -1;
557   return 0;
558 }
559 
560 // Compare two symbols. Return 1 if the new symbol should win, -1 if
561 // the new symbol should lose, or 0 if there is a conflict.
562 int Symbol::compare(const Symbol *other) const {
563   assert(other->isDefined() || other->isCommon());
564 
565   if (!isDefined() && !isCommon())
566     return 1;
567 
568   if (int cmp = compareVersion(getName(), other->getName()))
569     return cmp;
570 
571   if (other->isWeak())
572     return -1;
573 
574   if (isWeak())
575     return 1;
576 
577   if (isCommon() && other->isCommon()) {
578     if (config->warnCommon)
579       warn("multiple common of " + getName());
580     return 0;
581   }
582 
583   if (isCommon()) {
584     if (config->warnCommon)
585       warn("common " + getName() + " is overridden");
586     return 1;
587   }
588 
589   if (other->isCommon()) {
590     if (config->warnCommon)
591       warn("common " + getName() + " is overridden");
592     return -1;
593   }
594 
595   auto *oldSym = cast<Defined>(this);
596   auto *newSym = cast<Defined>(other);
597 
598   if (dyn_cast_or_null<BitcodeFile>(other->file))
599     return 0;
600 
601   if (!oldSym->section && !newSym->section && oldSym->value == newSym->value &&
602       newSym->binding == STB_GLOBAL)
603     return -1;
604 
605   return 0;
606 }
607 
608 static void reportDuplicate(Symbol *sym, InputFile *newFile,
609                             InputSectionBase *errSec, uint64_t errOffset) {
610   if (config->allowMultipleDefinition)
611     return;
612 
613   Defined *d = cast<Defined>(sym);
614   if (!d->section || !errSec) {
615     error("duplicate symbol: " + toString(*sym) + "\n>>> defined in " +
616           toString(sym->file) + "\n>>> defined in " + toString(newFile));
617     return;
618   }
619 
620   // Construct and print an error message in the form of:
621   //
622   //   ld.lld: error: duplicate symbol: foo
623   //   >>> defined at bar.c:30
624   //   >>>            bar.o (/home/alice/src/bar.o)
625   //   >>> defined at baz.c:563
626   //   >>>            baz.o in archive libbaz.a
627   auto *sec1 = cast<InputSectionBase>(d->section);
628   std::string src1 = sec1->getSrcMsg(*sym, d->value);
629   std::string obj1 = sec1->getObjMsg(d->value);
630   std::string src2 = errSec->getSrcMsg(*sym, errOffset);
631   std::string obj2 = errSec->getObjMsg(errOffset);
632 
633   std::string msg = "duplicate symbol: " + toString(*sym) + "\n>>> defined at ";
634   if (!src1.empty())
635     msg += src1 + "\n>>>            ";
636   msg += obj1 + "\n>>> defined at ";
637   if (!src2.empty())
638     msg += src2 + "\n>>>            ";
639   msg += obj2;
640   error(msg);
641 }
642 
643 void Symbol::resolveCommon(const CommonSymbol &other) {
644   int cmp = compare(&other);
645   if (cmp < 0)
646     return;
647 
648   if (cmp > 0) {
649     if (auto *s = dyn_cast<SharedSymbol>(this)) {
650       // Increase st_size if the shared symbol has a larger st_size. The shared
651       // symbol may be created from common symbols. The fact that some object
652       // files were linked into a shared object first should not change the
653       // regular rule that picks the largest st_size.
654       uint64_t size = s->size;
655       replace(other);
656       if (size > cast<CommonSymbol>(this)->size)
657         cast<CommonSymbol>(this)->size = size;
658     } else {
659       replace(other);
660     }
661     return;
662   }
663 
664   CommonSymbol *oldSym = cast<CommonSymbol>(this);
665 
666   oldSym->alignment = std::max(oldSym->alignment, other.alignment);
667   if (oldSym->size < other.size) {
668     oldSym->file = other.file;
669     oldSym->size = other.size;
670   }
671 }
672 
673 void Symbol::resolveDefined(const Defined &other) {
674   int cmp = compare(&other);
675   if (cmp > 0)
676     replace(other);
677   else if (cmp == 0)
678     reportDuplicate(this, other.file,
679                     dyn_cast_or_null<InputSectionBase>(other.section),
680                     other.value);
681 }
682 
683 template <class LazyT> void Symbol::resolveLazy(const LazyT &other) {
684   if (!isUndefined()) {
685     // See the comment in resolveUndefined().
686     if (isDefined())
687       backwardReferences.erase(this);
688     return;
689   }
690 
691   // An undefined weak will not fetch archive members. See comment on Lazy in
692   // Symbols.h for the details.
693   if (isWeak()) {
694     uint8_t ty = type;
695     replace(other);
696     type = ty;
697     binding = STB_WEAK;
698     return;
699   }
700 
701   other.fetch();
702 }
703 
704 void Symbol::resolveShared(const SharedSymbol &other) {
705   if (isCommon()) {
706     // See the comment in resolveCommon() above.
707     if (other.size > cast<CommonSymbol>(this)->size)
708       cast<CommonSymbol>(this)->size = other.size;
709     return;
710   }
711   if (visibility == STV_DEFAULT && (isUndefined() || isLazy())) {
712     // An undefined symbol with non default visibility must be satisfied
713     // in the same DSO.
714     uint8_t bind = binding;
715     replace(other);
716     binding = bind;
717   }
718 }
719 
720 } // namespace elf
721 } // namespace lld
722