1 //===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 // 10 // This file implements extra semantic analysis beyond what is enforced 11 // by the C type system. 12 // 13 //===----------------------------------------------------------------------===// 14 15 #include "clang/Sema/SemaInternal.h" 16 #include "clang/AST/ASTContext.h" 17 #include "clang/AST/CharUnits.h" 18 #include "clang/AST/DeclCXX.h" 19 #include "clang/AST/DeclObjC.h" 20 #include "clang/AST/EvaluatedExprVisitor.h" 21 #include "clang/AST/Expr.h" 22 #include "clang/AST/ExprCXX.h" 23 #include "clang/AST/ExprObjC.h" 24 #include "clang/AST/StmtCXX.h" 25 #include "clang/AST/StmtObjC.h" 26 #include "clang/Analysis/Analyses/FormatString.h" 27 #include "clang/Basic/CharInfo.h" 28 #include "clang/Basic/TargetBuiltins.h" 29 #include "clang/Basic/TargetInfo.h" 30 #include "clang/Lex/Preprocessor.h" 31 #include "clang/Sema/Initialization.h" 32 #include "clang/Sema/Lookup.h" 33 #include "clang/Sema/ScopeInfo.h" 34 #include "clang/Sema/Sema.h" 35 #include "llvm/ADT/STLExtras.h" 36 #include "llvm/ADT/SmallBitVector.h" 37 #include "llvm/ADT/SmallString.h" 38 #include "llvm/Support/ConvertUTF.h" 39 #include "llvm/Support/raw_ostream.h" 40 #include <limits> 41 using namespace clang; 42 using namespace sema; 43 44 SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 45 unsigned ByteNo) const { 46 return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 47 PP.getLangOpts(), PP.getTargetInfo()); 48 } 49 50 /// Checks that a call expression's argument count is the desired number. 51 /// This is useful when doing custom type-checking. Returns true on error. 52 static bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 53 unsigned argCount = call->getNumArgs(); 54 if (argCount == desiredArgCount) return false; 55 56 if (argCount < desiredArgCount) 57 return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 58 << 0 /*function call*/ << desiredArgCount << argCount 59 << call->getSourceRange(); 60 61 // Highlight all the excess arguments. 62 SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 63 call->getArg(argCount - 1)->getLocEnd()); 64 65 return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 66 << 0 /*function call*/ << desiredArgCount << argCount 67 << call->getArg(1)->getSourceRange(); 68 } 69 70 /// Check that the first argument to __builtin_annotation is an integer 71 /// and the second argument is a non-wide string literal. 72 static bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) { 73 if (checkArgCount(S, TheCall, 2)) 74 return true; 75 76 // First argument should be an integer. 77 Expr *ValArg = TheCall->getArg(0); 78 QualType Ty = ValArg->getType(); 79 if (!Ty->isIntegerType()) { 80 S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg) 81 << ValArg->getSourceRange(); 82 return true; 83 } 84 85 // Second argument should be a constant string. 86 Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts(); 87 StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg); 88 if (!Literal || !Literal->isAscii()) { 89 S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg) 90 << StrArg->getSourceRange(); 91 return true; 92 } 93 94 TheCall->setType(Ty); 95 return false; 96 } 97 98 /// Check that the argument to __builtin_addressof is a glvalue, and set the 99 /// result type to the corresponding pointer type. 100 static bool SemaBuiltinAddressof(Sema &S, CallExpr *TheCall) { 101 if (checkArgCount(S, TheCall, 1)) 102 return true; 103 104 ExprResult Arg(S.Owned(TheCall->getArg(0))); 105 QualType ResultType = S.CheckAddressOfOperand(Arg, TheCall->getLocStart()); 106 if (ResultType.isNull()) 107 return true; 108 109 TheCall->setArg(0, Arg.take()); 110 TheCall->setType(ResultType); 111 return false; 112 } 113 114 ExprResult 115 Sema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 116 ExprResult TheCallResult(Owned(TheCall)); 117 118 // Find out if any arguments are required to be integer constant expressions. 119 unsigned ICEArguments = 0; 120 ASTContext::GetBuiltinTypeError Error; 121 Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 122 if (Error != ASTContext::GE_None) 123 ICEArguments = 0; // Don't diagnose previously diagnosed errors. 124 125 // If any arguments are required to be ICE's, check and diagnose. 126 for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 127 // Skip arguments not required to be ICE's. 128 if ((ICEArguments & (1 << ArgNo)) == 0) continue; 129 130 llvm::APSInt Result; 131 if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 132 return true; 133 ICEArguments &= ~(1 << ArgNo); 134 } 135 136 switch (BuiltinID) { 137 case Builtin::BI__builtin___CFStringMakeConstantString: 138 assert(TheCall->getNumArgs() == 1 && 139 "Wrong # arguments to builtin CFStringMakeConstantString"); 140 if (CheckObjCString(TheCall->getArg(0))) 141 return ExprError(); 142 break; 143 case Builtin::BI__builtin_stdarg_start: 144 case Builtin::BI__builtin_va_start: 145 if (SemaBuiltinVAStart(TheCall)) 146 return ExprError(); 147 break; 148 case Builtin::BI__builtin_isgreater: 149 case Builtin::BI__builtin_isgreaterequal: 150 case Builtin::BI__builtin_isless: 151 case Builtin::BI__builtin_islessequal: 152 case Builtin::BI__builtin_islessgreater: 153 case Builtin::BI__builtin_isunordered: 154 if (SemaBuiltinUnorderedCompare(TheCall)) 155 return ExprError(); 156 break; 157 case Builtin::BI__builtin_fpclassify: 158 if (SemaBuiltinFPClassification(TheCall, 6)) 159 return ExprError(); 160 break; 161 case Builtin::BI__builtin_isfinite: 162 case Builtin::BI__builtin_isinf: 163 case Builtin::BI__builtin_isinf_sign: 164 case Builtin::BI__builtin_isnan: 165 case Builtin::BI__builtin_isnormal: 166 if (SemaBuiltinFPClassification(TheCall, 1)) 167 return ExprError(); 168 break; 169 case Builtin::BI__builtin_shufflevector: 170 return SemaBuiltinShuffleVector(TheCall); 171 // TheCall will be freed by the smart pointer here, but that's fine, since 172 // SemaBuiltinShuffleVector guts it, but then doesn't release it. 173 case Builtin::BI__builtin_prefetch: 174 if (SemaBuiltinPrefetch(TheCall)) 175 return ExprError(); 176 break; 177 case Builtin::BI__builtin_object_size: 178 if (SemaBuiltinObjectSize(TheCall)) 179 return ExprError(); 180 break; 181 case Builtin::BI__builtin_longjmp: 182 if (SemaBuiltinLongjmp(TheCall)) 183 return ExprError(); 184 break; 185 186 case Builtin::BI__builtin_classify_type: 187 if (checkArgCount(*this, TheCall, 1)) return true; 188 TheCall->setType(Context.IntTy); 189 break; 190 case Builtin::BI__builtin_constant_p: 191 if (checkArgCount(*this, TheCall, 1)) return true; 192 TheCall->setType(Context.IntTy); 193 break; 194 case Builtin::BI__sync_fetch_and_add: 195 case Builtin::BI__sync_fetch_and_add_1: 196 case Builtin::BI__sync_fetch_and_add_2: 197 case Builtin::BI__sync_fetch_and_add_4: 198 case Builtin::BI__sync_fetch_and_add_8: 199 case Builtin::BI__sync_fetch_and_add_16: 200 case Builtin::BI__sync_fetch_and_sub: 201 case Builtin::BI__sync_fetch_and_sub_1: 202 case Builtin::BI__sync_fetch_and_sub_2: 203 case Builtin::BI__sync_fetch_and_sub_4: 204 case Builtin::BI__sync_fetch_and_sub_8: 205 case Builtin::BI__sync_fetch_and_sub_16: 206 case Builtin::BI__sync_fetch_and_or: 207 case Builtin::BI__sync_fetch_and_or_1: 208 case Builtin::BI__sync_fetch_and_or_2: 209 case Builtin::BI__sync_fetch_and_or_4: 210 case Builtin::BI__sync_fetch_and_or_8: 211 case Builtin::BI__sync_fetch_and_or_16: 212 case Builtin::BI__sync_fetch_and_and: 213 case Builtin::BI__sync_fetch_and_and_1: 214 case Builtin::BI__sync_fetch_and_and_2: 215 case Builtin::BI__sync_fetch_and_and_4: 216 case Builtin::BI__sync_fetch_and_and_8: 217 case Builtin::BI__sync_fetch_and_and_16: 218 case Builtin::BI__sync_fetch_and_xor: 219 case Builtin::BI__sync_fetch_and_xor_1: 220 case Builtin::BI__sync_fetch_and_xor_2: 221 case Builtin::BI__sync_fetch_and_xor_4: 222 case Builtin::BI__sync_fetch_and_xor_8: 223 case Builtin::BI__sync_fetch_and_xor_16: 224 case Builtin::BI__sync_add_and_fetch: 225 case Builtin::BI__sync_add_and_fetch_1: 226 case Builtin::BI__sync_add_and_fetch_2: 227 case Builtin::BI__sync_add_and_fetch_4: 228 case Builtin::BI__sync_add_and_fetch_8: 229 case Builtin::BI__sync_add_and_fetch_16: 230 case Builtin::BI__sync_sub_and_fetch: 231 case Builtin::BI__sync_sub_and_fetch_1: 232 case Builtin::BI__sync_sub_and_fetch_2: 233 case Builtin::BI__sync_sub_and_fetch_4: 234 case Builtin::BI__sync_sub_and_fetch_8: 235 case Builtin::BI__sync_sub_and_fetch_16: 236 case Builtin::BI__sync_and_and_fetch: 237 case Builtin::BI__sync_and_and_fetch_1: 238 case Builtin::BI__sync_and_and_fetch_2: 239 case Builtin::BI__sync_and_and_fetch_4: 240 case Builtin::BI__sync_and_and_fetch_8: 241 case Builtin::BI__sync_and_and_fetch_16: 242 case Builtin::BI__sync_or_and_fetch: 243 case Builtin::BI__sync_or_and_fetch_1: 244 case Builtin::BI__sync_or_and_fetch_2: 245 case Builtin::BI__sync_or_and_fetch_4: 246 case Builtin::BI__sync_or_and_fetch_8: 247 case Builtin::BI__sync_or_and_fetch_16: 248 case Builtin::BI__sync_xor_and_fetch: 249 case Builtin::BI__sync_xor_and_fetch_1: 250 case Builtin::BI__sync_xor_and_fetch_2: 251 case Builtin::BI__sync_xor_and_fetch_4: 252 case Builtin::BI__sync_xor_and_fetch_8: 253 case Builtin::BI__sync_xor_and_fetch_16: 254 case Builtin::BI__sync_val_compare_and_swap: 255 case Builtin::BI__sync_val_compare_and_swap_1: 256 case Builtin::BI__sync_val_compare_and_swap_2: 257 case Builtin::BI__sync_val_compare_and_swap_4: 258 case Builtin::BI__sync_val_compare_and_swap_8: 259 case Builtin::BI__sync_val_compare_and_swap_16: 260 case Builtin::BI__sync_bool_compare_and_swap: 261 case Builtin::BI__sync_bool_compare_and_swap_1: 262 case Builtin::BI__sync_bool_compare_and_swap_2: 263 case Builtin::BI__sync_bool_compare_and_swap_4: 264 case Builtin::BI__sync_bool_compare_and_swap_8: 265 case Builtin::BI__sync_bool_compare_and_swap_16: 266 case Builtin::BI__sync_lock_test_and_set: 267 case Builtin::BI__sync_lock_test_and_set_1: 268 case Builtin::BI__sync_lock_test_and_set_2: 269 case Builtin::BI__sync_lock_test_and_set_4: 270 case Builtin::BI__sync_lock_test_and_set_8: 271 case Builtin::BI__sync_lock_test_and_set_16: 272 case Builtin::BI__sync_lock_release: 273 case Builtin::BI__sync_lock_release_1: 274 case Builtin::BI__sync_lock_release_2: 275 case Builtin::BI__sync_lock_release_4: 276 case Builtin::BI__sync_lock_release_8: 277 case Builtin::BI__sync_lock_release_16: 278 case Builtin::BI__sync_swap: 279 case Builtin::BI__sync_swap_1: 280 case Builtin::BI__sync_swap_2: 281 case Builtin::BI__sync_swap_4: 282 case Builtin::BI__sync_swap_8: 283 case Builtin::BI__sync_swap_16: 284 return SemaBuiltinAtomicOverloaded(TheCallResult); 285 #define BUILTIN(ID, TYPE, ATTRS) 286 #define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \ 287 case Builtin::BI##ID: \ 288 return SemaAtomicOpsOverloaded(TheCallResult, AtomicExpr::AO##ID); 289 #include "clang/Basic/Builtins.def" 290 case Builtin::BI__builtin_annotation: 291 if (SemaBuiltinAnnotation(*this, TheCall)) 292 return ExprError(); 293 break; 294 case Builtin::BI__builtin_addressof: 295 if (SemaBuiltinAddressof(*this, TheCall)) 296 return ExprError(); 297 break; 298 } 299 300 // Since the target specific builtins for each arch overlap, only check those 301 // of the arch we are compiling for. 302 if (BuiltinID >= Builtin::FirstTSBuiltin) { 303 switch (Context.getTargetInfo().getTriple().getArch()) { 304 case llvm::Triple::arm: 305 case llvm::Triple::thumb: 306 if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 307 return ExprError(); 308 break; 309 case llvm::Triple::aarch64: 310 if (CheckAArch64BuiltinFunctionCall(BuiltinID, TheCall)) 311 return ExprError(); 312 break; 313 case llvm::Triple::mips: 314 case llvm::Triple::mipsel: 315 case llvm::Triple::mips64: 316 case llvm::Triple::mips64el: 317 if (CheckMipsBuiltinFunctionCall(BuiltinID, TheCall)) 318 return ExprError(); 319 break; 320 default: 321 break; 322 } 323 } 324 325 return TheCallResult; 326 } 327 328 // Get the valid immediate range for the specified NEON type code. 329 static unsigned RFT(unsigned t, bool shift = false) { 330 NeonTypeFlags Type(t); 331 int IsQuad = Type.isQuad(); 332 switch (Type.getEltType()) { 333 case NeonTypeFlags::Int8: 334 case NeonTypeFlags::Poly8: 335 return shift ? 7 : (8 << IsQuad) - 1; 336 case NeonTypeFlags::Int16: 337 case NeonTypeFlags::Poly16: 338 return shift ? 15 : (4 << IsQuad) - 1; 339 case NeonTypeFlags::Int32: 340 return shift ? 31 : (2 << IsQuad) - 1; 341 case NeonTypeFlags::Int64: 342 case NeonTypeFlags::Poly64: 343 return shift ? 63 : (1 << IsQuad) - 1; 344 case NeonTypeFlags::Poly128: 345 return shift ? 127 : (1 << IsQuad) - 1; 346 case NeonTypeFlags::Float16: 347 assert(!shift && "cannot shift float types!"); 348 return (4 << IsQuad) - 1; 349 case NeonTypeFlags::Float32: 350 assert(!shift && "cannot shift float types!"); 351 return (2 << IsQuad) - 1; 352 case NeonTypeFlags::Float64: 353 assert(!shift && "cannot shift float types!"); 354 return (1 << IsQuad) - 1; 355 } 356 llvm_unreachable("Invalid NeonTypeFlag!"); 357 } 358 359 /// getNeonEltType - Return the QualType corresponding to the elements of 360 /// the vector type specified by the NeonTypeFlags. This is used to check 361 /// the pointer arguments for Neon load/store intrinsics. 362 static QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context, 363 bool IsAArch64) { 364 switch (Flags.getEltType()) { 365 case NeonTypeFlags::Int8: 366 return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy; 367 case NeonTypeFlags::Int16: 368 return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy; 369 case NeonTypeFlags::Int32: 370 return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy; 371 case NeonTypeFlags::Int64: 372 return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy; 373 case NeonTypeFlags::Poly8: 374 return IsAArch64 ? Context.UnsignedCharTy : Context.SignedCharTy; 375 case NeonTypeFlags::Poly16: 376 return IsAArch64 ? Context.UnsignedShortTy : Context.ShortTy; 377 case NeonTypeFlags::Poly64: 378 return Context.UnsignedLongLongTy; 379 case NeonTypeFlags::Poly128: 380 break; 381 case NeonTypeFlags::Float16: 382 return Context.HalfTy; 383 case NeonTypeFlags::Float32: 384 return Context.FloatTy; 385 case NeonTypeFlags::Float64: 386 return Context.DoubleTy; 387 } 388 llvm_unreachable("Invalid NeonTypeFlag!"); 389 } 390 391 bool Sema::CheckAArch64BuiltinFunctionCall(unsigned BuiltinID, 392 CallExpr *TheCall) { 393 394 llvm::APSInt Result; 395 396 uint64_t mask = 0; 397 unsigned TV = 0; 398 int PtrArgNum = -1; 399 bool HasConstPtr = false; 400 switch (BuiltinID) { 401 #define GET_NEON_AARCH64_OVERLOAD_CHECK 402 #include "clang/Basic/arm_neon.inc" 403 #undef GET_NEON_AARCH64_OVERLOAD_CHECK 404 } 405 406 // For NEON intrinsics which are overloaded on vector element type, validate 407 // the immediate which specifies which variant to emit. 408 unsigned ImmArg = TheCall->getNumArgs() - 1; 409 if (mask) { 410 if (SemaBuiltinConstantArg(TheCall, ImmArg, Result)) 411 return true; 412 413 TV = Result.getLimitedValue(64); 414 if ((TV > 63) || (mask & (1ULL << TV)) == 0) 415 return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 416 << TheCall->getArg(ImmArg)->getSourceRange(); 417 } 418 419 if (PtrArgNum >= 0) { 420 // Check that pointer arguments have the specified type. 421 Expr *Arg = TheCall->getArg(PtrArgNum); 422 if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) 423 Arg = ICE->getSubExpr(); 424 ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg); 425 QualType RHSTy = RHS.get()->getType(); 426 QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context, true); 427 if (HasConstPtr) 428 EltTy = EltTy.withConst(); 429 QualType LHSTy = Context.getPointerType(EltTy); 430 AssignConvertType ConvTy; 431 ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS); 432 if (RHS.isInvalid()) 433 return true; 434 if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy, 435 RHS.get(), AA_Assigning)) 436 return true; 437 } 438 439 // For NEON intrinsics which take an immediate value as part of the 440 // instruction, range check them here. 441 unsigned i = 0, l = 0, u = 0; 442 switch (BuiltinID) { 443 default: 444 return false; 445 #define GET_NEON_AARCH64_IMMEDIATE_CHECK 446 #include "clang/Basic/arm_neon.inc" 447 #undef GET_NEON_AARCH64_IMMEDIATE_CHECK 448 } 449 ; 450 451 // We can't check the value of a dependent argument. 452 if (TheCall->getArg(i)->isTypeDependent() || 453 TheCall->getArg(i)->isValueDependent()) 454 return false; 455 456 // Check that the immediate argument is actually a constant. 457 if (SemaBuiltinConstantArg(TheCall, i, Result)) 458 return true; 459 460 // Range check against the upper/lower values for this isntruction. 461 unsigned Val = Result.getZExtValue(); 462 if (Val < l || Val > (u + l)) 463 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 464 << l << u + l << TheCall->getArg(i)->getSourceRange(); 465 466 return false; 467 } 468 469 bool Sema::CheckARMBuiltinExclusiveCall(unsigned BuiltinID, CallExpr *TheCall) { 470 assert((BuiltinID == ARM::BI__builtin_arm_ldrex || 471 BuiltinID == ARM::BI__builtin_arm_strex) && 472 "unexpected ARM builtin"); 473 bool IsLdrex = BuiltinID == ARM::BI__builtin_arm_ldrex; 474 475 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 476 477 // Ensure that we have the proper number of arguments. 478 if (checkArgCount(*this, TheCall, IsLdrex ? 1 : 2)) 479 return true; 480 481 // Inspect the pointer argument of the atomic builtin. This should always be 482 // a pointer type, whose element is an integral scalar or pointer type. 483 // Because it is a pointer type, we don't have to worry about any implicit 484 // casts here. 485 Expr *PointerArg = TheCall->getArg(IsLdrex ? 0 : 1); 486 ExprResult PointerArgRes = DefaultFunctionArrayLvalueConversion(PointerArg); 487 if (PointerArgRes.isInvalid()) 488 return true; 489 PointerArg = PointerArgRes.take(); 490 491 const PointerType *pointerType = PointerArg->getType()->getAs<PointerType>(); 492 if (!pointerType) { 493 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 494 << PointerArg->getType() << PointerArg->getSourceRange(); 495 return true; 496 } 497 498 // ldrex takes a "const volatile T*" and strex takes a "volatile T*". Our next 499 // task is to insert the appropriate casts into the AST. First work out just 500 // what the appropriate type is. 501 QualType ValType = pointerType->getPointeeType(); 502 QualType AddrType = ValType.getUnqualifiedType().withVolatile(); 503 if (IsLdrex) 504 AddrType.addConst(); 505 506 // Issue a warning if the cast is dodgy. 507 CastKind CastNeeded = CK_NoOp; 508 if (!AddrType.isAtLeastAsQualifiedAs(ValType)) { 509 CastNeeded = CK_BitCast; 510 Diag(DRE->getLocStart(), diag::ext_typecheck_convert_discards_qualifiers) 511 << PointerArg->getType() 512 << Context.getPointerType(AddrType) 513 << AA_Passing << PointerArg->getSourceRange(); 514 } 515 516 // Finally, do the cast and replace the argument with the corrected version. 517 AddrType = Context.getPointerType(AddrType); 518 PointerArgRes = ImpCastExprToType(PointerArg, AddrType, CastNeeded); 519 if (PointerArgRes.isInvalid()) 520 return true; 521 PointerArg = PointerArgRes.take(); 522 523 TheCall->setArg(IsLdrex ? 0 : 1, PointerArg); 524 525 // In general, we allow ints, floats and pointers to be loaded and stored. 526 if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 527 !ValType->isBlockPointerType() && !ValType->isFloatingType()) { 528 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intfltptr) 529 << PointerArg->getType() << PointerArg->getSourceRange(); 530 return true; 531 } 532 533 // But ARM doesn't have instructions to deal with 128-bit versions. 534 if (Context.getTypeSize(ValType) > 64) { 535 Diag(DRE->getLocStart(), diag::err_atomic_exclusive_builtin_pointer_size) 536 << PointerArg->getType() << PointerArg->getSourceRange(); 537 return true; 538 } 539 540 switch (ValType.getObjCLifetime()) { 541 case Qualifiers::OCL_None: 542 case Qualifiers::OCL_ExplicitNone: 543 // okay 544 break; 545 546 case Qualifiers::OCL_Weak: 547 case Qualifiers::OCL_Strong: 548 case Qualifiers::OCL_Autoreleasing: 549 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 550 << ValType << PointerArg->getSourceRange(); 551 return true; 552 } 553 554 555 if (IsLdrex) { 556 TheCall->setType(ValType); 557 return false; 558 } 559 560 // Initialize the argument to be stored. 561 ExprResult ValArg = TheCall->getArg(0); 562 InitializedEntity Entity = InitializedEntity::InitializeParameter( 563 Context, ValType, /*consume*/ false); 564 ValArg = PerformCopyInitialization(Entity, SourceLocation(), ValArg); 565 if (ValArg.isInvalid()) 566 return true; 567 TheCall->setArg(0, ValArg.get()); 568 569 // __builtin_arm_strex always returns an int. It's marked as such in the .def, 570 // but the custom checker bypasses all default analysis. 571 TheCall->setType(Context.IntTy); 572 return false; 573 } 574 575 bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 576 llvm::APSInt Result; 577 578 if (BuiltinID == ARM::BI__builtin_arm_ldrex || 579 BuiltinID == ARM::BI__builtin_arm_strex) { 580 return CheckARMBuiltinExclusiveCall(BuiltinID, TheCall); 581 } 582 583 uint64_t mask = 0; 584 unsigned TV = 0; 585 int PtrArgNum = -1; 586 bool HasConstPtr = false; 587 switch (BuiltinID) { 588 #define GET_NEON_OVERLOAD_CHECK 589 #include "clang/Basic/arm_neon.inc" 590 #undef GET_NEON_OVERLOAD_CHECK 591 } 592 593 // For NEON intrinsics which are overloaded on vector element type, validate 594 // the immediate which specifies which variant to emit. 595 unsigned ImmArg = TheCall->getNumArgs()-1; 596 if (mask) { 597 if (SemaBuiltinConstantArg(TheCall, ImmArg, Result)) 598 return true; 599 600 TV = Result.getLimitedValue(64); 601 if ((TV > 63) || (mask & (1ULL << TV)) == 0) 602 return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 603 << TheCall->getArg(ImmArg)->getSourceRange(); 604 } 605 606 if (PtrArgNum >= 0) { 607 // Check that pointer arguments have the specified type. 608 Expr *Arg = TheCall->getArg(PtrArgNum); 609 if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) 610 Arg = ICE->getSubExpr(); 611 ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg); 612 QualType RHSTy = RHS.get()->getType(); 613 QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context, false); 614 if (HasConstPtr) 615 EltTy = EltTy.withConst(); 616 QualType LHSTy = Context.getPointerType(EltTy); 617 AssignConvertType ConvTy; 618 ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS); 619 if (RHS.isInvalid()) 620 return true; 621 if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy, 622 RHS.get(), AA_Assigning)) 623 return true; 624 } 625 626 // For NEON intrinsics which take an immediate value as part of the 627 // instruction, range check them here. 628 unsigned i = 0, l = 0, u = 0; 629 switch (BuiltinID) { 630 default: return false; 631 case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 632 case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 633 case ARM::BI__builtin_arm_vcvtr_f: 634 case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 635 case ARM::BI__builtin_arm_dmb: 636 case ARM::BI__builtin_arm_dsb: l = 0; u = 15; break; 637 #define GET_NEON_IMMEDIATE_CHECK 638 #include "clang/Basic/arm_neon.inc" 639 #undef GET_NEON_IMMEDIATE_CHECK 640 }; 641 642 // We can't check the value of a dependent argument. 643 if (TheCall->getArg(i)->isTypeDependent() || 644 TheCall->getArg(i)->isValueDependent()) 645 return false; 646 647 // Check that the immediate argument is actually a constant. 648 if (SemaBuiltinConstantArg(TheCall, i, Result)) 649 return true; 650 651 // Range check against the upper/lower values for this isntruction. 652 unsigned Val = Result.getZExtValue(); 653 if (Val < l || Val > (u + l)) 654 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 655 << l << u+l << TheCall->getArg(i)->getSourceRange(); 656 657 // FIXME: VFP Intrinsics should error if VFP not present. 658 return false; 659 } 660 661 bool Sema::CheckMipsBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 662 unsigned i = 0, l = 0, u = 0; 663 switch (BuiltinID) { 664 default: return false; 665 case Mips::BI__builtin_mips_wrdsp: i = 1; l = 0; u = 63; break; 666 case Mips::BI__builtin_mips_rddsp: i = 0; l = 0; u = 63; break; 667 case Mips::BI__builtin_mips_append: i = 2; l = 0; u = 31; break; 668 case Mips::BI__builtin_mips_balign: i = 2; l = 0; u = 3; break; 669 case Mips::BI__builtin_mips_precr_sra_ph_w: i = 2; l = 0; u = 31; break; 670 case Mips::BI__builtin_mips_precr_sra_r_ph_w: i = 2; l = 0; u = 31; break; 671 case Mips::BI__builtin_mips_prepend: i = 2; l = 0; u = 31; break; 672 }; 673 674 // We can't check the value of a dependent argument. 675 if (TheCall->getArg(i)->isTypeDependent() || 676 TheCall->getArg(i)->isValueDependent()) 677 return false; 678 679 // Check that the immediate argument is actually a constant. 680 llvm::APSInt Result; 681 if (SemaBuiltinConstantArg(TheCall, i, Result)) 682 return true; 683 684 // Range check against the upper/lower values for this instruction. 685 unsigned Val = Result.getZExtValue(); 686 if (Val < l || Val > u) 687 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 688 << l << u << TheCall->getArg(i)->getSourceRange(); 689 690 return false; 691 } 692 693 /// Given a FunctionDecl's FormatAttr, attempts to populate the FomatStringInfo 694 /// parameter with the FormatAttr's correct format_idx and firstDataArg. 695 /// Returns true when the format fits the function and the FormatStringInfo has 696 /// been populated. 697 bool Sema::getFormatStringInfo(const FormatAttr *Format, bool IsCXXMember, 698 FormatStringInfo *FSI) { 699 FSI->HasVAListArg = Format->getFirstArg() == 0; 700 FSI->FormatIdx = Format->getFormatIdx() - 1; 701 FSI->FirstDataArg = FSI->HasVAListArg ? 0 : Format->getFirstArg() - 1; 702 703 // The way the format attribute works in GCC, the implicit this argument 704 // of member functions is counted. However, it doesn't appear in our own 705 // lists, so decrement format_idx in that case. 706 if (IsCXXMember) { 707 if(FSI->FormatIdx == 0) 708 return false; 709 --FSI->FormatIdx; 710 if (FSI->FirstDataArg != 0) 711 --FSI->FirstDataArg; 712 } 713 return true; 714 } 715 716 /// Checks if a the given expression evaluates to null. 717 /// 718 /// \brief Returns true if the value evaluates to null. 719 static bool CheckNonNullExpr(Sema &S, 720 const Expr *Expr) { 721 // As a special case, transparent unions initialized with zero are 722 // considered null for the purposes of the nonnull attribute. 723 if (const RecordType *UT = Expr->getType()->getAsUnionType()) { 724 if (UT->getDecl()->hasAttr<TransparentUnionAttr>()) 725 if (const CompoundLiteralExpr *CLE = 726 dyn_cast<CompoundLiteralExpr>(Expr)) 727 if (const InitListExpr *ILE = 728 dyn_cast<InitListExpr>(CLE->getInitializer())) 729 Expr = ILE->getInit(0); 730 } 731 732 bool Result; 733 return (!Expr->isValueDependent() && 734 Expr->EvaluateAsBooleanCondition(Result, S.Context) && 735 !Result); 736 } 737 738 static void CheckNonNullArgument(Sema &S, 739 const Expr *ArgExpr, 740 SourceLocation CallSiteLoc) { 741 if (CheckNonNullExpr(S, ArgExpr)) 742 S.Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 743 } 744 745 static void CheckNonNullArguments(Sema &S, 746 const NamedDecl *FDecl, 747 const Expr * const *ExprArgs, 748 SourceLocation CallSiteLoc) { 749 // Check the attributes attached to the method/function itself. 750 for (specific_attr_iterator<NonNullAttr> 751 I = FDecl->specific_attr_begin<NonNullAttr>(), 752 E = FDecl->specific_attr_end<NonNullAttr>(); I != E; ++I) { 753 754 const NonNullAttr *NonNull = *I; 755 for (NonNullAttr::args_iterator i = NonNull->args_begin(), 756 e = NonNull->args_end(); 757 i != e; ++i) { 758 CheckNonNullArgument(S, ExprArgs[*i], CallSiteLoc); 759 } 760 } 761 762 // Check the attributes on the parameters. 763 ArrayRef<ParmVarDecl*> parms; 764 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(FDecl)) 765 parms = FD->parameters(); 766 else if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(FDecl)) 767 parms = MD->parameters(); 768 769 unsigned argIndex = 0; 770 for (ArrayRef<ParmVarDecl*>::iterator I = parms.begin(), E = parms.end(); 771 I != E; ++I, ++argIndex) { 772 const ParmVarDecl *PVD = *I; 773 if (PVD->hasAttr<NonNullAttr>()) 774 CheckNonNullArgument(S, ExprArgs[argIndex], CallSiteLoc); 775 } 776 } 777 778 /// Handles the checks for format strings, non-POD arguments to vararg 779 /// functions, and NULL arguments passed to non-NULL parameters. 780 void Sema::checkCall(NamedDecl *FDecl, ArrayRef<const Expr *> Args, 781 unsigned NumParams, bool IsMemberFunction, 782 SourceLocation Loc, SourceRange Range, 783 VariadicCallType CallType) { 784 // FIXME: We should check as much as we can in the template definition. 785 if (CurContext->isDependentContext()) 786 return; 787 788 // Printf and scanf checking. 789 llvm::SmallBitVector CheckedVarArgs; 790 if (FDecl) { 791 for (specific_attr_iterator<FormatAttr> 792 I = FDecl->specific_attr_begin<FormatAttr>(), 793 E = FDecl->specific_attr_end<FormatAttr>(); 794 I != E; ++I) { 795 // Only create vector if there are format attributes. 796 CheckedVarArgs.resize(Args.size()); 797 798 CheckFormatArguments(*I, Args, IsMemberFunction, CallType, Loc, Range, 799 CheckedVarArgs); 800 } 801 } 802 803 // Refuse POD arguments that weren't caught by the format string 804 // checks above. 805 if (CallType != VariadicDoesNotApply) { 806 for (unsigned ArgIdx = NumParams; ArgIdx < Args.size(); ++ArgIdx) { 807 // Args[ArgIdx] can be null in malformed code. 808 if (const Expr *Arg = Args[ArgIdx]) { 809 if (CheckedVarArgs.empty() || !CheckedVarArgs[ArgIdx]) 810 checkVariadicArgument(Arg, CallType); 811 } 812 } 813 } 814 815 if (FDecl) { 816 CheckNonNullArguments(*this, FDecl, Args.data(), Loc); 817 818 // Type safety checking. 819 for (specific_attr_iterator<ArgumentWithTypeTagAttr> 820 i = FDecl->specific_attr_begin<ArgumentWithTypeTagAttr>(), 821 e = FDecl->specific_attr_end<ArgumentWithTypeTagAttr>(); 822 i != e; ++i) { 823 CheckArgumentWithTypeTag(*i, Args.data()); 824 } 825 } 826 } 827 828 /// CheckConstructorCall - Check a constructor call for correctness and safety 829 /// properties not enforced by the C type system. 830 void Sema::CheckConstructorCall(FunctionDecl *FDecl, 831 ArrayRef<const Expr *> Args, 832 const FunctionProtoType *Proto, 833 SourceLocation Loc) { 834 VariadicCallType CallType = 835 Proto->isVariadic() ? VariadicConstructor : VariadicDoesNotApply; 836 checkCall(FDecl, Args, Proto->getNumParams(), 837 /*IsMemberFunction=*/true, Loc, SourceRange(), CallType); 838 } 839 840 /// CheckFunctionCall - Check a direct function call for various correctness 841 /// and safety properties not strictly enforced by the C type system. 842 bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall, 843 const FunctionProtoType *Proto) { 844 bool IsMemberOperatorCall = isa<CXXOperatorCallExpr>(TheCall) && 845 isa<CXXMethodDecl>(FDecl); 846 bool IsMemberFunction = isa<CXXMemberCallExpr>(TheCall) || 847 IsMemberOperatorCall; 848 VariadicCallType CallType = getVariadicCallType(FDecl, Proto, 849 TheCall->getCallee()); 850 unsigned NumParams = Proto ? Proto->getNumParams() : 0; 851 Expr** Args = TheCall->getArgs(); 852 unsigned NumArgs = TheCall->getNumArgs(); 853 if (IsMemberOperatorCall) { 854 // If this is a call to a member operator, hide the first argument 855 // from checkCall. 856 // FIXME: Our choice of AST representation here is less than ideal. 857 ++Args; 858 --NumArgs; 859 } 860 checkCall(FDecl, llvm::makeArrayRef<const Expr *>(Args, NumArgs), NumParams, 861 IsMemberFunction, TheCall->getRParenLoc(), 862 TheCall->getCallee()->getSourceRange(), CallType); 863 864 IdentifierInfo *FnInfo = FDecl->getIdentifier(); 865 // None of the checks below are needed for functions that don't have 866 // simple names (e.g., C++ conversion functions). 867 if (!FnInfo) 868 return false; 869 870 unsigned CMId = FDecl->getMemoryFunctionKind(); 871 if (CMId == 0) 872 return false; 873 874 // Handle memory setting and copying functions. 875 if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat) 876 CheckStrlcpycatArguments(TheCall, FnInfo); 877 else if (CMId == Builtin::BIstrncat) 878 CheckStrncatArguments(TheCall, FnInfo); 879 else 880 CheckMemaccessArguments(TheCall, CMId, FnInfo); 881 882 return false; 883 } 884 885 bool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac, 886 ArrayRef<const Expr *> Args) { 887 VariadicCallType CallType = 888 Method->isVariadic() ? VariadicMethod : VariadicDoesNotApply; 889 890 checkCall(Method, Args, Method->param_size(), 891 /*IsMemberFunction=*/false, 892 lbrac, Method->getSourceRange(), CallType); 893 894 return false; 895 } 896 897 bool Sema::CheckPointerCall(NamedDecl *NDecl, CallExpr *TheCall, 898 const FunctionProtoType *Proto) { 899 const VarDecl *V = dyn_cast<VarDecl>(NDecl); 900 if (!V) 901 return false; 902 903 QualType Ty = V->getType(); 904 if (!Ty->isBlockPointerType() && !Ty->isFunctionPointerType()) 905 return false; 906 907 VariadicCallType CallType; 908 if (!Proto || !Proto->isVariadic()) { 909 CallType = VariadicDoesNotApply; 910 } else if (Ty->isBlockPointerType()) { 911 CallType = VariadicBlock; 912 } else { // Ty->isFunctionPointerType() 913 CallType = VariadicFunction; 914 } 915 unsigned NumParams = Proto ? Proto->getNumParams() : 0; 916 917 checkCall(NDecl, llvm::makeArrayRef<const Expr *>(TheCall->getArgs(), 918 TheCall->getNumArgs()), 919 NumParams, /*IsMemberFunction=*/false, TheCall->getRParenLoc(), 920 TheCall->getCallee()->getSourceRange(), CallType); 921 922 return false; 923 } 924 925 /// Checks function calls when a FunctionDecl or a NamedDecl is not available, 926 /// such as function pointers returned from functions. 927 bool Sema::CheckOtherCall(CallExpr *TheCall, const FunctionProtoType *Proto) { 928 VariadicCallType CallType = getVariadicCallType(/*FDecl=*/0, Proto, 929 TheCall->getCallee()); 930 unsigned NumParams = Proto ? Proto->getNumParams() : 0; 931 932 checkCall(/*FDecl=*/0, llvm::makeArrayRef<const Expr *>( 933 TheCall->getArgs(), TheCall->getNumArgs()), 934 NumParams, /*IsMemberFunction=*/false, TheCall->getRParenLoc(), 935 TheCall->getCallee()->getSourceRange(), CallType); 936 937 return false; 938 } 939 940 ExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult, 941 AtomicExpr::AtomicOp Op) { 942 CallExpr *TheCall = cast<CallExpr>(TheCallResult.get()); 943 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 944 945 // All these operations take one of the following forms: 946 enum { 947 // C __c11_atomic_init(A *, C) 948 Init, 949 // C __c11_atomic_load(A *, int) 950 Load, 951 // void __atomic_load(A *, CP, int) 952 Copy, 953 // C __c11_atomic_add(A *, M, int) 954 Arithmetic, 955 // C __atomic_exchange_n(A *, CP, int) 956 Xchg, 957 // void __atomic_exchange(A *, C *, CP, int) 958 GNUXchg, 959 // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int) 960 C11CmpXchg, 961 // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int) 962 GNUCmpXchg 963 } Form = Init; 964 const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 4, 5, 6 }; 965 const unsigned NumVals[] = { 1, 0, 1, 1, 1, 2, 2, 3 }; 966 // where: 967 // C is an appropriate type, 968 // A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins, 969 // CP is C for __c11 builtins and GNU _n builtins and is C * otherwise, 970 // M is C if C is an integer, and ptrdiff_t if C is a pointer, and 971 // the int parameters are for orderings. 972 973 assert(AtomicExpr::AO__c11_atomic_init == 0 && 974 AtomicExpr::AO__c11_atomic_fetch_xor + 1 == AtomicExpr::AO__atomic_load 975 && "need to update code for modified C11 atomics"); 976 bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init && 977 Op <= AtomicExpr::AO__c11_atomic_fetch_xor; 978 bool IsN = Op == AtomicExpr::AO__atomic_load_n || 979 Op == AtomicExpr::AO__atomic_store_n || 980 Op == AtomicExpr::AO__atomic_exchange_n || 981 Op == AtomicExpr::AO__atomic_compare_exchange_n; 982 bool IsAddSub = false; 983 984 switch (Op) { 985 case AtomicExpr::AO__c11_atomic_init: 986 Form = Init; 987 break; 988 989 case AtomicExpr::AO__c11_atomic_load: 990 case AtomicExpr::AO__atomic_load_n: 991 Form = Load; 992 break; 993 994 case AtomicExpr::AO__c11_atomic_store: 995 case AtomicExpr::AO__atomic_load: 996 case AtomicExpr::AO__atomic_store: 997 case AtomicExpr::AO__atomic_store_n: 998 Form = Copy; 999 break; 1000 1001 case AtomicExpr::AO__c11_atomic_fetch_add: 1002 case AtomicExpr::AO__c11_atomic_fetch_sub: 1003 case AtomicExpr::AO__atomic_fetch_add: 1004 case AtomicExpr::AO__atomic_fetch_sub: 1005 case AtomicExpr::AO__atomic_add_fetch: 1006 case AtomicExpr::AO__atomic_sub_fetch: 1007 IsAddSub = true; 1008 // Fall through. 1009 case AtomicExpr::AO__c11_atomic_fetch_and: 1010 case AtomicExpr::AO__c11_atomic_fetch_or: 1011 case AtomicExpr::AO__c11_atomic_fetch_xor: 1012 case AtomicExpr::AO__atomic_fetch_and: 1013 case AtomicExpr::AO__atomic_fetch_or: 1014 case AtomicExpr::AO__atomic_fetch_xor: 1015 case AtomicExpr::AO__atomic_fetch_nand: 1016 case AtomicExpr::AO__atomic_and_fetch: 1017 case AtomicExpr::AO__atomic_or_fetch: 1018 case AtomicExpr::AO__atomic_xor_fetch: 1019 case AtomicExpr::AO__atomic_nand_fetch: 1020 Form = Arithmetic; 1021 break; 1022 1023 case AtomicExpr::AO__c11_atomic_exchange: 1024 case AtomicExpr::AO__atomic_exchange_n: 1025 Form = Xchg; 1026 break; 1027 1028 case AtomicExpr::AO__atomic_exchange: 1029 Form = GNUXchg; 1030 break; 1031 1032 case AtomicExpr::AO__c11_atomic_compare_exchange_strong: 1033 case AtomicExpr::AO__c11_atomic_compare_exchange_weak: 1034 Form = C11CmpXchg; 1035 break; 1036 1037 case AtomicExpr::AO__atomic_compare_exchange: 1038 case AtomicExpr::AO__atomic_compare_exchange_n: 1039 Form = GNUCmpXchg; 1040 break; 1041 } 1042 1043 // Check we have the right number of arguments. 1044 if (TheCall->getNumArgs() < NumArgs[Form]) { 1045 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1046 << 0 << NumArgs[Form] << TheCall->getNumArgs() 1047 << TheCall->getCallee()->getSourceRange(); 1048 return ExprError(); 1049 } else if (TheCall->getNumArgs() > NumArgs[Form]) { 1050 Diag(TheCall->getArg(NumArgs[Form])->getLocStart(), 1051 diag::err_typecheck_call_too_many_args) 1052 << 0 << NumArgs[Form] << TheCall->getNumArgs() 1053 << TheCall->getCallee()->getSourceRange(); 1054 return ExprError(); 1055 } 1056 1057 // Inspect the first argument of the atomic operation. 1058 Expr *Ptr = TheCall->getArg(0); 1059 Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get(); 1060 const PointerType *pointerType = Ptr->getType()->getAs<PointerType>(); 1061 if (!pointerType) { 1062 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 1063 << Ptr->getType() << Ptr->getSourceRange(); 1064 return ExprError(); 1065 } 1066 1067 // For a __c11 builtin, this should be a pointer to an _Atomic type. 1068 QualType AtomTy = pointerType->getPointeeType(); // 'A' 1069 QualType ValType = AtomTy; // 'C' 1070 if (IsC11) { 1071 if (!AtomTy->isAtomicType()) { 1072 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 1073 << Ptr->getType() << Ptr->getSourceRange(); 1074 return ExprError(); 1075 } 1076 if (AtomTy.isConstQualified()) { 1077 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_non_const_atomic) 1078 << Ptr->getType() << Ptr->getSourceRange(); 1079 return ExprError(); 1080 } 1081 ValType = AtomTy->getAs<AtomicType>()->getValueType(); 1082 } 1083 1084 // For an arithmetic operation, the implied arithmetic must be well-formed. 1085 if (Form == Arithmetic) { 1086 // gcc does not enforce these rules for GNU atomics, but we do so for sanity. 1087 if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) { 1088 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 1089 << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 1090 return ExprError(); 1091 } 1092 if (!IsAddSub && !ValType->isIntegerType()) { 1093 Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int) 1094 << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 1095 return ExprError(); 1096 } 1097 } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) { 1098 // For __atomic_*_n operations, the value type must be a scalar integral or 1099 // pointer type which is 1, 2, 4, 8 or 16 bytes in length. 1100 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 1101 << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 1102 return ExprError(); 1103 } 1104 1105 if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context) && 1106 !AtomTy->isScalarType()) { 1107 // For GNU atomics, require a trivially-copyable type. This is not part of 1108 // the GNU atomics specification, but we enforce it for sanity. 1109 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy) 1110 << Ptr->getType() << Ptr->getSourceRange(); 1111 return ExprError(); 1112 } 1113 1114 // FIXME: For any builtin other than a load, the ValType must not be 1115 // const-qualified. 1116 1117 switch (ValType.getObjCLifetime()) { 1118 case Qualifiers::OCL_None: 1119 case Qualifiers::OCL_ExplicitNone: 1120 // okay 1121 break; 1122 1123 case Qualifiers::OCL_Weak: 1124 case Qualifiers::OCL_Strong: 1125 case Qualifiers::OCL_Autoreleasing: 1126 // FIXME: Can this happen? By this point, ValType should be known 1127 // to be trivially copyable. 1128 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 1129 << ValType << Ptr->getSourceRange(); 1130 return ExprError(); 1131 } 1132 1133 QualType ResultType = ValType; 1134 if (Form == Copy || Form == GNUXchg || Form == Init) 1135 ResultType = Context.VoidTy; 1136 else if (Form == C11CmpXchg || Form == GNUCmpXchg) 1137 ResultType = Context.BoolTy; 1138 1139 // The type of a parameter passed 'by value'. In the GNU atomics, such 1140 // arguments are actually passed as pointers. 1141 QualType ByValType = ValType; // 'CP' 1142 if (!IsC11 && !IsN) 1143 ByValType = Ptr->getType(); 1144 1145 // The first argument --- the pointer --- has a fixed type; we 1146 // deduce the types of the rest of the arguments accordingly. Walk 1147 // the remaining arguments, converting them to the deduced value type. 1148 for (unsigned i = 1; i != NumArgs[Form]; ++i) { 1149 QualType Ty; 1150 if (i < NumVals[Form] + 1) { 1151 switch (i) { 1152 case 1: 1153 // The second argument is the non-atomic operand. For arithmetic, this 1154 // is always passed by value, and for a compare_exchange it is always 1155 // passed by address. For the rest, GNU uses by-address and C11 uses 1156 // by-value. 1157 assert(Form != Load); 1158 if (Form == Init || (Form == Arithmetic && ValType->isIntegerType())) 1159 Ty = ValType; 1160 else if (Form == Copy || Form == Xchg) 1161 Ty = ByValType; 1162 else if (Form == Arithmetic) 1163 Ty = Context.getPointerDiffType(); 1164 else 1165 Ty = Context.getPointerType(ValType.getUnqualifiedType()); 1166 break; 1167 case 2: 1168 // The third argument to compare_exchange / GNU exchange is a 1169 // (pointer to a) desired value. 1170 Ty = ByValType; 1171 break; 1172 case 3: 1173 // The fourth argument to GNU compare_exchange is a 'weak' flag. 1174 Ty = Context.BoolTy; 1175 break; 1176 } 1177 } else { 1178 // The order(s) are always converted to int. 1179 Ty = Context.IntTy; 1180 } 1181 1182 InitializedEntity Entity = 1183 InitializedEntity::InitializeParameter(Context, Ty, false); 1184 ExprResult Arg = TheCall->getArg(i); 1185 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 1186 if (Arg.isInvalid()) 1187 return true; 1188 TheCall->setArg(i, Arg.get()); 1189 } 1190 1191 // Permute the arguments into a 'consistent' order. 1192 SmallVector<Expr*, 5> SubExprs; 1193 SubExprs.push_back(Ptr); 1194 switch (Form) { 1195 case Init: 1196 // Note, AtomicExpr::getVal1() has a special case for this atomic. 1197 SubExprs.push_back(TheCall->getArg(1)); // Val1 1198 break; 1199 case Load: 1200 SubExprs.push_back(TheCall->getArg(1)); // Order 1201 break; 1202 case Copy: 1203 case Arithmetic: 1204 case Xchg: 1205 SubExprs.push_back(TheCall->getArg(2)); // Order 1206 SubExprs.push_back(TheCall->getArg(1)); // Val1 1207 break; 1208 case GNUXchg: 1209 // Note, AtomicExpr::getVal2() has a special case for this atomic. 1210 SubExprs.push_back(TheCall->getArg(3)); // Order 1211 SubExprs.push_back(TheCall->getArg(1)); // Val1 1212 SubExprs.push_back(TheCall->getArg(2)); // Val2 1213 break; 1214 case C11CmpXchg: 1215 SubExprs.push_back(TheCall->getArg(3)); // Order 1216 SubExprs.push_back(TheCall->getArg(1)); // Val1 1217 SubExprs.push_back(TheCall->getArg(4)); // OrderFail 1218 SubExprs.push_back(TheCall->getArg(2)); // Val2 1219 break; 1220 case GNUCmpXchg: 1221 SubExprs.push_back(TheCall->getArg(4)); // Order 1222 SubExprs.push_back(TheCall->getArg(1)); // Val1 1223 SubExprs.push_back(TheCall->getArg(5)); // OrderFail 1224 SubExprs.push_back(TheCall->getArg(2)); // Val2 1225 SubExprs.push_back(TheCall->getArg(3)); // Weak 1226 break; 1227 } 1228 1229 AtomicExpr *AE = new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(), 1230 SubExprs, ResultType, Op, 1231 TheCall->getRParenLoc()); 1232 1233 if ((Op == AtomicExpr::AO__c11_atomic_load || 1234 (Op == AtomicExpr::AO__c11_atomic_store)) && 1235 Context.AtomicUsesUnsupportedLibcall(AE)) 1236 Diag(AE->getLocStart(), diag::err_atomic_load_store_uses_lib) << 1237 ((Op == AtomicExpr::AO__c11_atomic_load) ? 0 : 1); 1238 1239 return Owned(AE); 1240 } 1241 1242 1243 /// checkBuiltinArgument - Given a call to a builtin function, perform 1244 /// normal type-checking on the given argument, updating the call in 1245 /// place. This is useful when a builtin function requires custom 1246 /// type-checking for some of its arguments but not necessarily all of 1247 /// them. 1248 /// 1249 /// Returns true on error. 1250 static bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) { 1251 FunctionDecl *Fn = E->getDirectCallee(); 1252 assert(Fn && "builtin call without direct callee!"); 1253 1254 ParmVarDecl *Param = Fn->getParamDecl(ArgIndex); 1255 InitializedEntity Entity = 1256 InitializedEntity::InitializeParameter(S.Context, Param); 1257 1258 ExprResult Arg = E->getArg(0); 1259 Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg); 1260 if (Arg.isInvalid()) 1261 return true; 1262 1263 E->setArg(ArgIndex, Arg.take()); 1264 return false; 1265 } 1266 1267 /// SemaBuiltinAtomicOverloaded - We have a call to a function like 1268 /// __sync_fetch_and_add, which is an overloaded function based on the pointer 1269 /// type of its first argument. The main ActOnCallExpr routines have already 1270 /// promoted the types of arguments because all of these calls are prototyped as 1271 /// void(...). 1272 /// 1273 /// This function goes through and does final semantic checking for these 1274 /// builtins, 1275 ExprResult 1276 Sema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 1277 CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 1278 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 1279 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 1280 1281 // Ensure that we have at least one argument to do type inference from. 1282 if (TheCall->getNumArgs() < 1) { 1283 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 1284 << 0 << 1 << TheCall->getNumArgs() 1285 << TheCall->getCallee()->getSourceRange(); 1286 return ExprError(); 1287 } 1288 1289 // Inspect the first argument of the atomic builtin. This should always be 1290 // a pointer type, whose element is an integral scalar or pointer type. 1291 // Because it is a pointer type, we don't have to worry about any implicit 1292 // casts here. 1293 // FIXME: We don't allow floating point scalars as input. 1294 Expr *FirstArg = TheCall->getArg(0); 1295 ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg); 1296 if (FirstArgResult.isInvalid()) 1297 return ExprError(); 1298 FirstArg = FirstArgResult.take(); 1299 TheCall->setArg(0, FirstArg); 1300 1301 const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>(); 1302 if (!pointerType) { 1303 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 1304 << FirstArg->getType() << FirstArg->getSourceRange(); 1305 return ExprError(); 1306 } 1307 1308 QualType ValType = pointerType->getPointeeType(); 1309 if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 1310 !ValType->isBlockPointerType()) { 1311 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 1312 << FirstArg->getType() << FirstArg->getSourceRange(); 1313 return ExprError(); 1314 } 1315 1316 switch (ValType.getObjCLifetime()) { 1317 case Qualifiers::OCL_None: 1318 case Qualifiers::OCL_ExplicitNone: 1319 // okay 1320 break; 1321 1322 case Qualifiers::OCL_Weak: 1323 case Qualifiers::OCL_Strong: 1324 case Qualifiers::OCL_Autoreleasing: 1325 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 1326 << ValType << FirstArg->getSourceRange(); 1327 return ExprError(); 1328 } 1329 1330 // Strip any qualifiers off ValType. 1331 ValType = ValType.getUnqualifiedType(); 1332 1333 // The majority of builtins return a value, but a few have special return 1334 // types, so allow them to override appropriately below. 1335 QualType ResultType = ValType; 1336 1337 // We need to figure out which concrete builtin this maps onto. For example, 1338 // __sync_fetch_and_add with a 2 byte object turns into 1339 // __sync_fetch_and_add_2. 1340 #define BUILTIN_ROW(x) \ 1341 { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 1342 Builtin::BI##x##_8, Builtin::BI##x##_16 } 1343 1344 static const unsigned BuiltinIndices[][5] = { 1345 BUILTIN_ROW(__sync_fetch_and_add), 1346 BUILTIN_ROW(__sync_fetch_and_sub), 1347 BUILTIN_ROW(__sync_fetch_and_or), 1348 BUILTIN_ROW(__sync_fetch_and_and), 1349 BUILTIN_ROW(__sync_fetch_and_xor), 1350 1351 BUILTIN_ROW(__sync_add_and_fetch), 1352 BUILTIN_ROW(__sync_sub_and_fetch), 1353 BUILTIN_ROW(__sync_and_and_fetch), 1354 BUILTIN_ROW(__sync_or_and_fetch), 1355 BUILTIN_ROW(__sync_xor_and_fetch), 1356 1357 BUILTIN_ROW(__sync_val_compare_and_swap), 1358 BUILTIN_ROW(__sync_bool_compare_and_swap), 1359 BUILTIN_ROW(__sync_lock_test_and_set), 1360 BUILTIN_ROW(__sync_lock_release), 1361 BUILTIN_ROW(__sync_swap) 1362 }; 1363 #undef BUILTIN_ROW 1364 1365 // Determine the index of the size. 1366 unsigned SizeIndex; 1367 switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 1368 case 1: SizeIndex = 0; break; 1369 case 2: SizeIndex = 1; break; 1370 case 4: SizeIndex = 2; break; 1371 case 8: SizeIndex = 3; break; 1372 case 16: SizeIndex = 4; break; 1373 default: 1374 Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 1375 << FirstArg->getType() << FirstArg->getSourceRange(); 1376 return ExprError(); 1377 } 1378 1379 // Each of these builtins has one pointer argument, followed by some number of 1380 // values (0, 1 or 2) followed by a potentially empty varags list of stuff 1381 // that we ignore. Find out which row of BuiltinIndices to read from as well 1382 // as the number of fixed args. 1383 unsigned BuiltinID = FDecl->getBuiltinID(); 1384 unsigned BuiltinIndex, NumFixed = 1; 1385 switch (BuiltinID) { 1386 default: llvm_unreachable("Unknown overloaded atomic builtin!"); 1387 case Builtin::BI__sync_fetch_and_add: 1388 case Builtin::BI__sync_fetch_and_add_1: 1389 case Builtin::BI__sync_fetch_and_add_2: 1390 case Builtin::BI__sync_fetch_and_add_4: 1391 case Builtin::BI__sync_fetch_and_add_8: 1392 case Builtin::BI__sync_fetch_and_add_16: 1393 BuiltinIndex = 0; 1394 break; 1395 1396 case Builtin::BI__sync_fetch_and_sub: 1397 case Builtin::BI__sync_fetch_and_sub_1: 1398 case Builtin::BI__sync_fetch_and_sub_2: 1399 case Builtin::BI__sync_fetch_and_sub_4: 1400 case Builtin::BI__sync_fetch_and_sub_8: 1401 case Builtin::BI__sync_fetch_and_sub_16: 1402 BuiltinIndex = 1; 1403 break; 1404 1405 case Builtin::BI__sync_fetch_and_or: 1406 case Builtin::BI__sync_fetch_and_or_1: 1407 case Builtin::BI__sync_fetch_and_or_2: 1408 case Builtin::BI__sync_fetch_and_or_4: 1409 case Builtin::BI__sync_fetch_and_or_8: 1410 case Builtin::BI__sync_fetch_and_or_16: 1411 BuiltinIndex = 2; 1412 break; 1413 1414 case Builtin::BI__sync_fetch_and_and: 1415 case Builtin::BI__sync_fetch_and_and_1: 1416 case Builtin::BI__sync_fetch_and_and_2: 1417 case Builtin::BI__sync_fetch_and_and_4: 1418 case Builtin::BI__sync_fetch_and_and_8: 1419 case Builtin::BI__sync_fetch_and_and_16: 1420 BuiltinIndex = 3; 1421 break; 1422 1423 case Builtin::BI__sync_fetch_and_xor: 1424 case Builtin::BI__sync_fetch_and_xor_1: 1425 case Builtin::BI__sync_fetch_and_xor_2: 1426 case Builtin::BI__sync_fetch_and_xor_4: 1427 case Builtin::BI__sync_fetch_and_xor_8: 1428 case Builtin::BI__sync_fetch_and_xor_16: 1429 BuiltinIndex = 4; 1430 break; 1431 1432 case Builtin::BI__sync_add_and_fetch: 1433 case Builtin::BI__sync_add_and_fetch_1: 1434 case Builtin::BI__sync_add_and_fetch_2: 1435 case Builtin::BI__sync_add_and_fetch_4: 1436 case Builtin::BI__sync_add_and_fetch_8: 1437 case Builtin::BI__sync_add_and_fetch_16: 1438 BuiltinIndex = 5; 1439 break; 1440 1441 case Builtin::BI__sync_sub_and_fetch: 1442 case Builtin::BI__sync_sub_and_fetch_1: 1443 case Builtin::BI__sync_sub_and_fetch_2: 1444 case Builtin::BI__sync_sub_and_fetch_4: 1445 case Builtin::BI__sync_sub_and_fetch_8: 1446 case Builtin::BI__sync_sub_and_fetch_16: 1447 BuiltinIndex = 6; 1448 break; 1449 1450 case Builtin::BI__sync_and_and_fetch: 1451 case Builtin::BI__sync_and_and_fetch_1: 1452 case Builtin::BI__sync_and_and_fetch_2: 1453 case Builtin::BI__sync_and_and_fetch_4: 1454 case Builtin::BI__sync_and_and_fetch_8: 1455 case Builtin::BI__sync_and_and_fetch_16: 1456 BuiltinIndex = 7; 1457 break; 1458 1459 case Builtin::BI__sync_or_and_fetch: 1460 case Builtin::BI__sync_or_and_fetch_1: 1461 case Builtin::BI__sync_or_and_fetch_2: 1462 case Builtin::BI__sync_or_and_fetch_4: 1463 case Builtin::BI__sync_or_and_fetch_8: 1464 case Builtin::BI__sync_or_and_fetch_16: 1465 BuiltinIndex = 8; 1466 break; 1467 1468 case Builtin::BI__sync_xor_and_fetch: 1469 case Builtin::BI__sync_xor_and_fetch_1: 1470 case Builtin::BI__sync_xor_and_fetch_2: 1471 case Builtin::BI__sync_xor_and_fetch_4: 1472 case Builtin::BI__sync_xor_and_fetch_8: 1473 case Builtin::BI__sync_xor_and_fetch_16: 1474 BuiltinIndex = 9; 1475 break; 1476 1477 case Builtin::BI__sync_val_compare_and_swap: 1478 case Builtin::BI__sync_val_compare_and_swap_1: 1479 case Builtin::BI__sync_val_compare_and_swap_2: 1480 case Builtin::BI__sync_val_compare_and_swap_4: 1481 case Builtin::BI__sync_val_compare_and_swap_8: 1482 case Builtin::BI__sync_val_compare_and_swap_16: 1483 BuiltinIndex = 10; 1484 NumFixed = 2; 1485 break; 1486 1487 case Builtin::BI__sync_bool_compare_and_swap: 1488 case Builtin::BI__sync_bool_compare_and_swap_1: 1489 case Builtin::BI__sync_bool_compare_and_swap_2: 1490 case Builtin::BI__sync_bool_compare_and_swap_4: 1491 case Builtin::BI__sync_bool_compare_and_swap_8: 1492 case Builtin::BI__sync_bool_compare_and_swap_16: 1493 BuiltinIndex = 11; 1494 NumFixed = 2; 1495 ResultType = Context.BoolTy; 1496 break; 1497 1498 case Builtin::BI__sync_lock_test_and_set: 1499 case Builtin::BI__sync_lock_test_and_set_1: 1500 case Builtin::BI__sync_lock_test_and_set_2: 1501 case Builtin::BI__sync_lock_test_and_set_4: 1502 case Builtin::BI__sync_lock_test_and_set_8: 1503 case Builtin::BI__sync_lock_test_and_set_16: 1504 BuiltinIndex = 12; 1505 break; 1506 1507 case Builtin::BI__sync_lock_release: 1508 case Builtin::BI__sync_lock_release_1: 1509 case Builtin::BI__sync_lock_release_2: 1510 case Builtin::BI__sync_lock_release_4: 1511 case Builtin::BI__sync_lock_release_8: 1512 case Builtin::BI__sync_lock_release_16: 1513 BuiltinIndex = 13; 1514 NumFixed = 0; 1515 ResultType = Context.VoidTy; 1516 break; 1517 1518 case Builtin::BI__sync_swap: 1519 case Builtin::BI__sync_swap_1: 1520 case Builtin::BI__sync_swap_2: 1521 case Builtin::BI__sync_swap_4: 1522 case Builtin::BI__sync_swap_8: 1523 case Builtin::BI__sync_swap_16: 1524 BuiltinIndex = 14; 1525 break; 1526 } 1527 1528 // Now that we know how many fixed arguments we expect, first check that we 1529 // have at least that many. 1530 if (TheCall->getNumArgs() < 1+NumFixed) { 1531 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 1532 << 0 << 1+NumFixed << TheCall->getNumArgs() 1533 << TheCall->getCallee()->getSourceRange(); 1534 return ExprError(); 1535 } 1536 1537 // Get the decl for the concrete builtin from this, we can tell what the 1538 // concrete integer type we should convert to is. 1539 unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 1540 const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 1541 FunctionDecl *NewBuiltinDecl; 1542 if (NewBuiltinID == BuiltinID) 1543 NewBuiltinDecl = FDecl; 1544 else { 1545 // Perform builtin lookup to avoid redeclaring it. 1546 DeclarationName DN(&Context.Idents.get(NewBuiltinName)); 1547 LookupResult Res(*this, DN, DRE->getLocStart(), LookupOrdinaryName); 1548 LookupName(Res, TUScope, /*AllowBuiltinCreation=*/true); 1549 assert(Res.getFoundDecl()); 1550 NewBuiltinDecl = dyn_cast<FunctionDecl>(Res.getFoundDecl()); 1551 if (NewBuiltinDecl == 0) 1552 return ExprError(); 1553 } 1554 1555 // The first argument --- the pointer --- has a fixed type; we 1556 // deduce the types of the rest of the arguments accordingly. Walk 1557 // the remaining arguments, converting them to the deduced value type. 1558 for (unsigned i = 0; i != NumFixed; ++i) { 1559 ExprResult Arg = TheCall->getArg(i+1); 1560 1561 // GCC does an implicit conversion to the pointer or integer ValType. This 1562 // can fail in some cases (1i -> int**), check for this error case now. 1563 // Initialize the argument. 1564 InitializedEntity Entity = InitializedEntity::InitializeParameter(Context, 1565 ValType, /*consume*/ false); 1566 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 1567 if (Arg.isInvalid()) 1568 return ExprError(); 1569 1570 // Okay, we have something that *can* be converted to the right type. Check 1571 // to see if there is a potentially weird extension going on here. This can 1572 // happen when you do an atomic operation on something like an char* and 1573 // pass in 42. The 42 gets converted to char. This is even more strange 1574 // for things like 45.123 -> char, etc. 1575 // FIXME: Do this check. 1576 TheCall->setArg(i+1, Arg.take()); 1577 } 1578 1579 ASTContext& Context = this->getASTContext(); 1580 1581 // Create a new DeclRefExpr to refer to the new decl. 1582 DeclRefExpr* NewDRE = DeclRefExpr::Create( 1583 Context, 1584 DRE->getQualifierLoc(), 1585 SourceLocation(), 1586 NewBuiltinDecl, 1587 /*enclosing*/ false, 1588 DRE->getLocation(), 1589 Context.BuiltinFnTy, 1590 DRE->getValueKind()); 1591 1592 // Set the callee in the CallExpr. 1593 // FIXME: This loses syntactic information. 1594 QualType CalleePtrTy = Context.getPointerType(NewBuiltinDecl->getType()); 1595 ExprResult PromotedCall = ImpCastExprToType(NewDRE, CalleePtrTy, 1596 CK_BuiltinFnToFnPtr); 1597 TheCall->setCallee(PromotedCall.take()); 1598 1599 // Change the result type of the call to match the original value type. This 1600 // is arbitrary, but the codegen for these builtins ins design to handle it 1601 // gracefully. 1602 TheCall->setType(ResultType); 1603 1604 return TheCallResult; 1605 } 1606 1607 /// CheckObjCString - Checks that the argument to the builtin 1608 /// CFString constructor is correct 1609 /// Note: It might also make sense to do the UTF-16 conversion here (would 1610 /// simplify the backend). 1611 bool Sema::CheckObjCString(Expr *Arg) { 1612 Arg = Arg->IgnoreParenCasts(); 1613 StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 1614 1615 if (!Literal || !Literal->isAscii()) { 1616 Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 1617 << Arg->getSourceRange(); 1618 return true; 1619 } 1620 1621 if (Literal->containsNonAsciiOrNull()) { 1622 StringRef String = Literal->getString(); 1623 unsigned NumBytes = String.size(); 1624 SmallVector<UTF16, 128> ToBuf(NumBytes); 1625 const UTF8 *FromPtr = (const UTF8 *)String.data(); 1626 UTF16 *ToPtr = &ToBuf[0]; 1627 1628 ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 1629 &ToPtr, ToPtr + NumBytes, 1630 strictConversion); 1631 // Check for conversion failure. 1632 if (Result != conversionOK) 1633 Diag(Arg->getLocStart(), 1634 diag::warn_cfstring_truncated) << Arg->getSourceRange(); 1635 } 1636 return false; 1637 } 1638 1639 /// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 1640 /// Emit an error and return true on failure, return false on success. 1641 bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 1642 Expr *Fn = TheCall->getCallee(); 1643 if (TheCall->getNumArgs() > 2) { 1644 Diag(TheCall->getArg(2)->getLocStart(), 1645 diag::err_typecheck_call_too_many_args) 1646 << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1647 << Fn->getSourceRange() 1648 << SourceRange(TheCall->getArg(2)->getLocStart(), 1649 (*(TheCall->arg_end()-1))->getLocEnd()); 1650 return true; 1651 } 1652 1653 if (TheCall->getNumArgs() < 2) { 1654 return Diag(TheCall->getLocEnd(), 1655 diag::err_typecheck_call_too_few_args_at_least) 1656 << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 1657 } 1658 1659 // Type-check the first argument normally. 1660 if (checkBuiltinArgument(*this, TheCall, 0)) 1661 return true; 1662 1663 // Determine whether the current function is variadic or not. 1664 BlockScopeInfo *CurBlock = getCurBlock(); 1665 bool isVariadic; 1666 if (CurBlock) 1667 isVariadic = CurBlock->TheDecl->isVariadic(); 1668 else if (FunctionDecl *FD = getCurFunctionDecl()) 1669 isVariadic = FD->isVariadic(); 1670 else 1671 isVariadic = getCurMethodDecl()->isVariadic(); 1672 1673 if (!isVariadic) { 1674 Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 1675 return true; 1676 } 1677 1678 // Verify that the second argument to the builtin is the last argument of the 1679 // current function or method. 1680 bool SecondArgIsLastNamedArgument = false; 1681 const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 1682 1683 // These are valid if SecondArgIsLastNamedArgument is false after the next 1684 // block. 1685 QualType Type; 1686 SourceLocation ParamLoc; 1687 1688 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 1689 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 1690 // FIXME: This isn't correct for methods (results in bogus warning). 1691 // Get the last formal in the current function. 1692 const ParmVarDecl *LastArg; 1693 if (CurBlock) 1694 LastArg = *(CurBlock->TheDecl->param_end()-1); 1695 else if (FunctionDecl *FD = getCurFunctionDecl()) 1696 LastArg = *(FD->param_end()-1); 1697 else 1698 LastArg = *(getCurMethodDecl()->param_end()-1); 1699 SecondArgIsLastNamedArgument = PV == LastArg; 1700 1701 Type = PV->getType(); 1702 ParamLoc = PV->getLocation(); 1703 } 1704 } 1705 1706 if (!SecondArgIsLastNamedArgument) 1707 Diag(TheCall->getArg(1)->getLocStart(), 1708 diag::warn_second_parameter_of_va_start_not_last_named_argument); 1709 else if (Type->isReferenceType()) { 1710 Diag(Arg->getLocStart(), 1711 diag::warn_va_start_of_reference_type_is_undefined); 1712 Diag(ParamLoc, diag::note_parameter_type) << Type; 1713 } 1714 1715 TheCall->setType(Context.VoidTy); 1716 return false; 1717 } 1718 1719 /// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 1720 /// friends. This is declared to take (...), so we have to check everything. 1721 bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 1722 if (TheCall->getNumArgs() < 2) 1723 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1724 << 0 << 2 << TheCall->getNumArgs()/*function call*/; 1725 if (TheCall->getNumArgs() > 2) 1726 return Diag(TheCall->getArg(2)->getLocStart(), 1727 diag::err_typecheck_call_too_many_args) 1728 << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1729 << SourceRange(TheCall->getArg(2)->getLocStart(), 1730 (*(TheCall->arg_end()-1))->getLocEnd()); 1731 1732 ExprResult OrigArg0 = TheCall->getArg(0); 1733 ExprResult OrigArg1 = TheCall->getArg(1); 1734 1735 // Do standard promotions between the two arguments, returning their common 1736 // type. 1737 QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 1738 if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 1739 return true; 1740 1741 // Make sure any conversions are pushed back into the call; this is 1742 // type safe since unordered compare builtins are declared as "_Bool 1743 // foo(...)". 1744 TheCall->setArg(0, OrigArg0.get()); 1745 TheCall->setArg(1, OrigArg1.get()); 1746 1747 if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 1748 return false; 1749 1750 // If the common type isn't a real floating type, then the arguments were 1751 // invalid for this operation. 1752 if (Res.isNull() || !Res->isRealFloatingType()) 1753 return Diag(OrigArg0.get()->getLocStart(), 1754 diag::err_typecheck_call_invalid_ordered_compare) 1755 << OrigArg0.get()->getType() << OrigArg1.get()->getType() 1756 << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 1757 1758 return false; 1759 } 1760 1761 /// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 1762 /// __builtin_isnan and friends. This is declared to take (...), so we have 1763 /// to check everything. We expect the last argument to be a floating point 1764 /// value. 1765 bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 1766 if (TheCall->getNumArgs() < NumArgs) 1767 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1768 << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 1769 if (TheCall->getNumArgs() > NumArgs) 1770 return Diag(TheCall->getArg(NumArgs)->getLocStart(), 1771 diag::err_typecheck_call_too_many_args) 1772 << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 1773 << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 1774 (*(TheCall->arg_end()-1))->getLocEnd()); 1775 1776 Expr *OrigArg = TheCall->getArg(NumArgs-1); 1777 1778 if (OrigArg->isTypeDependent()) 1779 return false; 1780 1781 // This operation requires a non-_Complex floating-point number. 1782 if (!OrigArg->getType()->isRealFloatingType()) 1783 return Diag(OrigArg->getLocStart(), 1784 diag::err_typecheck_call_invalid_unary_fp) 1785 << OrigArg->getType() << OrigArg->getSourceRange(); 1786 1787 // If this is an implicit conversion from float -> double, remove it. 1788 if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 1789 Expr *CastArg = Cast->getSubExpr(); 1790 if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 1791 assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 1792 "promotion from float to double is the only expected cast here"); 1793 Cast->setSubExpr(0); 1794 TheCall->setArg(NumArgs-1, CastArg); 1795 } 1796 } 1797 1798 return false; 1799 } 1800 1801 /// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 1802 // This is declared to take (...), so we have to check everything. 1803 ExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 1804 if (TheCall->getNumArgs() < 2) 1805 return ExprError(Diag(TheCall->getLocEnd(), 1806 diag::err_typecheck_call_too_few_args_at_least) 1807 << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1808 << TheCall->getSourceRange()); 1809 1810 // Determine which of the following types of shufflevector we're checking: 1811 // 1) unary, vector mask: (lhs, mask) 1812 // 2) binary, vector mask: (lhs, rhs, mask) 1813 // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 1814 QualType resType = TheCall->getArg(0)->getType(); 1815 unsigned numElements = 0; 1816 1817 if (!TheCall->getArg(0)->isTypeDependent() && 1818 !TheCall->getArg(1)->isTypeDependent()) { 1819 QualType LHSType = TheCall->getArg(0)->getType(); 1820 QualType RHSType = TheCall->getArg(1)->getType(); 1821 1822 if (!LHSType->isVectorType() || !RHSType->isVectorType()) 1823 return ExprError(Diag(TheCall->getLocStart(), 1824 diag::err_shufflevector_non_vector) 1825 << SourceRange(TheCall->getArg(0)->getLocStart(), 1826 TheCall->getArg(1)->getLocEnd())); 1827 1828 numElements = LHSType->getAs<VectorType>()->getNumElements(); 1829 unsigned numResElements = TheCall->getNumArgs() - 2; 1830 1831 // Check to see if we have a call with 2 vector arguments, the unary shuffle 1832 // with mask. If so, verify that RHS is an integer vector type with the 1833 // same number of elts as lhs. 1834 if (TheCall->getNumArgs() == 2) { 1835 if (!RHSType->hasIntegerRepresentation() || 1836 RHSType->getAs<VectorType>()->getNumElements() != numElements) 1837 return ExprError(Diag(TheCall->getLocStart(), 1838 diag::err_shufflevector_incompatible_vector) 1839 << SourceRange(TheCall->getArg(1)->getLocStart(), 1840 TheCall->getArg(1)->getLocEnd())); 1841 } else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 1842 return ExprError(Diag(TheCall->getLocStart(), 1843 diag::err_shufflevector_incompatible_vector) 1844 << SourceRange(TheCall->getArg(0)->getLocStart(), 1845 TheCall->getArg(1)->getLocEnd())); 1846 } else if (numElements != numResElements) { 1847 QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 1848 resType = Context.getVectorType(eltType, numResElements, 1849 VectorType::GenericVector); 1850 } 1851 } 1852 1853 for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 1854 if (TheCall->getArg(i)->isTypeDependent() || 1855 TheCall->getArg(i)->isValueDependent()) 1856 continue; 1857 1858 llvm::APSInt Result(32); 1859 if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 1860 return ExprError(Diag(TheCall->getLocStart(), 1861 diag::err_shufflevector_nonconstant_argument) 1862 << TheCall->getArg(i)->getSourceRange()); 1863 1864 // Allow -1 which will be translated to undef in the IR. 1865 if (Result.isSigned() && Result.isAllOnesValue()) 1866 continue; 1867 1868 if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 1869 return ExprError(Diag(TheCall->getLocStart(), 1870 diag::err_shufflevector_argument_too_large) 1871 << TheCall->getArg(i)->getSourceRange()); 1872 } 1873 1874 SmallVector<Expr*, 32> exprs; 1875 1876 for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 1877 exprs.push_back(TheCall->getArg(i)); 1878 TheCall->setArg(i, 0); 1879 } 1880 1881 return Owned(new (Context) ShuffleVectorExpr(Context, exprs, resType, 1882 TheCall->getCallee()->getLocStart(), 1883 TheCall->getRParenLoc())); 1884 } 1885 1886 /// SemaConvertVectorExpr - Handle __builtin_convertvector 1887 ExprResult Sema::SemaConvertVectorExpr(Expr *E, TypeSourceInfo *TInfo, 1888 SourceLocation BuiltinLoc, 1889 SourceLocation RParenLoc) { 1890 ExprValueKind VK = VK_RValue; 1891 ExprObjectKind OK = OK_Ordinary; 1892 QualType DstTy = TInfo->getType(); 1893 QualType SrcTy = E->getType(); 1894 1895 if (!SrcTy->isVectorType() && !SrcTy->isDependentType()) 1896 return ExprError(Diag(BuiltinLoc, 1897 diag::err_convertvector_non_vector) 1898 << E->getSourceRange()); 1899 if (!DstTy->isVectorType() && !DstTy->isDependentType()) 1900 return ExprError(Diag(BuiltinLoc, 1901 diag::err_convertvector_non_vector_type)); 1902 1903 if (!SrcTy->isDependentType() && !DstTy->isDependentType()) { 1904 unsigned SrcElts = SrcTy->getAs<VectorType>()->getNumElements(); 1905 unsigned DstElts = DstTy->getAs<VectorType>()->getNumElements(); 1906 if (SrcElts != DstElts) 1907 return ExprError(Diag(BuiltinLoc, 1908 diag::err_convertvector_incompatible_vector) 1909 << E->getSourceRange()); 1910 } 1911 1912 return Owned(new (Context) ConvertVectorExpr(E, TInfo, DstTy, VK, OK, 1913 BuiltinLoc, RParenLoc)); 1914 1915 } 1916 1917 /// SemaBuiltinPrefetch - Handle __builtin_prefetch. 1918 // This is declared to take (const void*, ...) and can take two 1919 // optional constant int args. 1920 bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 1921 unsigned NumArgs = TheCall->getNumArgs(); 1922 1923 if (NumArgs > 3) 1924 return Diag(TheCall->getLocEnd(), 1925 diag::err_typecheck_call_too_many_args_at_most) 1926 << 0 /*function call*/ << 3 << NumArgs 1927 << TheCall->getSourceRange(); 1928 1929 // Argument 0 is checked for us and the remaining arguments must be 1930 // constant integers. 1931 for (unsigned i = 1; i != NumArgs; ++i) { 1932 Expr *Arg = TheCall->getArg(i); 1933 1934 // We can't check the value of a dependent argument. 1935 if (Arg->isTypeDependent() || Arg->isValueDependent()) 1936 continue; 1937 1938 llvm::APSInt Result; 1939 if (SemaBuiltinConstantArg(TheCall, i, Result)) 1940 return true; 1941 1942 // FIXME: gcc issues a warning and rewrites these to 0. These 1943 // seems especially odd for the third argument since the default 1944 // is 3. 1945 if (i == 1) { 1946 if (Result.getLimitedValue() > 1) 1947 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 1948 << "0" << "1" << Arg->getSourceRange(); 1949 } else { 1950 if (Result.getLimitedValue() > 3) 1951 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 1952 << "0" << "3" << Arg->getSourceRange(); 1953 } 1954 } 1955 1956 return false; 1957 } 1958 1959 /// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 1960 /// TheCall is a constant expression. 1961 bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 1962 llvm::APSInt &Result) { 1963 Expr *Arg = TheCall->getArg(ArgNum); 1964 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 1965 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 1966 1967 if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 1968 1969 if (!Arg->isIntegerConstantExpr(Result, Context)) 1970 return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 1971 << FDecl->getDeclName() << Arg->getSourceRange(); 1972 1973 return false; 1974 } 1975 1976 /// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 1977 /// int type). This simply type checks that type is one of the defined 1978 /// constants (0-3). 1979 // For compatibility check 0-3, llvm only handles 0 and 2. 1980 bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 1981 llvm::APSInt Result; 1982 1983 // We can't check the value of a dependent argument. 1984 if (TheCall->getArg(1)->isTypeDependent() || 1985 TheCall->getArg(1)->isValueDependent()) 1986 return false; 1987 1988 // Check constant-ness first. 1989 if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1990 return true; 1991 1992 Expr *Arg = TheCall->getArg(1); 1993 if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 1994 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 1995 << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1996 } 1997 1998 return false; 1999 } 2000 2001 /// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 2002 /// This checks that val is a constant 1. 2003 bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 2004 Expr *Arg = TheCall->getArg(1); 2005 llvm::APSInt Result; 2006 2007 // TODO: This is less than ideal. Overload this to take a value. 2008 if (SemaBuiltinConstantArg(TheCall, 1, Result)) 2009 return true; 2010 2011 if (Result != 1) 2012 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 2013 << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 2014 2015 return false; 2016 } 2017 2018 namespace { 2019 enum StringLiteralCheckType { 2020 SLCT_NotALiteral, 2021 SLCT_UncheckedLiteral, 2022 SLCT_CheckedLiteral 2023 }; 2024 } 2025 2026 // Determine if an expression is a string literal or constant string. 2027 // If this function returns false on the arguments to a function expecting a 2028 // format string, we will usually need to emit a warning. 2029 // True string literals are then checked by CheckFormatString. 2030 static StringLiteralCheckType 2031 checkFormatStringExpr(Sema &S, const Expr *E, ArrayRef<const Expr *> Args, 2032 bool HasVAListArg, unsigned format_idx, 2033 unsigned firstDataArg, Sema::FormatStringType Type, 2034 Sema::VariadicCallType CallType, bool InFunctionCall, 2035 llvm::SmallBitVector &CheckedVarArgs) { 2036 tryAgain: 2037 if (E->isTypeDependent() || E->isValueDependent()) 2038 return SLCT_NotALiteral; 2039 2040 E = E->IgnoreParenCasts(); 2041 2042 if (E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull)) 2043 // Technically -Wformat-nonliteral does not warn about this case. 2044 // The behavior of printf and friends in this case is implementation 2045 // dependent. Ideally if the format string cannot be null then 2046 // it should have a 'nonnull' attribute in the function prototype. 2047 return SLCT_UncheckedLiteral; 2048 2049 switch (E->getStmtClass()) { 2050 case Stmt::BinaryConditionalOperatorClass: 2051 case Stmt::ConditionalOperatorClass: { 2052 // The expression is a literal if both sub-expressions were, and it was 2053 // completely checked only if both sub-expressions were checked. 2054 const AbstractConditionalOperator *C = 2055 cast<AbstractConditionalOperator>(E); 2056 StringLiteralCheckType Left = 2057 checkFormatStringExpr(S, C->getTrueExpr(), Args, 2058 HasVAListArg, format_idx, firstDataArg, 2059 Type, CallType, InFunctionCall, CheckedVarArgs); 2060 if (Left == SLCT_NotALiteral) 2061 return SLCT_NotALiteral; 2062 StringLiteralCheckType Right = 2063 checkFormatStringExpr(S, C->getFalseExpr(), Args, 2064 HasVAListArg, format_idx, firstDataArg, 2065 Type, CallType, InFunctionCall, CheckedVarArgs); 2066 return Left < Right ? Left : Right; 2067 } 2068 2069 case Stmt::ImplicitCastExprClass: { 2070 E = cast<ImplicitCastExpr>(E)->getSubExpr(); 2071 goto tryAgain; 2072 } 2073 2074 case Stmt::OpaqueValueExprClass: 2075 if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 2076 E = src; 2077 goto tryAgain; 2078 } 2079 return SLCT_NotALiteral; 2080 2081 case Stmt::PredefinedExprClass: 2082 // While __func__, etc., are technically not string literals, they 2083 // cannot contain format specifiers and thus are not a security 2084 // liability. 2085 return SLCT_UncheckedLiteral; 2086 2087 case Stmt::DeclRefExprClass: { 2088 const DeclRefExpr *DR = cast<DeclRefExpr>(E); 2089 2090 // As an exception, do not flag errors for variables binding to 2091 // const string literals. 2092 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 2093 bool isConstant = false; 2094 QualType T = DR->getType(); 2095 2096 if (const ArrayType *AT = S.Context.getAsArrayType(T)) { 2097 isConstant = AT->getElementType().isConstant(S.Context); 2098 } else if (const PointerType *PT = T->getAs<PointerType>()) { 2099 isConstant = T.isConstant(S.Context) && 2100 PT->getPointeeType().isConstant(S.Context); 2101 } else if (T->isObjCObjectPointerType()) { 2102 // In ObjC, there is usually no "const ObjectPointer" type, 2103 // so don't check if the pointee type is constant. 2104 isConstant = T.isConstant(S.Context); 2105 } 2106 2107 if (isConstant) { 2108 if (const Expr *Init = VD->getAnyInitializer()) { 2109 // Look through initializers like const char c[] = { "foo" } 2110 if (const InitListExpr *InitList = dyn_cast<InitListExpr>(Init)) { 2111 if (InitList->isStringLiteralInit()) 2112 Init = InitList->getInit(0)->IgnoreParenImpCasts(); 2113 } 2114 return checkFormatStringExpr(S, Init, Args, 2115 HasVAListArg, format_idx, 2116 firstDataArg, Type, CallType, 2117 /*InFunctionCall*/false, CheckedVarArgs); 2118 } 2119 } 2120 2121 // For vprintf* functions (i.e., HasVAListArg==true), we add a 2122 // special check to see if the format string is a function parameter 2123 // of the function calling the printf function. If the function 2124 // has an attribute indicating it is a printf-like function, then we 2125 // should suppress warnings concerning non-literals being used in a call 2126 // to a vprintf function. For example: 2127 // 2128 // void 2129 // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 2130 // va_list ap; 2131 // va_start(ap, fmt); 2132 // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 2133 // ... 2134 // } 2135 if (HasVAListArg) { 2136 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) { 2137 if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) { 2138 int PVIndex = PV->getFunctionScopeIndex() + 1; 2139 for (specific_attr_iterator<FormatAttr> 2140 i = ND->specific_attr_begin<FormatAttr>(), 2141 e = ND->specific_attr_end<FormatAttr>(); i != e ; ++i) { 2142 FormatAttr *PVFormat = *i; 2143 // adjust for implicit parameter 2144 if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 2145 if (MD->isInstance()) 2146 ++PVIndex; 2147 // We also check if the formats are compatible. 2148 // We can't pass a 'scanf' string to a 'printf' function. 2149 if (PVIndex == PVFormat->getFormatIdx() && 2150 Type == S.GetFormatStringType(PVFormat)) 2151 return SLCT_UncheckedLiteral; 2152 } 2153 } 2154 } 2155 } 2156 } 2157 2158 return SLCT_NotALiteral; 2159 } 2160 2161 case Stmt::CallExprClass: 2162 case Stmt::CXXMemberCallExprClass: { 2163 const CallExpr *CE = cast<CallExpr>(E); 2164 if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) { 2165 if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) { 2166 unsigned ArgIndex = FA->getFormatIdx(); 2167 if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 2168 if (MD->isInstance()) 2169 --ArgIndex; 2170 const Expr *Arg = CE->getArg(ArgIndex - 1); 2171 2172 return checkFormatStringExpr(S, Arg, Args, 2173 HasVAListArg, format_idx, firstDataArg, 2174 Type, CallType, InFunctionCall, 2175 CheckedVarArgs); 2176 } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) { 2177 unsigned BuiltinID = FD->getBuiltinID(); 2178 if (BuiltinID == Builtin::BI__builtin___CFStringMakeConstantString || 2179 BuiltinID == Builtin::BI__builtin___NSStringMakeConstantString) { 2180 const Expr *Arg = CE->getArg(0); 2181 return checkFormatStringExpr(S, Arg, Args, 2182 HasVAListArg, format_idx, 2183 firstDataArg, Type, CallType, 2184 InFunctionCall, CheckedVarArgs); 2185 } 2186 } 2187 } 2188 2189 return SLCT_NotALiteral; 2190 } 2191 2192 case Stmt::ObjCMessageExprClass: { 2193 const ObjCMessageExpr *ME = cast<ObjCMessageExpr>(E); 2194 if (const ObjCMethodDecl *MDecl = ME->getMethodDecl()) { 2195 if (const NamedDecl *ND = dyn_cast<NamedDecl>(MDecl)) { 2196 if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) { 2197 unsigned ArgIndex = FA->getFormatIdx(); 2198 if (ArgIndex <= ME->getNumArgs()) { 2199 const Expr *Arg = ME->getArg(ArgIndex-1); 2200 return checkFormatStringExpr(S, Arg, Args, 2201 HasVAListArg, format_idx, 2202 firstDataArg, Type, CallType, 2203 InFunctionCall, CheckedVarArgs); 2204 } 2205 } 2206 } 2207 } 2208 2209 return SLCT_NotALiteral; 2210 } 2211 2212 case Stmt::ObjCStringLiteralClass: 2213 case Stmt::StringLiteralClass: { 2214 const StringLiteral *StrE = NULL; 2215 2216 if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 2217 StrE = ObjCFExpr->getString(); 2218 else 2219 StrE = cast<StringLiteral>(E); 2220 2221 if (StrE) { 2222 S.CheckFormatString(StrE, E, Args, HasVAListArg, format_idx, firstDataArg, 2223 Type, InFunctionCall, CallType, CheckedVarArgs); 2224 return SLCT_CheckedLiteral; 2225 } 2226 2227 return SLCT_NotALiteral; 2228 } 2229 2230 default: 2231 return SLCT_NotALiteral; 2232 } 2233 } 2234 2235 Sema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) { 2236 return llvm::StringSwitch<FormatStringType>(Format->getType()->getName()) 2237 .Case("scanf", FST_Scanf) 2238 .Cases("printf", "printf0", FST_Printf) 2239 .Cases("NSString", "CFString", FST_NSString) 2240 .Case("strftime", FST_Strftime) 2241 .Case("strfmon", FST_Strfmon) 2242 .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf) 2243 .Default(FST_Unknown); 2244 } 2245 2246 /// CheckFormatArguments - Check calls to printf and scanf (and similar 2247 /// functions) for correct use of format strings. 2248 /// Returns true if a format string has been fully checked. 2249 bool Sema::CheckFormatArguments(const FormatAttr *Format, 2250 ArrayRef<const Expr *> Args, 2251 bool IsCXXMember, 2252 VariadicCallType CallType, 2253 SourceLocation Loc, SourceRange Range, 2254 llvm::SmallBitVector &CheckedVarArgs) { 2255 FormatStringInfo FSI; 2256 if (getFormatStringInfo(Format, IsCXXMember, &FSI)) 2257 return CheckFormatArguments(Args, FSI.HasVAListArg, FSI.FormatIdx, 2258 FSI.FirstDataArg, GetFormatStringType(Format), 2259 CallType, Loc, Range, CheckedVarArgs); 2260 return false; 2261 } 2262 2263 bool Sema::CheckFormatArguments(ArrayRef<const Expr *> Args, 2264 bool HasVAListArg, unsigned format_idx, 2265 unsigned firstDataArg, FormatStringType Type, 2266 VariadicCallType CallType, 2267 SourceLocation Loc, SourceRange Range, 2268 llvm::SmallBitVector &CheckedVarArgs) { 2269 // CHECK: printf/scanf-like function is called with no format string. 2270 if (format_idx >= Args.size()) { 2271 Diag(Loc, diag::warn_missing_format_string) << Range; 2272 return false; 2273 } 2274 2275 const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts(); 2276 2277 // CHECK: format string is not a string literal. 2278 // 2279 // Dynamically generated format strings are difficult to 2280 // automatically vet at compile time. Requiring that format strings 2281 // are string literals: (1) permits the checking of format strings by 2282 // the compiler and thereby (2) can practically remove the source of 2283 // many format string exploits. 2284 2285 // Format string can be either ObjC string (e.g. @"%d") or 2286 // C string (e.g. "%d") 2287 // ObjC string uses the same format specifiers as C string, so we can use 2288 // the same format string checking logic for both ObjC and C strings. 2289 StringLiteralCheckType CT = 2290 checkFormatStringExpr(*this, OrigFormatExpr, Args, HasVAListArg, 2291 format_idx, firstDataArg, Type, CallType, 2292 /*IsFunctionCall*/true, CheckedVarArgs); 2293 if (CT != SLCT_NotALiteral) 2294 // Literal format string found, check done! 2295 return CT == SLCT_CheckedLiteral; 2296 2297 // Strftime is particular as it always uses a single 'time' argument, 2298 // so it is safe to pass a non-literal string. 2299 if (Type == FST_Strftime) 2300 return false; 2301 2302 // Do not emit diag when the string param is a macro expansion and the 2303 // format is either NSString or CFString. This is a hack to prevent 2304 // diag when using the NSLocalizedString and CFCopyLocalizedString macros 2305 // which are usually used in place of NS and CF string literals. 2306 if (Type == FST_NSString && 2307 SourceMgr.isInSystemMacro(Args[format_idx]->getLocStart())) 2308 return false; 2309 2310 // If there are no arguments specified, warn with -Wformat-security, otherwise 2311 // warn only with -Wformat-nonliteral. 2312 if (Args.size() == firstDataArg) 2313 Diag(Args[format_idx]->getLocStart(), 2314 diag::warn_format_nonliteral_noargs) 2315 << OrigFormatExpr->getSourceRange(); 2316 else 2317 Diag(Args[format_idx]->getLocStart(), 2318 diag::warn_format_nonliteral) 2319 << OrigFormatExpr->getSourceRange(); 2320 return false; 2321 } 2322 2323 namespace { 2324 class CheckFormatHandler : public analyze_format_string::FormatStringHandler { 2325 protected: 2326 Sema &S; 2327 const StringLiteral *FExpr; 2328 const Expr *OrigFormatExpr; 2329 const unsigned FirstDataArg; 2330 const unsigned NumDataArgs; 2331 const char *Beg; // Start of format string. 2332 const bool HasVAListArg; 2333 ArrayRef<const Expr *> Args; 2334 unsigned FormatIdx; 2335 llvm::SmallBitVector CoveredArgs; 2336 bool usesPositionalArgs; 2337 bool atFirstArg; 2338 bool inFunctionCall; 2339 Sema::VariadicCallType CallType; 2340 llvm::SmallBitVector &CheckedVarArgs; 2341 public: 2342 CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 2343 const Expr *origFormatExpr, unsigned firstDataArg, 2344 unsigned numDataArgs, const char *beg, bool hasVAListArg, 2345 ArrayRef<const Expr *> Args, 2346 unsigned formatIdx, bool inFunctionCall, 2347 Sema::VariadicCallType callType, 2348 llvm::SmallBitVector &CheckedVarArgs) 2349 : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 2350 FirstDataArg(firstDataArg), NumDataArgs(numDataArgs), 2351 Beg(beg), HasVAListArg(hasVAListArg), 2352 Args(Args), FormatIdx(formatIdx), 2353 usesPositionalArgs(false), atFirstArg(true), 2354 inFunctionCall(inFunctionCall), CallType(callType), 2355 CheckedVarArgs(CheckedVarArgs) { 2356 CoveredArgs.resize(numDataArgs); 2357 CoveredArgs.reset(); 2358 } 2359 2360 void DoneProcessing(); 2361 2362 void HandleIncompleteSpecifier(const char *startSpecifier, 2363 unsigned specifierLen); 2364 2365 void HandleInvalidLengthModifier( 2366 const analyze_format_string::FormatSpecifier &FS, 2367 const analyze_format_string::ConversionSpecifier &CS, 2368 const char *startSpecifier, unsigned specifierLen, unsigned DiagID); 2369 2370 void HandleNonStandardLengthModifier( 2371 const analyze_format_string::FormatSpecifier &FS, 2372 const char *startSpecifier, unsigned specifierLen); 2373 2374 void HandleNonStandardConversionSpecifier( 2375 const analyze_format_string::ConversionSpecifier &CS, 2376 const char *startSpecifier, unsigned specifierLen); 2377 2378 virtual void HandlePosition(const char *startPos, unsigned posLen); 2379 2380 virtual void HandleInvalidPosition(const char *startSpecifier, 2381 unsigned specifierLen, 2382 analyze_format_string::PositionContext p); 2383 2384 virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 2385 2386 void HandleNullChar(const char *nullCharacter); 2387 2388 template <typename Range> 2389 static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall, 2390 const Expr *ArgumentExpr, 2391 PartialDiagnostic PDiag, 2392 SourceLocation StringLoc, 2393 bool IsStringLocation, Range StringRange, 2394 ArrayRef<FixItHint> Fixit = None); 2395 2396 protected: 2397 bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 2398 const char *startSpec, 2399 unsigned specifierLen, 2400 const char *csStart, unsigned csLen); 2401 2402 void HandlePositionalNonpositionalArgs(SourceLocation Loc, 2403 const char *startSpec, 2404 unsigned specifierLen); 2405 2406 SourceRange getFormatStringRange(); 2407 CharSourceRange getSpecifierRange(const char *startSpecifier, 2408 unsigned specifierLen); 2409 SourceLocation getLocationOfByte(const char *x); 2410 2411 const Expr *getDataArg(unsigned i) const; 2412 2413 bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 2414 const analyze_format_string::ConversionSpecifier &CS, 2415 const char *startSpecifier, unsigned specifierLen, 2416 unsigned argIndex); 2417 2418 template <typename Range> 2419 void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc, 2420 bool IsStringLocation, Range StringRange, 2421 ArrayRef<FixItHint> Fixit = None); 2422 2423 void CheckPositionalAndNonpositionalArgs( 2424 const analyze_format_string::FormatSpecifier *FS); 2425 }; 2426 } 2427 2428 SourceRange CheckFormatHandler::getFormatStringRange() { 2429 return OrigFormatExpr->getSourceRange(); 2430 } 2431 2432 CharSourceRange CheckFormatHandler:: 2433 getSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 2434 SourceLocation Start = getLocationOfByte(startSpecifier); 2435 SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 2436 2437 // Advance the end SourceLocation by one due to half-open ranges. 2438 End = End.getLocWithOffset(1); 2439 2440 return CharSourceRange::getCharRange(Start, End); 2441 } 2442 2443 SourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 2444 return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 2445 } 2446 2447 void CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 2448 unsigned specifierLen){ 2449 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier), 2450 getLocationOfByte(startSpecifier), 2451 /*IsStringLocation*/true, 2452 getSpecifierRange(startSpecifier, specifierLen)); 2453 } 2454 2455 void CheckFormatHandler::HandleInvalidLengthModifier( 2456 const analyze_format_string::FormatSpecifier &FS, 2457 const analyze_format_string::ConversionSpecifier &CS, 2458 const char *startSpecifier, unsigned specifierLen, unsigned DiagID) { 2459 using namespace analyze_format_string; 2460 2461 const LengthModifier &LM = FS.getLengthModifier(); 2462 CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength()); 2463 2464 // See if we know how to fix this length modifier. 2465 Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier(); 2466 if (FixedLM) { 2467 EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(), 2468 getLocationOfByte(LM.getStart()), 2469 /*IsStringLocation*/true, 2470 getSpecifierRange(startSpecifier, specifierLen)); 2471 2472 S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier) 2473 << FixedLM->toString() 2474 << FixItHint::CreateReplacement(LMRange, FixedLM->toString()); 2475 2476 } else { 2477 FixItHint Hint; 2478 if (DiagID == diag::warn_format_nonsensical_length) 2479 Hint = FixItHint::CreateRemoval(LMRange); 2480 2481 EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(), 2482 getLocationOfByte(LM.getStart()), 2483 /*IsStringLocation*/true, 2484 getSpecifierRange(startSpecifier, specifierLen), 2485 Hint); 2486 } 2487 } 2488 2489 void CheckFormatHandler::HandleNonStandardLengthModifier( 2490 const analyze_format_string::FormatSpecifier &FS, 2491 const char *startSpecifier, unsigned specifierLen) { 2492 using namespace analyze_format_string; 2493 2494 const LengthModifier &LM = FS.getLengthModifier(); 2495 CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength()); 2496 2497 // See if we know how to fix this length modifier. 2498 Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier(); 2499 if (FixedLM) { 2500 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 2501 << LM.toString() << 0, 2502 getLocationOfByte(LM.getStart()), 2503 /*IsStringLocation*/true, 2504 getSpecifierRange(startSpecifier, specifierLen)); 2505 2506 S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier) 2507 << FixedLM->toString() 2508 << FixItHint::CreateReplacement(LMRange, FixedLM->toString()); 2509 2510 } else { 2511 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 2512 << LM.toString() << 0, 2513 getLocationOfByte(LM.getStart()), 2514 /*IsStringLocation*/true, 2515 getSpecifierRange(startSpecifier, specifierLen)); 2516 } 2517 } 2518 2519 void CheckFormatHandler::HandleNonStandardConversionSpecifier( 2520 const analyze_format_string::ConversionSpecifier &CS, 2521 const char *startSpecifier, unsigned specifierLen) { 2522 using namespace analyze_format_string; 2523 2524 // See if we know how to fix this conversion specifier. 2525 Optional<ConversionSpecifier> FixedCS = CS.getStandardSpecifier(); 2526 if (FixedCS) { 2527 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 2528 << CS.toString() << /*conversion specifier*/1, 2529 getLocationOfByte(CS.getStart()), 2530 /*IsStringLocation*/true, 2531 getSpecifierRange(startSpecifier, specifierLen)); 2532 2533 CharSourceRange CSRange = getSpecifierRange(CS.getStart(), CS.getLength()); 2534 S.Diag(getLocationOfByte(CS.getStart()), diag::note_format_fix_specifier) 2535 << FixedCS->toString() 2536 << FixItHint::CreateReplacement(CSRange, FixedCS->toString()); 2537 } else { 2538 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 2539 << CS.toString() << /*conversion specifier*/1, 2540 getLocationOfByte(CS.getStart()), 2541 /*IsStringLocation*/true, 2542 getSpecifierRange(startSpecifier, specifierLen)); 2543 } 2544 } 2545 2546 void CheckFormatHandler::HandlePosition(const char *startPos, 2547 unsigned posLen) { 2548 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg), 2549 getLocationOfByte(startPos), 2550 /*IsStringLocation*/true, 2551 getSpecifierRange(startPos, posLen)); 2552 } 2553 2554 void 2555 CheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 2556 analyze_format_string::PositionContext p) { 2557 EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier) 2558 << (unsigned) p, 2559 getLocationOfByte(startPos), /*IsStringLocation*/true, 2560 getSpecifierRange(startPos, posLen)); 2561 } 2562 2563 void CheckFormatHandler::HandleZeroPosition(const char *startPos, 2564 unsigned posLen) { 2565 EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier), 2566 getLocationOfByte(startPos), 2567 /*IsStringLocation*/true, 2568 getSpecifierRange(startPos, posLen)); 2569 } 2570 2571 void CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 2572 if (!isa<ObjCStringLiteral>(OrigFormatExpr)) { 2573 // The presence of a null character is likely an error. 2574 EmitFormatDiagnostic( 2575 S.PDiag(diag::warn_printf_format_string_contains_null_char), 2576 getLocationOfByte(nullCharacter), /*IsStringLocation*/true, 2577 getFormatStringRange()); 2578 } 2579 } 2580 2581 // Note that this may return NULL if there was an error parsing or building 2582 // one of the argument expressions. 2583 const Expr *CheckFormatHandler::getDataArg(unsigned i) const { 2584 return Args[FirstDataArg + i]; 2585 } 2586 2587 void CheckFormatHandler::DoneProcessing() { 2588 // Does the number of data arguments exceed the number of 2589 // format conversions in the format string? 2590 if (!HasVAListArg) { 2591 // Find any arguments that weren't covered. 2592 CoveredArgs.flip(); 2593 signed notCoveredArg = CoveredArgs.find_first(); 2594 if (notCoveredArg >= 0) { 2595 assert((unsigned)notCoveredArg < NumDataArgs); 2596 if (const Expr *E = getDataArg((unsigned) notCoveredArg)) { 2597 SourceLocation Loc = E->getLocStart(); 2598 if (!S.getSourceManager().isInSystemMacro(Loc)) { 2599 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used), 2600 Loc, /*IsStringLocation*/false, 2601 getFormatStringRange()); 2602 } 2603 } 2604 } 2605 } 2606 } 2607 2608 bool 2609 CheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 2610 SourceLocation Loc, 2611 const char *startSpec, 2612 unsigned specifierLen, 2613 const char *csStart, 2614 unsigned csLen) { 2615 2616 bool keepGoing = true; 2617 if (argIndex < NumDataArgs) { 2618 // Consider the argument coverered, even though the specifier doesn't 2619 // make sense. 2620 CoveredArgs.set(argIndex); 2621 } 2622 else { 2623 // If argIndex exceeds the number of data arguments we 2624 // don't issue a warning because that is just a cascade of warnings (and 2625 // they may have intended '%%' anyway). We don't want to continue processing 2626 // the format string after this point, however, as we will like just get 2627 // gibberish when trying to match arguments. 2628 keepGoing = false; 2629 } 2630 2631 EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion) 2632 << StringRef(csStart, csLen), 2633 Loc, /*IsStringLocation*/true, 2634 getSpecifierRange(startSpec, specifierLen)); 2635 2636 return keepGoing; 2637 } 2638 2639 void 2640 CheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc, 2641 const char *startSpec, 2642 unsigned specifierLen) { 2643 EmitFormatDiagnostic( 2644 S.PDiag(diag::warn_format_mix_positional_nonpositional_args), 2645 Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen)); 2646 } 2647 2648 bool 2649 CheckFormatHandler::CheckNumArgs( 2650 const analyze_format_string::FormatSpecifier &FS, 2651 const analyze_format_string::ConversionSpecifier &CS, 2652 const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 2653 2654 if (argIndex >= NumDataArgs) { 2655 PartialDiagnostic PDiag = FS.usesPositionalArg() 2656 ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args) 2657 << (argIndex+1) << NumDataArgs) 2658 : S.PDiag(diag::warn_printf_insufficient_data_args); 2659 EmitFormatDiagnostic( 2660 PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true, 2661 getSpecifierRange(startSpecifier, specifierLen)); 2662 return false; 2663 } 2664 return true; 2665 } 2666 2667 template<typename Range> 2668 void CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag, 2669 SourceLocation Loc, 2670 bool IsStringLocation, 2671 Range StringRange, 2672 ArrayRef<FixItHint> FixIt) { 2673 EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag, 2674 Loc, IsStringLocation, StringRange, FixIt); 2675 } 2676 2677 /// \brief If the format string is not within the funcion call, emit a note 2678 /// so that the function call and string are in diagnostic messages. 2679 /// 2680 /// \param InFunctionCall if true, the format string is within the function 2681 /// call and only one diagnostic message will be produced. Otherwise, an 2682 /// extra note will be emitted pointing to location of the format string. 2683 /// 2684 /// \param ArgumentExpr the expression that is passed as the format string 2685 /// argument in the function call. Used for getting locations when two 2686 /// diagnostics are emitted. 2687 /// 2688 /// \param PDiag the callee should already have provided any strings for the 2689 /// diagnostic message. This function only adds locations and fixits 2690 /// to diagnostics. 2691 /// 2692 /// \param Loc primary location for diagnostic. If two diagnostics are 2693 /// required, one will be at Loc and a new SourceLocation will be created for 2694 /// the other one. 2695 /// 2696 /// \param IsStringLocation if true, Loc points to the format string should be 2697 /// used for the note. Otherwise, Loc points to the argument list and will 2698 /// be used with PDiag. 2699 /// 2700 /// \param StringRange some or all of the string to highlight. This is 2701 /// templated so it can accept either a CharSourceRange or a SourceRange. 2702 /// 2703 /// \param FixIt optional fix it hint for the format string. 2704 template<typename Range> 2705 void CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall, 2706 const Expr *ArgumentExpr, 2707 PartialDiagnostic PDiag, 2708 SourceLocation Loc, 2709 bool IsStringLocation, 2710 Range StringRange, 2711 ArrayRef<FixItHint> FixIt) { 2712 if (InFunctionCall) { 2713 const Sema::SemaDiagnosticBuilder &D = S.Diag(Loc, PDiag); 2714 D << StringRange; 2715 for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end(); 2716 I != E; ++I) { 2717 D << *I; 2718 } 2719 } else { 2720 S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag) 2721 << ArgumentExpr->getSourceRange(); 2722 2723 const Sema::SemaDiagnosticBuilder &Note = 2724 S.Diag(IsStringLocation ? Loc : StringRange.getBegin(), 2725 diag::note_format_string_defined); 2726 2727 Note << StringRange; 2728 for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end(); 2729 I != E; ++I) { 2730 Note << *I; 2731 } 2732 } 2733 } 2734 2735 //===--- CHECK: Printf format string checking ------------------------------===// 2736 2737 namespace { 2738 class CheckPrintfHandler : public CheckFormatHandler { 2739 bool ObjCContext; 2740 public: 2741 CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 2742 const Expr *origFormatExpr, unsigned firstDataArg, 2743 unsigned numDataArgs, bool isObjC, 2744 const char *beg, bool hasVAListArg, 2745 ArrayRef<const Expr *> Args, 2746 unsigned formatIdx, bool inFunctionCall, 2747 Sema::VariadicCallType CallType, 2748 llvm::SmallBitVector &CheckedVarArgs) 2749 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 2750 numDataArgs, beg, hasVAListArg, Args, 2751 formatIdx, inFunctionCall, CallType, CheckedVarArgs), 2752 ObjCContext(isObjC) 2753 {} 2754 2755 2756 bool HandleInvalidPrintfConversionSpecifier( 2757 const analyze_printf::PrintfSpecifier &FS, 2758 const char *startSpecifier, 2759 unsigned specifierLen); 2760 2761 bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 2762 const char *startSpecifier, 2763 unsigned specifierLen); 2764 bool checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 2765 const char *StartSpecifier, 2766 unsigned SpecifierLen, 2767 const Expr *E); 2768 2769 bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 2770 const char *startSpecifier, unsigned specifierLen); 2771 void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 2772 const analyze_printf::OptionalAmount &Amt, 2773 unsigned type, 2774 const char *startSpecifier, unsigned specifierLen); 2775 void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2776 const analyze_printf::OptionalFlag &flag, 2777 const char *startSpecifier, unsigned specifierLen); 2778 void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 2779 const analyze_printf::OptionalFlag &ignoredFlag, 2780 const analyze_printf::OptionalFlag &flag, 2781 const char *startSpecifier, unsigned specifierLen); 2782 bool checkForCStrMembers(const analyze_printf::ArgType &AT, 2783 const Expr *E, const CharSourceRange &CSR); 2784 2785 }; 2786 } 2787 2788 bool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 2789 const analyze_printf::PrintfSpecifier &FS, 2790 const char *startSpecifier, 2791 unsigned specifierLen) { 2792 const analyze_printf::PrintfConversionSpecifier &CS = 2793 FS.getConversionSpecifier(); 2794 2795 return HandleInvalidConversionSpecifier(FS.getArgIndex(), 2796 getLocationOfByte(CS.getStart()), 2797 startSpecifier, specifierLen, 2798 CS.getStart(), CS.getLength()); 2799 } 2800 2801 bool CheckPrintfHandler::HandleAmount( 2802 const analyze_format_string::OptionalAmount &Amt, 2803 unsigned k, const char *startSpecifier, 2804 unsigned specifierLen) { 2805 2806 if (Amt.hasDataArgument()) { 2807 if (!HasVAListArg) { 2808 unsigned argIndex = Amt.getArgIndex(); 2809 if (argIndex >= NumDataArgs) { 2810 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg) 2811 << k, 2812 getLocationOfByte(Amt.getStart()), 2813 /*IsStringLocation*/true, 2814 getSpecifierRange(startSpecifier, specifierLen)); 2815 // Don't do any more checking. We will just emit 2816 // spurious errors. 2817 return false; 2818 } 2819 2820 // Type check the data argument. It should be an 'int'. 2821 // Although not in conformance with C99, we also allow the argument to be 2822 // an 'unsigned int' as that is a reasonably safe case. GCC also 2823 // doesn't emit a warning for that case. 2824 CoveredArgs.set(argIndex); 2825 const Expr *Arg = getDataArg(argIndex); 2826 if (!Arg) 2827 return false; 2828 2829 QualType T = Arg->getType(); 2830 2831 const analyze_printf::ArgType &AT = Amt.getArgType(S.Context); 2832 assert(AT.isValid()); 2833 2834 if (!AT.matchesType(S.Context, T)) { 2835 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type) 2836 << k << AT.getRepresentativeTypeName(S.Context) 2837 << T << Arg->getSourceRange(), 2838 getLocationOfByte(Amt.getStart()), 2839 /*IsStringLocation*/true, 2840 getSpecifierRange(startSpecifier, specifierLen)); 2841 // Don't do any more checking. We will just emit 2842 // spurious errors. 2843 return false; 2844 } 2845 } 2846 } 2847 return true; 2848 } 2849 2850 void CheckPrintfHandler::HandleInvalidAmount( 2851 const analyze_printf::PrintfSpecifier &FS, 2852 const analyze_printf::OptionalAmount &Amt, 2853 unsigned type, 2854 const char *startSpecifier, 2855 unsigned specifierLen) { 2856 const analyze_printf::PrintfConversionSpecifier &CS = 2857 FS.getConversionSpecifier(); 2858 2859 FixItHint fixit = 2860 Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant 2861 ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 2862 Amt.getConstantLength())) 2863 : FixItHint(); 2864 2865 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount) 2866 << type << CS.toString(), 2867 getLocationOfByte(Amt.getStart()), 2868 /*IsStringLocation*/true, 2869 getSpecifierRange(startSpecifier, specifierLen), 2870 fixit); 2871 } 2872 2873 void CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2874 const analyze_printf::OptionalFlag &flag, 2875 const char *startSpecifier, 2876 unsigned specifierLen) { 2877 // Warn about pointless flag with a fixit removal. 2878 const analyze_printf::PrintfConversionSpecifier &CS = 2879 FS.getConversionSpecifier(); 2880 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag) 2881 << flag.toString() << CS.toString(), 2882 getLocationOfByte(flag.getPosition()), 2883 /*IsStringLocation*/true, 2884 getSpecifierRange(startSpecifier, specifierLen), 2885 FixItHint::CreateRemoval( 2886 getSpecifierRange(flag.getPosition(), 1))); 2887 } 2888 2889 void CheckPrintfHandler::HandleIgnoredFlag( 2890 const analyze_printf::PrintfSpecifier &FS, 2891 const analyze_printf::OptionalFlag &ignoredFlag, 2892 const analyze_printf::OptionalFlag &flag, 2893 const char *startSpecifier, 2894 unsigned specifierLen) { 2895 // Warn about ignored flag with a fixit removal. 2896 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag) 2897 << ignoredFlag.toString() << flag.toString(), 2898 getLocationOfByte(ignoredFlag.getPosition()), 2899 /*IsStringLocation*/true, 2900 getSpecifierRange(startSpecifier, specifierLen), 2901 FixItHint::CreateRemoval( 2902 getSpecifierRange(ignoredFlag.getPosition(), 1))); 2903 } 2904 2905 // Determines if the specified is a C++ class or struct containing 2906 // a member with the specified name and kind (e.g. a CXXMethodDecl named 2907 // "c_str()"). 2908 template<typename MemberKind> 2909 static llvm::SmallPtrSet<MemberKind*, 1> 2910 CXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) { 2911 const RecordType *RT = Ty->getAs<RecordType>(); 2912 llvm::SmallPtrSet<MemberKind*, 1> Results; 2913 2914 if (!RT) 2915 return Results; 2916 const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl()); 2917 if (!RD) 2918 return Results; 2919 2920 LookupResult R(S, &S.PP.getIdentifierTable().get(Name), SourceLocation(), 2921 Sema::LookupMemberName); 2922 2923 // We just need to include all members of the right kind turned up by the 2924 // filter, at this point. 2925 if (S.LookupQualifiedName(R, RT->getDecl())) 2926 for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) { 2927 NamedDecl *decl = (*I)->getUnderlyingDecl(); 2928 if (MemberKind *FK = dyn_cast<MemberKind>(decl)) 2929 Results.insert(FK); 2930 } 2931 return Results; 2932 } 2933 2934 // Check if a (w)string was passed when a (w)char* was needed, and offer a 2935 // better diagnostic if so. AT is assumed to be valid. 2936 // Returns true when a c_str() conversion method is found. 2937 bool CheckPrintfHandler::checkForCStrMembers( 2938 const analyze_printf::ArgType &AT, const Expr *E, 2939 const CharSourceRange &CSR) { 2940 typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet; 2941 2942 MethodSet Results = 2943 CXXRecordMembersNamed<CXXMethodDecl>("c_str", S, E->getType()); 2944 2945 for (MethodSet::iterator MI = Results.begin(), ME = Results.end(); 2946 MI != ME; ++MI) { 2947 const CXXMethodDecl *Method = *MI; 2948 if (Method->getNumParams() == 0 && 2949 AT.matchesType(S.Context, Method->getReturnType())) { 2950 // FIXME: Suggest parens if the expression needs them. 2951 SourceLocation EndLoc = 2952 S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()); 2953 S.Diag(E->getLocStart(), diag::note_printf_c_str) 2954 << "c_str()" 2955 << FixItHint::CreateInsertion(EndLoc, ".c_str()"); 2956 return true; 2957 } 2958 } 2959 2960 return false; 2961 } 2962 2963 bool 2964 CheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 2965 &FS, 2966 const char *startSpecifier, 2967 unsigned specifierLen) { 2968 2969 using namespace analyze_format_string; 2970 using namespace analyze_printf; 2971 const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 2972 2973 if (FS.consumesDataArgument()) { 2974 if (atFirstArg) { 2975 atFirstArg = false; 2976 usesPositionalArgs = FS.usesPositionalArg(); 2977 } 2978 else if (usesPositionalArgs != FS.usesPositionalArg()) { 2979 HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 2980 startSpecifier, specifierLen); 2981 return false; 2982 } 2983 } 2984 2985 // First check if the field width, precision, and conversion specifier 2986 // have matching data arguments. 2987 if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 2988 startSpecifier, specifierLen)) { 2989 return false; 2990 } 2991 2992 if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 2993 startSpecifier, specifierLen)) { 2994 return false; 2995 } 2996 2997 if (!CS.consumesDataArgument()) { 2998 // FIXME: Technically specifying a precision or field width here 2999 // makes no sense. Worth issuing a warning at some point. 3000 return true; 3001 } 3002 3003 // Consume the argument. 3004 unsigned argIndex = FS.getArgIndex(); 3005 if (argIndex < NumDataArgs) { 3006 // The check to see if the argIndex is valid will come later. 3007 // We set the bit here because we may exit early from this 3008 // function if we encounter some other error. 3009 CoveredArgs.set(argIndex); 3010 } 3011 3012 // Check for using an Objective-C specific conversion specifier 3013 // in a non-ObjC literal. 3014 if (!ObjCContext && CS.isObjCArg()) { 3015 return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 3016 specifierLen); 3017 } 3018 3019 // Check for invalid use of field width 3020 if (!FS.hasValidFieldWidth()) { 3021 HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 3022 startSpecifier, specifierLen); 3023 } 3024 3025 // Check for invalid use of precision 3026 if (!FS.hasValidPrecision()) { 3027 HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 3028 startSpecifier, specifierLen); 3029 } 3030 3031 // Check each flag does not conflict with any other component. 3032 if (!FS.hasValidThousandsGroupingPrefix()) 3033 HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 3034 if (!FS.hasValidLeadingZeros()) 3035 HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 3036 if (!FS.hasValidPlusPrefix()) 3037 HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 3038 if (!FS.hasValidSpacePrefix()) 3039 HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 3040 if (!FS.hasValidAlternativeForm()) 3041 HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 3042 if (!FS.hasValidLeftJustified()) 3043 HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 3044 3045 // Check that flags are not ignored by another flag 3046 if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 3047 HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 3048 startSpecifier, specifierLen); 3049 if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 3050 HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 3051 startSpecifier, specifierLen); 3052 3053 // Check the length modifier is valid with the given conversion specifier. 3054 if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo())) 3055 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 3056 diag::warn_format_nonsensical_length); 3057 else if (!FS.hasStandardLengthModifier()) 3058 HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen); 3059 else if (!FS.hasStandardLengthConversionCombination()) 3060 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 3061 diag::warn_format_non_standard_conversion_spec); 3062 3063 if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 3064 HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 3065 3066 // The remaining checks depend on the data arguments. 3067 if (HasVAListArg) 3068 return true; 3069 3070 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 3071 return false; 3072 3073 const Expr *Arg = getDataArg(argIndex); 3074 if (!Arg) 3075 return true; 3076 3077 return checkFormatExpr(FS, startSpecifier, specifierLen, Arg); 3078 } 3079 3080 static bool requiresParensToAddCast(const Expr *E) { 3081 // FIXME: We should have a general way to reason about operator 3082 // precedence and whether parens are actually needed here. 3083 // Take care of a few common cases where they aren't. 3084 const Expr *Inside = E->IgnoreImpCasts(); 3085 if (const PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(Inside)) 3086 Inside = POE->getSyntacticForm()->IgnoreImpCasts(); 3087 3088 switch (Inside->getStmtClass()) { 3089 case Stmt::ArraySubscriptExprClass: 3090 case Stmt::CallExprClass: 3091 case Stmt::CharacterLiteralClass: 3092 case Stmt::CXXBoolLiteralExprClass: 3093 case Stmt::DeclRefExprClass: 3094 case Stmt::FloatingLiteralClass: 3095 case Stmt::IntegerLiteralClass: 3096 case Stmt::MemberExprClass: 3097 case Stmt::ObjCArrayLiteralClass: 3098 case Stmt::ObjCBoolLiteralExprClass: 3099 case Stmt::ObjCBoxedExprClass: 3100 case Stmt::ObjCDictionaryLiteralClass: 3101 case Stmt::ObjCEncodeExprClass: 3102 case Stmt::ObjCIvarRefExprClass: 3103 case Stmt::ObjCMessageExprClass: 3104 case Stmt::ObjCPropertyRefExprClass: 3105 case Stmt::ObjCStringLiteralClass: 3106 case Stmt::ObjCSubscriptRefExprClass: 3107 case Stmt::ParenExprClass: 3108 case Stmt::StringLiteralClass: 3109 case Stmt::UnaryOperatorClass: 3110 return false; 3111 default: 3112 return true; 3113 } 3114 } 3115 3116 bool 3117 CheckPrintfHandler::checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 3118 const char *StartSpecifier, 3119 unsigned SpecifierLen, 3120 const Expr *E) { 3121 using namespace analyze_format_string; 3122 using namespace analyze_printf; 3123 // Now type check the data expression that matches the 3124 // format specifier. 3125 const analyze_printf::ArgType &AT = FS.getArgType(S.Context, 3126 ObjCContext); 3127 if (!AT.isValid()) 3128 return true; 3129 3130 QualType ExprTy = E->getType(); 3131 while (const TypeOfExprType *TET = dyn_cast<TypeOfExprType>(ExprTy)) { 3132 ExprTy = TET->getUnderlyingExpr()->getType(); 3133 } 3134 3135 if (AT.matchesType(S.Context, ExprTy)) 3136 return true; 3137 3138 // Look through argument promotions for our error message's reported type. 3139 // This includes the integral and floating promotions, but excludes array 3140 // and function pointer decay; seeing that an argument intended to be a 3141 // string has type 'char [6]' is probably more confusing than 'char *'. 3142 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 3143 if (ICE->getCastKind() == CK_IntegralCast || 3144 ICE->getCastKind() == CK_FloatingCast) { 3145 E = ICE->getSubExpr(); 3146 ExprTy = E->getType(); 3147 3148 // Check if we didn't match because of an implicit cast from a 'char' 3149 // or 'short' to an 'int'. This is done because printf is a varargs 3150 // function. 3151 if (ICE->getType() == S.Context.IntTy || 3152 ICE->getType() == S.Context.UnsignedIntTy) { 3153 // All further checking is done on the subexpression. 3154 if (AT.matchesType(S.Context, ExprTy)) 3155 return true; 3156 } 3157 } 3158 } else if (const CharacterLiteral *CL = dyn_cast<CharacterLiteral>(E)) { 3159 // Special case for 'a', which has type 'int' in C. 3160 // Note, however, that we do /not/ want to treat multibyte constants like 3161 // 'MooV' as characters! This form is deprecated but still exists. 3162 if (ExprTy == S.Context.IntTy) 3163 if (llvm::isUIntN(S.Context.getCharWidth(), CL->getValue())) 3164 ExprTy = S.Context.CharTy; 3165 } 3166 3167 // %C in an Objective-C context prints a unichar, not a wchar_t. 3168 // If the argument is an integer of some kind, believe the %C and suggest 3169 // a cast instead of changing the conversion specifier. 3170 QualType IntendedTy = ExprTy; 3171 if (ObjCContext && 3172 FS.getConversionSpecifier().getKind() == ConversionSpecifier::CArg) { 3173 if (ExprTy->isIntegralOrUnscopedEnumerationType() && 3174 !ExprTy->isCharType()) { 3175 // 'unichar' is defined as a typedef of unsigned short, but we should 3176 // prefer using the typedef if it is visible. 3177 IntendedTy = S.Context.UnsignedShortTy; 3178 3179 // While we are here, check if the value is an IntegerLiteral that happens 3180 // to be within the valid range. 3181 if (const IntegerLiteral *IL = dyn_cast<IntegerLiteral>(E)) { 3182 const llvm::APInt &V = IL->getValue(); 3183 if (V.getActiveBits() <= S.Context.getTypeSize(IntendedTy)) 3184 return true; 3185 } 3186 3187 LookupResult Result(S, &S.Context.Idents.get("unichar"), E->getLocStart(), 3188 Sema::LookupOrdinaryName); 3189 if (S.LookupName(Result, S.getCurScope())) { 3190 NamedDecl *ND = Result.getFoundDecl(); 3191 if (TypedefNameDecl *TD = dyn_cast<TypedefNameDecl>(ND)) 3192 if (TD->getUnderlyingType() == IntendedTy) 3193 IntendedTy = S.Context.getTypedefType(TD); 3194 } 3195 } 3196 } 3197 3198 // Special-case some of Darwin's platform-independence types by suggesting 3199 // casts to primitive types that are known to be large enough. 3200 bool ShouldNotPrintDirectly = false; 3201 if (S.Context.getTargetInfo().getTriple().isOSDarwin()) { 3202 // Use a 'while' to peel off layers of typedefs. 3203 QualType TyTy = IntendedTy; 3204 while (const TypedefType *UserTy = TyTy->getAs<TypedefType>()) { 3205 StringRef Name = UserTy->getDecl()->getName(); 3206 QualType CastTy = llvm::StringSwitch<QualType>(Name) 3207 .Case("NSInteger", S.Context.LongTy) 3208 .Case("NSUInteger", S.Context.UnsignedLongTy) 3209 .Case("SInt32", S.Context.IntTy) 3210 .Case("UInt32", S.Context.UnsignedIntTy) 3211 .Default(QualType()); 3212 3213 if (!CastTy.isNull()) { 3214 ShouldNotPrintDirectly = true; 3215 IntendedTy = CastTy; 3216 break; 3217 } 3218 TyTy = UserTy->desugar(); 3219 } 3220 } 3221 3222 // We may be able to offer a FixItHint if it is a supported type. 3223 PrintfSpecifier fixedFS = FS; 3224 bool success = fixedFS.fixType(IntendedTy, S.getLangOpts(), 3225 S.Context, ObjCContext); 3226 3227 if (success) { 3228 // Get the fix string from the fixed format specifier 3229 SmallString<16> buf; 3230 llvm::raw_svector_ostream os(buf); 3231 fixedFS.toString(os); 3232 3233 CharSourceRange SpecRange = getSpecifierRange(StartSpecifier, SpecifierLen); 3234 3235 if (IntendedTy == ExprTy) { 3236 // In this case, the specifier is wrong and should be changed to match 3237 // the argument. 3238 EmitFormatDiagnostic( 3239 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 3240 << AT.getRepresentativeTypeName(S.Context) << IntendedTy 3241 << E->getSourceRange(), 3242 E->getLocStart(), 3243 /*IsStringLocation*/false, 3244 SpecRange, 3245 FixItHint::CreateReplacement(SpecRange, os.str())); 3246 3247 } else { 3248 // The canonical type for formatting this value is different from the 3249 // actual type of the expression. (This occurs, for example, with Darwin's 3250 // NSInteger on 32-bit platforms, where it is typedef'd as 'int', but 3251 // should be printed as 'long' for 64-bit compatibility.) 3252 // Rather than emitting a normal format/argument mismatch, we want to 3253 // add a cast to the recommended type (and correct the format string 3254 // if necessary). 3255 SmallString<16> CastBuf; 3256 llvm::raw_svector_ostream CastFix(CastBuf); 3257 CastFix << "("; 3258 IntendedTy.print(CastFix, S.Context.getPrintingPolicy()); 3259 CastFix << ")"; 3260 3261 SmallVector<FixItHint,4> Hints; 3262 if (!AT.matchesType(S.Context, IntendedTy)) 3263 Hints.push_back(FixItHint::CreateReplacement(SpecRange, os.str())); 3264 3265 if (const CStyleCastExpr *CCast = dyn_cast<CStyleCastExpr>(E)) { 3266 // If there's already a cast present, just replace it. 3267 SourceRange CastRange(CCast->getLParenLoc(), CCast->getRParenLoc()); 3268 Hints.push_back(FixItHint::CreateReplacement(CastRange, CastFix.str())); 3269 3270 } else if (!requiresParensToAddCast(E)) { 3271 // If the expression has high enough precedence, 3272 // just write the C-style cast. 3273 Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 3274 CastFix.str())); 3275 } else { 3276 // Otherwise, add parens around the expression as well as the cast. 3277 CastFix << "("; 3278 Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 3279 CastFix.str())); 3280 3281 SourceLocation After = S.PP.getLocForEndOfToken(E->getLocEnd()); 3282 Hints.push_back(FixItHint::CreateInsertion(After, ")")); 3283 } 3284 3285 if (ShouldNotPrintDirectly) { 3286 // The expression has a type that should not be printed directly. 3287 // We extract the name from the typedef because we don't want to show 3288 // the underlying type in the diagnostic. 3289 StringRef Name = cast<TypedefType>(ExprTy)->getDecl()->getName(); 3290 3291 EmitFormatDiagnostic(S.PDiag(diag::warn_format_argument_needs_cast) 3292 << Name << IntendedTy 3293 << E->getSourceRange(), 3294 E->getLocStart(), /*IsStringLocation=*/false, 3295 SpecRange, Hints); 3296 } else { 3297 // In this case, the expression could be printed using a different 3298 // specifier, but we've decided that the specifier is probably correct 3299 // and we should cast instead. Just use the normal warning message. 3300 EmitFormatDiagnostic( 3301 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 3302 << AT.getRepresentativeTypeName(S.Context) << ExprTy 3303 << E->getSourceRange(), 3304 E->getLocStart(), /*IsStringLocation*/false, 3305 SpecRange, Hints); 3306 } 3307 } 3308 } else { 3309 const CharSourceRange &CSR = getSpecifierRange(StartSpecifier, 3310 SpecifierLen); 3311 // Since the warning for passing non-POD types to variadic functions 3312 // was deferred until now, we emit a warning for non-POD 3313 // arguments here. 3314 switch (S.isValidVarArgType(ExprTy)) { 3315 case Sema::VAK_Valid: 3316 case Sema::VAK_ValidInCXX11: 3317 EmitFormatDiagnostic( 3318 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 3319 << AT.getRepresentativeTypeName(S.Context) << ExprTy 3320 << CSR 3321 << E->getSourceRange(), 3322 E->getLocStart(), /*IsStringLocation*/false, CSR); 3323 break; 3324 3325 case Sema::VAK_Undefined: 3326 EmitFormatDiagnostic( 3327 S.PDiag(diag::warn_non_pod_vararg_with_format_string) 3328 << S.getLangOpts().CPlusPlus11 3329 << ExprTy 3330 << CallType 3331 << AT.getRepresentativeTypeName(S.Context) 3332 << CSR 3333 << E->getSourceRange(), 3334 E->getLocStart(), /*IsStringLocation*/false, CSR); 3335 checkForCStrMembers(AT, E, CSR); 3336 break; 3337 3338 case Sema::VAK_Invalid: 3339 if (ExprTy->isObjCObjectType()) 3340 EmitFormatDiagnostic( 3341 S.PDiag(diag::err_cannot_pass_objc_interface_to_vararg_format) 3342 << S.getLangOpts().CPlusPlus11 3343 << ExprTy 3344 << CallType 3345 << AT.getRepresentativeTypeName(S.Context) 3346 << CSR 3347 << E->getSourceRange(), 3348 E->getLocStart(), /*IsStringLocation*/false, CSR); 3349 else 3350 // FIXME: If this is an initializer list, suggest removing the braces 3351 // or inserting a cast to the target type. 3352 S.Diag(E->getLocStart(), diag::err_cannot_pass_to_vararg_format) 3353 << isa<InitListExpr>(E) << ExprTy << CallType 3354 << AT.getRepresentativeTypeName(S.Context) 3355 << E->getSourceRange(); 3356 break; 3357 } 3358 3359 assert(FirstDataArg + FS.getArgIndex() < CheckedVarArgs.size() && 3360 "format string specifier index out of range"); 3361 CheckedVarArgs[FirstDataArg + FS.getArgIndex()] = true; 3362 } 3363 3364 return true; 3365 } 3366 3367 //===--- CHECK: Scanf format string checking ------------------------------===// 3368 3369 namespace { 3370 class CheckScanfHandler : public CheckFormatHandler { 3371 public: 3372 CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 3373 const Expr *origFormatExpr, unsigned firstDataArg, 3374 unsigned numDataArgs, const char *beg, bool hasVAListArg, 3375 ArrayRef<const Expr *> Args, 3376 unsigned formatIdx, bool inFunctionCall, 3377 Sema::VariadicCallType CallType, 3378 llvm::SmallBitVector &CheckedVarArgs) 3379 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 3380 numDataArgs, beg, hasVAListArg, 3381 Args, formatIdx, inFunctionCall, CallType, 3382 CheckedVarArgs) 3383 {} 3384 3385 bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 3386 const char *startSpecifier, 3387 unsigned specifierLen); 3388 3389 bool HandleInvalidScanfConversionSpecifier( 3390 const analyze_scanf::ScanfSpecifier &FS, 3391 const char *startSpecifier, 3392 unsigned specifierLen); 3393 3394 void HandleIncompleteScanList(const char *start, const char *end); 3395 }; 3396 } 3397 3398 void CheckScanfHandler::HandleIncompleteScanList(const char *start, 3399 const char *end) { 3400 EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete), 3401 getLocationOfByte(end), /*IsStringLocation*/true, 3402 getSpecifierRange(start, end - start)); 3403 } 3404 3405 bool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 3406 const analyze_scanf::ScanfSpecifier &FS, 3407 const char *startSpecifier, 3408 unsigned specifierLen) { 3409 3410 const analyze_scanf::ScanfConversionSpecifier &CS = 3411 FS.getConversionSpecifier(); 3412 3413 return HandleInvalidConversionSpecifier(FS.getArgIndex(), 3414 getLocationOfByte(CS.getStart()), 3415 startSpecifier, specifierLen, 3416 CS.getStart(), CS.getLength()); 3417 } 3418 3419 bool CheckScanfHandler::HandleScanfSpecifier( 3420 const analyze_scanf::ScanfSpecifier &FS, 3421 const char *startSpecifier, 3422 unsigned specifierLen) { 3423 3424 using namespace analyze_scanf; 3425 using namespace analyze_format_string; 3426 3427 const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 3428 3429 // Handle case where '%' and '*' don't consume an argument. These shouldn't 3430 // be used to decide if we are using positional arguments consistently. 3431 if (FS.consumesDataArgument()) { 3432 if (atFirstArg) { 3433 atFirstArg = false; 3434 usesPositionalArgs = FS.usesPositionalArg(); 3435 } 3436 else if (usesPositionalArgs != FS.usesPositionalArg()) { 3437 HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 3438 startSpecifier, specifierLen); 3439 return false; 3440 } 3441 } 3442 3443 // Check if the field with is non-zero. 3444 const OptionalAmount &Amt = FS.getFieldWidth(); 3445 if (Amt.getHowSpecified() == OptionalAmount::Constant) { 3446 if (Amt.getConstantAmount() == 0) { 3447 const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 3448 Amt.getConstantLength()); 3449 EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width), 3450 getLocationOfByte(Amt.getStart()), 3451 /*IsStringLocation*/true, R, 3452 FixItHint::CreateRemoval(R)); 3453 } 3454 } 3455 3456 if (!FS.consumesDataArgument()) { 3457 // FIXME: Technically specifying a precision or field width here 3458 // makes no sense. Worth issuing a warning at some point. 3459 return true; 3460 } 3461 3462 // Consume the argument. 3463 unsigned argIndex = FS.getArgIndex(); 3464 if (argIndex < NumDataArgs) { 3465 // The check to see if the argIndex is valid will come later. 3466 // We set the bit here because we may exit early from this 3467 // function if we encounter some other error. 3468 CoveredArgs.set(argIndex); 3469 } 3470 3471 // Check the length modifier is valid with the given conversion specifier. 3472 if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo())) 3473 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 3474 diag::warn_format_nonsensical_length); 3475 else if (!FS.hasStandardLengthModifier()) 3476 HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen); 3477 else if (!FS.hasStandardLengthConversionCombination()) 3478 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 3479 diag::warn_format_non_standard_conversion_spec); 3480 3481 if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 3482 HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 3483 3484 // The remaining checks depend on the data arguments. 3485 if (HasVAListArg) 3486 return true; 3487 3488 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 3489 return false; 3490 3491 // Check that the argument type matches the format specifier. 3492 const Expr *Ex = getDataArg(argIndex); 3493 if (!Ex) 3494 return true; 3495 3496 const analyze_format_string::ArgType &AT = FS.getArgType(S.Context); 3497 if (AT.isValid() && !AT.matchesType(S.Context, Ex->getType())) { 3498 ScanfSpecifier fixedFS = FS; 3499 bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(), 3500 S.Context); 3501 3502 if (success) { 3503 // Get the fix string from the fixed format specifier. 3504 SmallString<128> buf; 3505 llvm::raw_svector_ostream os(buf); 3506 fixedFS.toString(os); 3507 3508 EmitFormatDiagnostic( 3509 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 3510 << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 3511 << Ex->getSourceRange(), 3512 Ex->getLocStart(), 3513 /*IsStringLocation*/false, 3514 getSpecifierRange(startSpecifier, specifierLen), 3515 FixItHint::CreateReplacement( 3516 getSpecifierRange(startSpecifier, specifierLen), 3517 os.str())); 3518 } else { 3519 EmitFormatDiagnostic( 3520 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 3521 << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 3522 << Ex->getSourceRange(), 3523 Ex->getLocStart(), 3524 /*IsStringLocation*/false, 3525 getSpecifierRange(startSpecifier, specifierLen)); 3526 } 3527 } 3528 3529 return true; 3530 } 3531 3532 void Sema::CheckFormatString(const StringLiteral *FExpr, 3533 const Expr *OrigFormatExpr, 3534 ArrayRef<const Expr *> Args, 3535 bool HasVAListArg, unsigned format_idx, 3536 unsigned firstDataArg, FormatStringType Type, 3537 bool inFunctionCall, VariadicCallType CallType, 3538 llvm::SmallBitVector &CheckedVarArgs) { 3539 3540 // CHECK: is the format string a wide literal? 3541 if (!FExpr->isAscii() && !FExpr->isUTF8()) { 3542 CheckFormatHandler::EmitFormatDiagnostic( 3543 *this, inFunctionCall, Args[format_idx], 3544 PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(), 3545 /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 3546 return; 3547 } 3548 3549 // Str - The format string. NOTE: this is NOT null-terminated! 3550 StringRef StrRef = FExpr->getString(); 3551 const char *Str = StrRef.data(); 3552 unsigned StrLen = StrRef.size(); 3553 const unsigned numDataArgs = Args.size() - firstDataArg; 3554 3555 // CHECK: empty format string? 3556 if (StrLen == 0 && numDataArgs > 0) { 3557 CheckFormatHandler::EmitFormatDiagnostic( 3558 *this, inFunctionCall, Args[format_idx], 3559 PDiag(diag::warn_empty_format_string), FExpr->getLocStart(), 3560 /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 3561 return; 3562 } 3563 3564 if (Type == FST_Printf || Type == FST_NSString) { 3565 CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 3566 numDataArgs, (Type == FST_NSString), 3567 Str, HasVAListArg, Args, format_idx, 3568 inFunctionCall, CallType, CheckedVarArgs); 3569 3570 if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen, 3571 getLangOpts(), 3572 Context.getTargetInfo())) 3573 H.DoneProcessing(); 3574 } else if (Type == FST_Scanf) { 3575 CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, numDataArgs, 3576 Str, HasVAListArg, Args, format_idx, 3577 inFunctionCall, CallType, CheckedVarArgs); 3578 3579 if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen, 3580 getLangOpts(), 3581 Context.getTargetInfo())) 3582 H.DoneProcessing(); 3583 } // TODO: handle other formats 3584 } 3585 3586 //===--- CHECK: Standard memory functions ---------------------------------===// 3587 3588 /// \brief Takes the expression passed to the size_t parameter of functions 3589 /// such as memcmp, strncat, etc and warns if it's a comparison. 3590 /// 3591 /// This is to catch typos like `if (memcmp(&a, &b, sizeof(a) > 0))`. 3592 static bool CheckMemorySizeofForComparison(Sema &S, const Expr *E, 3593 IdentifierInfo *FnName, 3594 SourceLocation FnLoc, 3595 SourceLocation RParenLoc) { 3596 const BinaryOperator *Size = dyn_cast<BinaryOperator>(E); 3597 if (!Size) 3598 return false; 3599 3600 // if E is binop and op is >, <, >=, <=, ==, &&, ||: 3601 if (!Size->isComparisonOp() && !Size->isEqualityOp() && !Size->isLogicalOp()) 3602 return false; 3603 3604 Preprocessor &PP = S.getPreprocessor(); 3605 SourceRange SizeRange = Size->getSourceRange(); 3606 S.Diag(Size->getOperatorLoc(), diag::warn_memsize_comparison) 3607 << SizeRange << FnName; 3608 S.Diag(FnLoc, diag::warn_memsize_comparison_paren_note) 3609 << FnName 3610 << FixItHint::CreateInsertion( 3611 PP.getLocForEndOfToken(Size->getLHS()->getLocEnd()), 3612 ")") 3613 << FixItHint::CreateRemoval(RParenLoc); 3614 S.Diag(SizeRange.getBegin(), diag::warn_memsize_comparison_cast_note) 3615 << FixItHint::CreateInsertion(SizeRange.getBegin(), "(size_t)(") 3616 << FixItHint::CreateInsertion( 3617 PP.getLocForEndOfToken(SizeRange.getEnd()), ")"); 3618 3619 return true; 3620 } 3621 3622 /// \brief Determine whether the given type is a dynamic class type (e.g., 3623 /// whether it has a vtable). 3624 static bool isDynamicClassType(QualType T) { 3625 if (CXXRecordDecl *Record = T->getAsCXXRecordDecl()) 3626 if (CXXRecordDecl *Definition = Record->getDefinition()) 3627 if (Definition->isDynamicClass()) 3628 return true; 3629 3630 return false; 3631 } 3632 3633 /// \brief If E is a sizeof expression, returns its argument expression, 3634 /// otherwise returns NULL. 3635 static const Expr *getSizeOfExprArg(const Expr* E) { 3636 if (const UnaryExprOrTypeTraitExpr *SizeOf = 3637 dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 3638 if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType()) 3639 return SizeOf->getArgumentExpr()->IgnoreParenImpCasts(); 3640 3641 return 0; 3642 } 3643 3644 /// \brief If E is a sizeof expression, returns its argument type. 3645 static QualType getSizeOfArgType(const Expr* E) { 3646 if (const UnaryExprOrTypeTraitExpr *SizeOf = 3647 dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 3648 if (SizeOf->getKind() == clang::UETT_SizeOf) 3649 return SizeOf->getTypeOfArgument(); 3650 3651 return QualType(); 3652 } 3653 3654 /// \brief Check for dangerous or invalid arguments to memset(). 3655 /// 3656 /// This issues warnings on known problematic, dangerous or unspecified 3657 /// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp' 3658 /// function calls. 3659 /// 3660 /// \param Call The call expression to diagnose. 3661 void Sema::CheckMemaccessArguments(const CallExpr *Call, 3662 unsigned BId, 3663 IdentifierInfo *FnName) { 3664 assert(BId != 0); 3665 3666 // It is possible to have a non-standard definition of memset. Validate 3667 // we have enough arguments, and if not, abort further checking. 3668 unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3); 3669 if (Call->getNumArgs() < ExpectedNumArgs) 3670 return; 3671 3672 unsigned LastArg = (BId == Builtin::BImemset || 3673 BId == Builtin::BIstrndup ? 1 : 2); 3674 unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2); 3675 const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts(); 3676 3677 if (CheckMemorySizeofForComparison(*this, LenExpr, FnName, 3678 Call->getLocStart(), Call->getRParenLoc())) 3679 return; 3680 3681 // We have special checking when the length is a sizeof expression. 3682 QualType SizeOfArgTy = getSizeOfArgType(LenExpr); 3683 const Expr *SizeOfArg = getSizeOfExprArg(LenExpr); 3684 llvm::FoldingSetNodeID SizeOfArgID; 3685 3686 for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 3687 const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 3688 SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange(); 3689 3690 QualType DestTy = Dest->getType(); 3691 if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 3692 QualType PointeeTy = DestPtrTy->getPointeeType(); 3693 3694 // Never warn about void type pointers. This can be used to suppress 3695 // false positives. 3696 if (PointeeTy->isVoidType()) 3697 continue; 3698 3699 // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by 3700 // actually comparing the expressions for equality. Because computing the 3701 // expression IDs can be expensive, we only do this if the diagnostic is 3702 // enabled. 3703 if (SizeOfArg && 3704 Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess, 3705 SizeOfArg->getExprLoc())) { 3706 // We only compute IDs for expressions if the warning is enabled, and 3707 // cache the sizeof arg's ID. 3708 if (SizeOfArgID == llvm::FoldingSetNodeID()) 3709 SizeOfArg->Profile(SizeOfArgID, Context, true); 3710 llvm::FoldingSetNodeID DestID; 3711 Dest->Profile(DestID, Context, true); 3712 if (DestID == SizeOfArgID) { 3713 // TODO: For strncpy() and friends, this could suggest sizeof(dst) 3714 // over sizeof(src) as well. 3715 unsigned ActionIdx = 0; // Default is to suggest dereferencing. 3716 StringRef ReadableName = FnName->getName(); 3717 3718 if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest)) 3719 if (UnaryOp->getOpcode() == UO_AddrOf) 3720 ActionIdx = 1; // If its an address-of operator, just remove it. 3721 if (!PointeeTy->isIncompleteType() && 3722 (Context.getTypeSize(PointeeTy) == Context.getCharWidth())) 3723 ActionIdx = 2; // If the pointee's size is sizeof(char), 3724 // suggest an explicit length. 3725 3726 // If the function is defined as a builtin macro, do not show macro 3727 // expansion. 3728 SourceLocation SL = SizeOfArg->getExprLoc(); 3729 SourceRange DSR = Dest->getSourceRange(); 3730 SourceRange SSR = SizeOfArg->getSourceRange(); 3731 SourceManager &SM = PP.getSourceManager(); 3732 3733 if (SM.isMacroArgExpansion(SL)) { 3734 ReadableName = Lexer::getImmediateMacroName(SL, SM, LangOpts); 3735 SL = SM.getSpellingLoc(SL); 3736 DSR = SourceRange(SM.getSpellingLoc(DSR.getBegin()), 3737 SM.getSpellingLoc(DSR.getEnd())); 3738 SSR = SourceRange(SM.getSpellingLoc(SSR.getBegin()), 3739 SM.getSpellingLoc(SSR.getEnd())); 3740 } 3741 3742 DiagRuntimeBehavior(SL, SizeOfArg, 3743 PDiag(diag::warn_sizeof_pointer_expr_memaccess) 3744 << ReadableName 3745 << PointeeTy 3746 << DestTy 3747 << DSR 3748 << SSR); 3749 DiagRuntimeBehavior(SL, SizeOfArg, 3750 PDiag(diag::warn_sizeof_pointer_expr_memaccess_note) 3751 << ActionIdx 3752 << SSR); 3753 3754 break; 3755 } 3756 } 3757 3758 // Also check for cases where the sizeof argument is the exact same 3759 // type as the memory argument, and where it points to a user-defined 3760 // record type. 3761 if (SizeOfArgTy != QualType()) { 3762 if (PointeeTy->isRecordType() && 3763 Context.typesAreCompatible(SizeOfArgTy, DestTy)) { 3764 DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest, 3765 PDiag(diag::warn_sizeof_pointer_type_memaccess) 3766 << FnName << SizeOfArgTy << ArgIdx 3767 << PointeeTy << Dest->getSourceRange() 3768 << LenExpr->getSourceRange()); 3769 break; 3770 } 3771 } 3772 3773 // Always complain about dynamic classes. 3774 if (isDynamicClassType(PointeeTy)) { 3775 3776 unsigned OperationType = 0; 3777 // "overwritten" if we're warning about the destination for any call 3778 // but memcmp; otherwise a verb appropriate to the call. 3779 if (ArgIdx != 0 || BId == Builtin::BImemcmp) { 3780 if (BId == Builtin::BImemcpy) 3781 OperationType = 1; 3782 else if(BId == Builtin::BImemmove) 3783 OperationType = 2; 3784 else if (BId == Builtin::BImemcmp) 3785 OperationType = 3; 3786 } 3787 3788 DiagRuntimeBehavior( 3789 Dest->getExprLoc(), Dest, 3790 PDiag(diag::warn_dyn_class_memaccess) 3791 << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx) 3792 << FnName << PointeeTy 3793 << OperationType 3794 << Call->getCallee()->getSourceRange()); 3795 } else if (PointeeTy.hasNonTrivialObjCLifetime() && 3796 BId != Builtin::BImemset) 3797 DiagRuntimeBehavior( 3798 Dest->getExprLoc(), Dest, 3799 PDiag(diag::warn_arc_object_memaccess) 3800 << ArgIdx << FnName << PointeeTy 3801 << Call->getCallee()->getSourceRange()); 3802 else 3803 continue; 3804 3805 DiagRuntimeBehavior( 3806 Dest->getExprLoc(), Dest, 3807 PDiag(diag::note_bad_memaccess_silence) 3808 << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 3809 break; 3810 } 3811 } 3812 } 3813 3814 // A little helper routine: ignore addition and subtraction of integer literals. 3815 // This intentionally does not ignore all integer constant expressions because 3816 // we don't want to remove sizeof(). 3817 static const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) { 3818 Ex = Ex->IgnoreParenCasts(); 3819 3820 for (;;) { 3821 const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex); 3822 if (!BO || !BO->isAdditiveOp()) 3823 break; 3824 3825 const Expr *RHS = BO->getRHS()->IgnoreParenCasts(); 3826 const Expr *LHS = BO->getLHS()->IgnoreParenCasts(); 3827 3828 if (isa<IntegerLiteral>(RHS)) 3829 Ex = LHS; 3830 else if (isa<IntegerLiteral>(LHS)) 3831 Ex = RHS; 3832 else 3833 break; 3834 } 3835 3836 return Ex; 3837 } 3838 3839 static bool isConstantSizeArrayWithMoreThanOneElement(QualType Ty, 3840 ASTContext &Context) { 3841 // Only handle constant-sized or VLAs, but not flexible members. 3842 if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(Ty)) { 3843 // Only issue the FIXIT for arrays of size > 1. 3844 if (CAT->getSize().getSExtValue() <= 1) 3845 return false; 3846 } else if (!Ty->isVariableArrayType()) { 3847 return false; 3848 } 3849 return true; 3850 } 3851 3852 // Warn if the user has made the 'size' argument to strlcpy or strlcat 3853 // be the size of the source, instead of the destination. 3854 void Sema::CheckStrlcpycatArguments(const CallExpr *Call, 3855 IdentifierInfo *FnName) { 3856 3857 // Don't crash if the user has the wrong number of arguments 3858 if (Call->getNumArgs() != 3) 3859 return; 3860 3861 const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context); 3862 const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context); 3863 const Expr *CompareWithSrc = NULL; 3864 3865 if (CheckMemorySizeofForComparison(*this, SizeArg, FnName, 3866 Call->getLocStart(), Call->getRParenLoc())) 3867 return; 3868 3869 // Look for 'strlcpy(dst, x, sizeof(x))' 3870 if (const Expr *Ex = getSizeOfExprArg(SizeArg)) 3871 CompareWithSrc = Ex; 3872 else { 3873 // Look for 'strlcpy(dst, x, strlen(x))' 3874 if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) { 3875 if (SizeCall->getBuiltinCallee() == Builtin::BIstrlen && 3876 SizeCall->getNumArgs() == 1) 3877 CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context); 3878 } 3879 } 3880 3881 if (!CompareWithSrc) 3882 return; 3883 3884 // Determine if the argument to sizeof/strlen is equal to the source 3885 // argument. In principle there's all kinds of things you could do 3886 // here, for instance creating an == expression and evaluating it with 3887 // EvaluateAsBooleanCondition, but this uses a more direct technique: 3888 const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg); 3889 if (!SrcArgDRE) 3890 return; 3891 3892 const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc); 3893 if (!CompareWithSrcDRE || 3894 SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl()) 3895 return; 3896 3897 const Expr *OriginalSizeArg = Call->getArg(2); 3898 Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size) 3899 << OriginalSizeArg->getSourceRange() << FnName; 3900 3901 // Output a FIXIT hint if the destination is an array (rather than a 3902 // pointer to an array). This could be enhanced to handle some 3903 // pointers if we know the actual size, like if DstArg is 'array+2' 3904 // we could say 'sizeof(array)-2'. 3905 const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts(); 3906 if (!isConstantSizeArrayWithMoreThanOneElement(DstArg->getType(), Context)) 3907 return; 3908 3909 SmallString<128> sizeString; 3910 llvm::raw_svector_ostream OS(sizeString); 3911 OS << "sizeof("; 3912 DstArg->printPretty(OS, 0, getPrintingPolicy()); 3913 OS << ")"; 3914 3915 Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size) 3916 << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(), 3917 OS.str()); 3918 } 3919 3920 /// Check if two expressions refer to the same declaration. 3921 static bool referToTheSameDecl(const Expr *E1, const Expr *E2) { 3922 if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1)) 3923 if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2)) 3924 return D1->getDecl() == D2->getDecl(); 3925 return false; 3926 } 3927 3928 static const Expr *getStrlenExprArg(const Expr *E) { 3929 if (const CallExpr *CE = dyn_cast<CallExpr>(E)) { 3930 const FunctionDecl *FD = CE->getDirectCallee(); 3931 if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen) 3932 return 0; 3933 return CE->getArg(0)->IgnoreParenCasts(); 3934 } 3935 return 0; 3936 } 3937 3938 // Warn on anti-patterns as the 'size' argument to strncat. 3939 // The correct size argument should look like following: 3940 // strncat(dst, src, sizeof(dst) - strlen(dest) - 1); 3941 void Sema::CheckStrncatArguments(const CallExpr *CE, 3942 IdentifierInfo *FnName) { 3943 // Don't crash if the user has the wrong number of arguments. 3944 if (CE->getNumArgs() < 3) 3945 return; 3946 const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts(); 3947 const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts(); 3948 const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts(); 3949 3950 if (CheckMemorySizeofForComparison(*this, LenArg, FnName, CE->getLocStart(), 3951 CE->getRParenLoc())) 3952 return; 3953 3954 // Identify common expressions, which are wrongly used as the size argument 3955 // to strncat and may lead to buffer overflows. 3956 unsigned PatternType = 0; 3957 if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) { 3958 // - sizeof(dst) 3959 if (referToTheSameDecl(SizeOfArg, DstArg)) 3960 PatternType = 1; 3961 // - sizeof(src) 3962 else if (referToTheSameDecl(SizeOfArg, SrcArg)) 3963 PatternType = 2; 3964 } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) { 3965 if (BE->getOpcode() == BO_Sub) { 3966 const Expr *L = BE->getLHS()->IgnoreParenCasts(); 3967 const Expr *R = BE->getRHS()->IgnoreParenCasts(); 3968 // - sizeof(dst) - strlen(dst) 3969 if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) && 3970 referToTheSameDecl(DstArg, getStrlenExprArg(R))) 3971 PatternType = 1; 3972 // - sizeof(src) - (anything) 3973 else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L))) 3974 PatternType = 2; 3975 } 3976 } 3977 3978 if (PatternType == 0) 3979 return; 3980 3981 // Generate the diagnostic. 3982 SourceLocation SL = LenArg->getLocStart(); 3983 SourceRange SR = LenArg->getSourceRange(); 3984 SourceManager &SM = PP.getSourceManager(); 3985 3986 // If the function is defined as a builtin macro, do not show macro expansion. 3987 if (SM.isMacroArgExpansion(SL)) { 3988 SL = SM.getSpellingLoc(SL); 3989 SR = SourceRange(SM.getSpellingLoc(SR.getBegin()), 3990 SM.getSpellingLoc(SR.getEnd())); 3991 } 3992 3993 // Check if the destination is an array (rather than a pointer to an array). 3994 QualType DstTy = DstArg->getType(); 3995 bool isKnownSizeArray = isConstantSizeArrayWithMoreThanOneElement(DstTy, 3996 Context); 3997 if (!isKnownSizeArray) { 3998 if (PatternType == 1) 3999 Diag(SL, diag::warn_strncat_wrong_size) << SR; 4000 else 4001 Diag(SL, diag::warn_strncat_src_size) << SR; 4002 return; 4003 } 4004 4005 if (PatternType == 1) 4006 Diag(SL, diag::warn_strncat_large_size) << SR; 4007 else 4008 Diag(SL, diag::warn_strncat_src_size) << SR; 4009 4010 SmallString<128> sizeString; 4011 llvm::raw_svector_ostream OS(sizeString); 4012 OS << "sizeof("; 4013 DstArg->printPretty(OS, 0, getPrintingPolicy()); 4014 OS << ") - "; 4015 OS << "strlen("; 4016 DstArg->printPretty(OS, 0, getPrintingPolicy()); 4017 OS << ") - 1"; 4018 4019 Diag(SL, diag::note_strncat_wrong_size) 4020 << FixItHint::CreateReplacement(SR, OS.str()); 4021 } 4022 4023 //===--- CHECK: Return Address of Stack Variable --------------------------===// 4024 4025 static Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 4026 Decl *ParentDecl); 4027 static Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars, 4028 Decl *ParentDecl); 4029 4030 /// CheckReturnStackAddr - Check if a return statement returns the address 4031 /// of a stack variable. 4032 static void 4033 CheckReturnStackAddr(Sema &S, Expr *RetValExp, QualType lhsType, 4034 SourceLocation ReturnLoc) { 4035 4036 Expr *stackE = 0; 4037 SmallVector<DeclRefExpr *, 8> refVars; 4038 4039 // Perform checking for returned stack addresses, local blocks, 4040 // label addresses or references to temporaries. 4041 if (lhsType->isPointerType() || 4042 (!S.getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) { 4043 stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/0); 4044 } else if (lhsType->isReferenceType()) { 4045 stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/0); 4046 } 4047 4048 if (stackE == 0) 4049 return; // Nothing suspicious was found. 4050 4051 SourceLocation diagLoc; 4052 SourceRange diagRange; 4053 if (refVars.empty()) { 4054 diagLoc = stackE->getLocStart(); 4055 diagRange = stackE->getSourceRange(); 4056 } else { 4057 // We followed through a reference variable. 'stackE' contains the 4058 // problematic expression but we will warn at the return statement pointing 4059 // at the reference variable. We will later display the "trail" of 4060 // reference variables using notes. 4061 diagLoc = refVars[0]->getLocStart(); 4062 diagRange = refVars[0]->getSourceRange(); 4063 } 4064 4065 if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 4066 S.Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 4067 : diag::warn_ret_stack_addr) 4068 << DR->getDecl()->getDeclName() << diagRange; 4069 } else if (isa<BlockExpr>(stackE)) { // local block. 4070 S.Diag(diagLoc, diag::err_ret_local_block) << diagRange; 4071 } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 4072 S.Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 4073 } else { // local temporary. 4074 S.Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 4075 : diag::warn_ret_local_temp_addr) 4076 << diagRange; 4077 } 4078 4079 // Display the "trail" of reference variables that we followed until we 4080 // found the problematic expression using notes. 4081 for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 4082 VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 4083 // If this var binds to another reference var, show the range of the next 4084 // var, otherwise the var binds to the problematic expression, in which case 4085 // show the range of the expression. 4086 SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 4087 : stackE->getSourceRange(); 4088 S.Diag(VD->getLocation(), diag::note_ref_var_local_bind) 4089 << VD->getDeclName() << range; 4090 } 4091 } 4092 4093 /// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 4094 /// check if the expression in a return statement evaluates to an address 4095 /// to a location on the stack, a local block, an address of a label, or a 4096 /// reference to local temporary. The recursion is used to traverse the 4097 /// AST of the return expression, with recursion backtracking when we 4098 /// encounter a subexpression that (1) clearly does not lead to one of the 4099 /// above problematic expressions (2) is something we cannot determine leads to 4100 /// a problematic expression based on such local checking. 4101 /// 4102 /// Both EvalAddr and EvalVal follow through reference variables to evaluate 4103 /// the expression that they point to. Such variables are added to the 4104 /// 'refVars' vector so that we know what the reference variable "trail" was. 4105 /// 4106 /// EvalAddr processes expressions that are pointers that are used as 4107 /// references (and not L-values). EvalVal handles all other values. 4108 /// At the base case of the recursion is a check for the above problematic 4109 /// expressions. 4110 /// 4111 /// This implementation handles: 4112 /// 4113 /// * pointer-to-pointer casts 4114 /// * implicit conversions from array references to pointers 4115 /// * taking the address of fields 4116 /// * arbitrary interplay between "&" and "*" operators 4117 /// * pointer arithmetic from an address of a stack variable 4118 /// * taking the address of an array element where the array is on the stack 4119 static Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 4120 Decl *ParentDecl) { 4121 if (E->isTypeDependent()) 4122 return NULL; 4123 4124 // We should only be called for evaluating pointer expressions. 4125 assert((E->getType()->isAnyPointerType() || 4126 E->getType()->isBlockPointerType() || 4127 E->getType()->isObjCQualifiedIdType()) && 4128 "EvalAddr only works on pointers"); 4129 4130 E = E->IgnoreParens(); 4131 4132 // Our "symbolic interpreter" is just a dispatch off the currently 4133 // viewed AST node. We then recursively traverse the AST by calling 4134 // EvalAddr and EvalVal appropriately. 4135 switch (E->getStmtClass()) { 4136 case Stmt::DeclRefExprClass: { 4137 DeclRefExpr *DR = cast<DeclRefExpr>(E); 4138 4139 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 4140 // If this is a reference variable, follow through to the expression that 4141 // it points to. 4142 if (V->hasLocalStorage() && 4143 V->getType()->isReferenceType() && V->hasInit()) { 4144 // Add the reference variable to the "trail". 4145 refVars.push_back(DR); 4146 return EvalAddr(V->getInit(), refVars, ParentDecl); 4147 } 4148 4149 return NULL; 4150 } 4151 4152 case Stmt::UnaryOperatorClass: { 4153 // The only unary operator that make sense to handle here 4154 // is AddrOf. All others don't make sense as pointers. 4155 UnaryOperator *U = cast<UnaryOperator>(E); 4156 4157 if (U->getOpcode() == UO_AddrOf) 4158 return EvalVal(U->getSubExpr(), refVars, ParentDecl); 4159 else 4160 return NULL; 4161 } 4162 4163 case Stmt::BinaryOperatorClass: { 4164 // Handle pointer arithmetic. All other binary operators are not valid 4165 // in this context. 4166 BinaryOperator *B = cast<BinaryOperator>(E); 4167 BinaryOperatorKind op = B->getOpcode(); 4168 4169 if (op != BO_Add && op != BO_Sub) 4170 return NULL; 4171 4172 Expr *Base = B->getLHS(); 4173 4174 // Determine which argument is the real pointer base. It could be 4175 // the RHS argument instead of the LHS. 4176 if (!Base->getType()->isPointerType()) Base = B->getRHS(); 4177 4178 assert (Base->getType()->isPointerType()); 4179 return EvalAddr(Base, refVars, ParentDecl); 4180 } 4181 4182 // For conditional operators we need to see if either the LHS or RHS are 4183 // valid DeclRefExpr*s. If one of them is valid, we return it. 4184 case Stmt::ConditionalOperatorClass: { 4185 ConditionalOperator *C = cast<ConditionalOperator>(E); 4186 4187 // Handle the GNU extension for missing LHS. 4188 // FIXME: That isn't a ConditionalOperator, so doesn't get here. 4189 if (Expr *LHSExpr = C->getLHS()) { 4190 // In C++, we can have a throw-expression, which has 'void' type. 4191 if (!LHSExpr->getType()->isVoidType()) 4192 if (Expr *LHS = EvalAddr(LHSExpr, refVars, ParentDecl)) 4193 return LHS; 4194 } 4195 4196 // In C++, we can have a throw-expression, which has 'void' type. 4197 if (C->getRHS()->getType()->isVoidType()) 4198 return 0; 4199 4200 return EvalAddr(C->getRHS(), refVars, ParentDecl); 4201 } 4202 4203 case Stmt::BlockExprClass: 4204 if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 4205 return E; // local block. 4206 return NULL; 4207 4208 case Stmt::AddrLabelExprClass: 4209 return E; // address of label. 4210 4211 case Stmt::ExprWithCleanupsClass: 4212 return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars, 4213 ParentDecl); 4214 4215 // For casts, we need to handle conversions from arrays to 4216 // pointer values, and pointer-to-pointer conversions. 4217 case Stmt::ImplicitCastExprClass: 4218 case Stmt::CStyleCastExprClass: 4219 case Stmt::CXXFunctionalCastExprClass: 4220 case Stmt::ObjCBridgedCastExprClass: 4221 case Stmt::CXXStaticCastExprClass: 4222 case Stmt::CXXDynamicCastExprClass: 4223 case Stmt::CXXConstCastExprClass: 4224 case Stmt::CXXReinterpretCastExprClass: { 4225 Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 4226 switch (cast<CastExpr>(E)->getCastKind()) { 4227 case CK_BitCast: 4228 case CK_LValueToRValue: 4229 case CK_NoOp: 4230 case CK_BaseToDerived: 4231 case CK_DerivedToBase: 4232 case CK_UncheckedDerivedToBase: 4233 case CK_Dynamic: 4234 case CK_CPointerToObjCPointerCast: 4235 case CK_BlockPointerToObjCPointerCast: 4236 case CK_AnyPointerToBlockPointerCast: 4237 return EvalAddr(SubExpr, refVars, ParentDecl); 4238 4239 case CK_ArrayToPointerDecay: 4240 return EvalVal(SubExpr, refVars, ParentDecl); 4241 4242 default: 4243 return 0; 4244 } 4245 } 4246 4247 case Stmt::MaterializeTemporaryExprClass: 4248 if (Expr *Result = EvalAddr( 4249 cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 4250 refVars, ParentDecl)) 4251 return Result; 4252 4253 return E; 4254 4255 // Everything else: we simply don't reason about them. 4256 default: 4257 return NULL; 4258 } 4259 } 4260 4261 4262 /// EvalVal - This function is complements EvalAddr in the mutual recursion. 4263 /// See the comments for EvalAddr for more details. 4264 static Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 4265 Decl *ParentDecl) { 4266 do { 4267 // We should only be called for evaluating non-pointer expressions, or 4268 // expressions with a pointer type that are not used as references but instead 4269 // are l-values (e.g., DeclRefExpr with a pointer type). 4270 4271 // Our "symbolic interpreter" is just a dispatch off the currently 4272 // viewed AST node. We then recursively traverse the AST by calling 4273 // EvalAddr and EvalVal appropriately. 4274 4275 E = E->IgnoreParens(); 4276 switch (E->getStmtClass()) { 4277 case Stmt::ImplicitCastExprClass: { 4278 ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 4279 if (IE->getValueKind() == VK_LValue) { 4280 E = IE->getSubExpr(); 4281 continue; 4282 } 4283 return NULL; 4284 } 4285 4286 case Stmt::ExprWithCleanupsClass: 4287 return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,ParentDecl); 4288 4289 case Stmt::DeclRefExprClass: { 4290 // When we hit a DeclRefExpr we are looking at code that refers to a 4291 // variable's name. If it's not a reference variable we check if it has 4292 // local storage within the function, and if so, return the expression. 4293 DeclRefExpr *DR = cast<DeclRefExpr>(E); 4294 4295 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) { 4296 // Check if it refers to itself, e.g. "int& i = i;". 4297 if (V == ParentDecl) 4298 return DR; 4299 4300 if (V->hasLocalStorage()) { 4301 if (!V->getType()->isReferenceType()) 4302 return DR; 4303 4304 // Reference variable, follow through to the expression that 4305 // it points to. 4306 if (V->hasInit()) { 4307 // Add the reference variable to the "trail". 4308 refVars.push_back(DR); 4309 return EvalVal(V->getInit(), refVars, V); 4310 } 4311 } 4312 } 4313 4314 return NULL; 4315 } 4316 4317 case Stmt::UnaryOperatorClass: { 4318 // The only unary operator that make sense to handle here 4319 // is Deref. All others don't resolve to a "name." This includes 4320 // handling all sorts of rvalues passed to a unary operator. 4321 UnaryOperator *U = cast<UnaryOperator>(E); 4322 4323 if (U->getOpcode() == UO_Deref) 4324 return EvalAddr(U->getSubExpr(), refVars, ParentDecl); 4325 4326 return NULL; 4327 } 4328 4329 case Stmt::ArraySubscriptExprClass: { 4330 // Array subscripts are potential references to data on the stack. We 4331 // retrieve the DeclRefExpr* for the array variable if it indeed 4332 // has local storage. 4333 return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars,ParentDecl); 4334 } 4335 4336 case Stmt::ConditionalOperatorClass: { 4337 // For conditional operators we need to see if either the LHS or RHS are 4338 // non-NULL Expr's. If one is non-NULL, we return it. 4339 ConditionalOperator *C = cast<ConditionalOperator>(E); 4340 4341 // Handle the GNU extension for missing LHS. 4342 if (Expr *LHSExpr = C->getLHS()) { 4343 // In C++, we can have a throw-expression, which has 'void' type. 4344 if (!LHSExpr->getType()->isVoidType()) 4345 if (Expr *LHS = EvalVal(LHSExpr, refVars, ParentDecl)) 4346 return LHS; 4347 } 4348 4349 // In C++, we can have a throw-expression, which has 'void' type. 4350 if (C->getRHS()->getType()->isVoidType()) 4351 return 0; 4352 4353 return EvalVal(C->getRHS(), refVars, ParentDecl); 4354 } 4355 4356 // Accesses to members are potential references to data on the stack. 4357 case Stmt::MemberExprClass: { 4358 MemberExpr *M = cast<MemberExpr>(E); 4359 4360 // Check for indirect access. We only want direct field accesses. 4361 if (M->isArrow()) 4362 return NULL; 4363 4364 // Check whether the member type is itself a reference, in which case 4365 // we're not going to refer to the member, but to what the member refers to. 4366 if (M->getMemberDecl()->getType()->isReferenceType()) 4367 return NULL; 4368 4369 return EvalVal(M->getBase(), refVars, ParentDecl); 4370 } 4371 4372 case Stmt::MaterializeTemporaryExprClass: 4373 if (Expr *Result = EvalVal( 4374 cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 4375 refVars, ParentDecl)) 4376 return Result; 4377 4378 return E; 4379 4380 default: 4381 // Check that we don't return or take the address of a reference to a 4382 // temporary. This is only useful in C++. 4383 if (!E->isTypeDependent() && E->isRValue()) 4384 return E; 4385 4386 // Everything else: we simply don't reason about them. 4387 return NULL; 4388 } 4389 } while (true); 4390 } 4391 4392 void 4393 Sema::CheckReturnValExpr(Expr *RetValExp, QualType lhsType, 4394 SourceLocation ReturnLoc, 4395 bool isObjCMethod, 4396 const AttrVec *Attrs, 4397 const FunctionDecl *FD) { 4398 CheckReturnStackAddr(*this, RetValExp, lhsType, ReturnLoc); 4399 4400 // Check if the return value is null but should not be. 4401 if (Attrs) 4402 for (specific_attr_iterator<ReturnsNonNullAttr> 4403 I = specific_attr_iterator<ReturnsNonNullAttr>(Attrs->begin()), 4404 E = specific_attr_iterator<ReturnsNonNullAttr>(Attrs->end()); 4405 I != E; ++I) { 4406 if (CheckNonNullExpr(*this, RetValExp)) 4407 Diag(ReturnLoc, diag::warn_null_ret) 4408 << (isObjCMethod ? 1 : 0) << RetValExp->getSourceRange(); 4409 break; 4410 } 4411 4412 // C++11 [basic.stc.dynamic.allocation]p4: 4413 // If an allocation function declared with a non-throwing 4414 // exception-specification fails to allocate storage, it shall return 4415 // a null pointer. Any other allocation function that fails to allocate 4416 // storage shall indicate failure only by throwing an exception [...] 4417 if (FD) { 4418 OverloadedOperatorKind Op = FD->getOverloadedOperator(); 4419 if (Op == OO_New || Op == OO_Array_New) { 4420 const FunctionProtoType *Proto 4421 = FD->getType()->castAs<FunctionProtoType>(); 4422 if (!Proto->isNothrow(Context, /*ResultIfDependent*/true) && 4423 CheckNonNullExpr(*this, RetValExp)) 4424 Diag(ReturnLoc, diag::warn_operator_new_returns_null) 4425 << FD << getLangOpts().CPlusPlus11; 4426 } 4427 } 4428 } 4429 4430 //===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 4431 4432 /// Check for comparisons of floating point operands using != and ==. 4433 /// Issue a warning if these are no self-comparisons, as they are not likely 4434 /// to do what the programmer intended. 4435 void Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) { 4436 Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts(); 4437 Expr* RightExprSansParen = RHS->IgnoreParenImpCasts(); 4438 4439 // Special case: check for x == x (which is OK). 4440 // Do not emit warnings for such cases. 4441 if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 4442 if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 4443 if (DRL->getDecl() == DRR->getDecl()) 4444 return; 4445 4446 4447 // Special case: check for comparisons against literals that can be exactly 4448 // represented by APFloat. In such cases, do not emit a warning. This 4449 // is a heuristic: often comparison against such literals are used to 4450 // detect if a value in a variable has not changed. This clearly can 4451 // lead to false negatives. 4452 if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 4453 if (FLL->isExact()) 4454 return; 4455 } else 4456 if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)) 4457 if (FLR->isExact()) 4458 return; 4459 4460 // Check for comparisons with builtin types. 4461 if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 4462 if (CL->getBuiltinCallee()) 4463 return; 4464 4465 if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 4466 if (CR->getBuiltinCallee()) 4467 return; 4468 4469 // Emit the diagnostic. 4470 Diag(Loc, diag::warn_floatingpoint_eq) 4471 << LHS->getSourceRange() << RHS->getSourceRange(); 4472 } 4473 4474 //===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 4475 //===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 4476 4477 namespace { 4478 4479 /// Structure recording the 'active' range of an integer-valued 4480 /// expression. 4481 struct IntRange { 4482 /// The number of bits active in the int. 4483 unsigned Width; 4484 4485 /// True if the int is known not to have negative values. 4486 bool NonNegative; 4487 4488 IntRange(unsigned Width, bool NonNegative) 4489 : Width(Width), NonNegative(NonNegative) 4490 {} 4491 4492 /// Returns the range of the bool type. 4493 static IntRange forBoolType() { 4494 return IntRange(1, true); 4495 } 4496 4497 /// Returns the range of an opaque value of the given integral type. 4498 static IntRange forValueOfType(ASTContext &C, QualType T) { 4499 return forValueOfCanonicalType(C, 4500 T->getCanonicalTypeInternal().getTypePtr()); 4501 } 4502 4503 /// Returns the range of an opaque value of a canonical integral type. 4504 static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 4505 assert(T->isCanonicalUnqualified()); 4506 4507 if (const VectorType *VT = dyn_cast<VectorType>(T)) 4508 T = VT->getElementType().getTypePtr(); 4509 if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 4510 T = CT->getElementType().getTypePtr(); 4511 4512 // For enum types, use the known bit width of the enumerators. 4513 if (const EnumType *ET = dyn_cast<EnumType>(T)) { 4514 EnumDecl *Enum = ET->getDecl(); 4515 if (!Enum->isCompleteDefinition()) 4516 return IntRange(C.getIntWidth(QualType(T, 0)), false); 4517 4518 unsigned NumPositive = Enum->getNumPositiveBits(); 4519 unsigned NumNegative = Enum->getNumNegativeBits(); 4520 4521 if (NumNegative == 0) 4522 return IntRange(NumPositive, true/*NonNegative*/); 4523 else 4524 return IntRange(std::max(NumPositive + 1, NumNegative), 4525 false/*NonNegative*/); 4526 } 4527 4528 const BuiltinType *BT = cast<BuiltinType>(T); 4529 assert(BT->isInteger()); 4530 4531 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 4532 } 4533 4534 /// Returns the "target" range of a canonical integral type, i.e. 4535 /// the range of values expressible in the type. 4536 /// 4537 /// This matches forValueOfCanonicalType except that enums have the 4538 /// full range of their type, not the range of their enumerators. 4539 static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 4540 assert(T->isCanonicalUnqualified()); 4541 4542 if (const VectorType *VT = dyn_cast<VectorType>(T)) 4543 T = VT->getElementType().getTypePtr(); 4544 if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 4545 T = CT->getElementType().getTypePtr(); 4546 if (const EnumType *ET = dyn_cast<EnumType>(T)) 4547 T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr(); 4548 4549 const BuiltinType *BT = cast<BuiltinType>(T); 4550 assert(BT->isInteger()); 4551 4552 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 4553 } 4554 4555 /// Returns the supremum of two ranges: i.e. their conservative merge. 4556 static IntRange join(IntRange L, IntRange R) { 4557 return IntRange(std::max(L.Width, R.Width), 4558 L.NonNegative && R.NonNegative); 4559 } 4560 4561 /// Returns the infinum of two ranges: i.e. their aggressive merge. 4562 static IntRange meet(IntRange L, IntRange R) { 4563 return IntRange(std::min(L.Width, R.Width), 4564 L.NonNegative || R.NonNegative); 4565 } 4566 }; 4567 4568 static IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, 4569 unsigned MaxWidth) { 4570 if (value.isSigned() && value.isNegative()) 4571 return IntRange(value.getMinSignedBits(), false); 4572 4573 if (value.getBitWidth() > MaxWidth) 4574 value = value.trunc(MaxWidth); 4575 4576 // isNonNegative() just checks the sign bit without considering 4577 // signedness. 4578 return IntRange(value.getActiveBits(), true); 4579 } 4580 4581 static IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 4582 unsigned MaxWidth) { 4583 if (result.isInt()) 4584 return GetValueRange(C, result.getInt(), MaxWidth); 4585 4586 if (result.isVector()) { 4587 IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 4588 for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 4589 IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 4590 R = IntRange::join(R, El); 4591 } 4592 return R; 4593 } 4594 4595 if (result.isComplexInt()) { 4596 IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 4597 IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 4598 return IntRange::join(R, I); 4599 } 4600 4601 // This can happen with lossless casts to intptr_t of "based" lvalues. 4602 // Assume it might use arbitrary bits. 4603 // FIXME: The only reason we need to pass the type in here is to get 4604 // the sign right on this one case. It would be nice if APValue 4605 // preserved this. 4606 assert(result.isLValue() || result.isAddrLabelDiff()); 4607 return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 4608 } 4609 4610 static QualType GetExprType(Expr *E) { 4611 QualType Ty = E->getType(); 4612 if (const AtomicType *AtomicRHS = Ty->getAs<AtomicType>()) 4613 Ty = AtomicRHS->getValueType(); 4614 return Ty; 4615 } 4616 4617 /// Pseudo-evaluate the given integer expression, estimating the 4618 /// range of values it might take. 4619 /// 4620 /// \param MaxWidth - the width to which the value will be truncated 4621 static IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 4622 E = E->IgnoreParens(); 4623 4624 // Try a full evaluation first. 4625 Expr::EvalResult result; 4626 if (E->EvaluateAsRValue(result, C)) 4627 return GetValueRange(C, result.Val, GetExprType(E), MaxWidth); 4628 4629 // I think we only want to look through implicit casts here; if the 4630 // user has an explicit widening cast, we should treat the value as 4631 // being of the new, wider type. 4632 if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 4633 if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue) 4634 return GetExprRange(C, CE->getSubExpr(), MaxWidth); 4635 4636 IntRange OutputTypeRange = IntRange::forValueOfType(C, GetExprType(CE)); 4637 4638 bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 4639 4640 // Assume that non-integer casts can span the full range of the type. 4641 if (!isIntegerCast) 4642 return OutputTypeRange; 4643 4644 IntRange SubRange 4645 = GetExprRange(C, CE->getSubExpr(), 4646 std::min(MaxWidth, OutputTypeRange.Width)); 4647 4648 // Bail out if the subexpr's range is as wide as the cast type. 4649 if (SubRange.Width >= OutputTypeRange.Width) 4650 return OutputTypeRange; 4651 4652 // Otherwise, we take the smaller width, and we're non-negative if 4653 // either the output type or the subexpr is. 4654 return IntRange(SubRange.Width, 4655 SubRange.NonNegative || OutputTypeRange.NonNegative); 4656 } 4657 4658 if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 4659 // If we can fold the condition, just take that operand. 4660 bool CondResult; 4661 if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 4662 return GetExprRange(C, CondResult ? CO->getTrueExpr() 4663 : CO->getFalseExpr(), 4664 MaxWidth); 4665 4666 // Otherwise, conservatively merge. 4667 IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 4668 IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 4669 return IntRange::join(L, R); 4670 } 4671 4672 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 4673 switch (BO->getOpcode()) { 4674 4675 // Boolean-valued operations are single-bit and positive. 4676 case BO_LAnd: 4677 case BO_LOr: 4678 case BO_LT: 4679 case BO_GT: 4680 case BO_LE: 4681 case BO_GE: 4682 case BO_EQ: 4683 case BO_NE: 4684 return IntRange::forBoolType(); 4685 4686 // The type of the assignments is the type of the LHS, so the RHS 4687 // is not necessarily the same type. 4688 case BO_MulAssign: 4689 case BO_DivAssign: 4690 case BO_RemAssign: 4691 case BO_AddAssign: 4692 case BO_SubAssign: 4693 case BO_XorAssign: 4694 case BO_OrAssign: 4695 // TODO: bitfields? 4696 return IntRange::forValueOfType(C, GetExprType(E)); 4697 4698 // Simple assignments just pass through the RHS, which will have 4699 // been coerced to the LHS type. 4700 case BO_Assign: 4701 // TODO: bitfields? 4702 return GetExprRange(C, BO->getRHS(), MaxWidth); 4703 4704 // Operations with opaque sources are black-listed. 4705 case BO_PtrMemD: 4706 case BO_PtrMemI: 4707 return IntRange::forValueOfType(C, GetExprType(E)); 4708 4709 // Bitwise-and uses the *infinum* of the two source ranges. 4710 case BO_And: 4711 case BO_AndAssign: 4712 return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 4713 GetExprRange(C, BO->getRHS(), MaxWidth)); 4714 4715 // Left shift gets black-listed based on a judgement call. 4716 case BO_Shl: 4717 // ...except that we want to treat '1 << (blah)' as logically 4718 // positive. It's an important idiom. 4719 if (IntegerLiteral *I 4720 = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 4721 if (I->getValue() == 1) { 4722 IntRange R = IntRange::forValueOfType(C, GetExprType(E)); 4723 return IntRange(R.Width, /*NonNegative*/ true); 4724 } 4725 } 4726 // fallthrough 4727 4728 case BO_ShlAssign: 4729 return IntRange::forValueOfType(C, GetExprType(E)); 4730 4731 // Right shift by a constant can narrow its left argument. 4732 case BO_Shr: 4733 case BO_ShrAssign: { 4734 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 4735 4736 // If the shift amount is a positive constant, drop the width by 4737 // that much. 4738 llvm::APSInt shift; 4739 if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 4740 shift.isNonNegative()) { 4741 unsigned zext = shift.getZExtValue(); 4742 if (zext >= L.Width) 4743 L.Width = (L.NonNegative ? 0 : 1); 4744 else 4745 L.Width -= zext; 4746 } 4747 4748 return L; 4749 } 4750 4751 // Comma acts as its right operand. 4752 case BO_Comma: 4753 return GetExprRange(C, BO->getRHS(), MaxWidth); 4754 4755 // Black-list pointer subtractions. 4756 case BO_Sub: 4757 if (BO->getLHS()->getType()->isPointerType()) 4758 return IntRange::forValueOfType(C, GetExprType(E)); 4759 break; 4760 4761 // The width of a division result is mostly determined by the size 4762 // of the LHS. 4763 case BO_Div: { 4764 // Don't 'pre-truncate' the operands. 4765 unsigned opWidth = C.getIntWidth(GetExprType(E)); 4766 IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 4767 4768 // If the divisor is constant, use that. 4769 llvm::APSInt divisor; 4770 if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) { 4771 unsigned log2 = divisor.logBase2(); // floor(log_2(divisor)) 4772 if (log2 >= L.Width) 4773 L.Width = (L.NonNegative ? 0 : 1); 4774 else 4775 L.Width = std::min(L.Width - log2, MaxWidth); 4776 return L; 4777 } 4778 4779 // Otherwise, just use the LHS's width. 4780 IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 4781 return IntRange(L.Width, L.NonNegative && R.NonNegative); 4782 } 4783 4784 // The result of a remainder can't be larger than the result of 4785 // either side. 4786 case BO_Rem: { 4787 // Don't 'pre-truncate' the operands. 4788 unsigned opWidth = C.getIntWidth(GetExprType(E)); 4789 IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 4790 IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 4791 4792 IntRange meet = IntRange::meet(L, R); 4793 meet.Width = std::min(meet.Width, MaxWidth); 4794 return meet; 4795 } 4796 4797 // The default behavior is okay for these. 4798 case BO_Mul: 4799 case BO_Add: 4800 case BO_Xor: 4801 case BO_Or: 4802 break; 4803 } 4804 4805 // The default case is to treat the operation as if it were closed 4806 // on the narrowest type that encompasses both operands. 4807 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 4808 IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 4809 return IntRange::join(L, R); 4810 } 4811 4812 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 4813 switch (UO->getOpcode()) { 4814 // Boolean-valued operations are white-listed. 4815 case UO_LNot: 4816 return IntRange::forBoolType(); 4817 4818 // Operations with opaque sources are black-listed. 4819 case UO_Deref: 4820 case UO_AddrOf: // should be impossible 4821 return IntRange::forValueOfType(C, GetExprType(E)); 4822 4823 default: 4824 return GetExprRange(C, UO->getSubExpr(), MaxWidth); 4825 } 4826 } 4827 4828 if (OpaqueValueExpr *OVE = dyn_cast<OpaqueValueExpr>(E)) 4829 return GetExprRange(C, OVE->getSourceExpr(), MaxWidth); 4830 4831 if (FieldDecl *BitField = E->getSourceBitField()) 4832 return IntRange(BitField->getBitWidthValue(C), 4833 BitField->getType()->isUnsignedIntegerOrEnumerationType()); 4834 4835 return IntRange::forValueOfType(C, GetExprType(E)); 4836 } 4837 4838 static IntRange GetExprRange(ASTContext &C, Expr *E) { 4839 return GetExprRange(C, E, C.getIntWidth(GetExprType(E))); 4840 } 4841 4842 /// Checks whether the given value, which currently has the given 4843 /// source semantics, has the same value when coerced through the 4844 /// target semantics. 4845 static bool IsSameFloatAfterCast(const llvm::APFloat &value, 4846 const llvm::fltSemantics &Src, 4847 const llvm::fltSemantics &Tgt) { 4848 llvm::APFloat truncated = value; 4849 4850 bool ignored; 4851 truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 4852 truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 4853 4854 return truncated.bitwiseIsEqual(value); 4855 } 4856 4857 /// Checks whether the given value, which currently has the given 4858 /// source semantics, has the same value when coerced through the 4859 /// target semantics. 4860 /// 4861 /// The value might be a vector of floats (or a complex number). 4862 static bool IsSameFloatAfterCast(const APValue &value, 4863 const llvm::fltSemantics &Src, 4864 const llvm::fltSemantics &Tgt) { 4865 if (value.isFloat()) 4866 return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 4867 4868 if (value.isVector()) { 4869 for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 4870 if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 4871 return false; 4872 return true; 4873 } 4874 4875 assert(value.isComplexFloat()); 4876 return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 4877 IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 4878 } 4879 4880 static void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 4881 4882 static bool IsZero(Sema &S, Expr *E) { 4883 // Suppress cases where we are comparing against an enum constant. 4884 if (const DeclRefExpr *DR = 4885 dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 4886 if (isa<EnumConstantDecl>(DR->getDecl())) 4887 return false; 4888 4889 // Suppress cases where the '0' value is expanded from a macro. 4890 if (E->getLocStart().isMacroID()) 4891 return false; 4892 4893 llvm::APSInt Value; 4894 return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 4895 } 4896 4897 static bool HasEnumType(Expr *E) { 4898 // Strip off implicit integral promotions. 4899 while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 4900 if (ICE->getCastKind() != CK_IntegralCast && 4901 ICE->getCastKind() != CK_NoOp) 4902 break; 4903 E = ICE->getSubExpr(); 4904 } 4905 4906 return E->getType()->isEnumeralType(); 4907 } 4908 4909 static void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 4910 // Disable warning in template instantiations. 4911 if (!S.ActiveTemplateInstantiations.empty()) 4912 return; 4913 4914 BinaryOperatorKind op = E->getOpcode(); 4915 if (E->isValueDependent()) 4916 return; 4917 4918 if (op == BO_LT && IsZero(S, E->getRHS())) { 4919 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 4920 << "< 0" << "false" << HasEnumType(E->getLHS()) 4921 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 4922 } else if (op == BO_GE && IsZero(S, E->getRHS())) { 4923 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 4924 << ">= 0" << "true" << HasEnumType(E->getLHS()) 4925 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 4926 } else if (op == BO_GT && IsZero(S, E->getLHS())) { 4927 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 4928 << "0 >" << "false" << HasEnumType(E->getRHS()) 4929 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 4930 } else if (op == BO_LE && IsZero(S, E->getLHS())) { 4931 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 4932 << "0 <=" << "true" << HasEnumType(E->getRHS()) 4933 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 4934 } 4935 } 4936 4937 static void DiagnoseOutOfRangeComparison(Sema &S, BinaryOperator *E, 4938 Expr *Constant, Expr *Other, 4939 llvm::APSInt Value, 4940 bool RhsConstant) { 4941 // Disable warning in template instantiations. 4942 if (!S.ActiveTemplateInstantiations.empty()) 4943 return; 4944 4945 // 0 values are handled later by CheckTrivialUnsignedComparison(). 4946 if (Value == 0) 4947 return; 4948 4949 BinaryOperatorKind op = E->getOpcode(); 4950 QualType OtherT = Other->getType(); 4951 QualType ConstantT = Constant->getType(); 4952 QualType CommonT = E->getLHS()->getType(); 4953 if (S.Context.hasSameUnqualifiedType(OtherT, ConstantT)) 4954 return; 4955 assert((OtherT->isIntegerType() && ConstantT->isIntegerType()) 4956 && "comparison with non-integer type"); 4957 4958 bool ConstantSigned = ConstantT->isSignedIntegerType(); 4959 bool CommonSigned = CommonT->isSignedIntegerType(); 4960 4961 bool EqualityOnly = false; 4962 4963 // TODO: Investigate using GetExprRange() to get tighter bounds on 4964 // on the bit ranges. 4965 IntRange OtherRange = IntRange::forValueOfType(S.Context, OtherT); 4966 unsigned OtherWidth = OtherRange.Width; 4967 4968 if (CommonSigned) { 4969 // The common type is signed, therefore no signed to unsigned conversion. 4970 if (!OtherRange.NonNegative) { 4971 // Check that the constant is representable in type OtherT. 4972 if (ConstantSigned) { 4973 if (OtherWidth >= Value.getMinSignedBits()) 4974 return; 4975 } else { // !ConstantSigned 4976 if (OtherWidth >= Value.getActiveBits() + 1) 4977 return; 4978 } 4979 } else { // !OtherSigned 4980 // Check that the constant is representable in type OtherT. 4981 // Negative values are out of range. 4982 if (ConstantSigned) { 4983 if (Value.isNonNegative() && OtherWidth >= Value.getActiveBits()) 4984 return; 4985 } else { // !ConstantSigned 4986 if (OtherWidth >= Value.getActiveBits()) 4987 return; 4988 } 4989 } 4990 } else { // !CommonSigned 4991 if (OtherRange.NonNegative) { 4992 if (OtherWidth >= Value.getActiveBits()) 4993 return; 4994 } else if (!OtherRange.NonNegative && !ConstantSigned) { 4995 // Check to see if the constant is representable in OtherT. 4996 if (OtherWidth > Value.getActiveBits()) 4997 return; 4998 // Check to see if the constant is equivalent to a negative value 4999 // cast to CommonT. 5000 if (S.Context.getIntWidth(ConstantT) == S.Context.getIntWidth(CommonT) && 5001 Value.isNegative() && Value.getMinSignedBits() <= OtherWidth) 5002 return; 5003 // The constant value rests between values that OtherT can represent after 5004 // conversion. Relational comparison still works, but equality 5005 // comparisons will be tautological. 5006 EqualityOnly = true; 5007 } else { // OtherSigned && ConstantSigned 5008 assert(0 && "Two signed types converted to unsigned types."); 5009 } 5010 } 5011 5012 bool PositiveConstant = !ConstantSigned || Value.isNonNegative(); 5013 5014 bool IsTrue = true; 5015 if (op == BO_EQ || op == BO_NE) { 5016 IsTrue = op == BO_NE; 5017 } else if (EqualityOnly) { 5018 return; 5019 } else if (RhsConstant) { 5020 if (op == BO_GT || op == BO_GE) 5021 IsTrue = !PositiveConstant; 5022 else // op == BO_LT || op == BO_LE 5023 IsTrue = PositiveConstant; 5024 } else { 5025 if (op == BO_LT || op == BO_LE) 5026 IsTrue = !PositiveConstant; 5027 else // op == BO_GT || op == BO_GE 5028 IsTrue = PositiveConstant; 5029 } 5030 5031 // If this is a comparison to an enum constant, include that 5032 // constant in the diagnostic. 5033 const EnumConstantDecl *ED = 0; 5034 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Constant)) 5035 ED = dyn_cast<EnumConstantDecl>(DR->getDecl()); 5036 5037 SmallString<64> PrettySourceValue; 5038 llvm::raw_svector_ostream OS(PrettySourceValue); 5039 if (ED) 5040 OS << '\'' << *ED << "' (" << Value << ")"; 5041 else 5042 OS << Value; 5043 5044 S.DiagRuntimeBehavior(E->getOperatorLoc(), E, 5045 S.PDiag(diag::warn_out_of_range_compare) 5046 << OS.str() << OtherT << IsTrue 5047 << E->getLHS()->getSourceRange() 5048 << E->getRHS()->getSourceRange()); 5049 } 5050 5051 /// Analyze the operands of the given comparison. Implements the 5052 /// fallback case from AnalyzeComparison. 5053 static void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 5054 AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 5055 AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 5056 } 5057 5058 /// \brief Implements -Wsign-compare. 5059 /// 5060 /// \param E the binary operator to check for warnings 5061 static void AnalyzeComparison(Sema &S, BinaryOperator *E) { 5062 // The type the comparison is being performed in. 5063 QualType T = E->getLHS()->getType(); 5064 assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 5065 && "comparison with mismatched types"); 5066 if (E->isValueDependent()) 5067 return AnalyzeImpConvsInComparison(S, E); 5068 5069 Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); 5070 Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); 5071 5072 bool IsComparisonConstant = false; 5073 5074 // Check whether an integer constant comparison results in a value 5075 // of 'true' or 'false'. 5076 if (T->isIntegralType(S.Context)) { 5077 llvm::APSInt RHSValue; 5078 bool IsRHSIntegralLiteral = 5079 RHS->isIntegerConstantExpr(RHSValue, S.Context); 5080 llvm::APSInt LHSValue; 5081 bool IsLHSIntegralLiteral = 5082 LHS->isIntegerConstantExpr(LHSValue, S.Context); 5083 if (IsRHSIntegralLiteral && !IsLHSIntegralLiteral) 5084 DiagnoseOutOfRangeComparison(S, E, RHS, LHS, RHSValue, true); 5085 else if (!IsRHSIntegralLiteral && IsLHSIntegralLiteral) 5086 DiagnoseOutOfRangeComparison(S, E, LHS, RHS, LHSValue, false); 5087 else 5088 IsComparisonConstant = 5089 (IsRHSIntegralLiteral && IsLHSIntegralLiteral); 5090 } else if (!T->hasUnsignedIntegerRepresentation()) 5091 IsComparisonConstant = E->isIntegerConstantExpr(S.Context); 5092 5093 // We don't do anything special if this isn't an unsigned integral 5094 // comparison: we're only interested in integral comparisons, and 5095 // signed comparisons only happen in cases we don't care to warn about. 5096 // 5097 // We also don't care about value-dependent expressions or expressions 5098 // whose result is a constant. 5099 if (!T->hasUnsignedIntegerRepresentation() || IsComparisonConstant) 5100 return AnalyzeImpConvsInComparison(S, E); 5101 5102 // Check to see if one of the (unmodified) operands is of different 5103 // signedness. 5104 Expr *signedOperand, *unsignedOperand; 5105 if (LHS->getType()->hasSignedIntegerRepresentation()) { 5106 assert(!RHS->getType()->hasSignedIntegerRepresentation() && 5107 "unsigned comparison between two signed integer expressions?"); 5108 signedOperand = LHS; 5109 unsignedOperand = RHS; 5110 } else if (RHS->getType()->hasSignedIntegerRepresentation()) { 5111 signedOperand = RHS; 5112 unsignedOperand = LHS; 5113 } else { 5114 CheckTrivialUnsignedComparison(S, E); 5115 return AnalyzeImpConvsInComparison(S, E); 5116 } 5117 5118 // Otherwise, calculate the effective range of the signed operand. 5119 IntRange signedRange = GetExprRange(S.Context, signedOperand); 5120 5121 // Go ahead and analyze implicit conversions in the operands. Note 5122 // that we skip the implicit conversions on both sides. 5123 AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc()); 5124 AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc()); 5125 5126 // If the signed range is non-negative, -Wsign-compare won't fire, 5127 // but we should still check for comparisons which are always true 5128 // or false. 5129 if (signedRange.NonNegative) 5130 return CheckTrivialUnsignedComparison(S, E); 5131 5132 // For (in)equality comparisons, if the unsigned operand is a 5133 // constant which cannot collide with a overflowed signed operand, 5134 // then reinterpreting the signed operand as unsigned will not 5135 // change the result of the comparison. 5136 if (E->isEqualityOp()) { 5137 unsigned comparisonWidth = S.Context.getIntWidth(T); 5138 IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 5139 5140 // We should never be unable to prove that the unsigned operand is 5141 // non-negative. 5142 assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 5143 5144 if (unsignedRange.Width < comparisonWidth) 5145 return; 5146 } 5147 5148 S.DiagRuntimeBehavior(E->getOperatorLoc(), E, 5149 S.PDiag(diag::warn_mixed_sign_comparison) 5150 << LHS->getType() << RHS->getType() 5151 << LHS->getSourceRange() << RHS->getSourceRange()); 5152 } 5153 5154 /// Analyzes an attempt to assign the given value to a bitfield. 5155 /// 5156 /// Returns true if there was something fishy about the attempt. 5157 static bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 5158 SourceLocation InitLoc) { 5159 assert(Bitfield->isBitField()); 5160 if (Bitfield->isInvalidDecl()) 5161 return false; 5162 5163 // White-list bool bitfields. 5164 if (Bitfield->getType()->isBooleanType()) 5165 return false; 5166 5167 // Ignore value- or type-dependent expressions. 5168 if (Bitfield->getBitWidth()->isValueDependent() || 5169 Bitfield->getBitWidth()->isTypeDependent() || 5170 Init->isValueDependent() || 5171 Init->isTypeDependent()) 5172 return false; 5173 5174 Expr *OriginalInit = Init->IgnoreParenImpCasts(); 5175 5176 llvm::APSInt Value; 5177 if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects)) 5178 return false; 5179 5180 unsigned OriginalWidth = Value.getBitWidth(); 5181 unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context); 5182 5183 if (OriginalWidth <= FieldWidth) 5184 return false; 5185 5186 // Compute the value which the bitfield will contain. 5187 llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 5188 TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType()); 5189 5190 // Check whether the stored value is equal to the original value. 5191 TruncatedValue = TruncatedValue.extend(OriginalWidth); 5192 if (llvm::APSInt::isSameValue(Value, TruncatedValue)) 5193 return false; 5194 5195 // Special-case bitfields of width 1: booleans are naturally 0/1, and 5196 // therefore don't strictly fit into a signed bitfield of width 1. 5197 if (FieldWidth == 1 && Value == 1) 5198 return false; 5199 5200 std::string PrettyValue = Value.toString(10); 5201 std::string PrettyTrunc = TruncatedValue.toString(10); 5202 5203 S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 5204 << PrettyValue << PrettyTrunc << OriginalInit->getType() 5205 << Init->getSourceRange(); 5206 5207 return true; 5208 } 5209 5210 /// Analyze the given simple or compound assignment for warning-worthy 5211 /// operations. 5212 static void AnalyzeAssignment(Sema &S, BinaryOperator *E) { 5213 // Just recurse on the LHS. 5214 AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 5215 5216 // We want to recurse on the RHS as normal unless we're assigning to 5217 // a bitfield. 5218 if (FieldDecl *Bitfield = E->getLHS()->getSourceBitField()) { 5219 if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 5220 E->getOperatorLoc())) { 5221 // Recurse, ignoring any implicit conversions on the RHS. 5222 return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 5223 E->getOperatorLoc()); 5224 } 5225 } 5226 5227 AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 5228 } 5229 5230 /// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 5231 static void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 5232 SourceLocation CContext, unsigned diag, 5233 bool pruneControlFlow = false) { 5234 if (pruneControlFlow) { 5235 S.DiagRuntimeBehavior(E->getExprLoc(), E, 5236 S.PDiag(diag) 5237 << SourceType << T << E->getSourceRange() 5238 << SourceRange(CContext)); 5239 return; 5240 } 5241 S.Diag(E->getExprLoc(), diag) 5242 << SourceType << T << E->getSourceRange() << SourceRange(CContext); 5243 } 5244 5245 /// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 5246 static void DiagnoseImpCast(Sema &S, Expr *E, QualType T, 5247 SourceLocation CContext, unsigned diag, 5248 bool pruneControlFlow = false) { 5249 DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow); 5250 } 5251 5252 /// Diagnose an implicit cast from a literal expression. Does not warn when the 5253 /// cast wouldn't lose information. 5254 void DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T, 5255 SourceLocation CContext) { 5256 // Try to convert the literal exactly to an integer. If we can, don't warn. 5257 bool isExact = false; 5258 const llvm::APFloat &Value = FL->getValue(); 5259 llvm::APSInt IntegerValue(S.Context.getIntWidth(T), 5260 T->hasUnsignedIntegerRepresentation()); 5261 if (Value.convertToInteger(IntegerValue, 5262 llvm::APFloat::rmTowardZero, &isExact) 5263 == llvm::APFloat::opOK && isExact) 5264 return; 5265 5266 // FIXME: Force the precision of the source value down so we don't print 5267 // digits which are usually useless (we don't really care here if we 5268 // truncate a digit by accident in edge cases). Ideally, APFloat::toString 5269 // would automatically print the shortest representation, but it's a bit 5270 // tricky to implement. 5271 SmallString<16> PrettySourceValue; 5272 unsigned precision = llvm::APFloat::semanticsPrecision(Value.getSemantics()); 5273 precision = (precision * 59 + 195) / 196; 5274 Value.toString(PrettySourceValue, precision); 5275 5276 SmallString<16> PrettyTargetValue; 5277 if (T->isSpecificBuiltinType(BuiltinType::Bool)) 5278 PrettyTargetValue = IntegerValue == 0 ? "false" : "true"; 5279 else 5280 IntegerValue.toString(PrettyTargetValue); 5281 5282 S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer) 5283 << FL->getType() << T.getUnqualifiedType() << PrettySourceValue 5284 << PrettyTargetValue << FL->getSourceRange() << SourceRange(CContext); 5285 } 5286 5287 std::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 5288 if (!Range.Width) return "0"; 5289 5290 llvm::APSInt ValueInRange = Value; 5291 ValueInRange.setIsSigned(!Range.NonNegative); 5292 ValueInRange = ValueInRange.trunc(Range.Width); 5293 return ValueInRange.toString(10); 5294 } 5295 5296 static bool IsImplicitBoolFloatConversion(Sema &S, Expr *Ex, bool ToBool) { 5297 if (!isa<ImplicitCastExpr>(Ex)) 5298 return false; 5299 5300 Expr *InnerE = Ex->IgnoreParenImpCasts(); 5301 const Type *Target = S.Context.getCanonicalType(Ex->getType()).getTypePtr(); 5302 const Type *Source = 5303 S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 5304 if (Target->isDependentType()) 5305 return false; 5306 5307 const BuiltinType *FloatCandidateBT = 5308 dyn_cast<BuiltinType>(ToBool ? Source : Target); 5309 const Type *BoolCandidateType = ToBool ? Target : Source; 5310 5311 return (BoolCandidateType->isSpecificBuiltinType(BuiltinType::Bool) && 5312 FloatCandidateBT && (FloatCandidateBT->isFloatingPoint())); 5313 } 5314 5315 void CheckImplicitArgumentConversions(Sema &S, CallExpr *TheCall, 5316 SourceLocation CC) { 5317 unsigned NumArgs = TheCall->getNumArgs(); 5318 for (unsigned i = 0; i < NumArgs; ++i) { 5319 Expr *CurrA = TheCall->getArg(i); 5320 if (!IsImplicitBoolFloatConversion(S, CurrA, true)) 5321 continue; 5322 5323 bool IsSwapped = ((i > 0) && 5324 IsImplicitBoolFloatConversion(S, TheCall->getArg(i - 1), false)); 5325 IsSwapped |= ((i < (NumArgs - 1)) && 5326 IsImplicitBoolFloatConversion(S, TheCall->getArg(i + 1), false)); 5327 if (IsSwapped) { 5328 // Warn on this floating-point to bool conversion. 5329 DiagnoseImpCast(S, CurrA->IgnoreParenImpCasts(), 5330 CurrA->getType(), CC, 5331 diag::warn_impcast_floating_point_to_bool); 5332 } 5333 } 5334 } 5335 5336 void CheckImplicitConversion(Sema &S, Expr *E, QualType T, 5337 SourceLocation CC, bool *ICContext = 0) { 5338 if (E->isTypeDependent() || E->isValueDependent()) return; 5339 5340 const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 5341 const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 5342 if (Source == Target) return; 5343 if (Target->isDependentType()) return; 5344 5345 // If the conversion context location is invalid don't complain. We also 5346 // don't want to emit a warning if the issue occurs from the expansion of 5347 // a system macro. The problem is that 'getSpellingLoc()' is slow, so we 5348 // delay this check as long as possible. Once we detect we are in that 5349 // scenario, we just return. 5350 if (CC.isInvalid()) 5351 return; 5352 5353 // Diagnose implicit casts to bool. 5354 if (Target->isSpecificBuiltinType(BuiltinType::Bool)) { 5355 if (isa<StringLiteral>(E)) 5356 // Warn on string literal to bool. Checks for string literals in logical 5357 // and expressions, for instance, assert(0 && "error here"), are 5358 // prevented by a check in AnalyzeImplicitConversions(). 5359 return DiagnoseImpCast(S, E, T, CC, 5360 diag::warn_impcast_string_literal_to_bool); 5361 if (isa<ObjCStringLiteral>(E) || isa<ObjCArrayLiteral>(E) || 5362 isa<ObjCDictionaryLiteral>(E) || isa<ObjCBoxedExpr>(E)) { 5363 // This covers the literal expressions that evaluate to Objective-C 5364 // objects. 5365 return DiagnoseImpCast(S, E, T, CC, 5366 diag::warn_impcast_objective_c_literal_to_bool); 5367 } 5368 if (Source->isFunctionType()) { 5369 // Warn on function to bool. Checks free functions and static member 5370 // functions. Weakly imported functions are excluded from the check, 5371 // since it's common to test their value to check whether the linker 5372 // found a definition for them. 5373 ValueDecl *D = 0; 5374 if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) { 5375 D = R->getDecl(); 5376 } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) { 5377 D = M->getMemberDecl(); 5378 } 5379 5380 if (D && !D->isWeak()) { 5381 if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) { 5382 S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool) 5383 << F << E->getSourceRange() << SourceRange(CC); 5384 S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence) 5385 << FixItHint::CreateInsertion(E->getExprLoc(), "&"); 5386 QualType ReturnType; 5387 UnresolvedSet<4> NonTemplateOverloads; 5388 S.tryExprAsCall(*E, ReturnType, NonTemplateOverloads); 5389 if (!ReturnType.isNull() 5390 && ReturnType->isSpecificBuiltinType(BuiltinType::Bool)) 5391 S.Diag(E->getExprLoc(), diag::note_function_to_bool_call) 5392 << FixItHint::CreateInsertion( 5393 S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()"); 5394 return; 5395 } 5396 } 5397 } 5398 } 5399 5400 // Strip vector types. 5401 if (isa<VectorType>(Source)) { 5402 if (!isa<VectorType>(Target)) { 5403 if (S.SourceMgr.isInSystemMacro(CC)) 5404 return; 5405 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 5406 } 5407 5408 // If the vector cast is cast between two vectors of the same size, it is 5409 // a bitcast, not a conversion. 5410 if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target)) 5411 return; 5412 5413 Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 5414 Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 5415 } 5416 5417 // Strip complex types. 5418 if (isa<ComplexType>(Source)) { 5419 if (!isa<ComplexType>(Target)) { 5420 if (S.SourceMgr.isInSystemMacro(CC)) 5421 return; 5422 5423 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 5424 } 5425 5426 Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 5427 Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 5428 } 5429 5430 const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 5431 const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 5432 5433 // If the source is floating point... 5434 if (SourceBT && SourceBT->isFloatingPoint()) { 5435 // ...and the target is floating point... 5436 if (TargetBT && TargetBT->isFloatingPoint()) { 5437 // ...then warn if we're dropping FP rank. 5438 5439 // Builtin FP kinds are ordered by increasing FP rank. 5440 if (SourceBT->getKind() > TargetBT->getKind()) { 5441 // Don't warn about float constants that are precisely 5442 // representable in the target type. 5443 Expr::EvalResult result; 5444 if (E->EvaluateAsRValue(result, S.Context)) { 5445 // Value might be a float, a float vector, or a float complex. 5446 if (IsSameFloatAfterCast(result.Val, 5447 S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 5448 S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 5449 return; 5450 } 5451 5452 if (S.SourceMgr.isInSystemMacro(CC)) 5453 return; 5454 5455 DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 5456 } 5457 return; 5458 } 5459 5460 // If the target is integral, always warn. 5461 if (TargetBT && TargetBT->isInteger()) { 5462 if (S.SourceMgr.isInSystemMacro(CC)) 5463 return; 5464 5465 Expr *InnerE = E->IgnoreParenImpCasts(); 5466 // We also want to warn on, e.g., "int i = -1.234" 5467 if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE)) 5468 if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus) 5469 InnerE = UOp->getSubExpr()->IgnoreParenImpCasts(); 5470 5471 if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) { 5472 DiagnoseFloatingLiteralImpCast(S, FL, T, CC); 5473 } else { 5474 DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 5475 } 5476 } 5477 5478 // If the target is bool, warn if expr is a function or method call. 5479 if (Target->isSpecificBuiltinType(BuiltinType::Bool) && 5480 isa<CallExpr>(E)) { 5481 // Check last argument of function call to see if it is an 5482 // implicit cast from a type matching the type the result 5483 // is being cast to. 5484 CallExpr *CEx = cast<CallExpr>(E); 5485 unsigned NumArgs = CEx->getNumArgs(); 5486 if (NumArgs > 0) { 5487 Expr *LastA = CEx->getArg(NumArgs - 1); 5488 Expr *InnerE = LastA->IgnoreParenImpCasts(); 5489 const Type *InnerType = 5490 S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 5491 if (isa<ImplicitCastExpr>(LastA) && (InnerType == Target)) { 5492 // Warn on this floating-point to bool conversion 5493 DiagnoseImpCast(S, E, T, CC, 5494 diag::warn_impcast_floating_point_to_bool); 5495 } 5496 } 5497 } 5498 return; 5499 } 5500 5501 if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull) 5502 == Expr::NPCK_GNUNull) && !Target->isAnyPointerType() 5503 && !Target->isBlockPointerType() && !Target->isMemberPointerType() 5504 && Target->isScalarType() && !Target->isNullPtrType()) { 5505 SourceLocation Loc = E->getSourceRange().getBegin(); 5506 if (Loc.isMacroID()) 5507 Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first; 5508 if (!Loc.isMacroID() || CC.isMacroID()) 5509 S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer) 5510 << T << clang::SourceRange(CC) 5511 << FixItHint::CreateReplacement(Loc, 5512 S.getFixItZeroLiteralForType(T, Loc)); 5513 } 5514 5515 if (!Source->isIntegerType() || !Target->isIntegerType()) 5516 return; 5517 5518 // TODO: remove this early return once the false positives for constant->bool 5519 // in templates, macros, etc, are reduced or removed. 5520 if (Target->isSpecificBuiltinType(BuiltinType::Bool)) 5521 return; 5522 5523 IntRange SourceRange = GetExprRange(S.Context, E); 5524 IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 5525 5526 if (SourceRange.Width > TargetRange.Width) { 5527 // If the source is a constant, use a default-on diagnostic. 5528 // TODO: this should happen for bitfield stores, too. 5529 llvm::APSInt Value(32); 5530 if (E->isIntegerConstantExpr(Value, S.Context)) { 5531 if (S.SourceMgr.isInSystemMacro(CC)) 5532 return; 5533 5534 std::string PrettySourceValue = Value.toString(10); 5535 std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 5536 5537 S.DiagRuntimeBehavior(E->getExprLoc(), E, 5538 S.PDiag(diag::warn_impcast_integer_precision_constant) 5539 << PrettySourceValue << PrettyTargetValue 5540 << E->getType() << T << E->getSourceRange() 5541 << clang::SourceRange(CC)); 5542 return; 5543 } 5544 5545 // People want to build with -Wshorten-64-to-32 and not -Wconversion. 5546 if (S.SourceMgr.isInSystemMacro(CC)) 5547 return; 5548 5549 if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64) 5550 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32, 5551 /* pruneControlFlow */ true); 5552 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 5553 } 5554 5555 if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 5556 (!TargetRange.NonNegative && SourceRange.NonNegative && 5557 SourceRange.Width == TargetRange.Width)) { 5558 5559 if (S.SourceMgr.isInSystemMacro(CC)) 5560 return; 5561 5562 unsigned DiagID = diag::warn_impcast_integer_sign; 5563 5564 // Traditionally, gcc has warned about this under -Wsign-compare. 5565 // We also want to warn about it in -Wconversion. 5566 // So if -Wconversion is off, use a completely identical diagnostic 5567 // in the sign-compare group. 5568 // The conditional-checking code will 5569 if (ICContext) { 5570 DiagID = diag::warn_impcast_integer_sign_conditional; 5571 *ICContext = true; 5572 } 5573 5574 return DiagnoseImpCast(S, E, T, CC, DiagID); 5575 } 5576 5577 // Diagnose conversions between different enumeration types. 5578 // In C, we pretend that the type of an EnumConstantDecl is its enumeration 5579 // type, to give us better diagnostics. 5580 QualType SourceType = E->getType(); 5581 if (!S.getLangOpts().CPlusPlus) { 5582 if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 5583 if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 5584 EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 5585 SourceType = S.Context.getTypeDeclType(Enum); 5586 Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 5587 } 5588 } 5589 5590 if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 5591 if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 5592 if (SourceEnum->getDecl()->hasNameForLinkage() && 5593 TargetEnum->getDecl()->hasNameForLinkage() && 5594 SourceEnum != TargetEnum) { 5595 if (S.SourceMgr.isInSystemMacro(CC)) 5596 return; 5597 5598 return DiagnoseImpCast(S, E, SourceType, T, CC, 5599 diag::warn_impcast_different_enum_types); 5600 } 5601 5602 return; 5603 } 5604 5605 void CheckConditionalOperator(Sema &S, ConditionalOperator *E, 5606 SourceLocation CC, QualType T); 5607 5608 void CheckConditionalOperand(Sema &S, Expr *E, QualType T, 5609 SourceLocation CC, bool &ICContext) { 5610 E = E->IgnoreParenImpCasts(); 5611 5612 if (isa<ConditionalOperator>(E)) 5613 return CheckConditionalOperator(S, cast<ConditionalOperator>(E), CC, T); 5614 5615 AnalyzeImplicitConversions(S, E, CC); 5616 if (E->getType() != T) 5617 return CheckImplicitConversion(S, E, T, CC, &ICContext); 5618 return; 5619 } 5620 5621 void CheckConditionalOperator(Sema &S, ConditionalOperator *E, 5622 SourceLocation CC, QualType T) { 5623 AnalyzeImplicitConversions(S, E->getCond(), CC); 5624 5625 bool Suspicious = false; 5626 CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 5627 CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 5628 5629 // If -Wconversion would have warned about either of the candidates 5630 // for a signedness conversion to the context type... 5631 if (!Suspicious) return; 5632 5633 // ...but it's currently ignored... 5634 if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 5635 CC)) 5636 return; 5637 5638 // ...then check whether it would have warned about either of the 5639 // candidates for a signedness conversion to the condition type. 5640 if (E->getType() == T) return; 5641 5642 Suspicious = false; 5643 CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 5644 E->getType(), CC, &Suspicious); 5645 if (!Suspicious) 5646 CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 5647 E->getType(), CC, &Suspicious); 5648 } 5649 5650 /// AnalyzeImplicitConversions - Find and report any interesting 5651 /// implicit conversions in the given expression. There are a couple 5652 /// of competing diagnostics here, -Wconversion and -Wsign-compare. 5653 void AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 5654 QualType T = OrigE->getType(); 5655 Expr *E = OrigE->IgnoreParenImpCasts(); 5656 5657 if (E->isTypeDependent() || E->isValueDependent()) 5658 return; 5659 5660 // For conditional operators, we analyze the arguments as if they 5661 // were being fed directly into the output. 5662 if (isa<ConditionalOperator>(E)) { 5663 ConditionalOperator *CO = cast<ConditionalOperator>(E); 5664 CheckConditionalOperator(S, CO, CC, T); 5665 return; 5666 } 5667 5668 // Check implicit argument conversions for function calls. 5669 if (CallExpr *Call = dyn_cast<CallExpr>(E)) 5670 CheckImplicitArgumentConversions(S, Call, CC); 5671 5672 // Go ahead and check any implicit conversions we might have skipped. 5673 // The non-canonical typecheck is just an optimization; 5674 // CheckImplicitConversion will filter out dead implicit conversions. 5675 if (E->getType() != T) 5676 CheckImplicitConversion(S, E, T, CC); 5677 5678 // Now continue drilling into this expression. 5679 5680 if (PseudoObjectExpr * POE = dyn_cast<PseudoObjectExpr>(E)) { 5681 if (POE->getResultExpr()) 5682 E = POE->getResultExpr(); 5683 } 5684 5685 if (const OpaqueValueExpr *OVE = dyn_cast<OpaqueValueExpr>(E)) 5686 return AnalyzeImplicitConversions(S, OVE->getSourceExpr(), CC); 5687 5688 // Skip past explicit casts. 5689 if (isa<ExplicitCastExpr>(E)) { 5690 E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 5691 return AnalyzeImplicitConversions(S, E, CC); 5692 } 5693 5694 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 5695 // Do a somewhat different check with comparison operators. 5696 if (BO->isComparisonOp()) 5697 return AnalyzeComparison(S, BO); 5698 5699 // And with simple assignments. 5700 if (BO->getOpcode() == BO_Assign) 5701 return AnalyzeAssignment(S, BO); 5702 } 5703 5704 // These break the otherwise-useful invariant below. Fortunately, 5705 // we don't really need to recurse into them, because any internal 5706 // expressions should have been analyzed already when they were 5707 // built into statements. 5708 if (isa<StmtExpr>(E)) return; 5709 5710 // Don't descend into unevaluated contexts. 5711 if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 5712 5713 // Now just recurse over the expression's children. 5714 CC = E->getExprLoc(); 5715 BinaryOperator *BO = dyn_cast<BinaryOperator>(E); 5716 bool IsLogicalAndOperator = BO && BO->getOpcode() == BO_LAnd; 5717 for (Stmt::child_range I = E->children(); I; ++I) { 5718 Expr *ChildExpr = dyn_cast_or_null<Expr>(*I); 5719 if (!ChildExpr) 5720 continue; 5721 5722 if (IsLogicalAndOperator && 5723 isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts())) 5724 // Ignore checking string literals that are in logical and operators. 5725 // This is a common pattern for asserts. 5726 continue; 5727 AnalyzeImplicitConversions(S, ChildExpr, CC); 5728 } 5729 } 5730 5731 } // end anonymous namespace 5732 5733 /// Diagnoses "dangerous" implicit conversions within the given 5734 /// expression (which is a full expression). Implements -Wconversion 5735 /// and -Wsign-compare. 5736 /// 5737 /// \param CC the "context" location of the implicit conversion, i.e. 5738 /// the most location of the syntactic entity requiring the implicit 5739 /// conversion 5740 void Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 5741 // Don't diagnose in unevaluated contexts. 5742 if (isUnevaluatedContext()) 5743 return; 5744 5745 // Don't diagnose for value- or type-dependent expressions. 5746 if (E->isTypeDependent() || E->isValueDependent()) 5747 return; 5748 5749 // Check for array bounds violations in cases where the check isn't triggered 5750 // elsewhere for other Expr types (like BinaryOperators), e.g. when an 5751 // ArraySubscriptExpr is on the RHS of a variable initialization. 5752 CheckArrayAccess(E); 5753 5754 // This is not the right CC for (e.g.) a variable initialization. 5755 AnalyzeImplicitConversions(*this, E, CC); 5756 } 5757 5758 /// Diagnose when expression is an integer constant expression and its evaluation 5759 /// results in integer overflow 5760 void Sema::CheckForIntOverflow (Expr *E) { 5761 if (isa<BinaryOperator>(E->IgnoreParens())) 5762 E->EvaluateForOverflow(Context); 5763 } 5764 5765 namespace { 5766 /// \brief Visitor for expressions which looks for unsequenced operations on the 5767 /// same object. 5768 class SequenceChecker : public EvaluatedExprVisitor<SequenceChecker> { 5769 typedef EvaluatedExprVisitor<SequenceChecker> Base; 5770 5771 /// \brief A tree of sequenced regions within an expression. Two regions are 5772 /// unsequenced if one is an ancestor or a descendent of the other. When we 5773 /// finish processing an expression with sequencing, such as a comma 5774 /// expression, we fold its tree nodes into its parent, since they are 5775 /// unsequenced with respect to nodes we will visit later. 5776 class SequenceTree { 5777 struct Value { 5778 explicit Value(unsigned Parent) : Parent(Parent), Merged(false) {} 5779 unsigned Parent : 31; 5780 bool Merged : 1; 5781 }; 5782 SmallVector<Value, 8> Values; 5783 5784 public: 5785 /// \brief A region within an expression which may be sequenced with respect 5786 /// to some other region. 5787 class Seq { 5788 explicit Seq(unsigned N) : Index(N) {} 5789 unsigned Index; 5790 friend class SequenceTree; 5791 public: 5792 Seq() : Index(0) {} 5793 }; 5794 5795 SequenceTree() { Values.push_back(Value(0)); } 5796 Seq root() const { return Seq(0); } 5797 5798 /// \brief Create a new sequence of operations, which is an unsequenced 5799 /// subset of \p Parent. This sequence of operations is sequenced with 5800 /// respect to other children of \p Parent. 5801 Seq allocate(Seq Parent) { 5802 Values.push_back(Value(Parent.Index)); 5803 return Seq(Values.size() - 1); 5804 } 5805 5806 /// \brief Merge a sequence of operations into its parent. 5807 void merge(Seq S) { 5808 Values[S.Index].Merged = true; 5809 } 5810 5811 /// \brief Determine whether two operations are unsequenced. This operation 5812 /// is asymmetric: \p Cur should be the more recent sequence, and \p Old 5813 /// should have been merged into its parent as appropriate. 5814 bool isUnsequenced(Seq Cur, Seq Old) { 5815 unsigned C = representative(Cur.Index); 5816 unsigned Target = representative(Old.Index); 5817 while (C >= Target) { 5818 if (C == Target) 5819 return true; 5820 C = Values[C].Parent; 5821 } 5822 return false; 5823 } 5824 5825 private: 5826 /// \brief Pick a representative for a sequence. 5827 unsigned representative(unsigned K) { 5828 if (Values[K].Merged) 5829 // Perform path compression as we go. 5830 return Values[K].Parent = representative(Values[K].Parent); 5831 return K; 5832 } 5833 }; 5834 5835 /// An object for which we can track unsequenced uses. 5836 typedef NamedDecl *Object; 5837 5838 /// Different flavors of object usage which we track. We only track the 5839 /// least-sequenced usage of each kind. 5840 enum UsageKind { 5841 /// A read of an object. Multiple unsequenced reads are OK. 5842 UK_Use, 5843 /// A modification of an object which is sequenced before the value 5844 /// computation of the expression, such as ++n in C++. 5845 UK_ModAsValue, 5846 /// A modification of an object which is not sequenced before the value 5847 /// computation of the expression, such as n++. 5848 UK_ModAsSideEffect, 5849 5850 UK_Count = UK_ModAsSideEffect + 1 5851 }; 5852 5853 struct Usage { 5854 Usage() : Use(0), Seq() {} 5855 Expr *Use; 5856 SequenceTree::Seq Seq; 5857 }; 5858 5859 struct UsageInfo { 5860 UsageInfo() : Diagnosed(false) {} 5861 Usage Uses[UK_Count]; 5862 /// Have we issued a diagnostic for this variable already? 5863 bool Diagnosed; 5864 }; 5865 typedef llvm::SmallDenseMap<Object, UsageInfo, 16> UsageInfoMap; 5866 5867 Sema &SemaRef; 5868 /// Sequenced regions within the expression. 5869 SequenceTree Tree; 5870 /// Declaration modifications and references which we have seen. 5871 UsageInfoMap UsageMap; 5872 /// The region we are currently within. 5873 SequenceTree::Seq Region; 5874 /// Filled in with declarations which were modified as a side-effect 5875 /// (that is, post-increment operations). 5876 SmallVectorImpl<std::pair<Object, Usage> > *ModAsSideEffect; 5877 /// Expressions to check later. We defer checking these to reduce 5878 /// stack usage. 5879 SmallVectorImpl<Expr *> &WorkList; 5880 5881 /// RAII object wrapping the visitation of a sequenced subexpression of an 5882 /// expression. At the end of this process, the side-effects of the evaluation 5883 /// become sequenced with respect to the value computation of the result, so 5884 /// we downgrade any UK_ModAsSideEffect within the evaluation to 5885 /// UK_ModAsValue. 5886 struct SequencedSubexpression { 5887 SequencedSubexpression(SequenceChecker &Self) 5888 : Self(Self), OldModAsSideEffect(Self.ModAsSideEffect) { 5889 Self.ModAsSideEffect = &ModAsSideEffect; 5890 } 5891 ~SequencedSubexpression() { 5892 for (unsigned I = 0, E = ModAsSideEffect.size(); I != E; ++I) { 5893 UsageInfo &U = Self.UsageMap[ModAsSideEffect[I].first]; 5894 U.Uses[UK_ModAsSideEffect] = ModAsSideEffect[I].second; 5895 Self.addUsage(U, ModAsSideEffect[I].first, 5896 ModAsSideEffect[I].second.Use, UK_ModAsValue); 5897 } 5898 Self.ModAsSideEffect = OldModAsSideEffect; 5899 } 5900 5901 SequenceChecker &Self; 5902 SmallVector<std::pair<Object, Usage>, 4> ModAsSideEffect; 5903 SmallVectorImpl<std::pair<Object, Usage> > *OldModAsSideEffect; 5904 }; 5905 5906 /// RAII object wrapping the visitation of a subexpression which we might 5907 /// choose to evaluate as a constant. If any subexpression is evaluated and 5908 /// found to be non-constant, this allows us to suppress the evaluation of 5909 /// the outer expression. 5910 class EvaluationTracker { 5911 public: 5912 EvaluationTracker(SequenceChecker &Self) 5913 : Self(Self), Prev(Self.EvalTracker), EvalOK(true) { 5914 Self.EvalTracker = this; 5915 } 5916 ~EvaluationTracker() { 5917 Self.EvalTracker = Prev; 5918 if (Prev) 5919 Prev->EvalOK &= EvalOK; 5920 } 5921 5922 bool evaluate(const Expr *E, bool &Result) { 5923 if (!EvalOK || E->isValueDependent()) 5924 return false; 5925 EvalOK = E->EvaluateAsBooleanCondition(Result, Self.SemaRef.Context); 5926 return EvalOK; 5927 } 5928 5929 private: 5930 SequenceChecker &Self; 5931 EvaluationTracker *Prev; 5932 bool EvalOK; 5933 } *EvalTracker; 5934 5935 /// \brief Find the object which is produced by the specified expression, 5936 /// if any. 5937 Object getObject(Expr *E, bool Mod) const { 5938 E = E->IgnoreParenCasts(); 5939 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 5940 if (Mod && (UO->getOpcode() == UO_PreInc || UO->getOpcode() == UO_PreDec)) 5941 return getObject(UO->getSubExpr(), Mod); 5942 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 5943 if (BO->getOpcode() == BO_Comma) 5944 return getObject(BO->getRHS(), Mod); 5945 if (Mod && BO->isAssignmentOp()) 5946 return getObject(BO->getLHS(), Mod); 5947 } else if (MemberExpr *ME = dyn_cast<MemberExpr>(E)) { 5948 // FIXME: Check for more interesting cases, like "x.n = ++x.n". 5949 if (isa<CXXThisExpr>(ME->getBase()->IgnoreParenCasts())) 5950 return ME->getMemberDecl(); 5951 } else if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 5952 // FIXME: If this is a reference, map through to its value. 5953 return DRE->getDecl(); 5954 return 0; 5955 } 5956 5957 /// \brief Note that an object was modified or used by an expression. 5958 void addUsage(UsageInfo &UI, Object O, Expr *Ref, UsageKind UK) { 5959 Usage &U = UI.Uses[UK]; 5960 if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) { 5961 if (UK == UK_ModAsSideEffect && ModAsSideEffect) 5962 ModAsSideEffect->push_back(std::make_pair(O, U)); 5963 U.Use = Ref; 5964 U.Seq = Region; 5965 } 5966 } 5967 /// \brief Check whether a modification or use conflicts with a prior usage. 5968 void checkUsage(Object O, UsageInfo &UI, Expr *Ref, UsageKind OtherKind, 5969 bool IsModMod) { 5970 if (UI.Diagnosed) 5971 return; 5972 5973 const Usage &U = UI.Uses[OtherKind]; 5974 if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) 5975 return; 5976 5977 Expr *Mod = U.Use; 5978 Expr *ModOrUse = Ref; 5979 if (OtherKind == UK_Use) 5980 std::swap(Mod, ModOrUse); 5981 5982 SemaRef.Diag(Mod->getExprLoc(), 5983 IsModMod ? diag::warn_unsequenced_mod_mod 5984 : diag::warn_unsequenced_mod_use) 5985 << O << SourceRange(ModOrUse->getExprLoc()); 5986 UI.Diagnosed = true; 5987 } 5988 5989 void notePreUse(Object O, Expr *Use) { 5990 UsageInfo &U = UsageMap[O]; 5991 // Uses conflict with other modifications. 5992 checkUsage(O, U, Use, UK_ModAsValue, false); 5993 } 5994 void notePostUse(Object O, Expr *Use) { 5995 UsageInfo &U = UsageMap[O]; 5996 checkUsage(O, U, Use, UK_ModAsSideEffect, false); 5997 addUsage(U, O, Use, UK_Use); 5998 } 5999 6000 void notePreMod(Object O, Expr *Mod) { 6001 UsageInfo &U = UsageMap[O]; 6002 // Modifications conflict with other modifications and with uses. 6003 checkUsage(O, U, Mod, UK_ModAsValue, true); 6004 checkUsage(O, U, Mod, UK_Use, false); 6005 } 6006 void notePostMod(Object O, Expr *Use, UsageKind UK) { 6007 UsageInfo &U = UsageMap[O]; 6008 checkUsage(O, U, Use, UK_ModAsSideEffect, true); 6009 addUsage(U, O, Use, UK); 6010 } 6011 6012 public: 6013 SequenceChecker(Sema &S, Expr *E, SmallVectorImpl<Expr *> &WorkList) 6014 : Base(S.Context), SemaRef(S), Region(Tree.root()), ModAsSideEffect(0), 6015 WorkList(WorkList), EvalTracker(0) { 6016 Visit(E); 6017 } 6018 6019 void VisitStmt(Stmt *S) { 6020 // Skip all statements which aren't expressions for now. 6021 } 6022 6023 void VisitExpr(Expr *E) { 6024 // By default, just recurse to evaluated subexpressions. 6025 Base::VisitStmt(E); 6026 } 6027 6028 void VisitCastExpr(CastExpr *E) { 6029 Object O = Object(); 6030 if (E->getCastKind() == CK_LValueToRValue) 6031 O = getObject(E->getSubExpr(), false); 6032 6033 if (O) 6034 notePreUse(O, E); 6035 VisitExpr(E); 6036 if (O) 6037 notePostUse(O, E); 6038 } 6039 6040 void VisitBinComma(BinaryOperator *BO) { 6041 // C++11 [expr.comma]p1: 6042 // Every value computation and side effect associated with the left 6043 // expression is sequenced before every value computation and side 6044 // effect associated with the right expression. 6045 SequenceTree::Seq LHS = Tree.allocate(Region); 6046 SequenceTree::Seq RHS = Tree.allocate(Region); 6047 SequenceTree::Seq OldRegion = Region; 6048 6049 { 6050 SequencedSubexpression SeqLHS(*this); 6051 Region = LHS; 6052 Visit(BO->getLHS()); 6053 } 6054 6055 Region = RHS; 6056 Visit(BO->getRHS()); 6057 6058 Region = OldRegion; 6059 6060 // Forget that LHS and RHS are sequenced. They are both unsequenced 6061 // with respect to other stuff. 6062 Tree.merge(LHS); 6063 Tree.merge(RHS); 6064 } 6065 6066 void VisitBinAssign(BinaryOperator *BO) { 6067 // The modification is sequenced after the value computation of the LHS 6068 // and RHS, so check it before inspecting the operands and update the 6069 // map afterwards. 6070 Object O = getObject(BO->getLHS(), true); 6071 if (!O) 6072 return VisitExpr(BO); 6073 6074 notePreMod(O, BO); 6075 6076 // C++11 [expr.ass]p7: 6077 // E1 op= E2 is equivalent to E1 = E1 op E2, except that E1 is evaluated 6078 // only once. 6079 // 6080 // Therefore, for a compound assignment operator, O is considered used 6081 // everywhere except within the evaluation of E1 itself. 6082 if (isa<CompoundAssignOperator>(BO)) 6083 notePreUse(O, BO); 6084 6085 Visit(BO->getLHS()); 6086 6087 if (isa<CompoundAssignOperator>(BO)) 6088 notePostUse(O, BO); 6089 6090 Visit(BO->getRHS()); 6091 6092 // C++11 [expr.ass]p1: 6093 // the assignment is sequenced [...] before the value computation of the 6094 // assignment expression. 6095 // C11 6.5.16/3 has no such rule. 6096 notePostMod(O, BO, SemaRef.getLangOpts().CPlusPlus ? UK_ModAsValue 6097 : UK_ModAsSideEffect); 6098 } 6099 void VisitCompoundAssignOperator(CompoundAssignOperator *CAO) { 6100 VisitBinAssign(CAO); 6101 } 6102 6103 void VisitUnaryPreInc(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); } 6104 void VisitUnaryPreDec(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); } 6105 void VisitUnaryPreIncDec(UnaryOperator *UO) { 6106 Object O = getObject(UO->getSubExpr(), true); 6107 if (!O) 6108 return VisitExpr(UO); 6109 6110 notePreMod(O, UO); 6111 Visit(UO->getSubExpr()); 6112 // C++11 [expr.pre.incr]p1: 6113 // the expression ++x is equivalent to x+=1 6114 notePostMod(O, UO, SemaRef.getLangOpts().CPlusPlus ? UK_ModAsValue 6115 : UK_ModAsSideEffect); 6116 } 6117 6118 void VisitUnaryPostInc(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); } 6119 void VisitUnaryPostDec(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); } 6120 void VisitUnaryPostIncDec(UnaryOperator *UO) { 6121 Object O = getObject(UO->getSubExpr(), true); 6122 if (!O) 6123 return VisitExpr(UO); 6124 6125 notePreMod(O, UO); 6126 Visit(UO->getSubExpr()); 6127 notePostMod(O, UO, UK_ModAsSideEffect); 6128 } 6129 6130 /// Don't visit the RHS of '&&' or '||' if it might not be evaluated. 6131 void VisitBinLOr(BinaryOperator *BO) { 6132 // The side-effects of the LHS of an '&&' are sequenced before the 6133 // value computation of the RHS, and hence before the value computation 6134 // of the '&&' itself, unless the LHS evaluates to zero. We treat them 6135 // as if they were unconditionally sequenced. 6136 EvaluationTracker Eval(*this); 6137 { 6138 SequencedSubexpression Sequenced(*this); 6139 Visit(BO->getLHS()); 6140 } 6141 6142 bool Result; 6143 if (Eval.evaluate(BO->getLHS(), Result)) { 6144 if (!Result) 6145 Visit(BO->getRHS()); 6146 } else { 6147 // Check for unsequenced operations in the RHS, treating it as an 6148 // entirely separate evaluation. 6149 // 6150 // FIXME: If there are operations in the RHS which are unsequenced 6151 // with respect to operations outside the RHS, and those operations 6152 // are unconditionally evaluated, diagnose them. 6153 WorkList.push_back(BO->getRHS()); 6154 } 6155 } 6156 void VisitBinLAnd(BinaryOperator *BO) { 6157 EvaluationTracker Eval(*this); 6158 { 6159 SequencedSubexpression Sequenced(*this); 6160 Visit(BO->getLHS()); 6161 } 6162 6163 bool Result; 6164 if (Eval.evaluate(BO->getLHS(), Result)) { 6165 if (Result) 6166 Visit(BO->getRHS()); 6167 } else { 6168 WorkList.push_back(BO->getRHS()); 6169 } 6170 } 6171 6172 // Only visit the condition, unless we can be sure which subexpression will 6173 // be chosen. 6174 void VisitAbstractConditionalOperator(AbstractConditionalOperator *CO) { 6175 EvaluationTracker Eval(*this); 6176 { 6177 SequencedSubexpression Sequenced(*this); 6178 Visit(CO->getCond()); 6179 } 6180 6181 bool Result; 6182 if (Eval.evaluate(CO->getCond(), Result)) 6183 Visit(Result ? CO->getTrueExpr() : CO->getFalseExpr()); 6184 else { 6185 WorkList.push_back(CO->getTrueExpr()); 6186 WorkList.push_back(CO->getFalseExpr()); 6187 } 6188 } 6189 6190 void VisitCallExpr(CallExpr *CE) { 6191 // C++11 [intro.execution]p15: 6192 // When calling a function [...], every value computation and side effect 6193 // associated with any argument expression, or with the postfix expression 6194 // designating the called function, is sequenced before execution of every 6195 // expression or statement in the body of the function [and thus before 6196 // the value computation of its result]. 6197 SequencedSubexpression Sequenced(*this); 6198 Base::VisitCallExpr(CE); 6199 6200 // FIXME: CXXNewExpr and CXXDeleteExpr implicitly call functions. 6201 } 6202 6203 void VisitCXXConstructExpr(CXXConstructExpr *CCE) { 6204 // This is a call, so all subexpressions are sequenced before the result. 6205 SequencedSubexpression Sequenced(*this); 6206 6207 if (!CCE->isListInitialization()) 6208 return VisitExpr(CCE); 6209 6210 // In C++11, list initializations are sequenced. 6211 SmallVector<SequenceTree::Seq, 32> Elts; 6212 SequenceTree::Seq Parent = Region; 6213 for (CXXConstructExpr::arg_iterator I = CCE->arg_begin(), 6214 E = CCE->arg_end(); 6215 I != E; ++I) { 6216 Region = Tree.allocate(Parent); 6217 Elts.push_back(Region); 6218 Visit(*I); 6219 } 6220 6221 // Forget that the initializers are sequenced. 6222 Region = Parent; 6223 for (unsigned I = 0; I < Elts.size(); ++I) 6224 Tree.merge(Elts[I]); 6225 } 6226 6227 void VisitInitListExpr(InitListExpr *ILE) { 6228 if (!SemaRef.getLangOpts().CPlusPlus11) 6229 return VisitExpr(ILE); 6230 6231 // In C++11, list initializations are sequenced. 6232 SmallVector<SequenceTree::Seq, 32> Elts; 6233 SequenceTree::Seq Parent = Region; 6234 for (unsigned I = 0; I < ILE->getNumInits(); ++I) { 6235 Expr *E = ILE->getInit(I); 6236 if (!E) continue; 6237 Region = Tree.allocate(Parent); 6238 Elts.push_back(Region); 6239 Visit(E); 6240 } 6241 6242 // Forget that the initializers are sequenced. 6243 Region = Parent; 6244 for (unsigned I = 0; I < Elts.size(); ++I) 6245 Tree.merge(Elts[I]); 6246 } 6247 }; 6248 } 6249 6250 void Sema::CheckUnsequencedOperations(Expr *E) { 6251 SmallVector<Expr *, 8> WorkList; 6252 WorkList.push_back(E); 6253 while (!WorkList.empty()) { 6254 Expr *Item = WorkList.pop_back_val(); 6255 SequenceChecker(*this, Item, WorkList); 6256 } 6257 } 6258 6259 void Sema::CheckCompletedExpr(Expr *E, SourceLocation CheckLoc, 6260 bool IsConstexpr) { 6261 CheckImplicitConversions(E, CheckLoc); 6262 CheckUnsequencedOperations(E); 6263 if (!IsConstexpr && !E->isValueDependent()) 6264 CheckForIntOverflow(E); 6265 } 6266 6267 void Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 6268 FieldDecl *BitField, 6269 Expr *Init) { 6270 (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 6271 } 6272 6273 /// CheckParmsForFunctionDef - Check that the parameters of the given 6274 /// function are appropriate for the definition of a function. This 6275 /// takes care of any checks that cannot be performed on the 6276 /// declaration itself, e.g., that the types of each of the function 6277 /// parameters are complete. 6278 bool Sema::CheckParmsForFunctionDef(ParmVarDecl *const *P, 6279 ParmVarDecl *const *PEnd, 6280 bool CheckParameterNames) { 6281 bool HasInvalidParm = false; 6282 for (; P != PEnd; ++P) { 6283 ParmVarDecl *Param = *P; 6284 6285 // C99 6.7.5.3p4: the parameters in a parameter type list in a 6286 // function declarator that is part of a function definition of 6287 // that function shall not have incomplete type. 6288 // 6289 // This is also C++ [dcl.fct]p6. 6290 if (!Param->isInvalidDecl() && 6291 RequireCompleteType(Param->getLocation(), Param->getType(), 6292 diag::err_typecheck_decl_incomplete_type)) { 6293 Param->setInvalidDecl(); 6294 HasInvalidParm = true; 6295 } 6296 6297 // C99 6.9.1p5: If the declarator includes a parameter type list, the 6298 // declaration of each parameter shall include an identifier. 6299 if (CheckParameterNames && 6300 Param->getIdentifier() == 0 && 6301 !Param->isImplicit() && 6302 !getLangOpts().CPlusPlus) 6303 Diag(Param->getLocation(), diag::err_parameter_name_omitted); 6304 6305 // C99 6.7.5.3p12: 6306 // If the function declarator is not part of a definition of that 6307 // function, parameters may have incomplete type and may use the [*] 6308 // notation in their sequences of declarator specifiers to specify 6309 // variable length array types. 6310 QualType PType = Param->getOriginalType(); 6311 while (const ArrayType *AT = Context.getAsArrayType(PType)) { 6312 if (AT->getSizeModifier() == ArrayType::Star) { 6313 // FIXME: This diagnostic should point the '[*]' if source-location 6314 // information is added for it. 6315 Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 6316 break; 6317 } 6318 PType= AT->getElementType(); 6319 } 6320 6321 // MSVC destroys objects passed by value in the callee. Therefore a 6322 // function definition which takes such a parameter must be able to call the 6323 // object's destructor. However, we don't perform any direct access check 6324 // on the dtor. 6325 if (getLangOpts().CPlusPlus && Context.getTargetInfo() 6326 .getCXXABI() 6327 .areArgsDestroyedLeftToRightInCallee()) { 6328 if (!Param->isInvalidDecl()) { 6329 if (const RecordType *RT = Param->getType()->getAs<RecordType>()) { 6330 CXXRecordDecl *ClassDecl = cast<CXXRecordDecl>(RT->getDecl()); 6331 if (!ClassDecl->isInvalidDecl() && 6332 !ClassDecl->hasIrrelevantDestructor() && 6333 !ClassDecl->isDependentContext()) { 6334 CXXDestructorDecl *Destructor = LookupDestructor(ClassDecl); 6335 MarkFunctionReferenced(Param->getLocation(), Destructor); 6336 DiagnoseUseOfDecl(Destructor, Param->getLocation()); 6337 } 6338 } 6339 } 6340 } 6341 } 6342 6343 return HasInvalidParm; 6344 } 6345 6346 /// CheckCastAlign - Implements -Wcast-align, which warns when a 6347 /// pointer cast increases the alignment requirements. 6348 void Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 6349 // This is actually a lot of work to potentially be doing on every 6350 // cast; don't do it if we're ignoring -Wcast_align (as is the default). 6351 if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 6352 TRange.getBegin()) 6353 == DiagnosticsEngine::Ignored) 6354 return; 6355 6356 // Ignore dependent types. 6357 if (T->isDependentType() || Op->getType()->isDependentType()) 6358 return; 6359 6360 // Require that the destination be a pointer type. 6361 const PointerType *DestPtr = T->getAs<PointerType>(); 6362 if (!DestPtr) return; 6363 6364 // If the destination has alignment 1, we're done. 6365 QualType DestPointee = DestPtr->getPointeeType(); 6366 if (DestPointee->isIncompleteType()) return; 6367 CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 6368 if (DestAlign.isOne()) return; 6369 6370 // Require that the source be a pointer type. 6371 const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 6372 if (!SrcPtr) return; 6373 QualType SrcPointee = SrcPtr->getPointeeType(); 6374 6375 // Whitelist casts from cv void*. We already implicitly 6376 // whitelisted casts to cv void*, since they have alignment 1. 6377 // Also whitelist casts involving incomplete types, which implicitly 6378 // includes 'void'. 6379 if (SrcPointee->isIncompleteType()) return; 6380 6381 CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 6382 if (SrcAlign >= DestAlign) return; 6383 6384 Diag(TRange.getBegin(), diag::warn_cast_align) 6385 << Op->getType() << T 6386 << static_cast<unsigned>(SrcAlign.getQuantity()) 6387 << static_cast<unsigned>(DestAlign.getQuantity()) 6388 << TRange << Op->getSourceRange(); 6389 } 6390 6391 static const Type* getElementType(const Expr *BaseExpr) { 6392 const Type* EltType = BaseExpr->getType().getTypePtr(); 6393 if (EltType->isAnyPointerType()) 6394 return EltType->getPointeeType().getTypePtr(); 6395 else if (EltType->isArrayType()) 6396 return EltType->getBaseElementTypeUnsafe(); 6397 return EltType; 6398 } 6399 6400 /// \brief Check whether this array fits the idiom of a size-one tail padded 6401 /// array member of a struct. 6402 /// 6403 /// We avoid emitting out-of-bounds access warnings for such arrays as they are 6404 /// commonly used to emulate flexible arrays in C89 code. 6405 static bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size, 6406 const NamedDecl *ND) { 6407 if (Size != 1 || !ND) return false; 6408 6409 const FieldDecl *FD = dyn_cast<FieldDecl>(ND); 6410 if (!FD) return false; 6411 6412 // Don't consider sizes resulting from macro expansions or template argument 6413 // substitution to form C89 tail-padded arrays. 6414 6415 TypeSourceInfo *TInfo = FD->getTypeSourceInfo(); 6416 while (TInfo) { 6417 TypeLoc TL = TInfo->getTypeLoc(); 6418 // Look through typedefs. 6419 if (TypedefTypeLoc TTL = TL.getAs<TypedefTypeLoc>()) { 6420 const TypedefNameDecl *TDL = TTL.getTypedefNameDecl(); 6421 TInfo = TDL->getTypeSourceInfo(); 6422 continue; 6423 } 6424 if (ConstantArrayTypeLoc CTL = TL.getAs<ConstantArrayTypeLoc>()) { 6425 const Expr *SizeExpr = dyn_cast<IntegerLiteral>(CTL.getSizeExpr()); 6426 if (!SizeExpr || SizeExpr->getExprLoc().isMacroID()) 6427 return false; 6428 } 6429 break; 6430 } 6431 6432 const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext()); 6433 if (!RD) return false; 6434 if (RD->isUnion()) return false; 6435 if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) { 6436 if (!CRD->isStandardLayout()) return false; 6437 } 6438 6439 // See if this is the last field decl in the record. 6440 const Decl *D = FD; 6441 while ((D = D->getNextDeclInContext())) 6442 if (isa<FieldDecl>(D)) 6443 return false; 6444 return true; 6445 } 6446 6447 void Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr, 6448 const ArraySubscriptExpr *ASE, 6449 bool AllowOnePastEnd, bool IndexNegated) { 6450 IndexExpr = IndexExpr->IgnoreParenImpCasts(); 6451 if (IndexExpr->isValueDependent()) 6452 return; 6453 6454 const Type *EffectiveType = getElementType(BaseExpr); 6455 BaseExpr = BaseExpr->IgnoreParenCasts(); 6456 const ConstantArrayType *ArrayTy = 6457 Context.getAsConstantArrayType(BaseExpr->getType()); 6458 if (!ArrayTy) 6459 return; 6460 6461 llvm::APSInt index; 6462 if (!IndexExpr->EvaluateAsInt(index, Context)) 6463 return; 6464 if (IndexNegated) 6465 index = -index; 6466 6467 const NamedDecl *ND = NULL; 6468 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 6469 ND = dyn_cast<NamedDecl>(DRE->getDecl()); 6470 if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 6471 ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 6472 6473 if (index.isUnsigned() || !index.isNegative()) { 6474 llvm::APInt size = ArrayTy->getSize(); 6475 if (!size.isStrictlyPositive()) 6476 return; 6477 6478 const Type* BaseType = getElementType(BaseExpr); 6479 if (BaseType != EffectiveType) { 6480 // Make sure we're comparing apples to apples when comparing index to size 6481 uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType); 6482 uint64_t array_typesize = Context.getTypeSize(BaseType); 6483 // Handle ptrarith_typesize being zero, such as when casting to void* 6484 if (!ptrarith_typesize) ptrarith_typesize = 1; 6485 if (ptrarith_typesize != array_typesize) { 6486 // There's a cast to a different size type involved 6487 uint64_t ratio = array_typesize / ptrarith_typesize; 6488 // TODO: Be smarter about handling cases where array_typesize is not a 6489 // multiple of ptrarith_typesize 6490 if (ptrarith_typesize * ratio == array_typesize) 6491 size *= llvm::APInt(size.getBitWidth(), ratio); 6492 } 6493 } 6494 6495 if (size.getBitWidth() > index.getBitWidth()) 6496 index = index.zext(size.getBitWidth()); 6497 else if (size.getBitWidth() < index.getBitWidth()) 6498 size = size.zext(index.getBitWidth()); 6499 6500 // For array subscripting the index must be less than size, but for pointer 6501 // arithmetic also allow the index (offset) to be equal to size since 6502 // computing the next address after the end of the array is legal and 6503 // commonly done e.g. in C++ iterators and range-based for loops. 6504 if (AllowOnePastEnd ? index.ule(size) : index.ult(size)) 6505 return; 6506 6507 // Also don't warn for arrays of size 1 which are members of some 6508 // structure. These are often used to approximate flexible arrays in C89 6509 // code. 6510 if (IsTailPaddedMemberArray(*this, size, ND)) 6511 return; 6512 6513 // Suppress the warning if the subscript expression (as identified by the 6514 // ']' location) and the index expression are both from macro expansions 6515 // within a system header. 6516 if (ASE) { 6517 SourceLocation RBracketLoc = SourceMgr.getSpellingLoc( 6518 ASE->getRBracketLoc()); 6519 if (SourceMgr.isInSystemHeader(RBracketLoc)) { 6520 SourceLocation IndexLoc = SourceMgr.getSpellingLoc( 6521 IndexExpr->getLocStart()); 6522 if (SourceMgr.isWrittenInSameFile(RBracketLoc, IndexLoc)) 6523 return; 6524 } 6525 } 6526 6527 unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds; 6528 if (ASE) 6529 DiagID = diag::warn_array_index_exceeds_bounds; 6530 6531 DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 6532 PDiag(DiagID) << index.toString(10, true) 6533 << size.toString(10, true) 6534 << (unsigned)size.getLimitedValue(~0U) 6535 << IndexExpr->getSourceRange()); 6536 } else { 6537 unsigned DiagID = diag::warn_array_index_precedes_bounds; 6538 if (!ASE) { 6539 DiagID = diag::warn_ptr_arith_precedes_bounds; 6540 if (index.isNegative()) index = -index; 6541 } 6542 6543 DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 6544 PDiag(DiagID) << index.toString(10, true) 6545 << IndexExpr->getSourceRange()); 6546 } 6547 6548 if (!ND) { 6549 // Try harder to find a NamedDecl to point at in the note. 6550 while (const ArraySubscriptExpr *ASE = 6551 dyn_cast<ArraySubscriptExpr>(BaseExpr)) 6552 BaseExpr = ASE->getBase()->IgnoreParenCasts(); 6553 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 6554 ND = dyn_cast<NamedDecl>(DRE->getDecl()); 6555 if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 6556 ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 6557 } 6558 6559 if (ND) 6560 DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 6561 PDiag(diag::note_array_index_out_of_bounds) 6562 << ND->getDeclName()); 6563 } 6564 6565 void Sema::CheckArrayAccess(const Expr *expr) { 6566 int AllowOnePastEnd = 0; 6567 while (expr) { 6568 expr = expr->IgnoreParenImpCasts(); 6569 switch (expr->getStmtClass()) { 6570 case Stmt::ArraySubscriptExprClass: { 6571 const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr); 6572 CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE, 6573 AllowOnePastEnd > 0); 6574 return; 6575 } 6576 case Stmt::UnaryOperatorClass: { 6577 // Only unwrap the * and & unary operators 6578 const UnaryOperator *UO = cast<UnaryOperator>(expr); 6579 expr = UO->getSubExpr(); 6580 switch (UO->getOpcode()) { 6581 case UO_AddrOf: 6582 AllowOnePastEnd++; 6583 break; 6584 case UO_Deref: 6585 AllowOnePastEnd--; 6586 break; 6587 default: 6588 return; 6589 } 6590 break; 6591 } 6592 case Stmt::ConditionalOperatorClass: { 6593 const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 6594 if (const Expr *lhs = cond->getLHS()) 6595 CheckArrayAccess(lhs); 6596 if (const Expr *rhs = cond->getRHS()) 6597 CheckArrayAccess(rhs); 6598 return; 6599 } 6600 default: 6601 return; 6602 } 6603 } 6604 } 6605 6606 //===--- CHECK: Objective-C retain cycles ----------------------------------// 6607 6608 namespace { 6609 struct RetainCycleOwner { 6610 RetainCycleOwner() : Variable(0), Indirect(false) {} 6611 VarDecl *Variable; 6612 SourceRange Range; 6613 SourceLocation Loc; 6614 bool Indirect; 6615 6616 void setLocsFrom(Expr *e) { 6617 Loc = e->getExprLoc(); 6618 Range = e->getSourceRange(); 6619 } 6620 }; 6621 } 6622 6623 /// Consider whether capturing the given variable can possibly lead to 6624 /// a retain cycle. 6625 static bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) { 6626 // In ARC, it's captured strongly iff the variable has __strong 6627 // lifetime. In MRR, it's captured strongly if the variable is 6628 // __block and has an appropriate type. 6629 if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 6630 return false; 6631 6632 owner.Variable = var; 6633 if (ref) 6634 owner.setLocsFrom(ref); 6635 return true; 6636 } 6637 6638 static bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) { 6639 while (true) { 6640 e = e->IgnoreParens(); 6641 if (CastExpr *cast = dyn_cast<CastExpr>(e)) { 6642 switch (cast->getCastKind()) { 6643 case CK_BitCast: 6644 case CK_LValueBitCast: 6645 case CK_LValueToRValue: 6646 case CK_ARCReclaimReturnedObject: 6647 e = cast->getSubExpr(); 6648 continue; 6649 6650 default: 6651 return false; 6652 } 6653 } 6654 6655 if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) { 6656 ObjCIvarDecl *ivar = ref->getDecl(); 6657 if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 6658 return false; 6659 6660 // Try to find a retain cycle in the base. 6661 if (!findRetainCycleOwner(S, ref->getBase(), owner)) 6662 return false; 6663 6664 if (ref->isFreeIvar()) owner.setLocsFrom(ref); 6665 owner.Indirect = true; 6666 return true; 6667 } 6668 6669 if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) { 6670 VarDecl *var = dyn_cast<VarDecl>(ref->getDecl()); 6671 if (!var) return false; 6672 return considerVariable(var, ref, owner); 6673 } 6674 6675 if (MemberExpr *member = dyn_cast<MemberExpr>(e)) { 6676 if (member->isArrow()) return false; 6677 6678 // Don't count this as an indirect ownership. 6679 e = member->getBase(); 6680 continue; 6681 } 6682 6683 if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) { 6684 // Only pay attention to pseudo-objects on property references. 6685 ObjCPropertyRefExpr *pre 6686 = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm() 6687 ->IgnoreParens()); 6688 if (!pre) return false; 6689 if (pre->isImplicitProperty()) return false; 6690 ObjCPropertyDecl *property = pre->getExplicitProperty(); 6691 if (!property->isRetaining() && 6692 !(property->getPropertyIvarDecl() && 6693 property->getPropertyIvarDecl()->getType() 6694 .getObjCLifetime() == Qualifiers::OCL_Strong)) 6695 return false; 6696 6697 owner.Indirect = true; 6698 if (pre->isSuperReceiver()) { 6699 owner.Variable = S.getCurMethodDecl()->getSelfDecl(); 6700 if (!owner.Variable) 6701 return false; 6702 owner.Loc = pre->getLocation(); 6703 owner.Range = pre->getSourceRange(); 6704 return true; 6705 } 6706 e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase()) 6707 ->getSourceExpr()); 6708 continue; 6709 } 6710 6711 // Array ivars? 6712 6713 return false; 6714 } 6715 } 6716 6717 namespace { 6718 struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> { 6719 FindCaptureVisitor(ASTContext &Context, VarDecl *variable) 6720 : EvaluatedExprVisitor<FindCaptureVisitor>(Context), 6721 Variable(variable), Capturer(0) {} 6722 6723 VarDecl *Variable; 6724 Expr *Capturer; 6725 6726 void VisitDeclRefExpr(DeclRefExpr *ref) { 6727 if (ref->getDecl() == Variable && !Capturer) 6728 Capturer = ref; 6729 } 6730 6731 void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) { 6732 if (Capturer) return; 6733 Visit(ref->getBase()); 6734 if (Capturer && ref->isFreeIvar()) 6735 Capturer = ref; 6736 } 6737 6738 void VisitBlockExpr(BlockExpr *block) { 6739 // Look inside nested blocks 6740 if (block->getBlockDecl()->capturesVariable(Variable)) 6741 Visit(block->getBlockDecl()->getBody()); 6742 } 6743 6744 void VisitOpaqueValueExpr(OpaqueValueExpr *OVE) { 6745 if (Capturer) return; 6746 if (OVE->getSourceExpr()) 6747 Visit(OVE->getSourceExpr()); 6748 } 6749 }; 6750 } 6751 6752 /// Check whether the given argument is a block which captures a 6753 /// variable. 6754 static Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) { 6755 assert(owner.Variable && owner.Loc.isValid()); 6756 6757 e = e->IgnoreParenCasts(); 6758 6759 // Look through [^{...} copy] and Block_copy(^{...}). 6760 if (ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(e)) { 6761 Selector Cmd = ME->getSelector(); 6762 if (Cmd.isUnarySelector() && Cmd.getNameForSlot(0) == "copy") { 6763 e = ME->getInstanceReceiver(); 6764 if (!e) 6765 return 0; 6766 e = e->IgnoreParenCasts(); 6767 } 6768 } else if (CallExpr *CE = dyn_cast<CallExpr>(e)) { 6769 if (CE->getNumArgs() == 1) { 6770 FunctionDecl *Fn = dyn_cast_or_null<FunctionDecl>(CE->getCalleeDecl()); 6771 if (Fn) { 6772 const IdentifierInfo *FnI = Fn->getIdentifier(); 6773 if (FnI && FnI->isStr("_Block_copy")) { 6774 e = CE->getArg(0)->IgnoreParenCasts(); 6775 } 6776 } 6777 } 6778 } 6779 6780 BlockExpr *block = dyn_cast<BlockExpr>(e); 6781 if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable)) 6782 return 0; 6783 6784 FindCaptureVisitor visitor(S.Context, owner.Variable); 6785 visitor.Visit(block->getBlockDecl()->getBody()); 6786 return visitor.Capturer; 6787 } 6788 6789 static void diagnoseRetainCycle(Sema &S, Expr *capturer, 6790 RetainCycleOwner &owner) { 6791 assert(capturer); 6792 assert(owner.Variable && owner.Loc.isValid()); 6793 6794 S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle) 6795 << owner.Variable << capturer->getSourceRange(); 6796 S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner) 6797 << owner.Indirect << owner.Range; 6798 } 6799 6800 /// Check for a keyword selector that starts with the word 'add' or 6801 /// 'set'. 6802 static bool isSetterLikeSelector(Selector sel) { 6803 if (sel.isUnarySelector()) return false; 6804 6805 StringRef str = sel.getNameForSlot(0); 6806 while (!str.empty() && str.front() == '_') str = str.substr(1); 6807 if (str.startswith("set")) 6808 str = str.substr(3); 6809 else if (str.startswith("add")) { 6810 // Specially whitelist 'addOperationWithBlock:'. 6811 if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock")) 6812 return false; 6813 str = str.substr(3); 6814 } 6815 else 6816 return false; 6817 6818 if (str.empty()) return true; 6819 return !isLowercase(str.front()); 6820 } 6821 6822 /// Check a message send to see if it's likely to cause a retain cycle. 6823 void Sema::checkRetainCycles(ObjCMessageExpr *msg) { 6824 // Only check instance methods whose selector looks like a setter. 6825 if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector())) 6826 return; 6827 6828 // Try to find a variable that the receiver is strongly owned by. 6829 RetainCycleOwner owner; 6830 if (msg->getReceiverKind() == ObjCMessageExpr::Instance) { 6831 if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner)) 6832 return; 6833 } else { 6834 assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance); 6835 owner.Variable = getCurMethodDecl()->getSelfDecl(); 6836 owner.Loc = msg->getSuperLoc(); 6837 owner.Range = msg->getSuperLoc(); 6838 } 6839 6840 // Check whether the receiver is captured by any of the arguments. 6841 for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i) 6842 if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) 6843 return diagnoseRetainCycle(*this, capturer, owner); 6844 } 6845 6846 /// Check a property assign to see if it's likely to cause a retain cycle. 6847 void Sema::checkRetainCycles(Expr *receiver, Expr *argument) { 6848 RetainCycleOwner owner; 6849 if (!findRetainCycleOwner(*this, receiver, owner)) 6850 return; 6851 6852 if (Expr *capturer = findCapturingExpr(*this, argument, owner)) 6853 diagnoseRetainCycle(*this, capturer, owner); 6854 } 6855 6856 void Sema::checkRetainCycles(VarDecl *Var, Expr *Init) { 6857 RetainCycleOwner Owner; 6858 if (!considerVariable(Var, /*DeclRefExpr=*/0, Owner)) 6859 return; 6860 6861 // Because we don't have an expression for the variable, we have to set the 6862 // location explicitly here. 6863 Owner.Loc = Var->getLocation(); 6864 Owner.Range = Var->getSourceRange(); 6865 6866 if (Expr *Capturer = findCapturingExpr(*this, Init, Owner)) 6867 diagnoseRetainCycle(*this, Capturer, Owner); 6868 } 6869 6870 static bool checkUnsafeAssignLiteral(Sema &S, SourceLocation Loc, 6871 Expr *RHS, bool isProperty) { 6872 // Check if RHS is an Objective-C object literal, which also can get 6873 // immediately zapped in a weak reference. Note that we explicitly 6874 // allow ObjCStringLiterals, since those are designed to never really die. 6875 RHS = RHS->IgnoreParenImpCasts(); 6876 6877 // This enum needs to match with the 'select' in 6878 // warn_objc_arc_literal_assign (off-by-1). 6879 Sema::ObjCLiteralKind Kind = S.CheckLiteralKind(RHS); 6880 if (Kind == Sema::LK_String || Kind == Sema::LK_None) 6881 return false; 6882 6883 S.Diag(Loc, diag::warn_arc_literal_assign) 6884 << (unsigned) Kind 6885 << (isProperty ? 0 : 1) 6886 << RHS->getSourceRange(); 6887 6888 return true; 6889 } 6890 6891 static bool checkUnsafeAssignObject(Sema &S, SourceLocation Loc, 6892 Qualifiers::ObjCLifetime LT, 6893 Expr *RHS, bool isProperty) { 6894 // Strip off any implicit cast added to get to the one ARC-specific. 6895 while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 6896 if (cast->getCastKind() == CK_ARCConsumeObject) { 6897 S.Diag(Loc, diag::warn_arc_retained_assign) 6898 << (LT == Qualifiers::OCL_ExplicitNone) 6899 << (isProperty ? 0 : 1) 6900 << RHS->getSourceRange(); 6901 return true; 6902 } 6903 RHS = cast->getSubExpr(); 6904 } 6905 6906 if (LT == Qualifiers::OCL_Weak && 6907 checkUnsafeAssignLiteral(S, Loc, RHS, isProperty)) 6908 return true; 6909 6910 return false; 6911 } 6912 6913 bool Sema::checkUnsafeAssigns(SourceLocation Loc, 6914 QualType LHS, Expr *RHS) { 6915 Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime(); 6916 6917 if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone) 6918 return false; 6919 6920 if (checkUnsafeAssignObject(*this, Loc, LT, RHS, false)) 6921 return true; 6922 6923 return false; 6924 } 6925 6926 void Sema::checkUnsafeExprAssigns(SourceLocation Loc, 6927 Expr *LHS, Expr *RHS) { 6928 QualType LHSType; 6929 // PropertyRef on LHS type need be directly obtained from 6930 // its declaration as it has a PseudoType. 6931 ObjCPropertyRefExpr *PRE 6932 = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens()); 6933 if (PRE && !PRE->isImplicitProperty()) { 6934 const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 6935 if (PD) 6936 LHSType = PD->getType(); 6937 } 6938 6939 if (LHSType.isNull()) 6940 LHSType = LHS->getType(); 6941 6942 Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime(); 6943 6944 if (LT == Qualifiers::OCL_Weak) { 6945 DiagnosticsEngine::Level Level = 6946 Diags.getDiagnosticLevel(diag::warn_arc_repeated_use_of_weak, Loc); 6947 if (Level != DiagnosticsEngine::Ignored) 6948 getCurFunction()->markSafeWeakUse(LHS); 6949 } 6950 6951 if (checkUnsafeAssigns(Loc, LHSType, RHS)) 6952 return; 6953 6954 // FIXME. Check for other life times. 6955 if (LT != Qualifiers::OCL_None) 6956 return; 6957 6958 if (PRE) { 6959 if (PRE->isImplicitProperty()) 6960 return; 6961 const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 6962 if (!PD) 6963 return; 6964 6965 unsigned Attributes = PD->getPropertyAttributes(); 6966 if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) { 6967 // when 'assign' attribute was not explicitly specified 6968 // by user, ignore it and rely on property type itself 6969 // for lifetime info. 6970 unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten(); 6971 if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) && 6972 LHSType->isObjCRetainableType()) 6973 return; 6974 6975 while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 6976 if (cast->getCastKind() == CK_ARCConsumeObject) { 6977 Diag(Loc, diag::warn_arc_retained_property_assign) 6978 << RHS->getSourceRange(); 6979 return; 6980 } 6981 RHS = cast->getSubExpr(); 6982 } 6983 } 6984 else if (Attributes & ObjCPropertyDecl::OBJC_PR_weak) { 6985 if (checkUnsafeAssignObject(*this, Loc, Qualifiers::OCL_Weak, RHS, true)) 6986 return; 6987 } 6988 } 6989 } 6990 6991 //===--- CHECK: Empty statement body (-Wempty-body) ---------------------===// 6992 6993 namespace { 6994 bool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr, 6995 SourceLocation StmtLoc, 6996 const NullStmt *Body) { 6997 // Do not warn if the body is a macro that expands to nothing, e.g: 6998 // 6999 // #define CALL(x) 7000 // if (condition) 7001 // CALL(0); 7002 // 7003 if (Body->hasLeadingEmptyMacro()) 7004 return false; 7005 7006 // Get line numbers of statement and body. 7007 bool StmtLineInvalid; 7008 unsigned StmtLine = SourceMgr.getSpellingLineNumber(StmtLoc, 7009 &StmtLineInvalid); 7010 if (StmtLineInvalid) 7011 return false; 7012 7013 bool BodyLineInvalid; 7014 unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(), 7015 &BodyLineInvalid); 7016 if (BodyLineInvalid) 7017 return false; 7018 7019 // Warn if null statement and body are on the same line. 7020 if (StmtLine != BodyLine) 7021 return false; 7022 7023 return true; 7024 } 7025 } // Unnamed namespace 7026 7027 void Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc, 7028 const Stmt *Body, 7029 unsigned DiagID) { 7030 // Since this is a syntactic check, don't emit diagnostic for template 7031 // instantiations, this just adds noise. 7032 if (CurrentInstantiationScope) 7033 return; 7034 7035 // The body should be a null statement. 7036 const NullStmt *NBody = dyn_cast<NullStmt>(Body); 7037 if (!NBody) 7038 return; 7039 7040 // Do the usual checks. 7041 if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 7042 return; 7043 7044 Diag(NBody->getSemiLoc(), DiagID); 7045 Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 7046 } 7047 7048 void Sema::DiagnoseEmptyLoopBody(const Stmt *S, 7049 const Stmt *PossibleBody) { 7050 assert(!CurrentInstantiationScope); // Ensured by caller 7051 7052 SourceLocation StmtLoc; 7053 const Stmt *Body; 7054 unsigned DiagID; 7055 if (const ForStmt *FS = dyn_cast<ForStmt>(S)) { 7056 StmtLoc = FS->getRParenLoc(); 7057 Body = FS->getBody(); 7058 DiagID = diag::warn_empty_for_body; 7059 } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) { 7060 StmtLoc = WS->getCond()->getSourceRange().getEnd(); 7061 Body = WS->getBody(); 7062 DiagID = diag::warn_empty_while_body; 7063 } else 7064 return; // Neither `for' nor `while'. 7065 7066 // The body should be a null statement. 7067 const NullStmt *NBody = dyn_cast<NullStmt>(Body); 7068 if (!NBody) 7069 return; 7070 7071 // Skip expensive checks if diagnostic is disabled. 7072 if (Diags.getDiagnosticLevel(DiagID, NBody->getSemiLoc()) == 7073 DiagnosticsEngine::Ignored) 7074 return; 7075 7076 // Do the usual checks. 7077 if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 7078 return; 7079 7080 // `for(...);' and `while(...);' are popular idioms, so in order to keep 7081 // noise level low, emit diagnostics only if for/while is followed by a 7082 // CompoundStmt, e.g.: 7083 // for (int i = 0; i < n; i++); 7084 // { 7085 // a(i); 7086 // } 7087 // or if for/while is followed by a statement with more indentation 7088 // than for/while itself: 7089 // for (int i = 0; i < n; i++); 7090 // a(i); 7091 bool ProbableTypo = isa<CompoundStmt>(PossibleBody); 7092 if (!ProbableTypo) { 7093 bool BodyColInvalid; 7094 unsigned BodyCol = SourceMgr.getPresumedColumnNumber( 7095 PossibleBody->getLocStart(), 7096 &BodyColInvalid); 7097 if (BodyColInvalid) 7098 return; 7099 7100 bool StmtColInvalid; 7101 unsigned StmtCol = SourceMgr.getPresumedColumnNumber( 7102 S->getLocStart(), 7103 &StmtColInvalid); 7104 if (StmtColInvalid) 7105 return; 7106 7107 if (BodyCol > StmtCol) 7108 ProbableTypo = true; 7109 } 7110 7111 if (ProbableTypo) { 7112 Diag(NBody->getSemiLoc(), DiagID); 7113 Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 7114 } 7115 } 7116 7117 //===--- Layout compatibility ----------------------------------------------// 7118 7119 namespace { 7120 7121 bool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2); 7122 7123 /// \brief Check if two enumeration types are layout-compatible. 7124 bool isLayoutCompatible(ASTContext &C, EnumDecl *ED1, EnumDecl *ED2) { 7125 // C++11 [dcl.enum] p8: 7126 // Two enumeration types are layout-compatible if they have the same 7127 // underlying type. 7128 return ED1->isComplete() && ED2->isComplete() && 7129 C.hasSameType(ED1->getIntegerType(), ED2->getIntegerType()); 7130 } 7131 7132 /// \brief Check if two fields are layout-compatible. 7133 bool isLayoutCompatible(ASTContext &C, FieldDecl *Field1, FieldDecl *Field2) { 7134 if (!isLayoutCompatible(C, Field1->getType(), Field2->getType())) 7135 return false; 7136 7137 if (Field1->isBitField() != Field2->isBitField()) 7138 return false; 7139 7140 if (Field1->isBitField()) { 7141 // Make sure that the bit-fields are the same length. 7142 unsigned Bits1 = Field1->getBitWidthValue(C); 7143 unsigned Bits2 = Field2->getBitWidthValue(C); 7144 7145 if (Bits1 != Bits2) 7146 return false; 7147 } 7148 7149 return true; 7150 } 7151 7152 /// \brief Check if two standard-layout structs are layout-compatible. 7153 /// (C++11 [class.mem] p17) 7154 bool isLayoutCompatibleStruct(ASTContext &C, 7155 RecordDecl *RD1, 7156 RecordDecl *RD2) { 7157 // If both records are C++ classes, check that base classes match. 7158 if (const CXXRecordDecl *D1CXX = dyn_cast<CXXRecordDecl>(RD1)) { 7159 // If one of records is a CXXRecordDecl we are in C++ mode, 7160 // thus the other one is a CXXRecordDecl, too. 7161 const CXXRecordDecl *D2CXX = cast<CXXRecordDecl>(RD2); 7162 // Check number of base classes. 7163 if (D1CXX->getNumBases() != D2CXX->getNumBases()) 7164 return false; 7165 7166 // Check the base classes. 7167 for (CXXRecordDecl::base_class_const_iterator 7168 Base1 = D1CXX->bases_begin(), 7169 BaseEnd1 = D1CXX->bases_end(), 7170 Base2 = D2CXX->bases_begin(); 7171 Base1 != BaseEnd1; 7172 ++Base1, ++Base2) { 7173 if (!isLayoutCompatible(C, Base1->getType(), Base2->getType())) 7174 return false; 7175 } 7176 } else if (const CXXRecordDecl *D2CXX = dyn_cast<CXXRecordDecl>(RD2)) { 7177 // If only RD2 is a C++ class, it should have zero base classes. 7178 if (D2CXX->getNumBases() > 0) 7179 return false; 7180 } 7181 7182 // Check the fields. 7183 RecordDecl::field_iterator Field2 = RD2->field_begin(), 7184 Field2End = RD2->field_end(), 7185 Field1 = RD1->field_begin(), 7186 Field1End = RD1->field_end(); 7187 for ( ; Field1 != Field1End && Field2 != Field2End; ++Field1, ++Field2) { 7188 if (!isLayoutCompatible(C, *Field1, *Field2)) 7189 return false; 7190 } 7191 if (Field1 != Field1End || Field2 != Field2End) 7192 return false; 7193 7194 return true; 7195 } 7196 7197 /// \brief Check if two standard-layout unions are layout-compatible. 7198 /// (C++11 [class.mem] p18) 7199 bool isLayoutCompatibleUnion(ASTContext &C, 7200 RecordDecl *RD1, 7201 RecordDecl *RD2) { 7202 llvm::SmallPtrSet<FieldDecl *, 8> UnmatchedFields; 7203 for (RecordDecl::field_iterator Field2 = RD2->field_begin(), 7204 Field2End = RD2->field_end(); 7205 Field2 != Field2End; ++Field2) { 7206 UnmatchedFields.insert(*Field2); 7207 } 7208 7209 for (RecordDecl::field_iterator Field1 = RD1->field_begin(), 7210 Field1End = RD1->field_end(); 7211 Field1 != Field1End; ++Field1) { 7212 llvm::SmallPtrSet<FieldDecl *, 8>::iterator 7213 I = UnmatchedFields.begin(), 7214 E = UnmatchedFields.end(); 7215 7216 for ( ; I != E; ++I) { 7217 if (isLayoutCompatible(C, *Field1, *I)) { 7218 bool Result = UnmatchedFields.erase(*I); 7219 (void) Result; 7220 assert(Result); 7221 break; 7222 } 7223 } 7224 if (I == E) 7225 return false; 7226 } 7227 7228 return UnmatchedFields.empty(); 7229 } 7230 7231 bool isLayoutCompatible(ASTContext &C, RecordDecl *RD1, RecordDecl *RD2) { 7232 if (RD1->isUnion() != RD2->isUnion()) 7233 return false; 7234 7235 if (RD1->isUnion()) 7236 return isLayoutCompatibleUnion(C, RD1, RD2); 7237 else 7238 return isLayoutCompatibleStruct(C, RD1, RD2); 7239 } 7240 7241 /// \brief Check if two types are layout-compatible in C++11 sense. 7242 bool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2) { 7243 if (T1.isNull() || T2.isNull()) 7244 return false; 7245 7246 // C++11 [basic.types] p11: 7247 // If two types T1 and T2 are the same type, then T1 and T2 are 7248 // layout-compatible types. 7249 if (C.hasSameType(T1, T2)) 7250 return true; 7251 7252 T1 = T1.getCanonicalType().getUnqualifiedType(); 7253 T2 = T2.getCanonicalType().getUnqualifiedType(); 7254 7255 const Type::TypeClass TC1 = T1->getTypeClass(); 7256 const Type::TypeClass TC2 = T2->getTypeClass(); 7257 7258 if (TC1 != TC2) 7259 return false; 7260 7261 if (TC1 == Type::Enum) { 7262 return isLayoutCompatible(C, 7263 cast<EnumType>(T1)->getDecl(), 7264 cast<EnumType>(T2)->getDecl()); 7265 } else if (TC1 == Type::Record) { 7266 if (!T1->isStandardLayoutType() || !T2->isStandardLayoutType()) 7267 return false; 7268 7269 return isLayoutCompatible(C, 7270 cast<RecordType>(T1)->getDecl(), 7271 cast<RecordType>(T2)->getDecl()); 7272 } 7273 7274 return false; 7275 } 7276 } 7277 7278 //===--- CHECK: pointer_with_type_tag attribute: datatypes should match ----// 7279 7280 namespace { 7281 /// \brief Given a type tag expression find the type tag itself. 7282 /// 7283 /// \param TypeExpr Type tag expression, as it appears in user's code. 7284 /// 7285 /// \param VD Declaration of an identifier that appears in a type tag. 7286 /// 7287 /// \param MagicValue Type tag magic value. 7288 bool FindTypeTagExpr(const Expr *TypeExpr, const ASTContext &Ctx, 7289 const ValueDecl **VD, uint64_t *MagicValue) { 7290 while(true) { 7291 if (!TypeExpr) 7292 return false; 7293 7294 TypeExpr = TypeExpr->IgnoreParenImpCasts()->IgnoreParenCasts(); 7295 7296 switch (TypeExpr->getStmtClass()) { 7297 case Stmt::UnaryOperatorClass: { 7298 const UnaryOperator *UO = cast<UnaryOperator>(TypeExpr); 7299 if (UO->getOpcode() == UO_AddrOf || UO->getOpcode() == UO_Deref) { 7300 TypeExpr = UO->getSubExpr(); 7301 continue; 7302 } 7303 return false; 7304 } 7305 7306 case Stmt::DeclRefExprClass: { 7307 const DeclRefExpr *DRE = cast<DeclRefExpr>(TypeExpr); 7308 *VD = DRE->getDecl(); 7309 return true; 7310 } 7311 7312 case Stmt::IntegerLiteralClass: { 7313 const IntegerLiteral *IL = cast<IntegerLiteral>(TypeExpr); 7314 llvm::APInt MagicValueAPInt = IL->getValue(); 7315 if (MagicValueAPInt.getActiveBits() <= 64) { 7316 *MagicValue = MagicValueAPInt.getZExtValue(); 7317 return true; 7318 } else 7319 return false; 7320 } 7321 7322 case Stmt::BinaryConditionalOperatorClass: 7323 case Stmt::ConditionalOperatorClass: { 7324 const AbstractConditionalOperator *ACO = 7325 cast<AbstractConditionalOperator>(TypeExpr); 7326 bool Result; 7327 if (ACO->getCond()->EvaluateAsBooleanCondition(Result, Ctx)) { 7328 if (Result) 7329 TypeExpr = ACO->getTrueExpr(); 7330 else 7331 TypeExpr = ACO->getFalseExpr(); 7332 continue; 7333 } 7334 return false; 7335 } 7336 7337 case Stmt::BinaryOperatorClass: { 7338 const BinaryOperator *BO = cast<BinaryOperator>(TypeExpr); 7339 if (BO->getOpcode() == BO_Comma) { 7340 TypeExpr = BO->getRHS(); 7341 continue; 7342 } 7343 return false; 7344 } 7345 7346 default: 7347 return false; 7348 } 7349 } 7350 } 7351 7352 /// \brief Retrieve the C type corresponding to type tag TypeExpr. 7353 /// 7354 /// \param TypeExpr Expression that specifies a type tag. 7355 /// 7356 /// \param MagicValues Registered magic values. 7357 /// 7358 /// \param FoundWrongKind Set to true if a type tag was found, but of a wrong 7359 /// kind. 7360 /// 7361 /// \param TypeInfo Information about the corresponding C type. 7362 /// 7363 /// \returns true if the corresponding C type was found. 7364 bool GetMatchingCType( 7365 const IdentifierInfo *ArgumentKind, 7366 const Expr *TypeExpr, const ASTContext &Ctx, 7367 const llvm::DenseMap<Sema::TypeTagMagicValue, 7368 Sema::TypeTagData> *MagicValues, 7369 bool &FoundWrongKind, 7370 Sema::TypeTagData &TypeInfo) { 7371 FoundWrongKind = false; 7372 7373 // Variable declaration that has type_tag_for_datatype attribute. 7374 const ValueDecl *VD = NULL; 7375 7376 uint64_t MagicValue; 7377 7378 if (!FindTypeTagExpr(TypeExpr, Ctx, &VD, &MagicValue)) 7379 return false; 7380 7381 if (VD) { 7382 for (specific_attr_iterator<TypeTagForDatatypeAttr> 7383 I = VD->specific_attr_begin<TypeTagForDatatypeAttr>(), 7384 E = VD->specific_attr_end<TypeTagForDatatypeAttr>(); 7385 I != E; ++I) { 7386 if (I->getArgumentKind() != ArgumentKind) { 7387 FoundWrongKind = true; 7388 return false; 7389 } 7390 TypeInfo.Type = I->getMatchingCType(); 7391 TypeInfo.LayoutCompatible = I->getLayoutCompatible(); 7392 TypeInfo.MustBeNull = I->getMustBeNull(); 7393 return true; 7394 } 7395 return false; 7396 } 7397 7398 if (!MagicValues) 7399 return false; 7400 7401 llvm::DenseMap<Sema::TypeTagMagicValue, 7402 Sema::TypeTagData>::const_iterator I = 7403 MagicValues->find(std::make_pair(ArgumentKind, MagicValue)); 7404 if (I == MagicValues->end()) 7405 return false; 7406 7407 TypeInfo = I->second; 7408 return true; 7409 } 7410 } // unnamed namespace 7411 7412 void Sema::RegisterTypeTagForDatatype(const IdentifierInfo *ArgumentKind, 7413 uint64_t MagicValue, QualType Type, 7414 bool LayoutCompatible, 7415 bool MustBeNull) { 7416 if (!TypeTagForDatatypeMagicValues) 7417 TypeTagForDatatypeMagicValues.reset( 7418 new llvm::DenseMap<TypeTagMagicValue, TypeTagData>); 7419 7420 TypeTagMagicValue Magic(ArgumentKind, MagicValue); 7421 (*TypeTagForDatatypeMagicValues)[Magic] = 7422 TypeTagData(Type, LayoutCompatible, MustBeNull); 7423 } 7424 7425 namespace { 7426 bool IsSameCharType(QualType T1, QualType T2) { 7427 const BuiltinType *BT1 = T1->getAs<BuiltinType>(); 7428 if (!BT1) 7429 return false; 7430 7431 const BuiltinType *BT2 = T2->getAs<BuiltinType>(); 7432 if (!BT2) 7433 return false; 7434 7435 BuiltinType::Kind T1Kind = BT1->getKind(); 7436 BuiltinType::Kind T2Kind = BT2->getKind(); 7437 7438 return (T1Kind == BuiltinType::SChar && T2Kind == BuiltinType::Char_S) || 7439 (T1Kind == BuiltinType::UChar && T2Kind == BuiltinType::Char_U) || 7440 (T1Kind == BuiltinType::Char_U && T2Kind == BuiltinType::UChar) || 7441 (T1Kind == BuiltinType::Char_S && T2Kind == BuiltinType::SChar); 7442 } 7443 } // unnamed namespace 7444 7445 void Sema::CheckArgumentWithTypeTag(const ArgumentWithTypeTagAttr *Attr, 7446 const Expr * const *ExprArgs) { 7447 const IdentifierInfo *ArgumentKind = Attr->getArgumentKind(); 7448 bool IsPointerAttr = Attr->getIsPointer(); 7449 7450 const Expr *TypeTagExpr = ExprArgs[Attr->getTypeTagIdx()]; 7451 bool FoundWrongKind; 7452 TypeTagData TypeInfo; 7453 if (!GetMatchingCType(ArgumentKind, TypeTagExpr, Context, 7454 TypeTagForDatatypeMagicValues.get(), 7455 FoundWrongKind, TypeInfo)) { 7456 if (FoundWrongKind) 7457 Diag(TypeTagExpr->getExprLoc(), 7458 diag::warn_type_tag_for_datatype_wrong_kind) 7459 << TypeTagExpr->getSourceRange(); 7460 return; 7461 } 7462 7463 const Expr *ArgumentExpr = ExprArgs[Attr->getArgumentIdx()]; 7464 if (IsPointerAttr) { 7465 // Skip implicit cast of pointer to `void *' (as a function argument). 7466 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgumentExpr)) 7467 if (ICE->getType()->isVoidPointerType() && 7468 ICE->getCastKind() == CK_BitCast) 7469 ArgumentExpr = ICE->getSubExpr(); 7470 } 7471 QualType ArgumentType = ArgumentExpr->getType(); 7472 7473 // Passing a `void*' pointer shouldn't trigger a warning. 7474 if (IsPointerAttr && ArgumentType->isVoidPointerType()) 7475 return; 7476 7477 if (TypeInfo.MustBeNull) { 7478 // Type tag with matching void type requires a null pointer. 7479 if (!ArgumentExpr->isNullPointerConstant(Context, 7480 Expr::NPC_ValueDependentIsNotNull)) { 7481 Diag(ArgumentExpr->getExprLoc(), 7482 diag::warn_type_safety_null_pointer_required) 7483 << ArgumentKind->getName() 7484 << ArgumentExpr->getSourceRange() 7485 << TypeTagExpr->getSourceRange(); 7486 } 7487 return; 7488 } 7489 7490 QualType RequiredType = TypeInfo.Type; 7491 if (IsPointerAttr) 7492 RequiredType = Context.getPointerType(RequiredType); 7493 7494 bool mismatch = false; 7495 if (!TypeInfo.LayoutCompatible) { 7496 mismatch = !Context.hasSameType(ArgumentType, RequiredType); 7497 7498 // C++11 [basic.fundamental] p1: 7499 // Plain char, signed char, and unsigned char are three distinct types. 7500 // 7501 // But we treat plain `char' as equivalent to `signed char' or `unsigned 7502 // char' depending on the current char signedness mode. 7503 if (mismatch) 7504 if ((IsPointerAttr && IsSameCharType(ArgumentType->getPointeeType(), 7505 RequiredType->getPointeeType())) || 7506 (!IsPointerAttr && IsSameCharType(ArgumentType, RequiredType))) 7507 mismatch = false; 7508 } else 7509 if (IsPointerAttr) 7510 mismatch = !isLayoutCompatible(Context, 7511 ArgumentType->getPointeeType(), 7512 RequiredType->getPointeeType()); 7513 else 7514 mismatch = !isLayoutCompatible(Context, ArgumentType, RequiredType); 7515 7516 if (mismatch) 7517 Diag(ArgumentExpr->getExprLoc(), diag::warn_type_safety_type_mismatch) 7518 << ArgumentType << ArgumentKind 7519 << TypeInfo.LayoutCompatible << RequiredType 7520 << ArgumentExpr->getSourceRange() 7521 << TypeTagExpr->getSourceRange(); 7522 } 7523