1 //===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 // 10 // This file implements extra semantic analysis beyond what is enforced 11 // by the C type system. 12 // 13 //===----------------------------------------------------------------------===// 14 15 #include "clang/AST/ASTContext.h" 16 #include "clang/AST/CharUnits.h" 17 #include "clang/AST/DeclCXX.h" 18 #include "clang/AST/DeclObjC.h" 19 #include "clang/AST/EvaluatedExprVisitor.h" 20 #include "clang/AST/Expr.h" 21 #include "clang/AST/ExprCXX.h" 22 #include "clang/AST/ExprObjC.h" 23 #include "clang/AST/ExprOpenMP.h" 24 #include "clang/AST/StmtCXX.h" 25 #include "clang/AST/StmtObjC.h" 26 #include "clang/Analysis/Analyses/FormatString.h" 27 #include "clang/Basic/CharInfo.h" 28 #include "clang/Basic/TargetBuiltins.h" 29 #include "clang/Basic/TargetInfo.h" 30 #include "clang/Lex/Lexer.h" // TODO: Extract static functions to fix layering. 31 #include "clang/Sema/Initialization.h" 32 #include "clang/Sema/Lookup.h" 33 #include "clang/Sema/ScopeInfo.h" 34 #include "clang/Sema/Sema.h" 35 #include "clang/Sema/SemaInternal.h" 36 #include "llvm/ADT/STLExtras.h" 37 #include "llvm/ADT/SmallBitVector.h" 38 #include "llvm/ADT/SmallString.h" 39 #include "llvm/Support/ConvertUTF.h" 40 #include "llvm/Support/Format.h" 41 #include "llvm/Support/Locale.h" 42 #include "llvm/Support/raw_ostream.h" 43 44 using namespace clang; 45 using namespace sema; 46 47 SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 48 unsigned ByteNo) const { 49 return SL->getLocationOfByte(ByteNo, getSourceManager(), LangOpts, 50 Context.getTargetInfo()); 51 } 52 53 /// Checks that a call expression's argument count is the desired number. 54 /// This is useful when doing custom type-checking. Returns true on error. 55 static bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 56 unsigned argCount = call->getNumArgs(); 57 if (argCount == desiredArgCount) return false; 58 59 if (argCount < desiredArgCount) 60 return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 61 << 0 /*function call*/ << desiredArgCount << argCount 62 << call->getSourceRange(); 63 64 // Highlight all the excess arguments. 65 SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 66 call->getArg(argCount - 1)->getLocEnd()); 67 68 return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 69 << 0 /*function call*/ << desiredArgCount << argCount 70 << call->getArg(1)->getSourceRange(); 71 } 72 73 /// Check that the first argument to __builtin_annotation is an integer 74 /// and the second argument is a non-wide string literal. 75 static bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) { 76 if (checkArgCount(S, TheCall, 2)) 77 return true; 78 79 // First argument should be an integer. 80 Expr *ValArg = TheCall->getArg(0); 81 QualType Ty = ValArg->getType(); 82 if (!Ty->isIntegerType()) { 83 S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg) 84 << ValArg->getSourceRange(); 85 return true; 86 } 87 88 // Second argument should be a constant string. 89 Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts(); 90 StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg); 91 if (!Literal || !Literal->isAscii()) { 92 S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg) 93 << StrArg->getSourceRange(); 94 return true; 95 } 96 97 TheCall->setType(Ty); 98 return false; 99 } 100 101 /// Check that the argument to __builtin_addressof is a glvalue, and set the 102 /// result type to the corresponding pointer type. 103 static bool SemaBuiltinAddressof(Sema &S, CallExpr *TheCall) { 104 if (checkArgCount(S, TheCall, 1)) 105 return true; 106 107 ExprResult Arg(TheCall->getArg(0)); 108 QualType ResultType = S.CheckAddressOfOperand(Arg, TheCall->getLocStart()); 109 if (ResultType.isNull()) 110 return true; 111 112 TheCall->setArg(0, Arg.get()); 113 TheCall->setType(ResultType); 114 return false; 115 } 116 117 static bool SemaBuiltinOverflow(Sema &S, CallExpr *TheCall) { 118 if (checkArgCount(S, TheCall, 3)) 119 return true; 120 121 // First two arguments should be integers. 122 for (unsigned I = 0; I < 2; ++I) { 123 Expr *Arg = TheCall->getArg(I); 124 QualType Ty = Arg->getType(); 125 if (!Ty->isIntegerType()) { 126 S.Diag(Arg->getLocStart(), diag::err_overflow_builtin_must_be_int) 127 << Ty << Arg->getSourceRange(); 128 return true; 129 } 130 } 131 132 // Third argument should be a pointer to a non-const integer. 133 // IRGen correctly handles volatile, restrict, and address spaces, and 134 // the other qualifiers aren't possible. 135 { 136 Expr *Arg = TheCall->getArg(2); 137 QualType Ty = Arg->getType(); 138 const auto *PtrTy = Ty->getAs<PointerType>(); 139 if (!(PtrTy && PtrTy->getPointeeType()->isIntegerType() && 140 !PtrTy->getPointeeType().isConstQualified())) { 141 S.Diag(Arg->getLocStart(), diag::err_overflow_builtin_must_be_ptr_int) 142 << Ty << Arg->getSourceRange(); 143 return true; 144 } 145 } 146 147 return false; 148 } 149 150 static void SemaBuiltinMemChkCall(Sema &S, FunctionDecl *FDecl, 151 CallExpr *TheCall, unsigned SizeIdx, 152 unsigned DstSizeIdx) { 153 if (TheCall->getNumArgs() <= SizeIdx || 154 TheCall->getNumArgs() <= DstSizeIdx) 155 return; 156 157 const Expr *SizeArg = TheCall->getArg(SizeIdx); 158 const Expr *DstSizeArg = TheCall->getArg(DstSizeIdx); 159 160 llvm::APSInt Size, DstSize; 161 162 // find out if both sizes are known at compile time 163 if (!SizeArg->EvaluateAsInt(Size, S.Context) || 164 !DstSizeArg->EvaluateAsInt(DstSize, S.Context)) 165 return; 166 167 if (Size.ule(DstSize)) 168 return; 169 170 // confirmed overflow so generate the diagnostic. 171 IdentifierInfo *FnName = FDecl->getIdentifier(); 172 SourceLocation SL = TheCall->getLocStart(); 173 SourceRange SR = TheCall->getSourceRange(); 174 175 S.Diag(SL, diag::warn_memcpy_chk_overflow) << SR << FnName; 176 } 177 178 static bool SemaBuiltinCallWithStaticChain(Sema &S, CallExpr *BuiltinCall) { 179 if (checkArgCount(S, BuiltinCall, 2)) 180 return true; 181 182 SourceLocation BuiltinLoc = BuiltinCall->getLocStart(); 183 Expr *Builtin = BuiltinCall->getCallee()->IgnoreImpCasts(); 184 Expr *Call = BuiltinCall->getArg(0); 185 Expr *Chain = BuiltinCall->getArg(1); 186 187 if (Call->getStmtClass() != Stmt::CallExprClass) { 188 S.Diag(BuiltinLoc, diag::err_first_argument_to_cwsc_not_call) 189 << Call->getSourceRange(); 190 return true; 191 } 192 193 auto CE = cast<CallExpr>(Call); 194 if (CE->getCallee()->getType()->isBlockPointerType()) { 195 S.Diag(BuiltinLoc, diag::err_first_argument_to_cwsc_block_call) 196 << Call->getSourceRange(); 197 return true; 198 } 199 200 const Decl *TargetDecl = CE->getCalleeDecl(); 201 if (const FunctionDecl *FD = dyn_cast_or_null<FunctionDecl>(TargetDecl)) 202 if (FD->getBuiltinID()) { 203 S.Diag(BuiltinLoc, diag::err_first_argument_to_cwsc_builtin_call) 204 << Call->getSourceRange(); 205 return true; 206 } 207 208 if (isa<CXXPseudoDestructorExpr>(CE->getCallee()->IgnoreParens())) { 209 S.Diag(BuiltinLoc, diag::err_first_argument_to_cwsc_pdtor_call) 210 << Call->getSourceRange(); 211 return true; 212 } 213 214 ExprResult ChainResult = S.UsualUnaryConversions(Chain); 215 if (ChainResult.isInvalid()) 216 return true; 217 if (!ChainResult.get()->getType()->isPointerType()) { 218 S.Diag(BuiltinLoc, diag::err_second_argument_to_cwsc_not_pointer) 219 << Chain->getSourceRange(); 220 return true; 221 } 222 223 QualType ReturnTy = CE->getCallReturnType(S.Context); 224 QualType ArgTys[2] = { ReturnTy, ChainResult.get()->getType() }; 225 QualType BuiltinTy = S.Context.getFunctionType( 226 ReturnTy, ArgTys, FunctionProtoType::ExtProtoInfo()); 227 QualType BuiltinPtrTy = S.Context.getPointerType(BuiltinTy); 228 229 Builtin = 230 S.ImpCastExprToType(Builtin, BuiltinPtrTy, CK_BuiltinFnToFnPtr).get(); 231 232 BuiltinCall->setType(CE->getType()); 233 BuiltinCall->setValueKind(CE->getValueKind()); 234 BuiltinCall->setObjectKind(CE->getObjectKind()); 235 BuiltinCall->setCallee(Builtin); 236 BuiltinCall->setArg(1, ChainResult.get()); 237 238 return false; 239 } 240 241 static bool SemaBuiltinSEHScopeCheck(Sema &SemaRef, CallExpr *TheCall, 242 Scope::ScopeFlags NeededScopeFlags, 243 unsigned DiagID) { 244 // Scopes aren't available during instantiation. Fortunately, builtin 245 // functions cannot be template args so they cannot be formed through template 246 // instantiation. Therefore checking once during the parse is sufficient. 247 if (SemaRef.inTemplateInstantiation()) 248 return false; 249 250 Scope *S = SemaRef.getCurScope(); 251 while (S && !S->isSEHExceptScope()) 252 S = S->getParent(); 253 if (!S || !(S->getFlags() & NeededScopeFlags)) { 254 auto *DRE = cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 255 SemaRef.Diag(TheCall->getExprLoc(), DiagID) 256 << DRE->getDecl()->getIdentifier(); 257 return true; 258 } 259 260 return false; 261 } 262 263 static inline bool isBlockPointer(Expr *Arg) { 264 return Arg->getType()->isBlockPointerType(); 265 } 266 267 /// OpenCL C v2.0, s6.13.17.2 - Checks that the block parameters are all local 268 /// void*, which is a requirement of device side enqueue. 269 static bool checkOpenCLBlockArgs(Sema &S, Expr *BlockArg) { 270 const BlockPointerType *BPT = 271 cast<BlockPointerType>(BlockArg->getType().getCanonicalType()); 272 ArrayRef<QualType> Params = 273 BPT->getPointeeType()->getAs<FunctionProtoType>()->getParamTypes(); 274 unsigned ArgCounter = 0; 275 bool IllegalParams = false; 276 // Iterate through the block parameters until either one is found that is not 277 // a local void*, or the block is valid. 278 for (ArrayRef<QualType>::iterator I = Params.begin(), E = Params.end(); 279 I != E; ++I, ++ArgCounter) { 280 if (!(*I)->isPointerType() || !(*I)->getPointeeType()->isVoidType() || 281 (*I)->getPointeeType().getQualifiers().getAddressSpace() != 282 LangAS::opencl_local) { 283 // Get the location of the error. If a block literal has been passed 284 // (BlockExpr) then we can point straight to the offending argument, 285 // else we just point to the variable reference. 286 SourceLocation ErrorLoc; 287 if (isa<BlockExpr>(BlockArg)) { 288 BlockDecl *BD = cast<BlockExpr>(BlockArg)->getBlockDecl(); 289 ErrorLoc = BD->getParamDecl(ArgCounter)->getLocStart(); 290 } else if (isa<DeclRefExpr>(BlockArg)) { 291 ErrorLoc = cast<DeclRefExpr>(BlockArg)->getLocStart(); 292 } 293 S.Diag(ErrorLoc, 294 diag::err_opencl_enqueue_kernel_blocks_non_local_void_args); 295 IllegalParams = true; 296 } 297 } 298 299 return IllegalParams; 300 } 301 302 /// OpenCL C v2.0, s6.13.17.6 - Check the argument to the 303 /// get_kernel_work_group_size 304 /// and get_kernel_preferred_work_group_size_multiple builtin functions. 305 static bool SemaOpenCLBuiltinKernelWorkGroupSize(Sema &S, CallExpr *TheCall) { 306 if (checkArgCount(S, TheCall, 1)) 307 return true; 308 309 Expr *BlockArg = TheCall->getArg(0); 310 if (!isBlockPointer(BlockArg)) { 311 S.Diag(BlockArg->getLocStart(), 312 diag::err_opencl_enqueue_kernel_expected_type) << "block"; 313 return true; 314 } 315 return checkOpenCLBlockArgs(S, BlockArg); 316 } 317 318 /// Diagnose integer type and any valid implicit conversion to it. 319 static bool checkOpenCLEnqueueIntType(Sema &S, Expr *E, 320 const QualType &IntType); 321 322 static bool checkOpenCLEnqueueLocalSizeArgs(Sema &S, CallExpr *TheCall, 323 unsigned Start, unsigned End) { 324 bool IllegalParams = false; 325 for (unsigned I = Start; I <= End; ++I) 326 IllegalParams |= checkOpenCLEnqueueIntType(S, TheCall->getArg(I), 327 S.Context.getSizeType()); 328 return IllegalParams; 329 } 330 331 /// OpenCL v2.0, s6.13.17.1 - Check that sizes are provided for all 332 /// 'local void*' parameter of passed block. 333 static bool checkOpenCLEnqueueVariadicArgs(Sema &S, CallExpr *TheCall, 334 Expr *BlockArg, 335 unsigned NumNonVarArgs) { 336 const BlockPointerType *BPT = 337 cast<BlockPointerType>(BlockArg->getType().getCanonicalType()); 338 unsigned NumBlockParams = 339 BPT->getPointeeType()->getAs<FunctionProtoType>()->getNumParams(); 340 unsigned TotalNumArgs = TheCall->getNumArgs(); 341 342 // For each argument passed to the block, a corresponding uint needs to 343 // be passed to describe the size of the local memory. 344 if (TotalNumArgs != NumBlockParams + NumNonVarArgs) { 345 S.Diag(TheCall->getLocStart(), 346 diag::err_opencl_enqueue_kernel_local_size_args); 347 return true; 348 } 349 350 // Check that the sizes of the local memory are specified by integers. 351 return checkOpenCLEnqueueLocalSizeArgs(S, TheCall, NumNonVarArgs, 352 TotalNumArgs - 1); 353 } 354 355 /// OpenCL C v2.0, s6.13.17 - Enqueue kernel function contains four different 356 /// overload formats specified in Table 6.13.17.1. 357 /// int enqueue_kernel(queue_t queue, 358 /// kernel_enqueue_flags_t flags, 359 /// const ndrange_t ndrange, 360 /// void (^block)(void)) 361 /// int enqueue_kernel(queue_t queue, 362 /// kernel_enqueue_flags_t flags, 363 /// const ndrange_t ndrange, 364 /// uint num_events_in_wait_list, 365 /// clk_event_t *event_wait_list, 366 /// clk_event_t *event_ret, 367 /// void (^block)(void)) 368 /// int enqueue_kernel(queue_t queue, 369 /// kernel_enqueue_flags_t flags, 370 /// const ndrange_t ndrange, 371 /// void (^block)(local void*, ...), 372 /// uint size0, ...) 373 /// int enqueue_kernel(queue_t queue, 374 /// kernel_enqueue_flags_t flags, 375 /// const ndrange_t ndrange, 376 /// uint num_events_in_wait_list, 377 /// clk_event_t *event_wait_list, 378 /// clk_event_t *event_ret, 379 /// void (^block)(local void*, ...), 380 /// uint size0, ...) 381 static bool SemaOpenCLBuiltinEnqueueKernel(Sema &S, CallExpr *TheCall) { 382 unsigned NumArgs = TheCall->getNumArgs(); 383 384 if (NumArgs < 4) { 385 S.Diag(TheCall->getLocStart(), diag::err_typecheck_call_too_few_args); 386 return true; 387 } 388 389 Expr *Arg0 = TheCall->getArg(0); 390 Expr *Arg1 = TheCall->getArg(1); 391 Expr *Arg2 = TheCall->getArg(2); 392 Expr *Arg3 = TheCall->getArg(3); 393 394 // First argument always needs to be a queue_t type. 395 if (!Arg0->getType()->isQueueT()) { 396 S.Diag(TheCall->getArg(0)->getLocStart(), 397 diag::err_opencl_enqueue_kernel_expected_type) 398 << S.Context.OCLQueueTy; 399 return true; 400 } 401 402 // Second argument always needs to be a kernel_enqueue_flags_t enum value. 403 if (!Arg1->getType()->isIntegerType()) { 404 S.Diag(TheCall->getArg(1)->getLocStart(), 405 diag::err_opencl_enqueue_kernel_expected_type) 406 << "'kernel_enqueue_flags_t' (i.e. uint)"; 407 return true; 408 } 409 410 // Third argument is always an ndrange_t type. 411 if (Arg2->getType().getUnqualifiedType().getAsString() != "ndrange_t") { 412 S.Diag(TheCall->getArg(2)->getLocStart(), 413 diag::err_opencl_enqueue_kernel_expected_type) 414 << "'ndrange_t'"; 415 return true; 416 } 417 418 // With four arguments, there is only one form that the function could be 419 // called in: no events and no variable arguments. 420 if (NumArgs == 4) { 421 // check that the last argument is the right block type. 422 if (!isBlockPointer(Arg3)) { 423 S.Diag(Arg3->getLocStart(), diag::err_opencl_enqueue_kernel_expected_type) 424 << "block"; 425 return true; 426 } 427 // we have a block type, check the prototype 428 const BlockPointerType *BPT = 429 cast<BlockPointerType>(Arg3->getType().getCanonicalType()); 430 if (BPT->getPointeeType()->getAs<FunctionProtoType>()->getNumParams() > 0) { 431 S.Diag(Arg3->getLocStart(), 432 diag::err_opencl_enqueue_kernel_blocks_no_args); 433 return true; 434 } 435 return false; 436 } 437 // we can have block + varargs. 438 if (isBlockPointer(Arg3)) 439 return (checkOpenCLBlockArgs(S, Arg3) || 440 checkOpenCLEnqueueVariadicArgs(S, TheCall, Arg3, 4)); 441 // last two cases with either exactly 7 args or 7 args and varargs. 442 if (NumArgs >= 7) { 443 // check common block argument. 444 Expr *Arg6 = TheCall->getArg(6); 445 if (!isBlockPointer(Arg6)) { 446 S.Diag(Arg6->getLocStart(), diag::err_opencl_enqueue_kernel_expected_type) 447 << "block"; 448 return true; 449 } 450 if (checkOpenCLBlockArgs(S, Arg6)) 451 return true; 452 453 // Forth argument has to be any integer type. 454 if (!Arg3->getType()->isIntegerType()) { 455 S.Diag(TheCall->getArg(3)->getLocStart(), 456 diag::err_opencl_enqueue_kernel_expected_type) 457 << "integer"; 458 return true; 459 } 460 // check remaining common arguments. 461 Expr *Arg4 = TheCall->getArg(4); 462 Expr *Arg5 = TheCall->getArg(5); 463 464 // Fifth argument is always passed as a pointer to clk_event_t. 465 if (!Arg4->isNullPointerConstant(S.Context, 466 Expr::NPC_ValueDependentIsNotNull) && 467 !Arg4->getType()->getPointeeOrArrayElementType()->isClkEventT()) { 468 S.Diag(TheCall->getArg(4)->getLocStart(), 469 diag::err_opencl_enqueue_kernel_expected_type) 470 << S.Context.getPointerType(S.Context.OCLClkEventTy); 471 return true; 472 } 473 474 // Sixth argument is always passed as a pointer to clk_event_t. 475 if (!Arg5->isNullPointerConstant(S.Context, 476 Expr::NPC_ValueDependentIsNotNull) && 477 !(Arg5->getType()->isPointerType() && 478 Arg5->getType()->getPointeeType()->isClkEventT())) { 479 S.Diag(TheCall->getArg(5)->getLocStart(), 480 diag::err_opencl_enqueue_kernel_expected_type) 481 << S.Context.getPointerType(S.Context.OCLClkEventTy); 482 return true; 483 } 484 485 if (NumArgs == 7) 486 return false; 487 488 return checkOpenCLEnqueueVariadicArgs(S, TheCall, Arg6, 7); 489 } 490 491 // None of the specific case has been detected, give generic error 492 S.Diag(TheCall->getLocStart(), 493 diag::err_opencl_enqueue_kernel_incorrect_args); 494 return true; 495 } 496 497 /// Returns OpenCL access qual. 498 static OpenCLAccessAttr *getOpenCLArgAccess(const Decl *D) { 499 return D->getAttr<OpenCLAccessAttr>(); 500 } 501 502 /// Returns true if pipe element type is different from the pointer. 503 static bool checkOpenCLPipeArg(Sema &S, CallExpr *Call) { 504 const Expr *Arg0 = Call->getArg(0); 505 // First argument type should always be pipe. 506 if (!Arg0->getType()->isPipeType()) { 507 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_pipe_first_arg) 508 << Call->getDirectCallee() << Arg0->getSourceRange(); 509 return true; 510 } 511 OpenCLAccessAttr *AccessQual = 512 getOpenCLArgAccess(cast<DeclRefExpr>(Arg0)->getDecl()); 513 // Validates the access qualifier is compatible with the call. 514 // OpenCL v2.0 s6.13.16 - The access qualifiers for pipe should only be 515 // read_only and write_only, and assumed to be read_only if no qualifier is 516 // specified. 517 switch (Call->getDirectCallee()->getBuiltinID()) { 518 case Builtin::BIread_pipe: 519 case Builtin::BIreserve_read_pipe: 520 case Builtin::BIcommit_read_pipe: 521 case Builtin::BIwork_group_reserve_read_pipe: 522 case Builtin::BIsub_group_reserve_read_pipe: 523 case Builtin::BIwork_group_commit_read_pipe: 524 case Builtin::BIsub_group_commit_read_pipe: 525 if (!(!AccessQual || AccessQual->isReadOnly())) { 526 S.Diag(Arg0->getLocStart(), 527 diag::err_opencl_builtin_pipe_invalid_access_modifier) 528 << "read_only" << Arg0->getSourceRange(); 529 return true; 530 } 531 break; 532 case Builtin::BIwrite_pipe: 533 case Builtin::BIreserve_write_pipe: 534 case Builtin::BIcommit_write_pipe: 535 case Builtin::BIwork_group_reserve_write_pipe: 536 case Builtin::BIsub_group_reserve_write_pipe: 537 case Builtin::BIwork_group_commit_write_pipe: 538 case Builtin::BIsub_group_commit_write_pipe: 539 if (!(AccessQual && AccessQual->isWriteOnly())) { 540 S.Diag(Arg0->getLocStart(), 541 diag::err_opencl_builtin_pipe_invalid_access_modifier) 542 << "write_only" << Arg0->getSourceRange(); 543 return true; 544 } 545 break; 546 default: 547 break; 548 } 549 return false; 550 } 551 552 /// Returns true if pipe element type is different from the pointer. 553 static bool checkOpenCLPipePacketType(Sema &S, CallExpr *Call, unsigned Idx) { 554 const Expr *Arg0 = Call->getArg(0); 555 const Expr *ArgIdx = Call->getArg(Idx); 556 const PipeType *PipeTy = cast<PipeType>(Arg0->getType()); 557 const QualType EltTy = PipeTy->getElementType(); 558 const PointerType *ArgTy = ArgIdx->getType()->getAs<PointerType>(); 559 // The Idx argument should be a pointer and the type of the pointer and 560 // the type of pipe element should also be the same. 561 if (!ArgTy || 562 !S.Context.hasSameType( 563 EltTy, ArgTy->getPointeeType()->getCanonicalTypeInternal())) { 564 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_pipe_invalid_arg) 565 << Call->getDirectCallee() << S.Context.getPointerType(EltTy) 566 << ArgIdx->getType() << ArgIdx->getSourceRange(); 567 return true; 568 } 569 return false; 570 } 571 572 // \brief Performs semantic analysis for the read/write_pipe call. 573 // \param S Reference to the semantic analyzer. 574 // \param Call A pointer to the builtin call. 575 // \return True if a semantic error has been found, false otherwise. 576 static bool SemaBuiltinRWPipe(Sema &S, CallExpr *Call) { 577 // OpenCL v2.0 s6.13.16.2 - The built-in read/write 578 // functions have two forms. 579 switch (Call->getNumArgs()) { 580 case 2: { 581 if (checkOpenCLPipeArg(S, Call)) 582 return true; 583 // The call with 2 arguments should be 584 // read/write_pipe(pipe T, T*). 585 // Check packet type T. 586 if (checkOpenCLPipePacketType(S, Call, 1)) 587 return true; 588 } break; 589 590 case 4: { 591 if (checkOpenCLPipeArg(S, Call)) 592 return true; 593 // The call with 4 arguments should be 594 // read/write_pipe(pipe T, reserve_id_t, uint, T*). 595 // Check reserve_id_t. 596 if (!Call->getArg(1)->getType()->isReserveIDT()) { 597 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_pipe_invalid_arg) 598 << Call->getDirectCallee() << S.Context.OCLReserveIDTy 599 << Call->getArg(1)->getType() << Call->getArg(1)->getSourceRange(); 600 return true; 601 } 602 603 // Check the index. 604 const Expr *Arg2 = Call->getArg(2); 605 if (!Arg2->getType()->isIntegerType() && 606 !Arg2->getType()->isUnsignedIntegerType()) { 607 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_pipe_invalid_arg) 608 << Call->getDirectCallee() << S.Context.UnsignedIntTy 609 << Arg2->getType() << Arg2->getSourceRange(); 610 return true; 611 } 612 613 // Check packet type T. 614 if (checkOpenCLPipePacketType(S, Call, 3)) 615 return true; 616 } break; 617 default: 618 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_pipe_arg_num) 619 << Call->getDirectCallee() << Call->getSourceRange(); 620 return true; 621 } 622 623 return false; 624 } 625 626 // \brief Performs a semantic analysis on the {work_group_/sub_group_ 627 // /_}reserve_{read/write}_pipe 628 // \param S Reference to the semantic analyzer. 629 // \param Call The call to the builtin function to be analyzed. 630 // \return True if a semantic error was found, false otherwise. 631 static bool SemaBuiltinReserveRWPipe(Sema &S, CallExpr *Call) { 632 if (checkArgCount(S, Call, 2)) 633 return true; 634 635 if (checkOpenCLPipeArg(S, Call)) 636 return true; 637 638 // Check the reserve size. 639 if (!Call->getArg(1)->getType()->isIntegerType() && 640 !Call->getArg(1)->getType()->isUnsignedIntegerType()) { 641 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_pipe_invalid_arg) 642 << Call->getDirectCallee() << S.Context.UnsignedIntTy 643 << Call->getArg(1)->getType() << Call->getArg(1)->getSourceRange(); 644 return true; 645 } 646 647 return false; 648 } 649 650 // \brief Performs a semantic analysis on {work_group_/sub_group_ 651 // /_}commit_{read/write}_pipe 652 // \param S Reference to the semantic analyzer. 653 // \param Call The call to the builtin function to be analyzed. 654 // \return True if a semantic error was found, false otherwise. 655 static bool SemaBuiltinCommitRWPipe(Sema &S, CallExpr *Call) { 656 if (checkArgCount(S, Call, 2)) 657 return true; 658 659 if (checkOpenCLPipeArg(S, Call)) 660 return true; 661 662 // Check reserve_id_t. 663 if (!Call->getArg(1)->getType()->isReserveIDT()) { 664 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_pipe_invalid_arg) 665 << Call->getDirectCallee() << S.Context.OCLReserveIDTy 666 << Call->getArg(1)->getType() << Call->getArg(1)->getSourceRange(); 667 return true; 668 } 669 670 return false; 671 } 672 673 // \brief Performs a semantic analysis on the call to built-in Pipe 674 // Query Functions. 675 // \param S Reference to the semantic analyzer. 676 // \param Call The call to the builtin function to be analyzed. 677 // \return True if a semantic error was found, false otherwise. 678 static bool SemaBuiltinPipePackets(Sema &S, CallExpr *Call) { 679 if (checkArgCount(S, Call, 1)) 680 return true; 681 682 if (!Call->getArg(0)->getType()->isPipeType()) { 683 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_pipe_first_arg) 684 << Call->getDirectCallee() << Call->getArg(0)->getSourceRange(); 685 return true; 686 } 687 688 return false; 689 } 690 // \brief OpenCL v2.0 s6.13.9 - Address space qualifier functions. 691 // \brief Performs semantic analysis for the to_global/local/private call. 692 // \param S Reference to the semantic analyzer. 693 // \param BuiltinID ID of the builtin function. 694 // \param Call A pointer to the builtin call. 695 // \return True if a semantic error has been found, false otherwise. 696 static bool SemaOpenCLBuiltinToAddr(Sema &S, unsigned BuiltinID, 697 CallExpr *Call) { 698 if (Call->getNumArgs() != 1) { 699 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_to_addr_arg_num) 700 << Call->getDirectCallee() << Call->getSourceRange(); 701 return true; 702 } 703 704 auto RT = Call->getArg(0)->getType(); 705 if (!RT->isPointerType() || RT->getPointeeType() 706 .getAddressSpace() == LangAS::opencl_constant) { 707 S.Diag(Call->getLocStart(), diag::err_opencl_builtin_to_addr_invalid_arg) 708 << Call->getArg(0) << Call->getDirectCallee() << Call->getSourceRange(); 709 return true; 710 } 711 712 RT = RT->getPointeeType(); 713 auto Qual = RT.getQualifiers(); 714 switch (BuiltinID) { 715 case Builtin::BIto_global: 716 Qual.setAddressSpace(LangAS::opencl_global); 717 break; 718 case Builtin::BIto_local: 719 Qual.setAddressSpace(LangAS::opencl_local); 720 break; 721 default: 722 Qual.removeAddressSpace(); 723 } 724 Call->setType(S.Context.getPointerType(S.Context.getQualifiedType( 725 RT.getUnqualifiedType(), Qual))); 726 727 return false; 728 } 729 730 ExprResult 731 Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID, 732 CallExpr *TheCall) { 733 ExprResult TheCallResult(TheCall); 734 735 // Find out if any arguments are required to be integer constant expressions. 736 unsigned ICEArguments = 0; 737 ASTContext::GetBuiltinTypeError Error; 738 Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 739 if (Error != ASTContext::GE_None) 740 ICEArguments = 0; // Don't diagnose previously diagnosed errors. 741 742 // If any arguments are required to be ICE's, check and diagnose. 743 for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 744 // Skip arguments not required to be ICE's. 745 if ((ICEArguments & (1 << ArgNo)) == 0) continue; 746 747 llvm::APSInt Result; 748 if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 749 return true; 750 ICEArguments &= ~(1 << ArgNo); 751 } 752 753 switch (BuiltinID) { 754 case Builtin::BI__builtin___CFStringMakeConstantString: 755 assert(TheCall->getNumArgs() == 1 && 756 "Wrong # arguments to builtin CFStringMakeConstantString"); 757 if (CheckObjCString(TheCall->getArg(0))) 758 return ExprError(); 759 break; 760 case Builtin::BI__builtin_stdarg_start: 761 case Builtin::BI__builtin_va_start: 762 if (SemaBuiltinVAStart(BuiltinID, TheCall)) 763 return ExprError(); 764 break; 765 case Builtin::BI__va_start: { 766 switch (Context.getTargetInfo().getTriple().getArch()) { 767 case llvm::Triple::arm: 768 case llvm::Triple::thumb: 769 if (SemaBuiltinVAStartARM(TheCall)) 770 return ExprError(); 771 break; 772 default: 773 if (SemaBuiltinVAStart(BuiltinID, TheCall)) 774 return ExprError(); 775 break; 776 } 777 break; 778 } 779 case Builtin::BI__builtin_isgreater: 780 case Builtin::BI__builtin_isgreaterequal: 781 case Builtin::BI__builtin_isless: 782 case Builtin::BI__builtin_islessequal: 783 case Builtin::BI__builtin_islessgreater: 784 case Builtin::BI__builtin_isunordered: 785 if (SemaBuiltinUnorderedCompare(TheCall)) 786 return ExprError(); 787 break; 788 case Builtin::BI__builtin_fpclassify: 789 if (SemaBuiltinFPClassification(TheCall, 6)) 790 return ExprError(); 791 break; 792 case Builtin::BI__builtin_isfinite: 793 case Builtin::BI__builtin_isinf: 794 case Builtin::BI__builtin_isinf_sign: 795 case Builtin::BI__builtin_isnan: 796 case Builtin::BI__builtin_isnormal: 797 if (SemaBuiltinFPClassification(TheCall, 1)) 798 return ExprError(); 799 break; 800 case Builtin::BI__builtin_shufflevector: 801 return SemaBuiltinShuffleVector(TheCall); 802 // TheCall will be freed by the smart pointer here, but that's fine, since 803 // SemaBuiltinShuffleVector guts it, but then doesn't release it. 804 case Builtin::BI__builtin_prefetch: 805 if (SemaBuiltinPrefetch(TheCall)) 806 return ExprError(); 807 break; 808 case Builtin::BI__builtin_alloca_with_align: 809 if (SemaBuiltinAllocaWithAlign(TheCall)) 810 return ExprError(); 811 break; 812 case Builtin::BI__assume: 813 case Builtin::BI__builtin_assume: 814 if (SemaBuiltinAssume(TheCall)) 815 return ExprError(); 816 break; 817 case Builtin::BI__builtin_assume_aligned: 818 if (SemaBuiltinAssumeAligned(TheCall)) 819 return ExprError(); 820 break; 821 case Builtin::BI__builtin_object_size: 822 if (SemaBuiltinConstantArgRange(TheCall, 1, 0, 3)) 823 return ExprError(); 824 break; 825 case Builtin::BI__builtin_longjmp: 826 if (SemaBuiltinLongjmp(TheCall)) 827 return ExprError(); 828 break; 829 case Builtin::BI__builtin_setjmp: 830 if (SemaBuiltinSetjmp(TheCall)) 831 return ExprError(); 832 break; 833 case Builtin::BI_setjmp: 834 case Builtin::BI_setjmpex: 835 if (checkArgCount(*this, TheCall, 1)) 836 return true; 837 break; 838 839 case Builtin::BI__builtin_classify_type: 840 if (checkArgCount(*this, TheCall, 1)) return true; 841 TheCall->setType(Context.IntTy); 842 break; 843 case Builtin::BI__builtin_constant_p: 844 if (checkArgCount(*this, TheCall, 1)) return true; 845 TheCall->setType(Context.IntTy); 846 break; 847 case Builtin::BI__sync_fetch_and_add: 848 case Builtin::BI__sync_fetch_and_add_1: 849 case Builtin::BI__sync_fetch_and_add_2: 850 case Builtin::BI__sync_fetch_and_add_4: 851 case Builtin::BI__sync_fetch_and_add_8: 852 case Builtin::BI__sync_fetch_and_add_16: 853 case Builtin::BI__sync_fetch_and_sub: 854 case Builtin::BI__sync_fetch_and_sub_1: 855 case Builtin::BI__sync_fetch_and_sub_2: 856 case Builtin::BI__sync_fetch_and_sub_4: 857 case Builtin::BI__sync_fetch_and_sub_8: 858 case Builtin::BI__sync_fetch_and_sub_16: 859 case Builtin::BI__sync_fetch_and_or: 860 case Builtin::BI__sync_fetch_and_or_1: 861 case Builtin::BI__sync_fetch_and_or_2: 862 case Builtin::BI__sync_fetch_and_or_4: 863 case Builtin::BI__sync_fetch_and_or_8: 864 case Builtin::BI__sync_fetch_and_or_16: 865 case Builtin::BI__sync_fetch_and_and: 866 case Builtin::BI__sync_fetch_and_and_1: 867 case Builtin::BI__sync_fetch_and_and_2: 868 case Builtin::BI__sync_fetch_and_and_4: 869 case Builtin::BI__sync_fetch_and_and_8: 870 case Builtin::BI__sync_fetch_and_and_16: 871 case Builtin::BI__sync_fetch_and_xor: 872 case Builtin::BI__sync_fetch_and_xor_1: 873 case Builtin::BI__sync_fetch_and_xor_2: 874 case Builtin::BI__sync_fetch_and_xor_4: 875 case Builtin::BI__sync_fetch_and_xor_8: 876 case Builtin::BI__sync_fetch_and_xor_16: 877 case Builtin::BI__sync_fetch_and_nand: 878 case Builtin::BI__sync_fetch_and_nand_1: 879 case Builtin::BI__sync_fetch_and_nand_2: 880 case Builtin::BI__sync_fetch_and_nand_4: 881 case Builtin::BI__sync_fetch_and_nand_8: 882 case Builtin::BI__sync_fetch_and_nand_16: 883 case Builtin::BI__sync_add_and_fetch: 884 case Builtin::BI__sync_add_and_fetch_1: 885 case Builtin::BI__sync_add_and_fetch_2: 886 case Builtin::BI__sync_add_and_fetch_4: 887 case Builtin::BI__sync_add_and_fetch_8: 888 case Builtin::BI__sync_add_and_fetch_16: 889 case Builtin::BI__sync_sub_and_fetch: 890 case Builtin::BI__sync_sub_and_fetch_1: 891 case Builtin::BI__sync_sub_and_fetch_2: 892 case Builtin::BI__sync_sub_and_fetch_4: 893 case Builtin::BI__sync_sub_and_fetch_8: 894 case Builtin::BI__sync_sub_and_fetch_16: 895 case Builtin::BI__sync_and_and_fetch: 896 case Builtin::BI__sync_and_and_fetch_1: 897 case Builtin::BI__sync_and_and_fetch_2: 898 case Builtin::BI__sync_and_and_fetch_4: 899 case Builtin::BI__sync_and_and_fetch_8: 900 case Builtin::BI__sync_and_and_fetch_16: 901 case Builtin::BI__sync_or_and_fetch: 902 case Builtin::BI__sync_or_and_fetch_1: 903 case Builtin::BI__sync_or_and_fetch_2: 904 case Builtin::BI__sync_or_and_fetch_4: 905 case Builtin::BI__sync_or_and_fetch_8: 906 case Builtin::BI__sync_or_and_fetch_16: 907 case Builtin::BI__sync_xor_and_fetch: 908 case Builtin::BI__sync_xor_and_fetch_1: 909 case Builtin::BI__sync_xor_and_fetch_2: 910 case Builtin::BI__sync_xor_and_fetch_4: 911 case Builtin::BI__sync_xor_and_fetch_8: 912 case Builtin::BI__sync_xor_and_fetch_16: 913 case Builtin::BI__sync_nand_and_fetch: 914 case Builtin::BI__sync_nand_and_fetch_1: 915 case Builtin::BI__sync_nand_and_fetch_2: 916 case Builtin::BI__sync_nand_and_fetch_4: 917 case Builtin::BI__sync_nand_and_fetch_8: 918 case Builtin::BI__sync_nand_and_fetch_16: 919 case Builtin::BI__sync_val_compare_and_swap: 920 case Builtin::BI__sync_val_compare_and_swap_1: 921 case Builtin::BI__sync_val_compare_and_swap_2: 922 case Builtin::BI__sync_val_compare_and_swap_4: 923 case Builtin::BI__sync_val_compare_and_swap_8: 924 case Builtin::BI__sync_val_compare_and_swap_16: 925 case Builtin::BI__sync_bool_compare_and_swap: 926 case Builtin::BI__sync_bool_compare_and_swap_1: 927 case Builtin::BI__sync_bool_compare_and_swap_2: 928 case Builtin::BI__sync_bool_compare_and_swap_4: 929 case Builtin::BI__sync_bool_compare_and_swap_8: 930 case Builtin::BI__sync_bool_compare_and_swap_16: 931 case Builtin::BI__sync_lock_test_and_set: 932 case Builtin::BI__sync_lock_test_and_set_1: 933 case Builtin::BI__sync_lock_test_and_set_2: 934 case Builtin::BI__sync_lock_test_and_set_4: 935 case Builtin::BI__sync_lock_test_and_set_8: 936 case Builtin::BI__sync_lock_test_and_set_16: 937 case Builtin::BI__sync_lock_release: 938 case Builtin::BI__sync_lock_release_1: 939 case Builtin::BI__sync_lock_release_2: 940 case Builtin::BI__sync_lock_release_4: 941 case Builtin::BI__sync_lock_release_8: 942 case Builtin::BI__sync_lock_release_16: 943 case Builtin::BI__sync_swap: 944 case Builtin::BI__sync_swap_1: 945 case Builtin::BI__sync_swap_2: 946 case Builtin::BI__sync_swap_4: 947 case Builtin::BI__sync_swap_8: 948 case Builtin::BI__sync_swap_16: 949 return SemaBuiltinAtomicOverloaded(TheCallResult); 950 case Builtin::BI__builtin_nontemporal_load: 951 case Builtin::BI__builtin_nontemporal_store: 952 return SemaBuiltinNontemporalOverloaded(TheCallResult); 953 #define BUILTIN(ID, TYPE, ATTRS) 954 #define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \ 955 case Builtin::BI##ID: \ 956 return SemaAtomicOpsOverloaded(TheCallResult, AtomicExpr::AO##ID); 957 #include "clang/Basic/Builtins.def" 958 case Builtin::BI__builtin_annotation: 959 if (SemaBuiltinAnnotation(*this, TheCall)) 960 return ExprError(); 961 break; 962 case Builtin::BI__builtin_addressof: 963 if (SemaBuiltinAddressof(*this, TheCall)) 964 return ExprError(); 965 break; 966 case Builtin::BI__builtin_add_overflow: 967 case Builtin::BI__builtin_sub_overflow: 968 case Builtin::BI__builtin_mul_overflow: 969 if (SemaBuiltinOverflow(*this, TheCall)) 970 return ExprError(); 971 break; 972 case Builtin::BI__builtin_operator_new: 973 case Builtin::BI__builtin_operator_delete: 974 if (!getLangOpts().CPlusPlus) { 975 Diag(TheCall->getExprLoc(), diag::err_builtin_requires_language) 976 << (BuiltinID == Builtin::BI__builtin_operator_new 977 ? "__builtin_operator_new" 978 : "__builtin_operator_delete") 979 << "C++"; 980 return ExprError(); 981 } 982 // CodeGen assumes it can find the global new and delete to call, 983 // so ensure that they are declared. 984 DeclareGlobalNewDelete(); 985 break; 986 987 // check secure string manipulation functions where overflows 988 // are detectable at compile time 989 case Builtin::BI__builtin___memcpy_chk: 990 case Builtin::BI__builtin___memmove_chk: 991 case Builtin::BI__builtin___memset_chk: 992 case Builtin::BI__builtin___strlcat_chk: 993 case Builtin::BI__builtin___strlcpy_chk: 994 case Builtin::BI__builtin___strncat_chk: 995 case Builtin::BI__builtin___strncpy_chk: 996 case Builtin::BI__builtin___stpncpy_chk: 997 SemaBuiltinMemChkCall(*this, FDecl, TheCall, 2, 3); 998 break; 999 case Builtin::BI__builtin___memccpy_chk: 1000 SemaBuiltinMemChkCall(*this, FDecl, TheCall, 3, 4); 1001 break; 1002 case Builtin::BI__builtin___snprintf_chk: 1003 case Builtin::BI__builtin___vsnprintf_chk: 1004 SemaBuiltinMemChkCall(*this, FDecl, TheCall, 1, 3); 1005 break; 1006 case Builtin::BI__builtin_call_with_static_chain: 1007 if (SemaBuiltinCallWithStaticChain(*this, TheCall)) 1008 return ExprError(); 1009 break; 1010 case Builtin::BI__exception_code: 1011 case Builtin::BI_exception_code: 1012 if (SemaBuiltinSEHScopeCheck(*this, TheCall, Scope::SEHExceptScope, 1013 diag::err_seh___except_block)) 1014 return ExprError(); 1015 break; 1016 case Builtin::BI__exception_info: 1017 case Builtin::BI_exception_info: 1018 if (SemaBuiltinSEHScopeCheck(*this, TheCall, Scope::SEHFilterScope, 1019 diag::err_seh___except_filter)) 1020 return ExprError(); 1021 break; 1022 case Builtin::BI__GetExceptionInfo: 1023 if (checkArgCount(*this, TheCall, 1)) 1024 return ExprError(); 1025 1026 if (CheckCXXThrowOperand( 1027 TheCall->getLocStart(), 1028 Context.getExceptionObjectType(FDecl->getParamDecl(0)->getType()), 1029 TheCall)) 1030 return ExprError(); 1031 1032 TheCall->setType(Context.VoidPtrTy); 1033 break; 1034 // OpenCL v2.0, s6.13.16 - Pipe functions 1035 case Builtin::BIread_pipe: 1036 case Builtin::BIwrite_pipe: 1037 // Since those two functions are declared with var args, we need a semantic 1038 // check for the argument. 1039 if (SemaBuiltinRWPipe(*this, TheCall)) 1040 return ExprError(); 1041 TheCall->setType(Context.IntTy); 1042 break; 1043 case Builtin::BIreserve_read_pipe: 1044 case Builtin::BIreserve_write_pipe: 1045 case Builtin::BIwork_group_reserve_read_pipe: 1046 case Builtin::BIwork_group_reserve_write_pipe: 1047 case Builtin::BIsub_group_reserve_read_pipe: 1048 case Builtin::BIsub_group_reserve_write_pipe: 1049 if (SemaBuiltinReserveRWPipe(*this, TheCall)) 1050 return ExprError(); 1051 // Since return type of reserve_read/write_pipe built-in function is 1052 // reserve_id_t, which is not defined in the builtin def file , we used int 1053 // as return type and need to override the return type of these functions. 1054 TheCall->setType(Context.OCLReserveIDTy); 1055 break; 1056 case Builtin::BIcommit_read_pipe: 1057 case Builtin::BIcommit_write_pipe: 1058 case Builtin::BIwork_group_commit_read_pipe: 1059 case Builtin::BIwork_group_commit_write_pipe: 1060 case Builtin::BIsub_group_commit_read_pipe: 1061 case Builtin::BIsub_group_commit_write_pipe: 1062 if (SemaBuiltinCommitRWPipe(*this, TheCall)) 1063 return ExprError(); 1064 break; 1065 case Builtin::BIget_pipe_num_packets: 1066 case Builtin::BIget_pipe_max_packets: 1067 if (SemaBuiltinPipePackets(*this, TheCall)) 1068 return ExprError(); 1069 TheCall->setType(Context.UnsignedIntTy); 1070 break; 1071 case Builtin::BIto_global: 1072 case Builtin::BIto_local: 1073 case Builtin::BIto_private: 1074 if (SemaOpenCLBuiltinToAddr(*this, BuiltinID, TheCall)) 1075 return ExprError(); 1076 break; 1077 // OpenCL v2.0, s6.13.17 - Enqueue kernel functions. 1078 case Builtin::BIenqueue_kernel: 1079 if (SemaOpenCLBuiltinEnqueueKernel(*this, TheCall)) 1080 return ExprError(); 1081 break; 1082 case Builtin::BIget_kernel_work_group_size: 1083 case Builtin::BIget_kernel_preferred_work_group_size_multiple: 1084 if (SemaOpenCLBuiltinKernelWorkGroupSize(*this, TheCall)) 1085 return ExprError(); 1086 break; 1087 case Builtin::BI__builtin_os_log_format: 1088 case Builtin::BI__builtin_os_log_format_buffer_size: 1089 if (SemaBuiltinOSLogFormat(TheCall)) { 1090 return ExprError(); 1091 } 1092 break; 1093 } 1094 1095 // Since the target specific builtins for each arch overlap, only check those 1096 // of the arch we are compiling for. 1097 if (Context.BuiltinInfo.isTSBuiltin(BuiltinID)) { 1098 switch (Context.getTargetInfo().getTriple().getArch()) { 1099 case llvm::Triple::arm: 1100 case llvm::Triple::armeb: 1101 case llvm::Triple::thumb: 1102 case llvm::Triple::thumbeb: 1103 if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 1104 return ExprError(); 1105 break; 1106 case llvm::Triple::aarch64: 1107 case llvm::Triple::aarch64_be: 1108 if (CheckAArch64BuiltinFunctionCall(BuiltinID, TheCall)) 1109 return ExprError(); 1110 break; 1111 case llvm::Triple::mips: 1112 case llvm::Triple::mipsel: 1113 case llvm::Triple::mips64: 1114 case llvm::Triple::mips64el: 1115 if (CheckMipsBuiltinFunctionCall(BuiltinID, TheCall)) 1116 return ExprError(); 1117 break; 1118 case llvm::Triple::systemz: 1119 if (CheckSystemZBuiltinFunctionCall(BuiltinID, TheCall)) 1120 return ExprError(); 1121 break; 1122 case llvm::Triple::x86: 1123 case llvm::Triple::x86_64: 1124 if (CheckX86BuiltinFunctionCall(BuiltinID, TheCall)) 1125 return ExprError(); 1126 break; 1127 case llvm::Triple::ppc: 1128 case llvm::Triple::ppc64: 1129 case llvm::Triple::ppc64le: 1130 if (CheckPPCBuiltinFunctionCall(BuiltinID, TheCall)) 1131 return ExprError(); 1132 break; 1133 default: 1134 break; 1135 } 1136 } 1137 1138 return TheCallResult; 1139 } 1140 1141 // Get the valid immediate range for the specified NEON type code. 1142 static unsigned RFT(unsigned t, bool shift = false, bool ForceQuad = false) { 1143 NeonTypeFlags Type(t); 1144 int IsQuad = ForceQuad ? true : Type.isQuad(); 1145 switch (Type.getEltType()) { 1146 case NeonTypeFlags::Int8: 1147 case NeonTypeFlags::Poly8: 1148 return shift ? 7 : (8 << IsQuad) - 1; 1149 case NeonTypeFlags::Int16: 1150 case NeonTypeFlags::Poly16: 1151 return shift ? 15 : (4 << IsQuad) - 1; 1152 case NeonTypeFlags::Int32: 1153 return shift ? 31 : (2 << IsQuad) - 1; 1154 case NeonTypeFlags::Int64: 1155 case NeonTypeFlags::Poly64: 1156 return shift ? 63 : (1 << IsQuad) - 1; 1157 case NeonTypeFlags::Poly128: 1158 return shift ? 127 : (1 << IsQuad) - 1; 1159 case NeonTypeFlags::Float16: 1160 assert(!shift && "cannot shift float types!"); 1161 return (4 << IsQuad) - 1; 1162 case NeonTypeFlags::Float32: 1163 assert(!shift && "cannot shift float types!"); 1164 return (2 << IsQuad) - 1; 1165 case NeonTypeFlags::Float64: 1166 assert(!shift && "cannot shift float types!"); 1167 return (1 << IsQuad) - 1; 1168 } 1169 llvm_unreachable("Invalid NeonTypeFlag!"); 1170 } 1171 1172 /// getNeonEltType - Return the QualType corresponding to the elements of 1173 /// the vector type specified by the NeonTypeFlags. This is used to check 1174 /// the pointer arguments for Neon load/store intrinsics. 1175 static QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context, 1176 bool IsPolyUnsigned, bool IsInt64Long) { 1177 switch (Flags.getEltType()) { 1178 case NeonTypeFlags::Int8: 1179 return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy; 1180 case NeonTypeFlags::Int16: 1181 return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy; 1182 case NeonTypeFlags::Int32: 1183 return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy; 1184 case NeonTypeFlags::Int64: 1185 if (IsInt64Long) 1186 return Flags.isUnsigned() ? Context.UnsignedLongTy : Context.LongTy; 1187 else 1188 return Flags.isUnsigned() ? Context.UnsignedLongLongTy 1189 : Context.LongLongTy; 1190 case NeonTypeFlags::Poly8: 1191 return IsPolyUnsigned ? Context.UnsignedCharTy : Context.SignedCharTy; 1192 case NeonTypeFlags::Poly16: 1193 return IsPolyUnsigned ? Context.UnsignedShortTy : Context.ShortTy; 1194 case NeonTypeFlags::Poly64: 1195 if (IsInt64Long) 1196 return Context.UnsignedLongTy; 1197 else 1198 return Context.UnsignedLongLongTy; 1199 case NeonTypeFlags::Poly128: 1200 break; 1201 case NeonTypeFlags::Float16: 1202 return Context.HalfTy; 1203 case NeonTypeFlags::Float32: 1204 return Context.FloatTy; 1205 case NeonTypeFlags::Float64: 1206 return Context.DoubleTy; 1207 } 1208 llvm_unreachable("Invalid NeonTypeFlag!"); 1209 } 1210 1211 bool Sema::CheckNeonBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 1212 llvm::APSInt Result; 1213 uint64_t mask = 0; 1214 unsigned TV = 0; 1215 int PtrArgNum = -1; 1216 bool HasConstPtr = false; 1217 switch (BuiltinID) { 1218 #define GET_NEON_OVERLOAD_CHECK 1219 #include "clang/Basic/arm_neon.inc" 1220 #undef GET_NEON_OVERLOAD_CHECK 1221 } 1222 1223 // For NEON intrinsics which are overloaded on vector element type, validate 1224 // the immediate which specifies which variant to emit. 1225 unsigned ImmArg = TheCall->getNumArgs()-1; 1226 if (mask) { 1227 if (SemaBuiltinConstantArg(TheCall, ImmArg, Result)) 1228 return true; 1229 1230 TV = Result.getLimitedValue(64); 1231 if ((TV > 63) || (mask & (1ULL << TV)) == 0) 1232 return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 1233 << TheCall->getArg(ImmArg)->getSourceRange(); 1234 } 1235 1236 if (PtrArgNum >= 0) { 1237 // Check that pointer arguments have the specified type. 1238 Expr *Arg = TheCall->getArg(PtrArgNum); 1239 if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) 1240 Arg = ICE->getSubExpr(); 1241 ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg); 1242 QualType RHSTy = RHS.get()->getType(); 1243 1244 llvm::Triple::ArchType Arch = Context.getTargetInfo().getTriple().getArch(); 1245 bool IsPolyUnsigned = Arch == llvm::Triple::aarch64 || 1246 Arch == llvm::Triple::aarch64_be; 1247 bool IsInt64Long = 1248 Context.getTargetInfo().getInt64Type() == TargetInfo::SignedLong; 1249 QualType EltTy = 1250 getNeonEltType(NeonTypeFlags(TV), Context, IsPolyUnsigned, IsInt64Long); 1251 if (HasConstPtr) 1252 EltTy = EltTy.withConst(); 1253 QualType LHSTy = Context.getPointerType(EltTy); 1254 AssignConvertType ConvTy; 1255 ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS); 1256 if (RHS.isInvalid()) 1257 return true; 1258 if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy, 1259 RHS.get(), AA_Assigning)) 1260 return true; 1261 } 1262 1263 // For NEON intrinsics which take an immediate value as part of the 1264 // instruction, range check them here. 1265 unsigned i = 0, l = 0, u = 0; 1266 switch (BuiltinID) { 1267 default: 1268 return false; 1269 #define GET_NEON_IMMEDIATE_CHECK 1270 #include "clang/Basic/arm_neon.inc" 1271 #undef GET_NEON_IMMEDIATE_CHECK 1272 } 1273 1274 return SemaBuiltinConstantArgRange(TheCall, i, l, u + l); 1275 } 1276 1277 bool Sema::CheckARMBuiltinExclusiveCall(unsigned BuiltinID, CallExpr *TheCall, 1278 unsigned MaxWidth) { 1279 assert((BuiltinID == ARM::BI__builtin_arm_ldrex || 1280 BuiltinID == ARM::BI__builtin_arm_ldaex || 1281 BuiltinID == ARM::BI__builtin_arm_strex || 1282 BuiltinID == ARM::BI__builtin_arm_stlex || 1283 BuiltinID == AArch64::BI__builtin_arm_ldrex || 1284 BuiltinID == AArch64::BI__builtin_arm_ldaex || 1285 BuiltinID == AArch64::BI__builtin_arm_strex || 1286 BuiltinID == AArch64::BI__builtin_arm_stlex) && 1287 "unexpected ARM builtin"); 1288 bool IsLdrex = BuiltinID == ARM::BI__builtin_arm_ldrex || 1289 BuiltinID == ARM::BI__builtin_arm_ldaex || 1290 BuiltinID == AArch64::BI__builtin_arm_ldrex || 1291 BuiltinID == AArch64::BI__builtin_arm_ldaex; 1292 1293 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 1294 1295 // Ensure that we have the proper number of arguments. 1296 if (checkArgCount(*this, TheCall, IsLdrex ? 1 : 2)) 1297 return true; 1298 1299 // Inspect the pointer argument of the atomic builtin. This should always be 1300 // a pointer type, whose element is an integral scalar or pointer type. 1301 // Because it is a pointer type, we don't have to worry about any implicit 1302 // casts here. 1303 Expr *PointerArg = TheCall->getArg(IsLdrex ? 0 : 1); 1304 ExprResult PointerArgRes = DefaultFunctionArrayLvalueConversion(PointerArg); 1305 if (PointerArgRes.isInvalid()) 1306 return true; 1307 PointerArg = PointerArgRes.get(); 1308 1309 const PointerType *pointerType = PointerArg->getType()->getAs<PointerType>(); 1310 if (!pointerType) { 1311 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 1312 << PointerArg->getType() << PointerArg->getSourceRange(); 1313 return true; 1314 } 1315 1316 // ldrex takes a "const volatile T*" and strex takes a "volatile T*". Our next 1317 // task is to insert the appropriate casts into the AST. First work out just 1318 // what the appropriate type is. 1319 QualType ValType = pointerType->getPointeeType(); 1320 QualType AddrType = ValType.getUnqualifiedType().withVolatile(); 1321 if (IsLdrex) 1322 AddrType.addConst(); 1323 1324 // Issue a warning if the cast is dodgy. 1325 CastKind CastNeeded = CK_NoOp; 1326 if (!AddrType.isAtLeastAsQualifiedAs(ValType)) { 1327 CastNeeded = CK_BitCast; 1328 Diag(DRE->getLocStart(), diag::ext_typecheck_convert_discards_qualifiers) 1329 << PointerArg->getType() 1330 << Context.getPointerType(AddrType) 1331 << AA_Passing << PointerArg->getSourceRange(); 1332 } 1333 1334 // Finally, do the cast and replace the argument with the corrected version. 1335 AddrType = Context.getPointerType(AddrType); 1336 PointerArgRes = ImpCastExprToType(PointerArg, AddrType, CastNeeded); 1337 if (PointerArgRes.isInvalid()) 1338 return true; 1339 PointerArg = PointerArgRes.get(); 1340 1341 TheCall->setArg(IsLdrex ? 0 : 1, PointerArg); 1342 1343 // In general, we allow ints, floats and pointers to be loaded and stored. 1344 if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 1345 !ValType->isBlockPointerType() && !ValType->isFloatingType()) { 1346 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intfltptr) 1347 << PointerArg->getType() << PointerArg->getSourceRange(); 1348 return true; 1349 } 1350 1351 // But ARM doesn't have instructions to deal with 128-bit versions. 1352 if (Context.getTypeSize(ValType) > MaxWidth) { 1353 assert(MaxWidth == 64 && "Diagnostic unexpectedly inaccurate"); 1354 Diag(DRE->getLocStart(), diag::err_atomic_exclusive_builtin_pointer_size) 1355 << PointerArg->getType() << PointerArg->getSourceRange(); 1356 return true; 1357 } 1358 1359 switch (ValType.getObjCLifetime()) { 1360 case Qualifiers::OCL_None: 1361 case Qualifiers::OCL_ExplicitNone: 1362 // okay 1363 break; 1364 1365 case Qualifiers::OCL_Weak: 1366 case Qualifiers::OCL_Strong: 1367 case Qualifiers::OCL_Autoreleasing: 1368 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 1369 << ValType << PointerArg->getSourceRange(); 1370 return true; 1371 } 1372 1373 if (IsLdrex) { 1374 TheCall->setType(ValType); 1375 return false; 1376 } 1377 1378 // Initialize the argument to be stored. 1379 ExprResult ValArg = TheCall->getArg(0); 1380 InitializedEntity Entity = InitializedEntity::InitializeParameter( 1381 Context, ValType, /*consume*/ false); 1382 ValArg = PerformCopyInitialization(Entity, SourceLocation(), ValArg); 1383 if (ValArg.isInvalid()) 1384 return true; 1385 TheCall->setArg(0, ValArg.get()); 1386 1387 // __builtin_arm_strex always returns an int. It's marked as such in the .def, 1388 // but the custom checker bypasses all default analysis. 1389 TheCall->setType(Context.IntTy); 1390 return false; 1391 } 1392 1393 bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 1394 if (BuiltinID == ARM::BI__builtin_arm_ldrex || 1395 BuiltinID == ARM::BI__builtin_arm_ldaex || 1396 BuiltinID == ARM::BI__builtin_arm_strex || 1397 BuiltinID == ARM::BI__builtin_arm_stlex) { 1398 return CheckARMBuiltinExclusiveCall(BuiltinID, TheCall, 64); 1399 } 1400 1401 if (BuiltinID == ARM::BI__builtin_arm_prefetch) { 1402 return SemaBuiltinConstantArgRange(TheCall, 1, 0, 1) || 1403 SemaBuiltinConstantArgRange(TheCall, 2, 0, 1); 1404 } 1405 1406 if (BuiltinID == ARM::BI__builtin_arm_rsr64 || 1407 BuiltinID == ARM::BI__builtin_arm_wsr64) 1408 return SemaBuiltinARMSpecialReg(BuiltinID, TheCall, 0, 3, false); 1409 1410 if (BuiltinID == ARM::BI__builtin_arm_rsr || 1411 BuiltinID == ARM::BI__builtin_arm_rsrp || 1412 BuiltinID == ARM::BI__builtin_arm_wsr || 1413 BuiltinID == ARM::BI__builtin_arm_wsrp) 1414 return SemaBuiltinARMSpecialReg(BuiltinID, TheCall, 0, 5, true); 1415 1416 if (CheckNeonBuiltinFunctionCall(BuiltinID, TheCall)) 1417 return true; 1418 1419 // For intrinsics which take an immediate value as part of the instruction, 1420 // range check them here. 1421 unsigned i = 0, l = 0, u = 0; 1422 switch (BuiltinID) { 1423 default: return false; 1424 case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 1425 case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 1426 case ARM::BI__builtin_arm_vcvtr_f: 1427 case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 1428 case ARM::BI__builtin_arm_dmb: 1429 case ARM::BI__builtin_arm_dsb: 1430 case ARM::BI__builtin_arm_isb: 1431 case ARM::BI__builtin_arm_dbg: l = 0; u = 15; break; 1432 } 1433 1434 // FIXME: VFP Intrinsics should error if VFP not present. 1435 return SemaBuiltinConstantArgRange(TheCall, i, l, u + l); 1436 } 1437 1438 bool Sema::CheckAArch64BuiltinFunctionCall(unsigned BuiltinID, 1439 CallExpr *TheCall) { 1440 if (BuiltinID == AArch64::BI__builtin_arm_ldrex || 1441 BuiltinID == AArch64::BI__builtin_arm_ldaex || 1442 BuiltinID == AArch64::BI__builtin_arm_strex || 1443 BuiltinID == AArch64::BI__builtin_arm_stlex) { 1444 return CheckARMBuiltinExclusiveCall(BuiltinID, TheCall, 128); 1445 } 1446 1447 if (BuiltinID == AArch64::BI__builtin_arm_prefetch) { 1448 return SemaBuiltinConstantArgRange(TheCall, 1, 0, 1) || 1449 SemaBuiltinConstantArgRange(TheCall, 2, 0, 2) || 1450 SemaBuiltinConstantArgRange(TheCall, 3, 0, 1) || 1451 SemaBuiltinConstantArgRange(TheCall, 4, 0, 1); 1452 } 1453 1454 if (BuiltinID == AArch64::BI__builtin_arm_rsr64 || 1455 BuiltinID == AArch64::BI__builtin_arm_wsr64) 1456 return SemaBuiltinARMSpecialReg(BuiltinID, TheCall, 0, 5, true); 1457 1458 if (BuiltinID == AArch64::BI__builtin_arm_rsr || 1459 BuiltinID == AArch64::BI__builtin_arm_rsrp || 1460 BuiltinID == AArch64::BI__builtin_arm_wsr || 1461 BuiltinID == AArch64::BI__builtin_arm_wsrp) 1462 return SemaBuiltinARMSpecialReg(BuiltinID, TheCall, 0, 5, true); 1463 1464 if (CheckNeonBuiltinFunctionCall(BuiltinID, TheCall)) 1465 return true; 1466 1467 // For intrinsics which take an immediate value as part of the instruction, 1468 // range check them here. 1469 unsigned i = 0, l = 0, u = 0; 1470 switch (BuiltinID) { 1471 default: return false; 1472 case AArch64::BI__builtin_arm_dmb: 1473 case AArch64::BI__builtin_arm_dsb: 1474 case AArch64::BI__builtin_arm_isb: l = 0; u = 15; break; 1475 } 1476 1477 return SemaBuiltinConstantArgRange(TheCall, i, l, u + l); 1478 } 1479 1480 // CheckMipsBuiltinFunctionCall - Checks the constant value passed to the 1481 // intrinsic is correct. The switch statement is ordered by DSP, MSA. The 1482 // ordering for DSP is unspecified. MSA is ordered by the data format used 1483 // by the underlying instruction i.e., df/m, df/n and then by size. 1484 // 1485 // FIXME: The size tests here should instead be tablegen'd along with the 1486 // definitions from include/clang/Basic/BuiltinsMips.def. 1487 // FIXME: GCC is strict on signedness for some of these intrinsics, we should 1488 // be too. 1489 bool Sema::CheckMipsBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 1490 unsigned i = 0, l = 0, u = 0, m = 0; 1491 switch (BuiltinID) { 1492 default: return false; 1493 case Mips::BI__builtin_mips_wrdsp: i = 1; l = 0; u = 63; break; 1494 case Mips::BI__builtin_mips_rddsp: i = 0; l = 0; u = 63; break; 1495 case Mips::BI__builtin_mips_append: i = 2; l = 0; u = 31; break; 1496 case Mips::BI__builtin_mips_balign: i = 2; l = 0; u = 3; break; 1497 case Mips::BI__builtin_mips_precr_sra_ph_w: i = 2; l = 0; u = 31; break; 1498 case Mips::BI__builtin_mips_precr_sra_r_ph_w: i = 2; l = 0; u = 31; break; 1499 case Mips::BI__builtin_mips_prepend: i = 2; l = 0; u = 31; break; 1500 // MSA instrinsics. Instructions (which the intrinsics maps to) which use the 1501 // df/m field. 1502 // These intrinsics take an unsigned 3 bit immediate. 1503 case Mips::BI__builtin_msa_bclri_b: 1504 case Mips::BI__builtin_msa_bnegi_b: 1505 case Mips::BI__builtin_msa_bseti_b: 1506 case Mips::BI__builtin_msa_sat_s_b: 1507 case Mips::BI__builtin_msa_sat_u_b: 1508 case Mips::BI__builtin_msa_slli_b: 1509 case Mips::BI__builtin_msa_srai_b: 1510 case Mips::BI__builtin_msa_srari_b: 1511 case Mips::BI__builtin_msa_srli_b: 1512 case Mips::BI__builtin_msa_srlri_b: i = 1; l = 0; u = 7; break; 1513 case Mips::BI__builtin_msa_binsli_b: 1514 case Mips::BI__builtin_msa_binsri_b: i = 2; l = 0; u = 7; break; 1515 // These intrinsics take an unsigned 4 bit immediate. 1516 case Mips::BI__builtin_msa_bclri_h: 1517 case Mips::BI__builtin_msa_bnegi_h: 1518 case Mips::BI__builtin_msa_bseti_h: 1519 case Mips::BI__builtin_msa_sat_s_h: 1520 case Mips::BI__builtin_msa_sat_u_h: 1521 case Mips::BI__builtin_msa_slli_h: 1522 case Mips::BI__builtin_msa_srai_h: 1523 case Mips::BI__builtin_msa_srari_h: 1524 case Mips::BI__builtin_msa_srli_h: 1525 case Mips::BI__builtin_msa_srlri_h: i = 1; l = 0; u = 15; break; 1526 case Mips::BI__builtin_msa_binsli_h: 1527 case Mips::BI__builtin_msa_binsri_h: i = 2; l = 0; u = 15; break; 1528 // These intrinsics take an unsigned 5 bit immedate. 1529 // The first block of intrinsics actually have an unsigned 5 bit field, 1530 // not a df/n field. 1531 case Mips::BI__builtin_msa_clei_u_b: 1532 case Mips::BI__builtin_msa_clei_u_h: 1533 case Mips::BI__builtin_msa_clei_u_w: 1534 case Mips::BI__builtin_msa_clei_u_d: 1535 case Mips::BI__builtin_msa_clti_u_b: 1536 case Mips::BI__builtin_msa_clti_u_h: 1537 case Mips::BI__builtin_msa_clti_u_w: 1538 case Mips::BI__builtin_msa_clti_u_d: 1539 case Mips::BI__builtin_msa_maxi_u_b: 1540 case Mips::BI__builtin_msa_maxi_u_h: 1541 case Mips::BI__builtin_msa_maxi_u_w: 1542 case Mips::BI__builtin_msa_maxi_u_d: 1543 case Mips::BI__builtin_msa_mini_u_b: 1544 case Mips::BI__builtin_msa_mini_u_h: 1545 case Mips::BI__builtin_msa_mini_u_w: 1546 case Mips::BI__builtin_msa_mini_u_d: 1547 case Mips::BI__builtin_msa_addvi_b: 1548 case Mips::BI__builtin_msa_addvi_h: 1549 case Mips::BI__builtin_msa_addvi_w: 1550 case Mips::BI__builtin_msa_addvi_d: 1551 case Mips::BI__builtin_msa_bclri_w: 1552 case Mips::BI__builtin_msa_bnegi_w: 1553 case Mips::BI__builtin_msa_bseti_w: 1554 case Mips::BI__builtin_msa_sat_s_w: 1555 case Mips::BI__builtin_msa_sat_u_w: 1556 case Mips::BI__builtin_msa_slli_w: 1557 case Mips::BI__builtin_msa_srai_w: 1558 case Mips::BI__builtin_msa_srari_w: 1559 case Mips::BI__builtin_msa_srli_w: 1560 case Mips::BI__builtin_msa_srlri_w: 1561 case Mips::BI__builtin_msa_subvi_b: 1562 case Mips::BI__builtin_msa_subvi_h: 1563 case Mips::BI__builtin_msa_subvi_w: 1564 case Mips::BI__builtin_msa_subvi_d: i = 1; l = 0; u = 31; break; 1565 case Mips::BI__builtin_msa_binsli_w: 1566 case Mips::BI__builtin_msa_binsri_w: i = 2; l = 0; u = 31; break; 1567 // These intrinsics take an unsigned 6 bit immediate. 1568 case Mips::BI__builtin_msa_bclri_d: 1569 case Mips::BI__builtin_msa_bnegi_d: 1570 case Mips::BI__builtin_msa_bseti_d: 1571 case Mips::BI__builtin_msa_sat_s_d: 1572 case Mips::BI__builtin_msa_sat_u_d: 1573 case Mips::BI__builtin_msa_slli_d: 1574 case Mips::BI__builtin_msa_srai_d: 1575 case Mips::BI__builtin_msa_srari_d: 1576 case Mips::BI__builtin_msa_srli_d: 1577 case Mips::BI__builtin_msa_srlri_d: i = 1; l = 0; u = 63; break; 1578 case Mips::BI__builtin_msa_binsli_d: 1579 case Mips::BI__builtin_msa_binsri_d: i = 2; l = 0; u = 63; break; 1580 // These intrinsics take a signed 5 bit immediate. 1581 case Mips::BI__builtin_msa_ceqi_b: 1582 case Mips::BI__builtin_msa_ceqi_h: 1583 case Mips::BI__builtin_msa_ceqi_w: 1584 case Mips::BI__builtin_msa_ceqi_d: 1585 case Mips::BI__builtin_msa_clti_s_b: 1586 case Mips::BI__builtin_msa_clti_s_h: 1587 case Mips::BI__builtin_msa_clti_s_w: 1588 case Mips::BI__builtin_msa_clti_s_d: 1589 case Mips::BI__builtin_msa_clei_s_b: 1590 case Mips::BI__builtin_msa_clei_s_h: 1591 case Mips::BI__builtin_msa_clei_s_w: 1592 case Mips::BI__builtin_msa_clei_s_d: 1593 case Mips::BI__builtin_msa_maxi_s_b: 1594 case Mips::BI__builtin_msa_maxi_s_h: 1595 case Mips::BI__builtin_msa_maxi_s_w: 1596 case Mips::BI__builtin_msa_maxi_s_d: 1597 case Mips::BI__builtin_msa_mini_s_b: 1598 case Mips::BI__builtin_msa_mini_s_h: 1599 case Mips::BI__builtin_msa_mini_s_w: 1600 case Mips::BI__builtin_msa_mini_s_d: i = 1; l = -16; u = 15; break; 1601 // These intrinsics take an unsigned 8 bit immediate. 1602 case Mips::BI__builtin_msa_andi_b: 1603 case Mips::BI__builtin_msa_nori_b: 1604 case Mips::BI__builtin_msa_ori_b: 1605 case Mips::BI__builtin_msa_shf_b: 1606 case Mips::BI__builtin_msa_shf_h: 1607 case Mips::BI__builtin_msa_shf_w: 1608 case Mips::BI__builtin_msa_xori_b: i = 1; l = 0; u = 255; break; 1609 case Mips::BI__builtin_msa_bseli_b: 1610 case Mips::BI__builtin_msa_bmnzi_b: 1611 case Mips::BI__builtin_msa_bmzi_b: i = 2; l = 0; u = 255; break; 1612 // df/n format 1613 // These intrinsics take an unsigned 4 bit immediate. 1614 case Mips::BI__builtin_msa_copy_s_b: 1615 case Mips::BI__builtin_msa_copy_u_b: 1616 case Mips::BI__builtin_msa_insve_b: 1617 case Mips::BI__builtin_msa_splati_b: i = 1; l = 0; u = 15; break; 1618 case Mips::BI__builtin_msa_sldi_b: i = 2; l = 0; u = 15; break; 1619 // These intrinsics take an unsigned 3 bit immediate. 1620 case Mips::BI__builtin_msa_copy_s_h: 1621 case Mips::BI__builtin_msa_copy_u_h: 1622 case Mips::BI__builtin_msa_insve_h: 1623 case Mips::BI__builtin_msa_splati_h: i = 1; l = 0; u = 7; break; 1624 case Mips::BI__builtin_msa_sldi_h: i = 2; l = 0; u = 7; break; 1625 // These intrinsics take an unsigned 2 bit immediate. 1626 case Mips::BI__builtin_msa_copy_s_w: 1627 case Mips::BI__builtin_msa_copy_u_w: 1628 case Mips::BI__builtin_msa_insve_w: 1629 case Mips::BI__builtin_msa_splati_w: i = 1; l = 0; u = 3; break; 1630 case Mips::BI__builtin_msa_sldi_w: i = 2; l = 0; u = 3; break; 1631 // These intrinsics take an unsigned 1 bit immediate. 1632 case Mips::BI__builtin_msa_copy_s_d: 1633 case Mips::BI__builtin_msa_copy_u_d: 1634 case Mips::BI__builtin_msa_insve_d: 1635 case Mips::BI__builtin_msa_splati_d: i = 1; l = 0; u = 1; break; 1636 case Mips::BI__builtin_msa_sldi_d: i = 2; l = 0; u = 1; break; 1637 // Memory offsets and immediate loads. 1638 // These intrinsics take a signed 10 bit immediate. 1639 case Mips::BI__builtin_msa_ldi_b: i = 0; l = -128; u = 255; break; 1640 case Mips::BI__builtin_msa_ldi_h: 1641 case Mips::BI__builtin_msa_ldi_w: 1642 case Mips::BI__builtin_msa_ldi_d: i = 0; l = -512; u = 511; break; 1643 case Mips::BI__builtin_msa_ld_b: i = 1; l = -512; u = 511; m = 16; break; 1644 case Mips::BI__builtin_msa_ld_h: i = 1; l = -1024; u = 1022; m = 16; break; 1645 case Mips::BI__builtin_msa_ld_w: i = 1; l = -2048; u = 2044; m = 16; break; 1646 case Mips::BI__builtin_msa_ld_d: i = 1; l = -4096; u = 4088; m = 16; break; 1647 case Mips::BI__builtin_msa_st_b: i = 2; l = -512; u = 511; m = 16; break; 1648 case Mips::BI__builtin_msa_st_h: i = 2; l = -1024; u = 1022; m = 16; break; 1649 case Mips::BI__builtin_msa_st_w: i = 2; l = -2048; u = 2044; m = 16; break; 1650 case Mips::BI__builtin_msa_st_d: i = 2; l = -4096; u = 4088; m = 16; break; 1651 } 1652 1653 if (!m) 1654 return SemaBuiltinConstantArgRange(TheCall, i, l, u); 1655 1656 return SemaBuiltinConstantArgRange(TheCall, i, l, u) || 1657 SemaBuiltinConstantArgMultiple(TheCall, i, m); 1658 } 1659 1660 bool Sema::CheckPPCBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 1661 unsigned i = 0, l = 0, u = 0; 1662 bool Is64BitBltin = BuiltinID == PPC::BI__builtin_divde || 1663 BuiltinID == PPC::BI__builtin_divdeu || 1664 BuiltinID == PPC::BI__builtin_bpermd; 1665 bool IsTarget64Bit = Context.getTargetInfo() 1666 .getTypeWidth(Context 1667 .getTargetInfo() 1668 .getIntPtrType()) == 64; 1669 bool IsBltinExtDiv = BuiltinID == PPC::BI__builtin_divwe || 1670 BuiltinID == PPC::BI__builtin_divweu || 1671 BuiltinID == PPC::BI__builtin_divde || 1672 BuiltinID == PPC::BI__builtin_divdeu; 1673 1674 if (Is64BitBltin && !IsTarget64Bit) 1675 return Diag(TheCall->getLocStart(), diag::err_64_bit_builtin_32_bit_tgt) 1676 << TheCall->getSourceRange(); 1677 1678 if ((IsBltinExtDiv && !Context.getTargetInfo().hasFeature("extdiv")) || 1679 (BuiltinID == PPC::BI__builtin_bpermd && 1680 !Context.getTargetInfo().hasFeature("bpermd"))) 1681 return Diag(TheCall->getLocStart(), diag::err_ppc_builtin_only_on_pwr7) 1682 << TheCall->getSourceRange(); 1683 1684 switch (BuiltinID) { 1685 default: return false; 1686 case PPC::BI__builtin_altivec_crypto_vshasigmaw: 1687 case PPC::BI__builtin_altivec_crypto_vshasigmad: 1688 return SemaBuiltinConstantArgRange(TheCall, 1, 0, 1) || 1689 SemaBuiltinConstantArgRange(TheCall, 2, 0, 15); 1690 case PPC::BI__builtin_tbegin: 1691 case PPC::BI__builtin_tend: i = 0; l = 0; u = 1; break; 1692 case PPC::BI__builtin_tsr: i = 0; l = 0; u = 7; break; 1693 case PPC::BI__builtin_tabortwc: 1694 case PPC::BI__builtin_tabortdc: i = 0; l = 0; u = 31; break; 1695 case PPC::BI__builtin_tabortwci: 1696 case PPC::BI__builtin_tabortdci: 1697 return SemaBuiltinConstantArgRange(TheCall, 0, 0, 31) || 1698 SemaBuiltinConstantArgRange(TheCall, 2, 0, 31); 1699 } 1700 return SemaBuiltinConstantArgRange(TheCall, i, l, u); 1701 } 1702 1703 bool Sema::CheckSystemZBuiltinFunctionCall(unsigned BuiltinID, 1704 CallExpr *TheCall) { 1705 if (BuiltinID == SystemZ::BI__builtin_tabort) { 1706 Expr *Arg = TheCall->getArg(0); 1707 llvm::APSInt AbortCode(32); 1708 if (Arg->isIntegerConstantExpr(AbortCode, Context) && 1709 AbortCode.getSExtValue() >= 0 && AbortCode.getSExtValue() < 256) 1710 return Diag(Arg->getLocStart(), diag::err_systemz_invalid_tabort_code) 1711 << Arg->getSourceRange(); 1712 } 1713 1714 // For intrinsics which take an immediate value as part of the instruction, 1715 // range check them here. 1716 unsigned i = 0, l = 0, u = 0; 1717 switch (BuiltinID) { 1718 default: return false; 1719 case SystemZ::BI__builtin_s390_lcbb: i = 1; l = 0; u = 15; break; 1720 case SystemZ::BI__builtin_s390_verimb: 1721 case SystemZ::BI__builtin_s390_verimh: 1722 case SystemZ::BI__builtin_s390_verimf: 1723 case SystemZ::BI__builtin_s390_verimg: i = 3; l = 0; u = 255; break; 1724 case SystemZ::BI__builtin_s390_vfaeb: 1725 case SystemZ::BI__builtin_s390_vfaeh: 1726 case SystemZ::BI__builtin_s390_vfaef: 1727 case SystemZ::BI__builtin_s390_vfaebs: 1728 case SystemZ::BI__builtin_s390_vfaehs: 1729 case SystemZ::BI__builtin_s390_vfaefs: 1730 case SystemZ::BI__builtin_s390_vfaezb: 1731 case SystemZ::BI__builtin_s390_vfaezh: 1732 case SystemZ::BI__builtin_s390_vfaezf: 1733 case SystemZ::BI__builtin_s390_vfaezbs: 1734 case SystemZ::BI__builtin_s390_vfaezhs: 1735 case SystemZ::BI__builtin_s390_vfaezfs: i = 2; l = 0; u = 15; break; 1736 case SystemZ::BI__builtin_s390_vfidb: 1737 return SemaBuiltinConstantArgRange(TheCall, 1, 0, 15) || 1738 SemaBuiltinConstantArgRange(TheCall, 2, 0, 15); 1739 case SystemZ::BI__builtin_s390_vftcidb: i = 1; l = 0; u = 4095; break; 1740 case SystemZ::BI__builtin_s390_vlbb: i = 1; l = 0; u = 15; break; 1741 case SystemZ::BI__builtin_s390_vpdi: i = 2; l = 0; u = 15; break; 1742 case SystemZ::BI__builtin_s390_vsldb: i = 2; l = 0; u = 15; break; 1743 case SystemZ::BI__builtin_s390_vstrcb: 1744 case SystemZ::BI__builtin_s390_vstrch: 1745 case SystemZ::BI__builtin_s390_vstrcf: 1746 case SystemZ::BI__builtin_s390_vstrczb: 1747 case SystemZ::BI__builtin_s390_vstrczh: 1748 case SystemZ::BI__builtin_s390_vstrczf: 1749 case SystemZ::BI__builtin_s390_vstrcbs: 1750 case SystemZ::BI__builtin_s390_vstrchs: 1751 case SystemZ::BI__builtin_s390_vstrcfs: 1752 case SystemZ::BI__builtin_s390_vstrczbs: 1753 case SystemZ::BI__builtin_s390_vstrczhs: 1754 case SystemZ::BI__builtin_s390_vstrczfs: i = 3; l = 0; u = 15; break; 1755 } 1756 return SemaBuiltinConstantArgRange(TheCall, i, l, u); 1757 } 1758 1759 /// SemaBuiltinCpuSupports - Handle __builtin_cpu_supports(char *). 1760 /// This checks that the target supports __builtin_cpu_supports and 1761 /// that the string argument is constant and valid. 1762 static bool SemaBuiltinCpuSupports(Sema &S, CallExpr *TheCall) { 1763 Expr *Arg = TheCall->getArg(0); 1764 1765 // Check if the argument is a string literal. 1766 if (!isa<StringLiteral>(Arg->IgnoreParenImpCasts())) 1767 return S.Diag(TheCall->getLocStart(), diag::err_expr_not_string_literal) 1768 << Arg->getSourceRange(); 1769 1770 // Check the contents of the string. 1771 StringRef Feature = 1772 cast<StringLiteral>(Arg->IgnoreParenImpCasts())->getString(); 1773 if (!S.Context.getTargetInfo().validateCpuSupports(Feature)) 1774 return S.Diag(TheCall->getLocStart(), diag::err_invalid_cpu_supports) 1775 << Arg->getSourceRange(); 1776 return false; 1777 } 1778 1779 // Check if the rounding mode is legal. 1780 bool Sema::CheckX86BuiltinRoundingOrSAE(unsigned BuiltinID, CallExpr *TheCall) { 1781 // Indicates if this instruction has rounding control or just SAE. 1782 bool HasRC = false; 1783 1784 unsigned ArgNum = 0; 1785 switch (BuiltinID) { 1786 default: 1787 return false; 1788 case X86::BI__builtin_ia32_vcvttsd2si32: 1789 case X86::BI__builtin_ia32_vcvttsd2si64: 1790 case X86::BI__builtin_ia32_vcvttsd2usi32: 1791 case X86::BI__builtin_ia32_vcvttsd2usi64: 1792 case X86::BI__builtin_ia32_vcvttss2si32: 1793 case X86::BI__builtin_ia32_vcvttss2si64: 1794 case X86::BI__builtin_ia32_vcvttss2usi32: 1795 case X86::BI__builtin_ia32_vcvttss2usi64: 1796 ArgNum = 1; 1797 break; 1798 case X86::BI__builtin_ia32_cvtps2pd512_mask: 1799 case X86::BI__builtin_ia32_cvttpd2dq512_mask: 1800 case X86::BI__builtin_ia32_cvttpd2qq512_mask: 1801 case X86::BI__builtin_ia32_cvttpd2udq512_mask: 1802 case X86::BI__builtin_ia32_cvttpd2uqq512_mask: 1803 case X86::BI__builtin_ia32_cvttps2dq512_mask: 1804 case X86::BI__builtin_ia32_cvttps2qq512_mask: 1805 case X86::BI__builtin_ia32_cvttps2udq512_mask: 1806 case X86::BI__builtin_ia32_cvttps2uqq512_mask: 1807 case X86::BI__builtin_ia32_exp2pd_mask: 1808 case X86::BI__builtin_ia32_exp2ps_mask: 1809 case X86::BI__builtin_ia32_getexppd512_mask: 1810 case X86::BI__builtin_ia32_getexpps512_mask: 1811 case X86::BI__builtin_ia32_rcp28pd_mask: 1812 case X86::BI__builtin_ia32_rcp28ps_mask: 1813 case X86::BI__builtin_ia32_rsqrt28pd_mask: 1814 case X86::BI__builtin_ia32_rsqrt28ps_mask: 1815 case X86::BI__builtin_ia32_vcomisd: 1816 case X86::BI__builtin_ia32_vcomiss: 1817 case X86::BI__builtin_ia32_vcvtph2ps512_mask: 1818 ArgNum = 3; 1819 break; 1820 case X86::BI__builtin_ia32_cmppd512_mask: 1821 case X86::BI__builtin_ia32_cmpps512_mask: 1822 case X86::BI__builtin_ia32_cmpsd_mask: 1823 case X86::BI__builtin_ia32_cmpss_mask: 1824 case X86::BI__builtin_ia32_cvtss2sd_round_mask: 1825 case X86::BI__builtin_ia32_getexpsd128_round_mask: 1826 case X86::BI__builtin_ia32_getexpss128_round_mask: 1827 case X86::BI__builtin_ia32_maxpd512_mask: 1828 case X86::BI__builtin_ia32_maxps512_mask: 1829 case X86::BI__builtin_ia32_maxsd_round_mask: 1830 case X86::BI__builtin_ia32_maxss_round_mask: 1831 case X86::BI__builtin_ia32_minpd512_mask: 1832 case X86::BI__builtin_ia32_minps512_mask: 1833 case X86::BI__builtin_ia32_minsd_round_mask: 1834 case X86::BI__builtin_ia32_minss_round_mask: 1835 case X86::BI__builtin_ia32_rcp28sd_round_mask: 1836 case X86::BI__builtin_ia32_rcp28ss_round_mask: 1837 case X86::BI__builtin_ia32_reducepd512_mask: 1838 case X86::BI__builtin_ia32_reduceps512_mask: 1839 case X86::BI__builtin_ia32_rndscalepd_mask: 1840 case X86::BI__builtin_ia32_rndscaleps_mask: 1841 case X86::BI__builtin_ia32_rsqrt28sd_round_mask: 1842 case X86::BI__builtin_ia32_rsqrt28ss_round_mask: 1843 ArgNum = 4; 1844 break; 1845 case X86::BI__builtin_ia32_fixupimmpd512_mask: 1846 case X86::BI__builtin_ia32_fixupimmpd512_maskz: 1847 case X86::BI__builtin_ia32_fixupimmps512_mask: 1848 case X86::BI__builtin_ia32_fixupimmps512_maskz: 1849 case X86::BI__builtin_ia32_fixupimmsd_mask: 1850 case X86::BI__builtin_ia32_fixupimmsd_maskz: 1851 case X86::BI__builtin_ia32_fixupimmss_mask: 1852 case X86::BI__builtin_ia32_fixupimmss_maskz: 1853 case X86::BI__builtin_ia32_rangepd512_mask: 1854 case X86::BI__builtin_ia32_rangeps512_mask: 1855 case X86::BI__builtin_ia32_rangesd128_round_mask: 1856 case X86::BI__builtin_ia32_rangess128_round_mask: 1857 case X86::BI__builtin_ia32_reducesd_mask: 1858 case X86::BI__builtin_ia32_reducess_mask: 1859 case X86::BI__builtin_ia32_rndscalesd_round_mask: 1860 case X86::BI__builtin_ia32_rndscaless_round_mask: 1861 ArgNum = 5; 1862 break; 1863 case X86::BI__builtin_ia32_vcvtsd2si64: 1864 case X86::BI__builtin_ia32_vcvtsd2si32: 1865 case X86::BI__builtin_ia32_vcvtsd2usi32: 1866 case X86::BI__builtin_ia32_vcvtsd2usi64: 1867 case X86::BI__builtin_ia32_vcvtss2si32: 1868 case X86::BI__builtin_ia32_vcvtss2si64: 1869 case X86::BI__builtin_ia32_vcvtss2usi32: 1870 case X86::BI__builtin_ia32_vcvtss2usi64: 1871 ArgNum = 1; 1872 HasRC = true; 1873 break; 1874 case X86::BI__builtin_ia32_cvtsi2sd64: 1875 case X86::BI__builtin_ia32_cvtsi2ss32: 1876 case X86::BI__builtin_ia32_cvtsi2ss64: 1877 case X86::BI__builtin_ia32_cvtusi2sd64: 1878 case X86::BI__builtin_ia32_cvtusi2ss32: 1879 case X86::BI__builtin_ia32_cvtusi2ss64: 1880 ArgNum = 2; 1881 HasRC = true; 1882 break; 1883 case X86::BI__builtin_ia32_cvtdq2ps512_mask: 1884 case X86::BI__builtin_ia32_cvtudq2ps512_mask: 1885 case X86::BI__builtin_ia32_cvtpd2ps512_mask: 1886 case X86::BI__builtin_ia32_cvtpd2qq512_mask: 1887 case X86::BI__builtin_ia32_cvtpd2uqq512_mask: 1888 case X86::BI__builtin_ia32_cvtps2qq512_mask: 1889 case X86::BI__builtin_ia32_cvtps2uqq512_mask: 1890 case X86::BI__builtin_ia32_cvtqq2pd512_mask: 1891 case X86::BI__builtin_ia32_cvtqq2ps512_mask: 1892 case X86::BI__builtin_ia32_cvtuqq2pd512_mask: 1893 case X86::BI__builtin_ia32_cvtuqq2ps512_mask: 1894 case X86::BI__builtin_ia32_sqrtpd512_mask: 1895 case X86::BI__builtin_ia32_sqrtps512_mask: 1896 ArgNum = 3; 1897 HasRC = true; 1898 break; 1899 case X86::BI__builtin_ia32_addpd512_mask: 1900 case X86::BI__builtin_ia32_addps512_mask: 1901 case X86::BI__builtin_ia32_divpd512_mask: 1902 case X86::BI__builtin_ia32_divps512_mask: 1903 case X86::BI__builtin_ia32_mulpd512_mask: 1904 case X86::BI__builtin_ia32_mulps512_mask: 1905 case X86::BI__builtin_ia32_subpd512_mask: 1906 case X86::BI__builtin_ia32_subps512_mask: 1907 case X86::BI__builtin_ia32_addss_round_mask: 1908 case X86::BI__builtin_ia32_addsd_round_mask: 1909 case X86::BI__builtin_ia32_divss_round_mask: 1910 case X86::BI__builtin_ia32_divsd_round_mask: 1911 case X86::BI__builtin_ia32_mulss_round_mask: 1912 case X86::BI__builtin_ia32_mulsd_round_mask: 1913 case X86::BI__builtin_ia32_subss_round_mask: 1914 case X86::BI__builtin_ia32_subsd_round_mask: 1915 case X86::BI__builtin_ia32_scalefpd512_mask: 1916 case X86::BI__builtin_ia32_scalefps512_mask: 1917 case X86::BI__builtin_ia32_scalefsd_round_mask: 1918 case X86::BI__builtin_ia32_scalefss_round_mask: 1919 case X86::BI__builtin_ia32_getmantpd512_mask: 1920 case X86::BI__builtin_ia32_getmantps512_mask: 1921 case X86::BI__builtin_ia32_cvtsd2ss_round_mask: 1922 case X86::BI__builtin_ia32_sqrtsd_round_mask: 1923 case X86::BI__builtin_ia32_sqrtss_round_mask: 1924 case X86::BI__builtin_ia32_vfmaddpd512_mask: 1925 case X86::BI__builtin_ia32_vfmaddpd512_mask3: 1926 case X86::BI__builtin_ia32_vfmaddpd512_maskz: 1927 case X86::BI__builtin_ia32_vfmaddps512_mask: 1928 case X86::BI__builtin_ia32_vfmaddps512_mask3: 1929 case X86::BI__builtin_ia32_vfmaddps512_maskz: 1930 case X86::BI__builtin_ia32_vfmaddsubpd512_mask: 1931 case X86::BI__builtin_ia32_vfmaddsubpd512_mask3: 1932 case X86::BI__builtin_ia32_vfmaddsubpd512_maskz: 1933 case X86::BI__builtin_ia32_vfmaddsubps512_mask: 1934 case X86::BI__builtin_ia32_vfmaddsubps512_mask3: 1935 case X86::BI__builtin_ia32_vfmaddsubps512_maskz: 1936 case X86::BI__builtin_ia32_vfmsubpd512_mask3: 1937 case X86::BI__builtin_ia32_vfmsubps512_mask3: 1938 case X86::BI__builtin_ia32_vfmsubaddpd512_mask3: 1939 case X86::BI__builtin_ia32_vfmsubaddps512_mask3: 1940 case X86::BI__builtin_ia32_vfnmaddpd512_mask: 1941 case X86::BI__builtin_ia32_vfnmaddps512_mask: 1942 case X86::BI__builtin_ia32_vfnmsubpd512_mask: 1943 case X86::BI__builtin_ia32_vfnmsubpd512_mask3: 1944 case X86::BI__builtin_ia32_vfnmsubps512_mask: 1945 case X86::BI__builtin_ia32_vfnmsubps512_mask3: 1946 case X86::BI__builtin_ia32_vfmaddsd3_mask: 1947 case X86::BI__builtin_ia32_vfmaddsd3_maskz: 1948 case X86::BI__builtin_ia32_vfmaddsd3_mask3: 1949 case X86::BI__builtin_ia32_vfmaddss3_mask: 1950 case X86::BI__builtin_ia32_vfmaddss3_maskz: 1951 case X86::BI__builtin_ia32_vfmaddss3_mask3: 1952 ArgNum = 4; 1953 HasRC = true; 1954 break; 1955 case X86::BI__builtin_ia32_getmantsd_round_mask: 1956 case X86::BI__builtin_ia32_getmantss_round_mask: 1957 ArgNum = 5; 1958 HasRC = true; 1959 break; 1960 } 1961 1962 llvm::APSInt Result; 1963 1964 // We can't check the value of a dependent argument. 1965 Expr *Arg = TheCall->getArg(ArgNum); 1966 if (Arg->isTypeDependent() || Arg->isValueDependent()) 1967 return false; 1968 1969 // Check constant-ness first. 1970 if (SemaBuiltinConstantArg(TheCall, ArgNum, Result)) 1971 return true; 1972 1973 // Make sure rounding mode is either ROUND_CUR_DIRECTION or ROUND_NO_EXC bit 1974 // is set. If the intrinsic has rounding control(bits 1:0), make sure its only 1975 // combined with ROUND_NO_EXC. 1976 if (Result == 4/*ROUND_CUR_DIRECTION*/ || 1977 Result == 8/*ROUND_NO_EXC*/ || 1978 (HasRC && Result.getZExtValue() >= 8 && Result.getZExtValue() <= 11)) 1979 return false; 1980 1981 return Diag(TheCall->getLocStart(), diag::err_x86_builtin_invalid_rounding) 1982 << Arg->getSourceRange(); 1983 } 1984 1985 // Check if the gather/scatter scale is legal. 1986 bool Sema::CheckX86BuiltinGatherScatterScale(unsigned BuiltinID, 1987 CallExpr *TheCall) { 1988 unsigned ArgNum = 0; 1989 switch (BuiltinID) { 1990 default: 1991 return false; 1992 case X86::BI__builtin_ia32_gatherpfdpd: 1993 case X86::BI__builtin_ia32_gatherpfdps: 1994 case X86::BI__builtin_ia32_gatherpfqpd: 1995 case X86::BI__builtin_ia32_gatherpfqps: 1996 case X86::BI__builtin_ia32_scatterpfdpd: 1997 case X86::BI__builtin_ia32_scatterpfdps: 1998 case X86::BI__builtin_ia32_scatterpfqpd: 1999 case X86::BI__builtin_ia32_scatterpfqps: 2000 ArgNum = 3; 2001 break; 2002 case X86::BI__builtin_ia32_gatherd_pd: 2003 case X86::BI__builtin_ia32_gatherd_pd256: 2004 case X86::BI__builtin_ia32_gatherq_pd: 2005 case X86::BI__builtin_ia32_gatherq_pd256: 2006 case X86::BI__builtin_ia32_gatherd_ps: 2007 case X86::BI__builtin_ia32_gatherd_ps256: 2008 case X86::BI__builtin_ia32_gatherq_ps: 2009 case X86::BI__builtin_ia32_gatherq_ps256: 2010 case X86::BI__builtin_ia32_gatherd_q: 2011 case X86::BI__builtin_ia32_gatherd_q256: 2012 case X86::BI__builtin_ia32_gatherq_q: 2013 case X86::BI__builtin_ia32_gatherq_q256: 2014 case X86::BI__builtin_ia32_gatherd_d: 2015 case X86::BI__builtin_ia32_gatherd_d256: 2016 case X86::BI__builtin_ia32_gatherq_d: 2017 case X86::BI__builtin_ia32_gatherq_d256: 2018 case X86::BI__builtin_ia32_gather3div2df: 2019 case X86::BI__builtin_ia32_gather3div2di: 2020 case X86::BI__builtin_ia32_gather3div4df: 2021 case X86::BI__builtin_ia32_gather3div4di: 2022 case X86::BI__builtin_ia32_gather3div4sf: 2023 case X86::BI__builtin_ia32_gather3div4si: 2024 case X86::BI__builtin_ia32_gather3div8sf: 2025 case X86::BI__builtin_ia32_gather3div8si: 2026 case X86::BI__builtin_ia32_gather3siv2df: 2027 case X86::BI__builtin_ia32_gather3siv2di: 2028 case X86::BI__builtin_ia32_gather3siv4df: 2029 case X86::BI__builtin_ia32_gather3siv4di: 2030 case X86::BI__builtin_ia32_gather3siv4sf: 2031 case X86::BI__builtin_ia32_gather3siv4si: 2032 case X86::BI__builtin_ia32_gather3siv8sf: 2033 case X86::BI__builtin_ia32_gather3siv8si: 2034 case X86::BI__builtin_ia32_gathersiv8df: 2035 case X86::BI__builtin_ia32_gathersiv16sf: 2036 case X86::BI__builtin_ia32_gatherdiv8df: 2037 case X86::BI__builtin_ia32_gatherdiv16sf: 2038 case X86::BI__builtin_ia32_gathersiv8di: 2039 case X86::BI__builtin_ia32_gathersiv16si: 2040 case X86::BI__builtin_ia32_gatherdiv8di: 2041 case X86::BI__builtin_ia32_gatherdiv16si: 2042 case X86::BI__builtin_ia32_scatterdiv2df: 2043 case X86::BI__builtin_ia32_scatterdiv2di: 2044 case X86::BI__builtin_ia32_scatterdiv4df: 2045 case X86::BI__builtin_ia32_scatterdiv4di: 2046 case X86::BI__builtin_ia32_scatterdiv4sf: 2047 case X86::BI__builtin_ia32_scatterdiv4si: 2048 case X86::BI__builtin_ia32_scatterdiv8sf: 2049 case X86::BI__builtin_ia32_scatterdiv8si: 2050 case X86::BI__builtin_ia32_scattersiv2df: 2051 case X86::BI__builtin_ia32_scattersiv2di: 2052 case X86::BI__builtin_ia32_scattersiv4df: 2053 case X86::BI__builtin_ia32_scattersiv4di: 2054 case X86::BI__builtin_ia32_scattersiv4sf: 2055 case X86::BI__builtin_ia32_scattersiv4si: 2056 case X86::BI__builtin_ia32_scattersiv8sf: 2057 case X86::BI__builtin_ia32_scattersiv8si: 2058 case X86::BI__builtin_ia32_scattersiv8df: 2059 case X86::BI__builtin_ia32_scattersiv16sf: 2060 case X86::BI__builtin_ia32_scatterdiv8df: 2061 case X86::BI__builtin_ia32_scatterdiv16sf: 2062 case X86::BI__builtin_ia32_scattersiv8di: 2063 case X86::BI__builtin_ia32_scattersiv16si: 2064 case X86::BI__builtin_ia32_scatterdiv8di: 2065 case X86::BI__builtin_ia32_scatterdiv16si: 2066 ArgNum = 4; 2067 break; 2068 } 2069 2070 llvm::APSInt Result; 2071 2072 // We can't check the value of a dependent argument. 2073 Expr *Arg = TheCall->getArg(ArgNum); 2074 if (Arg->isTypeDependent() || Arg->isValueDependent()) 2075 return false; 2076 2077 // Check constant-ness first. 2078 if (SemaBuiltinConstantArg(TheCall, ArgNum, Result)) 2079 return true; 2080 2081 if (Result == 1 || Result == 2 || Result == 4 || Result == 8) 2082 return false; 2083 2084 return Diag(TheCall->getLocStart(), diag::err_x86_builtin_invalid_scale) 2085 << Arg->getSourceRange(); 2086 } 2087 2088 bool Sema::CheckX86BuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 2089 if (BuiltinID == X86::BI__builtin_cpu_supports) 2090 return SemaBuiltinCpuSupports(*this, TheCall); 2091 2092 if (BuiltinID == X86::BI__builtin_ms_va_start) 2093 return SemaBuiltinVAStart(BuiltinID, TheCall); 2094 2095 // If the intrinsic has rounding or SAE make sure its valid. 2096 if (CheckX86BuiltinRoundingOrSAE(BuiltinID, TheCall)) 2097 return true; 2098 2099 // If the intrinsic has a gather/scatter scale immediate make sure its valid. 2100 if (CheckX86BuiltinGatherScatterScale(BuiltinID, TheCall)) 2101 return true; 2102 2103 // For intrinsics which take an immediate value as part of the instruction, 2104 // range check them here. 2105 int i = 0, l = 0, u = 0; 2106 switch (BuiltinID) { 2107 default: 2108 return false; 2109 case X86::BI_mm_prefetch: 2110 i = 1; l = 0; u = 3; 2111 break; 2112 case X86::BI__builtin_ia32_sha1rnds4: 2113 case X86::BI__builtin_ia32_shuf_f32x4_256_mask: 2114 case X86::BI__builtin_ia32_shuf_f64x2_256_mask: 2115 case X86::BI__builtin_ia32_shuf_i32x4_256_mask: 2116 case X86::BI__builtin_ia32_shuf_i64x2_256_mask: 2117 i = 2; l = 0; u = 3; 2118 break; 2119 case X86::BI__builtin_ia32_vpermil2pd: 2120 case X86::BI__builtin_ia32_vpermil2pd256: 2121 case X86::BI__builtin_ia32_vpermil2ps: 2122 case X86::BI__builtin_ia32_vpermil2ps256: 2123 i = 3; l = 0; u = 3; 2124 break; 2125 case X86::BI__builtin_ia32_cmpb128_mask: 2126 case X86::BI__builtin_ia32_cmpw128_mask: 2127 case X86::BI__builtin_ia32_cmpd128_mask: 2128 case X86::BI__builtin_ia32_cmpq128_mask: 2129 case X86::BI__builtin_ia32_cmpb256_mask: 2130 case X86::BI__builtin_ia32_cmpw256_mask: 2131 case X86::BI__builtin_ia32_cmpd256_mask: 2132 case X86::BI__builtin_ia32_cmpq256_mask: 2133 case X86::BI__builtin_ia32_cmpb512_mask: 2134 case X86::BI__builtin_ia32_cmpw512_mask: 2135 case X86::BI__builtin_ia32_cmpd512_mask: 2136 case X86::BI__builtin_ia32_cmpq512_mask: 2137 case X86::BI__builtin_ia32_ucmpb128_mask: 2138 case X86::BI__builtin_ia32_ucmpw128_mask: 2139 case X86::BI__builtin_ia32_ucmpd128_mask: 2140 case X86::BI__builtin_ia32_ucmpq128_mask: 2141 case X86::BI__builtin_ia32_ucmpb256_mask: 2142 case X86::BI__builtin_ia32_ucmpw256_mask: 2143 case X86::BI__builtin_ia32_ucmpd256_mask: 2144 case X86::BI__builtin_ia32_ucmpq256_mask: 2145 case X86::BI__builtin_ia32_ucmpb512_mask: 2146 case X86::BI__builtin_ia32_ucmpw512_mask: 2147 case X86::BI__builtin_ia32_ucmpd512_mask: 2148 case X86::BI__builtin_ia32_ucmpq512_mask: 2149 case X86::BI__builtin_ia32_vpcomub: 2150 case X86::BI__builtin_ia32_vpcomuw: 2151 case X86::BI__builtin_ia32_vpcomud: 2152 case X86::BI__builtin_ia32_vpcomuq: 2153 case X86::BI__builtin_ia32_vpcomb: 2154 case X86::BI__builtin_ia32_vpcomw: 2155 case X86::BI__builtin_ia32_vpcomd: 2156 case X86::BI__builtin_ia32_vpcomq: 2157 i = 2; l = 0; u = 7; 2158 break; 2159 case X86::BI__builtin_ia32_roundps: 2160 case X86::BI__builtin_ia32_roundpd: 2161 case X86::BI__builtin_ia32_roundps256: 2162 case X86::BI__builtin_ia32_roundpd256: 2163 i = 1; l = 0; u = 15; 2164 break; 2165 case X86::BI__builtin_ia32_roundss: 2166 case X86::BI__builtin_ia32_roundsd: 2167 case X86::BI__builtin_ia32_rangepd128_mask: 2168 case X86::BI__builtin_ia32_rangepd256_mask: 2169 case X86::BI__builtin_ia32_rangepd512_mask: 2170 case X86::BI__builtin_ia32_rangeps128_mask: 2171 case X86::BI__builtin_ia32_rangeps256_mask: 2172 case X86::BI__builtin_ia32_rangeps512_mask: 2173 case X86::BI__builtin_ia32_getmantsd_round_mask: 2174 case X86::BI__builtin_ia32_getmantss_round_mask: 2175 i = 2; l = 0; u = 15; 2176 break; 2177 case X86::BI__builtin_ia32_cmpps: 2178 case X86::BI__builtin_ia32_cmpss: 2179 case X86::BI__builtin_ia32_cmppd: 2180 case X86::BI__builtin_ia32_cmpsd: 2181 case X86::BI__builtin_ia32_cmpps256: 2182 case X86::BI__builtin_ia32_cmppd256: 2183 case X86::BI__builtin_ia32_cmpps128_mask: 2184 case X86::BI__builtin_ia32_cmppd128_mask: 2185 case X86::BI__builtin_ia32_cmpps256_mask: 2186 case X86::BI__builtin_ia32_cmppd256_mask: 2187 case X86::BI__builtin_ia32_cmpps512_mask: 2188 case X86::BI__builtin_ia32_cmppd512_mask: 2189 case X86::BI__builtin_ia32_cmpsd_mask: 2190 case X86::BI__builtin_ia32_cmpss_mask: 2191 i = 2; l = 0; u = 31; 2192 break; 2193 case X86::BI__builtin_ia32_xabort: 2194 i = 0; l = -128; u = 255; 2195 break; 2196 case X86::BI__builtin_ia32_pshufw: 2197 case X86::BI__builtin_ia32_aeskeygenassist128: 2198 i = 1; l = -128; u = 255; 2199 break; 2200 case X86::BI__builtin_ia32_vcvtps2ph: 2201 case X86::BI__builtin_ia32_vcvtps2ph256: 2202 case X86::BI__builtin_ia32_rndscaleps_128_mask: 2203 case X86::BI__builtin_ia32_rndscalepd_128_mask: 2204 case X86::BI__builtin_ia32_rndscaleps_256_mask: 2205 case X86::BI__builtin_ia32_rndscalepd_256_mask: 2206 case X86::BI__builtin_ia32_rndscaleps_mask: 2207 case X86::BI__builtin_ia32_rndscalepd_mask: 2208 case X86::BI__builtin_ia32_reducepd128_mask: 2209 case X86::BI__builtin_ia32_reducepd256_mask: 2210 case X86::BI__builtin_ia32_reducepd512_mask: 2211 case X86::BI__builtin_ia32_reduceps128_mask: 2212 case X86::BI__builtin_ia32_reduceps256_mask: 2213 case X86::BI__builtin_ia32_reduceps512_mask: 2214 case X86::BI__builtin_ia32_prold512_mask: 2215 case X86::BI__builtin_ia32_prolq512_mask: 2216 case X86::BI__builtin_ia32_prold128_mask: 2217 case X86::BI__builtin_ia32_prold256_mask: 2218 case X86::BI__builtin_ia32_prolq128_mask: 2219 case X86::BI__builtin_ia32_prolq256_mask: 2220 case X86::BI__builtin_ia32_prord128_mask: 2221 case X86::BI__builtin_ia32_prord256_mask: 2222 case X86::BI__builtin_ia32_prorq128_mask: 2223 case X86::BI__builtin_ia32_prorq256_mask: 2224 case X86::BI__builtin_ia32_fpclasspd128_mask: 2225 case X86::BI__builtin_ia32_fpclasspd256_mask: 2226 case X86::BI__builtin_ia32_fpclassps128_mask: 2227 case X86::BI__builtin_ia32_fpclassps256_mask: 2228 case X86::BI__builtin_ia32_fpclassps512_mask: 2229 case X86::BI__builtin_ia32_fpclasspd512_mask: 2230 case X86::BI__builtin_ia32_fpclasssd_mask: 2231 case X86::BI__builtin_ia32_fpclassss_mask: 2232 i = 1; l = 0; u = 255; 2233 break; 2234 case X86::BI__builtin_ia32_palignr: 2235 case X86::BI__builtin_ia32_insertps128: 2236 case X86::BI__builtin_ia32_dpps: 2237 case X86::BI__builtin_ia32_dppd: 2238 case X86::BI__builtin_ia32_dpps256: 2239 case X86::BI__builtin_ia32_mpsadbw128: 2240 case X86::BI__builtin_ia32_mpsadbw256: 2241 case X86::BI__builtin_ia32_pcmpistrm128: 2242 case X86::BI__builtin_ia32_pcmpistri128: 2243 case X86::BI__builtin_ia32_pcmpistria128: 2244 case X86::BI__builtin_ia32_pcmpistric128: 2245 case X86::BI__builtin_ia32_pcmpistrio128: 2246 case X86::BI__builtin_ia32_pcmpistris128: 2247 case X86::BI__builtin_ia32_pcmpistriz128: 2248 case X86::BI__builtin_ia32_pclmulqdq128: 2249 case X86::BI__builtin_ia32_vperm2f128_pd256: 2250 case X86::BI__builtin_ia32_vperm2f128_ps256: 2251 case X86::BI__builtin_ia32_vperm2f128_si256: 2252 case X86::BI__builtin_ia32_permti256: 2253 i = 2; l = -128; u = 255; 2254 break; 2255 case X86::BI__builtin_ia32_palignr128: 2256 case X86::BI__builtin_ia32_palignr256: 2257 case X86::BI__builtin_ia32_palignr512_mask: 2258 case X86::BI__builtin_ia32_vcomisd: 2259 case X86::BI__builtin_ia32_vcomiss: 2260 case X86::BI__builtin_ia32_shuf_f32x4_mask: 2261 case X86::BI__builtin_ia32_shuf_f64x2_mask: 2262 case X86::BI__builtin_ia32_shuf_i32x4_mask: 2263 case X86::BI__builtin_ia32_shuf_i64x2_mask: 2264 case X86::BI__builtin_ia32_dbpsadbw128_mask: 2265 case X86::BI__builtin_ia32_dbpsadbw256_mask: 2266 case X86::BI__builtin_ia32_dbpsadbw512_mask: 2267 i = 2; l = 0; u = 255; 2268 break; 2269 case X86::BI__builtin_ia32_fixupimmpd512_mask: 2270 case X86::BI__builtin_ia32_fixupimmpd512_maskz: 2271 case X86::BI__builtin_ia32_fixupimmps512_mask: 2272 case X86::BI__builtin_ia32_fixupimmps512_maskz: 2273 case X86::BI__builtin_ia32_fixupimmsd_mask: 2274 case X86::BI__builtin_ia32_fixupimmsd_maskz: 2275 case X86::BI__builtin_ia32_fixupimmss_mask: 2276 case X86::BI__builtin_ia32_fixupimmss_maskz: 2277 case X86::BI__builtin_ia32_fixupimmpd128_mask: 2278 case X86::BI__builtin_ia32_fixupimmpd128_maskz: 2279 case X86::BI__builtin_ia32_fixupimmpd256_mask: 2280 case X86::BI__builtin_ia32_fixupimmpd256_maskz: 2281 case X86::BI__builtin_ia32_fixupimmps128_mask: 2282 case X86::BI__builtin_ia32_fixupimmps128_maskz: 2283 case X86::BI__builtin_ia32_fixupimmps256_mask: 2284 case X86::BI__builtin_ia32_fixupimmps256_maskz: 2285 case X86::BI__builtin_ia32_pternlogd512_mask: 2286 case X86::BI__builtin_ia32_pternlogd512_maskz: 2287 case X86::BI__builtin_ia32_pternlogq512_mask: 2288 case X86::BI__builtin_ia32_pternlogq512_maskz: 2289 case X86::BI__builtin_ia32_pternlogd128_mask: 2290 case X86::BI__builtin_ia32_pternlogd128_maskz: 2291 case X86::BI__builtin_ia32_pternlogd256_mask: 2292 case X86::BI__builtin_ia32_pternlogd256_maskz: 2293 case X86::BI__builtin_ia32_pternlogq128_mask: 2294 case X86::BI__builtin_ia32_pternlogq128_maskz: 2295 case X86::BI__builtin_ia32_pternlogq256_mask: 2296 case X86::BI__builtin_ia32_pternlogq256_maskz: 2297 i = 3; l = 0; u = 255; 2298 break; 2299 case X86::BI__builtin_ia32_gatherpfdpd: 2300 case X86::BI__builtin_ia32_gatherpfdps: 2301 case X86::BI__builtin_ia32_gatherpfqpd: 2302 case X86::BI__builtin_ia32_gatherpfqps: 2303 case X86::BI__builtin_ia32_scatterpfdpd: 2304 case X86::BI__builtin_ia32_scatterpfdps: 2305 case X86::BI__builtin_ia32_scatterpfqpd: 2306 case X86::BI__builtin_ia32_scatterpfqps: 2307 i = 4; l = 2; u = 3; 2308 break; 2309 case X86::BI__builtin_ia32_pcmpestrm128: 2310 case X86::BI__builtin_ia32_pcmpestri128: 2311 case X86::BI__builtin_ia32_pcmpestria128: 2312 case X86::BI__builtin_ia32_pcmpestric128: 2313 case X86::BI__builtin_ia32_pcmpestrio128: 2314 case X86::BI__builtin_ia32_pcmpestris128: 2315 case X86::BI__builtin_ia32_pcmpestriz128: 2316 i = 4; l = -128; u = 255; 2317 break; 2318 case X86::BI__builtin_ia32_rndscalesd_round_mask: 2319 case X86::BI__builtin_ia32_rndscaless_round_mask: 2320 i = 4; l = 0; u = 255; 2321 break; 2322 } 2323 return SemaBuiltinConstantArgRange(TheCall, i, l, u); 2324 } 2325 2326 /// Given a FunctionDecl's FormatAttr, attempts to populate the FomatStringInfo 2327 /// parameter with the FormatAttr's correct format_idx and firstDataArg. 2328 /// Returns true when the format fits the function and the FormatStringInfo has 2329 /// been populated. 2330 bool Sema::getFormatStringInfo(const FormatAttr *Format, bool IsCXXMember, 2331 FormatStringInfo *FSI) { 2332 FSI->HasVAListArg = Format->getFirstArg() == 0; 2333 FSI->FormatIdx = Format->getFormatIdx() - 1; 2334 FSI->FirstDataArg = FSI->HasVAListArg ? 0 : Format->getFirstArg() - 1; 2335 2336 // The way the format attribute works in GCC, the implicit this argument 2337 // of member functions is counted. However, it doesn't appear in our own 2338 // lists, so decrement format_idx in that case. 2339 if (IsCXXMember) { 2340 if(FSI->FormatIdx == 0) 2341 return false; 2342 --FSI->FormatIdx; 2343 if (FSI->FirstDataArg != 0) 2344 --FSI->FirstDataArg; 2345 } 2346 return true; 2347 } 2348 2349 /// Checks if a the given expression evaluates to null. 2350 /// 2351 /// \brief Returns true if the value evaluates to null. 2352 static bool CheckNonNullExpr(Sema &S, const Expr *Expr) { 2353 // If the expression has non-null type, it doesn't evaluate to null. 2354 if (auto nullability 2355 = Expr->IgnoreImplicit()->getType()->getNullability(S.Context)) { 2356 if (*nullability == NullabilityKind::NonNull) 2357 return false; 2358 } 2359 2360 // As a special case, transparent unions initialized with zero are 2361 // considered null for the purposes of the nonnull attribute. 2362 if (const RecordType *UT = Expr->getType()->getAsUnionType()) { 2363 if (UT->getDecl()->hasAttr<TransparentUnionAttr>()) 2364 if (const CompoundLiteralExpr *CLE = 2365 dyn_cast<CompoundLiteralExpr>(Expr)) 2366 if (const InitListExpr *ILE = 2367 dyn_cast<InitListExpr>(CLE->getInitializer())) 2368 Expr = ILE->getInit(0); 2369 } 2370 2371 bool Result; 2372 return (!Expr->isValueDependent() && 2373 Expr->EvaluateAsBooleanCondition(Result, S.Context) && 2374 !Result); 2375 } 2376 2377 static void CheckNonNullArgument(Sema &S, 2378 const Expr *ArgExpr, 2379 SourceLocation CallSiteLoc) { 2380 if (CheckNonNullExpr(S, ArgExpr)) 2381 S.DiagRuntimeBehavior(CallSiteLoc, ArgExpr, 2382 S.PDiag(diag::warn_null_arg) << ArgExpr->getSourceRange()); 2383 } 2384 2385 bool Sema::GetFormatNSStringIdx(const FormatAttr *Format, unsigned &Idx) { 2386 FormatStringInfo FSI; 2387 if ((GetFormatStringType(Format) == FST_NSString) && 2388 getFormatStringInfo(Format, false, &FSI)) { 2389 Idx = FSI.FormatIdx; 2390 return true; 2391 } 2392 return false; 2393 } 2394 /// \brief Diagnose use of %s directive in an NSString which is being passed 2395 /// as formatting string to formatting method. 2396 static void 2397 DiagnoseCStringFormatDirectiveInCFAPI(Sema &S, 2398 const NamedDecl *FDecl, 2399 Expr **Args, 2400 unsigned NumArgs) { 2401 unsigned Idx = 0; 2402 bool Format = false; 2403 ObjCStringFormatFamily SFFamily = FDecl->getObjCFStringFormattingFamily(); 2404 if (SFFamily == ObjCStringFormatFamily::SFF_CFString) { 2405 Idx = 2; 2406 Format = true; 2407 } 2408 else 2409 for (const auto *I : FDecl->specific_attrs<FormatAttr>()) { 2410 if (S.GetFormatNSStringIdx(I, Idx)) { 2411 Format = true; 2412 break; 2413 } 2414 } 2415 if (!Format || NumArgs <= Idx) 2416 return; 2417 const Expr *FormatExpr = Args[Idx]; 2418 if (const CStyleCastExpr *CSCE = dyn_cast<CStyleCastExpr>(FormatExpr)) 2419 FormatExpr = CSCE->getSubExpr(); 2420 const StringLiteral *FormatString; 2421 if (const ObjCStringLiteral *OSL = 2422 dyn_cast<ObjCStringLiteral>(FormatExpr->IgnoreParenImpCasts())) 2423 FormatString = OSL->getString(); 2424 else 2425 FormatString = dyn_cast<StringLiteral>(FormatExpr->IgnoreParenImpCasts()); 2426 if (!FormatString) 2427 return; 2428 if (S.FormatStringHasSArg(FormatString)) { 2429 S.Diag(FormatExpr->getExprLoc(), diag::warn_objc_cdirective_format_string) 2430 << "%s" << 1 << 1; 2431 S.Diag(FDecl->getLocation(), diag::note_entity_declared_at) 2432 << FDecl->getDeclName(); 2433 } 2434 } 2435 2436 /// Determine whether the given type has a non-null nullability annotation. 2437 static bool isNonNullType(ASTContext &ctx, QualType type) { 2438 if (auto nullability = type->getNullability(ctx)) 2439 return *nullability == NullabilityKind::NonNull; 2440 2441 return false; 2442 } 2443 2444 static void CheckNonNullArguments(Sema &S, 2445 const NamedDecl *FDecl, 2446 const FunctionProtoType *Proto, 2447 ArrayRef<const Expr *> Args, 2448 SourceLocation CallSiteLoc) { 2449 assert((FDecl || Proto) && "Need a function declaration or prototype"); 2450 2451 // Check the attributes attached to the method/function itself. 2452 llvm::SmallBitVector NonNullArgs; 2453 if (FDecl) { 2454 // Handle the nonnull attribute on the function/method declaration itself. 2455 for (const auto *NonNull : FDecl->specific_attrs<NonNullAttr>()) { 2456 if (!NonNull->args_size()) { 2457 // Easy case: all pointer arguments are nonnull. 2458 for (const auto *Arg : Args) 2459 if (S.isValidPointerAttrType(Arg->getType())) 2460 CheckNonNullArgument(S, Arg, CallSiteLoc); 2461 return; 2462 } 2463 2464 for (unsigned Val : NonNull->args()) { 2465 if (Val >= Args.size()) 2466 continue; 2467 if (NonNullArgs.empty()) 2468 NonNullArgs.resize(Args.size()); 2469 NonNullArgs.set(Val); 2470 } 2471 } 2472 } 2473 2474 if (FDecl && (isa<FunctionDecl>(FDecl) || isa<ObjCMethodDecl>(FDecl))) { 2475 // Handle the nonnull attribute on the parameters of the 2476 // function/method. 2477 ArrayRef<ParmVarDecl*> parms; 2478 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(FDecl)) 2479 parms = FD->parameters(); 2480 else 2481 parms = cast<ObjCMethodDecl>(FDecl)->parameters(); 2482 2483 unsigned ParamIndex = 0; 2484 for (ArrayRef<ParmVarDecl*>::iterator I = parms.begin(), E = parms.end(); 2485 I != E; ++I, ++ParamIndex) { 2486 const ParmVarDecl *PVD = *I; 2487 if (PVD->hasAttr<NonNullAttr>() || 2488 isNonNullType(S.Context, PVD->getType())) { 2489 if (NonNullArgs.empty()) 2490 NonNullArgs.resize(Args.size()); 2491 2492 NonNullArgs.set(ParamIndex); 2493 } 2494 } 2495 } else { 2496 // If we have a non-function, non-method declaration but no 2497 // function prototype, try to dig out the function prototype. 2498 if (!Proto) { 2499 if (const ValueDecl *VD = dyn_cast<ValueDecl>(FDecl)) { 2500 QualType type = VD->getType().getNonReferenceType(); 2501 if (auto pointerType = type->getAs<PointerType>()) 2502 type = pointerType->getPointeeType(); 2503 else if (auto blockType = type->getAs<BlockPointerType>()) 2504 type = blockType->getPointeeType(); 2505 // FIXME: data member pointers? 2506 2507 // Dig out the function prototype, if there is one. 2508 Proto = type->getAs<FunctionProtoType>(); 2509 } 2510 } 2511 2512 // Fill in non-null argument information from the nullability 2513 // information on the parameter types (if we have them). 2514 if (Proto) { 2515 unsigned Index = 0; 2516 for (auto paramType : Proto->getParamTypes()) { 2517 if (isNonNullType(S.Context, paramType)) { 2518 if (NonNullArgs.empty()) 2519 NonNullArgs.resize(Args.size()); 2520 2521 NonNullArgs.set(Index); 2522 } 2523 2524 ++Index; 2525 } 2526 } 2527 } 2528 2529 // Check for non-null arguments. 2530 for (unsigned ArgIndex = 0, ArgIndexEnd = NonNullArgs.size(); 2531 ArgIndex != ArgIndexEnd; ++ArgIndex) { 2532 if (NonNullArgs[ArgIndex]) 2533 CheckNonNullArgument(S, Args[ArgIndex], CallSiteLoc); 2534 } 2535 } 2536 2537 /// Handles the checks for format strings, non-POD arguments to vararg 2538 /// functions, NULL arguments passed to non-NULL parameters, and diagnose_if 2539 /// attributes. 2540 void Sema::checkCall(NamedDecl *FDecl, const FunctionProtoType *Proto, 2541 const Expr *ThisArg, ArrayRef<const Expr *> Args, 2542 bool IsMemberFunction, SourceLocation Loc, 2543 SourceRange Range, VariadicCallType CallType) { 2544 // FIXME: We should check as much as we can in the template definition. 2545 if (CurContext->isDependentContext()) 2546 return; 2547 2548 // Printf and scanf checking. 2549 llvm::SmallBitVector CheckedVarArgs; 2550 if (FDecl) { 2551 for (const auto *I : FDecl->specific_attrs<FormatAttr>()) { 2552 // Only create vector if there are format attributes. 2553 CheckedVarArgs.resize(Args.size()); 2554 2555 CheckFormatArguments(I, Args, IsMemberFunction, CallType, Loc, Range, 2556 CheckedVarArgs); 2557 } 2558 } 2559 2560 // Refuse POD arguments that weren't caught by the format string 2561 // checks above. 2562 auto *FD = dyn_cast_or_null<FunctionDecl>(FDecl); 2563 if (CallType != VariadicDoesNotApply && 2564 (!FD || FD->getBuiltinID() != Builtin::BI__noop)) { 2565 unsigned NumParams = Proto ? Proto->getNumParams() 2566 : FDecl && isa<FunctionDecl>(FDecl) 2567 ? cast<FunctionDecl>(FDecl)->getNumParams() 2568 : FDecl && isa<ObjCMethodDecl>(FDecl) 2569 ? cast<ObjCMethodDecl>(FDecl)->param_size() 2570 : 0; 2571 2572 for (unsigned ArgIdx = NumParams; ArgIdx < Args.size(); ++ArgIdx) { 2573 // Args[ArgIdx] can be null in malformed code. 2574 if (const Expr *Arg = Args[ArgIdx]) { 2575 if (CheckedVarArgs.empty() || !CheckedVarArgs[ArgIdx]) 2576 checkVariadicArgument(Arg, CallType); 2577 } 2578 } 2579 } 2580 2581 if (FDecl || Proto) { 2582 CheckNonNullArguments(*this, FDecl, Proto, Args, Loc); 2583 2584 // Type safety checking. 2585 if (FDecl) { 2586 for (const auto *I : FDecl->specific_attrs<ArgumentWithTypeTagAttr>()) 2587 CheckArgumentWithTypeTag(I, Args.data()); 2588 } 2589 } 2590 2591 if (FD) 2592 diagnoseArgDependentDiagnoseIfAttrs(FD, ThisArg, Args, Loc); 2593 } 2594 2595 /// CheckConstructorCall - Check a constructor call for correctness and safety 2596 /// properties not enforced by the C type system. 2597 void Sema::CheckConstructorCall(FunctionDecl *FDecl, 2598 ArrayRef<const Expr *> Args, 2599 const FunctionProtoType *Proto, 2600 SourceLocation Loc) { 2601 VariadicCallType CallType = 2602 Proto->isVariadic() ? VariadicConstructor : VariadicDoesNotApply; 2603 checkCall(FDecl, Proto, /*ThisArg=*/nullptr, Args, /*IsMemberFunction=*/true, 2604 Loc, SourceRange(), CallType); 2605 } 2606 2607 /// CheckFunctionCall - Check a direct function call for various correctness 2608 /// and safety properties not strictly enforced by the C type system. 2609 bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall, 2610 const FunctionProtoType *Proto) { 2611 bool IsMemberOperatorCall = isa<CXXOperatorCallExpr>(TheCall) && 2612 isa<CXXMethodDecl>(FDecl); 2613 bool IsMemberFunction = isa<CXXMemberCallExpr>(TheCall) || 2614 IsMemberOperatorCall; 2615 VariadicCallType CallType = getVariadicCallType(FDecl, Proto, 2616 TheCall->getCallee()); 2617 Expr** Args = TheCall->getArgs(); 2618 unsigned NumArgs = TheCall->getNumArgs(); 2619 2620 Expr *ImplicitThis = nullptr; 2621 if (IsMemberOperatorCall) { 2622 // If this is a call to a member operator, hide the first argument 2623 // from checkCall. 2624 // FIXME: Our choice of AST representation here is less than ideal. 2625 ImplicitThis = Args[0]; 2626 ++Args; 2627 --NumArgs; 2628 } else if (IsMemberFunction) 2629 ImplicitThis = 2630 cast<CXXMemberCallExpr>(TheCall)->getImplicitObjectArgument(); 2631 2632 checkCall(FDecl, Proto, ImplicitThis, llvm::makeArrayRef(Args, NumArgs), 2633 IsMemberFunction, TheCall->getRParenLoc(), 2634 TheCall->getCallee()->getSourceRange(), CallType); 2635 2636 IdentifierInfo *FnInfo = FDecl->getIdentifier(); 2637 // None of the checks below are needed for functions that don't have 2638 // simple names (e.g., C++ conversion functions). 2639 if (!FnInfo) 2640 return false; 2641 2642 CheckAbsoluteValueFunction(TheCall, FDecl); 2643 CheckMaxUnsignedZero(TheCall, FDecl); 2644 2645 if (getLangOpts().ObjC1) 2646 DiagnoseCStringFormatDirectiveInCFAPI(*this, FDecl, Args, NumArgs); 2647 2648 unsigned CMId = FDecl->getMemoryFunctionKind(); 2649 if (CMId == 0) 2650 return false; 2651 2652 // Handle memory setting and copying functions. 2653 if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat) 2654 CheckStrlcpycatArguments(TheCall, FnInfo); 2655 else if (CMId == Builtin::BIstrncat) 2656 CheckStrncatArguments(TheCall, FnInfo); 2657 else 2658 CheckMemaccessArguments(TheCall, CMId, FnInfo); 2659 2660 return false; 2661 } 2662 2663 bool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac, 2664 ArrayRef<const Expr *> Args) { 2665 VariadicCallType CallType = 2666 Method->isVariadic() ? VariadicMethod : VariadicDoesNotApply; 2667 2668 checkCall(Method, nullptr, /*ThisArg=*/nullptr, Args, 2669 /*IsMemberFunction=*/false, lbrac, Method->getSourceRange(), 2670 CallType); 2671 2672 return false; 2673 } 2674 2675 bool Sema::CheckPointerCall(NamedDecl *NDecl, CallExpr *TheCall, 2676 const FunctionProtoType *Proto) { 2677 QualType Ty; 2678 if (const auto *V = dyn_cast<VarDecl>(NDecl)) 2679 Ty = V->getType().getNonReferenceType(); 2680 else if (const auto *F = dyn_cast<FieldDecl>(NDecl)) 2681 Ty = F->getType().getNonReferenceType(); 2682 else 2683 return false; 2684 2685 if (!Ty->isBlockPointerType() && !Ty->isFunctionPointerType() && 2686 !Ty->isFunctionProtoType()) 2687 return false; 2688 2689 VariadicCallType CallType; 2690 if (!Proto || !Proto->isVariadic()) { 2691 CallType = VariadicDoesNotApply; 2692 } else if (Ty->isBlockPointerType()) { 2693 CallType = VariadicBlock; 2694 } else { // Ty->isFunctionPointerType() 2695 CallType = VariadicFunction; 2696 } 2697 2698 checkCall(NDecl, Proto, /*ThisArg=*/nullptr, 2699 llvm::makeArrayRef(TheCall->getArgs(), TheCall->getNumArgs()), 2700 /*IsMemberFunction=*/false, TheCall->getRParenLoc(), 2701 TheCall->getCallee()->getSourceRange(), CallType); 2702 2703 return false; 2704 } 2705 2706 /// Checks function calls when a FunctionDecl or a NamedDecl is not available, 2707 /// such as function pointers returned from functions. 2708 bool Sema::CheckOtherCall(CallExpr *TheCall, const FunctionProtoType *Proto) { 2709 VariadicCallType CallType = getVariadicCallType(/*FDecl=*/nullptr, Proto, 2710 TheCall->getCallee()); 2711 checkCall(/*FDecl=*/nullptr, Proto, /*ThisArg=*/nullptr, 2712 llvm::makeArrayRef(TheCall->getArgs(), TheCall->getNumArgs()), 2713 /*IsMemberFunction=*/false, TheCall->getRParenLoc(), 2714 TheCall->getCallee()->getSourceRange(), CallType); 2715 2716 return false; 2717 } 2718 2719 static bool isValidOrderingForOp(int64_t Ordering, AtomicExpr::AtomicOp Op) { 2720 if (!llvm::isValidAtomicOrderingCABI(Ordering)) 2721 return false; 2722 2723 auto OrderingCABI = (llvm::AtomicOrderingCABI)Ordering; 2724 switch (Op) { 2725 case AtomicExpr::AO__c11_atomic_init: 2726 llvm_unreachable("There is no ordering argument for an init"); 2727 2728 case AtomicExpr::AO__c11_atomic_load: 2729 case AtomicExpr::AO__atomic_load_n: 2730 case AtomicExpr::AO__atomic_load: 2731 return OrderingCABI != llvm::AtomicOrderingCABI::release && 2732 OrderingCABI != llvm::AtomicOrderingCABI::acq_rel; 2733 2734 case AtomicExpr::AO__c11_atomic_store: 2735 case AtomicExpr::AO__atomic_store: 2736 case AtomicExpr::AO__atomic_store_n: 2737 return OrderingCABI != llvm::AtomicOrderingCABI::consume && 2738 OrderingCABI != llvm::AtomicOrderingCABI::acquire && 2739 OrderingCABI != llvm::AtomicOrderingCABI::acq_rel; 2740 2741 default: 2742 return true; 2743 } 2744 } 2745 2746 ExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult, 2747 AtomicExpr::AtomicOp Op) { 2748 CallExpr *TheCall = cast<CallExpr>(TheCallResult.get()); 2749 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 2750 2751 // All these operations take one of the following forms: 2752 enum { 2753 // C __c11_atomic_init(A *, C) 2754 Init, 2755 // C __c11_atomic_load(A *, int) 2756 Load, 2757 // void __atomic_load(A *, CP, int) 2758 LoadCopy, 2759 // void __atomic_store(A *, CP, int) 2760 Copy, 2761 // C __c11_atomic_add(A *, M, int) 2762 Arithmetic, 2763 // C __atomic_exchange_n(A *, CP, int) 2764 Xchg, 2765 // void __atomic_exchange(A *, C *, CP, int) 2766 GNUXchg, 2767 // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int) 2768 C11CmpXchg, 2769 // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int) 2770 GNUCmpXchg 2771 } Form = Init; 2772 const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 3, 4, 5, 6 }; 2773 const unsigned NumVals[] = { 1, 0, 1, 1, 1, 1, 2, 2, 3 }; 2774 // where: 2775 // C is an appropriate type, 2776 // A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins, 2777 // CP is C for __c11 builtins and GNU _n builtins and is C * otherwise, 2778 // M is C if C is an integer, and ptrdiff_t if C is a pointer, and 2779 // the int parameters are for orderings. 2780 2781 static_assert(AtomicExpr::AO__c11_atomic_init == 0 && 2782 AtomicExpr::AO__c11_atomic_fetch_xor + 1 == 2783 AtomicExpr::AO__atomic_load, 2784 "need to update code for modified C11 atomics"); 2785 bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init && 2786 Op <= AtomicExpr::AO__c11_atomic_fetch_xor; 2787 bool IsN = Op == AtomicExpr::AO__atomic_load_n || 2788 Op == AtomicExpr::AO__atomic_store_n || 2789 Op == AtomicExpr::AO__atomic_exchange_n || 2790 Op == AtomicExpr::AO__atomic_compare_exchange_n; 2791 bool IsAddSub = false; 2792 2793 switch (Op) { 2794 case AtomicExpr::AO__c11_atomic_init: 2795 Form = Init; 2796 break; 2797 2798 case AtomicExpr::AO__c11_atomic_load: 2799 case AtomicExpr::AO__atomic_load_n: 2800 Form = Load; 2801 break; 2802 2803 case AtomicExpr::AO__atomic_load: 2804 Form = LoadCopy; 2805 break; 2806 2807 case AtomicExpr::AO__c11_atomic_store: 2808 case AtomicExpr::AO__atomic_store: 2809 case AtomicExpr::AO__atomic_store_n: 2810 Form = Copy; 2811 break; 2812 2813 case AtomicExpr::AO__c11_atomic_fetch_add: 2814 case AtomicExpr::AO__c11_atomic_fetch_sub: 2815 case AtomicExpr::AO__atomic_fetch_add: 2816 case AtomicExpr::AO__atomic_fetch_sub: 2817 case AtomicExpr::AO__atomic_add_fetch: 2818 case AtomicExpr::AO__atomic_sub_fetch: 2819 IsAddSub = true; 2820 // Fall through. 2821 case AtomicExpr::AO__c11_atomic_fetch_and: 2822 case AtomicExpr::AO__c11_atomic_fetch_or: 2823 case AtomicExpr::AO__c11_atomic_fetch_xor: 2824 case AtomicExpr::AO__atomic_fetch_and: 2825 case AtomicExpr::AO__atomic_fetch_or: 2826 case AtomicExpr::AO__atomic_fetch_xor: 2827 case AtomicExpr::AO__atomic_fetch_nand: 2828 case AtomicExpr::AO__atomic_and_fetch: 2829 case AtomicExpr::AO__atomic_or_fetch: 2830 case AtomicExpr::AO__atomic_xor_fetch: 2831 case AtomicExpr::AO__atomic_nand_fetch: 2832 Form = Arithmetic; 2833 break; 2834 2835 case AtomicExpr::AO__c11_atomic_exchange: 2836 case AtomicExpr::AO__atomic_exchange_n: 2837 Form = Xchg; 2838 break; 2839 2840 case AtomicExpr::AO__atomic_exchange: 2841 Form = GNUXchg; 2842 break; 2843 2844 case AtomicExpr::AO__c11_atomic_compare_exchange_strong: 2845 case AtomicExpr::AO__c11_atomic_compare_exchange_weak: 2846 Form = C11CmpXchg; 2847 break; 2848 2849 case AtomicExpr::AO__atomic_compare_exchange: 2850 case AtomicExpr::AO__atomic_compare_exchange_n: 2851 Form = GNUCmpXchg; 2852 break; 2853 } 2854 2855 // Check we have the right number of arguments. 2856 if (TheCall->getNumArgs() < NumArgs[Form]) { 2857 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 2858 << 0 << NumArgs[Form] << TheCall->getNumArgs() 2859 << TheCall->getCallee()->getSourceRange(); 2860 return ExprError(); 2861 } else if (TheCall->getNumArgs() > NumArgs[Form]) { 2862 Diag(TheCall->getArg(NumArgs[Form])->getLocStart(), 2863 diag::err_typecheck_call_too_many_args) 2864 << 0 << NumArgs[Form] << TheCall->getNumArgs() 2865 << TheCall->getCallee()->getSourceRange(); 2866 return ExprError(); 2867 } 2868 2869 // Inspect the first argument of the atomic operation. 2870 Expr *Ptr = TheCall->getArg(0); 2871 ExprResult ConvertedPtr = DefaultFunctionArrayLvalueConversion(Ptr); 2872 if (ConvertedPtr.isInvalid()) 2873 return ExprError(); 2874 2875 Ptr = ConvertedPtr.get(); 2876 const PointerType *pointerType = Ptr->getType()->getAs<PointerType>(); 2877 if (!pointerType) { 2878 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 2879 << Ptr->getType() << Ptr->getSourceRange(); 2880 return ExprError(); 2881 } 2882 2883 // For a __c11 builtin, this should be a pointer to an _Atomic type. 2884 QualType AtomTy = pointerType->getPointeeType(); // 'A' 2885 QualType ValType = AtomTy; // 'C' 2886 if (IsC11) { 2887 if (!AtomTy->isAtomicType()) { 2888 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 2889 << Ptr->getType() << Ptr->getSourceRange(); 2890 return ExprError(); 2891 } 2892 if (AtomTy.isConstQualified()) { 2893 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_non_const_atomic) 2894 << Ptr->getType() << Ptr->getSourceRange(); 2895 return ExprError(); 2896 } 2897 ValType = AtomTy->getAs<AtomicType>()->getValueType(); 2898 } else if (Form != Load && Form != LoadCopy) { 2899 if (ValType.isConstQualified()) { 2900 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_non_const_pointer) 2901 << Ptr->getType() << Ptr->getSourceRange(); 2902 return ExprError(); 2903 } 2904 } 2905 2906 // For an arithmetic operation, the implied arithmetic must be well-formed. 2907 if (Form == Arithmetic) { 2908 // gcc does not enforce these rules for GNU atomics, but we do so for sanity. 2909 if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) { 2910 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 2911 << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 2912 return ExprError(); 2913 } 2914 if (!IsAddSub && !ValType->isIntegerType()) { 2915 Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int) 2916 << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 2917 return ExprError(); 2918 } 2919 if (IsC11 && ValType->isPointerType() && 2920 RequireCompleteType(Ptr->getLocStart(), ValType->getPointeeType(), 2921 diag::err_incomplete_type)) { 2922 return ExprError(); 2923 } 2924 } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) { 2925 // For __atomic_*_n operations, the value type must be a scalar integral or 2926 // pointer type which is 1, 2, 4, 8 or 16 bytes in length. 2927 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 2928 << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 2929 return ExprError(); 2930 } 2931 2932 if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context) && 2933 !AtomTy->isScalarType()) { 2934 // For GNU atomics, require a trivially-copyable type. This is not part of 2935 // the GNU atomics specification, but we enforce it for sanity. 2936 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy) 2937 << Ptr->getType() << Ptr->getSourceRange(); 2938 return ExprError(); 2939 } 2940 2941 switch (ValType.getObjCLifetime()) { 2942 case Qualifiers::OCL_None: 2943 case Qualifiers::OCL_ExplicitNone: 2944 // okay 2945 break; 2946 2947 case Qualifiers::OCL_Weak: 2948 case Qualifiers::OCL_Strong: 2949 case Qualifiers::OCL_Autoreleasing: 2950 // FIXME: Can this happen? By this point, ValType should be known 2951 // to be trivially copyable. 2952 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 2953 << ValType << Ptr->getSourceRange(); 2954 return ExprError(); 2955 } 2956 2957 // atomic_fetch_or takes a pointer to a volatile 'A'. We shouldn't let the 2958 // volatile-ness of the pointee-type inject itself into the result or the 2959 // other operands. Similarly atomic_load can take a pointer to a const 'A'. 2960 ValType.removeLocalVolatile(); 2961 ValType.removeLocalConst(); 2962 QualType ResultType = ValType; 2963 if (Form == Copy || Form == LoadCopy || Form == GNUXchg || Form == Init) 2964 ResultType = Context.VoidTy; 2965 else if (Form == C11CmpXchg || Form == GNUCmpXchg) 2966 ResultType = Context.BoolTy; 2967 2968 // The type of a parameter passed 'by value'. In the GNU atomics, such 2969 // arguments are actually passed as pointers. 2970 QualType ByValType = ValType; // 'CP' 2971 if (!IsC11 && !IsN) 2972 ByValType = Ptr->getType(); 2973 2974 // The first argument --- the pointer --- has a fixed type; we 2975 // deduce the types of the rest of the arguments accordingly. Walk 2976 // the remaining arguments, converting them to the deduced value type. 2977 for (unsigned i = 1; i != NumArgs[Form]; ++i) { 2978 QualType Ty; 2979 if (i < NumVals[Form] + 1) { 2980 switch (i) { 2981 case 1: 2982 // The second argument is the non-atomic operand. For arithmetic, this 2983 // is always passed by value, and for a compare_exchange it is always 2984 // passed by address. For the rest, GNU uses by-address and C11 uses 2985 // by-value. 2986 assert(Form != Load); 2987 if (Form == Init || (Form == Arithmetic && ValType->isIntegerType())) 2988 Ty = ValType; 2989 else if (Form == Copy || Form == Xchg) 2990 Ty = ByValType; 2991 else if (Form == Arithmetic) 2992 Ty = Context.getPointerDiffType(); 2993 else { 2994 Expr *ValArg = TheCall->getArg(i); 2995 // Treat this argument as _Nonnull as we want to show a warning if 2996 // NULL is passed into it. 2997 CheckNonNullArgument(*this, ValArg, DRE->getLocStart()); 2998 unsigned AS = 0; 2999 // Keep address space of non-atomic pointer type. 3000 if (const PointerType *PtrTy = 3001 ValArg->getType()->getAs<PointerType>()) { 3002 AS = PtrTy->getPointeeType().getAddressSpace(); 3003 } 3004 Ty = Context.getPointerType( 3005 Context.getAddrSpaceQualType(ValType.getUnqualifiedType(), AS)); 3006 } 3007 break; 3008 case 2: 3009 // The third argument to compare_exchange / GNU exchange is a 3010 // (pointer to a) desired value. 3011 Ty = ByValType; 3012 break; 3013 case 3: 3014 // The fourth argument to GNU compare_exchange is a 'weak' flag. 3015 Ty = Context.BoolTy; 3016 break; 3017 } 3018 } else { 3019 // The order(s) are always converted to int. 3020 Ty = Context.IntTy; 3021 } 3022 3023 InitializedEntity Entity = 3024 InitializedEntity::InitializeParameter(Context, Ty, false); 3025 ExprResult Arg = TheCall->getArg(i); 3026 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 3027 if (Arg.isInvalid()) 3028 return true; 3029 TheCall->setArg(i, Arg.get()); 3030 } 3031 3032 // Permute the arguments into a 'consistent' order. 3033 SmallVector<Expr*, 5> SubExprs; 3034 SubExprs.push_back(Ptr); 3035 switch (Form) { 3036 case Init: 3037 // Note, AtomicExpr::getVal1() has a special case for this atomic. 3038 SubExprs.push_back(TheCall->getArg(1)); // Val1 3039 break; 3040 case Load: 3041 SubExprs.push_back(TheCall->getArg(1)); // Order 3042 break; 3043 case LoadCopy: 3044 case Copy: 3045 case Arithmetic: 3046 case Xchg: 3047 SubExprs.push_back(TheCall->getArg(2)); // Order 3048 SubExprs.push_back(TheCall->getArg(1)); // Val1 3049 break; 3050 case GNUXchg: 3051 // Note, AtomicExpr::getVal2() has a special case for this atomic. 3052 SubExprs.push_back(TheCall->getArg(3)); // Order 3053 SubExprs.push_back(TheCall->getArg(1)); // Val1 3054 SubExprs.push_back(TheCall->getArg(2)); // Val2 3055 break; 3056 case C11CmpXchg: 3057 SubExprs.push_back(TheCall->getArg(3)); // Order 3058 SubExprs.push_back(TheCall->getArg(1)); // Val1 3059 SubExprs.push_back(TheCall->getArg(4)); // OrderFail 3060 SubExprs.push_back(TheCall->getArg(2)); // Val2 3061 break; 3062 case GNUCmpXchg: 3063 SubExprs.push_back(TheCall->getArg(4)); // Order 3064 SubExprs.push_back(TheCall->getArg(1)); // Val1 3065 SubExprs.push_back(TheCall->getArg(5)); // OrderFail 3066 SubExprs.push_back(TheCall->getArg(2)); // Val2 3067 SubExprs.push_back(TheCall->getArg(3)); // Weak 3068 break; 3069 } 3070 3071 if (SubExprs.size() >= 2 && Form != Init) { 3072 llvm::APSInt Result(32); 3073 if (SubExprs[1]->isIntegerConstantExpr(Result, Context) && 3074 !isValidOrderingForOp(Result.getSExtValue(), Op)) 3075 Diag(SubExprs[1]->getLocStart(), 3076 diag::warn_atomic_op_has_invalid_memory_order) 3077 << SubExprs[1]->getSourceRange(); 3078 } 3079 3080 AtomicExpr *AE = new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(), 3081 SubExprs, ResultType, Op, 3082 TheCall->getRParenLoc()); 3083 3084 if ((Op == AtomicExpr::AO__c11_atomic_load || 3085 (Op == AtomicExpr::AO__c11_atomic_store)) && 3086 Context.AtomicUsesUnsupportedLibcall(AE)) 3087 Diag(AE->getLocStart(), diag::err_atomic_load_store_uses_lib) << 3088 ((Op == AtomicExpr::AO__c11_atomic_load) ? 0 : 1); 3089 3090 return AE; 3091 } 3092 3093 /// checkBuiltinArgument - Given a call to a builtin function, perform 3094 /// normal type-checking on the given argument, updating the call in 3095 /// place. This is useful when a builtin function requires custom 3096 /// type-checking for some of its arguments but not necessarily all of 3097 /// them. 3098 /// 3099 /// Returns true on error. 3100 static bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) { 3101 FunctionDecl *Fn = E->getDirectCallee(); 3102 assert(Fn && "builtin call without direct callee!"); 3103 3104 ParmVarDecl *Param = Fn->getParamDecl(ArgIndex); 3105 InitializedEntity Entity = 3106 InitializedEntity::InitializeParameter(S.Context, Param); 3107 3108 ExprResult Arg = E->getArg(0); 3109 Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg); 3110 if (Arg.isInvalid()) 3111 return true; 3112 3113 E->setArg(ArgIndex, Arg.get()); 3114 return false; 3115 } 3116 3117 /// SemaBuiltinAtomicOverloaded - We have a call to a function like 3118 /// __sync_fetch_and_add, which is an overloaded function based on the pointer 3119 /// type of its first argument. The main ActOnCallExpr routines have already 3120 /// promoted the types of arguments because all of these calls are prototyped as 3121 /// void(...). 3122 /// 3123 /// This function goes through and does final semantic checking for these 3124 /// builtins, 3125 ExprResult 3126 Sema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 3127 CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 3128 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 3129 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 3130 3131 // Ensure that we have at least one argument to do type inference from. 3132 if (TheCall->getNumArgs() < 1) { 3133 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 3134 << 0 << 1 << TheCall->getNumArgs() 3135 << TheCall->getCallee()->getSourceRange(); 3136 return ExprError(); 3137 } 3138 3139 // Inspect the first argument of the atomic builtin. This should always be 3140 // a pointer type, whose element is an integral scalar or pointer type. 3141 // Because it is a pointer type, we don't have to worry about any implicit 3142 // casts here. 3143 // FIXME: We don't allow floating point scalars as input. 3144 Expr *FirstArg = TheCall->getArg(0); 3145 ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg); 3146 if (FirstArgResult.isInvalid()) 3147 return ExprError(); 3148 FirstArg = FirstArgResult.get(); 3149 TheCall->setArg(0, FirstArg); 3150 3151 const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>(); 3152 if (!pointerType) { 3153 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 3154 << FirstArg->getType() << FirstArg->getSourceRange(); 3155 return ExprError(); 3156 } 3157 3158 QualType ValType = pointerType->getPointeeType(); 3159 if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 3160 !ValType->isBlockPointerType()) { 3161 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 3162 << FirstArg->getType() << FirstArg->getSourceRange(); 3163 return ExprError(); 3164 } 3165 3166 switch (ValType.getObjCLifetime()) { 3167 case Qualifiers::OCL_None: 3168 case Qualifiers::OCL_ExplicitNone: 3169 // okay 3170 break; 3171 3172 case Qualifiers::OCL_Weak: 3173 case Qualifiers::OCL_Strong: 3174 case Qualifiers::OCL_Autoreleasing: 3175 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 3176 << ValType << FirstArg->getSourceRange(); 3177 return ExprError(); 3178 } 3179 3180 // Strip any qualifiers off ValType. 3181 ValType = ValType.getUnqualifiedType(); 3182 3183 // The majority of builtins return a value, but a few have special return 3184 // types, so allow them to override appropriately below. 3185 QualType ResultType = ValType; 3186 3187 // We need to figure out which concrete builtin this maps onto. For example, 3188 // __sync_fetch_and_add with a 2 byte object turns into 3189 // __sync_fetch_and_add_2. 3190 #define BUILTIN_ROW(x) \ 3191 { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 3192 Builtin::BI##x##_8, Builtin::BI##x##_16 } 3193 3194 static const unsigned BuiltinIndices[][5] = { 3195 BUILTIN_ROW(__sync_fetch_and_add), 3196 BUILTIN_ROW(__sync_fetch_and_sub), 3197 BUILTIN_ROW(__sync_fetch_and_or), 3198 BUILTIN_ROW(__sync_fetch_and_and), 3199 BUILTIN_ROW(__sync_fetch_and_xor), 3200 BUILTIN_ROW(__sync_fetch_and_nand), 3201 3202 BUILTIN_ROW(__sync_add_and_fetch), 3203 BUILTIN_ROW(__sync_sub_and_fetch), 3204 BUILTIN_ROW(__sync_and_and_fetch), 3205 BUILTIN_ROW(__sync_or_and_fetch), 3206 BUILTIN_ROW(__sync_xor_and_fetch), 3207 BUILTIN_ROW(__sync_nand_and_fetch), 3208 3209 BUILTIN_ROW(__sync_val_compare_and_swap), 3210 BUILTIN_ROW(__sync_bool_compare_and_swap), 3211 BUILTIN_ROW(__sync_lock_test_and_set), 3212 BUILTIN_ROW(__sync_lock_release), 3213 BUILTIN_ROW(__sync_swap) 3214 }; 3215 #undef BUILTIN_ROW 3216 3217 // Determine the index of the size. 3218 unsigned SizeIndex; 3219 switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 3220 case 1: SizeIndex = 0; break; 3221 case 2: SizeIndex = 1; break; 3222 case 4: SizeIndex = 2; break; 3223 case 8: SizeIndex = 3; break; 3224 case 16: SizeIndex = 4; break; 3225 default: 3226 Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 3227 << FirstArg->getType() << FirstArg->getSourceRange(); 3228 return ExprError(); 3229 } 3230 3231 // Each of these builtins has one pointer argument, followed by some number of 3232 // values (0, 1 or 2) followed by a potentially empty varags list of stuff 3233 // that we ignore. Find out which row of BuiltinIndices to read from as well 3234 // as the number of fixed args. 3235 unsigned BuiltinID = FDecl->getBuiltinID(); 3236 unsigned BuiltinIndex, NumFixed = 1; 3237 bool WarnAboutSemanticsChange = false; 3238 switch (BuiltinID) { 3239 default: llvm_unreachable("Unknown overloaded atomic builtin!"); 3240 case Builtin::BI__sync_fetch_and_add: 3241 case Builtin::BI__sync_fetch_and_add_1: 3242 case Builtin::BI__sync_fetch_and_add_2: 3243 case Builtin::BI__sync_fetch_and_add_4: 3244 case Builtin::BI__sync_fetch_and_add_8: 3245 case Builtin::BI__sync_fetch_and_add_16: 3246 BuiltinIndex = 0; 3247 break; 3248 3249 case Builtin::BI__sync_fetch_and_sub: 3250 case Builtin::BI__sync_fetch_and_sub_1: 3251 case Builtin::BI__sync_fetch_and_sub_2: 3252 case Builtin::BI__sync_fetch_and_sub_4: 3253 case Builtin::BI__sync_fetch_and_sub_8: 3254 case Builtin::BI__sync_fetch_and_sub_16: 3255 BuiltinIndex = 1; 3256 break; 3257 3258 case Builtin::BI__sync_fetch_and_or: 3259 case Builtin::BI__sync_fetch_and_or_1: 3260 case Builtin::BI__sync_fetch_and_or_2: 3261 case Builtin::BI__sync_fetch_and_or_4: 3262 case Builtin::BI__sync_fetch_and_or_8: 3263 case Builtin::BI__sync_fetch_and_or_16: 3264 BuiltinIndex = 2; 3265 break; 3266 3267 case Builtin::BI__sync_fetch_and_and: 3268 case Builtin::BI__sync_fetch_and_and_1: 3269 case Builtin::BI__sync_fetch_and_and_2: 3270 case Builtin::BI__sync_fetch_and_and_4: 3271 case Builtin::BI__sync_fetch_and_and_8: 3272 case Builtin::BI__sync_fetch_and_and_16: 3273 BuiltinIndex = 3; 3274 break; 3275 3276 case Builtin::BI__sync_fetch_and_xor: 3277 case Builtin::BI__sync_fetch_and_xor_1: 3278 case Builtin::BI__sync_fetch_and_xor_2: 3279 case Builtin::BI__sync_fetch_and_xor_4: 3280 case Builtin::BI__sync_fetch_and_xor_8: 3281 case Builtin::BI__sync_fetch_and_xor_16: 3282 BuiltinIndex = 4; 3283 break; 3284 3285 case Builtin::BI__sync_fetch_and_nand: 3286 case Builtin::BI__sync_fetch_and_nand_1: 3287 case Builtin::BI__sync_fetch_and_nand_2: 3288 case Builtin::BI__sync_fetch_and_nand_4: 3289 case Builtin::BI__sync_fetch_and_nand_8: 3290 case Builtin::BI__sync_fetch_and_nand_16: 3291 BuiltinIndex = 5; 3292 WarnAboutSemanticsChange = true; 3293 break; 3294 3295 case Builtin::BI__sync_add_and_fetch: 3296 case Builtin::BI__sync_add_and_fetch_1: 3297 case Builtin::BI__sync_add_and_fetch_2: 3298 case Builtin::BI__sync_add_and_fetch_4: 3299 case Builtin::BI__sync_add_and_fetch_8: 3300 case Builtin::BI__sync_add_and_fetch_16: 3301 BuiltinIndex = 6; 3302 break; 3303 3304 case Builtin::BI__sync_sub_and_fetch: 3305 case Builtin::BI__sync_sub_and_fetch_1: 3306 case Builtin::BI__sync_sub_and_fetch_2: 3307 case Builtin::BI__sync_sub_and_fetch_4: 3308 case Builtin::BI__sync_sub_and_fetch_8: 3309 case Builtin::BI__sync_sub_and_fetch_16: 3310 BuiltinIndex = 7; 3311 break; 3312 3313 case Builtin::BI__sync_and_and_fetch: 3314 case Builtin::BI__sync_and_and_fetch_1: 3315 case Builtin::BI__sync_and_and_fetch_2: 3316 case Builtin::BI__sync_and_and_fetch_4: 3317 case Builtin::BI__sync_and_and_fetch_8: 3318 case Builtin::BI__sync_and_and_fetch_16: 3319 BuiltinIndex = 8; 3320 break; 3321 3322 case Builtin::BI__sync_or_and_fetch: 3323 case Builtin::BI__sync_or_and_fetch_1: 3324 case Builtin::BI__sync_or_and_fetch_2: 3325 case Builtin::BI__sync_or_and_fetch_4: 3326 case Builtin::BI__sync_or_and_fetch_8: 3327 case Builtin::BI__sync_or_and_fetch_16: 3328 BuiltinIndex = 9; 3329 break; 3330 3331 case Builtin::BI__sync_xor_and_fetch: 3332 case Builtin::BI__sync_xor_and_fetch_1: 3333 case Builtin::BI__sync_xor_and_fetch_2: 3334 case Builtin::BI__sync_xor_and_fetch_4: 3335 case Builtin::BI__sync_xor_and_fetch_8: 3336 case Builtin::BI__sync_xor_and_fetch_16: 3337 BuiltinIndex = 10; 3338 break; 3339 3340 case Builtin::BI__sync_nand_and_fetch: 3341 case Builtin::BI__sync_nand_and_fetch_1: 3342 case Builtin::BI__sync_nand_and_fetch_2: 3343 case Builtin::BI__sync_nand_and_fetch_4: 3344 case Builtin::BI__sync_nand_and_fetch_8: 3345 case Builtin::BI__sync_nand_and_fetch_16: 3346 BuiltinIndex = 11; 3347 WarnAboutSemanticsChange = true; 3348 break; 3349 3350 case Builtin::BI__sync_val_compare_and_swap: 3351 case Builtin::BI__sync_val_compare_and_swap_1: 3352 case Builtin::BI__sync_val_compare_and_swap_2: 3353 case Builtin::BI__sync_val_compare_and_swap_4: 3354 case Builtin::BI__sync_val_compare_and_swap_8: 3355 case Builtin::BI__sync_val_compare_and_swap_16: 3356 BuiltinIndex = 12; 3357 NumFixed = 2; 3358 break; 3359 3360 case Builtin::BI__sync_bool_compare_and_swap: 3361 case Builtin::BI__sync_bool_compare_and_swap_1: 3362 case Builtin::BI__sync_bool_compare_and_swap_2: 3363 case Builtin::BI__sync_bool_compare_and_swap_4: 3364 case Builtin::BI__sync_bool_compare_and_swap_8: 3365 case Builtin::BI__sync_bool_compare_and_swap_16: 3366 BuiltinIndex = 13; 3367 NumFixed = 2; 3368 ResultType = Context.BoolTy; 3369 break; 3370 3371 case Builtin::BI__sync_lock_test_and_set: 3372 case Builtin::BI__sync_lock_test_and_set_1: 3373 case Builtin::BI__sync_lock_test_and_set_2: 3374 case Builtin::BI__sync_lock_test_and_set_4: 3375 case Builtin::BI__sync_lock_test_and_set_8: 3376 case Builtin::BI__sync_lock_test_and_set_16: 3377 BuiltinIndex = 14; 3378 break; 3379 3380 case Builtin::BI__sync_lock_release: 3381 case Builtin::BI__sync_lock_release_1: 3382 case Builtin::BI__sync_lock_release_2: 3383 case Builtin::BI__sync_lock_release_4: 3384 case Builtin::BI__sync_lock_release_8: 3385 case Builtin::BI__sync_lock_release_16: 3386 BuiltinIndex = 15; 3387 NumFixed = 0; 3388 ResultType = Context.VoidTy; 3389 break; 3390 3391 case Builtin::BI__sync_swap: 3392 case Builtin::BI__sync_swap_1: 3393 case Builtin::BI__sync_swap_2: 3394 case Builtin::BI__sync_swap_4: 3395 case Builtin::BI__sync_swap_8: 3396 case Builtin::BI__sync_swap_16: 3397 BuiltinIndex = 16; 3398 break; 3399 } 3400 3401 // Now that we know how many fixed arguments we expect, first check that we 3402 // have at least that many. 3403 if (TheCall->getNumArgs() < 1+NumFixed) { 3404 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 3405 << 0 << 1+NumFixed << TheCall->getNumArgs() 3406 << TheCall->getCallee()->getSourceRange(); 3407 return ExprError(); 3408 } 3409 3410 if (WarnAboutSemanticsChange) { 3411 Diag(TheCall->getLocEnd(), diag::warn_sync_fetch_and_nand_semantics_change) 3412 << TheCall->getCallee()->getSourceRange(); 3413 } 3414 3415 // Get the decl for the concrete builtin from this, we can tell what the 3416 // concrete integer type we should convert to is. 3417 unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 3418 const char *NewBuiltinName = Context.BuiltinInfo.getName(NewBuiltinID); 3419 FunctionDecl *NewBuiltinDecl; 3420 if (NewBuiltinID == BuiltinID) 3421 NewBuiltinDecl = FDecl; 3422 else { 3423 // Perform builtin lookup to avoid redeclaring it. 3424 DeclarationName DN(&Context.Idents.get(NewBuiltinName)); 3425 LookupResult Res(*this, DN, DRE->getLocStart(), LookupOrdinaryName); 3426 LookupName(Res, TUScope, /*AllowBuiltinCreation=*/true); 3427 assert(Res.getFoundDecl()); 3428 NewBuiltinDecl = dyn_cast<FunctionDecl>(Res.getFoundDecl()); 3429 if (!NewBuiltinDecl) 3430 return ExprError(); 3431 } 3432 3433 // The first argument --- the pointer --- has a fixed type; we 3434 // deduce the types of the rest of the arguments accordingly. Walk 3435 // the remaining arguments, converting them to the deduced value type. 3436 for (unsigned i = 0; i != NumFixed; ++i) { 3437 ExprResult Arg = TheCall->getArg(i+1); 3438 3439 // GCC does an implicit conversion to the pointer or integer ValType. This 3440 // can fail in some cases (1i -> int**), check for this error case now. 3441 // Initialize the argument. 3442 InitializedEntity Entity = InitializedEntity::InitializeParameter(Context, 3443 ValType, /*consume*/ false); 3444 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 3445 if (Arg.isInvalid()) 3446 return ExprError(); 3447 3448 // Okay, we have something that *can* be converted to the right type. Check 3449 // to see if there is a potentially weird extension going on here. This can 3450 // happen when you do an atomic operation on something like an char* and 3451 // pass in 42. The 42 gets converted to char. This is even more strange 3452 // for things like 45.123 -> char, etc. 3453 // FIXME: Do this check. 3454 TheCall->setArg(i+1, Arg.get()); 3455 } 3456 3457 ASTContext& Context = this->getASTContext(); 3458 3459 // Create a new DeclRefExpr to refer to the new decl. 3460 DeclRefExpr* NewDRE = DeclRefExpr::Create( 3461 Context, 3462 DRE->getQualifierLoc(), 3463 SourceLocation(), 3464 NewBuiltinDecl, 3465 /*enclosing*/ false, 3466 DRE->getLocation(), 3467 Context.BuiltinFnTy, 3468 DRE->getValueKind()); 3469 3470 // Set the callee in the CallExpr. 3471 // FIXME: This loses syntactic information. 3472 QualType CalleePtrTy = Context.getPointerType(NewBuiltinDecl->getType()); 3473 ExprResult PromotedCall = ImpCastExprToType(NewDRE, CalleePtrTy, 3474 CK_BuiltinFnToFnPtr); 3475 TheCall->setCallee(PromotedCall.get()); 3476 3477 // Change the result type of the call to match the original value type. This 3478 // is arbitrary, but the codegen for these builtins ins design to handle it 3479 // gracefully. 3480 TheCall->setType(ResultType); 3481 3482 return TheCallResult; 3483 } 3484 3485 /// SemaBuiltinNontemporalOverloaded - We have a call to 3486 /// __builtin_nontemporal_store or __builtin_nontemporal_load, which is an 3487 /// overloaded function based on the pointer type of its last argument. 3488 /// 3489 /// This function goes through and does final semantic checking for these 3490 /// builtins. 3491 ExprResult Sema::SemaBuiltinNontemporalOverloaded(ExprResult TheCallResult) { 3492 CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 3493 DeclRefExpr *DRE = 3494 cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 3495 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 3496 unsigned BuiltinID = FDecl->getBuiltinID(); 3497 assert((BuiltinID == Builtin::BI__builtin_nontemporal_store || 3498 BuiltinID == Builtin::BI__builtin_nontemporal_load) && 3499 "Unexpected nontemporal load/store builtin!"); 3500 bool isStore = BuiltinID == Builtin::BI__builtin_nontemporal_store; 3501 unsigned numArgs = isStore ? 2 : 1; 3502 3503 // Ensure that we have the proper number of arguments. 3504 if (checkArgCount(*this, TheCall, numArgs)) 3505 return ExprError(); 3506 3507 // Inspect the last argument of the nontemporal builtin. This should always 3508 // be a pointer type, from which we imply the type of the memory access. 3509 // Because it is a pointer type, we don't have to worry about any implicit 3510 // casts here. 3511 Expr *PointerArg = TheCall->getArg(numArgs - 1); 3512 ExprResult PointerArgResult = 3513 DefaultFunctionArrayLvalueConversion(PointerArg); 3514 3515 if (PointerArgResult.isInvalid()) 3516 return ExprError(); 3517 PointerArg = PointerArgResult.get(); 3518 TheCall->setArg(numArgs - 1, PointerArg); 3519 3520 const PointerType *pointerType = PointerArg->getType()->getAs<PointerType>(); 3521 if (!pointerType) { 3522 Diag(DRE->getLocStart(), diag::err_nontemporal_builtin_must_be_pointer) 3523 << PointerArg->getType() << PointerArg->getSourceRange(); 3524 return ExprError(); 3525 } 3526 3527 QualType ValType = pointerType->getPointeeType(); 3528 3529 // Strip any qualifiers off ValType. 3530 ValType = ValType.getUnqualifiedType(); 3531 if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 3532 !ValType->isBlockPointerType() && !ValType->isFloatingType() && 3533 !ValType->isVectorType()) { 3534 Diag(DRE->getLocStart(), 3535 diag::err_nontemporal_builtin_must_be_pointer_intfltptr_or_vector) 3536 << PointerArg->getType() << PointerArg->getSourceRange(); 3537 return ExprError(); 3538 } 3539 3540 if (!isStore) { 3541 TheCall->setType(ValType); 3542 return TheCallResult; 3543 } 3544 3545 ExprResult ValArg = TheCall->getArg(0); 3546 InitializedEntity Entity = InitializedEntity::InitializeParameter( 3547 Context, ValType, /*consume*/ false); 3548 ValArg = PerformCopyInitialization(Entity, SourceLocation(), ValArg); 3549 if (ValArg.isInvalid()) 3550 return ExprError(); 3551 3552 TheCall->setArg(0, ValArg.get()); 3553 TheCall->setType(Context.VoidTy); 3554 return TheCallResult; 3555 } 3556 3557 /// CheckObjCString - Checks that the argument to the builtin 3558 /// CFString constructor is correct 3559 /// Note: It might also make sense to do the UTF-16 conversion here (would 3560 /// simplify the backend). 3561 bool Sema::CheckObjCString(Expr *Arg) { 3562 Arg = Arg->IgnoreParenCasts(); 3563 StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 3564 3565 if (!Literal || !Literal->isAscii()) { 3566 Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 3567 << Arg->getSourceRange(); 3568 return true; 3569 } 3570 3571 if (Literal->containsNonAsciiOrNull()) { 3572 StringRef String = Literal->getString(); 3573 unsigned NumBytes = String.size(); 3574 SmallVector<llvm::UTF16, 128> ToBuf(NumBytes); 3575 const llvm::UTF8 *FromPtr = (const llvm::UTF8 *)String.data(); 3576 llvm::UTF16 *ToPtr = &ToBuf[0]; 3577 3578 llvm::ConversionResult Result = 3579 llvm::ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, &ToPtr, 3580 ToPtr + NumBytes, llvm::strictConversion); 3581 // Check for conversion failure. 3582 if (Result != llvm::conversionOK) 3583 Diag(Arg->getLocStart(), 3584 diag::warn_cfstring_truncated) << Arg->getSourceRange(); 3585 } 3586 return false; 3587 } 3588 3589 /// CheckObjCString - Checks that the format string argument to the os_log() 3590 /// and os_trace() functions is correct, and converts it to const char *. 3591 ExprResult Sema::CheckOSLogFormatStringArg(Expr *Arg) { 3592 Arg = Arg->IgnoreParenCasts(); 3593 auto *Literal = dyn_cast<StringLiteral>(Arg); 3594 if (!Literal) { 3595 if (auto *ObjcLiteral = dyn_cast<ObjCStringLiteral>(Arg)) { 3596 Literal = ObjcLiteral->getString(); 3597 } 3598 } 3599 3600 if (!Literal || (!Literal->isAscii() && !Literal->isUTF8())) { 3601 return ExprError( 3602 Diag(Arg->getLocStart(), diag::err_os_log_format_not_string_constant) 3603 << Arg->getSourceRange()); 3604 } 3605 3606 ExprResult Result(Literal); 3607 QualType ResultTy = Context.getPointerType(Context.CharTy.withConst()); 3608 InitializedEntity Entity = 3609 InitializedEntity::InitializeParameter(Context, ResultTy, false); 3610 Result = PerformCopyInitialization(Entity, SourceLocation(), Result); 3611 return Result; 3612 } 3613 3614 /// Check that the user is calling the appropriate va_start builtin for the 3615 /// target and calling convention. 3616 static bool checkVAStartABI(Sema &S, unsigned BuiltinID, Expr *Fn) { 3617 const llvm::Triple &TT = S.Context.getTargetInfo().getTriple(); 3618 bool IsX64 = TT.getArch() == llvm::Triple::x86_64; 3619 bool IsWindows = TT.isOSWindows(); 3620 bool IsMSVAStart = BuiltinID == X86::BI__builtin_ms_va_start; 3621 if (IsX64) { 3622 clang::CallingConv CC = CC_C; 3623 if (const FunctionDecl *FD = S.getCurFunctionDecl()) 3624 CC = FD->getType()->getAs<FunctionType>()->getCallConv(); 3625 if (IsMSVAStart) { 3626 // Don't allow this in System V ABI functions. 3627 if (CC == CC_X86_64SysV || (!IsWindows && CC != CC_X86_64Win64)) 3628 return S.Diag(Fn->getLocStart(), 3629 diag::err_ms_va_start_used_in_sysv_function); 3630 } else { 3631 // On x86-64 Unix, don't allow this in Win64 ABI functions. 3632 // On x64 Windows, don't allow this in System V ABI functions. 3633 // (Yes, that means there's no corresponding way to support variadic 3634 // System V ABI functions on Windows.) 3635 if ((IsWindows && CC == CC_X86_64SysV) || 3636 (!IsWindows && CC == CC_X86_64Win64)) 3637 return S.Diag(Fn->getLocStart(), 3638 diag::err_va_start_used_in_wrong_abi_function) 3639 << !IsWindows; 3640 } 3641 return false; 3642 } 3643 3644 if (IsMSVAStart) 3645 return S.Diag(Fn->getLocStart(), diag::err_x86_builtin_64_only); 3646 return false; 3647 } 3648 3649 static bool checkVAStartIsInVariadicFunction(Sema &S, Expr *Fn, 3650 ParmVarDecl **LastParam = nullptr) { 3651 // Determine whether the current function, block, or obj-c method is variadic 3652 // and get its parameter list. 3653 bool IsVariadic = false; 3654 ArrayRef<ParmVarDecl *> Params; 3655 DeclContext *Caller = S.CurContext; 3656 if (auto *Block = dyn_cast<BlockDecl>(Caller)) { 3657 IsVariadic = Block->isVariadic(); 3658 Params = Block->parameters(); 3659 } else if (auto *FD = dyn_cast<FunctionDecl>(Caller)) { 3660 IsVariadic = FD->isVariadic(); 3661 Params = FD->parameters(); 3662 } else if (auto *MD = dyn_cast<ObjCMethodDecl>(Caller)) { 3663 IsVariadic = MD->isVariadic(); 3664 // FIXME: This isn't correct for methods (results in bogus warning). 3665 Params = MD->parameters(); 3666 } else if (isa<CapturedDecl>(Caller)) { 3667 // We don't support va_start in a CapturedDecl. 3668 S.Diag(Fn->getLocStart(), diag::err_va_start_captured_stmt); 3669 return true; 3670 } else { 3671 // This must be some other declcontext that parses exprs. 3672 S.Diag(Fn->getLocStart(), diag::err_va_start_outside_function); 3673 return true; 3674 } 3675 3676 if (!IsVariadic) { 3677 S.Diag(Fn->getLocStart(), diag::err_va_start_fixed_function); 3678 return true; 3679 } 3680 3681 if (LastParam) 3682 *LastParam = Params.empty() ? nullptr : Params.back(); 3683 3684 return false; 3685 } 3686 3687 /// Check the arguments to '__builtin_va_start' or '__builtin_ms_va_start' 3688 /// for validity. Emit an error and return true on failure; return false 3689 /// on success. 3690 bool Sema::SemaBuiltinVAStart(unsigned BuiltinID, CallExpr *TheCall) { 3691 Expr *Fn = TheCall->getCallee(); 3692 3693 if (checkVAStartABI(*this, BuiltinID, Fn)) 3694 return true; 3695 3696 if (TheCall->getNumArgs() > 2) { 3697 Diag(TheCall->getArg(2)->getLocStart(), 3698 diag::err_typecheck_call_too_many_args) 3699 << 0 /*function call*/ << 2 << TheCall->getNumArgs() 3700 << Fn->getSourceRange() 3701 << SourceRange(TheCall->getArg(2)->getLocStart(), 3702 (*(TheCall->arg_end()-1))->getLocEnd()); 3703 return true; 3704 } 3705 3706 if (TheCall->getNumArgs() < 2) { 3707 return Diag(TheCall->getLocEnd(), 3708 diag::err_typecheck_call_too_few_args_at_least) 3709 << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 3710 } 3711 3712 // Type-check the first argument normally. 3713 if (checkBuiltinArgument(*this, TheCall, 0)) 3714 return true; 3715 3716 // Check that the current function is variadic, and get its last parameter. 3717 ParmVarDecl *LastParam; 3718 if (checkVAStartIsInVariadicFunction(*this, Fn, &LastParam)) 3719 return true; 3720 3721 // Verify that the second argument to the builtin is the last argument of the 3722 // current function or method. 3723 bool SecondArgIsLastNamedArgument = false; 3724 const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 3725 3726 // These are valid if SecondArgIsLastNamedArgument is false after the next 3727 // block. 3728 QualType Type; 3729 SourceLocation ParamLoc; 3730 bool IsCRegister = false; 3731 3732 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 3733 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 3734 SecondArgIsLastNamedArgument = PV == LastParam; 3735 3736 Type = PV->getType(); 3737 ParamLoc = PV->getLocation(); 3738 IsCRegister = 3739 PV->getStorageClass() == SC_Register && !getLangOpts().CPlusPlus; 3740 } 3741 } 3742 3743 if (!SecondArgIsLastNamedArgument) 3744 Diag(TheCall->getArg(1)->getLocStart(), 3745 diag::warn_second_arg_of_va_start_not_last_named_param); 3746 else if (IsCRegister || Type->isReferenceType() || 3747 Type->isSpecificBuiltinType(BuiltinType::Float) || [=] { 3748 // Promotable integers are UB, but enumerations need a bit of 3749 // extra checking to see what their promotable type actually is. 3750 if (!Type->isPromotableIntegerType()) 3751 return false; 3752 if (!Type->isEnumeralType()) 3753 return true; 3754 const EnumDecl *ED = Type->getAs<EnumType>()->getDecl(); 3755 return !(ED && 3756 Context.typesAreCompatible(ED->getPromotionType(), Type)); 3757 }()) { 3758 unsigned Reason = 0; 3759 if (Type->isReferenceType()) Reason = 1; 3760 else if (IsCRegister) Reason = 2; 3761 Diag(Arg->getLocStart(), diag::warn_va_start_type_is_undefined) << Reason; 3762 Diag(ParamLoc, diag::note_parameter_type) << Type; 3763 } 3764 3765 TheCall->setType(Context.VoidTy); 3766 return false; 3767 } 3768 3769 bool Sema::SemaBuiltinVAStartARM(CallExpr *Call) { 3770 // void __va_start(va_list *ap, const char *named_addr, size_t slot_size, 3771 // const char *named_addr); 3772 3773 Expr *Func = Call->getCallee(); 3774 3775 if (Call->getNumArgs() < 3) 3776 return Diag(Call->getLocEnd(), 3777 diag::err_typecheck_call_too_few_args_at_least) 3778 << 0 /*function call*/ << 3 << Call->getNumArgs(); 3779 3780 // Type-check the first argument normally. 3781 if (checkBuiltinArgument(*this, Call, 0)) 3782 return true; 3783 3784 // Check that the current function is variadic. 3785 if (checkVAStartIsInVariadicFunction(*this, Func)) 3786 return true; 3787 3788 const struct { 3789 unsigned ArgNo; 3790 QualType Type; 3791 } ArgumentTypes[] = { 3792 { 1, Context.getPointerType(Context.CharTy.withConst()) }, 3793 { 2, Context.getSizeType() }, 3794 }; 3795 3796 for (const auto &AT : ArgumentTypes) { 3797 const Expr *Arg = Call->getArg(AT.ArgNo)->IgnoreParens(); 3798 if (Arg->getType().getCanonicalType() == AT.Type.getCanonicalType()) 3799 continue; 3800 Diag(Arg->getLocStart(), diag::err_typecheck_convert_incompatible) 3801 << Arg->getType() << AT.Type << 1 /* different class */ 3802 << 0 /* qualifier difference */ << 3 /* parameter mismatch */ 3803 << AT.ArgNo + 1 << Arg->getType() << AT.Type; 3804 } 3805 3806 return false; 3807 } 3808 3809 /// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 3810 /// friends. This is declared to take (...), so we have to check everything. 3811 bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 3812 if (TheCall->getNumArgs() < 2) 3813 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 3814 << 0 << 2 << TheCall->getNumArgs()/*function call*/; 3815 if (TheCall->getNumArgs() > 2) 3816 return Diag(TheCall->getArg(2)->getLocStart(), 3817 diag::err_typecheck_call_too_many_args) 3818 << 0 /*function call*/ << 2 << TheCall->getNumArgs() 3819 << SourceRange(TheCall->getArg(2)->getLocStart(), 3820 (*(TheCall->arg_end()-1))->getLocEnd()); 3821 3822 ExprResult OrigArg0 = TheCall->getArg(0); 3823 ExprResult OrigArg1 = TheCall->getArg(1); 3824 3825 // Do standard promotions between the two arguments, returning their common 3826 // type. 3827 QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 3828 if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 3829 return true; 3830 3831 // Make sure any conversions are pushed back into the call; this is 3832 // type safe since unordered compare builtins are declared as "_Bool 3833 // foo(...)". 3834 TheCall->setArg(0, OrigArg0.get()); 3835 TheCall->setArg(1, OrigArg1.get()); 3836 3837 if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 3838 return false; 3839 3840 // If the common type isn't a real floating type, then the arguments were 3841 // invalid for this operation. 3842 if (Res.isNull() || !Res->isRealFloatingType()) 3843 return Diag(OrigArg0.get()->getLocStart(), 3844 diag::err_typecheck_call_invalid_ordered_compare) 3845 << OrigArg0.get()->getType() << OrigArg1.get()->getType() 3846 << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 3847 3848 return false; 3849 } 3850 3851 /// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 3852 /// __builtin_isnan and friends. This is declared to take (...), so we have 3853 /// to check everything. We expect the last argument to be a floating point 3854 /// value. 3855 bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 3856 if (TheCall->getNumArgs() < NumArgs) 3857 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 3858 << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 3859 if (TheCall->getNumArgs() > NumArgs) 3860 return Diag(TheCall->getArg(NumArgs)->getLocStart(), 3861 diag::err_typecheck_call_too_many_args) 3862 << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 3863 << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 3864 (*(TheCall->arg_end()-1))->getLocEnd()); 3865 3866 Expr *OrigArg = TheCall->getArg(NumArgs-1); 3867 3868 if (OrigArg->isTypeDependent()) 3869 return false; 3870 3871 // This operation requires a non-_Complex floating-point number. 3872 if (!OrigArg->getType()->isRealFloatingType()) 3873 return Diag(OrigArg->getLocStart(), 3874 diag::err_typecheck_call_invalid_unary_fp) 3875 << OrigArg->getType() << OrigArg->getSourceRange(); 3876 3877 // If this is an implicit conversion from float -> float or double, remove it. 3878 if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 3879 // Only remove standard FloatCasts, leaving other casts inplace 3880 if (Cast->getCastKind() == CK_FloatingCast) { 3881 Expr *CastArg = Cast->getSubExpr(); 3882 if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 3883 assert((Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) || 3884 Cast->getType()->isSpecificBuiltinType(BuiltinType::Float)) && 3885 "promotion from float to either float or double is the only expected cast here"); 3886 Cast->setSubExpr(nullptr); 3887 TheCall->setArg(NumArgs-1, CastArg); 3888 } 3889 } 3890 } 3891 3892 return false; 3893 } 3894 3895 /// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 3896 // This is declared to take (...), so we have to check everything. 3897 ExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 3898 if (TheCall->getNumArgs() < 2) 3899 return ExprError(Diag(TheCall->getLocEnd(), 3900 diag::err_typecheck_call_too_few_args_at_least) 3901 << 0 /*function call*/ << 2 << TheCall->getNumArgs() 3902 << TheCall->getSourceRange()); 3903 3904 // Determine which of the following types of shufflevector we're checking: 3905 // 1) unary, vector mask: (lhs, mask) 3906 // 2) binary, scalar mask: (lhs, rhs, index, ..., index) 3907 QualType resType = TheCall->getArg(0)->getType(); 3908 unsigned numElements = 0; 3909 3910 if (!TheCall->getArg(0)->isTypeDependent() && 3911 !TheCall->getArg(1)->isTypeDependent()) { 3912 QualType LHSType = TheCall->getArg(0)->getType(); 3913 QualType RHSType = TheCall->getArg(1)->getType(); 3914 3915 if (!LHSType->isVectorType() || !RHSType->isVectorType()) 3916 return ExprError(Diag(TheCall->getLocStart(), 3917 diag::err_shufflevector_non_vector) 3918 << SourceRange(TheCall->getArg(0)->getLocStart(), 3919 TheCall->getArg(1)->getLocEnd())); 3920 3921 numElements = LHSType->getAs<VectorType>()->getNumElements(); 3922 unsigned numResElements = TheCall->getNumArgs() - 2; 3923 3924 // Check to see if we have a call with 2 vector arguments, the unary shuffle 3925 // with mask. If so, verify that RHS is an integer vector type with the 3926 // same number of elts as lhs. 3927 if (TheCall->getNumArgs() == 2) { 3928 if (!RHSType->hasIntegerRepresentation() || 3929 RHSType->getAs<VectorType>()->getNumElements() != numElements) 3930 return ExprError(Diag(TheCall->getLocStart(), 3931 diag::err_shufflevector_incompatible_vector) 3932 << SourceRange(TheCall->getArg(1)->getLocStart(), 3933 TheCall->getArg(1)->getLocEnd())); 3934 } else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 3935 return ExprError(Diag(TheCall->getLocStart(), 3936 diag::err_shufflevector_incompatible_vector) 3937 << SourceRange(TheCall->getArg(0)->getLocStart(), 3938 TheCall->getArg(1)->getLocEnd())); 3939 } else if (numElements != numResElements) { 3940 QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 3941 resType = Context.getVectorType(eltType, numResElements, 3942 VectorType::GenericVector); 3943 } 3944 } 3945 3946 for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 3947 if (TheCall->getArg(i)->isTypeDependent() || 3948 TheCall->getArg(i)->isValueDependent()) 3949 continue; 3950 3951 llvm::APSInt Result(32); 3952 if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 3953 return ExprError(Diag(TheCall->getLocStart(), 3954 diag::err_shufflevector_nonconstant_argument) 3955 << TheCall->getArg(i)->getSourceRange()); 3956 3957 // Allow -1 which will be translated to undef in the IR. 3958 if (Result.isSigned() && Result.isAllOnesValue()) 3959 continue; 3960 3961 if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 3962 return ExprError(Diag(TheCall->getLocStart(), 3963 diag::err_shufflevector_argument_too_large) 3964 << TheCall->getArg(i)->getSourceRange()); 3965 } 3966 3967 SmallVector<Expr*, 32> exprs; 3968 3969 for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 3970 exprs.push_back(TheCall->getArg(i)); 3971 TheCall->setArg(i, nullptr); 3972 } 3973 3974 return new (Context) ShuffleVectorExpr(Context, exprs, resType, 3975 TheCall->getCallee()->getLocStart(), 3976 TheCall->getRParenLoc()); 3977 } 3978 3979 /// SemaConvertVectorExpr - Handle __builtin_convertvector 3980 ExprResult Sema::SemaConvertVectorExpr(Expr *E, TypeSourceInfo *TInfo, 3981 SourceLocation BuiltinLoc, 3982 SourceLocation RParenLoc) { 3983 ExprValueKind VK = VK_RValue; 3984 ExprObjectKind OK = OK_Ordinary; 3985 QualType DstTy = TInfo->getType(); 3986 QualType SrcTy = E->getType(); 3987 3988 if (!SrcTy->isVectorType() && !SrcTy->isDependentType()) 3989 return ExprError(Diag(BuiltinLoc, 3990 diag::err_convertvector_non_vector) 3991 << E->getSourceRange()); 3992 if (!DstTy->isVectorType() && !DstTy->isDependentType()) 3993 return ExprError(Diag(BuiltinLoc, 3994 diag::err_convertvector_non_vector_type)); 3995 3996 if (!SrcTy->isDependentType() && !DstTy->isDependentType()) { 3997 unsigned SrcElts = SrcTy->getAs<VectorType>()->getNumElements(); 3998 unsigned DstElts = DstTy->getAs<VectorType>()->getNumElements(); 3999 if (SrcElts != DstElts) 4000 return ExprError(Diag(BuiltinLoc, 4001 diag::err_convertvector_incompatible_vector) 4002 << E->getSourceRange()); 4003 } 4004 4005 return new (Context) 4006 ConvertVectorExpr(E, TInfo, DstTy, VK, OK, BuiltinLoc, RParenLoc); 4007 } 4008 4009 /// SemaBuiltinPrefetch - Handle __builtin_prefetch. 4010 // This is declared to take (const void*, ...) and can take two 4011 // optional constant int args. 4012 bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 4013 unsigned NumArgs = TheCall->getNumArgs(); 4014 4015 if (NumArgs > 3) 4016 return Diag(TheCall->getLocEnd(), 4017 diag::err_typecheck_call_too_many_args_at_most) 4018 << 0 /*function call*/ << 3 << NumArgs 4019 << TheCall->getSourceRange(); 4020 4021 // Argument 0 is checked for us and the remaining arguments must be 4022 // constant integers. 4023 for (unsigned i = 1; i != NumArgs; ++i) 4024 if (SemaBuiltinConstantArgRange(TheCall, i, 0, i == 1 ? 1 : 3)) 4025 return true; 4026 4027 return false; 4028 } 4029 4030 /// SemaBuiltinAssume - Handle __assume (MS Extension). 4031 // __assume does not evaluate its arguments, and should warn if its argument 4032 // has side effects. 4033 bool Sema::SemaBuiltinAssume(CallExpr *TheCall) { 4034 Expr *Arg = TheCall->getArg(0); 4035 if (Arg->isInstantiationDependent()) return false; 4036 4037 if (Arg->HasSideEffects(Context)) 4038 Diag(Arg->getLocStart(), diag::warn_assume_side_effects) 4039 << Arg->getSourceRange() 4040 << cast<FunctionDecl>(TheCall->getCalleeDecl())->getIdentifier(); 4041 4042 return false; 4043 } 4044 4045 /// Handle __builtin_alloca_with_align. This is declared 4046 /// as (size_t, size_t) where the second size_t must be a power of 2 greater 4047 /// than 8. 4048 bool Sema::SemaBuiltinAllocaWithAlign(CallExpr *TheCall) { 4049 // The alignment must be a constant integer. 4050 Expr *Arg = TheCall->getArg(1); 4051 4052 // We can't check the value of a dependent argument. 4053 if (!Arg->isTypeDependent() && !Arg->isValueDependent()) { 4054 if (const auto *UE = 4055 dyn_cast<UnaryExprOrTypeTraitExpr>(Arg->IgnoreParenImpCasts())) 4056 if (UE->getKind() == UETT_AlignOf) 4057 Diag(TheCall->getLocStart(), diag::warn_alloca_align_alignof) 4058 << Arg->getSourceRange(); 4059 4060 llvm::APSInt Result = Arg->EvaluateKnownConstInt(Context); 4061 4062 if (!Result.isPowerOf2()) 4063 return Diag(TheCall->getLocStart(), 4064 diag::err_alignment_not_power_of_two) 4065 << Arg->getSourceRange(); 4066 4067 if (Result < Context.getCharWidth()) 4068 return Diag(TheCall->getLocStart(), diag::err_alignment_too_small) 4069 << (unsigned)Context.getCharWidth() 4070 << Arg->getSourceRange(); 4071 4072 if (Result > INT32_MAX) 4073 return Diag(TheCall->getLocStart(), diag::err_alignment_too_big) 4074 << INT32_MAX 4075 << Arg->getSourceRange(); 4076 } 4077 4078 return false; 4079 } 4080 4081 /// Handle __builtin_assume_aligned. This is declared 4082 /// as (const void*, size_t, ...) and can take one optional constant int arg. 4083 bool Sema::SemaBuiltinAssumeAligned(CallExpr *TheCall) { 4084 unsigned NumArgs = TheCall->getNumArgs(); 4085 4086 if (NumArgs > 3) 4087 return Diag(TheCall->getLocEnd(), 4088 diag::err_typecheck_call_too_many_args_at_most) 4089 << 0 /*function call*/ << 3 << NumArgs 4090 << TheCall->getSourceRange(); 4091 4092 // The alignment must be a constant integer. 4093 Expr *Arg = TheCall->getArg(1); 4094 4095 // We can't check the value of a dependent argument. 4096 if (!Arg->isTypeDependent() && !Arg->isValueDependent()) { 4097 llvm::APSInt Result; 4098 if (SemaBuiltinConstantArg(TheCall, 1, Result)) 4099 return true; 4100 4101 if (!Result.isPowerOf2()) 4102 return Diag(TheCall->getLocStart(), 4103 diag::err_alignment_not_power_of_two) 4104 << Arg->getSourceRange(); 4105 } 4106 4107 if (NumArgs > 2) { 4108 ExprResult Arg(TheCall->getArg(2)); 4109 InitializedEntity Entity = InitializedEntity::InitializeParameter(Context, 4110 Context.getSizeType(), false); 4111 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 4112 if (Arg.isInvalid()) return true; 4113 TheCall->setArg(2, Arg.get()); 4114 } 4115 4116 return false; 4117 } 4118 4119 bool Sema::SemaBuiltinOSLogFormat(CallExpr *TheCall) { 4120 unsigned BuiltinID = 4121 cast<FunctionDecl>(TheCall->getCalleeDecl())->getBuiltinID(); 4122 bool IsSizeCall = BuiltinID == Builtin::BI__builtin_os_log_format_buffer_size; 4123 4124 unsigned NumArgs = TheCall->getNumArgs(); 4125 unsigned NumRequiredArgs = IsSizeCall ? 1 : 2; 4126 if (NumArgs < NumRequiredArgs) { 4127 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 4128 << 0 /* function call */ << NumRequiredArgs << NumArgs 4129 << TheCall->getSourceRange(); 4130 } 4131 if (NumArgs >= NumRequiredArgs + 0x100) { 4132 return Diag(TheCall->getLocEnd(), 4133 diag::err_typecheck_call_too_many_args_at_most) 4134 << 0 /* function call */ << (NumRequiredArgs + 0xff) << NumArgs 4135 << TheCall->getSourceRange(); 4136 } 4137 unsigned i = 0; 4138 4139 // For formatting call, check buffer arg. 4140 if (!IsSizeCall) { 4141 ExprResult Arg(TheCall->getArg(i)); 4142 InitializedEntity Entity = InitializedEntity::InitializeParameter( 4143 Context, Context.VoidPtrTy, false); 4144 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 4145 if (Arg.isInvalid()) 4146 return true; 4147 TheCall->setArg(i, Arg.get()); 4148 i++; 4149 } 4150 4151 // Check string literal arg. 4152 unsigned FormatIdx = i; 4153 { 4154 ExprResult Arg = CheckOSLogFormatStringArg(TheCall->getArg(i)); 4155 if (Arg.isInvalid()) 4156 return true; 4157 TheCall->setArg(i, Arg.get()); 4158 i++; 4159 } 4160 4161 // Make sure variadic args are scalar. 4162 unsigned FirstDataArg = i; 4163 while (i < NumArgs) { 4164 ExprResult Arg = DefaultVariadicArgumentPromotion( 4165 TheCall->getArg(i), VariadicFunction, nullptr); 4166 if (Arg.isInvalid()) 4167 return true; 4168 CharUnits ArgSize = Context.getTypeSizeInChars(Arg.get()->getType()); 4169 if (ArgSize.getQuantity() >= 0x100) { 4170 return Diag(Arg.get()->getLocEnd(), diag::err_os_log_argument_too_big) 4171 << i << (int)ArgSize.getQuantity() << 0xff 4172 << TheCall->getSourceRange(); 4173 } 4174 TheCall->setArg(i, Arg.get()); 4175 i++; 4176 } 4177 4178 // Check formatting specifiers. NOTE: We're only doing this for the non-size 4179 // call to avoid duplicate diagnostics. 4180 if (!IsSizeCall) { 4181 llvm::SmallBitVector CheckedVarArgs(NumArgs, false); 4182 ArrayRef<const Expr *> Args(TheCall->getArgs(), TheCall->getNumArgs()); 4183 bool Success = CheckFormatArguments( 4184 Args, /*HasVAListArg*/ false, FormatIdx, FirstDataArg, FST_OSLog, 4185 VariadicFunction, TheCall->getLocStart(), SourceRange(), 4186 CheckedVarArgs); 4187 if (!Success) 4188 return true; 4189 } 4190 4191 if (IsSizeCall) { 4192 TheCall->setType(Context.getSizeType()); 4193 } else { 4194 TheCall->setType(Context.VoidPtrTy); 4195 } 4196 return false; 4197 } 4198 4199 /// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 4200 /// TheCall is a constant expression. 4201 bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 4202 llvm::APSInt &Result) { 4203 Expr *Arg = TheCall->getArg(ArgNum); 4204 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 4205 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 4206 4207 if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 4208 4209 if (!Arg->isIntegerConstantExpr(Result, Context)) 4210 return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 4211 << FDecl->getDeclName() << Arg->getSourceRange(); 4212 4213 return false; 4214 } 4215 4216 /// SemaBuiltinConstantArgRange - Handle a check if argument ArgNum of CallExpr 4217 /// TheCall is a constant expression in the range [Low, High]. 4218 bool Sema::SemaBuiltinConstantArgRange(CallExpr *TheCall, int ArgNum, 4219 int Low, int High) { 4220 llvm::APSInt Result; 4221 4222 // We can't check the value of a dependent argument. 4223 Expr *Arg = TheCall->getArg(ArgNum); 4224 if (Arg->isTypeDependent() || Arg->isValueDependent()) 4225 return false; 4226 4227 // Check constant-ness first. 4228 if (SemaBuiltinConstantArg(TheCall, ArgNum, Result)) 4229 return true; 4230 4231 if (Result.getSExtValue() < Low || Result.getSExtValue() > High) 4232 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 4233 << Low << High << Arg->getSourceRange(); 4234 4235 return false; 4236 } 4237 4238 /// SemaBuiltinConstantArgMultiple - Handle a check if argument ArgNum of CallExpr 4239 /// TheCall is a constant expression is a multiple of Num.. 4240 bool Sema::SemaBuiltinConstantArgMultiple(CallExpr *TheCall, int ArgNum, 4241 unsigned Num) { 4242 llvm::APSInt Result; 4243 4244 // We can't check the value of a dependent argument. 4245 Expr *Arg = TheCall->getArg(ArgNum); 4246 if (Arg->isTypeDependent() || Arg->isValueDependent()) 4247 return false; 4248 4249 // Check constant-ness first. 4250 if (SemaBuiltinConstantArg(TheCall, ArgNum, Result)) 4251 return true; 4252 4253 if (Result.getSExtValue() % Num != 0) 4254 return Diag(TheCall->getLocStart(), diag::err_argument_not_multiple) 4255 << Num << Arg->getSourceRange(); 4256 4257 return false; 4258 } 4259 4260 /// SemaBuiltinARMSpecialReg - Handle a check if argument ArgNum of CallExpr 4261 /// TheCall is an ARM/AArch64 special register string literal. 4262 bool Sema::SemaBuiltinARMSpecialReg(unsigned BuiltinID, CallExpr *TheCall, 4263 int ArgNum, unsigned ExpectedFieldNum, 4264 bool AllowName) { 4265 bool IsARMBuiltin = BuiltinID == ARM::BI__builtin_arm_rsr64 || 4266 BuiltinID == ARM::BI__builtin_arm_wsr64 || 4267 BuiltinID == ARM::BI__builtin_arm_rsr || 4268 BuiltinID == ARM::BI__builtin_arm_rsrp || 4269 BuiltinID == ARM::BI__builtin_arm_wsr || 4270 BuiltinID == ARM::BI__builtin_arm_wsrp; 4271 bool IsAArch64Builtin = BuiltinID == AArch64::BI__builtin_arm_rsr64 || 4272 BuiltinID == AArch64::BI__builtin_arm_wsr64 || 4273 BuiltinID == AArch64::BI__builtin_arm_rsr || 4274 BuiltinID == AArch64::BI__builtin_arm_rsrp || 4275 BuiltinID == AArch64::BI__builtin_arm_wsr || 4276 BuiltinID == AArch64::BI__builtin_arm_wsrp; 4277 assert((IsARMBuiltin || IsAArch64Builtin) && "Unexpected ARM builtin."); 4278 4279 // We can't check the value of a dependent argument. 4280 Expr *Arg = TheCall->getArg(ArgNum); 4281 if (Arg->isTypeDependent() || Arg->isValueDependent()) 4282 return false; 4283 4284 // Check if the argument is a string literal. 4285 if (!isa<StringLiteral>(Arg->IgnoreParenImpCasts())) 4286 return Diag(TheCall->getLocStart(), diag::err_expr_not_string_literal) 4287 << Arg->getSourceRange(); 4288 4289 // Check the type of special register given. 4290 StringRef Reg = cast<StringLiteral>(Arg->IgnoreParenImpCasts())->getString(); 4291 SmallVector<StringRef, 6> Fields; 4292 Reg.split(Fields, ":"); 4293 4294 if (Fields.size() != ExpectedFieldNum && !(AllowName && Fields.size() == 1)) 4295 return Diag(TheCall->getLocStart(), diag::err_arm_invalid_specialreg) 4296 << Arg->getSourceRange(); 4297 4298 // If the string is the name of a register then we cannot check that it is 4299 // valid here but if the string is of one the forms described in ACLE then we 4300 // can check that the supplied fields are integers and within the valid 4301 // ranges. 4302 if (Fields.size() > 1) { 4303 bool FiveFields = Fields.size() == 5; 4304 4305 bool ValidString = true; 4306 if (IsARMBuiltin) { 4307 ValidString &= Fields[0].startswith_lower("cp") || 4308 Fields[0].startswith_lower("p"); 4309 if (ValidString) 4310 Fields[0] = 4311 Fields[0].drop_front(Fields[0].startswith_lower("cp") ? 2 : 1); 4312 4313 ValidString &= Fields[2].startswith_lower("c"); 4314 if (ValidString) 4315 Fields[2] = Fields[2].drop_front(1); 4316 4317 if (FiveFields) { 4318 ValidString &= Fields[3].startswith_lower("c"); 4319 if (ValidString) 4320 Fields[3] = Fields[3].drop_front(1); 4321 } 4322 } 4323 4324 SmallVector<int, 5> Ranges; 4325 if (FiveFields) 4326 Ranges.append({IsAArch64Builtin ? 1 : 15, 7, 15, 15, 7}); 4327 else 4328 Ranges.append({15, 7, 15}); 4329 4330 for (unsigned i=0; i<Fields.size(); ++i) { 4331 int IntField; 4332 ValidString &= !Fields[i].getAsInteger(10, IntField); 4333 ValidString &= (IntField >= 0 && IntField <= Ranges[i]); 4334 } 4335 4336 if (!ValidString) 4337 return Diag(TheCall->getLocStart(), diag::err_arm_invalid_specialreg) 4338 << Arg->getSourceRange(); 4339 4340 } else if (IsAArch64Builtin && Fields.size() == 1) { 4341 // If the register name is one of those that appear in the condition below 4342 // and the special register builtin being used is one of the write builtins, 4343 // then we require that the argument provided for writing to the register 4344 // is an integer constant expression. This is because it will be lowered to 4345 // an MSR (immediate) instruction, so we need to know the immediate at 4346 // compile time. 4347 if (TheCall->getNumArgs() != 2) 4348 return false; 4349 4350 std::string RegLower = Reg.lower(); 4351 if (RegLower != "spsel" && RegLower != "daifset" && RegLower != "daifclr" && 4352 RegLower != "pan" && RegLower != "uao") 4353 return false; 4354 4355 return SemaBuiltinConstantArgRange(TheCall, 1, 0, 15); 4356 } 4357 4358 return false; 4359 } 4360 4361 /// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 4362 /// This checks that the target supports __builtin_longjmp and 4363 /// that val is a constant 1. 4364 bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 4365 if (!Context.getTargetInfo().hasSjLjLowering()) 4366 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_unsupported) 4367 << SourceRange(TheCall->getLocStart(), TheCall->getLocEnd()); 4368 4369 Expr *Arg = TheCall->getArg(1); 4370 llvm::APSInt Result; 4371 4372 // TODO: This is less than ideal. Overload this to take a value. 4373 if (SemaBuiltinConstantArg(TheCall, 1, Result)) 4374 return true; 4375 4376 if (Result != 1) 4377 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 4378 << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 4379 4380 return false; 4381 } 4382 4383 /// SemaBuiltinSetjmp - Handle __builtin_setjmp(void *env[5]). 4384 /// This checks that the target supports __builtin_setjmp. 4385 bool Sema::SemaBuiltinSetjmp(CallExpr *TheCall) { 4386 if (!Context.getTargetInfo().hasSjLjLowering()) 4387 return Diag(TheCall->getLocStart(), diag::err_builtin_setjmp_unsupported) 4388 << SourceRange(TheCall->getLocStart(), TheCall->getLocEnd()); 4389 return false; 4390 } 4391 4392 namespace { 4393 class UncoveredArgHandler { 4394 enum { Unknown = -1, AllCovered = -2 }; 4395 signed FirstUncoveredArg; 4396 SmallVector<const Expr *, 4> DiagnosticExprs; 4397 4398 public: 4399 UncoveredArgHandler() : FirstUncoveredArg(Unknown) { } 4400 4401 bool hasUncoveredArg() const { 4402 return (FirstUncoveredArg >= 0); 4403 } 4404 4405 unsigned getUncoveredArg() const { 4406 assert(hasUncoveredArg() && "no uncovered argument"); 4407 return FirstUncoveredArg; 4408 } 4409 4410 void setAllCovered() { 4411 // A string has been found with all arguments covered, so clear out 4412 // the diagnostics. 4413 DiagnosticExprs.clear(); 4414 FirstUncoveredArg = AllCovered; 4415 } 4416 4417 void Update(signed NewFirstUncoveredArg, const Expr *StrExpr) { 4418 assert(NewFirstUncoveredArg >= 0 && "Outside range"); 4419 4420 // Don't update if a previous string covers all arguments. 4421 if (FirstUncoveredArg == AllCovered) 4422 return; 4423 4424 // UncoveredArgHandler tracks the highest uncovered argument index 4425 // and with it all the strings that match this index. 4426 if (NewFirstUncoveredArg == FirstUncoveredArg) 4427 DiagnosticExprs.push_back(StrExpr); 4428 else if (NewFirstUncoveredArg > FirstUncoveredArg) { 4429 DiagnosticExprs.clear(); 4430 DiagnosticExprs.push_back(StrExpr); 4431 FirstUncoveredArg = NewFirstUncoveredArg; 4432 } 4433 } 4434 4435 void Diagnose(Sema &S, bool IsFunctionCall, const Expr *ArgExpr); 4436 }; 4437 4438 enum StringLiteralCheckType { 4439 SLCT_NotALiteral, 4440 SLCT_UncheckedLiteral, 4441 SLCT_CheckedLiteral 4442 }; 4443 } // end anonymous namespace 4444 4445 static void sumOffsets(llvm::APSInt &Offset, llvm::APSInt Addend, 4446 BinaryOperatorKind BinOpKind, 4447 bool AddendIsRight) { 4448 unsigned BitWidth = Offset.getBitWidth(); 4449 unsigned AddendBitWidth = Addend.getBitWidth(); 4450 // There might be negative interim results. 4451 if (Addend.isUnsigned()) { 4452 Addend = Addend.zext(++AddendBitWidth); 4453 Addend.setIsSigned(true); 4454 } 4455 // Adjust the bit width of the APSInts. 4456 if (AddendBitWidth > BitWidth) { 4457 Offset = Offset.sext(AddendBitWidth); 4458 BitWidth = AddendBitWidth; 4459 } else if (BitWidth > AddendBitWidth) { 4460 Addend = Addend.sext(BitWidth); 4461 } 4462 4463 bool Ov = false; 4464 llvm::APSInt ResOffset = Offset; 4465 if (BinOpKind == BO_Add) 4466 ResOffset = Offset.sadd_ov(Addend, Ov); 4467 else { 4468 assert(AddendIsRight && BinOpKind == BO_Sub && 4469 "operator must be add or sub with addend on the right"); 4470 ResOffset = Offset.ssub_ov(Addend, Ov); 4471 } 4472 4473 // We add an offset to a pointer here so we should support an offset as big as 4474 // possible. 4475 if (Ov) { 4476 assert(BitWidth <= UINT_MAX / 2 && "index (intermediate) result too big"); 4477 Offset = Offset.sext(2 * BitWidth); 4478 sumOffsets(Offset, Addend, BinOpKind, AddendIsRight); 4479 return; 4480 } 4481 4482 Offset = ResOffset; 4483 } 4484 4485 namespace { 4486 // This is a wrapper class around StringLiteral to support offsetted string 4487 // literals as format strings. It takes the offset into account when returning 4488 // the string and its length or the source locations to display notes correctly. 4489 class FormatStringLiteral { 4490 const StringLiteral *FExpr; 4491 int64_t Offset; 4492 4493 public: 4494 FormatStringLiteral(const StringLiteral *fexpr, int64_t Offset = 0) 4495 : FExpr(fexpr), Offset(Offset) {} 4496 4497 StringRef getString() const { 4498 return FExpr->getString().drop_front(Offset); 4499 } 4500 4501 unsigned getByteLength() const { 4502 return FExpr->getByteLength() - getCharByteWidth() * Offset; 4503 } 4504 unsigned getLength() const { return FExpr->getLength() - Offset; } 4505 unsigned getCharByteWidth() const { return FExpr->getCharByteWidth(); } 4506 4507 StringLiteral::StringKind getKind() const { return FExpr->getKind(); } 4508 4509 QualType getType() const { return FExpr->getType(); } 4510 4511 bool isAscii() const { return FExpr->isAscii(); } 4512 bool isWide() const { return FExpr->isWide(); } 4513 bool isUTF8() const { return FExpr->isUTF8(); } 4514 bool isUTF16() const { return FExpr->isUTF16(); } 4515 bool isUTF32() const { return FExpr->isUTF32(); } 4516 bool isPascal() const { return FExpr->isPascal(); } 4517 4518 SourceLocation getLocationOfByte( 4519 unsigned ByteNo, const SourceManager &SM, const LangOptions &Features, 4520 const TargetInfo &Target, unsigned *StartToken = nullptr, 4521 unsigned *StartTokenByteOffset = nullptr) const { 4522 return FExpr->getLocationOfByte(ByteNo + Offset, SM, Features, Target, 4523 StartToken, StartTokenByteOffset); 4524 } 4525 4526 SourceLocation getLocStart() const LLVM_READONLY { 4527 return FExpr->getLocStart().getLocWithOffset(Offset); 4528 } 4529 SourceLocation getLocEnd() const LLVM_READONLY { return FExpr->getLocEnd(); } 4530 }; 4531 } // end anonymous namespace 4532 4533 static void CheckFormatString(Sema &S, const FormatStringLiteral *FExpr, 4534 const Expr *OrigFormatExpr, 4535 ArrayRef<const Expr *> Args, 4536 bool HasVAListArg, unsigned format_idx, 4537 unsigned firstDataArg, 4538 Sema::FormatStringType Type, 4539 bool inFunctionCall, 4540 Sema::VariadicCallType CallType, 4541 llvm::SmallBitVector &CheckedVarArgs, 4542 UncoveredArgHandler &UncoveredArg); 4543 4544 // Determine if an expression is a string literal or constant string. 4545 // If this function returns false on the arguments to a function expecting a 4546 // format string, we will usually need to emit a warning. 4547 // True string literals are then checked by CheckFormatString. 4548 static StringLiteralCheckType 4549 checkFormatStringExpr(Sema &S, const Expr *E, ArrayRef<const Expr *> Args, 4550 bool HasVAListArg, unsigned format_idx, 4551 unsigned firstDataArg, Sema::FormatStringType Type, 4552 Sema::VariadicCallType CallType, bool InFunctionCall, 4553 llvm::SmallBitVector &CheckedVarArgs, 4554 UncoveredArgHandler &UncoveredArg, 4555 llvm::APSInt Offset) { 4556 tryAgain: 4557 assert(Offset.isSigned() && "invalid offset"); 4558 4559 if (E->isTypeDependent() || E->isValueDependent()) 4560 return SLCT_NotALiteral; 4561 4562 E = E->IgnoreParenCasts(); 4563 4564 if (E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull)) 4565 // Technically -Wformat-nonliteral does not warn about this case. 4566 // The behavior of printf and friends in this case is implementation 4567 // dependent. Ideally if the format string cannot be null then 4568 // it should have a 'nonnull' attribute in the function prototype. 4569 return SLCT_UncheckedLiteral; 4570 4571 switch (E->getStmtClass()) { 4572 case Stmt::BinaryConditionalOperatorClass: 4573 case Stmt::ConditionalOperatorClass: { 4574 // The expression is a literal if both sub-expressions were, and it was 4575 // completely checked only if both sub-expressions were checked. 4576 const AbstractConditionalOperator *C = 4577 cast<AbstractConditionalOperator>(E); 4578 4579 // Determine whether it is necessary to check both sub-expressions, for 4580 // example, because the condition expression is a constant that can be 4581 // evaluated at compile time. 4582 bool CheckLeft = true, CheckRight = true; 4583 4584 bool Cond; 4585 if (C->getCond()->EvaluateAsBooleanCondition(Cond, S.getASTContext())) { 4586 if (Cond) 4587 CheckRight = false; 4588 else 4589 CheckLeft = false; 4590 } 4591 4592 // We need to maintain the offsets for the right and the left hand side 4593 // separately to check if every possible indexed expression is a valid 4594 // string literal. They might have different offsets for different string 4595 // literals in the end. 4596 StringLiteralCheckType Left; 4597 if (!CheckLeft) 4598 Left = SLCT_UncheckedLiteral; 4599 else { 4600 Left = checkFormatStringExpr(S, C->getTrueExpr(), Args, 4601 HasVAListArg, format_idx, firstDataArg, 4602 Type, CallType, InFunctionCall, 4603 CheckedVarArgs, UncoveredArg, Offset); 4604 if (Left == SLCT_NotALiteral || !CheckRight) { 4605 return Left; 4606 } 4607 } 4608 4609 StringLiteralCheckType Right = 4610 checkFormatStringExpr(S, C->getFalseExpr(), Args, 4611 HasVAListArg, format_idx, firstDataArg, 4612 Type, CallType, InFunctionCall, CheckedVarArgs, 4613 UncoveredArg, Offset); 4614 4615 return (CheckLeft && Left < Right) ? Left : Right; 4616 } 4617 4618 case Stmt::ImplicitCastExprClass: { 4619 E = cast<ImplicitCastExpr>(E)->getSubExpr(); 4620 goto tryAgain; 4621 } 4622 4623 case Stmt::OpaqueValueExprClass: 4624 if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 4625 E = src; 4626 goto tryAgain; 4627 } 4628 return SLCT_NotALiteral; 4629 4630 case Stmt::PredefinedExprClass: 4631 // While __func__, etc., are technically not string literals, they 4632 // cannot contain format specifiers and thus are not a security 4633 // liability. 4634 return SLCT_UncheckedLiteral; 4635 4636 case Stmt::DeclRefExprClass: { 4637 const DeclRefExpr *DR = cast<DeclRefExpr>(E); 4638 4639 // As an exception, do not flag errors for variables binding to 4640 // const string literals. 4641 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 4642 bool isConstant = false; 4643 QualType T = DR->getType(); 4644 4645 if (const ArrayType *AT = S.Context.getAsArrayType(T)) { 4646 isConstant = AT->getElementType().isConstant(S.Context); 4647 } else if (const PointerType *PT = T->getAs<PointerType>()) { 4648 isConstant = T.isConstant(S.Context) && 4649 PT->getPointeeType().isConstant(S.Context); 4650 } else if (T->isObjCObjectPointerType()) { 4651 // In ObjC, there is usually no "const ObjectPointer" type, 4652 // so don't check if the pointee type is constant. 4653 isConstant = T.isConstant(S.Context); 4654 } 4655 4656 if (isConstant) { 4657 if (const Expr *Init = VD->getAnyInitializer()) { 4658 // Look through initializers like const char c[] = { "foo" } 4659 if (const InitListExpr *InitList = dyn_cast<InitListExpr>(Init)) { 4660 if (InitList->isStringLiteralInit()) 4661 Init = InitList->getInit(0)->IgnoreParenImpCasts(); 4662 } 4663 return checkFormatStringExpr(S, Init, Args, 4664 HasVAListArg, format_idx, 4665 firstDataArg, Type, CallType, 4666 /*InFunctionCall*/ false, CheckedVarArgs, 4667 UncoveredArg, Offset); 4668 } 4669 } 4670 4671 // For vprintf* functions (i.e., HasVAListArg==true), we add a 4672 // special check to see if the format string is a function parameter 4673 // of the function calling the printf function. If the function 4674 // has an attribute indicating it is a printf-like function, then we 4675 // should suppress warnings concerning non-literals being used in a call 4676 // to a vprintf function. For example: 4677 // 4678 // void 4679 // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 4680 // va_list ap; 4681 // va_start(ap, fmt); 4682 // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 4683 // ... 4684 // } 4685 if (HasVAListArg) { 4686 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) { 4687 if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) { 4688 int PVIndex = PV->getFunctionScopeIndex() + 1; 4689 for (const auto *PVFormat : ND->specific_attrs<FormatAttr>()) { 4690 // adjust for implicit parameter 4691 if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 4692 if (MD->isInstance()) 4693 ++PVIndex; 4694 // We also check if the formats are compatible. 4695 // We can't pass a 'scanf' string to a 'printf' function. 4696 if (PVIndex == PVFormat->getFormatIdx() && 4697 Type == S.GetFormatStringType(PVFormat)) 4698 return SLCT_UncheckedLiteral; 4699 } 4700 } 4701 } 4702 } 4703 } 4704 4705 return SLCT_NotALiteral; 4706 } 4707 4708 case Stmt::CallExprClass: 4709 case Stmt::CXXMemberCallExprClass: { 4710 const CallExpr *CE = cast<CallExpr>(E); 4711 if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) { 4712 if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) { 4713 unsigned ArgIndex = FA->getFormatIdx(); 4714 if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 4715 if (MD->isInstance()) 4716 --ArgIndex; 4717 const Expr *Arg = CE->getArg(ArgIndex - 1); 4718 4719 return checkFormatStringExpr(S, Arg, Args, 4720 HasVAListArg, format_idx, firstDataArg, 4721 Type, CallType, InFunctionCall, 4722 CheckedVarArgs, UncoveredArg, Offset); 4723 } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) { 4724 unsigned BuiltinID = FD->getBuiltinID(); 4725 if (BuiltinID == Builtin::BI__builtin___CFStringMakeConstantString || 4726 BuiltinID == Builtin::BI__builtin___NSStringMakeConstantString) { 4727 const Expr *Arg = CE->getArg(0); 4728 return checkFormatStringExpr(S, Arg, Args, 4729 HasVAListArg, format_idx, 4730 firstDataArg, Type, CallType, 4731 InFunctionCall, CheckedVarArgs, 4732 UncoveredArg, Offset); 4733 } 4734 } 4735 } 4736 4737 return SLCT_NotALiteral; 4738 } 4739 case Stmt::ObjCMessageExprClass: { 4740 const auto *ME = cast<ObjCMessageExpr>(E); 4741 if (const auto *ND = ME->getMethodDecl()) { 4742 if (const auto *FA = ND->getAttr<FormatArgAttr>()) { 4743 unsigned ArgIndex = FA->getFormatIdx(); 4744 const Expr *Arg = ME->getArg(ArgIndex - 1); 4745 return checkFormatStringExpr( 4746 S, Arg, Args, HasVAListArg, format_idx, firstDataArg, Type, 4747 CallType, InFunctionCall, CheckedVarArgs, UncoveredArg, Offset); 4748 } 4749 } 4750 4751 return SLCT_NotALiteral; 4752 } 4753 case Stmt::ObjCStringLiteralClass: 4754 case Stmt::StringLiteralClass: { 4755 const StringLiteral *StrE = nullptr; 4756 4757 if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 4758 StrE = ObjCFExpr->getString(); 4759 else 4760 StrE = cast<StringLiteral>(E); 4761 4762 if (StrE) { 4763 if (Offset.isNegative() || Offset > StrE->getLength()) { 4764 // TODO: It would be better to have an explicit warning for out of 4765 // bounds literals. 4766 return SLCT_NotALiteral; 4767 } 4768 FormatStringLiteral FStr(StrE, Offset.sextOrTrunc(64).getSExtValue()); 4769 CheckFormatString(S, &FStr, E, Args, HasVAListArg, format_idx, 4770 firstDataArg, Type, InFunctionCall, CallType, 4771 CheckedVarArgs, UncoveredArg); 4772 return SLCT_CheckedLiteral; 4773 } 4774 4775 return SLCT_NotALiteral; 4776 } 4777 case Stmt::BinaryOperatorClass: { 4778 llvm::APSInt LResult; 4779 llvm::APSInt RResult; 4780 4781 const BinaryOperator *BinOp = cast<BinaryOperator>(E); 4782 4783 // A string literal + an int offset is still a string literal. 4784 if (BinOp->isAdditiveOp()) { 4785 bool LIsInt = BinOp->getLHS()->EvaluateAsInt(LResult, S.Context); 4786 bool RIsInt = BinOp->getRHS()->EvaluateAsInt(RResult, S.Context); 4787 4788 if (LIsInt != RIsInt) { 4789 BinaryOperatorKind BinOpKind = BinOp->getOpcode(); 4790 4791 if (LIsInt) { 4792 if (BinOpKind == BO_Add) { 4793 sumOffsets(Offset, LResult, BinOpKind, RIsInt); 4794 E = BinOp->getRHS(); 4795 goto tryAgain; 4796 } 4797 } else { 4798 sumOffsets(Offset, RResult, BinOpKind, RIsInt); 4799 E = BinOp->getLHS(); 4800 goto tryAgain; 4801 } 4802 } 4803 } 4804 4805 return SLCT_NotALiteral; 4806 } 4807 case Stmt::UnaryOperatorClass: { 4808 const UnaryOperator *UnaOp = cast<UnaryOperator>(E); 4809 auto ASE = dyn_cast<ArraySubscriptExpr>(UnaOp->getSubExpr()); 4810 if (UnaOp->getOpcode() == clang::UO_AddrOf && ASE) { 4811 llvm::APSInt IndexResult; 4812 if (ASE->getRHS()->EvaluateAsInt(IndexResult, S.Context)) { 4813 sumOffsets(Offset, IndexResult, BO_Add, /*RHS is int*/ true); 4814 E = ASE->getBase(); 4815 goto tryAgain; 4816 } 4817 } 4818 4819 return SLCT_NotALiteral; 4820 } 4821 4822 default: 4823 return SLCT_NotALiteral; 4824 } 4825 } 4826 4827 Sema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) { 4828 return llvm::StringSwitch<FormatStringType>(Format->getType()->getName()) 4829 .Case("scanf", FST_Scanf) 4830 .Cases("printf", "printf0", FST_Printf) 4831 .Cases("NSString", "CFString", FST_NSString) 4832 .Case("strftime", FST_Strftime) 4833 .Case("strfmon", FST_Strfmon) 4834 .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf) 4835 .Case("freebsd_kprintf", FST_FreeBSDKPrintf) 4836 .Case("os_trace", FST_OSLog) 4837 .Case("os_log", FST_OSLog) 4838 .Default(FST_Unknown); 4839 } 4840 4841 /// CheckFormatArguments - Check calls to printf and scanf (and similar 4842 /// functions) for correct use of format strings. 4843 /// Returns true if a format string has been fully checked. 4844 bool Sema::CheckFormatArguments(const FormatAttr *Format, 4845 ArrayRef<const Expr *> Args, 4846 bool IsCXXMember, 4847 VariadicCallType CallType, 4848 SourceLocation Loc, SourceRange Range, 4849 llvm::SmallBitVector &CheckedVarArgs) { 4850 FormatStringInfo FSI; 4851 if (getFormatStringInfo(Format, IsCXXMember, &FSI)) 4852 return CheckFormatArguments(Args, FSI.HasVAListArg, FSI.FormatIdx, 4853 FSI.FirstDataArg, GetFormatStringType(Format), 4854 CallType, Loc, Range, CheckedVarArgs); 4855 return false; 4856 } 4857 4858 bool Sema::CheckFormatArguments(ArrayRef<const Expr *> Args, 4859 bool HasVAListArg, unsigned format_idx, 4860 unsigned firstDataArg, FormatStringType Type, 4861 VariadicCallType CallType, 4862 SourceLocation Loc, SourceRange Range, 4863 llvm::SmallBitVector &CheckedVarArgs) { 4864 // CHECK: printf/scanf-like function is called with no format string. 4865 if (format_idx >= Args.size()) { 4866 Diag(Loc, diag::warn_missing_format_string) << Range; 4867 return false; 4868 } 4869 4870 const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts(); 4871 4872 // CHECK: format string is not a string literal. 4873 // 4874 // Dynamically generated format strings are difficult to 4875 // automatically vet at compile time. Requiring that format strings 4876 // are string literals: (1) permits the checking of format strings by 4877 // the compiler and thereby (2) can practically remove the source of 4878 // many format string exploits. 4879 4880 // Format string can be either ObjC string (e.g. @"%d") or 4881 // C string (e.g. "%d") 4882 // ObjC string uses the same format specifiers as C string, so we can use 4883 // the same format string checking logic for both ObjC and C strings. 4884 UncoveredArgHandler UncoveredArg; 4885 StringLiteralCheckType CT = 4886 checkFormatStringExpr(*this, OrigFormatExpr, Args, HasVAListArg, 4887 format_idx, firstDataArg, Type, CallType, 4888 /*IsFunctionCall*/ true, CheckedVarArgs, 4889 UncoveredArg, 4890 /*no string offset*/ llvm::APSInt(64, false) = 0); 4891 4892 // Generate a diagnostic where an uncovered argument is detected. 4893 if (UncoveredArg.hasUncoveredArg()) { 4894 unsigned ArgIdx = UncoveredArg.getUncoveredArg() + firstDataArg; 4895 assert(ArgIdx < Args.size() && "ArgIdx outside bounds"); 4896 UncoveredArg.Diagnose(*this, /*IsFunctionCall*/true, Args[ArgIdx]); 4897 } 4898 4899 if (CT != SLCT_NotALiteral) 4900 // Literal format string found, check done! 4901 return CT == SLCT_CheckedLiteral; 4902 4903 // Strftime is particular as it always uses a single 'time' argument, 4904 // so it is safe to pass a non-literal string. 4905 if (Type == FST_Strftime) 4906 return false; 4907 4908 // Do not emit diag when the string param is a macro expansion and the 4909 // format is either NSString or CFString. This is a hack to prevent 4910 // diag when using the NSLocalizedString and CFCopyLocalizedString macros 4911 // which are usually used in place of NS and CF string literals. 4912 SourceLocation FormatLoc = Args[format_idx]->getLocStart(); 4913 if (Type == FST_NSString && SourceMgr.isInSystemMacro(FormatLoc)) 4914 return false; 4915 4916 // If there are no arguments specified, warn with -Wformat-security, otherwise 4917 // warn only with -Wformat-nonliteral. 4918 if (Args.size() == firstDataArg) { 4919 Diag(FormatLoc, diag::warn_format_nonliteral_noargs) 4920 << OrigFormatExpr->getSourceRange(); 4921 switch (Type) { 4922 default: 4923 break; 4924 case FST_Kprintf: 4925 case FST_FreeBSDKPrintf: 4926 case FST_Printf: 4927 Diag(FormatLoc, diag::note_format_security_fixit) 4928 << FixItHint::CreateInsertion(FormatLoc, "\"%s\", "); 4929 break; 4930 case FST_NSString: 4931 Diag(FormatLoc, diag::note_format_security_fixit) 4932 << FixItHint::CreateInsertion(FormatLoc, "@\"%@\", "); 4933 break; 4934 } 4935 } else { 4936 Diag(FormatLoc, diag::warn_format_nonliteral) 4937 << OrigFormatExpr->getSourceRange(); 4938 } 4939 return false; 4940 } 4941 4942 namespace { 4943 class CheckFormatHandler : public analyze_format_string::FormatStringHandler { 4944 protected: 4945 Sema &S; 4946 const FormatStringLiteral *FExpr; 4947 const Expr *OrigFormatExpr; 4948 const Sema::FormatStringType FSType; 4949 const unsigned FirstDataArg; 4950 const unsigned NumDataArgs; 4951 const char *Beg; // Start of format string. 4952 const bool HasVAListArg; 4953 ArrayRef<const Expr *> Args; 4954 unsigned FormatIdx; 4955 llvm::SmallBitVector CoveredArgs; 4956 bool usesPositionalArgs; 4957 bool atFirstArg; 4958 bool inFunctionCall; 4959 Sema::VariadicCallType CallType; 4960 llvm::SmallBitVector &CheckedVarArgs; 4961 UncoveredArgHandler &UncoveredArg; 4962 4963 public: 4964 CheckFormatHandler(Sema &s, const FormatStringLiteral *fexpr, 4965 const Expr *origFormatExpr, 4966 const Sema::FormatStringType type, unsigned firstDataArg, 4967 unsigned numDataArgs, const char *beg, bool hasVAListArg, 4968 ArrayRef<const Expr *> Args, unsigned formatIdx, 4969 bool inFunctionCall, Sema::VariadicCallType callType, 4970 llvm::SmallBitVector &CheckedVarArgs, 4971 UncoveredArgHandler &UncoveredArg) 4972 : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), FSType(type), 4973 FirstDataArg(firstDataArg), NumDataArgs(numDataArgs), Beg(beg), 4974 HasVAListArg(hasVAListArg), Args(Args), FormatIdx(formatIdx), 4975 usesPositionalArgs(false), atFirstArg(true), 4976 inFunctionCall(inFunctionCall), CallType(callType), 4977 CheckedVarArgs(CheckedVarArgs), UncoveredArg(UncoveredArg) { 4978 CoveredArgs.resize(numDataArgs); 4979 CoveredArgs.reset(); 4980 } 4981 4982 void DoneProcessing(); 4983 4984 void HandleIncompleteSpecifier(const char *startSpecifier, 4985 unsigned specifierLen) override; 4986 4987 void HandleInvalidLengthModifier( 4988 const analyze_format_string::FormatSpecifier &FS, 4989 const analyze_format_string::ConversionSpecifier &CS, 4990 const char *startSpecifier, unsigned specifierLen, 4991 unsigned DiagID); 4992 4993 void HandleNonStandardLengthModifier( 4994 const analyze_format_string::FormatSpecifier &FS, 4995 const char *startSpecifier, unsigned specifierLen); 4996 4997 void HandleNonStandardConversionSpecifier( 4998 const analyze_format_string::ConversionSpecifier &CS, 4999 const char *startSpecifier, unsigned specifierLen); 5000 5001 void HandlePosition(const char *startPos, unsigned posLen) override; 5002 5003 void HandleInvalidPosition(const char *startSpecifier, 5004 unsigned specifierLen, 5005 analyze_format_string::PositionContext p) override; 5006 5007 void HandleZeroPosition(const char *startPos, unsigned posLen) override; 5008 5009 void HandleNullChar(const char *nullCharacter) override; 5010 5011 template <typename Range> 5012 static void 5013 EmitFormatDiagnostic(Sema &S, bool inFunctionCall, const Expr *ArgumentExpr, 5014 const PartialDiagnostic &PDiag, SourceLocation StringLoc, 5015 bool IsStringLocation, Range StringRange, 5016 ArrayRef<FixItHint> Fixit = None); 5017 5018 protected: 5019 bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 5020 const char *startSpec, 5021 unsigned specifierLen, 5022 const char *csStart, unsigned csLen); 5023 5024 void HandlePositionalNonpositionalArgs(SourceLocation Loc, 5025 const char *startSpec, 5026 unsigned specifierLen); 5027 5028 SourceRange getFormatStringRange(); 5029 CharSourceRange getSpecifierRange(const char *startSpecifier, 5030 unsigned specifierLen); 5031 SourceLocation getLocationOfByte(const char *x); 5032 5033 const Expr *getDataArg(unsigned i) const; 5034 5035 bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 5036 const analyze_format_string::ConversionSpecifier &CS, 5037 const char *startSpecifier, unsigned specifierLen, 5038 unsigned argIndex); 5039 5040 template <typename Range> 5041 void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc, 5042 bool IsStringLocation, Range StringRange, 5043 ArrayRef<FixItHint> Fixit = None); 5044 }; 5045 } // end anonymous namespace 5046 5047 SourceRange CheckFormatHandler::getFormatStringRange() { 5048 return OrigFormatExpr->getSourceRange(); 5049 } 5050 5051 CharSourceRange CheckFormatHandler:: 5052 getSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 5053 SourceLocation Start = getLocationOfByte(startSpecifier); 5054 SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 5055 5056 // Advance the end SourceLocation by one due to half-open ranges. 5057 End = End.getLocWithOffset(1); 5058 5059 return CharSourceRange::getCharRange(Start, End); 5060 } 5061 5062 SourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 5063 return FExpr->getLocationOfByte(x - Beg, S.getSourceManager(), 5064 S.getLangOpts(), S.Context.getTargetInfo()); 5065 } 5066 5067 void CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 5068 unsigned specifierLen){ 5069 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier), 5070 getLocationOfByte(startSpecifier), 5071 /*IsStringLocation*/true, 5072 getSpecifierRange(startSpecifier, specifierLen)); 5073 } 5074 5075 void CheckFormatHandler::HandleInvalidLengthModifier( 5076 const analyze_format_string::FormatSpecifier &FS, 5077 const analyze_format_string::ConversionSpecifier &CS, 5078 const char *startSpecifier, unsigned specifierLen, unsigned DiagID) { 5079 using namespace analyze_format_string; 5080 5081 const LengthModifier &LM = FS.getLengthModifier(); 5082 CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength()); 5083 5084 // See if we know how to fix this length modifier. 5085 Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier(); 5086 if (FixedLM) { 5087 EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(), 5088 getLocationOfByte(LM.getStart()), 5089 /*IsStringLocation*/true, 5090 getSpecifierRange(startSpecifier, specifierLen)); 5091 5092 S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier) 5093 << FixedLM->toString() 5094 << FixItHint::CreateReplacement(LMRange, FixedLM->toString()); 5095 5096 } else { 5097 FixItHint Hint; 5098 if (DiagID == diag::warn_format_nonsensical_length) 5099 Hint = FixItHint::CreateRemoval(LMRange); 5100 5101 EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(), 5102 getLocationOfByte(LM.getStart()), 5103 /*IsStringLocation*/true, 5104 getSpecifierRange(startSpecifier, specifierLen), 5105 Hint); 5106 } 5107 } 5108 5109 void CheckFormatHandler::HandleNonStandardLengthModifier( 5110 const analyze_format_string::FormatSpecifier &FS, 5111 const char *startSpecifier, unsigned specifierLen) { 5112 using namespace analyze_format_string; 5113 5114 const LengthModifier &LM = FS.getLengthModifier(); 5115 CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength()); 5116 5117 // See if we know how to fix this length modifier. 5118 Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier(); 5119 if (FixedLM) { 5120 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 5121 << LM.toString() << 0, 5122 getLocationOfByte(LM.getStart()), 5123 /*IsStringLocation*/true, 5124 getSpecifierRange(startSpecifier, specifierLen)); 5125 5126 S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier) 5127 << FixedLM->toString() 5128 << FixItHint::CreateReplacement(LMRange, FixedLM->toString()); 5129 5130 } else { 5131 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 5132 << LM.toString() << 0, 5133 getLocationOfByte(LM.getStart()), 5134 /*IsStringLocation*/true, 5135 getSpecifierRange(startSpecifier, specifierLen)); 5136 } 5137 } 5138 5139 void CheckFormatHandler::HandleNonStandardConversionSpecifier( 5140 const analyze_format_string::ConversionSpecifier &CS, 5141 const char *startSpecifier, unsigned specifierLen) { 5142 using namespace analyze_format_string; 5143 5144 // See if we know how to fix this conversion specifier. 5145 Optional<ConversionSpecifier> FixedCS = CS.getStandardSpecifier(); 5146 if (FixedCS) { 5147 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 5148 << CS.toString() << /*conversion specifier*/1, 5149 getLocationOfByte(CS.getStart()), 5150 /*IsStringLocation*/true, 5151 getSpecifierRange(startSpecifier, specifierLen)); 5152 5153 CharSourceRange CSRange = getSpecifierRange(CS.getStart(), CS.getLength()); 5154 S.Diag(getLocationOfByte(CS.getStart()), diag::note_format_fix_specifier) 5155 << FixedCS->toString() 5156 << FixItHint::CreateReplacement(CSRange, FixedCS->toString()); 5157 } else { 5158 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 5159 << CS.toString() << /*conversion specifier*/1, 5160 getLocationOfByte(CS.getStart()), 5161 /*IsStringLocation*/true, 5162 getSpecifierRange(startSpecifier, specifierLen)); 5163 } 5164 } 5165 5166 void CheckFormatHandler::HandlePosition(const char *startPos, 5167 unsigned posLen) { 5168 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg), 5169 getLocationOfByte(startPos), 5170 /*IsStringLocation*/true, 5171 getSpecifierRange(startPos, posLen)); 5172 } 5173 5174 void 5175 CheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 5176 analyze_format_string::PositionContext p) { 5177 EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier) 5178 << (unsigned) p, 5179 getLocationOfByte(startPos), /*IsStringLocation*/true, 5180 getSpecifierRange(startPos, posLen)); 5181 } 5182 5183 void CheckFormatHandler::HandleZeroPosition(const char *startPos, 5184 unsigned posLen) { 5185 EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier), 5186 getLocationOfByte(startPos), 5187 /*IsStringLocation*/true, 5188 getSpecifierRange(startPos, posLen)); 5189 } 5190 5191 void CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 5192 if (!isa<ObjCStringLiteral>(OrigFormatExpr)) { 5193 // The presence of a null character is likely an error. 5194 EmitFormatDiagnostic( 5195 S.PDiag(diag::warn_printf_format_string_contains_null_char), 5196 getLocationOfByte(nullCharacter), /*IsStringLocation*/true, 5197 getFormatStringRange()); 5198 } 5199 } 5200 5201 // Note that this may return NULL if there was an error parsing or building 5202 // one of the argument expressions. 5203 const Expr *CheckFormatHandler::getDataArg(unsigned i) const { 5204 return Args[FirstDataArg + i]; 5205 } 5206 5207 void CheckFormatHandler::DoneProcessing() { 5208 // Does the number of data arguments exceed the number of 5209 // format conversions in the format string? 5210 if (!HasVAListArg) { 5211 // Find any arguments that weren't covered. 5212 CoveredArgs.flip(); 5213 signed notCoveredArg = CoveredArgs.find_first(); 5214 if (notCoveredArg >= 0) { 5215 assert((unsigned)notCoveredArg < NumDataArgs); 5216 UncoveredArg.Update(notCoveredArg, OrigFormatExpr); 5217 } else { 5218 UncoveredArg.setAllCovered(); 5219 } 5220 } 5221 } 5222 5223 void UncoveredArgHandler::Diagnose(Sema &S, bool IsFunctionCall, 5224 const Expr *ArgExpr) { 5225 assert(hasUncoveredArg() && DiagnosticExprs.size() > 0 && 5226 "Invalid state"); 5227 5228 if (!ArgExpr) 5229 return; 5230 5231 SourceLocation Loc = ArgExpr->getLocStart(); 5232 5233 if (S.getSourceManager().isInSystemMacro(Loc)) 5234 return; 5235 5236 PartialDiagnostic PDiag = S.PDiag(diag::warn_printf_data_arg_not_used); 5237 for (auto E : DiagnosticExprs) 5238 PDiag << E->getSourceRange(); 5239 5240 CheckFormatHandler::EmitFormatDiagnostic( 5241 S, IsFunctionCall, DiagnosticExprs[0], 5242 PDiag, Loc, /*IsStringLocation*/false, 5243 DiagnosticExprs[0]->getSourceRange()); 5244 } 5245 5246 bool 5247 CheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 5248 SourceLocation Loc, 5249 const char *startSpec, 5250 unsigned specifierLen, 5251 const char *csStart, 5252 unsigned csLen) { 5253 bool keepGoing = true; 5254 if (argIndex < NumDataArgs) { 5255 // Consider the argument coverered, even though the specifier doesn't 5256 // make sense. 5257 CoveredArgs.set(argIndex); 5258 } 5259 else { 5260 // If argIndex exceeds the number of data arguments we 5261 // don't issue a warning because that is just a cascade of warnings (and 5262 // they may have intended '%%' anyway). We don't want to continue processing 5263 // the format string after this point, however, as we will like just get 5264 // gibberish when trying to match arguments. 5265 keepGoing = false; 5266 } 5267 5268 StringRef Specifier(csStart, csLen); 5269 5270 // If the specifier in non-printable, it could be the first byte of a UTF-8 5271 // sequence. In that case, print the UTF-8 code point. If not, print the byte 5272 // hex value. 5273 std::string CodePointStr; 5274 if (!llvm::sys::locale::isPrint(*csStart)) { 5275 llvm::UTF32 CodePoint; 5276 const llvm::UTF8 **B = reinterpret_cast<const llvm::UTF8 **>(&csStart); 5277 const llvm::UTF8 *E = 5278 reinterpret_cast<const llvm::UTF8 *>(csStart + csLen); 5279 llvm::ConversionResult Result = 5280 llvm::convertUTF8Sequence(B, E, &CodePoint, llvm::strictConversion); 5281 5282 if (Result != llvm::conversionOK) { 5283 unsigned char FirstChar = *csStart; 5284 CodePoint = (llvm::UTF32)FirstChar; 5285 } 5286 5287 llvm::raw_string_ostream OS(CodePointStr); 5288 if (CodePoint < 256) 5289 OS << "\\x" << llvm::format("%02x", CodePoint); 5290 else if (CodePoint <= 0xFFFF) 5291 OS << "\\u" << llvm::format("%04x", CodePoint); 5292 else 5293 OS << "\\U" << llvm::format("%08x", CodePoint); 5294 OS.flush(); 5295 Specifier = CodePointStr; 5296 } 5297 5298 EmitFormatDiagnostic( 5299 S.PDiag(diag::warn_format_invalid_conversion) << Specifier, Loc, 5300 /*IsStringLocation*/ true, getSpecifierRange(startSpec, specifierLen)); 5301 5302 return keepGoing; 5303 } 5304 5305 void 5306 CheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc, 5307 const char *startSpec, 5308 unsigned specifierLen) { 5309 EmitFormatDiagnostic( 5310 S.PDiag(diag::warn_format_mix_positional_nonpositional_args), 5311 Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen)); 5312 } 5313 5314 bool 5315 CheckFormatHandler::CheckNumArgs( 5316 const analyze_format_string::FormatSpecifier &FS, 5317 const analyze_format_string::ConversionSpecifier &CS, 5318 const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 5319 5320 if (argIndex >= NumDataArgs) { 5321 PartialDiagnostic PDiag = FS.usesPositionalArg() 5322 ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args) 5323 << (argIndex+1) << NumDataArgs) 5324 : S.PDiag(diag::warn_printf_insufficient_data_args); 5325 EmitFormatDiagnostic( 5326 PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true, 5327 getSpecifierRange(startSpecifier, specifierLen)); 5328 5329 // Since more arguments than conversion tokens are given, by extension 5330 // all arguments are covered, so mark this as so. 5331 UncoveredArg.setAllCovered(); 5332 return false; 5333 } 5334 return true; 5335 } 5336 5337 template<typename Range> 5338 void CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag, 5339 SourceLocation Loc, 5340 bool IsStringLocation, 5341 Range StringRange, 5342 ArrayRef<FixItHint> FixIt) { 5343 EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag, 5344 Loc, IsStringLocation, StringRange, FixIt); 5345 } 5346 5347 /// \brief If the format string is not within the funcion call, emit a note 5348 /// so that the function call and string are in diagnostic messages. 5349 /// 5350 /// \param InFunctionCall if true, the format string is within the function 5351 /// call and only one diagnostic message will be produced. Otherwise, an 5352 /// extra note will be emitted pointing to location of the format string. 5353 /// 5354 /// \param ArgumentExpr the expression that is passed as the format string 5355 /// argument in the function call. Used for getting locations when two 5356 /// diagnostics are emitted. 5357 /// 5358 /// \param PDiag the callee should already have provided any strings for the 5359 /// diagnostic message. This function only adds locations and fixits 5360 /// to diagnostics. 5361 /// 5362 /// \param Loc primary location for diagnostic. If two diagnostics are 5363 /// required, one will be at Loc and a new SourceLocation will be created for 5364 /// the other one. 5365 /// 5366 /// \param IsStringLocation if true, Loc points to the format string should be 5367 /// used for the note. Otherwise, Loc points to the argument list and will 5368 /// be used with PDiag. 5369 /// 5370 /// \param StringRange some or all of the string to highlight. This is 5371 /// templated so it can accept either a CharSourceRange or a SourceRange. 5372 /// 5373 /// \param FixIt optional fix it hint for the format string. 5374 template <typename Range> 5375 void CheckFormatHandler::EmitFormatDiagnostic( 5376 Sema &S, bool InFunctionCall, const Expr *ArgumentExpr, 5377 const PartialDiagnostic &PDiag, SourceLocation Loc, bool IsStringLocation, 5378 Range StringRange, ArrayRef<FixItHint> FixIt) { 5379 if (InFunctionCall) { 5380 const Sema::SemaDiagnosticBuilder &D = S.Diag(Loc, PDiag); 5381 D << StringRange; 5382 D << FixIt; 5383 } else { 5384 S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag) 5385 << ArgumentExpr->getSourceRange(); 5386 5387 const Sema::SemaDiagnosticBuilder &Note = 5388 S.Diag(IsStringLocation ? Loc : StringRange.getBegin(), 5389 diag::note_format_string_defined); 5390 5391 Note << StringRange; 5392 Note << FixIt; 5393 } 5394 } 5395 5396 //===--- CHECK: Printf format string checking ------------------------------===// 5397 5398 namespace { 5399 class CheckPrintfHandler : public CheckFormatHandler { 5400 public: 5401 CheckPrintfHandler(Sema &s, const FormatStringLiteral *fexpr, 5402 const Expr *origFormatExpr, 5403 const Sema::FormatStringType type, unsigned firstDataArg, 5404 unsigned numDataArgs, bool isObjC, const char *beg, 5405 bool hasVAListArg, ArrayRef<const Expr *> Args, 5406 unsigned formatIdx, bool inFunctionCall, 5407 Sema::VariadicCallType CallType, 5408 llvm::SmallBitVector &CheckedVarArgs, 5409 UncoveredArgHandler &UncoveredArg) 5410 : CheckFormatHandler(s, fexpr, origFormatExpr, type, firstDataArg, 5411 numDataArgs, beg, hasVAListArg, Args, formatIdx, 5412 inFunctionCall, CallType, CheckedVarArgs, 5413 UncoveredArg) {} 5414 5415 bool isObjCContext() const { return FSType == Sema::FST_NSString; } 5416 5417 /// Returns true if '%@' specifiers are allowed in the format string. 5418 bool allowsObjCArg() const { 5419 return FSType == Sema::FST_NSString || FSType == Sema::FST_OSLog || 5420 FSType == Sema::FST_OSTrace; 5421 } 5422 5423 bool HandleInvalidPrintfConversionSpecifier( 5424 const analyze_printf::PrintfSpecifier &FS, 5425 const char *startSpecifier, 5426 unsigned specifierLen) override; 5427 5428 bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 5429 const char *startSpecifier, 5430 unsigned specifierLen) override; 5431 bool checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 5432 const char *StartSpecifier, 5433 unsigned SpecifierLen, 5434 const Expr *E); 5435 5436 bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 5437 const char *startSpecifier, unsigned specifierLen); 5438 void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 5439 const analyze_printf::OptionalAmount &Amt, 5440 unsigned type, 5441 const char *startSpecifier, unsigned specifierLen); 5442 void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 5443 const analyze_printf::OptionalFlag &flag, 5444 const char *startSpecifier, unsigned specifierLen); 5445 void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 5446 const analyze_printf::OptionalFlag &ignoredFlag, 5447 const analyze_printf::OptionalFlag &flag, 5448 const char *startSpecifier, unsigned specifierLen); 5449 bool checkForCStrMembers(const analyze_printf::ArgType &AT, 5450 const Expr *E); 5451 5452 void HandleEmptyObjCModifierFlag(const char *startFlag, 5453 unsigned flagLen) override; 5454 5455 void HandleInvalidObjCModifierFlag(const char *startFlag, 5456 unsigned flagLen) override; 5457 5458 void HandleObjCFlagsWithNonObjCConversion(const char *flagsStart, 5459 const char *flagsEnd, 5460 const char *conversionPosition) 5461 override; 5462 }; 5463 } // end anonymous namespace 5464 5465 bool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 5466 const analyze_printf::PrintfSpecifier &FS, 5467 const char *startSpecifier, 5468 unsigned specifierLen) { 5469 const analyze_printf::PrintfConversionSpecifier &CS = 5470 FS.getConversionSpecifier(); 5471 5472 return HandleInvalidConversionSpecifier(FS.getArgIndex(), 5473 getLocationOfByte(CS.getStart()), 5474 startSpecifier, specifierLen, 5475 CS.getStart(), CS.getLength()); 5476 } 5477 5478 bool CheckPrintfHandler::HandleAmount( 5479 const analyze_format_string::OptionalAmount &Amt, 5480 unsigned k, const char *startSpecifier, 5481 unsigned specifierLen) { 5482 if (Amt.hasDataArgument()) { 5483 if (!HasVAListArg) { 5484 unsigned argIndex = Amt.getArgIndex(); 5485 if (argIndex >= NumDataArgs) { 5486 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg) 5487 << k, 5488 getLocationOfByte(Amt.getStart()), 5489 /*IsStringLocation*/true, 5490 getSpecifierRange(startSpecifier, specifierLen)); 5491 // Don't do any more checking. We will just emit 5492 // spurious errors. 5493 return false; 5494 } 5495 5496 // Type check the data argument. It should be an 'int'. 5497 // Although not in conformance with C99, we also allow the argument to be 5498 // an 'unsigned int' as that is a reasonably safe case. GCC also 5499 // doesn't emit a warning for that case. 5500 CoveredArgs.set(argIndex); 5501 const Expr *Arg = getDataArg(argIndex); 5502 if (!Arg) 5503 return false; 5504 5505 QualType T = Arg->getType(); 5506 5507 const analyze_printf::ArgType &AT = Amt.getArgType(S.Context); 5508 assert(AT.isValid()); 5509 5510 if (!AT.matchesType(S.Context, T)) { 5511 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type) 5512 << k << AT.getRepresentativeTypeName(S.Context) 5513 << T << Arg->getSourceRange(), 5514 getLocationOfByte(Amt.getStart()), 5515 /*IsStringLocation*/true, 5516 getSpecifierRange(startSpecifier, specifierLen)); 5517 // Don't do any more checking. We will just emit 5518 // spurious errors. 5519 return false; 5520 } 5521 } 5522 } 5523 return true; 5524 } 5525 5526 void CheckPrintfHandler::HandleInvalidAmount( 5527 const analyze_printf::PrintfSpecifier &FS, 5528 const analyze_printf::OptionalAmount &Amt, 5529 unsigned type, 5530 const char *startSpecifier, 5531 unsigned specifierLen) { 5532 const analyze_printf::PrintfConversionSpecifier &CS = 5533 FS.getConversionSpecifier(); 5534 5535 FixItHint fixit = 5536 Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant 5537 ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 5538 Amt.getConstantLength())) 5539 : FixItHint(); 5540 5541 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount) 5542 << type << CS.toString(), 5543 getLocationOfByte(Amt.getStart()), 5544 /*IsStringLocation*/true, 5545 getSpecifierRange(startSpecifier, specifierLen), 5546 fixit); 5547 } 5548 5549 void CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 5550 const analyze_printf::OptionalFlag &flag, 5551 const char *startSpecifier, 5552 unsigned specifierLen) { 5553 // Warn about pointless flag with a fixit removal. 5554 const analyze_printf::PrintfConversionSpecifier &CS = 5555 FS.getConversionSpecifier(); 5556 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag) 5557 << flag.toString() << CS.toString(), 5558 getLocationOfByte(flag.getPosition()), 5559 /*IsStringLocation*/true, 5560 getSpecifierRange(startSpecifier, specifierLen), 5561 FixItHint::CreateRemoval( 5562 getSpecifierRange(flag.getPosition(), 1))); 5563 } 5564 5565 void CheckPrintfHandler::HandleIgnoredFlag( 5566 const analyze_printf::PrintfSpecifier &FS, 5567 const analyze_printf::OptionalFlag &ignoredFlag, 5568 const analyze_printf::OptionalFlag &flag, 5569 const char *startSpecifier, 5570 unsigned specifierLen) { 5571 // Warn about ignored flag with a fixit removal. 5572 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag) 5573 << ignoredFlag.toString() << flag.toString(), 5574 getLocationOfByte(ignoredFlag.getPosition()), 5575 /*IsStringLocation*/true, 5576 getSpecifierRange(startSpecifier, specifierLen), 5577 FixItHint::CreateRemoval( 5578 getSpecifierRange(ignoredFlag.getPosition(), 1))); 5579 } 5580 5581 // void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc, 5582 // bool IsStringLocation, Range StringRange, 5583 // ArrayRef<FixItHint> Fixit = None); 5584 5585 void CheckPrintfHandler::HandleEmptyObjCModifierFlag(const char *startFlag, 5586 unsigned flagLen) { 5587 // Warn about an empty flag. 5588 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_empty_objc_flag), 5589 getLocationOfByte(startFlag), 5590 /*IsStringLocation*/true, 5591 getSpecifierRange(startFlag, flagLen)); 5592 } 5593 5594 void CheckPrintfHandler::HandleInvalidObjCModifierFlag(const char *startFlag, 5595 unsigned flagLen) { 5596 // Warn about an invalid flag. 5597 auto Range = getSpecifierRange(startFlag, flagLen); 5598 StringRef flag(startFlag, flagLen); 5599 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_invalid_objc_flag) << flag, 5600 getLocationOfByte(startFlag), 5601 /*IsStringLocation*/true, 5602 Range, FixItHint::CreateRemoval(Range)); 5603 } 5604 5605 void CheckPrintfHandler::HandleObjCFlagsWithNonObjCConversion( 5606 const char *flagsStart, const char *flagsEnd, const char *conversionPosition) { 5607 // Warn about using '[...]' without a '@' conversion. 5608 auto Range = getSpecifierRange(flagsStart, flagsEnd - flagsStart + 1); 5609 auto diag = diag::warn_printf_ObjCflags_without_ObjCConversion; 5610 EmitFormatDiagnostic(S.PDiag(diag) << StringRef(conversionPosition, 1), 5611 getLocationOfByte(conversionPosition), 5612 /*IsStringLocation*/true, 5613 Range, FixItHint::CreateRemoval(Range)); 5614 } 5615 5616 // Determines if the specified is a C++ class or struct containing 5617 // a member with the specified name and kind (e.g. a CXXMethodDecl named 5618 // "c_str()"). 5619 template<typename MemberKind> 5620 static llvm::SmallPtrSet<MemberKind*, 1> 5621 CXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) { 5622 const RecordType *RT = Ty->getAs<RecordType>(); 5623 llvm::SmallPtrSet<MemberKind*, 1> Results; 5624 5625 if (!RT) 5626 return Results; 5627 const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl()); 5628 if (!RD || !RD->getDefinition()) 5629 return Results; 5630 5631 LookupResult R(S, &S.Context.Idents.get(Name), SourceLocation(), 5632 Sema::LookupMemberName); 5633 R.suppressDiagnostics(); 5634 5635 // We just need to include all members of the right kind turned up by the 5636 // filter, at this point. 5637 if (S.LookupQualifiedName(R, RT->getDecl())) 5638 for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) { 5639 NamedDecl *decl = (*I)->getUnderlyingDecl(); 5640 if (MemberKind *FK = dyn_cast<MemberKind>(decl)) 5641 Results.insert(FK); 5642 } 5643 return Results; 5644 } 5645 5646 /// Check if we could call '.c_str()' on an object. 5647 /// 5648 /// FIXME: This returns the wrong results in some cases (if cv-qualifiers don't 5649 /// allow the call, or if it would be ambiguous). 5650 bool Sema::hasCStrMethod(const Expr *E) { 5651 typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet; 5652 MethodSet Results = 5653 CXXRecordMembersNamed<CXXMethodDecl>("c_str", *this, E->getType()); 5654 for (MethodSet::iterator MI = Results.begin(), ME = Results.end(); 5655 MI != ME; ++MI) 5656 if ((*MI)->getMinRequiredArguments() == 0) 5657 return true; 5658 return false; 5659 } 5660 5661 // Check if a (w)string was passed when a (w)char* was needed, and offer a 5662 // better diagnostic if so. AT is assumed to be valid. 5663 // Returns true when a c_str() conversion method is found. 5664 bool CheckPrintfHandler::checkForCStrMembers( 5665 const analyze_printf::ArgType &AT, const Expr *E) { 5666 typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet; 5667 5668 MethodSet Results = 5669 CXXRecordMembersNamed<CXXMethodDecl>("c_str", S, E->getType()); 5670 5671 for (MethodSet::iterator MI = Results.begin(), ME = Results.end(); 5672 MI != ME; ++MI) { 5673 const CXXMethodDecl *Method = *MI; 5674 if (Method->getMinRequiredArguments() == 0 && 5675 AT.matchesType(S.Context, Method->getReturnType())) { 5676 // FIXME: Suggest parens if the expression needs them. 5677 SourceLocation EndLoc = S.getLocForEndOfToken(E->getLocEnd()); 5678 S.Diag(E->getLocStart(), diag::note_printf_c_str) 5679 << "c_str()" 5680 << FixItHint::CreateInsertion(EndLoc, ".c_str()"); 5681 return true; 5682 } 5683 } 5684 5685 return false; 5686 } 5687 5688 bool 5689 CheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 5690 &FS, 5691 const char *startSpecifier, 5692 unsigned specifierLen) { 5693 using namespace analyze_format_string; 5694 using namespace analyze_printf; 5695 const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 5696 5697 if (FS.consumesDataArgument()) { 5698 if (atFirstArg) { 5699 atFirstArg = false; 5700 usesPositionalArgs = FS.usesPositionalArg(); 5701 } 5702 else if (usesPositionalArgs != FS.usesPositionalArg()) { 5703 HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 5704 startSpecifier, specifierLen); 5705 return false; 5706 } 5707 } 5708 5709 // First check if the field width, precision, and conversion specifier 5710 // have matching data arguments. 5711 if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 5712 startSpecifier, specifierLen)) { 5713 return false; 5714 } 5715 5716 if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 5717 startSpecifier, specifierLen)) { 5718 return false; 5719 } 5720 5721 if (!CS.consumesDataArgument()) { 5722 // FIXME: Technically specifying a precision or field width here 5723 // makes no sense. Worth issuing a warning at some point. 5724 return true; 5725 } 5726 5727 // Consume the argument. 5728 unsigned argIndex = FS.getArgIndex(); 5729 if (argIndex < NumDataArgs) { 5730 // The check to see if the argIndex is valid will come later. 5731 // We set the bit here because we may exit early from this 5732 // function if we encounter some other error. 5733 CoveredArgs.set(argIndex); 5734 } 5735 5736 // FreeBSD kernel extensions. 5737 if (CS.getKind() == ConversionSpecifier::FreeBSDbArg || 5738 CS.getKind() == ConversionSpecifier::FreeBSDDArg) { 5739 // We need at least two arguments. 5740 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex + 1)) 5741 return false; 5742 5743 // Claim the second argument. 5744 CoveredArgs.set(argIndex + 1); 5745 5746 // Type check the first argument (int for %b, pointer for %D) 5747 const Expr *Ex = getDataArg(argIndex); 5748 const analyze_printf::ArgType &AT = 5749 (CS.getKind() == ConversionSpecifier::FreeBSDbArg) ? 5750 ArgType(S.Context.IntTy) : ArgType::CPointerTy; 5751 if (AT.isValid() && !AT.matchesType(S.Context, Ex->getType())) 5752 EmitFormatDiagnostic( 5753 S.PDiag(diag::warn_format_conversion_argument_type_mismatch) 5754 << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 5755 << false << Ex->getSourceRange(), 5756 Ex->getLocStart(), /*IsStringLocation*/false, 5757 getSpecifierRange(startSpecifier, specifierLen)); 5758 5759 // Type check the second argument (char * for both %b and %D) 5760 Ex = getDataArg(argIndex + 1); 5761 const analyze_printf::ArgType &AT2 = ArgType::CStrTy; 5762 if (AT2.isValid() && !AT2.matchesType(S.Context, Ex->getType())) 5763 EmitFormatDiagnostic( 5764 S.PDiag(diag::warn_format_conversion_argument_type_mismatch) 5765 << AT2.getRepresentativeTypeName(S.Context) << Ex->getType() 5766 << false << Ex->getSourceRange(), 5767 Ex->getLocStart(), /*IsStringLocation*/false, 5768 getSpecifierRange(startSpecifier, specifierLen)); 5769 5770 return true; 5771 } 5772 5773 // Check for using an Objective-C specific conversion specifier 5774 // in a non-ObjC literal. 5775 if (!allowsObjCArg() && CS.isObjCArg()) { 5776 return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 5777 specifierLen); 5778 } 5779 5780 // %P can only be used with os_log. 5781 if (FSType != Sema::FST_OSLog && CS.getKind() == ConversionSpecifier::PArg) { 5782 return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 5783 specifierLen); 5784 } 5785 5786 // %n is not allowed with os_log. 5787 if (FSType == Sema::FST_OSLog && CS.getKind() == ConversionSpecifier::nArg) { 5788 EmitFormatDiagnostic(S.PDiag(diag::warn_os_log_format_narg), 5789 getLocationOfByte(CS.getStart()), 5790 /*IsStringLocation*/ false, 5791 getSpecifierRange(startSpecifier, specifierLen)); 5792 5793 return true; 5794 } 5795 5796 // Only scalars are allowed for os_trace. 5797 if (FSType == Sema::FST_OSTrace && 5798 (CS.getKind() == ConversionSpecifier::PArg || 5799 CS.getKind() == ConversionSpecifier::sArg || 5800 CS.getKind() == ConversionSpecifier::ObjCObjArg)) { 5801 return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 5802 specifierLen); 5803 } 5804 5805 // Check for use of public/private annotation outside of os_log(). 5806 if (FSType != Sema::FST_OSLog) { 5807 if (FS.isPublic().isSet()) { 5808 EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_annotation) 5809 << "public", 5810 getLocationOfByte(FS.isPublic().getPosition()), 5811 /*IsStringLocation*/ false, 5812 getSpecifierRange(startSpecifier, specifierLen)); 5813 } 5814 if (FS.isPrivate().isSet()) { 5815 EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_annotation) 5816 << "private", 5817 getLocationOfByte(FS.isPrivate().getPosition()), 5818 /*IsStringLocation*/ false, 5819 getSpecifierRange(startSpecifier, specifierLen)); 5820 } 5821 } 5822 5823 // Check for invalid use of field width 5824 if (!FS.hasValidFieldWidth()) { 5825 HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 5826 startSpecifier, specifierLen); 5827 } 5828 5829 // Check for invalid use of precision 5830 if (!FS.hasValidPrecision()) { 5831 HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 5832 startSpecifier, specifierLen); 5833 } 5834 5835 // Precision is mandatory for %P specifier. 5836 if (CS.getKind() == ConversionSpecifier::PArg && 5837 FS.getPrecision().getHowSpecified() == OptionalAmount::NotSpecified) { 5838 EmitFormatDiagnostic(S.PDiag(diag::warn_format_P_no_precision), 5839 getLocationOfByte(startSpecifier), 5840 /*IsStringLocation*/ false, 5841 getSpecifierRange(startSpecifier, specifierLen)); 5842 } 5843 5844 // Check each flag does not conflict with any other component. 5845 if (!FS.hasValidThousandsGroupingPrefix()) 5846 HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 5847 if (!FS.hasValidLeadingZeros()) 5848 HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 5849 if (!FS.hasValidPlusPrefix()) 5850 HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 5851 if (!FS.hasValidSpacePrefix()) 5852 HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 5853 if (!FS.hasValidAlternativeForm()) 5854 HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 5855 if (!FS.hasValidLeftJustified()) 5856 HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 5857 5858 // Check that flags are not ignored by another flag 5859 if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 5860 HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 5861 startSpecifier, specifierLen); 5862 if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 5863 HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 5864 startSpecifier, specifierLen); 5865 5866 // Check the length modifier is valid with the given conversion specifier. 5867 if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo())) 5868 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 5869 diag::warn_format_nonsensical_length); 5870 else if (!FS.hasStandardLengthModifier()) 5871 HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen); 5872 else if (!FS.hasStandardLengthConversionCombination()) 5873 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 5874 diag::warn_format_non_standard_conversion_spec); 5875 5876 if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 5877 HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 5878 5879 // The remaining checks depend on the data arguments. 5880 if (HasVAListArg) 5881 return true; 5882 5883 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 5884 return false; 5885 5886 const Expr *Arg = getDataArg(argIndex); 5887 if (!Arg) 5888 return true; 5889 5890 return checkFormatExpr(FS, startSpecifier, specifierLen, Arg); 5891 } 5892 5893 static bool requiresParensToAddCast(const Expr *E) { 5894 // FIXME: We should have a general way to reason about operator 5895 // precedence and whether parens are actually needed here. 5896 // Take care of a few common cases where they aren't. 5897 const Expr *Inside = E->IgnoreImpCasts(); 5898 if (const PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(Inside)) 5899 Inside = POE->getSyntacticForm()->IgnoreImpCasts(); 5900 5901 switch (Inside->getStmtClass()) { 5902 case Stmt::ArraySubscriptExprClass: 5903 case Stmt::CallExprClass: 5904 case Stmt::CharacterLiteralClass: 5905 case Stmt::CXXBoolLiteralExprClass: 5906 case Stmt::DeclRefExprClass: 5907 case Stmt::FloatingLiteralClass: 5908 case Stmt::IntegerLiteralClass: 5909 case Stmt::MemberExprClass: 5910 case Stmt::ObjCArrayLiteralClass: 5911 case Stmt::ObjCBoolLiteralExprClass: 5912 case Stmt::ObjCBoxedExprClass: 5913 case Stmt::ObjCDictionaryLiteralClass: 5914 case Stmt::ObjCEncodeExprClass: 5915 case Stmt::ObjCIvarRefExprClass: 5916 case Stmt::ObjCMessageExprClass: 5917 case Stmt::ObjCPropertyRefExprClass: 5918 case Stmt::ObjCStringLiteralClass: 5919 case Stmt::ObjCSubscriptRefExprClass: 5920 case Stmt::ParenExprClass: 5921 case Stmt::StringLiteralClass: 5922 case Stmt::UnaryOperatorClass: 5923 return false; 5924 default: 5925 return true; 5926 } 5927 } 5928 5929 static std::pair<QualType, StringRef> 5930 shouldNotPrintDirectly(const ASTContext &Context, 5931 QualType IntendedTy, 5932 const Expr *E) { 5933 // Use a 'while' to peel off layers of typedefs. 5934 QualType TyTy = IntendedTy; 5935 while (const TypedefType *UserTy = TyTy->getAs<TypedefType>()) { 5936 StringRef Name = UserTy->getDecl()->getName(); 5937 QualType CastTy = llvm::StringSwitch<QualType>(Name) 5938 .Case("NSInteger", Context.LongTy) 5939 .Case("NSUInteger", Context.UnsignedLongTy) 5940 .Case("SInt32", Context.IntTy) 5941 .Case("UInt32", Context.UnsignedIntTy) 5942 .Default(QualType()); 5943 5944 if (!CastTy.isNull()) 5945 return std::make_pair(CastTy, Name); 5946 5947 TyTy = UserTy->desugar(); 5948 } 5949 5950 // Strip parens if necessary. 5951 if (const ParenExpr *PE = dyn_cast<ParenExpr>(E)) 5952 return shouldNotPrintDirectly(Context, 5953 PE->getSubExpr()->getType(), 5954 PE->getSubExpr()); 5955 5956 // If this is a conditional expression, then its result type is constructed 5957 // via usual arithmetic conversions and thus there might be no necessary 5958 // typedef sugar there. Recurse to operands to check for NSInteger & 5959 // Co. usage condition. 5960 if (const ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 5961 QualType TrueTy, FalseTy; 5962 StringRef TrueName, FalseName; 5963 5964 std::tie(TrueTy, TrueName) = 5965 shouldNotPrintDirectly(Context, 5966 CO->getTrueExpr()->getType(), 5967 CO->getTrueExpr()); 5968 std::tie(FalseTy, FalseName) = 5969 shouldNotPrintDirectly(Context, 5970 CO->getFalseExpr()->getType(), 5971 CO->getFalseExpr()); 5972 5973 if (TrueTy == FalseTy) 5974 return std::make_pair(TrueTy, TrueName); 5975 else if (TrueTy.isNull()) 5976 return std::make_pair(FalseTy, FalseName); 5977 else if (FalseTy.isNull()) 5978 return std::make_pair(TrueTy, TrueName); 5979 } 5980 5981 return std::make_pair(QualType(), StringRef()); 5982 } 5983 5984 bool 5985 CheckPrintfHandler::checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 5986 const char *StartSpecifier, 5987 unsigned SpecifierLen, 5988 const Expr *E) { 5989 using namespace analyze_format_string; 5990 using namespace analyze_printf; 5991 // Now type check the data expression that matches the 5992 // format specifier. 5993 const analyze_printf::ArgType &AT = FS.getArgType(S.Context, isObjCContext()); 5994 if (!AT.isValid()) 5995 return true; 5996 5997 QualType ExprTy = E->getType(); 5998 while (const TypeOfExprType *TET = dyn_cast<TypeOfExprType>(ExprTy)) { 5999 ExprTy = TET->getUnderlyingExpr()->getType(); 6000 } 6001 6002 analyze_printf::ArgType::MatchKind match = AT.matchesType(S.Context, ExprTy); 6003 6004 if (match == analyze_printf::ArgType::Match) { 6005 return true; 6006 } 6007 6008 // Look through argument promotions for our error message's reported type. 6009 // This includes the integral and floating promotions, but excludes array 6010 // and function pointer decay; seeing that an argument intended to be a 6011 // string has type 'char [6]' is probably more confusing than 'char *'. 6012 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 6013 if (ICE->getCastKind() == CK_IntegralCast || 6014 ICE->getCastKind() == CK_FloatingCast) { 6015 E = ICE->getSubExpr(); 6016 ExprTy = E->getType(); 6017 6018 // Check if we didn't match because of an implicit cast from a 'char' 6019 // or 'short' to an 'int'. This is done because printf is a varargs 6020 // function. 6021 if (ICE->getType() == S.Context.IntTy || 6022 ICE->getType() == S.Context.UnsignedIntTy) { 6023 // All further checking is done on the subexpression. 6024 if (AT.matchesType(S.Context, ExprTy)) 6025 return true; 6026 } 6027 } 6028 } else if (const CharacterLiteral *CL = dyn_cast<CharacterLiteral>(E)) { 6029 // Special case for 'a', which has type 'int' in C. 6030 // Note, however, that we do /not/ want to treat multibyte constants like 6031 // 'MooV' as characters! This form is deprecated but still exists. 6032 if (ExprTy == S.Context.IntTy) 6033 if (llvm::isUIntN(S.Context.getCharWidth(), CL->getValue())) 6034 ExprTy = S.Context.CharTy; 6035 } 6036 6037 // Look through enums to their underlying type. 6038 bool IsEnum = false; 6039 if (auto EnumTy = ExprTy->getAs<EnumType>()) { 6040 ExprTy = EnumTy->getDecl()->getIntegerType(); 6041 IsEnum = true; 6042 } 6043 6044 // %C in an Objective-C context prints a unichar, not a wchar_t. 6045 // If the argument is an integer of some kind, believe the %C and suggest 6046 // a cast instead of changing the conversion specifier. 6047 QualType IntendedTy = ExprTy; 6048 if (isObjCContext() && 6049 FS.getConversionSpecifier().getKind() == ConversionSpecifier::CArg) { 6050 if (ExprTy->isIntegralOrUnscopedEnumerationType() && 6051 !ExprTy->isCharType()) { 6052 // 'unichar' is defined as a typedef of unsigned short, but we should 6053 // prefer using the typedef if it is visible. 6054 IntendedTy = S.Context.UnsignedShortTy; 6055 6056 // While we are here, check if the value is an IntegerLiteral that happens 6057 // to be within the valid range. 6058 if (const IntegerLiteral *IL = dyn_cast<IntegerLiteral>(E)) { 6059 const llvm::APInt &V = IL->getValue(); 6060 if (V.getActiveBits() <= S.Context.getTypeSize(IntendedTy)) 6061 return true; 6062 } 6063 6064 LookupResult Result(S, &S.Context.Idents.get("unichar"), E->getLocStart(), 6065 Sema::LookupOrdinaryName); 6066 if (S.LookupName(Result, S.getCurScope())) { 6067 NamedDecl *ND = Result.getFoundDecl(); 6068 if (TypedefNameDecl *TD = dyn_cast<TypedefNameDecl>(ND)) 6069 if (TD->getUnderlyingType() == IntendedTy) 6070 IntendedTy = S.Context.getTypedefType(TD); 6071 } 6072 } 6073 } 6074 6075 // Special-case some of Darwin's platform-independence types by suggesting 6076 // casts to primitive types that are known to be large enough. 6077 bool ShouldNotPrintDirectly = false; StringRef CastTyName; 6078 if (S.Context.getTargetInfo().getTriple().isOSDarwin()) { 6079 QualType CastTy; 6080 std::tie(CastTy, CastTyName) = shouldNotPrintDirectly(S.Context, IntendedTy, E); 6081 if (!CastTy.isNull()) { 6082 IntendedTy = CastTy; 6083 ShouldNotPrintDirectly = true; 6084 } 6085 } 6086 6087 // We may be able to offer a FixItHint if it is a supported type. 6088 PrintfSpecifier fixedFS = FS; 6089 bool success = 6090 fixedFS.fixType(IntendedTy, S.getLangOpts(), S.Context, isObjCContext()); 6091 6092 if (success) { 6093 // Get the fix string from the fixed format specifier 6094 SmallString<16> buf; 6095 llvm::raw_svector_ostream os(buf); 6096 fixedFS.toString(os); 6097 6098 CharSourceRange SpecRange = getSpecifierRange(StartSpecifier, SpecifierLen); 6099 6100 if (IntendedTy == ExprTy && !ShouldNotPrintDirectly) { 6101 unsigned diag = diag::warn_format_conversion_argument_type_mismatch; 6102 if (match == analyze_format_string::ArgType::NoMatchPedantic) { 6103 diag = diag::warn_format_conversion_argument_type_mismatch_pedantic; 6104 } 6105 // In this case, the specifier is wrong and should be changed to match 6106 // the argument. 6107 EmitFormatDiagnostic(S.PDiag(diag) 6108 << AT.getRepresentativeTypeName(S.Context) 6109 << IntendedTy << IsEnum << E->getSourceRange(), 6110 E->getLocStart(), 6111 /*IsStringLocation*/ false, SpecRange, 6112 FixItHint::CreateReplacement(SpecRange, os.str())); 6113 } else { 6114 // The canonical type for formatting this value is different from the 6115 // actual type of the expression. (This occurs, for example, with Darwin's 6116 // NSInteger on 32-bit platforms, where it is typedef'd as 'int', but 6117 // should be printed as 'long' for 64-bit compatibility.) 6118 // Rather than emitting a normal format/argument mismatch, we want to 6119 // add a cast to the recommended type (and correct the format string 6120 // if necessary). 6121 SmallString<16> CastBuf; 6122 llvm::raw_svector_ostream CastFix(CastBuf); 6123 CastFix << "("; 6124 IntendedTy.print(CastFix, S.Context.getPrintingPolicy()); 6125 CastFix << ")"; 6126 6127 SmallVector<FixItHint,4> Hints; 6128 if (!AT.matchesType(S.Context, IntendedTy)) 6129 Hints.push_back(FixItHint::CreateReplacement(SpecRange, os.str())); 6130 6131 if (const CStyleCastExpr *CCast = dyn_cast<CStyleCastExpr>(E)) { 6132 // If there's already a cast present, just replace it. 6133 SourceRange CastRange(CCast->getLParenLoc(), CCast->getRParenLoc()); 6134 Hints.push_back(FixItHint::CreateReplacement(CastRange, CastFix.str())); 6135 6136 } else if (!requiresParensToAddCast(E)) { 6137 // If the expression has high enough precedence, 6138 // just write the C-style cast. 6139 Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 6140 CastFix.str())); 6141 } else { 6142 // Otherwise, add parens around the expression as well as the cast. 6143 CastFix << "("; 6144 Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 6145 CastFix.str())); 6146 6147 SourceLocation After = S.getLocForEndOfToken(E->getLocEnd()); 6148 Hints.push_back(FixItHint::CreateInsertion(After, ")")); 6149 } 6150 6151 if (ShouldNotPrintDirectly) { 6152 // The expression has a type that should not be printed directly. 6153 // We extract the name from the typedef because we don't want to show 6154 // the underlying type in the diagnostic. 6155 StringRef Name; 6156 if (const TypedefType *TypedefTy = dyn_cast<TypedefType>(ExprTy)) 6157 Name = TypedefTy->getDecl()->getName(); 6158 else 6159 Name = CastTyName; 6160 EmitFormatDiagnostic(S.PDiag(diag::warn_format_argument_needs_cast) 6161 << Name << IntendedTy << IsEnum 6162 << E->getSourceRange(), 6163 E->getLocStart(), /*IsStringLocation=*/false, 6164 SpecRange, Hints); 6165 } else { 6166 // In this case, the expression could be printed using a different 6167 // specifier, but we've decided that the specifier is probably correct 6168 // and we should cast instead. Just use the normal warning message. 6169 EmitFormatDiagnostic( 6170 S.PDiag(diag::warn_format_conversion_argument_type_mismatch) 6171 << AT.getRepresentativeTypeName(S.Context) << ExprTy << IsEnum 6172 << E->getSourceRange(), 6173 E->getLocStart(), /*IsStringLocation*/false, 6174 SpecRange, Hints); 6175 } 6176 } 6177 } else { 6178 const CharSourceRange &CSR = getSpecifierRange(StartSpecifier, 6179 SpecifierLen); 6180 // Since the warning for passing non-POD types to variadic functions 6181 // was deferred until now, we emit a warning for non-POD 6182 // arguments here. 6183 switch (S.isValidVarArgType(ExprTy)) { 6184 case Sema::VAK_Valid: 6185 case Sema::VAK_ValidInCXX11: { 6186 unsigned diag = diag::warn_format_conversion_argument_type_mismatch; 6187 if (match == analyze_printf::ArgType::NoMatchPedantic) { 6188 diag = diag::warn_format_conversion_argument_type_mismatch_pedantic; 6189 } 6190 6191 EmitFormatDiagnostic( 6192 S.PDiag(diag) << AT.getRepresentativeTypeName(S.Context) << ExprTy 6193 << IsEnum << CSR << E->getSourceRange(), 6194 E->getLocStart(), /*IsStringLocation*/ false, CSR); 6195 break; 6196 } 6197 case Sema::VAK_Undefined: 6198 case Sema::VAK_MSVCUndefined: 6199 EmitFormatDiagnostic( 6200 S.PDiag(diag::warn_non_pod_vararg_with_format_string) 6201 << S.getLangOpts().CPlusPlus11 6202 << ExprTy 6203 << CallType 6204 << AT.getRepresentativeTypeName(S.Context) 6205 << CSR 6206 << E->getSourceRange(), 6207 E->getLocStart(), /*IsStringLocation*/false, CSR); 6208 checkForCStrMembers(AT, E); 6209 break; 6210 6211 case Sema::VAK_Invalid: 6212 if (ExprTy->isObjCObjectType()) 6213 EmitFormatDiagnostic( 6214 S.PDiag(diag::err_cannot_pass_objc_interface_to_vararg_format) 6215 << S.getLangOpts().CPlusPlus11 6216 << ExprTy 6217 << CallType 6218 << AT.getRepresentativeTypeName(S.Context) 6219 << CSR 6220 << E->getSourceRange(), 6221 E->getLocStart(), /*IsStringLocation*/false, CSR); 6222 else 6223 // FIXME: If this is an initializer list, suggest removing the braces 6224 // or inserting a cast to the target type. 6225 S.Diag(E->getLocStart(), diag::err_cannot_pass_to_vararg_format) 6226 << isa<InitListExpr>(E) << ExprTy << CallType 6227 << AT.getRepresentativeTypeName(S.Context) 6228 << E->getSourceRange(); 6229 break; 6230 } 6231 6232 assert(FirstDataArg + FS.getArgIndex() < CheckedVarArgs.size() && 6233 "format string specifier index out of range"); 6234 CheckedVarArgs[FirstDataArg + FS.getArgIndex()] = true; 6235 } 6236 6237 return true; 6238 } 6239 6240 //===--- CHECK: Scanf format string checking ------------------------------===// 6241 6242 namespace { 6243 class CheckScanfHandler : public CheckFormatHandler { 6244 public: 6245 CheckScanfHandler(Sema &s, const FormatStringLiteral *fexpr, 6246 const Expr *origFormatExpr, Sema::FormatStringType type, 6247 unsigned firstDataArg, unsigned numDataArgs, 6248 const char *beg, bool hasVAListArg, 6249 ArrayRef<const Expr *> Args, unsigned formatIdx, 6250 bool inFunctionCall, Sema::VariadicCallType CallType, 6251 llvm::SmallBitVector &CheckedVarArgs, 6252 UncoveredArgHandler &UncoveredArg) 6253 : CheckFormatHandler(s, fexpr, origFormatExpr, type, firstDataArg, 6254 numDataArgs, beg, hasVAListArg, Args, formatIdx, 6255 inFunctionCall, CallType, CheckedVarArgs, 6256 UncoveredArg) {} 6257 6258 bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 6259 const char *startSpecifier, 6260 unsigned specifierLen) override; 6261 6262 bool HandleInvalidScanfConversionSpecifier( 6263 const analyze_scanf::ScanfSpecifier &FS, 6264 const char *startSpecifier, 6265 unsigned specifierLen) override; 6266 6267 void HandleIncompleteScanList(const char *start, const char *end) override; 6268 }; 6269 } // end anonymous namespace 6270 6271 void CheckScanfHandler::HandleIncompleteScanList(const char *start, 6272 const char *end) { 6273 EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete), 6274 getLocationOfByte(end), /*IsStringLocation*/true, 6275 getSpecifierRange(start, end - start)); 6276 } 6277 6278 bool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 6279 const analyze_scanf::ScanfSpecifier &FS, 6280 const char *startSpecifier, 6281 unsigned specifierLen) { 6282 6283 const analyze_scanf::ScanfConversionSpecifier &CS = 6284 FS.getConversionSpecifier(); 6285 6286 return HandleInvalidConversionSpecifier(FS.getArgIndex(), 6287 getLocationOfByte(CS.getStart()), 6288 startSpecifier, specifierLen, 6289 CS.getStart(), CS.getLength()); 6290 } 6291 6292 bool CheckScanfHandler::HandleScanfSpecifier( 6293 const analyze_scanf::ScanfSpecifier &FS, 6294 const char *startSpecifier, 6295 unsigned specifierLen) { 6296 using namespace analyze_scanf; 6297 using namespace analyze_format_string; 6298 6299 const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 6300 6301 // Handle case where '%' and '*' don't consume an argument. These shouldn't 6302 // be used to decide if we are using positional arguments consistently. 6303 if (FS.consumesDataArgument()) { 6304 if (atFirstArg) { 6305 atFirstArg = false; 6306 usesPositionalArgs = FS.usesPositionalArg(); 6307 } 6308 else if (usesPositionalArgs != FS.usesPositionalArg()) { 6309 HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 6310 startSpecifier, specifierLen); 6311 return false; 6312 } 6313 } 6314 6315 // Check if the field with is non-zero. 6316 const OptionalAmount &Amt = FS.getFieldWidth(); 6317 if (Amt.getHowSpecified() == OptionalAmount::Constant) { 6318 if (Amt.getConstantAmount() == 0) { 6319 const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 6320 Amt.getConstantLength()); 6321 EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width), 6322 getLocationOfByte(Amt.getStart()), 6323 /*IsStringLocation*/true, R, 6324 FixItHint::CreateRemoval(R)); 6325 } 6326 } 6327 6328 if (!FS.consumesDataArgument()) { 6329 // FIXME: Technically specifying a precision or field width here 6330 // makes no sense. Worth issuing a warning at some point. 6331 return true; 6332 } 6333 6334 // Consume the argument. 6335 unsigned argIndex = FS.getArgIndex(); 6336 if (argIndex < NumDataArgs) { 6337 // The check to see if the argIndex is valid will come later. 6338 // We set the bit here because we may exit early from this 6339 // function if we encounter some other error. 6340 CoveredArgs.set(argIndex); 6341 } 6342 6343 // Check the length modifier is valid with the given conversion specifier. 6344 if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo())) 6345 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 6346 diag::warn_format_nonsensical_length); 6347 else if (!FS.hasStandardLengthModifier()) 6348 HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen); 6349 else if (!FS.hasStandardLengthConversionCombination()) 6350 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 6351 diag::warn_format_non_standard_conversion_spec); 6352 6353 if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 6354 HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 6355 6356 // The remaining checks depend on the data arguments. 6357 if (HasVAListArg) 6358 return true; 6359 6360 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 6361 return false; 6362 6363 // Check that the argument type matches the format specifier. 6364 const Expr *Ex = getDataArg(argIndex); 6365 if (!Ex) 6366 return true; 6367 6368 const analyze_format_string::ArgType &AT = FS.getArgType(S.Context); 6369 6370 if (!AT.isValid()) { 6371 return true; 6372 } 6373 6374 analyze_format_string::ArgType::MatchKind match = 6375 AT.matchesType(S.Context, Ex->getType()); 6376 if (match == analyze_format_string::ArgType::Match) { 6377 return true; 6378 } 6379 6380 ScanfSpecifier fixedFS = FS; 6381 bool success = fixedFS.fixType(Ex->getType(), Ex->IgnoreImpCasts()->getType(), 6382 S.getLangOpts(), S.Context); 6383 6384 unsigned diag = diag::warn_format_conversion_argument_type_mismatch; 6385 if (match == analyze_format_string::ArgType::NoMatchPedantic) { 6386 diag = diag::warn_format_conversion_argument_type_mismatch_pedantic; 6387 } 6388 6389 if (success) { 6390 // Get the fix string from the fixed format specifier. 6391 SmallString<128> buf; 6392 llvm::raw_svector_ostream os(buf); 6393 fixedFS.toString(os); 6394 6395 EmitFormatDiagnostic( 6396 S.PDiag(diag) << AT.getRepresentativeTypeName(S.Context) 6397 << Ex->getType() << false << Ex->getSourceRange(), 6398 Ex->getLocStart(), 6399 /*IsStringLocation*/ false, 6400 getSpecifierRange(startSpecifier, specifierLen), 6401 FixItHint::CreateReplacement( 6402 getSpecifierRange(startSpecifier, specifierLen), os.str())); 6403 } else { 6404 EmitFormatDiagnostic(S.PDiag(diag) 6405 << AT.getRepresentativeTypeName(S.Context) 6406 << Ex->getType() << false << Ex->getSourceRange(), 6407 Ex->getLocStart(), 6408 /*IsStringLocation*/ false, 6409 getSpecifierRange(startSpecifier, specifierLen)); 6410 } 6411 6412 return true; 6413 } 6414 6415 static void CheckFormatString(Sema &S, const FormatStringLiteral *FExpr, 6416 const Expr *OrigFormatExpr, 6417 ArrayRef<const Expr *> Args, 6418 bool HasVAListArg, unsigned format_idx, 6419 unsigned firstDataArg, 6420 Sema::FormatStringType Type, 6421 bool inFunctionCall, 6422 Sema::VariadicCallType CallType, 6423 llvm::SmallBitVector &CheckedVarArgs, 6424 UncoveredArgHandler &UncoveredArg) { 6425 // CHECK: is the format string a wide literal? 6426 if (!FExpr->isAscii() && !FExpr->isUTF8()) { 6427 CheckFormatHandler::EmitFormatDiagnostic( 6428 S, inFunctionCall, Args[format_idx], 6429 S.PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(), 6430 /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 6431 return; 6432 } 6433 6434 // Str - The format string. NOTE: this is NOT null-terminated! 6435 StringRef StrRef = FExpr->getString(); 6436 const char *Str = StrRef.data(); 6437 // Account for cases where the string literal is truncated in a declaration. 6438 const ConstantArrayType *T = 6439 S.Context.getAsConstantArrayType(FExpr->getType()); 6440 assert(T && "String literal not of constant array type!"); 6441 size_t TypeSize = T->getSize().getZExtValue(); 6442 size_t StrLen = std::min(std::max(TypeSize, size_t(1)) - 1, StrRef.size()); 6443 const unsigned numDataArgs = Args.size() - firstDataArg; 6444 6445 // Emit a warning if the string literal is truncated and does not contain an 6446 // embedded null character. 6447 if (TypeSize <= StrRef.size() && 6448 StrRef.substr(0, TypeSize).find('\0') == StringRef::npos) { 6449 CheckFormatHandler::EmitFormatDiagnostic( 6450 S, inFunctionCall, Args[format_idx], 6451 S.PDiag(diag::warn_printf_format_string_not_null_terminated), 6452 FExpr->getLocStart(), 6453 /*IsStringLocation=*/true, OrigFormatExpr->getSourceRange()); 6454 return; 6455 } 6456 6457 // CHECK: empty format string? 6458 if (StrLen == 0 && numDataArgs > 0) { 6459 CheckFormatHandler::EmitFormatDiagnostic( 6460 S, inFunctionCall, Args[format_idx], 6461 S.PDiag(diag::warn_empty_format_string), FExpr->getLocStart(), 6462 /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 6463 return; 6464 } 6465 6466 if (Type == Sema::FST_Printf || Type == Sema::FST_NSString || 6467 Type == Sema::FST_FreeBSDKPrintf || Type == Sema::FST_OSLog || 6468 Type == Sema::FST_OSTrace) { 6469 CheckPrintfHandler H( 6470 S, FExpr, OrigFormatExpr, Type, firstDataArg, numDataArgs, 6471 (Type == Sema::FST_NSString || Type == Sema::FST_OSTrace), Str, 6472 HasVAListArg, Args, format_idx, inFunctionCall, CallType, 6473 CheckedVarArgs, UncoveredArg); 6474 6475 if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen, 6476 S.getLangOpts(), 6477 S.Context.getTargetInfo(), 6478 Type == Sema::FST_FreeBSDKPrintf)) 6479 H.DoneProcessing(); 6480 } else if (Type == Sema::FST_Scanf) { 6481 CheckScanfHandler H(S, FExpr, OrigFormatExpr, Type, firstDataArg, 6482 numDataArgs, Str, HasVAListArg, Args, format_idx, 6483 inFunctionCall, CallType, CheckedVarArgs, UncoveredArg); 6484 6485 if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen, 6486 S.getLangOpts(), 6487 S.Context.getTargetInfo())) 6488 H.DoneProcessing(); 6489 } // TODO: handle other formats 6490 } 6491 6492 bool Sema::FormatStringHasSArg(const StringLiteral *FExpr) { 6493 // Str - The format string. NOTE: this is NOT null-terminated! 6494 StringRef StrRef = FExpr->getString(); 6495 const char *Str = StrRef.data(); 6496 // Account for cases where the string literal is truncated in a declaration. 6497 const ConstantArrayType *T = Context.getAsConstantArrayType(FExpr->getType()); 6498 assert(T && "String literal not of constant array type!"); 6499 size_t TypeSize = T->getSize().getZExtValue(); 6500 size_t StrLen = std::min(std::max(TypeSize, size_t(1)) - 1, StrRef.size()); 6501 return analyze_format_string::ParseFormatStringHasSArg(Str, Str + StrLen, 6502 getLangOpts(), 6503 Context.getTargetInfo()); 6504 } 6505 6506 //===--- CHECK: Warn on use of wrong absolute value function. -------------===// 6507 6508 // Returns the related absolute value function that is larger, of 0 if one 6509 // does not exist. 6510 static unsigned getLargerAbsoluteValueFunction(unsigned AbsFunction) { 6511 switch (AbsFunction) { 6512 default: 6513 return 0; 6514 6515 case Builtin::BI__builtin_abs: 6516 return Builtin::BI__builtin_labs; 6517 case Builtin::BI__builtin_labs: 6518 return Builtin::BI__builtin_llabs; 6519 case Builtin::BI__builtin_llabs: 6520 return 0; 6521 6522 case Builtin::BI__builtin_fabsf: 6523 return Builtin::BI__builtin_fabs; 6524 case Builtin::BI__builtin_fabs: 6525 return Builtin::BI__builtin_fabsl; 6526 case Builtin::BI__builtin_fabsl: 6527 return 0; 6528 6529 case Builtin::BI__builtin_cabsf: 6530 return Builtin::BI__builtin_cabs; 6531 case Builtin::BI__builtin_cabs: 6532 return Builtin::BI__builtin_cabsl; 6533 case Builtin::BI__builtin_cabsl: 6534 return 0; 6535 6536 case Builtin::BIabs: 6537 return Builtin::BIlabs; 6538 case Builtin::BIlabs: 6539 return Builtin::BIllabs; 6540 case Builtin::BIllabs: 6541 return 0; 6542 6543 case Builtin::BIfabsf: 6544 return Builtin::BIfabs; 6545 case Builtin::BIfabs: 6546 return Builtin::BIfabsl; 6547 case Builtin::BIfabsl: 6548 return 0; 6549 6550 case Builtin::BIcabsf: 6551 return Builtin::BIcabs; 6552 case Builtin::BIcabs: 6553 return Builtin::BIcabsl; 6554 case Builtin::BIcabsl: 6555 return 0; 6556 } 6557 } 6558 6559 // Returns the argument type of the absolute value function. 6560 static QualType getAbsoluteValueArgumentType(ASTContext &Context, 6561 unsigned AbsType) { 6562 if (AbsType == 0) 6563 return QualType(); 6564 6565 ASTContext::GetBuiltinTypeError Error = ASTContext::GE_None; 6566 QualType BuiltinType = Context.GetBuiltinType(AbsType, Error); 6567 if (Error != ASTContext::GE_None) 6568 return QualType(); 6569 6570 const FunctionProtoType *FT = BuiltinType->getAs<FunctionProtoType>(); 6571 if (!FT) 6572 return QualType(); 6573 6574 if (FT->getNumParams() != 1) 6575 return QualType(); 6576 6577 return FT->getParamType(0); 6578 } 6579 6580 // Returns the best absolute value function, or zero, based on type and 6581 // current absolute value function. 6582 static unsigned getBestAbsFunction(ASTContext &Context, QualType ArgType, 6583 unsigned AbsFunctionKind) { 6584 unsigned BestKind = 0; 6585 uint64_t ArgSize = Context.getTypeSize(ArgType); 6586 for (unsigned Kind = AbsFunctionKind; Kind != 0; 6587 Kind = getLargerAbsoluteValueFunction(Kind)) { 6588 QualType ParamType = getAbsoluteValueArgumentType(Context, Kind); 6589 if (Context.getTypeSize(ParamType) >= ArgSize) { 6590 if (BestKind == 0) 6591 BestKind = Kind; 6592 else if (Context.hasSameType(ParamType, ArgType)) { 6593 BestKind = Kind; 6594 break; 6595 } 6596 } 6597 } 6598 return BestKind; 6599 } 6600 6601 enum AbsoluteValueKind { 6602 AVK_Integer, 6603 AVK_Floating, 6604 AVK_Complex 6605 }; 6606 6607 static AbsoluteValueKind getAbsoluteValueKind(QualType T) { 6608 if (T->isIntegralOrEnumerationType()) 6609 return AVK_Integer; 6610 if (T->isRealFloatingType()) 6611 return AVK_Floating; 6612 if (T->isAnyComplexType()) 6613 return AVK_Complex; 6614 6615 llvm_unreachable("Type not integer, floating, or complex"); 6616 } 6617 6618 // Changes the absolute value function to a different type. Preserves whether 6619 // the function is a builtin. 6620 static unsigned changeAbsFunction(unsigned AbsKind, 6621 AbsoluteValueKind ValueKind) { 6622 switch (ValueKind) { 6623 case AVK_Integer: 6624 switch (AbsKind) { 6625 default: 6626 return 0; 6627 case Builtin::BI__builtin_fabsf: 6628 case Builtin::BI__builtin_fabs: 6629 case Builtin::BI__builtin_fabsl: 6630 case Builtin::BI__builtin_cabsf: 6631 case Builtin::BI__builtin_cabs: 6632 case Builtin::BI__builtin_cabsl: 6633 return Builtin::BI__builtin_abs; 6634 case Builtin::BIfabsf: 6635 case Builtin::BIfabs: 6636 case Builtin::BIfabsl: 6637 case Builtin::BIcabsf: 6638 case Builtin::BIcabs: 6639 case Builtin::BIcabsl: 6640 return Builtin::BIabs; 6641 } 6642 case AVK_Floating: 6643 switch (AbsKind) { 6644 default: 6645 return 0; 6646 case Builtin::BI__builtin_abs: 6647 case Builtin::BI__builtin_labs: 6648 case Builtin::BI__builtin_llabs: 6649 case Builtin::BI__builtin_cabsf: 6650 case Builtin::BI__builtin_cabs: 6651 case Builtin::BI__builtin_cabsl: 6652 return Builtin::BI__builtin_fabsf; 6653 case Builtin::BIabs: 6654 case Builtin::BIlabs: 6655 case Builtin::BIllabs: 6656 case Builtin::BIcabsf: 6657 case Builtin::BIcabs: 6658 case Builtin::BIcabsl: 6659 return Builtin::BIfabsf; 6660 } 6661 case AVK_Complex: 6662 switch (AbsKind) { 6663 default: 6664 return 0; 6665 case Builtin::BI__builtin_abs: 6666 case Builtin::BI__builtin_labs: 6667 case Builtin::BI__builtin_llabs: 6668 case Builtin::BI__builtin_fabsf: 6669 case Builtin::BI__builtin_fabs: 6670 case Builtin::BI__builtin_fabsl: 6671 return Builtin::BI__builtin_cabsf; 6672 case Builtin::BIabs: 6673 case Builtin::BIlabs: 6674 case Builtin::BIllabs: 6675 case Builtin::BIfabsf: 6676 case Builtin::BIfabs: 6677 case Builtin::BIfabsl: 6678 return Builtin::BIcabsf; 6679 } 6680 } 6681 llvm_unreachable("Unable to convert function"); 6682 } 6683 6684 static unsigned getAbsoluteValueFunctionKind(const FunctionDecl *FDecl) { 6685 const IdentifierInfo *FnInfo = FDecl->getIdentifier(); 6686 if (!FnInfo) 6687 return 0; 6688 6689 switch (FDecl->getBuiltinID()) { 6690 default: 6691 return 0; 6692 case Builtin::BI__builtin_abs: 6693 case Builtin::BI__builtin_fabs: 6694 case Builtin::BI__builtin_fabsf: 6695 case Builtin::BI__builtin_fabsl: 6696 case Builtin::BI__builtin_labs: 6697 case Builtin::BI__builtin_llabs: 6698 case Builtin::BI__builtin_cabs: 6699 case Builtin::BI__builtin_cabsf: 6700 case Builtin::BI__builtin_cabsl: 6701 case Builtin::BIabs: 6702 case Builtin::BIlabs: 6703 case Builtin::BIllabs: 6704 case Builtin::BIfabs: 6705 case Builtin::BIfabsf: 6706 case Builtin::BIfabsl: 6707 case Builtin::BIcabs: 6708 case Builtin::BIcabsf: 6709 case Builtin::BIcabsl: 6710 return FDecl->getBuiltinID(); 6711 } 6712 llvm_unreachable("Unknown Builtin type"); 6713 } 6714 6715 // If the replacement is valid, emit a note with replacement function. 6716 // Additionally, suggest including the proper header if not already included. 6717 static void emitReplacement(Sema &S, SourceLocation Loc, SourceRange Range, 6718 unsigned AbsKind, QualType ArgType) { 6719 bool EmitHeaderHint = true; 6720 const char *HeaderName = nullptr; 6721 const char *FunctionName = nullptr; 6722 if (S.getLangOpts().CPlusPlus && !ArgType->isAnyComplexType()) { 6723 FunctionName = "std::abs"; 6724 if (ArgType->isIntegralOrEnumerationType()) { 6725 HeaderName = "cstdlib"; 6726 } else if (ArgType->isRealFloatingType()) { 6727 HeaderName = "cmath"; 6728 } else { 6729 llvm_unreachable("Invalid Type"); 6730 } 6731 6732 // Lookup all std::abs 6733 if (NamespaceDecl *Std = S.getStdNamespace()) { 6734 LookupResult R(S, &S.Context.Idents.get("abs"), Loc, Sema::LookupAnyName); 6735 R.suppressDiagnostics(); 6736 S.LookupQualifiedName(R, Std); 6737 6738 for (const auto *I : R) { 6739 const FunctionDecl *FDecl = nullptr; 6740 if (const UsingShadowDecl *UsingD = dyn_cast<UsingShadowDecl>(I)) { 6741 FDecl = dyn_cast<FunctionDecl>(UsingD->getTargetDecl()); 6742 } else { 6743 FDecl = dyn_cast<FunctionDecl>(I); 6744 } 6745 if (!FDecl) 6746 continue; 6747 6748 // Found std::abs(), check that they are the right ones. 6749 if (FDecl->getNumParams() != 1) 6750 continue; 6751 6752 // Check that the parameter type can handle the argument. 6753 QualType ParamType = FDecl->getParamDecl(0)->getType(); 6754 if (getAbsoluteValueKind(ArgType) == getAbsoluteValueKind(ParamType) && 6755 S.Context.getTypeSize(ArgType) <= 6756 S.Context.getTypeSize(ParamType)) { 6757 // Found a function, don't need the header hint. 6758 EmitHeaderHint = false; 6759 break; 6760 } 6761 } 6762 } 6763 } else { 6764 FunctionName = S.Context.BuiltinInfo.getName(AbsKind); 6765 HeaderName = S.Context.BuiltinInfo.getHeaderName(AbsKind); 6766 6767 if (HeaderName) { 6768 DeclarationName DN(&S.Context.Idents.get(FunctionName)); 6769 LookupResult R(S, DN, Loc, Sema::LookupAnyName); 6770 R.suppressDiagnostics(); 6771 S.LookupName(R, S.getCurScope()); 6772 6773 if (R.isSingleResult()) { 6774 FunctionDecl *FD = dyn_cast<FunctionDecl>(R.getFoundDecl()); 6775 if (FD && FD->getBuiltinID() == AbsKind) { 6776 EmitHeaderHint = false; 6777 } else { 6778 return; 6779 } 6780 } else if (!R.empty()) { 6781 return; 6782 } 6783 } 6784 } 6785 6786 S.Diag(Loc, diag::note_replace_abs_function) 6787 << FunctionName << FixItHint::CreateReplacement(Range, FunctionName); 6788 6789 if (!HeaderName) 6790 return; 6791 6792 if (!EmitHeaderHint) 6793 return; 6794 6795 S.Diag(Loc, diag::note_include_header_or_declare) << HeaderName 6796 << FunctionName; 6797 } 6798 6799 template <std::size_t StrLen> 6800 static bool IsStdFunction(const FunctionDecl *FDecl, 6801 const char (&Str)[StrLen]) { 6802 if (!FDecl) 6803 return false; 6804 if (!FDecl->getIdentifier() || !FDecl->getIdentifier()->isStr(Str)) 6805 return false; 6806 if (!FDecl->isInStdNamespace()) 6807 return false; 6808 6809 return true; 6810 } 6811 6812 // Warn when using the wrong abs() function. 6813 void Sema::CheckAbsoluteValueFunction(const CallExpr *Call, 6814 const FunctionDecl *FDecl) { 6815 if (Call->getNumArgs() != 1) 6816 return; 6817 6818 unsigned AbsKind = getAbsoluteValueFunctionKind(FDecl); 6819 bool IsStdAbs = IsStdFunction(FDecl, "abs"); 6820 if (AbsKind == 0 && !IsStdAbs) 6821 return; 6822 6823 QualType ArgType = Call->getArg(0)->IgnoreParenImpCasts()->getType(); 6824 QualType ParamType = Call->getArg(0)->getType(); 6825 6826 // Unsigned types cannot be negative. Suggest removing the absolute value 6827 // function call. 6828 if (ArgType->isUnsignedIntegerType()) { 6829 const char *FunctionName = 6830 IsStdAbs ? "std::abs" : Context.BuiltinInfo.getName(AbsKind); 6831 Diag(Call->getExprLoc(), diag::warn_unsigned_abs) << ArgType << ParamType; 6832 Diag(Call->getExprLoc(), diag::note_remove_abs) 6833 << FunctionName 6834 << FixItHint::CreateRemoval(Call->getCallee()->getSourceRange()); 6835 return; 6836 } 6837 6838 // Taking the absolute value of a pointer is very suspicious, they probably 6839 // wanted to index into an array, dereference a pointer, call a function, etc. 6840 if (ArgType->isPointerType() || ArgType->canDecayToPointerType()) { 6841 unsigned DiagType = 0; 6842 if (ArgType->isFunctionType()) 6843 DiagType = 1; 6844 else if (ArgType->isArrayType()) 6845 DiagType = 2; 6846 6847 Diag(Call->getExprLoc(), diag::warn_pointer_abs) << DiagType << ArgType; 6848 return; 6849 } 6850 6851 // std::abs has overloads which prevent most of the absolute value problems 6852 // from occurring. 6853 if (IsStdAbs) 6854 return; 6855 6856 AbsoluteValueKind ArgValueKind = getAbsoluteValueKind(ArgType); 6857 AbsoluteValueKind ParamValueKind = getAbsoluteValueKind(ParamType); 6858 6859 // The argument and parameter are the same kind. Check if they are the right 6860 // size. 6861 if (ArgValueKind == ParamValueKind) { 6862 if (Context.getTypeSize(ArgType) <= Context.getTypeSize(ParamType)) 6863 return; 6864 6865 unsigned NewAbsKind = getBestAbsFunction(Context, ArgType, AbsKind); 6866 Diag(Call->getExprLoc(), diag::warn_abs_too_small) 6867 << FDecl << ArgType << ParamType; 6868 6869 if (NewAbsKind == 0) 6870 return; 6871 6872 emitReplacement(*this, Call->getExprLoc(), 6873 Call->getCallee()->getSourceRange(), NewAbsKind, ArgType); 6874 return; 6875 } 6876 6877 // ArgValueKind != ParamValueKind 6878 // The wrong type of absolute value function was used. Attempt to find the 6879 // proper one. 6880 unsigned NewAbsKind = changeAbsFunction(AbsKind, ArgValueKind); 6881 NewAbsKind = getBestAbsFunction(Context, ArgType, NewAbsKind); 6882 if (NewAbsKind == 0) 6883 return; 6884 6885 Diag(Call->getExprLoc(), diag::warn_wrong_absolute_value_type) 6886 << FDecl << ParamValueKind << ArgValueKind; 6887 6888 emitReplacement(*this, Call->getExprLoc(), 6889 Call->getCallee()->getSourceRange(), NewAbsKind, ArgType); 6890 } 6891 6892 //===--- CHECK: Warn on use of std::max and unsigned zero. r---------------===// 6893 void Sema::CheckMaxUnsignedZero(const CallExpr *Call, 6894 const FunctionDecl *FDecl) { 6895 if (!Call || !FDecl) return; 6896 6897 // Ignore template specializations and macros. 6898 if (inTemplateInstantiation()) return; 6899 if (Call->getExprLoc().isMacroID()) return; 6900 6901 // Only care about the one template argument, two function parameter std::max 6902 if (Call->getNumArgs() != 2) return; 6903 if (!IsStdFunction(FDecl, "max")) return; 6904 const auto * ArgList = FDecl->getTemplateSpecializationArgs(); 6905 if (!ArgList) return; 6906 if (ArgList->size() != 1) return; 6907 6908 // Check that template type argument is unsigned integer. 6909 const auto& TA = ArgList->get(0); 6910 if (TA.getKind() != TemplateArgument::Type) return; 6911 QualType ArgType = TA.getAsType(); 6912 if (!ArgType->isUnsignedIntegerType()) return; 6913 6914 // See if either argument is a literal zero. 6915 auto IsLiteralZeroArg = [](const Expr* E) -> bool { 6916 const auto *MTE = dyn_cast<MaterializeTemporaryExpr>(E); 6917 if (!MTE) return false; 6918 const auto *Num = dyn_cast<IntegerLiteral>(MTE->GetTemporaryExpr()); 6919 if (!Num) return false; 6920 if (Num->getValue() != 0) return false; 6921 return true; 6922 }; 6923 6924 const Expr *FirstArg = Call->getArg(0); 6925 const Expr *SecondArg = Call->getArg(1); 6926 const bool IsFirstArgZero = IsLiteralZeroArg(FirstArg); 6927 const bool IsSecondArgZero = IsLiteralZeroArg(SecondArg); 6928 6929 // Only warn when exactly one argument is zero. 6930 if (IsFirstArgZero == IsSecondArgZero) return; 6931 6932 SourceRange FirstRange = FirstArg->getSourceRange(); 6933 SourceRange SecondRange = SecondArg->getSourceRange(); 6934 6935 SourceRange ZeroRange = IsFirstArgZero ? FirstRange : SecondRange; 6936 6937 Diag(Call->getExprLoc(), diag::warn_max_unsigned_zero) 6938 << IsFirstArgZero << Call->getCallee()->getSourceRange() << ZeroRange; 6939 6940 // Deduce what parts to remove so that "std::max(0u, foo)" becomes "(foo)". 6941 SourceRange RemovalRange; 6942 if (IsFirstArgZero) { 6943 RemovalRange = SourceRange(FirstRange.getBegin(), 6944 SecondRange.getBegin().getLocWithOffset(-1)); 6945 } else { 6946 RemovalRange = SourceRange(getLocForEndOfToken(FirstRange.getEnd()), 6947 SecondRange.getEnd()); 6948 } 6949 6950 Diag(Call->getExprLoc(), diag::note_remove_max_call) 6951 << FixItHint::CreateRemoval(Call->getCallee()->getSourceRange()) 6952 << FixItHint::CreateRemoval(RemovalRange); 6953 } 6954 6955 //===--- CHECK: Standard memory functions ---------------------------------===// 6956 6957 /// \brief Takes the expression passed to the size_t parameter of functions 6958 /// such as memcmp, strncat, etc and warns if it's a comparison. 6959 /// 6960 /// This is to catch typos like `if (memcmp(&a, &b, sizeof(a) > 0))`. 6961 static bool CheckMemorySizeofForComparison(Sema &S, const Expr *E, 6962 IdentifierInfo *FnName, 6963 SourceLocation FnLoc, 6964 SourceLocation RParenLoc) { 6965 const BinaryOperator *Size = dyn_cast<BinaryOperator>(E); 6966 if (!Size) 6967 return false; 6968 6969 // if E is binop and op is >, <, >=, <=, ==, &&, ||: 6970 if (!Size->isComparisonOp() && !Size->isEqualityOp() && !Size->isLogicalOp()) 6971 return false; 6972 6973 SourceRange SizeRange = Size->getSourceRange(); 6974 S.Diag(Size->getOperatorLoc(), diag::warn_memsize_comparison) 6975 << SizeRange << FnName; 6976 S.Diag(FnLoc, diag::note_memsize_comparison_paren) 6977 << FnName << FixItHint::CreateInsertion( 6978 S.getLocForEndOfToken(Size->getLHS()->getLocEnd()), ")") 6979 << FixItHint::CreateRemoval(RParenLoc); 6980 S.Diag(SizeRange.getBegin(), diag::note_memsize_comparison_cast_silence) 6981 << FixItHint::CreateInsertion(SizeRange.getBegin(), "(size_t)(") 6982 << FixItHint::CreateInsertion(S.getLocForEndOfToken(SizeRange.getEnd()), 6983 ")"); 6984 6985 return true; 6986 } 6987 6988 /// \brief Determine whether the given type is or contains a dynamic class type 6989 /// (e.g., whether it has a vtable). 6990 static const CXXRecordDecl *getContainedDynamicClass(QualType T, 6991 bool &IsContained) { 6992 // Look through array types while ignoring qualifiers. 6993 const Type *Ty = T->getBaseElementTypeUnsafe(); 6994 IsContained = false; 6995 6996 const CXXRecordDecl *RD = Ty->getAsCXXRecordDecl(); 6997 RD = RD ? RD->getDefinition() : nullptr; 6998 if (!RD || RD->isInvalidDecl()) 6999 return nullptr; 7000 7001 if (RD->isDynamicClass()) 7002 return RD; 7003 7004 // Check all the fields. If any bases were dynamic, the class is dynamic. 7005 // It's impossible for a class to transitively contain itself by value, so 7006 // infinite recursion is impossible. 7007 for (auto *FD : RD->fields()) { 7008 bool SubContained; 7009 if (const CXXRecordDecl *ContainedRD = 7010 getContainedDynamicClass(FD->getType(), SubContained)) { 7011 IsContained = true; 7012 return ContainedRD; 7013 } 7014 } 7015 7016 return nullptr; 7017 } 7018 7019 /// \brief If E is a sizeof expression, returns its argument expression, 7020 /// otherwise returns NULL. 7021 static const Expr *getSizeOfExprArg(const Expr *E) { 7022 if (const UnaryExprOrTypeTraitExpr *SizeOf = 7023 dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 7024 if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType()) 7025 return SizeOf->getArgumentExpr()->IgnoreParenImpCasts(); 7026 7027 return nullptr; 7028 } 7029 7030 /// \brief If E is a sizeof expression, returns its argument type. 7031 static QualType getSizeOfArgType(const Expr *E) { 7032 if (const UnaryExprOrTypeTraitExpr *SizeOf = 7033 dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 7034 if (SizeOf->getKind() == clang::UETT_SizeOf) 7035 return SizeOf->getTypeOfArgument(); 7036 7037 return QualType(); 7038 } 7039 7040 /// \brief Check for dangerous or invalid arguments to memset(). 7041 /// 7042 /// This issues warnings on known problematic, dangerous or unspecified 7043 /// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp' 7044 /// function calls. 7045 /// 7046 /// \param Call The call expression to diagnose. 7047 void Sema::CheckMemaccessArguments(const CallExpr *Call, 7048 unsigned BId, 7049 IdentifierInfo *FnName) { 7050 assert(BId != 0); 7051 7052 // It is possible to have a non-standard definition of memset. Validate 7053 // we have enough arguments, and if not, abort further checking. 7054 unsigned ExpectedNumArgs = 7055 (BId == Builtin::BIstrndup || BId == Builtin::BIbzero ? 2 : 3); 7056 if (Call->getNumArgs() < ExpectedNumArgs) 7057 return; 7058 7059 unsigned LastArg = (BId == Builtin::BImemset || BId == Builtin::BIbzero || 7060 BId == Builtin::BIstrndup ? 1 : 2); 7061 unsigned LenArg = 7062 (BId == Builtin::BIbzero || BId == Builtin::BIstrndup ? 1 : 2); 7063 const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts(); 7064 7065 if (CheckMemorySizeofForComparison(*this, LenExpr, FnName, 7066 Call->getLocStart(), Call->getRParenLoc())) 7067 return; 7068 7069 // We have special checking when the length is a sizeof expression. 7070 QualType SizeOfArgTy = getSizeOfArgType(LenExpr); 7071 const Expr *SizeOfArg = getSizeOfExprArg(LenExpr); 7072 llvm::FoldingSetNodeID SizeOfArgID; 7073 7074 // Although widely used, 'bzero' is not a standard function. Be more strict 7075 // with the argument types before allowing diagnostics and only allow the 7076 // form bzero(ptr, sizeof(...)). 7077 QualType FirstArgTy = Call->getArg(0)->IgnoreParenImpCasts()->getType(); 7078 if (BId == Builtin::BIbzero && !FirstArgTy->getAs<PointerType>()) 7079 return; 7080 7081 for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 7082 const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 7083 SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange(); 7084 7085 QualType DestTy = Dest->getType(); 7086 QualType PointeeTy; 7087 if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 7088 PointeeTy = DestPtrTy->getPointeeType(); 7089 7090 // Never warn about void type pointers. This can be used to suppress 7091 // false positives. 7092 if (PointeeTy->isVoidType()) 7093 continue; 7094 7095 // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by 7096 // actually comparing the expressions for equality. Because computing the 7097 // expression IDs can be expensive, we only do this if the diagnostic is 7098 // enabled. 7099 if (SizeOfArg && 7100 !Diags.isIgnored(diag::warn_sizeof_pointer_expr_memaccess, 7101 SizeOfArg->getExprLoc())) { 7102 // We only compute IDs for expressions if the warning is enabled, and 7103 // cache the sizeof arg's ID. 7104 if (SizeOfArgID == llvm::FoldingSetNodeID()) 7105 SizeOfArg->Profile(SizeOfArgID, Context, true); 7106 llvm::FoldingSetNodeID DestID; 7107 Dest->Profile(DestID, Context, true); 7108 if (DestID == SizeOfArgID) { 7109 // TODO: For strncpy() and friends, this could suggest sizeof(dst) 7110 // over sizeof(src) as well. 7111 unsigned ActionIdx = 0; // Default is to suggest dereferencing. 7112 StringRef ReadableName = FnName->getName(); 7113 7114 if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest)) 7115 if (UnaryOp->getOpcode() == UO_AddrOf) 7116 ActionIdx = 1; // If its an address-of operator, just remove it. 7117 if (!PointeeTy->isIncompleteType() && 7118 (Context.getTypeSize(PointeeTy) == Context.getCharWidth())) 7119 ActionIdx = 2; // If the pointee's size is sizeof(char), 7120 // suggest an explicit length. 7121 7122 // If the function is defined as a builtin macro, do not show macro 7123 // expansion. 7124 SourceLocation SL = SizeOfArg->getExprLoc(); 7125 SourceRange DSR = Dest->getSourceRange(); 7126 SourceRange SSR = SizeOfArg->getSourceRange(); 7127 SourceManager &SM = getSourceManager(); 7128 7129 if (SM.isMacroArgExpansion(SL)) { 7130 ReadableName = Lexer::getImmediateMacroName(SL, SM, LangOpts); 7131 SL = SM.getSpellingLoc(SL); 7132 DSR = SourceRange(SM.getSpellingLoc(DSR.getBegin()), 7133 SM.getSpellingLoc(DSR.getEnd())); 7134 SSR = SourceRange(SM.getSpellingLoc(SSR.getBegin()), 7135 SM.getSpellingLoc(SSR.getEnd())); 7136 } 7137 7138 DiagRuntimeBehavior(SL, SizeOfArg, 7139 PDiag(diag::warn_sizeof_pointer_expr_memaccess) 7140 << ReadableName 7141 << PointeeTy 7142 << DestTy 7143 << DSR 7144 << SSR); 7145 DiagRuntimeBehavior(SL, SizeOfArg, 7146 PDiag(diag::warn_sizeof_pointer_expr_memaccess_note) 7147 << ActionIdx 7148 << SSR); 7149 7150 break; 7151 } 7152 } 7153 7154 // Also check for cases where the sizeof argument is the exact same 7155 // type as the memory argument, and where it points to a user-defined 7156 // record type. 7157 if (SizeOfArgTy != QualType()) { 7158 if (PointeeTy->isRecordType() && 7159 Context.typesAreCompatible(SizeOfArgTy, DestTy)) { 7160 DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest, 7161 PDiag(diag::warn_sizeof_pointer_type_memaccess) 7162 << FnName << SizeOfArgTy << ArgIdx 7163 << PointeeTy << Dest->getSourceRange() 7164 << LenExpr->getSourceRange()); 7165 break; 7166 } 7167 } 7168 } else if (DestTy->isArrayType()) { 7169 PointeeTy = DestTy; 7170 } 7171 7172 if (PointeeTy == QualType()) 7173 continue; 7174 7175 // Always complain about dynamic classes. 7176 bool IsContained; 7177 if (const CXXRecordDecl *ContainedRD = 7178 getContainedDynamicClass(PointeeTy, IsContained)) { 7179 7180 unsigned OperationType = 0; 7181 // "overwritten" if we're warning about the destination for any call 7182 // but memcmp; otherwise a verb appropriate to the call. 7183 if (ArgIdx != 0 || BId == Builtin::BImemcmp) { 7184 if (BId == Builtin::BImemcpy) 7185 OperationType = 1; 7186 else if(BId == Builtin::BImemmove) 7187 OperationType = 2; 7188 else if (BId == Builtin::BImemcmp) 7189 OperationType = 3; 7190 } 7191 7192 DiagRuntimeBehavior( 7193 Dest->getExprLoc(), Dest, 7194 PDiag(diag::warn_dyn_class_memaccess) 7195 << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx) 7196 << FnName << IsContained << ContainedRD << OperationType 7197 << Call->getCallee()->getSourceRange()); 7198 } else if (PointeeTy.hasNonTrivialObjCLifetime() && 7199 BId != Builtin::BImemset) 7200 DiagRuntimeBehavior( 7201 Dest->getExprLoc(), Dest, 7202 PDiag(diag::warn_arc_object_memaccess) 7203 << ArgIdx << FnName << PointeeTy 7204 << Call->getCallee()->getSourceRange()); 7205 else 7206 continue; 7207 7208 DiagRuntimeBehavior( 7209 Dest->getExprLoc(), Dest, 7210 PDiag(diag::note_bad_memaccess_silence) 7211 << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 7212 break; 7213 } 7214 } 7215 7216 // A little helper routine: ignore addition and subtraction of integer literals. 7217 // This intentionally does not ignore all integer constant expressions because 7218 // we don't want to remove sizeof(). 7219 static const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) { 7220 Ex = Ex->IgnoreParenCasts(); 7221 7222 for (;;) { 7223 const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex); 7224 if (!BO || !BO->isAdditiveOp()) 7225 break; 7226 7227 const Expr *RHS = BO->getRHS()->IgnoreParenCasts(); 7228 const Expr *LHS = BO->getLHS()->IgnoreParenCasts(); 7229 7230 if (isa<IntegerLiteral>(RHS)) 7231 Ex = LHS; 7232 else if (isa<IntegerLiteral>(LHS)) 7233 Ex = RHS; 7234 else 7235 break; 7236 } 7237 7238 return Ex; 7239 } 7240 7241 static bool isConstantSizeArrayWithMoreThanOneElement(QualType Ty, 7242 ASTContext &Context) { 7243 // Only handle constant-sized or VLAs, but not flexible members. 7244 if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(Ty)) { 7245 // Only issue the FIXIT for arrays of size > 1. 7246 if (CAT->getSize().getSExtValue() <= 1) 7247 return false; 7248 } else if (!Ty->isVariableArrayType()) { 7249 return false; 7250 } 7251 return true; 7252 } 7253 7254 // Warn if the user has made the 'size' argument to strlcpy or strlcat 7255 // be the size of the source, instead of the destination. 7256 void Sema::CheckStrlcpycatArguments(const CallExpr *Call, 7257 IdentifierInfo *FnName) { 7258 7259 // Don't crash if the user has the wrong number of arguments 7260 unsigned NumArgs = Call->getNumArgs(); 7261 if ((NumArgs != 3) && (NumArgs != 4)) 7262 return; 7263 7264 const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context); 7265 const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context); 7266 const Expr *CompareWithSrc = nullptr; 7267 7268 if (CheckMemorySizeofForComparison(*this, SizeArg, FnName, 7269 Call->getLocStart(), Call->getRParenLoc())) 7270 return; 7271 7272 // Look for 'strlcpy(dst, x, sizeof(x))' 7273 if (const Expr *Ex = getSizeOfExprArg(SizeArg)) 7274 CompareWithSrc = Ex; 7275 else { 7276 // Look for 'strlcpy(dst, x, strlen(x))' 7277 if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) { 7278 if (SizeCall->getBuiltinCallee() == Builtin::BIstrlen && 7279 SizeCall->getNumArgs() == 1) 7280 CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context); 7281 } 7282 } 7283 7284 if (!CompareWithSrc) 7285 return; 7286 7287 // Determine if the argument to sizeof/strlen is equal to the source 7288 // argument. In principle there's all kinds of things you could do 7289 // here, for instance creating an == expression and evaluating it with 7290 // EvaluateAsBooleanCondition, but this uses a more direct technique: 7291 const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg); 7292 if (!SrcArgDRE) 7293 return; 7294 7295 const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc); 7296 if (!CompareWithSrcDRE || 7297 SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl()) 7298 return; 7299 7300 const Expr *OriginalSizeArg = Call->getArg(2); 7301 Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size) 7302 << OriginalSizeArg->getSourceRange() << FnName; 7303 7304 // Output a FIXIT hint if the destination is an array (rather than a 7305 // pointer to an array). This could be enhanced to handle some 7306 // pointers if we know the actual size, like if DstArg is 'array+2' 7307 // we could say 'sizeof(array)-2'. 7308 const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts(); 7309 if (!isConstantSizeArrayWithMoreThanOneElement(DstArg->getType(), Context)) 7310 return; 7311 7312 SmallString<128> sizeString; 7313 llvm::raw_svector_ostream OS(sizeString); 7314 OS << "sizeof("; 7315 DstArg->printPretty(OS, nullptr, getPrintingPolicy()); 7316 OS << ")"; 7317 7318 Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size) 7319 << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(), 7320 OS.str()); 7321 } 7322 7323 /// Check if two expressions refer to the same declaration. 7324 static bool referToTheSameDecl(const Expr *E1, const Expr *E2) { 7325 if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1)) 7326 if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2)) 7327 return D1->getDecl() == D2->getDecl(); 7328 return false; 7329 } 7330 7331 static const Expr *getStrlenExprArg(const Expr *E) { 7332 if (const CallExpr *CE = dyn_cast<CallExpr>(E)) { 7333 const FunctionDecl *FD = CE->getDirectCallee(); 7334 if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen) 7335 return nullptr; 7336 return CE->getArg(0)->IgnoreParenCasts(); 7337 } 7338 return nullptr; 7339 } 7340 7341 // Warn on anti-patterns as the 'size' argument to strncat. 7342 // The correct size argument should look like following: 7343 // strncat(dst, src, sizeof(dst) - strlen(dest) - 1); 7344 void Sema::CheckStrncatArguments(const CallExpr *CE, 7345 IdentifierInfo *FnName) { 7346 // Don't crash if the user has the wrong number of arguments. 7347 if (CE->getNumArgs() < 3) 7348 return; 7349 const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts(); 7350 const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts(); 7351 const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts(); 7352 7353 if (CheckMemorySizeofForComparison(*this, LenArg, FnName, CE->getLocStart(), 7354 CE->getRParenLoc())) 7355 return; 7356 7357 // Identify common expressions, which are wrongly used as the size argument 7358 // to strncat and may lead to buffer overflows. 7359 unsigned PatternType = 0; 7360 if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) { 7361 // - sizeof(dst) 7362 if (referToTheSameDecl(SizeOfArg, DstArg)) 7363 PatternType = 1; 7364 // - sizeof(src) 7365 else if (referToTheSameDecl(SizeOfArg, SrcArg)) 7366 PatternType = 2; 7367 } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) { 7368 if (BE->getOpcode() == BO_Sub) { 7369 const Expr *L = BE->getLHS()->IgnoreParenCasts(); 7370 const Expr *R = BE->getRHS()->IgnoreParenCasts(); 7371 // - sizeof(dst) - strlen(dst) 7372 if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) && 7373 referToTheSameDecl(DstArg, getStrlenExprArg(R))) 7374 PatternType = 1; 7375 // - sizeof(src) - (anything) 7376 else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L))) 7377 PatternType = 2; 7378 } 7379 } 7380 7381 if (PatternType == 0) 7382 return; 7383 7384 // Generate the diagnostic. 7385 SourceLocation SL = LenArg->getLocStart(); 7386 SourceRange SR = LenArg->getSourceRange(); 7387 SourceManager &SM = getSourceManager(); 7388 7389 // If the function is defined as a builtin macro, do not show macro expansion. 7390 if (SM.isMacroArgExpansion(SL)) { 7391 SL = SM.getSpellingLoc(SL); 7392 SR = SourceRange(SM.getSpellingLoc(SR.getBegin()), 7393 SM.getSpellingLoc(SR.getEnd())); 7394 } 7395 7396 // Check if the destination is an array (rather than a pointer to an array). 7397 QualType DstTy = DstArg->getType(); 7398 bool isKnownSizeArray = isConstantSizeArrayWithMoreThanOneElement(DstTy, 7399 Context); 7400 if (!isKnownSizeArray) { 7401 if (PatternType == 1) 7402 Diag(SL, diag::warn_strncat_wrong_size) << SR; 7403 else 7404 Diag(SL, diag::warn_strncat_src_size) << SR; 7405 return; 7406 } 7407 7408 if (PatternType == 1) 7409 Diag(SL, diag::warn_strncat_large_size) << SR; 7410 else 7411 Diag(SL, diag::warn_strncat_src_size) << SR; 7412 7413 SmallString<128> sizeString; 7414 llvm::raw_svector_ostream OS(sizeString); 7415 OS << "sizeof("; 7416 DstArg->printPretty(OS, nullptr, getPrintingPolicy()); 7417 OS << ") - "; 7418 OS << "strlen("; 7419 DstArg->printPretty(OS, nullptr, getPrintingPolicy()); 7420 OS << ") - 1"; 7421 7422 Diag(SL, diag::note_strncat_wrong_size) 7423 << FixItHint::CreateReplacement(SR, OS.str()); 7424 } 7425 7426 //===--- CHECK: Return Address of Stack Variable --------------------------===// 7427 7428 static const Expr *EvalVal(const Expr *E, 7429 SmallVectorImpl<const DeclRefExpr *> &refVars, 7430 const Decl *ParentDecl); 7431 static const Expr *EvalAddr(const Expr *E, 7432 SmallVectorImpl<const DeclRefExpr *> &refVars, 7433 const Decl *ParentDecl); 7434 7435 /// CheckReturnStackAddr - Check if a return statement returns the address 7436 /// of a stack variable. 7437 static void 7438 CheckReturnStackAddr(Sema &S, Expr *RetValExp, QualType lhsType, 7439 SourceLocation ReturnLoc) { 7440 7441 const Expr *stackE = nullptr; 7442 SmallVector<const DeclRefExpr *, 8> refVars; 7443 7444 // Perform checking for returned stack addresses, local blocks, 7445 // label addresses or references to temporaries. 7446 if (lhsType->isPointerType() || 7447 (!S.getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) { 7448 stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/nullptr); 7449 } else if (lhsType->isReferenceType()) { 7450 stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/nullptr); 7451 } 7452 7453 if (!stackE) 7454 return; // Nothing suspicious was found. 7455 7456 // Parameters are initialized in the calling scope, so taking the address 7457 // of a parameter reference doesn't need a warning. 7458 for (auto *DRE : refVars) 7459 if (isa<ParmVarDecl>(DRE->getDecl())) 7460 return; 7461 7462 SourceLocation diagLoc; 7463 SourceRange diagRange; 7464 if (refVars.empty()) { 7465 diagLoc = stackE->getLocStart(); 7466 diagRange = stackE->getSourceRange(); 7467 } else { 7468 // We followed through a reference variable. 'stackE' contains the 7469 // problematic expression but we will warn at the return statement pointing 7470 // at the reference variable. We will later display the "trail" of 7471 // reference variables using notes. 7472 diagLoc = refVars[0]->getLocStart(); 7473 diagRange = refVars[0]->getSourceRange(); 7474 } 7475 7476 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { 7477 // address of local var 7478 S.Diag(diagLoc, diag::warn_ret_stack_addr_ref) << lhsType->isReferenceType() 7479 << DR->getDecl()->getDeclName() << diagRange; 7480 } else if (isa<BlockExpr>(stackE)) { // local block. 7481 S.Diag(diagLoc, diag::err_ret_local_block) << diagRange; 7482 } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 7483 S.Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 7484 } else { // local temporary. 7485 // If there is an LValue->RValue conversion, then the value of the 7486 // reference type is used, not the reference. 7487 if (auto *ICE = dyn_cast<ImplicitCastExpr>(RetValExp)) { 7488 if (ICE->getCastKind() == CK_LValueToRValue) { 7489 return; 7490 } 7491 } 7492 S.Diag(diagLoc, diag::warn_ret_local_temp_addr_ref) 7493 << lhsType->isReferenceType() << diagRange; 7494 } 7495 7496 // Display the "trail" of reference variables that we followed until we 7497 // found the problematic expression using notes. 7498 for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 7499 const VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 7500 // If this var binds to another reference var, show the range of the next 7501 // var, otherwise the var binds to the problematic expression, in which case 7502 // show the range of the expression. 7503 SourceRange range = (i < e - 1) ? refVars[i + 1]->getSourceRange() 7504 : stackE->getSourceRange(); 7505 S.Diag(VD->getLocation(), diag::note_ref_var_local_bind) 7506 << VD->getDeclName() << range; 7507 } 7508 } 7509 7510 /// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 7511 /// check if the expression in a return statement evaluates to an address 7512 /// to a location on the stack, a local block, an address of a label, or a 7513 /// reference to local temporary. The recursion is used to traverse the 7514 /// AST of the return expression, with recursion backtracking when we 7515 /// encounter a subexpression that (1) clearly does not lead to one of the 7516 /// above problematic expressions (2) is something we cannot determine leads to 7517 /// a problematic expression based on such local checking. 7518 /// 7519 /// Both EvalAddr and EvalVal follow through reference variables to evaluate 7520 /// the expression that they point to. Such variables are added to the 7521 /// 'refVars' vector so that we know what the reference variable "trail" was. 7522 /// 7523 /// EvalAddr processes expressions that are pointers that are used as 7524 /// references (and not L-values). EvalVal handles all other values. 7525 /// At the base case of the recursion is a check for the above problematic 7526 /// expressions. 7527 /// 7528 /// This implementation handles: 7529 /// 7530 /// * pointer-to-pointer casts 7531 /// * implicit conversions from array references to pointers 7532 /// * taking the address of fields 7533 /// * arbitrary interplay between "&" and "*" operators 7534 /// * pointer arithmetic from an address of a stack variable 7535 /// * taking the address of an array element where the array is on the stack 7536 static const Expr *EvalAddr(const Expr *E, 7537 SmallVectorImpl<const DeclRefExpr *> &refVars, 7538 const Decl *ParentDecl) { 7539 if (E->isTypeDependent()) 7540 return nullptr; 7541 7542 // We should only be called for evaluating pointer expressions. 7543 assert((E->getType()->isAnyPointerType() || 7544 E->getType()->isBlockPointerType() || 7545 E->getType()->isObjCQualifiedIdType()) && 7546 "EvalAddr only works on pointers"); 7547 7548 E = E->IgnoreParens(); 7549 7550 // Our "symbolic interpreter" is just a dispatch off the currently 7551 // viewed AST node. We then recursively traverse the AST by calling 7552 // EvalAddr and EvalVal appropriately. 7553 switch (E->getStmtClass()) { 7554 case Stmt::DeclRefExprClass: { 7555 const DeclRefExpr *DR = cast<DeclRefExpr>(E); 7556 7557 // If we leave the immediate function, the lifetime isn't about to end. 7558 if (DR->refersToEnclosingVariableOrCapture()) 7559 return nullptr; 7560 7561 if (const VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 7562 // If this is a reference variable, follow through to the expression that 7563 // it points to. 7564 if (V->hasLocalStorage() && 7565 V->getType()->isReferenceType() && V->hasInit()) { 7566 // Add the reference variable to the "trail". 7567 refVars.push_back(DR); 7568 return EvalAddr(V->getInit(), refVars, ParentDecl); 7569 } 7570 7571 return nullptr; 7572 } 7573 7574 case Stmt::UnaryOperatorClass: { 7575 // The only unary operator that make sense to handle here 7576 // is AddrOf. All others don't make sense as pointers. 7577 const UnaryOperator *U = cast<UnaryOperator>(E); 7578 7579 if (U->getOpcode() == UO_AddrOf) 7580 return EvalVal(U->getSubExpr(), refVars, ParentDecl); 7581 return nullptr; 7582 } 7583 7584 case Stmt::BinaryOperatorClass: { 7585 // Handle pointer arithmetic. All other binary operators are not valid 7586 // in this context. 7587 const BinaryOperator *B = cast<BinaryOperator>(E); 7588 BinaryOperatorKind op = B->getOpcode(); 7589 7590 if (op != BO_Add && op != BO_Sub) 7591 return nullptr; 7592 7593 const Expr *Base = B->getLHS(); 7594 7595 // Determine which argument is the real pointer base. It could be 7596 // the RHS argument instead of the LHS. 7597 if (!Base->getType()->isPointerType()) 7598 Base = B->getRHS(); 7599 7600 assert(Base->getType()->isPointerType()); 7601 return EvalAddr(Base, refVars, ParentDecl); 7602 } 7603 7604 // For conditional operators we need to see if either the LHS or RHS are 7605 // valid DeclRefExpr*s. If one of them is valid, we return it. 7606 case Stmt::ConditionalOperatorClass: { 7607 const ConditionalOperator *C = cast<ConditionalOperator>(E); 7608 7609 // Handle the GNU extension for missing LHS. 7610 // FIXME: That isn't a ConditionalOperator, so doesn't get here. 7611 if (const Expr *LHSExpr = C->getLHS()) { 7612 // In C++, we can have a throw-expression, which has 'void' type. 7613 if (!LHSExpr->getType()->isVoidType()) 7614 if (const Expr *LHS = EvalAddr(LHSExpr, refVars, ParentDecl)) 7615 return LHS; 7616 } 7617 7618 // In C++, we can have a throw-expression, which has 'void' type. 7619 if (C->getRHS()->getType()->isVoidType()) 7620 return nullptr; 7621 7622 return EvalAddr(C->getRHS(), refVars, ParentDecl); 7623 } 7624 7625 case Stmt::BlockExprClass: 7626 if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 7627 return E; // local block. 7628 return nullptr; 7629 7630 case Stmt::AddrLabelExprClass: 7631 return E; // address of label. 7632 7633 case Stmt::ExprWithCleanupsClass: 7634 return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars, 7635 ParentDecl); 7636 7637 // For casts, we need to handle conversions from arrays to 7638 // pointer values, and pointer-to-pointer conversions. 7639 case Stmt::ImplicitCastExprClass: 7640 case Stmt::CStyleCastExprClass: 7641 case Stmt::CXXFunctionalCastExprClass: 7642 case Stmt::ObjCBridgedCastExprClass: 7643 case Stmt::CXXStaticCastExprClass: 7644 case Stmt::CXXDynamicCastExprClass: 7645 case Stmt::CXXConstCastExprClass: 7646 case Stmt::CXXReinterpretCastExprClass: { 7647 const Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 7648 switch (cast<CastExpr>(E)->getCastKind()) { 7649 case CK_LValueToRValue: 7650 case CK_NoOp: 7651 case CK_BaseToDerived: 7652 case CK_DerivedToBase: 7653 case CK_UncheckedDerivedToBase: 7654 case CK_Dynamic: 7655 case CK_CPointerToObjCPointerCast: 7656 case CK_BlockPointerToObjCPointerCast: 7657 case CK_AnyPointerToBlockPointerCast: 7658 return EvalAddr(SubExpr, refVars, ParentDecl); 7659 7660 case CK_ArrayToPointerDecay: 7661 return EvalVal(SubExpr, refVars, ParentDecl); 7662 7663 case CK_BitCast: 7664 if (SubExpr->getType()->isAnyPointerType() || 7665 SubExpr->getType()->isBlockPointerType() || 7666 SubExpr->getType()->isObjCQualifiedIdType()) 7667 return EvalAddr(SubExpr, refVars, ParentDecl); 7668 else 7669 return nullptr; 7670 7671 default: 7672 return nullptr; 7673 } 7674 } 7675 7676 case Stmt::MaterializeTemporaryExprClass: 7677 if (const Expr *Result = 7678 EvalAddr(cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 7679 refVars, ParentDecl)) 7680 return Result; 7681 return E; 7682 7683 // Everything else: we simply don't reason about them. 7684 default: 7685 return nullptr; 7686 } 7687 } 7688 7689 /// EvalVal - This function is complements EvalAddr in the mutual recursion. 7690 /// See the comments for EvalAddr for more details. 7691 static const Expr *EvalVal(const Expr *E, 7692 SmallVectorImpl<const DeclRefExpr *> &refVars, 7693 const Decl *ParentDecl) { 7694 do { 7695 // We should only be called for evaluating non-pointer expressions, or 7696 // expressions with a pointer type that are not used as references but 7697 // instead 7698 // are l-values (e.g., DeclRefExpr with a pointer type). 7699 7700 // Our "symbolic interpreter" is just a dispatch off the currently 7701 // viewed AST node. We then recursively traverse the AST by calling 7702 // EvalAddr and EvalVal appropriately. 7703 7704 E = E->IgnoreParens(); 7705 switch (E->getStmtClass()) { 7706 case Stmt::ImplicitCastExprClass: { 7707 const ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 7708 if (IE->getValueKind() == VK_LValue) { 7709 E = IE->getSubExpr(); 7710 continue; 7711 } 7712 return nullptr; 7713 } 7714 7715 case Stmt::ExprWithCleanupsClass: 7716 return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars, 7717 ParentDecl); 7718 7719 case Stmt::DeclRefExprClass: { 7720 // When we hit a DeclRefExpr we are looking at code that refers to a 7721 // variable's name. If it's not a reference variable we check if it has 7722 // local storage within the function, and if so, return the expression. 7723 const DeclRefExpr *DR = cast<DeclRefExpr>(E); 7724 7725 // If we leave the immediate function, the lifetime isn't about to end. 7726 if (DR->refersToEnclosingVariableOrCapture()) 7727 return nullptr; 7728 7729 if (const VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) { 7730 // Check if it refers to itself, e.g. "int& i = i;". 7731 if (V == ParentDecl) 7732 return DR; 7733 7734 if (V->hasLocalStorage()) { 7735 if (!V->getType()->isReferenceType()) 7736 return DR; 7737 7738 // Reference variable, follow through to the expression that 7739 // it points to. 7740 if (V->hasInit()) { 7741 // Add the reference variable to the "trail". 7742 refVars.push_back(DR); 7743 return EvalVal(V->getInit(), refVars, V); 7744 } 7745 } 7746 } 7747 7748 return nullptr; 7749 } 7750 7751 case Stmt::UnaryOperatorClass: { 7752 // The only unary operator that make sense to handle here 7753 // is Deref. All others don't resolve to a "name." This includes 7754 // handling all sorts of rvalues passed to a unary operator. 7755 const UnaryOperator *U = cast<UnaryOperator>(E); 7756 7757 if (U->getOpcode() == UO_Deref) 7758 return EvalAddr(U->getSubExpr(), refVars, ParentDecl); 7759 7760 return nullptr; 7761 } 7762 7763 case Stmt::ArraySubscriptExprClass: { 7764 // Array subscripts are potential references to data on the stack. We 7765 // retrieve the DeclRefExpr* for the array variable if it indeed 7766 // has local storage. 7767 const auto *ASE = cast<ArraySubscriptExpr>(E); 7768 if (ASE->isTypeDependent()) 7769 return nullptr; 7770 return EvalAddr(ASE->getBase(), refVars, ParentDecl); 7771 } 7772 7773 case Stmt::OMPArraySectionExprClass: { 7774 return EvalAddr(cast<OMPArraySectionExpr>(E)->getBase(), refVars, 7775 ParentDecl); 7776 } 7777 7778 case Stmt::ConditionalOperatorClass: { 7779 // For conditional operators we need to see if either the LHS or RHS are 7780 // non-NULL Expr's. If one is non-NULL, we return it. 7781 const ConditionalOperator *C = cast<ConditionalOperator>(E); 7782 7783 // Handle the GNU extension for missing LHS. 7784 if (const Expr *LHSExpr = C->getLHS()) { 7785 // In C++, we can have a throw-expression, which has 'void' type. 7786 if (!LHSExpr->getType()->isVoidType()) 7787 if (const Expr *LHS = EvalVal(LHSExpr, refVars, ParentDecl)) 7788 return LHS; 7789 } 7790 7791 // In C++, we can have a throw-expression, which has 'void' type. 7792 if (C->getRHS()->getType()->isVoidType()) 7793 return nullptr; 7794 7795 return EvalVal(C->getRHS(), refVars, ParentDecl); 7796 } 7797 7798 // Accesses to members are potential references to data on the stack. 7799 case Stmt::MemberExprClass: { 7800 const MemberExpr *M = cast<MemberExpr>(E); 7801 7802 // Check for indirect access. We only want direct field accesses. 7803 if (M->isArrow()) 7804 return nullptr; 7805 7806 // Check whether the member type is itself a reference, in which case 7807 // we're not going to refer to the member, but to what the member refers 7808 // to. 7809 if (M->getMemberDecl()->getType()->isReferenceType()) 7810 return nullptr; 7811 7812 return EvalVal(M->getBase(), refVars, ParentDecl); 7813 } 7814 7815 case Stmt::MaterializeTemporaryExprClass: 7816 if (const Expr *Result = 7817 EvalVal(cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 7818 refVars, ParentDecl)) 7819 return Result; 7820 return E; 7821 7822 default: 7823 // Check that we don't return or take the address of a reference to a 7824 // temporary. This is only useful in C++. 7825 if (!E->isTypeDependent() && E->isRValue()) 7826 return E; 7827 7828 // Everything else: we simply don't reason about them. 7829 return nullptr; 7830 } 7831 } while (true); 7832 } 7833 7834 void 7835 Sema::CheckReturnValExpr(Expr *RetValExp, QualType lhsType, 7836 SourceLocation ReturnLoc, 7837 bool isObjCMethod, 7838 const AttrVec *Attrs, 7839 const FunctionDecl *FD) { 7840 CheckReturnStackAddr(*this, RetValExp, lhsType, ReturnLoc); 7841 7842 // Check if the return value is null but should not be. 7843 if (((Attrs && hasSpecificAttr<ReturnsNonNullAttr>(*Attrs)) || 7844 (!isObjCMethod && isNonNullType(Context, lhsType))) && 7845 CheckNonNullExpr(*this, RetValExp)) 7846 Diag(ReturnLoc, diag::warn_null_ret) 7847 << (isObjCMethod ? 1 : 0) << RetValExp->getSourceRange(); 7848 7849 // C++11 [basic.stc.dynamic.allocation]p4: 7850 // If an allocation function declared with a non-throwing 7851 // exception-specification fails to allocate storage, it shall return 7852 // a null pointer. Any other allocation function that fails to allocate 7853 // storage shall indicate failure only by throwing an exception [...] 7854 if (FD) { 7855 OverloadedOperatorKind Op = FD->getOverloadedOperator(); 7856 if (Op == OO_New || Op == OO_Array_New) { 7857 const FunctionProtoType *Proto 7858 = FD->getType()->castAs<FunctionProtoType>(); 7859 if (!Proto->isNothrow(Context, /*ResultIfDependent*/true) && 7860 CheckNonNullExpr(*this, RetValExp)) 7861 Diag(ReturnLoc, diag::warn_operator_new_returns_null) 7862 << FD << getLangOpts().CPlusPlus11; 7863 } 7864 } 7865 } 7866 7867 //===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 7868 7869 /// Check for comparisons of floating point operands using != and ==. 7870 /// Issue a warning if these are no self-comparisons, as they are not likely 7871 /// to do what the programmer intended. 7872 void Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) { 7873 Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts(); 7874 Expr* RightExprSansParen = RHS->IgnoreParenImpCasts(); 7875 7876 // Special case: check for x == x (which is OK). 7877 // Do not emit warnings for such cases. 7878 if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 7879 if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 7880 if (DRL->getDecl() == DRR->getDecl()) 7881 return; 7882 7883 // Special case: check for comparisons against literals that can be exactly 7884 // represented by APFloat. In such cases, do not emit a warning. This 7885 // is a heuristic: often comparison against such literals are used to 7886 // detect if a value in a variable has not changed. This clearly can 7887 // lead to false negatives. 7888 if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 7889 if (FLL->isExact()) 7890 return; 7891 } else 7892 if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)) 7893 if (FLR->isExact()) 7894 return; 7895 7896 // Check for comparisons with builtin types. 7897 if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 7898 if (CL->getBuiltinCallee()) 7899 return; 7900 7901 if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 7902 if (CR->getBuiltinCallee()) 7903 return; 7904 7905 // Emit the diagnostic. 7906 Diag(Loc, diag::warn_floatingpoint_eq) 7907 << LHS->getSourceRange() << RHS->getSourceRange(); 7908 } 7909 7910 //===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 7911 //===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 7912 7913 namespace { 7914 7915 /// Structure recording the 'active' range of an integer-valued 7916 /// expression. 7917 struct IntRange { 7918 /// The number of bits active in the int. 7919 unsigned Width; 7920 7921 /// True if the int is known not to have negative values. 7922 bool NonNegative; 7923 7924 IntRange(unsigned Width, bool NonNegative) 7925 : Width(Width), NonNegative(NonNegative) 7926 {} 7927 7928 /// Returns the range of the bool type. 7929 static IntRange forBoolType() { 7930 return IntRange(1, true); 7931 } 7932 7933 /// Returns the range of an opaque value of the given integral type. 7934 static IntRange forValueOfType(ASTContext &C, QualType T) { 7935 return forValueOfCanonicalType(C, 7936 T->getCanonicalTypeInternal().getTypePtr()); 7937 } 7938 7939 /// Returns the range of an opaque value of a canonical integral type. 7940 static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 7941 assert(T->isCanonicalUnqualified()); 7942 7943 if (const VectorType *VT = dyn_cast<VectorType>(T)) 7944 T = VT->getElementType().getTypePtr(); 7945 if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 7946 T = CT->getElementType().getTypePtr(); 7947 if (const AtomicType *AT = dyn_cast<AtomicType>(T)) 7948 T = AT->getValueType().getTypePtr(); 7949 7950 // For enum types, use the known bit width of the enumerators. 7951 if (const EnumType *ET = dyn_cast<EnumType>(T)) { 7952 EnumDecl *Enum = ET->getDecl(); 7953 if (!Enum->isCompleteDefinition()) 7954 return IntRange(C.getIntWidth(QualType(T, 0)), false); 7955 7956 unsigned NumPositive = Enum->getNumPositiveBits(); 7957 unsigned NumNegative = Enum->getNumNegativeBits(); 7958 7959 if (NumNegative == 0) 7960 return IntRange(NumPositive, true/*NonNegative*/); 7961 else 7962 return IntRange(std::max(NumPositive + 1, NumNegative), 7963 false/*NonNegative*/); 7964 } 7965 7966 const BuiltinType *BT = cast<BuiltinType>(T); 7967 assert(BT->isInteger()); 7968 7969 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 7970 } 7971 7972 /// Returns the "target" range of a canonical integral type, i.e. 7973 /// the range of values expressible in the type. 7974 /// 7975 /// This matches forValueOfCanonicalType except that enums have the 7976 /// full range of their type, not the range of their enumerators. 7977 static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 7978 assert(T->isCanonicalUnqualified()); 7979 7980 if (const VectorType *VT = dyn_cast<VectorType>(T)) 7981 T = VT->getElementType().getTypePtr(); 7982 if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 7983 T = CT->getElementType().getTypePtr(); 7984 if (const AtomicType *AT = dyn_cast<AtomicType>(T)) 7985 T = AT->getValueType().getTypePtr(); 7986 if (const EnumType *ET = dyn_cast<EnumType>(T)) 7987 T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr(); 7988 7989 const BuiltinType *BT = cast<BuiltinType>(T); 7990 assert(BT->isInteger()); 7991 7992 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 7993 } 7994 7995 /// Returns the supremum of two ranges: i.e. their conservative merge. 7996 static IntRange join(IntRange L, IntRange R) { 7997 return IntRange(std::max(L.Width, R.Width), 7998 L.NonNegative && R.NonNegative); 7999 } 8000 8001 /// Returns the infinum of two ranges: i.e. their aggressive merge. 8002 static IntRange meet(IntRange L, IntRange R) { 8003 return IntRange(std::min(L.Width, R.Width), 8004 L.NonNegative || R.NonNegative); 8005 } 8006 }; 8007 8008 IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) { 8009 if (value.isSigned() && value.isNegative()) 8010 return IntRange(value.getMinSignedBits(), false); 8011 8012 if (value.getBitWidth() > MaxWidth) 8013 value = value.trunc(MaxWidth); 8014 8015 // isNonNegative() just checks the sign bit without considering 8016 // signedness. 8017 return IntRange(value.getActiveBits(), true); 8018 } 8019 8020 IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 8021 unsigned MaxWidth) { 8022 if (result.isInt()) 8023 return GetValueRange(C, result.getInt(), MaxWidth); 8024 8025 if (result.isVector()) { 8026 IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 8027 for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 8028 IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 8029 R = IntRange::join(R, El); 8030 } 8031 return R; 8032 } 8033 8034 if (result.isComplexInt()) { 8035 IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 8036 IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 8037 return IntRange::join(R, I); 8038 } 8039 8040 // This can happen with lossless casts to intptr_t of "based" lvalues. 8041 // Assume it might use arbitrary bits. 8042 // FIXME: The only reason we need to pass the type in here is to get 8043 // the sign right on this one case. It would be nice if APValue 8044 // preserved this. 8045 assert(result.isLValue() || result.isAddrLabelDiff()); 8046 return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 8047 } 8048 8049 QualType GetExprType(const Expr *E) { 8050 QualType Ty = E->getType(); 8051 if (const AtomicType *AtomicRHS = Ty->getAs<AtomicType>()) 8052 Ty = AtomicRHS->getValueType(); 8053 return Ty; 8054 } 8055 8056 /// Pseudo-evaluate the given integer expression, estimating the 8057 /// range of values it might take. 8058 /// 8059 /// \param MaxWidth - the width to which the value will be truncated 8060 IntRange GetExprRange(ASTContext &C, const Expr *E, unsigned MaxWidth) { 8061 E = E->IgnoreParens(); 8062 8063 // Try a full evaluation first. 8064 Expr::EvalResult result; 8065 if (E->EvaluateAsRValue(result, C)) 8066 return GetValueRange(C, result.Val, GetExprType(E), MaxWidth); 8067 8068 // I think we only want to look through implicit casts here; if the 8069 // user has an explicit widening cast, we should treat the value as 8070 // being of the new, wider type. 8071 if (const auto *CE = dyn_cast<ImplicitCastExpr>(E)) { 8072 if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue) 8073 return GetExprRange(C, CE->getSubExpr(), MaxWidth); 8074 8075 IntRange OutputTypeRange = IntRange::forValueOfType(C, GetExprType(CE)); 8076 8077 bool isIntegerCast = CE->getCastKind() == CK_IntegralCast || 8078 CE->getCastKind() == CK_BooleanToSignedIntegral; 8079 8080 // Assume that non-integer casts can span the full range of the type. 8081 if (!isIntegerCast) 8082 return OutputTypeRange; 8083 8084 IntRange SubRange 8085 = GetExprRange(C, CE->getSubExpr(), 8086 std::min(MaxWidth, OutputTypeRange.Width)); 8087 8088 // Bail out if the subexpr's range is as wide as the cast type. 8089 if (SubRange.Width >= OutputTypeRange.Width) 8090 return OutputTypeRange; 8091 8092 // Otherwise, we take the smaller width, and we're non-negative if 8093 // either the output type or the subexpr is. 8094 return IntRange(SubRange.Width, 8095 SubRange.NonNegative || OutputTypeRange.NonNegative); 8096 } 8097 8098 if (const auto *CO = dyn_cast<ConditionalOperator>(E)) { 8099 // If we can fold the condition, just take that operand. 8100 bool CondResult; 8101 if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 8102 return GetExprRange(C, CondResult ? CO->getTrueExpr() 8103 : CO->getFalseExpr(), 8104 MaxWidth); 8105 8106 // Otherwise, conservatively merge. 8107 IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 8108 IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 8109 return IntRange::join(L, R); 8110 } 8111 8112 if (const auto *BO = dyn_cast<BinaryOperator>(E)) { 8113 switch (BO->getOpcode()) { 8114 8115 // Boolean-valued operations are single-bit and positive. 8116 case BO_LAnd: 8117 case BO_LOr: 8118 case BO_LT: 8119 case BO_GT: 8120 case BO_LE: 8121 case BO_GE: 8122 case BO_EQ: 8123 case BO_NE: 8124 return IntRange::forBoolType(); 8125 8126 // The type of the assignments is the type of the LHS, so the RHS 8127 // is not necessarily the same type. 8128 case BO_MulAssign: 8129 case BO_DivAssign: 8130 case BO_RemAssign: 8131 case BO_AddAssign: 8132 case BO_SubAssign: 8133 case BO_XorAssign: 8134 case BO_OrAssign: 8135 // TODO: bitfields? 8136 return IntRange::forValueOfType(C, GetExprType(E)); 8137 8138 // Simple assignments just pass through the RHS, which will have 8139 // been coerced to the LHS type. 8140 case BO_Assign: 8141 // TODO: bitfields? 8142 return GetExprRange(C, BO->getRHS(), MaxWidth); 8143 8144 // Operations with opaque sources are black-listed. 8145 case BO_PtrMemD: 8146 case BO_PtrMemI: 8147 return IntRange::forValueOfType(C, GetExprType(E)); 8148 8149 // Bitwise-and uses the *infinum* of the two source ranges. 8150 case BO_And: 8151 case BO_AndAssign: 8152 return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 8153 GetExprRange(C, BO->getRHS(), MaxWidth)); 8154 8155 // Left shift gets black-listed based on a judgement call. 8156 case BO_Shl: 8157 // ...except that we want to treat '1 << (blah)' as logically 8158 // positive. It's an important idiom. 8159 if (IntegerLiteral *I 8160 = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 8161 if (I->getValue() == 1) { 8162 IntRange R = IntRange::forValueOfType(C, GetExprType(E)); 8163 return IntRange(R.Width, /*NonNegative*/ true); 8164 } 8165 } 8166 // fallthrough 8167 8168 case BO_ShlAssign: 8169 return IntRange::forValueOfType(C, GetExprType(E)); 8170 8171 // Right shift by a constant can narrow its left argument. 8172 case BO_Shr: 8173 case BO_ShrAssign: { 8174 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 8175 8176 // If the shift amount is a positive constant, drop the width by 8177 // that much. 8178 llvm::APSInt shift; 8179 if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 8180 shift.isNonNegative()) { 8181 unsigned zext = shift.getZExtValue(); 8182 if (zext >= L.Width) 8183 L.Width = (L.NonNegative ? 0 : 1); 8184 else 8185 L.Width -= zext; 8186 } 8187 8188 return L; 8189 } 8190 8191 // Comma acts as its right operand. 8192 case BO_Comma: 8193 return GetExprRange(C, BO->getRHS(), MaxWidth); 8194 8195 // Black-list pointer subtractions. 8196 case BO_Sub: 8197 if (BO->getLHS()->getType()->isPointerType()) 8198 return IntRange::forValueOfType(C, GetExprType(E)); 8199 break; 8200 8201 // The width of a division result is mostly determined by the size 8202 // of the LHS. 8203 case BO_Div: { 8204 // Don't 'pre-truncate' the operands. 8205 unsigned opWidth = C.getIntWidth(GetExprType(E)); 8206 IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 8207 8208 // If the divisor is constant, use that. 8209 llvm::APSInt divisor; 8210 if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) { 8211 unsigned log2 = divisor.logBase2(); // floor(log_2(divisor)) 8212 if (log2 >= L.Width) 8213 L.Width = (L.NonNegative ? 0 : 1); 8214 else 8215 L.Width = std::min(L.Width - log2, MaxWidth); 8216 return L; 8217 } 8218 8219 // Otherwise, just use the LHS's width. 8220 IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 8221 return IntRange(L.Width, L.NonNegative && R.NonNegative); 8222 } 8223 8224 // The result of a remainder can't be larger than the result of 8225 // either side. 8226 case BO_Rem: { 8227 // Don't 'pre-truncate' the operands. 8228 unsigned opWidth = C.getIntWidth(GetExprType(E)); 8229 IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 8230 IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 8231 8232 IntRange meet = IntRange::meet(L, R); 8233 meet.Width = std::min(meet.Width, MaxWidth); 8234 return meet; 8235 } 8236 8237 // The default behavior is okay for these. 8238 case BO_Mul: 8239 case BO_Add: 8240 case BO_Xor: 8241 case BO_Or: 8242 break; 8243 } 8244 8245 // The default case is to treat the operation as if it were closed 8246 // on the narrowest type that encompasses both operands. 8247 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 8248 IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 8249 return IntRange::join(L, R); 8250 } 8251 8252 if (const auto *UO = dyn_cast<UnaryOperator>(E)) { 8253 switch (UO->getOpcode()) { 8254 // Boolean-valued operations are white-listed. 8255 case UO_LNot: 8256 return IntRange::forBoolType(); 8257 8258 // Operations with opaque sources are black-listed. 8259 case UO_Deref: 8260 case UO_AddrOf: // should be impossible 8261 return IntRange::forValueOfType(C, GetExprType(E)); 8262 8263 default: 8264 return GetExprRange(C, UO->getSubExpr(), MaxWidth); 8265 } 8266 } 8267 8268 if (const auto *OVE = dyn_cast<OpaqueValueExpr>(E)) 8269 return GetExprRange(C, OVE->getSourceExpr(), MaxWidth); 8270 8271 if (const auto *BitField = E->getSourceBitField()) 8272 return IntRange(BitField->getBitWidthValue(C), 8273 BitField->getType()->isUnsignedIntegerOrEnumerationType()); 8274 8275 return IntRange::forValueOfType(C, GetExprType(E)); 8276 } 8277 8278 IntRange GetExprRange(ASTContext &C, const Expr *E) { 8279 return GetExprRange(C, E, C.getIntWidth(GetExprType(E))); 8280 } 8281 8282 /// Checks whether the given value, which currently has the given 8283 /// source semantics, has the same value when coerced through the 8284 /// target semantics. 8285 bool IsSameFloatAfterCast(const llvm::APFloat &value, 8286 const llvm::fltSemantics &Src, 8287 const llvm::fltSemantics &Tgt) { 8288 llvm::APFloat truncated = value; 8289 8290 bool ignored; 8291 truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 8292 truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 8293 8294 return truncated.bitwiseIsEqual(value); 8295 } 8296 8297 /// Checks whether the given value, which currently has the given 8298 /// source semantics, has the same value when coerced through the 8299 /// target semantics. 8300 /// 8301 /// The value might be a vector of floats (or a complex number). 8302 bool IsSameFloatAfterCast(const APValue &value, 8303 const llvm::fltSemantics &Src, 8304 const llvm::fltSemantics &Tgt) { 8305 if (value.isFloat()) 8306 return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 8307 8308 if (value.isVector()) { 8309 for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 8310 if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 8311 return false; 8312 return true; 8313 } 8314 8315 assert(value.isComplexFloat()); 8316 return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 8317 IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 8318 } 8319 8320 void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 8321 8322 bool IsZero(Sema &S, Expr *E) { 8323 // Suppress cases where we are comparing against an enum constant. 8324 if (const DeclRefExpr *DR = 8325 dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 8326 if (isa<EnumConstantDecl>(DR->getDecl())) 8327 return false; 8328 8329 // Suppress cases where the '0' value is expanded from a macro. 8330 if (E->getLocStart().isMacroID()) 8331 return false; 8332 8333 llvm::APSInt Value; 8334 return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 8335 } 8336 8337 bool HasEnumType(Expr *E) { 8338 // Strip off implicit integral promotions. 8339 while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 8340 if (ICE->getCastKind() != CK_IntegralCast && 8341 ICE->getCastKind() != CK_NoOp) 8342 break; 8343 E = ICE->getSubExpr(); 8344 } 8345 8346 return E->getType()->isEnumeralType(); 8347 } 8348 8349 void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 8350 // Disable warning in template instantiations. 8351 if (S.inTemplateInstantiation()) 8352 return; 8353 8354 BinaryOperatorKind op = E->getOpcode(); 8355 if (E->isValueDependent()) 8356 return; 8357 8358 if (op == BO_LT && IsZero(S, E->getRHS())) { 8359 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 8360 << "< 0" << "false" << HasEnumType(E->getLHS()) 8361 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 8362 } else if (op == BO_GE && IsZero(S, E->getRHS())) { 8363 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 8364 << ">= 0" << "true" << HasEnumType(E->getLHS()) 8365 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 8366 } else if (op == BO_GT && IsZero(S, E->getLHS())) { 8367 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 8368 << "0 >" << "false" << HasEnumType(E->getRHS()) 8369 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 8370 } else if (op == BO_LE && IsZero(S, E->getLHS())) { 8371 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 8372 << "0 <=" << "true" << HasEnumType(E->getRHS()) 8373 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 8374 } 8375 } 8376 8377 void DiagnoseOutOfRangeComparison(Sema &S, BinaryOperator *E, Expr *Constant, 8378 Expr *Other, const llvm::APSInt &Value, 8379 bool RhsConstant) { 8380 // Disable warning in template instantiations. 8381 if (S.inTemplateInstantiation()) 8382 return; 8383 8384 // TODO: Investigate using GetExprRange() to get tighter bounds 8385 // on the bit ranges. 8386 QualType OtherT = Other->getType(); 8387 if (const auto *AT = OtherT->getAs<AtomicType>()) 8388 OtherT = AT->getValueType(); 8389 IntRange OtherRange = IntRange::forValueOfType(S.Context, OtherT); 8390 unsigned OtherWidth = OtherRange.Width; 8391 8392 bool OtherIsBooleanType = Other->isKnownToHaveBooleanValue(); 8393 8394 // 0 values are handled later by CheckTrivialUnsignedComparison(). 8395 if ((Value == 0) && (!OtherIsBooleanType)) 8396 return; 8397 8398 BinaryOperatorKind op = E->getOpcode(); 8399 bool IsTrue = true; 8400 8401 // Used for diagnostic printout. 8402 enum { 8403 LiteralConstant = 0, 8404 CXXBoolLiteralTrue, 8405 CXXBoolLiteralFalse 8406 } LiteralOrBoolConstant = LiteralConstant; 8407 8408 if (!OtherIsBooleanType) { 8409 QualType ConstantT = Constant->getType(); 8410 QualType CommonT = E->getLHS()->getType(); 8411 8412 if (S.Context.hasSameUnqualifiedType(OtherT, ConstantT)) 8413 return; 8414 assert((OtherT->isIntegerType() && ConstantT->isIntegerType()) && 8415 "comparison with non-integer type"); 8416 8417 bool ConstantSigned = ConstantT->isSignedIntegerType(); 8418 bool CommonSigned = CommonT->isSignedIntegerType(); 8419 8420 bool EqualityOnly = false; 8421 8422 if (CommonSigned) { 8423 // The common type is signed, therefore no signed to unsigned conversion. 8424 if (!OtherRange.NonNegative) { 8425 // Check that the constant is representable in type OtherT. 8426 if (ConstantSigned) { 8427 if (OtherWidth >= Value.getMinSignedBits()) 8428 return; 8429 } else { // !ConstantSigned 8430 if (OtherWidth >= Value.getActiveBits() + 1) 8431 return; 8432 } 8433 } else { // !OtherSigned 8434 // Check that the constant is representable in type OtherT. 8435 // Negative values are out of range. 8436 if (ConstantSigned) { 8437 if (Value.isNonNegative() && OtherWidth >= Value.getActiveBits()) 8438 return; 8439 } else { // !ConstantSigned 8440 if (OtherWidth >= Value.getActiveBits()) 8441 return; 8442 } 8443 } 8444 } else { // !CommonSigned 8445 if (OtherRange.NonNegative) { 8446 if (OtherWidth >= Value.getActiveBits()) 8447 return; 8448 } else { // OtherSigned 8449 assert(!ConstantSigned && 8450 "Two signed types converted to unsigned types."); 8451 // Check to see if the constant is representable in OtherT. 8452 if (OtherWidth > Value.getActiveBits()) 8453 return; 8454 // Check to see if the constant is equivalent to a negative value 8455 // cast to CommonT. 8456 if (S.Context.getIntWidth(ConstantT) == 8457 S.Context.getIntWidth(CommonT) && 8458 Value.isNegative() && Value.getMinSignedBits() <= OtherWidth) 8459 return; 8460 // The constant value rests between values that OtherT can represent 8461 // after conversion. Relational comparison still works, but equality 8462 // comparisons will be tautological. 8463 EqualityOnly = true; 8464 } 8465 } 8466 8467 bool PositiveConstant = !ConstantSigned || Value.isNonNegative(); 8468 8469 if (op == BO_EQ || op == BO_NE) { 8470 IsTrue = op == BO_NE; 8471 } else if (EqualityOnly) { 8472 return; 8473 } else if (RhsConstant) { 8474 if (op == BO_GT || op == BO_GE) 8475 IsTrue = !PositiveConstant; 8476 else // op == BO_LT || op == BO_LE 8477 IsTrue = PositiveConstant; 8478 } else { 8479 if (op == BO_LT || op == BO_LE) 8480 IsTrue = !PositiveConstant; 8481 else // op == BO_GT || op == BO_GE 8482 IsTrue = PositiveConstant; 8483 } 8484 } else { 8485 // Other isKnownToHaveBooleanValue 8486 enum CompareBoolWithConstantResult { AFals, ATrue, Unkwn }; 8487 enum ConstantValue { LT_Zero, Zero, One, GT_One, SizeOfConstVal }; 8488 enum ConstantSide { Lhs, Rhs, SizeOfConstSides }; 8489 8490 static const struct LinkedConditions { 8491 CompareBoolWithConstantResult BO_LT_OP[SizeOfConstSides][SizeOfConstVal]; 8492 CompareBoolWithConstantResult BO_GT_OP[SizeOfConstSides][SizeOfConstVal]; 8493 CompareBoolWithConstantResult BO_LE_OP[SizeOfConstSides][SizeOfConstVal]; 8494 CompareBoolWithConstantResult BO_GE_OP[SizeOfConstSides][SizeOfConstVal]; 8495 CompareBoolWithConstantResult BO_EQ_OP[SizeOfConstSides][SizeOfConstVal]; 8496 CompareBoolWithConstantResult BO_NE_OP[SizeOfConstSides][SizeOfConstVal]; 8497 8498 } TruthTable = { 8499 // Constant on LHS. | Constant on RHS. | 8500 // LT_Zero| Zero | One |GT_One| LT_Zero| Zero | One |GT_One| 8501 { { ATrue, Unkwn, AFals, AFals }, { AFals, AFals, Unkwn, ATrue } }, 8502 { { AFals, AFals, Unkwn, ATrue }, { ATrue, Unkwn, AFals, AFals } }, 8503 { { ATrue, ATrue, Unkwn, AFals }, { AFals, Unkwn, ATrue, ATrue } }, 8504 { { AFals, Unkwn, ATrue, ATrue }, { ATrue, ATrue, Unkwn, AFals } }, 8505 { { AFals, Unkwn, Unkwn, AFals }, { AFals, Unkwn, Unkwn, AFals } }, 8506 { { ATrue, Unkwn, Unkwn, ATrue }, { ATrue, Unkwn, Unkwn, ATrue } } 8507 }; 8508 8509 bool ConstantIsBoolLiteral = isa<CXXBoolLiteralExpr>(Constant); 8510 8511 enum ConstantValue ConstVal = Zero; 8512 if (Value.isUnsigned() || Value.isNonNegative()) { 8513 if (Value == 0) { 8514 LiteralOrBoolConstant = 8515 ConstantIsBoolLiteral ? CXXBoolLiteralFalse : LiteralConstant; 8516 ConstVal = Zero; 8517 } else if (Value == 1) { 8518 LiteralOrBoolConstant = 8519 ConstantIsBoolLiteral ? CXXBoolLiteralTrue : LiteralConstant; 8520 ConstVal = One; 8521 } else { 8522 LiteralOrBoolConstant = LiteralConstant; 8523 ConstVal = GT_One; 8524 } 8525 } else { 8526 ConstVal = LT_Zero; 8527 } 8528 8529 CompareBoolWithConstantResult CmpRes; 8530 8531 switch (op) { 8532 case BO_LT: 8533 CmpRes = TruthTable.BO_LT_OP[RhsConstant][ConstVal]; 8534 break; 8535 case BO_GT: 8536 CmpRes = TruthTable.BO_GT_OP[RhsConstant][ConstVal]; 8537 break; 8538 case BO_LE: 8539 CmpRes = TruthTable.BO_LE_OP[RhsConstant][ConstVal]; 8540 break; 8541 case BO_GE: 8542 CmpRes = TruthTable.BO_GE_OP[RhsConstant][ConstVal]; 8543 break; 8544 case BO_EQ: 8545 CmpRes = TruthTable.BO_EQ_OP[RhsConstant][ConstVal]; 8546 break; 8547 case BO_NE: 8548 CmpRes = TruthTable.BO_NE_OP[RhsConstant][ConstVal]; 8549 break; 8550 default: 8551 CmpRes = Unkwn; 8552 break; 8553 } 8554 8555 if (CmpRes == AFals) { 8556 IsTrue = false; 8557 } else if (CmpRes == ATrue) { 8558 IsTrue = true; 8559 } else { 8560 return; 8561 } 8562 } 8563 8564 // If this is a comparison to an enum constant, include that 8565 // constant in the diagnostic. 8566 const EnumConstantDecl *ED = nullptr; 8567 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Constant)) 8568 ED = dyn_cast<EnumConstantDecl>(DR->getDecl()); 8569 8570 SmallString<64> PrettySourceValue; 8571 llvm::raw_svector_ostream OS(PrettySourceValue); 8572 if (ED) 8573 OS << '\'' << *ED << "' (" << Value << ")"; 8574 else 8575 OS << Value; 8576 8577 S.DiagRuntimeBehavior( 8578 E->getOperatorLoc(), E, 8579 S.PDiag(diag::warn_out_of_range_compare) 8580 << OS.str() << LiteralOrBoolConstant 8581 << OtherT << (OtherIsBooleanType && !OtherT->isBooleanType()) << IsTrue 8582 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange()); 8583 } 8584 8585 /// Analyze the operands of the given comparison. Implements the 8586 /// fallback case from AnalyzeComparison. 8587 void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 8588 AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 8589 AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 8590 } 8591 8592 /// \brief Implements -Wsign-compare. 8593 /// 8594 /// \param E the binary operator to check for warnings 8595 void AnalyzeComparison(Sema &S, BinaryOperator *E) { 8596 // The type the comparison is being performed in. 8597 QualType T = E->getLHS()->getType(); 8598 8599 // Only analyze comparison operators where both sides have been converted to 8600 // the same type. 8601 if (!S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType())) 8602 return AnalyzeImpConvsInComparison(S, E); 8603 8604 // Don't analyze value-dependent comparisons directly. 8605 if (E->isValueDependent()) 8606 return AnalyzeImpConvsInComparison(S, E); 8607 8608 Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); 8609 Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); 8610 8611 bool IsComparisonConstant = false; 8612 8613 // Check whether an integer constant comparison results in a value 8614 // of 'true' or 'false'. 8615 if (T->isIntegralType(S.Context)) { 8616 llvm::APSInt RHSValue; 8617 bool IsRHSIntegralLiteral = 8618 RHS->isIntegerConstantExpr(RHSValue, S.Context); 8619 llvm::APSInt LHSValue; 8620 bool IsLHSIntegralLiteral = 8621 LHS->isIntegerConstantExpr(LHSValue, S.Context); 8622 if (IsRHSIntegralLiteral && !IsLHSIntegralLiteral) 8623 DiagnoseOutOfRangeComparison(S, E, RHS, LHS, RHSValue, true); 8624 else if (!IsRHSIntegralLiteral && IsLHSIntegralLiteral) 8625 DiagnoseOutOfRangeComparison(S, E, LHS, RHS, LHSValue, false); 8626 else 8627 IsComparisonConstant = 8628 (IsRHSIntegralLiteral && IsLHSIntegralLiteral); 8629 } else if (!T->hasUnsignedIntegerRepresentation()) 8630 IsComparisonConstant = E->isIntegerConstantExpr(S.Context); 8631 8632 // We don't do anything special if this isn't an unsigned integral 8633 // comparison: we're only interested in integral comparisons, and 8634 // signed comparisons only happen in cases we don't care to warn about. 8635 // 8636 // We also don't care about value-dependent expressions or expressions 8637 // whose result is a constant. 8638 if (!T->hasUnsignedIntegerRepresentation() || IsComparisonConstant) 8639 return AnalyzeImpConvsInComparison(S, E); 8640 8641 // Check to see if one of the (unmodified) operands is of different 8642 // signedness. 8643 Expr *signedOperand, *unsignedOperand; 8644 if (LHS->getType()->hasSignedIntegerRepresentation()) { 8645 assert(!RHS->getType()->hasSignedIntegerRepresentation() && 8646 "unsigned comparison between two signed integer expressions?"); 8647 signedOperand = LHS; 8648 unsignedOperand = RHS; 8649 } else if (RHS->getType()->hasSignedIntegerRepresentation()) { 8650 signedOperand = RHS; 8651 unsignedOperand = LHS; 8652 } else { 8653 CheckTrivialUnsignedComparison(S, E); 8654 return AnalyzeImpConvsInComparison(S, E); 8655 } 8656 8657 // Otherwise, calculate the effective range of the signed operand. 8658 IntRange signedRange = GetExprRange(S.Context, signedOperand); 8659 8660 // Go ahead and analyze implicit conversions in the operands. Note 8661 // that we skip the implicit conversions on both sides. 8662 AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc()); 8663 AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc()); 8664 8665 // If the signed range is non-negative, -Wsign-compare won't fire, 8666 // but we should still check for comparisons which are always true 8667 // or false. 8668 if (signedRange.NonNegative) 8669 return CheckTrivialUnsignedComparison(S, E); 8670 8671 // For (in)equality comparisons, if the unsigned operand is a 8672 // constant which cannot collide with a overflowed signed operand, 8673 // then reinterpreting the signed operand as unsigned will not 8674 // change the result of the comparison. 8675 if (E->isEqualityOp()) { 8676 unsigned comparisonWidth = S.Context.getIntWidth(T); 8677 IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 8678 8679 // We should never be unable to prove that the unsigned operand is 8680 // non-negative. 8681 assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 8682 8683 if (unsignedRange.Width < comparisonWidth) 8684 return; 8685 } 8686 8687 S.DiagRuntimeBehavior(E->getOperatorLoc(), E, 8688 S.PDiag(diag::warn_mixed_sign_comparison) 8689 << LHS->getType() << RHS->getType() 8690 << LHS->getSourceRange() << RHS->getSourceRange()); 8691 } 8692 8693 /// Analyzes an attempt to assign the given value to a bitfield. 8694 /// 8695 /// Returns true if there was something fishy about the attempt. 8696 bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 8697 SourceLocation InitLoc) { 8698 assert(Bitfield->isBitField()); 8699 if (Bitfield->isInvalidDecl()) 8700 return false; 8701 8702 // White-list bool bitfields. 8703 QualType BitfieldType = Bitfield->getType(); 8704 if (BitfieldType->isBooleanType()) 8705 return false; 8706 8707 if (BitfieldType->isEnumeralType()) { 8708 EnumDecl *BitfieldEnumDecl = BitfieldType->getAs<EnumType>()->getDecl(); 8709 // If the underlying enum type was not explicitly specified as an unsigned 8710 // type and the enum contain only positive values, MSVC++ will cause an 8711 // inconsistency by storing this as a signed type. 8712 if (S.getLangOpts().CPlusPlus11 && 8713 !BitfieldEnumDecl->getIntegerTypeSourceInfo() && 8714 BitfieldEnumDecl->getNumPositiveBits() > 0 && 8715 BitfieldEnumDecl->getNumNegativeBits() == 0) { 8716 S.Diag(InitLoc, diag::warn_no_underlying_type_specified_for_enum_bitfield) 8717 << BitfieldEnumDecl->getNameAsString(); 8718 } 8719 } 8720 8721 if (Bitfield->getType()->isBooleanType()) 8722 return false; 8723 8724 // Ignore value- or type-dependent expressions. 8725 if (Bitfield->getBitWidth()->isValueDependent() || 8726 Bitfield->getBitWidth()->isTypeDependent() || 8727 Init->isValueDependent() || 8728 Init->isTypeDependent()) 8729 return false; 8730 8731 Expr *OriginalInit = Init->IgnoreParenImpCasts(); 8732 unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context); 8733 8734 llvm::APSInt Value; 8735 if (!OriginalInit->EvaluateAsInt(Value, S.Context, 8736 Expr::SE_AllowSideEffects)) { 8737 // The RHS is not constant. If the RHS has an enum type, make sure the 8738 // bitfield is wide enough to hold all the values of the enum without 8739 // truncation. 8740 if (const auto *EnumTy = OriginalInit->getType()->getAs<EnumType>()) { 8741 EnumDecl *ED = EnumTy->getDecl(); 8742 bool SignedBitfield = BitfieldType->isSignedIntegerType(); 8743 8744 // Enum types are implicitly signed on Windows, so check if there are any 8745 // negative enumerators to see if the enum was intended to be signed or 8746 // not. 8747 bool SignedEnum = ED->getNumNegativeBits() > 0; 8748 8749 // Check for surprising sign changes when assigning enum values to a 8750 // bitfield of different signedness. If the bitfield is signed and we 8751 // have exactly the right number of bits to store this unsigned enum, 8752 // suggest changing the enum to an unsigned type. This typically happens 8753 // on Windows where unfixed enums always use an underlying type of 'int'. 8754 unsigned DiagID = 0; 8755 if (SignedEnum && !SignedBitfield) { 8756 DiagID = diag::warn_unsigned_bitfield_assigned_signed_enum; 8757 } else if (SignedBitfield && !SignedEnum && 8758 ED->getNumPositiveBits() == FieldWidth) { 8759 DiagID = diag::warn_signed_bitfield_enum_conversion; 8760 } 8761 8762 if (DiagID) { 8763 S.Diag(InitLoc, DiagID) << Bitfield << ED; 8764 TypeSourceInfo *TSI = Bitfield->getTypeSourceInfo(); 8765 SourceRange TypeRange = 8766 TSI ? TSI->getTypeLoc().getSourceRange() : SourceRange(); 8767 S.Diag(Bitfield->getTypeSpecStartLoc(), diag::note_change_bitfield_sign) 8768 << SignedEnum << TypeRange; 8769 } 8770 8771 // Compute the required bitwidth. If the enum has negative values, we need 8772 // one more bit than the normal number of positive bits to represent the 8773 // sign bit. 8774 unsigned BitsNeeded = SignedEnum ? std::max(ED->getNumPositiveBits() + 1, 8775 ED->getNumNegativeBits()) 8776 : ED->getNumPositiveBits(); 8777 8778 // Check the bitwidth. 8779 if (BitsNeeded > FieldWidth) { 8780 Expr *WidthExpr = Bitfield->getBitWidth(); 8781 S.Diag(InitLoc, diag::warn_bitfield_too_small_for_enum) 8782 << Bitfield << ED; 8783 S.Diag(WidthExpr->getExprLoc(), diag::note_widen_bitfield) 8784 << BitsNeeded << ED << WidthExpr->getSourceRange(); 8785 } 8786 } 8787 8788 return false; 8789 } 8790 8791 unsigned OriginalWidth = Value.getBitWidth(); 8792 8793 if (!Value.isSigned() || Value.isNegative()) 8794 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(OriginalInit)) 8795 if (UO->getOpcode() == UO_Minus || UO->getOpcode() == UO_Not) 8796 OriginalWidth = Value.getMinSignedBits(); 8797 8798 if (OriginalWidth <= FieldWidth) 8799 return false; 8800 8801 // Compute the value which the bitfield will contain. 8802 llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 8803 TruncatedValue.setIsSigned(BitfieldType->isSignedIntegerType()); 8804 8805 // Check whether the stored value is equal to the original value. 8806 TruncatedValue = TruncatedValue.extend(OriginalWidth); 8807 if (llvm::APSInt::isSameValue(Value, TruncatedValue)) 8808 return false; 8809 8810 // Special-case bitfields of width 1: booleans are naturally 0/1, and 8811 // therefore don't strictly fit into a signed bitfield of width 1. 8812 if (FieldWidth == 1 && Value == 1) 8813 return false; 8814 8815 std::string PrettyValue = Value.toString(10); 8816 std::string PrettyTrunc = TruncatedValue.toString(10); 8817 8818 S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 8819 << PrettyValue << PrettyTrunc << OriginalInit->getType() 8820 << Init->getSourceRange(); 8821 8822 return true; 8823 } 8824 8825 /// Analyze the given simple or compound assignment for warning-worthy 8826 /// operations. 8827 void AnalyzeAssignment(Sema &S, BinaryOperator *E) { 8828 // Just recurse on the LHS. 8829 AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 8830 8831 // We want to recurse on the RHS as normal unless we're assigning to 8832 // a bitfield. 8833 if (FieldDecl *Bitfield = E->getLHS()->getSourceBitField()) { 8834 if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 8835 E->getOperatorLoc())) { 8836 // Recurse, ignoring any implicit conversions on the RHS. 8837 return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 8838 E->getOperatorLoc()); 8839 } 8840 } 8841 8842 AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 8843 } 8844 8845 /// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 8846 void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 8847 SourceLocation CContext, unsigned diag, 8848 bool pruneControlFlow = false) { 8849 if (pruneControlFlow) { 8850 S.DiagRuntimeBehavior(E->getExprLoc(), E, 8851 S.PDiag(diag) 8852 << SourceType << T << E->getSourceRange() 8853 << SourceRange(CContext)); 8854 return; 8855 } 8856 S.Diag(E->getExprLoc(), diag) 8857 << SourceType << T << E->getSourceRange() << SourceRange(CContext); 8858 } 8859 8860 /// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 8861 void DiagnoseImpCast(Sema &S, Expr *E, QualType T, SourceLocation CContext, 8862 unsigned diag, bool pruneControlFlow = false) { 8863 DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow); 8864 } 8865 8866 8867 /// Diagnose an implicit cast from a floating point value to an integer value. 8868 void DiagnoseFloatingImpCast(Sema &S, Expr *E, QualType T, 8869 8870 SourceLocation CContext) { 8871 const bool IsBool = T->isSpecificBuiltinType(BuiltinType::Bool); 8872 const bool PruneWarnings = S.inTemplateInstantiation(); 8873 8874 Expr *InnerE = E->IgnoreParenImpCasts(); 8875 // We also want to warn on, e.g., "int i = -1.234" 8876 if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE)) 8877 if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus) 8878 InnerE = UOp->getSubExpr()->IgnoreParenImpCasts(); 8879 8880 const bool IsLiteral = 8881 isa<FloatingLiteral>(E) || isa<FloatingLiteral>(InnerE); 8882 8883 llvm::APFloat Value(0.0); 8884 bool IsConstant = 8885 E->EvaluateAsFloat(Value, S.Context, Expr::SE_AllowSideEffects); 8886 if (!IsConstant) { 8887 return DiagnoseImpCast(S, E, T, CContext, 8888 diag::warn_impcast_float_integer, PruneWarnings); 8889 } 8890 8891 bool isExact = false; 8892 8893 llvm::APSInt IntegerValue(S.Context.getIntWidth(T), 8894 T->hasUnsignedIntegerRepresentation()); 8895 if (Value.convertToInteger(IntegerValue, llvm::APFloat::rmTowardZero, 8896 &isExact) == llvm::APFloat::opOK && 8897 isExact) { 8898 if (IsLiteral) return; 8899 return DiagnoseImpCast(S, E, T, CContext, diag::warn_impcast_float_integer, 8900 PruneWarnings); 8901 } 8902 8903 unsigned DiagID = 0; 8904 if (IsLiteral) { 8905 // Warn on floating point literal to integer. 8906 DiagID = diag::warn_impcast_literal_float_to_integer; 8907 } else if (IntegerValue == 0) { 8908 if (Value.isZero()) { // Skip -0.0 to 0 conversion. 8909 return DiagnoseImpCast(S, E, T, CContext, 8910 diag::warn_impcast_float_integer, PruneWarnings); 8911 } 8912 // Warn on non-zero to zero conversion. 8913 DiagID = diag::warn_impcast_float_to_integer_zero; 8914 } else { 8915 if (IntegerValue.isUnsigned()) { 8916 if (!IntegerValue.isMaxValue()) { 8917 return DiagnoseImpCast(S, E, T, CContext, 8918 diag::warn_impcast_float_integer, PruneWarnings); 8919 } 8920 } else { // IntegerValue.isSigned() 8921 if (!IntegerValue.isMaxSignedValue() && 8922 !IntegerValue.isMinSignedValue()) { 8923 return DiagnoseImpCast(S, E, T, CContext, 8924 diag::warn_impcast_float_integer, PruneWarnings); 8925 } 8926 } 8927 // Warn on evaluatable floating point expression to integer conversion. 8928 DiagID = diag::warn_impcast_float_to_integer; 8929 } 8930 8931 // FIXME: Force the precision of the source value down so we don't print 8932 // digits which are usually useless (we don't really care here if we 8933 // truncate a digit by accident in edge cases). Ideally, APFloat::toString 8934 // would automatically print the shortest representation, but it's a bit 8935 // tricky to implement. 8936 SmallString<16> PrettySourceValue; 8937 unsigned precision = llvm::APFloat::semanticsPrecision(Value.getSemantics()); 8938 precision = (precision * 59 + 195) / 196; 8939 Value.toString(PrettySourceValue, precision); 8940 8941 SmallString<16> PrettyTargetValue; 8942 if (IsBool) 8943 PrettyTargetValue = Value.isZero() ? "false" : "true"; 8944 else 8945 IntegerValue.toString(PrettyTargetValue); 8946 8947 if (PruneWarnings) { 8948 S.DiagRuntimeBehavior(E->getExprLoc(), E, 8949 S.PDiag(DiagID) 8950 << E->getType() << T.getUnqualifiedType() 8951 << PrettySourceValue << PrettyTargetValue 8952 << E->getSourceRange() << SourceRange(CContext)); 8953 } else { 8954 S.Diag(E->getExprLoc(), DiagID) 8955 << E->getType() << T.getUnqualifiedType() << PrettySourceValue 8956 << PrettyTargetValue << E->getSourceRange() << SourceRange(CContext); 8957 } 8958 } 8959 8960 std::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 8961 if (!Range.Width) return "0"; 8962 8963 llvm::APSInt ValueInRange = Value; 8964 ValueInRange.setIsSigned(!Range.NonNegative); 8965 ValueInRange = ValueInRange.trunc(Range.Width); 8966 return ValueInRange.toString(10); 8967 } 8968 8969 bool IsImplicitBoolFloatConversion(Sema &S, Expr *Ex, bool ToBool) { 8970 if (!isa<ImplicitCastExpr>(Ex)) 8971 return false; 8972 8973 Expr *InnerE = Ex->IgnoreParenImpCasts(); 8974 const Type *Target = S.Context.getCanonicalType(Ex->getType()).getTypePtr(); 8975 const Type *Source = 8976 S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 8977 if (Target->isDependentType()) 8978 return false; 8979 8980 const BuiltinType *FloatCandidateBT = 8981 dyn_cast<BuiltinType>(ToBool ? Source : Target); 8982 const Type *BoolCandidateType = ToBool ? Target : Source; 8983 8984 return (BoolCandidateType->isSpecificBuiltinType(BuiltinType::Bool) && 8985 FloatCandidateBT && (FloatCandidateBT->isFloatingPoint())); 8986 } 8987 8988 void CheckImplicitArgumentConversions(Sema &S, CallExpr *TheCall, 8989 SourceLocation CC) { 8990 unsigned NumArgs = TheCall->getNumArgs(); 8991 for (unsigned i = 0; i < NumArgs; ++i) { 8992 Expr *CurrA = TheCall->getArg(i); 8993 if (!IsImplicitBoolFloatConversion(S, CurrA, true)) 8994 continue; 8995 8996 bool IsSwapped = ((i > 0) && 8997 IsImplicitBoolFloatConversion(S, TheCall->getArg(i - 1), false)); 8998 IsSwapped |= ((i < (NumArgs - 1)) && 8999 IsImplicitBoolFloatConversion(S, TheCall->getArg(i + 1), false)); 9000 if (IsSwapped) { 9001 // Warn on this floating-point to bool conversion. 9002 DiagnoseImpCast(S, CurrA->IgnoreParenImpCasts(), 9003 CurrA->getType(), CC, 9004 diag::warn_impcast_floating_point_to_bool); 9005 } 9006 } 9007 } 9008 9009 void DiagnoseNullConversion(Sema &S, Expr *E, QualType T, SourceLocation CC) { 9010 if (S.Diags.isIgnored(diag::warn_impcast_null_pointer_to_integer, 9011 E->getExprLoc())) 9012 return; 9013 9014 // Don't warn on functions which have return type nullptr_t. 9015 if (isa<CallExpr>(E)) 9016 return; 9017 9018 // Check for NULL (GNUNull) or nullptr (CXX11_nullptr). 9019 const Expr::NullPointerConstantKind NullKind = 9020 E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull); 9021 if (NullKind != Expr::NPCK_GNUNull && NullKind != Expr::NPCK_CXX11_nullptr) 9022 return; 9023 9024 // Return if target type is a safe conversion. 9025 if (T->isAnyPointerType() || T->isBlockPointerType() || 9026 T->isMemberPointerType() || !T->isScalarType() || T->isNullPtrType()) 9027 return; 9028 9029 SourceLocation Loc = E->getSourceRange().getBegin(); 9030 9031 // Venture through the macro stacks to get to the source of macro arguments. 9032 // The new location is a better location than the complete location that was 9033 // passed in. 9034 while (S.SourceMgr.isMacroArgExpansion(Loc)) 9035 Loc = S.SourceMgr.getImmediateMacroCallerLoc(Loc); 9036 9037 while (S.SourceMgr.isMacroArgExpansion(CC)) 9038 CC = S.SourceMgr.getImmediateMacroCallerLoc(CC); 9039 9040 // __null is usually wrapped in a macro. Go up a macro if that is the case. 9041 if (NullKind == Expr::NPCK_GNUNull && Loc.isMacroID()) { 9042 StringRef MacroName = Lexer::getImmediateMacroNameForDiagnostics( 9043 Loc, S.SourceMgr, S.getLangOpts()); 9044 if (MacroName == "NULL") 9045 Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first; 9046 } 9047 9048 // Only warn if the null and context location are in the same macro expansion. 9049 if (S.SourceMgr.getFileID(Loc) != S.SourceMgr.getFileID(CC)) 9050 return; 9051 9052 S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer) 9053 << (NullKind == Expr::NPCK_CXX11_nullptr) << T << clang::SourceRange(CC) 9054 << FixItHint::CreateReplacement(Loc, 9055 S.getFixItZeroLiteralForType(T, Loc)); 9056 } 9057 9058 void checkObjCArrayLiteral(Sema &S, QualType TargetType, 9059 ObjCArrayLiteral *ArrayLiteral); 9060 void checkObjCDictionaryLiteral(Sema &S, QualType TargetType, 9061 ObjCDictionaryLiteral *DictionaryLiteral); 9062 9063 /// Check a single element within a collection literal against the 9064 /// target element type. 9065 void checkObjCCollectionLiteralElement(Sema &S, QualType TargetElementType, 9066 Expr *Element, unsigned ElementKind) { 9067 // Skip a bitcast to 'id' or qualified 'id'. 9068 if (auto ICE = dyn_cast<ImplicitCastExpr>(Element)) { 9069 if (ICE->getCastKind() == CK_BitCast && 9070 ICE->getSubExpr()->getType()->getAs<ObjCObjectPointerType>()) 9071 Element = ICE->getSubExpr(); 9072 } 9073 9074 QualType ElementType = Element->getType(); 9075 ExprResult ElementResult(Element); 9076 if (ElementType->getAs<ObjCObjectPointerType>() && 9077 S.CheckSingleAssignmentConstraints(TargetElementType, 9078 ElementResult, 9079 false, false) 9080 != Sema::Compatible) { 9081 S.Diag(Element->getLocStart(), 9082 diag::warn_objc_collection_literal_element) 9083 << ElementType << ElementKind << TargetElementType 9084 << Element->getSourceRange(); 9085 } 9086 9087 if (auto ArrayLiteral = dyn_cast<ObjCArrayLiteral>(Element)) 9088 checkObjCArrayLiteral(S, TargetElementType, ArrayLiteral); 9089 else if (auto DictionaryLiteral = dyn_cast<ObjCDictionaryLiteral>(Element)) 9090 checkObjCDictionaryLiteral(S, TargetElementType, DictionaryLiteral); 9091 } 9092 9093 /// Check an Objective-C array literal being converted to the given 9094 /// target type. 9095 void checkObjCArrayLiteral(Sema &S, QualType TargetType, 9096 ObjCArrayLiteral *ArrayLiteral) { 9097 if (!S.NSArrayDecl) 9098 return; 9099 9100 const auto *TargetObjCPtr = TargetType->getAs<ObjCObjectPointerType>(); 9101 if (!TargetObjCPtr) 9102 return; 9103 9104 if (TargetObjCPtr->isUnspecialized() || 9105 TargetObjCPtr->getInterfaceDecl()->getCanonicalDecl() 9106 != S.NSArrayDecl->getCanonicalDecl()) 9107 return; 9108 9109 auto TypeArgs = TargetObjCPtr->getTypeArgs(); 9110 if (TypeArgs.size() != 1) 9111 return; 9112 9113 QualType TargetElementType = TypeArgs[0]; 9114 for (unsigned I = 0, N = ArrayLiteral->getNumElements(); I != N; ++I) { 9115 checkObjCCollectionLiteralElement(S, TargetElementType, 9116 ArrayLiteral->getElement(I), 9117 0); 9118 } 9119 } 9120 9121 /// Check an Objective-C dictionary literal being converted to the given 9122 /// target type. 9123 void checkObjCDictionaryLiteral(Sema &S, QualType TargetType, 9124 ObjCDictionaryLiteral *DictionaryLiteral) { 9125 if (!S.NSDictionaryDecl) 9126 return; 9127 9128 const auto *TargetObjCPtr = TargetType->getAs<ObjCObjectPointerType>(); 9129 if (!TargetObjCPtr) 9130 return; 9131 9132 if (TargetObjCPtr->isUnspecialized() || 9133 TargetObjCPtr->getInterfaceDecl()->getCanonicalDecl() 9134 != S.NSDictionaryDecl->getCanonicalDecl()) 9135 return; 9136 9137 auto TypeArgs = TargetObjCPtr->getTypeArgs(); 9138 if (TypeArgs.size() != 2) 9139 return; 9140 9141 QualType TargetKeyType = TypeArgs[0]; 9142 QualType TargetObjectType = TypeArgs[1]; 9143 for (unsigned I = 0, N = DictionaryLiteral->getNumElements(); I != N; ++I) { 9144 auto Element = DictionaryLiteral->getKeyValueElement(I); 9145 checkObjCCollectionLiteralElement(S, TargetKeyType, Element.Key, 1); 9146 checkObjCCollectionLiteralElement(S, TargetObjectType, Element.Value, 2); 9147 } 9148 } 9149 9150 // Helper function to filter out cases for constant width constant conversion. 9151 // Don't warn on char array initialization or for non-decimal values. 9152 bool isSameWidthConstantConversion(Sema &S, Expr *E, QualType T, 9153 SourceLocation CC) { 9154 // If initializing from a constant, and the constant starts with '0', 9155 // then it is a binary, octal, or hexadecimal. Allow these constants 9156 // to fill all the bits, even if there is a sign change. 9157 if (auto *IntLit = dyn_cast<IntegerLiteral>(E->IgnoreParenImpCasts())) { 9158 const char FirstLiteralCharacter = 9159 S.getSourceManager().getCharacterData(IntLit->getLocStart())[0]; 9160 if (FirstLiteralCharacter == '0') 9161 return false; 9162 } 9163 9164 // If the CC location points to a '{', and the type is char, then assume 9165 // assume it is an array initialization. 9166 if (CC.isValid() && T->isCharType()) { 9167 const char FirstContextCharacter = 9168 S.getSourceManager().getCharacterData(CC)[0]; 9169 if (FirstContextCharacter == '{') 9170 return false; 9171 } 9172 9173 return true; 9174 } 9175 9176 void CheckImplicitConversion(Sema &S, Expr *E, QualType T, 9177 SourceLocation CC, bool *ICContext = nullptr) { 9178 if (E->isTypeDependent() || E->isValueDependent()) return; 9179 9180 const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 9181 const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 9182 if (Source == Target) return; 9183 if (Target->isDependentType()) return; 9184 9185 // If the conversion context location is invalid don't complain. We also 9186 // don't want to emit a warning if the issue occurs from the expansion of 9187 // a system macro. The problem is that 'getSpellingLoc()' is slow, so we 9188 // delay this check as long as possible. Once we detect we are in that 9189 // scenario, we just return. 9190 if (CC.isInvalid()) 9191 return; 9192 9193 // Diagnose implicit casts to bool. 9194 if (Target->isSpecificBuiltinType(BuiltinType::Bool)) { 9195 if (isa<StringLiteral>(E)) 9196 // Warn on string literal to bool. Checks for string literals in logical 9197 // and expressions, for instance, assert(0 && "error here"), are 9198 // prevented by a check in AnalyzeImplicitConversions(). 9199 return DiagnoseImpCast(S, E, T, CC, 9200 diag::warn_impcast_string_literal_to_bool); 9201 if (isa<ObjCStringLiteral>(E) || isa<ObjCArrayLiteral>(E) || 9202 isa<ObjCDictionaryLiteral>(E) || isa<ObjCBoxedExpr>(E)) { 9203 // This covers the literal expressions that evaluate to Objective-C 9204 // objects. 9205 return DiagnoseImpCast(S, E, T, CC, 9206 diag::warn_impcast_objective_c_literal_to_bool); 9207 } 9208 if (Source->isPointerType() || Source->canDecayToPointerType()) { 9209 // Warn on pointer to bool conversion that is always true. 9210 S.DiagnoseAlwaysNonNullPointer(E, Expr::NPCK_NotNull, /*IsEqual*/ false, 9211 SourceRange(CC)); 9212 } 9213 } 9214 9215 // Check implicit casts from Objective-C collection literals to specialized 9216 // collection types, e.g., NSArray<NSString *> *. 9217 if (auto *ArrayLiteral = dyn_cast<ObjCArrayLiteral>(E)) 9218 checkObjCArrayLiteral(S, QualType(Target, 0), ArrayLiteral); 9219 else if (auto *DictionaryLiteral = dyn_cast<ObjCDictionaryLiteral>(E)) 9220 checkObjCDictionaryLiteral(S, QualType(Target, 0), DictionaryLiteral); 9221 9222 // Strip vector types. 9223 if (isa<VectorType>(Source)) { 9224 if (!isa<VectorType>(Target)) { 9225 if (S.SourceMgr.isInSystemMacro(CC)) 9226 return; 9227 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 9228 } 9229 9230 // If the vector cast is cast between two vectors of the same size, it is 9231 // a bitcast, not a conversion. 9232 if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target)) 9233 return; 9234 9235 Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 9236 Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 9237 } 9238 if (auto VecTy = dyn_cast<VectorType>(Target)) 9239 Target = VecTy->getElementType().getTypePtr(); 9240 9241 // Strip complex types. 9242 if (isa<ComplexType>(Source)) { 9243 if (!isa<ComplexType>(Target)) { 9244 if (S.SourceMgr.isInSystemMacro(CC)) 9245 return; 9246 9247 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 9248 } 9249 9250 Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 9251 Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 9252 } 9253 9254 const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 9255 const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 9256 9257 // If the source is floating point... 9258 if (SourceBT && SourceBT->isFloatingPoint()) { 9259 // ...and the target is floating point... 9260 if (TargetBT && TargetBT->isFloatingPoint()) { 9261 // ...then warn if we're dropping FP rank. 9262 9263 // Builtin FP kinds are ordered by increasing FP rank. 9264 if (SourceBT->getKind() > TargetBT->getKind()) { 9265 // Don't warn about float constants that are precisely 9266 // representable in the target type. 9267 Expr::EvalResult result; 9268 if (E->EvaluateAsRValue(result, S.Context)) { 9269 // Value might be a float, a float vector, or a float complex. 9270 if (IsSameFloatAfterCast(result.Val, 9271 S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 9272 S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 9273 return; 9274 } 9275 9276 if (S.SourceMgr.isInSystemMacro(CC)) 9277 return; 9278 9279 DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 9280 } 9281 // ... or possibly if we're increasing rank, too 9282 else if (TargetBT->getKind() > SourceBT->getKind()) { 9283 if (S.SourceMgr.isInSystemMacro(CC)) 9284 return; 9285 9286 DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_double_promotion); 9287 } 9288 return; 9289 } 9290 9291 // If the target is integral, always warn. 9292 if (TargetBT && TargetBT->isInteger()) { 9293 if (S.SourceMgr.isInSystemMacro(CC)) 9294 return; 9295 9296 DiagnoseFloatingImpCast(S, E, T, CC); 9297 } 9298 9299 // Detect the case where a call result is converted from floating-point to 9300 // to bool, and the final argument to the call is converted from bool, to 9301 // discover this typo: 9302 // 9303 // bool b = fabs(x < 1.0); // should be "bool b = fabs(x) < 1.0;" 9304 // 9305 // FIXME: This is an incredibly special case; is there some more general 9306 // way to detect this class of misplaced-parentheses bug? 9307 if (Target->isBooleanType() && isa<CallExpr>(E)) { 9308 // Check last argument of function call to see if it is an 9309 // implicit cast from a type matching the type the result 9310 // is being cast to. 9311 CallExpr *CEx = cast<CallExpr>(E); 9312 if (unsigned NumArgs = CEx->getNumArgs()) { 9313 Expr *LastA = CEx->getArg(NumArgs - 1); 9314 Expr *InnerE = LastA->IgnoreParenImpCasts(); 9315 if (isa<ImplicitCastExpr>(LastA) && 9316 InnerE->getType()->isBooleanType()) { 9317 // Warn on this floating-point to bool conversion 9318 DiagnoseImpCast(S, E, T, CC, 9319 diag::warn_impcast_floating_point_to_bool); 9320 } 9321 } 9322 } 9323 return; 9324 } 9325 9326 DiagnoseNullConversion(S, E, T, CC); 9327 9328 S.DiscardMisalignedMemberAddress(Target, E); 9329 9330 if (!Source->isIntegerType() || !Target->isIntegerType()) 9331 return; 9332 9333 // TODO: remove this early return once the false positives for constant->bool 9334 // in templates, macros, etc, are reduced or removed. 9335 if (Target->isSpecificBuiltinType(BuiltinType::Bool)) 9336 return; 9337 9338 IntRange SourceRange = GetExprRange(S.Context, E); 9339 IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 9340 9341 if (SourceRange.Width > TargetRange.Width) { 9342 // If the source is a constant, use a default-on diagnostic. 9343 // TODO: this should happen for bitfield stores, too. 9344 llvm::APSInt Value(32); 9345 if (E->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects)) { 9346 if (S.SourceMgr.isInSystemMacro(CC)) 9347 return; 9348 9349 std::string PrettySourceValue = Value.toString(10); 9350 std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 9351 9352 S.DiagRuntimeBehavior(E->getExprLoc(), E, 9353 S.PDiag(diag::warn_impcast_integer_precision_constant) 9354 << PrettySourceValue << PrettyTargetValue 9355 << E->getType() << T << E->getSourceRange() 9356 << clang::SourceRange(CC)); 9357 return; 9358 } 9359 9360 // People want to build with -Wshorten-64-to-32 and not -Wconversion. 9361 if (S.SourceMgr.isInSystemMacro(CC)) 9362 return; 9363 9364 if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64) 9365 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32, 9366 /* pruneControlFlow */ true); 9367 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 9368 } 9369 9370 if (TargetRange.Width == SourceRange.Width && !TargetRange.NonNegative && 9371 SourceRange.NonNegative && Source->isSignedIntegerType()) { 9372 // Warn when doing a signed to signed conversion, warn if the positive 9373 // source value is exactly the width of the target type, which will 9374 // cause a negative value to be stored. 9375 9376 llvm::APSInt Value; 9377 if (E->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects) && 9378 !S.SourceMgr.isInSystemMacro(CC)) { 9379 if (isSameWidthConstantConversion(S, E, T, CC)) { 9380 std::string PrettySourceValue = Value.toString(10); 9381 std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 9382 9383 S.DiagRuntimeBehavior( 9384 E->getExprLoc(), E, 9385 S.PDiag(diag::warn_impcast_integer_precision_constant) 9386 << PrettySourceValue << PrettyTargetValue << E->getType() << T 9387 << E->getSourceRange() << clang::SourceRange(CC)); 9388 return; 9389 } 9390 } 9391 9392 // Fall through for non-constants to give a sign conversion warning. 9393 } 9394 9395 if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 9396 (!TargetRange.NonNegative && SourceRange.NonNegative && 9397 SourceRange.Width == TargetRange.Width)) { 9398 if (S.SourceMgr.isInSystemMacro(CC)) 9399 return; 9400 9401 unsigned DiagID = diag::warn_impcast_integer_sign; 9402 9403 // Traditionally, gcc has warned about this under -Wsign-compare. 9404 // We also want to warn about it in -Wconversion. 9405 // So if -Wconversion is off, use a completely identical diagnostic 9406 // in the sign-compare group. 9407 // The conditional-checking code will 9408 if (ICContext) { 9409 DiagID = diag::warn_impcast_integer_sign_conditional; 9410 *ICContext = true; 9411 } 9412 9413 return DiagnoseImpCast(S, E, T, CC, DiagID); 9414 } 9415 9416 // Diagnose conversions between different enumeration types. 9417 // In C, we pretend that the type of an EnumConstantDecl is its enumeration 9418 // type, to give us better diagnostics. 9419 QualType SourceType = E->getType(); 9420 if (!S.getLangOpts().CPlusPlus) { 9421 if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 9422 if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 9423 EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 9424 SourceType = S.Context.getTypeDeclType(Enum); 9425 Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 9426 } 9427 } 9428 9429 if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 9430 if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 9431 if (SourceEnum->getDecl()->hasNameForLinkage() && 9432 TargetEnum->getDecl()->hasNameForLinkage() && 9433 SourceEnum != TargetEnum) { 9434 if (S.SourceMgr.isInSystemMacro(CC)) 9435 return; 9436 9437 return DiagnoseImpCast(S, E, SourceType, T, CC, 9438 diag::warn_impcast_different_enum_types); 9439 } 9440 } 9441 9442 void CheckConditionalOperator(Sema &S, ConditionalOperator *E, 9443 SourceLocation CC, QualType T); 9444 9445 void CheckConditionalOperand(Sema &S, Expr *E, QualType T, 9446 SourceLocation CC, bool &ICContext) { 9447 E = E->IgnoreParenImpCasts(); 9448 9449 if (isa<ConditionalOperator>(E)) 9450 return CheckConditionalOperator(S, cast<ConditionalOperator>(E), CC, T); 9451 9452 AnalyzeImplicitConversions(S, E, CC); 9453 if (E->getType() != T) 9454 return CheckImplicitConversion(S, E, T, CC, &ICContext); 9455 } 9456 9457 void CheckConditionalOperator(Sema &S, ConditionalOperator *E, 9458 SourceLocation CC, QualType T) { 9459 AnalyzeImplicitConversions(S, E->getCond(), E->getQuestionLoc()); 9460 9461 bool Suspicious = false; 9462 CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 9463 CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 9464 9465 // If -Wconversion would have warned about either of the candidates 9466 // for a signedness conversion to the context type... 9467 if (!Suspicious) return; 9468 9469 // ...but it's currently ignored... 9470 if (!S.Diags.isIgnored(diag::warn_impcast_integer_sign_conditional, CC)) 9471 return; 9472 9473 // ...then check whether it would have warned about either of the 9474 // candidates for a signedness conversion to the condition type. 9475 if (E->getType() == T) return; 9476 9477 Suspicious = false; 9478 CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 9479 E->getType(), CC, &Suspicious); 9480 if (!Suspicious) 9481 CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 9482 E->getType(), CC, &Suspicious); 9483 } 9484 9485 /// CheckBoolLikeConversion - Check conversion of given expression to boolean. 9486 /// Input argument E is a logical expression. 9487 void CheckBoolLikeConversion(Sema &S, Expr *E, SourceLocation CC) { 9488 if (S.getLangOpts().Bool) 9489 return; 9490 CheckImplicitConversion(S, E->IgnoreParenImpCasts(), S.Context.BoolTy, CC); 9491 } 9492 9493 /// AnalyzeImplicitConversions - Find and report any interesting 9494 /// implicit conversions in the given expression. There are a couple 9495 /// of competing diagnostics here, -Wconversion and -Wsign-compare. 9496 void AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 9497 QualType T = OrigE->getType(); 9498 Expr *E = OrigE->IgnoreParenImpCasts(); 9499 9500 if (E->isTypeDependent() || E->isValueDependent()) 9501 return; 9502 9503 // For conditional operators, we analyze the arguments as if they 9504 // were being fed directly into the output. 9505 if (isa<ConditionalOperator>(E)) { 9506 ConditionalOperator *CO = cast<ConditionalOperator>(E); 9507 CheckConditionalOperator(S, CO, CC, T); 9508 return; 9509 } 9510 9511 // Check implicit argument conversions for function calls. 9512 if (CallExpr *Call = dyn_cast<CallExpr>(E)) 9513 CheckImplicitArgumentConversions(S, Call, CC); 9514 9515 // Go ahead and check any implicit conversions we might have skipped. 9516 // The non-canonical typecheck is just an optimization; 9517 // CheckImplicitConversion will filter out dead implicit conversions. 9518 if (E->getType() != T) 9519 CheckImplicitConversion(S, E, T, CC); 9520 9521 // Now continue drilling into this expression. 9522 9523 if (PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(E)) { 9524 // The bound subexpressions in a PseudoObjectExpr are not reachable 9525 // as transitive children. 9526 // FIXME: Use a more uniform representation for this. 9527 for (auto *SE : POE->semantics()) 9528 if (auto *OVE = dyn_cast<OpaqueValueExpr>(SE)) 9529 AnalyzeImplicitConversions(S, OVE->getSourceExpr(), CC); 9530 } 9531 9532 // Skip past explicit casts. 9533 if (isa<ExplicitCastExpr>(E)) { 9534 E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 9535 return AnalyzeImplicitConversions(S, E, CC); 9536 } 9537 9538 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 9539 // Do a somewhat different check with comparison operators. 9540 if (BO->isComparisonOp()) 9541 return AnalyzeComparison(S, BO); 9542 9543 // And with simple assignments. 9544 if (BO->getOpcode() == BO_Assign) 9545 return AnalyzeAssignment(S, BO); 9546 } 9547 9548 // These break the otherwise-useful invariant below. Fortunately, 9549 // we don't really need to recurse into them, because any internal 9550 // expressions should have been analyzed already when they were 9551 // built into statements. 9552 if (isa<StmtExpr>(E)) return; 9553 9554 // Don't descend into unevaluated contexts. 9555 if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 9556 9557 // Now just recurse over the expression's children. 9558 CC = E->getExprLoc(); 9559 BinaryOperator *BO = dyn_cast<BinaryOperator>(E); 9560 bool IsLogicalAndOperator = BO && BO->getOpcode() == BO_LAnd; 9561 for (Stmt *SubStmt : E->children()) { 9562 Expr *ChildExpr = dyn_cast_or_null<Expr>(SubStmt); 9563 if (!ChildExpr) 9564 continue; 9565 9566 if (IsLogicalAndOperator && 9567 isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts())) 9568 // Ignore checking string literals that are in logical and operators. 9569 // This is a common pattern for asserts. 9570 continue; 9571 AnalyzeImplicitConversions(S, ChildExpr, CC); 9572 } 9573 9574 if (BO && BO->isLogicalOp()) { 9575 Expr *SubExpr = BO->getLHS()->IgnoreParenImpCasts(); 9576 if (!IsLogicalAndOperator || !isa<StringLiteral>(SubExpr)) 9577 ::CheckBoolLikeConversion(S, SubExpr, BO->getExprLoc()); 9578 9579 SubExpr = BO->getRHS()->IgnoreParenImpCasts(); 9580 if (!IsLogicalAndOperator || !isa<StringLiteral>(SubExpr)) 9581 ::CheckBoolLikeConversion(S, SubExpr, BO->getExprLoc()); 9582 } 9583 9584 if (const UnaryOperator *U = dyn_cast<UnaryOperator>(E)) 9585 if (U->getOpcode() == UO_LNot) 9586 ::CheckBoolLikeConversion(S, U->getSubExpr(), CC); 9587 } 9588 9589 } // end anonymous namespace 9590 9591 /// Diagnose integer type and any valid implicit convertion to it. 9592 static bool checkOpenCLEnqueueIntType(Sema &S, Expr *E, const QualType &IntT) { 9593 // Taking into account implicit conversions, 9594 // allow any integer. 9595 if (!E->getType()->isIntegerType()) { 9596 S.Diag(E->getLocStart(), 9597 diag::err_opencl_enqueue_kernel_invalid_local_size_type); 9598 return true; 9599 } 9600 // Potentially emit standard warnings for implicit conversions if enabled 9601 // using -Wconversion. 9602 CheckImplicitConversion(S, E, IntT, E->getLocStart()); 9603 return false; 9604 } 9605 9606 // Helper function for Sema::DiagnoseAlwaysNonNullPointer. 9607 // Returns true when emitting a warning about taking the address of a reference. 9608 static bool CheckForReference(Sema &SemaRef, const Expr *E, 9609 const PartialDiagnostic &PD) { 9610 E = E->IgnoreParenImpCasts(); 9611 9612 const FunctionDecl *FD = nullptr; 9613 9614 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) { 9615 if (!DRE->getDecl()->getType()->isReferenceType()) 9616 return false; 9617 } else if (const MemberExpr *M = dyn_cast<MemberExpr>(E)) { 9618 if (!M->getMemberDecl()->getType()->isReferenceType()) 9619 return false; 9620 } else if (const CallExpr *Call = dyn_cast<CallExpr>(E)) { 9621 if (!Call->getCallReturnType(SemaRef.Context)->isReferenceType()) 9622 return false; 9623 FD = Call->getDirectCallee(); 9624 } else { 9625 return false; 9626 } 9627 9628 SemaRef.Diag(E->getExprLoc(), PD); 9629 9630 // If possible, point to location of function. 9631 if (FD) { 9632 SemaRef.Diag(FD->getLocation(), diag::note_reference_is_return_value) << FD; 9633 } 9634 9635 return true; 9636 } 9637 9638 // Returns true if the SourceLocation is expanded from any macro body. 9639 // Returns false if the SourceLocation is invalid, is from not in a macro 9640 // expansion, or is from expanded from a top-level macro argument. 9641 static bool IsInAnyMacroBody(const SourceManager &SM, SourceLocation Loc) { 9642 if (Loc.isInvalid()) 9643 return false; 9644 9645 while (Loc.isMacroID()) { 9646 if (SM.isMacroBodyExpansion(Loc)) 9647 return true; 9648 Loc = SM.getImmediateMacroCallerLoc(Loc); 9649 } 9650 9651 return false; 9652 } 9653 9654 /// \brief Diagnose pointers that are always non-null. 9655 /// \param E the expression containing the pointer 9656 /// \param NullKind NPCK_NotNull if E is a cast to bool, otherwise, E is 9657 /// compared to a null pointer 9658 /// \param IsEqual True when the comparison is equal to a null pointer 9659 /// \param Range Extra SourceRange to highlight in the diagnostic 9660 void Sema::DiagnoseAlwaysNonNullPointer(Expr *E, 9661 Expr::NullPointerConstantKind NullKind, 9662 bool IsEqual, SourceRange Range) { 9663 if (!E) 9664 return; 9665 9666 // Don't warn inside macros. 9667 if (E->getExprLoc().isMacroID()) { 9668 const SourceManager &SM = getSourceManager(); 9669 if (IsInAnyMacroBody(SM, E->getExprLoc()) || 9670 IsInAnyMacroBody(SM, Range.getBegin())) 9671 return; 9672 } 9673 E = E->IgnoreImpCasts(); 9674 9675 const bool IsCompare = NullKind != Expr::NPCK_NotNull; 9676 9677 if (isa<CXXThisExpr>(E)) { 9678 unsigned DiagID = IsCompare ? diag::warn_this_null_compare 9679 : diag::warn_this_bool_conversion; 9680 Diag(E->getExprLoc(), DiagID) << E->getSourceRange() << Range << IsEqual; 9681 return; 9682 } 9683 9684 bool IsAddressOf = false; 9685 9686 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 9687 if (UO->getOpcode() != UO_AddrOf) 9688 return; 9689 IsAddressOf = true; 9690 E = UO->getSubExpr(); 9691 } 9692 9693 if (IsAddressOf) { 9694 unsigned DiagID = IsCompare 9695 ? diag::warn_address_of_reference_null_compare 9696 : diag::warn_address_of_reference_bool_conversion; 9697 PartialDiagnostic PD = PDiag(DiagID) << E->getSourceRange() << Range 9698 << IsEqual; 9699 if (CheckForReference(*this, E, PD)) { 9700 return; 9701 } 9702 } 9703 9704 auto ComplainAboutNonnullParamOrCall = [&](const Attr *NonnullAttr) { 9705 bool IsParam = isa<NonNullAttr>(NonnullAttr); 9706 std::string Str; 9707 llvm::raw_string_ostream S(Str); 9708 E->printPretty(S, nullptr, getPrintingPolicy()); 9709 unsigned DiagID = IsCompare ? diag::warn_nonnull_expr_compare 9710 : diag::warn_cast_nonnull_to_bool; 9711 Diag(E->getExprLoc(), DiagID) << IsParam << S.str() 9712 << E->getSourceRange() << Range << IsEqual; 9713 Diag(NonnullAttr->getLocation(), diag::note_declared_nonnull) << IsParam; 9714 }; 9715 9716 // If we have a CallExpr that is tagged with returns_nonnull, we can complain. 9717 if (auto *Call = dyn_cast<CallExpr>(E->IgnoreParenImpCasts())) { 9718 if (auto *Callee = Call->getDirectCallee()) { 9719 if (const Attr *A = Callee->getAttr<ReturnsNonNullAttr>()) { 9720 ComplainAboutNonnullParamOrCall(A); 9721 return; 9722 } 9723 } 9724 } 9725 9726 // Expect to find a single Decl. Skip anything more complicated. 9727 ValueDecl *D = nullptr; 9728 if (DeclRefExpr *R = dyn_cast<DeclRefExpr>(E)) { 9729 D = R->getDecl(); 9730 } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) { 9731 D = M->getMemberDecl(); 9732 } 9733 9734 // Weak Decls can be null. 9735 if (!D || D->isWeak()) 9736 return; 9737 9738 // Check for parameter decl with nonnull attribute 9739 if (const auto* PV = dyn_cast<ParmVarDecl>(D)) { 9740 if (getCurFunction() && 9741 !getCurFunction()->ModifiedNonNullParams.count(PV)) { 9742 if (const Attr *A = PV->getAttr<NonNullAttr>()) { 9743 ComplainAboutNonnullParamOrCall(A); 9744 return; 9745 } 9746 9747 if (const auto *FD = dyn_cast<FunctionDecl>(PV->getDeclContext())) { 9748 auto ParamIter = llvm::find(FD->parameters(), PV); 9749 assert(ParamIter != FD->param_end()); 9750 unsigned ParamNo = std::distance(FD->param_begin(), ParamIter); 9751 9752 for (const auto *NonNull : FD->specific_attrs<NonNullAttr>()) { 9753 if (!NonNull->args_size()) { 9754 ComplainAboutNonnullParamOrCall(NonNull); 9755 return; 9756 } 9757 9758 for (unsigned ArgNo : NonNull->args()) { 9759 if (ArgNo == ParamNo) { 9760 ComplainAboutNonnullParamOrCall(NonNull); 9761 return; 9762 } 9763 } 9764 } 9765 } 9766 } 9767 } 9768 9769 QualType T = D->getType(); 9770 const bool IsArray = T->isArrayType(); 9771 const bool IsFunction = T->isFunctionType(); 9772 9773 // Address of function is used to silence the function warning. 9774 if (IsAddressOf && IsFunction) { 9775 return; 9776 } 9777 9778 // Found nothing. 9779 if (!IsAddressOf && !IsFunction && !IsArray) 9780 return; 9781 9782 // Pretty print the expression for the diagnostic. 9783 std::string Str; 9784 llvm::raw_string_ostream S(Str); 9785 E->printPretty(S, nullptr, getPrintingPolicy()); 9786 9787 unsigned DiagID = IsCompare ? diag::warn_null_pointer_compare 9788 : diag::warn_impcast_pointer_to_bool; 9789 enum { 9790 AddressOf, 9791 FunctionPointer, 9792 ArrayPointer 9793 } DiagType; 9794 if (IsAddressOf) 9795 DiagType = AddressOf; 9796 else if (IsFunction) 9797 DiagType = FunctionPointer; 9798 else if (IsArray) 9799 DiagType = ArrayPointer; 9800 else 9801 llvm_unreachable("Could not determine diagnostic."); 9802 Diag(E->getExprLoc(), DiagID) << DiagType << S.str() << E->getSourceRange() 9803 << Range << IsEqual; 9804 9805 if (!IsFunction) 9806 return; 9807 9808 // Suggest '&' to silence the function warning. 9809 Diag(E->getExprLoc(), diag::note_function_warning_silence) 9810 << FixItHint::CreateInsertion(E->getLocStart(), "&"); 9811 9812 // Check to see if '()' fixit should be emitted. 9813 QualType ReturnType; 9814 UnresolvedSet<4> NonTemplateOverloads; 9815 tryExprAsCall(*E, ReturnType, NonTemplateOverloads); 9816 if (ReturnType.isNull()) 9817 return; 9818 9819 if (IsCompare) { 9820 // There are two cases here. If there is null constant, the only suggest 9821 // for a pointer return type. If the null is 0, then suggest if the return 9822 // type is a pointer or an integer type. 9823 if (!ReturnType->isPointerType()) { 9824 if (NullKind == Expr::NPCK_ZeroExpression || 9825 NullKind == Expr::NPCK_ZeroLiteral) { 9826 if (!ReturnType->isIntegerType()) 9827 return; 9828 } else { 9829 return; 9830 } 9831 } 9832 } else { // !IsCompare 9833 // For function to bool, only suggest if the function pointer has bool 9834 // return type. 9835 if (!ReturnType->isSpecificBuiltinType(BuiltinType::Bool)) 9836 return; 9837 } 9838 Diag(E->getExprLoc(), diag::note_function_to_function_call) 9839 << FixItHint::CreateInsertion(getLocForEndOfToken(E->getLocEnd()), "()"); 9840 } 9841 9842 /// Diagnoses "dangerous" implicit conversions within the given 9843 /// expression (which is a full expression). Implements -Wconversion 9844 /// and -Wsign-compare. 9845 /// 9846 /// \param CC the "context" location of the implicit conversion, i.e. 9847 /// the most location of the syntactic entity requiring the implicit 9848 /// conversion 9849 void Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 9850 // Don't diagnose in unevaluated contexts. 9851 if (isUnevaluatedContext()) 9852 return; 9853 9854 // Don't diagnose for value- or type-dependent expressions. 9855 if (E->isTypeDependent() || E->isValueDependent()) 9856 return; 9857 9858 // Check for array bounds violations in cases where the check isn't triggered 9859 // elsewhere for other Expr types (like BinaryOperators), e.g. when an 9860 // ArraySubscriptExpr is on the RHS of a variable initialization. 9861 CheckArrayAccess(E); 9862 9863 // This is not the right CC for (e.g.) a variable initialization. 9864 AnalyzeImplicitConversions(*this, E, CC); 9865 } 9866 9867 /// CheckBoolLikeConversion - Check conversion of given expression to boolean. 9868 /// Input argument E is a logical expression. 9869 void Sema::CheckBoolLikeConversion(Expr *E, SourceLocation CC) { 9870 ::CheckBoolLikeConversion(*this, E, CC); 9871 } 9872 9873 namespace { 9874 /// \brief Visitor for expressions which looks for unsequenced operations on the 9875 /// same object. 9876 class SequenceChecker : public EvaluatedExprVisitor<SequenceChecker> { 9877 typedef EvaluatedExprVisitor<SequenceChecker> Base; 9878 9879 /// \brief A tree of sequenced regions within an expression. Two regions are 9880 /// unsequenced if one is an ancestor or a descendent of the other. When we 9881 /// finish processing an expression with sequencing, such as a comma 9882 /// expression, we fold its tree nodes into its parent, since they are 9883 /// unsequenced with respect to nodes we will visit later. 9884 class SequenceTree { 9885 struct Value { 9886 explicit Value(unsigned Parent) : Parent(Parent), Merged(false) {} 9887 unsigned Parent : 31; 9888 unsigned Merged : 1; 9889 }; 9890 SmallVector<Value, 8> Values; 9891 9892 public: 9893 /// \brief A region within an expression which may be sequenced with respect 9894 /// to some other region. 9895 class Seq { 9896 explicit Seq(unsigned N) : Index(N) {} 9897 unsigned Index; 9898 friend class SequenceTree; 9899 public: 9900 Seq() : Index(0) {} 9901 }; 9902 9903 SequenceTree() { Values.push_back(Value(0)); } 9904 Seq root() const { return Seq(0); } 9905 9906 /// \brief Create a new sequence of operations, which is an unsequenced 9907 /// subset of \p Parent. This sequence of operations is sequenced with 9908 /// respect to other children of \p Parent. 9909 Seq allocate(Seq Parent) { 9910 Values.push_back(Value(Parent.Index)); 9911 return Seq(Values.size() - 1); 9912 } 9913 9914 /// \brief Merge a sequence of operations into its parent. 9915 void merge(Seq S) { 9916 Values[S.Index].Merged = true; 9917 } 9918 9919 /// \brief Determine whether two operations are unsequenced. This operation 9920 /// is asymmetric: \p Cur should be the more recent sequence, and \p Old 9921 /// should have been merged into its parent as appropriate. 9922 bool isUnsequenced(Seq Cur, Seq Old) { 9923 unsigned C = representative(Cur.Index); 9924 unsigned Target = representative(Old.Index); 9925 while (C >= Target) { 9926 if (C == Target) 9927 return true; 9928 C = Values[C].Parent; 9929 } 9930 return false; 9931 } 9932 9933 private: 9934 /// \brief Pick a representative for a sequence. 9935 unsigned representative(unsigned K) { 9936 if (Values[K].Merged) 9937 // Perform path compression as we go. 9938 return Values[K].Parent = representative(Values[K].Parent); 9939 return K; 9940 } 9941 }; 9942 9943 /// An object for which we can track unsequenced uses. 9944 typedef NamedDecl *Object; 9945 9946 /// Different flavors of object usage which we track. We only track the 9947 /// least-sequenced usage of each kind. 9948 enum UsageKind { 9949 /// A read of an object. Multiple unsequenced reads are OK. 9950 UK_Use, 9951 /// A modification of an object which is sequenced before the value 9952 /// computation of the expression, such as ++n in C++. 9953 UK_ModAsValue, 9954 /// A modification of an object which is not sequenced before the value 9955 /// computation of the expression, such as n++. 9956 UK_ModAsSideEffect, 9957 9958 UK_Count = UK_ModAsSideEffect + 1 9959 }; 9960 9961 struct Usage { 9962 Usage() : Use(nullptr), Seq() {} 9963 Expr *Use; 9964 SequenceTree::Seq Seq; 9965 }; 9966 9967 struct UsageInfo { 9968 UsageInfo() : Diagnosed(false) {} 9969 Usage Uses[UK_Count]; 9970 /// Have we issued a diagnostic for this variable already? 9971 bool Diagnosed; 9972 }; 9973 typedef llvm::SmallDenseMap<Object, UsageInfo, 16> UsageInfoMap; 9974 9975 Sema &SemaRef; 9976 /// Sequenced regions within the expression. 9977 SequenceTree Tree; 9978 /// Declaration modifications and references which we have seen. 9979 UsageInfoMap UsageMap; 9980 /// The region we are currently within. 9981 SequenceTree::Seq Region; 9982 /// Filled in with declarations which were modified as a side-effect 9983 /// (that is, post-increment operations). 9984 SmallVectorImpl<std::pair<Object, Usage> > *ModAsSideEffect; 9985 /// Expressions to check later. We defer checking these to reduce 9986 /// stack usage. 9987 SmallVectorImpl<Expr *> &WorkList; 9988 9989 /// RAII object wrapping the visitation of a sequenced subexpression of an 9990 /// expression. At the end of this process, the side-effects of the evaluation 9991 /// become sequenced with respect to the value computation of the result, so 9992 /// we downgrade any UK_ModAsSideEffect within the evaluation to 9993 /// UK_ModAsValue. 9994 struct SequencedSubexpression { 9995 SequencedSubexpression(SequenceChecker &Self) 9996 : Self(Self), OldModAsSideEffect(Self.ModAsSideEffect) { 9997 Self.ModAsSideEffect = &ModAsSideEffect; 9998 } 9999 ~SequencedSubexpression() { 10000 for (auto &M : llvm::reverse(ModAsSideEffect)) { 10001 UsageInfo &U = Self.UsageMap[M.first]; 10002 auto &SideEffectUsage = U.Uses[UK_ModAsSideEffect]; 10003 Self.addUsage(U, M.first, SideEffectUsage.Use, UK_ModAsValue); 10004 SideEffectUsage = M.second; 10005 } 10006 Self.ModAsSideEffect = OldModAsSideEffect; 10007 } 10008 10009 SequenceChecker &Self; 10010 SmallVector<std::pair<Object, Usage>, 4> ModAsSideEffect; 10011 SmallVectorImpl<std::pair<Object, Usage> > *OldModAsSideEffect; 10012 }; 10013 10014 /// RAII object wrapping the visitation of a subexpression which we might 10015 /// choose to evaluate as a constant. If any subexpression is evaluated and 10016 /// found to be non-constant, this allows us to suppress the evaluation of 10017 /// the outer expression. 10018 class EvaluationTracker { 10019 public: 10020 EvaluationTracker(SequenceChecker &Self) 10021 : Self(Self), Prev(Self.EvalTracker), EvalOK(true) { 10022 Self.EvalTracker = this; 10023 } 10024 ~EvaluationTracker() { 10025 Self.EvalTracker = Prev; 10026 if (Prev) 10027 Prev->EvalOK &= EvalOK; 10028 } 10029 10030 bool evaluate(const Expr *E, bool &Result) { 10031 if (!EvalOK || E->isValueDependent()) 10032 return false; 10033 EvalOK = E->EvaluateAsBooleanCondition(Result, Self.SemaRef.Context); 10034 return EvalOK; 10035 } 10036 10037 private: 10038 SequenceChecker &Self; 10039 EvaluationTracker *Prev; 10040 bool EvalOK; 10041 } *EvalTracker; 10042 10043 /// \brief Find the object which is produced by the specified expression, 10044 /// if any. 10045 Object getObject(Expr *E, bool Mod) const { 10046 E = E->IgnoreParenCasts(); 10047 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 10048 if (Mod && (UO->getOpcode() == UO_PreInc || UO->getOpcode() == UO_PreDec)) 10049 return getObject(UO->getSubExpr(), Mod); 10050 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 10051 if (BO->getOpcode() == BO_Comma) 10052 return getObject(BO->getRHS(), Mod); 10053 if (Mod && BO->isAssignmentOp()) 10054 return getObject(BO->getLHS(), Mod); 10055 } else if (MemberExpr *ME = dyn_cast<MemberExpr>(E)) { 10056 // FIXME: Check for more interesting cases, like "x.n = ++x.n". 10057 if (isa<CXXThisExpr>(ME->getBase()->IgnoreParenCasts())) 10058 return ME->getMemberDecl(); 10059 } else if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 10060 // FIXME: If this is a reference, map through to its value. 10061 return DRE->getDecl(); 10062 return nullptr; 10063 } 10064 10065 /// \brief Note that an object was modified or used by an expression. 10066 void addUsage(UsageInfo &UI, Object O, Expr *Ref, UsageKind UK) { 10067 Usage &U = UI.Uses[UK]; 10068 if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) { 10069 if (UK == UK_ModAsSideEffect && ModAsSideEffect) 10070 ModAsSideEffect->push_back(std::make_pair(O, U)); 10071 U.Use = Ref; 10072 U.Seq = Region; 10073 } 10074 } 10075 /// \brief Check whether a modification or use conflicts with a prior usage. 10076 void checkUsage(Object O, UsageInfo &UI, Expr *Ref, UsageKind OtherKind, 10077 bool IsModMod) { 10078 if (UI.Diagnosed) 10079 return; 10080 10081 const Usage &U = UI.Uses[OtherKind]; 10082 if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) 10083 return; 10084 10085 Expr *Mod = U.Use; 10086 Expr *ModOrUse = Ref; 10087 if (OtherKind == UK_Use) 10088 std::swap(Mod, ModOrUse); 10089 10090 SemaRef.Diag(Mod->getExprLoc(), 10091 IsModMod ? diag::warn_unsequenced_mod_mod 10092 : diag::warn_unsequenced_mod_use) 10093 << O << SourceRange(ModOrUse->getExprLoc()); 10094 UI.Diagnosed = true; 10095 } 10096 10097 void notePreUse(Object O, Expr *Use) { 10098 UsageInfo &U = UsageMap[O]; 10099 // Uses conflict with other modifications. 10100 checkUsage(O, U, Use, UK_ModAsValue, false); 10101 } 10102 void notePostUse(Object O, Expr *Use) { 10103 UsageInfo &U = UsageMap[O]; 10104 checkUsage(O, U, Use, UK_ModAsSideEffect, false); 10105 addUsage(U, O, Use, UK_Use); 10106 } 10107 10108 void notePreMod(Object O, Expr *Mod) { 10109 UsageInfo &U = UsageMap[O]; 10110 // Modifications conflict with other modifications and with uses. 10111 checkUsage(O, U, Mod, UK_ModAsValue, true); 10112 checkUsage(O, U, Mod, UK_Use, false); 10113 } 10114 void notePostMod(Object O, Expr *Use, UsageKind UK) { 10115 UsageInfo &U = UsageMap[O]; 10116 checkUsage(O, U, Use, UK_ModAsSideEffect, true); 10117 addUsage(U, O, Use, UK); 10118 } 10119 10120 public: 10121 SequenceChecker(Sema &S, Expr *E, SmallVectorImpl<Expr *> &WorkList) 10122 : Base(S.Context), SemaRef(S), Region(Tree.root()), 10123 ModAsSideEffect(nullptr), WorkList(WorkList), EvalTracker(nullptr) { 10124 Visit(E); 10125 } 10126 10127 void VisitStmt(Stmt *S) { 10128 // Skip all statements which aren't expressions for now. 10129 } 10130 10131 void VisitExpr(Expr *E) { 10132 // By default, just recurse to evaluated subexpressions. 10133 Base::VisitStmt(E); 10134 } 10135 10136 void VisitCastExpr(CastExpr *E) { 10137 Object O = Object(); 10138 if (E->getCastKind() == CK_LValueToRValue) 10139 O = getObject(E->getSubExpr(), false); 10140 10141 if (O) 10142 notePreUse(O, E); 10143 VisitExpr(E); 10144 if (O) 10145 notePostUse(O, E); 10146 } 10147 10148 void VisitBinComma(BinaryOperator *BO) { 10149 // C++11 [expr.comma]p1: 10150 // Every value computation and side effect associated with the left 10151 // expression is sequenced before every value computation and side 10152 // effect associated with the right expression. 10153 SequenceTree::Seq LHS = Tree.allocate(Region); 10154 SequenceTree::Seq RHS = Tree.allocate(Region); 10155 SequenceTree::Seq OldRegion = Region; 10156 10157 { 10158 SequencedSubexpression SeqLHS(*this); 10159 Region = LHS; 10160 Visit(BO->getLHS()); 10161 } 10162 10163 Region = RHS; 10164 Visit(BO->getRHS()); 10165 10166 Region = OldRegion; 10167 10168 // Forget that LHS and RHS are sequenced. They are both unsequenced 10169 // with respect to other stuff. 10170 Tree.merge(LHS); 10171 Tree.merge(RHS); 10172 } 10173 10174 void VisitBinAssign(BinaryOperator *BO) { 10175 // The modification is sequenced after the value computation of the LHS 10176 // and RHS, so check it before inspecting the operands and update the 10177 // map afterwards. 10178 Object O = getObject(BO->getLHS(), true); 10179 if (!O) 10180 return VisitExpr(BO); 10181 10182 notePreMod(O, BO); 10183 10184 // C++11 [expr.ass]p7: 10185 // E1 op= E2 is equivalent to E1 = E1 op E2, except that E1 is evaluated 10186 // only once. 10187 // 10188 // Therefore, for a compound assignment operator, O is considered used 10189 // everywhere except within the evaluation of E1 itself. 10190 if (isa<CompoundAssignOperator>(BO)) 10191 notePreUse(O, BO); 10192 10193 Visit(BO->getLHS()); 10194 10195 if (isa<CompoundAssignOperator>(BO)) 10196 notePostUse(O, BO); 10197 10198 Visit(BO->getRHS()); 10199 10200 // C++11 [expr.ass]p1: 10201 // the assignment is sequenced [...] before the value computation of the 10202 // assignment expression. 10203 // C11 6.5.16/3 has no such rule. 10204 notePostMod(O, BO, SemaRef.getLangOpts().CPlusPlus ? UK_ModAsValue 10205 : UK_ModAsSideEffect); 10206 } 10207 10208 void VisitCompoundAssignOperator(CompoundAssignOperator *CAO) { 10209 VisitBinAssign(CAO); 10210 } 10211 10212 void VisitUnaryPreInc(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); } 10213 void VisitUnaryPreDec(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); } 10214 void VisitUnaryPreIncDec(UnaryOperator *UO) { 10215 Object O = getObject(UO->getSubExpr(), true); 10216 if (!O) 10217 return VisitExpr(UO); 10218 10219 notePreMod(O, UO); 10220 Visit(UO->getSubExpr()); 10221 // C++11 [expr.pre.incr]p1: 10222 // the expression ++x is equivalent to x+=1 10223 notePostMod(O, UO, SemaRef.getLangOpts().CPlusPlus ? UK_ModAsValue 10224 : UK_ModAsSideEffect); 10225 } 10226 10227 void VisitUnaryPostInc(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); } 10228 void VisitUnaryPostDec(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); } 10229 void VisitUnaryPostIncDec(UnaryOperator *UO) { 10230 Object O = getObject(UO->getSubExpr(), true); 10231 if (!O) 10232 return VisitExpr(UO); 10233 10234 notePreMod(O, UO); 10235 Visit(UO->getSubExpr()); 10236 notePostMod(O, UO, UK_ModAsSideEffect); 10237 } 10238 10239 /// Don't visit the RHS of '&&' or '||' if it might not be evaluated. 10240 void VisitBinLOr(BinaryOperator *BO) { 10241 // The side-effects of the LHS of an '&&' are sequenced before the 10242 // value computation of the RHS, and hence before the value computation 10243 // of the '&&' itself, unless the LHS evaluates to zero. We treat them 10244 // as if they were unconditionally sequenced. 10245 EvaluationTracker Eval(*this); 10246 { 10247 SequencedSubexpression Sequenced(*this); 10248 Visit(BO->getLHS()); 10249 } 10250 10251 bool Result; 10252 if (Eval.evaluate(BO->getLHS(), Result)) { 10253 if (!Result) 10254 Visit(BO->getRHS()); 10255 } else { 10256 // Check for unsequenced operations in the RHS, treating it as an 10257 // entirely separate evaluation. 10258 // 10259 // FIXME: If there are operations in the RHS which are unsequenced 10260 // with respect to operations outside the RHS, and those operations 10261 // are unconditionally evaluated, diagnose them. 10262 WorkList.push_back(BO->getRHS()); 10263 } 10264 } 10265 void VisitBinLAnd(BinaryOperator *BO) { 10266 EvaluationTracker Eval(*this); 10267 { 10268 SequencedSubexpression Sequenced(*this); 10269 Visit(BO->getLHS()); 10270 } 10271 10272 bool Result; 10273 if (Eval.evaluate(BO->getLHS(), Result)) { 10274 if (Result) 10275 Visit(BO->getRHS()); 10276 } else { 10277 WorkList.push_back(BO->getRHS()); 10278 } 10279 } 10280 10281 // Only visit the condition, unless we can be sure which subexpression will 10282 // be chosen. 10283 void VisitAbstractConditionalOperator(AbstractConditionalOperator *CO) { 10284 EvaluationTracker Eval(*this); 10285 { 10286 SequencedSubexpression Sequenced(*this); 10287 Visit(CO->getCond()); 10288 } 10289 10290 bool Result; 10291 if (Eval.evaluate(CO->getCond(), Result)) 10292 Visit(Result ? CO->getTrueExpr() : CO->getFalseExpr()); 10293 else { 10294 WorkList.push_back(CO->getTrueExpr()); 10295 WorkList.push_back(CO->getFalseExpr()); 10296 } 10297 } 10298 10299 void VisitCallExpr(CallExpr *CE) { 10300 // C++11 [intro.execution]p15: 10301 // When calling a function [...], every value computation and side effect 10302 // associated with any argument expression, or with the postfix expression 10303 // designating the called function, is sequenced before execution of every 10304 // expression or statement in the body of the function [and thus before 10305 // the value computation of its result]. 10306 SequencedSubexpression Sequenced(*this); 10307 Base::VisitCallExpr(CE); 10308 10309 // FIXME: CXXNewExpr and CXXDeleteExpr implicitly call functions. 10310 } 10311 10312 void VisitCXXConstructExpr(CXXConstructExpr *CCE) { 10313 // This is a call, so all subexpressions are sequenced before the result. 10314 SequencedSubexpression Sequenced(*this); 10315 10316 if (!CCE->isListInitialization()) 10317 return VisitExpr(CCE); 10318 10319 // In C++11, list initializations are sequenced. 10320 SmallVector<SequenceTree::Seq, 32> Elts; 10321 SequenceTree::Seq Parent = Region; 10322 for (CXXConstructExpr::arg_iterator I = CCE->arg_begin(), 10323 E = CCE->arg_end(); 10324 I != E; ++I) { 10325 Region = Tree.allocate(Parent); 10326 Elts.push_back(Region); 10327 Visit(*I); 10328 } 10329 10330 // Forget that the initializers are sequenced. 10331 Region = Parent; 10332 for (unsigned I = 0; I < Elts.size(); ++I) 10333 Tree.merge(Elts[I]); 10334 } 10335 10336 void VisitInitListExpr(InitListExpr *ILE) { 10337 if (!SemaRef.getLangOpts().CPlusPlus11) 10338 return VisitExpr(ILE); 10339 10340 // In C++11, list initializations are sequenced. 10341 SmallVector<SequenceTree::Seq, 32> Elts; 10342 SequenceTree::Seq Parent = Region; 10343 for (unsigned I = 0; I < ILE->getNumInits(); ++I) { 10344 Expr *E = ILE->getInit(I); 10345 if (!E) continue; 10346 Region = Tree.allocate(Parent); 10347 Elts.push_back(Region); 10348 Visit(E); 10349 } 10350 10351 // Forget that the initializers are sequenced. 10352 Region = Parent; 10353 for (unsigned I = 0; I < Elts.size(); ++I) 10354 Tree.merge(Elts[I]); 10355 } 10356 }; 10357 } // end anonymous namespace 10358 10359 void Sema::CheckUnsequencedOperations(Expr *E) { 10360 SmallVector<Expr *, 8> WorkList; 10361 WorkList.push_back(E); 10362 while (!WorkList.empty()) { 10363 Expr *Item = WorkList.pop_back_val(); 10364 SequenceChecker(*this, Item, WorkList); 10365 } 10366 } 10367 10368 void Sema::CheckCompletedExpr(Expr *E, SourceLocation CheckLoc, 10369 bool IsConstexpr) { 10370 CheckImplicitConversions(E, CheckLoc); 10371 if (!E->isInstantiationDependent()) 10372 CheckUnsequencedOperations(E); 10373 if (!IsConstexpr && !E->isValueDependent()) 10374 E->EvaluateForOverflow(Context); 10375 DiagnoseMisalignedMembers(); 10376 } 10377 10378 void Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 10379 FieldDecl *BitField, 10380 Expr *Init) { 10381 (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 10382 } 10383 10384 static void diagnoseArrayStarInParamType(Sema &S, QualType PType, 10385 SourceLocation Loc) { 10386 if (!PType->isVariablyModifiedType()) 10387 return; 10388 if (const auto *PointerTy = dyn_cast<PointerType>(PType)) { 10389 diagnoseArrayStarInParamType(S, PointerTy->getPointeeType(), Loc); 10390 return; 10391 } 10392 if (const auto *ReferenceTy = dyn_cast<ReferenceType>(PType)) { 10393 diagnoseArrayStarInParamType(S, ReferenceTy->getPointeeType(), Loc); 10394 return; 10395 } 10396 if (const auto *ParenTy = dyn_cast<ParenType>(PType)) { 10397 diagnoseArrayStarInParamType(S, ParenTy->getInnerType(), Loc); 10398 return; 10399 } 10400 10401 const ArrayType *AT = S.Context.getAsArrayType(PType); 10402 if (!AT) 10403 return; 10404 10405 if (AT->getSizeModifier() != ArrayType::Star) { 10406 diagnoseArrayStarInParamType(S, AT->getElementType(), Loc); 10407 return; 10408 } 10409 10410 S.Diag(Loc, diag::err_array_star_in_function_definition); 10411 } 10412 10413 /// CheckParmsForFunctionDef - Check that the parameters of the given 10414 /// function are appropriate for the definition of a function. This 10415 /// takes care of any checks that cannot be performed on the 10416 /// declaration itself, e.g., that the types of each of the function 10417 /// parameters are complete. 10418 bool Sema::CheckParmsForFunctionDef(ArrayRef<ParmVarDecl *> Parameters, 10419 bool CheckParameterNames) { 10420 bool HasInvalidParm = false; 10421 for (ParmVarDecl *Param : Parameters) { 10422 // C99 6.7.5.3p4: the parameters in a parameter type list in a 10423 // function declarator that is part of a function definition of 10424 // that function shall not have incomplete type. 10425 // 10426 // This is also C++ [dcl.fct]p6. 10427 if (!Param->isInvalidDecl() && 10428 RequireCompleteType(Param->getLocation(), Param->getType(), 10429 diag::err_typecheck_decl_incomplete_type)) { 10430 Param->setInvalidDecl(); 10431 HasInvalidParm = true; 10432 } 10433 10434 // C99 6.9.1p5: If the declarator includes a parameter type list, the 10435 // declaration of each parameter shall include an identifier. 10436 if (CheckParameterNames && 10437 Param->getIdentifier() == nullptr && 10438 !Param->isImplicit() && 10439 !getLangOpts().CPlusPlus) 10440 Diag(Param->getLocation(), diag::err_parameter_name_omitted); 10441 10442 // C99 6.7.5.3p12: 10443 // If the function declarator is not part of a definition of that 10444 // function, parameters may have incomplete type and may use the [*] 10445 // notation in their sequences of declarator specifiers to specify 10446 // variable length array types. 10447 QualType PType = Param->getOriginalType(); 10448 // FIXME: This diagnostic should point the '[*]' if source-location 10449 // information is added for it. 10450 diagnoseArrayStarInParamType(*this, PType, Param->getLocation()); 10451 10452 // MSVC destroys objects passed by value in the callee. Therefore a 10453 // function definition which takes such a parameter must be able to call the 10454 // object's destructor. However, we don't perform any direct access check 10455 // on the dtor. 10456 if (getLangOpts().CPlusPlus && Context.getTargetInfo() 10457 .getCXXABI() 10458 .areArgsDestroyedLeftToRightInCallee()) { 10459 if (!Param->isInvalidDecl()) { 10460 if (const RecordType *RT = Param->getType()->getAs<RecordType>()) { 10461 CXXRecordDecl *ClassDecl = cast<CXXRecordDecl>(RT->getDecl()); 10462 if (!ClassDecl->isInvalidDecl() && 10463 !ClassDecl->hasIrrelevantDestructor() && 10464 !ClassDecl->isDependentContext()) { 10465 CXXDestructorDecl *Destructor = LookupDestructor(ClassDecl); 10466 MarkFunctionReferenced(Param->getLocation(), Destructor); 10467 DiagnoseUseOfDecl(Destructor, Param->getLocation()); 10468 } 10469 } 10470 } 10471 } 10472 10473 // Parameters with the pass_object_size attribute only need to be marked 10474 // constant at function definitions. Because we lack information about 10475 // whether we're on a declaration or definition when we're instantiating the 10476 // attribute, we need to check for constness here. 10477 if (const auto *Attr = Param->getAttr<PassObjectSizeAttr>()) 10478 if (!Param->getType().isConstQualified()) 10479 Diag(Param->getLocation(), diag::err_attribute_pointers_only) 10480 << Attr->getSpelling() << 1; 10481 } 10482 10483 return HasInvalidParm; 10484 } 10485 10486 /// A helper function to get the alignment of a Decl referred to by DeclRefExpr 10487 /// or MemberExpr. 10488 static CharUnits getDeclAlign(Expr *E, CharUnits TypeAlign, 10489 ASTContext &Context) { 10490 if (const auto *DRE = dyn_cast<DeclRefExpr>(E)) 10491 return Context.getDeclAlign(DRE->getDecl()); 10492 10493 if (const auto *ME = dyn_cast<MemberExpr>(E)) 10494 return Context.getDeclAlign(ME->getMemberDecl()); 10495 10496 return TypeAlign; 10497 } 10498 10499 /// CheckCastAlign - Implements -Wcast-align, which warns when a 10500 /// pointer cast increases the alignment requirements. 10501 void Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 10502 // This is actually a lot of work to potentially be doing on every 10503 // cast; don't do it if we're ignoring -Wcast_align (as is the default). 10504 if (getDiagnostics().isIgnored(diag::warn_cast_align, TRange.getBegin())) 10505 return; 10506 10507 // Ignore dependent types. 10508 if (T->isDependentType() || Op->getType()->isDependentType()) 10509 return; 10510 10511 // Require that the destination be a pointer type. 10512 const PointerType *DestPtr = T->getAs<PointerType>(); 10513 if (!DestPtr) return; 10514 10515 // If the destination has alignment 1, we're done. 10516 QualType DestPointee = DestPtr->getPointeeType(); 10517 if (DestPointee->isIncompleteType()) return; 10518 CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 10519 if (DestAlign.isOne()) return; 10520 10521 // Require that the source be a pointer type. 10522 const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 10523 if (!SrcPtr) return; 10524 QualType SrcPointee = SrcPtr->getPointeeType(); 10525 10526 // Whitelist casts from cv void*. We already implicitly 10527 // whitelisted casts to cv void*, since they have alignment 1. 10528 // Also whitelist casts involving incomplete types, which implicitly 10529 // includes 'void'. 10530 if (SrcPointee->isIncompleteType()) return; 10531 10532 CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 10533 10534 if (auto *CE = dyn_cast<CastExpr>(Op)) { 10535 if (CE->getCastKind() == CK_ArrayToPointerDecay) 10536 SrcAlign = getDeclAlign(CE->getSubExpr(), SrcAlign, Context); 10537 } else if (auto *UO = dyn_cast<UnaryOperator>(Op)) { 10538 if (UO->getOpcode() == UO_AddrOf) 10539 SrcAlign = getDeclAlign(UO->getSubExpr(), SrcAlign, Context); 10540 } 10541 10542 if (SrcAlign >= DestAlign) return; 10543 10544 Diag(TRange.getBegin(), diag::warn_cast_align) 10545 << Op->getType() << T 10546 << static_cast<unsigned>(SrcAlign.getQuantity()) 10547 << static_cast<unsigned>(DestAlign.getQuantity()) 10548 << TRange << Op->getSourceRange(); 10549 } 10550 10551 /// \brief Check whether this array fits the idiom of a size-one tail padded 10552 /// array member of a struct. 10553 /// 10554 /// We avoid emitting out-of-bounds access warnings for such arrays as they are 10555 /// commonly used to emulate flexible arrays in C89 code. 10556 static bool IsTailPaddedMemberArray(Sema &S, const llvm::APInt &Size, 10557 const NamedDecl *ND) { 10558 if (Size != 1 || !ND) return false; 10559 10560 const FieldDecl *FD = dyn_cast<FieldDecl>(ND); 10561 if (!FD) return false; 10562 10563 // Don't consider sizes resulting from macro expansions or template argument 10564 // substitution to form C89 tail-padded arrays. 10565 10566 TypeSourceInfo *TInfo = FD->getTypeSourceInfo(); 10567 while (TInfo) { 10568 TypeLoc TL = TInfo->getTypeLoc(); 10569 // Look through typedefs. 10570 if (TypedefTypeLoc TTL = TL.getAs<TypedefTypeLoc>()) { 10571 const TypedefNameDecl *TDL = TTL.getTypedefNameDecl(); 10572 TInfo = TDL->getTypeSourceInfo(); 10573 continue; 10574 } 10575 if (ConstantArrayTypeLoc CTL = TL.getAs<ConstantArrayTypeLoc>()) { 10576 const Expr *SizeExpr = dyn_cast<IntegerLiteral>(CTL.getSizeExpr()); 10577 if (!SizeExpr || SizeExpr->getExprLoc().isMacroID()) 10578 return false; 10579 } 10580 break; 10581 } 10582 10583 const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext()); 10584 if (!RD) return false; 10585 if (RD->isUnion()) return false; 10586 if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) { 10587 if (!CRD->isStandardLayout()) return false; 10588 } 10589 10590 // See if this is the last field decl in the record. 10591 const Decl *D = FD; 10592 while ((D = D->getNextDeclInContext())) 10593 if (isa<FieldDecl>(D)) 10594 return false; 10595 return true; 10596 } 10597 10598 void Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr, 10599 const ArraySubscriptExpr *ASE, 10600 bool AllowOnePastEnd, bool IndexNegated) { 10601 IndexExpr = IndexExpr->IgnoreParenImpCasts(); 10602 if (IndexExpr->isValueDependent()) 10603 return; 10604 10605 const Type *EffectiveType = 10606 BaseExpr->getType()->getPointeeOrArrayElementType(); 10607 BaseExpr = BaseExpr->IgnoreParenCasts(); 10608 const ConstantArrayType *ArrayTy = 10609 Context.getAsConstantArrayType(BaseExpr->getType()); 10610 if (!ArrayTy) 10611 return; 10612 10613 llvm::APSInt index; 10614 if (!IndexExpr->EvaluateAsInt(index, Context, Expr::SE_AllowSideEffects)) 10615 return; 10616 if (IndexNegated) 10617 index = -index; 10618 10619 const NamedDecl *ND = nullptr; 10620 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 10621 ND = dyn_cast<NamedDecl>(DRE->getDecl()); 10622 if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 10623 ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 10624 10625 if (index.isUnsigned() || !index.isNegative()) { 10626 llvm::APInt size = ArrayTy->getSize(); 10627 if (!size.isStrictlyPositive()) 10628 return; 10629 10630 const Type *BaseType = BaseExpr->getType()->getPointeeOrArrayElementType(); 10631 if (BaseType != EffectiveType) { 10632 // Make sure we're comparing apples to apples when comparing index to size 10633 uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType); 10634 uint64_t array_typesize = Context.getTypeSize(BaseType); 10635 // Handle ptrarith_typesize being zero, such as when casting to void* 10636 if (!ptrarith_typesize) ptrarith_typesize = 1; 10637 if (ptrarith_typesize != array_typesize) { 10638 // There's a cast to a different size type involved 10639 uint64_t ratio = array_typesize / ptrarith_typesize; 10640 // TODO: Be smarter about handling cases where array_typesize is not a 10641 // multiple of ptrarith_typesize 10642 if (ptrarith_typesize * ratio == array_typesize) 10643 size *= llvm::APInt(size.getBitWidth(), ratio); 10644 } 10645 } 10646 10647 if (size.getBitWidth() > index.getBitWidth()) 10648 index = index.zext(size.getBitWidth()); 10649 else if (size.getBitWidth() < index.getBitWidth()) 10650 size = size.zext(index.getBitWidth()); 10651 10652 // For array subscripting the index must be less than size, but for pointer 10653 // arithmetic also allow the index (offset) to be equal to size since 10654 // computing the next address after the end of the array is legal and 10655 // commonly done e.g. in C++ iterators and range-based for loops. 10656 if (AllowOnePastEnd ? index.ule(size) : index.ult(size)) 10657 return; 10658 10659 // Also don't warn for arrays of size 1 which are members of some 10660 // structure. These are often used to approximate flexible arrays in C89 10661 // code. 10662 if (IsTailPaddedMemberArray(*this, size, ND)) 10663 return; 10664 10665 // Suppress the warning if the subscript expression (as identified by the 10666 // ']' location) and the index expression are both from macro expansions 10667 // within a system header. 10668 if (ASE) { 10669 SourceLocation RBracketLoc = SourceMgr.getSpellingLoc( 10670 ASE->getRBracketLoc()); 10671 if (SourceMgr.isInSystemHeader(RBracketLoc)) { 10672 SourceLocation IndexLoc = SourceMgr.getSpellingLoc( 10673 IndexExpr->getLocStart()); 10674 if (SourceMgr.isWrittenInSameFile(RBracketLoc, IndexLoc)) 10675 return; 10676 } 10677 } 10678 10679 unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds; 10680 if (ASE) 10681 DiagID = diag::warn_array_index_exceeds_bounds; 10682 10683 DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 10684 PDiag(DiagID) << index.toString(10, true) 10685 << size.toString(10, true) 10686 << (unsigned)size.getLimitedValue(~0U) 10687 << IndexExpr->getSourceRange()); 10688 } else { 10689 unsigned DiagID = diag::warn_array_index_precedes_bounds; 10690 if (!ASE) { 10691 DiagID = diag::warn_ptr_arith_precedes_bounds; 10692 if (index.isNegative()) index = -index; 10693 } 10694 10695 DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 10696 PDiag(DiagID) << index.toString(10, true) 10697 << IndexExpr->getSourceRange()); 10698 } 10699 10700 if (!ND) { 10701 // Try harder to find a NamedDecl to point at in the note. 10702 while (const ArraySubscriptExpr *ASE = 10703 dyn_cast<ArraySubscriptExpr>(BaseExpr)) 10704 BaseExpr = ASE->getBase()->IgnoreParenCasts(); 10705 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 10706 ND = dyn_cast<NamedDecl>(DRE->getDecl()); 10707 if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 10708 ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 10709 } 10710 10711 if (ND) 10712 DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 10713 PDiag(diag::note_array_index_out_of_bounds) 10714 << ND->getDeclName()); 10715 } 10716 10717 void Sema::CheckArrayAccess(const Expr *expr) { 10718 int AllowOnePastEnd = 0; 10719 while (expr) { 10720 expr = expr->IgnoreParenImpCasts(); 10721 switch (expr->getStmtClass()) { 10722 case Stmt::ArraySubscriptExprClass: { 10723 const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr); 10724 CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE, 10725 AllowOnePastEnd > 0); 10726 return; 10727 } 10728 case Stmt::OMPArraySectionExprClass: { 10729 const OMPArraySectionExpr *ASE = cast<OMPArraySectionExpr>(expr); 10730 if (ASE->getLowerBound()) 10731 CheckArrayAccess(ASE->getBase(), ASE->getLowerBound(), 10732 /*ASE=*/nullptr, AllowOnePastEnd > 0); 10733 return; 10734 } 10735 case Stmt::UnaryOperatorClass: { 10736 // Only unwrap the * and & unary operators 10737 const UnaryOperator *UO = cast<UnaryOperator>(expr); 10738 expr = UO->getSubExpr(); 10739 switch (UO->getOpcode()) { 10740 case UO_AddrOf: 10741 AllowOnePastEnd++; 10742 break; 10743 case UO_Deref: 10744 AllowOnePastEnd--; 10745 break; 10746 default: 10747 return; 10748 } 10749 break; 10750 } 10751 case Stmt::ConditionalOperatorClass: { 10752 const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 10753 if (const Expr *lhs = cond->getLHS()) 10754 CheckArrayAccess(lhs); 10755 if (const Expr *rhs = cond->getRHS()) 10756 CheckArrayAccess(rhs); 10757 return; 10758 } 10759 case Stmt::CXXOperatorCallExprClass: { 10760 const auto *OCE = cast<CXXOperatorCallExpr>(expr); 10761 for (const auto *Arg : OCE->arguments()) 10762 CheckArrayAccess(Arg); 10763 return; 10764 } 10765 default: 10766 return; 10767 } 10768 } 10769 } 10770 10771 //===--- CHECK: Objective-C retain cycles ----------------------------------// 10772 10773 namespace { 10774 struct RetainCycleOwner { 10775 RetainCycleOwner() : Variable(nullptr), Indirect(false) {} 10776 VarDecl *Variable; 10777 SourceRange Range; 10778 SourceLocation Loc; 10779 bool Indirect; 10780 10781 void setLocsFrom(Expr *e) { 10782 Loc = e->getExprLoc(); 10783 Range = e->getSourceRange(); 10784 } 10785 }; 10786 } // end anonymous namespace 10787 10788 /// Consider whether capturing the given variable can possibly lead to 10789 /// a retain cycle. 10790 static bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) { 10791 // In ARC, it's captured strongly iff the variable has __strong 10792 // lifetime. In MRR, it's captured strongly if the variable is 10793 // __block and has an appropriate type. 10794 if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 10795 return false; 10796 10797 owner.Variable = var; 10798 if (ref) 10799 owner.setLocsFrom(ref); 10800 return true; 10801 } 10802 10803 static bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) { 10804 while (true) { 10805 e = e->IgnoreParens(); 10806 if (CastExpr *cast = dyn_cast<CastExpr>(e)) { 10807 switch (cast->getCastKind()) { 10808 case CK_BitCast: 10809 case CK_LValueBitCast: 10810 case CK_LValueToRValue: 10811 case CK_ARCReclaimReturnedObject: 10812 e = cast->getSubExpr(); 10813 continue; 10814 10815 default: 10816 return false; 10817 } 10818 } 10819 10820 if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) { 10821 ObjCIvarDecl *ivar = ref->getDecl(); 10822 if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 10823 return false; 10824 10825 // Try to find a retain cycle in the base. 10826 if (!findRetainCycleOwner(S, ref->getBase(), owner)) 10827 return false; 10828 10829 if (ref->isFreeIvar()) owner.setLocsFrom(ref); 10830 owner.Indirect = true; 10831 return true; 10832 } 10833 10834 if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) { 10835 VarDecl *var = dyn_cast<VarDecl>(ref->getDecl()); 10836 if (!var) return false; 10837 return considerVariable(var, ref, owner); 10838 } 10839 10840 if (MemberExpr *member = dyn_cast<MemberExpr>(e)) { 10841 if (member->isArrow()) return false; 10842 10843 // Don't count this as an indirect ownership. 10844 e = member->getBase(); 10845 continue; 10846 } 10847 10848 if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) { 10849 // Only pay attention to pseudo-objects on property references. 10850 ObjCPropertyRefExpr *pre 10851 = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm() 10852 ->IgnoreParens()); 10853 if (!pre) return false; 10854 if (pre->isImplicitProperty()) return false; 10855 ObjCPropertyDecl *property = pre->getExplicitProperty(); 10856 if (!property->isRetaining() && 10857 !(property->getPropertyIvarDecl() && 10858 property->getPropertyIvarDecl()->getType() 10859 .getObjCLifetime() == Qualifiers::OCL_Strong)) 10860 return false; 10861 10862 owner.Indirect = true; 10863 if (pre->isSuperReceiver()) { 10864 owner.Variable = S.getCurMethodDecl()->getSelfDecl(); 10865 if (!owner.Variable) 10866 return false; 10867 owner.Loc = pre->getLocation(); 10868 owner.Range = pre->getSourceRange(); 10869 return true; 10870 } 10871 e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase()) 10872 ->getSourceExpr()); 10873 continue; 10874 } 10875 10876 // Array ivars? 10877 10878 return false; 10879 } 10880 } 10881 10882 namespace { 10883 struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> { 10884 FindCaptureVisitor(ASTContext &Context, VarDecl *variable) 10885 : EvaluatedExprVisitor<FindCaptureVisitor>(Context), 10886 Context(Context), Variable(variable), Capturer(nullptr), 10887 VarWillBeReased(false) {} 10888 ASTContext &Context; 10889 VarDecl *Variable; 10890 Expr *Capturer; 10891 bool VarWillBeReased; 10892 10893 void VisitDeclRefExpr(DeclRefExpr *ref) { 10894 if (ref->getDecl() == Variable && !Capturer) 10895 Capturer = ref; 10896 } 10897 10898 void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) { 10899 if (Capturer) return; 10900 Visit(ref->getBase()); 10901 if (Capturer && ref->isFreeIvar()) 10902 Capturer = ref; 10903 } 10904 10905 void VisitBlockExpr(BlockExpr *block) { 10906 // Look inside nested blocks 10907 if (block->getBlockDecl()->capturesVariable(Variable)) 10908 Visit(block->getBlockDecl()->getBody()); 10909 } 10910 10911 void VisitOpaqueValueExpr(OpaqueValueExpr *OVE) { 10912 if (Capturer) return; 10913 if (OVE->getSourceExpr()) 10914 Visit(OVE->getSourceExpr()); 10915 } 10916 void VisitBinaryOperator(BinaryOperator *BinOp) { 10917 if (!Variable || VarWillBeReased || BinOp->getOpcode() != BO_Assign) 10918 return; 10919 Expr *LHS = BinOp->getLHS(); 10920 if (const DeclRefExpr *DRE = dyn_cast_or_null<DeclRefExpr>(LHS)) { 10921 if (DRE->getDecl() != Variable) 10922 return; 10923 if (Expr *RHS = BinOp->getRHS()) { 10924 RHS = RHS->IgnoreParenCasts(); 10925 llvm::APSInt Value; 10926 VarWillBeReased = 10927 (RHS && RHS->isIntegerConstantExpr(Value, Context) && Value == 0); 10928 } 10929 } 10930 } 10931 }; 10932 } // end anonymous namespace 10933 10934 /// Check whether the given argument is a block which captures a 10935 /// variable. 10936 static Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) { 10937 assert(owner.Variable && owner.Loc.isValid()); 10938 10939 e = e->IgnoreParenCasts(); 10940 10941 // Look through [^{...} copy] and Block_copy(^{...}). 10942 if (ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(e)) { 10943 Selector Cmd = ME->getSelector(); 10944 if (Cmd.isUnarySelector() && Cmd.getNameForSlot(0) == "copy") { 10945 e = ME->getInstanceReceiver(); 10946 if (!e) 10947 return nullptr; 10948 e = e->IgnoreParenCasts(); 10949 } 10950 } else if (CallExpr *CE = dyn_cast<CallExpr>(e)) { 10951 if (CE->getNumArgs() == 1) { 10952 FunctionDecl *Fn = dyn_cast_or_null<FunctionDecl>(CE->getCalleeDecl()); 10953 if (Fn) { 10954 const IdentifierInfo *FnI = Fn->getIdentifier(); 10955 if (FnI && FnI->isStr("_Block_copy")) { 10956 e = CE->getArg(0)->IgnoreParenCasts(); 10957 } 10958 } 10959 } 10960 } 10961 10962 BlockExpr *block = dyn_cast<BlockExpr>(e); 10963 if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable)) 10964 return nullptr; 10965 10966 FindCaptureVisitor visitor(S.Context, owner.Variable); 10967 visitor.Visit(block->getBlockDecl()->getBody()); 10968 return visitor.VarWillBeReased ? nullptr : visitor.Capturer; 10969 } 10970 10971 static void diagnoseRetainCycle(Sema &S, Expr *capturer, 10972 RetainCycleOwner &owner) { 10973 assert(capturer); 10974 assert(owner.Variable && owner.Loc.isValid()); 10975 10976 S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle) 10977 << owner.Variable << capturer->getSourceRange(); 10978 S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner) 10979 << owner.Indirect << owner.Range; 10980 } 10981 10982 /// Check for a keyword selector that starts with the word 'add' or 10983 /// 'set'. 10984 static bool isSetterLikeSelector(Selector sel) { 10985 if (sel.isUnarySelector()) return false; 10986 10987 StringRef str = sel.getNameForSlot(0); 10988 while (!str.empty() && str.front() == '_') str = str.substr(1); 10989 if (str.startswith("set")) 10990 str = str.substr(3); 10991 else if (str.startswith("add")) { 10992 // Specially whitelist 'addOperationWithBlock:'. 10993 if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock")) 10994 return false; 10995 str = str.substr(3); 10996 } 10997 else 10998 return false; 10999 11000 if (str.empty()) return true; 11001 return !isLowercase(str.front()); 11002 } 11003 11004 static Optional<int> GetNSMutableArrayArgumentIndex(Sema &S, 11005 ObjCMessageExpr *Message) { 11006 bool IsMutableArray = S.NSAPIObj->isSubclassOfNSClass( 11007 Message->getReceiverInterface(), 11008 NSAPI::ClassId_NSMutableArray); 11009 if (!IsMutableArray) { 11010 return None; 11011 } 11012 11013 Selector Sel = Message->getSelector(); 11014 11015 Optional<NSAPI::NSArrayMethodKind> MKOpt = 11016 S.NSAPIObj->getNSArrayMethodKind(Sel); 11017 if (!MKOpt) { 11018 return None; 11019 } 11020 11021 NSAPI::NSArrayMethodKind MK = *MKOpt; 11022 11023 switch (MK) { 11024 case NSAPI::NSMutableArr_addObject: 11025 case NSAPI::NSMutableArr_insertObjectAtIndex: 11026 case NSAPI::NSMutableArr_setObjectAtIndexedSubscript: 11027 return 0; 11028 case NSAPI::NSMutableArr_replaceObjectAtIndex: 11029 return 1; 11030 11031 default: 11032 return None; 11033 } 11034 11035 return None; 11036 } 11037 11038 static 11039 Optional<int> GetNSMutableDictionaryArgumentIndex(Sema &S, 11040 ObjCMessageExpr *Message) { 11041 bool IsMutableDictionary = S.NSAPIObj->isSubclassOfNSClass( 11042 Message->getReceiverInterface(), 11043 NSAPI::ClassId_NSMutableDictionary); 11044 if (!IsMutableDictionary) { 11045 return None; 11046 } 11047 11048 Selector Sel = Message->getSelector(); 11049 11050 Optional<NSAPI::NSDictionaryMethodKind> MKOpt = 11051 S.NSAPIObj->getNSDictionaryMethodKind(Sel); 11052 if (!MKOpt) { 11053 return None; 11054 } 11055 11056 NSAPI::NSDictionaryMethodKind MK = *MKOpt; 11057 11058 switch (MK) { 11059 case NSAPI::NSMutableDict_setObjectForKey: 11060 case NSAPI::NSMutableDict_setValueForKey: 11061 case NSAPI::NSMutableDict_setObjectForKeyedSubscript: 11062 return 0; 11063 11064 default: 11065 return None; 11066 } 11067 11068 return None; 11069 } 11070 11071 static Optional<int> GetNSSetArgumentIndex(Sema &S, ObjCMessageExpr *Message) { 11072 bool IsMutableSet = S.NSAPIObj->isSubclassOfNSClass( 11073 Message->getReceiverInterface(), 11074 NSAPI::ClassId_NSMutableSet); 11075 11076 bool IsMutableOrderedSet = S.NSAPIObj->isSubclassOfNSClass( 11077 Message->getReceiverInterface(), 11078 NSAPI::ClassId_NSMutableOrderedSet); 11079 if (!IsMutableSet && !IsMutableOrderedSet) { 11080 return None; 11081 } 11082 11083 Selector Sel = Message->getSelector(); 11084 11085 Optional<NSAPI::NSSetMethodKind> MKOpt = S.NSAPIObj->getNSSetMethodKind(Sel); 11086 if (!MKOpt) { 11087 return None; 11088 } 11089 11090 NSAPI::NSSetMethodKind MK = *MKOpt; 11091 11092 switch (MK) { 11093 case NSAPI::NSMutableSet_addObject: 11094 case NSAPI::NSOrderedSet_setObjectAtIndex: 11095 case NSAPI::NSOrderedSet_setObjectAtIndexedSubscript: 11096 case NSAPI::NSOrderedSet_insertObjectAtIndex: 11097 return 0; 11098 case NSAPI::NSOrderedSet_replaceObjectAtIndexWithObject: 11099 return 1; 11100 } 11101 11102 return None; 11103 } 11104 11105 void Sema::CheckObjCCircularContainer(ObjCMessageExpr *Message) { 11106 if (!Message->isInstanceMessage()) { 11107 return; 11108 } 11109 11110 Optional<int> ArgOpt; 11111 11112 if (!(ArgOpt = GetNSMutableArrayArgumentIndex(*this, Message)) && 11113 !(ArgOpt = GetNSMutableDictionaryArgumentIndex(*this, Message)) && 11114 !(ArgOpt = GetNSSetArgumentIndex(*this, Message))) { 11115 return; 11116 } 11117 11118 int ArgIndex = *ArgOpt; 11119 11120 Expr *Arg = Message->getArg(ArgIndex)->IgnoreImpCasts(); 11121 if (OpaqueValueExpr *OE = dyn_cast<OpaqueValueExpr>(Arg)) { 11122 Arg = OE->getSourceExpr()->IgnoreImpCasts(); 11123 } 11124 11125 if (Message->getReceiverKind() == ObjCMessageExpr::SuperInstance) { 11126 if (DeclRefExpr *ArgRE = dyn_cast<DeclRefExpr>(Arg)) { 11127 if (ArgRE->isObjCSelfExpr()) { 11128 Diag(Message->getSourceRange().getBegin(), 11129 diag::warn_objc_circular_container) 11130 << ArgRE->getDecl()->getName() << StringRef("super"); 11131 } 11132 } 11133 } else { 11134 Expr *Receiver = Message->getInstanceReceiver()->IgnoreImpCasts(); 11135 11136 if (OpaqueValueExpr *OE = dyn_cast<OpaqueValueExpr>(Receiver)) { 11137 Receiver = OE->getSourceExpr()->IgnoreImpCasts(); 11138 } 11139 11140 if (DeclRefExpr *ReceiverRE = dyn_cast<DeclRefExpr>(Receiver)) { 11141 if (DeclRefExpr *ArgRE = dyn_cast<DeclRefExpr>(Arg)) { 11142 if (ReceiverRE->getDecl() == ArgRE->getDecl()) { 11143 ValueDecl *Decl = ReceiverRE->getDecl(); 11144 Diag(Message->getSourceRange().getBegin(), 11145 diag::warn_objc_circular_container) 11146 << Decl->getName() << Decl->getName(); 11147 if (!ArgRE->isObjCSelfExpr()) { 11148 Diag(Decl->getLocation(), 11149 diag::note_objc_circular_container_declared_here) 11150 << Decl->getName(); 11151 } 11152 } 11153 } 11154 } else if (ObjCIvarRefExpr *IvarRE = dyn_cast<ObjCIvarRefExpr>(Receiver)) { 11155 if (ObjCIvarRefExpr *IvarArgRE = dyn_cast<ObjCIvarRefExpr>(Arg)) { 11156 if (IvarRE->getDecl() == IvarArgRE->getDecl()) { 11157 ObjCIvarDecl *Decl = IvarRE->getDecl(); 11158 Diag(Message->getSourceRange().getBegin(), 11159 diag::warn_objc_circular_container) 11160 << Decl->getName() << Decl->getName(); 11161 Diag(Decl->getLocation(), 11162 diag::note_objc_circular_container_declared_here) 11163 << Decl->getName(); 11164 } 11165 } 11166 } 11167 } 11168 } 11169 11170 /// Check a message send to see if it's likely to cause a retain cycle. 11171 void Sema::checkRetainCycles(ObjCMessageExpr *msg) { 11172 // Only check instance methods whose selector looks like a setter. 11173 if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector())) 11174 return; 11175 11176 // Try to find a variable that the receiver is strongly owned by. 11177 RetainCycleOwner owner; 11178 if (msg->getReceiverKind() == ObjCMessageExpr::Instance) { 11179 if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner)) 11180 return; 11181 } else { 11182 assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance); 11183 owner.Variable = getCurMethodDecl()->getSelfDecl(); 11184 owner.Loc = msg->getSuperLoc(); 11185 owner.Range = msg->getSuperLoc(); 11186 } 11187 11188 // Check whether the receiver is captured by any of the arguments. 11189 for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i) 11190 if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) 11191 return diagnoseRetainCycle(*this, capturer, owner); 11192 } 11193 11194 /// Check a property assign to see if it's likely to cause a retain cycle. 11195 void Sema::checkRetainCycles(Expr *receiver, Expr *argument) { 11196 RetainCycleOwner owner; 11197 if (!findRetainCycleOwner(*this, receiver, owner)) 11198 return; 11199 11200 if (Expr *capturer = findCapturingExpr(*this, argument, owner)) 11201 diagnoseRetainCycle(*this, capturer, owner); 11202 } 11203 11204 void Sema::checkRetainCycles(VarDecl *Var, Expr *Init) { 11205 RetainCycleOwner Owner; 11206 if (!considerVariable(Var, /*DeclRefExpr=*/nullptr, Owner)) 11207 return; 11208 11209 // Because we don't have an expression for the variable, we have to set the 11210 // location explicitly here. 11211 Owner.Loc = Var->getLocation(); 11212 Owner.Range = Var->getSourceRange(); 11213 11214 if (Expr *Capturer = findCapturingExpr(*this, Init, Owner)) 11215 diagnoseRetainCycle(*this, Capturer, Owner); 11216 } 11217 11218 static bool checkUnsafeAssignLiteral(Sema &S, SourceLocation Loc, 11219 Expr *RHS, bool isProperty) { 11220 // Check if RHS is an Objective-C object literal, which also can get 11221 // immediately zapped in a weak reference. Note that we explicitly 11222 // allow ObjCStringLiterals, since those are designed to never really die. 11223 RHS = RHS->IgnoreParenImpCasts(); 11224 11225 // This enum needs to match with the 'select' in 11226 // warn_objc_arc_literal_assign (off-by-1). 11227 Sema::ObjCLiteralKind Kind = S.CheckLiteralKind(RHS); 11228 if (Kind == Sema::LK_String || Kind == Sema::LK_None) 11229 return false; 11230 11231 S.Diag(Loc, diag::warn_arc_literal_assign) 11232 << (unsigned) Kind 11233 << (isProperty ? 0 : 1) 11234 << RHS->getSourceRange(); 11235 11236 return true; 11237 } 11238 11239 static bool checkUnsafeAssignObject(Sema &S, SourceLocation Loc, 11240 Qualifiers::ObjCLifetime LT, 11241 Expr *RHS, bool isProperty) { 11242 // Strip off any implicit cast added to get to the one ARC-specific. 11243 while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 11244 if (cast->getCastKind() == CK_ARCConsumeObject) { 11245 S.Diag(Loc, diag::warn_arc_retained_assign) 11246 << (LT == Qualifiers::OCL_ExplicitNone) 11247 << (isProperty ? 0 : 1) 11248 << RHS->getSourceRange(); 11249 return true; 11250 } 11251 RHS = cast->getSubExpr(); 11252 } 11253 11254 if (LT == Qualifiers::OCL_Weak && 11255 checkUnsafeAssignLiteral(S, Loc, RHS, isProperty)) 11256 return true; 11257 11258 return false; 11259 } 11260 11261 bool Sema::checkUnsafeAssigns(SourceLocation Loc, 11262 QualType LHS, Expr *RHS) { 11263 Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime(); 11264 11265 if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone) 11266 return false; 11267 11268 if (checkUnsafeAssignObject(*this, Loc, LT, RHS, false)) 11269 return true; 11270 11271 return false; 11272 } 11273 11274 void Sema::checkUnsafeExprAssigns(SourceLocation Loc, 11275 Expr *LHS, Expr *RHS) { 11276 QualType LHSType; 11277 // PropertyRef on LHS type need be directly obtained from 11278 // its declaration as it has a PseudoType. 11279 ObjCPropertyRefExpr *PRE 11280 = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens()); 11281 if (PRE && !PRE->isImplicitProperty()) { 11282 const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 11283 if (PD) 11284 LHSType = PD->getType(); 11285 } 11286 11287 if (LHSType.isNull()) 11288 LHSType = LHS->getType(); 11289 11290 Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime(); 11291 11292 if (LT == Qualifiers::OCL_Weak) { 11293 if (!Diags.isIgnored(diag::warn_arc_repeated_use_of_weak, Loc)) 11294 getCurFunction()->markSafeWeakUse(LHS); 11295 } 11296 11297 if (checkUnsafeAssigns(Loc, LHSType, RHS)) 11298 return; 11299 11300 // FIXME. Check for other life times. 11301 if (LT != Qualifiers::OCL_None) 11302 return; 11303 11304 if (PRE) { 11305 if (PRE->isImplicitProperty()) 11306 return; 11307 const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 11308 if (!PD) 11309 return; 11310 11311 unsigned Attributes = PD->getPropertyAttributes(); 11312 if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) { 11313 // when 'assign' attribute was not explicitly specified 11314 // by user, ignore it and rely on property type itself 11315 // for lifetime info. 11316 unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten(); 11317 if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) && 11318 LHSType->isObjCRetainableType()) 11319 return; 11320 11321 while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 11322 if (cast->getCastKind() == CK_ARCConsumeObject) { 11323 Diag(Loc, diag::warn_arc_retained_property_assign) 11324 << RHS->getSourceRange(); 11325 return; 11326 } 11327 RHS = cast->getSubExpr(); 11328 } 11329 } 11330 else if (Attributes & ObjCPropertyDecl::OBJC_PR_weak) { 11331 if (checkUnsafeAssignObject(*this, Loc, Qualifiers::OCL_Weak, RHS, true)) 11332 return; 11333 } 11334 } 11335 } 11336 11337 //===--- CHECK: Empty statement body (-Wempty-body) ---------------------===// 11338 11339 namespace { 11340 bool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr, 11341 SourceLocation StmtLoc, 11342 const NullStmt *Body) { 11343 // Do not warn if the body is a macro that expands to nothing, e.g: 11344 // 11345 // #define CALL(x) 11346 // if (condition) 11347 // CALL(0); 11348 // 11349 if (Body->hasLeadingEmptyMacro()) 11350 return false; 11351 11352 // Get line numbers of statement and body. 11353 bool StmtLineInvalid; 11354 unsigned StmtLine = SourceMgr.getPresumedLineNumber(StmtLoc, 11355 &StmtLineInvalid); 11356 if (StmtLineInvalid) 11357 return false; 11358 11359 bool BodyLineInvalid; 11360 unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(), 11361 &BodyLineInvalid); 11362 if (BodyLineInvalid) 11363 return false; 11364 11365 // Warn if null statement and body are on the same line. 11366 if (StmtLine != BodyLine) 11367 return false; 11368 11369 return true; 11370 } 11371 } // end anonymous namespace 11372 11373 void Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc, 11374 const Stmt *Body, 11375 unsigned DiagID) { 11376 // Since this is a syntactic check, don't emit diagnostic for template 11377 // instantiations, this just adds noise. 11378 if (CurrentInstantiationScope) 11379 return; 11380 11381 // The body should be a null statement. 11382 const NullStmt *NBody = dyn_cast<NullStmt>(Body); 11383 if (!NBody) 11384 return; 11385 11386 // Do the usual checks. 11387 if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 11388 return; 11389 11390 Diag(NBody->getSemiLoc(), DiagID); 11391 Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 11392 } 11393 11394 void Sema::DiagnoseEmptyLoopBody(const Stmt *S, 11395 const Stmt *PossibleBody) { 11396 assert(!CurrentInstantiationScope); // Ensured by caller 11397 11398 SourceLocation StmtLoc; 11399 const Stmt *Body; 11400 unsigned DiagID; 11401 if (const ForStmt *FS = dyn_cast<ForStmt>(S)) { 11402 StmtLoc = FS->getRParenLoc(); 11403 Body = FS->getBody(); 11404 DiagID = diag::warn_empty_for_body; 11405 } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) { 11406 StmtLoc = WS->getCond()->getSourceRange().getEnd(); 11407 Body = WS->getBody(); 11408 DiagID = diag::warn_empty_while_body; 11409 } else 11410 return; // Neither `for' nor `while'. 11411 11412 // The body should be a null statement. 11413 const NullStmt *NBody = dyn_cast<NullStmt>(Body); 11414 if (!NBody) 11415 return; 11416 11417 // Skip expensive checks if diagnostic is disabled. 11418 if (Diags.isIgnored(DiagID, NBody->getSemiLoc())) 11419 return; 11420 11421 // Do the usual checks. 11422 if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 11423 return; 11424 11425 // `for(...);' and `while(...);' are popular idioms, so in order to keep 11426 // noise level low, emit diagnostics only if for/while is followed by a 11427 // CompoundStmt, e.g.: 11428 // for (int i = 0; i < n; i++); 11429 // { 11430 // a(i); 11431 // } 11432 // or if for/while is followed by a statement with more indentation 11433 // than for/while itself: 11434 // for (int i = 0; i < n; i++); 11435 // a(i); 11436 bool ProbableTypo = isa<CompoundStmt>(PossibleBody); 11437 if (!ProbableTypo) { 11438 bool BodyColInvalid; 11439 unsigned BodyCol = SourceMgr.getPresumedColumnNumber( 11440 PossibleBody->getLocStart(), 11441 &BodyColInvalid); 11442 if (BodyColInvalid) 11443 return; 11444 11445 bool StmtColInvalid; 11446 unsigned StmtCol = SourceMgr.getPresumedColumnNumber( 11447 S->getLocStart(), 11448 &StmtColInvalid); 11449 if (StmtColInvalid) 11450 return; 11451 11452 if (BodyCol > StmtCol) 11453 ProbableTypo = true; 11454 } 11455 11456 if (ProbableTypo) { 11457 Diag(NBody->getSemiLoc(), DiagID); 11458 Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 11459 } 11460 } 11461 11462 //===--- CHECK: Warn on self move with std::move. -------------------------===// 11463 11464 /// DiagnoseSelfMove - Emits a warning if a value is moved to itself. 11465 void Sema::DiagnoseSelfMove(const Expr *LHSExpr, const Expr *RHSExpr, 11466 SourceLocation OpLoc) { 11467 if (Diags.isIgnored(diag::warn_sizeof_pointer_expr_memaccess, OpLoc)) 11468 return; 11469 11470 if (inTemplateInstantiation()) 11471 return; 11472 11473 // Strip parens and casts away. 11474 LHSExpr = LHSExpr->IgnoreParenImpCasts(); 11475 RHSExpr = RHSExpr->IgnoreParenImpCasts(); 11476 11477 // Check for a call expression 11478 const CallExpr *CE = dyn_cast<CallExpr>(RHSExpr); 11479 if (!CE || CE->getNumArgs() != 1) 11480 return; 11481 11482 // Check for a call to std::move 11483 const FunctionDecl *FD = CE->getDirectCallee(); 11484 if (!FD || !FD->isInStdNamespace() || !FD->getIdentifier() || 11485 !FD->getIdentifier()->isStr("move")) 11486 return; 11487 11488 // Get argument from std::move 11489 RHSExpr = CE->getArg(0); 11490 11491 const DeclRefExpr *LHSDeclRef = dyn_cast<DeclRefExpr>(LHSExpr); 11492 const DeclRefExpr *RHSDeclRef = dyn_cast<DeclRefExpr>(RHSExpr); 11493 11494 // Two DeclRefExpr's, check that the decls are the same. 11495 if (LHSDeclRef && RHSDeclRef) { 11496 if (!LHSDeclRef->getDecl() || !RHSDeclRef->getDecl()) 11497 return; 11498 if (LHSDeclRef->getDecl()->getCanonicalDecl() != 11499 RHSDeclRef->getDecl()->getCanonicalDecl()) 11500 return; 11501 11502 Diag(OpLoc, diag::warn_self_move) << LHSExpr->getType() 11503 << LHSExpr->getSourceRange() 11504 << RHSExpr->getSourceRange(); 11505 return; 11506 } 11507 11508 // Member variables require a different approach to check for self moves. 11509 // MemberExpr's are the same if every nested MemberExpr refers to the same 11510 // Decl and that the base Expr's are DeclRefExpr's with the same Decl or 11511 // the base Expr's are CXXThisExpr's. 11512 const Expr *LHSBase = LHSExpr; 11513 const Expr *RHSBase = RHSExpr; 11514 const MemberExpr *LHSME = dyn_cast<MemberExpr>(LHSExpr); 11515 const MemberExpr *RHSME = dyn_cast<MemberExpr>(RHSExpr); 11516 if (!LHSME || !RHSME) 11517 return; 11518 11519 while (LHSME && RHSME) { 11520 if (LHSME->getMemberDecl()->getCanonicalDecl() != 11521 RHSME->getMemberDecl()->getCanonicalDecl()) 11522 return; 11523 11524 LHSBase = LHSME->getBase(); 11525 RHSBase = RHSME->getBase(); 11526 LHSME = dyn_cast<MemberExpr>(LHSBase); 11527 RHSME = dyn_cast<MemberExpr>(RHSBase); 11528 } 11529 11530 LHSDeclRef = dyn_cast<DeclRefExpr>(LHSBase); 11531 RHSDeclRef = dyn_cast<DeclRefExpr>(RHSBase); 11532 if (LHSDeclRef && RHSDeclRef) { 11533 if (!LHSDeclRef->getDecl() || !RHSDeclRef->getDecl()) 11534 return; 11535 if (LHSDeclRef->getDecl()->getCanonicalDecl() != 11536 RHSDeclRef->getDecl()->getCanonicalDecl()) 11537 return; 11538 11539 Diag(OpLoc, diag::warn_self_move) << LHSExpr->getType() 11540 << LHSExpr->getSourceRange() 11541 << RHSExpr->getSourceRange(); 11542 return; 11543 } 11544 11545 if (isa<CXXThisExpr>(LHSBase) && isa<CXXThisExpr>(RHSBase)) 11546 Diag(OpLoc, diag::warn_self_move) << LHSExpr->getType() 11547 << LHSExpr->getSourceRange() 11548 << RHSExpr->getSourceRange(); 11549 } 11550 11551 //===--- Layout compatibility ----------------------------------------------// 11552 11553 namespace { 11554 11555 bool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2); 11556 11557 /// \brief Check if two enumeration types are layout-compatible. 11558 bool isLayoutCompatible(ASTContext &C, EnumDecl *ED1, EnumDecl *ED2) { 11559 // C++11 [dcl.enum] p8: 11560 // Two enumeration types are layout-compatible if they have the same 11561 // underlying type. 11562 return ED1->isComplete() && ED2->isComplete() && 11563 C.hasSameType(ED1->getIntegerType(), ED2->getIntegerType()); 11564 } 11565 11566 /// \brief Check if two fields are layout-compatible. 11567 bool isLayoutCompatible(ASTContext &C, FieldDecl *Field1, FieldDecl *Field2) { 11568 if (!isLayoutCompatible(C, Field1->getType(), Field2->getType())) 11569 return false; 11570 11571 if (Field1->isBitField() != Field2->isBitField()) 11572 return false; 11573 11574 if (Field1->isBitField()) { 11575 // Make sure that the bit-fields are the same length. 11576 unsigned Bits1 = Field1->getBitWidthValue(C); 11577 unsigned Bits2 = Field2->getBitWidthValue(C); 11578 11579 if (Bits1 != Bits2) 11580 return false; 11581 } 11582 11583 return true; 11584 } 11585 11586 /// \brief Check if two standard-layout structs are layout-compatible. 11587 /// (C++11 [class.mem] p17) 11588 bool isLayoutCompatibleStruct(ASTContext &C, 11589 RecordDecl *RD1, 11590 RecordDecl *RD2) { 11591 // If both records are C++ classes, check that base classes match. 11592 if (const CXXRecordDecl *D1CXX = dyn_cast<CXXRecordDecl>(RD1)) { 11593 // If one of records is a CXXRecordDecl we are in C++ mode, 11594 // thus the other one is a CXXRecordDecl, too. 11595 const CXXRecordDecl *D2CXX = cast<CXXRecordDecl>(RD2); 11596 // Check number of base classes. 11597 if (D1CXX->getNumBases() != D2CXX->getNumBases()) 11598 return false; 11599 11600 // Check the base classes. 11601 for (CXXRecordDecl::base_class_const_iterator 11602 Base1 = D1CXX->bases_begin(), 11603 BaseEnd1 = D1CXX->bases_end(), 11604 Base2 = D2CXX->bases_begin(); 11605 Base1 != BaseEnd1; 11606 ++Base1, ++Base2) { 11607 if (!isLayoutCompatible(C, Base1->getType(), Base2->getType())) 11608 return false; 11609 } 11610 } else if (const CXXRecordDecl *D2CXX = dyn_cast<CXXRecordDecl>(RD2)) { 11611 // If only RD2 is a C++ class, it should have zero base classes. 11612 if (D2CXX->getNumBases() > 0) 11613 return false; 11614 } 11615 11616 // Check the fields. 11617 RecordDecl::field_iterator Field2 = RD2->field_begin(), 11618 Field2End = RD2->field_end(), 11619 Field1 = RD1->field_begin(), 11620 Field1End = RD1->field_end(); 11621 for ( ; Field1 != Field1End && Field2 != Field2End; ++Field1, ++Field2) { 11622 if (!isLayoutCompatible(C, *Field1, *Field2)) 11623 return false; 11624 } 11625 if (Field1 != Field1End || Field2 != Field2End) 11626 return false; 11627 11628 return true; 11629 } 11630 11631 /// \brief Check if two standard-layout unions are layout-compatible. 11632 /// (C++11 [class.mem] p18) 11633 bool isLayoutCompatibleUnion(ASTContext &C, 11634 RecordDecl *RD1, 11635 RecordDecl *RD2) { 11636 llvm::SmallPtrSet<FieldDecl *, 8> UnmatchedFields; 11637 for (auto *Field2 : RD2->fields()) 11638 UnmatchedFields.insert(Field2); 11639 11640 for (auto *Field1 : RD1->fields()) { 11641 llvm::SmallPtrSet<FieldDecl *, 8>::iterator 11642 I = UnmatchedFields.begin(), 11643 E = UnmatchedFields.end(); 11644 11645 for ( ; I != E; ++I) { 11646 if (isLayoutCompatible(C, Field1, *I)) { 11647 bool Result = UnmatchedFields.erase(*I); 11648 (void) Result; 11649 assert(Result); 11650 break; 11651 } 11652 } 11653 if (I == E) 11654 return false; 11655 } 11656 11657 return UnmatchedFields.empty(); 11658 } 11659 11660 bool isLayoutCompatible(ASTContext &C, RecordDecl *RD1, RecordDecl *RD2) { 11661 if (RD1->isUnion() != RD2->isUnion()) 11662 return false; 11663 11664 if (RD1->isUnion()) 11665 return isLayoutCompatibleUnion(C, RD1, RD2); 11666 else 11667 return isLayoutCompatibleStruct(C, RD1, RD2); 11668 } 11669 11670 /// \brief Check if two types are layout-compatible in C++11 sense. 11671 bool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2) { 11672 if (T1.isNull() || T2.isNull()) 11673 return false; 11674 11675 // C++11 [basic.types] p11: 11676 // If two types T1 and T2 are the same type, then T1 and T2 are 11677 // layout-compatible types. 11678 if (C.hasSameType(T1, T2)) 11679 return true; 11680 11681 T1 = T1.getCanonicalType().getUnqualifiedType(); 11682 T2 = T2.getCanonicalType().getUnqualifiedType(); 11683 11684 const Type::TypeClass TC1 = T1->getTypeClass(); 11685 const Type::TypeClass TC2 = T2->getTypeClass(); 11686 11687 if (TC1 != TC2) 11688 return false; 11689 11690 if (TC1 == Type::Enum) { 11691 return isLayoutCompatible(C, 11692 cast<EnumType>(T1)->getDecl(), 11693 cast<EnumType>(T2)->getDecl()); 11694 } else if (TC1 == Type::Record) { 11695 if (!T1->isStandardLayoutType() || !T2->isStandardLayoutType()) 11696 return false; 11697 11698 return isLayoutCompatible(C, 11699 cast<RecordType>(T1)->getDecl(), 11700 cast<RecordType>(T2)->getDecl()); 11701 } 11702 11703 return false; 11704 } 11705 } // end anonymous namespace 11706 11707 //===--- CHECK: pointer_with_type_tag attribute: datatypes should match ----// 11708 11709 namespace { 11710 /// \brief Given a type tag expression find the type tag itself. 11711 /// 11712 /// \param TypeExpr Type tag expression, as it appears in user's code. 11713 /// 11714 /// \param VD Declaration of an identifier that appears in a type tag. 11715 /// 11716 /// \param MagicValue Type tag magic value. 11717 bool FindTypeTagExpr(const Expr *TypeExpr, const ASTContext &Ctx, 11718 const ValueDecl **VD, uint64_t *MagicValue) { 11719 while(true) { 11720 if (!TypeExpr) 11721 return false; 11722 11723 TypeExpr = TypeExpr->IgnoreParenImpCasts()->IgnoreParenCasts(); 11724 11725 switch (TypeExpr->getStmtClass()) { 11726 case Stmt::UnaryOperatorClass: { 11727 const UnaryOperator *UO = cast<UnaryOperator>(TypeExpr); 11728 if (UO->getOpcode() == UO_AddrOf || UO->getOpcode() == UO_Deref) { 11729 TypeExpr = UO->getSubExpr(); 11730 continue; 11731 } 11732 return false; 11733 } 11734 11735 case Stmt::DeclRefExprClass: { 11736 const DeclRefExpr *DRE = cast<DeclRefExpr>(TypeExpr); 11737 *VD = DRE->getDecl(); 11738 return true; 11739 } 11740 11741 case Stmt::IntegerLiteralClass: { 11742 const IntegerLiteral *IL = cast<IntegerLiteral>(TypeExpr); 11743 llvm::APInt MagicValueAPInt = IL->getValue(); 11744 if (MagicValueAPInt.getActiveBits() <= 64) { 11745 *MagicValue = MagicValueAPInt.getZExtValue(); 11746 return true; 11747 } else 11748 return false; 11749 } 11750 11751 case Stmt::BinaryConditionalOperatorClass: 11752 case Stmt::ConditionalOperatorClass: { 11753 const AbstractConditionalOperator *ACO = 11754 cast<AbstractConditionalOperator>(TypeExpr); 11755 bool Result; 11756 if (ACO->getCond()->EvaluateAsBooleanCondition(Result, Ctx)) { 11757 if (Result) 11758 TypeExpr = ACO->getTrueExpr(); 11759 else 11760 TypeExpr = ACO->getFalseExpr(); 11761 continue; 11762 } 11763 return false; 11764 } 11765 11766 case Stmt::BinaryOperatorClass: { 11767 const BinaryOperator *BO = cast<BinaryOperator>(TypeExpr); 11768 if (BO->getOpcode() == BO_Comma) { 11769 TypeExpr = BO->getRHS(); 11770 continue; 11771 } 11772 return false; 11773 } 11774 11775 default: 11776 return false; 11777 } 11778 } 11779 } 11780 11781 /// \brief Retrieve the C type corresponding to type tag TypeExpr. 11782 /// 11783 /// \param TypeExpr Expression that specifies a type tag. 11784 /// 11785 /// \param MagicValues Registered magic values. 11786 /// 11787 /// \param FoundWrongKind Set to true if a type tag was found, but of a wrong 11788 /// kind. 11789 /// 11790 /// \param TypeInfo Information about the corresponding C type. 11791 /// 11792 /// \returns true if the corresponding C type was found. 11793 bool GetMatchingCType( 11794 const IdentifierInfo *ArgumentKind, 11795 const Expr *TypeExpr, const ASTContext &Ctx, 11796 const llvm::DenseMap<Sema::TypeTagMagicValue, 11797 Sema::TypeTagData> *MagicValues, 11798 bool &FoundWrongKind, 11799 Sema::TypeTagData &TypeInfo) { 11800 FoundWrongKind = false; 11801 11802 // Variable declaration that has type_tag_for_datatype attribute. 11803 const ValueDecl *VD = nullptr; 11804 11805 uint64_t MagicValue; 11806 11807 if (!FindTypeTagExpr(TypeExpr, Ctx, &VD, &MagicValue)) 11808 return false; 11809 11810 if (VD) { 11811 if (TypeTagForDatatypeAttr *I = VD->getAttr<TypeTagForDatatypeAttr>()) { 11812 if (I->getArgumentKind() != ArgumentKind) { 11813 FoundWrongKind = true; 11814 return false; 11815 } 11816 TypeInfo.Type = I->getMatchingCType(); 11817 TypeInfo.LayoutCompatible = I->getLayoutCompatible(); 11818 TypeInfo.MustBeNull = I->getMustBeNull(); 11819 return true; 11820 } 11821 return false; 11822 } 11823 11824 if (!MagicValues) 11825 return false; 11826 11827 llvm::DenseMap<Sema::TypeTagMagicValue, 11828 Sema::TypeTagData>::const_iterator I = 11829 MagicValues->find(std::make_pair(ArgumentKind, MagicValue)); 11830 if (I == MagicValues->end()) 11831 return false; 11832 11833 TypeInfo = I->second; 11834 return true; 11835 } 11836 } // end anonymous namespace 11837 11838 void Sema::RegisterTypeTagForDatatype(const IdentifierInfo *ArgumentKind, 11839 uint64_t MagicValue, QualType Type, 11840 bool LayoutCompatible, 11841 bool MustBeNull) { 11842 if (!TypeTagForDatatypeMagicValues) 11843 TypeTagForDatatypeMagicValues.reset( 11844 new llvm::DenseMap<TypeTagMagicValue, TypeTagData>); 11845 11846 TypeTagMagicValue Magic(ArgumentKind, MagicValue); 11847 (*TypeTagForDatatypeMagicValues)[Magic] = 11848 TypeTagData(Type, LayoutCompatible, MustBeNull); 11849 } 11850 11851 namespace { 11852 bool IsSameCharType(QualType T1, QualType T2) { 11853 const BuiltinType *BT1 = T1->getAs<BuiltinType>(); 11854 if (!BT1) 11855 return false; 11856 11857 const BuiltinType *BT2 = T2->getAs<BuiltinType>(); 11858 if (!BT2) 11859 return false; 11860 11861 BuiltinType::Kind T1Kind = BT1->getKind(); 11862 BuiltinType::Kind T2Kind = BT2->getKind(); 11863 11864 return (T1Kind == BuiltinType::SChar && T2Kind == BuiltinType::Char_S) || 11865 (T1Kind == BuiltinType::UChar && T2Kind == BuiltinType::Char_U) || 11866 (T1Kind == BuiltinType::Char_U && T2Kind == BuiltinType::UChar) || 11867 (T1Kind == BuiltinType::Char_S && T2Kind == BuiltinType::SChar); 11868 } 11869 } // end anonymous namespace 11870 11871 void Sema::CheckArgumentWithTypeTag(const ArgumentWithTypeTagAttr *Attr, 11872 const Expr * const *ExprArgs) { 11873 const IdentifierInfo *ArgumentKind = Attr->getArgumentKind(); 11874 bool IsPointerAttr = Attr->getIsPointer(); 11875 11876 const Expr *TypeTagExpr = ExprArgs[Attr->getTypeTagIdx()]; 11877 bool FoundWrongKind; 11878 TypeTagData TypeInfo; 11879 if (!GetMatchingCType(ArgumentKind, TypeTagExpr, Context, 11880 TypeTagForDatatypeMagicValues.get(), 11881 FoundWrongKind, TypeInfo)) { 11882 if (FoundWrongKind) 11883 Diag(TypeTagExpr->getExprLoc(), 11884 diag::warn_type_tag_for_datatype_wrong_kind) 11885 << TypeTagExpr->getSourceRange(); 11886 return; 11887 } 11888 11889 const Expr *ArgumentExpr = ExprArgs[Attr->getArgumentIdx()]; 11890 if (IsPointerAttr) { 11891 // Skip implicit cast of pointer to `void *' (as a function argument). 11892 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgumentExpr)) 11893 if (ICE->getType()->isVoidPointerType() && 11894 ICE->getCastKind() == CK_BitCast) 11895 ArgumentExpr = ICE->getSubExpr(); 11896 } 11897 QualType ArgumentType = ArgumentExpr->getType(); 11898 11899 // Passing a `void*' pointer shouldn't trigger a warning. 11900 if (IsPointerAttr && ArgumentType->isVoidPointerType()) 11901 return; 11902 11903 if (TypeInfo.MustBeNull) { 11904 // Type tag with matching void type requires a null pointer. 11905 if (!ArgumentExpr->isNullPointerConstant(Context, 11906 Expr::NPC_ValueDependentIsNotNull)) { 11907 Diag(ArgumentExpr->getExprLoc(), 11908 diag::warn_type_safety_null_pointer_required) 11909 << ArgumentKind->getName() 11910 << ArgumentExpr->getSourceRange() 11911 << TypeTagExpr->getSourceRange(); 11912 } 11913 return; 11914 } 11915 11916 QualType RequiredType = TypeInfo.Type; 11917 if (IsPointerAttr) 11918 RequiredType = Context.getPointerType(RequiredType); 11919 11920 bool mismatch = false; 11921 if (!TypeInfo.LayoutCompatible) { 11922 mismatch = !Context.hasSameType(ArgumentType, RequiredType); 11923 11924 // C++11 [basic.fundamental] p1: 11925 // Plain char, signed char, and unsigned char are three distinct types. 11926 // 11927 // But we treat plain `char' as equivalent to `signed char' or `unsigned 11928 // char' depending on the current char signedness mode. 11929 if (mismatch) 11930 if ((IsPointerAttr && IsSameCharType(ArgumentType->getPointeeType(), 11931 RequiredType->getPointeeType())) || 11932 (!IsPointerAttr && IsSameCharType(ArgumentType, RequiredType))) 11933 mismatch = false; 11934 } else 11935 if (IsPointerAttr) 11936 mismatch = !isLayoutCompatible(Context, 11937 ArgumentType->getPointeeType(), 11938 RequiredType->getPointeeType()); 11939 else 11940 mismatch = !isLayoutCompatible(Context, ArgumentType, RequiredType); 11941 11942 if (mismatch) 11943 Diag(ArgumentExpr->getExprLoc(), diag::warn_type_safety_type_mismatch) 11944 << ArgumentType << ArgumentKind 11945 << TypeInfo.LayoutCompatible << RequiredType 11946 << ArgumentExpr->getSourceRange() 11947 << TypeTagExpr->getSourceRange(); 11948 } 11949 11950 void Sema::AddPotentialMisalignedMembers(Expr *E, RecordDecl *RD, ValueDecl *MD, 11951 CharUnits Alignment) { 11952 MisalignedMembers.emplace_back(E, RD, MD, Alignment); 11953 } 11954 11955 void Sema::DiagnoseMisalignedMembers() { 11956 for (MisalignedMember &m : MisalignedMembers) { 11957 const NamedDecl *ND = m.RD; 11958 if (ND->getName().empty()) { 11959 if (const TypedefNameDecl *TD = m.RD->getTypedefNameForAnonDecl()) 11960 ND = TD; 11961 } 11962 Diag(m.E->getLocStart(), diag::warn_taking_address_of_packed_member) 11963 << m.MD << ND << m.E->getSourceRange(); 11964 } 11965 MisalignedMembers.clear(); 11966 } 11967 11968 void Sema::DiscardMisalignedMemberAddress(const Type *T, Expr *E) { 11969 E = E->IgnoreParens(); 11970 if (!T->isPointerType() && !T->isIntegerType()) 11971 return; 11972 if (isa<UnaryOperator>(E) && 11973 cast<UnaryOperator>(E)->getOpcode() == UO_AddrOf) { 11974 auto *Op = cast<UnaryOperator>(E)->getSubExpr()->IgnoreParens(); 11975 if (isa<MemberExpr>(Op)) { 11976 auto MA = std::find(MisalignedMembers.begin(), MisalignedMembers.end(), 11977 MisalignedMember(Op)); 11978 if (MA != MisalignedMembers.end() && 11979 (T->isIntegerType() || 11980 (T->isPointerType() && 11981 Context.getTypeAlignInChars(T->getPointeeType()) <= MA->Alignment))) 11982 MisalignedMembers.erase(MA); 11983 } 11984 } 11985 } 11986 11987 void Sema::RefersToMemberWithReducedAlignment( 11988 Expr *E, 11989 llvm::function_ref<void(Expr *, RecordDecl *, FieldDecl *, CharUnits)> 11990 Action) { 11991 const auto *ME = dyn_cast<MemberExpr>(E); 11992 if (!ME) 11993 return; 11994 11995 // No need to check expressions with an __unaligned-qualified type. 11996 if (E->getType().getQualifiers().hasUnaligned()) 11997 return; 11998 11999 // For a chain of MemberExpr like "a.b.c.d" this list 12000 // will keep FieldDecl's like [d, c, b]. 12001 SmallVector<FieldDecl *, 4> ReverseMemberChain; 12002 const MemberExpr *TopME = nullptr; 12003 bool AnyIsPacked = false; 12004 do { 12005 QualType BaseType = ME->getBase()->getType(); 12006 if (ME->isArrow()) 12007 BaseType = BaseType->getPointeeType(); 12008 RecordDecl *RD = BaseType->getAs<RecordType>()->getDecl(); 12009 12010 ValueDecl *MD = ME->getMemberDecl(); 12011 auto *FD = dyn_cast<FieldDecl>(MD); 12012 // We do not care about non-data members. 12013 if (!FD || FD->isInvalidDecl()) 12014 return; 12015 12016 AnyIsPacked = 12017 AnyIsPacked || (RD->hasAttr<PackedAttr>() || MD->hasAttr<PackedAttr>()); 12018 ReverseMemberChain.push_back(FD); 12019 12020 TopME = ME; 12021 ME = dyn_cast<MemberExpr>(ME->getBase()->IgnoreParens()); 12022 } while (ME); 12023 assert(TopME && "We did not compute a topmost MemberExpr!"); 12024 12025 // Not the scope of this diagnostic. 12026 if (!AnyIsPacked) 12027 return; 12028 12029 const Expr *TopBase = TopME->getBase()->IgnoreParenImpCasts(); 12030 const auto *DRE = dyn_cast<DeclRefExpr>(TopBase); 12031 // TODO: The innermost base of the member expression may be too complicated. 12032 // For now, just disregard these cases. This is left for future 12033 // improvement. 12034 if (!DRE && !isa<CXXThisExpr>(TopBase)) 12035 return; 12036 12037 // Alignment expected by the whole expression. 12038 CharUnits ExpectedAlignment = Context.getTypeAlignInChars(E->getType()); 12039 12040 // No need to do anything else with this case. 12041 if (ExpectedAlignment.isOne()) 12042 return; 12043 12044 // Synthesize offset of the whole access. 12045 CharUnits Offset; 12046 for (auto I = ReverseMemberChain.rbegin(); I != ReverseMemberChain.rend(); 12047 I++) { 12048 Offset += Context.toCharUnitsFromBits(Context.getFieldOffset(*I)); 12049 } 12050 12051 // Compute the CompleteObjectAlignment as the alignment of the whole chain. 12052 CharUnits CompleteObjectAlignment = Context.getTypeAlignInChars( 12053 ReverseMemberChain.back()->getParent()->getTypeForDecl()); 12054 12055 // The base expression of the innermost MemberExpr may give 12056 // stronger guarantees than the class containing the member. 12057 if (DRE && !TopME->isArrow()) { 12058 const ValueDecl *VD = DRE->getDecl(); 12059 if (!VD->getType()->isReferenceType()) 12060 CompleteObjectAlignment = 12061 std::max(CompleteObjectAlignment, Context.getDeclAlign(VD)); 12062 } 12063 12064 // Check if the synthesized offset fulfills the alignment. 12065 if (Offset % ExpectedAlignment != 0 || 12066 // It may fulfill the offset it but the effective alignment may still be 12067 // lower than the expected expression alignment. 12068 CompleteObjectAlignment < ExpectedAlignment) { 12069 // If this happens, we want to determine a sensible culprit of this. 12070 // Intuitively, watching the chain of member expressions from right to 12071 // left, we start with the required alignment (as required by the field 12072 // type) but some packed attribute in that chain has reduced the alignment. 12073 // It may happen that another packed structure increases it again. But if 12074 // we are here such increase has not been enough. So pointing the first 12075 // FieldDecl that either is packed or else its RecordDecl is, 12076 // seems reasonable. 12077 FieldDecl *FD = nullptr; 12078 CharUnits Alignment; 12079 for (FieldDecl *FDI : ReverseMemberChain) { 12080 if (FDI->hasAttr<PackedAttr>() || 12081 FDI->getParent()->hasAttr<PackedAttr>()) { 12082 FD = FDI; 12083 Alignment = std::min( 12084 Context.getTypeAlignInChars(FD->getType()), 12085 Context.getTypeAlignInChars(FD->getParent()->getTypeForDecl())); 12086 break; 12087 } 12088 } 12089 assert(FD && "We did not find a packed FieldDecl!"); 12090 Action(E, FD->getParent(), FD, Alignment); 12091 } 12092 } 12093 12094 void Sema::CheckAddressOfPackedMember(Expr *rhs) { 12095 using namespace std::placeholders; 12096 RefersToMemberWithReducedAlignment( 12097 rhs, std::bind(&Sema::AddPotentialMisalignedMembers, std::ref(*this), _1, 12098 _2, _3, _4)); 12099 } 12100 12101