1 /* SPDX-License-Identifier: BSD-3-Clause
2 * Copyright(c) 2014-2021 Broadcom
3 * All rights reserved.
4 */
5
6 #include <sys/queue.h>
7
8 #include <rte_log.h>
9 #include <rte_malloc.h>
10 #include <rte_flow.h>
11 #include <rte_flow_driver.h>
12 #include <rte_tailq.h>
13 #include <rte_alarm.h>
14 #include <rte_cycles.h>
15
16 #include "bnxt.h"
17 #include "bnxt_filter.h"
18 #include "bnxt_hwrm.h"
19 #include "bnxt_ring.h"
20 #include "bnxt_rxq.h"
21 #include "bnxt_rxr.h"
22 #include "bnxt_vnic.h"
23 #include "hsi_struct_def_dpdk.h"
24
25 static int
bnxt_flow_args_validate(const struct rte_flow_attr * attr,const struct rte_flow_item pattern[],const struct rte_flow_action actions[],struct rte_flow_error * error)26 bnxt_flow_args_validate(const struct rte_flow_attr *attr,
27 const struct rte_flow_item pattern[],
28 const struct rte_flow_action actions[],
29 struct rte_flow_error *error)
30 {
31 if (!pattern) {
32 rte_flow_error_set(error,
33 EINVAL,
34 RTE_FLOW_ERROR_TYPE_ITEM_NUM,
35 NULL,
36 "NULL pattern.");
37 return -rte_errno;
38 }
39
40 if (!actions) {
41 rte_flow_error_set(error,
42 EINVAL,
43 RTE_FLOW_ERROR_TYPE_ACTION_NUM,
44 NULL,
45 "NULL action.");
46 return -rte_errno;
47 }
48
49 if (!attr) {
50 rte_flow_error_set(error,
51 EINVAL,
52 RTE_FLOW_ERROR_TYPE_ATTR,
53 NULL,
54 "NULL attribute.");
55 return -rte_errno;
56 }
57
58 return 0;
59 }
60
61 static const struct rte_flow_item *
bnxt_flow_non_void_item(const struct rte_flow_item * cur)62 bnxt_flow_non_void_item(const struct rte_flow_item *cur)
63 {
64 while (1) {
65 if (cur->type != RTE_FLOW_ITEM_TYPE_VOID)
66 return cur;
67 cur++;
68 }
69 }
70
71 static const struct rte_flow_action *
bnxt_flow_non_void_action(const struct rte_flow_action * cur)72 bnxt_flow_non_void_action(const struct rte_flow_action *cur)
73 {
74 while (1) {
75 if (cur->type != RTE_FLOW_ACTION_TYPE_VOID)
76 return cur;
77 cur++;
78 }
79 }
80
81 static int
bnxt_filter_type_check(const struct rte_flow_item pattern[],struct rte_flow_error * error)82 bnxt_filter_type_check(const struct rte_flow_item pattern[],
83 struct rte_flow_error *error)
84 {
85 const struct rte_flow_item *item =
86 bnxt_flow_non_void_item(pattern);
87 int use_ntuple = 1;
88 bool has_vlan = 0;
89
90 while (item->type != RTE_FLOW_ITEM_TYPE_END) {
91 switch (item->type) {
92 case RTE_FLOW_ITEM_TYPE_ANY:
93 case RTE_FLOW_ITEM_TYPE_ETH:
94 use_ntuple = 0;
95 break;
96 case RTE_FLOW_ITEM_TYPE_VLAN:
97 use_ntuple = 0;
98 has_vlan = 1;
99 break;
100 case RTE_FLOW_ITEM_TYPE_IPV4:
101 case RTE_FLOW_ITEM_TYPE_IPV6:
102 case RTE_FLOW_ITEM_TYPE_TCP:
103 case RTE_FLOW_ITEM_TYPE_UDP:
104 /* FALLTHROUGH */
105 /* need ntuple match, reset exact match */
106 use_ntuple |= 1;
107 break;
108 default:
109 PMD_DRV_LOG(DEBUG, "Unknown Flow type\n");
110 use_ntuple |= 0;
111 }
112 item++;
113 }
114
115 if (has_vlan && use_ntuple) {
116 PMD_DRV_LOG(ERR,
117 "VLAN flow cannot use NTUPLE filter\n");
118 rte_flow_error_set(error, EINVAL,
119 RTE_FLOW_ERROR_TYPE_ITEM,
120 item,
121 "Cannot use VLAN with NTUPLE");
122 return -rte_errno;
123 }
124
125 return use_ntuple;
126 }
127
128 static int
bnxt_validate_and_parse_flow_type(struct bnxt * bp,const struct rte_flow_attr * attr,const struct rte_flow_item pattern[],struct rte_flow_error * error,struct bnxt_filter_info * filter)129 bnxt_validate_and_parse_flow_type(struct bnxt *bp,
130 const struct rte_flow_attr *attr,
131 const struct rte_flow_item pattern[],
132 struct rte_flow_error *error,
133 struct bnxt_filter_info *filter)
134 {
135 const struct rte_flow_item *item = bnxt_flow_non_void_item(pattern);
136 const struct rte_flow_item_vlan *vlan_spec, *vlan_mask;
137 const struct rte_flow_item_ipv4 *ipv4_spec, *ipv4_mask;
138 const struct rte_flow_item_ipv6 *ipv6_spec, *ipv6_mask;
139 const struct rte_flow_item_tcp *tcp_spec, *tcp_mask;
140 const struct rte_flow_item_udp *udp_spec, *udp_mask;
141 const struct rte_flow_item_eth *eth_spec, *eth_mask;
142 const struct rte_ether_addr *dst, *src;
143 const struct rte_flow_item_nvgre *nvgre_spec;
144 const struct rte_flow_item_nvgre *nvgre_mask;
145 const struct rte_flow_item_gre *gre_spec;
146 const struct rte_flow_item_gre *gre_mask;
147 const struct rte_flow_item_vxlan *vxlan_spec;
148 const struct rte_flow_item_vxlan *vxlan_mask;
149 uint8_t vni_mask[] = {0xFF, 0xFF, 0xFF};
150 uint8_t tni_mask[] = {0xFF, 0xFF, 0xFF};
151 const struct rte_flow_item_vf *vf_spec;
152 uint32_t tenant_id_be = 0, valid_flags = 0;
153 bool vni_masked = 0;
154 bool tni_masked = 0;
155 uint32_t en_ethertype;
156 uint8_t inner = 0;
157 uint32_t vf = 0;
158 uint32_t en = 0;
159 int use_ntuple;
160 int dflt_vnic;
161
162 use_ntuple = bnxt_filter_type_check(pattern, error);
163 if (use_ntuple < 0)
164 return use_ntuple;
165 PMD_DRV_LOG(DEBUG, "Use NTUPLE %d\n", use_ntuple);
166
167 filter->filter_type = use_ntuple ?
168 HWRM_CFA_NTUPLE_FILTER : HWRM_CFA_L2_FILTER;
169 en_ethertype = use_ntuple ?
170 NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE :
171 EM_FLOW_ALLOC_INPUT_EN_ETHERTYPE;
172
173 while (item->type != RTE_FLOW_ITEM_TYPE_END) {
174 if (item->last) {
175 /* last or range is NOT supported as match criteria */
176 rte_flow_error_set(error, EINVAL,
177 RTE_FLOW_ERROR_TYPE_ITEM,
178 item,
179 "No support for range");
180 return -rte_errno;
181 }
182
183 switch (item->type) {
184 case RTE_FLOW_ITEM_TYPE_ANY:
185 inner =
186 ((const struct rte_flow_item_any *)item->spec)->num > 3;
187 if (inner)
188 PMD_DRV_LOG(DEBUG, "Parse inner header\n");
189 break;
190 case RTE_FLOW_ITEM_TYPE_ETH:
191 if (!item->spec)
192 break;
193
194 eth_spec = item->spec;
195
196 if (item->mask)
197 eth_mask = item->mask;
198 else
199 eth_mask = &rte_flow_item_eth_mask;
200
201 /* Source MAC address mask cannot be partially set.
202 * Should be All 0's or all 1's.
203 * Destination MAC address mask must not be partially
204 * set. Should be all 1's or all 0's.
205 */
206 if ((!rte_is_zero_ether_addr(ð_mask->src) &&
207 !rte_is_broadcast_ether_addr(ð_mask->src)) ||
208 (!rte_is_zero_ether_addr(ð_mask->dst) &&
209 !rte_is_broadcast_ether_addr(ð_mask->dst))) {
210 rte_flow_error_set(error,
211 EINVAL,
212 RTE_FLOW_ERROR_TYPE_ITEM,
213 item,
214 "MAC_addr mask not valid");
215 return -rte_errno;
216 }
217
218 /* Mask is not allowed. Only exact matches are */
219 if (eth_mask->type &&
220 eth_mask->type != RTE_BE16(0xffff)) {
221 rte_flow_error_set(error, EINVAL,
222 RTE_FLOW_ERROR_TYPE_ITEM,
223 item,
224 "ethertype mask not valid");
225 return -rte_errno;
226 }
227
228 if (rte_is_broadcast_ether_addr(ð_mask->dst)) {
229 dst = ð_spec->dst;
230 if (!rte_is_valid_assigned_ether_addr(dst)) {
231 rte_flow_error_set(error,
232 EINVAL,
233 RTE_FLOW_ERROR_TYPE_ITEM,
234 item,
235 "DMAC is invalid");
236 PMD_DRV_LOG(ERR,
237 "DMAC is invalid!\n");
238 return -rte_errno;
239 }
240 rte_memcpy(filter->dst_macaddr,
241 ð_spec->dst, RTE_ETHER_ADDR_LEN);
242 en |= use_ntuple ?
243 NTUPLE_FLTR_ALLOC_INPUT_EN_DST_MACADDR :
244 EM_FLOW_ALLOC_INPUT_EN_DST_MACADDR;
245 valid_flags |= inner ?
246 BNXT_FLOW_L2_INNER_DST_VALID_FLAG :
247 BNXT_FLOW_L2_DST_VALID_FLAG;
248 filter->priority = attr->priority;
249 PMD_DRV_LOG(DEBUG,
250 "Creating a priority flow\n");
251 }
252 if (rte_is_broadcast_ether_addr(ð_mask->src)) {
253 src = ð_spec->src;
254 if (!rte_is_valid_assigned_ether_addr(src)) {
255 rte_flow_error_set(error,
256 EINVAL,
257 RTE_FLOW_ERROR_TYPE_ITEM,
258 item,
259 "SMAC is invalid");
260 PMD_DRV_LOG(ERR,
261 "SMAC is invalid!\n");
262 return -rte_errno;
263 }
264 rte_memcpy(filter->src_macaddr,
265 ð_spec->src, RTE_ETHER_ADDR_LEN);
266 en |= use_ntuple ?
267 NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_MACADDR :
268 EM_FLOW_ALLOC_INPUT_EN_SRC_MACADDR;
269 valid_flags |= inner ?
270 BNXT_FLOW_L2_INNER_SRC_VALID_FLAG :
271 BNXT_FLOW_L2_SRC_VALID_FLAG;
272 } /*
273 * else {
274 * PMD_DRV_LOG(ERR, "Handle this condition\n");
275 * }
276 */
277 if (eth_mask->type) {
278 filter->ethertype =
279 rte_be_to_cpu_16(eth_spec->type);
280 en |= en_ethertype;
281 }
282 if (inner)
283 valid_flags |= BNXT_FLOW_PARSE_INNER_FLAG;
284
285 break;
286 case RTE_FLOW_ITEM_TYPE_VLAN:
287 vlan_spec = item->spec;
288
289 if (item->mask)
290 vlan_mask = item->mask;
291 else
292 vlan_mask = &rte_flow_item_vlan_mask;
293
294 if (en & en_ethertype) {
295 rte_flow_error_set(error, EINVAL,
296 RTE_FLOW_ERROR_TYPE_ITEM,
297 item,
298 "VLAN TPID matching is not"
299 " supported");
300 return -rte_errno;
301 }
302 if (vlan_mask->tci &&
303 vlan_mask->tci == RTE_BE16(0x0fff)) {
304 /* Only the VLAN ID can be matched. */
305 filter->l2_ovlan =
306 rte_be_to_cpu_16(vlan_spec->tci &
307 RTE_BE16(0x0fff));
308 en |= EM_FLOW_ALLOC_INPUT_EN_OVLAN_VID;
309 } else {
310 rte_flow_error_set(error,
311 EINVAL,
312 RTE_FLOW_ERROR_TYPE_ITEM,
313 item,
314 "VLAN mask is invalid");
315 return -rte_errno;
316 }
317 if (vlan_mask->inner_type &&
318 vlan_mask->inner_type != RTE_BE16(0xffff)) {
319 rte_flow_error_set(error, EINVAL,
320 RTE_FLOW_ERROR_TYPE_ITEM,
321 item,
322 "inner ethertype mask not"
323 " valid");
324 return -rte_errno;
325 }
326 if (vlan_mask->inner_type) {
327 filter->ethertype =
328 rte_be_to_cpu_16(vlan_spec->inner_type);
329 en |= en_ethertype;
330 }
331
332 break;
333 case RTE_FLOW_ITEM_TYPE_IPV4:
334 /* If mask is not involved, we could use EM filters. */
335 ipv4_spec = item->spec;
336
337 if (!item->spec)
338 break;
339
340 if (item->mask)
341 ipv4_mask = item->mask;
342 else
343 ipv4_mask = &rte_flow_item_ipv4_mask;
344
345 /* Only IP DST and SRC fields are maskable. */
346 if (ipv4_mask->hdr.version_ihl ||
347 ipv4_mask->hdr.type_of_service ||
348 ipv4_mask->hdr.total_length ||
349 ipv4_mask->hdr.packet_id ||
350 ipv4_mask->hdr.fragment_offset ||
351 ipv4_mask->hdr.time_to_live ||
352 ipv4_mask->hdr.next_proto_id ||
353 ipv4_mask->hdr.hdr_checksum) {
354 rte_flow_error_set(error,
355 EINVAL,
356 RTE_FLOW_ERROR_TYPE_ITEM,
357 item,
358 "Invalid IPv4 mask.");
359 return -rte_errno;
360 }
361
362 filter->dst_ipaddr[0] = ipv4_spec->hdr.dst_addr;
363 filter->src_ipaddr[0] = ipv4_spec->hdr.src_addr;
364
365 if (use_ntuple)
366 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR |
367 NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
368 else
369 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_IPADDR |
370 EM_FLOW_ALLOC_INPUT_EN_DST_IPADDR;
371
372 if (ipv4_mask->hdr.src_addr) {
373 filter->src_ipaddr_mask[0] =
374 ipv4_mask->hdr.src_addr;
375 en |= !use_ntuple ? 0 :
376 NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
377 }
378
379 if (ipv4_mask->hdr.dst_addr) {
380 filter->dst_ipaddr_mask[0] =
381 ipv4_mask->hdr.dst_addr;
382 en |= !use_ntuple ? 0 :
383 NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
384 }
385
386 filter->ip_addr_type = use_ntuple ?
387 HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_IP_ADDR_TYPE_IPV4 :
388 HWRM_CFA_EM_FLOW_ALLOC_INPUT_IP_ADDR_TYPE_IPV4;
389
390 if (ipv4_spec->hdr.next_proto_id) {
391 filter->ip_protocol =
392 ipv4_spec->hdr.next_proto_id;
393 if (use_ntuple)
394 en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
395 else
396 en |= EM_FLOW_ALLOC_INPUT_EN_IP_PROTO;
397 }
398 break;
399 case RTE_FLOW_ITEM_TYPE_IPV6:
400 ipv6_spec = item->spec;
401
402 if (!item->spec)
403 break;
404
405 if (item->mask)
406 ipv6_mask = item->mask;
407 else
408 ipv6_mask = &rte_flow_item_ipv6_mask;
409
410 /* Only IP DST and SRC fields are maskable. */
411 if (ipv6_mask->hdr.vtc_flow ||
412 ipv6_mask->hdr.payload_len ||
413 ipv6_mask->hdr.proto ||
414 ipv6_mask->hdr.hop_limits) {
415 rte_flow_error_set(error,
416 EINVAL,
417 RTE_FLOW_ERROR_TYPE_ITEM,
418 item,
419 "Invalid IPv6 mask.");
420 return -rte_errno;
421 }
422
423 if (use_ntuple)
424 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR |
425 NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
426 else
427 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_IPADDR |
428 EM_FLOW_ALLOC_INPUT_EN_DST_IPADDR;
429
430 rte_memcpy(filter->src_ipaddr,
431 ipv6_spec->hdr.src_addr, 16);
432 rte_memcpy(filter->dst_ipaddr,
433 ipv6_spec->hdr.dst_addr, 16);
434
435 if (!bnxt_check_zero_bytes(ipv6_mask->hdr.src_addr,
436 16)) {
437 rte_memcpy(filter->src_ipaddr_mask,
438 ipv6_mask->hdr.src_addr, 16);
439 en |= !use_ntuple ? 0 :
440 NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
441 }
442
443 if (!bnxt_check_zero_bytes(ipv6_mask->hdr.dst_addr,
444 16)) {
445 rte_memcpy(filter->dst_ipaddr_mask,
446 ipv6_mask->hdr.dst_addr, 16);
447 en |= !use_ntuple ? 0 :
448 NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
449 }
450
451 filter->ip_addr_type = use_ntuple ?
452 NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV6 :
453 EM_FLOW_ALLOC_INPUT_IP_ADDR_TYPE_IPV6;
454 break;
455 case RTE_FLOW_ITEM_TYPE_TCP:
456 tcp_spec = item->spec;
457
458 if (!item->spec)
459 break;
460
461 if (item->mask)
462 tcp_mask = item->mask;
463 else
464 tcp_mask = &rte_flow_item_tcp_mask;
465
466 /* Check TCP mask. Only DST & SRC ports are maskable */
467 if (tcp_mask->hdr.sent_seq ||
468 tcp_mask->hdr.recv_ack ||
469 tcp_mask->hdr.data_off ||
470 tcp_mask->hdr.tcp_flags ||
471 tcp_mask->hdr.rx_win ||
472 tcp_mask->hdr.cksum ||
473 tcp_mask->hdr.tcp_urp) {
474 rte_flow_error_set(error,
475 EINVAL,
476 RTE_FLOW_ERROR_TYPE_ITEM,
477 item,
478 "Invalid TCP mask");
479 return -rte_errno;
480 }
481
482 filter->src_port = tcp_spec->hdr.src_port;
483 filter->dst_port = tcp_spec->hdr.dst_port;
484
485 if (use_ntuple)
486 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT |
487 NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
488 else
489 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_PORT |
490 EM_FLOW_ALLOC_INPUT_EN_DST_PORT;
491
492 if (tcp_mask->hdr.dst_port) {
493 filter->dst_port_mask = tcp_mask->hdr.dst_port;
494 en |= !use_ntuple ? 0 :
495 NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
496 }
497
498 if (tcp_mask->hdr.src_port) {
499 filter->src_port_mask = tcp_mask->hdr.src_port;
500 en |= !use_ntuple ? 0 :
501 NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
502 }
503 break;
504 case RTE_FLOW_ITEM_TYPE_UDP:
505 udp_spec = item->spec;
506
507 if (!item->spec)
508 break;
509
510 if (item->mask)
511 udp_mask = item->mask;
512 else
513 udp_mask = &rte_flow_item_udp_mask;
514
515 if (udp_mask->hdr.dgram_len ||
516 udp_mask->hdr.dgram_cksum) {
517 rte_flow_error_set(error,
518 EINVAL,
519 RTE_FLOW_ERROR_TYPE_ITEM,
520 item,
521 "Invalid UDP mask");
522 return -rte_errno;
523 }
524
525 filter->src_port = udp_spec->hdr.src_port;
526 filter->dst_port = udp_spec->hdr.dst_port;
527
528 if (use_ntuple)
529 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT |
530 NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
531 else
532 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_PORT |
533 EM_FLOW_ALLOC_INPUT_EN_DST_PORT;
534
535 if (udp_mask->hdr.dst_port) {
536 filter->dst_port_mask = udp_mask->hdr.dst_port;
537 en |= !use_ntuple ? 0 :
538 NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
539 }
540
541 if (udp_mask->hdr.src_port) {
542 filter->src_port_mask = udp_mask->hdr.src_port;
543 en |= !use_ntuple ? 0 :
544 NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
545 }
546 break;
547 case RTE_FLOW_ITEM_TYPE_VXLAN:
548 vxlan_spec = item->spec;
549 vxlan_mask = item->mask;
550 /* Check if VXLAN item is used to describe protocol.
551 * If yes, both spec and mask should be NULL.
552 * If no, both spec and mask shouldn't be NULL.
553 */
554 if ((!vxlan_spec && vxlan_mask) ||
555 (vxlan_spec && !vxlan_mask)) {
556 rte_flow_error_set(error,
557 EINVAL,
558 RTE_FLOW_ERROR_TYPE_ITEM,
559 item,
560 "Invalid VXLAN item");
561 return -rte_errno;
562 }
563
564 if (!vxlan_spec && !vxlan_mask) {
565 filter->tunnel_type =
566 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN;
567 break;
568 }
569
570 if (vxlan_spec->rsvd1 || vxlan_spec->rsvd0[0] ||
571 vxlan_spec->rsvd0[1] || vxlan_spec->rsvd0[2] ||
572 vxlan_spec->flags != 0x8) {
573 rte_flow_error_set(error,
574 EINVAL,
575 RTE_FLOW_ERROR_TYPE_ITEM,
576 item,
577 "Invalid VXLAN item");
578 return -rte_errno;
579 }
580
581 /* Check if VNI is masked. */
582 if (vxlan_mask != NULL) {
583 vni_masked =
584 !!memcmp(vxlan_mask->vni, vni_mask,
585 RTE_DIM(vni_mask));
586 if (vni_masked) {
587 rte_flow_error_set
588 (error,
589 EINVAL,
590 RTE_FLOW_ERROR_TYPE_ITEM,
591 item,
592 "Invalid VNI mask");
593 return -rte_errno;
594 }
595
596 rte_memcpy(((uint8_t *)&tenant_id_be + 1),
597 vxlan_spec->vni, 3);
598 filter->vni =
599 rte_be_to_cpu_32(tenant_id_be);
600 filter->tunnel_type =
601 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN;
602 }
603 break;
604 case RTE_FLOW_ITEM_TYPE_NVGRE:
605 nvgre_spec = item->spec;
606 nvgre_mask = item->mask;
607 /* Check if NVGRE item is used to describe protocol.
608 * If yes, both spec and mask should be NULL.
609 * If no, both spec and mask shouldn't be NULL.
610 */
611 if ((!nvgre_spec && nvgre_mask) ||
612 (nvgre_spec && !nvgre_mask)) {
613 rte_flow_error_set(error,
614 EINVAL,
615 RTE_FLOW_ERROR_TYPE_ITEM,
616 item,
617 "Invalid NVGRE item");
618 return -rte_errno;
619 }
620
621 if (!nvgre_spec && !nvgre_mask) {
622 filter->tunnel_type =
623 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_NVGRE;
624 break;
625 }
626
627 if (nvgre_spec->c_k_s_rsvd0_ver != 0x2000 ||
628 nvgre_spec->protocol != 0x6558) {
629 rte_flow_error_set(error,
630 EINVAL,
631 RTE_FLOW_ERROR_TYPE_ITEM,
632 item,
633 "Invalid NVGRE item");
634 return -rte_errno;
635 }
636
637 if (nvgre_spec && nvgre_mask) {
638 tni_masked =
639 !!memcmp(nvgre_mask->tni, tni_mask,
640 RTE_DIM(tni_mask));
641 if (tni_masked) {
642 rte_flow_error_set
643 (error,
644 EINVAL,
645 RTE_FLOW_ERROR_TYPE_ITEM,
646 item,
647 "Invalid TNI mask");
648 return -rte_errno;
649 }
650 rte_memcpy(((uint8_t *)&tenant_id_be + 1),
651 nvgre_spec->tni, 3);
652 filter->vni =
653 rte_be_to_cpu_32(tenant_id_be);
654 filter->tunnel_type =
655 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_NVGRE;
656 }
657 break;
658
659 case RTE_FLOW_ITEM_TYPE_GRE:
660 gre_spec = (const struct rte_flow_item_gre *)item->spec;
661 gre_mask = (const struct rte_flow_item_gre *)item->mask;
662
663 /*
664 *Check if GRE item is used to describe protocol.
665 * If yes, both spec and mask should be NULL.
666 * If no, both spec and mask shouldn't be NULL.
667 */
668 if (!!gre_spec ^ !!gre_mask) {
669 rte_flow_error_set(error, EINVAL,
670 RTE_FLOW_ERROR_TYPE_ITEM,
671 item,
672 "Invalid GRE item");
673 return -rte_errno;
674 }
675
676 if (!gre_spec && !gre_mask) {
677 filter->tunnel_type =
678 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_IPGRE;
679 break;
680 }
681 break;
682
683 case RTE_FLOW_ITEM_TYPE_VF:
684 vf_spec = item->spec;
685 vf = vf_spec->id;
686 if (!BNXT_PF(bp)) {
687 rte_flow_error_set(error,
688 EINVAL,
689 RTE_FLOW_ERROR_TYPE_ITEM,
690 item,
691 "Configuring on a VF!");
692 return -rte_errno;
693 }
694
695 if (vf >= bp->pdev->max_vfs) {
696 rte_flow_error_set(error,
697 EINVAL,
698 RTE_FLOW_ERROR_TYPE_ITEM,
699 item,
700 "Incorrect VF id!");
701 return -rte_errno;
702 }
703
704 if (!attr->transfer) {
705 rte_flow_error_set(error,
706 ENOTSUP,
707 RTE_FLOW_ERROR_TYPE_ITEM,
708 item,
709 "Matching VF traffic without"
710 " affecting it (transfer attribute)"
711 " is unsupported");
712 return -rte_errno;
713 }
714
715 filter->mirror_vnic_id =
716 dflt_vnic = bnxt_hwrm_func_qcfg_vf_dflt_vnic_id(bp, vf);
717 if (dflt_vnic < 0) {
718 /* This simply indicates there's no driver
719 * loaded. This is not an error.
720 */
721 rte_flow_error_set
722 (error,
723 EINVAL,
724 RTE_FLOW_ERROR_TYPE_ITEM,
725 item,
726 "Unable to get default VNIC for VF");
727 return -rte_errno;
728 }
729
730 filter->mirror_vnic_id = dflt_vnic;
731 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_MIRROR_VNIC_ID;
732 break;
733 default:
734 break;
735 }
736 item++;
737 }
738 filter->enables = en;
739 filter->valid_flags = valid_flags;
740
741 /* Items parsed but no filter to create in HW. */
742 if (filter->enables == 0 && filter->valid_flags == 0)
743 filter->filter_type = HWRM_CFA_CONFIG;
744
745 return 0;
746 }
747
748 /* Parse attributes */
749 static int
bnxt_flow_parse_attr(const struct rte_flow_attr * attr,struct rte_flow_error * error)750 bnxt_flow_parse_attr(const struct rte_flow_attr *attr,
751 struct rte_flow_error *error)
752 {
753 /* Must be input direction */
754 if (!attr->ingress) {
755 rte_flow_error_set(error,
756 EINVAL,
757 RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,
758 attr,
759 "Only support ingress.");
760 return -rte_errno;
761 }
762
763 /* Not supported */
764 if (attr->egress) {
765 rte_flow_error_set(error,
766 EINVAL,
767 RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,
768 attr,
769 "No support for egress.");
770 return -rte_errno;
771 }
772
773 return 0;
774 }
775
776 static struct bnxt_filter_info *
bnxt_find_matching_l2_filter(struct bnxt * bp,struct bnxt_filter_info * nf)777 bnxt_find_matching_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf)
778 {
779 struct bnxt_filter_info *mf, *f0;
780 struct bnxt_vnic_info *vnic0;
781 int i;
782
783 vnic0 = BNXT_GET_DEFAULT_VNIC(bp);
784 f0 = STAILQ_FIRST(&vnic0->filter);
785
786 /* This flow has same DST MAC as the port/l2 filter. */
787 if (memcmp(f0->l2_addr, nf->dst_macaddr, RTE_ETHER_ADDR_LEN) == 0)
788 return f0;
789
790 for (i = bp->max_vnics - 1; i >= 0; i--) {
791 struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
792
793 if (vnic->fw_vnic_id == INVALID_VNIC_ID)
794 continue;
795
796 STAILQ_FOREACH(mf, &vnic->filter, next) {
797
798 if (mf->matching_l2_fltr_ptr)
799 continue;
800
801 if (mf->ethertype == nf->ethertype &&
802 mf->l2_ovlan == nf->l2_ovlan &&
803 mf->l2_ovlan_mask == nf->l2_ovlan_mask &&
804 mf->l2_ivlan == nf->l2_ivlan &&
805 mf->l2_ivlan_mask == nf->l2_ivlan_mask &&
806 !memcmp(mf->src_macaddr, nf->src_macaddr,
807 RTE_ETHER_ADDR_LEN) &&
808 !memcmp(mf->dst_macaddr, nf->dst_macaddr,
809 RTE_ETHER_ADDR_LEN))
810 return mf;
811 }
812 }
813 return NULL;
814 }
815
816 static struct bnxt_filter_info *
bnxt_create_l2_filter(struct bnxt * bp,struct bnxt_filter_info * nf,struct bnxt_vnic_info * vnic)817 bnxt_create_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf,
818 struct bnxt_vnic_info *vnic)
819 {
820 struct bnxt_filter_info *filter1;
821 int rc;
822
823 /* Alloc new L2 filter.
824 * This flow needs MAC filter which does not match any existing
825 * L2 filters.
826 */
827 filter1 = bnxt_get_unused_filter(bp);
828 if (filter1 == NULL)
829 return NULL;
830
831 memcpy(filter1, nf, sizeof(*filter1));
832
833 filter1->flags = HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_XDP_DISABLE;
834 filter1->flags |= HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_PATH_RX;
835 if (nf->valid_flags & BNXT_FLOW_L2_SRC_VALID_FLAG ||
836 nf->valid_flags & BNXT_FLOW_L2_DST_VALID_FLAG) {
837 filter1->flags |=
838 HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;
839 PMD_DRV_LOG(DEBUG, "Create Outer filter\n");
840 }
841
842 if (nf->filter_type == HWRM_CFA_L2_FILTER &&
843 (nf->valid_flags & BNXT_FLOW_L2_SRC_VALID_FLAG ||
844 nf->valid_flags & BNXT_FLOW_L2_INNER_SRC_VALID_FLAG)) {
845 PMD_DRV_LOG(DEBUG, "Create L2 filter for SRC MAC\n");
846 filter1->flags |=
847 HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_SOURCE_VALID;
848 memcpy(filter1->l2_addr, nf->src_macaddr, RTE_ETHER_ADDR_LEN);
849 } else {
850 PMD_DRV_LOG(DEBUG, "Create L2 filter for DST MAC\n");
851 memcpy(filter1->l2_addr, nf->dst_macaddr, RTE_ETHER_ADDR_LEN);
852 }
853
854 if (nf->priority &&
855 (nf->valid_flags & BNXT_FLOW_L2_DST_VALID_FLAG ||
856 nf->valid_flags & BNXT_FLOW_L2_INNER_DST_VALID_FLAG)) {
857 /* Tell the FW where to place the filter in the table. */
858 if (nf->priority > 65535) {
859 filter1->pri_hint =
860 HWRM_CFA_L2_FILTER_ALLOC_INPUT_PRI_HINT_BELOW_FILTER;
861 /* This will place the filter in TCAM */
862 filter1->l2_filter_id_hint = (uint64_t)-1;
863 }
864 }
865
866 if (nf->valid_flags & (BNXT_FLOW_L2_DST_VALID_FLAG |
867 BNXT_FLOW_L2_SRC_VALID_FLAG |
868 BNXT_FLOW_L2_INNER_SRC_VALID_FLAG |
869 BNXT_FLOW_L2_INNER_DST_VALID_FLAG)) {
870 filter1->enables =
871 HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_ADDR |
872 L2_FILTER_ALLOC_INPUT_EN_L2_ADDR_MASK;
873 memset(filter1->l2_addr_mask, 0xff, RTE_ETHER_ADDR_LEN);
874 }
875
876 if (nf->valid_flags & BNXT_FLOW_L2_DROP_FLAG) {
877 filter1->flags |=
878 HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_DROP;
879 if (nf->ethertype == RTE_ETHER_TYPE_IPV4) {
880 /* Num VLANs for drop filter will/should be 0.
881 * If the req is memset to 0, then the count will
882 * be automatically set to 0.
883 */
884 if (nf->valid_flags & BNXT_FLOW_PARSE_INNER_FLAG) {
885 filter1->enables |=
886 L2_FILTER_ALLOC_INPUT_EN_T_NUM_VLANS;
887 } else {
888 filter1->enables |=
889 L2_FILTER_ALLOC_INPUT_EN_NUM_VLANS;
890 filter1->flags |=
891 HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;
892 }
893 }
894 }
895
896 rc = bnxt_hwrm_set_l2_filter(bp, vnic->fw_vnic_id,
897 filter1);
898 if (rc) {
899 bnxt_free_filter(bp, filter1);
900 return NULL;
901 }
902 return filter1;
903 }
904
905 struct bnxt_filter_info *
bnxt_get_l2_filter(struct bnxt * bp,struct bnxt_filter_info * nf,struct bnxt_vnic_info * vnic)906 bnxt_get_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf,
907 struct bnxt_vnic_info *vnic)
908 {
909 struct bnxt_filter_info *l2_filter = NULL;
910
911 l2_filter = bnxt_find_matching_l2_filter(bp, nf);
912 if (l2_filter) {
913 l2_filter->l2_ref_cnt++;
914 } else {
915 l2_filter = bnxt_create_l2_filter(bp, nf, vnic);
916 if (l2_filter) {
917 STAILQ_INSERT_TAIL(&vnic->filter, l2_filter, next);
918 l2_filter->vnic = vnic;
919 }
920 }
921 nf->matching_l2_fltr_ptr = l2_filter;
922
923 return l2_filter;
924 }
925
bnxt_vnic_cleanup(struct bnxt * bp,struct bnxt_vnic_info * vnic)926 static void bnxt_vnic_cleanup(struct bnxt *bp, struct bnxt_vnic_info *vnic)
927 {
928 if (vnic->rx_queue_cnt > 1)
929 bnxt_hwrm_vnic_ctx_free(bp, vnic);
930
931 bnxt_hwrm_vnic_free(bp, vnic);
932
933 rte_free(vnic->fw_grp_ids);
934 vnic->fw_grp_ids = NULL;
935
936 vnic->rx_queue_cnt = 0;
937 }
938
bnxt_vnic_prep(struct bnxt * bp,struct bnxt_vnic_info * vnic,const struct rte_flow_action * act,struct rte_flow_error * error)939 static int bnxt_vnic_prep(struct bnxt *bp, struct bnxt_vnic_info *vnic,
940 const struct rte_flow_action *act,
941 struct rte_flow_error *error)
942 {
943 struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
944 uint64_t rx_offloads = dev_conf->rxmode.offloads;
945 int rc;
946
947 if (bp->nr_vnics > bp->max_vnics - 1)
948 return rte_flow_error_set(error, EINVAL,
949 RTE_FLOW_ERROR_TYPE_ATTR_GROUP,
950 NULL,
951 "Group id is invalid");
952
953 rc = bnxt_vnic_grp_alloc(bp, vnic);
954 if (rc)
955 return rte_flow_error_set(error, -rc,
956 RTE_FLOW_ERROR_TYPE_ACTION,
957 act,
958 "Failed to alloc VNIC group");
959
960 rc = bnxt_hwrm_vnic_alloc(bp, vnic);
961 if (rc) {
962 rte_flow_error_set(error, -rc,
963 RTE_FLOW_ERROR_TYPE_ACTION,
964 act,
965 "Failed to alloc VNIC");
966 goto ret;
967 }
968
969 /* RSS context is required only when there is more than one RSS ring */
970 if (vnic->rx_queue_cnt > 1) {
971 rc = bnxt_hwrm_vnic_ctx_alloc(bp, vnic, 0);
972 if (rc) {
973 rte_flow_error_set(error, -rc,
974 RTE_FLOW_ERROR_TYPE_ACTION,
975 act,
976 "Failed to alloc VNIC context");
977 goto ret;
978 }
979 }
980
981 if (rx_offloads & RTE_ETH_RX_OFFLOAD_VLAN_STRIP)
982 vnic->vlan_strip = true;
983 else
984 vnic->vlan_strip = false;
985
986 rc = bnxt_hwrm_vnic_cfg(bp, vnic);
987 if (rc) {
988 rte_flow_error_set(error, -rc,
989 RTE_FLOW_ERROR_TYPE_ACTION,
990 act,
991 "Failed to configure VNIC");
992 goto ret;
993 }
994
995 rc = bnxt_hwrm_vnic_plcmode_cfg(bp, vnic);
996 if (rc) {
997 rte_flow_error_set(error, -rc,
998 RTE_FLOW_ERROR_TYPE_ACTION,
999 act,
1000 "Failed to configure VNIC plcmode");
1001 goto ret;
1002 }
1003
1004 bp->nr_vnics++;
1005
1006 return 0;
1007
1008 ret:
1009 bnxt_vnic_cleanup(bp, vnic);
1010 return rc;
1011 }
1012
match_vnic_rss_cfg(struct bnxt * bp,struct bnxt_vnic_info * vnic,const struct rte_flow_action_rss * rss)1013 static int match_vnic_rss_cfg(struct bnxt *bp,
1014 struct bnxt_vnic_info *vnic,
1015 const struct rte_flow_action_rss *rss)
1016 {
1017 unsigned int match = 0, i;
1018
1019 if (vnic->rx_queue_cnt != rss->queue_num)
1020 return -EINVAL;
1021
1022 for (i = 0; i < rss->queue_num; i++) {
1023 if (!bp->rx_queues[rss->queue[i]]->vnic->rx_queue_cnt &&
1024 !bp->rx_queues[rss->queue[i]]->rx_started)
1025 return -EINVAL;
1026 }
1027
1028 for (i = 0; i < vnic->rx_queue_cnt; i++) {
1029 int j;
1030
1031 for (j = 0; j < vnic->rx_queue_cnt; j++) {
1032 if (bp->grp_info[rss->queue[i]].fw_grp_id ==
1033 vnic->fw_grp_ids[j])
1034 match++;
1035 }
1036 }
1037
1038 if (match != vnic->rx_queue_cnt) {
1039 PMD_DRV_LOG(ERR,
1040 "VNIC queue count %d vs queues matched %d\n",
1041 match, vnic->rx_queue_cnt);
1042 return -EINVAL;
1043 }
1044
1045 return 0;
1046 }
1047
1048 static void
bnxt_update_filter_flags_en(struct bnxt_filter_info * filter,struct bnxt_filter_info * filter1,int use_ntuple)1049 bnxt_update_filter_flags_en(struct bnxt_filter_info *filter,
1050 struct bnxt_filter_info *filter1,
1051 int use_ntuple)
1052 {
1053 if (!use_ntuple &&
1054 !(filter->valid_flags &
1055 ~(BNXT_FLOW_L2_DST_VALID_FLAG |
1056 BNXT_FLOW_L2_SRC_VALID_FLAG |
1057 BNXT_FLOW_L2_INNER_SRC_VALID_FLAG |
1058 BNXT_FLOW_L2_INNER_DST_VALID_FLAG |
1059 BNXT_FLOW_L2_DROP_FLAG |
1060 BNXT_FLOW_PARSE_INNER_FLAG))) {
1061 filter->flags = filter1->flags;
1062 filter->enables = filter1->enables;
1063 filter->filter_type = HWRM_CFA_L2_FILTER;
1064 memcpy(filter->l2_addr, filter1->l2_addr, RTE_ETHER_ADDR_LEN);
1065 memset(filter->l2_addr_mask, 0xff, RTE_ETHER_ADDR_LEN);
1066 filter->pri_hint = filter1->pri_hint;
1067 filter->l2_filter_id_hint = filter1->l2_filter_id_hint;
1068 }
1069 filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
1070 filter->l2_ref_cnt = filter1->l2_ref_cnt;
1071 filter->flow_id = filter1->flow_id;
1072 PMD_DRV_LOG(DEBUG,
1073 "l2_filter: %p fw_l2_filter_id %" PRIx64 " l2_ref_cnt %u\n",
1074 filter1, filter->fw_l2_filter_id, filter->l2_ref_cnt);
1075 }
1076
1077 static int
bnxt_validate_rss_action(const struct rte_flow_action actions[])1078 bnxt_validate_rss_action(const struct rte_flow_action actions[])
1079 {
1080 for (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {
1081 switch (actions->type) {
1082 case RTE_FLOW_ACTION_TYPE_VOID:
1083 break;
1084 case RTE_FLOW_ACTION_TYPE_RSS:
1085 break;
1086 default:
1087 return -ENOTSUP;
1088 }
1089 }
1090
1091 return 0;
1092 }
1093
1094 static int
bnxt_get_vnic(struct bnxt * bp,uint32_t group)1095 bnxt_get_vnic(struct bnxt *bp, uint32_t group)
1096 {
1097 int vnic_id = 0;
1098
1099 /* For legacy NS3 based implementations,
1100 * group_id will be mapped to a VNIC ID.
1101 */
1102 if (BNXT_STINGRAY(bp))
1103 vnic_id = group;
1104
1105 /* Non NS3 cases, group_id will be ignored.
1106 * Setting will be configured on default VNIC.
1107 */
1108 return vnic_id;
1109 }
1110
1111 static int
bnxt_vnic_rss_cfg_update(struct bnxt * bp,struct bnxt_vnic_info * vnic,const struct rte_flow_action * act,struct rte_flow_error * error)1112 bnxt_vnic_rss_cfg_update(struct bnxt *bp,
1113 struct bnxt_vnic_info *vnic,
1114 const struct rte_flow_action *act,
1115 struct rte_flow_error *error)
1116 {
1117 const struct rte_flow_action_rss *rss;
1118 unsigned int rss_idx, i, j, fw_idx;
1119 uint16_t hash_type;
1120 uint64_t types;
1121 int rc;
1122
1123 rss = (const struct rte_flow_action_rss *)act->conf;
1124
1125 /* must specify either all the Rx queues created by application or zero queues */
1126 if (rss->queue_num && vnic->rx_queue_cnt != rss->queue_num) {
1127 rte_flow_error_set(error,
1128 EINVAL,
1129 RTE_FLOW_ERROR_TYPE_ACTION,
1130 act,
1131 "Incorrect RXQ count");
1132 rc = -rte_errno;
1133 goto ret;
1134 }
1135
1136 /* Validate Rx queues */
1137 for (i = 0; i < rss->queue_num; i++) {
1138 PMD_DRV_LOG(DEBUG, "RSS action Queue %d\n", rss->queue[i]);
1139
1140 if (rss->queue[i] >= bp->rx_nr_rings ||
1141 !bp->rx_queues[rss->queue[i]]) {
1142 rte_flow_error_set(error,
1143 EINVAL,
1144 RTE_FLOW_ERROR_TYPE_ACTION,
1145 act,
1146 "Invalid queue ID for RSS");
1147 rc = -rte_errno;
1148 goto ret;
1149 }
1150 }
1151
1152 /* Duplicate queue ids are not supported. */
1153 for (i = 0; i < rss->queue_num; i++) {
1154 for (j = i + 1; j < rss->queue_num; j++) {
1155 if (rss->queue[i] == rss->queue[j]) {
1156 rte_flow_error_set(error,
1157 EINVAL,
1158 RTE_FLOW_ERROR_TYPE_ACTION,
1159 act,
1160 "Duplicate queue ID for RSS");
1161 rc = -rte_errno;
1162 goto ret;
1163 }
1164 }
1165 }
1166
1167 /* Currently only Toeplitz hash is supported. */
1168 if (rss->func != RTE_ETH_HASH_FUNCTION_DEFAULT &&
1169 rss->func != RTE_ETH_HASH_FUNCTION_TOEPLITZ) {
1170 rte_flow_error_set(error,
1171 ENOTSUP,
1172 RTE_FLOW_ERROR_TYPE_ACTION,
1173 act,
1174 "Unsupported RSS hash function");
1175 rc = -rte_errno;
1176 goto ret;
1177 }
1178
1179 /* key_len should match the hash key supported by hardware */
1180 if (rss->key_len != 0 && rss->key_len != HW_HASH_KEY_SIZE) {
1181 rte_flow_error_set(error,
1182 EINVAL,
1183 RTE_FLOW_ERROR_TYPE_ACTION,
1184 act,
1185 "Incorrect hash key parameters");
1186 rc = -rte_errno;
1187 goto ret;
1188 }
1189
1190 /* Currently RSS hash on inner and outer headers are supported.
1191 * 0 => Default (innermost RSS) setting
1192 * 1 => Outermost
1193 */
1194 if (rss->level > 1) {
1195 rte_flow_error_set(error,
1196 ENOTSUP,
1197 RTE_FLOW_ERROR_TYPE_ACTION,
1198 act,
1199 "Unsupported hash level");
1200 rc = -rte_errno;
1201 goto ret;
1202 }
1203
1204 if ((rss->queue_num == 0 && rss->queue != NULL) ||
1205 (rss->queue_num != 0 && rss->queue == NULL)) {
1206 rte_flow_error_set(error,
1207 EINVAL,
1208 RTE_FLOW_ERROR_TYPE_ACTION,
1209 act,
1210 "Invalid queue config specified");
1211 rc = -rte_errno;
1212 goto ret;
1213 }
1214
1215 /* If RSS types is 0, use a best effort configuration */
1216 types = rss->types ? rss->types : RTE_ETH_RSS_IPV4 | RTE_ETH_RSS_IPV6;
1217
1218 hash_type = bnxt_rte_to_hwrm_hash_types(types);
1219
1220 /* If requested types can't be supported, leave existing settings */
1221 if (hash_type)
1222 vnic->hash_type = hash_type;
1223
1224 vnic->hash_mode =
1225 bnxt_rte_to_hwrm_hash_level(bp, rss->types, rss->level);
1226
1227 /* Update RSS key only if key_len != 0 */
1228 if (rss->key_len != 0)
1229 memcpy(vnic->rss_hash_key, rss->key, rss->key_len);
1230
1231 if (rss->queue_num == 0)
1232 goto skip_rss_table;
1233
1234 /* Prepare the indirection table */
1235 for (rss_idx = 0, fw_idx = 0; rss_idx < HW_HASH_INDEX_SIZE;
1236 rss_idx++, fw_idx++) {
1237 uint8_t *rxq_state = bp->eth_dev->data->rx_queue_state;
1238 struct bnxt_rx_queue *rxq;
1239 uint32_t idx;
1240
1241 for (i = 0; i < bp->rx_cp_nr_rings; i++) {
1242 idx = rss->queue[fw_idx % rss->queue_num];
1243 if (rxq_state[idx] != RTE_ETH_QUEUE_STATE_STOPPED)
1244 break;
1245 fw_idx++;
1246 }
1247
1248 if (i == bp->rx_cp_nr_rings)
1249 return 0;
1250
1251 if (BNXT_CHIP_P5(bp)) {
1252 rxq = bp->rx_queues[idx];
1253 vnic->rss_table[rss_idx * 2] =
1254 rxq->rx_ring->rx_ring_struct->fw_ring_id;
1255 vnic->rss_table[rss_idx * 2 + 1] =
1256 rxq->cp_ring->cp_ring_struct->fw_ring_id;
1257 } else {
1258 vnic->rss_table[rss_idx] = vnic->fw_grp_ids[idx];
1259 }
1260 }
1261
1262 skip_rss_table:
1263 rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic);
1264 if (rc != 0) {
1265 rte_flow_error_set(error,
1266 -rc,
1267 RTE_FLOW_ERROR_TYPE_ACTION,
1268 act,
1269 "VNIC RSS configure failed");
1270 rc = -rte_errno;
1271 goto ret;
1272 }
1273 ret:
1274 return rc;
1275 }
1276
1277 static int
bnxt_validate_and_parse_flow(struct rte_eth_dev * dev,const struct rte_flow_item pattern[],const struct rte_flow_action actions[],const struct rte_flow_attr * attr,struct rte_flow_error * error,struct bnxt_filter_info * filter)1278 bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,
1279 const struct rte_flow_item pattern[],
1280 const struct rte_flow_action actions[],
1281 const struct rte_flow_attr *attr,
1282 struct rte_flow_error *error,
1283 struct bnxt_filter_info *filter)
1284 {
1285 const struct rte_flow_action *act =
1286 bnxt_flow_non_void_action(actions);
1287 struct bnxt *bp = dev->data->dev_private;
1288 struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
1289 struct bnxt_vnic_info *vnic = NULL, *vnic0 = NULL;
1290 const struct rte_flow_action_queue *act_q;
1291 const struct rte_flow_action_vf *act_vf;
1292 struct bnxt_filter_info *filter1 = NULL;
1293 const struct rte_flow_action_rss *rss;
1294 struct bnxt_rx_queue *rxq = NULL;
1295 int dflt_vnic, vnic_id;
1296 unsigned int rss_idx;
1297 uint32_t vf = 0, i;
1298 int rc, use_ntuple;
1299
1300 rc =
1301 bnxt_validate_and_parse_flow_type(bp, attr, pattern, error, filter);
1302 if (rc != 0)
1303 goto ret;
1304
1305 rc = bnxt_flow_parse_attr(attr, error);
1306 if (rc != 0)
1307 goto ret;
1308
1309 /* Since we support ingress attribute only - right now. */
1310 if (filter->filter_type == HWRM_CFA_EM_FILTER)
1311 filter->flags = HWRM_CFA_EM_FLOW_ALLOC_INPUT_FLAGS_PATH_RX;
1312
1313 use_ntuple = bnxt_filter_type_check(pattern, error);
1314
1315 start:
1316 switch (act->type) {
1317 case RTE_FLOW_ACTION_TYPE_QUEUE:
1318 /* Allow this flow. Redirect to a VNIC. */
1319 act_q = (const struct rte_flow_action_queue *)act->conf;
1320 if (!act_q->index || act_q->index >= bp->rx_nr_rings) {
1321 rte_flow_error_set(error,
1322 EINVAL,
1323 RTE_FLOW_ERROR_TYPE_ACTION,
1324 act,
1325 "Invalid queue ID.");
1326 rc = -rte_errno;
1327 goto ret;
1328 }
1329 PMD_DRV_LOG(DEBUG, "Queue index %d\n", act_q->index);
1330
1331 vnic_id = attr->group;
1332 if (!vnic_id) {
1333 PMD_DRV_LOG(DEBUG, "Group id is 0\n");
1334 vnic_id = act_q->index;
1335 }
1336
1337 BNXT_VALID_VNIC_OR_RET(bp, vnic_id);
1338
1339 vnic = &bp->vnic_info[vnic_id];
1340 if (vnic->rx_queue_cnt) {
1341 if (vnic->start_grp_id != act_q->index) {
1342 PMD_DRV_LOG(ERR,
1343 "VNIC already in use\n");
1344 rte_flow_error_set(error,
1345 EINVAL,
1346 RTE_FLOW_ERROR_TYPE_ACTION,
1347 act,
1348 "VNIC already in use");
1349 rc = -rte_errno;
1350 goto ret;
1351 }
1352 goto use_vnic;
1353 }
1354
1355 rxq = bp->rx_queues[act_q->index];
1356
1357 if (!(dev_conf->rxmode.mq_mode & RTE_ETH_MQ_RX_RSS) && rxq &&
1358 vnic->fw_vnic_id != INVALID_HW_RING_ID)
1359 goto use_vnic;
1360
1361 if (!rxq) {
1362 PMD_DRV_LOG(ERR,
1363 "Queue invalid or used with other VNIC\n");
1364 rte_flow_error_set(error,
1365 EINVAL,
1366 RTE_FLOW_ERROR_TYPE_ACTION,
1367 act,
1368 "Queue invalid queue or in use");
1369 rc = -rte_errno;
1370 goto ret;
1371 }
1372
1373 rxq->vnic = vnic;
1374 rxq->rx_started = 1;
1375 vnic->rx_queue_cnt++;
1376 vnic->start_grp_id = act_q->index;
1377 vnic->end_grp_id = act_q->index;
1378 vnic->func_default = 0; //This is not a default VNIC.
1379
1380 PMD_DRV_LOG(DEBUG, "VNIC found\n");
1381
1382 rc = bnxt_vnic_prep(bp, vnic, act, error);
1383 if (rc)
1384 goto ret;
1385
1386 PMD_DRV_LOG(DEBUG,
1387 "vnic[%d] = %p vnic->fw_grp_ids = %p\n",
1388 act_q->index, vnic, vnic->fw_grp_ids);
1389
1390 use_vnic:
1391 vnic->ff_pool_idx = vnic_id;
1392 PMD_DRV_LOG(DEBUG,
1393 "Setting vnic ff_idx %d\n", vnic->ff_pool_idx);
1394 filter->dst_id = vnic->fw_vnic_id;
1395
1396 /* For ntuple filter, create the L2 filter with default VNIC.
1397 * The user specified redirect queue will be set while creating
1398 * the ntuple filter in hardware.
1399 */
1400 vnic0 = BNXT_GET_DEFAULT_VNIC(bp);
1401 if (use_ntuple)
1402 filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1403 else
1404 filter1 = bnxt_get_l2_filter(bp, filter, vnic);
1405 if (filter1 == NULL) {
1406 rte_flow_error_set(error,
1407 ENOSPC,
1408 RTE_FLOW_ERROR_TYPE_ACTION,
1409 act,
1410 "Filter not available");
1411 rc = -rte_errno;
1412 goto ret;
1413 }
1414
1415 PMD_DRV_LOG(DEBUG, "new fltr: %p l2fltr: %p l2_ref_cnt: %d\n",
1416 filter, filter1, filter1->l2_ref_cnt);
1417 bnxt_update_filter_flags_en(filter, filter1, use_ntuple);
1418 break;
1419 case RTE_FLOW_ACTION_TYPE_DROP:
1420 vnic0 = &bp->vnic_info[0];
1421 filter->dst_id = vnic0->fw_vnic_id;
1422 filter->valid_flags |= BNXT_FLOW_L2_DROP_FLAG;
1423 filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1424 if (filter1 == NULL) {
1425 rte_flow_error_set(error,
1426 ENOSPC,
1427 RTE_FLOW_ERROR_TYPE_ACTION,
1428 act,
1429 "Filter not available");
1430 rc = -rte_errno;
1431 goto ret;
1432 }
1433
1434 if (filter->filter_type == HWRM_CFA_EM_FILTER)
1435 filter->flags =
1436 HWRM_CFA_EM_FLOW_ALLOC_INPUT_FLAGS_DROP;
1437 else if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1438 filter->flags =
1439 HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP;
1440
1441 bnxt_update_filter_flags_en(filter, filter1, use_ntuple);
1442 break;
1443 case RTE_FLOW_ACTION_TYPE_VF:
1444 act_vf = (const struct rte_flow_action_vf *)act->conf;
1445 vf = act_vf->id;
1446
1447 if (filter->tunnel_type ==
1448 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN ||
1449 filter->tunnel_type ==
1450 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_IPGRE) {
1451 /* If issued on a VF, ensure id is 0 and is trusted */
1452 if (BNXT_VF(bp)) {
1453 if (!BNXT_VF_IS_TRUSTED(bp) || vf) {
1454 rte_flow_error_set(error, EINVAL,
1455 RTE_FLOW_ERROR_TYPE_ACTION,
1456 act,
1457 "Incorrect VF");
1458 rc = -rte_errno;
1459 goto ret;
1460 }
1461 }
1462
1463 filter->enables |= filter->tunnel_type;
1464 filter->filter_type = HWRM_CFA_TUNNEL_REDIRECT_FILTER;
1465 goto done;
1466 }
1467
1468 if (vf >= bp->pdev->max_vfs) {
1469 rte_flow_error_set(error,
1470 EINVAL,
1471 RTE_FLOW_ERROR_TYPE_ACTION,
1472 act,
1473 "Incorrect VF id!");
1474 rc = -rte_errno;
1475 goto ret;
1476 }
1477
1478 filter->mirror_vnic_id =
1479 dflt_vnic = bnxt_hwrm_func_qcfg_vf_dflt_vnic_id(bp, vf);
1480 if (dflt_vnic < 0) {
1481 /* This simply indicates there's no driver loaded.
1482 * This is not an error.
1483 */
1484 rte_flow_error_set(error,
1485 EINVAL,
1486 RTE_FLOW_ERROR_TYPE_ACTION,
1487 act,
1488 "Unable to get default VNIC for VF");
1489 rc = -rte_errno;
1490 goto ret;
1491 }
1492
1493 filter->mirror_vnic_id = dflt_vnic;
1494 filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_MIRROR_VNIC_ID;
1495
1496 vnic0 = &bp->vnic_info[0];
1497 filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1498 if (filter1 == NULL) {
1499 rte_flow_error_set(error,
1500 ENOSPC,
1501 RTE_FLOW_ERROR_TYPE_ACTION,
1502 act,
1503 "New filter not available");
1504 rc = -rte_errno;
1505 goto ret;
1506 }
1507
1508 filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
1509 filter->flow_id = filter1->flow_id;
1510 break;
1511 case RTE_FLOW_ACTION_TYPE_RSS:
1512 rc = bnxt_validate_rss_action(actions);
1513 if (rc != 0) {
1514 rte_flow_error_set(error,
1515 EINVAL,
1516 RTE_FLOW_ERROR_TYPE_ACTION,
1517 act,
1518 "Invalid actions specified with RSS");
1519 rc = -rte_errno;
1520 goto ret;
1521 }
1522
1523 rss = (const struct rte_flow_action_rss *)act->conf;
1524
1525 vnic_id = bnxt_get_vnic(bp, attr->group);
1526
1527 BNXT_VALID_VNIC_OR_RET(bp, vnic_id);
1528 vnic = &bp->vnic_info[vnic_id];
1529
1530 /*
1531 * For non NS3 cases, rte_flow_items will not be considered
1532 * for RSS updates.
1533 */
1534 if (filter->filter_type == HWRM_CFA_CONFIG) {
1535 /* RSS config update requested */
1536 rc = bnxt_vnic_rss_cfg_update(bp, vnic, act, error);
1537 if (rc != 0)
1538 goto ret;
1539
1540 filter->dst_id = vnic->fw_vnic_id;
1541 break;
1542 }
1543
1544 /* Check if requested RSS config matches RSS config of VNIC
1545 * only if it is not a fresh VNIC configuration.
1546 * Otherwise the existing VNIC configuration can be used.
1547 */
1548 if (vnic->rx_queue_cnt) {
1549 rc = match_vnic_rss_cfg(bp, vnic, rss);
1550 if (rc) {
1551 PMD_DRV_LOG(ERR,
1552 "VNIC and RSS config mismatch\n");
1553 rte_flow_error_set(error,
1554 EINVAL,
1555 RTE_FLOW_ERROR_TYPE_ACTION,
1556 act,
1557 "VNIC and RSS cfg mismatch");
1558 rc = -rte_errno;
1559 goto ret;
1560 }
1561 goto vnic_found;
1562 }
1563
1564 for (i = 0; i < rss->queue_num; i++) {
1565 PMD_DRV_LOG(DEBUG, "RSS action Queue %d\n",
1566 rss->queue[i]);
1567
1568 if (!rss->queue[i] ||
1569 rss->queue[i] >= bp->rx_nr_rings ||
1570 !bp->rx_queues[rss->queue[i]]) {
1571 rte_flow_error_set(error,
1572 EINVAL,
1573 RTE_FLOW_ERROR_TYPE_ACTION,
1574 act,
1575 "Invalid queue ID for RSS");
1576 rc = -rte_errno;
1577 goto ret;
1578 }
1579 rxq = bp->rx_queues[rss->queue[i]];
1580
1581 if (bp->vnic_info[0].fw_grp_ids[rss->queue[i]] !=
1582 INVALID_HW_RING_ID) {
1583 PMD_DRV_LOG(ERR,
1584 "queue active with other VNIC\n");
1585 rte_flow_error_set(error,
1586 EINVAL,
1587 RTE_FLOW_ERROR_TYPE_ACTION,
1588 act,
1589 "Invalid queue ID for RSS");
1590 rc = -rte_errno;
1591 goto ret;
1592 }
1593
1594 rxq->vnic = vnic;
1595 rxq->rx_started = 1;
1596 vnic->rx_queue_cnt++;
1597 }
1598
1599 vnic->start_grp_id = rss->queue[0];
1600 vnic->end_grp_id = rss->queue[rss->queue_num - 1];
1601 vnic->func_default = 0; //This is not a default VNIC.
1602
1603 rc = bnxt_vnic_prep(bp, vnic, act, error);
1604 if (rc)
1605 goto ret;
1606
1607 PMD_DRV_LOG(DEBUG,
1608 "vnic[%d] = %p vnic->fw_grp_ids = %p\n",
1609 vnic_id, vnic, vnic->fw_grp_ids);
1610
1611 vnic->ff_pool_idx = vnic_id;
1612 PMD_DRV_LOG(DEBUG,
1613 "Setting vnic ff_pool_idx %d\n", vnic->ff_pool_idx);
1614
1615 /* This can be done only after vnic_grp_alloc is done. */
1616 for (i = 0; i < vnic->rx_queue_cnt; i++) {
1617 vnic->fw_grp_ids[i] =
1618 bp->grp_info[rss->queue[i]].fw_grp_id;
1619 /* Make sure vnic0 does not use these rings. */
1620 bp->vnic_info[0].fw_grp_ids[rss->queue[i]] =
1621 INVALID_HW_RING_ID;
1622 }
1623
1624 for (rss_idx = 0; rss_idx < HW_HASH_INDEX_SIZE; ) {
1625 for (i = 0; i < vnic->rx_queue_cnt; i++)
1626 vnic->rss_table[rss_idx++] =
1627 vnic->fw_grp_ids[i];
1628 }
1629
1630 /* Configure RSS only if the queue count is > 1 */
1631 if (vnic->rx_queue_cnt > 1) {
1632 vnic->hash_type =
1633 bnxt_rte_to_hwrm_hash_types(rss->types);
1634 vnic->hash_mode =
1635 bnxt_rte_to_hwrm_hash_level(bp, rss->types, rss->level);
1636
1637 if (!rss->key_len) {
1638 /* If hash key has not been specified,
1639 * use random hash key.
1640 */
1641 bnxt_prandom_bytes(vnic->rss_hash_key,
1642 HW_HASH_KEY_SIZE);
1643 } else {
1644 if (rss->key_len > HW_HASH_KEY_SIZE)
1645 memcpy(vnic->rss_hash_key,
1646 rss->key,
1647 HW_HASH_KEY_SIZE);
1648 else
1649 memcpy(vnic->rss_hash_key,
1650 rss->key,
1651 rss->key_len);
1652 }
1653 bnxt_hwrm_vnic_rss_cfg(bp, vnic);
1654 } else {
1655 PMD_DRV_LOG(DEBUG, "No RSS config required\n");
1656 }
1657
1658 vnic_found:
1659 filter->dst_id = vnic->fw_vnic_id;
1660 filter1 = bnxt_get_l2_filter(bp, filter, vnic);
1661 if (filter1 == NULL) {
1662 rte_flow_error_set(error,
1663 ENOSPC,
1664 RTE_FLOW_ERROR_TYPE_ACTION,
1665 act,
1666 "New filter not available");
1667 rc = -rte_errno;
1668 goto ret;
1669 }
1670
1671 PMD_DRV_LOG(DEBUG, "L2 filter created\n");
1672 bnxt_update_filter_flags_en(filter, filter1, use_ntuple);
1673 break;
1674 case RTE_FLOW_ACTION_TYPE_MARK:
1675 if (bp->mark_table == NULL) {
1676 rte_flow_error_set(error,
1677 ENOMEM,
1678 RTE_FLOW_ERROR_TYPE_ACTION,
1679 act,
1680 "Mark table not allocated.");
1681 rc = -rte_errno;
1682 goto ret;
1683 }
1684
1685 if (bp->flags & BNXT_FLAG_RX_VECTOR_PKT_MODE) {
1686 PMD_DRV_LOG(DEBUG,
1687 "Disabling vector processing for mark\n");
1688 bp->eth_dev->rx_pkt_burst = bnxt_recv_pkts;
1689 bp->flags &= ~BNXT_FLAG_RX_VECTOR_PKT_MODE;
1690 }
1691
1692 filter->valid_flags |= BNXT_FLOW_MARK_FLAG;
1693 filter->mark = ((const struct rte_flow_action_mark *)
1694 act->conf)->id;
1695 PMD_DRV_LOG(DEBUG, "Mark the flow %d\n", filter->mark);
1696 break;
1697 default:
1698 rte_flow_error_set(error,
1699 EINVAL,
1700 RTE_FLOW_ERROR_TYPE_ACTION,
1701 act,
1702 "Invalid action.");
1703 rc = -rte_errno;
1704 goto ret;
1705 }
1706
1707 done:
1708 act = bnxt_flow_non_void_action(++act);
1709 while (act->type != RTE_FLOW_ACTION_TYPE_END)
1710 goto start;
1711
1712 return rc;
1713 ret:
1714
1715 if (filter1) {
1716 bnxt_hwrm_clear_l2_filter(bp, filter1);
1717 bnxt_free_filter(bp, filter1);
1718 }
1719
1720 if (rte_errno) {
1721 if (vnic && STAILQ_EMPTY(&vnic->filter))
1722 vnic->rx_queue_cnt = 0;
1723
1724 if (rxq && !vnic->rx_queue_cnt)
1725 rxq->vnic = &bp->vnic_info[0];
1726 }
1727 return -rte_errno;
1728 }
1729
1730 static
find_matching_vnic(struct bnxt * bp,struct bnxt_filter_info * filter)1731 struct bnxt_vnic_info *find_matching_vnic(struct bnxt *bp,
1732 struct bnxt_filter_info *filter)
1733 {
1734 struct bnxt_vnic_info *vnic = NULL;
1735 unsigned int i;
1736
1737 for (i = 0; i < bp->max_vnics; i++) {
1738 vnic = &bp->vnic_info[i];
1739 if (vnic->fw_vnic_id != INVALID_VNIC_ID &&
1740 filter->dst_id == vnic->fw_vnic_id) {
1741 PMD_DRV_LOG(DEBUG, "Found matching VNIC Id %d\n",
1742 vnic->ff_pool_idx);
1743 return vnic;
1744 }
1745 }
1746 return NULL;
1747 }
1748
1749 static int
bnxt_flow_validate(struct rte_eth_dev * dev,const struct rte_flow_attr * attr,const struct rte_flow_item pattern[],const struct rte_flow_action actions[],struct rte_flow_error * error)1750 bnxt_flow_validate(struct rte_eth_dev *dev,
1751 const struct rte_flow_attr *attr,
1752 const struct rte_flow_item pattern[],
1753 const struct rte_flow_action actions[],
1754 struct rte_flow_error *error)
1755 {
1756 struct bnxt *bp = dev->data->dev_private;
1757 struct bnxt_vnic_info *vnic = NULL;
1758 struct bnxt_filter_info *filter;
1759 int ret = 0;
1760
1761 bnxt_acquire_flow_lock(bp);
1762 ret = bnxt_flow_args_validate(attr, pattern, actions, error);
1763 if (ret != 0) {
1764 bnxt_release_flow_lock(bp);
1765 return ret;
1766 }
1767
1768 filter = bnxt_get_unused_filter(bp);
1769 if (filter == NULL) {
1770 rte_flow_error_set(error, ENOSPC,
1771 RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1772 "Not enough resources for a new flow");
1773 bnxt_release_flow_lock(bp);
1774 return -ENOSPC;
1775 }
1776
1777 ret = bnxt_validate_and_parse_flow(dev, pattern, actions, attr,
1778 error, filter);
1779 if (ret)
1780 goto exit;
1781
1782 vnic = find_matching_vnic(bp, filter);
1783 if (vnic) {
1784 if (STAILQ_EMPTY(&vnic->filter)) {
1785 bnxt_vnic_cleanup(bp, vnic);
1786 bp->nr_vnics--;
1787 PMD_DRV_LOG(DEBUG, "Free VNIC\n");
1788 }
1789 }
1790
1791 if (filter->filter_type == HWRM_CFA_EM_FILTER)
1792 bnxt_hwrm_clear_em_filter(bp, filter);
1793 else if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1794 bnxt_hwrm_clear_ntuple_filter(bp, filter);
1795 else
1796 bnxt_hwrm_clear_l2_filter(bp, filter);
1797
1798 exit:
1799 /* No need to hold on to this filter if we are just validating flow */
1800 bnxt_free_filter(bp, filter);
1801 bnxt_release_flow_lock(bp);
1802
1803 return ret;
1804 }
1805
1806 static void
bnxt_update_filter(struct bnxt * bp,struct bnxt_filter_info * old_filter,struct bnxt_filter_info * new_filter)1807 bnxt_update_filter(struct bnxt *bp, struct bnxt_filter_info *old_filter,
1808 struct bnxt_filter_info *new_filter)
1809 {
1810 /* Clear the new L2 filter that was created in the previous step in
1811 * bnxt_validate_and_parse_flow. For L2 filters, we will use the new
1812 * filter which points to the new destination queue and so we clear
1813 * the previous L2 filter. For ntuple filters, we are going to reuse
1814 * the old L2 filter and create new NTUPLE filter with this new
1815 * destination queue subsequently during bnxt_flow_create. So we
1816 * decrement the ref cnt of the L2 filter that would've been bumped
1817 * up previously in bnxt_validate_and_parse_flow as the old n-tuple
1818 * filter that was referencing it will be deleted now.
1819 */
1820 bnxt_hwrm_clear_l2_filter(bp, old_filter);
1821 if (new_filter->filter_type == HWRM_CFA_L2_FILTER) {
1822 bnxt_hwrm_set_l2_filter(bp, new_filter->dst_id, new_filter);
1823 } else {
1824 if (new_filter->filter_type == HWRM_CFA_EM_FILTER)
1825 bnxt_hwrm_clear_em_filter(bp, old_filter);
1826 if (new_filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1827 bnxt_hwrm_clear_ntuple_filter(bp, old_filter);
1828 }
1829 }
1830
1831 static int
bnxt_match_filter(struct bnxt * bp,struct bnxt_filter_info * nf)1832 bnxt_match_filter(struct bnxt *bp, struct bnxt_filter_info *nf)
1833 {
1834 struct bnxt_filter_info *mf;
1835 struct rte_flow *flow;
1836 int i;
1837
1838 for (i = bp->max_vnics - 1; i >= 0; i--) {
1839 struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
1840
1841 if (vnic->fw_vnic_id == INVALID_VNIC_ID)
1842 continue;
1843
1844 STAILQ_FOREACH(flow, &vnic->flow_list, next) {
1845 mf = flow->filter;
1846
1847 if (mf->filter_type == nf->filter_type &&
1848 mf->flags == nf->flags &&
1849 mf->src_port == nf->src_port &&
1850 mf->src_port_mask == nf->src_port_mask &&
1851 mf->dst_port == nf->dst_port &&
1852 mf->dst_port_mask == nf->dst_port_mask &&
1853 mf->ip_protocol == nf->ip_protocol &&
1854 mf->ip_addr_type == nf->ip_addr_type &&
1855 mf->ethertype == nf->ethertype &&
1856 mf->vni == nf->vni &&
1857 mf->tunnel_type == nf->tunnel_type &&
1858 mf->l2_ovlan == nf->l2_ovlan &&
1859 mf->l2_ovlan_mask == nf->l2_ovlan_mask &&
1860 mf->l2_ivlan == nf->l2_ivlan &&
1861 mf->l2_ivlan_mask == nf->l2_ivlan_mask &&
1862 !memcmp(mf->l2_addr, nf->l2_addr,
1863 RTE_ETHER_ADDR_LEN) &&
1864 !memcmp(mf->l2_addr_mask, nf->l2_addr_mask,
1865 RTE_ETHER_ADDR_LEN) &&
1866 !memcmp(mf->src_macaddr, nf->src_macaddr,
1867 RTE_ETHER_ADDR_LEN) &&
1868 !memcmp(mf->dst_macaddr, nf->dst_macaddr,
1869 RTE_ETHER_ADDR_LEN) &&
1870 !memcmp(mf->src_ipaddr, nf->src_ipaddr,
1871 sizeof(nf->src_ipaddr)) &&
1872 !memcmp(mf->src_ipaddr_mask, nf->src_ipaddr_mask,
1873 sizeof(nf->src_ipaddr_mask)) &&
1874 !memcmp(mf->dst_ipaddr, nf->dst_ipaddr,
1875 sizeof(nf->dst_ipaddr)) &&
1876 !memcmp(mf->dst_ipaddr_mask, nf->dst_ipaddr_mask,
1877 sizeof(nf->dst_ipaddr_mask))) {
1878 if (mf->dst_id == nf->dst_id)
1879 return -EEXIST;
1880 /* Free the old filter, update flow
1881 * with new filter
1882 */
1883 bnxt_update_filter(bp, mf, nf);
1884 STAILQ_REMOVE(&vnic->filter, mf,
1885 bnxt_filter_info, next);
1886 STAILQ_INSERT_TAIL(&vnic->filter, nf, next);
1887 bnxt_free_filter(bp, mf);
1888 flow->filter = nf;
1889 return -EXDEV;
1890 }
1891 }
1892 }
1893 return 0;
1894 }
1895
1896 static void
bnxt_setup_flow_counter(struct bnxt * bp)1897 bnxt_setup_flow_counter(struct bnxt *bp)
1898 {
1899 if (bp->fw_cap & BNXT_FW_CAP_ADV_FLOW_COUNTERS &&
1900 !(bp->flags & BNXT_FLAG_FC_THREAD) && BNXT_FLOW_XSTATS_EN(bp)) {
1901 rte_eal_alarm_set(US_PER_S * BNXT_FC_TIMER,
1902 bnxt_flow_cnt_alarm_cb,
1903 (void *)bp);
1904 bp->flags |= BNXT_FLAG_FC_THREAD;
1905 }
1906 }
1907
bnxt_flow_cnt_alarm_cb(void * arg)1908 void bnxt_flow_cnt_alarm_cb(void *arg)
1909 {
1910 int rc = 0;
1911 struct bnxt *bp = arg;
1912
1913 if (!bp->flow_stat->rx_fc_out_tbl.va) {
1914 PMD_DRV_LOG(ERR, "bp->flow_stat->rx_fc_out_tbl.va is NULL?\n");
1915 bnxt_cancel_fc_thread(bp);
1916 return;
1917 }
1918
1919 if (!bp->flow_stat->flow_count) {
1920 bnxt_cancel_fc_thread(bp);
1921 return;
1922 }
1923
1924 if (!bp->eth_dev->data->dev_started) {
1925 bnxt_cancel_fc_thread(bp);
1926 return;
1927 }
1928
1929 rc = bnxt_flow_stats_req(bp);
1930 if (rc) {
1931 PMD_DRV_LOG(ERR, "Flow stat alarm not rescheduled.\n");
1932 return;
1933 }
1934
1935 rte_eal_alarm_set(US_PER_S * BNXT_FC_TIMER,
1936 bnxt_flow_cnt_alarm_cb,
1937 (void *)bp);
1938 }
1939
1940
1941 static struct rte_flow *
bnxt_flow_create(struct rte_eth_dev * dev,const struct rte_flow_attr * attr,const struct rte_flow_item pattern[],const struct rte_flow_action actions[],struct rte_flow_error * error)1942 bnxt_flow_create(struct rte_eth_dev *dev,
1943 const struct rte_flow_attr *attr,
1944 const struct rte_flow_item pattern[],
1945 const struct rte_flow_action actions[],
1946 struct rte_flow_error *error)
1947 {
1948 struct bnxt *bp = dev->data->dev_private;
1949 struct bnxt_vnic_info *vnic = NULL;
1950 struct bnxt_filter_info *filter;
1951 bool update_flow = false;
1952 struct rte_flow *flow;
1953 int ret = 0;
1954 uint32_t tun_type, flow_id;
1955
1956 if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp)) {
1957 rte_flow_error_set(error, EINVAL,
1958 RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1959 "Failed to create flow, Not a Trusted VF!");
1960 return NULL;
1961 }
1962
1963 if (!dev->data->dev_started) {
1964 rte_flow_error_set(error,
1965 EINVAL,
1966 RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
1967 NULL,
1968 "Device must be started");
1969 return NULL;
1970 }
1971
1972 flow = rte_zmalloc("bnxt_flow", sizeof(struct rte_flow), 0);
1973 if (!flow) {
1974 rte_flow_error_set(error, ENOMEM,
1975 RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1976 "Failed to allocate memory");
1977 return flow;
1978 }
1979
1980 bnxt_acquire_flow_lock(bp);
1981 ret = bnxt_flow_args_validate(attr, pattern, actions, error);
1982 if (ret != 0) {
1983 PMD_DRV_LOG(ERR, "Not a validate flow.\n");
1984 goto free_flow;
1985 }
1986
1987 filter = bnxt_get_unused_filter(bp);
1988 if (filter == NULL) {
1989 rte_flow_error_set(error, ENOSPC,
1990 RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1991 "Not enough resources for a new flow");
1992 goto free_flow;
1993 }
1994
1995 ret = bnxt_validate_and_parse_flow(dev, pattern, actions, attr,
1996 error, filter);
1997 if (ret != 0)
1998 goto free_filter;
1999
2000 ret = bnxt_match_filter(bp, filter);
2001 if (ret == -EEXIST) {
2002 PMD_DRV_LOG(DEBUG, "Flow already exists.\n");
2003 /* Clear the filter that was created as part of
2004 * validate_and_parse_flow() above
2005 */
2006 bnxt_hwrm_clear_l2_filter(bp, filter);
2007 goto free_filter;
2008 } else if (ret == -EXDEV) {
2009 PMD_DRV_LOG(DEBUG, "Flow with same pattern exists\n");
2010 PMD_DRV_LOG(DEBUG, "Updating with different destination\n");
2011 update_flow = true;
2012 }
2013
2014 /* If tunnel redirection to a VF/PF is specified then only tunnel_type
2015 * is set and enable is set to the tunnel type. Issue hwrm cmd directly
2016 * in such a case.
2017 */
2018 if (filter->filter_type == HWRM_CFA_TUNNEL_REDIRECT_FILTER &&
2019 filter->enables == filter->tunnel_type) {
2020 ret = bnxt_hwrm_tunnel_redirect_query(bp, &tun_type);
2021 if (ret) {
2022 rte_flow_error_set(error, -ret,
2023 RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
2024 "Unable to query tunnel to VF");
2025 goto free_filter;
2026 }
2027 if (tun_type == (1U << filter->tunnel_type)) {
2028 ret =
2029 bnxt_hwrm_tunnel_redirect_free(bp,
2030 filter->tunnel_type);
2031 if (ret) {
2032 PMD_DRV_LOG(ERR,
2033 "Unable to free existing tunnel\n");
2034 rte_flow_error_set(error, -ret,
2035 RTE_FLOW_ERROR_TYPE_HANDLE,
2036 NULL,
2037 "Unable to free preexisting "
2038 "tunnel on VF");
2039 goto free_filter;
2040 }
2041 }
2042 ret = bnxt_hwrm_tunnel_redirect(bp, filter->tunnel_type);
2043 if (ret) {
2044 rte_flow_error_set(error, -ret,
2045 RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
2046 "Unable to redirect tunnel to VF");
2047 goto free_filter;
2048 }
2049 vnic = &bp->vnic_info[0];
2050 goto done;
2051 }
2052
2053 if (filter->filter_type == HWRM_CFA_EM_FILTER) {
2054 filter->enables |=
2055 HWRM_CFA_EM_FLOW_ALLOC_INPUT_ENABLES_L2_FILTER_ID;
2056 ret = bnxt_hwrm_set_em_filter(bp, filter->dst_id, filter);
2057 if (ret != 0) {
2058 rte_flow_error_set(error, -ret,
2059 RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
2060 "Failed to create EM filter");
2061 goto free_filter;
2062 }
2063 }
2064
2065 if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER) {
2066 filter->enables |=
2067 HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_L2_FILTER_ID;
2068 ret = bnxt_hwrm_set_ntuple_filter(bp, filter->dst_id, filter);
2069 if (ret != 0) {
2070 rte_flow_error_set(error, -ret,
2071 RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
2072 "Failed to create ntuple filter");
2073 goto free_filter;
2074 }
2075 }
2076
2077 vnic = find_matching_vnic(bp, filter);
2078 done:
2079 if (!ret || update_flow) {
2080 flow->filter = filter;
2081 flow->vnic = vnic;
2082 if (update_flow) {
2083 ret = -EXDEV;
2084 goto free_flow;
2085 }
2086
2087 if (filter->valid_flags & BNXT_FLOW_MARK_FLAG) {
2088 PMD_DRV_LOG(DEBUG,
2089 "Mark action: mark id 0x%x, flow id 0x%x\n",
2090 filter->mark, filter->flow_id);
2091
2092 /* TCAM and EM should be 16-bit only.
2093 * Other modes not supported.
2094 */
2095 flow_id = filter->flow_id & BNXT_FLOW_ID_MASK;
2096 if (bp->mark_table[flow_id].valid) {
2097 rte_flow_error_set(error, EEXIST,
2098 RTE_FLOW_ERROR_TYPE_HANDLE,
2099 NULL,
2100 "Flow with mark id exists");
2101 bnxt_clear_one_vnic_filter(bp, filter);
2102 goto free_filter;
2103 }
2104 bp->mark_table[flow_id].valid = true;
2105 bp->mark_table[flow_id].mark_id = filter->mark;
2106 }
2107
2108 STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
2109 STAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);
2110
2111 if (BNXT_FLOW_XSTATS_EN(bp))
2112 bp->flow_stat->flow_count++;
2113 bnxt_release_flow_lock(bp);
2114 bnxt_setup_flow_counter(bp);
2115 PMD_DRV_LOG(DEBUG, "Successfully created flow.\n");
2116 return flow;
2117 }
2118
2119 free_filter:
2120 bnxt_free_filter(bp, filter);
2121 free_flow:
2122 if (ret == -EEXIST)
2123 rte_flow_error_set(error, ret,
2124 RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
2125 "Matching Flow exists.");
2126 else if (ret == -EXDEV)
2127 rte_flow_error_set(error, 0,
2128 RTE_FLOW_ERROR_TYPE_NONE, NULL,
2129 "Flow with pattern exists, updating destination queue");
2130 else if (!rte_errno)
2131 rte_flow_error_set(error, -ret,
2132 RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
2133 "Failed to create flow.");
2134 rte_free(flow);
2135 flow = NULL;
2136 bnxt_release_flow_lock(bp);
2137 return flow;
2138 }
2139
bnxt_handle_tunnel_redirect_destroy(struct bnxt * bp,struct bnxt_filter_info * filter,struct rte_flow_error * error)2140 static int bnxt_handle_tunnel_redirect_destroy(struct bnxt *bp,
2141 struct bnxt_filter_info *filter,
2142 struct rte_flow_error *error)
2143 {
2144 uint16_t tun_dst_fid;
2145 uint32_t tun_type;
2146 int ret = 0;
2147
2148 ret = bnxt_hwrm_tunnel_redirect_query(bp, &tun_type);
2149 if (ret) {
2150 rte_flow_error_set(error, -ret,
2151 RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
2152 "Unable to query tunnel to VF");
2153 return ret;
2154 }
2155 if (tun_type == (1U << filter->tunnel_type)) {
2156 ret = bnxt_hwrm_tunnel_redirect_info(bp, filter->tunnel_type,
2157 &tun_dst_fid);
2158 if (ret) {
2159 rte_flow_error_set(error, -ret,
2160 RTE_FLOW_ERROR_TYPE_HANDLE,
2161 NULL,
2162 "tunnel_redirect info cmd fail");
2163 return ret;
2164 }
2165 PMD_DRV_LOG(INFO, "Pre-existing tunnel fid = %x vf->fid = %x\n",
2166 tun_dst_fid + bp->first_vf_id, bp->fw_fid);
2167
2168 /* Tunnel doesn't belong to this VF, so don't send HWRM
2169 * cmd, just delete the flow from driver
2170 */
2171 if (bp->fw_fid != (tun_dst_fid + bp->first_vf_id)) {
2172 PMD_DRV_LOG(ERR,
2173 "Tunnel does not belong to this VF, skip hwrm_tunnel_redirect_free\n");
2174 } else {
2175 ret = bnxt_hwrm_tunnel_redirect_free(bp,
2176 filter->tunnel_type);
2177 if (ret) {
2178 rte_flow_error_set(error, -ret,
2179 RTE_FLOW_ERROR_TYPE_HANDLE,
2180 NULL,
2181 "Unable to free tunnel redirection");
2182 return ret;
2183 }
2184 }
2185 }
2186 return ret;
2187 }
2188
2189 static int
_bnxt_flow_destroy(struct bnxt * bp,struct rte_flow * flow,struct rte_flow_error * error)2190 _bnxt_flow_destroy(struct bnxt *bp,
2191 struct rte_flow *flow,
2192 struct rte_flow_error *error)
2193 {
2194 struct bnxt_filter_info *filter;
2195 struct bnxt_vnic_info *vnic;
2196 int ret = 0;
2197 uint32_t flow_id;
2198
2199 filter = flow->filter;
2200 vnic = flow->vnic;
2201
2202 if (filter->filter_type == HWRM_CFA_TUNNEL_REDIRECT_FILTER &&
2203 filter->enables == filter->tunnel_type) {
2204 ret = bnxt_handle_tunnel_redirect_destroy(bp, filter, error);
2205 if (!ret)
2206 goto done;
2207 else
2208 return ret;
2209 }
2210
2211 /* For config type, there is no filter in HW. Finish cleanup here */
2212 if (filter->filter_type == HWRM_CFA_CONFIG)
2213 goto done;
2214
2215 ret = bnxt_match_filter(bp, filter);
2216 if (ret == 0)
2217 PMD_DRV_LOG(ERR, "Could not find matching flow\n");
2218
2219 if (filter->valid_flags & BNXT_FLOW_MARK_FLAG) {
2220 flow_id = filter->flow_id & BNXT_FLOW_ID_MASK;
2221 memset(&bp->mark_table[flow_id], 0,
2222 sizeof(bp->mark_table[flow_id]));
2223 filter->flow_id = 0;
2224 }
2225
2226 ret = bnxt_clear_one_vnic_filter(bp, filter);
2227
2228 done:
2229 if (!ret) {
2230 /* If it is a L2 drop filter, when the filter is created,
2231 * the FW updates the BC/MC records.
2232 * Once this filter is removed, issue the set_rx_mask command
2233 * to reset the BC/MC records in the HW to the settings
2234 * before the drop counter is created.
2235 */
2236 if (filter->valid_flags & BNXT_FLOW_L2_DROP_FLAG)
2237 bnxt_set_rx_mask_no_vlan(bp, &bp->vnic_info[0]);
2238
2239 STAILQ_REMOVE(&vnic->filter, filter, bnxt_filter_info, next);
2240 bnxt_free_filter(bp, filter);
2241 STAILQ_REMOVE(&vnic->flow_list, flow, rte_flow, next);
2242 rte_free(flow);
2243 if (BNXT_FLOW_XSTATS_EN(bp))
2244 bp->flow_stat->flow_count--;
2245
2246 /* If this was the last flow associated with this vnic,
2247 * switch the queue back to RSS pool.
2248 */
2249 if (vnic && !vnic->func_default &&
2250 STAILQ_EMPTY(&vnic->flow_list)) {
2251 bnxt_vnic_cleanup(bp, vnic);
2252 bp->nr_vnics--;
2253 }
2254 } else {
2255 rte_flow_error_set(error, -ret,
2256 RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
2257 "Failed to destroy flow.");
2258 }
2259
2260 return ret;
2261 }
2262
2263 static int
bnxt_flow_destroy(struct rte_eth_dev * dev,struct rte_flow * flow,struct rte_flow_error * error)2264 bnxt_flow_destroy(struct rte_eth_dev *dev,
2265 struct rte_flow *flow,
2266 struct rte_flow_error *error)
2267 {
2268 struct bnxt *bp = dev->data->dev_private;
2269 int ret = 0;
2270
2271 bnxt_acquire_flow_lock(bp);
2272 if (!flow) {
2273 rte_flow_error_set(error, EINVAL,
2274 RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
2275 "Invalid flow: failed to destroy flow.");
2276 bnxt_release_flow_lock(bp);
2277 return -EINVAL;
2278 }
2279
2280 if (!flow->filter) {
2281 rte_flow_error_set(error, EINVAL,
2282 RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
2283 "Invalid flow: failed to destroy flow.");
2284 bnxt_release_flow_lock(bp);
2285 return -EINVAL;
2286 }
2287 ret = _bnxt_flow_destroy(bp, flow, error);
2288 bnxt_release_flow_lock(bp);
2289
2290 return ret;
2291 }
2292
bnxt_cancel_fc_thread(struct bnxt * bp)2293 void bnxt_cancel_fc_thread(struct bnxt *bp)
2294 {
2295 bp->flags &= ~BNXT_FLAG_FC_THREAD;
2296 rte_eal_alarm_cancel(bnxt_flow_cnt_alarm_cb, (void *)bp);
2297 }
2298
2299 static int
bnxt_flow_flush(struct rte_eth_dev * dev,struct rte_flow_error * error)2300 bnxt_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)
2301 {
2302 struct bnxt *bp = dev->data->dev_private;
2303 struct bnxt_vnic_info *vnic;
2304 struct rte_flow *flow;
2305 unsigned int i;
2306 int ret = 0;
2307
2308 bnxt_acquire_flow_lock(bp);
2309 for (i = 0; i < bp->max_vnics; i++) {
2310 vnic = &bp->vnic_info[i];
2311 if (vnic && vnic->fw_vnic_id == INVALID_VNIC_ID)
2312 continue;
2313
2314 while (!STAILQ_EMPTY(&vnic->flow_list)) {
2315 flow = STAILQ_FIRST(&vnic->flow_list);
2316
2317 if (!flow->filter)
2318 continue;
2319
2320 ret = _bnxt_flow_destroy(bp, flow, error);
2321 if (ret)
2322 break;
2323 }
2324 }
2325
2326 bnxt_cancel_fc_thread(bp);
2327 bnxt_release_flow_lock(bp);
2328
2329 return ret;
2330 }
2331
2332 const struct rte_flow_ops bnxt_flow_ops = {
2333 .validate = bnxt_flow_validate,
2334 .create = bnxt_flow_create,
2335 .destroy = bnxt_flow_destroy,
2336 .flush = bnxt_flow_flush,
2337 };
2338