Cranelift: ISLE recursion check (#12474)

* add decl rec attribute

* implement recursion check

* add required `req` attributes

* document the `RecursionError` variant

* add required `req` attribu

Cranelift: ISLE recursion check (#12474)

* add decl rec attribute

* implement recursion check

* add required `req` attributes

* document the `RecursionError` variant

* add required `req` attributes to pully ISLE rules

* add `rec` to isle example

* use dfs for cycle detection

* document the `rec` attribute

* recursion safety comments

* "is permitted to be recursive"

* fix documentation of RecursionError variant

show more ...

Fix various broken links in docs. (#12125)

We've gotten a few one-off link-fix PRs, so in the Wasmtime meeting
today we decided to just fix them all ourselves so we don't get these
drive-by PRs anym

Fix various broken links in docs. (#12125)

We've gotten a few one-off link-fix PRs, so in the Wasmtime meeting
today we decided to just fix them all ourselves so we don't get these
drive-by PRs anymore (or at least not for a while, until links start to
rot again).

This PR fixes all applicable broken links we could find via the `lychee`
link-checker (thanks abrown for running that!). There are a few broken
links in subrepositories that this doesn't fix. And the link-checker
doesn't like links to subheaders on `.html` paths derived from `.md`
files by mdbook -- mdbook doesn't support these (rust-lang/mdBook#167)
but they render fine once published to the Web.

show more ...

chore: fix parenthesis balance (#10317)

parentheses are not balanced here

ISLE: fix more glitches in BNF (#9973)

* ensure not to consume const-ident as ident

* fix <spec>

* add missing `resultc` keyword

* correct <instantiate>

* Revert "add missing `resultc` keyword"

ISLE: fix more glitches in BNF (#9973)

* ensure not to consume const-ident as ident

* fix <spec>

* add missing `resultc` keyword

* correct <instantiate>

* Revert "add missing `resultc` keyword"

This reverts commit e2529f0d678b239db9fb64832ca8c1300cd4d44f.

* add <spec-bv> syntax

* glitch

* bitvec width is optional

* distinguish <spec_bv> from <ident>

show more ...

isle: BNF glitches (#9920)

* isle: BNF <int> glitch

such that it wouldn't match wildcard `_`

* fix `extern const` syntax

ISLE: improve syntax BNF (#9903)

* ISLE: improve syntax BNF

* fixes

fix typo (#9906)

Signed-off-by: Jack Drogon <[email protected]>

ISLE: Add proper bool type (#9593)

* ISLE: add proper booleans (expressions)

Copyright (c) 2024, Arm Limited.

Signed-off-by: Karl Meakin <[email protected]>

* ISLE: add proper booleans (pattern

ISLE: Add proper bool type (#9593)

* ISLE: add proper booleans (expressions)

Copyright (c) 2024, Arm Limited.

Signed-off-by: Karl Meakin <[email protected]>

* ISLE: add proper booleans (patterns)

Copyright (c) 2024, Arm Limited.

Signed-off-by: Karl Meakin <[email protected]>

* ISLE: add proper booleans (spec expressions)

Copyright (c) 2024, Arm Limited.

Signed-off-by: Karl Meakin <[email protected]>

* ISLE: replace opaque boolean constants

Copyright (c) 2024, Arm Limited.

Replace all occurences of `$true` and `$false` with `true` and `false`.

Signed-off-by: Karl Meakin <[email protected]>

* ISLE: remove `on_lhs` argument

Instead of threading `on_lhs` through all the calls to `translate_expr`,
we can just set `is_partial` and `is_pure` on `root_flags` to true.

Copyright (c) 2024, Arm Limited.

Signed-off-by: Karl Meakin <[email protected]>

* ISLE: add proper booleans (language reference)

Copyright (c) 2024, Arm Limited.

Signed-off-by: Karl Meakin <[email protected]>

---------

Signed-off-by: Karl Meakin <[email protected]>

show more ...

ISLE: update language reference (#9517)

The language specified in `language-reference.md` and the language
recognised by `parser.rs` had drifted out of sync. Update the language
reference to match t

ISLE: update language reference (#9517)

The language specified in `language-reference.md` and the language
recognised by `parser.rs` had drifted out of sync. Update the language
reference to match the actual language more closely.

Copyright (c) 2024, Arm Limited.

Signed-off-by: Karl Meakin <[email protected]>

show more ...

ISLE: Add block comments (#9529)

* ISLE: add block comments

Closes #3542

Copyright (c) 2024, Arm Limited.

Signed-off-by: Karl Meakin <[email protected]>

* ISLE: add comment syntax to language

ISLE: Add block comments (#9529)

* ISLE: add block comments

Closes #3542

Copyright (c) 2024, Arm Limited.

Signed-off-by: Karl Meakin <[email protected]>

* ISLE: add comment syntax to language reference

Copyright (c) 2024, Arm Limited.

Signed-off-by: Karl Meakin <[email protected]>

* ISLE: align definition of whitespace and newlines with wasm spec

The ISLE language is superficially similar to WebAssembly, so to reduce
confusion I think it would help to copy the wasm spec where possible.

This is technically a breaking change, since `\x0C` (`\f`) will no longer be
lexed as whitespace, but this character is exceedingly rare in practice.

Copyright (c) 2024, Arm Limited.

Signed-off-by: Karl Meakin <[email protected]>

---------

Signed-off-by: Karl Meakin <[email protected]>

show more ...

ISLE: remove Scheme-style boolean syntax (#9522)

The `#t` and `#f` syntax is misleading: they are actually integer
expressions, not booleans, so `#t` represents the integer `1` but *not*
the boolean

ISLE: remove Scheme-style boolean syntax (#9522)

The `#t` and `#f` syntax is misleading: they are actually integer
expressions, not booleans, so `#t` represents the integer `1` but *not*
the boolean `true`. They have been replaced by the named constants
`$true` and `$false`, and not used anywhere except tests, so they can be
removed without breaking any lowering/optimization code.

Copyright (c) 2024, Arm Limited.

Signed-off-by: Karl Meakin <[email protected]>

show more ...

Fix some typos (#8641)

* occurred

* winch typos

* tests typos

* cli typos

* fuzz typos

* examples typos

* docs typos

* crates/wasmtime typos

* crates/environ typos

* crates/cranelift typos

Fix some typos (#8641)

* occurred

* winch typos

* tests typos

* cli typos

* fuzz typos

* examples typos

* docs typos

* crates/wasmtime typos

* crates/environ typos

* crates/cranelift typos

* crates/test-programs typos

* crates/c-api typos

* crates/cache typos

* crates other typos

* cranelift/codegen/src/isa typos

* cranelift/codegen/src other typos

* cranelift/codegen other typos

* cranelift other typos

* ci js typo

* .github workflows typo

* RELEASES typo

* Fix clang-format documentation line

---------

Co-authored-by: Andrew Brown <[email protected]>

show more ...

Fix broken link in ISLE language reference (#7577)

riscv64: Further optimize constants loading (#7139)

* Further optimize RISCV constant loading

* Simplify existing rule

* Fix

* Bless missing tests

* Use right signedness for Imm20

Add support for binary/octal literals to ISLE (#6234)

* Add support for binary/octal literals to ISLE

In a number of x64-changes recently some u8 immediates are interpreted
as four bit-packed 2-bit

Add support for binary/octal literals to ISLE (#6234)

* Add support for binary/octal literals to ISLE

In a number of x64-changes recently some u8 immediates are interpreted
as four bit-packed 2-bit numbers and I have a tough time going between
hex and these bit-packed numbers. I've been writing `0xAA == 0b...` in
comments to indicate the intent but I figured it'd be a bit clearer if
the binary literal was accepted directly!

This is a minor update to the ISLE lexer to allow for binary `0b00...`
and octal `0o00...` literals in the same manner as hex literals. Some
comments in the x64 backend are then removed to use the binary literal
syntax directly.

* Update ISLE reference for octal/binary

* Update ISLE tests for octal/binary

show more ...

Add `partial` keyword to ISLE reference (#6076)

Noticed this was missing, tried to add based on the comments in https://github.com/bytecodealliance/wasmtime/pull/5392 (CC @jameysharp)

Fix a mistake in the language reference (#4352)

It is clear that the third rule does not contribute to the rewriting of the expression `(A (B (D 42)))` to `(C (D 42))` to `(E 42)`.

Fix some typos in the isle language reference (#4248)

ISLE: remove all uses of argument polarity, and remove it from the language. (#4091)

This PR removes "argument polarity": the feature of ISLE extractors that lets them take
inputs aside from the va

ISLE: remove all uses of argument polarity, and remove it from the language. (#4091)

This PR removes "argument polarity": the feature of ISLE extractors that lets them take
inputs aside from the value to be matched.

Cases that need this expressivity have been subsumed by #4072 with if-let clauses;
we can now finally remove this misfeature of the language, which has caused significant
confusion and has always felt like a bit of a hack.

This PR (i) removes the feature from the ISLE compiler; (ii) removes it from the reference
documentation; and (iii) refactors away all uses of the feature in our three existing
backends written in ISLE.

show more ...

ISLE language reference: move subsection to proper section. (#4087)

In #4072 I mistakenly put the subsection about if-let clauses in the
language doc just below the next section header, so it's in

ISLE language reference: move subsection to proper section. (#4087)

In #4072 I mistakenly put the subsection about if-let clauses in the
language doc just below the next section header, so it's in the wrong
section ("mapping to Rust"). This moves it back upward to where it
should be. Sorry about that!

show more ...

ISLE: add support for extended left-hand sides with `if-let` clauses. (#4072)

This PR adds support for `if-let` clauses, as proposed in
bytecodealliance/rfcs#21. These clauses augment the left-hand

ISLE: add support for extended left-hand sides with `if-let` clauses. (#4072)

This PR adds support for `if-let` clauses, as proposed in
bytecodealliance/rfcs#21. These clauses augment the left-hand side
(pattern-matching phase) of rules in the ISLE instruction-selection DSL
with sub-patterns matching on sub-expressions. The ability to list
additional match operations to perform, out-of-line from the original
toplevel pattern, greatly simplifies some idioms. See the RFC for more
details and examples of use.

show more ...

Remove `=x` uses from ISLE, and remove support from the DSL compiler. (#4078)

This is a follow-up on #4074: now that we have the simplified syntax, we
can remove the old, redundant syntax.

Implicit type conversions in ISLE (#3807)

Add support for implicit type conversions to ISLE.

This feature allows the DSL user to register to the compiler that a
particular term (used as a constr

Implicit type conversions in ISLE (#3807)

Add support for implicit type conversions to ISLE.

This feature allows the DSL user to register to the compiler that a
particular term (used as a constructor or extractor) converts from one
type to another. The compiler will then *automatically* insert this term
whenever a type mismatch involving that specific pair of types occurs.

This significantly cleans up many uses of the ISLE DSL. For example,
when defining the compiler backends, we often have newtypes like `Gpr`
around `Reg` (signifying a particular type of register); we can define
a conversion from Gpr to Reg automatically.

Conversions can also have side-effects, as long as these side-effects
are idempotent. For example, `put_value_in_reg` in a compiler backend
has the effect of marking the value as used, causing codegen to produce
it, and assigns a register to the value; but multiple invocations of
this will return the same register for the same value. Thus it is safe
to use it as an implicit conversion that may be invoked multiple times.
This is documented in the ISLE-Cranelift integration document.

This PR also adds some testing infrastructure to the ISLE compiler,
checking that "pass" tests pass through the DSL compiler, "fail" tests
do not, and "link" tests are able to generate code and link that code
with corresponding Rust code.

show more ...

Add link to ISLE language reference to ISLE Cranelift integration doc.

Move ISLE docs into cranelift/isle/docs/ and update links.