Fold the `wasmtime-error` crate into `wasmtime-core` (#12418)

Similar to #12398 and #12407 the idea is that all our dependency-free
(mostly) data structures and foundational data-types are in one lo

Fold the `wasmtime-error` crate into `wasmtime-core` (#12418)

Similar to #12398 and #12407 the idea is that all our dependency-free
(mostly) data structures and foundational data-types are in one location
to centralize testing, ergonomics, documentation, idioms, etc.

show more ...

Define a fallible-allocation-only version of `EntitySet` in `wasmtime-environ` (#12384)

* Add methods for fallible allocation to `cranelift_entity::EntitySet`

Part of https://github.com/bytecodeall

Define a fallible-allocation-only version of `EntitySet` in `wasmtime-environ` (#12384)

* Add methods for fallible allocation to `cranelift_entity::EntitySet`

Part of https://github.com/bytecodealliance/wasmtime/issues/12069

* Define a fallible-allocation-only version of `EntitySet` in `wasmtime-environ`

Part of https://github.com/bytecodealliance/wasmtime/issues/12069

show more ...

Add methods for fallible allocation to `cranelift_entity::EntitySet` (#12383)

Part of https://github.com/bytecodealliance/wasmtime/issues/12069

Enable the `clippy::multiple_bound_locations` lint (#11404)

This opts-in to a new Clippy lint which is intended to help clean up
historical refactorings to ensure that bounds on type parameters are

Enable the `clippy::multiple_bound_locations` lint (#11404)

This opts-in to a new Clippy lint which is intended to help clean up
historical refactorings to ensure that bounds on type parameters are
either in the type parameter declaration or in a `where` clause, but not
both.

show more ...

Implement Tarjan's strongly-connected components algorithm (#11239)

* Implement Tarjan's strongly-connected components algorithm

This commit implements [Tarjan's algorithm] for finding strongly-con

Implement Tarjan's strongly-connected components algorithm (#11239)

* Implement Tarjan's strongly-connected components algorithm

This commit implements [Tarjan's algorithm] for finding strongly-connected
components.

This algorithm takes `O(V+E)` time and uses `O(V+E)` space.

Tarjan's algorithm is usually presented as a recursive algorithm, but we do not
trust the input and cannot recurse over it for fear of blowing the
stack. Therefore, this implementation is iterative.

This will be used to do bottom-up inlining in Wasmtime's compilation
orchestration.

[Tarjan's algorithm]: https://en.wikipedia.org/wiki/Tarjan%27s_strongly_connected_components_algorithm

* address review feedback

show more ...

Update nightly used in CI (#10957)

A new lint was added to rustc so this updates the nightly used in CI and
then additionally fixes the lints that are firing.

Update Wasmtime to the 2024 Rust Edition (#10806)

* Update Wasmtime to the 2024 Rust Edition

Now that our MSRV supports the 2024 edition it's possible to make this
switch. This commit moves Wasmtim

Update Wasmtime to the 2024 Rust Edition (#10806)

* Update Wasmtime to the 2024 Rust Edition

Now that our MSRV supports the 2024 edition it's possible to make this
switch. This commit moves Wasmtime to the 2024 Edition to keep
up-to-date with Rust idioms and access many of the edition features
exclusive to the 2024 edition.

prtest:full

* Reformat with the 2024 edition

show more ...

`cranelift-frontend`: Propagate needs-stack-map from variables to values during finalization (#10468)

* cranelift-frontend: Propagate needs-stack-map from variables to values during finalization

Ra

`cranelift-frontend`: Propagate needs-stack-map from variables to values during finalization (#10468)

* cranelift-frontend: Propagate needs-stack-map from variables to values during finalization

Rather than trying to propagate the needs-stack-map bit from variables to values
online, while we are building the IR and defining and using variables, wait
until the function is being finalized, and then propagate everything all at
once. This avoids potential repeated work and is easier to ensure that it is
complete and covers all values associated with a variable, since by the time we
are finalizing the function, we won't add any new values for a variable that we
will need to keep track of and propagate this information to.

This also means that we can remove the `params_added_to_blocks` vector from the
SSA side effects structure, since it was only used to online-update the
`stack_map_values` set.

* Initialize the env-logger in `#[wasmtime_test]`

* Fix needs-stack-map set iteration

For reasons I do not understand, the `EntitySet::keys` method includes keys that
are not in the set, and we have unit tests asserting this bizarre behavior. Very
perplexing. So I added a new method to iterate over just the elements of the
set.

show more ...

Tiny improvements for `cranelift_entity::EntitySet` (#10469)

* Document return value of `EntitySet::insert`

* Implement a better `Debug` implementation for `EntitySet`

Derive serde on EntitySet when feature is enabled (#10368)

* Derive serde on EntitySet when feature is enabled

* Add cranelift-entity cargo check

cranelift-entity: Add a method to pre-reserve capacity to `EntitySet` (#9069)

Just exposing functionality that already exists in the underlying bitset
implementation.

Will be used in a follow-up pu

cranelift-entity: Add a method to pre-reserve capacity to `EntitySet` (#9069)

Just exposing functionality that already exists in the underlying bitset
implementation.

Will be used in a follow-up pull request.

show more ...

cranelift-entity: Implement `Extend` for `EntitySet` (#9068)

Co-authored-by: Trevor Elliott <[email protected]>

`cranelift-entity`: Implement `EntitySet` in terms of `cranelift_bitset::CompoundBitSet` (#8834)

* cranelift-entity: Implement `EntitySet` in terms of `cranelift_bitset::CompoundBitSet`

* Shrink th

`cranelift-entity`: Implement `EntitySet` in terms of `cranelift_bitset::CompoundBitSet` (#8834)

* cranelift-entity: Implement `EntitySet` in terms of `cranelift_bitset::CompoundBitSet`

* Shrink the size of `CompoundBitSet` so we don't perturb vmctx size test expectations

* Update vmctx size test expectations anyways because we shrunk "too much"

* Move `cranelift-bitset` to the front of `CRATES_TO_PUBLISH`

show more ...

cranelift-entity: Remove the unused `EntitySet::cardinality` method (#8827)

Fix some typos (#8641)

* occurred

* winch typos

* tests typos

* cli typos

* fuzz typos

* examples typos

* docs typos

* crates/wasmtime typos

* crates/environ typos

* crates/cranelift typos

Fix some typos (#8641)

* occurred

* winch typos

* tests typos

* cli typos

* fuzz typos

* examples typos

* docs typos

* crates/wasmtime typos

* crates/environ typos

* crates/cranelift typos

* crates/test-programs typos

* crates/c-api typos

* crates/cache typos

* crates other typos

* cranelift/codegen/src/isa typos

* cranelift/codegen/src other typos

* cranelift/codegen other typos

* cranelift other typos

* ci js typo

* .github workflows typo

* RELEASES typo

* Fix clang-format documentation line

---------

Co-authored-by: Andrew Brown <[email protected]>

show more ...

cranelift-entity: improve `EntitySet::cardinality()` implementation (#6066)

* Simplify 'EntitySet::cardinality()'

* Fix test

cranelift-entity: more efficient `EntitySet` implementation (#5978)

* Use usize intead of u8

* Rename 'byte's to appropriate words

cranelift-frontend: SSA-building cleanup (#4984)

* Cleanups to cranelift-frontend SSA construction

* Encode sealed/undef_variables relationship in type

A block can't have any undef_variables i

cranelift-frontend: SSA-building cleanup (#4984)

* Cleanups to cranelift-frontend SSA construction

* Encode sealed/undef_variables relationship in type

A block can't have any undef_variables if it is sealed. It's useful to
make that fact explicit in the types so that any time either value is
used, it's clear that we should think about the other one too.

In addition, encoding this fact in an enum type lets Rust apply an
optimization that reduces the size of SSABlockData by 8 bytes, making it
fit in a 64-byte cache line. I haven't taken the extra step of making
SSABlockData be 64-byte aligned because 1) it doesn't seem to have a
performance impact and b) doing so makes other structures quite a bit
bigger.

* Simplify finish_predecessors_lookup

Using Vec::drain is more concise than a combination of
iter().rev().take() followed by Vec::truncate. And in this case it
doesn't matter what order we examine the results in, because we just
want to know if they're all equal, so we might as well iterate forward
instead of in reverse.

There's no need for the ZeroOneOrMore enum. Instead, there are only two
cases: either we have a single value to use for the variable (possibly
synthesized as a constant zero), or we need to add a block parameter in
every predecessor.

Pre-filtering the results iterator to eliminate the sentinel makes it
easy to identify how many distinct definitions this variable has.
iter.next() indicates if there are any definitions at all, and then
iter.all() is a clear way to express that we want to know if the
remaining definitions are the same as the first one.

* Simplify append_jump_argument

* Avoid assigning default() into SecondaryMap

This eliminates some redundant reads and writes.

* cranelift-frontend: Construct with default()

This eliminates a bunch of boilerplate in favor of a built in `derive`
macro.

Also I'm deleting an import that had the comment "FIXME: Remove in
edition2021", which we've been using everywhere since April.

* Fix tests

show more ...

Mass rename Ebb and relatives to Block (#1365)

* Manually rename BasicBlock to BlockPredecessor

BasicBlock is a pair of (Ebb, Inst) that is used to represent the
basic block subcomponent of an E

Mass rename Ebb and relatives to Block (#1365)

* Manually rename BasicBlock to BlockPredecessor

BasicBlock is a pair of (Ebb, Inst) that is used to represent the
basic block subcomponent of an Ebb that is a predecessor to an Ebb.

Eventually we will be able to remove this struct, but for now it
makes sense to give it a non-conflicting name so that we can start
to transition Ebb to represent a basic block.

I have not updated any comments that refer to BasicBlock, as
eventually we will remove BlockPredecessor and replace with Block,
which is a basic block, so the comments will become correct.

* Manually rename SSABuilder block types to avoid conflict

SSABuilder has its own Block and BlockData types. These along with
associated identifier will cause conflicts in a later commit, so
they are renamed to be more verbose here.

* Automatically rename 'Ebb' to 'Block' in *.rs

* Automatically rename 'EBB' to 'block' in *.rs

* Automatically rename 'ebb' to 'block' in *.rs

* Automatically rename 'extended basic block' to 'basic block' in *.rs

* Automatically rename 'an basic block' to 'a basic block' in *.rs

* Manually update comment for `Block`

`Block`'s wikipedia article required an update.

* Automatically rename 'an `Block`' to 'a `Block`' in *.rs

* Automatically rename 'extended_basic_block' to 'basic_block' in *.rs

* Automatically rename 'ebb' to 'block' in *.clif

* Manually rename clif constant that contains 'ebb' as substring to avoid conflict

* Automatically rename filecheck uses of 'EBB' to 'BB'

'regex: EBB' -> 'regex: BB'
'$EBB' -> '$BB'

* Automatically rename 'EBB' 'Ebb' to 'block' in *.clif

* Automatically rename 'an block' to 'a block' in *.clif

* Fix broken testcase when function name length increases

Test function names are limited to 16 characters. This causes
the new longer name to be truncated and fail a filecheck test. An
outdated comment was also fixed.

show more ...

Fix clippy warnings.

This commit fixes the current set of (stable) clippy warnings in the repo.

Rustfmt

Remove std feature from cranelift-entity

Replaced instances of SparseSet with EntitySet

Cranelift: implement redundant fill removal on tree-shaped CFG regions. Mozilla bug 1570584. (#906)

moved crates in lib/ to src/, renamed crates, modified some files' text (#660)

moved crates in lib/ to src/, renamed crates, modified some files' text (#660)