Cranelift: pulley: don't use call{1,2,3,4} opcodes with PreserveAll ABI. (#12213)

These Pulley instructions are an optimization: they incorporate moves
from other registers to x0/x1/x2/x3 as part of

Cranelift: pulley: don't use call{1,2,3,4} opcodes with PreserveAll ABI. (#12213)

These Pulley instructions are an optimization: they incorporate moves
from other registers to x0/x1/x2/x3 as part of the call itself.

This works fine for the default calling convention, but the logic that
absorbs these moves and removes them from the list given to the rest of
the VCode/ABI machinery embeds a tacit assumption: the argument
registers are volatile (caller-saved). In particular, this is because
the call{1,2,3,4} instructions are *not* marked as clobbering
x0/x1/x2/x3 explicitly.

To fix this issue, this PR simply omits the magical folding that happens
in the emission code. An alternative would be to try to add the clobbers
to the special instructions, but actually we don't want these to be just
"clobbers": we want the usual regalloc constraints to take effect and
the values to be represented as continuing valid/live in the registers
after return, and the proper way to do that is to leave the `args` on
the call and let the regalloc operand pass add the fixed-reg operands.

Discovered while trying to land #12183.

show more ...

Cranelift: make all non-tail, non-indirect calls patchable, and rename patchable ABI to `preserve_all`. (#12160)

* Cranelift: make all non-tail, non-indirect calls patchable, and rename patchable AB

Cranelift: make all non-tail, non-indirect calls patchable, and rename patchable ABI to `preserve_all`. (#12160)

* Cranelift: make all non-tail, non-indirect calls patchable, and rename patchable ABI to `preserve_all`.

As discussed in this week's Cranelift meeting, we've discovered a need
to generalize the `patchable_call` mechanism and corresponding
`patchable` ABI slightly. In particular, we will need patchable
`try_call` callsites as well in order to allow breakpoint handlers to
throw exceptions (desirable functionality eventually) and have this work
in the presence of inlining. Also, it's just a nice generalization to
say that patchability is an orthogonal dimension to the call ABI and the
other restrictions we initially imposed, and works as long as the basic
requirement (no return values) is met.

This also renames the `patchable` ABI to `preserve_all`, to make it
clear that its purpose is actually orthogonal, and it can be used
independently of patchable callsites. It also deletes the `cold` ABI,
which never actually did anything and is misleading in the presence of
an actual cold-ish (subzero temperature, actually) ABI like
`preserve_all`.

* Review feedback.

show more ...

pulley: Implement support for `symbol_value` (#11576)

This commit fills out the Pulley lowerings of the `symbol_value` and
`func_addr` CLIF instructions. Additionally handling of relocations on
Pull

pulley: Implement support for `symbol_value` (#11576)

This commit fills out the Pulley lowerings of the `symbol_value` and
`func_addr` CLIF instructions. Additionally handling of relocations on
Pulley is improved to be more "formal" as opposed to just blindly using
an x64 relocation and assuming it works out. The intention here is to
make Pulley behave more similarly to other platforms in all these
respects while also enabling usage of Wasmtime to eventually use
`symbol_addr` to calculate an address relative to the current PC
(similar to x64).

This includes Cranelift golden tests as well as more filetests being
run, but the actual integration into Wasmtime will be deferred to a
future commit.

show more ...

Remove `expect(clippy::allow_attributes_without_reason)` from cranelift-codegen (#11182)

* Remove `expect(clippy::allow_attributes_without_reason)` from cranelift-codegen

This commit gets around to

Remove `expect(clippy::allow_attributes_without_reason)` from cranelift-codegen (#11182)

* Remove `expect(clippy::allow_attributes_without_reason)` from cranelift-codegen

This commit gets around to migrating the `cranelift-codegen` crate to
require a reason on lint directives and additionally switch to
`#[expect]` where possible.

prtest:full

* Move x64-only item to x64 backend

show more ...