Fix/suppress new GCC 12/13 warnings (#1192)

Signed-off-by: Dmitri Mokhov <[email protected]>

Optimize x86 atomic_fence (#328)

* Added optimized x86 atomic_fence for gcc-compatible compilers.

On x86 (32 and 64-bit) any lock-prefixed instruction provides sequential
consistency guarantees

Optimize x86 atomic_fence (#328)

* Added optimized x86 atomic_fence for gcc-compatible compilers.

On x86 (32 and 64-bit) any lock-prefixed instruction provides sequential
consistency guarantees for atomic operations and is more efficient than
mfence.

We are choosing a "lock not" on a dummy byte on the stack for the following
reasons:

- The "not" instruction does not affect flags or clobber any registers.
The memory operand is presumably accessible through esp/rsp.
- The dummy byte variable is at the top of the stack, which is likely
hot in cache.
- The dummy variable does not alias any other data on the stack, which
means the "lock not" instruction won't introduce any false data
dependencies with prior or following instructions.

In order to avoid various sanitizers and valgrind complaining, we have to
initialize the dummy variable to zero prior to the operation.

Additionally, for memory orders weaker than seq_cst there is no need for
any special instructions, and we only need a compiler fence. For the relaxed
memory order we don't need even that.

This optimization is only enabled for gcc up to version 11. In gcc 11 the
compiler implements a similar optimization for std::atomic_thread_fence.
Compilers compatible with gcc (namely, clang up to 13 and icc up to 2021.3.0,
inclusively) identify themselves as gcc < 11 and also benefit from this
optimization, as they otherwise generate mfence for
std::atomic_thread_fence(std::memory_order_seq_cst).

Signed-off-by: Andrey Semashev <[email protected]>

* Removed explicit mfence in atomic_fence on Windows.

The necessary instructions according to the memory order argument
should already be generated by std::atomic_thread_fence.

Signed-off-by: Andrey Semashev <[email protected]>

* Removed memory order argument from atomic_fence.

The code uses memory_order_seq_cst in all call sites of atomic_fence,
so remove the argument and simplifiy the implementation a bit. Also, renamed
the function to make the memory order it implements apparent.

Signed-off-by: Andrey Semashev <[email protected]>

show more ...

Changes in code after applying some clang-tidy check fixes (#620)

Applied fixes from clang-tidy(readability and modernize)

Signed-off-by: Ilya Isaev [email protected]

Commit oneTBB source code 82ff8707

Commit oneTBB source code 4fcd448a

Commit oneTBB source code 9ed4a21c

Commit oneTBB source code 8fda6294

Commit oneTBB source code 6420d97a

Commit oneTBB source code 4ebd2d06