Remove unneeded cl::ZeroOrMore for cl::opt/cl::list options

[Polly] Mark classes as final by default. NFC.

This make is obivious that a class was not intended to be derived from.

NPM analysis pass can unfortunately not marked as final because they are
deriv

[Polly] Mark classes as final by default. NFC.

This make is obivious that a class was not intended to be derived from.

NPM analysis pass can unfortunately not marked as final because they are
derived from a llvm::Checker<T> template internally by the NPM.

Also normalize the use of classes/structs
* NPM passes are structs
* Legacy passes are classes
* structs that have methods and are not a visitor pattern are classes
* structs have public inheritance by default, remove "public" keyword
* Use typedef'ed type instead of inline forward declaration

show more ...

[Polly] Port DeadCodeElim to the NewPM.

Apply include-what-you-use #include removal suggestions. NFC.

This removes unused includes (and forward declarations) as
suggested by include-what-you-use. If a transitive include of a removed
inclu

Apply include-what-you-use #include removal suggestions. NFC.

This removes unused includes (and forward declarations) as
suggested by include-what-you-use. If a transitive include of a removed
include is required to compile a file, I added the required header (or
forward declaration if suggested by include-what-you-use).

This should reduce compilation time and reduce the number of iterative
recompilations when a header was changed.

llvm-svn: 357209

show more ...

Update the file headers across all of the LLVM projects in the monorepo
to reflect the new license.

We understand that people may be surprised that we're moving the header
entirely to discuss the ne

Update the file headers across all of the LLVM projects in the monorepo
to reflect the new license.

We understand that people may be surprised that we're moving the header
entirely to discuss the new license. We checked this carefully with the
Foundation's lawyer and we believe this is the correct approach.

Essentially, all code in the project is now made available by the LLVM
project under our new license, so you will see that the license headers
include that license only. Some of our contributors have contributed
code under our old license, and accordingly, we have retained a copy of
our old license notice in the top-level files in each project and
repository.

llvm-svn: 351636

show more ...

getDependences to new C++ interface

Reviewers: Meinersbur, grosser, bollu, cs15btech11044, jdoerfert

Reviewed By: grosser

Subscribers: pollydev, llvm-commits

Tags: #polly

Differential Revision:

getDependences to new C++ interface

Reviewers: Meinersbur, grosser, bollu, cs15btech11044, jdoerfert

Reviewed By: grosser

Subscribers: pollydev, llvm-commits

Tags: #polly

Differential Revision: https://reviews.llvm.org/D47786

llvm-svn: 334092

show more ...

Move include/isl-noexceptions.h to include/isl/isl-noexceptions.h

llvm-svn: 311504

[Polly] Move Scop::restrictDomains to islpp. NFC.

Reviewers: grosser, Meinersbur, bollu

Differential Revision: https://reviews.llvm.org/D36659

llvm-svn: 310814

[ScopInfo] Move Scop::getPwAffOnly to isl++ [NFC]

llvm-svn: 310231

[ScopInfo] Move Scop::getDomains to isl++ [NFC]

llvm-svn: 310230

[ScopInfo] Move get*Writes/getReads/getAccesses to isl++

llvm-svn: 310219

[DeadCodeElimination] Translate to C++ bindings

This pass is a small and self-contained example of a piece of code that was
written with the isl C interface. The diff of this change nicely shows how

[DeadCodeElimination] Translate to C++ bindings

This pass is a small and self-contained example of a piece of code that was
written with the isl C interface. The diff of this change nicely shows how the
C++ bindings can improve the readability of the code by avoiding the long C
function names and by avoiding any need for memory management.

As you will see, no calls to isl_*_copy or isl_*_free are needed anymore.
Instead the C++ interface takes care of automatically managing the objects.
This may introduce internally additional copies, but due to the isl reference
counting, such copies are expected to be cheap. For performance critical
operations, we will later exploit move semantics to eliminate unnecessary
copies that have shown to be costly.

Below we give a set of examples that shows the benefit of the C++ interface vs.
the pure C interface.

Check properties
----------------

Before:

if (isl_aff_is_zero(aff) || isl_aff_is_one(aff))
return true;

After:

if (Aff.is_zero() || Aff.is_one())
return true;

Type conversion
---------------

Before:

isl_union_pw_multi_aff *UPMA = isl_union_pw_multi_aff_from_union_map(umap);

After:

isl::union_pw_multi_aff UPMA = UMap;

Type construction
-----------------

Before:

auto *Empty = isl_union_map_empty(space);

After:

auto Empty = isl::union_map::empty(Space);

Operations
----------

Before:

set = isl_union_set_intersect(set, set2);

After:

Set = Set.intersect(Set2);

The use of isl::boolean in return types also adds an increases the robustness
of Polly, as on conversion to true or false, we verify that no isl_bool_error
has been returned and assert in case an error was returned. Before this change
we would have just ignored the error and proceeded with (some) exection path.

Tags: #polly

Reviewed By: Meinersbur

Differential Revision: https://reviews.llvm.org/D30619

llvm-svn: 297466

show more ...

[DeadCodeElim] Put -polly-dce-precise-steps into the Polly category.

llvm-svn: 297318

Perform copying to created arrays according to the packing transformation

This is the fourth patch to apply the BLIS matmul optimization pattern on matmul
kernels (http://www.cs.utexas.edu/users/fla

Perform copying to created arrays according to the packing transformation

This is the fourth patch to apply the BLIS matmul optimization pattern on matmul
kernels (http://www.cs.utexas.edu/users/flame/pubs/TOMS-BLIS-Analytical.pdf).
BLIS implements gemm as three nested loops around a macro-kernel, plus two
packing routines. The macro-kernel is implemented in terms of two additional
loops around a micro-kernel. The micro-kernel is a loop around a rank-1
(i.e., outer product) update. In this change we perform copying to created
arrays, which is the last step to implement the packing transformation.

Reviewed-by: Tobias Grosser <[email protected]>

Differential Revision: https://reviews.llvm.org/D23260

llvm-svn: 281441

show more ...

Drop '@brief' from doxygen comments

LLVM's coding guideline suggests to not use @brief for one-sentence doxygen
comments to improve readability. Switch this once and for all to ensure people
do not

Drop '@brief' from doxygen comments

LLVM's coding guideline suggests to not use @brief for one-sentence doxygen
comments to improve readability. Switch this once and for all to ensure people
do not copy @brief comments from other parts of Polly, when writing new code.

llvm-svn: 280468

show more ...

clang-tidy: Add llvm namespace comments

llvm commonly adds a comment to the closing brace of a namespace to indicate
which namespace is closed. clang-tidy provides with llvm-namespace-comment
a hand

clang-tidy: Add llvm namespace comments

llvm commonly adds a comment to the closing brace of a namespace to indicate
which namespace is closed. clang-tidy provides with llvm-namespace-comment
a handy tool to check for this habit. We use it to ensure we consitently use
namespace comments in Polly.

There are slightly different styles in how namespaces are closed in LLVM. As
there is no large difference between the different comment styles we go for the
style clang-tidy suggests by default.

To reproduce this fix run:

for i in `ls tools/polly/lib/*/*.cpp`; \
clang-tidy -checks='-*,llvm-namespace-comment' -p build $i -fix \
-header-filter=".*"; \
done

This cleanup was suggested by Eugene Zelenko <[email protected]> in
http://reviews.llvm.org/D21488 and was split out to increase readability.

llvm-svn: 273621

show more ...

Decouple SCoP building logic from pass

Created a new pass ScopInfoRegionPass. As name suggests, it is a
region pass and it is there to preserve compatibility with our
existing Polly passes. S

Decouple SCoP building logic from pass

Created a new pass ScopInfoRegionPass. As name suggests, it is a
region pass and it is there to preserve compatibility with our
existing Polly passes. ScopInfoRegionPass will return a SCoP object
for a valid region while the creation of the SCoP stays in the
ScopInfo class.

Contributed-by: Utpal Bora <[email protected]>
Reviewed-by: Tobias Grosser <[email protected]>,
Johannes Doerfert <[email protected]>

Differential Revision: http://reviews.llvm.org/D20770

llvm-svn: 271259

show more ...

Add __isl_give annotations to return types [NFC]

llvm-svn: 265882

Allow the client of DependenceInfo to obtain dependences at different granularities.

llvm-svn: 262591

[NFC] Consistenly use commented and annotated ScopPass functions

The changes affect methods that are part of the Pass interface and
include:
- Comments that describe the methods purpose.

[NFC] Consistenly use commented and annotated ScopPass functions

The changes affect methods that are part of the Pass interface and
include:
- Comments that describe the methods purpose.
- A consistent use of the keywords override and virtual.
Additionally, the printScop method is now optional and removed from
SCoP passes that do not implement it.

llvm-svn: 248685

show more ...

Add explicit #includes for used isl features

llvm-svn: 236931

Sort include directives

Upcoming revisions of isl require us to include header files explicitly, which
have previously been already transitively included. Before we add them, we sort
the existing in

Sort include directives

Upcoming revisions of isl require us to include header files explicitly, which
have previously been already transitively included. Before we add them, we sort
the existing includes.

Thanks to Chandler for sort_includes.py. A simple, but very convenient script.

llvm-svn: 236930

show more ...

Create a dependence struct to hold dependence information for a SCoP.

The new Dependences struct in the DependenceInfo holds all information
that was formerly part of the DependenceInfo. It also

Create a dependence struct to hold dependence information for a SCoP.

The new Dependences struct in the DependenceInfo holds all information
that was formerly part of the DependenceInfo. It also provides the
same interface for the user to access this information.

This is another step to a more general ScopPass interface that does
allow multiple SCoPs to be "in flight".

llvm-svn: 231327

show more ...

Rename the Dependences pass to DependenceInfo [NFC]

We rename the Dependences pass to DependenceInfo as a first step to a
caching pass policy. The new DependenceInfo pass will later provide
"D

Rename the Dependences pass to DependenceInfo [NFC]

We rename the Dependences pass to DependenceInfo as a first step to a
caching pass policy. The new DependenceInfo pass will later provide
"Dependences" for a SCoP.

To keep consistency the test folder is renamed too.

llvm-svn: 231308

show more ...

[Refactor] Use virtual and override appropriately

+ Add override for overwritten methods.
+ Remove virtual for methods we do not want to be overwritten.

llvm-svn: 230898