[mlir:PDL] Fix a syntax ambiguity in pdl.attributepdl.attribute currently has a syntax ambiguity that leads to the incorrect parsingof pdl.attribute operations with locations that don't also have
[mlir:PDL] Fix a syntax ambiguity in pdl.attributepdl.attribute currently has a syntax ambiguity that leads to the incorrect parsingof pdl.attribute operations with locations that don't also have a constant value. For example:```pdl.attribute loc("foo")```The above IR is treated as being a pdl.attribute with a constant value containing the location,`loc("foo")`, which is incorrect. This commit changes the syntax to use `= <constant-value>` toclearly distinguish when the constant value is present, as opposed to just trying to parse an attribute.Differential Revision: https://reviews.llvm.org/D124582
show more ...
[mlir][NFC] Update textual references of `func` to `func.func` in Integration testsThe special case parsing of `func` operations is being removed.
[MLIR][PDL] Integration test of multi-root matching and related fixes.This diff adds an integration test to multi-root PDL matching. It consists of two subtests:1) A 1-layer perceptron with split
[MLIR][PDL] Integration test of multi-root matching and related fixes.This diff adds an integration test to multi-root PDL matching. It consists of two subtests:1) A 1-layer perceptron with split forward / backward operations.2) A 2-layer perceptron with fused forward / backward operations.These tests use a collection of hand-written patterns and TensorFlow operations to be matched. The first test has a DAG / SSA dominant resulting match; the second does not and is therefore stored in a graph region.This diff also includes two bug fixes:1) Mark the pdl_interp dialect as a dependent in the TestPDLByteCodePass. This is needed, because we create ops from that dialect as a part of the PDL-to-PDLInterp lowering.2) Fix of the starting index in the liveness range for the ForEach operations (bug exposed by the integration test).Reviewed By: MogballDifferential Revision: https://reviews.llvm.org/D116082