[lldb][import-std-module] Prefer the non-module diagnostics when in fallback modeThe `fallback` setting for import-std-module is supposed to allow runningexpression that require an imported C++ mo
[lldb][import-std-module] Prefer the non-module diagnostics when in fallback modeThe `fallback` setting for import-std-module is supposed to allow runningexpression that require an imported C++ module without causing any regressionsfor users (neither in terms of functionality nor performance). This is done byfirst trying to normally parse/evaluate an expression and when an error occurredduring this first attempt, we retry with the loaded 'std' module.When we run into a system with a 'std' module that for some reason doesn't buildor otherwise causes parse errors, then this currently means that the secondparse attempt will overwrite the error diagnostics of the first parse attempt.Given that the module build errors are outside of the scope of what the user caninfluence, it makes more sense to show the errors from the first parse attemptthat are only concerned with the actual user input.Reviewed By: aprantlDifferential Revision: https://reviews.llvm.org/D110696
show more ...